[07:52:21] 3MobileFrontend / 3General/Unknown: the background icon of the talk box on Special:UserProfile is misaligned in RTL wikis - 10https://bugzilla.wikimedia.org/64857 (10Amir E. Aharoni) a:3Amir E. Aharoni [07:53:16] (03PS1) 10Amire80: Fix the position of the talk link on Special:UserProfile [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/131436 (https://bugzilla.wikimedia.org/64857) [08:15:11] (03PS1) 10Amire80: Set bytes-added/removed to explicit LTR [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/131437 [08:38:37] 3MobileFrontend / 3General/Unknown: mobile contributions change numbers sometimes don't make sense - 10https://bugzilla.wikimedia.org/64867 (10Amir E. Aharoni) 3NEW p:3Unprio s:3normal a:3None A user in the Hebrew Wikipedia complained that the number of changed bytes that is shown in Special:Contribs... [08:40:36] 3MobileFrontend / 3General/Unknown: mobile contributions change numbers sometimes don't make sense - 10https://bugzilla.wikimedia.org/64867#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/SHhdpxwd [12:55:05] 3Wikipedia App / 3Generic: The app crashes when being brought to foreground after being left in background for some time - 10https://bugzilla.wikimedia.org/64827#c1 (10Sage Ross) p:5Unprio>3High s:5normal>3major I've had this happen about 10 times over the weekend. Sometimes it crashes immediately up... [13:02:52] 3Wikipedia App / 3Generic: open TOC is overwritten if page isn't finished loading - 10https://bugzilla.wikimedia.org/64889 (10Sage Ross) 3NEW p:3Unprio s:3normal a:3None Created attachment 15293 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15293&action=edit Open ToC with article content ins... [13:07:07] 3Wikipedia App / 3Generic: In TOC, tapping article title should return you to the top of the article - 10https://bugzilla.wikimedia.org/64890 (10Sage Ross) 3NEW p:3Unprio s:3normal a:3None When using the TOC, I often want to navigate back to lead section of the article. This is especially important f... [13:20:50] 3MobileFrontend / 3Feature requests: MobileFrontend extension does not support LdapAuthentication - 10https://bugzilla.wikimedia.org/63328#c6 (10Alexandre Ellert) I'm affected too. +1 for increase priority :) Thanks. [13:28:52] 3Wikipedia App / 3Generic: Font of "password" field is changing - 10https://bugzilla.wikimedia.org/64892#c1 (10Liangent) Created attachment 15294 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15294&action=edit Initial state [13:30:05] 3Wikipedia App / 3Generic: Font of "password" field is changing - 10https://bugzilla.wikimedia.org/64892#c2 (10Liangent) Created attachment 15295 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15295&action=edit After "Display password" is checked [13:30:50] 3Wikipedia App / 3Generic: Font of "password" field is changing - 10https://bugzilla.wikimedia.org/64892#c3 (10Liangent) Created attachment 15296 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15296&action=edit After "Display password" is checked then unchecked [13:31:35] 3Wikipedia App / 3Generic: Font of "password" field is changing, and is different from the one used in "Repeat password" - 10https://bugzilla.wikimedia.org/64892 (10Liangent) [14:07:08] (03PS2) 10Dbrant: Fixed action bar icon titles in Bookmarks and Create Account [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/131218 [14:24:13] good morning dbrant! [14:24:30] hey ragesoss! [14:26:53] hey dbrant [14:26:56] * YuviPanda has a heavy fever [14:26:57] dbrant: I noticed that you're not on the default CC list for the android app in Bugzilla. If that's intentional, carry on. Otherwise, you can ask Andre to add you. [14:26:58] hey ragesoss [14:27:11] yeah, we should. we should also add mhurd to the iOS ones [14:27:26] ragesoss: oh, I should surely add myself [14:27:41] dbrant: the bug ragesoss reported seems related to the .show() code, perhaps trying to show it before the view has been constructed or somesuch? [14:28:08] YuviPanda: I assume you mean: https://bugzilla.wikimedia.org/show_bug.cgi?id=64889 [14:28:11] YuviPanda: hmm, haven't looked at it yet [14:29:24] YuviPanda: any news re your passport/visa? [14:29:29] dbrant: oh yeah, I got mine! :D [14:29:39] YuviPanda: very good! [14:29:46] dbrant: yeah, was fairly stressful thoug [14:29:46] h [14:29:52] and being out in 37C weather for long :( [14:30:09] YuviPanda: lol well, it worked out [14:30:16] dbrant: yeah, am quite happy :D [14:31:02] ragesoss: can people be added as default cc for just a 'version'? [14:31:21] not sure. [14:31:42] (03PS3) 10Yuvipanda: Fixed action bar icon titles in Bookmarks and Create Account [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/131218 (owner: 10Dbrant) [14:31:43] (03CR) 10Yuvipanda: [C: 032] Fixed action bar icon titles in Bookmarks and Create Account [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/131218 (owner: 10Dbrant) [14:32:02] (03Merged) 10jenkins-bot: Fixed action bar icon titles in Bookmarks and Create Account [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/131218 (owner: 10Dbrant) [14:32:42] YuviPanda: I'll file a bug to have them added. dbrant should only be for the alpha? and same with mhurd? [14:33:32] ragesoss: no, dbrant for all android, but mhurd for all iOS [14:33:36] ragesoss: android and iOS are 'versions' [14:33:40] perhaps we should change them to components [14:33:49] ah. [14:34:01] yeah, components would definitely make more sense. [14:34:20] ragesoss: yeah [14:35:13] so, I won't file a bug for now. [14:36:44] ragesoss: there's already a bug for changing compnents, I think [14:37:26] ragesoss: https://bugzilla.wikimedia.org/show_bug.cgi?id=64621 [14:39:54] ragesoss: I commented [14:39:56] aha [14:42:27] YuviPanda: who else is working on the apps (in response to Andre's question for who should be part of that discussion)? Just brion? And probably Dan is relevant as well. [14:44:23] ragesoss: Deskana and brion and Monte and dbrant I think [14:44:36] k. that's who I added. [14:46:24] ragesoss: thanks :) [15:17:56] (03PS1) 10Amire80: i18n: Remove closing bracket on language list [extensions/MobileFrontend] (wmf/1.24wmf3) - 10https://gerrit.wikimedia.org/r/131480 [15:21:02] dbrant|lunch: the fever got worse so I'm gonna go off :( [15:31:58] (03PS1) 10Amire80: i18n: Remove closing bracket on language list [extensions/MobileFrontend] (wmf/1.24wmf2) - 10https://gerrit.wikimedia.org/r/131482 [15:45:44] (03CR) 10Anomie: [C: 032] "Simple backport." [extensions/MobileFrontend] (wmf/1.24wmf2) - 10https://gerrit.wikimedia.org/r/131482 (owner: 10Amire80) [15:45:53] (03CR) 10Anomie: [C: 032] "Simple backport." [extensions/MobileFrontend] (wmf/1.24wmf3) - 10https://gerrit.wikimedia.org/r/131480 (owner: 10Amire80) [15:46:26] (03Merged) 10jenkins-bot: i18n: Remove closing bracket on language list [extensions/MobileFrontend] (wmf/1.24wmf2) - 10https://gerrit.wikimedia.org/r/131482 (owner: 10Amire80) [15:46:51] (03Merged) 10jenkins-bot: i18n: Remove closing bracket on language list [extensions/MobileFrontend] (wmf/1.24wmf3) - 10https://gerrit.wikimedia.org/r/131480 (owner: 10Amire80) [16:24:35] 3MobileFrontend / 3stable: Option labels on the mobile preferences page can be too long - 10https://bugzilla.wikimedia.org/61114#c6 (10Andre Klapper) Mobile team: Could you please answer comment 3 / comment 4? [16:46:30] (03CR) 10Jdlrobson: [C: 032] Fix the position of the talk link on Special:UserProfile [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/131436 (https://bugzilla.wikimedia.org/64857) (owner: 10Amire80) [16:47:28] (03Merged) 10jenkins-bot: Fix the position of the talk link on Special:UserProfile [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/131436 (https://bugzilla.wikimedia.org/64857) (owner: 10Amire80) [16:47:51] 3MobileFrontend / 3General/Unknown: the background icon of the talk box on Special:UserProfile is misaligned in RTL wikis - 10https://bugzilla.wikimedia.org/64857 (10Jon) 5PAT>3RES/FIX [16:51:35] 3MobileFrontend / 3stable: Option labels on the mobile preferences page can be too long - 10https://bugzilla.wikimedia.org/61114#c7 (10Jon) Adding Maryana, she should be able to reply. Side note: It would be good to move this component into MediaWiki UI as part of this work. [16:52:35] 3MobileFrontend / 3Feature requests: Mantle: support handlebars compilation - 10https://bugzilla.wikimedia.org/64735#c2 (10Jon) Andre could we get a bugzilla product/component setup - Mediawiki Extensions / Mantle to move this to? [16:59:32] (03CR) 10Kaldari: "SG: Storer looks great, but it's overkill for mobile. We want something as light as possible." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/131239 (owner: 10Kaldari) [17:21:02] jdlrobson: around? I have a question about something in the Mobile tests I'd like to use elsewhere [17:21:26] chrismcmahon: sure. Just fixing the existing browser tests which are failing [17:22:10] (03PS1) 10Jdlrobson: QA: Fix the failing watchstar tests [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/131503 [17:22:12] ^ fixed here [17:22:19] chrismcmahon: so what's the question? [17:25:04] jdlrobson: MF tests in a few places does "class SpecialHistoryPage < ArticlePage" in order to get access to the bits defined in ArticlePage. I'm trying to do that in VE i.e. "class ArticlePage < VisualEditorPage" and getting "uninitialized constant VisualEditorPage (NameError)". I can't figure out why that works for MF but not for VE. [17:25:51] hey chrismcmahon i saw this a while back actually.. [17:26:03] Does ArticlePage extend anything else? [17:26:26] So in special_history_page I have class SpecialHistoryPage and class SpecialContributionsPage [17:26:37] i'm not sure why but if I put class SpecialContributionsPage into its own file I get the same error [17:26:45] i assume it's some kind of import error? [17:26:57] do you need to include ArticlePage inside the VisualEditorPage file? [17:27:32] maybe. I'm looking at your special_history_page now [17:28:21] (03PS3) 10Kaldari: Adding a jQuery plug-in for client-side storage [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/131239 [17:28:36] 3MobileFrontend / 3Feature requests: Mantle: support handlebars compilation - 10https://bugzilla.wikimedia.org/64735#c3 (10Andre Klapper) (In reply to Jon from comment #2) > Andre could we get a bugzilla product/component setup - Mediawiki Extensions > / Mantle to move this to? Please create a ticket for it... [17:31:17] jdlrobson: better example from MF would be watchlist_page. seems like that should be straightforward but that's the situation giving me the uninitialized constant error [17:31:47] yeh i've seen this before - i actually think it's to do with filename order [17:32:09] try renaming VisualEditor file to 1_visual_editor and see if you still get same error [17:33:07] haha. thanks jdlrobson, you may be right [17:34:23] sure enough [17:34:32] strange [17:34:36] brion: Will you still be in the office at 4pm? I've got a really busy day so that's the earliest I could sit down with you. [17:35:03] brion: Or you could send me instructions for me to do on my own, if it's easy enough. :) [17:35:05] 3MobileFrontend / 3Feature requests: Mantle: support handlebars compilation - 10https://bugzilla.wikimedia.org/64735#c4 (10Jon) Thanks opened bug 64906 [17:36:41] brion_: Will you still be in the office at 4pm? I've got a really busy day so that's the earliest I could sit down with you. [17:36:46] brion_: Or you could send me instructions for me to do on my own, if it's easy enough. :) [17:37:09] Deskana: sure i can be :) [17:37:22] lemme put it on my calendar so i don’t forget [17:37:24] brion: Great. Thanks! [17:37:39] :D [17:37:59] brion: I just sent a calendar invite. Didn't bother booking us a room. [17:38:02] (03PS3) 10Jdlrobson: API: respect onlyrequested sections on main page in mobileview [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/131113 (https://bugzilla.wikimedia.org/64663) (owner: 10MaxSem) [17:38:08] (03CR) 10Jdlrobson: [C: 032] API: respect onlyrequested sections on main page in mobileview [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/131113 (https://bugzilla.wikimedia.org/64663) (owner: 10MaxSem) [17:38:14] whee [17:38:56] (03Merged) 10jenkins-bot: API: respect onlyrequested sections on main page in mobileview [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/131113 (https://bugzilla.wikimedia.org/64663) (owner: 10MaxSem) [17:39:55] (03CR) 10Jdlrobson: [C: 031] "Not 100% happy here but since it is needed functionality and I'm only disagreeing on ideological reasons I'm happy to agree with this comp" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/109939 (owner: 10MaxSem) [17:44:06] (03CR) 10Jdlrobson: [C: 04-1] Fix overlay panel padding on tablets (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/131244 (https://bugzilla.wikimedia.org/64682) (owner: 10Kaldari) [17:46:13] (03PS2) 10Jdlrobson: i18n: Set bytes-added/removed to explicit LTR [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/131437 (owner: 10Amire80) [17:46:18] (03CR) 10Jdlrobson: [C: 032] i18n: Set bytes-added/removed to explicit LTR [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/131437 (owner: 10Amire80) [17:46:38] (03PS1) 10Dbrant: Hide the soft-keyboard _before_ the nav drawer is opened. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/131504 [17:46:54] (03PS1) 10Mhurd: Fix for article redirects and editing transcluded sections. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/131505 [17:47:08] (03Merged) 10jenkins-bot: i18n: Set bytes-added/removed to explicit LTR [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/131437 (owner: 10Amire80) [17:48:06] (03PS3) 10Jdlrobson: Rewrite Nearby as a PageList [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/130270 [17:48:14] (03PS3) 10Jdlrobson: Hygiene: Kill the confusingly named KeepGoingDrawer [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129730 [17:48:19] kaldari: https://gerrit.wikimedia.org/r/#/c/129730/ [17:49:35] 3MobileFrontend / 3General/Unknown: action=mobileview does not respect section= when returning Main Pages - 10https://bugzilla.wikimedia.org/64663 (10Jon) 5PAT>3RES/FIX [17:57:04] YuviPanda: I feel bug fixing rate is getting lower these days ... at least for bugs reported by me :p [17:57:17] and some serious bugs start appearing :( [17:58:31] Maryana: i have you on wiki with 355136052540492. do you still have that one? [17:58:34] from https://office.wikimedia.org/wiki/Engineering/Mobile/Testing_Devices [17:58:48] Maryana: the one that you have is 355136052476879 which is checked out to Monte [17:58:50] mhurd: --^ [17:58:58] liangent: We're trying our best! :) [17:59:17] liangent: Thank you so much for testing so diligently and filing all these bugs. We really appreciate it. [17:59:18] 355136058992861 [18:01:24] Deskana: :) [18:01:33] brion: the redirect patch is here: https://gerrit.wikimedia.org/r/#/c/131505/ (core data! ahh!) [18:01:53] \o/ [18:02:27] Maryana: also design has a permanent loaner 355136058833685 [18:03:45] i'll check w/vibha [18:06:08] (03PS10) 10Jdlrobson: Rewrite Search using a PageList [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/127833 [18:09:29] if I want to have a try on the ios app but I don't have an iphone, what can I do? [18:09:36] something like an emulator? [18:11:55] liangent: if you have a mac you can download xcode and run in simulator; otherwise not much we can do [18:14:18] brion: hmm I don't have a mac [18:14:22] 3Wikipedia App / 3Localization/Translation/Language: unable to edit on rtl wikis - 10https://bugzilla.wikimedia.org/61872#c6 (10Dan Garry) 5NEW>3RES/WOR Unable to replicate this problem in the current build. [18:16:41] (03PS2) 10Kaldari: Fix overlay panel padding on tablets [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/131244 (https://bugzilla.wikimedia.org/64682) [18:22:09] jdlrobson, MaxSem: If you have any thoughts about https://gerrit.wikimedia.org/r/#/c/131239/ (the localstorage plugin) feel free to add them to the discussion. I wrote it based on your suggestions at https://gerrit.wikimedia.org/r/#/c/130978/. Apparently there are two competing plug-ins already being used by WMF: jStorage, which doesn't support cookies, and Storer, used by Flow. [18:23:06] (03PS15) 10Jdlrobson: Hygiene: Standardise on our icon usage [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129085 [18:23:35] (03PS5) 10Jdlrobson: QA: Add browser tests for presence of more link on history page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/127185 [18:23:47] (03CR) 10Jdlrobson: "Hey Cmcmahon - can you review this?" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/127185 (owner: 10Jdlrobson) [18:24:03] (03PS2) 10Jdlrobson: Add frontend caching layer to nearby API calls [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/130383 [18:24:13] (03CR) 10jenkins-bot: [V: 04-1] Add frontend caching layer to nearby API calls [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/130383 (owner: 10Jdlrobson) [18:24:29] (03PS4) 10Jdlrobson: Rewrite Nearby as a PageList [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/130270 [18:24:54] (03CR) 10Jdlrobson: [C: 04-1] "Needs rebasing or something. Review other code first." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/130383 (owner: 10Jdlrobson) [18:25:18] (03PS4) 10Jdlrobson: QA: Remove dependency on Barack Obama article [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/125864 (https://bugzilla.wikimedia.org/56057) [18:25:29] (03CR) 10Jdlrobson: "@Cmcmahon I'd appreciate your review on this." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/125864 (https://bugzilla.wikimedia.org/56057) (owner: 10Jdlrobson) [18:25:35] (03PS2) 10Jdlrobson: Show toast when a page is protected [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/131235 (https://bugzilla.wikimedia.org/64643) [18:25:49] (03PS2) 10Jdlrobson: Hygiene: Refactor main menu code [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/131088 [18:25:53] (03PS3) 10Jdlrobson: Add iOS hover bug fix [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/131089 (https://bugzilla.wikimedia.org/64669) [18:26:07] (03CR) 10JGonera: [C: 04-1] Rewrite Search using a PageList (033 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/127833 (owner: 10Jdlrobson) [18:28:00] (03CR) 10Jdlrobson: [C: 032] Fix overlay panel padding on tablets (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/131244 (https://bugzilla.wikimedia.org/64682) (owner: 10Kaldari) [18:28:43] (03Merged) 10jenkins-bot: Fix overlay panel padding on tablets [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/131244 (https://bugzilla.wikimedia.org/64682) (owner: 10Kaldari) [18:36:34] YuviPanda: how are you feeling ? [18:37:11] tfinc: got a shot plus some paracetemol. feeling weak but much better than before [18:37:15] going through bugs now [18:37:41] hey Deskana, mhurd brion dbrant [18:37:43] YuviPanda: good to hear [18:38:00] YuviPanda: Hey Yuvi! Got your passport sorted? [18:38:02] * brion waves [18:38:19] Deskana: yup! [18:38:28] YuviPanda: Got the visa? [18:38:29] Deskana: I IZ COMING TO THE UK! [18:38:34] oh man i gotta search my apartment for my passport. i looked on my desk and found my wife’s passport instead :D [18:38:35] Yay! [18:38:35] 3MobileFrontend / 3beta: Editing - preview screen does not follow tablet margins - 10https://bugzilla.wikimedia.org/64682 (10Jon) 5PAT>3RES/FIX [18:38:46] YuviPanda: heya! [18:38:47] (03PS2) 10Jdlrobson: WIP: Add template dependency to Mantle extension [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129335 [18:38:58] Deskana: :D [18:39:07] Deskana: I responded on the bz discussion [18:39:54] (03CR) 10jenkins-bot: [V: 04-1] WIP: Add template dependency to Mantle extension [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129335 (owner: 10Jdlrobson) [18:40:01] YuviPanda: now all you need is some clothes :) [18:40:06] thedj: haha :D [18:40:22] thedj: I've been 'on the road' for about 2.5 months now, so I'm packing Indian Summer Clothes [18:41:18] i'm guessing that's not really 17 degree C proof [18:41:19] thedj: Deskana only other problem is that I couldn't find CHF, so only have EUR [18:41:26] thedj: no, 17C is winter [18:42:43] mmmm francs [18:42:49] (03PS1) 10Dbrant: more "proper" way of disabling ToC sliding. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/131514 [18:44:59] (03CR) 10Kaldari: [C: 031] "Haven't tested yet." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/131235 (https://bugzilla.wikimedia.org/64643) (owner: 10Jdlrobson) [18:46:35] 3Wikipedia App / 3Search: Search seems slow compared to m.wikipedia.org - 10https://bugzilla.wikimedia.org/60713#c3 (10Dan Garry) 5UNC>3RES/WOR My own testing does not show this to be the case, so marking this as WORKSFORME. [18:48:15] "Search" is kinda misnamed in the Android app, since it only checks for matches in page titles, right? [18:48:51] 3Wikipedia App / 3Search: Search seems slow compared to m.wikipedia.org - 10https://bugzilla.wikimedia.org/60713#c4 (10Yuvi Panda) FWIW, we do request more search results than mobile web, so this is technically true. [18:49:28] ragesoss: It uses the OpenSearch API which is the thing that's used for search suggestions on desktop. [18:49:43] but what if I want to search article text? [18:50:01] ragesoss: The reason is mostly for performance reasons; running a list=search query every time you type a new character into the search box will kill the search cluster. :) [18:50:21] yeah but on desktop you can hit enter and it'll search [18:50:29] exactly ^ [18:53:06] 3MobileFrontend / 3General/Unknown: iPhone URL protocol handler to open Wikipedia App from Safari - 10https://bugzilla.wikimedia.org/52472#c1 (10Dan Garry) This is a feature request for MobileFrontend. Moving accordingly. [18:53:46] Indeed, we've got a long way to go with search. :) [18:53:51] But right now the design issues are more pressing. [18:53:59] mhmm. [18:54:03] agreed. [18:55:36] 3MobileFrontend / 3General/Unknown: iPhone URL protocol handler to open Wikipedia App from Safari - 10https://bugzilla.wikimedia.org/52472#c2 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/4gkgWK9C [18:59:24] jdlrobson, I thought https://gerrit.wikimedia.org/r/#/c/129085/ was supposed not to load icons for non-js menu instead of loading the hires ones? [18:59:32] liangent: the bugs have gotten harder! [18:59:33] :D [18:59:41] liangent: but yeah, the current crash [19:00:14] (03CR) 10JGonera: [C: 04-1] "Non-JS menu has hires icons embedded, probably a waste of bandwidth, possibly may break something on old non-JS phones." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129085 (owner: 10Jdlrobson) [19:01:31] (03CR) 10Yuvipanda: [C: 04-1] Hide the soft-keyboard _before_ the nav drawer is opened. (031 comment) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/131504 (owner: 10Dbrant) [19:02:52] (03CR) 10Yuvipanda: [C: 04-1] more "proper" way of disabling ToC sliding. (032 comments) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/131514 (owner: 10Dbrant) [19:03:16] dbrant: I also had a couple of new patches waiting for review [19:10:36] do we maintain the flexibility so that 3rdparty wikis can reuse the app with simple modification? [19:11:19] (03PS3) 10Dr0ptp4kt: Add MCC-MNC once per app session on cellular. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/131246 [19:11:46] liangent: there's .wikipedia.org hardcoded in a bunch of places [19:11:58] liangent: but mostly it's pretty wikimedia agnostic [19:12:11] liangent: but I don't know how true that'll remain through time [19:12:53] (03CR) 10Dr0ptp4kt: "Removing -2. Ready for review." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/131246 (owner: 10Dr0ptp4kt) [19:13:06] YuviPanda: and wikipedia zero code [19:14:09] just wonder whether it is intentionally made in some way that others can reuse [19:15:11] liangent: nope, not really [19:15:45] hm [19:15:57] I hope that it is :/ [19:17:42] YuviPanda: or write a generic MediaWiki app and make Wikipedia app a fork of it :p [19:18:36] liangent: :D sadly I don't think that's on the cards :( [19:23:16] Add MCC-MNC once per app session on cellular. << has VPN been taken care of? [19:23:28] dr0ptp4kt: ^ [19:31:06] YuviPanda, i believe that falls under a DUN type profile. /me fires up vpn [19:31:28] dr0ptp4kt: you should help liangent setup a zero testing setup too, perhaps [19:33:56] YuviPanda: zero? [19:34:02] dr0ptp4kt: Wikipedia Zero [19:34:46] YuviPanda: I remember in some early version there was a toggle in settings about zero debugging [19:35:34] liangent: yeah, but you won't get any of it until the server determines you are from a 'zero rated carrier' [19:35:57] liangent, if you have a static-ish ip address, email it to me and i can add your ip. just make sure it's assigned to your equipment and not someone else [19:36:28] dr0ptp4kt: a VPN or somesuch would work too I presue [19:36:50] YuviPanda: yeah, as long as the source ip is predictable [19:36:52] YuviPanda: dr0ptp4kt: yeah maybe use a labs instance to do that? [19:37:03] yeah, we need to setup a labs instance that people can tunnel through [19:37:17] definitely not toollabs, but somewhere else [19:37:39] liangent: maybe. you'd want to verify the source's internet routable exit ip isn't shared [19:38:28] dr0ptp4kt: does real source ip matter if vpn is used? [19:38:51] liangent: typically, no - it's more the source ip of the vpn exit [19:40:54] (03PS2) 10Dbrant: Hide the soft-keyboard _before_ the nav drawer is opened. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/131504 [19:42:06] dr0ptp4kt: I wonder whether it's possible to connect to the main cluster using a source ip of 10.x.x.x [19:42:39] YuviPanda: heya! are these the final 4 app EL schemas: Schema:MobileWikiAppCreateAccount, MobileWikiAppReadingAction, MobileWikiAppEdit and MobileWikiAppLogin ? [19:42:39] YuviPanda: testing your patches now... [19:42:50] mhurd: pretty much, but AppReadingAction is still in flux, so don't do anything with that [19:42:58] YuviPanda: ah! ok [19:43:07] dbrant: cool [19:44:07] (03PS11) 10Jdlrobson: Rewrite Search using a PageList [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/127833 [19:44:26] (03PS16) 10Jdlrobson: Hygiene: Standardise on our icon usage [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129085 [19:44:30] (03CR) 10Kaldari: [C: 032] Show toast when a page is protected [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/131235 (https://bugzilla.wikimedia.org/64643) (owner: 10Jdlrobson) [19:45:24] chrismcmalunch / MaxSem / kaldari : can you review and merge https://gerrit.wikimedia.org/r/131503 so that our tests can pass again? [19:46:08] (03CR) 10MaxSem: [C: 032] "Looks plausible (c) Brion :P" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/131503 (owner: 10Jdlrobson) [19:46:10] (03CR) 10jenkins-bot: [V: 04-1] QA: Fix the failing watchstar tests [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/131503 (owner: 10Jdlrobson) [19:49:38] dbrant: https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom;TicketID=7526921 is the crash report + stacktrace. [19:52:49] (03CR) 10Dbrant: [C: 032] Fix .noflip.svg detection to work properly [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/131252 (owner: 10Yuvipanda) [19:55:23] 3Wikipedia App / 3Generic: The search bar doesn't appear after "back" - 10https://bugzilla.wikimedia.org/64913 (10Liangent) 3NEW p:3Unprio s:3normal a:3None 1. Go to some page, keep it unscrolled (reading the beginning) 2. Click a link 3. Scroll down until the search bar is hidden 4. Press back. Now... [19:56:31] YuviPanda: you used limn recently? [19:56:54] getting cryptic errors when trying to run it [19:57:31] jdlrobson: sadly no, haven't for a while [19:58:09] (03CR) 10Dbrant: [C: 032] Add StyleBundle classes + injection methods to CommunicationBridge [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/131229 (owner: 10Yuvipanda) [20:02:40] (03CR) 10Dbrant: [C: 032] Treat empty titles as pointing to the main page [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/131250 (https://bugzilla.wikimedia.org/64384) (owner: 10Yuvipanda) [20:04:55] (03PS1) 10Mhurd: Fix for doubled "self" reference. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/131538 [20:04:59] (03PS3) 10Dbrant: Hide the soft-keyboard _before_ the nav drawer is opened. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/131504 [20:06:33] (03PS1) 10Brion VIBBER: Data migration for old saved pages -> bookmarks [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/131539 [20:06:50] (03PS2) 10Dbrant: more "proper" way of disabling ToC sliding. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/131514 [20:07:50] (03CR) 10Yuvipanda: "Also when testing I found that if you open the drawer slowly but steadily the keyboard doesn't dismiss." (031 comment) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/131504 (owner: 10Dbrant) [20:08:47] YuviPanda: haven't tried yet, but does your https://gerrit.wikimedia.org/r/#/c/131250/1/wikipedia/src/main/java/org/wikipedia/PageTitle.java understand http://en.wikipedia.org/wiki/#foo ? [20:09:11] liangent: gah, no, it wouldn't [20:09:17] but where would you find such a link? [20:09:24] (not that we shouldn't handle it correctly) [20:09:25] still [20:09:44] YuviPanda: well I thought of it by reading your code [20:10:23] (03CR) 10JGonera: [C: 032] Rewrite Search using a PageList [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/127833 (owner: 10Jdlrobson) [20:10:47] liangent: file a bug? might be low prio tho [20:11:12] (03Merged) 10jenkins-bot: Rewrite Search using a PageList [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/127833 (owner: 10Jdlrobson) [20:11:28] (03PS1) 10Mhurd: Removed un-used files. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/131543 [20:12:28] (03PS1) 10Yuvipanda: Add missing curly braces [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/131546 [20:12:30] YuviPanda: since that commit was merged just now it can't be in the previous release. however when I tried http://en.wikipedia.org/wiki/ just now it doesn't crash anymore. instead it keeps loading forever [20:12:49] liangent: yeah, that was the previous release 'fix', which I don't know how :D [20:13:52] jdlrobson, kaldari https://gerrit.wikimedia.org/r/#/c/131205/ is merged so you can work on the dropdown story if you have time [20:16:08] 3Wikipedia App / 3Generic: http://en.wikipedia.org/wiki/#foo doesn't work in the app - 10https://bugzilla.wikimedia.org/64914 (10Liangent) 3NEW p:3Unprio s:3normal a:3None The fix for bug 64384 rewrites empty title to main page, but doesn't rewrite titles with fragment only. [20:17:27] YuviPanda: ^ maybe you can just copy the logic of Title::splitAndSecure() in php [20:17:47] *secureAndSplit() [20:17:51] (03CR) 10JGonera: [C: 04-1] Add iOS hover bug fix (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/131089 (https://bugzilla.wikimedia.org/64669) (owner: 10Jdlrobson) [20:18:14] and newFromText [20:22:14] jdlrobson: rebase? https://gerrit.wikimedia.org/r/#/c/131503/ [20:24:31] (03PS2) 10Jdlrobson: QA: Fix the failing watchstar tests [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/131503 [20:24:39] brion: there are a couple more super small ios patches [20:24:46] (03CR) 10Jdlrobson: [C: 032] QA: Fix the failing watchstar tests [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/131503 (owner: 10Jdlrobson) [20:24:47] ok [20:25:08] (03CR) 10Brion VIBBER: [C: 032 V: 032] Removed un-used files. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/131543 (owner: 10Mhurd) [20:25:43] (03CR) 10Brion VIBBER: [C: 032 V: 032] Fix for doubled "self" reference. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/131538 (owner: 10Mhurd) [20:26:00] (03PS2) 10Brion VIBBER: Fix for article redirects and editing transcluded sections. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/131505 (owner: 10Mhurd) [20:26:15] (03Merged) 10jenkins-bot: QA: Fix the failing watchstar tests [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/131503 (owner: 10Jdlrobson) [20:33:45] (03CR) 10Jdlrobson: Add iOS hover bug fix (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/131089 (https://bugzilla.wikimedia.org/64669) (owner: 10Jdlrobson) [20:33:48] (03CR) 10JGonera: [C: 032] Hygiene: Refactor main menu code [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/131088 (owner: 10Jdlrobson) [20:34:30] (03CR) 10Jdlrobson: Deal better with expired edit tokens [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/130522 (https://bugzilla.wikimedia.org/64416) (owner: 10Jdlrobson) [20:35:25] (03Merged) 10jenkins-bot: Hygiene: Refactor main menu code [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/131088 (owner: 10Jdlrobson) [20:35:56] (03PS3) 10Dbrant: more "proper" way of disabling ToC sliding. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/131514 [20:36:31] (03CR) 10Brion VIBBER: [C: 032 V: 032] "no explode yet \o/" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/131505 (owner: 10Mhurd) [20:37:13] jgonera: i'm not sure how to avoid shipping the icons in embed form to phones without js.. [20:38:01] plus background-image: none; ensures they will never be attempted to be loaded [20:38:05] jdlrobson, if not load given css file on that page? but if it's too tricky, I'm fine with the way it is [20:38:12] ensures? [20:38:16] they load for me [20:38:22] with JavaScript disabled? [20:38:29] and... they are loaded anyway because they're in css ;) [20:38:31] on Special:MobileMenu ? [20:38:37] i mean the CSS is there yes [20:38:45] but the rule is never activated [20:38:57] jdlrobson: That test step that creates 50 edits can take forever to run. Would it be possible to output something to console while it's doing that? [20:39:01] (03CR) 10Brion VIBBER: [C: 032 V: 032] "Looks sane enough!" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/130674 (owner: 10Dr0ptp4kt) [20:39:03] yep, without JS, on the special page [20:39:23] jdlrobson: like maybe ANSCI pong [20:39:35] kaldari, jdlrobson there's a test that generate 50 edits?! why? [20:40:07] jgonera: it does it once for the more link on the history page [20:40:29] er ASCII pong I mean :) [20:40:32] if the page has more than 50 edits it will never make 50 edits [20:40:35] jdlrobson, then the proper way would be to make that number configurable and override it for tests to e.g. 2 [20:40:42] ASCII pong sounds fun :) [20:40:50] jgonera: sure but the history page doesn't work that wa y:) [20:41:12] hm... [20:43:41] (03CR) 10Jdlrobson: "I'm not sure how this can be improved for non-JavaScript phones.... Yes the data URIS will be in the CSS file but the rules will never be " [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129085 (owner: 10Jdlrobson) [20:47:18] (03CR) 10Kaldari: [C: 04-1] QA: Add browser tests for presence of more link on history page (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/127185 (owner: 10Jdlrobson) [20:49:36] mhurd: brion YuviPanda : im putting together the monthly report for mobile apps. do we have a central place for our release notes that i can pull together ? [20:49:59] git log is probably a bit verbose [20:50:04] tfinc: from the betas [20:50:17] testflight pages might show all the release notes for each beta yeah [20:50:20] Maryana: have you noticed any missing data since the EventLogging migration? [20:50:23] yeah, i need one place that shows me it [20:50:28] tfinc: brion: ya [20:50:29] brion: link me to the page ? [20:50:54] YuviPanda: what do we have for android [20:50:54] ? [20:50:58] tfinc: try https://www.testflightapp.com/dashboard/applications/892043/builds/ [20:51:05] see if it lets you pull up the build information for each build [20:51:08] if not i’ll cut-n-paste em [20:51:35] that take me to the create a team page [20:51:39] brion: just throw them into an ether pad [20:51:52] ok [20:53:12] (03PS1) 10Dbrant: Don't need this for saved page fragment. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/131601 [20:55:00] tfinc: https://gist.github.com/brion/d31bce3c787568e521fd [20:55:31] StevenW: yeah, it looks like the data from tues the 29th is a little low.. [20:55:31] brion: what do we have for android? [20:55:35] and where is dmitry hiding today? [20:55:47] StevenW: just eyeballing these graphs: http://mobile-reportcard.wmflabs.org/#edits_daily-graphs-tab [20:55:48] Maryana: yeah I am also seeing large holes in historical schema data [20:55:55] :( [20:56:03] uh, search beta announcements on mobile-l maybe? :D [20:56:09] either our changelog from GettingStarted notes is completely wrong, or there are entire schemas missing data [20:57:20] * dbrant is not hiding! [20:57:50] dbrant: there you are :) [20:58:03] dbrant: any release list for android that i can pull from for the monthly report ? [20:58:19] tfinc: when is our next apps sprint kicking off? [20:58:19] the ones in alpha in store may have a notes list… [21:00:12] tfinc: not sure what you mean; I only know about the git log [21:00:47] dbrant: i need a good summary of what we've pushed out on android to update the monthly engineering report [21:00:57] dbrant: scroll up to see what brion sent me for iOS [21:05:58] brion: is there a similar Gist for Android updates? what do we usually use? [21:06:22] dbrant: i think for things we put out on play store as alphas, we can copy-paste out of there [21:07:02] under apk details there’s a ‘what’s new in this version’ [21:07:07] in the google play dev console [21:07:40] YuviPanda: stat1003 now accessible :) [21:09:29] brion: I don't think I have access to that... [21:09:37] 3MobileFrontend / 3General/Unknown: Hash gets swallowed (again) - 10https://bugzilla.wikimedia.org/64918 (10Jon) 3NEW p:3Unprio s:3normal a:3None Go to https://en.m.wikipedia.org/wiki/Roekiah#Early_life on a mobile device. This doesn't take you to the section. It leaves you at the top of the page. I... [21:09:39] ok lemme see if i can copy the recent ones [21:09:42] (03CR) 10Kaldari: [C: 032] Fix the reference close button [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/130786 (https://bugzilla.wikimedia.org/64629) (owner: 10Jdlrobson) [21:10:35] 3MobileFrontend / 3General/Unknown: Hash gets swallowed (again) - 10https://bugzilla.wikimedia.org/64918#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/9q49egRq [21:10:59] (03CR) 10Dbrant: [C: 032] Add missing curly braces [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/131546 (owner: 10Yuvipanda) [21:12:16] tfinc: ok here’s the last couple weeks worth of android alpha notes: https://gist.github.com/brion/249231538bad0110dc99 [21:12:30] thanks brion. that'll be enough [21:12:48] brion: thx :) [21:12:55] \o/ [21:13:39] ok i gotta run some errands (bills bills bills!) before i forget and the bank closes again [21:13:43] tfinc: i’ll be back online in 45 mins [21:13:48] brion: k [21:14:08] brion: still happy with that 512 ssd? [21:14:10] damn trash company wants their money [21:14:16] mhurd: so far so good :D [21:14:24] i’ll try encrypting it for travel next and make sure it doesn’t choke on that [21:23:55] (03PS4) 10Dbrant: Hide the soft-keyboard _before_ the nav drawer is opened. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/131504 [21:25:29] (03CR) 10Kaldari: [C: 04-1] Close toasts on a click event (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/130782 (https://bugzilla.wikimedia.org/64270) (owner: 10Jdlrobson) [21:28:32] mhurd: dbrant YuviPanda : i'm debating about standups during Zurich [21:28:52] i think it would be nice for those sticking around to still feel connected and thus i think we should keep them [21:28:56] what do you guys think ? [21:29:46] Who from the Apps team isn't going? [21:29:52] (03PS4) 10Jdlrobson: Deal better with expired edit tokens [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/130522 (https://bugzilla.wikimedia.org/64416) [21:29:52] 3MobileFrontend / 3General/Unknown: MobileFrontend "last edited by" strapline shouldn't include authorship information - 10https://bugzilla.wikimedia.org/64921 (10MZMcBride) 3NEW p:3Unprio s:3normal a:3None https://en.m.wikipedia.org/wiki/Barack_Obama reads: --- Last edited 3 days ago by Aquillion -... [21:29:52] I am not [21:30:35] Oh, there's an attendee list too. [21:30:35] 3MobileFrontend / 3General/Unknown: MobileFrontend "last edited by" strapline shouldn't include authorship information - 10https://bugzilla.wikimedia.org/64921#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/Cb9KaWn7 [21:30:38] (03CR) 10JGonera: [C: 04-1] "I'm getting unable to locate element, using {:css=>"#ca-protect a"} (Watir::Exception::UnknownObjectException)" (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/125864 (https://bugzilla.wikimedia.org/56057) (owner: 10Jdlrobson) [21:30:46] So Dmitry, Monte and myself. [21:31:01] tfinc: If you can find a space for it, then I'd certainly appreciate it. [21:31:08] Deskana: mhurd and dbrant [21:31:27] I would be fine either way (have them at the same time / different time / async) [21:31:35] 3MobileFrontend / 3General/Unknown: MobileFrontend "last edited" strapline should not include authorship information - 10https://bugzilla.wikimedia.org/64921 (10MZMcBride) [21:32:10] dbrant: not a new time. we either keep them or we don't [21:32:18] moving becomes too much of a distraction [21:35:08] (03CR) 10Kaldari: Close toasts on a click event (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/130782 (https://bugzilla.wikimedia.org/64270) (owner: 10Jdlrobson) [21:36:22] 3MobileFrontend / 3stable: Support non-Ajaxy forms-based editing for lower-JS devices - 10https://bugzilla.wikimedia.org/64923 (10dr0ptp4kt) 3NEW p:3Unprio s:3normal a:3None It would be cool to be able to edit from devices that lack high-end JavaScript support. [21:36:39] Deskana: sry was afk - so standups as usual while folks are out for Zurich? [21:38:33] (03CR) 10Jdlrobson: [C: 032] "I couldn't find an old enough phone that does support photo uploads. However a Blackberry device, a Windows Nokia phone and an Android 2 d" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/131106 (owner: 10Kaldari) [21:39:09] (03Merged) 10jenkins-bot: Promoting copyvio EXIF confirm message to stable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/131106 (owner: 10Kaldari) [21:39:23] 3MobileFrontend / 3General/Unknown: MobileFrontend "Random" feature does not use canonical URL form - 10https://bugzilla.wikimedia.org/64924 (10MZMcBride) 3NEW p:3Unprio s:3normal a:3None If I go to https://en.m.wikipedia.org/wiki/Main_Page and select "Random" from the hamburger drop-down menu in the... [21:39:35] 3MobileFrontend / 3General/Unknown: MobileFrontend "last edited" strapline should not include authorship information - 10https://bugzilla.wikimedia.org/64921#c2 (10Jon) I'm not sure what the problem is here or what your arguments are for not showing it... You can read about the motivation around this here h... [21:40:36] 3MobileFrontend / 3General/Unknown: MobileFrontend "Random" feature does not use canonical URL form - 10https://bugzilla.wikimedia.org/64924#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/bF1BpOdO [21:40:36] 3MobileFrontend / 3stable: Support non-Ajaxy forms-based editing for lower-JS devices - 10https://bugzilla.wikimedia.org/64923#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/yAJWziCm [21:44:06] 3MobileFrontend / 3stable: Support non-Ajaxy forms-based editing for lower-JS devices - 10https://bugzilla.wikimedia.org/64923#c2 (10Max Semenik) ?mobileaction=toggle_view_desktop ? :P [21:48:19] jdlrobson: would you mind if I put you on the gerrit review for my VE browser test refactor? [21:48:31] chrismcmahon: sure [21:49:05] 3MobileFrontend / 3Feature requests: Non-javascript based editing - 10https://bugzilla.wikimedia.org/64923 (10Jon) [21:49:11] thanks jdlrobson. being able to create target pages at run time changes a lot of stuff [21:52:37] 3MobileFrontend / 3stable: Examine discoverability and usability of search on low-JS devices - 10https://bugzilla.wikimedia.org/64926 (10dr0ptp4kt) 3NEW p:3Unprio s:3normal a:3None On en.m.wikipedia.org the "Search" button is pretty clearly labeled, but it's possible that users on lower-JS devices ma... [21:55:35] 3MobileFrontend / 3stable: Examine discoverability and usability of search on low-JS devices - 10https://bugzilla.wikimedia.org/64926#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/ZjBj0pe2 [21:55:36] (03CR) 10JGonera: [C: 04-1] Rewrite Nearby as a PageList (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/130270 (owner: 10Jdlrobson) [21:55:50] 3MobileFrontend / 3General/Unknown: MobileFrontend "last edited" strapline should not include authorship information - 10https://bugzilla.wikimedia.org/64921#c3 (10MZMcBride) (In reply to Jon from comment #2) > I'm not sure what the problem is here or what your arguments are for not > showing it... It's not... [22:01:35] 3MobileFrontend / 3General/Unknown: MobileFrontend "last edited" strapline should not include authorship information - 10https://bugzilla.wikimedia.org/64921#c4 (10Matthew Flaschen) It's a simple (albeit incomplete) window to who's working on the article. It's a step towards making people realize wiki pages... [22:01:50] 3MobileFrontend / 3General/Unknown: MobileFrontend "last edited" strapline should not include authorship information - 10https://bugzilla.wikimedia.org/64921#c5 (10MZMcBride) As mentioned in comment 0, it's also a fairly fundamental principle of Wikipedia articles that they are unsigned. By affixing a userna... [22:10:50] 3MobileFrontend / 3General/Unknown: MobileFrontend "last edited" strapline should not include authorship information - 10https://bugzilla.wikimedia.org/64921#c6 (10Matthew Flaschen) It is not a signature, any more than https://en.wikipedia.org/w/index.php?title=Barack_Obama&diff=cur&oldid=prev is. You haven... [22:14:36] (03CR) 10JGonera: "My main issue with this is that it has no tests whatsoever." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/131239 (owner: 10Kaldari) [22:15:37] (03CR) 10Jdlrobson: "@Kaldari can you merge then? guess we should open a bug for this against beta?" (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/130782 (https://bugzilla.wikimedia.org/64270) (owner: 10Jdlrobson) [22:17:34] (03PS5) 10Jdlrobson: QA: Remove dependency on Barack Obama article [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/125864 (https://bugzilla.wikimedia.org/56057) [22:17:50] jdlrobson, so the keep going thing is gone? [22:18:05] jgonera: in what sense? [22:18:11] jdlrobson, https://gerrit.wikimedia.org/r/#/c/129730/3 [22:18:20] the drawer is no longer used for keep going? [22:18:23] oh wait [22:18:25] yeh we've been using KeepGoingOVerlay [22:18:28] it's an overlay now [22:18:29] right [22:18:31] it's super confusing hence the patch :) [22:18:42] been bugging me like crazy [22:18:43] still, we do we remove the messages? we have different ones for the overlay? [22:18:51] w==why [22:18:53] we [22:20:37] Deskana: how is your time to start thinking about 2014-2015 goals? [22:21:11] tfinc: I imagine I'm going to be very bored here during the hackathon. :) [22:21:15] tfinc: So might be good then. [22:21:35] Deskana: what PDT time do you think you'll be on? [22:22:08] tfinc: What do you mean? What time will I be at work? [22:22:10] All day? :) [22:22:24] Deskana: thought you were going to Zurich [22:22:45] Deskana: but now i see that your not making it really easy later this week to sync up [22:22:46] :) [22:23:02] Nope. [22:23:09] (03PS1) 10Jdlrobson: Tools: Add check for trailing whitespace to pre-commit hook [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/131619 [22:23:34] I wanted to, but wasn't approved in the end. [22:34:05] 3MobileFrontend / 3General/Unknown: MobileFrontend "last edited" strapline should not include authorship information - 10https://bugzilla.wikimedia.org/64921#c7 (10Maryana Pinchuk) 5NEW>3RES/WON I believe both Matt and Jon have sufficiently explained the rationale for this feature (thanks, guys!), so I'm... [22:35:21] tfinc: Yeah. Sorry about that... [22:39:51] 3MobileFrontend / 3Feature requests: Examine discoverability and usability of search on low-JS devices - 10https://bugzilla.wikimedia.org/64926#c2 (10Jon) I'm not convinced. I think changing the search button to a search icon should be enough (see bug 63701). The placeholder reinforces it is a search but I... [22:45:52] (03PS4) 10Jdlrobson: Close toasts on a click event [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/130782 (https://bugzilla.wikimedia.org/64270) [22:54:47] (03CR) 10SG: "Kaldari: Storer is written to be extremely fast, so that can't be the concern. As far as size goes, it's 8.9KB minified, ~3490 bytes gzipp" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/131239 (owner: 10Kaldari) [22:55:00] (03CR) 10Jdlrobson: Rewrite Nearby as a PageList (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/130270 (owner: 10Jdlrobson) [22:57:01] (03PS5) 10Jdlrobson: Rewrite Nearby as a PageList [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/130270 [22:57:09] (03CR) 10jenkins-bot: [V: 04-1] Rewrite Nearby as a PageList [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/130270 (owner: 10Jdlrobson) [22:57:49] (03PS6) 10Jdlrobson: Rewrite Nearby as a PageList [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/130270 [23:00:21] 3MobileFrontend / 3Feature requests: Non-javascript based editing - 10https://bugzilla.wikimedia.org/64923#c3 (10Jon) Note... having server side templating would allow us to reuse the existing interface and reconstruct are views from a backend perspective.. [23:09:45] tfinc: If you want to sync up during Zurich, if you pick a time in the late afternoon CET I don't mind getting up early to chat to you. :) [23:10:05] Your rugged good looks and alluring demeanour would make it my pleasure. [23:10:10] [23:13:50] (03PS6) 10Jdlrobson: QA: Add browser tests for presence of more link on history page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/127185 [23:14:31] chrismcmahon: be sure to email me with the patches in VE you want me to look at - I won't find them in the Gerrit UI :) [23:15:14] jdlrobson: eh, I got a +1 from James and merged it already :-) I think it was a righteous refactor. [23:15:32] chrismcmahon: i still need to make the mobile tests pass again with respect to VE [23:15:38] any idea why it keeps failing on the documentNode step? [23:16:05] jgonera: we merged the css regression stuff? [23:16:07] https://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-firefox/540/testReport/junit/(root)/Lead%20image%20uploads/Opening_upload_preview/ [23:16:16] oh wait [23:16:19] no that's the copyvio ignore [23:17:59] ^ kaldari [23:18:28] uh oh [23:23:29] (03PS1) 10Jdlrobson: QA: Fix lead photo uploads tests [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/131628 [23:25:35] 3MobileFrontend / 3General/Unknown: MobileFrontend "last edited" strapline should not include authorship information - 10https://bugzilla.wikimedia.org/64921#c8 (10MZMcBride) 5RES/WON>3REO (In reply to Maryana Pinchuk from comment #7) > I believe both Matt and Jon have sufficiently explained the rational... [23:27:44] (03CR) 10Kaldari: [C: 032] QA: Fix lead photo uploads tests [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/131628 (owner: 10Jdlrobson) [23:28:31] jdlrobson: editor_ve_steps right now is "on(ArticlePage).editor_ve_element.when_present.should exist" add a polling wait is all I can see "on(ArticlePage).editor_ve_element.when_present(10).should be_visible" or some such [23:29:05] 3MobileFrontend / 3General/Unknown: MobileFrontend "last edited" strapline should not include authorship information - 10https://bugzilla.wikimedia.org/64921#c9 (10MZMcBride) (In reply to Matthew Flaschen from comment #6) > It is not a signature, any more than > https://en.wikipedia.org/w/index.php?title=Bar... [23:29:07] (03Merged) 10jenkins-bot: QA: Fix lead photo uploads tests [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/131628 (owner: 10Jdlrobson) [23:29:37] (03CR) 10Kaldari: [C: 032] QA: Add browser tests for presence of more link on history page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/127185 (owner: 10Jdlrobson) [23:30:04] (03PS1) 10Dbrant: Ensuring that the Search bar is visible when Back is pressed. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/131629 (https://bugzilla.wikimedia.org/64913) [23:30:35] 3MobileFrontend / 3General/Unknown: MobileFrontend "last edited" strapline should not include authorship information - 10https://bugzilla.wikimedia.org/64921#c10 (10MZMcBride) (In reply to Matthew Flaschen from comment #4) > It's a simple (albeit incomplete) window to who's working on the article. This isn'... [23:30:42] jdlrobson: You forgot my other comment: https://gerrit.wikimedia.org/r/#/c/130782/3//COMMIT_MSG [23:31:06] (03PS3) 10MaxSem: Fix the reference close button [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/130786 (https://bugzilla.wikimedia.org/64629) (owner: 10Jdlrobson) [23:31:14] (03CR) 10MaxSem: [C: 032] Fix the reference close button [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/130786 (https://bugzilla.wikimedia.org/64629) (owner: 10Jdlrobson) [23:32:10] (03CR) 10Kaldari: [C: 04-1] "See comment on Patch #3 for commit summary" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/130782 (https://bugzilla.wikimedia.org/64270) (owner: 10Jdlrobson) [23:32:20] 3MobileFrontend / 3General/Unknown: MobileFrontend "last edited" strapline should not include authorship information - 10https://bugzilla.wikimedia.org/64921#c11 (10Jon) 5REO>3UNC MZMcbride if something is not clear to you, please argue more concisely than 'Uh, no.' You're spamming my inbox and your argu... [23:33:38] (03Merged) 10jenkins-bot: QA: Add browser tests for presence of more link on history page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/127185 (owner: 10Jdlrobson) [23:36:34] 3MobileFrontend / 3General/Unknown: MobileFrontend "last edited" strapline should not include authorship information - 10https://bugzilla.wikimedia.org/64921#c12 (10MZMcBride) 5UNC>3NEW (In reply to Jon from comment #11) > MZMcbride if something is not clear to you, please argue more concisely than > 'Uh... [23:37:02] jdlrobson: no point, just walk away :) [23:39:49] Maryana: Please don't inappropriate mark tickets as wontfix. [23:39:55] inappropriately, even. [23:39:57] I need food. :-( [23:40:54] I often find the mobile team frustrating. [23:41:04] As it seems to do whatever it wants without regard for the rest of the ecosystem. [23:49:06] 3MobileFrontend / 3General/Unknown: MobileFrontend "last edited" strapline should not include authorship information - 10https://bugzilla.wikimedia.org/64921#c13 (10Jon) MZMcbride.. you're behaviour will not do anything in resolving this bug. The product owner Maryana has said this is a WONTFIX. Haven't we... [23:58:12] jgonera kaldari: did we change anything in the event emitter / page code recently? Some tests are broken [23:59:10] OWCH [23:59:12] yes we did [23:59:13] not good [23:59:49] 3MobileFrontend / 3General/Unknown: MobileFrontend "last edited" strapline should not include authorship information - 10https://bugzilla.wikimedia.org/64921#c14 (10Ryan Kaldari) 5NEW>3RES/WON As explained at http://blog.wikimedia.org/2014/05/02/the-wikipedia-editors-behind-the-curtain/, the rationale fo...