[00:03:08] (03PS6) 10Kaldari: Experimental: Undo button on diff page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/125747 [00:15:26] (03CR) 10Dr0ptp4kt: [C: 032 V: 032] more "proper" way of disabling ToC sliding. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/131514 (owner: 10Dbrant) [00:25:31] 3MobileFrontend / 3stable: "Desktop" in page footer of Special:Uploads returns Page unavailable - 10https://bugzilla.wikimedia.org/64986#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/DevwR3Oo [00:25:34] (03CR) 10Dr0ptp4kt: [C: 032 V: 032] Properly handle no network access during account creation [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/131640 (https://bugzilla.wikimedia.org/64891) (owner: 10Dbrant) [00:29:54] (03CR) 10Dr0ptp4kt: [C: 032 V: 032] Ensuring that the Search bar is visible when Back is pressed. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/131629 (https://bugzilla.wikimedia.org/64913) (owner: 10Dbrant) [00:36:47] (03CR) 10SG: [C: 04-1] "Two things." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/131897 (owner: 10Kaldari) [00:43:09] (03PS1) 10Mhurd: Use wikiFont for history discovery method icons. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/131916 [00:44:01] 3Wikipedia App / 3History: Wrong "random" dice icon - 10https://bugzilla.wikimedia.org/63953#c1 (10Monte Hurd) 5NEW>3RES/FIX Fixed! [00:58:14] (03PS1) 10Dr0ptp4kt: Bump version for release 2.0-alpha-2014-05-07 [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/131918 [00:58:49] (03CR) 10Dr0ptp4kt: [C: 032 V: 032] Bump version for release 2.0-alpha-2014-05-07 [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/131918 (owner: 10Dr0ptp4kt) [01:45:19] (03PS1) 10Dbrant: Changed ToC to be a sliding drawer from the right edge. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/131920 (https://bugzilla.wikimedia.org/63526) [02:08:48] 3Wikipedia App / 3Generic: Links to article names with Unicode characters do not open properly - 10https://bugzilla.wikimedia.org/64987 (10Dmitry Brant) 3NEW p:3Unprio s:3normal a:3None Clicking a link in a page that points to an article that has Unicode character(s) in the title doesn't actually tak... [02:32:50] (03PS1) 10Dbrant: Properly handle links to article titles with Unicode characters. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/131924 (https://bugzilla.wikimedia.org/64987) [02:35:04] (03PS1) 10Dbrant: Handle "invalidtitle" api response. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/131926 [03:35:58] (03CR) 10Yuvipanda: [C: 032] "Quite nice :)" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/131920 (https://bugzilla.wikimedia.org/63526) (owner: 10Dbrant) [03:36:23] (03Merged) 10jenkins-bot: Changed ToC to be a sliding drawer from the right edge. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/131920 (https://bugzilla.wikimedia.org/63526) (owner: 10Dbrant) [03:39:32] (03CR) 10Yuvipanda: [C: 032] Properly handle links to article titles with Unicode characters. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/131924 (https://bugzilla.wikimedia.org/64987) (owner: 10Dbrant) [03:39:48] (03Merged) 10jenkins-bot: Properly handle links to article titles with Unicode characters. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/131924 (https://bugzilla.wikimedia.org/64987) (owner: 10Dbrant) [03:43:56] (03CR) 10Yuvipanda: [C: 032] Handle "invalidtitle" api response. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/131926 (owner: 10Dbrant) [03:44:14] (03Merged) 10jenkins-bot: Handle "invalidtitle" api response. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/131926 (owner: 10Dbrant) [03:54:43] (03PS1) 10Yuvipanda: Bump version number to 2.0-alpha-2014-05-07bis [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/131927 [03:55:01] (03CR) 10Yuvipanda: [C: 032] Bump version number to 2.0-alpha-2014-05-07bis [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/131927 (owner: 10Yuvipanda) [03:55:18] (03Merged) 10jenkins-bot: Bump version number to 2.0-alpha-2014-05-07bis [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/131927 (owner: 10Yuvipanda) [10:41:09] 3Wikipedia App / 3Generic: last update date appears as January 1, 1970 - 10https://bugzilla.wikimedia.org/64136#c1 (10Amir E. Aharoni) I see this on all pages in all languages. [10:44:09] 3Wikipedia App / 3Generic: last update date appears as January 1, 1970 - 10https://bugzilla.wikimedia.org/64136#c2 (10Liangent) (In reply to Amir E. Aharoni from comment #1) > I see this on all pages in all languages. right. [15:12:19] dbrant: I think your TOC patch fixed this also: https://bugzilla.wikimedia.org/show_bug.cgi?id=64889 [15:12:34] I can no longer replicate it, at least. [15:12:47] although pages also seem to be loading rather faster for me today. [15:13:01] ragesoss: alright! I'll take it [15:13:28] but I found some really long pages to test on, and was able to view the whole TOC before the bottom entries became available, and still no TOC glitches. [15:13:57] (just a crash, but I think that's probably the same thing that happens if you load a whole bunch of pages really quickly) [15:15:24] 3Wikipedia App / 3Generic: open TOC is overwritten if page isn't finished loading - 10https://bugzilla.wikimedia.org/64889#c1 (10Sage Ross) 5NEW>3RES/WOR After the patch for bug 63133, I can no longer replicate this. I think the TOC change fixed it. [15:16:07] ragesoss: so wait, you *were* able to get it to crash when opening a long page? [15:16:34] dbrant: I got a crash after open about 5 lolng pages in a row. [15:16:46] after the crash, I was able to open the last one without issue. [15:16:58] dbrant: would you like the crash report? [15:17:17] ragesoss: absolutely [15:17:31] dbrant: do you have access to the OTRS queue where the crash reports go? [15:17:55] (if not, you should get access.) [15:18:16] ah yes, I've got it [15:18:19] forwarded the crash report. [15:19:02] got it! [15:19:18] crashes are annoying :( [15:21:10] ragesoss: I do rather like the pull-from-right design. [15:21:21] me too! [15:22:03] I'm about to file a separate bug for the last thing in that TOC bug report, the suggestion of making the area you can pull from wider. [15:22:46] that's fine; I just didn't want to do too much all at once. [15:22:55] It's a substantial usability issue for people with bumper cases and wide fingers, because it can be very tricky to actually initiate a swipe from the edge. [15:23:16] but I realize that it goes against the Android defaults as well. [15:23:40] so probably it should get a bit of input from the PMs, at least. [15:23:58] for sure [15:28:56] 3Wikipedia App / 3Generic: On phones with bumper cases and slim bezels, it is hard to pull out drawers - 10https://bugzilla.wikimedia.org/65004 (10Sage Ross) 3NEW p:3Unprio s:3minor a:3None I'm breaking this out from bug 63133... For phones with slim bezels and cases that extend above the plane of t... [15:30:10] 3Wikipedia App / 3Generic: Interaction between settings drawer and TOC is confusing - 10https://bugzilla.wikimedia.org/63133#c11 (10Sage Ross) 5PAT>3RES/FIX Nice! I think this is a big improvement. I hope this drawers UI sticks around. I've broken out the suggestion for increasing the grabbable area for... [15:31:54] 3Wikipedia App / 3Generic: Scrolling is broken for In-article scrollable elements - 10https://bugzilla.wikimedia.org/63526 (10Sage Ross) 5PAT>3RES/FIX [15:38:25] I'm still experiencing the issue where the app becomes unresponsive if I open too many articles in quick succession. [15:38:53] Not even 'so quick that I must be doing it on purpose' sometimes. [15:39:06] I just ran into it on accident on my Nexus 7. [15:43:55] will investigate... [15:45:00] (I assumed that this was the same thing described at https://bugzilla.wikimedia.org/show_bug.cgi?id=64762 , but maybe not) [15:47:22] that one had to do with articles not being rendered properly, but the app wasn't crashing. [15:47:49] I didn't get a crash in what I just described. [15:47:57] The app just becomes unresponsive. [15:48:24] Yuvi asked the other day what happens if I open a bunch of pages in a row, and this same thing is what I experienced. [15:48:40] I assumed that was the expected problems, but I guess he was asking about the rendering issue. [15:48:57] I see, that's curious. [15:49:32] I can't seem to get it to happen on my device... (Galaxy S3) [15:50:37] huh... that's weird. [15:50:52] On the main page, if I click "Full article..." [15:50:56] it opens in browser. [15:52:25] This is the template that formats it, so I have no idea why it would open in browser: https://en.wikipedia.org/w/index.php?title=Template:TFAFULL&action=edit [15:54:31] dbrant: it happens with me consistently on both Nexus 5 and 7, if I click enough links is quick succession. [16:11:56] 3Wikipedia App / 3Generic: The first row in TOC can be covered by the search bar - 10https://bugzilla.wikimedia.org/65006 (10Liangent) 3NEW p:3Unprio s:3normal a:3None 1. Pull out TOC 2. Pull out navigation drawer 3. Close navigation drawer [16:13:09] 3Wikipedia App / 3Generic: The first row in TOC can be covered by the search bar - 10https://bugzilla.wikimedia.org/65006#c1 (10Liangent) 5NEW>3RES/DUP *** This bug has been marked as a duplicate of bug 64664 *** [16:13:09] 3Wikipedia App / 3Generic: In some cases, the top rows of TOC drawer is covered by the search bar - 10https://bugzilla.wikimedia.org/64664#c2 (10Liangent) *** Bug 65006 has been marked as a duplicate of this bug. *** [16:18:39] 3Wikipedia App / 3Generic: App stops responding after being used for a while - 10https://bugzilla.wikimedia.org/64450#c3 (10Liangent) Still happening [16:19:55] 3Wikipedia App / 3Generic: Math images have a different background color than the app which looks ugly - 10https://bugzilla.wikimedia.org/64426 (10Liangent) 5RES/FIX>3REO [16:19:55] 3Wikipedia App / 3Generic: Math images have a different background color than the app which looks ugly - 10https://bugzilla.wikimedia.org/64426#c3 (10Liangent) 5UNC>3RES/FIX Can be reproduced with wikitext z^2 + 2az + b^2 [16:20:09] 3Wikipedia App / 3Generic: Math images have a different background color than the app which looks ugly - 10https://bugzilla.wikimedia.org/64426 (10Liangent) 5REO>3NEW [16:25:09] 3Wikipedia App / 3Generic: Some pages appear too wide and contents can't be scrolled left/right correctly - 10https://bugzilla.wikimedia.org/64130#c2 (10Liangent) 5ASS>3RES/FIX This I'd fixed now. [16:25:40] 3Wikipedia App / 3Generic: Some pages appear too wide and contents can't be scrolled left/right correctly - 10https://bugzilla.wikimedia.org/64130#c3 (10Liangent) This is fixed now. [16:34:30] ragesoss: I have a fix for the "full article" link. patching... [16:34:43] :D [16:35:30] In case you didn't see, Liangent bumped that 'stops responding' bug, which Yuvi thinks is a memory leak. [16:35:55] ragesoss: yep! [16:40:56] (03PS1) 10Dbrant: Fixed clicking on links that have inner tags. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/131994 [16:47:46] liangent: what device do you use? [16:51:21] chrismcmahon: you there? [16:56:14] (03CR) 10Yurik: [C: 032] MCC-MNC logging. [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/130991 (owner: 10Dr0ptp4kt) [16:57:09] (03PS1) 10Yurik: Re-applied "Redirect users to upload.wikimedia.org for direct links if okay."" [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/131998 [16:57:30] (03CR) 10Yurik: [C: 032] Re-applied "Redirect users to upload.wikimedia.org for direct links if okay."" [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/131998 (owner: 10Yurik) [16:57:34] (03Merged) 10jenkins-bot: MCC-MNC logging. [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/130991 (owner: 10Dr0ptp4kt) [16:57:52] (03Merged) 10jenkins-bot: Re-applied "Redirect users to upload.wikimedia.org for direct links if okay."" [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/131998 (owner: 10Yurik) [17:02:49] hi jdlrobson [17:04:29] chrismcmahon: i was trying to workout how to login to jenkins but i worked it out :) [17:08:43] https://en.wikipedia.org/wiki/Wikipedia:Requests_for_comment/Mobile_site_strapline [17:09:05] https://en.wikipedia.org/wiki/Wikipedia:Requests_for_comment/Mobile_site_strapline tfinc for your enjoyment [17:14:43] (03PS19) 10Jdlrobson: Hygiene: Standardise on our icon usage [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129085 [17:15:47] (03PS5) 10Jdlrobson: Show toast when a page is protected [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/131235 (https://bugzilla.wikimedia.org/64643) [17:17:13] (03CR) 10Jdlrobson: [C: 032] Show toast when a page is protected [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/131235 (https://bugzilla.wikimedia.org/64643) (owner: 10Jdlrobson) [17:17:47] (03Merged) 10jenkins-bot: Show toast when a page is protected [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/131235 (https://bugzilla.wikimedia.org/64643) (owner: 10Jdlrobson) [17:18:24] 3MobileFrontend / 3stable: Protected pages trigger the edit cta - 10https://bugzilla.wikimedia.org/64643 (10Jon) 5PAT>3RES/FIX [17:19:37] (03CR) 10Jdlrobson: "See also https://bugzilla.wikimedia.org/show_bug.cgi?id=65008" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/131897 (owner: 10Kaldari) [17:23:23] kaldari: can you +2 … it's so tempting for me to self merge https://gerrit.wikimedia.org/r/#/c/131111/ [17:23:50] ^ cc MaxSem [17:25:24] 3MobileFrontend / 3stable: Close icon in references drawer doesn't work - 10https://bugzilla.wikimedia.org/64629#c2 (10Jon) 5NEW>3RES/FIX Fixed by https://gerrit.wikimedia.org/r/#/c/130786/ [17:27:54] (03PS20) 10Jdlrobson: Hygiene: Standardise on our icon usage [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129085 [17:34:20] (03PS21) 10Jdlrobson: Hygiene: Standardise on our icon usage [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129085 [17:34:41] ^ kaldari please please pleaaasseee [17:35:06] Maryana: feel free to move the invite [17:35:34] will do [17:36:20] tfinc: just moved to 2:30 - did that show up on your cal, too? [17:36:42] Maryana: yup [17:36:57] i just deleted the hold i had today so feel free to move it up [17:37:41] dbrant|lunch: mhurd Maryana: i'm glad i kept the standup today. our conversations were very rich and we were abel to show that the hackathon isn't a huge disruption [17:37:48] i'm eager for friday [17:38:03] (03PS2) 10Jdlrobson: Hygiene: Remove blockquote css repetition [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/131880 [17:38:07] (03PS2) 10Jdlrobson: Hygiene: Sensible defaults for textarea elements [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/131881 [17:38:29] (03PS2) 10Jdlrobson: Hygiene: Use the reset for the left menu [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/131882 [17:39:06] chrismcmahon: if you get time to look at https://gerrit.wikimedia.org/r/#/c/125864/ i'd really appreciate it! [17:39:32] jdlrobson: are you not going to Zurich then? [17:39:41] chrismcmahon: i am - later today [17:39:46] hence why i'm trying to wrap up all my work :) [17:40:14] got it [17:40:46] jdlrobson: flipping through my passport today, saw that my brazil visa is good for 10 years.. [17:40:52] carnival has to happen :D [17:41:07] Maryana :-) [17:41:10] i still need to renew my passport.. [17:42:25] 3MobileFrontend / 3Feature requests: "Desktop" in page footer of Special:Uploads returns Page unavailable - 10https://bugzilla.wikimedia.org/64986#c2 (10Jon) We were asked to disable this page on desktop as the name was too similar to Special:Upload We can definitely review this though if there has been a c... [17:46:03] dr0ptp4kt: thank you for your code review for iOS and Android for mhurd and dbrant|lunch [17:46:19] tfinc, it's fun! [17:49:59] tfinc, to be fair, yesterday it was just for dbrant :) [17:50:23] dr0ptp4kt: whatch out, there is more coming from mhurd [17:50:44] tfinc: cool [17:51:46] (03CR) 10Mhurd: "We came up with the same solution for this :)" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/131994 (owner: 10Dbrant) [17:52:22] Maryana: are you coming into office today? [17:52:28] yep [17:52:30] want to go to airport together? [17:52:39] just getting all my crap together & will head out the door shortly [17:52:41] My flight is 6:15 PM [17:52:46] so i'll probably leave around 3 [17:52:53] yeah, sure thing :) [17:53:26] dr0ptp4kt: if those patches i added you to pass cr is there anything else i need to do before merge? or can you merge them? [17:53:41] ok, heading in. see y'all in an hour or so [17:54:14] (03CR) 10Cmcmahon: [C: 032] "Reviewed and tested page_loading.feature in FF and Chrome" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/125864 (https://bugzilla.wikimedia.org/56057) (owner: 10Jdlrobson) [17:54:44] mhurd, it looks like i now have +2 Verified and Code-Review, so they should be able to be merged. are all of the ones i'm on in a stable state for review? [17:54:47] (03Merged) 10jenkins-bot: QA: Remove dependency on Barack Obama article [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/125864 (https://bugzilla.wikimedia.org/56057) (owner: 10Jdlrobson) [17:55:03] (03PS2) 10Kaldari: Adding Storer-light.js for client-side storage [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/131897 [17:55:04] thanks chrismcmahon ! [17:56:04] dr0ptp4kt: there should be four - yes i think they’re stable [18:01:13] mhurd: aha, I didn't know about gruntJS... [18:01:52] (03PS22) 10Jdlrobson: Hygiene: Standardise on our icon usage [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129085 [18:02:11] dbrant: i only knew about it ‘cause i copied the “www” and “assets” dir structure from android recently :) [18:03:30] dbrant: assets is actually used by the app, and www is what grunt processes to produce assets folder contents [18:04:38] mhurd: I see! I had a feeling that some of the .js code was auto-generated. [18:04:41] 3MobileFrontend / 3stable: Article titles not centered vertically in search overlay - 10https://bugzilla.wikimedia.org/64633#c2 (10Jon) .page-list .title h3, .page-list .title .mw-mf-user, .page-list .title .component { /* margin-bottom: .5em; */ } When there is only one element in the list it does look odd... [18:05:01] (03CR) 10Kaldari: [C: 04-1] Hygiene: Standardise on our icon usage (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129085 (owner: 10Jdlrobson) [18:05:24] 3MobileFrontend / 3stable: Article titles not centered vertically in search overlay - 10https://bugzilla.wikimedia.org/64633#c3 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/XvCOklVl [18:05:35] dbrant: oh, yeah! especially the top of the bundle.js [18:06:34] kaldari: http://bloggingexperiment.com/css-text-indent-style-your-html-form/ [18:08:15] mhurd: are there instructions somewhere for installing / getting it to work? [18:10:37] dbrant: i cd to the “www” dir, then run “npm install” to make grunt download any dependencies specified by the grunt “www/package.json” file. once this completes i just run “grunt” command and it overwrites the “assets” folder contents [18:11:14] dbrant: these depend on gruntJS being already installed of course [18:11:36] (03CR) 10Kaldari: Hygiene: Standardise on our icon usage (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129085 (owner: 10Jdlrobson) [18:11:48] mhurd: oh i see, it's installed via the npm installer [18:12:12] dbrant: i often manually delete the assets folder contents before running grunt just to ensure cruft doesn’t build up [18:12:12] jdlrobson: found a real error https://gerrit.wikimedia.org/r/#/c/129085/22/includes/specials/SpecialMobileWatchlist.php [18:13:36] dbrant: yeah, and i think we’ve configured git to not save all the dependency files, that’s why you’ll need to run npm install once [18:13:58] (03CR) 10Kaldari: Hygiene: Standardise on our icon usage (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129085 (owner: 10Jdlrobson) [18:16:37] (03CR) 10Kaldari: Hygiene: Standardise on our icon usage (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129085 (owner: 10Jdlrobson) [18:19:40] (03PS1) 10MaxSem: Point Special:Uploads desktop link to Special:ListFiles [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/132012 (https://bugzilla.wikimedia.org/64986) [18:20:16] (03CR) 10jenkins-bot: [V: 04-1] Point Special:Uploads desktop link to Special:ListFiles [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/132012 (https://bugzilla.wikimedia.org/64986) (owner: 10MaxSem) [18:20:33] fuck you jerkins [18:20:42] mhurd: awesome; thanks [18:21:39] dbrant: yw :) [18:23:09] 3Wikipedia App / 3Generic: Math images have a different background color than the app which looks ugly - 10https://bugzilla.wikimedia.org/64426#c4 (10Dan Garry) This bug's just weird. The white background appears if you've got two squared symbols in there, but disappears if you've got more or less than that. [18:23:10] (03PS2) 10Dbrant: Fixed clicking on links that have inner tags. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/131994 [18:24:06] (03PS2) 10MaxSem: Point Special:Uploads desktop link to Special:ListFiles [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/132012 (https://bugzilla.wikimedia.org/64986) [18:30:17] (03CR) 10Kaldari: Hygiene: Standardise on our icon usage (037 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129085 (owner: 10Jdlrobson) [18:30:33] jdlrobson: OK, finished review for icon patch [18:32:10] 3Wikipedia App / 3Generic: Math images have a different background color than the app which looks ugly - 10https://bugzilla.wikimedia.org/64426#c5 (10Dmitry Brant) It looks like, for certain specific math formulas, the server generates a PNG with a white background, instead of a transparent background. The b... [18:37:21] (03CR) 10Mhurd: [C: 031] Fixed clicking on links that have inner tags. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/131994 (owner: 10Dbrant) [18:40:54] (03PS23) 10Jdlrobson: Hygiene: Standardise on our icon usage [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129085 [18:41:11] (03CR) 10Jdlrobson: Hygiene: Standardise on our icon usage (0310 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129085 (owner: 10Jdlrobson) [18:46:26] (03CR) 10Jdlrobson: [C: 04-1] "The problem is Special:Uploads always shows file uploads on Commons. Special:ListFiles shows files on the local wiki..." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/132012 (https://bugzilla.wikimedia.org/64986) (owner: 10MaxSem) [18:48:34] (03PS3) 10Kaldari: Adding Storer-light.js for client-side storage [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/131897 [18:51:25] (03PS24) 10Jdlrobson: Hygiene: Standardise on our icon usage [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129085 [18:53:21] moizsyed: please fill in the spreadsheet [18:53:41] (03CR) 10JGonera: [C: 032] Hygiene: Use the reset for the left menu [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/131882 (owner: 10Jdlrobson) [18:54:14] (03Merged) 10jenkins-bot: Hygiene: Use the reset for the left menu [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/131882 (owner: 10Jdlrobson) [18:55:27] (03CR) 10JGonera: [C: 04-1] "I don't think we should include tests for external libraries in our repo." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/131897 (owner: 10Kaldari) [18:59:24] jdlrobson: just did :) [18:59:30] moizsyed: thannkkyyyou [18:59:42] jdlrobson: thanks for liking the video btw ;) [18:59:53] ;-) [19:00:15] i would have preferred to answer the question though but it made up for the 404 ;-) [19:01:39] 3MobileFrontend / 3Feature requests: "Desktop" in page footer of Special:Uploads returns Page unavailable - 10https://bugzilla.wikimedia.org/64986#c4 (10Jon) Looking closer, the reason uploads isn't enabled as they use an overlay which doesn't style nicely at all in a desktop interface... [19:06:01] kaldari: Maryana when you say PM on Friday - what sort of time…? 1pm? 5pm? [19:06:31] for boat trip? [19:06:54] jdlrobson, any easy way of setting interwiki language links? or do I have to add them manually to the interwiki table in DB? [19:07:21] jgonera: Check the README [19:07:46] jgonera: for browser tests - there is a mini guide [19:08:36] jdlrobson, yeah, so that's what I know, thought there might have been an easier way [19:08:46] we should make it part of vagrant by default [19:09:40] Deskana: we still have a couple of un estimated stories in https://trello.com/b/BW5L3PEn/mobile-app-sprint-31-main-article-browse-search . i'm thinking of keeping the estimation meeting tomorrow if you can attend and step in for Maryana [19:09:50] mhurd: dbrant --^ [19:10:36] tfinc: Absolutely. [19:14:05] jdlrobson, still doesn't work for me [19:14:24] jgonera: mmm… so you ran the sql? [19:14:30] yeah [19:14:47] (19:10) root@localhost:[wiki]> INSERT INTO interwiki (iw_prefix, iw_url, iw_local, iw_trans) VALUES ("es", "https://es.wikipedia.org/wiki/$1", 0, 0); [19:14:47] Query OK, 1 row affected, 2 warnings (0.01 sec) [19:15:00] Warning (Code 1364): Field 'iw_api' doesn't have a default value [19:15:00] Warning (Code 1364): Field 'iw_wikiid' doesn't have a default value [19:15:17] [[es:Selenium language test page]] < what does putting that in a page do? [19:15:31] shows a red link [19:15:52] [[en:Plankton]] [19:15:52] [[:pl:Plankton]] [19:15:52] [[es:Plancton]] [19:15:55] all show red links [19:16:24] (I inserted pl an es wiki too) [19:17:17] ok, time to eat, will try again later [19:32:22] (03PS2) 10Jdlrobson: Cleanup ui.less now universal header [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/131892 (https://bugzilla.wikimedia.org/64719) [19:32:53] (03PS3) 10Jdlrobson: Hygiene: Remove blockquote css repetition [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/131880 [19:32:59] (03PS4) 10Jdlrobson: Hygiene: Remove blockquote css repetition [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/131880 [19:33:08] (03PS3) 10Jdlrobson: Hygiene: Sensible defaults for textarea elements [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/131881 [20:12:09] 3Wikipedia App / 3Generic: Following a link pointing to http://en.wikipedia.org/wiki/ crashes the app - 10https://bugzilla.wikimedia.org/64384 (10Dan Garry) 5PAT>3RES/FIX [20:16:54] 3Wikipedia App / 3Generic: http://en.wikipedia.org/wiki/#foo doesn't work in the app - 10https://bugzilla.wikimedia.org/64914#c1 (10Dan Garry) 5NEW>3RES/WOR This works for me; https://en.wikipedia.org/wiki/#foo (both http and https) take me to the main page in the latest build. [20:56:53] chrismcmahon: what does "Unable to pick a platform for the provided browser (RuntimeError)" mean? [20:56:59] see https://integration.wikimedia.org/ci/job/browsertests-MobileFrontend-en.m.wikipedia.org-linux-firefox/lastCompletedBuild/testReport/(root)/Language%20selection/Opening_language_overlay/ [20:58:21] jdlrobson: I'm not exactly sure, but it means Selenium did not have enough information to start a browser at all. I don't (yet) know why we're getting those from WMF Jenkins [21:11:21] (03CR) 10Dr0ptp4kt: "@YuviPanda, you asked the other day on IRC (paraphrasing) "what about VPNs"? So I went down the rabbit hole..." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/131246 (owner: 10Dr0ptp4kt) [21:26:06] jdlrobson: True == all([not a for a in [0, 0, 0]]) [21:26:21] and you probably want it to include a row with all 0z [21:26:34] because not a != a is None [21:26:39] because python is dumb :) [21:27:18] milimetric: huh? [21:27:25] so i want it to rewrite it then situation [21:28:02] you want it to add the row to cache only if it's not all Nulls [21:28:05] all([not a for a in [0, 0, 0]]) = rewrite, all([not a for a in ['', '', '']]) = rewrite all([not a for a in [None, None, None]]) = rewrite, all([not a for a in [0, '', None, 500]]) = don't rewrite [21:28:41] why rewrite if it's 0, 0, 0? isn't that valid data? [21:28:45] no [21:28:49] this is the situation we have right now [21:28:56] oh i see, my bad [21:29:00] I thought you had all Nones [21:29:03] if event logging drops then it counts 0 rows [21:29:03] cool, merging [21:29:08] got it, duh [21:29:09] k [21:29:10] even though there are rows :) [21:29:11] sweet! [21:29:18] thanks for the review! [21:29:21] are you in zurich now? [21:29:35] np, I'm in Grindelwald [21:29:38] at the analytics offsite [21:29:43] but will be in Zurich tomorrow [21:33:22] Deskana: you can do much better then ChatZilla [21:33:35] Deskana: http://limechat.net/mac/ [21:34:09] its two window layout is fantastic for monitoring anything and everything [21:37:39] 3MobileFrontend / 3Feature requests: Special:History should work on desktop - 10https://bugzilla.wikimedia.org/64939#c3 (10Jon) I tried enabling it and it works fine just doesn't completely fit in with the Vector style. Probably will need a bit of design love before doing this. It would be great to use this... [21:39:07] milimetric: can you merge https://gerrit.wikimedia.org/r/#/c/131599/ as well? [21:39:36] i've no way of testing it right now, but yes, if you've tested it, the code looked fine [21:40:28] jdlrobson: ^ [21:40:42] ok sweet [21:40:46] i have tested it :) [21:41:39] 3MobileFrontend / 3stable: Eventlogging for uploads seems to be broken - 10https://bugzilla.wikimedia.org/64618#c2 (10Jon) 5NEW>3RES/FIX A fix was deployed to the Limn graphs - https://gerrit.wikimedia.org/r/#/c/131547/2. Hopefully this will update the graph on next update. Also MobileWebUploads_8209043... [21:44:05] (03CR) 10Kaldari: [C: 032] Hygiene: Standardise on our icon usage [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129085 (owner: 10Jdlrobson) [21:44:44] (03Merged) 10jenkins-bot: Hygiene: Standardise on our icon usage [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129085 (owner: 10Jdlrobson) [21:54:36] (03PS11) 10Jdlrobson: DO NOT MERGE: Create script for checking css rule duplication [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129032 (https://bugzilla.wikimedia.org/64217) [21:55:29] (03PS1) 10Cmcmahon: QA tests that create a page via API should not run on prod [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/132117 [21:55:31] (03CR) 10jenkins-bot: [V: 04-1] DO NOT MERGE: Create script for checking css rule duplication [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129032 (https://bugzilla.wikimedia.org/64217) (owner: 10Jdlrobson) [21:56:08] jdlrobson: still around? If not, I'll self-merge this: https://gerrit.wikimedia.org/r/#/c/132117 [21:58:02] tfinc, jdlrobson: http://drinks.seriouseats.com/2011/11/hangover-helper-waffle-house-hash-browns.html [21:58:15] (03PS2) 10Jdlrobson: Introduce the transformable class [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/131886 [21:58:38] (03CR) 10Kaldari: [C: 032] QA tests that create a page via API should not run on prod [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/132117 (owner: 10Cmcmahon) [21:59:11] (03Merged) 10jenkins-bot: QA tests that create a page via API should not run on prod [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/132117 (owner: 10Cmcmahon) [22:01:39] hello [22:02:57] i missed dbrant|bbl, I think :) [22:03:14] tfinc: I'm in Zurich! Fever is all gone as well [22:03:17] going through email now [22:03:42] kaldari: ah, my youth in the Deep South, they're famous for being "scattered, smothered, covered, and chunked" [22:04:46] covered + chunked ftw (cheese & ham) [22:05:01] * YuviPanda just had decent pasta for the first time ever! [22:05:11] all the pasta I've had in India has sucked [22:05:17] (03PS2) 10Jdlrobson: Hygiene: Introduce .page-summary class [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/131885 [22:05:31] YuviPanda: what did you have? [22:06:08] chrismcmahon: pasta that looked like tubes with a chicken / pepper / mushroom sauce [22:06:12] I didn't eat the mushrooms tho [22:31:39] 3Wikipedia App / 3Generic: The search bar doesn't appear after "back" - 10https://bugzilla.wikimedia.org/64913#c3 (10Dan Garry) 5PAT>3RES/FIX Seems fixed to me. [22:31:52] mm, no Deskana [22:32:55] (03CR) 10Kaldari: [C: 04-1] Deal better with expired edit tokens (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/130522 (https://bugzilla.wikimedia.org/64416) (owner: 10Jdlrobson) [22:33:15] (03PS2) 10Mhurd: Shows respective main page for each lang wiki. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/131904 [22:34:13] (03CR) 10Kaldari: [C: 032] Hygiene: Remove unused template for languages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/131889 (owner: 10Jdlrobson) [22:34:25] 3Wikipedia App / 3Generic: Network failure is not handled at all in account creation - 10https://bugzilla.wikimedia.org/64891 (10Dan Garry) 5PAT>3RES/FIX [22:34:45] (03Merged) 10jenkins-bot: Hygiene: Remove unused template for languages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/131889 (owner: 10Jdlrobson) [22:41:57] (03Abandoned) 10Mhurd: Use wikiFont for history discovery method icons. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/131916 (owner: 10Mhurd) [23:02:48] YuviPanda: heya! [23:02:52] mhurd: hey! [23:03:23] YuviPanda: would you have a sec to point me in the direction of the anon editing killswitch stuff? [23:04:14] YuviPanda: the trello card mentions api end point, but i can’t recall what became of that [23:04:23] mhurd: yeah, no API endpoints [23:04:25] let me get the URL [23:04:30] YuviPanda: ah. cool [23:04:55] mhurd: https://bits.wikimedia.org/static-current/extensions/MobileApp/config/ios.json [23:05:21] YuviPanda: woohoo! thanks! [23:05:24] :) [23:05:36] mhurd: :) it's a general structure, so can be used for any form of kill switches / a-b testing, etc [23:05:42] YuviPanda: perfect! [23:05:56] mhurd: ;) [23:06:12] mhurd: I'm going to head to sleep in a few mins. want anything else? [23:06:51] YuviPanda: that’s good for now! get some rest :) [23:07:04] (03PS1) 10Kaldari: Only create editor switcher from wikitext editor if VE is usable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/132124 (https://bugzilla.wikimedia.org/64681) [23:07:05] mhurd: :) will do [23:14:13] (03CR) 10Kaldari: "jgonera: I only added tests because Jon asked for them :P" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/131897 (owner: 10Kaldari) [23:23:14] (03CR) 10Kaldari: [C: 04-1] Hygiene: Sensible defaults for textarea elements (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/131881 (owner: 10Jdlrobson) [23:58:59] (03CR) 10Jdlrobson: [C: 032] Only create editor switcher from wikitext editor if VE is usable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/132124 (https://bugzilla.wikimedia.org/64681) (owner: 10Kaldari) [23:59:31] (03Merged) 10jenkins-bot: Only create editor switcher from wikitext editor if VE is usable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/132124 (https://bugzilla.wikimedia.org/64681) (owner: 10Kaldari)