[00:10:21] (03PS1) 10MaxSem: Fix the mess with previous revisions in contributions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/132130 (https://bugzilla.wikimedia.org/64867) [00:16:49] (03PS4) 10Jdlrobson: Hygiene: Sensible defaults for textarea elements [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/131881 [00:17:20] (03CR) 10Jdlrobson: Hygiene: Sensible defaults for textarea elements (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/131881 (owner: 10Jdlrobson) [00:19:46] (03CR) 10Jdlrobson: "Max feel free to suggest an alternative patch. We should get this fixed asap though even if it is a short term solution." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/131759 (https://bugzilla.wikimedia.org/64543) (owner: 10Jdlrobson) [00:21:56] (03PS1) 10Dr0ptp4kt: WIP: DO NOT MERGE YET! Log more memcache related events in debug log. [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/132132 [00:23:00] (03PS2) 10Dr0ptp4kt: WIP: DO NOT MERGE YET! Log memcache state changes, increase timeout. [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/132132 [00:23:21] (03CR) 10Jdlrobson: Deal better with expired edit tokens (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/130522 (https://bugzilla.wikimedia.org/64416) (owner: 10Jdlrobson) [00:24:09] (03CR) 10MaxSem: [C: 04-1] "I'm not opposed to this in principle, but see comment." (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/131759 (https://bugzilla.wikimedia.org/64543) (owner: 10Jdlrobson) [00:25:31] (03PS4) 10Jdlrobson: Repurpose wgMFNearbyNamespace as wgMFContentNamespace [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/131759 (https://bugzilla.wikimedia.org/64543) [00:26:09] (03PS5) 10Jdlrobson: Deal better with expired edit tokens [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/130522 (https://bugzilla.wikimedia.org/64416) [00:28:59] (03CR) 10Jdlrobson: [C: 04-1] "When visiting http://localhost.beta/w/index.php/Special:History/Barack_Obama" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/132130 (https://bugzilla.wikimedia.org/64867) (owner: 10MaxSem) [00:33:36] (03PS2) 10MaxSem: Fix the mess with previous revisions in contributions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/132130 (https://bugzilla.wikimedia.org/64867) [00:44:37] (03PS3) 10Dr0ptp4kt: WIP: DO NOT MERGE YET! Log memcache state changes, increase timeout. [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/132132 [00:53:41] dr0ptp4kt: ping [01:07:18] (03CR) 10Dr0ptp4kt: "Seems to be working okay, but should a tap on the checkmark when the "Sign in and save" box seems to be "highlighted" blue cause an anonym" (031 comment) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/131660 (owner: 10Mhurd) [01:23:03] (03CR) 10Dr0ptp4kt: "Quick questions on whether stuff is intended to be transactional as opposed to bundled in one message per operation in the context of the " (034 comments) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/131740 (owner: 10Mhurd) [04:13:26] 3Wikipedia App / 3Generic: Math images have a different background color than the app which looks ugly - 10https://bugzilla.wikimedia.org/64426#c6 (10Dan Garry) 5NEW>3RES/INV (In reply to Dmitry Brant from comment #5) > It looks like, for certain specific math formulas, the server generates a > PNG with... [04:22:11] 3Wikipedia App / 3Generic: Links to article names with Unicode characters do not open properly - 10https://bugzilla.wikimedia.org/64987 (10Dan Garry) 5PAT>3RES/FIX [04:43:09] 3MobileFrontend / 3General/Unknown: MobileFrontend "last edited" strapline should not include authorship information - 10https://bugzilla.wikimedia.org/64921#c21 (10MZMcBride) (In reply to Ryan Kaldari from comment #20) > We're just trying to inform you that the Product Owner > (http://en.wikipedia.org/wiki/... [05:50:10] 3Wikipedia App / 3Generic: Math images have a different background color than the app which looks ugly - 10https://bugzilla.wikimedia.org/64426 (10Liangent) [05:50:10] 3Wikipedia App / 3Generic: Math images have a different background color than the app which looks ugly - 10https://bugzilla.wikimedia.org/64426 (10Liangent) [06:26:36] Reedy, you there? was wondering if i could get a hand with a patch [06:41:17] (03CR) 10SG: "Is there precedence for having external tests in our codebase?" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/131897 (owner: 10Kaldari) [06:41:41] dfoy, i'm making progress. see email [06:41:56] dfoy, i'm on gchat, just hiding. going to restart ff and leave irc [06:42:10] dr0ptp4kt: ok thx [06:44:18] dr0ptp4kt: I’m signing off for the night - I have an early morning call - anything you need? [08:45:44] [13WikipediaMobile] 15siebrand pushed 1 new commit to 06master: 02http://git.io/H5Fjeg [08:45:44] 13WikipediaMobile/06master 14d5023f5 15Siebrand Mazeland: Localisation updates from https://translatewiki.net. [10:09:15] (03CR) 10Krinkle: "Hm.. I don't think having it report fail/pass based on how much has changed is useful. Font rendering can indeed be variable, but shouldn'" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/126878 (owner: 10JGonera) [10:09:33] (03CR) 10Krinkle: "https://bugzilla.wikimedia.org/show_bug.cgi?id=62633" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/126878 (owner: 10JGonera) [14:13:33] (03PS1) 10Dbrant: Better scrolling when editing sections. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/132197 [14:28:14] (03CR) 10Dr0ptp4kt: "A question, and some commentary (possible future stories?)." (033 comments) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/131904 (owner: 10Mhurd) [15:46:00] (03PS1) 10Dbrant: Display "last updated" time correctly. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/132203 (https://bugzilla.wikimedia.org/64136) [16:56:39] ar you sure that https://gerrit.wikimedia.org/r/#/c/127179/ works? [17:10:44] it doesn't, fix already committed [17:10:47] :P [17:25:27] 3 PHP Warning: DOMDocument::createElement() [domdocument.createelement]: unterminated entity reference A in [17:25:27] /usr/local/apache/common-local/php-1.24wmf3/extensions/MobileFrontend/includes/MobileFormatter.php on line 202 [17:26:04] * Reedy kicks MaxSem [17:26:33] * MaxSem is too soft to be hurt [17:38:21] (03CR) 10Mhurd: "I think so. I believe the present thinking about that design is that the "sign in " option is blue to intentionally draw more attention to" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/131660 (owner: 10Mhurd) [17:38:49] (03PS1) 10MaxSem: Fix desktop link for MobileContributions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/132212 [17:40:29] (03CR) 10Mhurd: "Added comment." (031 comment) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/131740 (owner: 10Mhurd) [17:46:43] (03CR) 10Mhurd: "Added comments." (033 comments) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/131904 (owner: 10Mhurd) [17:47:58] (03CR) 10Dr0ptp4kt: [C: 032 V: 032] "Yep. Please convey to Vibha." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/131660 (owner: 10Mhurd) [17:50:45] 3MobileFrontend / 3stable: action=mobileview live & doc mismatch - 10https://bugzilla.wikimedia.org/65035 (10Liangent) 3NEW p:3Unprio s:3normal a:3None prop - Which information to get lastmodified - MW timestamp for when the page was last modified, e.g. "201... [17:55:27] 3MobileFrontend / 3stable: action=mobileview live & doc mismatch - 10https://bugzilla.wikimedia.org/65035#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/ny2GoKN2 [17:56:53] (03CR) 10Dr0ptp4kt: [C: 032 V: 032] "Per face-to-face, a full review of these will be done in a future patchset." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/131740 (owner: 10Mhurd) [18:01:12] (03CR) 10Dr0ptp4kt: [C: 032 V: 032] "Let's keep this moving. The other items are for follow up." (033 comments) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/131904 (owner: 10Mhurd) [18:05:46] (03CR) 10Yurik: [C: 04-1] "lets reuse the existing zero log" [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/132132 (owner: 10Dr0ptp4kt) [18:07:12] is there any MediaWiki:***.css that I can use to style documents in the app? [18:19:12] 3Wikipedia App / 3Generic: ToC taking up too much horizontal space - 10https://bugzilla.wikimedia.org/64341 (10Dan Garry) 5PAT>3RES/FIX [18:22:15] hey brion! [18:22:24] hey hey [18:22:27] i survived the flight [18:22:28] more or less [18:22:41] awesome [18:23:05] brion: hey, how would I be able to test your data migration patch? [18:23:50] (03PS1) 10Mhurd: Use wikiFont for history discovery method icons. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/132216 [18:23:55] lessee…. [18:24:06] dbrant: you have to be able to do an upgrade so you need the signing keys to be the same [18:24:21] you can either install the existing app from store and then the new app from a signed .apk... [18:24:42] brion: ah, i see. I don't have the signing keys [18:24:43] …or you can fire up Eclipse (or ant on CLI) :D and install the old app with your debug signing key [18:24:50] lemme grab the url for the repo [18:25:09] here’s the old app — https://github.com/wikimedia/WikipediaMobile [18:25:18] git clone https://github.com/wikimedia/WikipediaMobile.git [18:25:35] it’s got some extra stuff for other platforms but if you just use the ant build scripts or open it as a project in eclipse it’ll give you android [18:25:54] i believe it includes the necessary phonegap/cordova libraries so you can just install it straight [18:25:54] so as long as the new app is signed with the same key, it will upgrade? [18:26:00] yeah [18:26:11] alright! I'll try it [18:26:12] you may have to remove the new app before installing the old app because the system doesn’t like to downgrade packages [18:26:19] but the new one will upgrade on top of the old one yes [18:26:21] awesome :D [18:26:45] (03PS2) 10Mhurd: Use wikiFont for history discovery method icons. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/132216 [18:35:44] (03CR) 10Kaldari: "SG: Yes. As I mentioned, we already have tests for epoch.js in MobileFrontend, which is an external library." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/131897 (owner: 10Kaldari) [18:37:27] MaxSem: If you have a chance, can you take a look at https://gerrit.wikimedia.org/r/#/c/120696/, it's been sitting in gerrit for a month and a half. [18:38:14] oh shi... that's all ReviewerBot's spam [18:41:30] (03CR) 10Kaldari: [C: 032] Fix desktop link for MobileContributions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/132212 (owner: 10MaxSem) [18:41:59] 3Wikipedia App / 3Generic: Introduce MediaWiki:App.css or something in Extension:MobileApp - 10https://bugzilla.wikimedia.org/65037 (10Liangent) 3NEW p:3Unprio s:3normal a:3None To make it possible to style documents in the app on wiki. [18:42:06] (03Merged) 10jenkins-bot: Fix desktop link for MobileContributions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/132212 (owner: 10MaxSem) [18:46:23] mhurd: dbrant: http://hatjitsu.wmflabs.org/29921 [18:49:28] 3Wikipedia App / 3Generic: Introduce MediaWiki:App.css or something in Extension:MobileApp - 10https://bugzilla.wikimedia.org/65037#c1 (10Sam Reed (reedy)) p:5Unprio>3Normal s:5normal>3enhanc class Foobar extends ResourceLoaderWikiModule { /** * @param $context ResourceLoaderContext * @... [18:51:44] 3MobileFrontend / 3stable: Bare Special:Contributions (without subpage) shouldn't be caught by mobile - 10https://bugzilla.wikimedia.org/65039 (10Liangent) 3NEW p:3Unprio s:3normal a:3None https://en.wikipedia.org/wiki/Special:Contributions sends me to https://en.m.wikipedia.org/wiki/Special:Contribu... [18:51:55] (03CR) 10Kaldari: [C: 032] Deal better with expired edit tokens [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/130522 (https://bugzilla.wikimedia.org/64416) (owner: 10Jdlrobson) [18:52:27] (03Merged) 10jenkins-bot: Deal better with expired edit tokens [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/130522 (https://bugzilla.wikimedia.org/64416) (owner: 10Jdlrobson) [18:55:27] 3MobileFrontend / 3stable: Bare Special:Contributions (without subpage) shouldn't be caught by mobile - 10https://bugzilla.wikimedia.org/65039#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/AaSCnXPp [19:31:02] dr0ptp4kt: here’t that icon update: https://gerrit.wikimedia.org/r/#/c/132216/ [19:33:02] mhurd i'm not here [19:41:18] (03CR) 10Dbrant: [C: 032] "\o/ Tried it with 50 saved pages in multiple languages; no discernible impact on app loading time." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/131539 (owner: 10Brion VIBBER) [20:29:04] (03CR) 10Dr0ptp4kt: [C: 032 V: 032] Use wikiFont for history discovery method icons. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/132216 (owner: 10Mhurd) [20:30:15] 3MobileFrontend / 3alpha: If you switch to mobile view while editing and save your edit, it takes you back to the desktop editing interface - 10https://bugzilla.wikimedia.org/65041 (10Ryan Kaldari) 3NEW p:3Unprio s:3normal a:3None How to reproduce: 1. Go to http://en.m.wikipedia.beta.wmflabs.org/wiki... [20:30:27] 3MobileFrontend / 3alpha: If you switch to mobile view while editing and save your edit, it takes you back to the desktop editing interface - 10https://bugzilla.wikimedia.org/65041#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/1wfSMlbf [20:40:18] dr0ptp4kt: Did you get what you wanted deploying deployed? [20:41:59] (03CR) 10Kaldari: [C: 04-1] Hygiene: Sensible defaults for textarea elements (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/131881 (owner: 10Jdlrobson) [20:42:21] Reedy: yeah, we're good, thx [20:44:25] dbrant, lemme know once https://gerrit.wikimedia.org/r/#/c/131994/ is stable and ready for review (best to hit me on irc after adding me on the patch once you need me, if i don't ACK, then email) [20:45:10] (03CR) 10Kaldari: [C: 04-1] "I'm not a fan of moving away from semantic CSS just to reduce rule duplication. See comment at" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/131883 (owner: 10Jdlrobson) [21:02:37] (03PS4) 10Dr0ptp4kt: Log memcache state changes, increase timeout. [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/132132 [21:02:52] ^yurik for when you're off the call with tfinc [21:07:40] tfinc: i realized yurik's irc disconnected, so emailed him that patch, in case you were following along [21:09:05] (03PS1) 10MaxSem: Fix entity escaping on main pages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/132299 [21:09:22] dr0ptp4kt, ^ [21:11:40] MaxSem, looks good, add me to the patch and lemme know if you want me to do a gerrit review [21:12:03] dr0ptp4kt, yes - I'd like to deploy this today [21:12:42] 3Wikipedia App / 3Generic: Host the app somewhere on our own server, so Wikipedia Zero users can download it at zero rate - 10https://bugzilla.wikimedia.org/64471#c2 (10Dan Garry) 5NEW>3RES/INV Not really an apps issue, more to do with Wikipedia Zero. You can contact them about this. [21:12:56] (03CR) 10Dr0ptp4kt: [C: 031] "The main code works from what I can tell." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/132299 (owner: 10MaxSem) [21:13:10] kaldari: ^ you mind looking at this one, too? [21:24:32] (03CR) 10Kaldari: [C: 032] Fix entity escaping on main pages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/132299 (owner: 10MaxSem) [21:25:04] (03Merged) 10jenkins-bot: Fix entity escaping on main pages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/132299 (owner: 10MaxSem) [21:26:27] (03PS1) 10MaxSem: Fix entity escaping on main pages [extensions/MobileFrontend] (wmf/1.24wmf4) - 10https://gerrit.wikimedia.org/r/132300 [21:26:44] (03CR) 10MaxSem: [C: 032] Fix entity escaping on main pages [extensions/MobileFrontend] (wmf/1.24wmf4) - 10https://gerrit.wikimedia.org/r/132300 (owner: 10MaxSem) [21:27:31] (03Merged) 10jenkins-bot: Fix entity escaping on main pages [extensions/MobileFrontend] (wmf/1.24wmf4) - 10https://gerrit.wikimedia.org/r/132300 (owner: 10MaxSem) [21:31:44] 3MobileFrontend / 3beta: Mobile Table of Contents double unescapes encoded characters - 10https://bugzilla.wikimedia.org/65042 (10Ryan Kaldari) 3NEW p:3Unprio s:3normal a:3None Compare these two TOCs: http://en.wikipedia.beta.wmflabs.org/wiki/Igloo http://en.m.wikipedia.beta.wmflabs.org/wiki/Igloo (i... [21:33:35] (03PS1) 10MaxSem: Cherry-pick If917097f97d0239aa2ebdeabe863b5786e92230c [extensions/MobileFrontend] (wmf/1.24wmf3) - 10https://gerrit.wikimedia.org/r/132304 [21:34:00] (03CR) 10MaxSem: [C: 032] Cherry-pick If917097f97d0239aa2ebdeabe863b5786e92230c [extensions/MobileFrontend] (wmf/1.24wmf3) - 10https://gerrit.wikimedia.org/r/132304 (owner: 10MaxSem) [21:35:01] (03Merged) 10jenkins-bot: Cherry-pick If917097f97d0239aa2ebdeabe863b5786e92230c [extensions/MobileFrontend] (wmf/1.24wmf3) - 10https://gerrit.wikimedia.org/r/132304 (owner: 10MaxSem) [21:35:27] 3MobileFrontend / 3beta: Mobile Table of Contents double unescapes encoded characters - 10https://bugzilla.wikimedia.org/65042#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/IIXEuTOZ [21:40:59] 3Wikipedia App / 3Settings: If ToC is open, it should not be possible to swipe open the settings bar - 10https://bugzilla.wikimedia.org/65043 (10Dan Garry) 3NEW p:3Unprio s:3normal a:3None Steps to reproduce: 1) Swipe left to open ToC 2) Swipe right to open settings On a tablet with a wide screen,... [22:09:07] (03CR) 10Yurik: [C: 032] Log memcache state changes, increase timeout. [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/132132 (owner: 10Dr0ptp4kt) [22:09:09] (03CR) 10jenkins-bot: [V: 04-1] Log memcache state changes, increase timeout. [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/132132 (owner: 10Dr0ptp4kt) [22:34:45] 3MobileFrontend / 3stable: "Read in another language" gives desktop site's links - 10https://bugzilla.wikimedia.org/65047 (10fireattack) 3UNC p:3Unprio s:3normal a:3None instead of .m. ones. And it won't automatically jump to mobile site either. [22:35:27] 3MobileFrontend / 3stable: "Read in another language" gives desktop site's links - 10https://bugzilla.wikimedia.org/65047#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/5sNUXvKv [22:50:14] dbrant: how goes moving https://trello.com/c/Bei6hEaD/12-3-point-the-apps-to-online-extension-mobileapp-css-resources through code review ? [22:51:19] tfinc: hmm, I don't see the Gerrit change for that [22:51:37] dbrant: mail yuvi and ask him for it [22:51:57] tfinc: will do [23:05:48] (03PS5) 10Dr0ptp4kt: Log memcache state changes, increase timeout. [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/132132 [23:11:22] tfinc: moved back to Doing, per Yuvi [23:11:28] dbrant: thanks [23:25:10] mhurd: https://tools.usps.com/go/TrackConfirmAction?qtc_tLabels1=9114901159818691183434 :) [23:25:27] tfinc: yay! :) [23:40:27] yurik, i changed a few characters to see if that can unstick things in gerrit. would you please try https://gerrit.wikimedia.org/r/#/c/132132/ ? [23:41:23] (03CR) 10Yurik: [C: 032] Log memcache state changes, increase timeout. [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/132132 (owner: 10Dr0ptp4kt) [23:42:55] (03Merged) 10jenkins-bot: Log memcache state changes, increase timeout. [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/132132 (owner: 10Dr0ptp4kt) [23:43:41] yurik, thx, now we shall see. want me to put it on swat calendar? [23:43:57] i could push it next wed, or before, up to you [23:44:08] yurik, next wed fine for me [23:44:17] oki [23:45:32] dr0ptp4kt: update all the internets [23:53:04] git clone internets; rm -rf internets [23:53:08] oops, internets gone