[00:12:08] (03PS2) 10Mhurd: Anonymous editing killswitch. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/132587 [00:14:36] brion: ^ this should be better - i added a couple of notes for things which will need to be added. nothing too crazy [00:15:04] ok :D [00:15:05] moment [00:17:41] brion: (the notes are in the commit msg) [00:24:13] brion: gah! lost my connection there [00:26:36] ok moment [00:27:17] sweet i got a labs server setup with one of my old experimental extensions for scripting: http://embed-demo.wmflabs.org/wiki/Main_Page [00:27:25] now i can modernize it :D [00:27:29] but first…. code review [00:33:03] (03CR) 10Brion VIBBER: "Looks better :D" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/132587 (owner: 10Mhurd) [00:33:18] brion: better is good! :) [00:36:09] ok it sees the files on device, looks like they copied ok \o/ [00:36:14] lemme try in sim where i can edit it [00:38:43] brion: *fingers crossed* [00:39:04] mhurd: hmmmm, editing the Documents/Json/config/ios.json to say ‘true’ doesn’t seem to stop the edit icon from showing up when i restart the app [00:39:17] lemme dobule-check the code [00:39:53] but it…. looks right.... [00:40:16] brion: oh, edit icon still shows in case user is logged in [00:40:33] brion: only the “save anonymously” button goes away [00:40:42] ooooooooooh ok [00:40:48] i’m testing the wrong thing :D [00:41:29] sweet [00:41:31] ok looks good :D [00:42:29] oh whoops one minor thing [00:42:44] mhurd: i think there’s an imbalanced network indicator pop in the no-refresh case [00:43:09] lemme test [00:43:17] brion: ah [00:45:05] mhurd: nah it looks ok, we on’t seem to call the completion handler if we aborted in the before portion [00:45:09] (03PS1) 10Dr0ptp4kt: Make the PhantomJS tests go faster. [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/132591 [00:45:26] (03CR) 10Dr0ptp4kt: [C: 032] Make the PhantomJS tests go faster. [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/132591 (owner: 10Dr0ptp4kt) [00:45:28] brion: ah. the imbalance could have been an artifact of the intial patch getting held up on the write [00:45:46] brion: maybe? i’ll keep an eye out for it [00:45:50] (03Merged) 10jenkins-bot: Make the PhantomJS tests go faster. [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/132591 (owner: 10Dr0ptp4kt) [00:45:52] (03CR) 10Brion VIBBER: [C: 032 V: 032] "Seems to copy files ok, whee!" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/132587 (owner: 10Mhurd) [00:46:03] mhurd: yeah if it looks suspicious it should be easy enough to fix [00:46:04] brion: awesomeness! [00:46:17] brion: thanks for stayin up late for cr :) [00:46:24] sure thing :D [00:46:51] brion: well, i’m gonna get food. see ya later! [00:47:01] enjoy! [00:47:07] it’s sleep time for me i think :D [00:47:09] latah [00:47:13] g’night! [02:50:27] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/132518 (https://bugzilla.wikimedia.org/65094) (owner: 10MaxSem) [06:03:29] 3Wikipedia App / 3Generic: Viewing TOC of an nonexistent page crashes the app - 10https://bugzilla.wikimedia.org/65112 (10Liangent) 3NEW p:3Unprio s:3normal a:3None To view TOC of a nonexistent page, navigate to another page first, then press back. Now manu items appear enabled. [07:53:12] 3Wikipedia App / 3Generic: Viewing TOC of an nonexistent page crashes the app - 10https://bugzilla.wikimedia.org/65112#c1 (10Liangent) s/manu/menu/ [08:00:19] (03CR) 10Awjrichards: [C: 032] Hide uploads and nearby to non-JS users [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/132368 (owner: 10Jdlrobson) [08:01:29] (03Merged) 10jenkins-bot: Hide uploads and nearby to non-JS users [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/132368 (owner: 10Jdlrobson) [08:12:54] (03CR) 10Awjrichards: [C: 032] Regression: Don't show talk link on talk pages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/132371 (owner: 10Jdlrobson) [08:13:27] (03Merged) 10jenkins-bot: Regression: Don't show talk link on talk pages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/132371 (owner: 10Jdlrobson) [08:51:59] 3MobileFrontend / 3General/Unknown: Device detection code doesn't detect MSIE 11 - 10https://bugzilla.wikimedia.org/65118 (10Liangent) 3NEW p:3Unprio s:3normal a:3None See http://msdn.microsoft.com/en-us/library/ie/hh869301%28v=vs.85%29.aspx includes/DeviceDetection.php- $deviceName =... [08:55:27] 3MobileFrontend / 3General/Unknown: Device detection code doesn't detect MSIE 11 - 10https://bugzilla.wikimedia.org/65118#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/JeFdAiDn [09:04:28] 3MobileFrontend / 3General/Unknown: Device detection code doesn't detect MSIE 11 - 10https://bugzilla.wikimedia.org/65118#c2 (10Brion Vibber) Here's some sample UAs for IE 11: Windows 8.1 x64 desktop: Mozilla/5.0 (Windows NT 6.3; WOW64; Trident/7.0; rv:11.0) like Gecko Windows 8.1 x64 metro: Mozilla/5.0 (W... [09:24:27] 3MobileFrontend / 3General/Unknown: Device detection code doesn't detect MSIE 11 - 10https://bugzilla.wikimedia.org/65118#c3 (10Brion Vibber) Basically we want to detect the 'Trident' tag and find the 'rv:11.0' to extract the version. [09:41:47] (03PS1) 10Yuvipanda: Add instrumentation for ToC usage [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/132627 [09:44:42] (03PS2) 10Yuvipanda: Add instrumentation for ToC usage [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/132627 [09:53:50] lol YuviPanda|zz [09:54:15] you already have a patch for this guy: https://trello.com/c/7TJsFrbD/419-toc-eventlogging-instrumentation ? [12:23:04] brion: hey! There's a small patch for android app! :) [12:23:07] brion: can you merge? [12:23:18] \o/ [12:23:19] lemme look [12:23:31] YuviPanda: the toc instrumentation? [12:23:36] brion: ya [12:23:39] ok [12:28:38] (03CR) 10Brion VIBBER: "This gives us a 'close' even for the implicit close when the user 'click's a section; is that desired?" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/132627 (owner: 10Yuvipanda) [12:39:58] brion: doesn't hurt? [12:40:08] brion: but yeah, I think it'll be easier to have it only happen on specific lcoses [12:40:09] let me do it [12:41:13] ok [12:54:22] (03PS3) 10Yuvipanda: Add instrumentation for ToC usage [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/132627 [13:14:57] 3MobileFrontend / 3General/Unknown: Device detection code doesn't detect MSIE 11 - 10https://bugzilla.wikimedia.org/65118 (10Sam Reed (reedy)) p:5Unprio>3Normal s:5normal>3minor [13:18:06] (03CR) 10Brion VIBBER: [C: 032] Add instrumentation for ToC usage [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/132627 (owner: 10Yuvipanda) [13:18:17] brion: woo! :) [13:18:23] brion: can you make a release? :) [13:18:26] (03Merged) 10jenkins-bot: Add instrumentation for ToC usage [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/132627 (owner: 10Yuvipanda) [13:19:16] YuviPanda: on android? anything else to do but bump the version, make the build, and upload it to alpha on google play? [13:19:33] brion: nope [13:20:12] okee [13:22:26] (03PS1) 10Brion VIBBER: bump version to 47 (2.0-alpha-2014-05-10) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/132677 [13:22:42] (03CR) 10Brion VIBBER: [C: 032] "self-merge ;)" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/132677 (owner: 10Brion VIBBER) [13:22:59] c’mon jenkins do your thing [13:23:01] meanwhile i’ll build ;) [13:23:15] (03Merged) 10jenkins-bot: bump version to 47 (2.0-alpha-2014-05-10) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/132677 (owner: 10Brion VIBBER) [13:23:47] brion: :) [13:24:48] uploading... [13:25:01] the wifi has been surprisingly decent this time round [13:25:07] past hackathons have been …. not always so good ;) [13:25:37] brion: yeah. [13:25:41] brion: lots of traffic shaping [13:25:52] brion: gzip for dynamicproxy just got merged as well [13:26:26] nice [13:43:03] brion: the dynamicproxy also does SPDY! [13:43:08] \o/ [13:43:50] brion: it is currently SPDY/2 but will be SPDY/3 in a few hours [13:44:39] how… speedy! [13:45:22] brion: :) [13:46:23] brion: and the wikidata patch that would let us use it for search is also getting some work done [13:47:53] awesome sauce [13:48:41] gotta find power… [14:24:39] Maryana: ! you are alive! :D [14:31:20] heh, yes [14:40:30] YuviPanda: are you available for a little andriod design sprinting? [14:41:40] Maryana: yes! [14:41:45] Maryana: where are you guys? [14:42:09] tables near the food/coffee in the front [14:42:32] i'm gonna run up to my room & get my android phone, but moiz is here [14:44:00] Maryana: alright. I just broke all of labs webservices, so I'll be back in about 2-5 mins [15:36:27] 3MobileFrontend / 3Feature requests: Allow feedback for mobile beta features like Desktop - 10https://bugzilla.wikimedia.org/65078 (10Sam Reed (reedy)) p:5Unprio>3Normal s:5normal>3enhanc [15:39:13] 3MobileFrontend / 3General/Unknown: Show what features are included in Beta and Experimental on mobile. - 10https://bugzilla.wikimedia.org/65079 (10Sam Reed (reedy)) s:5normal>3enhanc [16:21:27] 3MobileFrontend / 3General/Unknown: Device detection code doesn't detect MSIE 11 - 10https://bugzilla.wikimedia.org/65118#c4 (10Max Semenik) Note that the DeviceDetection.php code from this bug report is outdated as we don't have that check anymore and mobileness check stll works properly as IE mobile 11's U... [19:42:35] (03CR) 10JGonera: [C: 04-1] Hygiene: Sensible defaults for textarea elements (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/131881 (owner: 10Jdlrobson) [22:01:59] 3MobileFrontend / 3Feature requests: Adds specific support for ProofreadPage Page: namespace - 10https://bugzilla.wikimedia.org/65165 (10Tpt) 3NEW p:3Unprio s:3normal a:3None The current MobileFrontend editor displays a simple text area with the raw content serialization, allowing users to break cont... [22:05:27] 3MobileFrontend / 3Feature requests: Adds specific support for ProofreadPage Page: namespace - 10https://bugzilla.wikimedia.org/65165#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/e5IPWl6D