[01:07:27] 3MobileFrontend / 3Feature requests: Adds specific support for ProofreadPage Page: namespace - 10https://bugzilla.wikimedia.org/65165#c2 (10Jon) Tpt and I will hopefully fix this at the hackathon tomorrow! [04:16:36] (03Abandoned) 10Besi: Fix typos [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/125684 (owner: 10Besi) [09:40:12] 3Wikipedia App / 3Generic: No error message(s) for wrong log-in credentials - 10https://bugzilla.wikimedia.org/63952 (10Maryana Pinchuk) 5NEW>3RES/FIX [09:49:16] awjr, https://gerrit.wikimedia.org/r/#/c/132749/ [09:52:08] jgonera: in https://gerrit.wikimedia.org/r/#/c/132749/3/puppet/modules/python/manifests/pil.pp i think you can get rid of lines 11 and 12 [09:54:51] awjr, Could not find dependency Package[libfreetype6-dev] for Package[PIL] at /tmp/vagrant-puppet-3/modules-0/python/manifests/pil.pp:35 [09:55:02] hmm sec [09:56:30] jgonera: actually im having problems provisioning as is [09:56:42] awjr, what is the error? [09:57:58] jgonera: it's not finished yet but what im seeing so far is: [09:58:02] err: /Stage[main]/Role::Confirmedit/Exec[generate FancyCaptcha images]/returns: change from notrun to 0 failed: echo "hello\nworld\n" > /tmp/words; mkdir ../../images/temp/captcha; python captcha.py --font=/usr/share/fonts/truetype/ttf-dejavu/DejaVuSans.ttf --wordlist=/tmp/words --key=FOO --output=../../images/temp/captcha --count=2 returned 1 instead of one of [0] at /tmp/vagrant-puppet-1/manifests/roles/confirmedit.pp:27 [09:58:13] which is fairly vague - i'll let you know what it says when it's done [09:58:17] ok [09:59:20] jgonera: just finished - no better error message but a bunch of stuff didn't run because of failed deps [09:59:32] hm [09:59:52] lemme try running that command manually [10:00:47] jgonera: it may be because of the relative path [10:00:55] after mkdir [10:01:12] why would that be? that's what cwd is for in exec {} isn't it? [10:01:33] jgonera: oh duh [10:01:48] jgonera: another possibility is that it's running before the extension and captcha.py is installed [10:02:25] awjr, yes, that's it ;) [10:02:30] thanks [10:02:59] jgonera: np - it's confusing to me that things don't necessarily go in order [10:03:30] awjr, no, it's my fault, I made exec the requirement for extension which doesn't make sense [10:03:39] it worked for me because I already had the extension [10:03:58] :p [10:08:21] awjr, try now [10:08:25] * awjr looks [10:09:24] jgonera: i think it's still possible for that stuff to fire out of order [10:09:49] awjr, how do I ensure "after" order? can I put require in exec{} ? [10:09:54] let me check [10:10:12] er not positive although i think i did it yesterday - lemme see [10:10:58] jgonera: i used 'before' in an exec statement yesterday to make sure it happened before something else, presumably 'after' will work too [10:11:19] awjr, nope, tried, "after" doesn't exist [10:11:27] I'll ask ori later [10:14:27] jgonera: maybe 'before' should go in the extension declaration [10:15:10] jgonera: http://docs.puppetlabs.com/references/latest/metaparameter.html [10:15:14] er http://docs.puppetlabs.com/references/latest/metaparameter.html#before [10:16:09] so i think you can use that with any resource since 'before' is a metaprametr [10:16:57] thanks, can you check if that works now? [10:20:36] oh jgonera also, you need -p in the mkdir [10:20:40] otherwise it will fail [10:20:52] -p? [10:21:15] right [10:21:16] jgonera: yeah, it makes sure all the necessary parent directories get created, because otherwise it will fail if ../images/temp don't exist [10:21:33] then i think it should work [10:24:01] jgonera: brb gonna grab more coffee [10:26:44] jgonera: b [10:29:30] jgonera: i just amended your commit [10:29:40] awjr, with -p? I just did that too [10:29:46] :p [10:30:12] sorry for the collision [10:30:27] ok jgonera provisioning it now works for me [10:30:43] cool, thanks awjr! does captcha work on create account? [10:30:48] checking [10:31:06] derp one sec my config is fubard [10:32:31] jgonera: yep i see the captcha :D [10:32:40] hurray! [10:33:10] ergh i hate those captchas [10:33:13] i can never read them [10:33:25] yay ok it all works, merging now [11:56:48] (03PS1) 10Jdlrobson: Allow other extensions/modules to tweak the editor [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/132798 [11:57:29] (03PS2) 10Jdlrobson: Remove unused image [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/132354 (owner: 10JGonera) [11:57:35] (03CR) 10Jdlrobson: [C: 032] Remove unused image [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/132354 (owner: 10JGonera) [11:58:16] (03Merged) 10jenkins-bot: Remove unused image [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/132354 (owner: 10JGonera) [12:04:13] (03PS2) 10Jdlrobson: Allow other extensions/modules to tweak the editor [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/132798 [12:17:59] (03PS3) 10Jdlrobson: Allow other extensions/modules to tweak the editor [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/132798 (https://bugzilla.wikimedia.org/65165) [12:19:25] YuviPanda: !!! [12:19:26] YuviPanda: !!! [12:19:26] YuviPanda: !!! [12:19:26] YuviPanda: !!! [12:19:27] YuviPanda: !!! [12:19:30] YuviPanda: !!! [12:19:32] YuviPanda: !!! [12:19:34] YuviPanda: !!! [12:19:35] Reedy: what did I do now [12:19:36] YuviPanda: !!! [12:19:38] YuviPanda: !!! [12:19:41] YuviPanda: !!! [12:19:43] License Certificate LC-583652-D367487107 for IntelliJ IDEA [12:19:47] OMG [12:19:49] WOOOOOO [12:19:53] !!!!! [12:19:55] !!!!!!!! [12:19:57] !!! [12:19:59] !!!!!!! [12:20:01] !! [12:20:25] sent [12:20:48] Reedy: ty! [12:21:19] NO USE LICENSE KEY! USE OPEN SORES [12:27:50] what happened? [13:07:15] 3MobileFrontend / 3Feature requests: Adds specific support for ProofreadPage Page: namespace - 10https://bugzilla.wikimedia.org/65165 (10Sam Reed (reedy)) s:5normal>3enhanc [14:03:35] (03CR) 10Jdlrobson: Hygiene: Sensible defaults for textarea elements (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/131881 (owner: 10Jdlrobson) [14:05:48] (03CR) 10Jdlrobson: Hygiene: Sensible defaults for textarea elements (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/131881 (owner: 10Jdlrobson) [14:06:47] (03CR) 10Jdlrobson: "My plan is this would be semantic - see FIXME in commit summary. Hence this is a WIP. I'm currently trying to make more sense of the patte" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/131883 (owner: 10Jdlrobson) [16:32:58] 3Wikipedia App / 3Generic: Viewing TOC of an nonexistent page crashes the app - 10https://bugzilla.wikimedia.org/65112#c2 (10Dmitry Brant) Related to (and will be fixed by) bug 64774. [17:56:45] 3MobileFrontend / 3beta: Mobilefrontend: Table of contents - expand clickable area - 10https://bugzilla.wikimedia.org/65201 (10Quiddity) 3NEW p:3Unprio s:3enhanc a:3None Created attachment 15348 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15348&action=edit screenshot of clickable area In... [18:00:28] 3MobileFrontend / 3beta: Mobilefrontend: Table of contents - expand clickable area - 10https://bugzilla.wikimedia.org/65201#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/txPVJEGy [18:04:30] 3MobileFrontend / 3stable: Byte diff on usercontribs page is far away from correct values sometimes - 10https://bugzilla.wikimedia.org/65202 (10Liangent) 3NEW p:3Unprio s:3normal a:3None See my contribution list [18:05:28] 3MobileFrontend / 3stable: Byte diff on usercontribs page is far away from correct values sometimes - 10https://bugzilla.wikimedia.org/65202#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/RRs2awiZ [18:10:28] 3MobileFrontend / 3stable: "Desktop" in footer of Special:Contributions/foo points to [[foo]] - 10https://bugzilla.wikimedia.org/65203#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/OpS6WQZc