[02:44:57] <wikibugs>	 3MobileFrontend / 3General/Unknown: mobile contributions change numbers sometimes don't make sense - 10https://bugzilla.wikimedia.org/64867#c3 (10Max Semenik) *** Bug 65202 has been marked as a duplicate of this bug. ***
[02:44:57] <wikibugs>	 3MobileFrontend / 3stable: Byte diff on usercontribs page is far away from correct values sometimes - 10https://bugzilla.wikimedia.org/65202#c2 (10Max Semenik) 5NEW>3RES/DUP   *** This bug has been marked as a duplicate of bug 64867 ***
[13:44:05] <wikipedia-github>	 [13WikipediaMobile] 15siebrand pushed 1 new commit to 06master: 02http://git.io/uYSUhQ
[13:44:05] <wikipedia-github>	 13WikipediaMobile/06master 146618dc2 15Siebrand Mazeland: Localisation updates from https://translatewiki.net.
[14:04:33] <grrrit-wm1>	 (03CR) 10Jdlrobson: [C: 04-1] Fix username handling on Special:Uploads (033 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/132518 (https://bugzilla.wikimedia.org/65094) (owner: 10MaxSem)
[14:05:23] <grrrit-wm1>	 (03CR) 10Jdlrobson: "Aside from my comments the one big problem with this patchset is a change in behaviour. Previously going to Special:Uploads whilst anonymo" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/132518 (https://bugzilla.wikimedia.org/65094) (owner: 10MaxSem)
[14:36:26] <grrrit-wm1>	 (03CR) 10Jdlrobson: "(Note this should probably copy Special:Watchlist for anon workflow)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/132518 (https://bugzilla.wikimedia.org/65094) (owner: 10MaxSem)
[14:37:28] <grrrit-wm1>	 (03CR) 10Jdlrobson: [C: 031] "LGTM will leave to MaxSem to get deciding vote." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/132586 (https://bugzilla.wikimedia.org/46745) (owner: 10Jjanes)
[14:38:02] <grrrit-wm1>	 (03CR) 10Jdlrobson: [C: 032] Fix mobileview parameter description [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/132325 (https://bugzilla.wikimedia.org/65035) (owner: 10MaxSem)
[14:38:41] <grrrit-wm1>	 (03Merged) 10jenkins-bot: Fix mobileview parameter description [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/132325 (https://bugzilla.wikimedia.org/65035) (owner: 10MaxSem)
[14:45:05] <grrrit-wm1>	 (03CR) 10Jdlrobson: [C: 04-1] "Something smells fishy here - why does this happen and why are we preventing horizontal scrolling all the time?" (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/132356 (owner: 10JGonera)
[14:51:44] <wikibugs>	 3MobileFrontend / 3stable: action=mobileview live & doc mismatch - 10https://bugzilla.wikimedia.org/65035 (10Jon) 5PAT>3RES/FIX
[15:11:47] <grrrit-wm1>	 (03CR) 10Dbrant: [C: 031] "Looks like it works correctly; however, we need to update the json api library in the Maven repo, otherwise the app fails to compile." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/131246 (owner: 10Dr0ptp4kt)
[15:11:57] <yurikR2>	 MaxSem, we have a big problem with forceHttps. Someone who logs in on their device, and later switches to zero.wikipedia.org will automatically switch to https which we don't support. Would it be ok to simply remove forceHttps cookie if the user comes to zero domain? Any other thoughts?
[15:12:32] <MaxSem>	 ignore instead of removing?
[15:12:49] <yurikR2>	 i was thinking of that, but we need to redirect to http as well
[15:13:37] <MaxSem>	 that would require varnish tweaks?
[15:13:54] <yurikR2>	 does varnish know about forceHttps? (checking...)
[15:14:22] <MaxSem>	 sorry I'm having breakfast atm, not very functional yet:)
[15:14:50] <yurikR2>	 MaxSem, sorry to wake u :)
[15:15:07] <yurikR2>	 varnish knows about forcehttps only as much as varying cache on it
[15:15:11] <MaxSem>	 that jerk called alarm watch did that:)
[15:15:18] <yurikR2>	 clock
[15:15:31] <yurikR2>	 happens
[15:27:22] <yurikR2>	 MaxSem, forceHTTPS is checked in main(), before anything else gets done
[15:27:45] <OuKB>	 blehh
[15:27:54] <OuKB>	 thats bad
[15:28:28] <yurikR2>	 yeah
[15:29:07] <yurikR2>	 if http & $request->getCookie( 'forceHTTPS', '' ) || $request->getCookie( 'forceHTTPS' ) || ($this->context->getUser()->isLoggedIn() && $this->context->getUser()->requiresHTTPS()))
[16:06:12] <dbrant>	 what's up, bearND!
[16:07:29] <bearND>	 dbrant: hello
[16:08:32] <dbrant>	 bearND: welcome! how is your setup going?
[16:11:32] <bearND>	 dbrant: got gerrit set up, repo cloned, installing sdk again since i switched to a new machine
[16:13:56] <dbrant>	 bearND: very good! Always feel free to ask us any questions.
[16:14:17] <dbrant>	 bearND: will you be coming to SF the week of the 26th? (I'll be there too)
[16:14:49] <bearND>	 dbrant: yes, i'll be there that week, too :)
[16:16:06] <dbrant>	 bearND: and you're UTC-7, right?
[16:17:36] <bearND>	 dbrant: currently UTC-6
[16:17:48] <dbrant>	 ah that's right
[16:18:06] <dbrant>	 I'm -4
[16:18:38] <bearND>	 dbrant: good to know
[16:26:19] <bearND>	 dbrant: are you still on maven 3.1.1?
[16:26:52] <YuviPanda>	 hey dbrant, bearND
[16:27:06] <dbrant>	 YuviPanda: hello!
[16:27:24] <bearND>	 YuviPanda: hello!
[16:28:01] <YuviPanda>	 :D
[16:28:06] <YuviPanda>	 bearND: welcome! :)
[16:28:17] <dbrant>	 bearND: not sure about the version. probably a question for Yuvi
[16:28:24] <YuviPanda>	 I'm in the hostel lobby in Zurich.
[16:28:33] <dbrant>	 nice
[16:28:45] <bearND>	 YuviPanda: thanks!
[16:28:49] <YuviPanda>	 so I'll probably get kicked out in a few hours, but I'll be around till then
[16:28:55] <YuviPanda>	 bearND: yeah, I'm still on 3.1.1
[16:29:05] <bearND>	 sounds good
[16:30:59] <dbrant>	 YuviPanda: how do we update packages in our maven repo? (e.g. the json api package)
[16:31:16] <YuviPanda>	 dbrant: terribly.
[16:31:32] <dbrant>	 awesome!
[16:31:34] <YuviPanda>	 dbrant: they are on tools.wmflabs.org
[16:31:47] <YuviPanda>	 dbrant: and I push them whenever we change versions
[16:32:53] <dbrant>	 well, dr0ptp4kt's latest patch is dependent on updating the json api...
[16:33:01] <YuviPanda>	 yeah
[16:33:05] <YuviPanda>	 I'm looking at my local setup
[16:33:16] <YuviPanda>	 s/at/for/
[16:33:36] <YuviPanda>	 dbrant: WMF has an archiva install, we should move to it at 'some point'
[16:33:44] <YuviPanda>	 bearND: how's the day been so far? quiet? :)
[16:33:53] <YuviPanda>	 HR will wake up and potentially give you some paperwork, I think.
[16:34:14] <YuviPanda>	 saw you've been working on getting everything setup
[16:34:37] <YuviPanda>	 dbrant: bearND we also have a free IntelliJ Ultimate Open Source License, so let me know if you guys want it
[16:35:29] <bearND>	 YuviPanda: quiet so far. i'll have a couple of meetings in the PM; yes, i'd like that IntelliJ Ultimate Open Source license very much. ty 
[16:35:38] <YuviPanda>	 bearND: :D
[16:36:20] <YuviPanda>	 bearND: dbrant sent!
[16:37:31] <bearND>	 YuviPanda: got it. ty
[16:37:47] <dbrant>	 yay
[16:37:48] <YuviPanda>	 bearND: :)
[16:37:54] <YuviPanda>	 all thanks to Reedy :)
[16:41:10] <YuviPanda>	 bearND: have you checked out our gerrit setup?
[16:41:54] <bearND>	 YuviPanda: yes, i'm in gerrit and have cloned the android repo
[16:42:03] <YuviPanda>	 bearND: coool!
[16:42:27] <YuviPanda>	 bearND: I'll start the process to add you to the appropriate ldap group so you can get the appropriate perms
[16:42:40] <YuviPanda>	 bearND: we have a checkstyle running via Jenkins-bot, but it isn't passing yet
[16:43:49] <bearND>	 YuviPanda: great. when submitting changes, do we add reviewers manually?
[16:44:07] <YuviPanda>	 bearND: there's a tool that does it automatically, but that seems a bit broken
[16:44:54] <Deskana>	 Ahh, hello bearND. :)
[16:45:07] <Deskana>	 Welcome!
[16:45:08] <YuviPanda>	 hello, Mr. Garry Sir!
[16:45:19] <bearND>	 Deskana: hello :)
[16:45:54] <Deskana>	 Hey YuviPanda.
[16:46:02] <YuviPanda>	 Deskana: still in Zurich
[16:46:34] <Deskana>	 YuviPanda: When do you head to my fine country?
[16:46:49] <YuviPanda>	 Deskana: tomorrow afternoon
[16:47:03] <YuviPanda>	 Deskana: flying to edinbrough
[16:47:07] <YuviPanda>	 (sp?)
[16:47:12] <Deskana>	 Edinburgh.
[16:47:22] <Deskana>	 Close. You spelt it more like it's pronounced. :)
[16:47:37] <YuviPanda>	 bearND: https://www.mediawiki.org/wiki/Git/Reviewers is the source for the tool.
[16:47:40] <YuviPanda>	 Deskana: woo!
[16:48:19] <Deskana>	 Edinburgh is lovely. Very majestic.
[16:48:29] <Deskana>	 A little surreal in that regard.
[16:48:42] <YuviPanda>	 Deskana: I'm going to be only passing through, though.
[16:48:47] <Deskana>	 Ah, shame.
[16:48:51] <YuviPanda>	 Deskana: will get picked up and get to Glasgow very quickly
[16:49:04] <YuviPanda>	 Deskana: but there are lots of weekend parties around, and who knows where there are.
[16:49:07] <Deskana>	 Actually, I had a recommendation for you...
[16:49:33] <Deskana>	 When you're in Glasgow you should go to a restaurant called Kama Sutra on Sauchihall Street.
[16:49:37] <Deskana>	 It's... interesting. :P
[16:50:03] <Deskana>	 You can taste what we think Indian food is, for real!
[16:50:12] * dbrant  jots that down for future reference

[16:50:27] <Deskana>	 Although, ahem, Manchester is where the really good Indian food is, of course.
[16:53:02] <grrrit-wm1>	 (03PS1) 10Dbrant: Fixed crash when fragment is detached from Activity. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/132955 (https://bugzilla.wikimedia.org/64493) 
[16:53:50] <Deskana>	 YuviPanda: Let me know what you think of Glasgow, anyway! I'm thrilled you're getting to explore my country.
[16:54:02] <Deskana>	 YuviPanda: Although the Scots would probably take issue with me describing Scotland as "my country", but whatever.
[16:54:47] <Deskana>	 I did have a few of them say "Welcome to my country!" last time I was there, and I resisted the temptation to say "Thank you. Welcome to mine!"
[16:56:22] <Deskana>	 Hmm, we should probably update https://www.mediawiki.org/wiki/Mobile
[16:56:42] <Deskana>	 Because I can just see bearND going there and not knowing who everyone is. :)
[16:56:57] <YuviPanda>	 hehe
[16:57:02] <YuviPanda>	 Deskana: PM! :)
[16:57:14] * Deskana  goes and does this.

[16:57:29] <YuviPanda>	 Deskana: :D I'll probably end up spending like a month there in August, and mostly in London
[16:57:39] <YuviPanda>	 Deskana: hehe :)
[16:57:42] * Deskana  shudders.

[16:57:44] <Deskana>	 Glasgow >> London
[16:57:52] <YuviPanda>	 Deskana: haha. I can split my time as well.
[16:57:55] <Deskana>	 Good!
[16:57:57] <YuviPanda>	 Deskana: probably will. cheaper that way.
[16:58:15] <Deskana>	 If you're getting the train, book your train tickets as far in advance as possible.
[16:58:16] <YuviPanda>	 dbrant: planning on going to Glasgow? :)
[16:58:26] <Deskana>	 You can save like £100 each way that way. I wish I was kidding.
[16:58:44] <YuviPanda>	 Deskana: my train from Glasgow to London for my flight in 2 weeks was booked a month and a half ago
[16:58:50] <dbrant>	 YuviPanda: I would love to, at some point.  I've only been to London and Dublin.
[16:58:50] <Deskana>	 Good! How much was it?
[16:58:58] <YuviPanda>	 Deskana: 30 something?
[16:59:04] <Deskana>	 That's pretty good.
[16:59:20] <YuviPanda>	 dbrant: :D I'll let you know how it is! :)
[16:59:36] * Deskana  is an Irish citizen and has never been to Dublin. :(

[17:00:04] <dbrant>	 ha!
[17:00:24] <YuviPanda>	 dbrant: bearND heard you guys are gonna be in SF soon!
[17:00:58] <dbrant>	 yep, for the (short) week of Memorial Day
[17:01:11] <bearND>	 YuviPanda: we'll be there in mar 27
[17:01:18] <bearND>	 on
[17:01:20] <YuviPanda>	 cool
[17:01:33] <YuviPanda>	 I'll sadly not make it this time, but I'm sure we'll figure out a way to meet in person at some point!
[17:01:52] <bearND>	 bummer
[17:02:04] <YuviPanda>	 yeah
[17:02:27] * Deskana  finds out when Memorial Day is.

[17:02:35] <Deskana>	 Oh!
[17:02:43] <tfinc>	 good morning all 
[17:02:45] * tfinc  waves at bearND

[17:02:48] <Deskana>	 dbrant: Really? You'll be in SF when I'm in Ohio? :P
[17:02:57] <bearND>	 tfinc: good morning :)
[17:02:57] <tfinc>	 bearND: is YuviPanda treting you well ?
[17:03:05] <Deskana>	 I get back to SF on Wed 28 May.
[17:03:05] <YuviPanda>	 bearND: oh, I just realized the auto reviewer adding bot isn't broken, but I mistyped the repo name!
[17:03:07] * YuviPanda  fixes

[17:03:13] <Deskana>	 Morning tfinc.
[17:03:42] <tfinc>	 bearND: glad to have you on board. standup is at 10:15. feel free to join us if you don't have anything HR related then
[17:04:09] <dbrant>	 Deskana: ah, I thought you said you'd be in Ohio next Wed?
[17:04:10] <tfinc>	 bearND: msg me if you need anything. i'll leave you in YuviPanda and dbrant capable hands and we'll check in in the afternoon 
[17:04:20] <YuviPanda>	 :) cya in a bit, tfinc
[17:04:28] <bearND>	 tfinc: yes, YuviPanda is treating me well. will join standup in a few, thanks for reminding me. HR meeting is in the PM
[17:04:30] * tfinc  finalizes bearND announce message 

[17:04:34] <Deskana>	 dbrant: I'm flying this Wednesday and I'll be there for two weeks. :)
[17:04:41] <tfinc>	 YuviPanda: hows is Zurich ?
[17:04:43] <tfinc>	 is/was
[17:04:49] <YuviPanda>	 tfinc: yeah, I can start on the LDAP setup after you send the email
[17:04:51] <YuviPanda>	 tfinc: very pretty!
[17:05:03] <dbrant>	 Deskana: right; so we'll overlap
[17:05:10] <Deskana>	 Yeah. I just find it funny. :P
[17:05:12] <YuviPanda>	 tfinc: and very useful / good. Won't get much time to enjoy it, but spent some time with juliusz walking around today. Going to Glasgow tomorrow morning
[17:09:12] <tfinc>	 ok sent
[17:09:15] <tfinc>	 YuviPanda: --^
[17:09:20] <YuviPanda>	 sweet.
[17:09:25] <tfinc>	 YuviPanda: are you still in Zurich or have you moved on to a new location ?
[17:09:36] <YuviPanda>	 tfinc: zurich tonight. Glasgow tomorrow morning
[17:09:48] <tfinc>	 YuviPanda: thanks for prepping https://etherpad.wikimedia.org/p/bernd-onboarding
[17:10:28] <tfinc>	 YuviPanda: it looks pretty similar to the list we wrote for dbrant, any changes ?
[17:10:55] <YuviPanda>	 tfinc: swapped people around, but other than that nothing.
[17:12:28] <tfinc>	 ok
[17:12:40] <tfinc>	 YuviPanda: can you update the designers on https://www.mediawiki.org/wiki/Wikimedia_Apps/Team#Who.27s_on_the_team ?
[17:13:26] <Deskana>	 tfinc: I'm actually in the process of updating the stuff on mediawiki.org.
[17:13:26] <Deskana>	 tfinc: Just sending a few emails relating to this sprint first.
[17:13:39] <YuviPanda>	 tfinc: yeah, Deskana is on it
[17:15:10] <tfinc>	 Deskana: k
[17:16:37] <tfinc>	 dbrant: YuviPanda waiting for you on the hangout
[17:16:59] <tfinc>	 Deskana: joining us ?
[17:17:18] <Deskana>	 tfinc: I don't have anything on my calendar. :/
[17:17:27] <Deskana>	 tfinc: Send me an invite? I'll run to my PC.
[17:17:39] <tfinc>	 Deskana: fixed
[17:27:55] <YuviPanda>	 tfinc: yeah, 2 more mins I thought.
[17:28:47] <tfinc>	 YuviPanda: we missed you
[17:28:52] <tfinc>	 YuviPanda: please mail in your sttus
[17:28:56] <tfinc>	 status*
[17:29:26] <tfinc>	 YuviPanda: not if we finish early and given our team size i have to keep us on task :)
[17:29:32] <YuviPanda>	 tfinc: damn. TZ confusion because of the +0530
[17:29:44] <YuviPanda>	 I thought it was 7:30 PM
[17:29:46] <YuviPanda>	 damn
[17:29:51] <YuviPanda>	 tfinc: I will
[17:30:25] <tfinc>	 bearND: i'll need you to create an account on trello.com .. you can use your wmf google account
[17:30:30] <tfinc>	 YuviPanda: time zone math is hard
[17:30:58] <tfinc>	 YuviPanda: but thankfully you'll be able to demonstrate to bearND what happens when someone misses a standup 
[17:31:54] <YuviPanda>	 tfinc: hah! :)
[17:32:06] <YuviPanda>	 tfinc: I'll be in a *different* timezone tomorrow. god help me.
[17:32:22] <YuviPanda>	 tfinc: and it'll only be *slightly* different as well (+1 instead of +2)
[17:32:28] <tfinc>	 YuviPanda: make sure you prep dbrant|lunch if you need any extra coverate for bearND
[17:32:34] <YuviPanda>	 tfinc: yeah, I'll do.
[17:32:47] <YuviPanda>	 tfinc: bearND has a lot of Gerrit experience already so the tough part is taken care of :)
[17:32:56] <tfinc>	 bearND: then you know the pain 
[17:33:13] <tfinc>	 YuviPanda: let gcal do you math for you
[17:34:08] <dfoy>	 yurik: ping
[17:34:31] <YuviPanda>	 tfinc: yeah, I am. I even saw the invite on my phone when I was out, but my brain somehow converted 7:15 to 7:30 pm. I'll be more careful next time
[17:34:33] <bearND>	 tfinc: i created a trello account with my WMF email this morning but i could only see the public boards
[17:34:41] <tfinc>	 "do you math" ... wow ... i should get breakfast if my grammar is this bad in the morning 
[17:35:10] <tfinc>	 bearND: what's the name of it? if you add an image it'll be faster to find
[17:35:24] <tfinc>	 there are a lot of bernd?? on trello 
[17:35:33] <YuviPanda>	 too many bernds on the trello!
[17:35:56] <tfinc>	 Deskana: with monte and brion out moving on iOS will be tricky 
[17:36:09] <Deskana>	 tfinc: Yeah. :/
[17:36:14] <bearND>	 berndsitzmann2
[17:36:17] <tfinc>	 we may have to revise depending on how he feels in the afternoon
[17:36:42] <Deskana>	 tfinc: That said, in some ways, we have a little more wiggle room with the iOS redesign than the Android one since we've got two sprints after this one before release, as opposed to Android which only has one.
[17:37:01] <tfinc>	 bearND: you're now on the current, previous, and backlog boards 
[17:37:12] <Deskana>	 tfinc: If Monte doesn't get better then I'll break move some cards to sprint 32.
[17:37:28] <tfinc>	 the previous will get closed today but i want to show you what it looks like when its done 
[17:37:50] <tfinc>	 bug_ello has been moved to sprint 31 
[17:38:01] <YuviPanda>	 nice
[17:38:07] <bearND>	 my trello picture is up now
[17:38:11] <YuviPanda>	 tfinc: no estimation happened for this sprint. should we schedule something?
[17:38:19] <tfinc>	 Deskana: we'll create the sprint 32 board after 30 is closed 
[17:38:24] <tfinc>	 i like to make one contingent on the other
[17:38:33] <tfinc>	 we *only* ever have 3 boards going 
[17:38:51] <Deskana>	 tfinc: Sounds good! Just finished reorganising a page on mediawiki.org so I'll look at sprint 30 now.
[17:38:58] <tfinc>	 YuviPanda: we met thursday and estimated everything minus bugs 
[17:39:01] <Deskana>	 Apologies for my slowness. Still settling into the process.
[17:39:08] <YuviPanda>	 tfinc: oh? Android too?
[17:39:11] <tfinc>	 bugs are not estimated. they are a drag on velocity 
[17:39:17] <tfinc>	 YuviPanda: correct. dbrant|lunch was there
[17:39:23] <tfinc>	 everything happened as normal
[17:39:30] <dr0ptp4kt>	 yurik, you there?
[17:39:34] <tfinc>	 i should have mailed about he bugs though to call out why they have no point values 
[17:39:36] <YuviPanda>	 tfinc: ah, cool. And lack of bug estimation explains why lot of them don't have numbers
[17:39:38] <tfinc>	 i can if you wane me to
[17:39:42] <tfinc>	 YuviPanda: exactly 
[17:40:02] <YuviPanda>	 tfinc: yeah, that'll be useful I think. lots of new team members
[17:40:46] <YuviPanda>	 bearND: https://lists.wikimedia.org/mailman/listinfo/mobile-l is the mailing list where most of our discussions happen, so please do join :)
[17:40:59] <YuviPanda>	 bearND: it's a public list on mailman.
[17:41:44] <YuviPanda>	 bearND: we also have a private list called mobile-tech that I think tfinc has already put you on. We use that for (missed) standup status, availability, scheduling meetings, etc. It is a private list.
[17:42:46] <tfinc>	 bearND: you should have a mobile-l invite in your inbox 
[17:43:15] <tfinc>	 bearND: and now you have a mobile-tech invite 
[17:43:57] <wikibugs>	 3Wikipedia App / 3Generic: [iOS] On preview app show [EDIT] link and takes me to the api - 10https://bugzilla.wikimedia.org/62571#c2 (10Dan Garry) 5NEW>3RES/WOR Both Monte and I are unable to reproduce this.
[17:43:58] <tfinc>	 YuviPanda: your going to be traveling so pick a time this week that works for bearND and me to go over the teams development process 
[17:44:04] <tfinc>	 and put up the calendar invite
[17:44:07] <tfinc>	 i'm happy to lead
[17:45:43] <YuviPanda>	 tfinc: yeah, I'll do that in about an hour!
[17:46:11] <tfinc>	 YuviPanda: thanks. once that's in place i'll be complete with my adminstrivia 
[17:46:28] <wikibugs>	 3Wikipedia App / 3Generic: The login form, registration form and registration captcha form are not scrollable - 10https://bugzilla.wikimedia.org/64406#c3 (10Dan Garry) I can't reproduce this, as I can't get the pages to display enough content for the content to scroll off the page.  Can you provide a screens...
[17:46:48] <tfinc>	 bearND: i'm going to leave you in dbrant|lunch and YuviPanda hands and we'll check in in the afternoon. feel free to msg me at any time if anything comes up
[17:46:57] <wikibugs>	 3Wikipedia App / 3Generic: iOS: When a page is found via a redirect, viewing the page history should show the history of the target page, not the redirect - 10https://bugzilla.wikimedia.org/64639 (10Dan Garry) 5NEW>3RES/FIX
[17:49:58] <bearND>	 tfinc: YuviPanda: thanks. i'm subscribed to the mobile-l list, i have not received the mobile-tech invite yet
[17:50:35] <bearND>	 oh wait. never mind. i found it
[17:50:43] <Deskana>	 Close one bug, find another...
[17:53:40] <YuviPanda>	 :)
[17:53:53] <YuviPanda>	 bearND: Deskana I'm going to get some food now, I'll be back in 30-45 mins
[17:59:13] <tfinc>	 Deskana: working remote today?
[17:59:37] <Deskana>	 tfinc: Was planning on doing. Not dead set on it though so I can come in if you like.
[18:00:12] <tfinc>	 Deskana: no its fine. at some point i'll want to grab a whiteboard and continuing thinking about annual goals. i did this with maryana last week and want to continue my stream of thought
[18:00:17] <tfinc>	 no rush
[18:00:36] <Deskana>	 Tomorrow? I'm off on Wednesday then I'll be in Ohio.
[18:00:48] <Deskana>	 If tomorrow's no good for you then I'll come in this afternoon.
[18:03:06] <Deskana>	 dbrant: Hey! About https://bugzilla.wikimedia.org/show_bug.cgi?id=65112
[18:03:10] <tfinc>	 Deskana: as long as your calendar is up to date then i can schedule it
[18:03:24] <Deskana>	 tfinc: Sure is. :)
[18:03:28] <Deskana>	 dbrant: I'm really unclear on what Liangent means in this bug. I can't reproduce it.
[18:04:56] <Deskana>	 dbrant: Ahh, I've got it now.
[18:05:27] <dbrant>	 Deskana: ah, typed a paragraph for nothing :)
[18:05:36] <Deskana>	 dbrant: Sorry. :P
[18:06:01] <dbrant>	 Deskana: I'm pretty sure the one I mentioned is related / will fix it
[18:06:58] <wikibugs>	 3Wikipedia App / 3Generic: Viewing TOC of an nonexistent page crashes the app - 10https://bugzilla.wikimedia.org/65112#c3 (10Dan Garry) Steps to reproduce:  1) Use search to go to [[Main page]]. 2) Hammer a load of nonsense into the search bar, then press go. You're taken to a nonexistent page. The ToC butto...
[18:08:17] <Deskana>	 Dbrant: Okay. I'll mark as a duplicate then.
[18:10:27] <wikibugs>	 3Wikipedia App / 3Generic: Viewing TOC of an nonexistent page crashes the app - 10https://bugzilla.wikimedia.org/65112#c4 (10Dan Garry) 5NEW>3RES/DUP This is intricately related to bug 64774 and Dmitry that his patch for that bug will fix this one, so I'm marking this bug as a duplicate so we can track t...
[18:10:42] <wikibugs>	 3Wikipedia App / 3Generic: Android: When overflow menu is disabled due to network error, it stays disabled even on articles it should be usable on - 10https://bugzilla.wikimedia.org/64774#c1 (10Dan Garry) *** Bug 65112 has been marked as a duplicate of this bug. ***
[18:14:37] <Deskana>	 tfinc: Alright, sprint 30 is clear. Now checking the carried over signoff.
[18:17:52] <wikibugs>	 3Wikipedia App / 3Generic: The login form, registration form and registration captcha form are not scrollable - 10https://bugzilla.wikimedia.org/64406#c4 (10Liangent) (In reply to Dan Garry from comment #3) > I can't reproduce this, as I can't get the pages to display enough content > for the content to scro...
[18:19:06] <tfinc>	 Deskana: make sure to prune sprint 31 as its currently 33 points for todo and doing
[18:19:14] <Deskana>	 Wow.
[18:19:16] <tfinc>	 Deskana: check in with Yuvi to find out about the 5 pointer https://trello.com/c/k7oQ2wLr/41-5-complete-page-styling-css-and-move-it-to-extension-mobileapp
[18:19:35] <grrrit-wm1>	 (03PS1) 10Dbrant: Stop blinking cursor after search result selected. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/132966 (https://bugzilla.wikimedia.org/64209) 
[18:19:51] <tfinc>	 dbrant: are you really working on all three of your cards in the doing column ?
[18:20:12] <dbrant>	 tfinc: They're literally 1-2 liners
[18:22:22] <wikibugs>	 3Wikipedia App / 3Generic: Time is calculated incorrectly in contribution list and page footer by subtracting edit timestamp in UTC from device timestamp in local timezone - 10https://bugzilla.wikimedia.org/63962 (10Dan Garry) 5NEW>3RES/FIX
[18:24:11] <Deskana>	 tfinc: Can you link me to the APKs for the old Android app again? I lost the link.
[18:27:34] <tfinc>	 Deskana: releases.wikimedia.org/mobile/android/
[18:27:40] <tfinc>	 https://releases.wikimedia.org/mobile/android/
[18:28:00] <tfinc>	 dbrant: k
[18:29:59] <Deskana>	 tfinc: Sorry, got disconnected. Could you pass me the link? :)
[18:30:16] <tfinc>	 Deskana: your killing me here ... https://releases.wikimedia.org/mobile/android/
[18:30:18] <tfinc>	 :)
[18:30:26] <Deskana>	 AGAIN.
[18:30:28] <Deskana>	 I jest, I jest.
[18:30:43] <Deskana>	 I bookmarked it this time.
[18:30:54] <wikibugs>	 3Wikipedia App / 3Generic: Tapping "play" on <audio> freezes the interface (when the file is being loaded?) - 10https://bugzilla.wikimedia.org/65233 (10Liangent) 3NEW p:3Unprio s:3normal a:3None <video> untested.
[18:31:31] <Deskana>	 tfinc: Thanks. :)
[18:32:24] <wikibugs>	 3Wikipedia App / 3Generic: <audio> overlaps with nearby contents - 10https://bugzilla.wikimedia.org/65234 (10Liangent) 3NEW p:3Unprio s:3normal a:3None <video> untested.  This and the previous bug were observed on [[Sigi Schmid]], at the bottom of the article.
[18:33:26] <Deskana>	 tfinc: Do you know which one of these is the app as it's found on the Play store if you're not in the Beta?
[18:34:26] <tfinc>	 25 (1.3.4) Jan 22, 2013 in Prod
[18:34:28] <tfinc>	 Deskana: should be --^
[18:34:39] <tfinc>	 with a SHA1 of 4104b09c34505325f5795f54cd9edf53a2ff1eaa
[18:34:58] <tfinc>	 thus https://releases.wikimedia.org/mobile/android/Wikipedia-v1.3.4.apk
[18:35:15] <Deskana>	 Yep, got it!
[18:35:15] <Deskana>	 Thanks!
[18:49:12] <Deskana>	 tfinc: Done with signoff, except for the killswitch thing which I want to test in person with Monte.
[18:49:36] <tfinc>	 Deskana: so +5 for sprint 30
[18:50:16] <tfinc>	 thanks
[19:05:57] <grrrit-wm1>	 (03PS1) 10Dbrant: Update overflow menu when back button pressed. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/132976 (https://bugzilla.wikimedia.org/64774) 
[19:16:00] <matanya>	 YuviPanda: i sent you a crash report
[19:22:08] <dbrant>	 matanya: can you cc me?
[19:22:22] <matanya>	 dbrant: sent directly yo YuviPanda 
[19:22:37] <matanya>	 i guess he can reply and add you :)
[19:22:38] <YuviPanda>	 dbrant: I'll forward to OTRS
[19:22:49] <YuviPanda>	 dbrant: check OTRS. There are a good number of 'em, most of them 'done'
[19:23:07] <grrrit-wm1>	 (03CR) 10Yuvipanda: [C: 04-1] "This can happen with any of the asynctasks, not just this one. While doing this for the tasks in this fragment would fix most crashes (and" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/132955 (https://bugzilla.wikimedia.org/64493) (owner: 10Dbrant)
[19:23:09] <matanya>	 the mobile-android queue 
[19:23:37] <matanya>	 dbrant: i think i need to welcome you, no? :)
[19:24:20] <dbrant>	 matanya: sure! thanks
[19:24:34] <matanya>	 best of luck
[19:24:42] <YuviPanda>	 matanya: bearND is our other new Android dev! just joined today :)
[19:24:48] <YuviPanda>	 ragesoss: ^
[19:24:54] <ragesoss>	 ohai
[19:24:59] <YuviPanda>	 bearND: matanya and ragesoss are superawesome testers for the app :)
[19:25:04] <ragesoss>	 bearND: welcome!
[19:25:44] <matanya>	 bearND: welcome!
[19:26:25] <bearND>	 rageoss: matanya: thanks. it's great to be here
[19:26:43] <bearND>	 ragesoss
[19:26:55] <bearND>	 still working on my typing + IRC skills
[19:27:04] <ragesoss>	 :D
[19:27:10] <YuviPanda>	 bearND: great nick, btw :)
[19:27:22] <matanya>	 bearND: tab is your friend 
[19:28:28] <bearND>	 matanya: ah, i see. ty. always good to have more friends ;)
[19:30:14] <bearND>	 YuviPanda: ty. i was looking for something that would help with pronunciation of my first name.
[19:30:31] <YuviPanda>	 bearND: :D I was actually trying to figure that out as well, and was very useful :D
[19:31:23] <YuviPanda>	 bearND: you should get an invite to the staff IRC channel soon
[19:32:18] <bearND>	 YuviPanda: for my previous team I hung up a poster of a teddy bear and added +ND at the end
[19:32:55] <YuviPanda>	 bearND: :D We should make that and make it your staff picture too! :D
[19:33:39] <bearND>	 YuviPanda: i was looking on commons for one, but didn't find anything suitable
[19:33:56] <YuviPanda>	 ragesoss: ^ no teddy bears on commons? we might need to add the ND ourselves tho
[19:35:20] <bearND>	 YuviPanda: there are some but they all look so sad
[19:35:37] <YuviPanda>	 hmm, I need to find Jean-Fred and make him find a happy one
[19:35:44] <YuviPanda>	 he's on a plane right now, I think, though :(
[19:35:49] <YuviPanda>	 bearND: WE WILL MAKE IT HAPPEN!
[19:36:14] <bearND>	 YuviPanda: awesome, thanks
[19:38:47] <YuviPanda>	 ohai moizsyed.
[19:38:53] <YuviPanda>	 moizsyed: happy birthday!
[19:39:03] <moizsyed>	 thanks YuviPanda
[19:39:05] <moizsyed>	 :)
[19:39:09] <YuviPanda>	 moizsyed: :) in SF this quick?
[19:39:14] <YuviPanda>	 also there's a large cat on my keyboard.
[19:39:17] <moizsyed>	 in toronto, right now
[19:39:19] <YuviPanda>	 it is mesmerized by the sounds
[19:39:22] <YuviPanda>	 moizsyed: ah, nice
[19:39:41] <YuviPanda>	 moizsyed: got some sleep?
[19:40:08] <YuviPanda>	 bearND: attempt to join #wikimedia-staff channel?
[19:40:26] <moizsyed>	 YuviPanda: i slept for a few hours on the plane
[19:40:51] <moizsyed>	 cant sleep not, or else i'll be jetlagged 
[19:41:03] <YuviPanda>	 moizsyed: how much longer do you need to be up?
[19:41:28] <grrrit-wm1>	 (03PS2) 10Dbrant: Fixed crash when fragment is detached from Activity. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/132955 (https://bugzilla.wikimedia.org/64493) 
[19:41:47] <moizsyed>	 YuviPanda: its 3:41pm.. so a few hours 
[19:41:55] <YuviPanda>	 moizsyed: ah. watch sharknado!
[19:42:30] <bearND>	 YuviPanda: i've joined #wikimedia-staff
[20:07:59] <matanya>	 bearND: https://commons.wikimedia.org/wiki/File:A_toy_bear.jpg
[20:08:23] <matanya>	 or actually, anything in https://commons.wikimedia.org/wiki/Category:Teddy_bears
[20:14:51] <bearND>	 matanya: https://commons.wikimedia.org/wiki/File:Newer_teddy_bear.jpg
[20:15:12] <matanya>	 even better
[20:41:34] <grrrit-wm1>	 (03PS1) 10Kaldari: Changing 'last edited' to 'last modified' so it is more accurate [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/133020 (https://bugzilla.wikimedia.org/64937) 
[20:49:51] <wikibugs>	 3MobileFrontend / 3stable: Bare Special:Contributions (without subpage) shouldn't be caught by mobile - 10https://bugzilla.wikimedia.org/65039#c2 (10Ryan Kaldari) Can you please describe the behavior you would expect? Should https://en.m.wikipedia.org/wiki/Special:Contributions display the desktop interface?
[20:55:50] <grrrit-wm1>	 (03CR) 10MaxSem: [C: 032] Fix watchlist query to work with PostgreSQL [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/132586 (https://bugzilla.wikimedia.org/46745) (owner: 10Jjanes)
[20:56:25] <grrrit-wm1>	 (03Merged) 10jenkins-bot: Fix watchlist query to work with PostgreSQL [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/132586 (https://bugzilla.wikimedia.org/46745) (owner: 10Jjanes)
[20:57:06] <wikibugs>	 3MobileFrontend / 3Feature requests: MobileFrontend doesn't support PostgreSQL - 10https://bugzilla.wikimedia.org/46745 (10Max Semenik) 5PAT>3RES/FIX
[21:03:06] <wikibugs>	 3MobileFrontend / 3stable: "Desktop" in footer of Special:Contributions/foo points to [[foo]] - 10https://bugzilla.wikimedia.org/65203#c2 (10Ryan Kaldari) This seems to already be fixed in beta labs: http://en.m.wikipedia.beta.wmflabs.org/wiki/Special:Contributions/Kaldari
[21:05:07] <wikibugs>	 3MobileFrontend / 3stable: Mobile view link unexpectedly goes to HTTPS - 10https://bugzilla.wikimedia.org/61358#c15 (10Andre Klapper) (In reply to grant from comment #13) > I'm in the middle of a server change. Give me a day or two.  Grant: Any news?
[21:07:51] <wikibugs>	 3Wikipedia App / 3Generic: iPhone URL protocol handler to open Wikipedia App from Safari - 10https://bugzilla.wikimedia.org/52472#c3 (10Ryan Kaldari) Actually, it's a feature request for Mobile apps.
[21:18:48] <grrrit-wm1>	 (03PS5) 10Kaldari: Repurpose wgMFNearbyNamespace as wgMFContentNamespace [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/131759 (https://bugzilla.wikimedia.org/64543) (owner: 10Jdlrobson)
[21:18:50] <grrrit-wm1>	 (03PS2) 10Kaldari: Use hash for random link [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/131760 (https://bugzilla.wikimedia.org/64924) (owner: 10Jdlrobson)
[21:22:00] <grrrit-wm1>	 (03PS1) 10Yurik: Handle zero.wp forceHTTPS cookie [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/133023 
[21:22:20] <yurik>	 dr0ptp4kt, ^
[21:22:24] <grrrit-wm1>	 (03CR) 10Kaldari: [C: 04-1] "Code also needs to be updated in RandomDrawer.js so that subsequent random pages have the hash instead of query string param." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/131760 (https://bugzilla.wikimedia.org/64924) (owner: 10Jdlrobson)
[21:25:06] <dr0ptp4kt>	 yurik, i'm looking at it
[21:25:14] <yurik>	 thx
[21:49:46] <grrrit-wm1>	 (03CR) 10Kaldari: [C: 04-1] Repurpose wgMFNearbyNamespace as wgMFContentNamespace (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/131759 (https://bugzilla.wikimedia.org/64543) (owner: 10Jdlrobson)
[21:52:25] <grrrit-wm1>	 (03PS6) 10Kaldari: Repurpose wgMFNearbyNamespace as wgMFContentNamespace [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/131759 (https://bugzilla.wikimedia.org/64543) (owner: 10Jdlrobson)
[21:52:43] <grrrit-wm1>	 (03PS3) 10Kaldari: Use hash for random link [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/131760 (https://bugzilla.wikimedia.org/64924) (owner: 10Jdlrobson)
[21:54:46] <YuviPanda>	 MaxSem: hey! find someone to knock https://gerrit.wikimedia.org/r/#/c/109939/ a +2?
[21:55:12] <YuviPanda>	 hey bearND! how's it going? app building ok?
[21:55:29] <MaxSem>	 how 'bout yourself?;P
[21:55:43] <grrrit-wm1>	 (03PS4) 10Kaldari: Use hash for random link [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/131760 (https://bugzilla.wikimedia.org/64924) (owner: 10Jdlrobson)
[21:59:23] <grrrit-wm1>	 (03CR) 10Kaldari: [C: 032] Repurpose wgMFNearbyNamespace as wgMFContentNamespace [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/131759 (https://bugzilla.wikimedia.org/64543) (owner: 10Jdlrobson)
[21:59:56] <grrrit-wm1>	 (03Merged) 10jenkins-bot: Repurpose wgMFNearbyNamespace as wgMFContentNamespace [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/131759 (https://bugzilla.wikimedia.org/64543) (owner: 10Jdlrobson)
[21:59:57] <tfinc>	 YuviPanda: i didn't seen an invite come through for bearND team dev practices training. make sure to add it
[22:00:23] <YuviPanda>	 tfinc: yeah, I was out meeting Juliusz. Let me do the TZ math now
[22:03:35] <YuviPanda>	 tfinc: I did that. I do not know how to schedule a room in the office though. can you do that?
[22:10:32] <grrrit-wm1>	 (03CR) 10Dr0ptp4kt: [C: 032] Handle zero.wp forceHTTPS cookie [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/133023 (owner: 10Yurik)
[22:10:42] <grrrit-wm1>	 (03Merged) 10jenkins-bot: Handle zero.wp forceHTTPS cookie [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/133023 (owner: 10Yurik)
[22:19:11] <grrrit-wm1>	 (03CR) 10MaxSem: "Eww, the login CTA was supposed to stay..." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/132518 (https://bugzilla.wikimedia.org/65094) (owner: 10MaxSem)
[22:19:43] <grrrit-wm1>	 (03CR) 10Kaldari: Hygiene: Sensible defaults for textarea elements (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/131881 (owner: 10Jdlrobson)
[22:21:56] <grrrit-wm1>	 (03PS1) 10Yurik: Handle BeforeHttpsRedirect hook to prohibit HTTP->HTTPS redirect [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/133029 
[22:22:04] <yurik>	 dr0ptp4kt, ^
[22:22:35] <grrrit-wm1>	 (03PS5) 10Kaldari: Use hash for random link [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/131760 (https://bugzilla.wikimedia.org/64924) (owner: 10Jdlrobson)
[22:22:51] <YuviPanda>	 kaldari: think you can take a look at https://gerrit.wikimedia.org/r/#/c/109939/?
[22:23:10] <kaldari>	 sure
[22:24:38] <YuviPanda>	 kaldari: thanks!
[22:39:26] <yurik>	 MaxSem, around?
[22:39:40] <MaxSem>	 yep
[22:39:50] <yurik>	 https://gerrit.wikimedia.org/r/#/c/132952/
[22:39:53] <yurik>	 https://gerrit.wikimedia.org/r/#/c/133029/
[22:40:04] <yurik>	 MaxSem, do you think we can get these patches in today?
[22:40:37] <bearND>	 YuviPanda: R.string.test_username / pwd are not set in the test project. Do you just add them to the string resources of the test project?
[22:41:12] <YuviPanda>	 bearND: they are already there.
[22:41:40] <YuviPanda>	 bearND: I think the problem is that R in this case is importing the wrong R - should be picking up the one from the test project and not the main one
[22:41:57] <MaxSem>	 yurik, there's UserRequiresHTTPS
[22:42:15] <YuviPanda>	 bearND: should be fixed easily, I think. Wanna submit a patch? :)
[22:42:22] <MaxSem>	 andCanIPUseHTTPS
[22:42:36] <bearND>	 YuviPanda: in the test project i only see hello and app_name
[22:42:41] <MaxSem>	 yurik, I think they already do what you want
[22:42:43] <yurik>	 MaxSem, yes, but "user" cannot really exist in zero - we disable it very early on
[22:42:57] <YuviPanda>	 bearND: do you not see a credentials.xml?
[22:43:33] <bearND>	 YuviPanda: yes, there they are
[22:43:42] <yurik>	 MaxSem, https won't go past varnish - it will simply not identify traffic as zero-rated, hence no configuration in the backend, hence auto-redirect to the error page
[22:44:00] <MaxSem>	 well
[22:44:04] <bearND>	 for some reason they didn't get picked up. weird
[22:44:12] <MaxSem>	 we're talking about https://gerrit.wikimedia.org/r/#/c/132952/2/includes/Wiki.php
[22:44:27] <yurik>	 yes
[22:44:37] <grrrit-wm1>	 (03CR) 10Kaldari: mobileview: return editable status (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/109939 (owner: 10MaxSem)
[22:44:52] <MaxSem>	 _before_ you get to run your hook, $this->context->getUser()->requiresHTTPS() already runs another hook
[22:45:23] <YuviPanda>	 kaldari: which PS did you leave a comment on?
[22:45:43] <MaxSem>	 yurik, so I'm asking why another hook is needed?
[22:46:05] <yurik>	 MaxSem, its an "OR"
[22:46:33] <kaldari>	 YuviPanda: patchset 4
[22:47:20] <kaldari>	 YuviPanda: I agree it's really hacky and wonder if it would be worth modifying core rather than doing it this way.
[22:47:43] <MaxSem>	 hmm, I wonder if this condition can be tweaked...
[22:48:45] <yurik>	 i  wouldn't risk it ;)
[22:48:57] <MaxSem>	 whoa
[22:49:10] <YuviPanda>	 kaldari: we can do that as a separate patch, and file this as a 'bug' in the meantime
[22:49:17] <yurik>	 checking user groups is supposedly expensive
[22:51:21] <YuviPanda>	 Deskana: around?
[22:51:26] <Deskana>	 YuviPanda: Yep.
[22:52:21] <YuviPanda>	 Deskana: re: kill switch. I don't think we should think of it as a permanent solution but more of an emergency hand brake. If shit goes down we pull it, and then re-asses based on why it went down, and then put out a release fixing it. At least that's my understanding. Does that make sense?
[22:52:45] <MaxSem>	 yurik, especially since UserRequiresHTTPS was created with zero in mind...
[22:52:56] <yurik>	 lol :)
[22:52:56] <Deskana>	 YuviPanda: Yep. I'd say don't worry too much about Howie's question. His job is to make sure that we've thought about these things, not necessarily to prescribe stuff to us. :)
[22:53:04] <grrrit-wm1>	 (03CR) 10Kaldari: [C: 04-1] mobileview: return editable status (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/109939 (owner: 10MaxSem)
[22:53:26] <yurik>	 MaxSem, here, the goal is to prohibit https, rather than require it
[22:53:39] <YuviPanda>	 Deskana: cool. Just didn't want to get dragged into a deeper hole where we tried to anticipate every outcome
[22:53:47] <Deskana>	 YuviPanda: I'll relay what you've said to him.
[22:53:54] <YuviPanda>	 Deskana: ty
[22:54:02] <MaxSem>	 yeah, and I introduced this hook specifically for that... :P
[22:55:45] <yurik>	 hmm.. ok, the CanIPUseHTTPS hook does IP check, which is useless for us (varnish does that work)
[22:56:41] <Deskana>	 YuviPanda: Would it be hard to display a message to the user if they start up the app and the kill switch is active? Either once (preferably), or more frequently?
[22:57:01] <YuviPanda>	 Deskana: what kinda message?
[22:57:11] <YuviPanda>	 as in, like, '1 sentence' vs '1 screen'
[22:57:40] <Deskana>	 YuviPanda: "Anonymous editing is temporarily disabled." or something similar.
[22:58:19] <yurik>	 MaxSem, so from my looking at UserRequiresHTTPS, and the code in Wiki, we would have to change it all
[22:58:23] <YuviPanda>	 Deskana: more frequently is easier :) Every time we check for the switch (once a day or so?) we can pop up a small toast somewhere doing that.
[22:58:35] <Deskana>	 YuviPanda: Deal. I'll make a card for that.
[22:58:36] <YuviPanda>	 Deskana: once would be slightly tougher since we'd have to track when it flips
[22:58:47] <MaxSem>	 mmm
[22:58:47] <Deskana>	 Every kill switch check is fine.
[22:58:52] <YuviPanda>	 cool
[22:59:01] <yurik>	 MaxSem, that code does ORs - like if forceHTTPS is set, nothing else is needed
[22:59:29] * MaxSem  bites jdlrobson greetingly

[22:59:32] <yurik>	 so unless we move all that logic into requiresHTTPS()
[22:59:41] <MaxSem>	 yurik, I see your concern...
[22:59:43] <MaxSem>	 meh
[22:59:49] <grrrit-wm1>	 (03PS7) 10Yuvipanda: mobileview: return editable status [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/109939 (owner: 10MaxSem)
[22:59:53] <YuviPanda>	 kaldari: ^
[23:00:25] <yurik>	 it would become "forceProtocol" - which returns either null, http, or https :)
[23:00:35] <yurik>	 MaxSem, ^
[23:00:51] <MaxSem>	 grrr
[23:01:15] <MaxSem>	 cookie checks don't really belong to user
[23:01:26] <MaxSem>	 no point in moving them here
[23:02:19] <yurik>	 well, cookies are the storage behind user identity
[23:04:28] <grrrit-wm1>	 (03CR) 10Yuvipanda: [C: 04-1] "Still seeing the blink" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/132966 (https://bugzilla.wikimedia.org/64209) (owner: 10Dbrant)
[23:06:22] <YuviPanda>	 Deskana: am gonna head off to sleep in about 5 min. lmk if there's anything you need
[23:06:58] <bearND>	 YuviPanda: had to add an import for org.wikimedia.wikipedia.test.R to LoginTaskTest to resolve the string ref (since the test projects AndroidManifest.xml has org.wikimedia.wikipedia.test as the package name)
[23:07:06] <YuviPanda>	 yeah, the * imports
[23:07:10] <yurik>	 MaxSem, i will push out this in a second - any last second objections? https://gerrit.wikimedia.org/r/#/c/133023/1/includes/PageRenderingHooks.php
[23:07:10] <YuviPanda>	 perhaps weren't the best idea
[23:07:32] <YuviPanda>	 bearND: submit a patch? :D
[23:07:40] <bearND>	 YuviPanda: sure
[23:07:46] <MaxSem>	 yurik, ewwwwwwwwwwww
[23:07:49] <Deskana>	 YuviPanda: I was always told it wasn't that bad because the JVM figures out what you're using and what you're not and therefore does it smartly.
[23:07:50] <MaxSem>	 wwwwwwww
[23:07:55] <yurik>	 MaxSem, tell me about it :(
[23:08:03] <Deskana>	 YuviPanda: But if that were true then why not just import *;? :P
[23:08:12] <MaxSem>	 functions with such name shouldn't return anything but bools
[23:08:13] <yurik>	 it gets called from the hack script
[23:08:39] <yurik>	 i know, i was thinking of changing it, but it is being used directly from the entry point hack script
[23:08:46] <yurik>	 so i would have to sync change them
[23:08:50] <YuviPanda>	 Deskana: no, the problem is that there were two classes named 'R', and here it was crashing hard because it was looking for the things in the other R
[23:08:50] <bearND>	 YuviPanda: is it cool if i add a specific class import, like import org.wikimedia.wikipedia.test.R;
[23:08:57] <yurik>	 i will it up
[23:08:57] <YuviPanda>	 bearND: yeah.
[23:09:03] <Deskana>	 YuviPanda: Oh. Right. :P
[23:09:07] <YuviPanda>	 Deskana: woo email! :)
[23:09:23] <yurik>	 MaxSem, check for security issues :)
[23:09:38] <MaxSem>	 NOT SECURE FOR MY BRAIN!
[23:09:51] * YuviPanda  pours the parser on MaxSem

[23:10:08] <MaxSem>	 .me enters the Matrix
[23:10:13] <yurik>	 ooo, i found a backdoor into max's brain!
[23:10:23] <yurik>	 yei... now what would i want to do there ?
[23:11:18] <grrrit-wm1>	 (03PS2) 10Yuvipanda: Update overflow menu when back button pressed. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/132976 (https://bugzilla.wikimedia.org/64774) (owner: 10Dbrant)
[23:12:21] <mutante>	 dbrant: hey, did you already use your access?
[23:12:25] <mutante>	 all good?
[23:13:07] <mutante>	 you should be able to login on bast1001 and jump over to stat1003 and upload releases to caesium, so i had 3 changes
[23:14:07] <YuviPanda>	 Deskana: dbrant bearND am off to sleep! night everyone.
[23:14:15] <Deskana>	 YuviPanda: Night. :)
[23:14:19] <YuviPanda>	 dbrant: can you help with CR when bearND brings up his patch? :)
[23:14:48] <bearND>	 YuviPanda: good night
[23:14:59] <mutante>	 bearND: welcome to wmf as well, that "RT" stuff, you should save it in case you want the ops guys to do stuff in the future:)
[23:15:27] <mutante>	 (well, as long as tools are not replaced)
[23:26:36] <yurik>	 oki, MaxSem, so what have you decided? :)
[23:27:26] <MaxSem>	 yurik, I mostly agree with your code but the new hook check should be in the main condition
[23:27:42] <yurik>	 MaxSem, not sure what you mean
[23:28:09] <MaxSem>	 cuz now you e.g. log that omg redirecting POST to https and then don't actually do that due to hook
[23:29:52] <yurik>	 MaxSem, in other words - move the if (wasposted) inside the wfrunhooks?
[23:31:54] <MaxSem>	 no, move the hook into the main check
[23:33:03] <yurik>	 MaxSem, but than it won't have the target URL
[23:33:06] <yurik>	 not that i need it
[23:33:19] <yurik>	 it becomes a true/false, rather than arbitrary redirect
[23:34:05] <MaxSem>	 eww right
[23:34:11] <MaxSem>	 such a mess
[23:34:20] <yurik>	 meh, i've seen parser
[23:34:37] <MaxSem>	 so just move the logging inside and be done with it
[23:38:48] <yurik>	 MaxSem, https://gerrit.wikimedia.org/r/#/c/132952/
[23:38:49] <yurik>	 :)
[23:40:10] <yurik>	 MaxSem, i would need +2 ;0
[23:40:14] <yurik>	 ;)
[23:40:31] <MaxSem>	 eh
[23:41:05] <grrrit-wm1>	 (03PS1) 10BearND: Add import for test specific R class [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/133038 
[23:41:08] <MaxSem>	 I just felt we need to give people from other teams some time to look at it:)
[23:41:51] <yurik>	 perhaps.
[23:41:58] <yurik>	 will wait until wed on this one i guess
[23:54:25] <grrrit-wm1>	 (03CR) 10Kaldari: [C: 032] mobileview: return editable status [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/109939 (owner: 10MaxSem)
[23:55:00] <grrrit-wm1>	 (03Merged) 10jenkins-bot: mobileview: return editable status [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/109939 (owner: 10MaxSem)
[23:58:53] <grrrit-wm1>	 (03CR) 10Dbrant: [C: 032] Add import for test specific R class [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/133038 (owner: 10BearND)