[00:01:07] Dbrant: thanks for reviewing. getting dinner… [00:01:24] bearND: np; well done! [00:10:06] 3MobileFrontend / 3General/Unknown: Hash gets swallowed (again) - 10https://bugzilla.wikimedia.org/64918#c2 (10Ryan Kaldari) I don't think it's a problem with the hash. If I try it with an h2 header, it works fine. It appears to only fail for sections that are collapsed. [00:23:20] (03CR) 10Kaldari: [C: 032] Ignore $wgMobileUrlTemplate when host is an IP address [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/131736 (owner: 10Yurik) [00:23:42] kaldari, thx [00:23:54] (03Merged) 10jenkins-bot: Ignore $wgMobileUrlTemplate when host is an IP address [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/131736 (owner: 10Yurik) [00:39:21] 3MobileFrontend / 3General/Unknown: MobileFrontend: Trying to create a username with a hash in should present the user with an error - 10https://bugzilla.wikimedia.org/64959#c6 (10Ryan Kaldari) 5NEW>3RES/FIX It now displays the error "You have not specified a valid username." [00:46:19] (03PS1) 10Dr0ptp4kt: Support Zero: namespace API read of configs sans IPs. [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/133039 [00:54:21] 3MobileFrontend / 3General/Unknown: Device detection code doesn't detect MSIE 11 - 10https://bugzilla.wikimedia.org/65118 (10Ryan Kaldari) 5NEW>3RES/WOR [00:57:35] cookies are evil :( [02:24:55] (03PS1) 10Yurik: Fixed domain name for cookie deletion and removed logout [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/133043 [07:47:21] 3MobileFrontend / 3General/Unknown: Device detection code doesn't detect MSIE 11 - 10https://bugzilla.wikimedia.org/65118#c5 (10Liangent) 5RES/WOR>3REO if I read correctly position: fixed check is still not covered. [07:53:06] 3MobileFrontend / 3General/Unknown: MobileFrontend: Trying to create a username with a hash in should present the user with an error - 10https://bugzilla.wikimedia.org/64959#c7 (10Liangent) 5RES/FIX>3REO still not fixed? 20140510 version on live enwiki [08:09:36] 3MobileFrontend / 3stable: Bare Special:Contributions (without subpage) shouldn't be caught by mobile - 10https://bugzilla.wikimedia.org/65039#c3 (10Liangent) maybe desktop form in mobile skin? and after a username is entered show contribs in mobile layout. [14:51:12] (03CR) 10Jdlrobson: [C: 031] "I'm fine with this as long as we check with one of the designers or Maryana before merging. Feel free to +2 when this has happened." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/133020 (https://bugzilla.wikimedia.org/64937) (owner: 10Kaldari) [14:52:14] (03CR) 10Jdlrobson: "(also I just noticed mobile-frontend-last-modified-years already says modified :-))" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/133020 (https://bugzilla.wikimedia.org/64937) (owner: 10Kaldari) [14:53:26] (03CR) 10Anomie: [C: 031] "Code itself looks sane. Haven't tested, and I'm not sure about the implications (e.g. security) with clearing forceHTTPS without logout or" [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/133043 (owner: 10Yurik) [14:59:22] (03CR) 10Jdlrobson: [C: 031] "Kaldari - looks good to me if good to you!" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/131760 (https://bugzilla.wikimedia.org/64924) (owner: 10Jdlrobson) [15:12:33] (03PS1) 10Jdlrobson: Regression: Fix Special:MobileWebApp [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/133080 [15:21:07] 3MobileFrontend / 3General/Unknown: MobileFrontend: Trying to create a username with a hash in should present the user with an error - 10https://bugzilla.wikimedia.org/64959#c8 (10Jon) 5REO>3RES/FIX Works fine for me on master. On desktop and mobile like Kaldari I see I see this locally and on beta labs... [15:43:51] 3MobileFrontend / 3General/Unknown: MobileFrontend: Trying to create a username with a hash in should present the user with an error - 10https://bugzilla.wikimedia.org/64959#c9 (10Liangent) (In reply to Jon from comment #8) > Works fine for me on master. On desktop and mobile like Kaldari I see > > I see th... [15:44:13] ^ how can I test the app against beta labs? [15:45:42] yuvi doesn't like adding a hidden preference item (eg. tweakable by editing xml), in some previous conversation... [15:54:52] 3MobileFrontend / 3General/Unknown: Device detection code doesn't detect MSIE 11 - 10https://bugzilla.wikimedia.org/65118#c6 (10Liangent) Actually I guess we should get rid of any home made scripts here and turn to use jquery.client. [16:29:28] (03PS1) 10Jdlrobson: Support position fixed on Trident (newer IE versions) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/133088 (https://bugzilla.wikimedia.org/65118) [16:29:33] (03CR) 10Dbrant: "Hmm... that's odd. It works correctly on all of my test devices. Are you sure we're following the same steps to reproduce?" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/132966 (https://bugzilla.wikimedia.org/64209) (owner: 10Dbrant) [16:46:32] (03CR) 10MaxSem: "Tests?" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/133088 (https://bugzilla.wikimedia.org/65118) (owner: 10Jdlrobson) [16:46:34] (03CR) 10BearND: [C: 031] "Works on my devices as well." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/132966 (https://bugzilla.wikimedia.org/64209) (owner: 10Dbrant) [16:53:53] 3MobileFrontend / 3stable: More link on Special:Contributions/Username doesn't work - 10https://bugzilla.wikimedia.org/65266 (10Jon) 3NEW p:3Unprio s:3normal a:3None Aude noticed this during the Zurich hackathon. Click more, see exactly the same entries... [16:54:37] 3MobileFrontend / 3stable: More link on Special:Contributions/Username doesn't work - 10https://bugzilla.wikimedia.org/65266#c1 (10Jon) We should copy what wea re doing on Special:History [16:55:21] 3MobileFrontend / 3stable: More link on Special:Contributions/Username doesn't work - 10https://bugzilla.wikimedia.org/65266#c2 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/8GHsxpOa [16:57:38] (03CR) 10Jdlrobson: [C: 032] "I wish this stuff had tests :-( but it seems to fix the problem for me" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/132130 (https://bugzilla.wikimedia.org/64867) (owner: 10MaxSem) [16:58:18] (03CR) 10jenkins-bot: [V: 04-1] Fix the mess with previous revisions in contributions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/132130 (https://bugzilla.wikimedia.org/64867) (owner: 10MaxSem) [17:06:15] * awjr waves [17:06:48] (03CR) 10MaxSem: [C: 032] Regression: Fix Special:MobileWebApp [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/133080 (owner: 10Jdlrobson) [17:06:56] hey awjr [17:06:58] *waves back to awjr* [17:06:58] hey Max [17:07:02] how was your flight awjr ? [17:07:03] :D [17:07:08] jdlrobson: im stuck in houston [17:07:16] awjr: still on the move? eek [17:07:20] jdlrobson: my flight got canceled last night due to weather [17:07:22] (03Merged) 10jenkins-bot: Regression: Fix Special:MobileWebApp [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/133080 (owner: 10Jdlrobson) [17:07:23] yeah :( [17:07:41] yeh i saw the mail :( [17:07:41] im trying to fly home standby, but so is everyone else :p [17:07:41] i was hoping you'd be home now [17:07:41] im booked on a flight late tonight [17:08:03] jdlrobson: how's florence? [17:08:16] awjr: it's pretty epic [17:08:20] :D [17:08:37] i have truffle cheese, the most amazing sun dried tomatoes i've ever had and a stick of tuscany salami [17:08:49] and the town is beautiful [17:08:58] been walking around it all morning before i started working :) [17:09:00] (03CR) 10Kaldari: [C: 04-1] Support position fixed on Trident (newer IE versions) (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/133088 (https://bugzilla.wikimedia.org/65118) (owner: 10Jdlrobson) [17:09:57] (03CR) 10Kaldari: [C: 032] Use hash for random link [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/131760 (https://bugzilla.wikimedia.org/64924) (owner: 10Jdlrobson) [17:10:25] hey kaldari [17:10:31] (03Merged) 10jenkins-bot: Use hash for random link [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/131760 (https://bugzilla.wikimedia.org/64924) (owner: 10Jdlrobson) [17:11:07] wikimedia sites are super slow today (gerrit and bugzilla :() [17:11:19] nice jdlrobson :) that sounds way better than… houston :p [17:11:49] at least i managed to find a hotel room last night - a lot of folks were stranded at the airport [17:13:41] jdlrobson: howdy! when are you heading back? [17:13:55] 13 days time kaldari [17:14:05] how's Max's house hunting going? [17:14:27] MaxSem: ^ [17:14:37] 3MobileFrontend / 3General/Unknown: MobileFrontend "Random" feature does not use canonical URL form - 10https://bugzilla.wikimedia.org/64924 (10Jon) 5PAT>3RES/FIX [17:15:49] (03CR) 10Jdlrobson: "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/132130 (https://bugzilla.wikimedia.org/64867) (owner: 10MaxSem) [17:16:28] kaldari: max is not in the room [17:16:41] (03CR) 10Jdlrobson: Support position fixed on Trident (newer IE versions) (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/133088 (https://bugzilla.wikimedia.org/65118) (owner: 10Jdlrobson) [17:17:15] (03PS3) 10Jdlrobson: Fix the mess with previous revisions in contributions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/132130 (https://bugzilla.wikimedia.org/64867) (owner: 10MaxSem) [17:22:04] (03CR) 10Kaldari: Support position fixed on Trident (newer IE versions) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/133088 (https://bugzilla.wikimedia.org/65118) (owner: 10Jdlrobson) [17:23:18] (03CR) 10MaxSem: Fixed domain name for cookie deletion and removed logout (031 comment) [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/133043 (owner: 10Yurik) [17:32:54] (03PS1) 10Dbrant: Update table of contents after editing page. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/133092 (https://bugzilla.wikimedia.org/64447) [17:34:19] kaldari: i just noticed we don't have any position fixed tests for supportsPositionFixed and the more i think about it they wouldn't add any value... [17:35:52] (03CR) 10Jdlrobson: "Actually now I think about it we don't have any position fixed tests for supportsPositionFixed and I'm not convinced they wouldn't add an" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/133088 (https://bugzilla.wikimedia.org/65118) (owner: 10Jdlrobson) [17:36:22] (03CR) 10Jdlrobson: "Attempt 2" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/132130 (https://bugzilla.wikimedia.org/64867) (owner: 10MaxSem) [17:36:42] jdlrobson: you used a double negative there [17:38:29] (03PS1) 10Mhurd: Fix for rotate on save confirm page changing nav bar title. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/133093 [17:38:34] awjr: hang on, i'll update the https patch [17:38:37] i have some local changes [17:39:00] ori: ahha ok, i was just about to fix the rebase :) [17:39:02] i'll hold off [17:39:35] jdlrobson: Maybe we could just have one generic test that assumes the tester is using a modern browser, just to make sure the flag is actually getting set. [17:39:58] dr0ptp4kt: any time for cr? (2 line patch) [17:40:22] mhurd, yep - add me and lemme know the url [17:40:39] dr0ptp4kt: https://gerrit.wikimedia.org/r/133093 [17:44:03] (03CR) 10MaxSem: [C: 032] Fix the mess with previous revisions in contributions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/132130 (https://bugzilla.wikimedia.org/64867) (owner: 10MaxSem) [17:44:24] (03CR) 10Liangent: [C: 04-1] "IIRC the "Trident" token was introduced in IE7 or IE8." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/133088 (https://bugzilla.wikimedia.org/65118) (owner: 10Jdlrobson) [17:44:44] (03Merged) 10jenkins-bot: Fix the mess with previous revisions in contributions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/132130 (https://bugzilla.wikimedia.org/64867) (owner: 10MaxSem) [17:46:24] (03CR) 10Liangent: "http://msdn.microsoft.com/en-us/library/ie/ms537503(v=vs.85).aspx" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/133088 (https://bugzilla.wikimedia.org/65118) (owner: 10Jdlrobson) [17:46:57] (03CR) 10Dr0ptp4kt: [C: 032 V: 032] Fix for rotate on save confirm page changing nav bar title. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/133093 (owner: 10Mhurd) [17:47:02] ^ mhurd thar [17:51:13] kaldari: awjr any problems if i disappear for 2 hours in about 10 mins? Apparently my friends found a squat and we've been invited to dinner (you can't make this stuff up) [17:51:37] kaldari: judging on liangent's comment it sounds like a test would be useful [17:52:04] fine with me [17:52:07] jdlrobson: sounds fine to me, im going to pop off soon for lunch too [17:56:11] great. see you in a bit! [17:59:23] jdlrobson: that test that uploads the file exif.png would only ever pass one time the way it is written. every subsequent load of exif.png is a duplicate. the thumb of the file on the "success" page has the correct alt text but the href is empty because the file uploaded is a duplicate [17:59:32] (03CR) 10Dr0ptp4kt: [C: 032] Fixed domain name for cookie deletion and removed logout [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/133043 (owner: 10Yurik) [17:59:48] (03Merged) 10jenkins-bot: Fixed domain name for cookie deletion and removed logout [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/133043 (owner: 10Yurik) [18:00:30] awjr kaldari btw i found flights from SFO to Hong Kong for $654 return 7 days (indirect) Sept-Dec if you are interested ;-) [18:00:38] @_@ [18:00:54] chrismcmahon: ahhhhh.. that's what's going on :( [18:00:55] already been to HK :) [18:01:04] is there a way to upload a random jpg? [18:01:14] that would be a cool feature [18:01:16] use wikimedia commons app [18:01:20] kaldari: sure but you can get a cheap flight onwards from there although might be a stretch for time ;-) [18:01:35] the flight sounds good [18:02:22] i mean, combine http://en.wikipedia.org/wiki/Lomography + commons app [18:02:27] and you got your random picture upload [18:02:40] MaxSem: thanks for taking care of that xss vuln btw [18:02:46] ok disappearing for a bit - Will leave this on so i don't miss anything. [18:03:43] jdlrobson: also, that test was never enabled for firefox, it's been only running for chrome [18:05:13] * tfinc looks around for Deskana [18:05:27] bearND: greetings on day2 [18:05:29] chrismcmahon: will be back in a couple of hours to debug some more - just breaking for an extended dinner :) [18:05:38] jdlrobson: how post Zurich going ? [18:05:46] is* [18:05:55] tfinc: greetings to you [18:06:02] tfinc jdlrobson just stepped out [18:06:34] mutante: hey, sorry I missed you yesterday! [18:06:35] awjr: haha keep getting pulled back in though ;-) [18:06:40] psych! [18:06:50] mutante: I can't seem to ssh into bast1001... [18:06:56] tfinc: it's great - just what i needed. Less stale here. Much needed change of environment :) [18:07:15] moizsyed: hey! [18:07:23] hey monte! [18:07:24] anyway now I'm checking out for realz [18:07:24] whats up [18:07:25] see you in a bit! [18:07:27] :) [18:07:38] mhurd: whats up [18:07:44] dbrant: i could confirm bast1001 has your key, i am watching the logfile if you wanna try again [18:07:46] moizsyed: awesome mocks [18:07:48] moizsyed: happy (belated) birthday! [18:08:00] thanks mhurd! [18:08:13] dbrant: if you want to PM me with an error you get or something, feel free [18:08:25] ori: thanks! are you back in sf? [18:08:33] moizsyed: yeah, but not in the office today [18:08:38] will be tomorrow [18:08:55] dbrant: i think your username is not set to "dbrant" Invalid user Unknown [18:09:00] if that is your IP i'm seeing [18:09:19] now that looks like it worked [18:09:24] accepted public key [18:09:30] moizsyed: oh, for all the little icons i was wondering if you could make additions to wikifont so i can has pixel perfect vectors [18:09:31] mhurd: let me know if you have any questions about the mocks, there might be some cases we're not addressing [18:09:38] mutante: ahh! I wasn't typing "dbrant@..." [18:09:58] mhurd, we'll do that [18:10:06] mutante: all good now; thanks! [18:10:12] moizsyed: woohoo! [18:10:12] dbrant: yea, you can set it in .ssh/config once if you don't wanna have to keep typing it [18:10:23] dbrant: cool! [18:33:14] MaxSem: do you see the option to add a new instance at https://wikitech.wikimedia.org/wiki/Nova_Resource:Mobile#Instances_for_this_project ? i saw the option 10 minutes ago, but now i don't see it. and i'm still logged in [18:34:36] moizsyed: hey would you have a second to confirm the links in the ios stories in the “To Do” column of the current sprint point to the correct mocks? (https://trello.com/b/BW5L3PEn/mobile-app-sprint-31-main-article-browse-search) [18:34:48] sure lemme check [18:34:53] https://wikitech.wikimedia.org/wiki/Special:NovaInstance [18:34:58] moizsyed: meeting was quick :) [18:35:04] MaxSem: thx :) [18:35:45] moizsyed: thanks! [18:44:32] mhurd: the links are not updated [18:44:51] mhurd: i will update the cards with updated mocks [18:45:03] moizsyed: glad i asked :) thanks! [18:45:14] mhurd: :) [18:45:14] mhurd: are you up to date on the sprint ? [18:45:47] tfinc: the mocks are ready and are moiz is linking them to their respective cards now [18:45:59] great. let me know if you need anything else to get started [18:58:16] Hey mobile-landers, is there any documentation about working on the iOS app without Apple software? [19:11:46] dr0ptp4kt, i just deployed the latest zero, the zero.wikipedia.org cookie works now [19:11:49] dfoy, ^ [19:12:03] it deletes forceHTTPS [19:12:28] so if any partner complains, if they whitelist zero., tell them to navigate to zero.wp [19:15:50] is gerrit down? [19:23:23] dbrant: bearND tfinc hey! Sorry I wasn't up earlier. [19:23:31] finally in Glasgow. 16C, and terrible [19:23:40] err, terribly cold [19:23:51] YuviPanda: still jealous! [19:24:11] dbrant: hehe :D [19:24:44] YuviPanda: np, glad you've made it [19:24:49] :) [19:24:56] yurikR, cool [19:27:26] bearND: how's checking out the code going? [19:28:37] YuviPanda: i've submitted another patch for the test project [19:28:56] it now compiles! [19:29:16] YuviPanda: was wondering about getting a look at the jenkins config for the job triggered by gerrit [19:29:24] bearND: ooooh, coool! [19:29:32] bearND: let me find our docs [19:29:39] awjr_away: source => 'puppet:///modules/nginx/nginx.conf', <-- this was not a part of your patch, since modules/nginx is a submodule [19:29:44] bearND: fixing all the checkstyle warnings so we can make it voting would also be great [19:29:59] dbrant: bearND the auto reviewer add thing also works now :) [19:30:09] yes! [19:32:14] dbrant: bearND checked out the IntelliJ Ultimate license? :) [19:32:49] (03PS2) 10Yuvipanda: Stop blinking cursor after search result selected. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/132966 (https://bugzilla.wikimedia.org/64209) (owner: 10Dbrant) [19:33:12] YuviPanda: yes! it's glorious [19:33:57] YuviPanda: I assume I can use it on all my machines? [19:34:03] dbrant: yeah. [19:34:24] dbrant: needs renewal in a year or so, but someone usually gets around to it. PHPStorm is pretty popular in the community [19:34:51] dbrant: has no number restrictions, as long as it is just you using it. Can use it for other pet projects too [19:34:56] bearND: https://www.mediawiki.org/wiki/Continuous_integration has docs [19:35:04] bearND: the subpages, specifically [19:35:05] very nice [19:35:19] bearND: I know that the folks running our CI system would be really happy to get some help :) [19:35:44] bearND: there isn't much docs about java stuff, since we are the only people using it right now, but you should be able to check out the repo and see how it's like [19:35:49] YuviPanda: still on CE of IntelliJ [19:36:14] bearND: it'll be cool if we can get continuous builds setup, but that could probably wait until after our release [19:36:32] YuviPanda: thanks for the link; when is the release planned for? [19:36:51] bearND: let me find the email thread from last week [19:38:59] YuviPanda: https://bugzilla.wikimedia.org/show_bug.cgi?id=65272 <- could that be because of the nginx change? [19:39:13] multichill: the nginx change was rolled back [19:40:23] Because of the rollback than? :P [19:40:38] multichill: hehe :P probably not. [19:40:47] YuviPanda: got it, ty [19:41:29] bearND: dbrant the cursor is still flashing for me. N4, kitkat [19:42:09] :( I'll try it in the emulator... [19:42:25] YuviPanda: i tested on a GB and ICS device, don't have kitkat yet but could fire up an emulator [19:42:40] bearND: dbrant I'm happy merging it if it works for some devices at least. [19:42:57] bearND: let me get an RT ticket to set you up with +2 rights [19:43:21] YuviPanda: yeah! :) [19:44:02] YuviPanda: yeah, maybe merge, and let Deskana try it? [19:44:09] dbrant: yeah, that sounds good [19:44:41] (03CR) 10Yuvipanda: [C: 032] "Still doesn't work for me, but perhaps it is just my device. merging for now." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/132966 (https://bugzilla.wikimedia.org/64209) (owner: 10Dbrant) [19:44:45] there [19:44:49] :) [19:44:58] (03Merged) 10jenkins-bot: Stop blinking cursor after search result selected. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/132966 (https://bugzilla.wikimedia.org/64209) (owner: 10Dbrant) [19:45:27] bearND: the docs in the code are a bit... lacking. And our JS parts have no docs at all. Sorry about that. slowly fixing stuff up [19:45:46] bearND: what's your gerrit username? [19:46:10] YuviPanda: it's BearND [19:47:06] ok [19:47:11] * YuviPanda files RT ticket [19:56:34] MaxSem, not sure what you meant by the very descriptive "???" comment ... https://gerrit.wikimedia.org/r/#/c/133079/1/.idea/dataSources.local.xml [19:56:43] (also known as WTF) [19:57:08] bearND: you should have +2 rights now [19:57:12] what is it for? [19:57:13] (03CR) 10Yuvipanda: [C: 04-1] Add MCC-MNC once per app session on cellular. (032 comments) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/131246 (owner: 10Dr0ptp4kt) [19:57:37] YuviPanda: yes, just verified. ty to you and mutante [19:57:44] wouldn't it be easier to make it available through Vagrantfile? [20:01:58] hey mhurd, i updated most of the todo cards with new mocks [20:02:18] moizsyed: perfect! thanks for syncing those up! [20:02:25] mhurd: let me know if you need anything :) [20:02:34] moizsyed: sounds good! [20:02:37] :0 [20:02:43] :) [20:05:32] (03PS1) 10JGonera: Fix margins in page list and search [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/133125 (https://bugzilla.wikimedia.org/64633) [20:05:47] (03PS1) 10JGonera: Avoid unnecessary scrollbar in NotificationsOverlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/133126 [20:12:09] (03PS1) 10Dr0ptp4kt: More PhantomJS updates and documentation. [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/133158 [20:12:26] (03CR) 10Dr0ptp4kt: [C: 032] More PhantomJS updates and documentation. [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/133158 (owner: 10Dr0ptp4kt) [20:12:47] (03Merged) 10jenkins-bot: More PhantomJS updates and documentation. [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/133158 (owner: 10Dr0ptp4kt) [20:20:41] (03CR) 10MaxSem: Fix username handling on Special:Uploads (033 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/132518 (https://bugzilla.wikimedia.org/65094) (owner: 10MaxSem) [20:21:02] (03PS2) 10MaxSem: Fix username handling on Special:Uploads [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/132518 (https://bugzilla.wikimedia.org/65094) [20:21:11] (03CR) 10JGonera: "> Something smells fishy here - why does this happen" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/132356 (owner: 10JGonera) [20:22:15] ori: oops, forgot to add it to the patchset [20:23:36] (03PS2) 10JGonera: Prevent horizontal scrollbar after menu closing animation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/132356 [20:25:55] erp [20:26:32] ori: i just tried to add the file and amend the commit but git review is saying 'remote: (W) No changes between prior commit 39567c0 and new commit 7503ecc' [20:26:35] * tfinc looks about  [20:26:37] YuviPanda: staying warm ? [20:26:39] awjr: welcome back [20:26:59] tfinc: I just accidentally wandered to the balcony. Had to cuddle under a blanket for about 5 mins to recover [20:27:00] oh is it because it's in a submodule? [20:27:05] tfinc thanks [20:27:09] tfinc still in houston though :p [20:27:42] awjr: yuck, i'm sorry. thats the only airport i've gone through in the world that announced where to pick up /drop off weapons [20:27:52] i kid you not [20:27:52] lol [20:28:02] it's a good thing no one told me where to pick up weapons last night... [20:28:25] tfinc they originally had me rebooked on a late flight out tonight [20:28:38] but i just saw that a seat opened up on an earlier flight and i'm out of here in two hours [20:29:05] (03CR) 10Jdlrobson: [C: 04-1] Fix margins in page list and search (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/133125 (https://bugzilla.wikimedia.org/64633) (owner: 10JGonera) [20:29:05] ori: i think something's gone sideways in my local checkouts - i'm going to pastebin you the conf [20:29:12] ^ jgonera_ feel free to disagree :) [20:29:44] ori: http://pastebin.de/125205 [20:29:55] dr0ptp4kt: meeting moved to chambers [20:36:07] (03CR) 10Jdlrobson: [C: 04-1] "Feel free to self merge with the added comment." (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/132356 (owner: 10JGonera) [20:40:56] (03PS1) 10BearND: Make IDE happier in test project [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/133163 [20:42:03] jdlrobson, I just realized that by muting gerrit bot I not only don't get notifications but don't see the messages at all ;) [20:42:43] (03CR) 10Yuvipanda: [C: 032] Make IDE happier in test project [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/133163 (owner: 10BearND) [20:42:46] adding comment [20:43:47] (03Merged) 10jenkins-bot: Make IDE happier in test project [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/133163 (owner: 10BearND) [20:43:51] (03PS3) 10JGonera: Prevent horizontal scrollbar after menu closing animation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/132356 [20:43:53] done [20:45:00] ok, wrapping up for today, bus is almost in Munich [20:45:57] have fun, jgonera :) [20:46:18] (03CR) 10JGonera: Fix margins in page list and search (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/133125 (https://bugzilla.wikimedia.org/64633) (owner: 10JGonera) [20:46:37] you too YuviPanda ;) [20:46:42] jgonera: :) [20:48:15] dbrant: sorry, a server I help maintain (tools.wmflabs.org) went down and I am the only admin around, so fixing that. will CR right after [20:48:24] YuviPanda: np! [20:51:53] bearND: wannna CR some of dbrant's code and +2? :) [20:54:27] bearND: doing my CRs is easy, since I don't write code with bugs in it. [20:55:01] hehe [20:57:07] bearND: here is one article about staff vs personal edits https://office.wikimedia.org/wiki/User_account_policy [20:57:25] bearND: i'm asking our legal counsel to see if there are any others [20:57:39] dbrant: YuviPanda: going to cr [20:57:52] tfinc: thanks [21:00:02] (03PS1) 10Cmcmahon: QA Duplicate images have empty href tag, check alt instead [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/133168 [21:05:03] (03CR) 10Jdlrobson: [C: 032] Prevent horizontal scrollbar after menu closing animation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/132356 (owner: 10JGonera) [21:05:11] (03CR) 10BearND: [C: 032 V: 032] "All the overflow items are enabled after going back. Wondering if we should keep Other languages disabled since that requires network acce" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/132976 (https://bugzilla.wikimedia.org/64774) (owner: 10Dbrant) [21:05:39] (03Merged) 10jenkins-bot: Prevent horizontal scrollbar after menu closing animation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/132356 (owner: 10JGonera) [21:09:43] dbrant or YuviPanda: do we have some sandbox articles to test editing? i'm trying to repro https://gerrit.wikimedia.org/r/#/c/133092/ [21:10:04] bearND: go to settings, change to 'test' wiki, and edit anything you want :) [21:10:12] bearND: it goes to test.wikipedia.org which is a full sandbox [21:10:25] YuviPanda: excellent, ty [21:10:38] bearND: :D [21:11:24] YuviPanda: di i need to log in first to see the test wiki setting? [21:12:01] bearND: it's part of the 'wikipedia language' setting. test is just considered a 'language' [21:12:07] bearND: it's under Language settings [21:12:35] (03PS1) 10Kaldari: Removing header margin and associated hacks [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/133170 [21:13:01] YuviPanda: dbrant: got it. thanks [21:15:36] (03PS2) 10Kaldari: Removing header margin and associated hacks [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/133170 [21:18:03] jdlrobson: https://gerrit.wikimedia.org/r/#/c/133168 at least gets us down the road, and will make the test green (assuming that check for the progress bar isn't flaky) [21:18:41] chrismcmahon: taking a look [21:18:49] chrismcmahon: also going to rename a file in the process [21:19:32] * marktraceur asks again [21:19:46] Is there any documentation about working on the iOS app without OS X and XCode? [21:20:45] marktraceur: you can't. [21:20:59] mhurd: marktraceur has a question for you [21:21:19] YuviPanda: I mean, I'm asking because I've links for whoever maintains the docs. [21:21:36] marktraceur: that would be mhurd. I don't know if there are docs :) [21:21:39] *nod* [21:21:43] marktraceur: no docs presently [21:21:44] marktraceur: if you are in the office, so is he. [21:21:55] dbrant YuviPanda: how does one add a new section to an article? i think i would need one to see a change in the ToC. Looks like i can only edit inside the section. [21:21:56] YuviPanda: Yeah, but IRC is wider-reaching and async! [21:22:13] marktraceur: completely agree! [21:22:20] bearND: you can just use a heading to start a new section [21:22:27] == new section == \n New section body [21:22:41] dr0ptp4kt, http://www.elasticsearch.org/overview/kibana/ [21:22:49] mhurd: My friend from the jailbreaking community pointed me at http://iphonedevwiki.net/index.php/Theos today, I thought you and other iOS hackers in our community might be interested. [21:23:02] bearND: edit an existing section, and add a paragraph that starts with "== new section ==" on one line [21:23:24] yurikR: nice! [21:25:00] marktraceur: way cool! [21:28:25] chrismcmahon: does that test pass for you? [21:29:08] YuviPanda: you double booked me for tomorrow training [21:29:35] jdlrobson: when I run it locally it fails looking for the upload progress bar. when I take that step out it correctly checks for random_string in the alt text of the thumb [21:29:47] chrismcmahon: i get timed out after 10 seconds (Watir::Wait::TimeoutError) [21:29:54] (03PS2) 10Jdlrobson: QA Duplicate images have empty href tag, check alt instead [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/133168 (owner: 10Cmcmahon) [21:30:08] let me quciky try against beta labs [21:31:11] YuviPanda: dbrant: thanks, i got my new section. ran into some hickups though since i couldn't create a new account from the app. is this a known bug? [21:31:56] chrismcmahon: for some reason in chrome on beta labs i get an unrelated error that stops me from testing :/ [21:32:14] mine passes on the upload progress bar [21:32:21] (locally) [21:34:00] jdlrobson: wfm on beta labs, progress bar also just now: http://pastebin.com/UqRvwM21 [21:34:16] chrismcmahon: mine seems to fail on the page.text.include? "#{@random_string}" #Chrome needs this, FF does not step [21:34:32] chrismcmahon: anyway willing to give it a go! [21:34:32] (03PS3) 10Jdlrobson: QA Duplicate images have empty href tag, check alt instead [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/133168 (owner: 10Cmcmahon) [21:34:36] i made some amendments ^ [21:35:07] (03CR) 10Jdlrobson: [C: 031] "@chrismcmahon Also did a file rename and some whitespace cleanup. Feel free to +2 if you are okay with those." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/133168 (owner: 10Cmcmahon) [21:36:14] (03CR) 10Cmcmahon: [C: 032] QA Duplicate images have empty href tag, check alt instead [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/133168 (owner: 10Cmcmahon) [21:37:06] (03Merged) 10jenkins-bot: QA Duplicate images have empty href tag, check alt instead [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/133168 (owner: 10Cmcmahon) [21:40:55] bearND: what was the behavior when creating an account? [21:46:07] dbrant: it was stuck there. pressing the action bar icon (paper airplane) did not do anything. next time i'll check the debugger. right now i'm trying to understand why you've change tocList.getAdapter == null to tocList.getHeaderViewsCount() == 0 [21:49:04] dbrant: it did update the ToC when I used an existing account. so the behavior is correct. just trying to understand the code change [21:50:45] mhurd: So quickly, is there somewhere I should put that link? [21:50:52] I don't know where the iOS docs are [21:51:02] bearND: so the "tocList.getAdapter() == null" was there so that the Adapter for the ListView would be set only once. [21:51:31] bearND: I changed it so that the HeaderView is set only once, but the Adapter is set every time (so that it refreshes after editing). [21:53:42] (03CR) 10Jdlrobson: [C: 032] Avoid unnecessary scrollbar in NotificationsOverlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/133126 (owner: 10JGonera) [21:53:52] kaity: are you around? [21:53:58] dbrant: ah, makes sense. couldn't we call adapter.notifyDataSetChanged(); instead of creating a new adapter? [21:54:03] jdlrobson: yep [21:54:13] are you okay with switchin g from the word edited to modified for the last modified bar? [21:54:17] background https://bugzilla.wikimedia.org/64937 [21:54:26] (03Merged) 10jenkins-bot: Avoid unnecessary scrollbar in NotificationsOverlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/133126 (owner: 10JGonera) [21:55:21] marktraceur: i could be wrong, but i don’t think theos can handle interface builder xml files yet [21:55:25] (03PS4) 10Jdlrobson: Hygiene: Cleanup edit switcher css [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/132345 (https://bugzilla.wikimedia.org/64968) [21:55:59] jdlrobson: what can a user modify that doesn't count as an edit? [21:56:18] kaity, protections and renames [21:56:38] they both create new revisions but don't alter page text [21:56:39] (03CR) 10Jdlrobson: "Removing Juliusz's -1 on learning this today:" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/131089 (https://bugzilla.wikimedia.org/64669) (owner: 10Jdlrobson) [21:56:50] mhurd: Hm, .nib files do seem to be missing from the docs. I can ask if that's a critical failure or if it's just not built to edit them, I guess [21:57:22] MaxSem: can we hide those from last edited bar? [21:57:34] not easily [21:59:21] marktraceur: the app’s presently using both .xib and .storyboard IB files, but they’re just fancier .nibs essentially iirc [21:59:44] MaxSem: jdlrobson can we hold off on changing for now to see if its really a problem? [22:00:18] we've received complaints thus I'd argue that it is [22:00:29] also note that core uses "modified" [22:00:37] kaity: for reference we already say "last modified a year ago" [22:00:52] and i'm pretty sure we can't hide them since that would invalidate our license agreement [22:01:00] (all edits are equal etc) [22:01:37] The purpose of the last edited is to humanize the article, and I think most readers would understand "edit" more than "modify" [22:02:51] thre have also been made claims that "edited" is somehow connected to editorial ownership... [22:02:51] Lets get feedback from more people [22:03:35] MaxSem: thats interesting, wheres that conversation happening? [22:04:11] bearND: looking into the create-account issue... there's something weird [22:06:33] https://bugzilla.wikimedia.org/show_bug.cgi?id=64921 [22:17:00] thanks MaxSem [22:17:06] ^ cc kaldari [22:17:38] ? [22:18:35] MaxSem: jdlrobson I saw the rfc also. But I'm not sure if I saw something saying "edited" implies more ownership than "modified" [22:19:12] kaity, there's no such thing as "modifier in chief":P [22:19:44] MaxSem: that was a different bug [22:19:47] I think both words mean very similar things, the main difference being modify seems more technical [22:20:13] https://bugzilla.wikimedia.org/show_bug.cgi?id=64937 [22:20:31] yes I think we do have more cultural associations with edit, but I think thats a good thing, more people easily understand what it means [22:22:36] do you guys think the bigger issue is that its not technically accurate sometimes, or that it could imply ownership? [22:22:55] kaity: The bug is mainly complaining that not every revision is actually an edit (which is true). Some revisions are things like changing the protection status of a page. I guess this is why we say 'modified' rather than 'edited' on desktop. [22:24:10] kaity: bug 64937 is mainly a technical complaint, while bug 64921 is more about the 'ownership' issue. [22:25:05] kaldari: is that causing a lot of confusion to users? [22:25:17] not sure [22:25:34] we can change it if you like, or defer the bug for now [22:25:40] ok, back for a bit [22:25:53] my laptop's out of charge, and I thought it was 7pm but it was actually 10pm so no adapter for me [22:25:55] oh well [22:27:11] yuvipanda_: welcome back. dbrant was looking into an account creation issue after editing a page [22:27:38] i wonder if more people will be confused by the use of the word modified and ignore the bar or if more people will see "edit", click it and be confused that it shows a different username? [22:27:56] bearND: there's an account creation issue after editing a page? [22:28:12] is there a bug number? [22:28:27] vbamba: are you around? [22:28:50] 3MobileFrontend / 3General/Unknown: MobileFrontend "last edited" strapline should not include authorship information - 10https://bugzilla.wikimedia.org/64921#c22 (10Ryan Kaldari) >It should be noted here that your comment is a gross misrepresentation of both >Wikimedia development and the use of wontfix. I... [22:29:11] yuvipanda_: not yet. i just mentioned it to him a bit earlier. [22:30:35] bearND:oh ok. Have you checked out bugzilla yet? [22:32:02] yuvipanda_: read-only yes, but have not submitted any bugs yet [22:32:33] kaity: the username shown will be the same. The potentional for confusion lies in the case where they see "Last edited 5 minutes ago by FatCat", they click 'edited' and it shows that FatCat didn't actually edit the article but performed some other action like changing protection or adding ArticleFeedback or something. Regardless of which we choose, it would probably be good to use the same language on both desktop and mobile. [22:34:16] kaldari: oh ok cool. I think we should change both to "edit" [22:34:17] Wikipedia must be the hardest site in the world to design for do to all the crazy edge cases in every interface :P [22:35:15] kaity: OK, I'll reply to the bug and mark it as WONTFIX. [22:35:28] thank you! :) [22:36:15] kaity: actually, I think I'll leave it open for more discussion for the time being, but I'll tell them that the design team prefers using 'edit' if that's OK. [22:36:29] yuvipanda_: ok, just registered at bugzilla. any guidelines for submitting bugs? [22:37:33] (03CR) 10Jdlrobson: Fix margins in page list and search (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/133125 (https://bugzilla.wikimedia.org/64633) (owner: 10JGonera) [22:37:47] (03PS4) 10Jdlrobson: Add iOS hover bug fix [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/131089 (https://bugzilla.wikimedia.org/64669) [22:37:50] kaldari: yea thats fine [22:38:08] yuvipanda_: How do you feel about having separate tags for both iOS and Android edits? [22:38:10] (03CR) 10Jdlrobson: [C: 04-1] "mailed this to juliusz not sure why i didn't do that before." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/131089 (https://bugzilla.wikimedia.org/64669) (owner: 10Jdlrobson) [22:38:10] bearND: good question. let me find. [22:38:45] Deskana: what would that accomplish? [22:38:50] Deskana: it's easy to do [22:39:43] yuvipanda_: Well, I'm curious about who's using apps vs web. I think we're going to end up with different user groups. And being able to easily find such users in MediaWiki itself is really awesome. [22:39:48] 3MobileFrontend / 3General/Unknown: MobileFrontend "last edited" strapline sometimes wrong (reports non-edits) - 10https://bugzilla.wikimedia.org/64937#c3 (10Ryan Kaldari) Talked to the design team to get sign-off on the patch. I explained the issue to them, but they still prefer using 'edited' rather than '... [22:39:57] yuvipanda_: I'm also curious about whether we end up having different user groups between Android and iOS... [22:40:41] Deskana: I definitely agree on apps vs web. The only potential problem with iOS vs Android is 'tag spam', but if you think that won't be a problem, I'm happy with it. [22:40:48] differentiating edits that way does seem quite useful [22:40:58] hmm, actually it would be quite useful. let's do it! [22:41:02] (03CR) 10Kaldari: [C: 04-1] "Design team says they prefer sticking with 'edited'. Marking as -1 until discussed further." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/133020 (https://bugzilla.wikimedia.org/64937) (owner: 10Kaldari) [22:41:07] (03CR) 10Jdlrobson: [C: 04-1] "Waiting on outcome of bug report." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/133020 (https://bugzilla.wikimedia.org/64937) (owner: 10Kaldari) [22:41:15] Deskana: I'm slightly bummed mobile web's tag is called 'mobile' rather than 'mobile web' tho [22:41:33] it's not inaccurate to say "edited" [22:41:40] in one case it's the page contents that were edited [22:41:45] in the other, its metadata [22:41:51] true [22:42:14] yuvipanda_: Well, we could always have an apps tag as well as the current mobile one. That way mobile web edits are ones that are tagged as mobile and not tagged as apps. [22:42:26] yuvipanda_: Let's consider *all* of our options before we set down one particular path. :) [22:42:30] ori: might be useful to add that comment to https://bugzilla.wikimedia.org/show_bug.cgi?id=64937 [22:42:32] "edited" is more suggestive of intelligent, constructive activity than "modified", which could mean almost anything [22:42:42] sure [22:42:43] yuvipanda_: I'll start a discussion on mobile-l. [22:43:07] Deskana: right. That would be accurate as well. [22:43:14] (03CR) 10Jdlrobson: [C: 04-1] "Considering that the last patch was broken I feel tests would be a good idea here - either browser or unit tests." (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/132518 (https://bugzilla.wikimedia.org/65094) (owner: 10MaxSem) [22:43:39] Deskana: sweet! we have a MobileApp extension that currently does nothing much (but I'm moving the CSS to it!) and this code would go ther as well [22:43:56] Deskana: can you help bearND with bugzilla? his first time! pointers, etc would be useful [22:44:30] Deskana: my primary machine is dead and I can't charge it because I don't have an appropriate adapter. I initially kept thinking it was 7pm based on the light outside but turned out to be 10 and there isn't anything open now [22:45:04] yuvipanda_: Certainly. [22:46:17] thanks Deskana! [22:46:28] bearND: I leave you in Deskana's capable hands :D [22:46:28] bearND: Hey! In case you've not twigged yet, I'm Dan, the associate product manager that was on the call yesterday. :) [22:47:05] chrismcmahon: any idea when the builds are moving to wikimedia from cloud bees? [22:48:03] 3MobileFrontend / 3General/Unknown: MobileFrontend "last edited" strapline sometimes wrong (reports non-edits) - 10https://bugzilla.wikimedia.org/64937#c4 (10Ori Livneh) "Last edited" is not, strictly speaking, inaccurate: in one case, it's the page contents that were edited; in the other, it's the page meta... [22:48:33] jdlrobson: eventually all of them. right now we're running builds headless on Firefox, but they have some issues. [22:48:59] Deskana: i figured that one out yesterday. thanks [22:49:09] jdlrobson: Zeljko has been out last week and this week with a new baby, we should be fixing up the WMF builds next week. [22:49:28] bearND: So, first step! Did you register an account on Bugzilla? :) [22:49:51] (03PS1) 10Jdlrobson: Make border-box the default [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/133188 [22:49:53] (03PS1) 10Jdlrobson: Icon cleanup [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/133189 [22:49:54] yuvipanda_: btw the account creation issue happens only on one of my two devices (the ICS one, but progresses to the captcha page on my gingerbread device) [22:49:55] (03PS1) 10Jdlrobson: Make icons in overlays and drawers global and reusable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/133190 [22:50:35] (03PS3) 10Jdlrobson: Cleanup ui.less now universal header [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/131892 (https://bugzilla.wikimedia.org/64719) [22:50:53] (03CR) 10Jdlrobson: "See https://gerrit.wikimedia.org/r/133188" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/131881 (owner: 10Jdlrobson) [22:51:23] bearND: hmm, ok. get through a short bugzilla bootcamp with Deskana, and then report it, and then we can discuss / fix? [22:51:36] 1hr till sleep wooo!! :) [22:52:03] jdlrobson: :) [22:52:22] yuvipanda_: will do. [22:52:34] Deskana: yes, i've registered on bugzilla [22:52:38] Great. [22:53:35] bearND: Your first step should probably be to set up a saved search for Android bugs. [22:54:02] Deskana: I'll be off in about 5 mins to crash and recover. Anything you'd want from me? [22:54:09] I'll be working during the day tomorrow as well [22:54:28] yuvipanda_: Not right now! I'll start that tags discussion soon, so your input on that would be great when you get a moment tomorrow. [22:54:33] Deskana: i will [22:54:37] yuvipanda_: <3 [22:54:42] :D wheeee! [22:55:45] Deskana: alright, I'm off now. cya! [22:55:48] bye, bearND ! [22:55:53] bearND: So if you're on the main page of Bugzilla, go to "Search Bugs", then click "Advanced Search". [22:56:05] bearND: With me so far? Tell me if I'm going too fast or too slow. [22:56:10] yuvipanda_: good night [22:57:09] Deskana: i've selected "Wikipedia App". any good suggestions on what to enter for the "words" field? [22:57:45] bearND: So when you've selected Wikipedia App you should probably filter to only have open bugs. [22:58:01] Deskana: you can type as fast as you'd like. irc is async, so i'll catch up eventually [22:58:19] So in the status bit, choose everything except RESOLVED and CLOSED, and leave resolution as ---. [22:59:05] The next bit, making sure you only get Android bugs, is a bit messy. [22:59:24] If you go to the Detailed Bug Information bit, and open the collapse box, there's loads of stuff in the "Version". [22:59:51] iirc all of our bugs for the Android app we're developing are filed in "Android (alpha)". [22:59:51] Deskana: i got also later and dup in the resolution field by default [23:00:06] bearND: Ah, well, take those out. Just choose ---. [23:00:42] Deskana: ok [23:01:03] Deskana: what about Android (stable)? [23:01:43] bearND: A lot of these are legacy categories. That one doesn't even have any open bugs in it. [23:02:10] bearND: To tell you the truth, I'm not sure what it's for. [23:02:12] Deskana: ok, so just Android (alpha) then [23:02:42] Because I just searched it and it doesn't appear to have any bugs in it at all, not even closed ones. [23:02:57] maybe it's for the future version, once we release? [23:03:05] bearND: Maybe yeah. [23:03:11] bearND: So now we're done! Hit search. :) [23:03:14] or it could also be for the old one [23:03:23] If you've got the same query as me, you'll have 25 bugs displaying. [23:03:40] i got 71 [23:04:07] That's probably because I ignored my instructions and chose iOS (Alpha). [23:04:23] I now have 71. :) [23:04:34] nice [23:04:44] So this is our list of open bugs! [23:04:46] Now to save it. [23:04:55] Scroll down to the bottom and there's a "Remember search as" [23:05:07] ok [23:05:16] Type something in there like "Android app open bugs", or whatever you think adequately describes the search. [23:05:19] Then hit "Remember as" [23:05:25] Sorry, "Remember search". [23:05:34] Now it'll appear in your Saved Searches on the left menu. [23:06:13] i see it [23:08:12] Deskana: are there any other recommended searches? [23:08:57] That depends on your preferences. I also have one that finds high priority bugs, but for the Mobile Apps team, prioritisation is done in Trello rather than Bugzilla, so that field is a bit meaningless. [23:09:12] i see [23:09:22] I also track closed bugs for some projects. [23:09:28] I think that'll probably do you for now. :) [23:09:40] ok, thanks :) [23:10:55] No problem! [23:11:03] Entering a bug is fairly self-explanatory I think. [23:11:22] We have a script called Bugello that automatically ports bugs from Bugzilla into Trello cards. [23:11:33] Deskana: are you working on any other projects? [23:11:57] bearND: Mobile Apps takes up most of my time, but there are few others I've got on the go. [23:12:11] Such as these... [23:12:11] https://www.mediawiki.org/wiki/SecurePoll_Redesign [23:12:20] https://www.mediawiki.org/wiki/SUL_finalisation [23:12:27] https://www.mediawiki.org/wiki/Search [23:13:07] As you can probably tell from my job title containing the word associate, I'm still learning the ropes of product management. :) [23:14:30] Deskana: ok, i'll give it a shot. still want to try out a few things first before i submit. i'm getting different behavior on my two devices i got [23:14:50] Hmm, interesting! [23:15:02] What's the behaviour? [23:15:27] on my 4.1 device i get stuck at the create account page, but on my 2.3.4 device i get to the captcha page, but haven't been able an account even then [23:18:50] Are they both on wifi or are they on cellular data? [23:19:08] wifi only [23:19:08] Just trying to rule out the possibility that one's on an IP that's blocked with account creation disabled. [23:19:10] Oh, yeah, that sounds wrong then. :) [23:20:08] Deskana: bearND I'm getting this behaviour on my tablet... looking into it now. [23:25:59] 3MobileFrontend / 3General/Unknown: Don't try to load VisualEditor in namespaces where it isn't supported - 10https://bugzilla.wikimedia.org/64681 (10Jon) 5PAT>3RES/FIX [23:27:14] 3MobileFrontend / 3General/Unknown: MobileFrontend "last edited" strapline sometimes wrong (reports non-edits) - 10https://bugzilla.wikimedia.org/64937#c5 (10Jared Zimmerman (WMF)) I'm going to agree that edited in this context is more in the spirit of the point of this. As we expand the ability to make smal... [23:28:59] 3MobileFrontend / 3General/Unknown: MobileFrontend "last edited" strapline sometimes wrong (reports non-edits) - 10https://bugzilla.wikimedia.org/64937#c6 (10Jon) So.. won't fix? [23:33:40] Deskana: dbrant: it works on my GB phone now. my 4.1.1 tablet still gets stuck on the new account page. not sure if the action in the action bar is disabled. i don't see anything in the log file after hitting it. [23:34:29] bearND: I have an idea of what's going on... patching now. [23:34:40] dbrant: cool [23:35:12] dbrant: i better submit that bug [23:36:12] i need sleep! see ya all tomorrow [23:41:12] 3Wikipedia App / 3Generic: account creation stuck on tablet - 10https://bugzilla.wikimedia.org/65275 (10Bernd Sitzmann) 3NEW p:3Unprio s:3normal a:3None On my 4.1.1 device i get stuck at the create account page. The send to action seems disabled. I don't see any log entry when I click it. Steps to... [23:41:33] dbrant: i'm trying to figure out the code. i assume it's in the CreateAccountActivity. where would i find something about the action in the action bar [23:42:07] bearND: nope, I think I've got it: [23:42:12] btw, i submitted the bug [23:42:58] (03PS1) 10Dbrant: Fixed NonEmptyValidator to work with all devices. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/133192 (https://bugzilla.wikimedia.org/65275) [23:43:10] bearND: ^ try that [23:43:18] ok, ty [23:44:11] bearND: if that works, I'll explain the logic behind it [23:45:23] dbrant: bingo, that did it [23:46:10] bearND: So, the "onCreateOptionsMenu" function is where the menu item(s) are enabled/disabled... [23:46:56] and then there's the "NonEmptyValidator" that gets bound to a series of EditText's and checks if they become empty/nonempty... [23:46:58] dbrant: sure [23:48:21] The NonEmptyValidator gives us a callback function where we call "invalidateOptionsMenu", which causes "onCreateOptionsMenu" to be called again, and thus the enable/disable state to be updated. [23:49:06] So, the actual state of the NonEmptyValidator was being set *after* the callback was called! [23:49:28] I actually don't know why it's been working this whole time... [23:50:15] dbrant: i also don't understand why this did not affect GB [23:51:01] bearND: lol well apparently it's been working on all of our test devices, except yours! [23:51:52] dbrant: but you were able to repo as well, weren't you? [23:52:53] bearND: I've actually just started using a new (old) tablet with 4.1 on it, and that's the only device on which I could repo. [23:53:22] (03CR) 10BearND: [C: 032 V: 032] "Thanks for the fast turn around. Works like a charm now." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/133192 (https://bugzilla.wikimedia.org/65275) (owner: 10Dbrant) [23:53:56] dbrant: yay for using old devices ;) [23:54:04] bearND: nice! [23:55:17] bearND: you only need to click +2 for Code Review. The +2 Verify is done by Jenkins [23:55:18] (03CR) 10Mattflaschen: "External code should be tested, but it should be tested in the external repo. Those tests can then be run before a new version is importe" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/131897 (owner: 10Kaldari) [23:57:37] dbrant: is jenkins really doing a build for our app? i don't understand why the test project didn't compile for me when i started. that should've been caught earlier by jenkins. [23:58:28] bearND: the way I understand it, at the moment jenkins only does a code style check, not a full build (we're working on that). [23:58:47] dbrant: ok. heading off for a bit. i'll try to look at the other patches later today or tomorrow morning. [23:59:07] bearND: me too! see ya later