[00:02:44] <wikibugs>	 3MobileFrontend / 3General/Unknown: MobileFrontend "last edited" strapline sometimes wrong (reports non-edits) - 10https://bugzilla.wikimedia.org/64937 (10Jared Zimmerman (WMF)) 5PAT>3RES/WON
[00:03:28] <grrrit-wm>	 (03CR) 10Kaldari: "FWIW, our version isn't a carbon copy of the external code (nor are the tests). Our version creates the init function within mw.mobileFron" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/131897 (owner: 10Kaldari)
[00:17:29] <wikibugs>	 3MobileFrontend / 3General/Unknown: MobileFrontend "last edited" strapline sometimes wrong (reports non-edits) - 10https://bugzilla.wikimedia.org/64937#c7 (10Ori Livneh) 5RES/WON>3REO Speaking of history: "WONTFIX" has a history of being used passive-aggressively, so it should be no surprise that it come...
[00:31:11] <grrrit-wm>	 (03PS4) 10Kaldari: Adding fork of Storer-light.js for client-side storage [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/131897 
[00:31:45] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Adding fork of Storer-light.js for client-side storage [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/131897 (owner: 10Kaldari)
[00:31:50] <grrrit-wm>	 (03CR) 10Kaldari: "I moved it out of the external directories, since it's technically a fork." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/131897 (owner: 10Kaldari)
[00:42:31] <grrrit-wm>	 (03PS2) 10Dr0ptp4kt: Support Zero: namespace API read of configs sans IPs. [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/133039 
[00:43:29] <wikibugs>	 3MobileFrontend / 3General/Unknown: MobileFrontend "last edited" strapline sometimes wrong (reports non-edits) - 10https://bugzilla.wikimedia.org/64937#c8 (10MZMcBride) (In reply to Ori Livneh from comment #7) > Speaking of history: "WONTFIX" has a history of being used > passive-aggressively, so it should b...
[01:00:50] <grrrit-wm>	 (03PS3) 10Dr0ptp4kt: Support Zero: namespace API read of configs sans IPs. [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/133039 
[04:09:16] <grrrit-wm>	 (03CR) 10Ori.livneh: "Falling back to cookies for storage is bad: we should be very deliberate and conservative with which cookies we set, and providing a gener" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/131897 (owner: 10Kaldari)
[04:17:30] <wikibugs>	 3MobileFrontend / 3General/Unknown: MobileFrontend "last edited" strapline should not include authorship information - 10https://bugzilla.wikimedia.org/64921#c23 (10MZMcBride) (In reply to Ryan Kaldari from comment #22) > I'm not sure I understand what your interpretation of WONTFIX is. According > to https:...
[04:55:14] <wikibugs>	 3MobileFrontend / 3General/Unknown: MobileFrontend "last edited" strapline should not include authorship information - 10https://bugzilla.wikimedia.org/64921#c24 (10Ryan Kaldari) >Resolved/wontfix typically means "we're never, ever going to do this, so stop >asking."  That was back when we had RESOLVED LATER...
[07:34:39] <grrrit-wm>	 (03PS4) 10Yurik: Support Zero: namespace API read of configs sans IPs. [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/133039 (owner: 10Dr0ptp4kt)
[07:41:12] <grrrit-wm>	 (03CR) 10Yurik: [C: 04-1] "Adam, pls take a look at my last 3..4 patch - fixed a number of minor issues." [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/133039 (owner: 10Dr0ptp4kt)
[11:41:32] <grrrit-wm>	 (03CR) 10Liangent: Support position fixed on Trident (newer IE versions) (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/133088 (https://bugzilla.wikimedia.org/65118) (owner: 10Jdlrobson)
[12:34:38] <wikibugs>	 3MobileFrontend / 3General/Unknown: MobileFrontend "last edited" strapline should not include authorship information - 10https://bugzilla.wikimedia.org/64921#c25 (10MZMcBride) (In reply to Ryan Kaldari from comment #24) >> Resolved/wontfix typically means "we're never, ever going to do this, so stop >> askin...
[12:49:52] <wikibugs>	 3MobileFrontend / 3General/Unknown: MobileFrontend "last edited" strapline should not include authorship information - 10https://bugzilla.wikimedia.org/64921#c26 (10Andre Klapper) (In reply to MZMcBride from comment #23) > That seems to be Andre's interpretation of resolved/wontfix.   The interpretation of W...
[12:55:55] <wikibugs>	 3MobileFrontend / 3General/Unknown: MobileFrontend "last edited" strapline should not include authorship information - 10https://bugzilla.wikimedia.org/64921#c27 (10MZMcBride) (In reply to Andre Klapper from comment #26) > (In reply to MZMcBride from comment #23) >> That seems to be Andre's interpretation of...
[13:45:50] <grrrit-wm>	 (03PS2) 10Jdlrobson: Support position fixed on Trident (newer IE versions) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/133088 (https://bugzilla.wikimedia.org/65118) 
[13:50:10] <grrrit-wm>	 (03CR) 10Liangent: Support position fixed on Trident (newer IE versions) (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/133088 (https://bugzilla.wikimedia.org/65118) (owner: 10Jdlrobson)
[14:10:35] <moizsyed>	 @jdlrobson you will like this: http://www.remadeco.org/
[14:10:43] * jdlrobson  looks

[14:11:17] <jdlrobson>	 moizsyed: that's where i got my t-shir
[14:11:52] <jdlrobson>	 well i assume it's related to http://www.bestmadeco.com/
[14:11:54] <moizsyed>	 jdlrobson: haha no, that was http://www.bestmadeco.com/
[14:12:14] <moizsyed>	 jdlrobson: they're making fun of best made
[14:13:05] <jdlrobson>	 moizsyed:are u back in san francisco?
[14:13:14] <moizsyed>	 jdlrobson: no in sf
[14:13:21] <moizsyed>	 jdlrobson: in toronto, i mean
[14:13:24] <jdlrobson>	 i'm currently sitting out in the sun in a plaza in florence - very good remote working location ;-)
[14:13:47] <moizsyed>	 jdlrobson: oh god, im jealous 
[14:14:06] <jdlrobson>	 this city is awesome. i need to explore working half the time here ;-)
[14:38:56] <grrrit-wm>	 (03PS1) 10Cmcmahon: QA Progress bar does not appear for Firefox, only Chrome [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/133247 
[15:16:08] <wikibugs>	 3MobileFrontend / 3General/Unknown: MobileFrontend "last edited" strapline should not include authorship information - 10https://bugzilla.wikimedia.org/64921#c28 (10Quim Gil) This discussion beyond the topic of the bug report should be moved somewhere else, or we will repeat it again in another bug report....
[15:29:04] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 04-1] "I know you don't like these but I think we should probably add a FIXME or at least a comment explaining why this doesn't work on Firefox a" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/133247 (owner: 10Cmcmahon)
[15:29:41] <grrrit-wm>	 (03PS5) 10Jdlrobson: Hygiene: Sensible defaults for textarea elements [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/131881 
[15:30:11] <grrrit-wm>	 (03PS3) 10Jdlrobson: Support position fixed on Trident (newer IE versions) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/133088 (https://bugzilla.wikimedia.org/65118) 
[15:36:27] <YuviPanda>	 hey dbrant / bearND!
[15:36:38] <dbrant>	 YuviPanda: hello!
[15:36:50] <YuviPanda>	 morning! 
[15:36:52] <dbrant>	 YuviPanda: how is Glasgow today?
[15:36:54] <bearND>	 YuviPanda: dbrant: hello
[15:37:10] <YuviPanda>	 Got an EU to UK adapter, so I have an US -> Indian -> EU -> UK plug setup going :D
[15:37:17] <dbrant>	 ha!
[15:37:25] <YuviPanda>	 dbrant: cold :)
[15:41:19] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 04-1] "Breaks upload and edit overlays - the continue button has no underline and the textarea gets crushed up against the header." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/133170 (owner: 10Kaldari)
[15:41:25] <bearND>	 dbrant: i'm going to mark the bug i submitted yesterday as fixed
[15:41:38] <bearND>	 the one you fixed, dbrant
[15:41:42] <dbrant>	 bearND: sure
[15:42:22] <wikibugs>	 3Wikipedia App / 3Generic: account creation stuck on tablet - 10https://bugzilla.wikimedia.org/65275 (10Bernd Sitzmann) 5PAT>3RES/FIX
[15:42:31] <YuviPanda>	 bearND: re: jenkins. it just runs checkstyle for now. We don't have it building things yet because the sdk isn't on our buildserver and I haven't managed to figure out how to get it there in a puppetized way
[15:42:48] <grrrit-wm>	 (03PS2) 10Cmcmahon: QA Progress bar does not appear for Firefox, only Chrome [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/133247 
[15:42:49] <grrrit-wm>	 (03CR) 10Liangent: Support position fixed on Trident (newer IE versions) (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/133088 (https://bugzilla.wikimedia.org/65118) (owner: 10Jdlrobson)
[15:43:06] <grrrit-wm>	 (03CR) 10Cmcmahon: "Good point, amended with a comment" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/133247 (owner: 10Cmcmahon)
[15:43:55] <grrrit-wm>	 (03PS3) 10Cmcmahon: QA Progress bar does not appear for Firefox, only Chrome [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/133247 
[15:45:07] <bearND>	 YuviPanda: good to know. once the basic build is going then we'll also have fun trying to get an emulator going on the build server
[15:45:17] <YuviPanda>	 bearND: yeah! definitely
[15:45:31] <bearND>	 YuviPanda: one of these days i'm also going to figure out what flake8 and zuul are.
[15:46:23] <YuviPanda>	 bearND: you should meet our CI folks. come over to #wikimedia-operations channel?
[15:49:56] <grrrit-wm>	 (03CR) 10Jdlrobson: Support position fixed on Trident (newer IE versions) (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/133088 (https://bugzilla.wikimedia.org/65118) (owner: 10Jdlrobson)
[15:50:16] <grrrit-wm>	 (03PS4) 10Jdlrobson: Support position fixed on Trident (newer IE versions) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/133088 (https://bugzilla.wikimedia.org/65118) 
[16:45:35] <grrrit-wm>	 (03CR) 10BearND: [C: 032] "Was not able to reproduce the bug with the original code, but the code changes make sense." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/132955 (https://bugzilla.wikimedia.org/64493) (owner: 10Dbrant)
[16:46:07] <grrrit-wm>	 (03CR) 10BearND: [V: 031] "Was not able to reproduce the bug with the original code, but the code changes make sense." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/132955 (https://bugzilla.wikimedia.org/64493) (owner: 10Dbrant)
[16:46:46] <bearND>	 YuviPanda: do i need to +2 in the verify section, too?
[16:46:57] <grrrit-wm>	 (03Merged) 10jenkins-bot: Fixed crash when fragment is detached from Activity. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/132955 (https://bugzilla.wikimedia.org/64493) (owner: 10Dbrant)
[16:47:36] <bearND>	 guess not since it merged
[16:53:02] <dbrant|lunch>	 bearND: jenkins does the +2 Verify
[16:56:08] <bearND>	 dbrant|lunch: i got some errors in the gerrit ui when i submitted the cr, talking about verify
[16:56:21] <bearND>	 dbrant|lunch: but it seems to have worked out
[16:59:56] <yurik>	 dr0ptp4kt, around?
[17:00:09] <dr0ptp4kt>	 yurik yes
[17:00:15] <YuviPanda>	 bearND: ah, so you just hit cr+2 and publish, not submit
[17:00:17] <yurik>	 have you seen my comments?
[17:00:20] <YuviPanda>	 bearND: jenkins does the v+2 and submits
[17:00:53] <dr0ptp4kt>	 yurik no
[17:01:15] <yurik>	 dr0ptp4kt, https://gerrit.wikimedia.org/r/#/c/133039/
[17:02:39] <YuviPanda>	 dr0ptp4kt: I also left some comments on the mcc patch
[17:05:18] <bearND>	 YuviPanda: ok, will just hit publish comments for https://gerrit.wikimedia.org/r/#/c/133092/1. should i rebase first?
[17:05:48] <YuviPanda>	 bearND: ya, I always rebase. We should at some point configure gerrit to require a rebase, I think
[17:06:03] <bearND>	 YuviPanda: k
[17:06:08] <grrrit-wm>	 (03PS2) 10BearND: Update table of contents after editing page. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/133092 (https://bugzilla.wikimedia.org/64447) (owner: 10Dbrant)
[17:06:27] <grrrit-wm>	 (03CR) 10BearND: [C: 032] Update table of contents after editing page. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/133092 (https://bugzilla.wikimedia.org/64447) (owner: 10Dbrant)
[17:06:30] <YuviPanda>	 bearND: had a look around the codebase so far? how's it look like?
[17:06:46] <grrrit-wm>	 (03Merged) 10jenkins-bot: Update table of contents after editing page. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/133092 (https://bugzilla.wikimedia.org/64447) (owner: 10Dbrant)
[17:07:22] <YuviPanda>	 bearND: I am going to make a release now.
[17:07:29] <bearND>	 YuviPanda: looking at bits and pieces so far, mainly around the changes i reviewed and some more in the page package
[17:07:37] <YuviPanda>	 bearND: you and dbrant|lunch should be able to get the keys next week in the office!
[17:07:43] <YuviPanda>	 signing keys, that is
[17:08:01] <YuviPanda>	 bearND: cool. EditSectionActivity is a bit of a mess, but otherwise things aren't *too* bad
[17:08:19] <YuviPanda>	 bearND: me and dbrant|lunch are trying to add javadocs to every method we touch from now on, though
[17:08:22] <yurik>	 dr0ptp4kt, so, are we deploying anything otherwise?
[17:09:30] <YuviPanda>	 bearND: would be nice if you could do that too :)
[17:10:20] <bearND>	 YuviPanda: we'll be in the office for the last week on the month, not next week. i'd be happy to do releases and push to the store
[17:10:34] <YuviPanda>	 bearND: ah, right. you should be able to get the keys then :)
[17:10:46] <YuviPanda>	 bearND: yeah, we push to the store on alpha channel pretty frequently. I might do one in a bit.
[17:10:54] <YuviPanda>	 bearND: there's also a make-release.sh script
[17:10:56] <YuviPanda>	 in scripts/
[17:11:00] <dr0ptp4kt>	 yurik, let's go with what you did there. i'll +2. i think we really ought to have a separate role for brandon's id, which we can take care of next week (his id can just keep the full zeroadmin right for now). i don't want the phantomjs job's corresponding mediawiki id to have access to the ips given that it's running in labs. i want it to be so that if that account gets popped there's no risk of the ips being disclosed. 
[17:11:06] <YuviPanda>	 bearND: brb, grabbing some grub before standup
[17:12:02] <wikibugs>	 3MobileFrontend / 3Feature requests: Bare Special:Contributions (without subpage) shouldn't be caught by mobile - 10https://bugzilla.wikimedia.org/65039 (10Jon)
[17:12:02] <yurik>	 dr0ptp4kt, ok, lets introduce zero-script and zero-script-ips  rights
[17:12:37] <YuviPanda>	 bearND: back.
[17:12:49] <YuviPanda>	 bearND: also we don't do self merges for anything, except version bumps. even those if someone else is available they shold do it
[17:12:54] <dr0ptp4kt>	 yurik, can you make the code change now? i need to update the sos wall and etherpad. alternatively, can we just go with what we have and worry about modifying next week? i don't want us to miss this window in any case.
[17:13:11] <yurik>	 ok, +2
[17:13:25] <grrrit-wm>	 (03CR) 10Dr0ptp4kt: [C: 032] Support Zero: namespace API read of configs sans IPs. [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/133039 (owner: 10Dr0ptp4kt)
[17:13:34] <dr0ptp4kt>	 yurik, done, you wanna get the mediawiki-config one?
[17:13:38] <grrrit-wm>	 (03Merged) 10jenkins-bot: Support Zero: namespace API read of configs sans IPs. [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/133039 (owner: 10Dr0ptp4kt)
[17:13:41] <yurik>	 will do
[17:14:21] <dr0ptp4kt>	 YuviPanda: thx for the review; brain was tired, hoping if no fires today to address. i think we should stick to just once per session, but am cool factoring out...it just needs to be synchronous in the local call chain to ensure that the header is indeed added to the message preflight :)
[17:14:39] <dr0ptp4kt>	 yurik, holler at me if you need me to check anything... off to the sos wall / etherpad i go for now
[17:14:51] <yurik>	 dr0ptp4kt, k
[17:15:14] <chrismcmahon>	 jdlrobson:  are you OK to merge https://gerrit.wikimedia.org/r/#/c/133247 ? Seems like a long time ago that we had the discussion about the progress bar, but I guess it wasn't really very long ago at all. 
[17:15:42] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 032] QA Progress bar does not appear for Firefox, only Chrome [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/133247 (owner: 10Cmcmahon)
[17:15:50] <jdlrobson>	 chrismcmahon: yeh that's fine - hadn't seen your follow up :)
[17:16:02] <jdlrobson>	 jgonera would say it should be a FIXME but he's not here ;-)
[17:16:25] <chrismcmahon>	 I don't know what there would be to fix really. 
[17:16:34] <grrrit-wm>	 (03PS5) 10Jdlrobson: Adding fork of Storer-light.js for client-side storage [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/131897 (owner: 10Kaldari)
[17:17:09] <grrrit-wm>	 (03Merged) 10jenkins-bot: QA Progress bar does not appear for Firefox, only Chrome [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/133247 (owner: 10Cmcmahon)
[17:17:23] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Adding fork of Storer-light.js for client-side storage [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/131897 (owner: 10Kaldari)
[17:17:52] <grrrit-wm>	 (03CR) 10Jdlrobson: "Ori raises a good point... and also on mobile cookies, are not needed - pretty much every mobile browser that we care about supports local" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/131897 (owner: 10Kaldari)
[17:18:49] <awjr>	 MaxSem: can you ask kaldari to hop on irc?
[17:20:14] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 04-1] Adding fork of Storer-light.js for client-side storage (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/131897 (owner: 10Kaldari)
[17:22:16] <grrrit-wm>	 (03CR) 10Kaldari: "I don't understand why falling back to cookies is a bad idea. Isn't using cookies better than failing to store the data??" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/131897 (owner: 10Kaldari)
[17:24:26] <YuviPanda>	 bearND: all our tests don't pass atm, I think. Think you can get them to? :)
[17:24:30] <jdlrobson>	 https://gerrit.wikimedia.org/r/#/c/132352/1 < awjr that /might/ be the patch but not at all clear
[17:24:53] <awjr>	 hmm
[17:25:50] <awjr>	 jdlrobson: looks possibe since that card is about adding the ooui components
[17:26:08] <bearND>	 YuviPanda: i think it's a classpath issue. i'll probably try to rearrange the dependencies in the test project
[17:26:24] <awjr>	 also maybe https://gerrit.wikimedia.org/r/#/c/132355/ ? jdlrobson
[17:26:29] <YuviPanda>	 bearND: oh? I thought it was just broken code
[17:27:07] <jdlrobson>	 awjr: i poked VE team but no reply - kaldari if you can can you grab them in person?
[17:27:17] <awjr>	 jdlrobson: it is too bad we can't make trello force you to include a comment with a link to patchset
[17:27:33] <awjr>	 jdlrobson: roan may still be traveling but trevor should be around i think
[17:27:52] <kaldari>	 jdlrobson: Sorry, my IRC was broken and I don't have the backlog. What am I buggin VE team about?
[17:28:01] <grrrit-wm>	 (03PS5) 10Jdlrobson: Cleanup and improve supportsPositionFixed [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/133088 (https://bugzilla.wikimedia.org/65118) 
[17:28:53] <YuviPanda>	 dbrant|lunch: and yay for profiling. I'm suspicious it is just the fact that we keep the fragments around (with .add instead of .replace), though
[17:28:56] <jdlrobson>	 kaldari:  trying to locate patch for https://trello.com/c/TXRBDuld/4-8-add-references-through-visual-editor
[17:29:01] <grrrit-wm>	 (03PS1) 10Yuvipanda: Bump version number to 2.0-alpha-2014-05-14 [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/133279 
[17:29:19] <YuviPanda>	 bearND: the meeting has been rescheduled by an hour, I think
[17:29:21] <dbrant>	 YuviPanda: yeah, I'm sure that's not helping matters...
[17:29:47] <YuviPanda>	 dbrant: yeah. the problem with just doing .replace is that I'm not clear on the lifecycle of the fragment when it is in that state. Also restoring scroll state was painful.
[17:30:00] <awjr>	 jdlrobson: kaldari MaxSem did juliusz delegate attending to scrum of scrums to any of you?
[17:30:15] <YuviPanda>	 dbrant: specifically, state of a fragment when it is in the fragment backstack.
[17:30:20] <jdlrobson>	 awjr: nope i only learnt he was on vacation this morning - i somehow missed that
[17:30:39] <YuviPanda>	 dbrant: can you +2 the version bump patch?
[17:31:03] <dbrant>	 YuviPanda: yep...
[17:31:16] <kaldari>	 jdlrobson: Oh, that was my patch. One sec...
[17:31:43] <bearND>	 YuviPanda: yes, i just accepted the updated meeting
[17:31:52] <kaldari>	 jdlrobson: oops wrong card, nevermind
[17:32:24] <YuviPanda>	 bearND: cool!
[17:33:48] <bearND>	 YuviPanda: about the tests: i'm getting this in logcat: java.lang.ClassNotFoundException: org.junit.Test. this is why i think i want to change the order of the dependencies
[17:34:18] <YuviPanda>	 bearND: oh ah, that might be, yeah. I am ashamed to say I haven't run them in a long time :|
[17:34:21] <YuviPanda>	 running them now, let's see what happens
[17:34:40] <jdlrobson>	 brb gotta dry some washing
[17:34:55] <kaldari>	 jdlrobson: added link to some likely patches to the Trello card
[17:35:26] <YuviPanda>	 bearND: hmm, I'm not getting that. I'm getting just actual test failures
[17:36:03] <grrrit-wm>	 (03CR) 10Dbrant: [C: 032] Bump version number to 2.0-alpha-2014-05-14 [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/133279 (owner: 10Yuvipanda)
[17:37:10] <bearND>	 YuviPanda: are you running from command line?
[17:37:11] <YuviPanda>	 dbrant: ty
[17:37:44] <YuviPanda>	 Maryana: hey!
[17:39:05] <jdlrobson>	 kaldari: Maryana according to krinkle ": So when editing a citation, the dialog looks like that screenshot there"
[17:39:24] <jdlrobson>	 "Krinkle: There is still some work left to be done with allowing simple creation of new citations (eg. not having to know the name of the template). I don't know the progress on that, could be done, might be WIP."
[17:39:59] <jdlrobson>	 kaldari: https://gerrit.wikimedia.org/r/131892 was the patch i wanted merged to help ve performance
[17:40:10] <jdlrobson>	 would be good to get this in before deploy branch is cut
[17:44:38] <kaldari>	 jdlrobson: That sounds like very old information.
[17:45:13] <kaldari>	 jdlrobson: unless Krinkle is talking about some interface I've never heard of
[17:45:16] <jdlrobson>	 mmm
[17:45:18] <jdlrobson>	 i have no idea then
[17:45:33] <jdlrobson>	 this is annoying - luckily jgonera is back on monday
[17:45:33] <jdlrobson>	 (according to his mail)
[17:45:43] <jdlrobson>	 hopefully we can work it out
[17:45:47] <jdlrobson>	 i'd hate to repeat work
[17:48:05] <YuviPanda>	 bearND: no, running from intelliJ
[17:48:09] <YuviPanda>	 bearND: let me try from commandline
[17:49:27] <Maryana>	 YuviPanda: ho!
[17:49:33] <YuviPanda>	 Maryana: you're alive! :)
[17:49:40] <Maryana>	 i am. are you?
[17:49:54] <YuviPanda>	 Maryana: for now, but let's see in 2 weeks :)
[17:49:59] <Maryana>	 hehe
[17:50:03] <YuviPanda>	 Maryana: pushed out a release. Is deskana around?
[17:50:12] <yurik>	 dr0ptp4kt, deployed
[17:50:23] <Maryana>	 YuviPanda: i think he's in ohio..?
[17:50:24] <dr0ptp4kt>	 yurik, thx
[17:50:32] <YuviPanda>	 Maryana: oh, right. ok.
[17:50:39] <Maryana>	 my email backlog is ridic, and i thought i was doing a good job triaging it :(
[17:50:50] <YuviPanda>	 Maryana: heh, I'll let you get back to it then :)
[17:51:09] <dr0ptp4kt>	 yurik it seems to work
[17:53:59] <kaldari>	 jdlrobson: I'm a bit confused by your comments on Storer. You suggest that it shouldn't be attached to mediawiki. or M., but you also say it should be in a closure. The function has to be accessible from other parts of the codebase though, so if I put it in a closure it has to be attached to something global. Should I attach it to jQuery instead?
[17:54:25] <YuviPanda>	 bearND: running from the commandline too. I don't get junit not found. That works. I am getting actual test failures because of out of date tests
[17:54:27] <jdlrobson>	 kaldari: so the library has no dependency on mediawiki or mw
[17:54:36] <jdlrobson>	 kaldari: thus we shouldn't give it a dependency there
[17:54:39] <kaldari>	 correct, nor jQuery
[17:54:48] <jdlrobson>	 attaching it to jQuery would make sense - how does Shayar's version do it?
[17:54:55] <YuviPanda>	 bearND: re: IRC. What IRC client are you using?
[17:55:07] <jdlrobson>	 actually why can't you just attach to window?
[17:55:20] <jdlrobson>	 (i thought it had a jQuery dependency )
[17:55:21] <kaldari>	 Shayar's version just created the function in global space, which you can't do in resourceLoader
[17:55:33] <kaldari>	 unless you attach to window
[17:55:54] <kaldari>	 I could do that instead
[17:57:04] <jdlrobson>	 yeh that should be fixed in Shayar's patch - that seems a bad aspect of his library
[17:57:29] <kaldari>	 I just didn't think people would want it in the global namespace since we seem to be extremely paranoid of doing that in MediaWiki
[17:58:16] <kaldari>	 but if you think it's OK, I'll add it to Shayar's patch and go back to using that
[17:58:19] <bearND>	 YuviPanda: adium
[17:58:30] <YuviPanda>	 bearND: cool. does it notify you everytime someone mentions your name?
[17:58:38] <YuviPanda>	 bearND: I prefer LimeChat, but Adium and Textual have many fans too
[17:58:43] <YuviPanda>	 (assuming OS X)
[17:59:30] <bearND>	 YuviPanda: it does add a star in the chat window and makes the app icon shake
[18:00:00] <YuviPanda>	 bearND: hmm, limechat gives me a notification on the top right no matter which app you are in, and that is really useful
[18:00:15] <bearND>	 YuviPanda: i just switched device, and ran the tests again, and get farther. some tests are failing as you've already mentioned
[18:00:53] <YuviPanda>	 bearND: cool. I'll create a card on Trello and add you to it. The way we use trello should be clearer after today's meeting, I think
[18:01:11] <YuviPanda>	 bearND: also you can give IRC commands by starting a line with slash. /nick bearND|lunch will change your nick to that, for example
[18:01:16] <YuviPanda>	 bearND: that's the most common way to set status
[18:01:53] <bearND>	 YuviPanda: i see. ty
[18:02:25] <YuviPanda>	 bearND: you can also privately message people by doing /msg <nick> <message>. That would open a new window, and you can continue talking normally in PM there
[18:02:59] <YuviPanda>	 bearND: it is customary to ask in a public channel for permission before PMing someone, unless that person has already said 'PM me anytime' or somesuch
[18:04:26] <bearND>	 YuviPanda: mind if i try to PM you?
[18:04:34] <YuviPanda>	 bearND: feel free!
[18:05:21] <YuviPanda>	 bearND: you can also start a message with /me and it displays differently, as an 'action'
[18:05:25] * YuviPanda  waves

[18:06:17] * bearND  testing action

[18:06:23] <bearND>	 cool
[18:06:25] <YuviPanda>	 :)
[18:07:16] <YuviPanda>	 bearND: there are also plenty of other channels. #wikimedia-operations is fun to follow (once you ignore the icinga bot!). -staff you already have seen. There's  also #wikimedia-dev which is fairly active and is for general wikimedia dev stuff
[18:07:28] <YuviPanda>	 bearND: I suggest joining #wikimedia-dev as well :)
[18:07:48] <YuviPanda>	 bearND: I usually 'idle' on IRC, and have learnt a *lot* just from passively following conversations between other people
[18:08:05] <bearND>	 YuviPanda: ok, i've been to #wikimedia-qa this morning as well
[18:08:11] <bearND>	 for jenkins
[18:08:14] <YuviPanda>	 bearND: ah, yeah. cool!
[18:09:23] <dbrant>	 I've been using Colloquy on my Mac, but I'll try Limechat
[18:10:27] <bearND>	 YuviPanda: so, i got three test failures/errors: PageTests.testJSONSerialization, PageTitleTests.testFromInternalLink; PreviewTaskTests crashed
[18:11:48] <bearND>	 YuviPanda: i've tried limechat before but i do like how aduim colors different people in the chat window. makes it easier to distiguish between the noisy announcements
[18:12:00] <YuviPanda>	 bearND: cool!
[18:12:49] <YuviPanda>	 bearND: right. I think all those are things that were modified in the code but the tests haven't been updated :(
[18:13:02] <YuviPanda>	 bearND: should get more vigilant about running tests, and also have them automatically run. And also more tests!
[18:13:40] <bearND>	 YuviPanda: i'll take a look at the failures and fix them
[18:13:44] <YuviPanda>	 bearND: cool!
[18:13:52] <YuviPanda>	 bearND: smaller the commits the better, so one commit per fix? :)
[18:14:04] <YuviPanda>	 bearND: also consider adding javadoc to places you touch
[18:14:23] * dbrant  is loving it.

[18:14:30] <YuviPanda>	 :D
[18:15:54] <grrrit-wm>	 (03CR) 10Jdlrobson: "Well.. cookies are sent to the server on every request that matches the domain – including ajax calls... (see https://developers.google.co" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/131897 (owner: 10Kaldari)
[18:17:53] <grrrit-wm>	 (03CR) 10Kaldari: "I know that cookies bloat the bandwidth, but isn't it still better to have inflated bandwidth than broken functionality? Keep in mind this" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/131897 (owner: 10Kaldari)
[18:17:59] <Maryana>	 kaldari: want to spin through bugs & things after the estimation meeting?
[18:18:59] <grrrit-wm>	 (03CR) 10Kaldari: "...and cases where localStorage is full." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/131897 (owner: 10Kaldari)
[18:19:23] <bearND>	 YuviPanda: wondering if i should override equals and hashCode for Page to make the PageTests green
[18:19:39] <YuviPanda>	 bearND: don't we already override equals?
[18:19:59] <bearND>	 YuviPanda: not in that class
[18:20:09] <YuviPanda>	 bearND: oh, then definitely, yeah
[18:20:14] <YuviPanda>	 that's weird. I thought we did
[18:20:23] <kaldari>	 Maryana: sure
[18:20:25] <bearND>	 oh wait
[18:20:32] <bearND>	 i missed it
[18:20:41] <YuviPanda>	 bearND: yeah, it's there. probably just missing something.
[18:30:41] <awjr>	 kaldari: any word yet on those mocks?
[18:31:12] <kaldari>	 kaity: Are you still working on a new mock for the verticial version of the mobile VE citation interface?
[18:42:23] <kaity>	 kaldari: yes, I'll get that to you today for sure
[18:43:46] <yurik>	 dr0ptp4kt, btw, take a look at our rfc - tim suggested a very nice solution for the banners
[18:45:46] <dr0ptp4kt>	 yurik, you're talking about the <script> and <noscript>, right? yeah, that's a nice concept, just have to think through FUOCs
[18:46:27] <yurik>	 dr0ptp4kt, yep, apparently it doesn't render until script is loaded - and it the script does document.write("<bannerhtml>")
[18:46:57] <yurik>	 which by the way also removes any message-related logic from th eclient
[19:01:47] <awjr>	 moizsyed: estimation/review meeting?
[19:03:27] <jdlrobson>	 MaxSem: kaldari https://trello.com/b/sFlwoPUn/mobile-web-q4-backlog
[19:07:36] <tfinc>	 YuviPanda: bearND :)
[19:07:41] <tfinc>	 YuviPanda: bad panda. you didn't book a room for me
[19:07:43] <tfinc>	 just got one
[19:07:57] <YuviPanda>	 tfinc: ow :( I poked you on IRC and said I didn't know how and asked you to. Must've gotten lost
[19:08:11] <YuviPanda>	 tfinc: first time I'm doing this, apologies. I'll find out how later.
[19:08:56] <tfinc>	 YuviPanda: we can go over it after. i'm just starting up the office video link
[19:09:15] * tfinc  shivers from the AV today

[19:09:21] <tfinc>	 AC*
[19:13:01] <tfinc>	 bearND: YuviPanda https://www.mediawiki.org/wiki/Wikimedia_Mobile_engineering/imported/Mobile_team/Mobile_web/Roles_and_responsibilities
[19:16:55] <wikibugs>	 3Wikipedia App / 3Generic: Introduce MediaWiki:App.css or something in Extension:MobileApp - 10https://bugzilla.wikimedia.org/65037 (10Yuvi Panda) 5PAT>3RES/FIX
[19:19:20] <awjr>	 jdlrobson: kaldari MaxSem http://hatjitsu.wmflabs.org/63819
[19:20:42] <YuviPanda>	 hey vbamba
[19:33:15] <vbamba>	 hello YuviPanda
[19:33:24] <vbamba>	 i just left a note on the trello card
[19:33:26] <YuviPanda>	 vbamba: hello! how is europe? :)
[19:33:36] <vbamba>	 its exciting in many ways :)
[19:33:37] <YuviPanda>	 vbamba: will check. are you going to be working on Europe time?
[19:33:46] <YuviPanda>	 vbamba: :D Glasgow is so collldddd. 
[19:34:18] <vbamba>	 until 22nd
[19:34:51] <YuviPanda>	 vbamba: cool :) Also, IIRC, the 'log in and save' 'save anonymously' stuff will go away, right?
[19:35:46] <YuviPanda>	 vbamba: yeah, Maryana moved the license code to backlog. next sprint :)
[19:36:10] <vbamba>	 yes. correct. i wanted to check with Maryana before that - Record the conclusions and tell me and moizsyed which sprint that is for.
[19:36:27] <vbamba>	 so both of us can get the flow together, it has a dependency on onboarding
[19:36:39] <vbamba>	 ah ok, so we need it for the 26th, but not now
[19:36:47] <vbamba>	 as in not right away*
[19:38:06] <Maryana>	 so, the onboarding stuff can be done independently
[19:38:22] <Maryana>	 whether or not we decide to do in-edit CTAs to login, i think it's still a good idea to prompt people to sign in on first time app open
[19:38:47] <YuviPanda>	 Maryana: reason I'm asking is that the iOS killswitch works by just removing the 'save anonymously' option, so if that's gonna go away that needs to change to just hiding pencil icons (which is what android does)
[19:43:12] <Maryana>	 well, at that point it becomes a CTA to login :)
[19:43:46] <Maryana>	 but i think before we make any decisions, i want to map out all the current & potential workflows and see if there's some complexity i can cut
[19:44:09] <vbamba>	 Ok so basically you have to log in to save. The Sign in CTA comes after Preview.
[19:44:28] <vbamba>	 Is that correct? 
[19:44:28] <YuviPanda>	 alright. Just wanted to flag it since I kept saying the kill switch removes the pencil icon, and that's changed on iOS :)
[19:45:01] <vbamba>	 Maryana, Sorry if we are driving you a bit crazy here. 
[19:45:38] <YuviPanda>	 'tis ok, she is plotting to return the favor :)
[19:45:39] <Maryana>	 no no, it's fine - it's a really tough problem
[19:47:50] <vbamba>	 can you just summarize your thoughts on the trello card?
[19:47:56] <vbamba>	 I might get kicked of this wifi
[19:48:21] <tfinc>	 bearND: YuviPanda http://hat.jit.su/33007
[19:48:32] <YuviPanda>	 haha, prophetic vibha
[19:54:28] <awjr>	 tfinc: head's up i put a mtg on your calendar for this afternoon
[20:01:48] <YuviPanda>	 bearND: https://code.google.com/p/android-screen-monitor/
[20:03:20] <bearND>	 YuviPanda: ty
[20:03:47] <tfinc>	 YuviPanda: bearND i put a bootcamp part 2 on the calendar for tomorrow
[20:03:59] <tfinc>	 bearND: any other question on the rituals that we talked about today?
[20:04:28] <YuviPanda>	 bearND: https://trello.com/b/BW5L3PEn/mobile-app-sprint-31-main-article-browse-search
[20:15:32] <YuviPanda>	 bearND: http://wikitech.wikimedia.org/
[20:20:46] <YuviPanda>	 bearND: ssh tools-login.wmflabs.org
[20:21:58] <YuviPanda>	 bearND: ssh <shellname>@tools-login.wmflabs.org
[20:26:35] <YuviPanda>	 bearND: become android-maven-repo 
[20:28:32] <YuviPanda>	 bearND: https://gerrit.wikimedia.org/r/#/c/131246/
[20:29:09] <YuviPanda>	 bearND: apps/android/java-mwapi
[20:29:50] <kaldari>	 Maryana: I'm ready for the other 2 whenever you are
[20:31:53] <wikibugs>	 3MobileFrontend / 3beta: Mobilefrontend: Table of contents - expand clickable area at top of TOC - 10https://bugzilla.wikimedia.org/65201 (10Ryan Kaldari)
[20:33:41] <YuviPanda>	 bearND: +    <repo.url>scpexe://yuvipanda@tools-login.wmflabs.org:/home/yuvipanda/maven</repo.url>
[20:34:38] <YuviPanda>	 bearND: mediawiki.org/wiki/Wikipedia_app/Maven_repo
[20:35:11] <YuviPanda>	 bearND: https://www.mediawiki.org/wiki/Wikimedia_Apps/Maven_repo
[20:35:49] <Maryana>	 kaldari: i'm still squatting in r31 :D
[20:40:27] <bearND>	 YuviPanda: thanks for the pointers :)
[21:03:02] <grrrit-wm>	 (03PS6) 10MaxSem: Cleanup and improve supportsPositionFixed [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/133088 (https://bugzilla.wikimedia.org/65118) (owner: 10Jdlrobson)
[21:05:03] <grrrit-wm>	 (03CR) 10MaxSem: [C: 032] "Just added a couple more UAs to tests." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/133088 (https://bugzilla.wikimedia.org/65118) (owner: 10Jdlrobson)
[21:05:38] <grrrit-wm>	 (03Merged) 10jenkins-bot: Cleanup and improve supportsPositionFixed [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/133088 (https://bugzilla.wikimedia.org/65118) (owner: 10Jdlrobson)
[21:21:07] <wikibugs>	 3MobileFrontend / 3General/Unknown: Show what features are included in Beta and Experimental on mobile. - 10https://bugzilla.wikimedia.org/65079#c2 (10Ryan Kaldari) Any suggestions on how this would be shown to the user?
[21:22:32] <YuviPanda>	 bearND: you're welcome!
[21:25:22] <wikibugs>	 3MobileFrontend / 3General/Unknown: Show what features are included in Beta and Experimental on mobile. - 10https://bugzilla.wikimedia.org/65079#c3 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/MJAgX3dr
[21:31:12] <grrrit-wm>	 (03PS1) 10MaxSem: Fix SpecialMobileContributions continuation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/133365 (https://bugzilla.wikimedia.org/65266) 
[21:32:50] <dbrant>	 YuviPanda: I've got a couple of observations:
[21:33:00] * YuviPanda  listens

[21:33:32] <dbrant>	 YuviPanda: I got the app to crash (out of memory) after going about ~75 pages deep...
[21:34:23] <dbrant>	 YuviPanda: Now, I was also getting the rendering issues on one of my devices again (4.1) after ~20 pages...
[21:34:23] <YuviPanda>	 right. what's the stacktrace like? some people are getting a 'cannot attach window' error...
[21:37:34] <dbrant>	 YuviPanda: it's definitely not 'cannot attach window'... it happens during the http request.
[21:37:51] <YuviPanda>	 dbrant: oh.
[21:37:54] <YuviPanda>	 dbrant: did you profile it?
[21:38:11] <dbrant>	 YuviPanda: and actually, a whole lot of "benign" out-of-memory errors occur well before the app itself crashes
[21:41:28] <dbrant>	 YuviPanda: well, by "profile", I watched the heap, as well as logcat.  I've never quite done any further-detailed analysis than that.
[21:41:37] <YuviPanda>	 dbrant: ah, hmm. 
[21:41:42] <YuviPanda>	 dbrant: thoughts on potential solutions?
[21:42:01] <YuviPanda>	 dbrant: I am pretty sure that we can't keep instantiating webviews and expecting it to just work
[21:42:20] <dbrant>	 YuviPanda: that is true!...
[21:42:25] <YuviPanda>	 dbrant: perhaps we could remove fragments from the back of the stack and keep, say, only the last 10 or something?
[21:42:43] <dbrant>	 YuviPanda: that would be my first thought...
[21:43:01] <dbrant>	 YuviPanda: do we know how it's handled on iOS?
[21:43:19] <YuviPanda>	 dbrant: I don't know. mhurd ^
[21:43:33] <YuviPanda>	 mhurd: do you instantiate a new webview for every page? or do you reuse the same one?
[21:43:52] <YuviPanda>	 dbrant: ^ is the ultimate solution, but that's a bit of work + we never found a reliable way to restore scroll position
[21:44:02] <mhurd>	 YuviPanda: reuse one
[21:44:28] <YuviPanda>	 mhurd: hmm, so when the user does a 'back' action, how are you restoring scroll state? especially if the user was in portrait first and is now in landscape?
[21:45:12] <mhurd>	 YuviPanda: lemme check...
[21:46:25] <dbrant>	 YuviPanda: is the scroll position an issue because the page could have been edited in the meantime?
[21:47:53] <mhurd>	 YuviPanda: so when web view stops scrolling i record the y scroll offset. i use that when i load an article subsequent times. on rotate because of the issue you mention, what i do is as the rotate begins i see which section is intersecting the top of the screen, then after the rotate finishes i just scroll to the top of that section. so on rotate it’s not perfect, but it at least gets you to the section you were reading
[21:49:33] <dbrant>	 YuviPanda: how about making the scroll position be the fraction of the total page height, instead of an absolute y-offset?
[21:50:05] <mhurd>	 dbrant: landscape will flow the text differently so it wont be accurate iirc
[21:50:37] <mhurd>	 dbrant: tried that once :)
[21:55:47] <mhurd>	 dbrant: oh, if that fraction takes into account the w/h ratio i guess it *would* work… right? given same text size landscape and portrait at least...
[21:56:04] <mhurd>	 *screen w/h ratio*
[21:57:23] <wikibugs>	 3MobileFrontend / 3General/Unknown: Show what features are included in Beta and Experimental on mobile. - 10https://bugzilla.wikimedia.org/65079#c4 (10Jared Zimmerman (WMF)) @ryan  I think at minimum you'd need a name for each feature, a short single line description and a link to a talk page for each or all...
[21:57:53] <wikibugs>	 3MobileFrontend / 3General/Unknown: Show what features are included in Beta and Experimental on mobile. - 10https://bugzilla.wikimedia.org/65079#c5 (10Jared Zimmerman (WMF)) Created attachment 15389   --> https://bugzilla.wikimedia.org/attachment.cgi?id=15389&action=edit mockup for granular beta on mobile
[22:00:17] <dbrant>	 mhurd: that's what I would think...
[22:00:53] <mhurd>	 dbrant: trying it out on ios presently… would be way cool ;)
[22:18:48] <YuviPanda>	 mhurd: dbrant sorry was dragged off forcibly for food. back now.
[22:19:34] <YuviPanda>	 mhurd: dbrant so I tried the w/h thing. doesn't work because things like images take up full width of the viewport no matter what.
[22:21:52] <YuviPanda>	 dbrant: mhurd do try out!
[22:22:13] <YuviPanda>	 dbrant: and we can just pop them off the stack as a less complicated possibility
[22:22:35] <dbrant>	 YuviPanda: I’ll do some experimenting…
[22:23:07] <YuviPanda>	 dbrant: cool. I think that's our biggest remaining technical issue (not counting technical debt)
[22:25:08] <YuviPanda>	 dbrant: mhurd I'll also go to sleep early today (in about 10m), so poke if I can help with anything in the meantime
[22:25:10] <YuviPanda>	 bearND: ^
[22:25:22] <mhurd>	 YuviPanda: will do!
[22:26:04] <bearND>	 YuviPanda: sounds good
[22:33:43] <tfinc>	 bearND: YuviPanda dbrant : can i just say how much i like receiving "This should be fixed in the latest alpha version. Thank you for reporting this! " mails 
[22:34:03] <YuviPanda>	 tfinc: :D I process them once every week or so
[22:35:27] <grrrit-wm>	 (03PS6) 10Kaldari: Adding Storer-light.js for client-side storage [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/131897 
[22:36:09] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Adding Storer-light.js for client-side storage [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/131897 (owner: 10Kaldari)
[22:37:04] <grrrit-wm>	 (03PS7) 10Kaldari: Adding Storer-light.js for client-side storage [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/131897 
[22:44:12] <kaity>	 kaldari: updated https://trello.com/c/xCo6uLAZ/9-5-references-dropdown-from-toolbar-styling
[22:46:28] <grrrit-wm>	 (03PS1) 10MaxSem: Fix XSS in section handling [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/133382 (https://bugzilla.wikimedia.org/65042) 
[22:49:21] <grrrit-wm>	 (03PS1) 10MaxSem: Fix XSS in section handling [extensions/MobileFrontend] (REL1_23) - 10https://gerrit.wikimedia.org/r/133383 (https://bugzilla.wikimedia.org/65042) 
[22:49:43] <grrrit-wm>	 (03CR) 10MaxSem: [C: 032] "Already deployed." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/133382 (https://bugzilla.wikimedia.org/65042) (owner: 10MaxSem)
[22:49:55] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Fix XSS in section handling [extensions/MobileFrontend] (REL1_23) - 10https://gerrit.wikimedia.org/r/133383 (https://bugzilla.wikimedia.org/65042) (owner: 10MaxSem)
[22:49:58] <grrrit-wm>	 (03CR) 10MaxSem: [C: 032] Fix XSS in section handling [extensions/MobileFrontend] (REL1_23) - 10https://gerrit.wikimedia.org/r/133383 (https://bugzilla.wikimedia.org/65042) (owner: 10MaxSem)
[22:50:17] <grrrit-wm>	 (03Merged) 10jenkins-bot: Fix XSS in section handling [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/133382 (https://bugzilla.wikimedia.org/65042) (owner: 10MaxSem)
[22:50:37] <grrrit-wm>	 (03Merged) 10jenkins-bot: Fix XSS in section handling [extensions/MobileFrontend] (REL1_23) - 10https://gerrit.wikimedia.org/r/133383 (https://bugzilla.wikimedia.org/65042) (owner: 10MaxSem)
[22:54:26] <mhurd>	 dbrant: YuviPanda|zzz: yuvi’s right about images taking up entire viewport width making the w/h ratio approach not work. i think (hope) the present ios behavior of just scrolling back to top of whatever section had been intersecting the top of screen when rotate began is good enough for m.v.p. 
[22:56:37] <dbrant>	 mhurd: then so it shall be; I'll do some further testing...
[22:57:22] <mhurd>	 dbrant: it works nicely, however, if the page is just a uniform wall of text :) oh well
[23:01:04] <grrrit-wm>	 (03PS1) 10MaxSem: Fix XSS in section handling [extensions/MobileFrontend] (wmf/1.24wmf4) - 10https://gerrit.wikimedia.org/r/133386 (https://bugzilla.wikimedia.org/65042) 
[23:01:16] <grrrit-wm>	 (03CR) 10MaxSem: [C: 032] Fix XSS in section handling [extensions/MobileFrontend] (wmf/1.24wmf4) - 10https://gerrit.wikimedia.org/r/133386 (https://bugzilla.wikimedia.org/65042) (owner: 10MaxSem)
[23:02:57] <grrrit-wm>	 (03Merged) 10jenkins-bot: Fix XSS in section handling [extensions/MobileFrontend] (wmf/1.24wmf4) - 10https://gerrit.wikimedia.org/r/133386 (https://bugzilla.wikimedia.org/65042) (owner: 10MaxSem)
[23:04:16] <grrrit-wm>	 (03PS1) 10MaxSem: Fix XSS in section handling [extensions/MobileFrontend] (wmf/1.24wmf3) - 10https://gerrit.wikimedia.org/r/133388 (https://bugzilla.wikimedia.org/65042) 
[23:04:31] <grrrit-wm>	 (03CR) 10MaxSem: [C: 032] Fix XSS in section handling [extensions/MobileFrontend] (wmf/1.24wmf3) - 10https://gerrit.wikimedia.org/r/133388 (https://bugzilla.wikimedia.org/65042) (owner: 10MaxSem)
[23:05:14] <grrrit-wm>	 (03CR) 10MaxSem: [C: 032] "Already live in production" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/133365 (https://bugzilla.wikimedia.org/65266) (owner: 10MaxSem)
[23:05:26] <grrrit-wm>	 (03CR) 10MaxSem: [C: 04-2] Fix SpecialMobileContributions continuation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/133365 (https://bugzilla.wikimedia.org/65266) (owner: 10MaxSem)
[23:05:31] <grrrit-wm>	 (03Merged) 10jenkins-bot: Fix XSS in section handling [extensions/MobileFrontend] (wmf/1.24wmf3) - 10https://gerrit.wikimedia.org/r/133388 (https://bugzilla.wikimedia.org/65042) (owner: 10MaxSem)
[23:05:56] <grrrit-wm>	 (03CR) 10MaxSem: "Disregard the above +2, was on a merging frenzy:P" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/133365 (https://bugzilla.wikimedia.org/65266) (owner: 10MaxSem)
[23:12:21] <grrrit-wm>	 (03CR) 10MaxSem: Fix SpecialMobileContributions continuation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/133365 (https://bugzilla.wikimedia.org/65266) (owner: 10MaxSem)
[23:13:22] <wikibugs>	 3MobileFrontend / 3General/Unknown: Show what features are included in Beta and Experimental on mobile. - 10https://bugzilla.wikimedia.org/65079#c6 (10Quiddity) Those are fantastic experimental features! :D  +1 to the design mockup.
[23:24:10] <grrrit-wm>	 (03CR) 10Kaldari: "jdlrobson: Looks like the issue is something specific to Chrome. Here's what it looks like in Firefox and Safari:" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/133170 (owner: 10Kaldari)
[23:30:22] <wikibugs>	 3MobileFrontend / 3beta: Mobile Table of Contents double unescapes encoded characters - 10https://bugzilla.wikimedia.org/65042#c12 (10Max Semenik) 5NEW>3RES/FIX p:5Unprio>3Immedi s:5normal>3blocke https://gerrit.wikimedia.org/r/#/c/133382/
[23:38:21] <Maryana>	 tfinc: do you happen to have the link to our notes from the last q review syncup we had handy?
[23:38:36] <Maryana>	 iirc we had an etherpad going, but i can't find it
[23:38:42] <Maryana>	 wanted to review that agenda w/howie
[23:41:22] <wikibugs>	 3MobileFrontend / 3General/Unknown: Show what features are included in Beta and Experimental on mobile. - 10https://bugzilla.wikimedia.org/65079 (10Quiddity)
[23:46:57] <grrrit-wm>	 (03PS1) 10BearND: Fix PageTests [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/133398 
[23:52:52] <wikibugs>	 3MobileFrontend / 3General/Unknown: Device detection code doesn't detect MSIE 11 - 10https://bugzilla.wikimedia.org/65118 (10Max Semenik) 5PAT>3RES/FIX