[00:14:35] kaldari: looks like kaity added new mocks to the refs dropdown card. got everything you need? [00:25:04] awjr: yep. I think that'll do it. [00:39:18] (03PS3) 10Kaldari: Removing header margin and associated hacks [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/133170 [01:03:47] (03CR) 10Kaldari: [C: 032] Fix SpecialMobileContributions continuation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/133365 (https://bugzilla.wikimedia.org/65266) (owner: 10MaxSem) [01:04:20] (03Merged) 10jenkins-bot: Fix SpecialMobileContributions continuation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/133365 (https://bugzilla.wikimedia.org/65266) (owner: 10MaxSem) [01:11:29] 3MobileFrontend / 3alpha: Non-canonical URLs get rewritten into weird psuedo-canonical URLs in alpha - 10https://bugzilla.wikimedia.org/65327 (10Ryan Kaldari) 3NEW p:3Unprio s:3normal a:3None In alpha, if I load the URL /index.php?title=Igloo, it gets rewritten as /index.php/Igloo?title=Igloo. You ca... [01:15:22] 3MobileFrontend / 3alpha: Non-canonical URLs get rewritten into weird psuedo-canonical URLs in alpha - 10https://bugzilla.wikimedia.org/65327#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/Q97IeqrE [02:07:59] (03PS1) 10Kaldari: WIP: Formatting for citation drop-down in mobile VisualEditor [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/133408 [02:08:16] (03CR) 10Kaldari: [C: 04-2] "Work in progress" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/133408 (owner: 10Kaldari) [05:14:49] (03CR) 10Mattflaschen: "Kaldari:" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/131897 (owner: 10Kaldari) [05:16:58] (03CR) 10Mattflaschen: "Re expiration, see http://stackoverflow.com/questions/2326943/when-do-items-in-html5-local-storage-expire" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/131897 (owner: 10Kaldari) [06:19:51] (03CR) 10Siebrand: [C: 031] "i18n/L10 reviewed." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/132518 (https://bugzilla.wikimedia.org/65094) (owner: 10MaxSem) [06:21:22] (03CR) 10Siebrand: [C: 031] "L10n reviewed." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/133020 (https://bugzilla.wikimedia.org/64937) (owner: 10Kaldari) [13:47:19] (03CR) 10Jdlrobson: [C: 04-1] "More carnage unleashed by this change - http://imgur.com/QuTHeMv" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/133170 (owner: 10Kaldari) [13:49:20] (03PS5) 10Jdlrobson: Hygiene: Cleanup edit switcher css [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/132345 (https://bugzilla.wikimedia.org/64968) [13:57:15] (03PS2) 10Jdlrobson: Make border-box the default [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/133188 [14:00:23] (03PS4) 10Jdlrobson: Fix VE performance by cleaning up ui.less now universal header [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/131892 (https://bugzilla.wikimedia.org/64719) [14:00:27] (03PS5) 10Jdlrobson: Fix VE performance by cleaning up ui.less now universal header [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/131892 (https://bugzilla.wikimedia.org/64719) [14:00:53] 3MobileFrontend / 3stable: Search page images misaligned - 10https://bugzilla.wikimedia.org/65347#c2 (10Jon) Created attachment 15396 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15396&action=edit example 2 [14:01:25] 3MobileFrontend / 3stable: Search page images misaligned - 10https://bugzilla.wikimedia.org/65347#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/hmCwdlhg [14:01:27] 3MobileFrontend / 3stable: Search page images misaligned - 10https://bugzilla.wikimedia.org/65347 (10Jon) 3NEW p:3Unprio s:3normal a:3None Created attachment 15395 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15395&action=edit Only for pages that do not need photos Has leaked on to product... [14:25:38] (03PS1) 10Jdlrobson: Respect the hash with sub headings [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/133470 (https://bugzilla.wikimedia.org/64918) [15:33:14] (03PS1) 10BearND: Override hashCode and toString when equals is overridden [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/133482 [15:34:53] ohai bearND and dbrant [15:35:04] YuviPanda: hello! [15:35:20] YuviPanda: dbrant good morning [15:35:43] I'm going to finish up the style loader patches today. [15:37:14] dbrant: are you considering being able to just use one webview for all pages? [15:37:37] YuviPanda: yes indeed, I'm experimenting with that now... [15:38:12] dbrant: cool. we might also consider a hybrid approach where we have a pool of 3-4 webviews and re-use them, so we can get scroll position exactly right [15:39:07] YuviPanda: yes, and the animation of going back to the previous page is pretty nice, so it would be a shame if we lost that entirely... [15:39:21] dbrant: yeah. we definitely should try to not lose that. [15:39:43] dbrant: we can still fake it, I am sure, but still... [15:40:17] dbrant: play with it and see how it goes! We should avoid making people lose position if at all possible. I wonder how the default browser does this [15:40:38] with respect to tabs, rather than back/front [15:40:50] right [15:49:39] (03PS1) 10Yuvipanda: Load styles via a StyleLoader [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/133488 [16:02:52] (03PS2) 10Yuvipanda: Load styles via a StyleLoader [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/133488 [16:28:15] (03CR) 10Ori.livneh: "> isn't it still better to have inflated bandwidth than broken functionality?" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/131897 (owner: 10Kaldari) [16:30:24] (03CR) 10Jdlrobson: [C: 031] "This looks fine - although a follow up patch showing it in use would be useful, as I worry without that we would end up" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/131897 (owner: 10Kaldari) [16:30:48] (03CR) 10Jdlrobson: "(it's sad I can't +1 and -1 at the same time :-)) I guess 0 would be the correct score." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/131897 (owner: 10Kaldari) [16:57:43] (03PS1) 10Jdlrobson: WIP QA: Add browser tests for Special:Uploads edge cases [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/133500 [16:57:58] (03CR) 10jenkins-bot: [V: 04-1] WIP QA: Add browser tests for Special:Uploads edge cases [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/133500 (owner: 10Jdlrobson) [17:09:29] (03PS4) 10Kaldari: Removing header margin and associated hacks [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/133170 [17:22:15] (03CR) 10Dbrant: [C: 032] Fix PageTests [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/133398 (owner: 10BearND) [17:34:25] (03PS2) 10Jdlrobson: QA: Add browser tests for Special:Uploads edge cases [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/133500 [17:34:43] (03CR) 10Jdlrobson: [C: 04-1] "@chrismcmahon any idea why I get uninitialized constant SpecialLoginPage (NameError)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/133500 (owner: 10Jdlrobson) [17:35:12] (03CR) 10jenkins-bot: [V: 04-1] QA: Add browser tests for Special:Uploads edge cases [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/133500 (owner: 10Jdlrobson) [17:37:48] (03CR) 10Cmcmahon: "because you defined a SpecialMobileSpecialLoginPage object but you have not defined a SpecialLoginPage object" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/133500 (owner: 10Jdlrobson) [17:38:49] bearND: are all tests passing now? [17:40:47] YuviPanda: no, PageTitleTests.testFromInternalLink and one more are failing. Looking at PageTitle constructor right now [17:40:58] bearND: cool. [17:41:07] handling for fragments has an issue when # is the last char [17:41:12] of [17:42:13] "/wiki/Talk:India#" produces ArrayOutOfBoundsException [17:42:42] aaah [17:43:21] YuviPanda: the fix is easy but i want to avoid making the code too complicated [17:43:41] bearND: yeah, but we definitely shouldn't crash on encountering empty fragments [17:46:57] YuviPanda: agreed [17:47:28] bearND: I think fromInternalLink uses splits and such now, wouldn't mind using a regex instead. [17:47:36] however, then we might have 2 problems... [17:48:40] YuviPanda: which are? [17:49:19] bearND: Site#titleForInternalLink [17:49:25] bearND: oh, the 2 problems [17:49:42] bearND: that's just a reference to http://blog.codinghorror.com/regular-expressions-now-you-have-two-problems/ [17:49:43] :) [17:50:02] (03CR) 10Kaldari: "Right now, I run out of localStorage space on a regular basis when using Wikipedia. It's quite annoying having to manually clean out my lo" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/131897 (owner: 10Kaldari) [17:52:10] (03CR) 10MaxSem: "I have a fear that once it's in place it will be used for data longer than appropriate for cookies." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/131897 (owner: 10Kaldari) [18:04:28] hey Deskana [18:04:34] Hey YuviPanda! [18:04:36] Deskana: how are the other 5 people in Ohio? [18:04:43] or is that joke supposed to be about Idaho? [18:05:20] I think that's Idaho. Ohio is the 7th most populous state. :P [18:05:41] Deskana: :) all the same [18:06:03] Deskana: are you working? [18:06:07] Yep. [18:06:48] I remember why I make such an effort to be on time for meetings now. [18:06:56] I'm sat here waiting for people to join this video call and nobody's here yet. [18:06:58] Deskana: cool. some things in ready for signoff, and they are in yesterday's build [18:08:00] YuviPanda: I signed off on one. Dmitry gave me instructions on how to sign off on the other. [18:08:20] Deskana: cool! [18:08:29] Just waiting for this meeting! [18:08:38] Deskana: what meeting is that? [18:08:51] It's a Platform thing. [18:09:13] I'm not entirely sure what it's about, the scope is a bit ill-defined. [18:09:15] We'll see afterwards. [18:09:51] Deskana: heh [18:09:53] Deskana: good luck [18:15:10] YuviPanda: on a related note: [18:15:44] YuviPanda: right now, when we go to History or Bookmarks, and select an item, it starts a brand new Activity with the new page. [18:16:04] YuviPanda: would it be simpler if we re-used the same activity? [18:16:43] dbrant: how will back work in that case? [18:16:53] dbrant: if I go from history to page, then hit 'back', it should take me back to history [18:17:54] YuviPanda: should it? [18:18:02] dbrant: I'd expect it to, no? [18:19:41] YuviPanda: that's not the behavior in the Browser [18:19:56] YuviPanda: why not just add the new page to the back-stack of previously-visited pages? [18:23:23] dbrant: I went from page -> history -> page, and then I realize I clicked wrong link, so I hit back, but whoops I don't go back to history [18:28:09] Is there already a bug for "This page does not exist" for all non-local images? [18:28:10] YuviPanda: I suppose that's compelling eough [18:28:21] ragesoss: no. do file. [18:28:33] ragesoss: I don't know why that's happening, since mobileview should support those. [18:28:38] k. I meant to do it days ago, and just realized I never did. [18:28:52] do it! [18:29:10] YuviPanda: I'm going to delve deeper into the Browser source code... I have ~50 tabs open, and it barely makes a dent in the heap usage. [18:29:21] dbrant: +1, yay. [18:31:41] 3Wikipedia App / 3Generic: Images from Commons say "This page does not exist" - 10https://bugzilla.wikimedia.org/65358 (10Sage Ross) 3NEW p:3Unprio s:3major a:3None As of the last ~week or longer, whenever you tap an image that is from Commons (rather than a local Wikipedia upload), the app displays... [18:39:30] bearND: https://trello.com/b/Id6qXKSY/mobile-app-latest-design-assets-by-page [19:05:27] bearND: that was good :) [19:06:04] YuviPanda: :) [19:06:18] bearND: after tests, have you looked at our checkstyle reports? :) [19:07:08] YuviPanda: yes, i have started looking at them. i wish they were easier to get to from the jenkins page [19:07:24] bearND: yeah, wish gerrit linked directly to those. [19:07:43] YuviPanda: some of the issues should be fixed by adding the hashCode override [19:08:05] bearND: yeah. [19:08:15] bearND: there's also a few trivial ones that have crept in (like missing braces) [19:08:47] bearND: and some of the visibility stuff needs to be fixed by a refactor of WikipediaApp [19:08:52] YuviPanda: in my earlier life we had some of the metrics, like #test and Android Lint on the Jenkins job page [19:09:05] bearND: oh yeah, Android Lint definitely would be useful. [19:09:19] bearND: tests probably once we have them running. [19:09:28] YuviPanda: yeah, but for now you can also run it from IntelliJ locally [19:09:34] but it's nice to see trends [19:09:36] yup [19:09:53] bearND: but for later. now we should fix bugs! [19:10:04] agreed [19:10:18] bearND: want to claim https://trello.com/c/7McHFjeA/30-android-network-error-tap-to-try-again-bar-is-too-persistent after fixing the tests? :) [19:12:00] mhurd: what have you done! I have 215 new trello notifications from you! :) [19:13:55] YuviPanda: i can do that, but would like to finish my current card first [19:14:16] YuviPanda: going to head to lunch for a bit [19:14:36] bearND: sure! Just wanted to point you to it :) [19:15:13] YuviPanda: thanks for the pointer. good to know what could be coming next [19:15:47] bearND: :) Usually you will just look at the To Do column and pick something up that wasn't claimed yet. I was just suggesting this. [19:19:44] YuviPanda: hahah sorry just making a pass throught the design board updating members on each card :) [19:19:50] mhurd: :) [19:24:03] kaldari: eep, good find [19:25:41] ori: I've been running into this problem pretty frequently for the last few weeks, although this is the first time I've gotten it on every page load (and with nothing in localStorage for that particular wiki). [19:26:09] although I imagine the problem is limited to people who use Firefox and frequent several Wikipedias [19:26:47] still severe [19:27:14] now you understand why I'm so interested in localstorage :) [19:27:16] you shouldn't see an exception because, as we discussed, everything using localStorage ought to be resilient [19:27:36] true [19:27:50] even if you remove module storage, it can't be the case that some gadget on commons is allowed to fill localStorage and break your experience of enwiki [19:28:21] so these are two related but discrete issues [19:28:31] yep [19:30:03] on the whole i think you're right that we need a unified storage api, so we can have the error-handling in one place [19:30:21] but since it's already required by mediawiki.js it has to be part of the startup module payload [19:30:26] which means it has to be very small [19:30:53] and imo it should not default to cookies as a storage medium [19:31:13] though i'm amenable to making it something you can explicitly request by passing some parameter [19:31:40] a "yes, i know what i'm doing, and i really do want you to default to cookie storage if localStorage isn't available" parameter [19:31:44] ori: well, if it's going to be used for everything, it probably shouldn't fall back to cookies, but personally, I still like falling back to cookies for our limited use on mobile. [19:32:00] but that's a longer discussion I suppose [19:32:08] it's not just performance that's the issue [19:32:20] we used to have a generic mechanism for developers to indicate which cookies are significant for caching [19:32:28] namely, tim's XVO stuff [19:32:32] which has a hook in mediawiki core [19:32:40] I didn't know about that [19:32:40] 3MobileFrontend / 3General/Unknown: Allow all or part of a mobile formatted screen to be called from desktop site - 10https://bugzilla.wikimedia.org/65367 (10Jared Zimmerman (WMF)) 3NEW p:3Unprio s:3normal a:3None e.g. be able to call the mobile watchlist view (without modal chrome) on desktop as a f... [19:32:54] 3MobileFrontend / 3General/Unknown: Allow all or part of a mobile formatted screen to be called from desktop site - 10https://bugzilla.wikimedia.org/65367 (10Jared Zimmerman (WMF)) [19:32:57] the problem is that it was only implemented for squid, and implementing it for varnish turns out to be a huge problem [19:33:38] so right now we grep for a cookie pattern: any cookie name ending in 'token' or 'session' is varied on [19:34:07] when an update to GettingStarted was deployed a couple of weeks ago, it overloaded the cluster [19:34:23] because it was (quite innocently) setting a cookie with a name that ended with one of those strings [19:34:40] oops [19:35:16] back in about an hr [19:35:23] 3MobileFrontend / 3General/Unknown: Allow all or part of a mobile formatted screen to be called from desktop site - 10https://bugzilla.wikimedia.org/65367#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/dhmhA2zq [19:35:43] off to lunch.... [19:36:00] kaldari: so basically that, plus the fact that the legal dept is sort of uneasy with ad-hoc cookie-ing without their oversight (for compliance with privacy policy) compelled a policy to make adding cookies a Big Deal you should communicate in advance [19:36:06] kaldari: which is incompatible with an automatic api [19:36:08] anyways, enjoy lunch [19:42:35] dbrant: bearND|lunch brb [19:45:18] kaldari: did you see my invite/email about the QA meeting? [19:50:12] awjr: does it make sense to do this meeting without juliusz? he's the one who actually knows what issues in VE need testing [19:50:26] Maryana: im trying to get one of the engineers on board [19:50:35] but i havent heard back yet from kaldari or jon [19:51:17] Maryana: worst case, it will still be worthwhile to touch base and we can get her to sit down with juliusz or someone else next week [19:51:43] ok - i think kaldari went to get lunch. [19:52:45] yeah - i sent them an email earlier this am so hopefully it's on his radar but im not sure [19:59:57] awjr: i don't think rumana is here today [19:59:59] heh [20:00:19] well that will complicate things [20:00:24] is she typically in the office or remote? [20:00:38] she's here [20:00:43] typically [20:00:51] but i haven't seen her today [20:04:18] awjr: just got back [20:04:27] kaldari: we may need to reschedule after all [20:04:39] Maryana: any luck? [20:29:32] (03CR) 10Kaldari: "Cookies are normally limited to 4 KB per cookie. In mobile, we aren't currently storing anything longer that a URL or sessionId." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/131897 (owner: 10Kaldari) [21:52:48] tfinc: https://meta.wikimedia.org/wiki/Schema:MobileWikiAppCreateAccount, https://meta.wikimedia.org/wiki/Schema:MobileWikiAppReadingAction, https://meta.wikimedia.org/wiki/Schema:MobileWikiAppLogin, https://meta.wikimedia.org/wiki/Schema:MobileWikiAppEdit [22:07:45] kaldari: please please please review https://gerrit.wikimedia.org/r/131892 asap [22:07:51] i need it to check the state of the VE stuff [22:23:02] erggg my mediawiki just died with latest core update and i have no clue why [22:23:26] MaxSem: getting cryptic error Fatal error: Call to a member function expired() on a non-object in /Users/jrobson/Sites/w/includes/parser/ParserCache.php on line 14 [22:23:28] any idea why? [22:23:54] call stack? [22:24:19] MaxSem: it claims it's happening in core [22:24:28] yes [22:24:53] but without a stack trace it's a guess work [22:25:12] i suspect it's a caching issue - killing memcached [22:25:31] ok yeh that did the trick - late nights are getting to me ;-) [22:26:03] jdlrobson: that's an unfortunate waste of a perfectly good bug :/ [22:26:11] would have been good to know [22:26:48] ori: i'm sure i could replicate it if you want [22:26:54] check out older version [22:26:56] start memcached [22:27:00] check out new version [22:27:07] run maintenance scripts [22:27:14] load page [22:27:39] jdlrobson: file a bug? :) [22:33:11] Maryana: I'm seeing MobileWebEditing validation errors [22:33:21] ValidationError: u'funnel' is a required property [22:36:55] jdlrobson: ^ [22:37:28] ori: really? mmmm that's concerning [22:37:37] i'll take a look after i've checked some ve stuff [22:38:21] ori: when did this start? [22:38:24] with latest deploy? [22:38:33] not sure, i can figure out [22:38:45] ori: thanks - not noticing anything odd in graphs at http://mobile-reportcard.wmflabs.org/#edits_daily-graphs-tab [22:42:08] jdlrobson: they're all from RYasmeen (WMF) [22:42:16] so probably just testing [22:42:24] ori: ahh - maybe it's VE related.. [22:42:28] * jdlrobson pokes [22:43:11] by the way, you can now use mw.track() to log eventlogging events without worrying about whether mw.eventLog.logEvent exists or not [22:43:39] remind me to show you at some point [22:43:43] it obsoletes your wrapper [22:44:05] registering schema modules is now also as simple as: $wgEventLoggingSchemas[ 'MobileWebEditing' ] = 7675117; [22:44:23] none of this 'class' => 'ResourceLoaderSchemaModule' nonsense [22:57:16] ori: that's pretty sweet [22:57:28] can you raise a bug and i'll make sure we move over to the cool way of doing things [22:58:41] ori: are you in the office? [22:58:43] is kaldari around? [23:00:27] jdlrobson: hey [23:00:31] i am around [23:00:51] howdy [23:01:29] kaldari: i have a ton of code review that needs attention most importantly https://gerrit.wikimedia.org/r/131892 [23:01:42] i'm a bit overwhelmed by all the code i've written that is rotting in gerrit :( [23:02:40] so are your reviewers, evidently :P [23:02:44] * ori butts out. [23:03:01] (03PS2) 10Kaldari: Formatting for citation drop-down in mobile VisualEditor [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/133408 [23:03:14] (03CR) 10Kaldari: Formatting for citation drop-down in mobile VisualEditor [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/133408 (owner: 10Kaldari) [23:04:20] jdlrobson: sure, I have a couple things in Gerrit that you can review if you want to take a break from writing more code (besides the localStorage stuff) [23:04:37] kaldari: yeh i've been looking at them [23:04:40] 3MobileFrontend / 3alpha: EventLogging errors when switching from VisualEditor - 10https://bugzilla.wikimedia.org/65378 (10Jon) 3NEW p:3Unprio s:3normal a:3None Load VE and switch to wikitext editor - triggers Validation error against schema MobileWebEditing: Missing property: funnel [23:04:50] jdlrobson: thanks for the bug [23:05:06] jdlrobson: thanks. I just finished the VE cite dropdown, so I'll take a look at your stuff now [23:05:22] 3MobileFrontend / 3alpha: EventLogging errors when switching from VisualEditor - 10https://bugzilla.wikimedia.org/65378#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/NxeR9xyO [23:08:06] jdlrobson: the cite dropdown is some pretty ugly/complicated CSS, but that's mainly because none of the components in VE have unique classes and I have to rely on the class heiarchies/positions instead. Plus some things still have to be overridden from the ooui defaults :( [23:10:22] (03CR) 10MaxSem: "Yes, but you're using them for the same stuff as LocalStorage so if the latter fails, cookies will be transparently used as a substitute f" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/131897 (owner: 10Kaldari) [23:10:58] kaldari: the 1px gap at the top of the continue button in your patch https://gerrit.wikimedia.org/r/133170 looks odd [23:11:03] kaldari, please paint it red, I like pretty bikesheds!:P [23:11:44] jdlrobson: That was only in Chrome and I thought I fixed that. [23:11:57] kaldari: still seeing in chrome [23:12:08] only on VE though [23:14:51] kaldari: i'll just merge as is [23:15:07] think it's toolbar related [23:15:37] kaldari: just to check - is kaity okay with it? [23:15:52] or moiz or vibha or whoever needs to care about this stuffn ow [23:16:02] jdlrobson: Should probably double-check with Kaity... [23:16:17] I'll see if she's around to sign-off on it.... [23:16:20] jdlrobson: bout what? [23:16:34] removing the margins around the overlay headers [23:16:36] getting rid of the header margins on mobile [23:16:49] yep do it [23:16:57] yay! [23:16:58] wait can i see it? [23:17:02] (03CR) 10Jdlrobson: [C: 031] "Check with Kaity. If she's fine with it then plus 2." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/133170 (owner: 10Kaldari) [23:17:02] sure.... [23:17:12] should i come over? [23:17:37] kaity: yes [23:18:34] (03CR) 10MaxSem: [C: 04-1] Respect the hash with sub headings (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/133470 (https://bugzilla.wikimedia.org/64918) (owner: 10Jdlrobson) [23:19:23] (03PS2) 10Jdlrobson: Respect the hash with sub headings [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/133470 (https://bugzilla.wikimedia.org/64918) [23:19:42] (03CR) 10Jdlrobson: Respect the hash with sub headings (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/133470 (https://bugzilla.wikimedia.org/64918) (owner: 10Jdlrobson) [23:23:22] jdlrobson: kaity has one minor suggestion for improvement, so I'll -1 for now and do some code review for you instead :) [23:23:25] 3Wikipedia App / 3Generic: Editing on slow data connection works strangely - 10https://bugzilla.wikimedia.org/65380 (10Dan Garry) 3NEW p:3Unprio s:3normal a:3None The iOS app works a bit strangely on slow connections. I went to [[User:Deskana/Countries/USA]], a page which is relatively short on wiki... [23:23:33] ok thanks kaity and kaldari [23:24:07] (03CR) 10Kaldari: [C: 04-1] "Kaity wants us to get rid of the vertical lines in the header while we're at it." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/133170 (owner: 10Kaldari) [23:26:29]  [23:26:39] * YuviPanda waves [23:27:50] hey, YuviPanda. welcome back :) [23:28:06] bearND: :) went out for food. Good fries. Also froze to death a bit. [23:28:12] Had like 4 layers of jackets on [23:28:13] chrismcmahon: any ideas what is happening in https://gerrit.wikimedia.org/r/133500 ? [23:28:15] afterwards [23:28:43] kaldari: kaity the vertical lines as in the ones to the left and right of the buttons? [23:28:58] jdlrobson: I left a comment this morning [23:29:03] i thought we intentionally added those to better signal they were buttons? [23:29:08] jdlrobson: I'm pissed that Chrome decided to create their own web rendering engine instead of sticking with WebKit. Now we have to deal with different CSS bugs in 4 different rendering engines. It's worse than the Netscape/Explorer days. [23:29:10] chrismcmahon: oh you did? sorry? gerrit fail :) [23:29:13] jdlrobson: yes [23:29:50] kaity: ^ [23:30:45] there are blink specific css bugs already? oh god [23:31:03] jdlrobson: https://www.dropbox.com/s/1ejygj657ixxerj/Screen%20Shot%202014-05-15%20at%204.30.13%20PM.png [23:31:31] like so [23:37:10] (03PS3) 10Jdlrobson: QA: Add browser tests for Special:Uploads edge cases [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/133500 [23:38:09] (03CR) 10jenkins-bot: [V: 04-1] QA: Add browser tests for Special:Uploads edge cases [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/133500 (owner: 10Jdlrobson) [23:39:45] (03CR) 10Kaldari: [C: 04-1] Hygiene: Introduce .page-summary class (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/131885 (owner: 10Jdlrobson) [23:40:01] (03CR) 10Jdlrobson: "Please cleanup if statements and rebase" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/132518 (https://bugzilla.wikimedia.org/65094) (owner: 10MaxSem) [23:40:05] (03PS3) 10Jdlrobson: Fix username handling on Special:Uploads [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/132518 (https://bugzilla.wikimedia.org/65094) (owner: 10MaxSem) [23:40:59] (03CR) 10Kaldari: [C: 032] Hygiene: Remove blockquote css repetition [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/131880 (owner: 10Jdlrobson) [23:41:31] (03Merged) 10jenkins-bot: Hygiene: Remove blockquote css repetition [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/131880 (owner: 10Jdlrobson) [23:41:45] (03PS4) 10Jdlrobson: Fix username handling on Special:Uploads [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/132518 (https://bugzilla.wikimedia.org/65094) (owner: 10MaxSem) [23:41:47] (03PS4) 10Jdlrobson: QA: Add browser tests for Special:Uploads edge cases [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/133500 [23:43:18] (03PS3) 10Jdlrobson: Hygiene: Introduce .page-summary class [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/131885 [23:44:10] 3MobileFrontend / 3Hygiene: Standardise on our grey colours - 10https://bugzilla.wikimedia.org/65381 (10Jon) 3NEW p:3Unprio s:3normal a:3Jon There are still various shades of gray that don't match with one of the predefined ones in variables.less Let's review these and sort this out. [23:44:24] (03CR) 10Jdlrobson: "Silly me" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/133500 (owner: 10Jdlrobson) [23:45:09] (03PS3) 10Yuvipanda: Load styles via a StyleLoader [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/133488 [23:45:11] (03PS1) 10Yuvipanda: [WIP] Fetch remote styles once a day and cache them [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/133640 [23:45:43] dbrant|bbl: bearND heading to sleep, but do take a look at the two patches ^. The second one has a fundamental bug (the files downloaded seem to be empty, I need to fix it tommorrow), but thoughts on the udnerlying mechanism welcome [23:45:53] (03PS3) 10Jdlrobson: Hygiene: Use truncated text class in overlay headers [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/132344 [23:45:59] bearND: this is also how we use the [WIP] thing. Useful to put up a patch and welcome feedback even if it has some bugs in it [23:46:12] (03PS2) 10Jdlrobson: Icon cleanup [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/133189 [23:46:22] (03PS2) 10Jdlrobson: Make icons in overlays and drawers global and reusable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/133190 [23:46:22] bearND: dbrant|bbl note that the CSS files will change per wiki, and I'll have to do some work about that later on. But for now, we can ignore that [23:46:34] bearND: with that, I'm off now. cya guys tomorrow! [23:46:37] (03PS3) 10Jdlrobson: Hygiene: Make border-box the default [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/133188 [23:46:44] (03PS3) 10Jdlrobson: Icon cleanup [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/133189 [23:46:50] (03PS4) 10Jdlrobson: Hygiene: Icon cleanup [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/133189 [23:46:52] YuviPanda: ok [23:46:58] (03PS3) 10Jdlrobson: Make icons in overlays and drawers global and reusable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/133190 [23:47:05] bearND: anything I can do for you before that? [23:47:08] (03PS4) 10Jdlrobson: Hygiene: Make icons in overlays and drawers global and reusable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/133190 [23:47:31] YuviPanda: i had a few questions. let's see how fast i can type [23:47:34] kaldari: how do i get the citation tool up and running? [23:47:41] bearND: go ahead :) I can be around :) [23:47:41] wtf ori sorry having some git challenges getting hte nginx config checked in [23:48:52] YuviPanda: first one is simple: In PreviewTaskTests we get a few new classes from the api. i assume i can just add them to the expected result [23:49:06] (03CR) 10Kaldari: [C: 032] Hygiene: Introduce .page-summary class [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/131885 (owner: 10Jdlrobson) [23:49:20] bearND: yeah, should do. Our API tests are a bit fragile, but should always reflect what the API returns [23:49:41] (03Merged) 10jenkins-bot: Hygiene: Introduce .page-summary class [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/131885 (owner: 10Jdlrobson) [23:49:50] YuviPanda: ok, i'll submit a ptach for this shortly [23:50:16] YuviPanda: next test failure is PageTitleTests.testFromInternalLink(PageTitleTests.java:46) [23:50:22] ori: i think i've got the https role commit sorted out and ready to go now :) [23:50:26] YuviPanda: In PageTitleTests i wonder why the fragment is supposed to have different values whether the # is at the end of the string or not present at all. "/wiki/Talk:India#" -> "" but "/wiki/Talk:India" -> null. i think they should behave the same. thoughts? [23:50:42] bearND: agreed. I think they both should be null [23:51:08] YuviPanda: great. patches will be sent shortly [23:51:27] bearND: cool! I love waking up to patches. one of the advantages of being in different timezones :D [23:51:42] (03PS1) 10BearND: Fix PreviewTaskTests [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/133642 [23:52:32] bearND: anything else? [23:53:09] (03PS1) 10BearND: Fix PageTitleTests [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/133643 [23:53:55] YuviPanda: those are the two patches i had prepped. once they are merged all android tests should be passing [23:54:01] bearND: \o/ coool! [23:54:08] bearND: you should move that card to the CR column then :) [23:54:17] and pick another one to work on and move it to doing. [23:54:19] awjr: my deployment is running a bit over, so 'eod' might mean literally eod [23:54:27] YuviPanda: i had some more questions about code style, etc. but that can wait if you are in a hurry [23:54:54] bearND: email me? would be nice to get our code style quality documented, and email is a good way to go about it. [23:55:07] bearND: actually, email mobile-l! Having these discussions in public is often helpful for other people to chime in as well [23:55:12] ori: ok no problem, i can wait til tomorrow to mail out about hackathon stuff [23:55:20] awjr: thanks, much appreciated [23:55:25] YuviPanda: like why are expected and actual args swapped in assertEquals; another one is why did you switch to * imports? [23:55:53] bearND: the former, it's an accident. I would happily welcome a patch that puts them in the right order [23:56:04] argh! git! [23:56:24] bearND: the latter because I was tired of having to constantly remove imports, but having already been bitten by it once (with the R import) I'd be happy to swap it back [23:56:45] (03CR) 10Jdlrobson: "Can't work out how to test this out and see it in action, but here's some comments on the code." (036 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/133408 (owner: 10Kaldari) [23:57:52] YuviPanda: sounds good. thank you. that's all for now. good night [23:58:00] bearND: dbrant night! [23:58:08] YuviPanda: later!