[00:06:56] jdlrobson, deploying https://gerrit.wikimedia.org/r/#/c/131762/ [00:09:42] deployed! [00:12:29] (03CR) 10Kaldari: Formatting for citation drop-down in mobile VisualEditor (036 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/133408 (owner: 10Kaldari) [00:14:00] (03CR) 10Kaldari: Formatting for citation drop-down in mobile VisualEditor (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/133408 (owner: 10Kaldari) [00:18:33] jdlrobson: So for the tests that will only run in Chrome, how do you get Cucumber to actually run Chrome? [00:25:26] (03CR) 10Kaldari: [C: 031] "Code looks good, but I haven't been able to figure out how to get Cucumber to run the test in Chrome (and it always fails in Firefox)." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/130985 (https://bugzilla.wikimedia.org/64400) (owner: 10Jdlrobson) [00:28:26] oh btw mhurd, that API change has finally been merged [00:28:55] MaxSem: awesome! thx! [00:28:56] (03CR) 10Jdlrobson: [C: 04-1] "Looks like I'll need to rebase this. Should only work in Chrome.." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/130985 (https://bugzilla.wikimedia.org/64400) (owner: 10Jdlrobson) [00:29:15] kaldari: i'll take a look tomorrow [00:29:18] i'm getting pretty tired now [00:29:23] so should probably start wrapping up [00:29:47] kaldari: can you send me instructions how you got the citation tool setup? [00:29:58] hopefully i can poke at that tomorrow and get juliusz's work there wrapped up [00:32:19] (03PS3) 10Jdlrobson: Hygiene: Cleanup main menu css border/background [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/132346 [00:32:41] (03CR) 10Cmcmahon: "to run in Chrome install chromedriver https://gerrit.wikimedia.org/r/#/c/130985/ and add env var (bash) "export BROWSER=chrome"" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/130985 (https://bugzilla.wikimedia.org/64400) (owner: 10Jdlrobson) [00:32:58] mhurd: leave in 15-20 ? [00:33:56] tfinc: kaldari MaxSem awjr_away need anything before i head to bed.. [00:34:06] jdlrobson: i'm good [00:34:09] nope [00:34:10] nope [00:34:12] thanks for checking in [00:34:14] sleep well [00:34:53] ok cool. zzzz from me then. I'm working european hours tomorrow so heads up you won't see me. I'll try and check my mail later friday night in case anything comes up though, so feel free to give me a big to do list for tomorrow! [00:35:24] (unless you want to get up super early / hack super late tonight ;-)) [00:38:12] (03CR) 10Kaldari: [C: 04-1] Rewrite Nearby as a PageList (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/130270 (owner: 10Jdlrobson) [00:38:26] tfinc: ya! [00:51:33] tfinc: i’m at a good breaking point [00:52:07] mhurd: i'll be good in about 5 [00:52:18] -10 [08:40:32] (03CR) 10Yuvipanda: [C: 032] Fix PreviewTaskTests [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/133642 (owner: 10BearND) [08:40:36] (03CR) 10Yuvipanda: [C: 032] Fix PageTitleTests [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/133643 (owner: 10BearND) [08:41:07] (03Merged) 10jenkins-bot: Fix PreviewTaskTests [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/133642 (owner: 10BearND) [08:41:09] (03Merged) 10jenkins-bot: Fix PageTitleTests [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/133643 (owner: 10BearND) [08:56:06] (03PS1) 10Jdlrobson: WIP Hygiene: Start using models for history and contributions page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/133680 [08:56:08] (03PS1) 10Jdlrobson: WIP: Use MobileFrontendEditCollection model [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/133681 [08:56:53] (03CR) 10jenkins-bot: [V: 04-1] WIP Hygiene: Start using models for history and contributions page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/133680 (owner: 10Jdlrobson) [08:56:55] (03CR) 10Jdlrobson: [C: 04-2] "@MaxSem I'd love your help with this. I just wanted to kick this off but I need your PHP foo to make this prettier and work." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/133681 (owner: 10Jdlrobson) [08:57:08] (03CR) 10Jdlrobson: [C: 04-2] "@MaxSem I'd love your help with this. I just wanted to kick this off but I need your PHP foo to make this prettier and work." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/133680 (owner: 10Jdlrobson) [08:58:40] (03PS6) 10Jdlrobson: Fix VE performance by cleaning up ui.less now universal header [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/131892 (https://bugzilla.wikimedia.org/64719) [09:00:09] 3MobileFrontend / 3stable: More link on Special:Contributions/Username doesn't work - 10https://bugzilla.wikimedia.org/65266 (10Jon) 5PAT>3RES/FIX [09:00:25] (03PS3) 10Jdlrobson: Respect the hash with sub headings [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/133470 (https://bugzilla.wikimedia.org/64918) [11:16:57] (03PS3) 10Jdlrobson: Formatting for citation drop-down in mobile VisualEditor [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/133408 (owner: 10Kaldari) [11:17:00] (03CR) 10Jdlrobson: "It looks good but we need to make thos" (035 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/133408 (owner: 10Kaldari) [11:17:29] (03CR) 10Jdlrobson: "@kaldari I made some changes to this. If you are happy feel free to +2" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/133408 (owner: 10Kaldari) [13:22:53] 3MobileFrontend / 3Hygiene: Consolidate Special:Uploads and Special:UploadWizard code - 10https://bugzilla.wikimedia.org/62638 (10Jon) a:3Jon [13:34:25] 3MobileFrontend / 3stable: Severe regression: Impossible to scroll on iPhone 4.3.2 - 10https://bugzilla.wikimedia.org/65393 (10Jon) 3NEW p:3Unprio s:3critic a:3None Created attachment 15406 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15406&action=edit Y U NO SCROLL!? This bug is present o... [13:35:23] 3MobileFrontend / 3stable: Severe regression: Impossible to scroll on iPhone 4.3.2 - 10https://bugzilla.wikimedia.org/65393#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/4E5xdNyG [13:40:26] (03PS1) 10Jdlrobson: Revert "Prevent horizontal scrollbar after menu closing animation" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/133703 (https://bugzilla.wikimedia.org/65393) [13:43:55] 3MobileFrontend / 3stable: Site notices look crappy on mobile - 10https://bugzilla.wikimedia.org/65395 (10Jon) 3NEW p:3Unprio s:3normal a:3None Created attachment 15407 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15407&action=edit Example on wikivoyage Let's hide them until we have a bett... [13:44:08] 3MobileFrontend / 3stable: Site notices look crappy on mobile - 10https://bugzilla.wikimedia.org/65395#c1 (10Jon) Created attachment 15408 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15408&action=edit Example on English Wikipedia [13:45:24] 3MobileFrontend / 3stable: Site notices look crappy on mobile - 10https://bugzilla.wikimedia.org/65395#c2 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/9ipjOQMd [13:45:43] yurikR2: https://www.mediawiki.org/wiki/Requests_for_comment/Wikidata_API would love to discuss this sometime soon in an RfC meeting, if you are interested [13:46:28] sumanah, thx, the problem is that wikidata mostly agrees with that approach, but doesn't have anyone to implement it ) [13:46:49] and so you would be implementing it, right? and you have no time, correct? [13:46:51] kinda like "it works, not as good but works, might as well keep it" [13:47:04] yes, kinda like that :) [13:47:34] oh, btw, sumanah, i was at the coworking space twice already (6th fl), was awesom! [13:47:38] will be there today too [13:48:00] cool yurikR2 - I am at Hacker School reunion week right now not too far from there, will be at coworking on Monday [13:48:29] looking forward to it [13:48:29] which plan did you pick? [13:48:45] don't remember off the top of my head, maybe 25 hrs/month? [13:56:38] 3MobileFrontend / 3Feature requests: Allow all or part of a mobile formatted screen to be called from desktop site - 10https://bugzilla.wikimedia.org/65367#c2 (10Jon) We could potentially do this in a hacky way via an iframe, but currently there is no way to construct the mobile version of the watchlist spec... [14:18:07] 3MobileFrontend / 3General/Unknown: mobile response: Error, edit not saved - 10https://bugzilla.wikimedia.org/64416#c9 (10Jon) 5ASS>3RES/FIX We've had no bad token errors since the 4th May [1] - that's 12 days. However the fix was merged on May 8 8:51 PM so I'm not sure if some other patch has contribute... [14:40:07] bearND: heya! [14:41:11] hey YuviPanda [14:41:22] hey dbrant! [14:41:26] YuviPanda: dbrant: hola [14:41:40] YuviPanda: I think I'm zeroing in on a solution [14:41:40] dbrant: woo! [14:41:45] bearND: do you know how I can tell intellij or maven to not stop when a single test fails? [14:42:02] dbrant: how are you thinking of tackling it? [14:43:36] YuviPanda: So, we would maintain a backstack of, say, four actual WebViews, but we'll also maintain a full backstack of page titles that were visited; but then: [14:44:22] YuviPanda: when the user clicks Back, we'll insert a new WebView at the bottom of the stack, and silently preload the page. [14:46:20] dbrant: yeah, sounds good. so we can just recycle the same 4 pageviewfragments over and over again? [14:48:31] dbrant: we'll need to do some work on scroll preservation but that's not too bad [14:48:51] YuviPanda: maybe not even recycle, but destroy/create. That would minimize changing the code of the Fragment. [14:49:08] dbrant: hmm, that's ok too. we can attempt recycling later on. [14:49:31] dbrant: although I am wondering if the PVF currently keeps state well enough for us to just recycle it. [14:50:12] YuviPanda: i'm not aware of a way that works for our project. i did realize that we have still issues with the DoEditTaskTests, so i moved the card back to doing [14:50:35] bearND: ok. I'll play around [14:50:41] YuviPanda: i ran into this earlier but got by it by clearing all tokens, so i thought it was a temporary issue [14:50:54] but i get it repeatetly [14:50:55] bearND: CreateAccount test is still failing, though. probably token errors. [14:50:59] YuviPanda: I'm thinking that recycling would require a lot more code to manage the AsyncTasks, as well as the Bridge... [14:51:10] dbrant: hmm, right. Hadn't thought of the bridge. [14:51:17] dbrant: yeah let's just destroy/recreate then [14:51:35] bearND: potentially an issue in our cookie peristance to shared prefs code [14:51:40] I'd love to replace it with a library somewhere [14:51:41] oh well [14:52:05] btw YuviPanda - wanted to bring 2 things to your attention - https://www.mediawiki.org/wiki/Performance_profiling_for_Wikimedia_code and https://www.mediawiki.org/wiki/Talk:Requests_for_comment/URL_shortener_service_for_Wikimedia (there are comments you might have opinions on) [14:52:05] I'll brb in about 30-45mins, going to make some lunch [14:52:06] brb [14:52:22] sumanah: will look at it after some eggs when I'm back! Thanks for the links! [14:52:35] YuviPanda: you could temporarily comment out the code in the failing test but it's not a good solution [15:02:13] YuviPanda|brb: for me both DoEditTaskTests and TriggerAbuseFilterTest.testAbuseFilterTriggerStop both fail for the same reason: DoEditTask.processResult gets an errorJSON {"info":"Invalid token","code":"badtoken"} [15:03:09] so if we could make DoEditTask retry with new tokens that should fix it [15:15:02] (03PS1) 10Jdlrobson: Style search button as icon for non-JS users [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/133721 (https://bugzilla.wikimedia.org/63701) [15:15:37] 3MobileFrontend / 3Feature requests: MobileFrontend "last edited" strapline sometimes wrong (reports non-edits) - 10https://bugzilla.wikimedia.org/64937 (10Jon) [15:15:53] 3MobileFrontend / 3stable: S60 crashes on Wikipedia - 10https://bugzilla.wikimedia.org/61385#c3 (10Jon) Max..? [15:18:22] 3MobileFrontend / 3General/Unknown: Problem with getMobileToken in MobileContext causing browser tests to fail - 10https://bugzilla.wikimedia.org/62614 (10Jon) 5PAT>3RES/FIX [15:23:09] 3MobileFrontend / 3alpha: VisualEditor Mobile: "Success! Your edit was saved" message stays in the VE mode unless user scrolls down the page - 10https://bugzilla.wikimedia.org/64270 (10Jon) 5PAT>3RES/FIX [15:24:09] 3MobileFrontend / 3General/Unknown: mainspace Special:Random instead of filespace Special:Random in mobile (browser) Commons sidebar - 10https://bugzilla.wikimedia.org/64543 (10Jon) 5PAT>3RES/FIX [15:24:10] 3MobileFrontend / 3General/Unknown: mainspace Special:Random instead of filespace Special:Random in mobile (browser) Commons sidebar - 10https://bugzilla.wikimedia.org/64543#c3 (10Jon) This has been merged [15:24:39] 3MobileFrontend / 3stable: MediaViewer doesn't use LoadingOverlay - 10https://bugzilla.wikimedia.org/64271 (10Jon) 5PAT>3RES/FIX [15:24:53] 3MobileFrontend / 3General/Unknown: mobile contributions change numbers sometimes don't make sense - 10https://bugzilla.wikimedia.org/64867 (10Jon) 5PAT>3RES/FIX [15:25:08] 3MobileFrontend / 3Hygiene: Rewrite ImageOverlay to use OverlayNew - 10https://bugzilla.wikimedia.org/64269 (10Jon) 5PAT>3RES/FIX [15:30:08] 3MobileFrontend / 3stable: mobileview fails on content pages redirecting to special pages - 10https://bugzilla.wikimedia.org/64305#c4 (10Jon) Max it would be great if the api could return a link to the special page or even better return something akin to { redirect: 'Special:X' } so the caller can take care... [15:31:09] 3MobileFrontend / 3General/Unknown: "This page has issues" link looks like a link, but is actually a giant invisible button - 10https://bugzilla.wikimedia.org/64679#c2 (10Jon) Change it to inline-block and let's get this bug closed. [15:31:37] 3MobileFrontend / 3stable: About and Disclaimers "-" interpreted wrong - 10https://bugzilla.wikimedia.org/63422 (10Jon) s:5normal>3enhanc [15:46:53] 3MobileFrontend / 3stable: "Desktop" link on history view points to article view - 10https://bugzilla.wikimedia.org/64383#c2 (10Jon) 5NEW>3RES/FIX This is a duplicate bug (I can't find the other bug though) and is fixed. [15:47:38] 3MobileFrontend / 3Feature requests: Uploads AbuseFilter styling regression - 10https://bugzilla.wikimedia.org/63332 (10Jon) [15:47:53] YuviPanda|brb: pretty much all tests that involve DoEditTask fail. [15:48:03] YuviPanda|brb: Then there is also WikipediaZeroTest failing because the response is an empty array ('[]') instead of a JSON object. [15:48:38] 3MobileFrontend / 3stable: Button looks different from other buttons - 10https://bugzilla.wikimedia.org/63701#c2 (10Jon) 5NEW>3PAT https://gerrit.wikimedia.org/r/#/c/133721/ for some reason wasn't picked up. [15:50:38] 3MobileFrontend / 3stable: "Desktop" in footer of Special:Contributions/foo points to [[foo]] - 10https://bugzilla.wikimedia.org/65203#c3 (10Jon) yep but this appears to be fixed on beta labs. On English Wikipedia it redirects to history page but mediawiki points to the correct place, so this will be fixed e... [15:50:38] 3MobileFrontend / 3stable: "Desktop" in footer of Special:Contributions/foo points to [[foo]] - 10https://bugzilla.wikimedia.org/65203 (10Jon) 5NEW>3RES/WOR [15:51:09] 3MobileFrontend / 3Hygiene: Minimize number of thumb sizes used in MobileFrontend extension - 10https://bugzilla.wikimedia.org/58285 (10Jon) a:3Jon [15:51:38] 3MobileFrontend / 3Feature requests: Do not offer link to PasswordReset if Email features have been disabled - 10https://bugzilla.wikimedia.org/63460 (10Jon) [15:51:52] 3MobileFrontend / 3Feature requests: Account creation link still offered despite createaccount = false - 10https://bugzilla.wikimedia.org/63456 (10Jon) [15:52:38] 3MobileFrontend / 3beta: MediaViewer conflicts with Zero - 10https://bugzilla.wikimedia.org/58778#c3 (10Jon) Did we fix this? I forget.. [15:58:19] bearND: back [15:58:27] bearND: DoEditTask failing is interesting since editing still works [16:02:23] 3MobileFrontend / 3beta: Typography for tablets on mobile and wikivoyage don't play nicely together - 10https://bugzilla.wikimedia.org/64722#c2 (10Jon) 5NEW>3RES/WON I reported it to the community as the code will need to change there - https://en.wikivoyage.org/w/index.php?title=MediaWiki_talk%3AMobile.... [16:03:38] 3MobileFrontend / 3alpha: Alpha: Non-user friendly page titles when navigating around in alpha - 10https://bugzilla.wikimedia.org/58337#c3 (10Jon) 5NEW>3RES/WOR This appears to be fixed now. Used https://en.m.wikipedia.org/wiki/Respiration_%28physiology%29?mobileaction=alpha as an example. [16:06:10] YuviPanda: indeed very interesting. Does the test in DoEditTaskTests fail for you, too? [16:06:23] 3MobileFrontend / 3Feature requests: “0 bytes added” should be specially handled and show something better - 10https://bugzilla.wikimedia.org/64616#c2 (10Jon) I guess we could have another icon... [16:06:43] bearND: yeah, it does. [16:06:52] 3MobileFrontend / 3Feature requests: “0 bytes added” should be specially handled and show something better - 10https://bugzilla.wikimedia.org/64616#c3 (10Jon) To be clear this is the icon on the diff page? https://en.m.wikipedia.org/wiki/Special:MobileDiff/608773477 [16:07:13] bearND: I have a feeling it might also be responsible for the itermittent https://trello.com/c/xqpwtw7u/42-android-app-does-not-realize-when-it-has-been-logged-out [16:09:56] YuviPanda: can i PM you? [16:10:01] bearND: sure! [16:11:52] 3MobileFrontend / 3alpha: Non-canonical URLs get rewritten into weird psuedo-canonical URLs in alpha - 10https://bugzilla.wikimedia.org/65327#c2 (10Jon) it's a feature but we should probably drop the title parameter. Really we should be redirecting to the canonical URL but there seems to be a bug around tha... [16:14:07] bearND: so tokens expire when: 1. action=logout call is made from any client with this user, 2. We reset them serverside (with the heartbleed bug, for example), 3. When you change your password [16:14:07] YuviPanda: those tests do pass when I manually clear the tokens [16:14:23] bearND: when do you clear them? after each edit? [16:14:44] bearND: so the tokens change when you log in / log out as well, so we should have code that clears tokens when a user logs in or out [16:14:46] bearND: and I think we do [16:16:36] YuviPanda: i clear them when a test was failing [16:17:28] (03CR) 10Jdlrobson: [C: 031] "Kaldari can +2 when ready" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/133408 (owner: 10Kaldari) [16:17:30] bearND: yeah, we shouldn't re-fetch tokens after every edit. [16:20:38] YuviPanda: i agree. but we should also not crash the app when the token is invalid [16:20:51] bearND: there's code in editsectionactivity that checks for it [16:20:56] bearND: and re-fetches tokens [16:20:56] i believe that happens since it throws EditingException [16:21:30] bearND: which might be why we aren't seeing edits still go through in the app [16:23:26] YuviPanda: do you mean line 199 in EditSectionActivity? [16:23:44] bearND: yeah, pretty much [16:23:57] bearND: so we should re-fetch tokens when they expire, but not all the time, and they shouldn't be expiring that much [16:24:13] YuviPanda: i see. this is catching the EditingException i was worried about earlier [16:24:20] bearND: yup! :) [16:24:28] bearND: our code needs better docs, tho [16:52:03] cdg [16:54:18] (03CR) 10Kaldari: [C: 032] Formatting for citation drop-down in mobile VisualEditor [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/133408 (owner: 10Kaldari) [16:55:05] (03Merged) 10jenkins-bot: Formatting for citation drop-down in mobile VisualEditor [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/133408 (owner: 10Kaldari) [16:56:32] (03CR) 10MaxSem: [C: 032] Revert "Prevent horizontal scrollbar after menu closing animation" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/133703 (https://bugzilla.wikimedia.org/65393) (owner: 10Jdlrobson) [16:57:39] (03Merged) 10jenkins-bot: Revert "Prevent horizontal scrollbar after menu closing animation" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/133703 (https://bugzilla.wikimedia.org/65393) (owner: 10Jdlrobson) [16:59:45] haha [16:59:49] I am an idiot [16:59:51] * YuviPanda goes to fix [17:06:35] all this because I forgot how + works on arrays [17:06:37] <- Idiot [17:07:06] welcome to php [17:07:10] the land of insanity [17:10:32] php arrays and + is an easy one to totally f up [17:10:36] it's entirely unintuitive [17:11:45] brion: merge https://gerrit.wikimedia.org/r/133737 [17:11:45] ? [17:11:49] brion: also welcome back :) [17:12:02] awjr: yeah, I was wondering whytf some of my CSS wasn't showing up [17:12:32] hello, brion [17:13:03] YuviPanda: i've fallen into that trap many times before, it's one of those lessons i've learned over and over [17:13:27] (03PS1) 10MaxSem: Revert "Prevent horizontal scrollbar after menu closing animation" [extensions/MobileFrontend] (wmf/1.24wmf5) - 10https://gerrit.wikimedia.org/r/133741 (https://bugzilla.wikimedia.org/65393) [17:13:36] awjr: yeah. Should setup my IDE to warn about that or something [17:14:15] (03CR) 10MaxSem: [C: 032] Revert "Prevent horizontal scrollbar after menu closing animation" [extensions/MobileFrontend] (wmf/1.24wmf5) - 10https://gerrit.wikimedia.org/r/133741 (https://bugzilla.wikimedia.org/65393) (owner: 10MaxSem) [17:14:49] (03Merged) 10jenkins-bot: Revert "Prevent horizontal scrollbar after menu closing animation" [extensions/MobileFrontend] (wmf/1.24wmf5) - 10https://gerrit.wikimedia.org/r/133741 (https://bugzilla.wikimedia.org/65393) (owner: 10MaxSem) [17:15:08] hey guys [17:15:10] lemme get on the hangout [17:26:56] my chrome profile got messed up from running beta versions or something, i had to relogin to everything [17:26:57] blah [17:29:25] 3MobileFrontend / 3Feature requests: “0 bytes added” should be specially handled and show something better - 10https://bugzilla.wikimedia.org/64616#c4 (10Liangent) (In reply to Jon from comment #3) > To be clear this is the icon on the diff page? > https://en.m.wikipedia.org/wiki/Special:MobileDiff/608773477... [17:30:22] bearND: adam === dr0ptp4kt [17:30:56] tfinc: thanks [17:31:12] tfinc and bearND: and sometimes == depending on static typing [17:31:27] hi bearND [17:31:32] bearND: I think the tests are failing because of our token storage. I can take a look later if you want. [17:31:35] dr0ptp4kt: lol. hi~ [17:32:14] brion: also https://gerrit.wikimedia.org/r/#/c/133737/ :) [17:32:24] \o/ [17:32:41] 1337 [17:32:56] oh wow [17:33:00] YuviPanda: btw, krinkle and i have push rights in the upstream lessphp repo [17:33:07] if you run into any issues we can accelerate a fix [17:33:30] ori: oh cool! the only bugger is how comments are re-ordered. [17:33:36] ori: this patch is just me being an idiot. [17:33:51] (03CR) 10Kaldari: [C: 04-1] "Got it running in Chrome (was missing the env var). When I run the new test, it fails on the 2nd upload:" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/130985 (https://bugzilla.wikimedia.org/64400) (owner: 10Jdlrobson) [17:34:29] dr0ptp4kt: one of our android tests for Zero is failing. when it requests https://en.wikipedia.org/w/api.php?action=zeroconfig&format=json&type=message&agent=WikipediaApp/2.0-alpha-2014-05-14%20(Android%204.4.2;%20Phone) the api returns [] (empty array) [17:35:08] dr0ptp4kt: looking at the test i think it did not do that before (assuming it passed at one point) [17:35:25] dr0ptp4kt: anything that strike you as odd in this request? should we change it? [17:36:17] bearND, looking [17:36:37] dr0ptp4kt: the WikipediaZeroTask expects an object with a message string [17:36:42] instead of the array [17:46:19] (03PS3) 10Kaldari: QA: Tests for 2nd upload from Special:Uploads page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/130985 (https://bugzilla.wikimedia.org/64400) (owner: 10Jdlrobson) [17:49:19] (03CR) 10Kaldari: [C: 04-1] "Rebased it, but the 2nd upload test still fails for me (although it works fine when doing it manually)." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/130985 (https://bugzilla.wikimedia.org/64400) (owner: 10Jdlrobson) [17:52:17] awjr: apropos of test2, that build is probably not worth much until we resolve this: https://bugzilla.wikimedia.org/show_bug.cgi?id=62509 I'm running it now post-yesterday's-deploy to see what it does, but I'll probably shut it down later today pending that bug. [18:02:06] dr0ptp4kt: i should mention that i'm doing this through wifi (not going through a carrier). other actions except config behave the same [18:03:14] bearND, yeah...hey, if you have an exit ip that's yours, please do pm it to me and i'll add it to the "TEST" operator configuration, which will help. that said, i'm going to try to update the test. my test runner is misbehaving, so hoping you can try it. will push the patch to gerrit shortly. [18:06:19] (03PS1) 10Dr0ptp4kt: Make W0 task handler test play more nicely. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/133755 [18:06:28] ^bearND would you please try that? [18:06:32] Deskana: :) [18:07:46] (03PS2) 10Dr0ptp4kt: Make W0 task handler test play more nicely. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/133755 [18:08:02] bearND: i mean that ^ (spelling correction) [18:13:23] 3MobileFrontend / 3stable: Severe regression: Impossible to scroll on iPhone 4.3.2 - 10https://bugzilla.wikimedia.org/65393 (10Max Semenik) 5PAT>3RES/FIX [18:49:42] Deskana: we will do an engineering cabal sometime too :P [18:50:05] lunch! [18:50:15] nom nom [18:50:20] (03PS4) 10Yuvipanda: Load styles via a StyleLoader [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/133488 [18:50:22] (03PS2) 10Yuvipanda: Fetch remote styles once a day and cache them [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/133640 [18:50:23] dbrant: wanna review? ^ [18:50:24] (03CR) 10jenkins-bot: [V: 04-1] Fetch remote styles once a day and cache them [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/133640 (owner: 10Yuvipanda) [18:50:27] waaat [18:50:43] ignore jenkins it is being slightly stupid [18:50:55] bearND: reviews appreciated ^ [18:51:35] bearND: I'm cool with investigating the token test failures as well. If you want, take yourself off that card and assign it to me [18:53:38] 3MobileFrontend / 3Feature requests: Allow all or part of a mobile formatted screen to be called from desktop site - 10https://bugzilla.wikimedia.org/65367#c3 (10Jared Zimmerman (WMF)) Jon, would implementing as an iframe be an acceptable short term solution for a beta feature environment? [18:54:19] (03PS5) 10Kaldari: Removing header margin and associated hacks [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/133170 [18:54:35] YuviPanda: will do [18:54:40] dbrant: thanks! [18:54:45] YuviPanda: i've added you to the card. are you also checking out dr0ptp4kt 's patch? (https://gerrit.wikimedia.org/r/133755 ) [18:55:07] bearND: no, can you do that? :) [18:55:23] (YuviPanda: btw, haven't forgotten about the mcc/mnc updates, which is different...will get to that one) [18:55:26] YuviPanda: just checked it out. it fixed the issue [18:55:33] bearND: cool :) feel free to merge! [18:55:54] dr0ptp4kt: can you schedule some sit-down time with bearND and dbrant to explain how the zero stuff works, both clientside and serverside? primarily serverside [18:56:07] YuviPanda: yep will do [18:56:20] (03CR) 10BearND: [C: 032] "works :)" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/133755 (owner: 10Dr0ptp4kt) [18:56:28] YuviPanda: ^ [18:56:33] bearND: cool! [18:56:42] (03Merged) 10jenkins-bot: Make W0 task handler test play more nicely. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/133755 (owner: 10Dr0ptp4kt) [18:57:34] dr0ptp4kt: thanks for the patch! :) [18:57:53] bearND, thanks for catching it [20:04:44] 3MobileFrontend / 3Feature requests: “0 bytes added” should be specially handled and show something better - 10https://bugzilla.wikimedia.org/64616#c5 (10Liangent) and maybe change that green text "0 bytes added" to gray text "no byte change" or something alike as well? [20:05:00] (03PS1) 10Yuvipanda: Remove source less files from the repo [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/133821 [20:05:02] dbrant|brb: bearND more patches! [20:05:18] dbrant|brb: bearND this hsould mostly complete https://trello.com/c/Bei6hEaD/40-3-point-the-apps-to-online-extension-mobileapp-css-resources [20:05:29] I will do some more optimizations later on (probably some lastmodifiedsince stuff) [20:05:39] YuviPanda: very nice [20:05:58] dbrant: :D This will also allow us to update page style css without having to update the app itself [20:06:12] dbrant: bearND do CR! [20:06:15] YuviPanda: yeah, that will be great [20:06:24] dbrant: yeah. [20:08:43] (03CR) 10Dbrant: [C: 032] Load styles via a StyleLoader [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/133488 (owner: 10Yuvipanda) [20:29:56] (03CR) 10BearND: [C: 031] "+1 so that dbrant can chime in as well" (033 comments) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/133640 (owner: 10Yuvipanda) [20:38:29] (03CR) 10Yuvipanda: Fetch remote styles once a day and cache them (031 comment) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/133640 (owner: 10Yuvipanda) [20:39:34] (03PS1) 10Dr0ptp4kt: Simplify automated test, use CasperJS atop PhanotmJS. [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/133828 [20:41:51] (03PS2) 10Yuvipanda: Remove source less files from the repo [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/133821 [20:41:53] (03PS3) 10Yuvipanda: Fetch remote styles once a day and cache them [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/133640 [20:42:23] (03CR) 10Yuvipanda: Fetch remote styles once a day and cache them (031 comment) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/133640 (owner: 10Yuvipanda) [20:42:30] bearND: responded to your comments [20:42:50] bearND: do test it as well. since we have no QA team or good automated tests, testing the change is a big chunk of CR work as well [20:48:31] (03PS2) 10Dr0ptp4kt: Simplify automated test, use CasperJS atop PhanotmJS. [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/133828 [21:13:12] (03CR) 10Mattflaschen: "> Right now, I run out of localStorage space on a regular basis when using Wikipedia. It's quite annoying having to manually clean out my " [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/131897 (owner: 10Kaldari) [21:18:49] dbrant: bearND am off now. cya next week! [21:19:18] YuviPanda|zzz: ok. cya [21:20:50] (03CR) 10BearND: [C: 031] Fetch remote styles once a day and cache them (031 comment) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/133640 (owner: 10Yuvipanda) [21:25:05] (03CR) 10Dr0ptp4kt: [C: 032] Simplify automated test, use CasperJS atop PhanotmJS. [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/133828 (owner: 10Dr0ptp4kt) [21:26:53] (03Merged) 10jenkins-bot: Simplify automated test, use CasperJS atop PhanotmJS. [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/133828 (owner: 10Dr0ptp4kt) [21:27:09] (03CR) 10Kaldari: ">> Right now, I run out of localStorage space on a regular basis when using Wikipedia. It's quite annoying having to manually clean out my" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/131897 (owner: 10Kaldari) [22:05:07] 3MobileFrontend / 3beta: MediaViewer conflicts with Zero - 10https://bugzilla.wikimedia.org/58778#c4 (10dr0ptp4kt) (In reply to Jon from comment #3) > Did we fix this? I forget.. Not sure. How far off is media viewer going to stable? [22:15:10] (03PS1) 10Dr0ptp4kt: Make automation test README more accurate. [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/133847 [22:15:31] (03CR) 10Dr0ptp4kt: [C: 032] Make automation test README more accurate. [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/133847 (owner: 10Dr0ptp4kt) [22:15:42] (03Merged) 10jenkins-bot: Make automation test README more accurate. [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/133847 (owner: 10Dr0ptp4kt) [22:27:45] mhurd: yeah do you have that in gerrit or someplace? [22:28:00] or github is fine too [22:29:00] brion: i’ll submit it for gerrit review in just a sec - it’s a hefty patch, but seems solid [22:29:06] ok [22:32:22] brion: the gist of the refactor was to keep using a navigationcontroller for pushing/popping view controllers, but to no longer use the navigationbar for cue for where to position top navigation. this eliminates all sorts of silly hacky hoops i had to jump through to, say, event change the nav bar height. it’s weird. so instead i containerized top, middle and bottom pieces in a root view controller - which you’ll see in the storyboard [22:32:38] aha [22:32:41] makes sense [22:32:41] *even change* [22:32:53] * brion digs out the ios 6 test devices :D [22:34:14] brion: so the top menu will be changing quite a bit after this backend stuff gets merged - as will the bottom menu. oh, also fixed the landscape text size issue in this patch and the ios6 blanking out the web view occasionally issue [22:34:26] \o/ [22:35:00] brion: doing super fast sanity check... [22:35:07] hehe [22:38:27] (03PS1) 10Mhurd: Refactor setting stage for menu styling stories. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/133857 [22:38:30] brion: ^ [22:39:33] whee [22:41:09] brion: what had previously been NavController.m is now TopMenuViewController.m and CenterNavController.m. That split drove most of the rest of the update - really happy to have teased apart the nav controller code from the top menu code [22:41:23] spiff [22:42:00] brion: oh, be sure to clear the derived data thing in organizer [22:43:12] brion: just realize i need to change the “NAVBAR_” enums to “TOPMENU_”, but that can come later i suppose [22:43:21] ok :) [22:43:26] testing and looking over code... [22:44:47] brion: i’ll start getting the bottom webview menu into the new structure [22:44:55] ok [22:45:28] brion: oh, tap white space to toggle top menu :) [22:45:44] cute :D [22:46:19] brion: the new structure will make it *much* easier to do all sorts of neat top menu things [22:46:29] awesome :D [22:46:53] nothing obviously exploding on device clicking around so far :D [22:47:16] brion: which is suprising given this entire patch was coded yesterday ;) [22:47:26] lol [22:47:51] brion: i was a little freaked out ripping so many things apart [22:48:22] when you have fewer pieces to put back than you had to rip out, that’s a sign you’ve improved modularity [22:48:27] either that or you missed a piece ;) [22:48:28] :) [22:48:31] hahah [22:50:35] (03CR) 10Brion VIBBER: "Looks good so far!" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/133857 (owner: 10Mhurd) [22:50:42] mhurd: so far so good [22:50:47] yay! [22:50:54] anything else you want to do on that patch or shall i go ahead and merge [22:51:24] brion: i think it’s a good place to merge [22:52:00] great [22:52:34] (03CR) 10Brion VIBBER: [C: 032 V: 032] "Not crashing on 6.1 or 7.1 test devices; code looks sane enough and is a nice bit cleaner than before. Merging before next steps. Yay!" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/133857 (owner: 10Mhurd) [22:53:38] brion: there may have been a few deleted files that for some reason didn’t go away. may have quick patch for that once i confirm [22:55:58] no worries [23:10:19] brion: patch forthcoming.. [23:14:25] \o/ [23:15:50] (03PS1) 10Mhurd: Removed extra files. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/133861 [23:15:52] brion: ^ [23:16:35] brion: not sure how those persisted [23:22:19] some files never die [23:22:30] they just… disappear from the xcode UI and sit around on disk [23:22:50] (03CR) 10Brion VIBBER: [C: 032 V: 032] Removed extra files. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/133861 (owner: 10Mhurd) [23:22:55] brion: woohoo! [23:23:01] brion: thanks! [23:28:50] (03PS1) 10MaxSem: mobileview: handle pages redirecting to special/media [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/133866 (https://bugzilla.wikimedia.org/64305) [23:29:28] (03CR) 10jenkins-bot: [V: 04-1] mobileview: handle pages redirecting to special/media [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/133866 (https://bugzilla.wikimedia.org/64305) (owner: 10MaxSem) [23:57:23] 3MobileFrontend / 3Feature requests: Allow all or part of a mobile formatted screen to be called from desktop site - 10https://bugzilla.wikimedia.org/65367#c4 (10Max Semenik) 5NEW>3RES/WON Per standup review: this is not how things are done: clients shouldn't get rendered HTML from servers. Instead, they...