[11:05:23] (03PS1) 10Yuvipanda: Do not clear out history after every 30 days [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/133966 [11:05:36] ragesoss: hey! around? [11:18:16] YuviPanda: or here? [11:18:22] liangent: yeah :) [11:18:58] YuviPanda: I don't have this channel in my autojoin list [11:19:06] liangent: you should add! :) [11:22:19] liangent: question, re: reading history on the app [11:22:25] liangent: when do you expect it, as a user, to be cleared? [11:25:00] YuviPanda: not something eager. I've been finding some feature on my phone from time to time and finally I turned to use mobilefrontend [11:25:05] but I can't remember what it is now :/ [11:25:35] liangent: hmm, the current app removes them after 30 days. That is considered a 'feature', but I don't think that matches user expectations. Just submitted a patch to remove that feature [11:25:47] liangent: 'finding some feature'? you mean features missing? [11:26:15] oh sorry I misunderstood you [11:26:39] I read it as read page history in the app [11:26:50] so "it's not a feature I want eagerly" :p [11:27:22] if you're talking about "History" in sidebar... [11:27:41] I would say I don't want it to disappear, and I really use it [11:27:53] YuviPanda: ^ [11:27:57] liangent: I just added 'search' to it as well [11:28:10] liangent: cool! https://gerrit.wikimedia.org/r/133966 rmeoves the auto clearing [11:29:16] not sure if it would slow down the app after the list grows very long... [11:29:56] liangent: it shouldn't. only concern is disk space usage [11:30:36] liangent: but even at say 512 bytes per entry (it is far less than that), that's 2048 pages before it hits 1MB [11:30:53] liangent: but there's the clear all button anyway [11:32:16] YuviPanda: well if it's stored forever and if there're use cases that some people clear it for device storage, I guess a button like "clear entries older than 30 says" is useful [11:32:27] liangent: ah, hmm. maybe. [11:32:36] dunno where to put that, tho [11:32:46] liangent: you can also do multiple selection, and clear just htose [11:33:22] multiselecting all entries older than 30 days manually is unrealistic [11:33:46] true, and there's no select all [11:34:20] and even, multiselecting items to delete for storage is unrealistic [11:34:41] liangent: I don't know where to put such a button, and I don't want to muddy the actionbar with two delete buttons [11:34:42] I would buy a new phone if I can only free up a few bytes with a tap [11:35:26] show the feature by long-pressing the delete button? [11:35:43] YuviPanda: [11:35:59] hmm [11:36:03] that's not a bad idea [11:36:29] let me see if it is easy to detect that with the action bar [11:36:29] or add a dropdown in the "clear history" dialog? [11:36:57] liangent: hmm, actually, a checkbox in the clear history dialog sounds like a good idea. [11:37:12] liangent: let me file a bug [11:38:21] YuviPanda: firefox has a dropdown labeled "Time range to clear" in "Clear Recent History" dialog [11:38:35] yeah, and I am utterly not a fan of that :P [11:38:42] (but that's used to clear "recent" history [11:40:55] 3Wikipedia App / 3History: Offer a way to only clear old history - 10https://bugzilla.wikimedia.org/65449 (10Yuvi Panda) 3NEW p:3Unprio s:3normal a:3None The app currently clears all history older than 30days automatically, but since this is apparently inconsistent with user expectations the feature... [11:41:03] liangent: ^ [11:41:07] 3Wikipedia App / 3History: Offer a way to only clear old history - 10https://bugzilla.wikimedia.org/65449 (10Yuvi Panda) p:5Unprio>3Low s:5normal>3enhanc [11:41:33] YuviPanda: I feel there're "stupid Java" in comments everywhere, in the codebase of the app.. [11:41:44] liangent: indeed. along with 'this never happens' [11:42:23] YuviPanda: in try-catch'es? [11:42:26] liangent: yeah [11:43:20] YuviPanda: last time I asked, how can I test the app on beta lab? [11:44:17] liangent: as in? [11:44:23] liangent: point it to betalabs instead of cluster? [11:45:00] YuviPanda: yeah [11:45:03] liangent: why? [11:45:35] YuviPanda: test upstream bugs [11:45:50] liangent: oh, hmm. I could make you a one off build, but that's going to be a bit of a pain to update. [11:45:56] liangent: which upstream bugs? [11:46:11] liangent: it's not too hard to make a one off that points to beta [11:46:11] last time it was hash in user name [11:46:42] and there will be other bugs in the future... [11:46:59] liangent: was that fixed upstream, btw? [11:47:35] YuviPanda: hash in user name is now rejected explicitly in core [11:47:42] liangent: oh cool! [11:48:29] liangent: do you want a one off build? [11:49:05] YuviPanda: hmm not now thanks [11:49:19] it might already be live now [11:49:25] liangent: ok! might be on test, yeah [11:50:11] liangent: if you set your wiki in settings to test, login and create account requests would go to test [11:50:45] and I said maybe it's possible to offer a hidden pref... [11:50:59] to set target url... [11:51:12] a pref not in ui and only editable by editing xml maybe... [11:52:42] hmm [11:53:21] liangent: editing which XML? I don't fully understand how that works. have a link? [11:53:59] YuviPanda: editing org.wikipedia_preferences.xml [11:54:24] /data/data/org.wikipedia/shared_prefs/org.wikipedia_preferences.xml , you don't know this? [11:54:55] aaaah [11:54:57] right. [11:55:05] no, I didn't know it was stored in an xml file [11:55:57] and it's bad that user password is stored in plain text here [11:56:13] true, but there's not much better solution [11:56:20] oauth? [11:56:21] if you encrypt it with a key, where do you put the key? [11:56:35] then you'd have the token there [11:56:39] not as bad as password, but still [11:57:59] post-it note on the side of your monitor [11:58:07] but I only have a laptop [11:58:24] well, a sturdy CRT is a good investment [11:58:27] security is important [11:58:32] liangent: OAuth also has no mobile story, plus it's terrible UX. [11:59:06] liangent: plus you need to root the phone and grant an app sudo before it can read other apps' internal data [11:59:27] ori: carrying it across borders would be problematic [11:59:43] YuviPanda: hm? [11:59:49] how is it related to rooting? [12:00:19] liangent: org.wikipedia_preferences.xml is not accessible to other apps normally [12:00:20] oh you mean plain text password .. right [12:01:53] yeah [12:02:25] YuviPanda: re the missing feature, I was thinking about watchlist [12:02:36] liangent: right. [12:02:59] liangent: we should probably add it next iteration, but then we'd have to have some actions. diff view, revert, talk page access? [12:03:47] so that's a bit of a big chunk of work [12:03:53] that's also why we killed my contributions [12:04:24] not necessary, as long as it's possible to jump to the section where a discussion happened automatically [12:05:26] liangent: that works for tlak pages, but not content [12:05:27] YuviPanda: for mycontribs, there's no such use case. I know what I edited myself [12:05:32] yeah [12:06:04] hm actually I don't monitor article content a lot [12:06:30] btw it seems in MF they encourage users to use watchlist as some "bookmark" feature [12:06:58] yeah, it's a bit weird :P [12:07:56] http://mobile-reportcard.wmflabs.org/ has some stats [12:10:53] YuviPanda: what's "Android uploads" [12:10:56] do we have this feature? [12:11:17] liangent: there's a commons app :) [12:12:32] liangent: on the play store [12:13:26] YuviPanda: they request a lot of permissions... [12:13:38] liangent: hmm? [12:13:53] commons app requests a lot of permissions [12:14:19] specifically there're account related ones [12:14:43] are they storing passwords / tokens inside Android's account infrastructure? [12:15:03] liangent: yeah [12:15:10] liangent: decided to not do that with the wikipedia app [12:15:40] YuviPanda: to reduce permissions required? [12:15:53] liangent: it was also simpler to do by a fair bit [12:17:20] liangent: we'll probably integrate photo upload into the app at some future point, but far off [12:18:48] YuviPanda: I rarely do uploads in my phone... [12:19:13] liangent: yeah, that's why it is a far off feature [12:21:08] 3MobileFrontend / 3beta: MediaViewer conflicts with Zero - 10https://bugzilla.wikimedia.org/58778#c6 (10dr0ptp4kt) (In reply to Andre Klapper from comment #5) > Don't know "stable", but MediaViewer will go live on en.wp next week: > https://en.wikipedia.org/wiki/Wikipedia: > Village_pump_%28technical%29#Medi... [12:22:27] liangent: I'll probably go add a search feature to bookmarks now. [12:22:34] liangent: not sure if you noticed - saved pages is now bookmarks. No more offline reading [12:27:00] YuviPanda: I know it, and I still seldom use it [12:27:13] liangent: :) cool. [12:36:26] YuviPanda: what does the app send with "Send usage reports"? [12:37:48] liangent: EventLogging data. I can show you the schemas if you want. [12:38:20] liangent: https://meta.wikimedia.org/wiki/Schema:MobileWikiAppReadingAction https://meta.wikimedia.org/wiki/Schema:MobileWikiAppCreateAccount https://meta.wikimedia.org/wiki/Schema:MobileWikiAppLogin https://meta.wikimedia.org/wiki/Schema:MobileWikiAppEdit [12:39:32] YuviPanda: is it batched, or sent as soon as an event happens? [12:39:40] liangent: as soon as the event happens. [12:40:08] YuviPanda: hm I think I should disable it to reduce data usage [12:40:22] liangent: yeah, you could. it's not much, though. [12:40:28] well, for some definition of 'mcuh' [12:40:30] *much [12:41:21] YuviPanda: I guess http header is a big overhead compared to logging data [12:41:40] liangent: the data is in the URL, these are just GETs [12:41:53] liangent: but yeah, spdy or somesuch might help, but we don't have any of that yet [12:43:02] and ssl handshake. does the app reuse connections? [12:43:37] YuviPanda: and by the way did you get https://bugzilla.wikimedia.org/show_bug.cgi?id=64393 ? [12:43:47] liangent: it should reuse connections, yeah [12:44:02] liangent: oh, yeah. sorry, forgot about it in travelling. [12:44:17] liangent: this is for tools, right? the general labs proxy lets things through [12:44:25] for tools [12:44:47] YuviPanda: liangent: it should reuse connections, yeah << so I guess this mean it's not reusing for now? [12:44:52] worth a bug? [12:45:30] liangent: no, I mean, I haven't verified it but the library we use should reuse connections automatically. It is an advertised feature [12:46:14] find [12:46:16] *fine [12:48:30] liangent: so for tools the proper thing to do would be to pass through if there's a body from upstream, and generate own if there isn't [12:48:37] not fully sure how to do that [12:50:41] so let tool authors decide whether to replace error pages for their tools? [12:52:25] 3Wikipedia App / 3Generic: Batch eventlogging upload - 10https://bugzilla.wikimedia.org/65450 (10Liangent) 3NEW p:3Unprio s:3normal a:3None To reduce data usage, given HTTP overhead exists. Better to upload in WiFi only. Save traffic further. Note that there's a "mobile hotspots" in Android. [12:54:25] YuviPanda: have to test whether lighttpd generates a "useless body" first... [12:56:52] liangent: right. you should be able to do that right now, I think. [12:57:11] liangent: figure out which host / port your lighty is running and curl from inside tools [13:06:18] YuviPanda: this doesn't work [13:06:40] tools.liangent-php@tools-webgrid-01:~$ curl http://127.0.0.1:46110 [13:06:40] curl: (7) couldn't connect to host [13:06:41] liangent: 'this'? [13:06:45] liangent: what are you trying? [13:06:49] tools.liangent-php@tools-login:~$ curl http://tools-webgrid-01:46110/ -v [13:06:50] * About to connect() to tools-webgrid-01 port 46110 (#0) [13:06:50] * Trying 10.68.16.28... Connection refused [13:06:50] * couldn't connect to host [13:06:50] * Closing connection #0 [13:06:50] curl: (7) couldn't connect to host [13:06:57] checking [13:07:49] liangent: are you sure that's the right port? I ssh'd into tools-webgrid-01 and curl'd and got the same thing [13:08:16] hmm, I do see there's an active connection from the proxy to that tho [13:08:26] tools.liangent-php@tools-webgrid-01:~$ netstat -e | grep liangent-php [13:08:27] tcp 0 0 tools-webgrid-01.:46110 tools-webproxy.eqi:8282 ESTABLISHED tools.liangent-php 455668297 [13:09:15] right [13:09:22] let me try from the proxy [13:09:54] hmm, same from the proxy as well? wth [13:13:53] 3Wikipedia App / 3Generic: Batch eventlogging upload - 10https://bugzilla.wikimedia.org/65450#c1 (10Yuvi Panda) p:5Unprio>3Low s:5normal>3enhanc Our serverside EventLogging infrastructure does not support this yet, and AFAIK there are no plans to do so. Supporting SPDY would be a good alternative. [13:16:08] 3Wikipedia App / 3Generic: Batch and delay eventlogging upload - 10https://bugzilla.wikimedia.org/65450 (10Liangent) [13:26:12] YuviPanda: did u say anything to me? [13:26:26] liangent0: i tried curling from the proxy and got the same thing [13:26:29] not sure what's going on there [13:27:06] and is it possible to disable content overriding per user? [13:28:43] liangent0: possible, yes. Unsure how exactly to expose it. [13:29:02] liangent0: perhaps I should just let 500s come through and just override the others [13:29:42] YuviPanda: mw uses 404... [13:29:47] 500 and 404 [13:30:25] YuviPanda: then what's left? [13:31:14] liangent0: 403, 502 and 503 [13:31:23] liangent0: this is Coren's code, I'm unsure why he's hijacking them. [13:31:30] liangent0: I think the hijacked page displays the maintainer names, etc [13:31:59] liangent0: a easier way would perhaps have a query param (like debug=true) the presence of which will not trigger any of the overrides [13:32:30] YuviPanda: I guess we should discuss this in -labs [14:23:08] 3Wikipedia App / 3Generic: java.lang.IllegalStateException: Fragment PageViewFragment{42c490f8} not attached to Activity - 10https://bugzilla.wikimedia.org/64493#c5 (10Yuvi Panda) Can you repro this now, Liangent? [14:25:08] 3Wikipedia App / 3Generic: Following a link which can't be handled on the device crashes the app - 10https://bugzilla.wikimedia.org/64424#c4 (10Yuvi Panda) Is this still the case? I can't find any link that crashes the app. [14:29:22] 3Wikipedia App / 3Generic: Mobile Apps: Trying to create a username with a hash in should present the user with an error - 10https://bugzilla.wikimedia.org/64409#c8 (10Yuvi Panda) The Upstream bug has been fixed, let me test locally and see if it is ok on the app. [14:40:54] 3Wikipedia App / 3Generic: the app should register itself as a handler for shared text (and look up it) - 10https://bugzilla.wikimedia.org/65458 (10imz) 3NEW p:3Unprio s:3normal a:3None I'm using Version 1.3.4 of the Android app from the F-Droid repo ( https://f-droid.org/repository/browse/?fdfilter=... [14:42:38] 3Wikipedia App / 3Generic: the app should register itself as a handler for shared text (and look up it) - 10https://bugzilla.wikimedia.org/65458 (10imz) [15:33:36] YuviPanda: https://zh.wikipedia.org/wiki/User:Liangent/wwlink does this link crash your app? [15:49:07] 3Wikipedia App / 3Generic: Following a link which can't be handled on the device crashes the app - 10https://bugzilla.wikimedia.org/64424#c6 (10Yuvi Panda) Testing in a moment... [16:03:32] YuviPanda: got it? [16:03:51] or do you need a backtrace? [16:06:07] 3MobileFrontend / 3beta: MediaViewer conflicts with Zero - 10https://bugzilla.wikimedia.org/58778#c8 (10Jon) No this is completely different code. I suspect it might be released before the tablet redirect so as not to remove any functionality. Maryana would be able to confirm on that. [17:23:27] 3Wikipedia App / 3Generic: Get Wikipedia app on f-droid - 10https://bugzilla.wikimedia.org/65460 (10Yuvi Panda) 3NEW p:3Unprio s:3normal a:3None F-Droid is a FOSS App Store available for Android, and has hosted our apps in the past. Should get the app on it at some point. This is going to be fairly... [17:23:39] 3Wikipedia App / 3Generic: Get Wikipedia app on f-droid - 10https://bugzilla.wikimedia.org/65460 (10Yuvi Panda) p:5Unprio>3Lowest s:5normal>3enhanc [17:49:54] YuviPanda: ^ ^ [18:16:39] liangent: still crashes, can verify. let me fix [18:16:41] liangent: I don't know what the appropriate solution is, though. [18:16:43] just pop up a dialog saying 'can not handle, sorry'? [18:26:39] 3Wikipedia App / 3Automated Builds: Get Wikipedia app on f-droid - 10https://bugzilla.wikimedia.org/65460 (10Yuvi Panda) [18:41:50] YuviPanda: and is the spinning circle mentioned by dan garry another bug? [18:51:12] liangent: yeah, and that sould mostly be fixed now [19:54:40] YuviPanda: tapping an image on commons => This page does not exist // is this bug tracked? [20:03:25] 3Wikipedia App / 3Generic: Long-pressing "save" button (the floppy disk) shows an empty bubble - 10https://bugzilla.wikimedia.org/65463 (10Liangent) 3NEW p:3Unprio s:3normal a:3None A message is expected there but someone assigned an empty one?