[08:49:45] (03CR) 10JGonera: [C: 032] Add iOS hover bug fix [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/131089 (https://bugzilla.wikimedia.org/64669) (owner: 10Jdlrobson) [08:50:26] (03Merged) 10jenkins-bot: Add iOS hover bug fix [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/131089 (https://bugzilla.wikimedia.org/64669) (owner: 10Jdlrobson) [11:15:57] kaity, you're in SF? [13:05:23] (03CR) 10JGonera: [C: 04-1] "Breaks the header in search overlay slightly. Type a search term, the X (clear input) button is too far to the right. Also, the right marg" (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/131892 (https://bugzilla.wikimedia.org/64719) (owner: 10Jdlrobson) [13:11:21] (03CR) 10JGonera: [C: 04-1] "Inline + having a follow-up patch that shows how it's going to be used would be useful too." (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/131897 (owner: 10Kaldari) [13:22:54] (03PS1) 10Dbrant: Keep only a limited number of WebViews in memory. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/134083 (https://bugzilla.wikimedia.org/64450) [13:30:40] (03CR) 10Dbrant: [C: 032] Make History list searchable [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/133941 (owner: 10Yuvipanda) [13:42:26] (03PS1) 10Dbrant: Added title to Save Edit menu item. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/134086 (https://bugzilla.wikimedia.org/65463) [14:04:32] Hey, does mobile still need/want/ wikis to do redirects based on user agent from their common.js? [14:04:38] https://mt.wikipedia.org/w/index.php?title=MediaWiki:Common.js&oldid=237545 [14:04:42] * Maintainer: [[User:Brion VIBBER]], [[User:hcatlin]] [14:04:45] if (/(Android|iPhone|iPod|webOS|NetFront|Opera Mini|SEMC-Browser|PlayStation Portable|Nintendo Wii)/.test(navigator.userAgent)) { [14:04:48] return 'http://' + wgContentLanguage + '.m.wikipedia.org/wiki/' + pageLink + "?wasRedirected=true" [14:05:23] Tip for next time, if you put it in common.js, it will be copied to 100s of wikis over the course of weeks/months, and they will not be kept up to date (one time copies, or every once in a blue moon) [14:06:09] Ask someone with deployer access to tin to run mwgrep to find usage (e.g. tin$ mwgrep stopMobileRedirectCookieExists) [15:13:50] (03PS1) 10Dbrant: Improve appearance of RTL languages in app language selection. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/134099 [15:28:14] 3Wikipedia App / 3History: iOS: Page history should not be cleared periodically, and there should be a clear history button - 10https://bugzilla.wikimedia.org/65489 (10Dan Garry) 3NEW p:3Unprio s:3normal a:3None For consistency with Android. [15:59:35] Hi YuviPanda: got a question about https://gerrit.wikimedia.org/r/#/c/133821/2. Why are most of the css files the same? There is only a slight different in the preview one. [16:06:58] 3Wikipedia App / 3Search: Android: "Network error. Tap to try again." bar is too persistent - 10https://bugzilla.wikimedia.org/64773 (10Bernd Sitzmann) 5NEW>3ASS a:3Bernd Sitzmann [16:11:41] (03CR) 10BearND: [C: 031] "Not sure why most of the css files are the same? There is only a slight difference between preview.css and the other ones." (032 comments) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/133821 (owner: 10Yuvipanda) [16:36:05] how'dyyyy [16:40:31] (03PS7) 10Jdlrobson: Fix VE performance by cleaning up ui.less now universal header [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/131892 (https://bugzilla.wikimedia.org/64719) [16:47:26] (03CR) 10Jdlrobson: "I'm confused Juliusz - can you demonstrate in a screenshot - I can't see any difference between master and my version..." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/131892 (https://bugzilla.wikimedia.org/64719) (owner: 10Jdlrobson) [16:47:51] (03PS8) 10Jdlrobson: Fix VE performance by cleaning up ui.less now universal header [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/131892 (https://bugzilla.wikimedia.org/64719) [16:49:11] jdlrobson, still ooo? [16:49:36] MaxSem: yeh i'm back a week today, an back in office tuesday next week (as long as jet lag is not too horrible) [16:49:38] you missing me? [16:49:50] MaxSem: how is your house hunting going? [16:50:05] was at first 2 open houses [16:50:32] ran away from first one because the street was horrible [16:50:58] looked at the closet they call studio on the second one [16:51:36] san frakcisco baby! [16:52:29] (03PS6) 10Jdlrobson: Removing header margin and associated hacks [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/133170 (owner: 10Kaldari) [16:52:41] MaxSem: haha [16:52:44] open houses are horrible [16:53:12] i've got all this fun to go through when i get back - i was just given my 30 day notice in my house :-) [16:53:19] just houses here are also horrible [16:55:28] MaxSem: :) [17:00:22] jgonera: standup! [17:03:58] jdlrobson: MaxSem: Your current activity regarding tables and redirects seems relevant to what I reported earlier today [17:04:07] Krinkle: Hey, does mobile still need/want/ wikis to do redirects based on user agent from their common.js? [17:04:07] 16:04 Krinkle: https://mt.wikipedia.org/w/index.php?title=MediaWiki:Common.js&oldid=237545 [17:04:07] 16:04 Krinkle: * Maintainer: [[User:Brion VIBBER]], [[User:hcatlin]] [17:04:09] 16:04 Krinkle: if (/(Android|iPhone|iPod|webOS|NetFront|Opera Mini|SEMC-Browser|PlayStation Portable|Nintendo Wii)/.test(navigator.userAgent)) { [17:04:11] 16:04 Krinkle: return 'http://' + wgContentLanguage + '.m.wikipedia.org/wiki/' + pageLink + "?wasRedirected=true" [17:04:13] 16:05 Krinkle: Tip for next time, if you put it in common.js, it will be copied to 100s of wikis over the course of weeks/months, and they will not be kept up to date (one time copies, or every once in a blue moon) [17:04:15] 16:06 Krinkle: Ask someone with deployer access to tin to run mwgrep to find usage (e.g. tin$ mwgrep stopMobileRedirectCookieExists) [17:04:17] 16:16 [17:05:19] mm? [17:06:20] jdlrobson: It redirects tablets with javascript [17:06:30] So this varnish change may not work as intended for a lot of wikis [17:06:48] Krinkle: why would we want to redirect with JavaScript ?(not sure i've been involved in this conversation) [17:06:55] I don't [17:07:07] I just saw that random script on a whole bunch of wikis while cleaning up in the last couple of weeks [17:07:09] thought I'd let you know [17:07:12] good luck :) That's all we know. [17:08:15] weird [17:08:54] Krinkle: looks like old school code [17:09:01] Blame brion :P [17:09:07] Krinkle: not sure what best action is here - to remove it or leave message on talk page [17:09:09] It usees the right cookies interesitngly [17:09:17] which could be a problem [17:09:58] If it's uncontroversial get a global script editor from the community (me) or staffer (James_F) to edit it our with a link to a useful page or mailing list post [17:09:58] Krinkle: where did you see this? [17:10:03] I did include a link [17:10:04] awjr: https://mt.wikipedia.org/w/index.php?title=MediaWiki:Common.js&oldid=237545 [17:10:14] tin$ mwgrep stopMobileRedirectCookieExists [17:10:17] there's 12 more matches [17:10:24] so 12 different wikis [17:10:32] possibly more, they mightve renamed the function etc. [17:11:05] mwgrep stopMobileRedirect; 14 matches [17:12:21] Krinkle, jdlrobson so what does this code do? redirect from mobile back to desktop? [17:13:06] jgonera: code seems pointless [17:13:25] doesn't do anything different from what we already have in place [17:13:35] and it only applies to desktop site [17:13:50] redirecting desktop site to mobile [17:13:50] yey for Common.js! [17:13:50] such a genius idea ;-P [17:14:00] hm, so it's crappy but won't mess up our tablet redirect? [17:15:20] (03CR) 10JGonera: [C: 032] "For some reason it works fine now. Probably some other change fixed it and rebasing helped." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/131892 (https://bugzilla.wikimedia.org/64719) (owner: 10Jdlrobson) [17:16:04] (03Merged) 10jenkins-bot: Fix VE performance by cleaning up ui.less now universal header [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/131892 (https://bugzilla.wikimedia.org/64719) (owner: 10Jdlrobson) [17:16:18] (03CR) 10Jdlrobson: [C: 032] "WFM" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/133866 (https://bugzilla.wikimedia.org/64305) (owner: 10MaxSem) [17:17:03] (03Merged) 10jenkins-bot: mobileview: handle pages redirecting to special/media [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/133866 (https://bugzilla.wikimedia.org/64305) (owner: 10MaxSem) [17:17:11] 3MobileFrontend / 3stable: Drop use of nth-child selector in ui.less - 10https://bugzilla.wikimedia.org/64719 (10Jon) 5PAT>3RES/FIX [17:17:27] 3MobileFrontend / 3stable: mobileview fails on content pages redirecting to special pages - 10https://bugzilla.wikimedia.org/64305 (10Jon) 5PAT>3RES/FIX [17:17:50] MaxSem: so are you still working on https://gerrit.wikimedia.org/r/#/c/132012/ [17:17:58] also can we take a look at https://gerrit.wikimedia.org/r/#/c/132518/ together to get that merged? [17:18:32] I just really don't like the $par tests they make the if statements really confusing to read [17:19:46] jgonera: correct [17:20:11] (03PS4) 10Jdlrobson: Respect the hash with sub headings [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/133470 (https://bugzilla.wikimedia.org/64918) [17:21:22] is there already a bug about redirects to specific sections not working on mobile? (Rather, they just redirect to the top of the article.) [17:21:37] ragesoss: web or apps? [17:22:18] both. [17:23:05] ragesoss: not that I know of. [17:23:07] ragesoss: yep that patch above :) [17:23:14] (RESPECT the hash) [17:23:18] ragesoss: file one for apps? :) [17:23:23] haha, good timing ragesoss & jdlrobson [17:23:25] YuviPanda: will do. [17:23:33] :D [17:23:36] ragesoss: congrats on your move btw :) [17:23:41] thanks! [17:24:01] (03PS6) 10Jdlrobson: Hygiene: Sensible defaults for textarea elements [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/131881 [17:24:26] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Sensible defaults for textarea elements [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/131881 (owner: 10Jdlrobson) [17:25:44] awjr: any experience with vagrant throwing the error "Warning: include_once(/vagrant/mediawiki/extensions/Parsoid/php/Parsoid.php): failed to open stream: No such file or directory in /vagrant/settings.d/puppet-managed/10-Parsoid.php on line 4" [17:26:37] jdlrobson: no but it sounds like parsoid is misconfigured [17:26:41] maybe the code paths have changed? [17:26:55] does that file exist jdlrobson? [17:27:07] maybe - all i did was add the parsoid role [17:27:10] i'll ssh in and look [17:27:40] (03CR) 10JGonera: [C: 04-1] "Text (heading title) and icons don't seem to be center-aligned. Also the whole header seems to have less padding, was this intentional? Pl" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/133170 (owner: 10Kaldari) [17:28:32] awjr: parsoid is there but an empty directory [17:28:56] jdlrobson: is the code up to date? [17:29:32] awjr: yup [17:29:59] 3Wikipedia App / 3Generic: Links to specific sections of articles don't work - 10https://bugzilla.wikimedia.org/65496 (10Sage Ross) 3NEW p:3Unprio s:3normal a:3None If a link (such as a redirect) includes a hash link to a particular section, it should take the user to the specified section of the art... [17:29:59] jdlrobson: it's possible that the config instructions in vagrant haven't been updated if there have been changes to file paths, etc [17:30:05] jdlrobson: dbl check with gabriel [17:31:50] jdlrobson, you did run vagrant provision, right? [17:31:51] my cat has started sitting on the printer [17:31:52] (03CR) 10Yuvipanda: "These are auto generated from the server - see the bash script for the source. The PHP LESS compiler mediawiki uses munges comments so the" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/133821 (owner: 10Yuvipanda) [17:31:55] jdlrobson: also - have you run vagrant provision recently? [17:31:58] i know i’m gonna end up with cat hair in my printouts [17:32:03] oh jinx jgonera :p [17:32:08] ;) [17:35:07] Krinkle, hey [17:35:17] thanks for the warning [17:35:22] fixeeeeng [17:36:00] dbrant: see my response [17:36:13] awjr: yup [17:36:25] awjr: just removed it add readied it [17:36:28] might have fixed it.. [17:36:30] (03CR) 10Yuvipanda: [C: 032] Added title to Save Edit menu item. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/134086 (https://bugzilla.wikimedia.org/65463) (owner: 10Dbrant) [17:36:40] (03PS4) 10Jdlrobson: Hygiene: Make border-box the default [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/133188 [17:37:23] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Make border-box the default [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/133188 (owner: 10Jdlrobson) [17:37:54] (03Merged) 10jenkins-bot: Added title to Save Edit menu item. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/134086 (https://bugzilla.wikimedia.org/65463) (owner: 10Dbrant) [17:37:56] YuviPanda: response to? [17:38:06] dbrant: damn, I meant bearND [17:38:07] sorry [17:38:11] np! [17:38:12] bearND: see my response to the css patch CR [17:41:52] (03CR) 10Kaldari: "jgonera: can you you send a screenshot, or at least tell me what browser you're looking at and which page? The titles and icons look verti" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/133170 (owner: 10Kaldari) [17:43:21] (03PS1) 10Jdlrobson: Hygiene: Browser test cleanup [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/134134 [17:45:20] YuviPanda: thanks. i saw it. so, since this is not marked as WIP i can +2, right? [17:46:58] bearND: yup! [17:46:59] 3MobileFrontend / 3Feature requests: mobile-friendly templates should be easy to create - 10https://bugzilla.wikimedia.org/65498 (10darklama) 3NEW p:3Unprio s:3enhanc a:3None mobile-friendly templates should be easy to create either by having separate desktop and mobile templates, or by providing a m... [17:47:02] bearND: but it has a dependent patch :) [17:47:31] jdlrobson: you get it working? [17:48:25] awjr: looks like it :) [17:48:27] 3Wikipedia App / 3Generic: Tapping edit soon after the activity is recreated crashes the app - 10https://bugzilla.wikimedia.org/65499#c1 (10Liangent) java.lang.NullPointerException at org.wikipedia.editing.EditHandler.onMessage(EditHandler.java:32) at org.wikipedia.bridge.CommunicationBridge$2.handleMessage(... [17:48:33] cool jdlrobson [17:48:37] dbrant: do you want to CR those first, or can i +2 both of them? [17:48:47] so jgonera kaldari question now is how can i get references up and running on vagrant [17:48:50] it looks like the parsoid role is busted but if you just use the visualeditor role parsoid gets set up correctly [17:49:14] Krinkle, I see some wikis are using [[MediaWiki:Common.js/mobile.js]] - is it even loaded? [17:49:23] Maybe, maybe not. [17:49:28] Probably yes [17:49:42] I see no references to it in common.js [17:49:48] Via Common.js, or via a gadget, or user script [17:49:52] or by url directly [17:50:26] 3MobileFrontend / 3Feature requests: mobile-friendly templates should be easy to create - 10https://bugzilla.wikimedia.org/65498#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/xn4GbsPV [17:50:30] meh, LCA took our global delete rights [17:50:32] bearND: sure, I was just looking at this one anyway: https://gerrit.wikimedia.org/r/#/c/133640/3 [17:50:43] 3MobileFrontend / 3Feature requests: mobile-friendly templates should be easy to create - 10https://bugzilla.wikimedia.org/65498#c2 (10Jon) Would this help? https://www.mediawiki.org/wiki/Requests_for_comment/Allow_styling_in_templates [17:50:59] * MaxSem unsheathes deleteBatch.php [17:51:03] dbrant: then i'll let you finish that first [17:53:12] 3Wikipedia App / 3Generic: Tapping edit soon after the activity is recreated crashes the app - 10https://bugzilla.wikimedia.org/65499#c2 (10Liangent) Repro: 1. Turn on "Don't keep activities" in Android developer options 2. Open the app; go to a page 3. Tap home (in Android) 4. Open the app again, then tap... [17:59:01] MaxSem: Just replace with // {{delete|reason}} [17:59:11] Let a local sysop or steward handle it. There's plenty [17:59:32] YuviPanda: see my last bug report [17:59:44] And email backtraces [17:59:51] also, there might me more in it than just the redirect, in which case you want to delete the page without a trace [17:59:57] liangent0: yeah, saw it [18:00:08] "Don't keep activities" crashes the app everywhere [18:00:26] really? that's ugh. [18:00:42] I thought I was keeping state fairly welll [18:01:29] YuviPanda: liangent0 I was going to do some digging regarding that. I've noticed it myself. [18:03:39] (03CR) 10Dbrant: [C: 032] Fetch remote styles once a day and cache them [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/133640 (owner: 10Yuvipanda) [18:04:31] (03PS7) 10Kaldari: Removing header margin and associated hacks [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/133170 [18:04:42] dbrant: cool! [18:04:44] (03CR) 10jenkins-bot: [V: 04-1] Removing header margin and associated hacks [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/133170 (owner: 10Kaldari) [18:05:23] YuviPanda: does a bugfix fix them all? [18:05:37] liangent0: no, should be individual ons. Not too many, hopefully [18:05:43] android's activity recreation causes so much pain [18:05:48] YuviPanda: or should I report each crash individually? [18:05:55] liangent0: do report each crash? [18:06:04] dbrant: you have OTRS access, right? you can see all of liangent0's crash reports there [18:06:15] YuviPanda: yes indeed [18:06:58] dbrant: cool! let me know if you have any issues accessing those [18:07:42] YuviPanda: i'd like to take a look at the crash reports, too [18:08:16] bearND: oh, let me get you setup on an OTRS account as well [18:08:31] (03PS8) 10Kaldari: Removing header margin and associated hacks [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/133170 [18:08:40] (03CR) 10jenkins-bot: [V: 04-1] Removing header margin and associated hacks [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/133170 (owner: 10Kaldari) [18:11:54] YuviPanda: and is a backtrack enough? [18:12:07] liangent0: along with a small sentence about what you were doing [18:13:08] Meh [18:13:40] liangent0: if that's too much work we'll be very happy with just a backtrace :) [18:14:02] liangent0: I *really* appreciate the work you're doing with the testing. Drink/Bevarage/Treat of choice when we meet :) [18:14:25] :) [18:14:47] hey Deskana! [18:15:52] jdlrobson, remember that e-mail I sent to mobile-l about setting up references? [18:16:50] Hey. [18:17:04] Deskana: nice beard / sideburns [18:17:23] YuviPanda: That's my "I can't be bothered shaving" beard. :P [18:17:35] Deskana: haha. mine gets a lot more scruffy [18:18:01] jgonera: yeh i followed that but i get blank forms [18:18:19] unless something hasn't been merged yet and i was misunderstanding what had been done [18:18:25] liangent0: pm? [18:31:06] liangent0: Thank you for continuing to test for us. You're great. :) [18:46:25] (03PS3) 10BearND: Remove source less files from the repo [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/133821 (owner: 10Yuvipanda) [18:47:40] (03CR) 10BearND: [C: 032] "Thanks for the explanation. Makes sense. We should add the betalabs stuff to our todo list, so we don't forget to change it to production " [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/133821 (owner: 10Yuvipanda) [18:47:58] (03Merged) 10jenkins-bot: Remove source less files from the repo [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/133821 (owner: 10Yuvipanda) [18:49:24] kaldari: are you abandoning https://gerrit.wikimedia.org/r/#/c/133020/ [18:49:53] jdlrobson: Yeah, I guess I should... [18:50:13] (03Abandoned) 10Kaldari: Changing 'last edited' to 'last modified' so it is more accurate [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/133020 (https://bugzilla.wikimedia.org/64937) (owner: 10Kaldari) [18:50:26] jdlrobson: Shit, that means I have to mark the bug as WONTFIX :P [18:50:47] kaldari: We can leave it under "Feature request" [18:50:51] i guess [18:50:55] i dunno [18:51:01] also are you testing https://gerrit.wikimedia.org/r/#/c/130985/3 in chrome or firefox? [18:51:17] I'm not sure why it would fail :/ [18:51:30] ^ chrismcmahon maybe you could take a look? [18:51:41] jdlrobson: in Chrome, still fails, but only on the 2nd upload [18:51:58] kaldari: ahhh i bet it's to do with the fact it's a duplicate [18:52:05] (03PS4) 10Jdlrobson: QA: Tests for 2nd upload from Special:Uploads page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/130985 (https://bugzilla.wikimedia.org/64400) [18:52:08] ^ kaldari try this rebased patch [18:52:12] jdlrobson: What do you mean by leave it under feature request? Don't close the bug? [18:52:31] kaldari: i dunno there was something between ori and Jared and mz [18:52:48] i don't see the point of getting into another flame war over something so petty [18:52:49] jdlrobson: I'm fine with leaving it open if you like [18:53:04] I already had my fight with MZ for the month :) [18:53:29] i still can't get citations to work :( [18:53:42] jdlrobson: how far did you get? [18:53:58] does it load on desktop for you? [18:54:27] kaldari: 1s [18:54:37] http://imgur.com/82SgJnL,IKCrnTs [18:54:43] it's just a blank dialog [18:54:50] so i guess something is wrong with my template setup [18:54:52] jdlrobson: double upload failure thing still? [18:55:02] chrismcmahon: yeh please - can you see if it works for you? [18:56:33] jdlrobson: Here's what I have as my Template:Cite_book: http://pastebin.com/FsK7TBZ9 [18:57:44] ahhha [18:57:48] thanks kaldari that did the magic [18:57:53] yay [18:59:21] ouch just found a new bug :D [19:00:15] jdlrobson: rebase didn't help on the testing patch [19:02:51] jdlrobson: I wish selenium didn't run so freakin fast. I can't tell why it's failing. Uploading 2 in a row manually seems to work fine ;P [19:03:04] kaldari: MMM [19:04:14] brb [19:04:14] 3MobileFrontend / 3alpha: CSS regression: Categories heading on a bed of arrows - 10https://bugzilla.wikimedia.org/65503 (10Jon) 3NEW p:3Unprio s:3normal a:3None Created attachment 15442 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15442&action=edit CSS regression See image [19:05:27] 3MobileFrontend / 3alpha: CSS regression: Categories heading on a bed of arrows - 10https://bugzilla.wikimedia.org/65503#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/e3klAwJm [19:11:47] (03PS2) 10Yuvipanda: Override hashCode and toString when equals is overridden [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/133482 (owner: 10BearND) [19:11:54] (03CR) 10Yuvipanda: [C: 032] Override hashCode and toString when equals is overridden [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/133482 (owner: 10BearND) [19:11:59] bearND|lunch, can you add wikimedia.org_3034313733312d323538@resource.calendar.google.com to our mtg calendar entry please? [19:12:15] (03Merged) 10jenkins-bot: Override hashCode and toString when equals is overridden [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/133482 (owner: 10BearND) [19:12:44] 3MobileFrontend / 3alpha: VE citations: Cannot scroll long citation dialog boxes - 10https://bugzilla.wikimedia.org/65504 (10Jon) 3NEW p:3Unprio s:3normal a:3None It clips at the bottom and I cannot scroll them. [19:13:13] 3MobileFrontend / 3alpha: VE citations: Cannot scroll long citation dialog boxes - 10https://bugzilla.wikimedia.org/65504#c1 (10Jon) I'm seeing this on the book citation dialog box. [19:13:29] 3Wikipedia App / 3Generic: Undefined in preview - 10https://bugzilla.wikimedia.org/65505 (10Liangent) 3NEW p:3Unprio s:3normal a:3None Turn on "don't keep activities"; jump out then come back in editing screen. [19:14:05] jdlrobson kaldari: def. failing not seeing the progress bar the second time, not sure why. it'll be a few hours before I can really dig in, got an interview in 45 minutes. (how attached are you to that check for progress bar, anyway?) [19:14:12] mmmmm [19:15:21] chrismcmahon: it's odd i'm not attached - i just don't understand why it wouldn't work since it worked the first time :/ [19:15:26] 3MobileFrontend / 3alpha: VE citations: Cannot scroll long citation dialog boxes - 10https://bugzilla.wikimedia.org/65504#c2 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/qMBlX2Gp [19:15:37] (03PS1) 10Dbrant: Fix crash when there's no network during StyleFetcherTask. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/134161 [19:15:45] YuviPanda: YuviPanda ^ [19:17:02] (03CR) 10Yuvipanda: Fix crash when there's no network during StyleFetcherTask. (032 comments) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/134161 (owner: 10Dbrant) [19:20:55] (03PS2) 10Dbrant: Fix crash when there's no network during StyleFetcherTask. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/134161 [19:24:05] anyway i'm heading off in your lunch break for my dinner break. talk in a bit. :) [19:30:57] nick dbrant|brb [19:53:56] 3MobileFrontend / 3Feature requests: mobile-friendly templates should be easy to create - 10https://bugzilla.wikimedia.org/65498#c3 (10darklama) Jon, I think layout and style separation is a good plan. However sometimes the layout of templates may need to be different between desktop and mobile browsers as w... [20:10:53] (03CR) 10Yuvipanda: [C: 032] Fix crash when there's no network during StyleFetcherTask. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/134161 (owner: 10Dbrant) [20:11:25] (03Merged) 10jenkins-bot: Fix crash when there's no network during StyleFetcherTask. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/134161 (owner: 10Dbrant) [20:11:27] (03CR) 10JGonera: [C: 04-1] "Can't switch back to VE with this patch." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/132345 (https://bugzilla.wikimedia.org/64968) (owner: 10Jdlrobson) [20:15:19] (03PS2) 10Yuvipanda: Improve appearance of RTL languages in app language selection. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/134099 (owner: 10Dbrant) [20:19:52] (03CR) 10Yuvipanda: "What exactly does this change?" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/134099 (owner: 10Dbrant) [20:20:29] (03CR) 10JGonera: "Looks better now:" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/133170 (owner: 10Kaldari) [20:21:46] (03CR) 10Dbrant: "The RTL languages were being listed on the extreme right of the selection dialog, which looked odd. If anything, it's inconsistent with th" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/134099 (owner: 10Dbrant) [20:21:53] (03CR) 10JGonera: [C: 032] Hygiene: Browser test cleanup [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/134134 (owner: 10Jdlrobson) [20:22:55] (03Merged) 10jenkins-bot: Hygiene: Browser test cleanup [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/134134 (owner: 10Jdlrobson) [20:27:30] (03CR) 10Yuvipanda: [C: 032] "Fair enough :)" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/134099 (owner: 10Dbrant) [20:27:33] (03PS2) 10Yuvipanda: Do not clear out history after every 30 days [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/133966 [20:28:05] (03Merged) 10jenkins-bot: Improve appearance of RTL languages in app language selection. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/134099 (owner: 10Dbrant) [20:29:28] 3MobileFrontend / 3Feature requests: mobile-friendly templates should be easy to create - 10https://bugzilla.wikimedia.org/65498#c4 (10Max Semenik) (In reply to darklama from comment #3) > Maybe have mw.IsMobile() in Scribunto, and > {{#mobile:{{MOBILEUSER}}|mobile layout|desktop layout}} > for pure template... [20:30:00] (03CR) 10JGonera: [C: 04-1] Respect the hash with sub headings (035 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/133470 (https://bugzilla.wikimedia.org/64918) (owner: 10Jdlrobson) [20:31:10] (03PS6) 10Jdlrobson: Hygiene: Cleanup edit switcher css [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/132345 (https://bugzilla.wikimedia.org/64968) [20:31:49] (03CR) 10Jdlrobson: "I can't find the bug right now but are you sure this is not an issue on master - basically refreshing a page whilst in wikitext editor it'" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/132345 (https://bugzilla.wikimedia.org/64968) (owner: 10Jdlrobson) [20:33:14] (03CR) 10JGonera: [C: 04-1] "Messes up main menu closing transition. Left border and background disappear too early while the transition is still in progress." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/132346 (owner: 10Jdlrobson) [20:36:49] (03CR) 10JGonera: [C: 04-1] "Honestly, I'm not sure if this is a good idea. Can you point to any production heavy-traffic well-designed web sites that use such CSS cla" (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/131886 (owner: 10Jdlrobson) [20:36:54] kaldari: i jacked your heater [20:37:10] it's freezing in the office today for some reason! [20:37:11] NP [20:37:28] oakland is much warmer [20:37:29] heh [20:37:37] if i didn't have meetings, i'd be there, too [20:37:49] * YuviPanda waves at Maryana and Deskana [20:38:03] yo yo, panda [20:38:16] Maryana: nice running costume! :) [20:38:21] hehehe [20:38:30] *so* many people wanted to take pictures with us! [20:38:52] Maryana: Deskana are there any preliminary thoughts from you guys about tomorrow's meeting for optimizing for editing vs signups? I feel better going into these meetings with some feel of your opinions currently. [20:39:06] Maryana: I would have too if I was there! I need to put up some of the pics from the boat ride and other places [20:39:29] my thought process right now is keep everything as simple as possible [20:39:40] unfortunately there's just a ton of complexity to this problem no matter how you slice it [20:39:57] we *have* to show license text on every edit [20:40:34] (03CR) 10JGonera: [C: 032] Hygiene: Use truncated text class in overlay headers [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/132344 (owner: 10Jdlrobson) [20:40:57] so i dunno.. i feel like somebody's baby is going to have to die :-/ [20:41:10] (03Merged) 10jenkins-bot: Hygiene: Use truncated text class in overlay headers [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/132344 (owner: 10Jdlrobson) [20:41:41] Maryana: right, but I was asking more about the stated question, which is optimizing login vs edits. [20:41:45] err [20:41:49] user registration vs edits. [20:42:37] ah, right. edits are more important, i think. [20:43:35] which is why i feel like something needs to get cut from the editing flow, otherwise we're confusing/cluttering up the user experience too much to get successful completion rates [20:44:04] it's warm in the uk Maryana :) [20:44:06] suprisingly.. [20:44:16] jdlrobson: it was 20C! I had a bathrobe tho [20:44:25] My office was upto 26 [20:44:35] YuviPanda: No multiple fleeces? [20:44:45] Reedy: it was on top of thermals, a vest, a T Shirt [20:44:59] YuviPanda: haha [20:45:09] YuviPanda: shouldn't have gone to scotland [20:45:19] Maryana: agreed. If we agree that edit completion rates are important, I guess it makes things easier. Good to know! [20:45:23] i think i'm going mad … i can't find a bug [20:47:20] (03PS2) 10Yuvipanda: Keep only a limited number of WebViews in memory. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/134083 (https://bugzilla.wikimedia.org/64450) (owner: 10Dbrant) [20:47:57] bearND: can you CR / test / merge https://gerrit.wikimedia.org/r/#/c/133966/ [20:47:58] ? [20:48:29] 3MobileFrontend / 3alpha: Cannot switch to VisualEditor after a reload - 10https://bugzilla.wikimedia.org/65506 (10Jon) 3NEW p:3Unprio s:3normal a:3None Could have sworn I raised this bug previously but here we go again.. Load Article#editor/0 in alpha See VisualEditor. Switch to source editor. Now r... [20:48:54] (03CR) 10Jdlrobson: "@jgonera Could have sworn I opened a bug but this new bug describes the issue I found - https://bugzilla.wikimedia.org/show_bug.cgi?id=655" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/132345 (https://bugzilla.wikimedia.org/64968) (owner: 10Jdlrobson) [20:50:26] 3MobileFrontend / 3alpha: Cannot switch to VisualEditor after a reload - 10https://bugzilla.wikimedia.org/65506#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/FcXnAItk [20:52:41] YuviPanda: yes, i'll CR https://gerrit.wikimedia.org/r/#/c/133966/ in a few [20:57:47] dbrant: gerrit seems dead, but I emailed you a screenshot [20:58:11] YuviPanda: !! I haven't seen that on my devices... [20:58:19] YuviPanda: what are your steps? [20:58:27] dbrant: also, we shouldn't be hitting the network again. We have a fully populated Page object we can reuse [20:58:36] dbrant: open a lot of pages, and then hit back [20:58:38] dbrant: multiple times [20:58:40] this is a N4 [20:58:45] on a slightly terrible connection [20:59:40] dbrant: but definitely should be reusing the Page object [21:00:32] YuviPanda: roger that [21:01:12] dbrant: gerrit is down for me atm, so couldn't put things there [21:01:26] dbrant: the screenshot issues are perhaps just the webview being really narrow to begin with, perhaps? [21:01:35] YuviPanda: i've hammered on the Back button, and didn't get anything like that [21:01:48] dbrant: how many articles up did you get to? [21:02:22] dbrant: there's also general slowness / lagginess, but I guess that's perhaps because of the multiple network requests going on in the background [21:02:29] YuviPanda: ~20 [21:02:46] dbrant: if we do go the network request route (that will save some more RAM), we should not load them up u ntil the user comes back to the page,I guess [21:03:42] (03CR) 10Yuvipanda: [C: 04-1] "More comments on IRC" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/134083 (https://bugzilla.wikimedia.org/64450) (owner: 10Dbrant) [21:04:11] YuviPanda: i'll look into reusing the Page [21:04:15] dbrant: ok! [21:04:30] dbrant: there's also slight complications there since the page object changes as pages get fully loaded. [21:05:11] new page objects are instantiated as more content becomes available. Moving them to just modifying one page object might make things easier, but I don't know [21:12:23] hey MaxSem [21:12:27] MaxSem: https://en.wikipedia.org/wiki/File:Sitta_europaea_wildlife_2_1.jpg exists [21:12:34] MaxSem: but https://en.wikipedia.org/wiki/Special:ApiSandbox#action=mobileview&format=json&page=File%3ASitta_europaea_wildlife_2_1.jpg§ions=all&prop=text returns no such page [21:12:39] MaxSem: the former is a foreign file repo page [21:12:52] MaxSem: but didn't we make them do something years ago? to return appropriate pages? [21:12:58] MaxSem: to make them work with the old app? [21:13:39] (03CR) 10Jdlrobson: Respect the hash with sub headings (035 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/133470 (https://bugzilla.wikimedia.org/64918) (owner: 10Jdlrobson) [21:13:48] (03PS5) 10Jdlrobson: Respect the hash with sub headings [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/133470 (https://bugzilla.wikimedia.org/64918) [21:14:13] MaxSem: works fine for local pages [21:14:21] (03PS5) 10Jdlrobson: Hygiene: Make border-box the default [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/133188 [21:14:25] woah, beta labs is really borked [21:14:26] ewwwwwwh [21:14:40] jgonera: don't know if you saw my comment on https://gerrit.wikimedia.org/r/132345 [21:14:42] MaxSem: I distinctly remember having this exact same conversation a year or so ago :P [21:14:59] please recall the outcome too please:P [21:15:19] (03CR) 10Jdlrobson: [C: 04-1] "This all hinges on whether border-box becomes default. -1ing until that happens." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/133189 (owner: 10Jdlrobson) [21:15:28] (03CR) 10Jdlrobson: [C: 04-1] "This all hinges on whether border-box becomes default. -1ing until that happens." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/133190 (owner: 10Jdlrobson) [21:15:41] 3Wikipedia App / 3Generic: Images from Commons say "This page does not exist" - 10https://bugzilla.wikimedia.org/65358#c1 (10Yuvi Panda) So local File pages work, remote File pages (from commons!) don't. But MobileView is supposed to explicitly handle those, but isn't. Checking with MaxSem to see what's happ... [21:15:47] MaxSem: you made a patch that made mobileview work for foreign repos? :) [21:15:51] jdlrobson, I'll check again, maybe my master is not up to date, although I pulled today [21:16:12] jgonera: there is a bug on master [21:16:20] i don't think my patch introduces it [21:16:29] well i know it doesn't :) [21:17:15] jdlrobson, I just checked master - wfm [21:18:01] MaxSem: 91467157f47a9766c2233ab6625e92863fd5ef84 [21:18:48] MaxSem: appropriate time and code :) [21:18:53] MaxSem: but doesn't seem to be working anymore [21:19:00] and checked your patch - does not work jdlrobson [21:19:05] I checked several times [21:20:05] MaxSem: I am going to guess this breaks things for the old app as well [21:20:10] (03CR) 10JGonera: "Latest master works for me, your patch doesn't..." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/132345 (https://bugzilla.wikimedia.org/64968) (owner: 10Jdlrobson) [21:20:41] 3MobileFrontend / 3alpha: Cannot switch to VisualEditor after a reload - 10https://bugzilla.wikimedia.org/65506#c2 (10Juliusz Gonera) Can't reproduce on latest master. [21:21:52] YuviPanda, yup: [21:24:07] erm, editing's not working for me when i test in master on vagrant [21:24:13] 3MobileFrontend / 3alpha: Cannot switch to VisualEditor after a reload - 10https://bugzilla.wikimedia.org/65506#c3 (10Ryan Kaldari) Works for me. Tested in Firefox on latest master. [21:24:16] is that what y'all are talking about? [21:24:33] jdlrobson: I can't reproduce either [21:24:56] I did this on Chrome [21:25:50] jdlrobson: Works for me in Chrome too [21:26:00] * jdlrobson tests again - is beta labs down? [21:26:04] yeah [21:26:08] :( [21:26:41] (03PS2) 10Jdlrobson: Style search button as icon for non-JS users [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/133721 (https://bugzilla.wikimedia.org/63701) [21:26:43] (03CR) 10Jdlrobson: "This icon is from the dropbox of icons that May has been maintaining. It's also the one in the Winter prototype." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/133721 (https://bugzilla.wikimedia.org/63701) (owner: 10Jdlrobson) [21:27:02] sigh [21:28:02] * Maryana hugs vagrant [21:28:26] kaldari: so it takes 2 clicks for me to toggle from wikitext editor to visualeditor [21:28:29] when wikitext is sticky [21:28:39] and then it loads two toolbars [21:28:45] both firefox and chrome [21:28:47] jdlrobson, on master? [21:28:51] jgonera: YES :P [21:28:58] so i don't know what's special about my instance [21:29:02] shame i can't test this on beta labs [21:29:08] use vagrant ;) [21:29:25] that's what i'm doing, and i can't edit at all.. but i don't have the ve role enabled yet [21:29:36] is that a dependency now or something? [21:29:45] shouldn't be... [21:29:55] it gives me this in the URL: Cats#editor/0 [21:30:12] that's fine [21:30:20] jgonera: i get the SAME issue on vagrant [21:30:53] Maryana: jgonera i think what is actually happening is VisualEditor code gets loading when you click the toggle button [21:30:59] and it takes forever so it makes you think it's not working [21:31:40] well, ve code shouldn't be loading for me cos i don't have the role enabled [21:31:46] let's see what happens when i turn ve on.. [21:31:52] Maryana, confirming, editing doesn't work at all without VE on master... can you file a bug? [21:32:12] sure thing [21:32:20] MaxSem: any luck tracking it down? or are you busy with something else? [21:32:31] ack, exceptions [21:32:33] 1 sec [21:33:57] 3MobileFrontend / 3alpha: Cannot switch to VisualEditor after a reload - 10https://bugzilla.wikimedia.org/65506#c4 (10Jon) So actually I've noticed it does actually load eventually but it takes 6 seconds to do so and doesn't show a loading overlay or anything so it's not clear the click did anything... I'm... [21:34:55] bugs bugs bugs [21:35:01] 3MobileFrontend / 3General/Unknown: Editing not working without VE enabled - 10https://bugzilla.wikimedia.org/65509 (10Maryana Pinchuk) 3NEW p:3Unprio s:3normal a:3None Seen on master via testing in Vagrant: Go to any article in stable and tap edit. If you don't have VE enabled, nothing happens :( [21:35:27] 3MobileFrontend / 3General/Unknown: Editing not working without VE enabled - 10https://bugzilla.wikimedia.org/65509#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/sRfzs31f [21:35:42] so many bugs, so little time! [21:35:47] :) [21:37:49] kaldari: http://imgur.com/mT6b42m [21:38:08] * YuviPanda gives Maryana a few extra limgs [21:38:18] enabling VE melted my vagrant :( [21:38:43] Exception from line 3264 of /vagrant/mediawiki/includes/GlobalFunctions.php: MediaWiki 1.23 required--this is only 1.23alpha [21:39:52] Maryana, update VE [21:41:58] 3MobileFrontend / 3stable: Button looks different from other buttons - 10https://bugzilla.wikimedia.org/63701#c3 (10Jon) Created attachment 15444 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15444&action=edit On desktop it stretches.. eek. [21:42:01] Maryana: pull in latest vagrant, then run vagrant git-update, and then try again [21:42:21] so that's 'git pull origin master && vagrant git-update' [21:42:38] (Max) Already fixing [21:45:38] Maryana: So the citation drop down card is basically finished, but I still have it in 'Awaiting final code review' because there are 2 patches left to be merged (one for ooui and one for VE). Should I get you to sign off on it without that one feature? I have no idea how long it will take the VE folks to review the patches for the last little bit, but it would be good to get the points for it in the meantime :) [21:45:57] i don't think that's how it works.. [21:45:59] :-P [21:46:09] Oh well :P [21:47:05] It's going to be a low-scoring iteration [21:47:08] it's not about the story points! won't someone think of the users? :) [21:47:44] what users? :P [21:47:48] Those poor users! [21:47:51] xcode troubles, trying a reboot. :P [21:48:14] (03CR) 10JGonera: [C: 04-1] "I already see it looks different after reloading first page. Header dimensions change. I'm not against this change but please be very care" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/133188 (owner: 10Jdlrobson) [21:49:04] MaxSem: https://bugzilla.wikimedia.org/show_bug.cgi?id=65358 is the appropriate bug, btw [21:49:11] 3Wikipedia App / 3Generic: Images from Commons say "This page does not exist" - 10https://bugzilla.wikimedia.org/65358#c2 (10Yuvi Panda) Commit 91467157f47a9766c2233ab6625e92863fd5ef84 on MobileFrontend from 2012 fixed this for the old app, but it doesn't seem to be working anymore? [21:49:15] (03CR) 10Jdlrobson: Allow other extensions/modules to tweak the editor (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/132798 (https://bugzilla.wikimedia.org/65165) (owner: 10Jdlrobson) [21:51:50] YuviPanda, Maryana: I think it'll probably become clear if we walk through the user's experience from start to finish. [21:52:01] Deskana: yeah, agreed [21:52:22] YuviPanda, Maryana: In doing that we'll probably realise where the repeteteton is, and where we can slice bits (thereby decreasing complexity) without losing anything. [21:52:54] Deskana: yeah, ostenibly keeping in mind we'll be building some onboarding on later on. [21:53:35] MaxSem: any views on https://gerrit.wikimedia.org/r/#/c/133680/1 btw? [21:53:58] (03CR) 10BearND: [C: 032] Do not clear out history after every 30 days [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/133966 (owner: 10Yuvipanda) [21:54:40] (03Merged) 10jenkins-bot: Do not clear out history after every 30 days [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/133966 (owner: 10Yuvipanda) [21:55:35] bearND: ty! [21:55:47] bearND: any luck on the search bar card? [21:59:58] (03CR) 10Jdlrobson: "I see.. it appears to be an issue of touch targets. Now fixed." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/132345 (https://bugzilla.wikimedia.org/64968) (owner: 10Jdlrobson) [22:00:02] (03PS7) 10Jdlrobson: Hygiene: Cleanup edit switcher css [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/132345 (https://bugzilla.wikimedia.org/64968) [22:02:57] kaldari: retrospective time! [22:03:22] kaldari: retro! [22:03:22] oh yeah.. [22:08:09] YuviPanda: setOnFocusChangeListener on searchTermText only seems to work on newer Android versions [22:09:06] bearND: yeah, that's been a consistent problem. Unsure how to fix [22:10:40] bearND: perhaps just put a timer on it? [22:12:14] YuviPanda: i'll check some more on SO [22:14:03] YuviPanda: i just checked on kitkat, and it even doesn't work there. only JellyBean [22:14:16] bearND: heh. yeah, focus changed listeners have never been reliable for me [22:14:52] bearND: don't sweat it too much. A simple fade or just a 'tap to dismiss' is fine, I think [22:15:10] perhaps a simple 2-3s fade *and* a tap to dismiss? [22:15:24] YuviPanda: currently it says tap to retry [22:15:28] hmm, right [22:15:31] forgot that. [22:15:32] ugh [22:16:03] bearND: but the problem is that it doesn't go away on other events, like hitting back or opening the drawer [22:17:12] (03PS1) 10Yuvipanda: Bump version number for 2.0-alpha-2014-05-19 [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/134262 [22:18:07] Maryana: liangent0: Deskana made a new release! Nothing much user visible in this one, except search on History + no losing history after 30 days. [22:18:22] (03CR) 10Yuvipanda: [C: 032] Bump version number for 2.0-alpha-2014-05-19 [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/134262 (owner: 10Yuvipanda) [22:19:38] (03Merged) 10jenkins-bot: Bump version number for 2.0-alpha-2014-05-19 [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/134262 (owner: 10Yuvipanda) [22:30:33] dbrant: I also think I was getting double history entries with that patch [22:30:55] YuviPanda: should have made it [wip]... [22:34:07] kaldari: https://www.mediawiki.org/wiki/Wikimedia_Mobile_engineering/imported/Mobile_team/Mobile_web/Team_norms [22:46:56] 3MobileFrontend / 3Feature requests: mobile-friendly templates should be easy to create - 10https://bugzilla.wikimedia.org/65498#c5 (10darklama) (In reply to Max Semenik from comment #4) > (In reply to darklama from comment #3) > > Maybe have mw.IsMobile() in Scribunto, and > > {{#mobile:{{MOBILEUSER}}|mobil... [22:56:32] dbrant: heh :) [23:14:48] bearND: hmm, interesting. my test runs for doedittasktest now pass [23:15:03] let me try something else [23:15:36] YuviPanda: i think it's intermittent. you mentioned some issues with the token store [23:16:31] bearND: hmm, right. [23:20:26] 3MobileFrontend / 3Feature requests: mobile-friendly templates should be easy to create - 10https://bugzilla.wikimedia.org/65498#c6 (10Max Semenik) Yes. [23:22:54] MaxSem: any luck with that bug? :) [23:23:07] meetings! [23:23:23] MaxSem: aah :) [23:26:57] 3MobileFrontend / 3Feature requests: mobile-friendly templates should be easy to create - 10https://bugzilla.wikimedia.org/65498#c7 (10Jon) Yeh so what Max is getting at is the bit of code that turns wikitext into HTML. This is currently generated on a save. What you are talking about would require 2 version... [23:35:28] James_F: do you have any idea of the status of this on your end? https://trello.com/c/F5I84Zcy/9-8-link-inspector-ui-for-progressive-action-and-delete-link-action [23:35:36] we talked about it like 3 weeks ago, not sure where y'all are at with it [23:37:27] kaldari: jgonera MaxSem jdlrobson http://hatjitsu.wmflabs.org/24800 [23:40:59] MaxSem, which skills do you think are not needed in the snake? [23:41:36] graphics, realtime interactions [23:42:33] Maryana: Off the top of my head I /believe/ that it's done at our end, but that might be wrong. [23:42:44] Maryana: jgonera might know. [23:42:51] he's not sure either :) [23:43:00] he's been on vacay for the past week [23:43:39] ok, it seems we need to catch up [23:43:42] http://etherpad.wikimedia.org/p/MobileWeb_Iteration_name [23:44:14] MaxSem, there are no graphs - we switched to element [23:45:00] as for real time interaction - it is not really there - it handles keystroke event and adds it to the que, plus it handles timer event and alters the screen. Take a look at my sample [23:45:25] if the person doesn't know how to do events, we don't want them for this position [23:45:35] in js, events are everything [23:53:55] moving cards between trello boards is a pain :( [23:54:12] Maryana: should I jsut move everything that's not accepted over to iteration wildebast? [23:54:54] awjr: should write a chrome extension [23:54:57] yeah, go for it :) [23:55:19] YuviPanda: that is a good idea.