[00:08:57] (03PS1) 10Yuvipanda: Fix crashing when handling an unprocessable external link [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/134281 (https://bugzilla.wikimedia.org/64424) [00:11:56] 3Wikipedia App / 3Generic: Following a link which can't be handled on the device crashes the app - 10https://bugzilla.wikimedia.org/64424#c8 (10Yuvi Panda) Just shows a small toast saying this link can't be opened. [00:12:11] 3Wikipedia App / 3Generic: Images from Commons say "This page does not exist" - 10https://bugzilla.wikimedia.org/65358 (10Yuvi Panda) p:5Unprio>3High [00:12:56] 3Wikipedia App / 3Generic: [Regression] action=mobileview does not return valid data for File: pages on commons when querying english wikipedia - 10https://bugzilla.wikimedia.org/65358 (10Yuvi Panda) [00:13:26] 3MobileFrontend / 3General/Unknown: [Regression] action=mobileview does not return valid data for File: pages on commons when querying english wikipedia - 10https://bugzilla.wikimedia.org/65358 (10Yuvi Panda) [00:13:41] 3MobileFrontend / 3General/Unknown: [Regression] action=mobileview does not return valid data for File: pages on commons when querying english wikipedia - 10https://bugzilla.wikimedia.org/65358#c3 (10Yuvi Panda) Note that this would break the current application in the store as well. [00:14:57] 3MobileFrontend / 3General/Unknown: [Regression] action=mobileview does not return valid data for File: pages on commons when querying english wikipedia - 10https://bugzilla.wikimedia.org/65358#c4 (10Max Semenik) Not "would", it actually breaks it. [00:16:26] 3MobileFrontend / 3General/Unknown: [Regression] action=mobileview does not return valid data for File: pages on commons when querying english wikipedia - 10https://bugzilla.wikimedia.org/65358#c5 (10Yuvi Panda) Ow. [00:30:00] Maryana: Trevor's out this week, so if there's still stuff to do on our end it will probably take a while, FYI. [00:31:03] ok [00:36:16] anybody want anything in particular reviewed before I retire? [00:37:15] retire fully from engineering? you're not *that* old [00:37:20] :D [00:37:20] Deskana: liangent0 know any page off the top of your head that had horizontal scrolling? [00:37:22] Maryana: ^ [00:37:30] I think I might've fixed it, but need to verify [00:38:55] b/c of infobox issues? [00:39:03] yeah [00:39:33] iirc, the san francisco article's demographics section [00:39:47] (03CR) 10Kaldari: [C: 04-1] Respect the hash with sub headings (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/133470 (https://bugzilla.wikimedia.org/64918) (owner: 10Jdlrobson) [00:40:37] hmm, the article itself is alright [00:40:39] let's see how this goes [00:40:54] Maryana: the tables themselves still have to scroll internally, but they don't cause the page itself to scroll [00:41:01] let me wrangle someone to merge it [00:41:21] sweet :) [00:41:47] ok, i'm outta here - catch you tomorrow, gang [00:42:00] have fun! [00:42:07] oh wow, it's late [00:42:08] fuck [00:42:16] go to bed! [01:16:27] YuviPanda: [[WP:VPT]] [01:17:21] YuviPanda: Hmm, that was fixed. [01:18:46] Deskana: are you sure? I'm still seeing it in the app [01:19:22] YuviPanda: Oh, well, I mentioned it because I knew there was a scroll on it on desktop which was causing some CSS weirdness with the search suggestions box. [01:19:29] ah [01:19:48] Deskana: it's fine on MF, and terrible in the app [01:19:49] I should just sit down somewhere tomorrow, scrap all the app's CSS, and just start over from MF [01:20:05] let me do that now, actually [01:22:36] YuviPanda: How long's that going to take? And what are the benefits? [01:22:49] Deskana: not too long. A couple of hours. [01:22:59] Deskana: benefits would be that the goddamn horizontal scroll goes away for good :) [01:23:43] Deskana: although with my last MobileApp patch even the infoboxes are looking slightly decent [01:24:54] Deskana: woot! ori just merged that patch, so in a few hours you should be able to see better looking infoboxes in the app [01:25:25] Deskana: we have a setup that means you don't have to update the app to see better styling. It auto-updates once a day just the page styling. [01:25:31] Deskana: so that actually drastically reduces the need to improve page css before first app launch, since we can do that whenever. [01:25:58] In the context of this sprint I think you're pretty much fine to do it anyway since you're on a bug fix sprint, but I think this is a useful exercise for me at least. :) [01:26:30] Oh right, that's cool. [01:26:40] MobileFrontend has that but the app doesn't right now? [01:26:47] Deskana: 'that'? [01:26:48] Deskana: as in? [01:26:52] The auto-update thing. [01:26:57] Or is you copying from MobileFrontend just because our CSS is awful? [01:27:43] Deskana: ah, the auto-update thing just got merged for Android app and pushed out in today's alpha [01:27:56] Okay, so that's the thing Ori merged. [01:28:14] And you're copying because our CSS is bad and MobileFrontend's is nice? [01:28:41] Deskana: no, the thing Ori merged was an update to the app CSS (which lives in Extension:MobileApp) that made Infoboxes look nicer [01:28:59] Deskana: and because we have the auto update thing, the new CSS will be on apps in a day, without needing for us to push out a new alpha [01:29:12] Deskana: essentially app updates are decoupled from page style updates. [01:29:29] page style updates is *only* how the content looks, has nothing to do with how the UI looks [01:29:49] Deskana: and I'm copying CSS because yes, our CSS isn't as good as MF's. [01:29:55] Right! [01:29:57] Sounds fine to me. [01:31:10] Deskana: yeah. I might want to spend some time talking ti kaldari or jdlrobson at some point tomorrow to understand MF's styles better before copying them [01:31:38] Deskana: note that the styles work is common for iOS and Android, so the work I'm doing now will reflect in iOS as well (eventually - Monte's not gotten to the 'use common CSS' card yet, I think) [01:37:10] Deskana: do you think we should have a design pass for page styling? [01:40:07] YuviPanda: Absolutely. [01:40:34] I'm sure there's tons they'd love to change. [01:40:37] Deskana: ah, hmm. I'll leave you to scheduling it then, and just let the current styles be. [01:40:58] Deskana: yeah, I'll be happy to as well :) We've enough core android folks around that I can spend time on these things [01:41:07] I think that's further down the line though, so if you don't mind investing the time for now then I'd be good with that. [01:41:11] If it's only a few hours. :) [01:41:39] Deskana: hmm, alright. I'll do that tomorrow. [01:42:01] I want to designers to be tightly focussed on the app restyling. [01:42:18] Deskana: Android this sprint is pretty light anyway. dbrant is taking care of our biggest technical blocker, so me and bearND are just picking out other bugs. Just submitted a patch for the worldwind:// thing, for example [01:42:18] Don't want to introduce more complications for htem. [01:42:25] Deskana: oh totally agree, yeah. [01:42:32] Great! Do you want me to pull the most important stuff out of the backlog for you now? [01:42:43] Or do you still have enough in the todo for the current sprint? [01:43:07] Deskana: there's still enough for the current sprint, I think. About + protection status + a couple more crashy bugs [01:43:20] Deskana: btw, I'm confused by the acceptance criteria on https://trello.com/c/c04jh3d9/29-1-as-a-potential-editor-i-want-to-see-the-protection-status-of-an-article-before-i-edit-so-i-don-t-waste-time-trying-to-edit-art [01:43:33] * Deskana looks. [01:43:59] Indeed, they do seem to contradict each other. [01:44:01] Deskana: why greyed out? protection status doesn't mean nobody can edit, and the patch that was merged does tell us if *current user* can edit or not. [01:44:07] I think you weren't in that meeting. [01:44:10] I wasn't. [01:44:12] I was in Zurich [01:44:13] So let me explain. [01:44:15] ok! [01:44:43] That patch that lets the API tell you whether the current user can edit or not wasn't merged then, so we put the stopgap criteria in (the last one). [01:44:51] aaah! [01:45:02] I'll just get rid of that from both copies of the card. [01:45:38] And the reason we want to display greyed out pencils is because otherwise the user might not know why the pencil isn't there. [01:45:40] Deskana: yeah, cool. that patch is live on testwiki now, and should be on enwiki this week. [01:45:48] If they go to a page and the pencil's gone, does the user know why? [01:45:52] Deskana: of course. but we should just do what MF does adn display a 'locked' pencil [01:46:03] Oh, sure, I'm agnostic to *what* indicator we use. [01:46:06] Just as long as we have one. [01:46:17] Consistency with MF is good. [01:46:21] Deskana: hmm, so there are now only two classes - those who have the rights to edit the page as it is now, and those who don't [01:46:43] so we could just show the normal pencil to people who can edit, and a locked one to those who can't, and a message about the protection to those who can't [01:46:49] people who have the rights don't have to know [01:46:53] that it is protected [01:47:10] what do you think? [01:47:11] The people who have the rights also need to know, because what they're allowed to do by policy varies on whether the page is protected or not. [01:47:18] ah, right [01:47:33] Admins have the ability to edit protected pages, but they're not always supposed to depending on policy. [01:47:39] but is that MVP? :D [01:47:55] Well that's why we had the stopgap card, too. [01:47:59] Let me think. [01:48:31] we do have protection status available in the API too, so we *can* show a message saying 'yes, this is protected, but you can edit' and 'yes, this is protected and you can not edit'. [01:48:36] In retrospect, I think we need to put the stopgap card back in. [01:48:42] Yeah, we can, but that needs design review as to where to put that. [01:48:50] yeah, true [01:49:03] Although I guess admins editing protected pages is sufficiently an edge case that for our MVP we can just stick something in somewhere stupid and fix it later. [01:49:26] * Deskana looks at the app quickly. [01:49:27] however, the solution I talked about - normal pencil for those who can and locked for those who can't, is the simplest to implement, since it is a boolean yes/no [01:49:56] Can you... [01:49:58] a) Do that [01:49:59] and [01:50:29] b) Put a notice under the "Edit section" bar saying "Note: This page is protected" or "Note: This page is semi-protected" if the page is protected but the user has the ability to edit? [01:50:31] How hard is the latter? [01:51:00] the problem with that is that there are a crazy number of protection levels [01:51:03] and custom ones [01:51:06] and such. [01:51:13] like templateeditor on enwiki, I am told. [01:51:27] negofbknshi34gvskdfikyt [01:51:33] and there can also be multiple protection levels on a single page at one time - semi-protected for a month but fully protected for a week [01:51:37] and the API supports that [01:51:40] "COMPLEXITYYYYYYYYYYYY!" - Captain Kirk [01:51:55] so ideally, I wouldn't touch protection status, and keep it a boolean 'user can edit', 'user can not edit' [01:52:15] btw, user can also not be able to edit because they were blocked :P [01:52:20] Yeah, but that's the difficulty! What a user is allowed to do depends on the protection level and the rights they have. [01:52:33] Deskana: yeah, but the API deals with that for me! that's the patch that got merged [01:52:42] No, I mean *socially* allowed to do. [01:52:52] Deskana: true, but MVP! [01:53:03] Deskana: it's not impossible, just hard with custom protection levels. [01:53:13] Yeah, so I'm tempted to say that we should not allow protected editing, because admins editing protected pages could get them in trouble. [01:53:33] Deskana: in that case I'd rather go the extra mile and show them the protection levels :) [01:53:44] Deskana: it's not that hard if we don't want custom messages for custom protection levels. [01:54:05] Just semi and full is fine. [01:54:07] Can you do that? [01:54:11] yeah, def. [01:54:27] * Deskana changes the acceptance criteria. [01:54:32] * YuviPanda watches [01:56:54] Deskana: I'll just use a 'crouton' banner, which disappears after a few seconds. we use them a lot in other places. fairly prominent [01:57:03] Yep, cool. [01:57:09] Okay, done. [01:57:26] Do you think that's still a 1? [01:57:46] Deskana: haha :P [01:58:07] Deskana: definitely doable in this iteration, but not a 1. I'd say a (3), which is what it was originally at. Not sure why it became a 1 [01:58:25] What's the procedure? Just change to a 3? [01:58:40] Deskana: I don't know. I'd say just make it a 3 and write a comment [01:58:40] Or in the next standup? [01:59:11] usually when this happens we just leave it as it is and not claim new points, but I've always hated that :P [02:00:17] I left a note. ;) [02:00:36] Deskana: :) [02:01:04] Deskana: also had another one for you, moment [02:01:30] Deskana: https://bugzilla.wikimedia.org/show_bug.cgi?id=65358 [02:01:36] * Deskana looks. [02:01:51] Deskana: the bug where if you tap an image on commons and it shows page does not exist is actually a MobileFrontend bug and is affecting the current app in the store too. [02:02:15] I've poked MaxSem to look at it, but thought you should know too [02:03:21] well [02:03:26] fixing it is easuy [02:03:40] is there a but at the end of the sentence? :) [02:03:46] now I'm trying to write a fucking test for it [02:03:52] aaah [02:03:56] cross wiki tests sound fun [02:05:01] MaxSem: thanks! :) [02:05:21] Deskana: hmm, also - is there value in letting editors who can't edit a page because of protection see the wikitext at all? We can just bounce them off then and there... [02:08:26] There is probably is (for consistency with desktop), but just not letting them edit for now is fine. [02:08:30] Not letting them see it. [02:08:40] Deskana: can we do that? simpler [02:09:07] Deskana: so there will be a pencil icon, but on tapping they will be told they can't edit it because so and so, and no edit window pops up. [02:09:34] Deskana: less confusing too, I'd think. we can also track that with EL if you want. [02:09:42] (all this will still fit into a 3) [02:09:57] YuviPanda: Yep, fine with me for MVP. [02:10:16] Deskana: want to change the Acceptance criteria? :) [02:10:34] Oh, I thought that was clear. [02:10:34] * Deskana looks. [02:10:53] That better? [02:11:06] Deskana: also do you want EventLogging for this? super trivial to add, and you can see how many people tap it and see the message [02:11:08] Deskana: yeah, mcuh [02:11:09] *much [02:11:36] MOAR EVENTLOGGING [02:11:40] If it's trivial, yes please. [02:11:51] cool, add it as a criteria. Let me write up a schema now [02:12:30] Done. [02:12:48] cool [02:14:40] Deskana: and https://meta.wikimedia.org/wiki/Schema:MobileWikiAppProtectedEditAttempt [02:15:03] Deskana: can you put the notes on the iOS card too? [02:15:23] I couldn't find the card... [02:15:46] Is it in the backlog? [02:16:27] Deskana: possibly, since iOS this sprint is full of design stuff [02:18:25] Deskana: hopefully at some point in the future we'll have support for edit notices, so all this can just reuse the desktop stuff [02:18:40] Deskana: btw, the app has support for AbuseFilter as well, you should try it out sometime :) [02:19:31] Eugh, edit notices. [02:19:32] I hate those. [02:19:35] haha [02:19:39] I find those fairly helpful [02:19:45] but they'll look like shit on mobile [02:19:50] I find them most useful on talk pages [02:20:18] What we need is millions of notices at the top of the talk pages. [02:20:19] https://en.wikipedia.org/wiki/Talk:Barack_Obama [02:20:21] Like that. [02:20:26] Because people read all of those. [02:20:27] All the time. [02:20:29] of course [02:20:30] duh [02:20:30] And they feel wiser for it. [02:20:34] Indeed [02:20:38] expand FAQs too, they do [02:20:56] Oh fuck I hadn't even noticed that. [02:20:57] Wow. [02:21:03] hahaa [02:21:18] sometimes when I'm bored I go and read talk pages of Evolution, Barack Obama, India, Jesus Christ, etc [02:21:23] and then I read wikimediaindia-l [02:21:27] and then AN/I [02:21:32] and sometimes wikimedia-l [02:21:51] wikimediauk-l has gotten better since some of the more... tricky people were placed on moderation [02:22:00] there's a large 'campaign' on wikimediaindia-l right now to stop donations to the WMF :P [02:22:35] lots of sock puppet accounts. Someone proposed a tech hackathon in India, and a sock popped up asking why WMF is paying tech staff to travel at all when the output is not in line with what they are paid [02:22:36] good times [02:22:52] That reminds me of this thread I saw on WO [02:23:00] WO? [02:23:00] Someone said "Staff at the WMF are paid too much because they're all incompetent" [02:23:05] Wikipediocracy [02:23:14] aaah [02:23:15] Someone replied "Yeah, pay the staff more so you can attract better people!" [02:23:15] right [02:23:33] They also cited one of my comments about how I got hired as the reason the WMF is so shit [02:23:44] And person 1 replied basically with "YEAH! THEY'RE OVERPAID!" and person 2 replied "YEAH! THEY'RE UNDERPAID!" [02:23:53] They were both agreeing with each other in spite of fundamentally disagreeing [02:23:56] What a circlejerk [02:24:03] hehe [02:24:21] Oh, Yuvi. You're an absolute delight to work with. I'm glad you're with us. :) [02:24:31] Deskana: :D <3 [02:25:03] Deskana: same here, sir :) Last month has been much nicer than before. [02:25:47] Deskana: oh, must remind you about Checkuser as well :P [02:26:41] YuviPanda: So I actually looked at that on Friday. It's much, much better than it was. [02:26:51] Deskana: CheckUser? explain [02:27:04] You mean the user agents, right? [02:27:10] Deskana: yeah. [02:27:28] Deskana: and about how they were useless for CheckUser? [02:27:28] from the app [02:27:30] Oh. I thought you submitted a patch to change it? [02:27:36] I ran a check on Friday and they're pretty okay. [02:27:41] Deskana: nope. [02:27:47] They're the same as they were months ago? [02:27:49] Deskana: oh, hmm. you should make an edit from the app and see how it is. [02:27:55] Deskana: the User Agents? Nope. [02:28:17] * Deskana looks up the email I sent to Maryana about it. [02:28:17] Deskana: for the app, they are 'WikipediaApp/ (/; phone/tablet) [02:28:59] Yeah. [02:29:00] Deskana: the solution we chalked out on mobile-l requires a bit of work. Mostly on the CheckUser extension side, and a tiny bit on the apps side. [02:29:07] Basically, what we've got now is good enough for MVP imo. [02:29:20] Deskana: oh! [02:29:25] Deskana: that's good to hear. [02:29:46] Would it be easy to put language code in there? [02:29:52] I mean, that'd add a lot. [02:30:04] Deskana: yeah, but we don't want to do that. keep fingerprinting as low as possible [02:30:13] Well most browsers also pass language configuration. [02:30:19] indeed, and that sucks :P [02:30:24] we should keep CU separate from UAs [02:30:28] I actually think on this one I am going to recuse as product owner. [02:30:33] haha. [02:30:33] COI? [02:30:37] Basically! [02:30:54] I'm too entrenched in one specific user group to be an effective product owner. [02:30:55] well, I'll see if I can hack this up the weekend after or something of that sort. [02:31:28] hoo offered to help, and since this is mostly CU work it'll be fun writing some PHP after a long time [02:31:39] but yeah, good to know it won't be an issue even if we don't touch it [02:31:47] Okay, I have to go. [02:31:52] Will you be around in an hour or so? [02:31:59] Deskana: probably not, it's 3:30 AM in the UK. [02:32:04] Deskana: but email will reach me! [02:32:04] Oh yeah, you're there. [02:32:20] Deskana: yeah. going to spend time with the girlfriend tomorrow evening, so finishing up stuff tonight [02:32:27] (will be around for meetings) [02:32:33] haha [02:32:34] Erm, what. [02:32:38] gj, Deskana [02:33:13] I have no idea how I did that. [02:33:13] Hah. [02:33:13] you probably wanted to write 'test' [02:33:18] and hit command first [02:33:24] cmd+T -> topic change, to 'est' [02:33:35] OH [02:33:37] I know what I did. [02:33:41] I tried to cmd-tab [02:33:48] Then tried to open a new tab and Google "EST" [02:33:49] aah [02:33:52] aaah [02:33:57] To see if it means "Eastern Standard Time" like I thought it did [02:34:05] So I could say "We're only five hours apart right now because I'm on EST!" [02:34:09] * Deskana facepalms. [02:34:11] Deskana: haha :) [02:34:40] Okay, so, I'm off for a bit. [02:34:43] Sleep well! [02:34:47] Deskana: you too! [02:34:47] And thanks for chatting. :) [02:34:51] Deskana: you too! :D [02:34:56] Deskana: good night, Mr. Garry Sir :) [04:48:40] (03PS1) 10BearND: Clear "Network error. Tap to try again." bar [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/134297 (https://bugzilla.wikimedia.org/64773) [05:22:31] (03CR) 10BearND: "Yuvi," [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/134281 (https://bugzilla.wikimedia.org/64424) (owner: 10Yuvipanda) [07:52:09] Am trying to build wikipedia-android using mvn install but it seems to be stuck at [07:52:16] "Downloading: https://tools.wmflabs.org/android-maven-repo/ch/acra/acra/4.5.0/acra-4.5.0.pom" for a long tiem [07:52:27] s/tiem/time [08:07:14] 3MobileFrontend / 3Feature requests: no path to Special:SpecialPages - 10https://bugzilla.wikimedia.org/63419#c5 (10florian.schmidt.welzow) I agree to Jon, SpecialPages aren't much important for the most of users, even less on mobile devices. Users, who need the Special pages know, how to navigate to them. I... [08:32:20] repeatedly tried mvn install and got it to download [10:35:15] anirudh24seven: cool :) [10:37:30] YuviPanda: am still struggling with this though. http://stackoverflow.com/questions/18025942/how-do-i-add-a-library-android-support-v7-appcompat-in-intellij-idea/ [10:38:22] anirudh24seven: you shouldn't have to need to do that, if you import it into IntelliJ as a Maven project [10:38:30] anirudh24seven: did you check the README? [10:38:43] (03PS2) 10Yuvipanda: Fix crashing when handling an unprocessable external link [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/134281 (https://bugzilla.wikimedia.org/64424) [10:40:41] YuviPanda: yes. I did read that fully and imported as a maven project. but still unable to build. [10:40:49] YuviPanda: getting errors similar to this: "android-apt-compiler:wikipedia/res/values-v14/styles_agora.xml:22: error: Error retrieving parent for item: No resource found that matches the given name '@style/Theme.AppCompat.Light'." [10:41:11] anirudh24seven: were you able to build with mvn install? [10:41:26] YuviPanda: yes [10:42:45] anirudh24seven: hmm, which version of IntelliJ? [10:46:54] trying in both, latest versions of Android Studio(0.5.8) and IntelliJ (13.1.2). retrying importing the project in IntelliJ. is there a different between both from an android developer perspective? [10:47:29] yeah, definitely. [10:47:39] Android Studio's maven support is still a bit wonky, I don't know how they managed to do that [10:47:42] just try IntelliJ [10:47:49] YuviPanda: ok [10:52:07] YuviPanda: wow. I guess I had been trying only Android Studio for the last few hours (instead of IntelliJ). built fine in IntelliJ now. :) [10:52:14] anirudh24seven: :D [10:52:29] anirudh24seven: woot! [10:56:06] YuviPanda: and runs fine on the device too. :) [10:56:12] anirudh24seven: wooot! :D [10:56:40] anirudh24seven: if you are looking for simple first patches, I'd suggest helping clear up the checkstyle errors. lots of trivial ones, and will give you experience with the gerrit workflow as well [10:57:13] anirudh24seven: https://integration.wikimedia.org/ci/job/apps-android-wikipedia-maven-checkstyle/552/checkstyleResult/? has them. [10:57:20] anirudh24seven: lots are simple ones, check by type. [10:58:15] YuviPanda: great. is this the associated bug? https://bugzilla.wikimedia.org/show_bug.cgi?id=63742 [11:00:44] anirudh24seven: yup! [11:01:01] anirudh24seven: usually I pick one type of error, fix all of it, and make a patch [11:01:17] YuviPanda: ok [12:16:40] 3MobileFrontend / 3stable: Edit button seems to have no effect in Wikivoyage - 10https://bugzilla.wikimedia.org/65529 (10Jon) 3NEW p:3Unprio s:3normal a:3None I'm currently trying to edit Wikivoyage and nothing happens when I click edit. Very weird. hash does change... [12:22:53] (03PS1) 10Florianschmidtwelzow: Add check for permission to create a new account [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/134341 (https://bugzilla.wikimedia.org/63456) [12:38:33] (03PS1) 10JGonera: Regression: Fix styling of page lists [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/134346 [12:42:29] (03PS2) 10JGonera: Fix margins in page list and search [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/133125 (https://bugzilla.wikimedia.org/64633) [12:42:38] hey jgonera! got a moment? [12:42:52] MF styles question [12:43:26] (03CR) 10JGonera: Fix margins in page list and search (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/133125 (https://bugzilla.wikimedia.org/64633) (owner: 10JGonera) [12:44:10] YuviPanda, I have just a few mins now [12:44:15] jgonera: ok! [12:44:19] if it's longer I'd rather eat first cause I'm starving ;) [12:44:57] jgonera: shouldn't be more than a few mins. [12:45:03] ok, shoot [12:45:13] jgonera: I'm trying to extract just the page content styling out of MF so I can use it for the apps [12:45:28] by extract I mean copy and then modify (to suit designers' tastes) and move to Extension:MobileApp [12:45:46] jgonera: am trying to understand which modules deal solely with page styling, since all the less files seem to contain a mix [12:46:04] jgonera: if this needs more than a few mins I'm happy to wait for you to finish lunch [12:46:43] YuviPanda, I'm afraid that all files do contain a mix that needs to be cleaned up [12:46:55] supposedly typography.less should be what you're looking for [12:46:58] jgonera: awww. can you at least tell me which modules I should look at? [12:47:02] but I bet there are styles in other places [12:47:07] yeah but I found styles in common.less etc [12:47:40] Jon sometimes has those rages of rearranging and cleaning up LESS files, but the way he does it often seems kind of arbitrary to me [12:47:50] haha [12:48:09] you can poke him when he's online, but I bet we'll have to shuffle stuff around [12:48:30] jgonera: hmm, ok [12:48:30] which is not bad [12:48:30] jgonera: I can just trawl through and copy paste for now [12:48:36] ugh, I'd rather avoid it [12:48:44] it shouldn't be too hard to move stuff around [12:49:25] jgonera: even then I'd have to copy paste some things anyway, since these will be modified [12:49:36] what will be modified? [12:49:39] jgonera: although it'd be nice to just reference the less files from MF in MA [12:49:46] jgonera: styles? we have a different font stack, for example [12:49:47] yes [12:49:51] (Open Sans) [12:50:00] oh, I see, I didn't know [12:50:05] but that should still be fine [12:50:17] have some common LESS file and then small files for MF and MA for tweaks [12:50:19] and overrides [12:50:27] true, if MF can be re-arranged to strip out the UI styles [12:50:32] from the content styles [12:51:03] it should be, I don't think UI and content styles are very tightly coupled [12:51:25] there might be a need for some line-height or font-size adjustment here and there [12:51:30] hmm, alright. jgonera I need to finish this up for this sprint, think anyone from MF can get to it before that? [12:51:33] (03PS1) 10Anirudh24seven: Add braces to 'if' construct. Change-Id: I32a197061dd0d6db7a471c0503770f5eed8ec7d8 [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/134350 [12:51:36] or should I explore temp. alternate options? [12:51:52] when does your sprint end? in two weeks? [12:51:57] jgonera: this friday :P [12:52:04] oh [12:52:15] I already have a mish mashed copy pasted version mergd [12:52:21] let me have a look at this today and I'll let you know [12:52:24] jgonera: woot! [12:52:26] jgonera: thanks! [12:52:33] sure [12:52:38] jgonera: ;) [12:52:44] anirudh24seven: thanks for the patch! :) [12:52:59] (03CR) 10Yuvipanda: [C: 032] "Thank you for the patch!" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/134350 (owner: 10Anirudh24seven) [12:53:18] (03Merged) 10jenkins-bot: Add braces to 'if' construct. Change-Id: I32a197061dd0d6db7a471c0503770f5eed8ec7d8 [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/134350 (owner: 10Anirudh24seven) [12:54:20] YuviPanda: welcome. :) what do you suggest now? can I try fixing other issues with the same bug or should I leave it for others as a good-first-bug? [12:54:52] anirudh24seven: I say go for fixing as much of it as you can, unless you get bored :) It's something we need to get to zero soon [12:55:07] YuviPanda: Great. Thanks. [13:00:40] YuviPanda: Should I have added the bug number in the commit message? The bug status is not updated with the my commit. [13:00:47] anirudh24seven: yeah, next time [13:00:53] Bug: to the commit message [13:01:00] YuviPanda: Got it [13:06:24] (03PS2) 10Florianschmidtwelzow: Add check for permission to create a new account [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/134341 (https://bugzilla.wikimedia.org/63456) [13:06:35] YuviPanda: Does Jenkins run Checkstyle for every build? The NeedBracesCheck warning hasn't disappeared. [13:06:44] anirudh24seven: it should, yeah. [13:50:41]