[00:00:05] bearND: Superfreak (aka Deskana aka Dan Garry aka Mr. Garry Sir) also knows his way around OTRS a bit, I believe [00:00:43] am off now. cya [00:20:19] (03PS1) 10Kaldari: Hygiene: Updating name of feature test (watchstar.feature) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/134537 [00:29:01] (03CR) 10Kaldari: [C: 032] Hygiene: Updating name of feature test (watchstar.feature) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/134537 (owner: 10Kaldari) [00:29:38] (03Merged) 10jenkins-bot: Hygiene: Updating name of feature test (watchstar.feature) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/134537 (owner: 10Kaldari) [05:07:20] (03PS1) 10BearND: Fix crash after switching languages [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/134557 (https://bugzilla.wikimedia.org/65539) [08:32:12] YuviPanda|zzz: https://integration.wikimedia.org/ci/job/apps-android-wikipedia-maven-checkstyle/552/checkstyleResult/ hasn't been updated. Why would that be? [09:22:53] (03PS1) 10Jdlrobson: Hygiene: Remove unused schema [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/134582 [10:24:06] (03PS4) 10Jdlrobson: Distinguish between VisualEditor and SourceEditor in event logging [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/134527 [10:24:08] (03PS1) 10Jdlrobson: Stop EventLogging errors when switching from VisualEditor to Editor [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/134587 (https://bugzilla.wikimedia.org/65378) [11:11:41] (03PS1) 10Florianschmidtwelzow: Implement upload via "Add image" on New file pages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/134589 (https://bugzilla.wikimedia.org/58311) [11:26:50] 3MobileFrontend / 3Feature requests: mobile-friendly templates should be easy to create - 10https://bugzilla.wikimedia.org/65498#c8 (10darklama) Multilingual Wikimedia projects like Meta, Commons, Incubator, etc. often include templates that change with a person's language choice, which requires far more par... [13:24:55] (03CR) 10Yuvipanda: "Why statics? I don't see any obvious negative with this one, but still feels very icky. It will clean up the code a fair bit at a lot of p" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/134557 (https://bugzilla.wikimedia.org/65539) (owner: 10BearND) [13:52:15] dbrant: thoughts on https://gerrit.wikimedia.org/r/#/c/134557/ [13:52:16] ? [13:53:46] YuviPanda: haven't looked at that one yet! I'll think about it [13:53:55] dbrant: ok [13:56:53] YuviPanda: I see; I've actually done it that way in the past. I don't find it icky, personally. [13:57:23] dbrant: hmm, it was just an in stinctive ick, but thinking about it again I can't find specific reasons for the ick. It's already a singleton anyway [13:58:28] dbrant: if we have that it'll also simplify a lot of code, I think [13:58:49] YuviPanda: I do believe so [14:00:54] dbrant: alright. let me test and merge [14:05:28] (03PS2) 10Yuvipanda: Fix crash after switching languages [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/134557 (https://bugzilla.wikimedia.org/65539) (owner: 10BearND) [14:06:50] (03CR) 10Yuvipanda: [C: 032] "PS2 is just a doc update." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/134557 (https://bugzilla.wikimedia.org/65539) (owner: 10BearND) [14:08:06] (03Merged) 10jenkins-bot: Fix crash after switching languages [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/134557 (https://bugzilla.wikimedia.org/65539) (owner: 10BearND) [14:12:08] * YuviPanda pokes jdlrobson with https://gerrit.wikimedia.org/r/#/c/134474/ [14:13:57] (03CR) 10Yuvipanda: "App has styles that are served from Extension:MobileApp, which currently is a clumsy copy of parts of MobileFrontend's styles plus our own" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/134473 (owner: 10JGonera) [14:15:13] (03CR) 10Yuvipanda: "https://trello.com/c/k7oQ2wLr/41-5-complete-page-styling-css-and-move-it-to-extension-mobileapp is associated trello card. It doesn't spec" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/134473 (owner: 10JGonera) [14:50:15] YuviPanda: kaldari has an open question [14:50:25] as do i on the parent patchse [14:51:18] (03PS2) 10Jdlrobson: Move styles related to content to typography*.less [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/134473 (owner: 10JGonera) [14:52:08] (03CR) 10Yuvipanda: "+1 for the idea of a component directory, but this patch could be considered as a first step in that direction." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/134473 (owner: 10JGonera) [14:52:57] YuviPanda: this would be a good easy time to do it though :) [14:53:10] hold off till jgonera shows up [14:53:16] he was supposed to be working till 2pm pst [14:53:22] so i thought he'd be around now [14:54:02] YuviPanda: kaldari is also in the midst of pushing new typography styles to stable [14:59:10] hi YuviPanda: thanks for merging https://gerrit.wikimedia.org/r/#/c/134557/. i had some mixed feelings about this one, too, but i don't see any big negatives making the app instance available. it helps wherever we need an app context, too. [15:38:34] (03Abandoned) 10BearND: Fix crash after switching languages [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/134404 (https://bugzilla.wikimedia.org/65539) (owner: 10BearND) [16:09:04] (03PS1) 10Jdlrobson: Add clicktracking to table of contents [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/134628 [16:09:06] (03PS1) 10Jdlrobson: Push table of contents to stable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/134629 [16:09:08] (03PS1) 10Jdlrobson: Open sections by default on tablets [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/134630 [16:32:39] (03CR) 10Jdlrobson: [C: 04-1] "Thanks a bunch for taking a look at this! :)" (033 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/134589 (https://bugzilla.wikimedia.org/58311) (owner: 10Florianschmidtwelzow) [16:49:37] (03Abandoned) 10Jdlrobson: Center the language list [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/127613 (https://bugzilla.wikimedia.org/64617) (owner: 10Amire80) [16:49:58] (03Abandoned) 10Jdlrobson: WIP: Anonymous editing in alpha [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/117324 (owner: 10Jdlrobson) [16:50:56] (03CR) 10Jdlrobson: "Hi Kelson - any chance to take another look? Sorry to bug you but if you are not working on it someone else might be able to fix it for yo" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/117699 (https://bugzilla.wikimedia.org/54885) (owner: 10Kelson) [16:51:25] (03PS2) 10Jdlrobson: WIP: Add non JavaScript site tests for search [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/126131 [16:54:14] Krinkle, is "Use of "anonymous" is deprecated." something related to jQuery update? [16:54:21] jgonera: mw.user [16:54:37] deprecated since 1.20 [16:54:42] as of today, with tracking [16:54:48] mw.user.isAnon() [16:54:53] mw.user is deprecated? [16:54:53] mw.user.getName() are the new names [16:54:56] oh [16:54:56] no [16:54:57] ok [16:56:46] the stack trace I'm given is kind of useless [16:58:32] jgonera: it leads to where the call to mw.user.anonymous is, no? [16:58:33] Krinkle, is it marked as deprecated anywhere in docs? [16:58:40] yes, for several years [16:58:42] Krinkle, not really [16:59:04] Put people don't generally read release notes or documentaiton, so now that we have mw.log, I'm adding tracking calls now so that people actually see it ( [16:59:19] that's good [16:59:42] (03CR) 10Florianschmidtwelzow: Implement upload via "Add image" on New file pages (033 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/134589 (https://bugzilla.wikimedia.org/58311) (owner: 10Florianschmidtwelzow) [17:00:02] Krinkle, we have something like this: https://git.wikimedia.org/blob/mediawiki%2Fextensions%2FMobileFrontend.git/2cd5b95249d1f0a0506208c62bb2a5d4c7709162/javascripts%2Fcommon%2Fuser.js and the extend call seems to be triggering it [17:00:05] brb, standup [17:01:01] jgonera: standup! [17:01:14] awjr, I know, hangout not loading again... [17:01:27] >_< [17:01:29] doh [17:02:42] jgonera: why would you do that? [17:07:07] kaity|away: can you sync up with jdlrobson RE https://trello.com/c/m3m53BdN/32-5-use-existing-references-dialog ? [17:07:30] kaity|away: he's unclear on the story and needs some clarification help [17:13:37] basile: yeah, me neither [17:13:47] bearND: we should definitely move a bunch of other things to use this as well [17:13:59] jdlrobson: just want to get it merged before the train though :P [17:14:08] sorry basile, I meant bearND [17:14:46] YuviPanda: ok [17:15:07] (03PS8) 10Dbrant: Keep only a limited number of WebViews in memory. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/134083 (https://bugzilla.wikimedia.org/64450) [17:15:30] jdlrobson: what was the issue? [17:15:57] https://bugzilla.wikimedia.org/show_bug.cgi?id=65587 [17:16:32] huh [17:16:50] it didn't show up in trello [17:16:55] yeah i see that [17:17:03] i wonder if something's wrong with bugello [17:17:05] investigating [17:17:08] ok cool [17:17:10] Maryana, https://bugzilla.wikimedia.org/show_bug.cgi?id=65504 can be closed, it's fixed by awaiting merge in OOUI [17:17:13] i think i raised another one but not 100% [17:18:28] yeah something's wrong with bugello [17:18:32] figuring it out now [17:19:54] >_< [17:20:04] (03PS3) 10Jdlrobson: QA: Add non JavaScript site tests for search [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/126131 [17:20:07] jdlrobson: i hadn't added teh bugello user to the new trello board [17:20:14] awjr: lolz [17:20:26] it is one of the annoying administrative things with trello [17:20:39] Krinkle, we're doing it so that we can extend mw.user [17:20:41] anyway jdlrobson can you dbl check that things look ok now? [17:20:48] awjr: will do [17:21:07] (03CR) 10Jdlrobson: "@jgonera are you still working on this?" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116156 (owner: 10JGonera) [17:21:34] (03CR) 10Jdlrobson: "Now ready to review." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/133190 (owner: 10Jdlrobson) [17:22:16] jgonera: Hm.. wouldn't it be easier to use mw.user as-is where possible and use your own where you need your own? Makes it harder to find what is what this way (and to identify what is what, because in the calling code mf.user.anonymous isn't mw.user.anonymous, and a perfect example there for getGroups [17:22:24] and if things change etc. [17:23:06] tfinc: bearND that was weird. everything else works fine! [17:23:11] the notices can't distinguish between access and calling (limitation of javascript), but in a way it makes sense as it is, you're mixing it in so your mf.user object has thse methods too. [17:23:46] jgonera: it might be worthwhile to collect a list of patchsets that we are waiting for VE to review to bring up during sos [17:23:56] awjr, OK [17:24:22] awjr, I mean, basically, it's all patches by me, kaldari and jdlrobson that are in VE and OOUI repos [17:24:56] but I can make a list in chronological order [17:24:56] jgonera: if you provide direct links there's a better chance someone else reading through the notes etc may take a look [17:25:16] but whatever you feel is best :) [17:26:30] (03PS5) 10Jdlrobson: Hygiene: Icon cleanup [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/133189 [17:26:33] Krinkle, so those deprecation warnings show up because I access deprecated functions when extending mw.user although I don't call them? [17:27:08] Krinkle, maybe we should have something separate, although it's probably a better idea to move those two methods to core [17:27:53] I think the pattern mf.user uses there is a bit odd and non-standard. I can't account for everything anyone does. mf is accessing the deprecated methods and copying them over. [17:28:15] jdlrobson, awjr do QUnit tests pass for you on master? [17:28:16] If you really want to keep it like that, I'd suggest skipping those keys. That would of course break if you're sing them, so that's a good test. [17:28:20] Or just copy the ones you want [17:28:34] Krinkle, so not use $.extend? [17:28:42] this way it makes it a lot harder to track. E.g. if a new method is added to mw.user, should mf.user automatically get it? Is that intuitive? [17:29:01] I'd just drop the mw.user link entirely, but for back-compat you could copy the ones you need [17:29:18] e.g. mf.user = { your: your2, your3: getUserRights: mw.user.getUserRights } [17:29:35] then slowly phase them out [17:30:40] (03PS5) 10Jdlrobson: Hygiene: Make icons in overlays and drawers global and reusable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/133190 [17:30:56] jgonera: just updating core [17:31:01] MobileFrontend qunit tests passing fine [17:31:15] (03PS9) 10Yuvipanda: Keep only a limited number of WebViews in memory. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/134083 (https://bugzilla.wikimedia.org/64450) (owner: 10Dbrant) [17:31:30] No errors jgonera [17:31:35] just message Use of "name" is deprecated. [17:31:35] Use of "anonymous" is deprecated. [17:31:37] jdlrobson, in chrome? [17:31:53] one of them is rounding error in nearby, I have to fix it... [17:32:02] the other one is "global failure" [17:32:12] Uncaught TypeError: Cannot read property '0' of undefined [17:32:45] ah chrome browser that's a different story [17:32:47] yeh that's failing [17:32:56] i thought i fixed that one in my nearby refactoring [17:33:05] also MobileFrontend uploads: global failure (2, 0, 2) [17:35:14] jdlrobson, any patches you need reviewed by VE folks? [17:35:24] kaldari, only * https://gerrit.wikimedia.org/r/#/c/134237/ [17:35:24] * https://gerrit.wikimedia.org/r/#/c/134240/ ? [17:36:28] MaxSem kaldari: jgonera kaity fyi i'm off to dinner in about 30 mins for a bit. I'll be back later for another hour and a half - let me know if there's anything in particular you'd like to focus on [17:36:37] You can go ahead and merge https://gerrit.wikimedia.org/r/#/c/134240/, it's trivial and won't break anything if it's merged before the other one [17:36:43] kaity: could you point me at where the use existing reference link is in the desktop visual editor interface? [17:36:46] jdlrobson, just answer this one question ;) [17:37:06] jgonera: my answer is no if you need it [17:37:11] i thought it was more an open question :) [17:37:13] (03PS1) 10Mhurd: More top and bottom menu refactor. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/134640 [17:37:30] https://gerrit.wikimedia.org/r/#/c/134237/ was reviewed by Roan, and he says it might need to be implemented differently, but he wants to get Trevor's opinion. I'll see if Krinkle has any thoughts in the meantime. [17:37:30] (03Abandoned) 10Jdlrobson: Introduce the transformable class [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/131886 (owner: 10Jdlrobson) [17:38:04] (03Abandoned) 10Jdlrobson: WIP: Add the cover element [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129583 (owner: 10Jdlrobson) [17:39:55] (03CR) 10Jdlrobson: QA: Add browser tests for Special:Uploads edge cases (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/133500 (owner: 10Jdlrobson) [17:40:20] (03Abandoned) 10Jdlrobson: QA: Tests for 2nd upload from Special:Uploads page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/130985 (https://bugzilla.wikimedia.org/64400) (owner: 10Jdlrobson) [17:40:34] thanks kaldari [17:43:18] jdlrobson: this bug: https://trello.com/c/4E5xdNyG/20-bug-65393-severe-regression-impossible-to-scroll-on-iphone-4-3-2 do you just mean iphone 4? what is an iphone 4.3.2? :) [17:43:36] it's the version number Maryana [17:43:40] we might have on in the magic drawer [17:43:54] i have a 4.. how do i check version? [17:44:17] errr settings [17:44:20] general > about [17:44:49] brb [17:45:15] (03CR) 10Kaldari: Respect the hash with sub headings (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/133470 (https://bugzilla.wikimedia.org/64918) (owner: 10Jdlrobson) [17:45:33] hmm [17:45:39] jdlrobson: Finally found what broke my browser tests ^ [17:46:32] (03PS2) 10Yurik: Handle BeforeHttpsRedirect hook to prohibit HTTP->HTTPS redirect [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/133029 [17:47:43] (03CR) 10MaxSem: [C: 031] Open sections by default on tablets [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/134630 (owner: 10Jdlrobson) [17:49:30] although I have no idea why [17:50:20] (03CR) 10MaxSem: [C: 032] Hygiene: Remove unused schema [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/134582 (owner: 10Jdlrobson) [17:51:12] (03Merged) 10jenkins-bot: Hygiene: Remove unused schema [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/134582 (owner: 10Jdlrobson) [17:52:32] kaldari: any idea why? [17:52:38] none [17:53:02] kaldari: does chrismcmahon have any ideas? [17:53:03] jdlrobson: apparently having a hash in the URL prevents it from switching to the mobile view, but I have no idea why [17:53:06] kaldari: any error message you are getting? [17:53:12] no [17:53:15] also which browser are you testing this in? [17:53:24] Firefox and Chrome, same effect [17:54:04] jdlrobson: to use an existing link in desktop you go to Insert > Reference [17:54:34] then the free-form dialog opens, theres a button at the bottom of that "use existing reference" [17:55:47] insert > reference? [17:55:57] so where does that go in mobile as we don't have that do we? [17:59:15] ^ kaity [17:59:29] also i need to head off in about 5 mins - i'll leave this on so you can message me and i'll pick this up later [18:00:17] jdlrobson: in mobile we will have it in the citation menu [18:00:17] https://trello.com/c/xCo6uLAZ/23-5-references-dropdown-from-toolbar-styling [18:00:34] desktop will move in this direction too [18:01:32] ahh i was looking at the other story. Ok this makes a bit more sense now. Thanks kaity [18:01:40] jdlrobson: sure! [18:06:11] search in MF on beta labs seems pretty broken right now. not returning results and a floating 'no-js-only' input box always visible [18:07:19] (03CR) 10Jdlrobson: Implement upload via "Add image" on New file pages (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/134589 (https://bugzilla.wikimedia.org/58311) (owner: 10Florianschmidtwelzow) [18:07:54] jdlrobson: ^ [18:07:57] kaldari: looks like you got the browser tests working locally again? [18:08:09] awjr: well sort of [18:08:10] jdlrobson: are you all set with what you neded for the references card? [18:08:30] chrismcmahon: any tests failing? [18:08:34] awjr: maybe :-) [18:08:38] Maryana, how do I sign off a card in trello? just archive? [18:08:38] I know how to make them work, but not without breaking the tests that rely on the hash [18:08:46] jgonera: just move to done [18:08:47] jgonera: just move it over to 'done' [18:08:50] kaldari: still having issues? [18:08:53] ah [18:09:04] kaldari: have you had a chance to chat with chrismcmahon? [18:09:10] oh, right, I forgot I have to scroll horizontally [18:09:18] chrismcmahon: looks okay to me.. [18:09:45] kaldari: not quite sure what's going on in your box [18:10:00] all i can think of is you are using old version of page object [18:10:21] chrismcmahon: any idea why this would break switching to the mobile view: https://gerrit.wikimedia.org/r/#/c/133470/7/tests/browser/features/support/pages/article_page.rb [18:10:39] specifically the hash character [18:10:44] kaldari: I saw your email, I was just about to look at that branch [18:10:55] kaldari: so it just does't look the browser or it falls on a step? [18:11:19] jdlrobson: It always fails on any step that is expecting the mobile view, which is pretty much all of them [18:11:43] MaxSem, why was https://bugzilla.wikimedia.org/show_bug.cgi?id=65094 even happening? what does this page has to do with Special:Uploads? [18:11:54] kaldari: that's super weird [18:11:57] yes [18:12:00] does the link to mobile view get clicked? [18:12:06] no [18:12:13] but that's not part of the steps [18:12:23] so it loads up in desktop mode? [18:12:29] it seems to switch to the mobile view through some sort of voodoo [18:12:44] Maryana: head's up i sent you a meeting invite for 230 today - feel free to move it if you prefer [18:12:49] yes, it just loads the desktop view [18:12:50] jgonera, the URL in that report is bogus due to a bug in UDP logging [18:12:59] oh, I see [18:13:09] so it was Special:Uploads for a user that doesn't exist? [18:14:04] jdlrobson, what you did in https://gerrit.wikimedia.org/r/#/c/133088/6/javascripts/common/application.js is evil, you're creating separate execution path for a test vs. production [18:14:13] or with an invalid title.... [18:14:27] if you want to test it this way, you should always require an argument for this function [18:14:53] jdlrobson: normally when I run tests, it loads the desktop view first and then a split second later it switches to the mobile view, but I have no idea what actually does that as there doesn't seem to be any explicit step that does that (that I can find). [18:14:55] thanks MaxSem [18:15:55] chrismcmahon: ^ [18:16:48] MaxSem, still not sure how this can be reproduced locally, what was an example URL that would cause this error? [18:17:07] chrismcmahon: It doesn't seem that anything actually calls set_cookie() BTW. [18:17:27] bbl [18:17:59] jdlrobson, it's actually buggy too... [18:18:12] it seems now it will assume all webkits support position fixed... [18:18:24] check Special:Uploads, Special:Uploads/, Special:Uploads/MediaWiki:foo while logged in or not [18:18:49] oh, and Special:Uploads/somenonexistentuser too [18:19:07] Special:Uploads/somenonexistentuse works on master~100 [18:19:30] kaldari: so when I look at cookies in my browser launched by selenium, I have the mf-format cookie set [18:20:24] jdlrobson, nope, I was wrong, but you removed a fixme without addressing it correctly though [18:20:47] jdlrobson, fixme said it will fail for webkits past 599 and you fixed it for 1000+ [18:21:42] (03PS1) 10Mhurd: Marked lang insertion point. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/134653 [18:23:27] kaldari: ironically, toggling.feature does in fact switch me to mobile view from desktop, but no other test does. One thing that I think is a little smelly is appending a bare # to the end of every single page in every single test. [18:24:36] yeah, we should probably fix that regardless [18:28:02] kaldari: patch for that in just a minute... [18:34:07] (03PS1) 10Cmcmahon: QA: only add a # character for the test and page that needs it [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/134657 [18:34:26] (03PS1) 10JGonera: Fix position: fixed support detection for Webkit [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/134658 [18:34:37] (03CR) 10Brion VIBBER: [C: 032 V: 032] More top and bottom menu refactor. (031 comment) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/134640 (owner: 10Mhurd) [18:34:48] kaldari: I don't know if it solves your cookie issue but it is much cleaner: https://gerrit.wikimedia.org/r/#/c/134657 [18:36:05] (03PS2) 10Florianschmidtwelzow: Implement upload via "Add image" on New file pages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/134589 (https://bugzilla.wikimedia.org/58311) [18:36:26] chrismcmahon: that'll probably fix it. Testing now [18:37:57] (03PS2) 10JGonera: Fix position: fixed support detection for Webkit [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/134658 [18:38:44] (03CR) 10Kaldari: [C: 032] QA: only add a # character for the test and page that needs it [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/134657 (owner: 10Cmcmahon) [18:38:54] chrismcmahon: Thanks! [18:39:02] kaldari: whew! [18:40:51] (03Merged) 10jenkins-bot: QA: only add a # character for the test and page that needs it [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/134657 (owner: 10Cmcmahon) [18:56:21] kaldari, you also don't have QUnit errors on latest core and MF masters? [18:56:28] running in Chrome [18:58:26] jgonera: last time I ran it I was getting one error in qunit, but I don't remember what it was... [18:58:55] kaldari, can you check when you have a moment? [19:02:09] jgonera: I get 1 fail in Firefox (uploads), and 2 in Chrome (NearbyApi: #getPages and uploads) [19:02:20] thanks kaldari [19:02:21] same here [19:02:43] fixing the one in nearby, the other one is more mysterious (and I tracked it down to EditorApi tests actually) [19:02:45] jgonera: the nearby failure in Chrome looks like some kind of rounding error [19:02:49] yep [19:03:00] never check for strict equality of floats [19:03:59] Krinkle, it seems we don't have https://github.com/jquery/qunit/tree/v1.11.0/addons/close-enough enabled. what is a nice way of checking float values in QUnit then? [19:07:55] jgonera: Example? [19:08:10] floats may be variable, but they shouldn't be random, they're deterministic [19:08:27] not-assertions and in-range assertions are usually result of a compromise. [19:08:34] I wouldn't recommend it for new tests [19:08:45] but if you have to, assert.ok( expression ) [19:08:56] or Math.round / Math.floor it [19:09:49] Math.abs [19:10:28] jgonera: what is the actual test? [19:10:46] maybe something should be mocked if it's polluted by something else [19:23:40] matanya: how goes signing off on the android stories ? [19:24:01] what tfinc ? [19:35:31] Maryana: ^ hehe [20:05:07] jdlrobson, has performance in VE improved noticeably after your CSS changes? [20:15:28] (03PS1) 10Brion VIBBER: Work in progress: language marker button in doc area (not yet functional) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/134678 [20:24:19] jgonera: i'll check it out now [20:26:16] jgonera: in terms of the supportsPositionFixed have you got some test cases which fail? I thought I covered them all - AppleWebKit/600 passes and AppleWebKit/533 and AppleWebKit/400 fail due to qunit [20:26:22] *according to quit [20:26:32] jdlrobson, I added cases that failed in my patch [20:26:44] jgonera: ok i'll take a look [20:29:55] jgonera: are there even versions of AppleWebKit that pass ResourceLoader tests that are below 100? [20:32:43] jdlrobson, I don't know, but why have a shoddy regex if we can have a correct regex? ;) [20:32:52] no sure i was just curious [20:33:56] (i don't think it does exist thus the bug isn't as bad as you make out :)) [20:34:07] kaldari_lunch: did you get to bottom of your issues? [20:34:19] also what's with this late lunchness! [20:34:26] you've changed! :P [20:34:45] Maryana, awjr adding tooltips is not going to be super easy [20:34:52] jdlrobson: it's true although I'm still not eating breakfast, just being hungry longer :) [20:35:07] jdlrobson: my testings issues are resolved now [20:35:44] kaldari: yeyy what was the issue? [20:36:33] well, the issue was the hash sign, but I have no idea why. Never solved that mystery :( [20:36:33] (03CR) 10Jdlrobson: [C: 032] Fix position: fixed support detection for Webkit [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/134658 (owner: 10JGonera) [20:36:54] jdlrobson: chris worked around it with https://gerrit.wikimedia.org/r/#/c/134657/ [20:37:05] (03Merged) 10jenkins-bot: Fix position: fixed support detection for Webkit [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/134658 (owner: 10JGonera) [20:37:26] kaldari: mmm there's a lot of mysteries in our browser tests and it worries me! :) [20:37:32] https://gerrit.wikimedia.org/r/#/c/133500/ < kaldari what was the problem with that? [20:38:17] jdlrobson: I'm lost here... [20:38:26] with the scenario name? [20:39:05] Would 'Scenario: Empty special page parameter takes user to their own uploads page' make more sense? [20:39:59] ^ kaldari [20:41:02] (03PS7) 10Jdlrobson: QA: Add browser tests for Special:Uploads edge cases [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/133500 [20:41:26] jdlrobson: Is there other option besides 'their own uploads page'? [20:41:34] it could 404 [20:41:42] this is how max wrote it though [20:41:43] :) [20:41:43] why not just say 'uploads page'? [20:42:46] 'personal userpage' definitely doesn't make me think of the uploads page [20:43:33] even 'personal uploads page' would be an improvement [20:43:50] (03CR) 10Jdlrobson: [C: 04-1] "Whoops - still doesn't seem to work!" (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/134589 (https://bugzilla.wikimedia.org/58311) (owner: 10Florianschmidtwelzow) [20:44:07] userpage means User:Jon to me [20:44:11] already changed it kaldari see https://gerrit.wikimedia.org/r/133500 :) [20:44:21] should be clearer now! :) [20:44:49] much better :) [20:45:19] cool :) [20:45:36] also if you could merge my nasty QA hygiene patches.. mechanical turk is expensive ;-) [20:46:46] YuviPanda|brb: hey was was the opt-in link for the android testing? [20:47:00] YuviPanda|brb: the group link from http://lists.wikimedia.org/pipermail/mobile-l/2014-March/006642.html says no such group [20:47:04] i don’t recall exactly what we changed [20:47:57] brion: the link in that message is wrong: https://groups.google.com/forum/#!forum/wpandroidapptesters [20:48:57] dbrant: yeah just figured that out :D [20:49:03] the period on the end broke it [20:49:08] yep [20:54:17] jdlrobson: The tests in https://gerrit.wikimedia.org/r/#/c/133500/ fail for me at the 'I click Create Account' step, but the step works fine in master. [20:54:30] does it work for you? [20:54:40] Krinkle, example test with float check: https://git.wikimedia.org/blob/mediawiki%2Fextensions%2FMobileFrontend.git/2cd5b95249d1f0a0506208c62bb2a5d4c7709162/tests%2Fqunit%2Fmodules%2Fnearby%2Ftest_NearbyApi.js#L50 [20:54:53] o_O [20:54:54] Krinkle, this fails on some browsers/platforms [20:55:03] because the number differs slightly [20:55:18] kaldari: which featuee test? [20:55:29] features/create_account_failure_messages.feature [20:55:55] kaldari: looking.. [20:56:04] tried in Chrome and Firefox [20:57:07] kaldari: same let me fix [20:57:57] (03PS8) 10Jdlrobson: QA: Add browser tests for Special:Uploads edge cases [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/133500 [20:58:17] kaldari: not sure how that happened but it was using the wrong page [20:58:26] nice catch :) [20:58:57] jgonera: i can confirm the VisualEditor stress test shows the same result for mobile as it does desktop http://en.m.wikipedia.beta.wmflabs.org/wiki/VisualEditor_stress_test? [20:59:39] kaldari: although still an issue - 1s [20:59:58] jdlrobson, how does that test work? where is the result? [21:00:17] jgonera: i'm using chrome dev tools [21:01:01] jdlrobson, but what is the test? how do I run it? [21:01:34] jgonera: so open chrome dev tools and click profile and collect JavaScript profile [21:01:47] jdlrobson, with VE open? [21:01:48] start it and click the edit button on mobile [21:01:53] ok [21:01:56] and when VE has loaded stop it [21:01:58] do same for desktop [21:02:02] jgonera: Where exactly? [21:02:07] do various runs and compare [21:02:10] jgonera: The response from getPages? [21:02:19] Krinkle, L50 [21:02:23] yes [21:02:34] That shouldn't contact the server but do an ajax mock, this is testing the processing client-side, so you can just mock the response [21:03:06] at which point you provide the float in the mock, and then it only varies in how mf js processes the number (e.g. rounding or no rounding), but that should be deterministic [21:03:25] Krinkle, it performs math on floats, contacting or not contacting server is irrelevant [21:03:30] if it doesn't do any processing at all, then this should probably be a phpunit test asserting the response from the api module [21:03:36] and it does stub the request anyway [21:03:39] ok [21:04:11] no, it performs math on floats in JS, and floats are never guaranteed to have exactly the same value on different platforms [21:04:20] that's why you check them with some precision [21:04:34] Number#toPrecision [21:04:37] might help [21:05:04] Math.round ? [21:05:04] Krinkle, I can just do assert.ok( Math.abs(pages[2].dist - 23.376927175788786) < 0.001 ); but that's ugly [21:05:04] That would remove all digest [21:05:04] hm [21:05:04] roPrecision trims it [21:05:09] +1 to toPrecision [21:05:14] I think you should end up with a strict test, you can decrease the precision if you want to tolerate that, but allowing a range is messy [21:05:21] but that returns a float or a string or what? [21:05:28] string i believe [21:05:35] Krinkle, what? [21:05:36] Yep [21:05:37] (03PS9) 10Jdlrobson: QA: Add browser tests for Special:Uploads edge cases [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/133500 [21:05:43] you always have to allow for a range in floats [21:05:50] No, you don't [21:06:02] implicitly yes, but not in the code explicitly. [21:06:11] ^ kaldari got that fixed [21:06:15] ok, I don't suspect you don't know how floats work, so I must be missing something? [21:06:22] I know how floats work [21:06:32] I also know how unit tests should not be written. [21:07:07] you can always, always, do a test that is both cross-browser reliable and reflects what you want to allow/disallow without needing to deal with non-strict comparison. [21:07:08] so how do you test code performing math on floats? [21:07:24] you devalue the precision to what you want to tolerate and strictly compare that [21:07:49] if a browser is way way off, that will hurt and break your code, so you don't want to tolerate anything, it should be within a "range", [21:07:58] well, ok, that's the same as allowing range I'd say, technically, I thought you said that using toPrecision is also not a good solution [21:08:12] e.g. assert.equal( dist.toPrecision, "23.377" ) [21:08:19] no [21:08:24] e.g. assert.equal( dist.toPrecision( 5 ), "23.377" ) [21:08:24] sure [21:08:32] ok, misunderstood you [21:08:43] the problem with ranges is that you can't assert or debug the value very well in frameworks and reports. [21:09:47] like using assert.ok( 5 == 7) instead of assert.equal(5, 7), and using assert.notEqual(arr.indexOf('x'), -1) instead of assert.equal(arr.indexOf('x'), 4); // don't tolerate it to be anywhere in the array, be strict. [21:09:48] etc. [21:09:53] sorry for the confusion [21:10:51] I know, that's why I asked about assert.close, because assert.ok is ugly ;) [21:12:15] (03PS1) 10JGonera: Fix NearbyApi test [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/134732 [21:12:30] (03PS3) 10Florianschmidtwelzow: Implement upload via "Add image" on New file pages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/134589 (https://bugzilla.wikimedia.org/58311) [21:14:14] (03CR) 10Florianschmidtwelzow: "Sorry for this amateur work :/ You are absolutly right, only remove the enabled class for css don't disable the button himself :/" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/134589 (https://bugzilla.wikimedia.org/58311) (owner: 10Florianschmidtwelzow) [21:14:33] (03CR) 10Florianschmidtwelzow: Implement upload via "Add image" on New file pages (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/134589 (https://bugzilla.wikimedia.org/58311) (owner: 10Florianschmidtwelzow) [21:14:44] (03CR) 10SG: "For what it's worth, the latest version of Storer.js implements expiry time support for all substorage types (cookie, local, session, memo" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/131897 (owner: 10Kaldari) [21:20:54] (03CR) 10SG: "^^ I mean the cookieStorage fallback for localStorage. To clarify: localStorage falls back to userData (IE, not implemented in Light versi" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/131897 (owner: 10Kaldari) [21:24:26] bearND: have you created a bug for java.lang.IllegalArgumentException: View=com.android.internal.policy.impl.PhoneWindow$DecorView{428387a8 V.E..... R......D 0,0-1026,288} not attached to window manager ? [21:25:24] liangent: no, i have not [21:27:19] (03CR) 10Jdlrobson: [C: 04-1] "Yey!! it works :-) - but still 2 more things to fix up to make this mergeable!" (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/134589 (https://bugzilla.wikimedia.org/58311) (owner: 10Florianschmidtwelzow) [21:27:21] brion: if ([[SessionSingleton sharedInstance] isCurrentArticleMain]) { [21:29:11] bearND: let me create it or cc me when you create it? [21:29:42] liangent: feel free to create it. is this the same as in OTRS? [21:30:24] bearND: yep [21:30:26] liangent: not sure what the process for OTRS bugs is yet. dbrant: do you know? [21:31:17] (03CR) 10Kaldari: [C: 032] QA: Add browser tests for Special:Uploads edge cases [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/133500 (owner: 10Jdlrobson) [21:31:17] bearND: I do not... I've just been looking thgouth them; not necessarily 'doing' anything with them. [21:31:25] *through [21:31:46] (03PS1) 10Mhurd: Update to wikiFont adding temp supplemental ios characters. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/134736 [21:31:55] bearND: because I saw you create https://bugzilla.wikimedia.org/show_bug.cgi?id=65539 .. so I though you were putting otrs bugs to bugzilla [21:32:32] bearND: I created the long title by typing some characters then repeating "select all - copy - paste - paste - paste" several times. [21:32:47] I guess it IS some "network" / http error [21:32:55] liangent: no, i wasn't transferring bugs from OTRS to bugzilla. I just happened to run into this issue myself when i tried to repro another bug you reported [21:33:04] (03Merged) 10jenkins-bot: QA: Add browser tests for Special:Uploads edge cases [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/133500 (owner: 10Jdlrobson) [21:33:04] 414 Request-URI Too Large [21:33:09] (03CR) 10Florianschmidtwelzow: "Yey!! it works :-) - but still 2 more things to fix up to make this mergeable!" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/134589 (https://bugzilla.wikimedia.org/58311) (owner: 10Florianschmidtwelzow) [21:33:44] bearND: this is about https://bugzilla.wikimedia.org/show_bug.cgi?id=65560 [21:34:07] liangent: yes, was about to bring that up. how long was the title? [21:34:35] I don't have an idea. I haven't even tried to count it [21:34:40] (03CR) 10Jdlrobson: "Sleep well! And thanks for all your help tackling this bug! Seriously you're almost at the finish line :D" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/134589 (https://bugzilla.wikimedia.org/58311) (owner: 10Florianschmidtwelzow) [21:34:59] as I said I repeated "select all - copy - paste - paste - paste" some times randomly [21:36:28] liangent: just noticed a new comment for this bug with 190 chars, and it worked [21:39:08] jgonera: did you figure out if the links/reference tooltips in VE would be easy to show? [21:39:23] kaity, they will not [21:39:36] they shouldn't be super hard [21:39:41] but they're not trivial [21:39:51] we got rid of them pretty well ;) [21:40:17] bearND: see my new comment there [21:42:25] liangent: ok, i'll create another page with a super long title [21:43:29] bearND: no you won't be actually "create" such a page [21:43:38] mediawiki has a limit of longest title of 255 bytes [21:44:19] liangent: yep, just ran into that. got "Bad title" [21:44:31] liangent: how did you do it? [21:44:56] liangent: or do you mean the page doesn't have to exist? [21:45:03] bearND: yeah [21:45:41] liangent: got it [21:54:48] liangent: i only get "page does not exist" though. this is why i assumed earlier the page has to exist. i now tried a title > 600 chars [21:55:23] bearND: try 6000 chars [21:57:29] jgonera: Any thoughts on https://gerrit.wikimedia.org/r/#/c/134473/ ? [21:57:31] (03PS2) 10Brion VIBBER: Work in progress: language marker button in doc area (not yet functional) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/134678 [21:58:17] (03PS2) 10Mhurd: Update to wikiFont adding temp supplemental ios characters. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/134736 [21:59:21] kaldari, I'll fix what you found but would keep directory structure in this one [21:59:50] I'll do that before going to bed, I'll spend a few more minutes trying to figure out that "global failure" in QUnit [22:01:35] bearND: got it? [22:04:47] liangent: no, i still get "This page does not exist." using 10k chars [22:06:11] bearND: huh it appears 4k is enough for me [22:06:29] bearND: does it still say "no results" for search? [22:07:16] and "this page does not exist" is shown after pressing "Go"? [22:08:01] liangent0: i'm going to try it again. before i was changing the code to modify the search text [22:12:47] meh [22:13:01] liangent0: got it now with 1000 chars [22:13:54] bearND: ah [22:14:22] liangent0: i mean i got the "Network error. Tap to try again.". When i press go I get thei page does not exist. the latter seems to be correct behavior [22:14:51] then try it with 6k chars :) [22:17:02] (03PS1) 10JGonera: Fix broken QUnit test for EditorApi [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/134744 [22:17:34] (03CR) 10Brion VIBBER: [C: 032 V: 032] Update to wikiFont adding temp supplemental ios characters. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/134736 (owner: 10Mhurd) [22:18:44] kaldari if you can merge https://gerrit.wikimedia.org/r/#/c/134732/ and https://gerrit.wikimedia.org/r/#/c/134744/ this will help me with jQuery update compatibility check [22:18:45] liangent0: what else do you expect with 6k chars? i already got the network error. [22:18:58] liangent0: {"info":"Prefix search request was longer longer than the maximum allowed length. (2304 > 255)","code":"request_too_long"} [22:19:13] Maryana: how goes sign off for https://trello.com/b/BW5L3PEn/mobile-app-sprint-31-main-article-browse-search ? [22:19:26] the android column is still beefy [22:19:37] bearND: tap Go then it says could not ... in body [22:20:19] (03CR) 10Kaldari: [C: 032] Fix NearbyApi test [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/134732 (owner: 10JGonera) [22:20:36] (03PS2) 10Brion VIBBER: Marked lang insertion point. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/134653 (owner: 10Mhurd) [22:20:45] (03PS3) 10Brion VIBBER: Work in progress: language marker button in doc area (not yet functional) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/134678 [22:20:54] (03Merged) 10jenkins-bot: Fix NearbyApi test [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/134732 (owner: 10JGonera) [22:21:26] kaldari, I'm also curious how that test passes on jenkins... [22:22:06] I suppose someone created Mediawiki:Test.css on the instance that runs it? [22:25:17] (03CR) 10Kaldari: [C: 032] Fix broken QUnit test for EditorApi [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/134744 (owner: 10JGonera) [22:25:28] jgonera: must have [22:25:32] merged now [22:25:38] thanks [22:25:55] (03Merged) 10jenkins-bot: Fix broken QUnit test for EditorApi [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/134744 (owner: 10JGonera) [22:27:04] liangent0: got a nice little stack trace now. it crashed ;( [22:27:26] bearND: bugzilla? [22:31:48] liangent0: https://bugzilla.wikimedia.org/show_bug.cgi?id=65610 [22:32:59] liangent0: i'm going to restrict the number of characters in the search field [22:33:04] (03PS3) 10JGonera: Move styles related to content to typography*.less [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/134473 [22:33:06] (03PS4) 10JGonera: Split content styles into separate modules [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/134474 [22:34:01] (03CR) 10JGonera: "Jon, we can change directory structure later, I'd not do it in this patch." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/134473 (owner: 10JGonera) [22:34:29] bearND: doesn't look like a pretty resolution.. but it should work [22:35:10] what's squareup? in backtrace [22:35:48] liangent0: well, the api doesn't allow more than 255 chars, so the client shouldn't even send more than that to the api [22:36:36] liangent0: squareup is the company that provides the event bus (otto) [22:37:30] for title search.. it's the case [22:37:47] if fulltext is implemented one day the length needs to be reconsidered again [22:40:07] liangent0: is there a higher limit for the number of chars in full text? [22:49:17] (03PS1) 10BearND: Restrict length of search input to 255 [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/134749 (https://bugzilla.wikimedia.org/65560) [22:49:28] liangent0: ^ [22:58:03] brion: should we share the mobile or desktop url? [22:58:24] mhurd: share the desktop url, it’ll get auto-detected as appropriate when people follow it [23:00:22] Maryana: can you pass me the mobile app analytics schema again ? [23:01:53] bearND: just got a point [23:02:10] Setting a limit of 255 chars is not enough [23:02:39] If the underlying system's limit is 255 bytes [23:03:02] awjr, kaldari, MaxSem, Maryana, going to bed, need anything? [23:03:10] nope [23:03:22] Some Unicode chars can take up to 4 bytes when utf8 encoded [23:03:22] nope jgonera, good night! [23:03:51] good night! [23:05:00] MaxSem: is the search limit in bytes? [23:05:14] in pages [23:05:35] title search, not full text [23:06:48] MaxSem: liangent0 and i are talking about https://bugzilla.wikimedia.org/show_bug.cgi?id=65560. when someone enters a very long text into the search field [23:06:55] (03PS1) 10Kaldari: Promoting mobile typography changes from beta to stable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/134759 [23:07:47] MaxSem: using opensearch api [23:08:10] tfinc: https://meta.wikimedia.org/wiki/Schema:MobileWikiAppEdit [23:09:24] MaxSem: then i get something like {"info":"Prefix search request was longer longer than the maximum allowed length. (2304 > 255)","code":"request_too_long"} [23:09:40] meh, just was looking for that message in logs [23:09:51] lemme ask teh search guys [23:10:37] actually, it's in PHP [23:10:44] bearND, 255 bytes [23:11:58] MaxSem: liangent0: thank you. will look for a better solution then [23:12:04] (03PS2) 10Kaldari: Promoting mobile typography changes from beta to stable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/134759 [23:13:52] bearND: dbrant|bbl brion am alive and back! [23:13:56] a little hypothermic [23:13:58] I think [23:14:09] \o/ [23:14:11] hehe [23:14:19] it’s what 17C? :) [23:16:38] YuviPanda: welcome back [23:17:12] brion: 12 [23:17:24] bbbrrrrr [23:17:36] (03PS3) 10Kaldari: Promoting mobile typography changes from beta to stable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/134759 [23:23:22] (03PS1) 10Mhurd: Hooked up basic share sheet. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/134765 [23:23:27] brion: ^ yay [23:24:26] woot [23:25:34] (03PS4) 10Brion VIBBER: Work in progress: language marker button in doc area [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/134678 [23:27:36] (03CR) 10Yuvipanda: [C: 04-1] "Crashes on opening:" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/134083 (https://bugzilla.wikimedia.org/64450) (owner: 10Dbrant) [23:28:40] ?? [23:28:44] (03PS2) 10Yuvipanda: Restrict length of search input to 255 [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/134749 (https://bugzilla.wikimedia.org/65560) (owner: 10BearND) [23:28:46] (03CR) 10Yuvipanda: [C: 032] Restrict length of search input to 255 [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/134749 (https://bugzilla.wikimedia.org/65560) (owner: 10BearND) [23:29:00] dbrant|bbl: yeah, it crashes on opening with that stacktrace [23:29:03] dbrant|bbl: N4 Kitkat [23:29:06] (03Merged) 10jenkins-bot: Restrict length of search input to 255 [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/134749 (https://bugzilla.wikimedia.org/65560) (owner: 10BearND) [23:29:14] [sigh] [23:31:15] (03CR) 10Brion VIBBER: [C: 032 V: 032] "\o/" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/134765 (owner: 10Mhurd) [23:31:40] (03PS3) 10Brion VIBBER: Marked lang insertion point. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/134653 (owner: 10Mhurd) [23:32:23] (03PS5) 10Brion VIBBER: Work in progress: language marker button in doc area [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/134678 [23:36:26] (03PS6) 10Brion VIBBER: Work in progress: language marker button in doc area [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/134678 [23:48:06] mhurd: https://gerrit.wikimedia.org/r/#/c/134678/ [23:48:46] brion: reminder about "Thinking about the next hire for the iOS team" [23:48:58] tfinc: it’s half-drafted in my queue :D [23:49:04] brion: thank you [23:49:15] tfinc: I responded to your PM, also emailed you in case it didn't make it [23:49:21] YuviPanda: i saw. thanks [23:49:27] tfinc: :) [23:54:35] (03PS10) 10Dbrant: Keep only a limited number of WebViews in memory. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/134083 (https://bugzilla.wikimedia.org/64450) [23:55:08] (03PS11) 10Dbrant: Keep only a limited number of WebViews in memory. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/134083 (https://bugzilla.wikimedia.org/64450) [23:55:43] * dbrant wipes off sweat [23:55:56] dbrant: woo! :) checking out now [23:56:02] dbrant: it's a fairly hard problem, I think [23:56:21] YuviPanda: no idea why it crashed for you... but I removed that code anyway. [23:58:54] anyone seen DanG? that android column is still beefy [23:58:59] Maryana: ---^ [23:59:18] i think he's signed out for the day (he's in ohio, which i guess is central/eastern time?)