[00:01:12] Maryana: i don't see any sign off from him today [00:01:26] tfinc: he was doing User Testing, I think? [00:01:30] i guess he didn't get to it. i'm sure he'll do it tomorrow [00:01:34] he emailed mobile-l [00:01:45] Maryana: can you check in with him tomorrow to see if he needs anything to do it ? [00:01:58] i think all he needs is free time :) [00:03:12] (03PS7) 10Brion VIBBER: Work in progress: language marker button in doc area [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/134678 [00:04:08] Maryana: any update on design wireframes for Android? would be nice to have a wip look before priori meeting [00:04:19] (03CR) 10Brion VIBBER: [C: 032 V: 032] Marked lang insertion point. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/134653 (owner: 10Mhurd) [00:04:26] YuviPanda: yep, moiz is working on it [00:04:32] i saw on his screen [00:04:51] YuviPanda: Yep [00:04:51] im working on it [00:04:51] jinx [00:04:53] i'll post something soon on trello [00:05:02] moizsyed: coool :) [00:05:19] (03CR) 10Brion VIBBER: [C: 032 V: 032] "Note: we may swap the HTML chunk out for a native widget, as the styling & events are a bit funky per discussion with monte. But this most" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/134678 (owner: 10Brion VIBBER) [00:08:39] YuviPanda: Maryana: check https://trello.com/c/k8hwTl3l/4-stub-android-nav-tweaks [00:10:04] moizsyed: sweet :) [00:10:27] moizsyed: the version number will be there just for the alphas. We will move them into an about screen at some point. [00:10:30] moizsyed: overall looks solid :) [00:10:41] moizsyed: and much less invasive than iOS. [00:13:52] YuviPanda: you're welcome ;) [00:14:00] moizsyed: thank you :P [00:15:22] dbrant: woo, seems to work pretty nice! Haven't looked at the code yet. Also unsure if it just works really well or because of dynamic memory management I'm not losing any fragments [00:15:50] dbrant: either way, I clicked through 50-60 pages, and didn't run into any issues [00:22:46] (03PS1) 10Kaldari: Fixing thumbnail sizing in search overlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/134770 (https://bugzilla.wikimedia.org/65347) [00:27:13] (03PS2) 10Kaldari: Fixing thumbnail sizing in search overlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/134770 (https://bugzilla.wikimedia.org/65347) [00:34:45] am off [00:34:46] night folks [00:38:27] (03PS3) 10Kaldari: Fixing thumbnail sizing in search overlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/134770 (https://bugzilla.wikimedia.org/65347) [00:51:38] [13wikimedia-mobile] 15tstarling pushed 2 new commits to 06master: 02http://git.io/bBylkQ [00:51:38] 13wikimedia-mobile/06master 1477d6f14 15Lopez Hugo: doc:README minor fix : date of rush was 2010. [00:51:38] 13wikimedia-mobile/06master 147f8dada 15Tim Starling: Merge pull request #4 from hugolpz/patch-1... [00:53:21] (03PS1) 10Mhurd: Fix for search term highlighting font size and TOC updates. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/134775 [01:25:49] (03PS12) 10Dbrant: Keep only a limited number of WebViews in memory. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/134083 (https://bugzilla.wikimedia.org/64450) [01:26:13] (03PS13) 10Dbrant: Keep only a limited number of WebViews in memory. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/134083 (https://bugzilla.wikimedia.org/64450) [03:38:45] (03PS1) 10Dr0ptp4kt: Run curl before CasperJS, have disk usage check home dir. [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/134778 [03:40:22] (03CR) 10Dr0ptp4kt: [C: 032] Run curl before CasperJS, have disk usage check home dir. [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/134778 (owner: 10Dr0ptp4kt) [03:40:31] (03Merged) 10jenkins-bot: Run curl before CasperJS, have disk usage check home dir. [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/134778 (owner: 10Dr0ptp4kt) [03:43:23] (03CR) 10Mattflaschen: "Thanks for clarifying. Expiration for non-cookie backends is not implemented here in this version (yet), right?" (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/131897 (owner: 10Kaldari) [05:56:05] (03PS4) 10Florianschmidtwelzow: Implement upload via "Add image" on New file pages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/134589 (https://bugzilla.wikimedia.org/58311) [05:57:16] (03CR) 10Florianschmidtwelzow: Implement upload via "Add image" on New file pages (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/134589 (https://bugzilla.wikimedia.org/58311) (owner: 10Florianschmidtwelzow) [08:17:25] (03CR) 10Jdlrobson: [C: 032] "Bingo! :)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/134589 (https://bugzilla.wikimedia.org/58311) (owner: 10Florianschmidtwelzow) [08:18:01] (03Merged) 10jenkins-bot: Implement upload via "Add image" on New file pages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/134589 (https://bugzilla.wikimedia.org/58311) (owner: 10Florianschmidtwelzow) [08:19:41] (03CR) 10Jdlrobson: [C: 032] "As long as we do fix this mess - it's never clear when something goes into common and when it goes into typography..." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/134473 (owner: 10JGonera) [08:20:14] (03Merged) 10jenkins-bot: Move styles related to content to typography*.less [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/134473 (owner: 10JGonera) [08:23:40] (03CR) 10Jdlrobson: [C: 032] Split content styles into separate modules [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/134474 (owner: 10JGonera) [08:24:13] (03Merged) 10jenkins-bot: Split content styles into separate modules [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/134474 (owner: 10JGonera) [08:25:14] (03CR) 10Jdlrobson: "Mm.. merging https://gerrit.wikimedia.org/r/134629 would have saved you the hassle and us the duplicate work...." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/134759 (owner: 10Kaldari) [08:29:57] (03CR) 10Jdlrobson: "Opened https://bugzilla.wikimedia.org/show_bug.cgi?id=65622" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/134474 (owner: 10JGonera) [08:32:19] (03PS4) 10Jdlrobson: Promoting mobile typography changes from beta to stable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/134759 (owner: 10Kaldari) [08:32:30] (03CR) 10jenkins-bot: [V: 04-1] Promoting mobile typography changes from beta to stable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/134759 (owner: 10Kaldari) [08:35:40] (03CR) 10Jdlrobson: [C: 04-1] "I rebased off my table of contents patch which also has some browser tests." (034 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/134759 (owner: 10Kaldari) [08:36:02] (03PS2) 10Jdlrobson: Add clicktracking to table of contents [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/134628 [08:36:06] (03PS2) 10Jdlrobson: Push table of contents to stable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/134629 [08:36:11] (03PS2) 10Jdlrobson: Open sections by default on tablets [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/134630 [08:40:07] (03CR) 10Jdlrobson: [C: 031] Fixing thumbnail sizing in search overlay (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/134770 (https://bugzilla.wikimedia.org/65347) (owner: 10Kaldari) [11:39:57] YuviPanda|zzz: still zzz ing? [11:52:28] (03PS1) 10Jdlrobson: QA: Fix broken browser tests [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/134805 [13:07:21] (03PS1) 10Jdlrobson: Enable expanding of section headings via space and enter keys [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/134814 [14:00:42] Krinkle: are you around? [14:03:48] 3MobileFrontend / 3Feature requests: Option labels on the mobile preferences page can be too long - 10https://bugzilla.wikimedia.org/61114#c8 (10Jon) Maryana is this something we can explore soon? Bug has been open for some time. [14:08:21] 3MobileFrontend / 3alpha: Ajax page loading - Uncaught TypeError: Cannot read property 'indexOf' of undefined - 10https://bugzilla.wikimedia.org/65631 (10Jon) 3NEW p:3Unprio s:3normal a:3None I see this when navigating around in alpha: Uncaught TypeError: Cannot read property 'indexOf' of undefined... [14:09:48] 3MobileFrontend / 3alpha: Ajax page loading - Uncaught TypeError: Cannot read property 'indexOf' of undefined - 10https://bugzilla.wikimedia.org/65631#c1 (10Jon) Seems related to protected pages e.g. https://en.m.wikipedia.org/w/api.php?action=mobileview&format=json&page=San+Francisco&variant=en&redirect=yes... [14:10:33] 3MobileFrontend / 3alpha: Ajax page loading - Uncaught TypeError: Cannot read property 'indexOf' of undefined - 10https://bugzilla.wikimedia.org/65631#c2 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/EeSR9JSQ [14:10:49] 3MobileFrontend / 3alpha: Last modified breaks on back button when lazy loading pages - 10https://bugzilla.wikimedia.org/65633 (10Jon) 3NEW p:3Unprio s:3normal a:3None Click a link, click another link, click a third Click back The page has no last modified bar. [14:11:47] 3MobileFrontend / 3beta: Pages are sometimes not fully loaded in alpha when using back/forward - 10https://bugzilla.wikimedia.org/59735 (10Jon) 5NEW>3RES/WOR [14:12:18] 3MobileFrontend / 3alpha: Non-canonical URLs get rewritten into weird psuedo-canonical URLs in alpha - 10https://bugzilla.wikimedia.org/65327#c3 (10Jon) thoughts kaldari..? [14:15:33] 3MobileFrontend / 3alpha: Last modified breaks on back button when lazy loading pages - 10https://bugzilla.wikimedia.org/65633#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/9OmgKBjY [14:38:33] (03CR) 10Cmcmahon: [C: 032] QA: Fix broken browser tests [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/134805 (owner: 10Jdlrobson) [14:39:12] (03Merged) 10jenkins-bot: QA: Fix broken browser tests [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/134805 (owner: 10Jdlrobson) [15:14:53] (03PS1) 10Jdlrobson: Don't stretch the image in the media viewer [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/134830 (https://bugzilla.wikimedia.org/63553) [15:50:03] 3Wikipedia App / 3Generic: Tapping edit soon after the activity is recreated crashes the app - 10https://bugzilla.wikimedia.org/65499 (10Dan Garry) 5PAT>3RES/FIX [15:50:48] 3Wikipedia App / 3Generic: Long-pressing "save" button (the floppy disk) shows an empty bubble - 10https://bugzilla.wikimedia.org/65463 (10Dan Garry) 5PAT>3RES/FIX [15:53:03] 3Wikipedia App / 3Generic: Switching languages crashed app - 10https://bugzilla.wikimedia.org/65539 (10Dan Garry) 5PAT>3RES/FIX [16:04:12] YuviPanda: I'm curious how it can cause a SIGSEGV if everything is written in java... [16:05:39] JVM bug? [16:06:12] liangent: what's this in reference to? [16:07:13] dbrant: in a build yuvi sent to me about "Potential fix for opening lots of pages crashing / slowing down the app" [16:08:53] dbrant: http://pastebin.com/VD951E2q [16:11:40] liangent: I see; I've been working on this set of issues for the last few days. It may not have been 'stable' as of the last build. The next build should clear it up. [16:12:44] liangent: But it's not unheard-of for Java code to cause an actual crash in native code :P [16:22:24] liangent: the bug you reported is probably unrelated to what dbrant was fixing, but I'm unsure. [16:22:41] liangent: dbrant I've had sigsegv before when something in the bridge has fucked up [16:29:04] (03PS1) 10Cmcmahon: QA: Test branch to be abandoned:wq [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/134842 [16:29:17] Krinkle, do I really have to use debug=true to see jQuery deprecation warnings? I can see "JQMIGRATE: Logging is active" even without debug=true [16:29:38] You do not need to use debug=true, who said that? [16:29:53] you did: http://lists.wikimedia.org/pipermail/wikitech-l/2014-May/076340.html [16:29:56] (03Abandoned) 10Cmcmahon: QA: Test branch to be abandoned:wq [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/134842 (owner: 10Cmcmahon) [16:30:19] last paragraph in Call to action [16:32:17] jgonera: It was changed from wmf3 to wmf4, I believe. [16:32:47] James_F, ok, yeah, I just added a bogus .live() call and I can see a warning without debug=true [16:33:03] * James_F nods. [16:38:39] jdlrobson: back [16:39:53] Deskana: re the pointing story, I'm not sure [16:40:01] Deskana: as in, not sure how you can sign off [16:40:22] Deskana: I could update the styling on the server, and it should update on your phone in one day, and you can use that [16:42:29] YuviPanda: have you got my mail? [16:42:46] jgonera: That was only for the first week when jQuery Migrate loaded alongside the old jQuery [16:42:56] Krinkle, I see [16:43:07] (we didn't want to load the new migrate on top of an old jquery, migrate is to polyfil old feaures on a new jquery) [16:43:13] YuviPanda: Sure, that works, but update it to something I'm definitely going to notice. ;) [16:43:21] YuviPanda: And reply to the thread with that information so that people know. :) [16:43:42] Deskana: on trello? [16:43:48] jgonera: https://gerrit.wikimedia.org/r/#/c/133477/ [16:44:02] Upgraded jQueyr and moved migrate to main scripts instead of debugScripts [16:44:39] jgonera: If we'd only load migrate in debug mode, a lot of stuff would be broken. [16:45:55] Deskana: if you check a page with a long title, spanning multiple lines, they will have terrible line spacing [16:45:59] Deskana: let me make a patch to fix that [16:46:33] Deskana: and then if you uninstall and re-install the app you should see the change in about a minute or so [16:51:12] makes sense Krinkle, that's why I was surprised by what I read in that email [16:51:35] man, it's been so long since I wrote any CSS, and now my em-sense is fucked up [16:56:15] jgonera: think you can merge https://gerrit.wikimedia.org/r/134850? Trivial fix, and am doing it so Deskana can sign off on a card. I'm working on a patch to just re-use MF styles right after that [16:57:17] jgonera: ty [16:57:29] Deskana: ping when you are ready to sign off on that, I can guide you through the steps [17:07:50] 3MobileFrontend / 3stable: Deprecation warnings in JS console - 10https://bugzilla.wikimedia.org/65643 (10Juliusz Gonera) 3NEW p:3Unprio s:3normal a:3None There are two warnings in JS console because of the way we extend mw.user: Use of "name" is deprecated. Use mw.user.getName instead. Use of "anon... [17:10:27] Deskana: quick note regarding this...: https://trello.com/c/kssLFGmJ [17:10:33] 3MobileFrontend / 3stable: Deprecation warnings in JS console - 10https://bugzilla.wikimedia.org/65643#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/BxpqQtzw [17:10:38] Deskana: There's not really any way to hide the keyboard "before" the drawer animation begins. The animation of the keyboard suspends all other animations in the UI; that's why it looks jittery. [17:11:33] 3MobileFrontend / 3alpha: Non-canonical URLs get rewritten into weird psuedo-canonical URLs in alpha - 10https://bugzilla.wikimedia.org/65327#c4 (10Ryan Kaldari) Yes, let's just drop the title parameter if possible. [17:11:33] Deskana: the only way to make it behave smoothly would be to hide the keyboard after the drawer animation is done. [17:24:16] dbrant: Right. We can worry about that later anyway, I think it's better than it was. :) [17:24:27] dbrant: We have bigger fish to fry! :) [17:24:44] Deskana: quite! [17:25:07] YuviPanda: Trello makes sense, yeah. [17:31:21] Deskana: want to do that sign off now? [17:31:28] Sure. Let me grab my tablet. [17:31:52] Deskana: bah, give me a bit. it didn't get merged fully [17:32:00] READY WHEN YOU ARE! [17:32:13] Deskana: OK! [17:32:16] HELLO MY NAME IS CAPS LOCK I AM HERE TO TELL YOU ABOUT OUR ONE TRUE LORD ANDROID [17:32:59] Deskana: SHIFT FOR EVER [17:33:55] jgonera: MobileApp has no jenkins yet so we have to V+2 manually. just did that [17:36:34] Deskana: alright, it is time :) [17:36:46] READY [17:36:46] Deskana: open a page that has longish title? one that'll span multiple lines? [17:36:56] Deskana: might be harder on a n7, actually. but shouldn't be *too* hard... [17:37:31] I remember one. [17:37:44] "Another Demonstration..." [17:38:00] https://en.wikipedia.org/wiki/Another_Demonstration_of_the_Cliff-Guibert_Fire_Hose_Reel,_Showing_a_Young_Girl_Coming_from_an_Office,_Detaching_Hose,_Running_with_It_60_Feet,_and_Playing_a_Stream,_All_Inside_of_30_Seconds [17:38:24] What next? [17:38:52] Deskana: do you see that the line spacing for the page title is fucked up? [17:38:53] too much? [17:39:06] Yeah, it's pretty big. There's more space between the lines than the lines themself occupy. [17:39:17] The title occupies half of my screen. [17:39:39] Deskana: yeah :) [17:39:49] Deskana: so, uninstall the app and re-install. The other option is to just wait a day, but this is faster :) [17:39:56] now I've got to watch that movie. [17:40:03] haha [17:40:10] We should have a WMF movie night. [17:40:12] And what that. [17:40:14] *watch [17:40:18] also Sharknado [17:40:22] EVERYONE SHOULD WATCH SHARKNADO [17:40:27] * Deskana reinstalls. [17:41:42] YuviPanda: Now it takes a third of the page. The spacing has decreased. [17:41:55] * Deskana understands now. [17:41:57] Deskana: indeed. so the page style has changed without updating the APK [17:42:05] Deskana: QED! :P [17:42:09] :D [17:42:11] Quite Enough Done. [17:42:36] Deskana: yeah, this is super awesome since it means page styling doesn't block app release [17:43:27] Deskana: you should respond on the mail thread / trello about this :) Since you now know how to sign off... [17:44:02] Deskana: re: the history clearing thing, I don't know how to sign off on that. [17:44:17] Signed off. [17:44:20] Deskana: you *could* set your phone's time back to more than 30 days and do stuff, and change it back [17:44:30] Deskana: and it should still be there with the latest app, but 'gone' with the older version [17:44:38] Deskana: YuviPanda: i verified that by changing the date on my android device [17:44:39] Did that code trigger whenever you looked at your history? [17:44:47] yeah [17:44:53] Deskana: nope, it triggers when you start the app. [17:44:57] just made sure that it didn't delete the history entries [17:45:01] Oh, okay, if bearND's signed off on it then we can go with that. [17:45:09] Deskana: woo! [17:45:52] i basically changed the date manually 30+ days in advance [17:45:59] bearND: have you checked out OTRS yet? [17:46:07] YuviPanda: yes [17:46:27] YuviPanda: was wondering what the process is of getting them to bugzilla [17:46:32] bearND: manually :D [17:46:44] bearND: just open up a bug and copy paste the stack trace, without mentioning any personal details [17:46:52] Router restart incoming for me. [17:46:52] bearND: https://ticket.wikimedia.org/otrs/index.pl?Action=AgentZoom&TicketID=7564292 should be something easy to fix, for exmaple [17:46:55] Be back soon! [17:47:55] bearND: can you poke dbrant to take a look at https://gerrit.wikimedia.org/r/#/c/134297/? I'm looking at the webviews patch [17:48:06] * MaxSem pokes YuviPanda  [17:48:32] what's up, MaxSem [17:48:33] YuviPanda: will do [17:48:42] YuviPanda: bearND: I'll check it out [17:49:04] dbrant: :) [17:49:10] YuviPanda, while I'm at it, what other page props the app might need besides __NOEDITSECTION__ ? [17:49:26] MaxSem: good question. Is there a list of pageprops I can look at? [17:49:38] ehhhhh [17:50:26] I'm going to login to one of the slaves and look at 'em [17:50:30] oh wait [17:50:32] that's kinda hard [17:50:33] hmm [17:51:08] actually not [17:51:11] also, don't run slow queries in prod;) [17:51:29] MaxSem: :P Going to run them on labsdb [17:53:04] MaxSem: disambiguation, and is wikibase_item the Q id of the page on wikidata? [17:53:17] Maryana: pass me the schemas for the app again please [17:53:20] MaxSem: yup, it is. [17:53:30] MaxSem: so yeah, disambiguation and wikibase_item please. [17:54:01] tfinc: https://meta.wikimedia.org/wiki/Schema:MobileWikiAppEdit [17:54:16] Deskana: thanks for moving on those sign offs [17:54:19] MaxSem: hmm, disambiguation is just empty all the time? [17:54:30] yep [17:54:35] MaxSem: so it isn't used? [17:54:42] MaxSem: or is the mere presence of it what is counted? [17:54:50] the latter [17:54:54] MaxSem: ah, cool. [17:55:01] thanks [17:55:02] MaxSem: yeah, having that be a prop that returns boolean would be nice [17:55:04] tfinc: :) [17:55:29] Maryana: Deskana I should make a page with all the instrumentation we are doing. We are up to 5 now, I think [17:56:03] YuviPanda: That'd be very helpful. [17:56:08] * Deskana sets a page on mediawiki.org up. [17:56:28] Deskana: Special:PrefixIndex/Schema:MobileWikiApp should give you all of 'em [17:56:43] Deskana: we can potentially even just transclude that list [17:56:43] * Deskana looks. [17:57:00] That page is empty. [17:57:40] YuviPanda: Any hints? [17:57:45] https://www.mediawiki.org/w/index.php?title=Special:PrefixIndex/Schema:MobileWikiApp [17:59:44] Deskana: https://meta.wikimedia.org/w/index.php?title=Special%3APrefixIndex&prefix=MobileWikiApp&namespace=470 [18:00:12] YuviPanda, https://gist.github.com/MaxSem/25fbfbcc61b263631064 [18:00:48] MaxSem: I ran select distinct pp_propname from page_props limit 50; [18:00:55] MaxSem: very fast and quite useful :D [18:01:15] MaxSem: and since it gave me only 21, I am sure that's all of them [18:10:02] Maryana, awjr is it OK if I'm not present at standup tomorrow? a friend has a BBQ birthday party that starts at 5-6pm my time (8-9am) [18:11:26] (03PS1) 10MaxSem: Reduce page_props usage [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/134858 [18:18:26] (03PS2) 10Mhurd: Fix for search term highlighting font size and TOC updates. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/134775 [18:19:39] Fatal error: Cannot use object of type stdClass as array in /usr/local/apache/common-local/php-1.24wmf5/extensions/MobileFrontend/includes/MobileFrontend.hooks.php on line 299 [18:19:42] MaxSem: ^^ [18:19:51] There's quite a few of them [18:19:55] Reedy, that's a core bug [18:19:56] PING ALL OF THE MOBILE [18:20:04] * MaxSem bites Reedy  [18:20:31] JUST DON'T PASS ME AN OBJECT INSTEAD OF ARRAY [18:22:26] (03CR) 10JGonera: [C: 04-1] "Inline." (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/134770 (https://bugzilla.wikimedia.org/65347) (owner: 10Kaldari) [18:24:09] (03CR) 10JGonera: [C: 032] Don't stretch the image in the media viewer [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/134830 (https://bugzilla.wikimedia.org/63553) (owner: 10Jdlrobson) [18:24:44] (03Merged) 10jenkins-bot: Don't stretch the image in the media viewer [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/134830 (https://bugzilla.wikimedia.org/63553) (owner: 10Jdlrobson) [18:25:29] (03CR) 10JGonera: [C: 04-1] "Is this simply moving it to stable? If yes, please change commit message." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/134814 (owner: 10Jdlrobson) [18:27:28] (03PS3) 10JGonera: Open sections by default on tablets (beta to stable) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/134630 (owner: 10Jdlrobson) [18:27:34] (03CR) 10JGonera: [C: 032] Open sections by default on tablets (beta to stable) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/134630 (owner: 10Jdlrobson) [18:30:48] Reedy, if you take a look at http://git.wikimedia.org/blob/mediawiki%2Fcore.git/4be4a9648af8753854cbd17c50fa4176e288b731/includes%2Fspecialpage%2FSpecialPageFactory.php#L182 you'll see that core should really pass all SpecialPage_initList hook handlers an array [18:31:19] (03CR) 10JGonera: [C: 032] Push table of contents to stable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/134629 (owner: 10Jdlrobson) [18:31:20] furthermore, I don't quite understand how it manages to pass an array [18:33:55] is it lunch time yet? [18:34:44] preilly, I might have lunch soon [18:35:05] YuviPanda: i had to clear my history on this machine. pass me a link to wmflabs hatjitsu [18:35:18] tfinc: http://hatjitsu.wmflabs.org/ [18:36:07] MaxSem: want to grab something in the neighborhood at like Noon? [18:36:15] sure [18:37:24] kaldari, did you get my email about dbrant's and bearND's onboarding? [18:37:32] MaxSem: feel free to invite anybody else that’s in the office… [18:37:50] Maryana, awjr you there? [18:38:01] yeah, what's up? [18:38:18] Maryana, awjr is it OK if I'm not present at standup tomorrow? a friend has a BBQ birthday party that starts at 5-6pm my time (8-9am) [18:38:36] jgonera: in an interview [18:39:01] brion: bearND: YuviPanda dbrant mhurd http://hatjitsu.wmflabs.org/79898 [18:39:01] jgonera: I think I missed it [18:39:03] fine by me, just send in your notes :) [18:39:09] sure [18:39:17] kaldari, just resent it [18:40:31] jgonera: thanks, replied [18:46:14] (03CR) 10JGonera: [C: 04-1] "Minor thing." (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/134628 (owner: 10Jdlrobson) [18:46:23] (03CR) 10Kaldari: Fixing thumbnail sizing in search overlay (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/134770 (https://bugzilla.wikimedia.org/65347) (owner: 10Kaldari) [18:47:03] dbrant: http://hatjitsu.wmflabs.org/79898 same link [18:48:42] (03CR) 10JGonera: Add clicktracking to table of contents (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/134628 (owner: 10Jdlrobson) [18:55:04] (03CR) 10Kaldari: Promoting mobile typography changes from beta to stable (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/134759 (owner: 10Kaldari) [18:56:39] preilly, I'm about to go out, where do we meet? [18:58:10] MaxSem: I still need a little bit to finish something [18:58:20] 3Wikipedia App / 3Settings: Send Feedback no longer works - 10https://bugzilla.wikimedia.org/65651 (10dr0ptp4kt) 3NEW p:3Unprio s:3normal a:3None The Send Feedback button off the W menu seems now to not be working on Testflight build #16. [18:58:28] sure, ping me [18:58:39] MaxSem: Okay like 10 minutes tops [19:05:16] jgonera: hmm, so we have to embed all images with the app css, and not have to fetch them remotely. [19:06:33] jgonera: thoughts on adding @embed to the external link image? [19:08:44] MaxSem: I can meet you in front of Wiki in 5 minutes [19:08:52] preilly, whee [19:09:00] bearND: this is working on my devices - https://gerrit.wikimedia.org/r/#/c/134297/2 Shall I +2, or did YuviPanda want to test further on his N4? [19:11:35] YuviPanda, should be fine if it's just in one place in CSS [19:11:47] dbrant: do merge if it wfy :) [19:11:47] jgonera: let me put up a patch? [19:11:52] in fact I think there's a bug saying that all images should be embedded [19:11:55] YuviPanda, sure [19:12:06] gotta go though, will check it tomorrow [19:12:47] (03CR) 10Dbrant: [C: 032] Clear "Network error. Tap to try again." bar [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/134297 (https://bugzilla.wikimedia.org/64773) (owner: 10BearND) [19:12:51] jgonera: sweet [19:12:57] dbrant: u tested on an N4 as well? [19:13:21] bearND: nope [19:14:13] bearND: I don't have any kitkat devices [19:15:10] dbrant: that's ok, just wondering [19:28:56] dbrant: I've so far been unable to get the app to freeze up, so yay :) [19:29:04] dbrant: does scroll position work with this patch as well? [19:29:19] dbrant: since I've not run into a 'start at top' page at all [19:30:44] YuviPanda: well I'm using a FragmentAdapter that automatically saves the state of the fragment when it's destroyed. So when you go back, it simply restores the state, which already contains the scroll position. [19:31:03] dbrant: hmm, haven't fully looked at the code yet. [19:31:13] dbrant: so this doesn't actually do a network request, but just re-uses Page [19:31:14] ? [19:31:42] am reading through the code now [19:31:56] awjr: waiting on you in the hangout [19:32:36] tfinc: yep joining no [19:32:37] w [19:34:31] YuviPanda: hang on, I lied a bit; when a fragment is destroyed by being too deep in the back-stack, it saves the state, but only the Title and Scroll position (not the full Page). So there will be a network request. [19:35:04] dbrant: ah, right. that's good enough. And when does it do the network request? [19:35:37] (03PS1) 10Yuvipanda: Move content images to content folder [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/134871 [19:35:54] MaxSem: kaldari ^ might want to merge this soon, since otherwise it'll break external link icons on Mobile [19:37:28] YuviPanda: when the fragment gets re-created. That's managed by the ViewPager at that point. [19:37:40] dbrant: hmm, so I guess it'll re-create when you are 'close by' [19:37:53] dbrant: IIRC you can set how many fragments you want it to keep and it'll recreate them [19:38:10] cool, we're doing it dynamically [19:38:47] awjr: ^^ (re: potential MobileFrontend breakage) [19:39:06] YuviPanda: right. So I suppose there will probably be network requests from fragments that are still 'hidden'... [19:39:17] YuviPanda: but this will ensure a smooth "back" experience [19:39:29] YuviPanda: cant look closely now; talk to MaxSem perhaps? [19:39:44] awjr: yeah, already pinged MaxSem and kaldari. Just flagging you as well, for completeness [19:39:53] thanks :) [19:42:35] dbrant: the backgroundRemoving on observable webview is causing issues in the preview screen, where sometimes the content just overlays with the background [19:42:41] dbrant: liangent sent me a screenshot, let me forard [19:44:11] YuviPanda: we don't have to keep that code; we'll just need to decrease the number of simultaneous WebViews a bit more. [19:44:28] dbrant: we don't have to max out on 16, I think. Perhaps something even lower? [19:45:12] dbrant: 8? 4? if the only drawback there is that multiple 'fast' backs will be slightly jerky, I think that's alright. [19:46:11] YuviPanda: 8, then. I only saw the flicker issue on one of my devices, and it started at ~10 (without the background hack). [19:46:40] dbrant: hmm, right. I'm ok with 4 too, but 8 sounds good. getting rid of the background hack would be nice, yeah [19:48:26] dbrant: code looks good otherwise :) going to check now with don't keep activities turned on [19:48:50] dbrant: more docs on the SAVE_STATE_FULL, _TITLE, _NONE would be helpful, I think [19:50:18] YuviPanda: will add [19:50:42] dbrant: am leaving those as comments on Gerrit [19:50:42] dbrant: excited to get this merged :) [19:50:48] dbrant: we should do some profiling even after, though. [19:50:54] YuviPanda: yep! [19:52:02] (03CR) 10Yuvipanda: [C: 031] "Looks good! Minor points" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/134083 (https://bugzilla.wikimedia.org/64450) (owner: 10Dbrant) [19:54:53] (03PS1) 10Yuvipanda: Minor fixes to the html structure [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/134889 [19:55:00] bearND: wanna merge ^? [19:56:50] YuviPanda: sure [19:58:27] YuviPanda: may be an hour or so since i have a meeting soon, and finishing set up of my new box [19:58:32] bearND: sure [20:00:25] (03PS2) 10Yuvipanda: Minor fixes to the html structure [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/134889 [21:07:33] dr0ptp4kt: piong [21:21:33] (03PS3) 10Mhurd: Fix for search term highlighting font size and TOC updates. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/134775 [21:27:26] mhurd: yo [21:28:07] code looks good lemme do a quick test [21:28:15] ooh i wonder if the autohinting helps on the 3gs [21:28:35] brion: yeah i don’t have my device here so super curious :) [21:30:49] (03PS3) 10BearND: Minor fixes to the html structure [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/134889 (owner: 10Yuvipanda) [21:31:33] (03CR) 10BearND: [C: 032] Minor fixes to the html structure [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/134889 (owner: 10Yuvipanda) [21:31:52] (03Merged) 10jenkins-bot: Minor fixes to the html structure [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/134889 (owner: 10Yuvipanda) [21:32:53] seems about the same [21:32:56] ah well worth a check :D [21:33:18] brion: doh! will have to revisit later [21:35:10] brion: can i do a quick amend on that patch? [21:35:23] mhurd: go ahead [21:35:29] i was just about to merge it :D [21:35:35] brion: k one sec... [21:41:04] (03PS4) 10Mhurd: Fix for search term highlighting font size and TOC updates. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/134775 [21:41:08] brion: ^ [21:41:25] i had just noticed i’d shrunken the search results text size [21:44:29] heh [21:44:32] brion: i think i’ll cut another beta if that last amend looks ok to you [21:44:39] ok quick test... [21:44:45] (03PS14) 10Dbrant: Keep only a limited number of WebViews in memory. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/134083 (https://bugzilla.wikimedia.org/64450) [21:45:56] looks good [21:46:15] (03CR) 10Brion VIBBER: [C: 032 V: 032] Fix for search term highlighting font size and TOC updates. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/134775 (owner: 10Mhurd) [21:46:25] brion: woohoo thx! [21:46:34] \o/ :D [22:02:43] (03CR) 10Kaldari: Fixing thumbnail sizing in search overlay (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/134770 (https://bugzilla.wikimedia.org/65347) (owner: 10Kaldari) [22:05:15] (03CR) 10Kaldari: Fixing thumbnail sizing in search overlay (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/134770 (https://bugzilla.wikimedia.org/65347) (owner: 10Kaldari) [22:12:26] Maryana: oh i cut a new release [22:12:37] i saw :) will update [22:14:08] (03CR) 10Jdlrobson: Add clicktracking to table of contents (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/134628 (owner: 10Jdlrobson) [22:22:27] (03CR) 10Kaldari: "jgonera: You can compare the widths with a DOM inspector such as Firebug. The widths should be identical now. I also made the height match" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/134770 (https://bugzilla.wikimedia.org/65347) (owner: 10Kaldari) [23:27:05] (03PS5) 10Kaldari: Promoting mobile typography changes from beta to stable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/134759 [23:36:18] (03PS1) 10Mhurd: Added save button to share menu - hooked it up too. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/134974 [23:36:51] (03PS6) 10Kaldari: Promoting mobile typography changes from beta to stable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/134759 [23:48:05] (03CR) 10SG: "Updated your commentary concerns upstream. It should be more clear now." (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/131897 (owner: 10Kaldari) [23:58:45] moizsyed: do you have a second? [23:59:01] mhurd: sure [23:59:08] i’ll come over there [23:59:12] moizsyed: ^ [23:59:12] mhurd: ok