[00:03:45] Maryana: i’m tackling this story presently https://trello.com/c/6OUSUp5G/3-as-a-user-i-can-have-useful-items-in-the-left-nav-grouped-by-context-so-i-can-find-the-items-i-want-quickly-and-easily but i noticed we don’t seem to have estimated it… do you recall if we perhaps did but just didn’t record it? [00:12:11] (03PS2) 10Mhurd: Added save button to share menu - hooked it up too. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/134974 [00:26:45] (03PS1) 10Kaldari: Promoting mobile typography changes from beta to stable: Part 2 [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/134978 [00:54:38] (03PS15) 10Yuvipanda: Keep only a limited number of WebViews in memory. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/134083 (https://bugzilla.wikimedia.org/64450) (owner: 10Dbrant) [01:36:36] (03CR) 10Yuvipanda: [C: 032] "w00t!" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/134083 (https://bugzilla.wikimedia.org/64450) (owner: 10Dbrant) [01:36:53] (03Merged) 10jenkins-bot: Keep only a limited number of WebViews in memory. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/134083 (https://bugzilla.wikimedia.org/64450) (owner: 10Dbrant) [01:38:51] (03PS1) 10Yuvipanda: Bump version number for 2.0-alpha-2014-05-22 [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/134988 [01:40:58] (03CR) 10Yuvipanda: [C: 032] Bump version number for 2.0-alpha-2014-05-22 [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/134988 (owner: 10Yuvipanda) [01:41:03] Deskana: around? [01:41:11] YuviPanda: Yep. Sup? [01:41:13] (03Merged) 10jenkins-bot: Bump version number for 2.0-alpha-2014-05-22 [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/134988 (owner: 10Yuvipanda) [01:41:20] Deskana: just pushed out a release that kills the 'app freezes after opening a number of pages' bug [01:41:36] Deskana: I've stress tested it a bit, but would be nice if you can poke at it a while too :) [01:41:50] YuviPanda: Sure. [01:41:59] YuviPanda: How was the restaurant? :P [01:42:28] Deskana: it was quite good, actually! we left a 30% tip. The waitress also happened to be someone my girlfriend knew, so we got a 25% discount as well [01:43:17] Deskana: I also emailed you a build in case the update doesn't come through to you fast enough [01:43:42] 30%! That's amazingly good for the UK. [01:43:50] Good service in the UK calls for around an 8% tip. [01:44:02] I typically leave less than that. [01:44:04] Deskana: actually no, it was closer to 15%. my math sucks [01:44:15] Sorry, I mean, *excellent* service. [01:44:17] Deskana: we left 4pouds for a 23pound bill [01:44:20] *pounds [01:44:30] That's quite generous still. :) [01:44:35] What did you have? [01:44:44] Deskana: biryani, and she had rice + paneer tikka. [01:44:46] all around quite nice [01:45:03] Deskana: ok, am going to go off now. will talk about restaurant more tomorrow! :) [01:45:14] Night! [01:45:16] Deskana: night! [01:45:33] Deskana: and do test the 'multiple pages open do not freeze app, and going back to them works as I think it should' thing as well :) [01:45:37] night [02:25:48] 3MobileFrontend / 3General/Unknown: Link is missing from the 'Create the page ...' text on the search result page - 10https://bugzilla.wikimedia.org/65640 (10Andre Klapper) s:5blocke>3normal [02:31:17] 3MobileFrontend / 3General/Unknown: Link is missing from the 'Create the page ...' text on the search result page - 10https://bugzilla.wikimedia.org/65640#c6 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/fZd8diDV [11:37:43] (03CR) 10Jdlrobson: "but it's not zero...?" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/134858 (owner: 10MaxSem) [12:02:51] (03CR) 10Jdlrobson: [C: 04-1] Promoting mobile typography changes from beta to stable: Part 2 (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/134978 (owner: 10Kaldari) [12:03:01] (03CR) 10Jdlrobson: [C: 04-1] Promoting mobile typography changes from beta to stable (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/134759 (owner: 10Kaldari) [12:03:41] (03CR) 10Jdlrobson: Promoting mobile typography changes from beta to stable (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/134759 (owner: 10Kaldari) [12:04:32] (03CR) 10Jdlrobson: Promoting mobile typography changes from beta to stable: Part 2 (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/134978 (owner: 10Kaldari) [12:06:39] (03PS2) 10Jdlrobson: Regression: Restore external links icons [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/134871 (owner: 10Yuvipanda) [12:07:01] (03CR) 10Jdlrobson: [C: 032] "Do we need a Lightning deploy for this? Yuvi can you check with Juliusz?" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/134871 (owner: 10Yuvipanda) [12:07:53] (03Merged) 10jenkins-bot: Regression: Restore external links icons [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/134871 (owner: 10Yuvipanda) [12:52:48] 3MobileFrontend / 3beta: Image viewer stretches small images. - 10https://bugzilla.wikimedia.org/63553 (10Jon) 5PAT>3RES/FIX [13:08:51] (03CR) 10JGonera: Add clicktracking to table of contents (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/134628 (owner: 10Jdlrobson) [13:24:18] 3MobileFrontend / 3General/Unknown: Link is missing from the 'Create the page ...' text on the search result page - 10https://bugzilla.wikimedia.org/65640#c7 (10Istvan Bujdoso) Thank you for the workaround. Unfortunately it's not working. If "Create the page" element isn't shown then how can I add new pages? [13:28:21] (03CR) 10JGonera: Promoting mobile typography changes from beta to stable: Part 2 (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/134978 (owner: 10Kaldari) [13:33:20] 3MobileFrontend / 3General/Unknown: Link is missing from the 'Create the page ...' text on the search result page - 10https://bugzilla.wikimedia.org/65640#c8 (10Florian) 5UNC>3NEW p:5Unprio>3Normal Yeah, like i said, i thought you have a local installation, where you edit MobileFrontend to show these... [13:41:16] (03PS3) 10Jdlrobson: Add clicktracking to table of contents [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/134628 [13:43:09] (03CR) 10Jdlrobson: Add clicktracking to table of contents (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/134628 (owner: 10Jdlrobson) [13:43:20] (03CR) 10Jdlrobson: Add clicktracking to table of contents (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/134628 (owner: 10Jdlrobson) [14:15:33] 3MobileFrontend / 3stable: Need to click twice in search overlay - 10https://bugzilla.wikimedia.org/65676#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/v11pdWWl [14:15:35] 3MobileFrontend / 3stable: Need to click twice in search overlay - 10https://bugzilla.wikimedia.org/65676 (10Juliusz Gonera) 3NEW p:3Unprio s:3normal a:3None Search for something on enwiki in desktop Chrome, click one of the results. Search overlay closes but I stay on the same page. When I repeat th... [14:17:33] 3MobileFrontend / 3stable: List of languages looks strange when mixes RTL and LTR languages - 10https://bugzilla.wikimedia.org/64617#c6 (10Juliusz Gonera) What are the steps or platform required to see this? A screenshot perhaps? [14:18:48] 3MobileFrontend / 3alpha: Cannot switch to VisualEditor after a reload - 10https://bugzilla.wikimedia.org/65506#c8 (10Juliusz Gonera) 5NEW>3RES/WOR I'm marking as workforsome, please raise another bug if there are problems with the spinner. [14:34:48] 3MobileFrontend / 3stable: List of languages looks strange when mixes RTL and LTR languages - 10https://bugzilla.wikimedia.org/64617#c7 (10Jon) Created attachment 15462 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15462&action=edit Arabic a RTL language, shown 2 from bottom is written in LTR [14:40:33] 3MobileFrontend / 3General/Unknown: indeterminate loader graphic should not be displayed when watchlisting or watchlisting - 10https://bugzilla.wikimedia.org/65599#c10 (10Juliusz Gonera) The star should keep spinning until it's watched/unwatched in my opinion. In my opinion, this is not a bug though, it stay... [14:47:33] 3MobileFrontend / 3General/Unknown: Link is missing from the 'Create the page ...' text on the search result page - 10https://bugzilla.wikimedia.org/65640#c9 (10Juliusz Gonera) The screenshot you attached shows a pretty old version of MobileFrontend. On English Wikipedia it looks like this: http://en.m.wikip... [14:50:33] 3MobileFrontend / 3alpha: Cannot switch to VisualEditor after a reload - 10https://bugzilla.wikimedia.org/65506#c9 (10Jon) 5RES/WOR>3REO It's not just the spinner - just sometimes it doesn't even start loading. I'm worried this indicates some bigger kind of problem. Let me attach some videos demonstratin... [14:52:03] 3MobileFrontend / 3alpha: Cannot switch to VisualEditor after a reload - 10https://bugzilla.wikimedia.org/65506#c10 (10Jon) Created attachment 15463 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15463&action=edit Delay between clicking button and seeing VE [14:53:03] 3MobileFrontend / 3alpha: Cannot switch to VisualEditor after a reload - 10https://bugzilla.wikimedia.org/65506#c11 (10Jon) Created attachment 15464 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15464&action=edit Double toolbar loading in VE [14:58:31] (03CR) 10JGonera: [C: 04-1] "Sorry, one thing I didn't notice earlier." (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/134628 (owner: 10Jdlrobson) [14:58:33] 3MobileFrontend / 3General/Unknown: Link is missing from the 'Create the page ...' text on the search result page - 10https://bugzilla.wikimedia.org/65640#c10 (10Florian) Now the question is: Is the reason to hide the "create link" link via css still present? The change: https://gerrit.wikimedia.org/r/#/c/76... [15:03:29] (03CR) 10Jdlrobson: Add clicktracking to table of contents (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/134628 (owner: 10Jdlrobson) [15:08:18] 3MobileFrontend / 3Feature requests: Link is missing from the 'Create the page ...' text on the search result page - 10https://bugzilla.wikimedia.org/65640#c11 (10Jon) If you look closely at the search page HTML the link is there it is just hidden via CSS with display none- it can be overriden by MediaWiki:M... [15:13:48] 3MobileFrontend / 3Feature requests: Link is missing from the 'Create the page ...' text on the search result page - 10https://bugzilla.wikimedia.org/65640#c12 (10Florian) @Jon: Maybe a new configuration variable? [15:14:23] (03CR) 10JGonera: [C: 04-1] Hygiene: Icon cleanup (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/133189 (owner: 10Jdlrobson) [15:19:07] (03PS7) 10Jdlrobson: Rewrite Nearby as a PageList [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/130270 [15:19:14] (03CR) 10jenkins-bot: [V: 04-1] Rewrite Nearby as a PageList [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/130270 (owner: 10Jdlrobson) [15:20:33] 3MobileFrontend / 3General/Unknown: Nearby pagelist missing border-top - 10https://bugzilla.wikimedia.org/65613#c2 (10Jon) Mmm.. the border is provided by having the content-header element above the page-list I'm not sure what is the best way to do this without creating a duplicate CSS rule or an empty cont... [15:20:59] (03PS8) 10Jdlrobson: Rewrite Nearby as a PageList [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/130270 [15:21:59] (03CR) 10Jdlrobson: Rewrite Nearby as a PageList (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/130270 (owner: 10Jdlrobson) [15:22:04] (03CR) 10jenkins-bot: [V: 04-1] Rewrite Nearby as a PageList [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/130270 (owner: 10Jdlrobson) [15:22:21] (03CR) 10JGonera: [C: 032] QA: Add non JavaScript site tests for search [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/126131 (owner: 10Jdlrobson) [15:23:03] 3MobileFrontend / 3Feature requests: Link is missing from the 'Create the page ...' text on the search result page - 10https://bugzilla.wikimedia.org/65640#c13 (10Jon) $wgMFNewPageCreation = false; maybe. At least than 3rd parties can toggle it on :) [15:23:07] (03Merged) 10jenkins-bot: QA: Add non JavaScript site tests for search [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/126131 (owner: 10Jdlrobson) [15:23:53] (03CR) 10JGonera: [C: 032] Stop EventLogging errors when switching from VisualEditor to Editor [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/134587 (https://bugzilla.wikimedia.org/65378) (owner: 10Jdlrobson) [15:24:24] jdlrobson, did you manage to get EL running locally? [15:24:26] (03Merged) 10jenkins-bot: Stop EventLogging errors when switching from VisualEditor to Editor [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/134587 (https://bugzilla.wikimedia.org/65378) (owner: 10Jdlrobson) [15:26:48] 3MobileFrontend / 3Feature requests: indeterminate loader graphic should not be displayed when watchlisting or watchlisting - 10https://bugzilla.wikimedia.org/65599 (10Jon) [15:28:03] 3MobileFrontend / 3alpha: EventLogging errors when switching from VisualEditor - 10https://bugzilla.wikimedia.org/65378 (10Jon) 5PAT>3RES/FIX [15:31:18] 3MobileFrontend / 3Feature requests: Link is missing from the 'Create the page ...' text on the search result page - 10https://bugzilla.wikimedia.org/65640#c14 (10Florian) Hmm, you would to toggle the create page link? Then the users have the problem, that the redlinks.js remove all links on page, including... [15:33:36] 3MobileFrontend / 3General/Unknown: Nearby pagelist missing border-top - 10https://bugzilla.wikimedia.org/65613#c3 (10Florian) Unhappily i was for the same problem and hoped someone other have a solution adhoc :D Maybe it's possible to add border-top class and add this class to the first element of nearby.... [15:49:31] jgonera: what do you mean? are you having issues with EventLogging? [15:49:57] I don't, but you wrote you had: https://gerrit.wikimedia.org/r/#/c/134527/ [15:51:51] OH, yeh I meant on vagrant [15:51:57] turned out i hadn't installed it ;-) [16:08:42] (03PS2) 10Jdlrobson: Enable expanding of section headings via space and enter keys in stable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/134814 [16:08:49] (03CR) 10Jdlrobson: "Done." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/134814 (owner: 10Jdlrobson) [16:27:01] (03PS1) 10Jdlrobson: Loading toggling css with JavaScript [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/135056 [16:28:53] 3MobileFrontend / 3stable: Need to click twice in search overlay - 10https://bugzilla.wikimedia.org/65676#c2 (10Jon) Yeh I think Arthur raised this issue a while ago and I occasionally see it. I can't work out why though :-/ [16:29:33] 3MobileFrontend / 3stable: Need to click twice in search overlay - 10https://bugzilla.wikimedia.org/65676#c3 (10Jon) It seems to be related to tap area. I've been able to produce it on my Chrome mobile and occasionally desktop chrome but never reliably. [16:31:48] 3MobileFrontend / 3beta: Last edit should only look in main namespace - 10https://bugzilla.wikimedia.org/57023#c7 (10Jon) 5NEW>3RES/WOR It says "Edited the page File:The new user profile page gives you a quick summary of the users edit history 2014-04-28 11-28.png, 24 days ago." which is good enough. Fe... [16:32:33] 3MobileFrontend / 3beta: Nearby scrolls the page even if it is not required - 10https://bugzilla.wikimedia.org/58482#c7 (10Jon) Is this still an issue now the Nearby beta feature was disabled? I suspect the new version will not have this issue. [16:32:33] 3MobileFrontend / 3beta: Nearby scrolls the page even if it is not required - 10https://bugzilla.wikimedia.org/58482 (10Jon) 5NEW>3UNC [16:33:48] 3MobileFrontend / 3General/Unknown: Editing not working without VE enabled - 10https://bugzilla.wikimedia.org/65509#c4 (10Jon) 5NEW>3RES/FIX Fixed by Ie1a853b634fe3ecc7e71e54a967e4b4795126f85 [16:40:16] (03PS1) 10BearND: Stabilize automated tests [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/135058 [16:43:09] (03PS1) 10BearND: Get tests to run on older devices. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/135059 [16:47:30] (03PS1) 10Dbrant: Fix edit/preview when activity is destroyed. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/135061 (https://bugzilla.wikimedia.org/65505) [16:56:55] (03CR) 10Brion VIBBER: [C: 032 V: 032] "Looks good, seems to work. :D On iOS 6.1 the 'cancel' button looks odd (black text over a darkish background) but that's not new in this " [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/134974 (owner: 10Mhurd) [17:16:07] brion: standup! [17:16:20] whee [17:19:05] 3Wikipedia App / 3Generic: Android: If you start the app after an update with no network access, it crashes! - 10https://bugzilla.wikimedia.org/65685 (10Dan Garry) 3NEW p:3Unprio s:3normal a:3None 1) Update the app (or force stop the app in settings) 2) Turn off your wifi and data connection (or ente... [17:22:35] 3Wikipedia App / 3Search: Android: If you search in the app with no network access, it crashes! - 10https://bugzilla.wikimedia.org/65686 (10Dan Garry) 3NEW p:3Unprio s:3normal a:3None 1) Open the app 2) Turn off wifi and data (or enter airplane mode) 3) Type in a query to the search bar, and you're p... [17:23:32] Maryana: Deskana ping? wanna talk a bit about the ugly baby (aka offline reading) [17:23:49] YuviPanda, Maryana: If we have time. [17:23:49] Deskana: also when it crashes you should follow the 'send crash report', which lands up in OTRS. very useful for debugging [17:24:13] Deskana: Maryana on IRC would be nice, I think, rather than the standup? [17:24:33] YuviPanda, Maryana: Sure, but I have another meeting after this. We can chat in 35 minutes, if that's alright. [17:24:43] YuviPanda: I'll reproduce the two crashes I just reported after my next meeting, and send the bug report this time. [17:24:52] Deskana: alright. [17:24:55] Deskana: ok! [17:30:33] 3Wikipedia App / 3Generic: [iOS] Search bar doesn't go away after article is selected - 10https://bugzilla.wikimedia.org/65623#c1 (10Dan Garry) 5NEW>3RES/FIX Tomasz says this is fixed. [17:31:41] YuviPanda: yeah, let's talk in half an hour :) [17:31:49] Maryana: alright. [17:31:56] brion: i’ll check that ios 6 dark cancel button now… [17:31:59] let me do some code review in the meantime [17:32:52] mhurd: spiff [17:34:21] brion: oh i see - that’s really dark! [17:35:20] brion: found what’s causing it [17:37:47] my facebook feed has been having more and more m. links recently... if this is indicative of the world in general, we really ought to rethink the whole m. subdomain concept... MaxSem? [17:37:49] (i will post about it to mobile-l if this discussion hasn't started yet [17:38:23] omgthinkofthechildren [17:39:28] MaxSem, think of the adults who post on FB using tablets :) [17:39:44] (03PS1) 10Mhurd: Fix for dark cancel button on sharing sheet. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/135066 [17:40:03] soon we will have a "share on Facebook" link on all WP pages :) [17:40:23] brion: ^ i did a quick audit of everywhere else a uibutton is used and this fix didn’t seem to mess any of those buttons up at all [17:40:29] * MaxSem burns yurik at stake [17:41:40] MaxSem was too late - the group of angry children got to yurik first... [17:43:03] in any case, is there an active discussion going on about it? The only real option IMO is to get rid of m. [17:55:49] Maryana, I started a flamewar on dynamic page views:P [17:56:22] i saw :) [17:56:24] it's not a flame war yet [17:56:29] it's only got 1 response [17:57:10] well, it will [17:57:12] be [17:57:23] killl all the features, yay! [18:00:47] Deskana: Maryana hangout being wonky, be there in a sec [18:01:02] I'm eating, I'll be there in a minute or two. [18:02:02] Deskana: ah, alright [18:47:22] (03PS1) 10MaxSem: Hygiene: rename scripts directory to dev-scripts [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/135083 [19:01:28] dbrant: can you take a look at bearnd's test patches? [19:01:47] YuviPanda: yeppers [19:17:50] (03CR) 10Dbrant: [C: 032] "all tests passing for me!" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/135058 (owner: 10BearND) [19:18:11] Deskana: ping! [19:18:21] YuviPanda: Heya. [19:18:50] Deskana: actually nevermind, I was gonna ping about https://trello.com/c/k7oQ2wLr/41-5-complete-page-styling-css-and-move-it-to-extension-mobileapp and then realized it isn't 'fully done', yet. [19:19:02] Deskana: however, have you looked at the page styling in the latest release? how bad does it seem? [19:19:23] I haven't yet because I kept getting the app to crash trying to sign off on things. :P [19:19:30] Which reminds me, I need to reproduce those crashes. [19:19:44] Deskana: oh yeah. forgot about that :) [19:19:46] Deskana: has it been crashy only recently? [19:19:53] Since the update, yeah. [19:20:13] Deskana: yeah, send in a crash report? [19:20:38] Will do. [19:20:40] * Deskana reproduces [19:20:53] Deskana: now you wait 9 months? :) [19:23:51] YuviPanda: Both bug reports sent. I included the bug number I was reproducing in each report, so you'd know which is which. [19:23:58] Deskana: cool [19:24:52] * dbrant takes a peek [19:25:04] dbrant: https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom&TicketID=7567284 [19:25:36] Is it just an uncaught exception? [19:25:55] isn't this the one I patched a couple days ago? [19:26:05] how recent is Deskana's build? [19:26:19] Well, I updated it this morning, then it crashed afterwards due to these bugs. :P [19:26:27] dbrant: APP_VERSION_NAME=2.0-alpha-2014-05-22 [19:26:32] so that was the latest one [19:27:34] YuviPanda: Erm, I think the styling is really broken. [19:27:42] YuviPanda: I can't see the title of this article because the search bar is in the way. [19:27:59] Deskana: screenshot? [19:28:00] Yep, I can't see article titles. :( [19:28:57] Deskana: that looks like the CSS is completely failing to load. Can you do an app re-install and see if the issues still persist? might be a bug in the downloader. [19:29:40] That may be related to me having wifi turned off shortly after I installed the app (which is what caused the crash) [19:29:57] Deskana: ah, right. that sounds like a very related bug. ugh [19:30:15] http://i.imgur.com/YRT0vDZ.png [19:30:19] Everything looks really... dense. [19:30:25] Deskana: yeah, definitely no CSS loading at all [19:30:29] Deskana: reinstall the app? [19:30:48] * Deskana reinstalls [19:30:56] (03CR) 10Brion VIBBER: [C: 032 V: 032] "Confirmed fixed on my iPod running 6.1, no obvious regression on iPhone 5s running 7.1. :D" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/135066 (owner: 10Mhurd) [19:31:26] Looks fine now. [19:31:38] So there's two issues with starting the app for the first time with data off [19:31:40] 1) It crashes [19:31:49] 2) It won't load CSS until the next sync [19:32:02] I'll file a bug for the second. [19:32:05] yeah [19:32:27] (2) is just us needing to be very careful to make sure that we did get a full CSS file before replacing the older ones [19:33:05] need to checksum or anything? [19:33:13] or just making sure no exceptions on the download :D [19:33:34] I dunno if we can do a proper checksum [19:33:58] YuviPanda: Well I can't reproduce the CSS not loading bug. [19:34:27] YuviPanda: I deleted the app again, downloaded it again, and started it with wifi off. It crashed as expected. But then when I turned wifi back on and started it, the CSS is fine. [19:35:34] https://trello.com/c/mUFaW1BT/64-undefined-in-preview doesn't work for me :( [19:36:28] Deskana: you'll need a newer build for that one [19:36:33] Oh, yeah, just noticed. [19:39:03] 3Wikipedia App / 3Generic: A very long title causes a false "network error" in search - 10https://bugzilla.wikimedia.org/65560 (10Dan Garry) 5PAT>3RES/FIX [19:39:18] 3Wikipedia App / 3Search: Android: "Network error. Tap to try again." bar is too persistent - 10https://bugzilla.wikimedia.org/64773 (10Dan Garry) 5PAT>3RES/FIX [19:39:30] dbrant: I'll wait for a new release. :) [19:41:30] damn, none of the mobile web devs are up now [19:42:16] YuviPanda, o rly? [19:42:59] MaxSem: as in, the folks I can ask css questions to :D [19:43:09] MaxSem: want to know where the origin font size is set for the mobile website. [19:43:52] you can ask me CSS questions too. I'll just reply that CSS sucks though [19:44:21] :D [19:48:09] dbrant: bearND btw, you can set up OTRS to notify you via email every time something comes into the mobile queue, if you haven't already [19:48:35] YuviPanda: yep, will do [19:51:20] MaxSem: app and web are now useing same styles, but I can't figure out why the font size is different [19:51:24] anyway, let me make a commit [19:52:44] YuviPanda: i just signed up for emails. is there a good way to mark tickets in ORTS as copied over to Bugzilla? [19:53:00] bearND: you can respond to the ticket saying 'now tracked at' and mark it as closed [19:53:17] YuviPanda: sounds good [19:54:35] Maryana: do you know if kaldari is in the office today? [19:54:41] YuviPanda: we should have a reply template for that [19:54:54] bearND: yeah, agreed. you can ask in #wikimedia-otrs for a new template to be added [19:55:21] YuviPanda: cool [19:56:22] (03PS1) 10Yuvipanda: Move more content styles out of common.less [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/135097 [19:56:53] MaxSem: ^ if you want to take a look :) [19:57:40] Deskana: Maryana also, we have nothing anywhere for reference display! [19:58:00] Wifi weirdness. Be right back. [19:58:45] (03PS1) 10Dbrant: Fix crash when loading page(s) with no network. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/135098 [19:58:53] awjr: do you know if kaldari or jgonera or jdlrobson will be available today? [19:59:13] YuviPanda: jon and juliusz are off for the day (they worked european hours) [19:59:18] YuviPanda: i expected kaldari to be in today [19:59:23] awjr: ah, ok [19:59:29] MaxSem: do you see kaldari around in the office? [19:59:59] dbrant: also, we don't actually need to make a separate request for that anymore, since that info is available on the action=mobileview call itself. probably something we should optimize out at some point [20:00:12] dbrant: when it was initially built that wasn't available, so we did this instead [20:00:19] YuviPanda: i see [20:00:22] dbrant: have you checked out en.wikipedia.org/wiki/Special:ApiSandbox? [20:00:50] YuviPanda: yes, but not nearly in-depth enough yet! [20:01:10] dbrant: play around with it a bit :) [20:03:53] bearND: I just noticed you're a member on this card - https://trello.com/c/MdlvA8Tg [20:04:21] bearND: I just submitted a patch that (I think) fixes it. I didn't realise there was a bug for that! sorry [20:04:34] I have returned. [20:04:47] Deskana: so, no card for reference display! clicking on a reference gives you a very shitty deal now [20:06:03] dbrant: np, i was just wondering about whether that was the same bug. just change the trello card to your name. i can CR [20:06:27] awjr: I guess the office has been swallowed by a big monster! :) [20:06:34] :p [20:06:38] max might be munching lunch [20:06:44] oh yeah [20:06:48] Maryana: yt? [20:07:07] I've been in 3 different timezones the last 3 weeks, plus my usual funky times, not good. [20:07:17] that sounds confusing :-| [20:07:27] yeah [20:07:28] it was [20:07:32] I did miss only one meeting tho [20:08:09] that's not so bad [20:08:20] awjr: yeah. and that too by only 15 min [20:08:33] awjr: UploadWizard found kaldari, is asking him to get on IRC [20:08:49] your internal chronometer must be pretty good :) [20:08:52] nice [20:09:05] yeah sometimes he forgets to log on :p [20:09:18] awjr: no, my internal chronometer has never really worked :D So not much there to fuck up [20:09:20] ... [20:09:21] lol [20:09:33] maybe that's the secret [20:09:37] just destroy the internal chronometer [20:10:09] awjr: yeah [20:10:11] hey kaldari! [20:10:18] howdy! [20:10:40] (03PS1) 10Yuvipanda: Embed the external link image [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/135102 [20:11:05] kaldari: first https://gerrit.wikimedia.org/r/#/c/135097/ and then a couple of questions about MobileFrontend CSS [20:11:05] YuviPanda: dbrant: what's this PageImage thing for? [20:11:20] bearND: it's for showing images that represent the page, either in search, or history, or bookmarks [20:11:30] looking [20:11:34] YuviPanda: ty [20:12:49] YuviPanda: I'm not sure we want to move the a rules or .nomobile as those apply outside the content area [20:13:38] is there a specific reason you want to move them? or just cleaning up? [20:14:15] kaldari: https://gerrit.wikimedia.org/r/135103 is the specific reason [20:14:29] kaldari: the apps will be re-using MF styles, with minor overrides. but don't want the chrome related selectors, just the content ones [20:14:38] kaldari: and a tags and .nomobile definitely are. [20:14:48] kaldari: also where does .nomobile apply outside of the content area? [20:15:39] YuviPanda: well it doesn't actually (as far as I know), but could potentially. For example, there are some APIs that load HTML outside the content area (Echo for example) that could use it in theory. [20:15:54] but it's an edge case [20:16:13] kaldari: right. and again, for MF there's no practical difference, and the primary use case is in content pages [20:16:19] true [20:16:30] kaldari: eventually I think Jon wanted to split up the CSS into individual components, which should make this problem go away [20:17:29] kaldari: so from MF's perspective, that patch is pretty much a no-op [20:18:00] moving .nomobile would actually be fine as a practical matter, but it doesn't really "belong" in content-only css, but that's a weak argument obviously :) [20:18:12] (03PS1) 10Brion VIBBER: RTL styling fix for language button [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/135104 [20:19:18] kaldari: yup :P I'd argue against using that in echo notifications, even :) Sounds like if that's the case they should be using different formatting or somesuch [20:19:28] kaldari: so... merge? :) The MobileApp patch can't be merged without this. [20:19:35] hmmm [20:20:45] YuviPanda: So what about the anchor styles? Those do get applied outside of content, in the footer for example. [20:21:15] kaldari: that is true. I can hack around them now by duplicating those in the app styles if you think that is cleaner, and re-include them when the files get split into components. [20:21:26] Maybe that's one that you should provide separately in the app css [20:21:30] (03CR) 10Dbrant: [C: 032] "works on 2.3!" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/135059 (owner: 10BearND) [20:21:33] Yeah, what you said :) [20:21:38] kaldari: yeah, let me remove that part [20:21:42] kaldari: gimme a second [20:22:09] kaldari: in the meantime, that patch had a dependent patch in MF :) [20:22:14] kaldari: about embedding an image. check? [20:22:19] kaldari: 1 line patch! [20:22:50] the external link one? [20:23:44] kaldari: yeah [20:23:47] (03PS2) 10Yuvipanda: Embed the external link image [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/135102 [20:23:47] kaldari: updated patch [20:23:49] (03PS2) 10Yuvipanda: Move more content styles out of common.less [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/135097 [20:23:57] (03CR) 10Kaldari: [C: 032] Embed the external link image [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/135102 (owner: 10Yuvipanda) [20:24:08] kaldari: moved a links back [20:25:00] (03PS2) 10BearND: Fix crash when loading page(s) with no network. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/135098 (owner: 10Dbrant) [20:25:12] (03CR) 10BearND: [C: 032] Fix crash when loading page(s) with no network. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/135098 (owner: 10Dbrant) [20:26:10] (03Merged) 10jenkins-bot: Fix crash when loading page(s) with no network. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/135098 (owner: 10Dbrant) [20:30:59] (03CR) 10Kaldari: [C: 032] Move more content styles out of common.less [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/135097 (owner: 10Yuvipanda) [20:31:04] kaldari: woot [20:31:32] YuviPanda: Anything else? [20:31:45] kaldari: yeah! [20:31:57] kaldari: so even with this style, the app font looks smaller than the web [20:32:24] kaldari: with the same styles and same html, but with just the content styles [20:32:32] (03Merged) 10jenkins-bot: Move more content styles out of common.less [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/135097 (owner: 10Yuvipanda) [20:32:45] kaldari: my em-fu is also very rusty, so is there some font-size specification that's used on MF but not on the content styles? [20:33:24] (03Merged) 10jenkins-bot: Embed the external link image [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/135102 (owner: 10Yuvipanda) [20:34:12] kaldari: also can you merge the mobile app patch? :) [20:35:41] YuviPanda: did you want to merge this one: https://gerrit.wikimedia.org/r/135061 [20:35:45] YuviPanda: (you moved it to sign-off in Trello) [20:36:02] dbrant: hmm, I thought I hit merge [20:36:53] (03PS2) 10Yuvipanda: Fix edit/preview when activity is destroyed. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/135061 (https://bugzilla.wikimedia.org/65505) (owner: 10Dbrant) [20:37:00] (03CR) 10Yuvipanda: [C: 032] Fix edit/preview when activity is destroyed. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/135061 (https://bugzilla.wikimedia.org/65505) (owner: 10Dbrant) [20:37:19] (03Merged) 10jenkins-bot: Fix edit/preview when activity is destroyed. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/135061 (https://bugzilla.wikimedia.org/65505) (owner: 10Dbrant) [20:37:53] alright! we're looking good [20:39:28] awjr: you rang? :) [20:40:30] YuviPanda: Sorry, stepped away for a bit... [20:40:34] hi Maryana :) issue resolved already ;) [20:40:34] lemme check... [20:40:48] heh, ok [20:41:54] awjr: BTW, second of those two pairs of VE/Mobile requests is merged; first waiting for Trevor. [20:42:19] YuviPanda: How do you define what 1em equals in the app? Most browsers set it to 16px. [20:42:53] pretty much all the MF styles are em based, so that will matter. [20:42:54] kaldari: it is set to 14px when I checked with inspector [20:43:08] YuviPanda: That might be the difference then. [20:43:15] kaldari: does it differ between browsers? [20:43:44] YuviPanda: Good question. I think 16px is pretty standard, but I'm not 100% sure [20:43:48] great James_F thanks! [20:44:09] lemme see... [20:44:50] kaldari: maybe MF should specify it? [20:46:15] YuviPanda: Well, the default pixel value of 1em is based on the default font size for the browser [20:46:30] which you can actually override in the prefs [20:46:37] ah, hmm [20:46:42] but I have no idea how you define that in the app [20:47:12] css? [20:47:14] we don't [20:47:19] so perhaps I should set it to 16px [20:48:01] so I guess I should set font-size: 16px; on html or body? [20:50:38] YuviPanda: Yeah, looks like all current desktop browsers set the default font size for the body to 16px. [20:51:34] I imagine body { font-size: 16px; } would do the trick [20:59:55] kaldari: yeah, let me do that [21:21:48] (03PS1) 10BearND: Fix crash using random and leaving app [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/135112 (https://bugzilla.wikimedia.org/65609) [21:23:03] (03CR) 10Kaldari: Promoting mobile typography changes from beta to stable (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/134759 (owner: 10Kaldari) [21:24:35] kaldari: hmm, weird. we have different fonts set for the app as well, so I guess that would be an issue too [21:25:02] ours are.. [21:25:02] @fontFamily: "Helvetica Neue", "Helvetica", "Nimbus Sans L", "Arial", "Liberation Sans", sans-serif; [21:25:03] @fontFamilyHeading: Georgia, serif; [21:25:18] although we need to change the header stack to match the new header stack in Vector [21:25:43] YuviPanda: And actually you guys could customize your stack per device [21:25:51] kaldari: yeah, we are. open sans on android [21:26:05] yeah, and no Helvetica Neue on android :) [21:26:08] yeah [21:26:30] kaldari: and open sans we embed [21:26:32] kaldari: in app! [21:26:45] Why Open Sans? [21:27:04] kaldari: May picked it. [21:27:24] kaldari: plus we can embed it, can't embed helvetica [21:28:02] Open Sans should be OK. It's basically a Helvetica clone, but not the best, although it has a huge character set. [21:28:25] kaldari: yeah. other option is Roboto [21:28:54] we *could* theoretically fuck around and give people comic sans :) [21:29:06] kaldari: web fonts have minimal perf impact here since we just ship them with the app [21:29:35] YuviPanda: Roboto is a better Helvetica clone, IMO. [21:29:47] but I'll trust May on it :) [21:29:56] kaldari: :) We did try out a bunch of them [21:30:43] YuviPanda: Arimo is a good one as well [21:31:49] kaldari: yeah [21:31:59] kaldari: should I include the resets as well? [21:32:41] YuviPanda: maybe, although there's one in there that could either be a pain or a blessing: [21:32:50] .box-sizing(border-box); [21:32:53] aaah [21:33:02] we set everything to border-box by default [21:33:16] which is great for doing grid-type layout [21:33:20] with percentages [21:33:40] but it might cause you to have to rewrite some app-specific CSS [21:33:54] kaldari: we have very minimal app-specific CSS anyway [21:33:57] kaldari: so it's alright [21:34:14] YuviPanda: In that case, I would encourage you guys applying the resets [21:34:29] kaldari: yeah, am doing that now [21:34:35] kaldari: hmm, I'm now getting exception 'Exception' with message 'variable @fontscalingfactor is undefined: failed at `font-size: 100% * @fontscalingfactor;` /vagrant/mediawiki/extensions/MobileApp/../MobileFrontend/less/content/main.less on line 14' in /vagrant/mediawiki/includes/libs/lessc.inc.php:3581 [21:34:37] any idea why? [21:34:39] let me update MF [21:35:06] you'll need minerva.variables.less as well [21:35:24] kaldari: doesn't the import automatically include them? [21:35:58] kaldari: yeah, updated mediawiki, seems to work now [21:36:07] probably, as long as it can find the file [21:36:22] although I have no idea how LESS works in appland [21:36:36] kaldari: things look better with the reset applied [21:37:21] kaldari: it also explains the font-spacing issues, perhaps [21:38:03] Yeah, a lot of stuff will be broken without the LESS variables [21:38:41] kaldari: no, with the reset. the less variables, if they don't work out, just cause fatals [21:40:13] YuviPanda: Just make sure the other app developers are aware that all the CSS will be border-box by default now. Otherwise they are going to be very confused one day. [21:40:22] kaldari: yeah, will do :) [21:40:32] kaldari: also, why does content_wrapper still exist? [21:40:55] moizsyed! [21:40:59] moizsyed: the person I was looking for [21:41:07] moizsyed: around? [21:41:23] kaldari: merge https://gerrit.wikimedia.org/r/135103? [21:41:26] YuviPanda: I'm not sure [21:41:45] kaldari: I'm not reproducing that on the app's html structure, since I don't see why it is needed or where it is used [21:42:35] hmm, I'm pretty sure we reference it in some CSS rules, but not sure if it's in any of the ones you are importing. [21:42:50] kaldari: yeah, from my git grep not really. You use it to report errors but that's pretty much it [21:42:59] kaldari: the other thing that makes me feel weird is that content is set as both an id and a class [21:43:20] yeah, that's just cruft and should be fixed at some point [21:43:30] (03PS1) 10Yuvipanda: Add proper hashbang [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/135115 [21:43:30] kaldari: yeah [21:43:40] kaldari: I might help fix things at some point, to make things cleaner for the app [21:43:49] jorm: is http://unicorn.wmflabs.org/winter/ showing the latest for winter? [21:43:55] kaldari: but, but, mind merging https://gerrit.wikimedia.org/r/135103? :) [21:44:09] looking [21:44:17] not the very VERY latest, no. [21:44:25] kaldari: the 48px padding is to accomodate the search bar [21:44:25] do you need the latest? [21:44:35] (03CR) 10Dbrant: Fix crash using random and leaving app (031 comment) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/135112 (https://bugzilla.wikimedia.org/65609) (owner: 10BearND) [21:44:57] kaldari: and the links are just links, and I think the color is different from what MF uses [21:44:58] jorm: a screenshot of the latest would be great [21:45:36] i can give you an URL if you like. it's not public, though. [21:46:20] Deskana: did you file bugs for the bugs you found? [21:46:38] YuviPanda: I don't have any way to test this change. I assume you've tested it locally? [21:46:43] kaldari: yup [21:47:01] (03CR) 10Yuvipanda: [C: 032] "Typo fix." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/135115 (owner: 10Yuvipanda) [21:47:18] (03Merged) 10jenkins-bot: Add proper hashbang [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/135115 (owner: 10Yuvipanda) [21:47:24] YuviPanda: Did you figure anything out about the LESS vars? [21:47:42] kaldari: oh yeah, it was a new var in a new mediawiki commit, and I hadn't updated my mediawiki repo in a while [21:47:51] ah [21:47:51] kaldari: git pull origin master on mediawiki fixed it [21:48:34] YuviPanda: whats up [21:49:23] moizsyed: I just rejigged the app's CSS to exactly mimic Mobile Frontend's, but one area they don't mimic - we've been using Open Sans on the android app, and it looked weird with the line spacing set on MobileFrontend. [21:49:48] YuviPanda: Would you mind if I just +1 it for now since I can't actually test it and it probably needs some thorough testing. Might be good to have another app dev take a look at it. [21:49:54] moizsyed: thoughts on that? do you want to spend a few minutes next week fixing up / tweaking the fonts / typography to match that? [21:50:32] kaldari: so the app pulls styles from betalabs, so if you merge it it'll be on the apps in a day [21:50:43] kaldari: but feel free to just +1, I can probably convince someone else to merge :D [21:51:05] YuviPanda: Yeah, that's what scares me :) [21:51:09] kaldari: :D [21:52:02] kaldari: I have killed most custom code in tehre tho [21:52:42] YuviPanda: sure... i need to take a look to find out what you're talking about [21:52:44] kaldari: but yeah, let it be. I'll tweak the overrides some more too, I think [21:52:50] YuviPanda: where can i see a build? [21:53:04] moizsyed: do you have an android device? [21:53:09] i do [21:53:50] moizsyed: I'm going to email you a build now. [21:53:55] YuviPanda: I couldn't reproduce the CSS bug so I just left it. Do you want me to file a bug, even though it'll be nonspecific and vague? [21:54:07] YuviPanda: alright [21:54:17] Deskana: yeah [21:54:23] Sure thing, boss! [21:54:35] Deskana: YuviPanda I've actually witnessed it myself once today [21:54:54] yeah, I saw it on my friend's device an hour ago [21:55:12] moizsyed: emailed you. you'll need to uninstall the old version first tho [21:55:18] alrght [21:56:09] moizsyed: also, not sure if you know - we don't have the Web's font limitations on the apps. we can use whatever font we want. [21:56:49] moizsyed: so if you want to explore other fonts, we can trivially do that too. we settled on Open Sans after a few days of may experimenting with different open fonts. [21:57:21] moizsyed: only restriction is that it has to be a free and open source font (since it lives in our repo). so anything from https://www.google.com/fonts is good to go, for example. [21:57:32] moizsyed: mentioning just in case you want to explore changing the fonts. [21:58:25] YuviPanda: can we stick to the fonts we're using in MobileFrontend [21:59:06] moizsyed: hmm, we can do that too, yeah. In that case you will get Roboto all the time, since everything else in that list is not available on ANdroid [21:59:08] *Android [21:59:36] (03PS7) 10Kaldari: Promoting mobile typography changes from beta to stable: Part 1 [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/134759 [21:59:38] moizsyed: the entire App's UI has also been on Open Sans all this time. Do you want to revert that to Roboto too? [22:00:33] 3Wikipedia App / 3Generic: Using "random" and go home when "loading random page" after bug 65539 crashes the app - 10https://bugzilla.wikimedia.org/65609#c2 (10Bernd Sitzmann) Liangent, I haven't been able to reproduce this yet. When you say go home do you mean press the home button to put the app into back... [22:00:56] (03CR) 10BearND: Fix crash using random and leaving app (031 comment) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/135112 (https://bugzilla.wikimedia.org/65609) (owner: 10BearND) [22:01:50] 3Wikipedia App / 3Generic: Android: App CSS failed to load after installation - 10https://bugzilla.wikimedia.org/65699 (10Dan Garry) 3NEW p:3Unprio s:3normal a:3None At some point today, after downloading the app, the CSS failed to load and the app had no CSS at all. Yuvi and I think this is related... [22:01:57] YuviPanda: ^^ [22:02:00] Deskana: cool [22:03:55] YuviPanda: when you go to mobile web on android, you get roboto? [22:09:53] (03CR) 10Kaldari: Promoting mobile typography changes from beta to stable: Part 2 (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/134978 (owner: 10Kaldari) [22:11:22] (03PS8) 10Kaldari: Promoting mobile typography changes from beta to stable: Part 1 [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/134759 [22:12:51] YuviPanda: you wanna get on hangout? [22:13:56] (03PS2) 10Kaldari: Promoting mobile typography changes from beta to stable: Part 2 [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/134978 [22:13:58] (03PS9) 10Kaldari: Promoting mobile typography changes from beta to stable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/134759 [22:15:20] (03PS1) 10Brion VIBBER: Initial 'last modified' marker at bottom of page [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/135118 [22:19:06] (03PS1) 10Kaldari: Syncing mobile header fonts with new Vector skin stack [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/135119 [22:21:59] (03CR) 10Brion VIBBER: [C: 032 V: 032] RTL styling fix for language button [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/135104 (owner: 10Brion VIBBER) [22:22:42] (03CR) 10Brion VIBBER: [C: 032 V: 032] Initial 'last modified' marker at bottom of page [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/135118 (owner: 10Brion VIBBER) [22:23:12] (03PS10) 10Kaldari: Promoting mobile typography changes from beta to stable: Part 1 [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/134759 [22:23:32] (03PS3) 10Kaldari: Promoting mobile typography changes from beta to stable: Part 2 [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/134978 [22:29:00] bearND: hi [22:29:57] liangent0: hi [22:30:54] any ideas how to easier reproduce https://bugzilla.wikimedia.org/show_bug.cgi?id=65609? [22:31:30] bearND: do you have an earlier build where crash-after-language exists [22:32:27] liangent0: i had not tried this with the earlier build, but i can go back to one [22:35:00] bearND: let's reproduce https://bugzilla.wikimedia.org/show_bug.cgi?id=65539 first [22:35:19] (03PS1) 10Florianschmidtwelzow: Introducing new "wgMFRemoveRedlinks" config [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/135120 (https://bugzilla.wikimedia.org/65640) [22:35:34] (03CR) 10jenkins-bot: [V: 04-1] Introducing new "wgMFRemoveRedlinks" config [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/135120 (https://bugzilla.wikimedia.org/65640) (owner: 10Florianschmidtwelzow) [22:36:17] liangent0: yes, just did that [22:36:33] bearND: then "cancel" the first crash dialog [22:36:54] pull out left drawer [22:37:14] liangent0: you mean restart the app then, right? [22:37:52] bearND: what I did exactly is pressing cancel [22:38:02] Not sure whether it means a restart [22:38:27] liangent0: once you press cancel the app is stopped [22:39:18] bearND: really? Can you send me an earlier build? [22:39:31] liangent at gmail [22:40:00] liangent0: ok [22:40:57] Whatever signature is OK [22:42:22] (03CR) 10MaxSem: [C: 04-1] "We have plans to deprecate red link removal completely, we'd better go down that road." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/135120 (https://bugzilla.wikimedia.org/65640) (owner: 10Florianschmidtwelzow) [22:43:39] liangent0: on its way [22:43:54] (03PS2) 10Florianschmidtwelzow: Introducing new "wgMFRemoveRedlinks" config [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/135120 (https://bugzilla.wikimedia.org/65640) [22:46:11] (03CR) 10Florianschmidtwelzow: "@MaxSem: Ah, ok, that i don't know :) Then, it's better to don't merge this commit, so nobody get confused with a new config deprecate in " [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/135120 (https://bugzilla.wikimedia.org/65640) (owner: 10Florianschmidtwelzow) [22:47:57] bearND: let's do this [22:48:11] Open the "history" interface [22:48:22] Open a history page [22:49:13] Go to "settings" interface [22:49:21] Change language [22:49:28] Tap back [22:49:32] Now it crashes [22:49:50] Tap cancel. You're now in the history interface [22:50:00] Tap back [22:50:32] Choose random, then tap home as soon as possible [22:50:42] Open the app again [22:50:46] Now it crashes [22:51:09] bearND: got it? [22:54:37] liangent0: no, i guess i don't press the home button on the device fast enough [22:54:53] liangent0: will need to throttle my connection [22:55:44] Force a 2G mobile data connection and I guess it can be slow enough [22:57:28] (03PS1) 10Yuvipanda: Update packaged styles to latest version [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/135122 [22:57:32] liangent0: need to fire up an emulator [22:57:37] bearND: merge? ^ [22:58:46] bearND: not really. Actually you can be faster on a real device... [22:58:50] bearND: hmm, actually I think I'm comfortable self-merging these, since they underwent review when they went into Extension:MobileAPp [22:59:06] (03PS2) 10Yuvipanda: Update packaged styles to latest version [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/135122 [22:59:10] bearND: what do you think? [22:59:30] Touchstart home, touchstart random, touchend random, touchend home [22:59:37] bearND: this works too [23:02:02] liangent0: this will take some time. thanks [23:02:49] YuviPanda: that's a lot of changes. have you tested this? [23:06:05] (03PS1) 10Kaldari: Add top border to page list on Nearby page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/135124 (https://bugzilla.wikimedia.org/65613) [23:12:04] (03PS1) 10Kaldari: Hygiene: Some CSS clean-up. Removing old cruft and consolidating. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/135126 [23:12:39] bearND: any updates? [23:15:33] 3MobileFrontend / 3stable: Tapping another ref when a reference is shown shouldn't close the ref bar - 10https://bugzilla.wikimedia.org/65708#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/H2LqkgwL [23:20:56] liangent0: brb [23:24:31] bearND: as I said, it's just running that script [23:24:35] bearND: it just brings the css files from http://bits.beta.wmflabs.org/en.wikipedia.beta.wmflabs.org/load.php?debug=true&lang=en&modules=mobile.app.pagestyle&only=styles&skin=vector&version=&* into the assets folder [23:24:37] bearND: and yeah, I tested it [23:24:50] bearND: you can test it too :) should have different typography and styles [23:24:51] bearND: on it [23:25:17] bearND: by it I mean the pages, of course [23:25:28] bearND: you can look at mediawiki/extensions/MobileApp.git for the source of the CSS [23:27:06] bearND: heading off now [23:27:24] YuviPanda|brb: sounds good. i'll cr later [23:28:56] liangent0: sorry, the emulator is super sloooow [23:29:18] bearND: hm? [23:35:56] (03PS1) 10Kaldari: Hygiene: Removing old button styles now that we use mw-ui-button [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/135137 [23:41:43] liangent0: i was able to reproduce it [23:42:00] took a lot of tries though [23:44:56] bearND: what's the key? [23:50:21] liangent0: i wish i knew. it's still difficult to repro. took a lot of tries. but i have an idea how to fix it. have you been able to repro with the latest build? [23:50:29] liangent0: can i send you an apk to try with the potential fix? [23:51:18] (03CR) 10Florianschmidtwelzow: [C: 031] Add top border to page list on Nearby page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/135124 (https://bugzilla.wikimedia.org/65613) (owner: 10Kaldari) [23:51:24] bearND: I wonder how it is related to the language change crash [23:51:31] liangent0: looks like you are much better at reproducing this one [23:51:43] I can't reproduce it with that one [23:51:44] liangent0: i don't think it is [23:52:02] liangent0: hmmm, that's interesting [23:52:04] *without [23:54:07] The reason that I can reproduce it easier is probably a slower network [23:55:13] liangent0: yeah, latency plays a big role [23:56:04] liangent0: but if you can't repro with the latest official build then we should put this one on hold until it can be reproduced with a new build [23:58:05] bearND: so if it's easy: maybe you can add some sleep to the async random fetching task