[00:03:16] bearND: it seems I tried to reproduce it without language change and it succeed .. [00:06:13] hm did someone change article stylesheets just now? [00:06:25] YuviPanda|brb: is it you? [00:08:21] liangent0: yes YuviPanda|brb was changing them. there is another stylesheet change that needs to be reviewed. did you notice anything weird? [00:09:23] bearND: body font size and line height are smaller than before [00:10:14] liangent0: i can push his other change through if you'd like to take a look [00:17:30] liangent0: now that i added the delay and guarded against the issue when the progress dialog gets dismissed, i got a crash when it tried to show the dialog ;( [00:18:27] yay i find it faster to destroy and recreate the activity by using multitask button (press it twice) [00:18:28] liangent0: although that's probably because where i added the delay [00:18:50] and I can reproduce it now with the latest official build [00:19:03] yes it's unrelated to language change [00:19:18] liangent0: good, i guess [00:20:05] (03PS4) 10Dr0ptp4kt: Add MCC-MNC once per app session on cellular. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/131246 [00:21:20] bearND: the key is, you must have already returned to the app (so it's a new activity now) when the random fetching task ends [00:22:49] liangent0: that makes sense [00:26:05] (03PS5) 10Dr0ptp4kt: Add MCC-MNC once per app session on cellular. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/131246 [00:26:09] so does your previous patch work? [00:28:03] 3Wikipedia App / 3Generic: Using "random" and go home when "loading random page" then return crashes the app - 10https://bugzilla.wikimedia.org/65609#c3 (10Liangent) The key is you must have already returned to the app (so it's a new activity now) when the random fetching task ends. [00:28:59] liangent0: well, i haven't been able to repo that. would you like me to send you another apk? [00:29:32] bearND: what's the difference? [00:29:41] from the one on google play [00:30:52] btw the new font looks bad... [00:31:03] the page appears too crowded [00:32:53] liangent0: let me push YuviPanda|brb other change then, and then i'll merge that and combine with my change. he changed some css files [00:33:14] (03CR) 10BearND: [C: 032] Update packaged styles to latest version [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/135122 (owner: 10Yuvipanda) [00:33:31] (03Merged) 10jenkins-bot: Update packaged styles to latest version [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/135122 (owner: 10Yuvipanda) [00:34:25] bearND: then i guess i need to install a new apk to see the change? [00:35:06] liangent0: yes, would you like it. you probably need ot uninstall the previous version because of a different signing key [00:35:48] liangent0: the font seems small [00:36:09] yeah [00:36:37] not sure whether gerrit 135122 fixes it [00:38:21] bearND: and an arrow appears in page footer [00:38:29] this should be fixed [00:41:29] bearND: and zhwp's main page starts to have a white background? [00:42:13] liangent0: i sent you another email with a link to the very latest, hot from the oven, apk + my local changes. i don't see the arrow with that version [00:42:54] liangent0: what was the background before? [00:43:13] "not that white" [00:43:23] like a normal article's background [00:44:01] liangent0: let's check the latest one i just sent so you can compare [00:44:47] it seems to make better use of screen real estate. i think the styles should be closer to mobile web now [00:45:05] bearND: no difference [00:47:37] bearND: your new apk is still crashing [00:48:00] i'm sending backtrace to you directly [00:50:58] liangent0: thank you the quick check. so the check for isShowing() was not enough then. [00:52:05] 3Wikipedia App / 3Generic: New stylesheets are ugly - 10https://bugzilla.wikimedia.org/65717 (10Liangent) 3NEW p:3Unprio s:3normal a:3None Fonts are too small Lines are too crowded zhwiki main page background appears too white (why?) An arrow (for external links) is showing in page footer [01:04:30] liangent0: i gotta go, but i'm going to research this some more later. next week i'm also going to check with the designers to see if we can replace the progress dialog with something else, like a little progress indicator in the search bar, or something like that. i'm not a big fan of dialogs [01:21:11] liangent: bearND|bbl yeah, new styles. same as MF styles [01:21:25] liangent: yeah, they currently look ugly, but that I think is just a font size change. [02:10:18] 3Wikipedia App / 3Generic: New stylesheets are ugly - 10https://bugzilla.wikimedia.org/65717#c1 (10Dan Garry) Can you show us a screenshot of what you're seeing? I only ask because I made this exact same complaint to Yuvi today, and it turned out I'd encountered a bug which had caused the CSS to not load pr... [12:05:33] 3Wikipedia App / 3Generic: New stylesheets are ugly - 10https://bugzilla.wikimedia.org/65717#c2 (10Yuvi Panda) I switched over all app styles to just re-use MobileFrontend styles, and that seems to have gone mostly ok (nicer infoboxes, lists, etc) - but fucked up the font size and spacing. You can probably s... [15:14:18] 3MobileFrontend / 3stable: Tapping another ref when a reference is shown shouldn't close the ref bar - 10https://bugzilla.wikimedia.org/65708 (10Florian) p:5Unprio>3Normal [15:44:45] (03PS1) 10Florianschmidtwelzow: Prevent hide drawer when click (again) on (another) reference [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/135270 (https://bugzilla.wikimedia.org/65708) [16:17:33] 3MobileFrontend / 3stable: "Read in another language" gives desktop site's links - 10https://bugzilla.wikimedia.org/65047#c2 (10Florian) 5UNC>3NEW If you change the language (or use "read in another language") on a mobile device you will be redirected to the mobile site on the "new" language Wikipedia, t... [17:00:04] 3MobileFrontend / 3General/Unknown: Thank notification on mobile doesn't ask for confirmation: accident-prone - 10https://bugzilla.wikimedia.org/61737#c6 (10pamdavies7) But as it has instant effect, the message will already have gone to the inappropriate recipient before it can be undone, leading to potentia... [17:28:03] 3MobileFrontend / 3Feature requests: Link is missing from the 'Create the page ...' text on the search result page - 10https://bugzilla.wikimedia.org/65640#c16 (10Istvan Bujdoso) (In reply to Florian from comment #8) > Yeah, like i said, i thought you have a local installation, where you edit > MobileFronten... [17:34:36] 3MobileFrontend / 3Feature requests: Link is missing from the 'Create the page ...' text on the search result page - 10https://bugzilla.wikimedia.org/65640#c17 (10Istvan Bujdoso) (In reply to Jon from comment #11) > If you look closely at the search page HTML the link is there it is just > hidden via CSS wit... [17:38:38] 3MobileFrontend / 3Feature requests: Link is missing from the 'Create the page ...' text on the search result page - 10https://bugzilla.wikimedia.org/65640#c18 (10Istvan Bujdoso) Does anyone know when will be a user friendly way to add new pages available to MobileFrontend? (E.g.: red links or a button) [17:42:33] 3MobileFrontend / 3Feature requests: Link is missing from the 'Create the page ...' text on the search result page - 10https://bugzilla.wikimedia.org/65640#c19 (10Florian) Like Max Sem said in gerrit: > We have plans to deprecate red link removal completely, we'd better go down that road. So, after the remo... [17:49:41] (03CR) 10Florianschmidtwelzow: "@Max Sem: Is there a roadmap or a target time/milestone/version, when the redlinks removal will be removed? :)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/135120 (https://bugzilla.wikimedia.org/65640) (owner: 10Florianschmidtwelzow) [18:09:33] 3Wikipedia App / 3Generic: Using "random" and go home when "loading random page" then return crashes the app - 10https://bugzilla.wikimedia.org/65609#c4 (10Bernd Sitzmann) I also think one would want to turn on "don't keep activities" in developer options on the device to get a better chance at reproducing t... [18:09:33] (03Abandoned) 10BearND: Fix crash using random and leaving app [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/135112 (https://bugzilla.wikimedia.org/65609) (owner: 10BearND) [18:19:41] hey bearND. around? [18:19:51] YuviPanda|brb: yup [18:21:07] YuviPanda: i think deskana wants another build to be able to sign off on the latest cards [18:21:16] bearND: yeah, I'm going to do one now [18:21:19] bearND: want to +2 the styles patch? [18:21:29] bearND: people will get them anyway since we download styles dynamically [18:21:47] YuviPanda: already did that yesterday [18:21:52] bearND: ah, didn't notice :) [18:21:57] YuviPanda: what's /data/data/org.wikipedia/files/*.css ? [18:21:59] bearND: did you check out how our styles work? :) [18:22:16] liangent: that's the styles that are being applied to the page content [18:22:56] liangent: they are refreshed daily from betalabs right now, will be refreshed from prod later on [18:23:01] YuviPanda: then abusefilter ? [18:23:12] liangent: it's the styles for the abusefilter warning? [18:23:42] YuviPanda: not completely [18:24:47] YuviPanda: but i know you've copied them from beta labs [18:25:10] YuviPanda: but its content appears identical to styles.css [18:49:05] liangent: for now, yeah [18:49:09] liangent: preview also is almost identical [18:49:14] liangent: we can update them in the future [18:49:32] bearND: right. StyleFetcher and StyleBundle (and subclasses) are what manage that, in case you are curious [18:54:18] 3MobileFrontend / 3General/Unknown: Show what features are included in Beta and Experimental on mobile. - 10https://bugzilla.wikimedia.org/65079#c7 (10Florian) Hmm, maybe two new arrays for registered alpha/beta features? Example: registeredBeta['name'] registeredBeta['name']['desc'] registeredAlpha['name'... [19:00:09] YuviPanda: thanks. looks like the site parameter in StyleLoader.getAvailableBundle is not used. so it's not site specific, right? [19:01:02] bearND: for now, yeah. but eventually we will be loading CSS that is different per site. en.wikipedia.org/wiki/Mediawiki:Mobile.css for enwiki, and similar pages for each wiki. contains custom per-wiki css [19:01:31] YuviPanda: cool. another quesiton: why does abusefilter have its own html + css files? [19:02:19] bearND: because it currently looks terrible and we will probably apply some specific styling there to make them look better. [19:03:45] liangent: and yeah, you can edit those css files if you have root [19:03:51] liangent: but they'll be overwritten the next day [19:19:03] 3MobileFrontend / 3Feature requests: Cannot easily retry upload - 10https://bugzilla.wikimedia.org/45377#c5 (10Florian) > we could reuse it on a subsequent click on the button Maybe with an ask to the user, if he want to use the cached file or upload a new. But with this, we haven't the description (if the u... [19:29:51] Yuvipanda: search box obscures top of article in latest build. It stays around a lot more than it should. [19:30:30] ragesoss: do the styles look like shit as well? [19:30:47] Yes [19:31:18] Saw that from irc browsing earlier. [19:31:50] ragesoss: uninstall and re-install? [19:33:30] Oh, hey, clearing the app from recent apps seems to have fixed it. [19:34:52] Font seems rather smaller than it used to be, though, Yuvipanda. [21:53:33] 3MobileFrontend / 3stable: Editor and image upload license is hardcoded - 10https://bugzilla.wikimedia.org/56639#c11 (10Florian) 5NEW>3RES/FIX This bug can be closed as resolved -> fixxed, am i right? MobileFrontend uses the License set in LocalSettings for both editing and uploading :) See https://gerr...