[02:11:30] (03PS1) 10Yuvipanda: WIP: Support protection status messaging [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/135506 [04:23:42] (03CR) 10Florianschmidtwelzow: [C: 04-1] Insert section name in edit summary (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/135311 (https://bugzilla.wikimedia.org/60134) (owner: 10Florianschmidtwelzow) [07:17:49] (03PS5) 10Florianschmidtwelzow: Insert section name in edit summary [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/135311 (https://bugzilla.wikimedia.org/60134) [11:22:11] 3MobileFrontend / 3Feature requests: Link is missing from the 'Create the page ...' text on the search result page - 10https://bugzilla.wikimedia.org/65640#c22 (10Istvan Bujdoso) Thank you. I use the stable version of MediaWiki (v1.22.6) and the MobileFrontend that can be downloaded from https://www.mediawi... [11:34:11] 3MobileFrontend / 3Feature requests: Link is missing from the 'Create the page ...' text on the search result page - 10https://bugzilla.wikimedia.org/65640#c23 (10Florian) You use the version of REL1_22 branch, yes? Then, for now, i can not say, why the redlinks will be removed. The redlink remove function w... [14:09:00] (03CR) 10JGonera: [C: 04-1] "Inline comment about schema + I get:" (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/134527 (owner: 10Jdlrobson) [14:16:51] (03CR) 10JGonera: [C: 032] Add top border to page list on Nearby page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/135124 (https://bugzilla.wikimedia.org/65613) (owner: 10Kaldari) [14:17:29] (03Merged) 10jenkins-bot: Add top border to page list on Nearby page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/135124 (https://bugzilla.wikimedia.org/65613) (owner: 10Kaldari) [14:29:11] (03CR) 10JGonera: [C: 04-1] "Comment on commit message. Also, buttons in stable watchlist are messed up." (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/135137 (owner: 10Kaldari) [14:30:19] (03CR) 10JGonera: [C: 032] Syncing mobile header fonts with new Vector skin stack [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/135119 (owner: 10Kaldari) [14:30:54] (03Merged) 10jenkins-bot: Syncing mobile header fonts with new Vector skin stack [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/135119 (owner: 10Kaldari) [14:32:22] (03CR) 10JGonera: [C: 032] Loading toggling css with JavaScript [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/135056 (owner: 10Jdlrobson) [14:32:58] (03Merged) 10jenkins-bot: Loading toggling css with JavaScript [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/135056 (owner: 10Jdlrobson) [14:36:57] 3MobileFrontend / 3General/Unknown: Nearby pagelist missing border-top - 10https://bugzilla.wikimedia.org/65613 (10Florian) 5PAT>3RES/FIX [14:37:20] (03CR) 10JGonera: [C: 032] Hygiene: rename scripts directory to dev-scripts [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/135083 (owner: 10MaxSem) [14:37:53] (03Merged) 10jenkins-bot: Hygiene: rename scripts directory to dev-scripts [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/135083 (owner: 10MaxSem) [14:49:41] (03CR) 10JGonera: [C: 04-1] "Doubts about two rules not being moved. If this is OK or you fix it, then feel free to self-merge." (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/134759 (owner: 10Kaldari) [14:53:53] (03CR) 10JGonera: [C: 032] Promoting mobile typography changes from beta to stable: Part 2 [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/134978 (owner: 10Kaldari) [14:54:51] (03CR) 10JGonera: [C: 031] Reduce page_props usage [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/134858 (owner: 10MaxSem) [14:56:40] jgonera: would these promotion patches touch the content/*.less files you extracted out? [14:56:47] jgonera: or are these purely for tablets? [14:57:08] YuviPanda, let me check [14:58:07] (03CR) 10JGonera: [C: 04-1] "Fix jslint and merge." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/130270 (owner: 10Jdlrobson) [15:00:30] YuviPanda, the first patch changes styles for everything, it's promoting beta styles to stable and removes skins.minerva.content.styles.beta module (so you only have to request skins.minerva.content.styles) [15:03:36] jgonera: ah, right. so I don't actually have to do anything since I"m referencing the less files directly [15:04:10] YuviPanda, just stop referencing mainNew.less since it won't exist anymore [15:04:20] jgonera: yeah, never referenced that [15:04:24] jgonera: cool! [15:06:10] (03PS2) 10Yuvipanda: WIP: Support protection status messaging [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/135506 [15:13:40] jgonera = mobilewebteam? [15:17:28] 3MobileFrontend / 3alpha: toggle to VE makes UI spin forever, no VE, js error - 10https://bugzilla.wikimedia.org/65810 (10Chris McMahon) 3NEW p:3Unprio s:3normal a:3None on http://en.m.wikipedia.beta.wmflabs.org/ as logged-in user; set Settings mode for VE access; edit a page; toggle VisualEditor mod... [15:17:41] 3MobileFrontend / 3stable: Filter for New User uploads in Mobile Web - 10https://bugzilla.wikimedia.org/62598 (10Steinsplitter) [15:20:26] 3MobileFrontend / 3alpha: toggle to VE makes UI spin forever, no VE, js error - 10https://bugzilla.wikimedia.org/65810#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/lIGKYsRM [15:20:45] Steinsplitter, jgonera = part of mobile web team [15:22:03] yey, you know if the mobile web team don't fix the spamproblem mobileweb will be disabled on commons in the next days (unsing MediaWiki:Mobile.js) ^^ [15:22:21] (the uploads spam) [15:23:49] Steinsplitter, is there any specific discussion somewhere you can point me to? [15:23:59] yes, i have given engough links [15:24:04] see bugsreports [15:24:23] can you give me the bug number? [15:24:40] 62598 [15:26:22] Steinsplitter, I'm sorry nobody replied in the bug lately, we had a change in product manager and the new PM had to get her head around lots of things [15:27:35] Steinsplitter, a new mechanism for detecting copyvios has been pushed to stable and deployed in production on May 15 if I'm not mistaken [15:28:01] yes, but don't help, nobody is reading the infomsg [15:28:01] are the statistics in the bug (84% provable copyvios) generated from data from the past 12 days? [15:28:26] yes, you can query the productions DB for deleted uploads [15:29:02] Steinsplitter, but that doesn't mean those uploads were uploaded after May 15, only that they were deleted after that date [15:29:29] we have engough reports onwiki, and we have deleted engough photos [15:29:48] yes, you can set a limit % timestamp [15:31:58] Steinsplitter, I will reply in the bug and make sure our PM directs her attention to it today (it's still early in San Francisco, but that should be in a few hours) [15:32:28] thx [15:32:30] (03PS3) 10Yuvipanda: WIP: Support protection status messaging [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/135506 [15:39:30] 3MobileFrontend / 3stable: Filter for New User uploads in Mobile Web - 10https://bugzilla.wikimedia.org/62598#c36 (10Juliusz Gonera) Sorry for not replying here in a long time. There was a change of product manager in the mobile team which slowed things down and made us lose focus. Just to let you know, the... [15:53:45] (03PS11) 10Kaldari: Promoting mobile typography changes from beta to stable: Part 1 [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/134759 [15:53:55] (03CR) 10jenkins-bot: [V: 04-1] Promoting mobile typography changes from beta to stable: Part 1 [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/134759 (owner: 10Kaldari) [15:56:10] (03PS12) 10Kaldari: Promoting mobile typography changes from beta to stable: Part 1 [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/134759 [15:59:36] (03PS4) 10Yuvipanda: Display message about protection status when editing [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/135506 [16:01:38] (03CR) 10JGonera: [C: 04-1] "Can't see any changes or comments regarding comments from patchset 10." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/134759 (owner: 10Kaldari) [16:03:57] (03CR) 10JGonera: [C: 032] Hygiene: Cleanup browser test steps which are not sentence case [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/134510 (owner: 10Jdlrobson) [16:04:31] jgonera: Here's the change you mentioned in the comment: https://gerrit.wikimedia.org/r/#/c/134759/10..11/less/content/main.less [16:04:54] jgonera: thanks for spotting that [16:04:55] kaldari, sorry, I just realized I tried to check it in a stupid way [16:05:09] I had to rebase it again afterwards [16:05:20] (03Merged) 10jenkins-bot: Hygiene: Cleanup browser test steps which are not sentence case [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/134510 (owner: 10Jdlrobson) [16:05:45] (03CR) 10JGonera: [C: 032] "Sorry, I checked diff in mainNew.less, that was stupid of me ;)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/134759 (owner: 10Kaldari) [16:06:06] (03CR) 10JGonera: [C: 032] Hygiene: Update QA steps which take arguments [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/134511 (owner: 10Jdlrobson) [16:06:27] (03Merged) 10jenkins-bot: Promoting mobile typography changes from beta to stable: Part 1 [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/134759 (owner: 10Kaldari) [16:06:29] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Update QA steps which take arguments [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/134511 (owner: 10Jdlrobson) [16:15:00] heya dr0ptp4kt! [16:15:13] YuviPanda, hola [16:15:27] dr0ptp4kt: saw the patch, looks good. have you tested it? I assume you have access to the varnish logs... [16:17:55] YuviPanda: yep, i've tested it. i did have kaldari query the event logging. i do have varnish web log access, too, yep. [16:18:26] 3MobileFrontend / 3stable: Filter for New User uploads in Mobile Web - 10https://bugzilla.wikimedia.org/62598#c37 (10Lupo) (In reply to Juliusz Gonera from comment #36) > Is the data that > Steinsplitter quotes based on period after that date? Yes. If it was enabled on the 15th, I had been patrolling that... [16:19:07] (03CR) 10JGonera: [C: 04-1] "There's no need for a separate request. Replace:" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/135311 (https://bugzilla.wikimedia.org/60134) (owner: 10Florianschmidtwelzow) [16:20:47] (03CR) 10JGonera: [C: 04-1] "I think we should get rid of the $wgMFNearby variable altogether, but please double check with Jon." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/135308 (https://bugzilla.wikimedia.org/64029) (owner: 10Florianschmidtwelzow) [16:21:23] YuviPanda: that reminds me! are there instructions on access requests for event logging? i'd like to be able to query myself [16:22:49] dr0ptp4kt: yeah, you need stat1003 access [16:23:09] dr0ptp4kt: however, mcc is going as a header, right? is there something on the serverside that is moving it to EL? [16:23:59] YuviPanda: thanks. do i need to email rt? [16:24:11] dr0ptp4kt: file an RT ticket, yeah [16:24:25] dr0ptp4kt: and I guess we are sampling it serverside? [16:24:54] YuviPanda: yep, api hook with 2% sampling [16:25:06] dr0ptp4kt: cool. [16:25:11] (03CR) 10JGonera: [C: 04-1] "Thanks for the patch! If we're changing that file, let's make it follow our coding conventions (alias jQuery as $, indentation):" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/135288 (https://bugzilla.wikimedia.org/48996) (owner: 10Florianschmidtwelzow) [16:25:19] dr0ptp4kt: can you point me to the schema? [16:25:32] dr0ptp4kt: also I just realized - we need to not send MCC-MNC is the user has opted out of EL [16:25:36] dr0ptp4kt: can you add that check? [16:25:48] (03PS4) 10Kaldari: Promoting mobile typography changes from beta to stable: Part 2 [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/134978 [16:26:44] YuviPanda: https://meta.wikimedia.org/wiki/Schema:MobileOperatorCode . note the api invocation server side also does not include the ua in the logged event [16:27:18] YuviPanda: gimme a few minutes [16:29:45] (03CR) 10JGonera: [C: 04-1] "When adding a new config option, add default value and docs in MobileFrontend.php (and then you also don't have to check if !== false)." (033 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/135120 (https://bugzilla.wikimedia.org/65640) (owner: 10Florianschmidtwelzow) [16:33:02] dr0ptp4kt: cool. [16:33:38] dr0ptp4kt: also can you rename it to be MobileWikiAppOperatorCode? I'm trying to make sure all related schemas have that prefix [16:35:30] (03CR) 10JGonera: [C: 032] "Thanks!" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/135270 (https://bugzilla.wikimedia.org/65708) (owner: 10Florianschmidtwelzow) [16:35:55] oh, realized both dbrant and bearND will be in transit [16:35:56] (03PS6) 10Dr0ptp4kt: Add MCC-MNC once per app session on cellular. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/131246 [16:36:04] (03Merged) 10jenkins-bot: Prevent hide drawer when click (again) on (another) reference [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/135270 (https://bugzilla.wikimedia.org/65708) (owner: 10Florianschmidtwelzow) [16:36:33] YuviPanda: ^^ i think that captures the pref. that pref will be checked (on) by default, correct? [16:36:46] dr0ptp4kt: yes [16:37:24] YuviPanda, thx. regarding schema rename lemme check a few things here. [16:38:28] (03CR) 10Yuvipanda: [C: 04-1] Add MCC-MNC once per app session on cellular. (032 comments) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/131246 (owner: 10Dr0ptp4kt) [16:38:32] dr0ptp4kt: couple of comments [16:38:44] 3MobileFrontend / 3stable: References drawer doesn't work after editing - 10https://bugzilla.wikimedia.org/65816 (10Juliusz Gonera) 3NEW p:3Unprio s:3normal a:3None Edit a page with references, click on a reference after saving your edit. Expected: see reference drawer Result: #cite_note-1 appended... [16:40:26] 3MobileFrontend / 3stable: References drawer doesn't work after editing - 10https://bugzilla.wikimedia.org/65816#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/P8B6FH4m [16:41:55] (03PS5) 10Yuvipanda: Display message about protection status when editing [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/135506 [16:42:31] * YuviPanda waves at jdlrobson [16:42:36] hey YuviPanda [16:42:44] hope you're not too sick of glasgow yet ;-) [16:42:50] jdlrobson: I'm in London till thursday :) [16:42:57] jdlrobson: wanted to go out but it was raining... [16:43:00] well, *is* [16:43:04] YuviPanda: yeh it was nasty when i left [16:43:06] was happy to leave [16:43:12] that's how it is most of the time ;-) [16:43:16] jdlrobson: :D [16:43:18] you need friends? [16:43:31] jdlrobson: nah, got plenty atm. staying with the lady, and she got plenty. [16:45:09] (03PS1) 10JGonera: Regression: fix trimmed cancel icon in drawers [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/135585 [16:46:09] (03PS2) 10JGonera: Regression: fix trimmed cancel icon in drawers [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/135585 [16:47:34] (03CR) 10JGonera: [C: 032] Hygiene: Some CSS clean-up. Removing old cruft and consolidating. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/135126 (owner: 10Kaldari) [16:48:08] jgonera: when are the new styles being deployed? [16:49:06] (03Merged) 10jenkins-bot: Hygiene: Some CSS clean-up. Removing old cruft and consolidating. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/135126 (owner: 10Kaldari) [17:02:09] (03PS6) 10Florianschmidtwelzow: Insert section name in edit summary [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/135311 (https://bugzilla.wikimedia.org/60134) [17:02:46] jgonera: Can you take another look at https://gerrit.wikimedia.org/r/#/c/134770/ ? [17:04:13] (03CR) 10Florianschmidtwelzow: "> but please double check with Jon." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/135308 (https://bugzilla.wikimedia.org/64029) (owner: 10Florianschmidtwelzow) [17:04:25] hey brion [17:05:50] hey yuvi! [17:06:01] YuviPanda: you make it back to india yet or still stuck somewhere? :D [17:06:06] brion: i'll be in the uk for 2 more weeks [17:06:11] heh ok :D [17:06:13] (03PS4) 10Kaldari: Fixing thumbnail sizing in search overlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/134770 (https://bugzilla.wikimedia.org/65347) [17:06:24] not a bad place to be stuck at least [17:06:37] brion: easier to just ignore the easyjet flight, re-route my emirates flight to Glasgow when it is cheaper, which is 2 weeks from now [17:07:40] yay planning travel [17:07:54] oh that reminds me i gotta finish some wikimania stuff soon [17:08:07] brion: yeah, me too [17:08:52] and i gotta confirm my parents are still coming to visit after the conference, we have a sci-fi convention also in london we’re going to cause we’re all nerds ;) [17:08:59] 3Wikipedia App / 3General/Unknown: iOS App: History view stops after a certain point - 10https://bugzilla.wikimedia.org/65820 (10Kunal Mehta (Legoktm)) 3NEW p:3Unprio s:3normal a:3None Created attachment 15488 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15488&action=edit (null) After I re... [17:09:05] but my mom just quit her job, so i hope they can still afford it :D [17:09:26] 3Wikipedia App / 3iOS App: iOS App: History view stops after a certain point - 10https://bugzilla.wikimedia.org/65820 (10Kunal Mehta (Legoktm)) [17:11:21] (03PS3) 10Florianschmidtwelzow: Remove clickable link around image instead of abort click event [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/135288 (https://bugzilla.wikimedia.org/48996) [17:11:41] 3Wikipedia App / 3iOS App: iOS App: Left drawer should animate from right instead of left - 10https://bugzilla.wikimedia.org/64336#c1 (10Kunal Mehta (Legoktm)) Now that the button is on the right, I've updated the summary that it should come from the right. [17:13:11] 3Wikipedia App / 3iOS App: iOS App: Left drawer should animate from right instead of left - 10https://bugzilla.wikimedia.org/64336#c2 (10Brion Vibber) Is this about the 'W' menu drawer or the table of contents drawer? [17:14:26] 3Wikipedia App / 3iOS App: iOS App: Left drawer should animate from right instead of left - 10https://bugzilla.wikimedia.org/64336#c3 (10May) This is the 'W' menu [17:14:56] 3Wikipedia App / 3iOS App: iOS App: Left drawer should animate from right instead of left - 10https://bugzilla.wikimedia.org/64336#c4 (10Kunal Mehta (Legoktm)) Table of contents, but now that I think of it the original report might have been about the "W" one... The "W" button is on the left and opens from... [17:19:58] 3Wikipedia App / 3iOS App: iOS App: Scrolling does not automatically show/hide search bar + navigation buttons - 10https://bugzilla.wikimedia.org/65822 (10Kunal Mehta (Legoktm)) 3NEW p:3Unprio s:3enhanc a:3None In Safari, if you scrolldown on a page the address bar and navigation stuff at the bottom... [17:23:41] 3Wikipedia App / 3iOS App: iOS App: Left drawer should animate from right instead of left - 10https://bugzilla.wikimedia.org/64336#c5 (10May) Yep this original bug is solved, just checked on ios app. [17:26:14] 3Wikipedia App / 3iOS App: iOS App: "W" menu needs reorganization - 10https://bugzilla.wikimedia.org/65824 (10Kunal Mehta (Legoktm)) 3NEW p:3Unprio s:3major a:3None The "W" menu is currently a mixture of lots of different things: - Login/logout (entire app) - Random article (navigation) - Browsing h... [17:27:17] (03PS7) 10Dr0ptp4kt: Add MCC-MNC once per app session on cellular. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/131246 [17:27:23] ^ YuviPanda [17:27:58] (03PS3) 10Florianschmidtwelzow: Introducing new "wgMFRemoveRedlinks" config [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/135120 (https://bugzilla.wikimedia.org/65640) [17:29:29] (03CR) 10Florianschmidtwelzow: Introducing new "wgMFRemoveRedlinks" config (033 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/135120 (https://bugzilla.wikimedia.org/65640) (owner: 10Florianschmidtwelzow) [17:30:12] 3MobileFrontend / 3stable: Tapping another ref when a reference is shown shouldn't close the ref bar - 10https://bugzilla.wikimedia.org/65708 (10Florian) 5PAT>3RES/FIX [17:30:28] dr0ptp4kt: standup, will look right after [17:34:59] 3Wikipedia App / 3iOS App: iOS App: Bottom of article says "1 other languages" - 10https://bugzilla.wikimedia.org/65825 (10Kunal Mehta (Legoktm)) 3NEW p:3Unprio s:3normal a:3None Plural is wrong, and it should be something like "Read in 1 other language". [17:35:42] YuviPanda: hang on, gotta make the WikipediaApp instance a singleton [17:37:47] (03CR) 10Dr0ptp4kt: "Hang on, going to submit PS8." (032 comments) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/131246 (owner: 10Dr0ptp4kt) [17:40:04] (03CR) 10JGonera: [C: 04-1] "Replied inline in patchset 3." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/134770 (https://bugzilla.wikimedia.org/65347) (owner: 10Kaldari) [17:42:16] (03CR) 10JGonera: [C: 04-1] "Thise removes EditorApi#getPreview so totally breaks the editor. I literally meant replacing one line there." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/135311 (https://bugzilla.wikimedia.org/60134) (owner: 10Florianschmidtwelzow) [17:42:30] (03PS8) 10Dr0ptp4kt: Add MCC-MNC once per app session on cellular. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/131246 [17:42:39] ^ YuviPanda ok, there, i think. [17:43:56] 3MobileFrontend / 3stable: Filter for New User uploads in Mobile Web - 10https://bugzilla.wikimedia.org/62598#c38 (10Maryana Pinchuk) It was good to try the EXIF filter for combatting low quality uploads, but it seems pretty clear that this isn't the right strategy for dealing with the issue. Lupo, I think y... [17:48:56] what's the time for the first public release of apps? [17:53:23] liangent1: 4th june for wide beta release, 25th for public public [17:55:52] jgonera: Don't see your new comments at https://gerrit.wikimedia.org/r/#/c/134770/3/less/modules/search/SearchOverlay.less [17:56:11] mobile web folks - can anyone confirm if the thumbnail patches (the one that removes the frames around images) is going to en wikipedia this week? [17:56:24] vbamba: yes, it is [17:56:43] jdlrobson: i took a quick look at your sellelo fixes. at quick glance looks OK. can i walk you through getting it up and running in tool labs later today? [17:56:47] vbamba: well actually I don't think it will be on en.wiki until lnext tuesday [17:56:52] awjr: sure [17:56:58] kaldari: will i see you in office today? [17:57:00] jdlrobson: cool i'll schedule some time this afternoon :) [17:57:04] vbamba: but it is merged now [17:57:16] kaldari: Yeah, cos I can't see it on mediawiki yet [17:57:26] jdlrobson: did you have a good trip back? [17:57:33] so its just waiting deployment? [17:57:48] jdlrobson: I don't know. The courthouse said I wasn't needed for the morning roll-call, but I might be needed for the afternoon roll-call, so I have to call them back after 11am. [17:58:04] vbamba: yes [17:58:26] vbamba: and that's only for mobile in stable mode [17:58:39] it's already that way for beta and alpha mode [17:59:24] (03CR) 10JGonera: "Gerrit is dumb." (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/134770 (https://bugzilla.wikimedia.org/65347) (owner: 10Kaldari) [17:59:30] awjr: yeh wasn't too bad. Still settling in ;-) [17:59:39] jdlrobson: unfortunately, the courthouse is in Oakland and if they need for the afternoon, I have to show up there at 1, so I can't leave Oakland for now [17:59:48] kaldari, sorry, try now, I sometimes forgot which of the dozen review buttons I have to click [17:59:54] forget* [18:00:06] jdlrobson: are you back at the office now? [18:00:14] kaldari: yup :) [18:00:41] vbamba, the ones for desktop or the ones for mobile stable? [18:01:50] YuviPanda: and any branching point? [18:02:03] or we'll just release a snapshot? [18:02:08] liangent1: not particularly. just see what master is on 4th, and push it out. [18:02:15] liangent1: you can see trello for what we have planned hto [18:02:19] https://trello.com/b/ez8tIIcj/mobile-app-sprint-32-android-beta-release [18:03:17] (03CR) 10Florianschmidtwelzow: "Damn :(" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/135311 (https://bugzilla.wikimedia.org/60134) (owner: 10Florianschmidtwelzow) [18:03:38] bearND: https://office.wikimedia.org/wiki/Office_IT [18:07:53] kaldari: not in SF but back in my office :) [18:09:05] awjr: wish I was there :) [18:09:20] kaldari: you'd love it, supposed to be 102F today [18:09:30] nice [18:12:04] awjr: can we push that meeting forward 30 mins? [18:12:11] i want to do the meditation at 12 and grab some lunch [18:12:18] jdlrobson: so 130? [18:12:23] yep that okay with you? [18:12:26] jdlrobson: totally [18:14:27] (03PS1) 10Dr0ptp4kt: Update MCC/MNC EL schema name to be consistent with mobile apps. [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/135599 [18:14:57] 3MobileFrontend / 3Feature requests: Include /* section title */ in edit summary for mobile section edits - 10https://bugzilla.wikimedia.org/60134#c8 (10Jon) Can I suggest we do not pre-fill the edit summary and instead auto prepend it programatically? I worry seeing /* Section History */ in an input box mi... [18:18:52] (03PS1) 10Jdlrobson: dev-scripts: Fix makegerrit command [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/135600 [18:19:56] 3MobileFrontend / 3Feature requests: Include /* section title */ in edit summary for mobile section edits - 10https://bugzilla.wikimedia.org/60134#c9 (10Florian) Hmm, it's an argument, the other side is, that, if we look at consistency between desktop and mobile edit, a pre filled summary with the section na... [18:21:40] YuviPanda: I see no change in css these days... is it not going to be turned back? [18:21:58] liangent1: the small font issue will be fixed tomorrow, I've a meeting with designers [18:22:03] liangent1: but no, the old styles are 'gone' [18:22:04] (03Abandoned) 10Jdlrobson: Hygiene: Update QA steps which take arguments [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/134511 (owner: 10Jdlrobson) [18:22:18] jdlrobson, jgonera: yay! I'm officially dismissed from jury service now! I'll be at the office after lunch. [18:22:27] ;) [18:22:48] YuviPanda: what about some other issues? [18:22:53] liangent1: like? [18:22:59] bgcolor? [18:23:06] jgonera: so what do you think about https://gerrit.wikimedia.org/r/#/c/134628/3/javascripts/modules/toc/toc.js ? [18:23:12] liangent1: it is just re-using mobilefrontend's css, but not including mobile.css [18:23:20] extlink arrow near cc-by-sa link? [18:23:29] liangent1: ah, that I shall fix presently. [18:24:33] (03CR) 10JGonera: Add clicktracking to table of contents (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/134628 (owner: 10Jdlrobson) [18:24:39] YuviPanda: re bgcolor issues: in the past, page bgcolor is the same as app bgcolor, but it's not the case anymore, causing a color change when a page is being loaded [18:25:00] liangent1: oh! can you file a separate bug? [18:25:57] (03CR) 10Jdlrobson: [C: 04-1] Promoting mobile typography changes from beta to stable: Part 2 (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/134978 (owner: 10Kaldari) [18:26:23] YuviPanda: what should I do with bug 65717 then? [18:26:36] liangent1: tracking bug? [18:27:57] YuviPanda: maybe [18:28:04] (03CR) 10Jdlrobson: [C: 032] Regression: fix trimmed cancel icon in drawers [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/135585 (owner: 10JGonera) [18:28:48] doing these things on a phone is a hassle [18:31:00] (03Merged) 10jenkins-bot: Regression: fix trimmed cancel icon in drawers [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/135585 (owner: 10JGonera) [18:32:16] (03PS4) 10Jdlrobson: Add clicktracking to table of contents [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/134628 [18:33:22] (03CR) 10Jdlrobson: "I think you'll find this error is unrelated and due to Ide6ef2a91f8f2915697ed186d8474a98e1da09af" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/134527 (owner: 10Jdlrobson) [18:33:26] (03PS5) 10Jdlrobson: Distinguish between VisualEditor and SourceEditor in event logging [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/134527 [18:33:38] (03CR) 10jenkins-bot: [V: 04-1] Add clicktracking to table of contents [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/134628 (owner: 10Jdlrobson) [18:33:40] (03CR) 10Jdlrobson: "@jgonera I've now rebased." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/134527 (owner: 10Jdlrobson) [18:40:56] 3Wikipedia App / 3Generic: Undefined in preview - 10https://bugzilla.wikimedia.org/65505 (10Maryana Pinchuk) 5PAT>3RES/FIX [18:40:57] heading out for a bit [18:43:41] jdlrobson: https://gerrit.wikimedia.org/r/#/c/135606/ – sorry, stupid mistake on my part. [18:43:56] jdlrobson: That should fix the "VE won't work at all on mobile" issue. [18:49:41] 3MobileFrontend / 3Feature requests: Link is missing from the 'Create the page ...' text on the search result page - 10https://bugzilla.wikimedia.org/65640#c24 (10Istvan Bujdoso) Yes. I use the version of REL1_22 branch. Something changes the link to span. At the end of the link() function (core MediaWiki f... [18:51:25] Yuvi|zzz: hmm, looks like the last build available thru play store was pushed on 5/22, and there were some bugs fixed after that [18:54:38] (03PS3) 10Jdlrobson: Enable expanding of section headings via space and enter keys in stable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/134814 [19:01:43] 3Wikipedia App / 3Generic: Font, spacing, & icon issues in new stylesheets - 10https://bugzilla.wikimedia.org/65717 (10Maryana Pinchuk) [19:03:27] 3Wikipedia App / 3Generic: Font, spacing, & icon issues in new stylesheets - 10https://bugzilla.wikimedia.org/65717#c3 (10Maryana Pinchuk) Changed to a slightly more NPOV bug description :) [19:03:51] Yuvi|zzz: nm, dbrant gave me the latest build :) [19:05:11] 3Wikipedia App / 3Generic: Font, spacing, & icon issues in new stylesheets - 10https://bugzilla.wikimedia.org/65717#c4 (10Liangent) To clarify the bgcolor issue (it's actually not specific to any page): in the past, page bgcolor is the same as app bgcolor, but it's not the case anymore, causing a color chang... [19:05:56] 3Wikipedia App / 3Search: Android: If you search in the app with no network access, it crashes! - 10https://bugzilla.wikimedia.org/65686 (10Maryana Pinchuk) 5NEW>3RES/FIX [19:06:27] 3Wikipedia App / 3Generic: Android: If you start the app after an update with no network access, it crashes! - 10https://bugzilla.wikimedia.org/65685 (10Maryana Pinchuk) 5NEW>3RES/FIX [19:09:26] 3MobileFrontend / 3stable: Filter for New User uploads in Mobile Web - 10https://bugzilla.wikimedia.org/62598#c39 (10Lupo) (In reply to Maryana Pinchuk from comment #38) > We're going to try limiting mobile web uploading to autoconfirmed users, Limiting this to autoconfirmed users is certainly worth a try.... [19:19:56] 3Wikipedia App / 3iOS App: iOS App: Left drawer should animate from right instead of left - 10https://bugzilla.wikimedia.org/64336 (10Maryana Pinchuk) 5NEW>3RES/FIX [19:20:30] (03PS1) 10Mhurd: New primary "W" menu and secondary lesser-used-items menu. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/135612 [19:20:52] brion: ^ it’s a monster :) [19:23:41] 3Wikipedia App / 3iOS App: iOS App: Scrolling does not automatically show/hide search bar + navigation buttons - 10https://bugzilla.wikimedia.org/65822#c1 (10Maryana Pinchuk) Yeah, we were originally going to experiment with a few different options for chrome behavior (always persistent, hide both top and bo... [19:25:12] 3Wikipedia App / 3iOS App: iOS App: "W" menu needs reorganization - 10https://bugzilla.wikimedia.org/65824#c1 (10Maryana Pinchuk) This page was just a placeholder :) The new design, which should be implemented in the next week or so, is here: https://trello.com/c/6OUSUp5G/20-3-as-a-user-i-can-have-useful-ite... [19:39:03] (03PS2) 10Mhurd: New primary "W" menu and secondary lesser-used-items menu. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/135612 [19:57:19] (03PS3) 10Mhurd: New primary "W" menu and secondary lesser-used-items menu. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/135612 [20:01:26] 3MobileFrontend / 3Feature requests: Link is missing from the 'Create the page ...' text on the search result page - 10https://bugzilla.wikimedia.org/65640#c25 (10Florian) > But the output in the browser is a span: This is exactly that, what this function has to do ;) Look at this change: https://gerrit.wik... [20:02:08] (03PS4) 10Mhurd: New primary "W" menu and secondary lesser-used-items menu. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/135612 [20:10:55] dbrant: mhurd: Here's the Show Desktop app for Mac: http://www.everydaysoftware.net/showdesktop/. You can change the settings to just have it show up in the menu bar. If you click the icon it hides all your windows [20:14:26] 3Wikipedia App / 3iOS App: iOS App: "W" menu needs reorganization - 10https://bugzilla.wikimedia.org/65824#c2 (10Kunal Mehta (Legoktm)) Looks better for the most part. Is the black background in the second step just for the mockup? I hope that isn't intended in the actual design. Where are the "save foo for... [20:15:43] bearND: ooh thanks! [20:15:56] 3Wikipedia App / 3iOS App: iOS App: Table of contents drawer should animate from right instead of left - 10https://bugzilla.wikimedia.org/64336#c6 (10Kunal Mehta (Legoktm)) 5RES/FIX>3REO Sorry about the confusion, the original bug May reported is fixed now, but the one I re-purposed this bug for is still... [20:25:41] 3Wikipedia App / 3iOS App: iOS app: Missing home / go to Main Page button - 10https://bugzilla.wikimedia.org/64394 (10Kunal Mehta (Legoktm)) [20:25:56] 3Wikipedia App / 3iOS App: iOS app: Credits screen needs improvement - 10https://bugzilla.wikimedia.org/64391 (10Kunal Mehta (Legoktm)) [20:26:06] (03CR) 10MaxSem: [C: 032] dev-scripts: Fix makegerrit command [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/135600 (owner: 10Jdlrobson) [20:26:11] 3Wikipedia App / 3iOS App: iOS app: Should have a "clear all" button for browsing history - 10https://bugzilla.wikimedia.org/63970 (10Kunal Mehta (Legoktm)) [20:26:48] (03Merged) 10jenkins-bot: dev-scripts: Fix makegerrit command [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/135600 (owner: 10Jdlrobson) [20:27:11] 3Wikipedia App / 3iOS App: Disable iOS autocorrect for captchas - 10https://bugzilla.wikimedia.org/60707 (10Kunal Mehta (Legoktm)) [20:27:12] 3Wikipedia App / 3iOS App: iOS autocorrect not enabled for edit summary - 10https://bugzilla.wikimedia.org/62574 (10Kunal Mehta (Legoktm)) [20:27:26] 3Wikipedia App / 3iOS App: iOS app: "Log out [username]" does not normalize username - 10https://bugzilla.wikimedia.org/63969 (10Kunal Mehta (Legoktm)) [20:27:26] 3Wikipedia App / 3iOS App: iOS app doesn't support {{DISPLAYTITLE:}} - 10https://bugzilla.wikimedia.org/63971 (10Kunal Mehta (Legoktm)) [20:27:41] 3Wikipedia App / 3iOS App: iOS app: Clicking on an image in an article no longer goes to file description page - 10https://bugzilla.wikimedia.org/64389 (10Kunal Mehta (Legoktm)) [20:27:41] 3Wikipedia App / 3iOS App: iOS: Special pages do nothing when clicked - 10https://bugzilla.wikimedia.org/63973 (10Kunal Mehta (Legoktm)) [20:27:56] 3Wikipedia App / 3iOS App: iOS app: Clicking on an image in an article no longer goes to file description page - 10https://bugzilla.wikimedia.org/64389#c1 (10Kunal Mehta (Legoktm)) 5NEW>3RES/WOR This seems to work again. [20:28:11] 3Wikipedia App / 3iOS App: iOS App: If a page is saved, "Save foo for offline reading" menu item is still visible - 10https://bugzilla.wikimedia.org/65107 (10Kunal Mehta (Legoktm)) [20:28:26] 3Wikipedia App / 3iOS App: iOS App: Make sure that app updates don't wipe saved pages. - 10https://bugzilla.wikimedia.org/65106 (10Kunal Mehta (Legoktm)) [20:28:27] 3Wikipedia App / 3iOS App: iOS App: Links to sections don't work, and anchor shows up in title - 10https://bugzilla.wikimedia.org/65108 (10Kunal Mehta (Legoktm)) [20:29:02] jdlrobson: yt? [20:29:51] MaxSem: do you know how to get someone added to tool labs? [20:30:12] i'd like to add jon as a maintainer for bingle/bugello but he doesn't appear to be a part of the tool labs project [20:30:20] (03CR) 10Brion VIBBER: "I'm not sure if this is desired behavior, but I notice if I tap into one of the popup sheets from the "..." more menu, then close it, I go" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/135612 (owner: 10Mhurd) [20:37:22] awjr, ask in #-labs? [20:37:32] MaxSem: yeah thanks, got it sorted there already :) [20:37:58] Maryana: any luck pulling those user interviews for me about apps ? [20:41:01] (03CR) 10MaxSem: [C: 04-2] "Blocking merge for now." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/134978 (owner: 10Kaldari) [20:49:24] (03CR) 10Brion VIBBER: [C: 032 V: 032] "Ok no other major surprises, let's merge and see what happens! Nav controller bits will be cleaned up in future per checkin with monte." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/135612 (owner: 10Mhurd) [20:53:50] Maryana: the “W” menu ios story has been merged and is ready for signoff. cutting beta release now [21:03:18] (03PS2) 10Jdlrobson: Reduce page_props usage [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/134858 (owner: 10MaxSem) [21:03:38] (03CR) 10Jdlrobson: [C: 032] "After talking to Max about my concern I'm happy to merge." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/134858 (owner: 10MaxSem) [21:04:52] (03Merged) 10jenkins-bot: Reduce page_props usage [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/134858 (owner: 10MaxSem) [21:08:35] (03CR) 10Mattflaschen: "Thanks for following up in your upstream repo. When you import it here, also update the URL (currently https://github.com/shahyar/Storer." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/131897 (owner: 10Kaldari) [21:09:30] (03CR) 10Jdlrobson: [C: 04-1] Introducing new "wgMFRemoveRedlinks" config (033 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/135120 (https://bugzilla.wikimedia.org/65640) (owner: 10Florianschmidtwelzow) [21:13:22] (03PS9) 10Jdlrobson: Rewrite Nearby as a PageList [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/130270 [21:13:35] (03CR) 10Jdlrobson: [C: 032] "Done and done." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/130270 (owner: 10Jdlrobson) [21:15:35] (03PS5) 10Jdlrobson: Add clicktracking to table of contents [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/134628 [21:16:09] (03Merged) 10jenkins-bot: Rewrite Nearby as a PageList [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/130270 (owner: 10Jdlrobson) [21:17:48] (03CR) 10Jdlrobson: [C: 031] Fixing thumbnail sizing in search overlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/134770 (https://bugzilla.wikimedia.org/65347) (owner: 10Kaldari) [21:19:30] (03CR) 10Jdlrobson: [C: 04-1] "Ideally this change should be done in core and in the HTML." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/135288 (https://bugzilla.wikimedia.org/48996) (owner: 10Florianschmidtwelzow) [21:26:08] (03CR) 10Florianschmidtwelzow: Introducing new "wgMFRemoveRedlinks" config (033 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/135120 (https://bugzilla.wikimedia.org/65640) (owner: 10Florianschmidtwelzow) [21:26:12] (03PS4) 10Florianschmidtwelzow: Introducing new "wgMFRemoveRedlinks" config [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/135120 (https://bugzilla.wikimedia.org/65640) [21:38:38] (03CR) 10Florianschmidtwelzow: "You mean to enable configuration in core, if the image is clickable (and/or only a little magnifying glass graphic to show full image) or " [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/135288 (https://bugzilla.wikimedia.org/48996) (owner: 10Florianschmidtwelzow) [21:44:47] (03CR) 10MaxSem: "I think there still might be need for this variable, e.g. MF and GeoData are installed but GD is not properly configured and thus Nearby i" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/135308 (https://bugzilla.wikimedia.org/64029) (owner: 10Florianschmidtwelzow) [21:52:47] dbrant: bearND Maryana are we recording anything else in the wikipedia app past https://meta.wikimedia.org/wiki/Schema:MobileWikiAppEdit ? [21:53:11] 3Wikipedia App / 3iOS App: iOS App: "W" menu needs reorganization - 10https://bugzilla.wikimedia.org/65824#c3 (10Kunal Mehta (Legoktm)) (In reply to Kunal Mehta (Legoktm) from comment #2) > Looks better for the most part. Is the black background in the second step > just for the mockup? I hope that isn't int... [21:53:48] tfinc: https://meta.wikimedia.org/wiki/Schema:MobileWikiAppCreateAccount https://meta.wikimedia.org/wiki/Schema:MobileWikiAppReadingAction https://meta.wikimedia.org/wiki/Schema:MobileWikiAppLogin [21:53:56] mhurd: thanks [21:54:14] mhurd: is there a category that i could look at to see all of them together ? [22:03:14] tfinc: hmm i don’t know [22:11:33] (03CR) 10Kaldari: "See reply in patch 3." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/134770 (https://bugzilla.wikimedia.org/65347) (owner: 10Kaldari) [22:15:14] 3Wikipedia App / 3iOS App: iOS App: Re-add copy url functionality - 10https://bugzilla.wikimedia.org/65835 (10Kunal Mehta (Legoktm)) 3NEW p:3Unprio s:3major a:3None Beta #20 got rid of the "copy url" functionality which was in previous betas. It was kinda broken (it copied more than the url), but it... [22:38:01] (03PS1) 10MaxSem: Fix fatal when using Minerva directly, outside of mobile view [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/135709 (https://bugzilla.wikimedia.org/65749) [22:38:56] 3Wikipedia App / 3iOS App: iOS App: "W" menu needs reorganization - 10https://bugzilla.wikimedia.org/65824#c4 (10Vibha Bamba) Kunal, You make a reasonable point here, We are actually using black backgrounds fairly conservatively. it is meant to clearly distinguish selection areas from content screens. [22:42:56] 3Wikipedia App / 3iOS App: iOS App: "W" menu needs reorganization - 10https://bugzilla.wikimedia.org/65824#c5 (10Vibha Bamba) In the final design which comes out in the next build, Save is punted to the default IOS Share sheet. The Edit History is at the very bottom of the article. See Language and Edit Hist... [22:44:19] (03PS5) 10Kaldari: Fixing thumbnail sizing in search overlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/134770 (https://bugzilla.wikimedia.org/65347) [22:46:03] kaldari: are you working 5/29 or will you be off on vacation? [22:46:23] awjr: I'm on vacation [22:46:42] kaldari: ok thanks [22:47:07] kaldari: can you take a look at https://gerrit.wikimedia.org/r/#/c/134527/ [22:47:54] (03PS6) 10Kaldari: Fixing thumbnail sizing in search overlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/134770 (https://bugzilla.wikimedia.org/65347) [22:49:50] sure [22:57:56] 3Wikipedia App / 3iOS App: iOS App: "W" menu needs reorganization - 10https://bugzilla.wikimedia.org/65824#c6 (10Kunal Mehta (Legoktm)) (In reply to Vibha Bamba from comment #4) > Kunal, You make a reasonable point here, We are actually using black > backgrounds fairly conservatively. it is meant to clearly... [23:16:08] (03CR) 10Kaldari: [C: 031] "Seems to work for me." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/134527 (owner: 10Jdlrobson) [23:19:26] 3Wikipedia App / 3iOS App: iOS App: If a page is saved, I can save it again and again - 10https://bugzilla.wikimedia.org/65107#c1 (10Maryana Pinchuk) The UI on this has changed a bit (you now save from the in-article chrome "share" icon), but the underlying issue remains that you can save a page multiple tim... [23:24:28] 3MobileFrontend / 3beta: Exception thrown by mobile.toc - stops table of contents from loading - 10https://bugzilla.wikimedia.org/65838 (10Jon) 3NEW p:3Unprio s:3normal a:3None Go to http://en.m.wikipedia.beta.wmflabs.org/wiki/Forty-seven_Ronin?mobileaction=alpha Exception thrown by mobile.toc load.... [23:24:56] 3MobileFrontend / 3alpha: toggle to VE makes UI spin forever, no VE, js error - 10https://bugzilla.wikimedia.org/65810#c2 (10Jon) 5NEW>3RES/INV This is bug 65823 but the JavaScript error is unrelated to that and actually bug 65838 [23:25:26] 3MobileFrontend / 3beta: Exception thrown by mobile.toc - stops table of contents from loading - 10https://bugzilla.wikimedia.org/65838#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/8IWP0SBH [23:26:24] (03CR) 10Jdlrobson: [C: 032] Fix fatal when using Minerva directly, outside of mobile view [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/135709 (https://bugzilla.wikimedia.org/65749) (owner: 10MaxSem) [23:26:41] 3MobileFrontend / 3General/Unknown: Fatal error: Cannot unset string offsets at SkinTemplate.php on line 1878 - 10https://bugzilla.wikimedia.org/65749 (10Jon) 5PAT>3RES/FIX [23:27:10] (03Merged) 10jenkins-bot: Fix fatal when using Minerva directly, outside of mobile view [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/135709 (https://bugzilla.wikimedia.org/65749) (owner: 10MaxSem) [23:27:40] awjr: finishing up your candidates feedback now [23:27:57] 3MobileFrontend / 3alpha: VE citations: Cannot scroll long citation dialog boxes - 10https://bugzilla.wikimedia.org/65504 (10Jon) 5PAT>3RES/FIX [23:31:13] tfinc: gonna be a sec late [23:31:14] (03PS1) 10Mhurd: Article image appears when sharing items via mail, Facebook etc. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/135719 [23:32:05] (03PS2) 10Mhurd: Article image appears when sharing items via mail, Facebook etc. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/135719 [23:42:57] tfinc: re: what we are recording, https://meta.wikimedia.org/w/index.php?title=Special%3APrefixIndex&prefix=MobileWikiApp&namespace=470 has list [23:48:19] (03CR) 10BearND: [C: 04-1] "compilation fails:" (031 comment) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/135506 (owner: 10Yuvipanda) [23:49:02] bearND: gah! [23:49:02] (03PS6) 10Yuvipanda: Display message about protection status when editing [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/135506 [23:49:04] stupid imports [23:49:06] bearND: fixed [23:49:43] (03CR) 10Jdlrobson: [C: 032] Fixing thumbnail sizing in search overlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/134770 (https://bugzilla.wikimedia.org/65347) (owner: 10Kaldari) [23:50:18] (03Merged) 10jenkins-bot: Fixing thumbnail sizing in search overlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/134770 (https://bugzilla.wikimedia.org/65347) (owner: 10Kaldari) [23:51:23] (03PS1) 10Dbrant: [WIP] implement nav tweaks. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/135721 [23:54:57] 3MobileFrontend / 3stable: Search page images misaligned - 10https://bugzilla.wikimedia.org/65347 (10Jon) 5PAT>3RES/FIX [23:55:59] (03PS1) 10Jdlrobson: Use same options for VisualEditor and Editor overlays [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/135722 (https://bugzilla.wikimedia.org/65587) [23:58:26] awjr: https://trello.com/c/XBr2mK0k/303-tablet-edits-to-desktop-site