[00:00:01] (03Merged) 10jenkins-bot: Regression: Fix MobileWebEditing schema - add funnel [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/135966 (https://bugzilla.wikimedia.org/65884) (owner: 10Jdlrobson) [00:01:16] vbamba: tried it out? :) [00:02:46] YuviPanda: o/ [00:08:07] yurik, you still there? i'm ready to +2 https://gerrit.wikimedia.org/r/#/c/133029 but wanted to make sure it was okay for release timing for you to do so [00:08:33] dr0ptp4kt, go ahead, it shouldn't cause any issues... i hope [00:08:40] :) [00:08:47] besides, this way it will get tested on beta ;) [00:09:15] dr0ptp4kt: heya! am going to merge the mcc patch now :) [00:09:42] yurik, you know what. do extra Vary items need to be added? [00:09:45] YuviPanda: thx [00:09:58] dr0ptp4kt, which items? [00:11:20] er um er. um. would x-cs be needed given that the redirect behavior would vary upon that? the caller varies on X-Proto, and the URL would otherwise be varied on, but what about X-CS? also, what about X-Subdomain? [00:11:28] yurik, sorry, just hit me [00:12:44] yurik, perhaps onBeforePageDisplay handles this up front, lemme see the order in which it executes [00:13:05] dr0ptp4kt, oh, right... good point... it might not be executed - this hook runs before everything else [00:14:40] YuviPanda: yes [00:14:51] compared it with mobile web on android too [00:17:05] (03PS2) 10Mhurd: Refactor modal views. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/135956 [00:17:37] looks good, feel like the text size could be a tad bigger [00:17:42] Kaity is looking at it too [00:18:45] vbamba: ok! it's exactly the same, fwiw. Chrome tells me so, but haven't done a visual test. [00:21:44] ok yurik, yeah, please do add vary on x-cs and x-subdomain. i suppose technically speaking for the time being x-forwarded-by should be varied upon as well. [00:22:44] YuviPanda: Its totally consistent with web on android. But wondering if both web and app should be a tad bigger. [00:24:39] vbamba: ah, right. [00:26:37] dr0ptp4kt, will do in a bit [00:26:58] yurik, thx. good luck. this makes my head hurt [00:28:19] YuviPanda: vbamba yes I agree! [00:29:45] kaity: vbamba if you change it for mobilefrontend it'll automagically change for the apps as well :) [00:33:09] kaity: we shd sync with moizsyed and violetto on type size [00:35:46] prtksxna: around? [00:35:50] prtksxna: am merging patches. [00:35:54] vbamba: ^ [00:38:29] thanks YuviPanda! prtksxna said he would email tomorrow. [00:38:56] vbamba: ah, hmm. ideally I'd like to have prtksxna around when merging, but I'll be in a bus all day tomorrow, and he'll be asleep when I wake up. [00:42:10] (03PS3) 10Mhurd: Refactor modal views. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/135956 [00:45:42] YuviPanda: Fair Enough [00:46:02] vbamba: :) I'll be around on Friday, though. I'll try to get to them asap. [00:46:09] prtksxna: primarily, have you tested all these? :P [00:48:41] 3MobileFrontend / 3alpha: No validation on VE add reference form - 10https://bugzilla.wikimedia.org/65864#c3 (10Arthur Richards) 5NEW>3RES/INV It wasn't - I've captured this in a story card: https://trello.com/c/9d7EY0NE/102-validate-input-for-ve-reference-workflow Resolving this as invalid as it is not... [00:55:11] 3Wikipedia App / 3Generic: Font, spacing, & icon issues in new stylesheets - 10https://bugzilla.wikimedia.org/65717#c5 (10Yuvi Panda) To be fair to liangent, they *were* ugly for a while because they were incomplete :) font size and line height should be fixed now. The external link icon in footer should be... [00:58:53] YuviPanda: there? [00:58:57] vbamba: yup [00:59:13] why do action bar icons have 3 folder sizes for android? [00:59:42] vbamba: for different pixel densities. some phones will have lower res, some higher, and android choses appropriately [00:59:56] vbamba: however, you just have to give us svgs of appropriate aspect ratios, and those folders with pngs will be automatically generated [01:00:13] vbamba: see https://github.com/wikimedia/apps-android-wikipedia/tree/master/icon-svgs for the other svg icons we have. [01:01:51] YuviPanda: i think the question is more about why we have different folders for the icon-svg files? [01:02:03] bearND: vbamba oh *that*. [01:02:23] YuviPanda: bearND dbrant and I were just discussing [01:02:26] bearND: those are the icon sizes that are generated. they aren't all actionbar icons - some are smaller (like the small icons used in history view) [01:02:39] bearND: so they'll be in 24, I believe. and some are larger (like the app icon itself) [01:03:02] bearND: if you see the script that generates pngs, (scripts/convert-icons.py it uses those as a hint as to what size icons to generate. [01:04:04] bearND: some of them are also marked 'noflip', which means separate LTR and RTL versions won't be generated [01:04:05] vbamba: ^ [01:08:47] YuviPanda: thanks, bbl [01:08:54] bearND: ok! [01:49:56] YuviPanda: still around? [01:49:59] prtksxna: ya [01:50:02] prtksxna: not4long [01:50:05] but tell [01:50:12] YuviPanda: All are tested, yes [01:50:20] prtksxna: kk [01:50:34] YuviPanda: The three in relating to animation classes are important [01:50:51] ok. I'll try to merge them tomorrow or friday, more probably friday [01:51:31] YuviPanda: Cool, I'll email spagewmf too [01:51:37] prtksxna: ok [01:52:12] 3Wikipedia App / 3iOS App: iOS App: Re-add copy url functionality - 10https://bugzilla.wikimedia.org/65835#c1 (10Kunal Mehta (Legoktm)) Release notes for #21 say it was re-added, but I don't see it? [02:53:20] (03CR) 10Yuvipanda: [C: 032] Remove unnecessary import [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/135785 (owner: 10BearND) [02:54:51] (03Merged) 10jenkins-bot: Remove unnecessary import [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/135785 (owner: 10BearND) [03:59:57] YuviPanda: when do you sleep? [04:00:07] vbamba: not yet, apparently :) [04:00:16] vbamba: have a bus in 3h, figured it'd be easier to just stay up and sleep in th ebus [04:00:18] *the bus [04:00:30] doing the about page story now, and following some wikidrama [04:00:33] vbamba: 'sup [04:10:05] vbamba: what's up? [04:10:16] vbamba: did you guys go to dinner with dbrant and bearND? [04:15:07] yes, correct, we went for dinner. [04:15:51] Yuvi, sleep deficit will catch up you know. [04:15:55] You cant just not sleep. [04:15:59] :) [04:18:53] (03PS4) 10Mhurd: Refactor modal views. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/135956 [04:18:54] vbamba: :) [04:19:00] vbamba: I will sleep on the bus [04:22:59] YuviPanda: just saw prateeks comment on a hovercards bug. https://bugzilla.wikimedia.org/show_bug.cgi?id=65433 [04:24:00] vbamba: cool! I'll try to test them as well [04:37:53] (03PS5) 10Mhurd: Refactor modal views. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/135956 [04:41:33] hey bearND! [04:42:26] 3Wikipedia App / 3iOS App: iOS App: Re-add copy url functionality - 10https://bugzilla.wikimedia.org/65835#c2 (10Kunal Mehta (Legoktm)) 5NEW>3RES/FIX Re-added in #22. Thank you! :D [04:44:14] hey YuviPanda! good morning [04:44:23] bearND: haven't slept yet :D have a bus in a few hours. [04:44:30] bearND: nice evening out? :) [04:45:25] YuviPanda: wow. that's wild. oh, you're traveling again. [04:45:50] bearND: still in the UK, yeah. [04:45:54] bearND: London to Glasgow [04:46:08] yes it was a nice evening. [04:46:19] bearND: :) been to SF before? [04:46:21] now i'm back in the hotel [04:47:00] yes, this is my fourth time. the first two were long time ago, though (2001 + 02) for JavaOne [04:47:22] great city [04:47:40] bearND: :D yeah, quite awesome [04:49:53] are you planning to sleep on the bus? [04:50:18] i can't believe you're still up [04:50:26] bearND: I am planning on sleeping on the bus, yeah [04:50:32] bearND: I keep odd hours, usually :) [04:50:34] hard core [04:51:34] bearND: :) [04:51:43] bearND: did my explanation of the svg folder names make sense? [04:52:37] YuviPanda: still need to check out more of the script. when you explained earlier we were all about to leave the office [04:52:45] bearND: yeah, figured :) [04:56:22] YuviPanda: so in 48 we basically have the launcher icon. just not sure what the general themes for 24 and 32 are. Looks like 32 is for the little indicators for history screen. [04:56:44] YuviPanda: do you have a recommendation for an svg viewer on mac? [04:56:54] bearND: firefox? or chrome? [04:57:05] or safari.. [05:01:25] YuviPanda: cool. there are a bunch of ending in _white.svg in 24. what are they for and how to best view them. in Chrome they seem just white on white. 32 has a bunch of png's. i guess they were added by accident, but at least those are the easiest to view [05:02:02] bearND: oh, the pngs shouldn't exist. no idea how they got there :| [05:02:39] bearND: others use inkscape, which is free and has other capabilities as well [05:02:43] 3MobileFrontend / 3stable: Nearby broken on commons - 10https://bugzilla.wikimedia.org/65888 (10Jon) 3NEW p:3Unprio s:3normal a:3None maybe a good thing but this is a regression... never shows any results :) [05:04:05] (03CR) 10Mhurd: "Added a couple small notes. Looks like a great start!!!" (033 comments) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/135885 (owner: 10Brion VIBBER) [05:05:26] 3MobileFrontend / 3stable: Nearby broken on commons - 10https://bugzilla.wikimedia.org/65888#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/D449gVrS [05:08:35] YuviPanda: Thanks for the tip about inkscape. now i can view the svg previews. still wondering what's up with the white svgs in 24 [05:09:28] bearND: YuviPanda: i’ve been using a inkscape and a command i found here http://throwachair.com/2013/10/26/generate-all-your-ios-app-icons-with-svg-and-inkscape/ for generating a variety of png resolutions from a svg for all of the various icon sizes ios requires. it’s pretty slick [05:10:52] *inkscape* not *a inkscape* :) [05:31:25] bearND: which ones? [05:34:20] YuviPanda: clock_white.svg, gear_white.svg, … [05:34:32] face_sleep_white [05:34:45] bearND: aaah. they are for the left nav, and since they are on a dark background they are all white themselves [05:48:36] YuviPanda: yes, makes sense. any tips for viewing those directly as svgs in Finder? if not no worries. we've got the png's as well. not sure if i'm using inkscape as intented. i basically just use it though the Finder preview. when i start inkscape i had to pint it to XQuartz, and when i click again it goes to X11. [05:55:47] bearND: no, haven't managed. mostly just convert them and view the pngs :D [05:56:02] bearND: you can always look at the equivalent pngs in res/drawable-* [05:56:46] (03CR) 10Yuvipanda: [C: 032] Add MCC-MNC once per app session on cellular. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/131246 (owner: 10Dr0ptp4kt) [05:57:35] (03Merged) 10jenkins-bot: Add MCC-MNC once per app session on cellular. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/131246 (owner: 10Dr0ptp4kt) [06:01:15] YuviPanda: thanks. np. yeah, just checking in case there was something simple i missed. still so many new things to learn. anyways, it's getting later here as well. so, i'm going to sign out soon. Thank you for your help! Safe travels! [07:07:41] 3MobileFrontend / 3stable: Nearby broken on commons - 10https://bugzilla.wikimedia.org/65888#c2 (10Max Semenik) 5NEW>3RES/INV Can't really blame it - all coordinates on Commons are secondary :P Started a discussion at https://commons.wikimedia.org/wiki/Module_talk:Coordinates#Mark_primary_coordinates_as_... [08:50:56] 3Wikipedia App / 3Android App: Redirects to main page (WP:MAIN) appear empty - 10https://bugzilla.wikimedia.org/65880 (10Andre Klapper) [09:00:42] 3MobileFrontend / 3Hygiene: $wgMFNearby shouldn't exist - 10https://bugzilla.wikimedia.org/64029#c5 (10Andre Klapper) (In reply to Jon from comment #3) > Not sure why it was assigned to me :) Jon: Because the default assignee of hygiene is you and that component (and its default assignee) was set up on 2014... [11:00:56] 3Wikipedia App / 3Generic: Font, spacing, & icon issues in new stylesheets - 10https://bugzilla.wikimedia.org/65717#c6 (10Liangent) (In reply to Yuvi Panda from comment #5) > The external link icon in > footer should be removed soon (patch in gerrit now). For the record, https://gerrit.wikimedia.org/r/#/c/1... [13:53:41] 3MobileFrontend / 3stable: Nearby broken on commons - 10https://bugzilla.wikimedia.org/65888#c3 (10Jon) 5RESO/INV>3REOP We should probably remove the feature then instead of serving broken feature. Let's keep this open until we've done something. [16:20:26] 3MobileFrontend / 3Feature requests: Allow configuration of the mobilefrontend menu - 10https://bugzilla.wikimedia.org/63459#c3 (10Jon) Note: this would be useful to disable nearby on Commons (see bug 65888) [16:57:49] jdlrobson, there's no reply to my comment here: https://gerrit.wikimedia.org/r/#/c/134527/4/includes/MobileFrontend.hooks.php [17:01:50] jgonera: looking [17:01:59] sigh.. gerrit drafts [17:02:06] (03CR) 10Jdlrobson: Distinguish between VisualEditor and SourceEditor in event logging (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/134527 (owner: 10Jdlrobson) [17:06:31] (03CR) 10JGonera: [C: 032] Distinguish between VisualEditor and SourceEditor in event logging [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/134527 (owner: 10Jdlrobson) [17:07:02] jdlrobson, is kaldari on vacation now? [17:08:52] (03Merged) 10jenkins-bot: Distinguish between VisualEditor and SourceEditor in event logging [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/134527 (owner: 10Jdlrobson) [17:09:18] jgonera: so i guess that means you weren't bothered about that schema concern? [17:09:23] and yeh kaldari is on vacation now :( [17:09:26] yeah, it's fine [17:09:43] jdlrobson, can you check https://gerrit.wikimedia.org/r/#/c/134978/ today? let's tweak it ourselves if you find that something's wrong [17:10:03] of course. although i didn't realize performance stuff was due today [17:10:08] so today is now going to be manic :( [17:10:22] performance stuff? [17:10:41] [Wmfall] Upcoming Annual Review deadlines and events [17:11:11] rummana is working on the performance stuff jdlrobson jgonera [17:11:17] oh crap... didn't they use to send this as a personal email instead of a mailing list? [17:11:29] awjr, jdlrobson means annual review [17:11:33] oh [17:11:34] lol [17:11:37] yes that too [17:18:21] (03PS3) 10Florianschmidtwelzow: Allow customization of page action buttons [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/135793 (https://bugzilla.wikimedia.org/63458) [17:18:43] (03CR) 10Florianschmidtwelzow: Allow customization of page action buttons (038 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/135793 (https://bugzilla.wikimedia.org/63458) (owner: 10Florianschmidtwelzow) [17:19:25] jdlrobson, the annual review forms don't look that bad [17:19:29] unless I missed some [17:21:44] (03PS4) 10Florianschmidtwelzow: Allow customization of page action buttons [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/135793 (https://bugzilla.wikimedia.org/63458) [17:27:28] (03PS4) 10Florianschmidtwelzow: Deprecate $wgMFNearby [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/135308 (https://bugzilla.wikimedia.org/64029) [17:27:59] (03PS5) 10Florianschmidtwelzow: Deprecate $wgMFNearby [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/135308 (https://bugzilla.wikimedia.org/64029) [17:29:25] MaxSem: do we need to LD that 500 error you found? [17:29:40] which one> [17:29:43] Fix fatal when using Minerva directly, outside of mobile view [17:29:53] Change id Ibf352d2dac90e9bacc7bf0083e5b60b0d2e164b1 [17:29:57] meh, doesn't look widespread [17:30:01] k [17:30:12] * MaxSem looks again [17:30:44] Posting the link https://en.wikipedia.org/wiki/San_Francisco?useskin=minerva will get it indexed and more widespread ;-) [17:39:11] 3MobileFrontend / 3Feature requests: Allow configuration of the mobilefrontend menu - 10https://bugzilla.wikimedia.org/63459#c4 (10Florian) Hmm, the question is, what would you exactly do? Only hide elements, you don't need? (Random Page, Home etc.) or add elements too? [17:44:14] I'm looking at this: https://trello.com/c/1hWk5SfP/5-make-sure-arabic-wikipedia-is-displayed-as-rtl [17:44:21] It's not working for me. [17:44:30] Is it just that there's no build for this yet? [17:45:05] Deskana: yeah no build [17:45:17] Deskana: also hi! [17:45:22] Hey Yuvi|zzz. :) [17:45:36] It's 6:45pm in the UK. You shouldn't be sleeping. :P [17:46:00] Deskana: was in a bus. plus i went to sleep at 8:30AM [17:52:07] YuviPanda: Not speaking as a mobile PM, there are a few patches in Hovercards that need reviewing if you have time. [17:52:24] YuviPanda: If you don't, I'll post on wikitech-l asking for help. Prateek said that was quite successful last time. [17:53:14] Deskana: I think YuviPanda said he might have time on Friday to look at them [17:53:25] A wild Prateek appears! [17:53:27] Deskana: I merged one yesterday, didn't want to merge today because merging right before deploy train bad. [17:53:30] Deskana: will merge tomorrow [17:53:30] Deskana: Post to wikitech-l after that maybe? [17:53:41] YuviPanda, prtksxna: All sounds good to me. Thanks! [17:53:45] Deskana: yw! [17:53:46] * prtksxna uses tail whip [17:53:49] Its super effective! [17:54:04] Deskana: all that's needed is for you to become labs PM and then you'll be PM in all the things I'm involved in! :) [17:54:17] Someone did try and solicit me to do that... [17:54:19] I forget who. [17:54:28] sumanah or coren perhaps. [17:54:57] Deskana: did they succeed? :) [17:55:09] Oh yeah, it was Sumana. [17:55:19] Not really! I was very new at the time and felt a bit overwhelmed by it. [17:55:29] YuviPanda: We might have solved the extract size issue involving multiple scripts [18:00:39] mhurd: were waiting on you and brion [18:01:53] hey brion [18:01:57] brion: retrospective [18:02:12] yurik: i'll be on standup shortly [18:02:14] moment [18:05:16] 3MobileFrontend / 3Feature requests: Allow configuration of the mobilefrontend menu - 10https://bugzilla.wikimedia.org/63459#c5 (10Jon) Max what would you suggest? I wonder if a hook on prepareDiscoveryTools and preparePersonalTools would suffice. An alternative approach would be a series of global variable... [18:11:30] jgonera: when are we pushing the new notification tablet styles to stable? [18:11:41] jdlrobson, good question [18:11:47] (03PS10) 10Jdlrobson: Promoting mobile typography changes from beta to stable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/134978 (owner: 10Kaldari) [18:11:51] it's not in the typography story [18:11:56] is there a card for the next iteration? [18:11:59] Maryana, ^ [18:12:02] (03CR) 10Jdlrobson: [C: 032] "Meets acceptance criteria" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/134978 (owner: 10Kaldari) [18:12:23] jgonera: isn't that in this sprint? [18:12:41] Maryana, can't see it there [18:12:56] Maryana, shouldn't be a complicated story [18:13:03] jgonera: https://trello.com/c/GPwMmp0E/11-5-typography-changes-to-stable [18:13:07] Maryana: it could have been in the typography story but it wasn't listed as a requirement [18:13:15] 3MobileFrontend / 3Feature requests: Allow configuration of the mobilefrontend menu - 10https://bugzilla.wikimedia.org/63459#c6 (10Florian) > I'd hold off any sort of patch until we work out how this would work. Totally agree :) > I wonder if a hook on prepareDiscoveryTools and preparePersonalTools would su... [18:13:17] yeah [18:13:19] need to be explicit about these things ;-) [18:13:32] let's add a card for next iteration? [18:14:12] i'm confused. what's the ambiguity here? [18:14:53] (03Merged) 10jenkins-bot: Promoting mobile typography changes from beta to stable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/134978 (owner: 10Kaldari) [18:15:22] jgonera: did whoever worked on this just move typography to stable without the stylesheets? [18:15:29] Maryana, if you open notifications (echo) in beta they look different than in stable, edspecially on a tablet [18:15:49] Maryana, it's not about typography and I'm not sure why jdlrobson linked those two together ;) [18:15:58] (in this conversation) [18:16:07] jgonera: i was responding to maryana who linked to it [18:16:22] ( Maryana: jgonera: https://trello.com/c/GPwMmp0E/11-5-typography-changes-to-stable) [18:16:25] so what specifically has *not* been moved to stable? [18:16:38] different look for notifications [18:16:44] oh, ok [18:16:46] it's not typography, it's new design for notifications [18:16:51] the bell and new overlay [18:16:52] yeah, that's fine, we can make a new card for that [18:16:54] sliding from the right [18:18:13] so that's just "notification styling to stable"? [18:18:17] * Maryana makes a card [18:19:04] yeah, or "new notifications drawer/overlay" [18:21:02] jgonera: https://trello.com/c/t7RXwVjE/103-notifications-styling-to-stable [18:22:01] (03PS3) 10Jdlrobson: Push table of contents to stable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/134629 [18:22:13] thanks Maryana [18:22:21] jgonera: did the 'move beta styles to stable' patches all get merged? [18:22:43] (03CR) 10Jdlrobson: [C: 032] "Rebased" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/134629 (owner: 10Jdlrobson) [18:23:16] (03Merged) 10jenkins-bot: Push table of contents to stable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/134629 (owner: 10Jdlrobson) [18:27:35] (03PS4) 10Jdlrobson: Open sections by default on tablets (beta to stable) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/134630 [18:28:16] (03CR) 10Jdlrobson: [C: 032] "Rebased." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/134630 (owner: 10Jdlrobson) [18:29:38] (03Merged) 10jenkins-bot: Open sections by default on tablets (beta to stable) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/134630 (owner: 10Jdlrobson) [18:31:25] (03PS1) 10Jdlrobson: Declare toggling toc dependency [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/136153 (https://bugzilla.wikimedia.org/65838) [18:34:30] 3MobileFrontend / 3stable: Deprecation warnings in JS console - 10https://bugzilla.wikimedia.org/65643#c8 (10Jon) 5NEW>3RESO/WON Juliusz feel free to disagree but I can't imagine we want to do anything here. In theory we could do the following: delete mw.user.name; delete mw.user.anonymous;... [18:36:06] (03PS4) 10Yurik: Handle BeforeHttpsRedirect hook to prohibit HTTP->HTTPS redirect [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/133029 [18:36:11] (03CR) 10Florianschmidtwelzow: [C: 031] Declare toggling toc dependency [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/136153 (https://bugzilla.wikimedia.org/65838) (owner: 10Jdlrobson) [18:36:43] dr0ptp4kt, added variance to the patch, could you check [18:37:46] i hope i don't break varnish with this https://gerrit.wikimedia.org/r/#/c/133029/ [18:37:56] dr0ptp4kt: I merged that patch earlier today / later yesterday [18:38:11] YuviPanda: thank you! [18:38:17] dr0ptp4kt: ty for the patch [18:38:18] yurikR, looking at the patch [18:38:28] YuviPanda: and thx for guidance [18:44:15] Yay, Yuvi says beta like me. :D [18:45:51] dr0ptp4kt: people sey beta in other ways? [18:45:53] err [18:45:56] i meant, Deskana [18:46:10] Americans say bay-ta [18:46:13] We say beta. [18:46:30] bee-tuh? [18:46:36] bay-tuh? [18:46:40] be-tah? [18:46:52] er bee-tah? [18:47:56] bee-tah [18:47:57] I think? [18:48:18] 3MobileFrontend / 3alpha: Distnace between "read in another language" and Nearby - 10https://bugzilla.wikimedia.org/65907 (10Florian) 3NEW p:3Unprio s:3normal a:3None Created attachment 15512 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15512&action=edit Not very beautiful distance For exa... [18:48:31] 3MobileFrontend / 3alpha: Distnace between "read in another language" and Nearby - 10https://bugzilla.wikimedia.org/65907#c1 (10Florian) Created attachment 15513 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15513&action=edit better, have a distnace bewteen buttons [18:49:00] 3MobileFrontend / 3alpha: Distnace between "read in another language" and Nearby - 10https://bugzilla.wikimedia.org/65907 (10Florian) p:5Unprio>3Low [18:50:30] 3MobileFrontend / 3Feature requests: Allow configuration of the mobilefrontend menu - 10https://bugzilla.wikimedia.org/63459 (10Florian) [18:50:31] 3MobileFrontend / 3alpha: Distnace between "read in another language" and Nearby - 10https://bugzilla.wikimedia.org/65907#c2 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/6EqCWPOh [18:50:31] 3MobileFrontend / 3Feature requests: no path to Special:SpecialPages - 10https://bugzilla.wikimedia.org/63419 (10Florian) [18:52:45] 3MobileFrontend / 3alpha: Distnace between "read in another language" and Nearby - 10https://bugzilla.wikimedia.org/65907#c3 (10Jon) Seems like a CSS regression - there just to be a 1px gap between them I think. Adding Moiz and May to give us an idea if this is a problem. [18:54:00] 3MobileFrontend / 3beta: Distnace between "read in another language" and Nearby - 10https://bugzilla.wikimedia.org/65907#c4 (10Jon) Also effects beta https://en.m.wikipedia.org/wiki/San_Francisco?mobileaction=beta [18:56:12] yurikR, able to do a videoconference to talk Vary? [18:56:16] woo Deskana [18:56:31] dr0ptp4kt, in 4 min? [18:56:33] dbrant: bearND there's one patch outstanding, think you can merge it before the big meeting starts? [18:56:40] yurikR, yeah [18:56:45] cool [18:58:11] YuviPanda: on it... [18:58:18] dbrant: coool! :) [19:00:29] dbrant: I lied, there are two patches. but one is just a simple message change [19:01:32] YuviPanda: but it’s dependent on the larger one [19:26:15] 3MobileFrontend / 3stable: Site notices look crappy on mobile - 10https://bugzilla.wikimedia.org/65395#c4 (10Florian) +1 to hide site notice until a better view. [19:29:46] (03CR) 10Dr0ptp4kt: [C: 032] "Okay, worst case, on zerodot subdomain there may be incorrectly cached responses. But the percentage of correct should go up in that case." [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/133029 (owner: 10Yurik) [19:29:58] (03Merged) 10jenkins-bot: Handle BeforeHttpsRedirect hook to prohibit HTTP->HTTPS redirect [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/133029 (owner: 10Yurik) [19:30:45] 3MobileFrontend / 3beta: Distance between "read in another language" and Nearby - 10https://bugzilla.wikimedia.org/65907 (10Andre Klapper) [20:02:21] tfinc: hangout issues, be there in a sec [20:03:12] jgonera: where you at now? [20:03:18] jgonera: nice lighting! [20:03:29] YuviPanda, still Poland, until Sunday [20:03:33] jgonera: cool [20:08:23] brion: i made a couple small notes on the event logging patch. the modal refactor patch i submitted should be stable too if you want to poke at it :) [20:08:34] mhurd: spiff i’ll take a peek [20:11:07] (03CR) 10Brion VIBBER: "notes on notes. good catches!" (033 comments) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/135885 (owner: 10Brion VIBBER) [20:21:55] tfinc: gonna grab charger… [20:33:05] MaxSem: err… 404 not found on https://en.wikipedia.org/wiki/High_five ? [20:33:10] this might effect demoing… :) [20:33:35] jdlrobson: is being investiaged in -operations [20:33:50] YuviPanda: deploying back up demo setup [20:34:00] 3Wikipedia App / 3iOS App: iOS App: Bottom of article says "1 other languages" - 10https://bugzilla.wikimedia.org/65825#c1 (10Brion Vibber) It's a bit unclear whether this is meant to say "1 Other Languages" or "1" followed by "Other Languages" [20:34:22] jdlrobson, meltdown [20:34:36] :-S [20:36:17] jgonera: make sure you have a back up option if your planning to demo using english wikipedia :) [20:36:29] jdlrobson, I'm going to demo using vagrant [20:36:38] mhurd: wikipedia is down, so the demo might have problems :) [20:36:50] YuviPanda: haha the curse of demos [20:36:52] jgonera: cool :) [20:36:53] whoaaa [20:37:03] all wikipedias 404? [20:37:16] holy crap [20:37:16] YuviPanda: really? well i have a few sites already loaded up in the simulator so they should still be ok at least [20:37:27] mhurd: yeah, is being investigated. I'll keep you updated [20:37:28] *sites* - articles [20:37:49] moizsyed: note: wikipedia down, so demos that depend on that might be a problem :) [20:38:09] jgonera: are you going to demo VE? [20:38:14] yes [20:38:19] k cool [20:38:26] YuviPanda: wikipedia is down? [20:38:27] why? you wanted to? ;) [20:38:29] moizsyed: yes. [20:38:37] jgonera: no go for it! [20:38:39] moizsyed: people are investigating, I'll keep you guys updated [20:38:46] YuviPanda: great [20:38:53] i brought ipads I could pass around too for people to play with? [20:39:00] moizsyed: should be ok for our stuff [20:39:18] hm, maybe, or maybe not because link inspector is buggy on ipad? ;) [20:40:57] jgonera: you can also jump in when kaity is talking about VE :0 [20:40:59] :) [20:40:59] jgonera: oh we should fix that then [20:41:08] mhurd: jgonera moizsyed site is mostly back up now. [20:41:16] YuviPanda: phew [20:41:17] kaity, yes, we have a trello card for it [20:41:29] I'll jump in whenever someone tells me to jump in [20:42:12] jgonera: you can jump whenever you want to jump [20:42:25] right now? jdlrobson enough talking! [20:42:30] https://www.youtube.com/watch?v=010KyIQjkTk [20:42:45] I'm not opening youtube link from moizsyed during a meeting [20:43:27] jgonera is too sane [20:43:38] "careful" is the word [20:43:58] Does seem one can't bee too careful with moizsyed's video links [20:44:45] hmm? [20:45:21] moizsyed's link might be very useful for your demo [20:45:31] you're not tricking me [20:46:47] My client gives me a preview: http://i.imgur.com/ch8T8is.png [20:46:50] I'm definitely not clicking it. [20:48:33] Deskana: yay limechat [20:49:08] Deskana: jgonera it is 'Kris Kross - Jump', perhaps making a reference I don't understand [20:49:17] * Deskana does not know either. [20:49:30] YuviPanda: Are you in the quarterly review? [20:49:59] Deskana: indeed, but youtube doesn't work on my firefox (no flash) but does show metadata ;) [20:50:31] jdlrobson: can you demo it live? [20:51:18] jdlrobson: site back up, btw [20:55:31] mhurd: unshare your screen. its really distracting [20:55:49] mhurd: unshare and go without the camera [20:56:15] @awjr not quite true - to start off with flow want to use handlebars which is a somewhat different template language [20:57:20] tfinc: who is speaking now? [20:57:23] awjr: ^ [20:57:35] I guess it is Erik now, but before that? [20:57:37] jdlrobson: feel free to clarify in the mtg :) [20:57:38] YuviPanda: Robla and Erik [20:57:41] ah, Robla [20:57:42] ok [21:00:23] god that kind of product owner person would be wonderful [21:00:46] come on jdlrobson, how can anyone be more wonderful than Maryana [21:01:11] lulz [21:01:27] deep fried butter [21:01:28] Maryana - handlebars or hogan or knockoff ;-) decide stat! [21:01:42] jdlrobson: swig, man. swig. all others suck [21:04:26] that's the 2nd time i've seen juliusz do that in a demo kaity i think the design might be bad ;-) [21:04:45] 3MobileFrontend / 3stable: Site notices look crappy on mobile - 10https://bugzilla.wikimedia.org/65395#c5 (10Jared Zimmerman (WMF)) Not only do they look bad, its really bad UX, the dismiss button hit area is far too small, and i accidently go to the banner target at least 50% of the time when i'm trying to... [21:08:17] jgonera: mute yourself while kaity is talking [21:09:51] jgonera: adjust the gain for your mic next time. its too sensitive. just like Arthur's [21:10:10] tfinc, I see, I had no idea, thanks [21:10:13] jgonera: what we picked up was mild rustling and since kaite voice is very soft it starts to drown it out [21:10:16] jgonera: np [21:10:41] actually I'd say that awjr's mic is good sensitivity for me and office's mic is too quiet [21:10:45] tfinc, ^ [21:12:30] mhurd [21:12:36] ready for battle? [21:12:44] put your game face on mhurd [21:13:48] mhurd, i think you should go into screenshare mode now... it wont be too distracting, we'll save time [21:13:56] k [21:14:22] (03PS1) 10Jdlrobson: Hide enabling of site notices behind flag [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/136237 (https://bugzilla.wikimedia.org/65395) [21:23:00] (03CR) 10Jdlrobson: [C: 04-1] "The unrelated whitespace changes make this hard to read." (038 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/135793 (https://bugzilla.wikimedia.org/63458) (owner: 10Florianschmidtwelzow) [21:23:43] awjr: TRUTH [21:23:54] awjr, there are 4 repositories that we have to work with when working on VE: VE in MW, VE core, OOUI, MobileFrontend [21:23:58] (referring to context switching slowing things down) [21:24:12] jdlrobson: oh i just saw your message [21:24:16] what did he do? [21:24:18] 3MobileFrontend / 3General/Unknown: Image icon (upload/locked) do not align - 10https://bugzilla.wikimedia.org/65911 (10Jared Zimmerman (WMF)) 3NEW p:3Unprio s:3normal a:3None perhaps this is resolved with wikifonts? [21:24:25] jgonera: not counting parsoid? :) [21:24:30] right [21:24:32] and sometimes core [21:24:36] jgonera: There's also a few others like TemplateData etc. that you probably won't touch. [21:24:44] but I don't have to touch Parsoid, it just has to work [21:24:45] 3MobileFrontend / 3General/Unknown: Image icon (upload/locked) do not align - 10https://bugzilla.wikimedia.org/65911#c1 (10Jared Zimmerman (WMF)) Created attachment 15515 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15515&action=edit misalignment highlighted in red/blue [21:24:49] kaity: oh i was just referring to putting url's in the reference inputs. I think placeholders would be better there. [21:24:50] yeah [21:24:53] i've done that myself too [21:24:55] jgonera: I wonder if vagrant counts [21:25:00] (put url in the title field for references) [21:25:16] jdlrobson, modify Parsoid? [21:25:20] jdlrobson: good point! I'll talk to VE team [21:25:30] 3MobileFrontend / 3General/Unknown: Image icon (upload/locked) do not align - 10https://bugzilla.wikimedia.org/65911#c2 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/SRrPmuid [21:25:34] oh, different thing, nvm [21:26:59] MaxSem: can you +2 https://gerrit.wikimedia.org/r/136153 - master is currently in undeployable state without [21:27:50] (03CR) 10MaxSem: [C: 032] Declare toggling toc dependency [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/136153 (https://bugzilla.wikimedia.org/65838) (owner: 10Jdlrobson) [21:27:58] thanks MaxSem :) [21:28:23] (03Merged) 10jenkins-bot: Declare toggling toc dependency [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/136153 (https://bugzilla.wikimedia.org/65838) (owner: 10Jdlrobson) [21:28:45] 3MobileFrontend / 3beta: Exception thrown by mobile.toc - stops table of contents from loading - 10https://bugzilla.wikimedia.org/65838 (10Jon) 5PATC>3RESO/FIX [21:30:14] jdlrobson, do we need to swat it? [21:30:23] MaxSem: dont tnink so [21:30:26] only got merged today [21:30:57] is kaldari here? [21:31:32] kaity, kaldari is on vacation [21:33:16] 3MobileFrontend / 3alpha: Cannot switch to VisualEditor after a reload - 10https://bugzilla.wikimedia.org/65506#c12 (10Jon) Best way to simulate this... Open wikitext editor via clicking edit icon. Kill your web server. Click the toggle to VE icon. Nothing happens. [21:34:05] 3MobileFrontend / 3General/Unknown: When notifications count is [0] badge and count should be hidden - 10https://bugzilla.wikimedia.org/65914#c1 (10Jared Zimmerman (WMF)) Created attachment 15518 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15518&action=edit zero count badge [21:34:33] y no break between web and apps :( [21:34:44] true... [21:34:57] my jet lag is kicking in [21:35:24] awjr: we should have called it before staring apps [21:35:26] awjr: thanks [21:35:30] 3MobileFrontend / 3General/Unknown: Showing notification icon+badge on notification screen doesn't make sense - 10https://bugzilla.wikimedia.org/65912#c2 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/xH4Fu82w [21:35:41] starting* [21:35:44] tfinc: yeah, i realized it right after you started talking :p [21:35:45] 3MobileFrontend / 3General/Unknown: When notifications count is [0] badge and count should be hidden - 10https://bugzilla.wikimedia.org/65914#c2 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/fgoEJlEk [21:36:15] (03CR) 10Florianschmidtwelzow: [C: 031] Hide enabling of site notices behind flag [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/136237 (https://bugzilla.wikimedia.org/65395) (owner: 10Jdlrobson) [21:39:19] awjr: ping me when people get back on [21:39:22] awjr: ? [21:39:28] sure thing YuviPanda [21:43:46] YuviPanda: ping [21:45:19] * jdlrobson growls at MaxSem [21:45:51] Max does https://gerrit.wikimedia.org/r/#/c/136244/1/includes/Skin.php remove the need for https://gerrit.wikimedia.org/r/136237 ? [21:46:34] (03Abandoned) 10Jdlrobson: WIP: Add light-on-dark class [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/131883 (owner: 10Jdlrobson) [21:47:02] 3MobileFrontend / 3General/Unknown: When notifications count is [0] badge and count should be hidden - 10https://bugzilla.wikimedia.org/65914 (10Jared Zimmerman (WMF)) 3NEW p:3Unprio s:3normal a:3None seems unnecessary to show a zero count badge all the time. When count is 0 the icon should be shown... [21:47:04] with a one-liner change in MF, it automatically kills scary desktop notices [21:47:07] (03Abandoned) 10Jdlrobson: WIP: Introduce counter class [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/131884 (owner: 10Jdlrobson) [21:47:23] hey jgonera [21:47:35] hey kaity [21:47:54] (03PS5) 10Florianschmidtwelzow: Allow customization of page action buttons [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/135793 (https://bugzilla.wikimedia.org/63458) [21:47:54] do you know when the switch edit mode icon change will go up? [21:48:03] (03CR) 10jenkins-bot: [V: 04-1] Allow customization of page action buttons [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/135793 (https://bugzilla.wikimedia.org/63458) (owner: 10Florianschmidtwelzow) [21:48:08] jgonera: should i make a card? [21:48:16] 3MobileFrontend / 3General/Unknown: Showing notification icon+badge on notification screen doesn't make sense - 10https://bugzilla.wikimedia.org/65912#c1 (10Jared Zimmerman (WMF)) Created attachment 15516 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15516&action=edit notifications icon showing on n... [21:48:21] kaity, it's totally my fault, I did not change it yet [21:48:49] you can make a card so that it gets picked up if I don't do it [21:49:05] dr0ptp4kt, around? [21:49:12] jgonera: ok [21:49:12] (03CR) 10Florianschmidtwelzow: Allow customization of page action buttons (038 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/135793 (https://bugzilla.wikimedia.org/63458) (owner: 10Florianschmidtwelzow) [21:49:16] yurikR: si [21:49:35] dr0ptp4kt, two patches ready for your approval :) [21:50:11] yurikR: wanna add me and provide urls? [21:50:29] https://gerrit.wikimedia.org/r/#/c/136245/ [21:50:42] https://gerrit.wikimedia.org/r/#/c/136243/ [21:51:38] dr0ptp4kt, ^ [21:56:53] kaity, I'm doing that right now, don't write the card [21:57:05] ok thank you!!!! [21:57:18] kaity, one thing for future, source and normal icons are not the same size, but I'll fix that [22:01:23] kaity, curiously the pencils don't have the same aspect ratio [22:01:35] sorry let me check [22:02:01] kaity, no wait, I think I'm wrong [22:02:25] kaity, they're fine, it's just size [22:04:50] kaity, I chose the smaller size of the two, but now it seems a bit too small, I'll adjust it and make a screenshot [22:04:59] cool thanks [22:09:42] kaity, am I supposed to change messages too? [22:10:19] MaxSem: talking about the wbsearchentities API? [22:10:22] MaxSem: or reasonator type things? [22:10:35] TextExtracts [22:10:51] nah, Max just wants to do the bl bl bl [22:11:45] MaxSem: noooo! not as good as wbsearchentities! [22:12:10] it's way to good for man-hours [22:13:31] 3MobileFrontend / 3General/Unknown: remove geohack until mobile formatted target page is available - 10https://bugzilla.wikimedia.org/65917#c1 (10Jared Zimmerman (WMF)) Created attachment 15520 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15520&action=edit geohack icon [22:13:46] 3MobileFrontend / 3General/Unknown: remove geohack until mobile formatted target page is available - 10https://bugzilla.wikimedia.org/65917#c2 (10Jared Zimmerman (WMF)) Created attachment 15521 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15521&action=edit geohack incompatible with mobile screen [22:13:52] you don't want humans repeatedly fill in information that's already there [22:14:05] MaxSem: but they already have [22:14:15] kaity, check your email [22:14:21] stupid humans, what can I say?:P [22:15:18] 3MobileFrontend / 3General/Unknown: geohack icon breaks consistency of action bar icon placement on pages with location in tablet screen - 10https://bugzilla.wikimedia.org/65918 (10Jared Zimmerman (WMF)) 3NEW p:3Unprio s:3normal a:3None when location is present geohack icon creates inconsistency of i... [22:15:31] 3MobileFrontend / 3General/Unknown: remove geohack until mobile formatted target page is available - 10https://bugzilla.wikimedia.org/65917#c3 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/zSS2VdOT [22:15:32] 3MobileFrontend / 3General/Unknown: geohack icon breaks consistency of action bar icon placement on pages with location in tablet screen - 10https://bugzilla.wikimedia.org/65918#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/JCb7wiH1 [22:15:46] 3MobileFrontend / 3General/Unknown: geohack icon breaks consistency of action bar icon placement on pages with location in tablet screen - 10https://bugzilla.wikimedia.org/65918#c2 (10Jared Zimmerman (WMF)) Created attachment 15522 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15522&action=edit geoh... [22:16:17] 3MobileFrontend / 3General/Unknown: geohack icon breaks consistency of action bar icon placement on pages with location in tablet screen - 10https://bugzilla.wikimedia.org/65918 (10Jared Zimmerman (WMF)) [22:16:17] 3MobileFrontend / 3General/Unknown: remove geohack until mobile formatted target page is available - 10https://bugzilla.wikimedia.org/65917 (10Jared Zimmerman (WMF)) [22:24:40] brion: do you want to talk about SOA as part of the asks ? [22:24:53] its not on the slide but if your up for it we can mention it [22:25:21] mhurd: --^ [22:25:24] tfinc: i think we’re a bit vague on plans for that, other than “yes we want better APIs and to socialize that idea” :D [22:25:38] and good services & apis go together well [22:25:39] ok. then i'll just mention it briefly [22:25:51] sounds good :D [22:31:17] (03PS1) 10Jdlrobson: WIP: have a standard way of invoking loader [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/136249 (https://bugzilla.wikimedia.org/65506) [22:32:24] (03CR) 10Jdlrobson: "Juliusz thoughts before I go down this rabbit hole..?" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/136249 (https://bugzilla.wikimedia.org/65506) (owner: 10Jdlrobson) [22:33:06] hey dbrant [22:33:19] dbrant: time for CR or too tired after meetings? :) [22:33:44] YuviPanda: yep, looking at it… [22:33:49] dbrant: cool [22:37:40] (03PS6) 10Florianschmidtwelzow: Allow customization of page action buttons [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/135793 (https://bugzilla.wikimedia.org/63458) [22:38:17] dbrant: stepping away to get some water, brb in 2m [22:44:41] (03CR) 10Florianschmidtwelzow: [C: 04-1] Allow customization of page action buttons (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/135793 (https://bugzilla.wikimedia.org/63458) (owner: 10Florianschmidtwelzow) [22:44:53] (03PS7) 10Florianschmidtwelzow: Allow customization of page action buttons [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/135793 (https://bugzilla.wikimedia.org/63458) [22:46:27] (03PS2) 10Yuvipanda: Remove external link styling from CC BY-SA link [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/135972 [22:46:35] dbrant: also removed the dependencies between the patches [22:48:23] jgonera: do you know if the default is set to show VE first? [22:48:51] dr0ptp4kt, any thoughts so far? i need to take off [22:49:16] (03CR) 10Dbrant: [C: 032] Remove external link styling from CC BY-SA link [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/135972 (owner: 10Yuvipanda) [22:49:25] kaity, yes [22:49:35] (03Merged) 10jenkins-bot: Remove external link styling from CC BY-SA link [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/135972 (owner: 10Yuvipanda) [22:52:47] YuviPanda: so, do we not want to just get rid of the Styled* classes? [22:53:07] dbrant: we could do that too, but it's a massive find and replace... [22:53:20] dbrant: if that's your only concern, I can do that in a followup patch [22:53:59] YuviPanda: pretty much, I think [22:54:19] dbrant: making another patch now [22:58:03] dbrant: hmm, almost done. let me roll that into the same pactch. moment [23:01:42] (03PS5) 10Yuvipanda: Stop using OpenSans, switch back to default font [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/135948 [23:01:43] dbrant: updated [23:05:04] YuviPanda: processing… [23:06:57] dbrant: I'm off now, cya guys later! [23:07:25] dbrant: do put out an alpha if you can! tomasz should be able to give you and bearND access to the play store. there's a scripts/make-release.bash that should work, but if not just manually make an apk [23:07:42] YuviPanda: will do; later! [23:07:42] kaity, is the size ok in the screenshot? [23:18:06] jgonera: i responded in the email [23:18:12] did you send another? [23:18:37] kaity, nope, sorry, didn't notice [23:18:56] you know, this is more work, I changed the icons and alignment but create a card for copy change and the dropdown [23:19:30] 3MobileFrontend / 3alpha: remove geohack until mobile formatted target page is available - 10https://bugzilla.wikimedia.org/65917#c4 (10Jon) 5NEW>3RESO/INV Talk to the community on wiki: https://en.m.wikipedia.org/wiki/MediaWiki:Mobile.css I'm sure they'd be willing to consider this in light of the Wiki... [23:20:16] 3MobileFrontend / 3General/Unknown: geohack icon breaks consistency of action bar icon placement on pages with location in tablet screen - 10https://bugzilla.wikimedia.org/65918#c3 (10Jon) 5NEW>3RESO/INV This is a feature added by the community. You will need to request they remove it from: https://en.m.... [23:21:32] (03PS1) 10JGonera: Update editor switcher icons and fix CSS [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/136253 [23:23:00] 3MobileFrontend / 3General/Unknown: When notifications count is [0] badge and count should be hidden - 10https://bugzilla.wikimedia.org/65914#c3 (10Moiz Syed) I had a chat about this a few days ago with Kaldari and Fabrice, this should be in the works now. [23:23:00] ok, can't think, going to bed [23:23:45] (03PS1) 10BearND: Replace floppy disk and trash icons [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/136254 [23:26:01] awjr, Maryana, jdlrobson, MaxSem need anything? [23:26:10] nah, go to bed :) [23:26:13] nope [23:26:21] thanks for demoing today jgonera :) [23:26:28] you too jdlrobson [23:26:33] ok, just as a reminder, working mostly EU hours tomorrow [23:26:35] no problem [23:26:40] see you [23:28:16] (03PS2) 10JGonera: Update editor switcher icons and fix CSS [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/136253 [23:29:15] (03PS6) 10Mhurd: Refactor modal views. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/135956 [23:29:27] brion: ^ tiny update to yesterday’s patch [23:45:59] vbamba, ping for Hovercards meeting. :) Where are you and Dan ? [23:46:36] Ah, I got a reply on gchat, all good. :) [23:50:56] (03PS1) 10BearND: Bump version for release 2.0-alpha-2014-05-29 [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/136257 [23:50:58] (03PS1) 10BearND: Bump version for release 2.0-alpha-2014-05-29 [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/136258 [23:51:00] (03PS1) 10BearND: Bump version for release 2.0-alpha-2014-05-29 [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/136259 [23:51:02] (03PS1) 10BearND: Bump version for release 2.0-alpha-2014-05-29 [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/136260 [23:51:04] (03PS1) 10BearND: Bump version for release 2.0-alpha-2014-05-29 [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/136261 [23:52:43] (03Abandoned) 10BearND: Bump version for release 2.0-alpha-2014-05-29 [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/136258 (owner: 10BearND) [23:52:59] (03Abandoned) 10BearND: Bump version for release 2.0-alpha-2014-05-29 [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/136257 (owner: 10BearND) [23:53:07] (03Abandoned) 10BearND: Bump version for release 2.0-alpha-2014-05-29 [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/136261 (owner: 10BearND) [23:53:17] (03Abandoned) 10BearND: Bump version for release 2.0-alpha-2014-05-29 [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/136260 (owner: 10BearND) [23:53:43] (03Abandoned) 10BearND: Bump version for release 2.0-alpha-2014-05-29 [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/136259 (owner: 10BearND) [23:57:17] prtksxna: all garbled [23:57:22] prtksxna: cant hear you [23:58:01] you sound like a screenreader [23:58:07] :\ [23:58:13] (03PS1) 10BearND: Bump version for release 2.0-alpha-2014-05-29 [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/136263 [23:58:15] (03PS1) 10BearND: Bump version for release 2.0-alpha-2014-05-29 [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/136264 [23:58:38] (03CR) 10Dbrant: Stop using OpenSans, switch back to default font (031 comment) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/135948 (owner: 10Yuvipanda)