[00:00:39] (03PS6) 10Dbrant: Stop using OpenSans, switch back to default font [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/135948 (owner: 10Yuvipanda) [00:02:32] (03CR) 10Dbrant: [C: 032] Stop using OpenSans, switch back to default font [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/135948 (owner: 10Yuvipanda) [00:09:37] (03PS1) 10BearND: Use clean build for release [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/136267 [00:11:44] (03Abandoned) 10BearND: Bump version for release 2.0-alpha-2014-05-29 [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/136264 (owner: 10BearND) [00:11:57] (03Abandoned) 10BearND: Bump version for release 2.0-alpha-2014-05-29 [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/136263 (owner: 10BearND) [00:13:09] (03PS1) 10BearND: Bump version for release 2.0-alpha-2014-05-30 [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/136268 [00:26:01] mhurd: I'm loving the frequent iOS releases. <3 [00:26:51] Superfreak: yay! me too! [00:31:17] (03PS2) 10BearND: Use clean build for release [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/136267 [00:32:07] (03Abandoned) 10BearND: Bump version for release 2.0-alpha-2014-05-30 [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/136268 (owner: 10BearND) [00:38:15] (03PS1) 10BearND: Bump version for release 2.0-alpha-2014-05-30 [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/136269 [01:03:34] (03Abandoned) 10BearND: Bump version for release 2.0-alpha-2014-05-30 [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/136269 (owner: 10BearND) [02:31:17] 3Wikipedia App / 3Android App: History search only matches beginning of article titles - 10https://bugzilla.wikimedia.org/65930 (10Sage Ross) 3NEW p:3Unprio s:3minor a:3None If I type something into the search in the History view, it only matches articles that *start* with my search text. So, for exa... [09:41:03] (03Merged) 10jenkins-bot: Stop using OpenSans, switch back to default font [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/135948 (owner: 10Yuvipanda) [13:13:14] hi everyone, my commons app won’t start up anymore… is there a way to get it to work again? [13:13:28] and/or what info do you need from me to look into the problem? [13:14:41] (03CR) 10JGonera: [C: 04-1] WIP: have a standard way of invoking loader (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/136249 (https://bugzilla.wikimedia.org/65506) (owner: 10Jdlrobson) [13:19:01] ter_burg: heya! have you tried uninstalling and reinstalling it again? [13:19:41] (03PS1) 10Yuvipanda: Make history search case insensitive & fully matching [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/136312 (https://bugzilla.wikimedia.org/65930) [13:19:52] ragesoss: ^ fixed that :) should add it to bookmarks as well [13:21:01] YuviPanda: https://www.youtube.com/watch?v=nn2FB1P_Mn8 ;-) [13:21:10] multichill: haha :D [13:23:17] Stil in Europe YuviPanda? [13:24:45] multichill: UK [13:24:46] YuviPanda: ehr… that did the trick... [13:24:55] ter_burg: usually does, no idea why. [13:24:56] YuviPanda: nice. [13:25:25] So that was the UK approach! Going to stay in Europe for much longer or back to India again? [13:25:36] multichill: back to India on June 10 [13:25:46] ter_burg: you should try the new wikipedia app as well. has editing! http://lists.wikimedia.org/pipermail/mobile-l/2014-March/006642.html to opt in [13:26:00] And also Wikimania? [13:26:04] multichill: yes! [13:26:52] ragesoss: I don't remember if it was case insensitive before, but it is now [13:27:05] it was case insensitive, I think. [13:27:17] at least, it handled the first letter correctly. [13:27:52] yeah, was already case insensitive. [13:31:20] ragesoss: ah, cool. either way, good to make that explicit [13:34:31] yuvipanda: will the app have both bookmarks and watchlist, later on? [13:34:41] YuviPanda: I don’t have an android phone anymore :-) [13:34:42] or will bookmarks be replaced by watchlist? [13:34:48] ragesoss: so bookmarks are going away again, being replaced with 'saved pages' which will be offline [13:35:00] ah, cool. [13:35:04] that makes sense. [13:35:08] ragesoss: and so yes, it'll have both. watchlists probably won't be push enabled, while notifications (when it comes!) will be [13:35:17] sweet. [13:35:21] looking forward to that. [13:35:57] ragesoss: :) [13:36:12] editing is not something I'll use very often in the app until I have watchlist and notifs. [13:36:16] ragesoss: why is that? [13:37:08] because if something is urgent enough that I would want to edit it on my mobile device, it's almost always a response to someone else's action. [13:37:20] which I don't know about without watchlist and notifs. [13:37:29] ragesoss: right. [13:37:42] aside from like typo correction when browsing, which is not one of the main ways I edit. [13:37:48] ragesoss: so watchlist and page history both mean we need to also have at least diff views and reverts [13:38:05] I mean, I'll fix something obvious if I see it, but if I'm going to dig into improving an article, I usually want to be on my computer. [13:38:15] yeah. [13:38:49] and MFE has come along way with mobile diffs. [13:39:25] even though I use the app a lot more than MFE, if I make an edit on mobile it's more likely with MFE. [13:39:44] (plus, with MFE, I know I'm really signed in) [13:39:45] ;) [13:40:49] ragesoss: :P I just found out about assert=, I think I'll use that to make sure you are always signed in [14:12:45] 3Wikipedia App / 3Generic: Page content is duplicated on main page - 10https://bugzilla.wikimedia.org/64694#c2 (10Yuvi Panda) 5NEW>3RESO/FIX Fixed since upstream bug was fixed. [14:13:30] 3Wikipedia App / 3Generic: Main Page ToC is empty - 10https://bugzilla.wikimedia.org/64693#c3 (10Yuvi Panda) Fixed by not showing ToC for pages without sections :) [15:46:09] Hi, I was wondering if there is any work already going on in making any native application? Or any thoughts/plans about it? [16:16:41] Hi, I was wondering if there is any work already going on in making any native application? Or any thoughts/plans about it? [16:17:48] yes, apps for iOS and Android are being developed [16:18:13] YuviPanda can tell you more about the Android one [16:18:16] chagolchana, ^ [16:23:41] Awesome.....I will wait for him. I guess it's night for him [16:56:18] chagolchana: heya! [16:56:41] Hi!!!! [16:56:42] chagolchana: you can sign up for alpha testing on http://lists.wikimedia.org/pipermail/mobile-l/2014-March/006642.html [16:59:58] eh....YuviPanda http://imgur.com/JSZNIiJ [17:00:11] chagolchana: remove . at end of URL [17:06:36] yurik yurikR after email hoping to review the two patchsets you added me to yesterday [17:14:46] dr0ptp4kt, thx [17:15:32] Maryana, I can help you with signing off on Monday before kick-off which happens kind of late (3pm) [17:15:51] tfinc: can't hear nor see you [17:16:53] Maryana: ^ [17:28:23] jgonera: that would be great :) i'll probably tackle as many of the user-facing stuff today as i can get through [17:28:29] *as much of [17:29:43] hey bearND! [17:30:31] bearND: can you try making a signed build from IntelliJ? Build -> Generate Signed APK [17:32:56] jgonera: jdlrobson why is there a font-size: 90%; applied to html {} in MF? [17:37:17] YuviPanda: yes. it works when i use intellij. is this how you usually do it? [17:37:31] bearND: usually not, but unsure what's been causing the issues. [17:37:43] bearND: either way, can you make a release now to play store with that apk, and then we can figure out the script? [17:39:35] (03PS2) 10Dbrant: [WIP] implement nav tweaks. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/135721 [17:39:47] mhurd: shouldn't have, no. why? [17:39:53] mhurd: the contents would've changed multiple times tho [17:40:09] YuviPanda: just checking :) [17:40:15] YuviPanda: thx! [17:40:18] mhurd: they will have to change before release, though [17:40:50] YuviPanda: ya [17:40:55] mhurd: cool! [17:40:55] YuviPanda: ok, just pulled in latest changes. will do a rebuild and upload latest [17:41:01] bearND: cool! [17:41:06] YuviPanda, because we wanted the default font size smaller, not sure if that's the best approach. anyway, I think it's 100% now with the new typography in stable [17:41:34] jgonera: ah, right. cool. [17:43:09] YuviPanda: apk size shrank from 2 MB to 1.6 (since we're not shipping the fonts anymore) [17:43:17] bearND: cool! :) [17:43:23] bearND: whoa big fonts! [17:43:52] YuviPanda: anything "you want me to say for the "What's new"? [17:44:13] bearND: usually I do a git log, see what's up since the last push, and mention it. Then I copy paste it in an email to mobile-l [17:44:27] bearND: YuviPanda ios “ipa” is 1.28 MB muhuhuahahahah [17:44:37] ;) [17:45:05] mhurd: so tiny ;) [17:45:36] bearND: delete all the bits [17:50:19] YuviPanda: another css question - would i be breaking any styling if i’m surrounding each section with a div? [17:50:32] mhurd: each section *should* ideally be surrounded with a div, actually. [17:50:45] mhurd: android app does [17:50:51] YuviPanda: oh good :) [17:51:13] YuviPanda: what’s your naming convention for the div id and/or class? [17:51:31] mhurd: id=content_block_ [17:51:44] mhurd: and for headings, it is id=heading_ [17:51:49] jgonera: so I am scheduled for QA interview Monday, scrum master Tuesday, QA Wednesday [17:51:53] do you have any interviews next week? [17:52:09] mhurd: the edit section icon is an inside the , with class edit_section [17:52:09] YuviPanda: i use same for id - will check on heading… [17:52:32] mhurd: cool [17:54:22] YuviPanda: would you mind making a tiny html snippet mocking that structure up that we could link to or place in docs? [17:55:17] YuviPanda: if that sounds like a good idea that is. not trying to create work [17:55:38] mhurd: https://gist.github.com/yuvipanda/e8464240f1b3ab228568 [17:56:39] YuviPanda: is it ok if i replace the content with “…” in that file? [17:56:49] mhurd: definitely! feel free to! [17:57:02] mhurd: I just did this because it was the easiest for me to do :D [17:57:30] YuviPanda: awesome! i’ll probably ask you to confirm that i boil it down to is still accurate [17:57:36] (03CR) 10Jdlrobson: [C: 031] "Great! Leaving at +1 in case Max or Juliusz would like to comment. Either should feel free to +2 if they have no objections." (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/135793 (https://bugzilla.wikimedia.org/63458) (owner: 10Florianschmidtwelzow) [17:57:38] mhurd: will happily do, yeah. [17:57:43] thx! [17:59:19] (03CR) 10Jdlrobson: WIP: have a standard way of invoking loader (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/136249 (https://bugzilla.wikimedia.org/65506) (owner: 10Jdlrobson) [17:59:36] (03PS1) 10Yuvipanda: Hide edit icons in main page [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/136361 [18:00:32] YuviPanda: oh i have a better idea - could you give me the html from a new test page called “demo” or something which has 2 sections each with just a single word piece of text. that way i’ll have a nice clean view of structure without lots of stuff? [18:00:49] mhurd: sure! moment [18:02:25] (03CR) 10Florianschmidtwelzow: Allow customization of page action buttons (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/135793 (https://bugzilla.wikimedia.org/63458) (owner: 10Florianschmidtwelzow) [18:03:15] mhurd: https://gist.github.com/yuvipanda/bbe2a1317d15dc1d1094 [18:04:33] (03CR) 10Jdlrobson: [C: 04-1] "~/Sites/w/extensions/MobileFrontend $ grep 'icon-40px' templates/ includes/ javascripts/ -R" (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/136253 (owner: 10JGonera) [18:04:42] mhurd_: https://gist.github.com/yuvipanda/bbe2a1317d15dc1d1094 [18:05:03] YuviPanda: woohoo that’s great! [18:05:10] mhurd: formatted it as well :) [18:05:11] YuviPanda: thanks! [18:05:25] YuviPanda: very very nice [18:06:28] (03CR) 10Jdlrobson: [C: 04-1] "$wgMFNearby still exists..?" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/135308 (https://bugzilla.wikimedia.org/64029) (owner: 10Florianschmidtwelzow) [18:08:55] hey people [18:10:18] hey MaxSem [18:11:28] (03CR) 10Florianschmidtwelzow: "I thought about the case posted from MaxSem and Kaldari, so this fallback is maybe necessary for some Wikis to disable Nearby without diab" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/135308 (https://bugzilla.wikimedia.org/64029) (owner: 10Florianschmidtwelzow) [18:20:18] wee, delivery in 20 minutes [18:20:21] bye [18:37:58] @YuviPanda I opted in for the alpha testing and then installed wikipedia app. But i still see the phonegap version in my mobile :( [18:37:58] Anything I am missing? [18:37:58] chagolchana: installed from play store in phone or desktop? [18:37:58] chagolchana: sometimes it doesn't work if you install it from the phone [18:37:58] :( I will uninstall and instal it again (did it from the browser) [18:37:58] got it [18:37:58] chagolchana: worked? [18:37:58] Yup. [18:40:01] dr0ptp4kt, around? [18:40:11] yurikR: si [18:40:32] dr0ptp4kt, i will submit all 3 extensions - please re-download [18:40:38] some minor changes [18:41:06] yurikR, alright, lemme know when ready [18:41:20] dr0ptp4kt, any questions so far? [18:42:19] yurikR, mainly only related to the following in ZeroBanner: The commit message says "Removes all non-banner related code", but it seems there's still some non-banner related code. but i'll see what you have when you push the three extensions [18:43:40] YuviPanda: :) [18:52:01] 3Wikipedia App / 3Automated Builds: Keyboard covers cursor when I tap at end of section - 10https://bugzilla.wikimedia.org/64676 (10Maryana Pinchuk) 5NEW>3RESO/FIX [18:52:43] dr0ptp4kt, done, pls update all 3 ext [18:53:00] yurikR k [18:56:25] bearND: feel free to publish the apk. we try to do one a day, ideally :) don't worry if it has bugs or whatever. [18:57:47] YuviPanda: published [18:57:55] bearND: cool! do mail out to mobile-l as well [18:58:03] tfinc: bearND just made his first release! :) [18:58:10] :) [18:58:23] bearND: congrats [18:58:32] tfinc: ty [18:59:23] dr0ptp4kt, is it working for you? [18:59:42] you might want to configure it to store & use everything locally [18:59:56] yurikR, i'm setting it up [19:00:32] if you +2 it, i will get it running on the betalabs [19:07:11] YuviPanda: sent out the mail. feel free to follow up if i missed anything [19:26:42] YuviPanda: style is missing again? [19:27:16] and this causes edit buttons to be missing :( [19:31:32] 3MobileFrontend / 3alpha: Visual inconsistencies between OOJS and VisualEditorOverlay - 10https://bugzilla.wikimedia.org/65957 (10Jon) 3NEW p:3Unprio s:3normal a:3None Created attachment 15538 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15538&action=edit exit overlay See attachments * Di... [19:31:45] 3MobileFrontend / 3alpha: Visual inconsistencies between OOJS and VisualEditorOverlay - 10https://bugzilla.wikimedia.org/65957#c1 (10Jon) Created attachment 15539 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15539&action=edit Exit dialog in VE [19:34:04] liangent: ugh, uninstall + reinstall to see if they come back? [19:35:16] also am going to be afk for a while [19:35:24] moizsyed: onboarding design +1 :) [19:35:31] 3MobileFrontend / 3alpha: Visual inconsistencies between OOJS and VisualEditorOverlay - 10https://bugzilla.wikimedia.org/65957#c2 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/MaI2stPq [19:35:41] moizsyed: do look at the login and account creation screens on Android. I don't think you will love it that much [19:45:15] yurikR, went for a falafel. will let youi know if i can get it to work, probably in the next 30 minutes i would think [19:45:51] YuviPanda: I wonder html structure of that edit button? [19:48:58] liangent0: you can connect your phone and go to chrome://inspect and inspect the HTML! [19:49:12] liangent0: as in, connect your phone to your laptop and go to there in chrome [19:49:17] liangent0: it is .edit_section, I believe. [19:49:20] liangent0: inside the [19:51:22] dbrant: am going to be afk for a few hours, will be responsive on email tho [19:51:23] brb [19:51:53] dbrant: hmm, see OTRS? I am seeing people reporting crashes on just opening the file :( [19:52:03] dbrant: can you verify / push a new release? [19:55:21] Yuvi|brb: uninstalling/reinstalling fixes that [19:55:32] liangent: yeah, known issue. should fix next week [19:55:42] liangent: mostly because betalabs is unreliable. if it sends back an empty response, that is cached [19:55:47] Is it possible to make it fixable by clearing app cache [19:56:06] liangent: hmm, possibly. I'll look into it when I fix it next week [19:56:29] am off for a bit now, brb [19:56:31] (for real [19:56:32] ) [19:58:33] 3Wikipedia App / 3Android App: Allow clearing app cache to clear cache for real - 10https://bugzilla.wikimedia.org/65960 (10Liangent) 3NEW p:3Unprio s:3normal a:3None Yuvi|brb: uninstalling/reinstalling fixes that liangent: yeah, known issue. should fix next week lian... [20:03:02] btw, i just updated jsonconfig a bit [20:03:17] dr0ptp4kt ^ [20:03:48] yurikR: got it [20:07:42] Yuvi|brb4real: ping me when you get back if you have a sec [20:09:09] Deskana: you have a second? [20:12:46] mhurd: Right now he's trying to get an IRC bouncer configured. [20:12:54] mhurd: I can get him to stop if you want. :-) [20:13:00] James_F: hehe no rush at all. [20:13:05] Kk. [20:13:54] Yuvi|brb4real: I see where the issue is happening in the code, but I can’t reproduce… [20:16:35] yurikR: using the config variables in the ZeroBanner README (my old ZRMA config vars aren't read in as I disabled that), http://localhost:8080/w/api.php?action=zerobanner&type=message&agent=neatapp provides a response with X-CS forged to a locally available unchanged (old format) config 250-99. i assume we don't expect Main_Page to render nicely or anything when /only/ ZeroBanner (with MF) is installed? [20:18:18] dr0ptp4kt, what do you mean we don't expect main page to render nicelly? it should function as it is now [20:19:30] yurikR it doesn't seem to have nice styling. the banner shows, but no nice styling. and Special:ZeroRatedMobileAccess doesn't show up? is that expected? [20:20:10] dr0ptp4kt, checkign Special:ZeroRatedMobileAccess [20:23:48] 3MobileFrontend / 3alpha: ToC menu item is still usable - 10https://bugzilla.wikimedia.org/65962 (10Liangent) 3NEW p:3Unprio s:3normal a:3None On pages without sections, it's no longer possible to pull out the TOC drawer, but the menu item is still usable. And it's even worse that I cannot close the... [20:25:12] yurikR: one other thing i did hit was a non-critical PHP /notice/ of the form " Undefined index: 1 in /vagrant/mediawiki/extensions/MobileFrontend/includes/MobileContext.php on line 636 " . i imagine this just has to do with domain name pattern format regexes and such [20:25:30] 3MobileFrontend / 3alpha: ToC menu item is still usable - 10https://bugzilla.wikimedia.org/65962#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/9dHKe12P [20:28:16] 3MobileFrontend / 3alpha: ToC menu item is still usable - 10https://bugzilla.wikimedia.org/65962#c2 (10Jon) 5NEW>3UNCO Did you mean to file this bug against apps...? [20:29:30] 3Wikipedia App / 3Android App: ToC menu item is still usable - 10https://bugzilla.wikimedia.org/65962#c3 (10Liangent) 5UNCO>3NEW (In reply to Jon from comment #2) > Did you mean to file this bug against apps...? You're right... [20:36:07] dr0ptp4kt, fixed special [20:37:09] dr0ptp4kt, did you update MF to the latest? [20:37:34] yurikR, yeah, my MF is at 1b6866058a0d54d0efb04c7123f4cea765f141b0 [20:39:04] dr0ptp4kt, not seeing it [20:39:08] how are you getting it? [20:39:56] git checkout master && git pull [20:40:02] yurikR ^ [20:40:26] yurikR, which commit is your mf at? [20:40:34] dr0ptp4kt, i meant what do you do to get the notice [20:41:46] yurikR, oh, i go to http://localhost:8080/wiki/Main_Page with X-CS: 250, X-Subdomain: M, User-Agent: android. able to repro on your local host? [20:42:10] dr0ptp4kt, try 127.0.0.1 [20:42:54] yurikR lol (quietly) it has enough dots. no warning there. [20:43:09] its a bug in mbf [20:43:17] wil fix in a sec [21:15:25] (03PS1) 10Yurik: updateMobileUrlHost bugfix in case pattern doesn't match [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/136457 [21:17:25] dr0ptp4kt, MaxSem, ^ [21:17:54] dr0ptp4kt, any other issues? [21:18:49] yurikR, on a separate note, the css/js not working has to do with 'targets' => array( 'mobile' ) being commented out. uncommenting it resolves it. yurikR, any other changes you're going to submit for review before you'd like me to +2 ZeroBanner and JsonConfig? i really would prefer that we can keep the api at action=zeroconfig so i don't have to update all three apps...but that could be a post-+2....is anyone using JsonConfig such that t [21:18:50] should be reviewing the JC patch as well? [21:19:14] yurikR, i think regarding other issues, we'll need to vet on betalabs [21:19:23] (that is those other than these basic ones) [21:19:45] dr0ptp4kt, yes, makes sense, lets not rename the action [21:19:59] targets need to be changed to all i guess [21:23:11] yurikR, alright. i'm gonna disconnect from irc. lemme know by email know once you have ZB and JC updates pushed to gerrit (also add others to JC if they should weigh in), okay? [21:23:30] dr0ptp4kt, sec, almost there [21:23:42] yurikR, ok, staying on irc for now :) [21:26:57] dr0ptp4kt, pls update zerobanner [21:27:41] grrrit-wm [21:27:46] grrrit-wm help [21:27:56] a bug for MobileApp Mediawiki extension https://bugzilla.wikimedia.org/show_bug.cgi?id=65954 :D [21:28:05] the PHPUnit tests are failing :-( [21:28:40] anyone knows how to add ZeroBanner & ZeroPortal ext gerrits to mobile channel? [21:31:49] and https://bugzilla.wikimedia.org/show_bug.cgi?id=65964 got filled to get MobileApp a bugzilla component [21:32:20] yurikR: depends there are two bots, one is Gerrit and the other are Bugzilla notifications [21:32:25] yurikR, seems to work. localhost:8080 works okay without NOTICEs using that mf thing you submitted for MaxSem's review [21:32:42] dr0ptp4kt, thx, pls+2 [21:32:57] yurikR: also I filled a bug for both extensions cause they are not passing Jshint :D [21:33:20] dr0ptp4kt, i tihnk we will switch varnish switch and your test scripts to use action=zeroportal [21:33:44] hashar, i suspect this is due to their reliance on jsonconfig ext [21:33:53] yurikR: for gerrit notifications you want to edit some file in ssh://gerrit.wikimedia.org:29418/labs/tools/grrrit.git Then ask whoever maintains it (at least YuviPanda) to +2 / Pull and reload the bot on labs [21:33:56] but may be something else [21:33:59] probably [21:34:13] might want to fix jshint in Zero extension [21:34:13] and reform it to Banner and Portal [21:34:29] hashar, i plan to kill ZRMA [21:34:41] though I am not sure why you add to fork two new repo :) That must ends us with ton of code duplication/ maintenance nigthmare [21:34:43] ahh [21:34:53] so that it is a split of it? [21:34:54] makes sense, eh? :) [21:34:58] yep [21:35:19] they are too different from original, was easier to do a clean split [21:35:19] if you don't have that much code for Portal/Banner, it would be rather cool to have ZRMA to pass jshint and tests :) [21:35:42] yurikR, is anyone using JsonConfig who should also review https://gerrit.wikimedia.org/r/#/c/136245/ ? [21:35:46] ? i just want to delete ZRMA [21:35:51] obsolete/archive [21:35:56] yeah sure [21:36:06] and make jsonconfig + banner + portal pass [21:36:18] dr0ptp4kt, noone is using it [21:36:41] anyway I filled three bugs requesting to pass jshint: ( https://bugzilla.wikimedia.org/61647 https://bugzilla.wikimedia.org/65818 https://bugzilla.wikimedia.org/65817 ) [21:37:02] if you get ZRMA to pass jshint and refork Banner and Portal that fix all three bugs :] [21:37:03] yurikR, okay i +2'd both the JC and the ZB [21:37:09] thx [21:37:41] dr0ptp4kt, zero portal was also updated [21:37:49] whenever you want, pls +2 [21:38:38] yurikR, i'll need to review it first. jenkins didn't like my +2 on https://gerrit.wikimedia.org/r/#/c/136243/ [21:39:53] hashar, do you know what this is? https://integration.wikimedia.org/ci/job/mwext-ZeroBanner-testextensions-master/5/console [21:39:59] PHP Fatal error: Class 'MFResourceLoaderModule' not found in /srv/ssd/jenkins-slave/workspace/mwext-ZeroBanner-testextensions-master/includes/resourceloader/ResourceLoader.php on line 434 [21:40:54] ? [21:42:45] yurikR, need to go for a walk. when i come back i'll review ZeroPortal. that is frightening. [21:42:49] ;) [21:42:56] dr0ptp4kt, no worries :) [21:43:01] yurikR, a dependency on MF? [21:43:01] enjoy your walk ) [21:43:27] MaxSem, right, is it configurable somewhere? [21:43:52] yurikR: ah missing a dependency [21:44:03] yurikR: don't you need MobileFrontend ? :) [21:44:13] hashar, sure am :) [21:44:18] as well as jsonconfig [21:44:25] ruhoh [21:44:26] I guess ZeroPortal depends on MobileFrontend as well isn't it ? [21:44:36] portal needs banner :) [21:44:56] * yurikR is building extension dependency trees [21:45:17] and Banner needs mobilefrontend right ? [21:45:30] and jsonconfig :) [21:45:39] is that an extension? [21:45:45] which might benefit from codeeditor ;) [21:45:49] yep [21:45:50] OH MY FG [21:46:06] just merge all of that in core ok? thx *grin* [21:46:44] done [21:47:50] I am adjusting the deps [21:47:52] hashar, did i mention that codeeditor benefits from wikieditor ? [21:48:53] * yurikR feels vindicated for all of those years fighting #include nightmares [21:49:01] do unit tests needs CodeEditor for ZeroBanner and ZeroPortal? [21:49:08] not really [21:49:18] but they would need JsonConfig right? [21:49:22] they use them in production, but they would work without them [21:49:29] I mean for unit tests :) [21:49:31] and only zeroportal [21:49:34] no [21:49:51] they do need jsonconfig [21:50:01] but editors are optional for zeroportal [21:50:06] yurikR: here are the deps [21:50:07] https://gerrit.wikimedia.org/r/136469 [21:51:09] hashar, is the order important for dep list? [21:51:18] I can't remember :-( [21:51:32] it just fetch them [21:51:45] ok, i'm +2ing [21:51:51] then a tiny PHP script is injected in LocalSettings;php [21:52:01] which loads the extensions using some glob() [21:52:20] I sent a new patchset [21:52:25] (amended commit message) [21:52:34] and now updating both jobs: mwext-ZeroBanner-testextensions-master and mwext-ZeroPortal-testextensions-master [21:53:21] hashar, thx!! i +2ed them, will see what happens :) [21:53:26] \O/ [21:53:43] I deployed them (that still needs to be done manually unfortunately) [21:55:00] the ZeroBanner is happy [21:55:06] ZeroPortal still failing though https://gerrit.wikimedia.org/r/#/c/136252/ [21:58:16] yurikR: you will need a ZeroPortal.php entry point :) [21:59:09] err in ZeroBanner [21:59:11] hashar, how do you mean? [22:00:26] Jenkins fetch the extensions [22:00:36] then includes ExtName/ExtName.php [22:00:49] ZeroPortal master did not have a ZeroPortal.php file [22:01:01] aarharahrar [22:01:04] sorry too late [22:01:10] ?? [22:01:14] its there [22:01:25] ZeroPortal test on https://gerrit.wikimedia.org/r/#/c/136252/ was failing because the ZeroBanner extension was missing a ZeroBanner.php file [22:01:29] but the change got merged [22:01:55] and now ZeroPortal test manage to properly load ZeroBanner [22:02:05] https://gerrit.wikimedia.org/r/#/c/136252/ <-- your ZeroPortal refactoring [22:02:16] tests are now passing on both repos \O/ [22:02:21] yeii!!! [22:02:23] thanks! [22:02:35] i will wait for dr0ptp4kt to review and +2 portal [22:02:58] banner got +2ed [22:03:03] so that unlocked portal [22:03:09] anyway all seems fine now [22:03:16] yep, thank you!!! [22:03:29] then make sure jshint pass!!!! [22:03:40] now time to break beta :) [22:03:47] I added you as CC on all the jshint bugs [22:03:48] haha [22:12:07] yurikR: glad it ends up working. Sleeping for now :D [22:12:09] have fun! [22:12:27] thanks hashar, good night [22:48:10] yurikR, i think maybe a "dummy" extension message file assignment is needed in ZeroPortal.php, but i'm not sure. updating $wgJsonConfigs['JsonZeroConfig'] to an array pointing at 172.0.0.0.1/w/api.php with username=admin and password=vagrant, and then commenting out the assignment to $wgJsonConfigs['JsonZeroConfig-local'] altogether, it sort of works. after saving Zero:250-99 locally, the change is reflected in the html, but there's a bi [22:48:10] mhurd: ping [22:48:10] set of NOTICEs at the top of the rendered html, e.g., "Did not find alias for special page 'Search'" [22:48:22] YuviPanda: hey! [22:48:27] mhurd: 'sup [22:48:31] dbrant: the crashing issue? [22:48:40] YuviPanda: quick question... [22:48:45] mhurd: sure [22:49:04] YuviPanda: can’t reproduce… and I’m not sure how/why it could happen [22:49:18] dbrant: hmm, maybe they got a corrupted install? [22:49:37] YuviPanda: so content block div id’s are in format “content_block_#”... [22:49:43] dr0ptp4kt, i think it would work if you set local=true [22:49:48] without username/password [22:49:53] haven't tested that scenario [22:50:07] mhurd: yeah, but they aren't actually used in any of the styles, so it's not *strictly* necessary at the moment [22:50:13] YuviPanda: but the very first one looks like this “#content_block_0”. is that leading “#” intentional? [22:50:14] yurikR, you mean 'isLocal' = true ? [22:50:18] yep [22:50:32] you don't need url than [22:50:39] yurikR, i have isLocal = true, but i'll comment out the creds [22:50:44] mhurd: haha, no, is a bug [22:50:46]