[00:12:02] (03PS3) 10Dbrant: [WIP] implement nav tweaks. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/135721 [01:37:41] (03PS1) 10Dbrant: Load selected history and bookmark items in the same fragment. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/136706 [01:40:51] (03PS1) 10Dbrant: Hide keyboard when history item selected after searching. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/136707 [04:21:46] 3MobileFrontend / 3Feature requests: Allow configuration of the mobilefrontend menu - 10https://bugzilla.wikimedia.org/63459 (10Florian) [04:21:46] 3MobileFrontend / 3Feature requests: no path to Special:SpecialPages - 10https://bugzilla.wikimedia.org/63419 (10Florian) [14:22:12] (03PS1) 10Dbrant: Don't use hard-coded file directory. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/136754 [14:54:59] (03PS4) 10Dbrant: Implement nav tweaks. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/135721 [14:59:01] (03PS2) 10Dbrant: Load selected history and bookmark items in the same fragment. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/136706 [15:13:14] (03PS1) 10BearND: Bump version for release 2.0-alpha-2014-05-30 [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/136760 [15:13:54] dbrant: YuviPanda|zzz: ^ that's the old one i wanted to push on Friday [15:14:46] bearND: is that what's currently on the Play Store? [15:14:57] dbrant: yes [15:15:40] in that case... [15:15:47] (03CR) 10Dbrant: [C: 032] Bump version for release 2.0-alpha-2014-05-30 [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/136760 (owner: 10BearND) [15:16:54] bearND: do you think you could start looking at https://gerrit.wikimedia.org/r/135721 [15:17:47] dbrant: sure. i'll take a look right away [15:17:55] I probably should have broken it up into smaller commits... but it's all kind of interrelated. [15:24:11] (03CR) 10jenkins-bot: [V: 04-1] Bump version for release 2.0-alpha-2014-05-30 [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/136760 (owner: 10BearND) [15:25:31] bearND: ^ "lost"? [15:27:02] (03CR) 10Hashar: "recheck" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/136760 (owner: 10BearND) [15:29:34] dbrant: what is lost? [15:30:27] (03CR) 10Hashar: "Dbrant : Zuul had an issue, you need to Code-Review +2 again :)" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/136760 (owner: 10BearND) [15:30:51] (03CR) 10Dbrant: [C: 032] Bump version for release 2.0-alpha-2014-05-30 [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/136760 (owner: 10BearND) [15:31:36] hashar: dbrant: thanks [15:37:26] bearND: LOST mean Jenkins has lost the job :-( We need to retrigger it [15:37:29] sorry :-( [15:38:02] hashar: good to know! thx [15:40:01] dbrant: https://integration.wikimedia.org/zuul/ shows all jobs being run [15:40:13] dbrant: you can retrigger tests by commenting in Gerrit 'recheck' [15:40:31] or for a +2 remove yourself from reviewers and revote Code-Review: +2 , that will reenqueue the change [15:41:08] hashar: nice! [16:25:26] (03PS4) 10Yurik: Major refactoring [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/136252 [16:35:59] * YuviPanda is alive and in one piece! yay! [16:36:42] Hello YuviPanda. Good to have you back. [16:36:50] bearND: :) [16:37:06] dbrant|lunch: didn't realize you were doing about too. [16:38:42] (03PS1) 10Yurik: Zero API is now duplicated as action=zeroportal [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/136765 [16:39:39] (03CR) 10Jdlrobson: [C: 032] "\o/" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/136253 (owner: 10JGonera) [16:40:18] (03Merged) 10jenkins-bot: Update editor switcher icons and fix CSS [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/136253 (owner: 10JGonera) [16:44:11] (03PS2) 10Yuvipanda: Hide keyboard when history item selected after searching. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/136707 (owner: 10Dbrant) [16:44:15] (03CR) 10Yuvipanda: [C: 032] Hide keyboard when history item selected after searching. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/136707 (owner: 10Dbrant) [16:44:25] (03PS1) 10Jdlrobson: QA: Make page loading test run again [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/136766 [16:45:53] (03Merged) 10jenkins-bot: Hide keyboard when history item selected after searching. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/136707 (owner: 10Dbrant) [16:47:47] (03PS2) 10Yuvipanda: Don't use hard-coded file directory. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/136754 (owner: 10Dbrant) [16:50:12] YuviPanda: In the values-qq/strings, what does the Identical keyword do? [16:50:35] bearND: it means in translatewiki.net some keys are identical to some other keys, possibly in different software [16:50:41] bearND: we don't add it, the translatewiki.net folks take care of that [16:51:00] MaxSem, do you have a second? need a second opinion on https://gerrit.wikimedia.org/r/#/c/136503/ [16:51:28] it should be a noop for production [16:51:59] YuviPanda: I'm looking at https://gerrit.wikimedia.org/r/#/c/135721/4/wikipedia/res/values-qq/strings.xml, and see that dbrant|lunch added one with that. So I got curious [16:52:25] YuviPanda, bearND: the last android build i have is from 5/25.. i know you guys have worked on stuff since :) is there a new build coming? [16:52:34] Maryana: there was one out on 29, I think? [16:52:57] Maryana: I can email you a build if you want as well [16:53:04] that would be great! [16:53:07] Maryana, I'll be a few minutes late for standup [16:53:09] Maryana: kk email coming [16:53:14] ty :) [16:53:32] jgonera: smh [16:53:42] ;) [16:53:42] Maryana: sent [16:53:58] (03CR) 10Yuvipanda: [C: 032] Don't use hard-coded file directory. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/136754 (owner: 10Dbrant) [16:54:01] Is that a sound of disapproval? [16:54:05] bearND: ah, right. :) [16:55:04] (03Merged) 10jenkins-bot: Don't use hard-coded file directory. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/136754 (owner: 10Dbrant) [16:55:32] Maryana: i published one on 5/29, but it was my first try. Did it not get updated? [16:55:50] bearND: it didn't for me.. don't know if that was just me, though :) [16:56:06] bearND: play store does list it as 'published' tho [16:56:22] (03PS5) 10Yuvipanda: Implement nav tweaks. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/135721 (owner: 10Dbrant) [16:56:36] YuviPanda: installed. new styles look niiiice [16:56:43] Maryana: INORITE! :D [16:56:54] Maryana: Theoretically, it should update if you had the store build on your device, but it would if you had side loaded the pervious apk [16:57:37] Maryana: *some* styles will still be missing (hlists on enwiki, for example) because they are loaded from Mediawiki:Mobile.css which the app doesn't support yet (not for MVP I think). I might put a hack in place [16:57:57] hm, looks like there's a regression on the left nav -- it's green again :-/ [16:58:51] Maryana: that patch hasn't been merged yet [16:58:55] Maryana: I am testing it atm [16:59:01] ah, ok [16:59:05] dbrant: did you remove the autohide behavior of the search bar? [16:59:06] Maryana: that was from a 'test' build I gave you [16:59:11] Maryana: did the designers want that removed? [16:59:22] black plz :) [17:00:01] * Maryana runs to mobile web standup [17:00:19] YuviPanda: Maryana: when I last spoke to Moiz, he wanted the search bar to persist, unless it's a really low-res screen. [17:01:21] YuviPanda: and I see it's in the checklist on trello [17:01:41] dbrant: hmm, I'll talk to him about it after, but ok for now. [17:02:04] dbrant: I can rebase my 'about' code to be on top of this one [17:02:31] err... [17:03:01] YuviPanda: that'd be great; you're adding all the license stuff, right? [17:03:13] dbrant: in the about page? yeah [17:03:23] dbrant: I realized in that patch I had forgotten to actually git add the files. [17:03:34] YuviPanda: lol yep i saw that [17:03:52] dbrant: I use git commit -p all the time, and a side effect of that is this... [17:04:00] bearND: heya! any progress on the license text card? [17:04:10] we should try to get everything merged in by tomorroe evening [17:04:31] YuviPanda: Maryana: i've been also looking at dbrant's latest patch. going to start on the license text shortly. [17:04:40] yurikR: i have that face-to-face working session this morning. when i get back from that this afternoon, i will be reinstalling all of the vm stuff and trying out the latest version of the patchsets. wanted to make sure you knew i wasn't going to be able to turn around a "final" code review by the end of the day most likely [17:04:43] bearND: ah, ok! I'm reviewing it too :) [17:05:45] dr0ptp4kt, thx, let me know. [17:06:20] dbrant: have some minor nits, writing them up now [17:06:46] YuviPanda: alright! [17:06:57] (03CR) 10BearND: Implement nav tweaks. (034 comments) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/135721 (owner: 10Dbrant) [17:07:08] YuviPanda: just published some comments for dbrant on an earlier PS [17:07:15] cool [17:07:33] bearND: got'em [17:07:35] (03CR) 10Yuvipanda: Implement nav tweaks. (031 comment) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/135721 (owner: 10Dbrant) [17:08:03] (03CR) 10Yuvipanda: "Commit message also needs updating, since it has a bunch more changes (remove QuickReturn, Toc Icon, etc)" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/135721 (owner: 10Dbrant) [17:09:42] (03CR) 10Yuvipanda: Implement nav tweaks. (031 comment) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/135721 (owner: 10Dbrant) [17:09:48] dbrant: the icon is a bit fuzzy for me too [17:10:41] YuviPanda: I was going to ask about that... how do the other icons (i.e. in the nav menu) come out to be pixel-perfect? This one is generated from SVG, just like the others... [17:12:55] dbrant: I was wondering if it was the rsvg version on your system, but I just ran it again and it is fuzzy too [17:12:56] mhurd: WWDC stream is on [17:13:17] were in the really bad humor section [17:13:40] dear god .. they just joked about OSX Weed ... [17:14:17] OS X Yosemite, hmm [17:22:41] (03PS2) 10Yuvipanda: Add About page [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/136518 [17:22:56] bearND: don't worry about the bugs atm, the license text thing is definitely more important since we can not ship the alpha without it [17:26:38] YuviPanda: ok [17:32:19] awjr_away: are you here through 6/6 ? [17:32:34] tfinc: mostly [17:32:37] bearND: can you hop on a quick google hangout with me and moiz at some point this afternoon to make sure you've got all you need for that license text story? :) [17:32:43] tfinc: my flight is at 530p on 6/6 [17:32:44] awjr: i need it for the weekly update [17:32:48] then yes. 6/6 [17:34:40] Maryana: sure. Anytime except 3:00 PT would work for me [17:35:06] great! just sent you an invite [17:35:16] Maryana: I had some questions for moiz at https://trello.com/c/k8hwTl3l/4-3-android-nav-tweaks, since I hadn't heard of it being removed, and people in general seemed to like it [17:35:47] speak of the devil [17:35:49] heh [17:35:59] Maryana: I had some questions for moizsyed at https://trello.com/c/k8hwTl3l/4-3-android-nav-tweaks, since I hadn't heard of it being removed, and people in general seemed to like it [17:36:12] i think the reasoning for keeping the top nav fixed was primarily for ToC access [17:36:44] yeah [17:36:53] Maryana: might make sense on iOS, but on android you can access ToC from swiping from right as well [17:36:54] moizsyed: ^ [17:37:14] Maryana: if the swip from right was more discoverable we wouldn't need to fix the search bar [17:37:44] swipe to the right is not really that discoverable [17:38:31] moizsyed: the first time you open ToC, it does slide from the right. [17:38:48] brion: http://b2cloud.com.au/tutorial/custom-airdrop-action-in-ios7/ [17:39:20] YuviPanda: I don't think that necessarily makes it obvious that swiping will get you the same thing, however. [17:39:49] I'm kind of biased about this stuff since I test on a tablet and I've got tons of space. I should really take some time to look at the app on a phone. [17:39:50] hmm, ok then. I was just worried about removing vertical reading space, since I lost about 2 full lines on my nexus [17:40:15] YuviPanda: I'm on the fence about this... could go either way [17:40:44] moizsyed: bringing back the search bar is *very* discoverable and a very oft-used pattern (almost all browsers and reading apps do it) [17:41:06] convince Maryana [17:41:11] Maryana: ^ [17:41:55] nice…. you’ll be able to use your mac as a speakerphone for your iphone in future osx [17:42:35] YuviPanda: Sent my take-home messages to mobile-l (finally). Thanks for prodding me. :) [17:42:50] Maryana: chrome, firefox *and* safari do this, and so does pocket (things I have checked just now) [17:43:47] Deskana: thank you! :) [17:45:33] YuviPanda: i really think if we want to do gestural navigation, at minimum we need a first-time use hint (e.g., coachmarks or toc popping out of the right on first open of app or something) [17:45:57] otherwise it's undiscoverable to anyone but android power users [17:46:10] Maryana: but anyone who has used chrome or firefox or safari would know how to bring the search bar back [17:46:32] sure, but it's an extra action :) [17:46:34] and users are lazy [17:46:37] they'll just scroll [17:46:41] which is not what we want [17:48:39] Maryana: it's very literally a tiny scroll up. not even a top bar tap. For the top bar tap you have to lift your finger up and go to the top as well [17:51:27] hey vbamba! thoughts on the search bar sliding off after the user scrolls behavior on Android? Maryana thinks it should be removed because users are too lazy to scroll up a blip and tap the icon and would rather keep scrolling all the way down (and I disagree). Your thoughts? [17:53:21] (03PS3) 10Yuvipanda: Add About page [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/136518 [17:53:26] dbrant: I've rebased my patch on top of yours [17:53:42] YuviPanda: nice! [17:54:32] (03CR) 10Yuvipanda: "Also with this ToC is openable on articles with only one section, and is empty. And is also not closeable by sliding." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/135721 (owner: 10Dbrant) [17:54:52] (03CR) 10Yuvipanda: "Also the white lines on the black navbar are too harsh. try greys?" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/135721 (owner: 10Dbrant) [17:55:02] dbrant: couple more comments. will look at the dependent patch now [17:55:12] YuviPanda: cool [17:56:24] moizsyed: i need an icon for the "More" menu, when you get a chance [17:57:01] 3MobileFrontend / 3Feature requests: Allow configuration of the mobilefrontend menu - 10https://bugzilla.wikimedia.org/63459#c7 (10Quim Gil) (In reply to Florian from comment #4) > Hmm, the question is, what would you exactly do? Only hide elements, you > don't need? (Random Page, Home etc.) or add elements... [17:57:20] dbrant: vibha should have that for you by end of day :) [17:57:39] Maryana_intervie: brilliant [17:58:35] @dbrant hello! [17:58:48] vbamba: hey! [17:58:49] @dbrant all the icons are in the wikifont now [17:58:51] including more [17:59:18] @violetto integrated the set I submitted on Friday [17:59:19] see https://github.com/munmay/WikiFont/blob/master/Screenshot-current.png [17:59:27] vbamba: we can't really use the wikifont on Android, need svgs [17:59:34] I need to quickly chat with YuviPanda to clear up size confusion [17:59:41] yes yes. I understand that [17:59:55] vbamba: cool! want to chat here or hangout? [18:00:07] YuviPanda: can you give me 10 minutes? [18:00:10] vbamba: sure [18:00:24] Im finishing up a life & death situation [18:01:09] oh! dbrant the only one missing is the share icon [18:01:17] dbrant: ^ [18:01:25] Ill put that in soon-ish [18:01:37] and do a clean export to the sizes you need [18:02:03] vbamba: that's fine; we're currently not using an icon for Share in Android. [18:02:35] (03PS3) 10Yuvipanda: Load selected history and bookmark items in the same fragment. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/136706 (owner: 10Dbrant) [18:07:01] Deskana|Maryana_intervie: what about the link for CC-BY-SA 3.0? Isn't that site specific? [18:07:40] bearND: not really, we just link to the CC link on the cc site [18:07:53] bearND: see the link in content_license_html [18:08:59] YuviPanda: where is content_license_html? [18:09:08] bearND: ah, strings.xml [18:09:31] YuviPanda: got it. ty [18:17:24] vbamba: yes i did [18:18:13] hmmm [18:18:29] did something change in apps/android/java-mwapi ? [18:18:33] i can’t build the android app anymore [18:18:37] Api constructor signature changed [18:18:43] brion: yeah, you should pull it out and do an mvn install [18:18:58] brion: I should update it on the tools repo [18:19:01] that's what she said. [18:19:07] maybe i have to reimport maven stuff [18:19:43] YuviPanda: bearND and I were curious -- in qq/strings.xml, what does {{Identical|...}} mean? [18:20:17] dbrant: ah, so it is used by translatewiki.net folks to indicate that a string is exactly the same as another commonly used string, which might be used across projects [18:20:26] dbrant: we should keep away from adding those, they'll add it as appropriate. [18:20:39] brion: you'll see commits from L10n-bot on the history, those are the ones being synced back [18:21:07] YuviPanda: last update on java-mwapi is may 2, or newer one available somewhere? [18:21:16] brion: may 2 should be it, yeah. [18:21:21] hmmmmmm [18:21:22] brion: you'd have to reimport sources in intellij too [18:21:59] * brion keeps poking buttons that say “reimport”, “generate”, “sources”, or anything else [18:23:07] wait… it still shows a compile error but it launches the app now [18:23:10] i …… am confused ;) [18:24:12] brion: haha [18:24:33] * brion handwaves at intellij and goes back to testing :D [18:24:51] ok, i’ve still got something wrong with my eventlogging, i’m gonna instrument the android one and double-check what’s different about my requests [18:25:51] brion: so, there are some magic incantations one can use on stat1003 that make this much easier, utilizing zsub [18:26:43] brion: zsub vanadium.eqiad.wmnet:8422 | grep MobileWikiApp should give you *all* wiki app events as they come in, valid or not [18:26:46] brion: mhurd: heads up that the Appstore is now getting test flight integration [18:26:46] i’m watching the raw event stream, but it doesn’t show anything from my ios app [18:26:49] aha lemme check that [18:26:53] brion: zsub vanadium.eqiad.wmnet:8600 | grep MobileWikiApp gives you only the valid ones. [18:26:58] \o [18:27:09] brion: yeah, 8422 is *all*, and 8600 is validated. [18:27:42] Hello all together :) I have a little problem. I have reinstalled my development environment and after i installed the phpunit and qunit i make installhooks. Normally then phpcs will be installed, but i became this two error messages: [18:27:50] Skipped installation of bin dev-scripts/phpcs for package > squizlabs/php_codesniffer: file not found in package [18:27:50] Skipped installation of bin dev-scripts/phpcbf for package > squizlabs/php_codesniffer: file not found in package [18:27:55] YuviPanda: oh let me know if you have a chance to factor out that top space in the css file [18:28:25] Unhappily i don't know, what i can do :( The error message, that phpcs isn't installed appears (correctly). [18:28:39] FlorianSW: unrelated, but have you considered using mediawiki-vagrant? [18:28:40] FlorianSW: http://www.mediawiki.org/wiki/MediaWiki-Vagrant [18:28:56] ooooh something about inter-app communications [18:29:02] (03PS1) 10BearND: [WIP] License text on every edit [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/136793 [18:29:10] ooh this could be awesome [18:31:05] And if i change the location (in phplint.sh) to the location of phpcs binary, all runs perfectly, has anyone an idea, what i did wrong? :) [18:31:20] FlorianSW: MaxSem or jgonera might be able to help [18:40:39] (03PS6) 10Dbrant: Implement nav tweaks. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/135721 [18:41:52] YuviPanda: bearND: ^ addressed all your comments, except the fuzzy icon appearance. [18:42:00] dbrant: yeah, we can fix that in another patch [18:43:22] dbrant: looks good, with a bunch of UI issues (ToC icon needs to be disabled when it isn't openable, and also the lines are still too stark) but can be fixed in another patch [18:43:27] dbrant: I'm testing, then gonna merge [18:44:43] dbrant: gonna mergeee [18:45:31] (03CR) 10Yuvipanda: [C: 032] "Has a bunch of minor issues:" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/135721 (owner: 10Dbrant) [18:45:37] dbrant: woo! [18:45:48] YuviPanda: yay! [18:45:52] (03Merged) 10jenkins-bot: Implement nav tweaks. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/135721 (owner: 10Dbrant) [18:46:09] YuviPanda: you mean something like 'greyed out' when it's disabled? [18:46:11] brion: mhurd: heads up that iOS is getting a new programming language [18:46:17] dbrant: yeah [18:46:19] Swift [18:46:25] oh my [18:47:15] “objective-c without the c" [18:47:27] exactly [18:47:29] as long as it links to obj-c code that could be interesting [18:48:17] they can all run in tandem [18:48:21] YuviPanda: looking at your About patch now... [18:49:11] sounds like it’ll be possible to inject code into a running app like writing bits of JS in a web browser console window [18:49:15] that would be SO AWESOME [18:49:48] also, there’s some kind of inter-app plugin mechanism in ios 8 which i’m really interested in [18:49:59] potentially we could do like a ‘look this word up in wikipedia’ extension to safari for instance [18:50:13] (03PS4) 10Yuvipanda: Add About page [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/136518 [18:50:26] brion: yes, their letting other apps register plugins, render their own ui, and integrate better [18:51:35] exciting times :D [18:51:57] dbrant: needs another rebase, on it [18:55:31] dbrant: bah, I seem to have 'lost' AboutActivity somehow. digging in to git [18:55:53] YuviPanda: standing by [18:57:43] (03PS2) 10Brion VIBBER: Work in progress (do not merge): EventLogging refactor [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/135885 [18:58:00] ok my events work now :D so some more cleanup to make sure everything’s sending out... [19:00:11] dbrant: haha, looks like I might have actually lost it. digging into pack files now [19:00:23] YuviPanda: no!! [19:00:48] dbrant: because I never added it to git, and might have lost it in a reset --hard [19:00:51] * YuviPanda lives dangerously [19:02:15] brion: mhurd here is the language guide https://itunes.apple.com/ie/book/swift-programming-language/id881256329?mt=11 [19:02:42] tfinc: i know what i’ll be reading tonight! [19:02:44] :) [19:05:40] dbrant: not too bad to write it again, but of course I'd prefer not to. [19:05:55] YuviPanda: that sucks [19:06:07] dbrant: yeah. my fault though. [19:06:39] dbrant: I was checking for the presence of AboutActivity, and didn't take into account the fact that it could've been *your* AboutActivity and not mine [19:07:17] bearND: having some video issues in the room.. [19:09:31] woo got it downloaded to my ibooks :D [19:12:28] chrismcmahon: heya - i thought we were going to be disabling the test2 browser test builds? [19:12:52] awjr: hrm, looking [19:13:07] chrismcmahon: cool - i just saw a failure email from test2 [19:13:26] * YuviPanda pokes Maryana again [19:13:50] YuviPanda: she was just in an interview and i suspect she's probably off to lunch now [19:14:01] awjr: ah, right [19:14:10] awjr: Jenkins restarted, fixing [19:18:22] awjr: you're in SF now? skipping out on the nice weather in Tucson? [19:19:01] chrismcmahon: yep for the week [19:19:04] chrismcmahon: nice weather?!?! [19:19:22] chrismcmahon: i saw today's forcast in tucson is for 110F [19:19:42] yep. mad dogs and Englishmen weather :-) [19:20:20] downloading xcode 6 beta and ios 8 betas [19:20:21] wheeee [19:29:26] dbrant: yeah, I accidentally rm'd it I think [19:29:57] dbrant: just rewriting it [19:30:02] dbrant: my fault, I rm'd it without checking [19:30:33] YuviPanda: :( [19:30:52] dbrant: most of the work was in XML anyway, so should be ok [19:31:07] dbrant: just need to get those link clicky things up again [19:44:14] YuviPanda: can you make it for the 1PM discussion ? no need to prep anything [19:44:19] Maryana: same for you [19:45:30] tfinc: hmm, when was it added? I don't remember seeing it before, might not be on for all of it. [19:45:55] tfinc: I'll make it if we can't reschedule to tomorrow, though. [19:45:57] I had to send it late as there was nothing else available for the next three days and we need to first pass done by friday [19:46:16] the* [19:46:28] i kept it to before 2 like you had requested for the others [19:46:31] tfinc: ah, hmm. alright, I'll make it. [19:46:38] tfinc: yeah, cool. thanks! [19:46:52] tfinc: thanks for the IRC poke, wouldn't have realized otherwise [19:46:59] thanks. sorry about the last minute notice as i had hoped to do it tomorrow or wed but its all that you guys have open [19:50:23] oooooh [19:50:42] ios 8 adds a 3rd-party keyboard extension point [19:58:35] brion: yup swype :) [19:59:02] tfinc: restarting computer, might be a minute or so late. [19:59:08] ok [19:59:33] also a widget extension point, might be good for wikipedia & commons article/image of the day [19:59:51] and share and ‘action’ points which we can probably use for upload or similar in future [20:03:02] tfinc: you guys are in robotspeak mode [20:03:47] Maryana: ^ [20:05:43] tfinc: Maryana I don't see you guys at all yet [20:05:50] Deskana: ^ [20:06:02] YuviPanda: We're having trouble with the hangout. Rejoining. [20:06:08] Deskana: ok! [20:10:42] YuviPanda: talk now? [20:11:00] vbamba: got pulled into a meeting with others, so am there now :( [20:11:10] vbamba: we can talk on IRC though [20:15:14] umm, no lets hangout quickly when you get free? [20:15:53] vbamba: probably not today, sorry :( [20:16:26] it wont take more than 15 minutes, but I understand if you need to go [20:16:56] vbamba: yeah, I need to be somewhere by 10pm today, and this one goes on till 9:50. sorry [20:17:29] its ok, we will survive till tomorrow [20:17:32] but only till tomorrow. [20:17:43] vbamba: :) [20:18:43] Mobile Web folks - anyone know if the thumbnail treatment patch goes out this week? [20:18:56] vbamba: they're all in that meeting too [20:19:25] bad timing i guess :) [20:19:34] ok ill poke them later [20:19:36] vbamba: yeah, we all got 30m notice for this meeting [20:35:49] MaxSem: https://gerrit.wikimedia.org/r/#/c/135793/ [20:38:13] (03CR) 10MaxSem: [C: 032] Allow customization of page action buttons [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/135793 (https://bugzilla.wikimedia.org/63458) (owner: 10Florianschmidtwelzow) [20:38:51] (03Merged) 10jenkins-bot: Allow customization of page action buttons [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/135793 (https://bugzilla.wikimedia.org/63458) (owner: 10Florianschmidtwelzow) [20:39:57] (03PS5) 10Yuvipanda: Add About page [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/136518 [20:39:58] dbrant: updated. [20:40:03] YuviPanda: thanks for merging the patch! [20:40:14] dbrant: can't get the underlines to go away this time, I forgot what I did the last time :( [20:42:46] 3MobileFrontend / 3stable: allow removing impossible page-actions - 10https://bugzilla.wikimedia.org/63458 (10Jon) 5PATC>3RESO/FIX [20:43:04] YuviPanda: will check it out [20:45:52] Thx for merging @MaxSem :) [20:45:57] :) [20:49:55] dbrant: am going to go off now, do email if anything comes up :) [20:50:13] YuviPanda: taktaktaktakat [20:50:19] YuviPanda: Can you mute yourself when you type? :) [20:50:22] bearND: dbrant I hope to get *everything* merged by EOD tomorrow, set out an alpha, test that, and then release [20:50:27] YuviPanda: You already did it. Thanks. :) [20:50:27] YuviPanda: of course! see you later [20:50:32] Deskana: yeah, just did. Usually do, forgot this time because someone pinged me when talking and I tabbed out. [20:50:44] Deskana: ALSO KEYBOARD SOUNDS ARE AWESOME! :) [20:50:46] YuviPanda: before you leave [20:50:52] bearND: sure! [20:51:06] YuviPanda: just wanted to check quickly if you have done anything with web links in TextViews [20:51:19] bearND: ah, yeah. my patch makes them open up in the browser [20:51:30] bearND: I had code that removed the underlines, but I 'lost' them in a rm snafu :( [20:51:52] bearND: https://gerrit.wikimedia.org/r/#/c/136518/ has some code in AboutActivity.java [20:52:22] YuviPanda: cool [20:52:33] YuviPanda: thanks [20:52:39] bearND: yw! [20:52:50] Deskana: and thanks for bringing up talk pages! one of my biggest pet peeves [20:53:00] YuviPanda: once yours and mine are merged we can probably refactor [20:54:56] bearND: agreed [20:57:09] YuviPanda: \o/ [20:59:35] Deskana: we should figure out what we need to talk about talk pages a bit before the meeting so we have a rough idea of what we want to talk about. set an agenda, etc [21:00:21] Deskana: I might be back in a fwe hours [21:00:36] YuviPanda|zzz: Sure. Or we can do it tomorrow. [21:00:44] Deskana: cool [21:00:54] Deskana: having that kinda expections going in helps a lot, I think [21:01:11] Deskana: do try out the alpha feature of talk pages in mobilefrontend too. talk to jdlrobson about it if you want, he was pretty passionate about talk pages as well [21:01:13] cya! [21:13:07] (03CR) 10Dbrant: [C: 04-1] "Can't compile: missing "@string/libraries_list" and "@string/contributors_list" :(" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/136518 (owner: 10Yuvipanda) [21:22:21] (03PS4) 10Dbrant: Load selected history and bookmark items in the same fragment. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/136706 [21:28:59] (03PS1) 10JGonera: Revert "Fixing thumbnail sizing in search overlay" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/136906 (https://bugzilla.wikimedia.org/65997) [21:37:15] bearND: have a silly question [21:37:52] for the license copy on android, do we control line breaks or is it like auto layout where the text auto-formats and you only specify paragraph alignment [21:38:29] vbamba: we can add line breaks if you'd like [21:43:37] vbamba: Just let me know where you want the line breaks. Also do you like the text to be centered, like I showed in the screenshot earlier? [21:51:02] I think we may be ok with the line height fix. [22:16:00] jdlrobson: wheres that list of beta/alpha / stable? [22:16:46] 3MobileFrontend / 3General/Unknown: Showing notification icon+badge on notification screen doesn't make sense - 10https://bugzilla.wikimedia.org/65912#c3 (10Jon) 5NEW>3RESO/INV Have turned it into a story. as this was originally was by design. Looks like we are doing that in this coming sprint. See abov... [22:19:01] kaity, https://www.mediawiki.org/wiki/Mobile/Release_history [22:19:09] jgonera: jdlrobson MaxSem http://hatjitsu.wmflabs.org/27646 [22:19:17] moizsyed: kaity ^ [22:28:02] 3MobileFrontend / 3Hygiene: Setup EventLogging schemas the new cool way. - 10https://bugzilla.wikimedia.org/66055 (10Jon) 3NEW p:3Unprio s:3normal a:3Jon To include a schema these days all you need to do is: $wgEventLoggingSchemas[ 'MobileWebEditing' ] = 8599025; We should move to this method. [22:29:00] 3MobileFrontend / 3General/Unknown: Image icon (upload/locked) do not align - 10https://bugzilla.wikimedia.org/65911#c3 (10Jon) 5NEW>3RESO/INV We are adjusting the upload icon to only show for auto-confirmed users on pages that need it. The icon will never show as 'locked' Track in https://trello.com/c/... [22:32:27] (03PS1) 10Florianschmidtwelzow: Fix for installation of PHP Codesniffer with composer [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/136926 [22:40:20] (03CR) 10Florianschmidtwelzow: "Damn, don't used git diff (looked only to the two lines in bin), so some new lines added/changed too. If i'm right, thats "only" a newer v" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/136926 (owner: 10Florianschmidtwelzow) [22:41:31] MaxSem: jdlrobson jgonera kaity moizsyed https://etherpad.wikimedia.org/p/MobileWeb-IterationName [23:01:01] (03PS2) 10BearND: [WIP] License text on every edit [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/136793 [23:13:09] (03PS3) 10BearND: [WIP] License text on every edit [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/136793 [23:21:03] (03PS5) 10Dbrant: Load selected history/bookmark/language items in the same fragment. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/136706 [23:39:20] MaxSem: jgonera tfinc awjr violetto Maryana anyone want to join me for a celebratory beer after work to celebrate my new place (and Max's new place? :)) [23:39:47] jdlrobson, maybe one beer, have to buy some groceries and unpack [23:40:11] jdlrobson: thanks for the invite jon but i'll be doing flying trapeze tonight. drinking + trapeze = :( [23:40:33] jdlrobson, sure! [23:40:35] tfinc: i dunno… that sounds like an awesome combination. The only thing that would make that better is BOAT [23:40:45] jdlrobson: yeah! [23:40:47] i gotta get to oakland by 630 [23:41:29] jdlrobson: help Maryana sign off on https://trello.com/c/m3m53BdN/32-5-use-existing-references-dialog so we can count the points this iteration [23:41:38] then i'll update the boards :) [23:41:45] we're in a ve meeting... [23:41:51] but after that [23:47:49] kk [23:52:23] jdlrobson: got a long distance call at 5p [23:52:43] jdlrobson: and then that long distance call started playing in my head [23:52:52] that song