[00:14:57] Maryana: are you guys still working on https://trello.com/c/Jmp3bdKn/15-ve-tablet-user-testing? [00:15:09] yep, one last round on thursday :) [00:24:31] cool thanks Maryana [02:38:17] (03PS6) 10Yuvipanda: Add About page [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/136518 [02:48:12] (03CR) 10Yuvipanda: "Whelp. git add fail *again*. New PS has it. Credits names are alphabetically ordered." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/136518 (owner: 10Yuvipanda) [02:57:19] (03CR) 10Dbrant: [C: 032] Add About page [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/136518 (owner: 10Yuvipanda) [03:11:21] (03PS1) 10Dbrant: Add feedback link to About page. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/136969 [05:21:23] (03PS2) 10Florianschmidtwelzow: Fix for installation of PHP Codesniffer with composer [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/136926 [08:37:47] 3MobileFrontend / 3Feature requests: Do not offer link to PasswordReset if Email features have been disabled - 10https://bugzilla.wikimedia.org/63460 (10Florian) a:3Florian [08:42:46] 3MobileFrontend / 3Feature requests: Do not offer link to PasswordReset if Email features have been disabled - 10https://bugzilla.wikimedia.org/63460#c5 (10Florian) I will push the patch later in a free minute :) [10:35:24] (03PS1) 10Florianschmidtwelzow: Check first if PasswordChange is available [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/137001 (https://bugzilla.wikimedia.org/63460) [10:37:55] (03PS2) 10Florianschmidtwelzow: Check first if PasswordChange is available [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/137001 (https://bugzilla.wikimedia.org/63460) [10:54:01] 3MobileFrontend / 3beta: Flash of Rory when clicking on redlink - 10https://bugzilla.wikimedia.org/64641#c4 (10Florian) I have tested this with Firefox ESR 17.0.1 and i became no flash of Rory, simply the editor? In alpha and beta :) [11:12:46] 3MobileFrontend / 3Feature requests: Review permission system for anonymous editing on mobile - 10https://bugzilla.wikimedia.org/53076#c24 (10Florian) > Any comment on when "sharing soon" might be? Is there any news? :) [11:35:17] 3MobileFrontend / 3beta: Main page "this page needs help" typography is incorrect - 10https://bugzilla.wikimedia.org/64265#c3 (10Florian) 5NEW>3RESO/INV The actual heading typo isn't Helvetica anymore. See change https://gerrit.wikimedia.org/r/#/c/120978 for vector (in addition to Typography refresh: htt... [12:37:12] (03PS6) 10Yuvipanda: Load selected history/bookmark/language items in the same fragment. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/136706 (owner: 10Dbrant) [13:27:46] (03PS1) 10Florianschmidtwelzow: Generate PHPDoc via Makefile [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/137011 (https://bugzilla.wikimedia.org/64398) [13:37:38] (03PS2) 10Florianschmidtwelzow: Generate PHPDoc via Makefile [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/137011 (https://bugzilla.wikimedia.org/64398) [13:59:11] (03PS1) 10Dbrant: Make "clear bookmarks" dialog consistent with "clear history" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/137016 [14:19:46] (03PS1) 10Dbrant: Tweak backgrounds in nav menu and search bar. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/137017 [14:51:56] (03PS1) 10Dbrant: Top left icon now slides *exactly* like Google apps (with hysteresis) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/137018 [15:18:48] (03PS4) 10BearND: [WIP] License text on every edit [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/136793 [15:22:54] Hi YuviPanda: would you mind taking a look? I added some prompts for leaving W0 when the links are clicked and W0 is active. I had to duplicate some of the bus handling code between PageActivity and EditSectionActivity. Any suggestions for refactoring? [15:23:16] (at the above patch) [15:25:29] YuviPanda: Also, I think designers would like to have a prompt about leaving the app in general when a link is clicked. Do we do that anywhere else? [15:26:46] (03PS5) 10BearND: License text on every edit [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/136793 [15:27:08] YuviPanda: only changed the commit message to not be WIP anymore [15:30:18] YuviPanda: I mean: PS5 only changed the commit message to not be WIP anymore; PS4 has the big changes [15:31:48] (03CR) 10BearND: [C: 031] "Since Yuvi is also dealing with About I'll let him coordinate when to merge it." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/136969 (owner: 10Dbrant) [15:35:02] YuviPanda: a few minor patches in the queue :) [15:46:13] (03CR) 10Cmcmahon: [C: 032] QA: Make page loading test run again [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/136766 (owner: 10Jdlrobson) [15:46:50] (03Merged) 10jenkins-bot: QA: Make page loading test run again [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/136766 (owner: 10Jdlrobson) [15:57:28] (03CR) 10BearND: Make "clear bookmarks" dialog consistent with "clear history" (031 comment) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/137016 (owner: 10Dbrant) [16:06:33] 3MobileFrontend / 3General/Unknown: Variant link prevents mobile redirect - 10https://bugzilla.wikimedia.org/66080 (10Jimmy Xu) 3NEW p:3Unprio s:3normal a:3None On zhwiki in addition to /wiki/ we have /zh-cn/ etc which act like ?variant=zh-cn. Google often index links with these variant prefix theref... [16:10:31] 3MobileFrontend / 3General/Unknown: Variant link prevents mobile redirect - 10https://bugzilla.wikimedia.org/66080#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/88rRBoIA [16:11:31] 3MobileFrontend / 3General/Unknown: Variant link prevents mobile redirect - 10https://bugzilla.wikimedia.org/66080#c2 (10Liangent) 5NEW>3RESO/DUP *** This bug has been marked as a duplicate of bug 51753 *** [16:14:29] * YuviPanda is back [16:14:42] bearND: for *any* link? I think that is excessive. Either way we shouldn't be doing any of that now :) [16:14:55] dbrant|lunch: can you look at bearND's patches? I'm going to look at yours now. [16:15:22] bearND: feel free to merge / CR dbrant|lunch's patches as well [16:16:43] YuviPanda: works for me. I did add the one for W0. I think we should do the same for the links in the about page. [16:16:55] bearND: for W0, probably, yeah [17:00:04] YuviPanda: Any good ideas on how to refactor the code for the bus subscriptions in my patch? I had to copy PageActivity.onWikipediaZeroInterstitialEvent() to EditSectionActivity. [17:00:04] bearND: we need a ZeroHandler class that encapsulates all Zero handling code, and have that be a singleton accessible from WikipediaApp [17:00:04] YuviPanda: yes, we could have that all in the zero package [17:00:04] bearND: yeah, agreed. [17:00:04] bearND: but ok right now, I think. we should focus on the beta for now. File a bug on bugzilla so we can keep track of it? [17:00:04] YuviPanda: good [17:03:45] (03PS1) 10Yurik: Update to match JCValidators patch in JsonConfig [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/137035 [17:04:14] (03CR) 10Yuvipanda: [C: 032] Add feedback link to About page. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/136969 (owner: 10Dbrant) [17:04:38] (03CR) 10Yuvipanda: [C: 032] Tweak backgrounds in nav menu and search bar. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/137017 (owner: 10Dbrant) [17:04:42] (03Merged) 10jenkins-bot: Add feedback link to About page. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/136969 (owner: 10Dbrant) [17:04:44] (03CR) 10Yuvipanda: [C: 04-1] Make "clear bookmarks" dialog consistent with "clear history" (031 comment) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/137016 (owner: 10Dbrant) [17:04:46] (03CR) 10Dr0ptp4kt: [C: 032] Update to match JCValidators patch in JsonConfig [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/137035 (owner: 10Yurik) [17:04:52] (03Merged) 10jenkins-bot: Tweak backgrounds in nav menu and search bar. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/137017 (owner: 10Dbrant) [17:04:54] (03PS2) 10Yuvipanda: Top left icon now slides *exactly* like Google apps (with hysteresis) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/137018 (owner: 10Dbrant) [17:05:10] (03CR) 10Yuvipanda: [C: 032] Top left icon now slides *exactly* like Google apps (with hysteresis) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/137018 (owner: 10Dbrant) [17:05:16] 3MobileFrontend / 3beta: Main page "this page needs help" typography is incorrect - 10https://bugzilla.wikimedia.org/64265#c5 (10Florian) Ok, than sorry :) [17:05:18] 3Wikipedia App / 3Android App: Refactor PageActivity.onWikipediaZeroInterstitialEvent - 10https://bugzilla.wikimedia.org/66081 (10Bernd Sitzmann) 3NEW p:3Unprio s:3normal a:3None Copied PageActivity.onWikipediaZeroInterstitialEvent() to EditSectionActivity. Should move this and other W0 functionality... [17:05:24] (03PS7) 10Yuvipanda: Load selected history/bookmark/language items in the same fragment. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/136706 (owner: 10Dbrant) [17:05:30] (03Merged) 10jenkins-bot: Top left icon now slides *exactly* like Google apps (with hysteresis) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/137018 (owner: 10Dbrant) [17:06:06] brion: heya! [17:06:14] yo [17:06:26] installing 10.10 beta on an old laptop, i coulnd’t resist :D [17:06:48] brion: hehe. yesterday was like a decade of christmases all in one day :) [17:07:11] brion: not much sleep last night [17:07:34] heheheh [17:07:48] brion: could you test if you can push a swift app to an ios6 device? super curious [17:07:59] hmmmm let’s find out [17:09:20] brion: i skimmed a large portion of the language pdf last night… some crazy-awesome stuff [17:10:21] ok fresh project defaults to 8.0 deployment target, let’s tweak that [17:10:24] YuviPanda: hey! [17:10:34] brion: fingers crossed [17:11:06] it let’s me select down to 6.0.... [17:11:28] sonofa [17:11:56] mhurd: it launches :D [17:11:57] on 3gs [17:13:30] brion: no way!!!!!!!! [17:13:35] brion: ahhhhahahahh!!!! [17:14:36] tfinc: ^ [17:15:05] :) [17:15:07] we probably shouldn’t migrate immediately ;) [17:15:10] mhurd: how are you liking swift ? [17:15:12] but good to know for later [17:15:33] i like that it compiles down to binaries using the same obj-c runtime [17:15:37] brion: gradually for sure - maybe start with a few categories to keep it simple [17:15:40] brion: ya! [17:15:43] so it’s not all that surprising it works :D [17:15:50] but it’s very happy [17:16:39] tfinc: it’s pretty great! [17:17:03] tfinc: xcode 6 looks amazing too [17:17:44] interesting [17:17:52] there’s a “resizable iphone” mode in the simulator o_O [17:18:00] mhurd: can you link me to the download for it? [17:18:06] brion: that same obj-c runtime compilation point is impressive [17:18:15] nm i see it [17:18:17] tfinc: should be in dev center? [17:18:21] tfinc: ah [17:19:13] oh and i see a "OS X Yosemite Developer" in there as well [17:19:18] i'll have to try that tonight [17:19:56] tfinc: yosemite!!! [17:20:02] tfinc: i approve [17:22:28] 3MobileFrontend / 3beta: Main page "this page needs help" typography is incorrect - 10https://bugzilla.wikimedia.org/64265#c4 (10Jon) 5RESO/INV>3REOP Not quite. Kaity is talking about the box at the top of the mobile main page which says "History of Tunisia" - the styling has changed. [17:22:53] i’m impressed that 10.10 supports my 4-year old spare macbook pro [17:23:09] supposedly every model supported by 10.9 is still supported [17:24:10] i’m really going to enjoy messing around with the new extensions system, especially on ios [17:29:49] mhurd: heya! [17:30:21] hey Deskana [17:33:30] brion: did you see interface builder’s new view hierarchy visualisations? [17:37:11] YuviPanda: Hey! [17:37:11] (03CR) 10Dbrant: Make "clear bookmarks" dialog consistent with "clear history" (031 comment) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/137016 (owner: 10Dbrant) [17:37:25] (03PS2) 10Dbrant: Make "clear bookmarks" dialog consistent with "clear history" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/137016 [17:39:08] mhurd: no that sounds bitchin :D [17:40:42] Deskana: in a meetintg, brb [17:42:44] waiting for things to install, be back in a bit to finish up CR :D [17:49:58] YuviPanda: how are you hiding the edit link when previewing changes? [17:50:13] mhurd: preview.css hides .edit_section [17:50:20] mhurd: preview.css is a different css file [17:50:28] YuviPanda: ah. makes sense [17:50:32] YuviPanda: thx! [17:51:19] mhurd: yw! [17:51:51] YuviPanda: whoa… lots of stuff in preview.css - shouldn’t it be mostly the same as styles.css? [17:52:02] mhurd: it is exactly the same :) [17:52:10] YuviPanda: ah. grunt [17:52:58] mhurd: similar system, but built by mediawiki resource loader [17:53:19] YuviPanda: oh wait. does this mean we have to sync 2 css files? [17:54:43] mhurd: I sync 3 files actually, one for the actual styles, one for preview, one for abusefilter [17:54:48] mhurd: they are in the scripts [17:55:03] YuviPanda: ah… cool. [17:55:22] YuviPanda: will update my stuff to do same [17:56:08] MaxSem: This user filed a feature request for Page Images [17:56:09] https://bugzilla.wikimedia.org/show_bug.cgi?id=66077 [17:56:43] thanks vbamba [17:56:44] mhurd: :) cool! [17:56:47] hey vbamba [17:57:10] it's a borderline wontfix though [17:57:13] Deskana: back! we have another meeting in a few mins, but let's catch up on IRC after [18:00:48] YuviPanda: design review finsihes in half hour [18:00:50] tlak then? [18:00:53] talk then? [18:00:59] vbamba: this meeting is going to take an hour, so after that [18:01:21] (03PS1) 10Yurik: Renamed i18n 'zeroconfig-*' into 'zero-config-*' [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/137059 [18:02:50] anyone seen jgonera about ? [18:02:51] jdlrobson: --^ [18:03:05] not immediately, although he was at his desk a few mins ago [18:03:55] tfinc: yeh he was here a few mins ago [18:05:44] (03PS6) 10Yuvipanda: License text on every edit [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/136793 (owner: 10BearND) [18:06:20] jgonera: meeting! [18:06:34] YuviPanda: could you re-send me the link to the file with the http://bits.beta.wmflabs.org urls for the 3 css files? [18:06:46] mhurd: sure! [18:10:01] (03CR) 10Raimond Spekking: [C: 032] Renamed i18n 'zeroconfig-*' into 'zero-config-*' [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/137059 (owner: 10Yurik) [18:10:11] (03Merged) 10jenkins-bot: Renamed i18n 'zeroconfig-*' into 'zero-config-*' [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/137059 (owner: 10Yurik) [18:12:06] (03PS1) 10Yurik: Cleaned out all of the old i18n messages [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/137062 [18:12:11] (03CR) 10jenkins-bot: [V: 04-1] Cleaned out all of the old i18n messages [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/137062 (owner: 10Yurik) [18:13:28] (03PS1) 10Dbrant: The Menu button (for phones that have it) opens the nav drawer. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/137063 [18:13:48] jdlrobson: around? MobileFrontend on tablet question. Are they served the same CSS as phones, with media queries making the diference? or are they served different things? [18:14:04] sure [18:14:09] YuviPanda: sadly [18:14:15] i wanted to be cool and only load tablet styles when needed [18:14:20] but it was too complicated [18:14:31] jdlrobson: heh, cache issues? [18:18:15] (03CR) 10Yurik: [C: 032 V: 032] "Coordinating it with Raymond" [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/137062 (owner: 10Yurik) [18:20:56] (03PS5) 10Yurik: Major refactoring [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/136252 [18:20:57] YuviPanda: talk at 12 [18:23:31] vbamba: ya makes sense [18:25:26] (03PS1) 10Jdlrobson: Ensure developers can use `make phplint` [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/137071 [18:29:20] (03CR) 10Jdlrobson: [C: 032] Revert "Fixing thumbnail sizing in search overlay" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/136906 (https://bugzilla.wikimedia.org/65997) (owner: 10JGonera) [18:29:21] @Jon: https://gerrit.wikimedia.org/r/#/c/136926/ [18:29:40] In addtion to: https://gerrit.wikimedia.org/r/137071 [18:29:55] (03Merged) 10jenkins-bot: Revert "Fixing thumbnail sizing in search overlay" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/136906 (https://bugzilla.wikimedia.org/65997) (owner: 10JGonera) [18:29:59] 3MobileFrontend / 3stable: Vertical padding in watchlist items is missing - 10https://bugzilla.wikimedia.org/65997#c2 (10Jon) 5NEW>3RESO/FIX Merged https://gerrit.wikimedia.org/r/136906 [18:30:06] hey FlorianSW :) [18:30:13] I think it's better to don't downgrade phpcs, it's working for me :) [18:30:14] i'm on it don't worry :) [18:30:22] Ah, ok :P [18:34:08] (03CR) 10Jdlrobson: [C: 032] "Awesome." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/137011 (https://bugzilla.wikimedia.org/64398) (owner: 10Florianschmidtwelzow) [18:34:45] thx for merge :) [18:35:22] (03Merged) 10jenkins-bot: Generate PHPDoc via Makefile [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/137011 (https://bugzilla.wikimedia.org/64398) (owner: 10Florianschmidtwelzow) [18:35:59] 3MobileFrontend / 3Hygiene: Get PHP documentation generating - 10https://bugzilla.wikimedia.org/64398 (10Florian) 5PATC>3RESO/FIX [18:39:32] 3MobileFrontend / 3Hygiene: make phpdoc shows errors in our PHP documentation - 10https://bugzilla.wikimedia.org/66086 (10Jon) 3NEW p:3Unprio s:3normal a:3Jon Here is the output when you run `make phpdoc`. Let's get this nice and clean! :) Parsing /Users/jrobson/Sites/w/extensions/MobileFrontend/inc... [18:41:05] (03CR) 10Jdlrobson: "I'm confused.. I thought composer.lock was generated from composer.json" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/136926 (owner: 10Florianschmidtwelzow) [18:41:19] (03CR) 10Jdlrobson: "See also https://gerrit.wikimedia.org/r/136926" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/137071 (owner: 10Jdlrobson) [18:44:18] (03CR) 10Jdlrobson: [C: 031] "Extremely minor concerns that I think should be done before merging. Someone else free to disagree." (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/137001 (https://bugzilla.wikimedia.org/63460) (owner: 10Florianschmidtwelzow) [18:45:36] (03CR) 10Florianschmidtwelzow: "Yeah, you are right. But, composer.lock is in git (correctly) to install all dependencies correct. But with this change https://gerrit.wik" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/136926 (owner: 10Florianschmidtwelzow) [18:45:59] 3MobileFrontend / 3Hygiene: make phpdoc shows errors in our PHP documentation - 10https://bugzilla.wikimedia.org/66086#c1 (10Florian) Yeah, this is a lot of writing work :D If it's ok, i would like to do that, so i can learn a little bit, what functions and functionallity MobileFrontend has, so assigne to me... [18:48:17] (03PS1) 10Yurik: i18n cleanup [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/137080 [18:50:46] (03PS1) 10Yurik: i18n cleanup [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/137081 [18:50:51] (03CR) 10jenkins-bot: [V: 04-1] i18n cleanup [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/137081 (owner: 10Yurik) [18:53:27] (03CR) 10Raimond Spekking: [C: 032] i18n cleanup [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/137080 (owner: 10Yurik) [18:53:36] (03Merged) 10jenkins-bot: i18n cleanup [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/137080 (owner: 10Yurik) [18:53:38] (03CR) 10Raimond Spekking: [C: 032] i18n cleanup [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/137081 (owner: 10Yurik) [18:53:42] (03CR) 10jenkins-bot: [V: 04-1] i18n cleanup [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/137081 (owner: 10Yurik) [18:57:16] (03PS3) 10Florianschmidtwelzow: Check first if PasswordChange is available [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/137001 (https://bugzilla.wikimedia.org/63460) [18:57:18] (03CR) 10Florianschmidtwelzow: Check first if PasswordChange is available (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/137001 (https://bugzilla.wikimedia.org/63460) (owner: 10Florianschmidtwelzow) [18:57:34] (03PS3) 10Jdlrobson: Add template dependency to Mantle extension [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129335 [18:57:53] (03CR) 10Florianschmidtwelzow: "> Someone else free to disagree." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/137001 (https://bugzilla.wikimedia.org/63460) (owner: 10Florianschmidtwelzow) [18:58:45] 3MobileFrontend / 3Hygiene: make phpdoc shows errors in our PHP documentation - 10https://bugzilla.wikimedia.org/66086#c2 (10Jon) 5NEW>3ASSI a:5Jon>3Florian Florian that would be awesome. Assigning to you! :) [18:59:39] (03CR) 10jenkins-bot: [V: 04-1] Add template dependency to Mantle extension [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129335 (owner: 10Jdlrobson) [19:04:01] hey mhurd [19:04:28] YuviPanda: thx for email bump! forgot you had emailed it :) [19:08:17] mhurd: :) [19:08:29] mhurd: do poke vibha if you see her, she wanted to talk to me at 12 :) [19:08:32] * YuviPanda waves at Deskana [19:08:40] YuviPanda: will do! [19:08:42] YuviPanda: Hey! What's up? [19:08:53] Deskana: talk page meeting prep talk. [19:09:13] (03CR) 10Yurik: [C: 032 V: 032] i18n cleanup [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/137081 (owner: 10Yurik) [19:09:48] So I'm going to think about exactly what our options are and start the meeting there. [19:10:01] What our options are and what the implications of each is. [19:10:23] I mean you can say "wait for Flow, or not wait", but what implications do those actually have for us? [19:10:30] I don't think that's entirely clear yet. [19:10:47] Deskana: right. and also to define what 'wait for flow' means. Flow to be feature complete, or available enough to give people a nice experience [19:11:11] Well that decision may not even be in our hands, which was your point yesterday; it's for Flow to decide when to put Flow on pages, which affects us. [19:11:24] So we're having our timeline be dependent on theirs which can be tricky too. [19:12:01] Deskana: indeed, and realistically from what I know that can be a, uh, while. Also must be prepared for a VE style community response for flow as well (although I don't think that's going to happen to the same extent) [19:15:56] YuviPanda: are you bundling the css files as well or just downloading them? [19:16:15] mhurd: bundling as well, so first time they'll just load from the bundle [19:16:21] YuviPanda: cool [19:16:26] YuviPanda: me too [19:16:51] mhurd: I'm going to move the styles to be android specifi and iOS specific in a minute [19:17:13] hey bearND! [19:17:52] YuviPanda: cool. will styles.css still have basically what it has now? just no android specific stuff, then there’ll be a styles-ios.css too? [19:18:18] mhurd: yeah, I'm going to make a .android and .ios, and strip out the android UI stuff from .ios [19:18:24] mhurd: the URLs will change, I'll keep you posted [19:18:48] i’m kinda offtrack today but i’m playing with ios 8 stuff and it’s WONDERFUL [19:18:54] making a share extension looks just STUPID easy [19:19:05] it even provides a default compose dialog which you can extend with some selectors [19:19:33] this’ll be really fun in the fall :D [19:19:37] YuviPanda: so the ios file is going to have all the styles stuff in it? [19:19:46] mhurd: yeah, pretty much [19:20:10] YuviPanda: my preference would be to have it only contain any ios specific things. in other words, mostly blank [19:20:18] mhurd: hmm? [19:20:40] mhurd: so, ResourceLoader (mediawiki's version of grunt) packages several .less files into one css file [19:20:54] mhurd: so for iOS, it'll have all content styles only, and nothing else. we can add iOS specific things later if we want [19:21:05] mhurd: for android it'll have all content styles and also ANdroid specific UI styles [19:21:23] mhurd: so from your perspective, only change will be a small URL shift (which would be stable afterwards) [19:21:50] bearND: can you CR https://gerrit.wikimedia.org/r/#/c/136706/ and other patchs from dbrant? [19:22:01] I'm fixing some Extension:MobileApp stuff [19:22:01] hey YuviPanda! [19:22:15] dbrant: can you CR the license text stuff from bearND? [19:22:17] YuviPanda: i think a much cleaner division would be to keep the common things in styles.css, and have a our platform specific things, very minimal, in platform specific files [19:22:28] YuviPanda: ok [19:22:30] YuviPanda: bearND: yep [19:22:39] mhurd: that is exactly what's happening, except you are downloading them as one file instead of multiple files [19:22:51] mhurd: this reduces bandwidth costs all around, and also lets us do minification [19:22:54] YuviPanda: confused [19:23:01] mhurd: check out mediawiki/extensions/MobileApp for a clearer picture? [19:23:08] YuviPanda: k [19:23:32] YuviPanda: oh do you have a url for that? [19:23:48] mhurd: it's on gerrit, mediawiki/extensions/MobileApp.git [19:23:56] YuviPanda: ah thanks! [19:29:36] YuviPanda: poked around the extension. makes more sense [19:29:38] :) [19:29:43] mhurd: :) [19:30:00] YuviPanda: will new css url be ready soon? [19:30:18] mhurd: yeah, in about 10m if I can find someone to merge [19:30:45] YuviPanda: will it just be new url for styles.css, or abusefilter.css and preview.css too? [19:31:07] mhurd: abusefilter.css is, atm, same as styles.css :) preview will be the same [19:31:14] mhurd: since atm preview does not have any OS specific thing [19:31:41] YuviPanda: ok, so whatever platform specific things we add will flow to these files as well? [19:31:51] mhurd: to the styles, yeah [19:45:48] (03PS1) 10Yuvipanda: Update StyleFetcher to fetch from new RL module names [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/137097 [19:46:24] brion: mhurd http://www.idownloadblog.com/2014/06/03/yosemite-ios-8-screenscasting/ :) [19:46:49] oh sweeeeeeet [19:51:55] tfinc: ok i can confirm that works with my 10.10 test box :D [19:52:08] excellent. it will make demos so easy [19:52:12] i wonder if we can hook it up direct to a hangout too [19:52:36] this’ll be much better for demoing some workflows than using the simulator yeah [20:02:37] YuviPanda: So to continue our discussion that I aborted by walking away from my desk in the middle of it... [20:03:27] Deskana: :D [20:03:31] Deskana: 'tis ok, this is IRC [20:03:37] YuviPanda: I'll spend an hour today at 4pm sketching out our options wrt talk pages, and their dependencies. [20:04:10] Deskana: cool. I'll be happy to be sounding board on whatever, technical or otherwise, if you want :) [20:04:25] (03PS6) 10Yurik: Major refactoring [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/136252 [20:04:30] I also wasn't aware that it was technically possible to go to talk pages. [20:04:46] Which probably speaks for itself if the product owner for the product wasn't aware it was possible... [20:05:57] (03PS8) 10BearND: Load selected history/bookmark/language items in the same fragment. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/136706 (owner: 10Dbrant) [20:06:43] YuviPanda: And yes, it is IRC, but as you are remote I want to make a special effort to make sure you feel like you're getting enough time with me. :) [20:06:45] (03CR) 10BearND: [C: 032] Load selected history/bookmark/language items in the same fragment. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/136706 (owner: 10Dbrant) [20:06:53] YuviPanda: there? [20:06:57] Deskana: woot! :D [20:07:05] (03Merged) 10jenkins-bot: Load selected history/bookmark/language items in the same fragment. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/136706 (owner: 10Dbrant) [20:07:26] Deskana: yeah, there are no namespace restrictions, but they don't show up until *after* the :. So if you type 'Tal' it won't show up, but if you type 'Talk:' they will [20:07:32] (03PS3) 10BearND: Make "clear bookmarks" dialog consistent with "clear history" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/137016 (owner: 10Dbrant) [20:07:52] YuviPanda: That's just because that's how the OpenSearch API works, right? [20:08:17] Deskana: yeah [20:08:24] vbamba: yea [20:08:41] (03CR) 10BearND: [C: 032] Make "clear bookmarks" dialog consistent with "clear history" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/137016 (owner: 10Dbrant) [20:08:58] bearND: awesome; looking at yours now... [20:08:59] (03Merged) 10jenkins-bot: Make "clear bookmarks" dialog consistent with "clear history" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/137016 (owner: 10Dbrant) [20:10:07] dbrant: firing up my GingerBread device so I can test https://gerrit.wikimedia.org/r/#/c/137063/ ... [20:11:13] "Firing up my GingerBread device" [20:11:19] I know what it means but it still makes me laugh [20:11:54] something Santa would say? [20:13:56] In the 1990s we baked gingerbread houses. Now, we make gingerbread devices. [20:14:07] iGinger [20:15:37] Deskana: GingerBread is so 2011 [20:17:01] bearND: sorted out with YuviPanda [20:18:38] vbamba: oh the icon stuff? [20:21:24] Deskana: :) we'll make a build soon, lots of important things getting merged [20:26:13] Deskana: Maryana tfinc we should have a beta release candidate in a few hours. will mail out for people to test [20:27:15] YuviPanda: eager to test it [20:27:39] bearND: go for switching out the icons to search_w [20:27:56] YuviPanda: ok [20:30:32] (03CR) 10Dbrant: License text on every edit (032 comments) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/136793 (owner: 10BearND) [20:30:44] bearND: a couple small things ^ [20:31:54] YuviPanda: \o/ [20:38:54] (03PS1) 10BearND: Change action bar home icon to W icon [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/137163 [20:48:45] mhurd: the old URL won't be working anymore. did I send you the new URLs? [20:49:59] YuviPanda: oh cool! [20:50:24] YuviPanda: no i don’t think i have the updated urls yet [20:51:37] mhurd: ah, moment [20:51:45] YuviPanda: in interview right now - so no rush :) [20:51:52] mhurd: I'll email [20:53:53] (03CR) 10Yuvipanda: [C: 032] "The W icon baseline doesn't match the title baseline, looks off. But better than the previous one." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/137163 (owner: 10BearND) [20:59:39] bearND: dbrant 4pm PDT cutoff time for patches being merged, and then a noon beta release tomorrow. thoughts? [21:00:12] YuviPanda: brilliant. [21:00:26] dbrant: so that gives us two more hours. think that is sufficient? [21:01:13] YuviPanda: dbrant: sounds great. about to submit another patch for the license text on every edit [21:01:28] bearND: cool [21:01:34] YuviPanda: I think it's manageable [21:01:58] dbrant: cool. we can make it 4:30 if you think that gives us more time but that might be too late for you guys on East Coast? [21:02:34] Deskana: I just discovered that we get a free bonus - on tablets with the app the MobileFrontend tablet styles will apply! Haven't tested though [21:05:08] (03Merged) 10jenkins-bot: Change action bar home icon to W icon [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/137163 (owner: 10BearND) [21:10:15] MaxSem: around? [21:11:34] YuviPanda, [21:11:36] yes [21:13:29] MaxSem: so, need to SWAT a small patch. or essentially just update MobileApp to master across all wikis, tomorrow. how hard? [21:14:00] MaxSem: also is there a swat window open later today? I just realized we need that for the app beta release tomorrow. it's also just all style changes, no php [21:14:19] MaxSem: actually, and a PHP change as well :| [21:14:24] damnit, should've caught this earlier. [21:14:41] YuviPanda, I will not be available, but other deployers will be [21:14:47] (Comcast) [21:14:58] MaxSem: haha. right. let me go look at the SWAT page [21:15:45] greg-g, ^^ [21:16:15] YuviPanda: are those changes merged into master, ie on beta? [21:16:15] let me see what patches need to go out [21:16:19] greg-g: yes, they are on beta [21:16:25] good deal :) [21:16:53] greg-g: think I can get them SWAT'ed during the 2300 window today? or is it too late for that? [21:16:59] also I don't know what time it is. let me check [21:17:04] heh [21:17:07] ok, two hours left [21:17:07] almost [21:17:09] it's 21 [21:17:21] not terribly late, no [21:17:59] greg-g: should I cherry-pick the patches to wmfNN branches, or can the SWAT members just update to master for me? [21:18:42] (03PS7) 10BearND: License text on every edit [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/136793 [21:18:51] YuviPanda: cherry-picks only [21:19:11] greg-g: alright, let me get that done and add to calendar. [21:19:22] dbrant: YuviPanda: ^ one more small change to the license text stuff from my previous patch: I also hide the license text container once one of the options (log in + save; anon save) is pressed [21:19:51] dbrant: bearND can you guys CR the rest of the stuff? just realized we hadn't deployed the styles to the entire cluster, need to rush to make the 23:00 UTC window. [21:20:44] YuviPanda: yep! [21:22:18] greg-g: there are 6 (small) patches, 5 CSS, 1 minor PHP (adds edit tags). Is that ok for a SWAT? I see there's a 'max 8 patches' limit. [21:22:23] greg-g: sorry for all the questions, first time I'm doing this [21:36:59] YuviPanda: no worries sir [21:37:26] YuviPanda: are those all separate cherry-picks? or can you group 'em? [21:37:42] greg-g: I can squash them if you want, yeah. [21:37:59] just makes it easier for the SWATers [21:38:08] greg-g: alright, let me squash. [21:38:13] thanks man [21:40:51] dbrant: are you in the middle of reviewing https://gerrit.wikimedia.org/r/#/c/136793/7? If not I'd have a minor change to add [21:40:54] YuviPanda: It seems there's a bit of confusion about what the latest version of the Android app is. [21:41:09] greg-g: we pushed out one on the 30th [21:41:11] YuviPanda: Can you take a look at the Play store and make sure it's got the latest version? Maryana and I are running different ones. :/ [21:41:12] bearND: go ahead & add it [21:41:24] Deskana: that's because someone sent maryana a more later version by email, I think [21:41:34] (03PS8) 10BearND: License text on every edit [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/136793 [21:41:36] Deskana: and once you install *that* it doesn't auto update, since it is out of band [21:41:40] dbrant: ^ [21:42:04] Deskana: I just realized we have to deploy the MobileApp changes across the cluster, so rushing now to make the 23:00 UTC window [21:43:26] YuviPanda: Yeah, but mine seems to be really out of date. [21:43:43] (03PS1) 10Dbrant: Fix logout behavior. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/137196 [21:43:46] It doesn't have any of the design tweaks. [21:43:47] Deskana: that's also perhaps because *I* sent you a custom build even more time ago, and that also won't update since that's out of band [21:43:59] I never got around to putting that on my device. [21:44:02] Deskana: we haven't made a release since the design tweaks. [21:44:11] Ahh, okay, so I guess what I'm asking is, can you? :) [21:44:14] Deskana: anyway, let me mail you a build now. [21:44:19] bearND: ^ minor (but critical) change of my own; fixes logging out. [21:44:51] dbrant: bearND can either of you guys just send an ad-hoc build to Deskana? :) [21:45:02] dbrant: great. checking it out [21:45:05] Just so I know, why can't we just put it on the app store? [21:45:48] I've got a new laptop since I set up my development environment so it'll take me a little time to get to the state where I can load a custom APK onto my tablet. [21:45:58] Was just wondering what's changed wrt our frequent Play store releases, if anything has. [21:47:01] Deskana: mostly just a lapse on our part, honestly. also, if we put it out to the play store, it takes a few hours for it to reach everyone's devices. [21:47:15] airdroid? [21:47:30] Deskana: to be fair, we did do a release on the 30th :) we just haven't been doing them every day [21:48:01] Deskana: and 30th was just 1 working day ago, and I didn't do any over the weekend. so practically nothing much has changed, except I was away at the Loch during the weekend and we didn't do one yesterday :) [21:48:15] Okay, well, I'll have to wait to test it until it's on the Play store, probably. Too busy to set up the development environment this week. [21:49:36] Deskana: what? you don't need a dev environment [21:49:55] Deskana: just forward it to whatever email account you have on your tablet, then just open it there. it will automatically install [21:50:08] * Deskana didn't realise it was that simple. [21:50:13] Deskana: we are no iOS! :) [21:50:30] Deskana: I just sent you the latest Android apk (with my license text announcement on edit screen changes - dbrant is currently looking to CR those changes) [21:50:52] Deskana: let me know if you have troubles. you need to enable it from settings first, but that should be fairly easy. [21:51:20] YuviPanda: I think I've already done that. [21:51:36] Deskana: cool! :) then you should be good to go [21:51:47] Deskana: we'll make an alpha update once all these things are merged today [21:52:25] Deskana: you can open the apk from the email I just sent you on your Android device, which would let you install it [21:52:53] Deskana: you'd have to uninstall the previous version, though since that probably came from someone else [21:53:00] bearND: not seeing the license text when not logged in... [21:54:04] dbrant: it's on the Preview edit screen, right under the Log in and save vs Save anonymously options [21:55:06] dbrant|brb: probably could use more contrast, to better distiguish from the preview [22:01:58] YuviPanda, bearND: I think we're not getting CSS on this version of the app. [22:03:17] greg-g: https://wikitech.wikimedia.org/w/index.php?title=Deployments&diff=115149&oldid=115136 :D first SWAT request, hopefully it is alright. [22:03:43] Deskana: yeah, that'd be fixed by https://gerrit.wikimedia.org/r/#/c/137097/ [22:04:02] Deskana: let me email you a fixed build :) [22:05:24] looks good [22:05:40] greg-g: woo! I'll make sure to be around SWAT time [22:06:39] (03CR) 10BearND: [C: 032] Fix logout behavior. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/137196 (owner: 10Dbrant) [22:07:14] YuviPanda: is https://gerrit.wikimedia.org/r/#/c/137097/ ready for CR? [22:07:27] bearND: yup! [22:07:42] YuviPanda: checking it out [22:07:46] bearND: cool [22:08:23] (03Merged) 10jenkins-bot: Fix logout behavior. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/137196 (owner: 10Dbrant) [22:16:58] (03PS1) 10Yuvipanda: Make downloading styles more robust [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/137212 [22:17:03] bearND: ^ as well. [22:22:23] YuviPanda: when i run the script, shouldn't i get updated css files? [22:22:35] bearND: the make-css-assets.bash script? [22:22:41] YuviPanda: yes [22:22:44] bearND: yeah, you should, but there haven't been any significant changes to it in a while. why? [22:23:05] bearND: just the URLs changed, the content of the files is the same [22:23:25] YuviPanda: just testing it. i was expecting updated css files, but i guess there were no changes there at all. ok. [22:23:36] bearND: yeah, no css changes [22:23:40] YuviPanda: another question: why are we still pulling from beta labs? [22:23:58] bearND: we will update to production when we make the release. [22:24:05] bearND: since betalabs deploys instantly, but production takes up to two weeks [22:26:00] YuviPanda: you mean production release? [22:26:16] bearND: no, using bits.wikimedia.org rather than bits.beta.wmflabs.org [22:26:49] bearND: oh, I mean, we will make a commit when releasing for Wikipedia Beta that changes the icon, name, etc. in that I'll switch the URL as well [22:28:57] (03PS1) 10Yuvipanda: Send app session ID with URL rather than using EL [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/137214 [22:28:59] (03CR) 10jenkins-bot: [V: 04-1] Send app session ID with URL rather than using EL [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/137214 (owner: 10Yuvipanda) [22:29:29] (03PS2) 10BearND: Update StyleFetcher to fetch from new RL module names [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/137097 (owner: 10Yuvipanda) [22:29:49] (03CR) 10BearND: [C: 032] Update StyleFetcher to fetch from new RL module names [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/137097 (owner: 10Yuvipanda) [22:30:17] (03Merged) 10jenkins-bot: Update StyleFetcher to fetch from new RL module names [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/137097 (owner: 10Yuvipanda) [22:31:24] (03PS2) 10BearND: Make downloading styles more robust [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/137212 (owner: 10Yuvipanda) [22:34:44] dbrant: have you tested https://gerrit.wikimedia.org/r/#/c/137063/ [22:35:18] YuviPanda: I have. (it's my patch) [22:35:28] dbrant: cool, let me merge then [22:35:30] (03CR) 10BearND: [C: 032] Make downloading styles more robust [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/137212 (owner: 10Yuvipanda) [22:35:48] (03Merged) 10jenkins-bot: Make downloading styles more robust [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/137212 (owner: 10Yuvipanda) [22:35:58] (03PS2) 10Yuvipanda: Send app session ID with URL rather than using EL [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/137214 [22:36:00] (03CR) 10jenkins-bot: [V: 04-1] Send app session ID with URL rather than using EL [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/137214 (owner: 10Yuvipanda) [22:38:25] (03CR) 10Yuvipanda: [C: 032] The Menu button (for phones that have it) opens the nav drawer. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/137063 (owner: 10Dbrant) [22:38:44] (03Merged) 10jenkins-bot: The Menu button (for phones that have it) opens the nav drawer. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/137063 (owner: 10Dbrant) [22:38:51] (03PS9) 10Dbrant: License text on every edit [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/136793 (owner: 10BearND) [22:39:44] (03PS3) 10Yuvipanda: Send app session ID with URL rather than using EL [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/137214 [22:42:54] dbrant: have a last minute analytics change as well that needs to go in, in order to have us avoid killing our servers :) [22:43:47] bearND: (sorry for delay), I meant to say it's completely hidden, along with the login/anon options. [22:44:27] dbrant: which device did you test this with? [22:45:39] bearND: Galaxy S3, Galaxy S4. [22:45:42] bearND: log out -> edit a section -> go to preview -> license text [22:45:56] *license text not displayed [22:47:03] dbrant: does it show when you're logged in? [22:47:10] bearND: it does. [22:51:47] dbrant: you have to tap save again at preview to get it to display [22:55:13] YuviPanda: bearND: oohhh, so it's displayed automatically when you're logged in; but if you're not logged it, it waits until you click Save? [22:55:30] dbrant: yeah [22:55:55] dbrant: when you're not logged in there is an extra step [22:56:16] i see... [22:56:47] i wish we had a different action bar icon for the previous steps, and the check mark only for the last step [22:57:33] bearND: should happen before shipping I guess [22:58:51] oh, YuviPanda, your patches are in the wrong day [22:58:54] move 'em to tuesday [22:58:58] the 3rd, not the 2nd [22:58:59] greg-g: oh, gah. [22:59:01] I have to run [22:59:05] later! [22:59:18] greg-g: thanks for catching [23:05:32] dbrant: bearND we should get the outstanding patches merged, despite it being past 4pm, I think. [23:05:41] (03CR) 10Dbrant: [C: 032] "Good for now, but will need a bit of refinement. (e.g. when not logged in, there's a chunk of whitespace above the preview before the user" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/136793 (owner: 10BearND) [23:06:35] dbrant: bearND can either of you poke https://gerrit.wikimedia.org/r/#/c/137214/ [23:08:01] (03CR) 10Jdlrobson: [C: 032] "WFM" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/137001 (https://bugzilla.wikimedia.org/63460) (owner: 10Florianschmidtwelzow) [23:08:19] (03PS4) 10Jdlrobson: Check first if PasswordChange is available [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/137001 (https://bugzilla.wikimedia.org/63460) (owner: 10Florianschmidtwelzow) [23:11:59] YuviPanda: So I was just going over our planning with Erik and Howie. [23:12:20] I ended up with a list of questions for us to consider tomorrow. [23:12:36] Deskana: coool! like? (if it isn't too much hassle to tell me now) [23:13:08] I tried to paste it in here but it ended up being massive. [23:13:09] Hold on. [23:13:13] Do we “wait for Flow”? [23:13:18] What does it mean to “wait for Flow”? (e.g. wait until it’s good enough for us on Mobile, or wait until it’s good enough for full rollout) [23:13:23] Does this introduce too many interdependencies for the apps team (such as Flow has to be “good enough” for desktop before we can use it on mobile properly?) [23:13:28] Do we only allow users to access Flow pages? [23:13:31] Does that give us wide enough coverage? [23:13:40] Do we do some work on a solution for talk pages, but focus most of our effort on Flow, such that we’ve got all aspects of the talk page in an (at least) usable state on apps? [23:13:52] And then wrt notifications: [23:13:52] Notifications and discussions are, to some degree, interdependent (e.g. the way “You’ve been mentioned on Talk:X” works depends on our solution to the discussions problem). The way this proceeds depends on that. [23:14:43] I'm going to come to the meeting tomorrow with my initial impressions of answers to these questions, and we can iterate from there [23:15:22] Deskana: cool! [23:15:48] * YuviPanda pokes dbrant and bearND with https://gerrit.wikimedia.org/r/#/c/137214/ again :) [23:15:58] YuviPanda: yep, looking at it now [23:16:01] dbrant: ty [23:16:03] YuviPanda: dbrantme too [23:16:03] I think we're already converging to no we do not "wait for Flow" and that we implement some talk page framework. [23:16:22] dbrant: I confirmed with analytics that it is being received serverside, even though they have no way of capturing it for analysis yet. [23:16:32] Deskana: woot! HappyPanda [23:19:01] But at this stage it's too early to say; I think we've not explored the alternative option of "Let's just support Flow pages" yet, because it may be that that is good enough given the Flow timeline for release. [23:19:19] It may or it may not. We should be able to say "We have investigated that thoroughly and it does not work for us", and we're not there yet :) [23:20:24] I suspect it's not enough, FYI. But we should explore it more. :) [23:21:34] bearND: any objections to YuviPanda's patch? (looks good to me) [23:22:29] dbrant: no objection, looks good to me. mainly removed the funnel thingy, and added a parameter to requests [23:23:14] (03CR) 10Dbrant: [C: 032] Send app session ID with URL rather than using EL [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/137214 (owner: 10Yuvipanda) [23:23:16] (03CR) 10jenkins-bot: [V: 04-1] Send app session ID with URL rather than using EL [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/137214 (owner: 10Yuvipanda) [23:24:03] dbrant: bah, maybe needs a manual rebase. looking [23:24:13] YuviPanda: conflict? :( [23:24:19] dbrant: yeah, let me resolve [23:24:49] dbrant: lol, my stupid IntelliJ fault. fixing [23:25:27] YuviPanda: what's the matter? [23:26:07] (03PS4) 10Yuvipanda: Send app session ID with URL rather than using EL [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/137214 [23:26:17] bearND: I had IntelliJ set to automatically 'fix' imports, and of course that caused merge conflicts [23:26:22] dbrant: bearND fixed, can you +2 again? [23:26:42] dbrant: bearND let me make a release on the play store [23:27:15] (03CR) 10Dbrant: [C: 032] Send app session ID with URL rather than using EL [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/137214 (owner: 10Yuvipanda) [23:27:37] (03PS1) 10Yuvipanda: Fix stray AboutActivity entry [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/137224 [23:27:42] w00t! [23:27:53] bearND: dbrant cool! :D [23:28:15] dbrant: bearND hmm, found a stray AboutActivity entry, unsure how the app compiled so far?! [23:28:41] HappyPanda: ha!! yes indeed [23:29:16] * bearND rebuilding [23:29:24] (03PS1) 10Yuvipanda: Bump version number for 2.0-alpha-2014-06-03 [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/137225 [23:29:26] hehe [23:29:49] Deskana|Away: heh, true on all counts. we should explore it thoroughly. if Flow on all places is viable in 3 months that's find, but I dunno how likely that is [23:30:23] HappyPanda: don't want to remove the extra AboutActivity in that patch? [23:30:24] dbrant: bearND making release now. [23:30:38] HappyPanda: dbrant: Just gulled master and rebuilt. It builds fine. [23:30:43] pulled [23:30:47] bearND: yeah, weirdl [23:30:54] dbrant: let's remove it, the bump patch is dependent on that. [23:31:09] HappyPanda: ah, didn't see that [23:31:16] dbrant: :) [23:32:40] (03CR) 10Dbrant: [C: 032] Fix stray AboutActivity entry [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/137224 (owner: 10Yuvipanda) [23:33:54] HappyPanda: hey the ios style still seems to have that spacing on top. is there something else i need to do to remove it? [23:34:05] (03CR) 10Dbrant: [C: 032] Bump version number for 2.0-alpha-2014-06-03 [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/137225 (owner: 10Yuvipanda) [23:38:49] (03PS2) 10Jdlrobson: Hygiene: Fix some FIXMEs [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/136501 [23:39:08] mhurd: ah, that rule didn't get rmeoved, I just noticed. let me fix for you. [23:39:23] HappyPanda: cool thanks! [23:39:33] mhurd: will poke when done, doing release now [23:40:14] HappyPanda: did you use your script for the release? just wondering why caused issues for me last week [23:40:30] HappyPanda: cool. oh is there an updated url for the preview too? [23:41:25] HappyPanda: or should i just use mobile.app.pagestyles.ios for that now as well? [23:42:14] HappyPanda: your diff only showed the styles.css and abusefilter.css urls changing [23:42:28] mhurd: preview styles are the same for both iOS and Android at the moment, since the UI styles aren't included. [23:42:43] mhurd: indeed, so preview is the same old URL [23:42:54] bearND: no, am making those with IntelliJ atm. will look at scripts in a bit [23:43:04] HappyPanda: does the preview style suppress the “Edit” link? [23:43:19] mhurd: yes, looks for .edit-page and hides them [23:43:29] HappyPanda: perfect. hooking it up now [23:43:43] mhurd: https://gerrit.wikimedia.org/r/#/c/137227/ is the patch that should get rid of the top thing for you [23:44:28] mhurd: now just need someone to merge it... :) [23:44:33] mhurd: brion ^ [23:45:37] dbrant: bearND alpha pushed. putting apk on releases and emailing out now [23:46:07] HappyPanda: bearND: songs will be sung of this day. [23:46:23] dbrant: bearND indeed! [23:46:55] evening. i've just installed REL1_22 of MobileFrontend on my wiki, and the "Mobile version" link that appears on the front page (and other pages) uses https://, not http://. Any particular reason why? I don't have https on this server. [23:47:55] dbrant: HappyPanda: lalalalalala [23:48:20] incidentally, this appears to only happen on the desktop version - If I head to the site on an iPad, it detects mobile and shows the http:// version. [23:49:26] HappyPanda: are you using the first part of the script (to bump the versions) at least? [23:49:59] bearND: no, since you reported the issue I just used the intelliJ bit. I might rewrite the script in python at some point as well [23:51:52] HappyPanda: it could've also been a difference in environment. Looks like you had a gerrit remote, which I don't have (see https://gerrit.wikimedia.org/r/#/c/136267/) [23:52:09] bearND: yeah, it makes a lot of assumptions. [23:56:19] Maryana: Deskana bearND dbrant brion email sent, apk uploaded, trello cards moved appropriately! [23:56:31] Maryana: Deskana bearND dbrant now to test test test for a few hours today and tomorrow. :) [23:56:33] sorry, i know my way around mediawiki software, but not mediawiki development - is there a issues/bug tracker for MobileFrontend? Am I in the right channel? I'm looking to see if someone has previously reported my https bug. [23:57:07] Morbus: heya! jdlrobson might be able to help. Also you can file bugs in bugzilla.wikimedia.org under the 'Mobile' component [23:57:12] s/component/product/ [23:57:42] thanks. [23:57:51] * Morbus is currently inside getMobileUrl() adding debugging statements ;) [23:58:13] Maryana: Deskana if you guys have the older version of the app, you should uninstall and install from play, or install the new apk I linked to in my mobile-l announcement [23:58:53] HappyPanda: thanks. looks like https://bugzilla.wikimedia.org/show_bug.cgi?id=61358 is mine. [23:59:00] will confirm/provide more info. [23:59:44] liangent: heya! new alpha went out, will become beta tomorrow