[00:00:53] * ragesoss is also putting kids to bed. [00:01:22] actually ... I feel the new interface is not as pretty as how it looked before? [00:01:29] Is it just me? [00:02:04] liangent: anything specific? [00:02:18] I was starting to like the green, although I was never quite sure why it was green. [00:02:35] dbrant: the sidebar is too dark? [00:03:17] The TOC icon makes the top bar feel crowded, but without it TOC had a discoverability problem. [00:03:28] dbrant: the menu (langlinks/bookmark/share) is too wide now [00:03:28] tfinc: bearND Deskana dbrant back! and yay, cool [00:03:36] YuviPanda: Hey, quick query. [00:03:39] Deskana: sure [00:03:39] YuviPanda: I'm sat with Dario. [00:03:44] https://en.wikipedia.org/w/index.php?title=Special:RecentChanges&tagfilter=mobile+app+edit [00:03:47] See those edits? [00:03:56] If you click on a diff, e.g. https://en.wikipedia.org/w/index.php?title=International_Society_for_Krishna_Consciousness&curid=174201&diff=611602192&oldid=609816982 [00:04:02] It doesn't show as being tagged as an app edit anymore [00:04:17] Any ideas why? [00:04:24] Deskana: hmm, that's weird. sounds like an upstream bug with things that have multiple tags only showing one tag [00:04:53] Deskana: I don't recall if we ever had multiple tags before. you can test this by blanking a section on testwiki while on MobileFrontend to see if the sectionblanking tag appears as well [00:05:59] YuviPanda: iirc rc tags are stored separately from revision tags [00:06:15] Did you add tags to everything? [00:06:21] liangent0: hmm, but I stole the code very literally from MobileFrontend so should be teh same [00:06:22] liangent0: agree about overflow width. It's because the 'other languages' string is too long. [00:06:23] liangent0: let me verify [00:06:34] ragesoss: I think we should remove the 'this page' thing from there [00:06:59] Yes. "Read in other languages" [00:07:33] Or you mean all three? [00:07:55] And then maybe just "Other languages"? [00:08:01] 3Wikipedia App / 3Android App: search for # crash - 10https://bugzilla.wikimedia.org/66151 (10Bernd Sitzmann) 3NEW p:3Unprio s:3normal a:3None OTRS 2014052810000779 https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom;TicketID=7574328 USER_COMMENT=performed a search for "#" ANDROID_VERS... [00:08:57] (03PS1) 10Yuvipanda: Shorten messages in the overflow menu [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/137501 [00:08:59] ragesoss: ^ [00:09:18] mhurd: doing the style changes now [00:09:30] YuviPanda: cool thanks! [00:09:46] YuviPanda: +1 [00:10:07] ragesoss: +1 there! :D [00:10:08] Languages is still far longer than the others, though. [00:10:46] 3Wikipedia App / 3Android App: Ampersand in page titles - 10https://bugzilla.wikimedia.org/66152 (10Dmitry Brant) 3NEW p:3Unprio s:3normal a:3None Pages that have an ampersand in the title don't load properly (either from the Search bar or from Intent). e.g. "Simon & Garfunkel", https://en.m.wikipedi... [00:11:21] (03CR) 10Dbrant: [C: 032] Shorten messages in the overflow menu [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/137501 (owner: 10Yuvipanda) [00:12:02] Deskana: can you file a bug? I'll loook into it and if it's an issue with the app I'll get it fixed and do a SWAT deploy at the next available opportunity [00:12:31] YuviPanda: Doesn't seem to be an issue with the app, Dario says. [00:13:10] Deskana: liangent0 mentioned that revision tags are stored differently from recent changes tags, so might be. either way bug is good, we can escalate it to core if necessary [00:15:31] mhurd: https://gerrit.wikimedia.org/r/137504 [00:16:10] Deskana: you have more feedback [00:16:16] YuviPanda: people want the dark theme back [00:17:08] tfinc: :D yeah. it was a terrible hack though, that I built up in a day or so. [00:18:30] Messages for bad username are unhelpful. [00:18:50] ragesoss: what does it say? [00:18:59] YuviPanda: mind if I upload the master apk at the time of the last version bump to alpha? I just want to get the crash fix for lang=de in the store for alpha as well since I already emailed people that it's fixed. There was one alpha OTRS report. [00:19:09] "Could not create account" [00:19:24] I think mine was too long. [00:19:24] bearND: yeah, please do. do bump the version number again, I don't know if Android updates it otherwise [00:19:47] Wanted to see how the menu treats a long username. [00:19:59] YuviPanda: it should, since it's a different app id (package name) [00:20:05] (It wraps it nicely!) [00:20:15] bearND: hmm? to the alpha, it's the same package name [00:20:21] ragesoss: :D we did test for that [00:20:52] What happ [00:21:14] YuviPanda: was the edit pencil inline css previously? [00:21:16] YuviPanda: alpha is org.wikipedia; beta is org.wikipedia.beta [00:21:44] bearND: right but if we are uploading to alpha it has to be org.wikipedia, can't be org.wikipedia.beta [00:21:49] mhurd: yeah, it's always been a data uri. [00:22:10] YuviPanda: this patch would restore that? [00:22:17] mhurd: yeah [00:22:30] YuviPanda: cool. do you want me to merge it? [00:22:38] YuviPanda: Back. [00:22:40] mhurd: no self merging on deployed extensions :) [00:22:41] YuviPanda: yes, that's why i built on master branch [00:22:43] TOC icon should not appear on pages without a TOC. [00:22:47] mhurd: oh, I missed the 'me' [00:22:49] mhurd: yeah, sure [00:22:52] ragesoss: it shouldn't? [00:22:58] ragesoss: are you testing with the alpha or the beta? [00:23:03] I don't think so. [00:23:17] bearND: right, but if we are pushing out the *alpha*, how do we change the package ID? I'm confused. [00:23:32] YuviPanda: done [00:23:40] mhurd: should be on betalabs in about 5-10m [00:24:14] 3Wikipedia App / 3Android App: Aliases of "special" namespace are not considered - 10https://bugzilla.wikimedia.org/66154#c1 (10Yuvi Panda) Which aliases are you talking about? we do take into account different aliases in different languages. [00:24:17] Back! [00:24:21] Yuvipanda: how do I know if alpha or beta? [00:24:32] ragesoss: does the icon of the app have a red or blue star? [00:24:38] ragesoss: also in 'more' -> 'about' has version [00:24:44] Found it. [00:24:45] Deskana: thanks for mailing out! [00:24:47] Alpha [00:25:15] ragesoss: ah, yeah. new alpha that went out had that fixed, but it was out only a couple hours ago [00:25:21] ragesoss: https://play.google.com/store/apps/details?id=org.wikipedia.beta is the beta. [00:26:14] 3Wikipedia App / 3Android App: Colons at the end of page title get ignored - 10https://bugzilla.wikimedia.org/66156#c1 (10Yuvi Panda) Fixes to this and other namespace related parsing bugs involve us maintaining a local list of namespace aliases on all the different wikis and using those when parsing PageTit... [00:26:25] Deskana: do you have access to the google play dev account? [00:26:26] YuviPanda: qq [00:26:34] Deskana: if so you can use that to see the new reviews coming in [00:26:35] vbamba: sure [00:27:02] actually, bearND and dbrant also [00:27:22] in the W menu on Android - You guys plan to remove the Icons and make the styling like IOS? [00:27:31] 3Wikipedia App / 3Android App: It should take me to the browser if I open a special page directly - 10https://bugzilla.wikimedia.org/66157 (10Liangent) 3NEW p:3Unprio s:3normal a:3None Instead of saying "page does not exist". [00:27:55] This is for the list items - History, Bookmarks, Random, More [00:28:03] vbamba: probably not, why? [00:28:29] 3Wikipedia App / 3Android App: Aliases of "special" namespace are not considered - 10https://bugzilla.wikimedia.org/66154#c2 (10Liangent) 5NEW>3RESO/INV What I saw is actually bug 66157. [00:28:30] Just wanting to know what to include from wikifont for the android icon update [00:28:52] vbamba: ah, we should probably keep those icons. Also IIRC the ones we use now are also from the wikifont [00:29:08] YuviPanda: i guess it was me who was confused. i thought versionCode 55 was the latest beta, but now i see it's 57. Looks like the latest version bump hasn't been pushed through gerrit yet [00:29:32] 3Wikipedia App / 3Android App: It should take me to the browser if I open a special page directly - 10https://bugzilla.wikimedia.org/66157#c1 (10Yuvi Panda) What do you mean by 'directly'? Typing in the searchbar and hitting 'go'? [00:29:48] YuviPanda: alpha is still on 54 [00:30:33] bearND: ah, I guess that was because I got pulled away before actually pushing the APK. [00:30:41] bearND: let me fix that, almost have the apk here [00:31:29] 3Wikipedia App / 3Android App: It should take me to the browser if I open a special page directly - 10https://bugzilla.wikimedia.org/66157#c2 (10Liangent) (In reply to Yuvi Panda from comment #1) > What do you mean by 'directly'? Typing in the searchbar and hitting 'go'? Right [00:31:38] YuviPanda: but i guess as long as it's built freshly it shouldn't have the issue with lang=de [00:31:41] YuviPanda: cool [00:31:42] bearND: dbrant can you guys look at the '#' crash and the & problems? [00:32:11] bearND: dbrant they should have trello cards now as well, so feel free to assign themselves to you so there's no work repetition [00:33:55] YuviPanda: dbrant i just transferred the # crash very recently from OTRS to bugzilla (was from ragesoss i think). i'll look at that one myself [00:34:03] bearND: cool [00:34:25] bearND: updated alpha [00:34:57] YuviPanda: guess who’s edit pencils have returned… [00:35:07] YuviPanda: thanks [00:35:07] mhurd: :D [00:35:08] YuviPanda: thanks!!!! [00:35:10] :) [00:35:21] mhurd: yw :) [00:35:29] mhurd: you should also see styling improvements in some infoboxes with that [00:35:38] YuviPanda: cool! [00:36:22] YuviPanda: do you see a weird issue with the en wiki default page’s first link? [00:36:37] YuviPanda: when i tap on it the infobox is wonky [00:36:59] mhurd: aligned to the left? [00:37:29] YuviPanda: wider than the screen i think [00:41:27] (03PS1) 10Yuvipanda: Bounce out special pages to Browser when directly entered [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/137512 (https://bugzilla.wikimedia.org/66157) [00:42:31] 3MobileFrontend / 3stable: Other languages button should not appear when there are nothing in the list - 10https://bugzilla.wikimedia.org/66158 (10Liangent) 3NEW p:3Unprio s:3normal a:3None See https://m.mediawiki.org/wiki/Bugzilla/zh [00:42:59] 3MobileFrontend / 3stable: Other languages button should not appear when nothing is in the list - 10https://bugzilla.wikimedia.org/66158 (10Liangent) [00:43:06] YuviPanda: i just emailed you some quick screen shots [00:44:46] 3MobileFrontend / 3stable: Language menu (of pages) should show variants based on page language instead of site language - 10https://bugzilla.wikimedia.org/66159 (10Liangent) 3NEW p:3Unprio s:3normal a:3None Maybe the same issue as bug 66158. [00:45:28] 3MobileFrontend / 3stable: Language menu (of pages) should show variants based on page language instead of site language - 10https://bugzilla.wikimedia.org/66159#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/2gdmj8Mz [00:45:29] 3MobileFrontend / 3stable: Other languages button should not appear when nothing is in the list - 10https://bugzilla.wikimedia.org/66158#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/b5dU3EwX [00:45:33] mhurd: i just checked the first but looks fine on Android. [00:45:42] mhurd: can you also grab an Android device nearby to check? [00:46:33] (03PS1) 10Yuvipanda: Hide all Wikipedia apps from external link windows [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/137514 [00:47:06] YuviPanda: the fix above [00:47:13] (03PS1) 10Dr0ptp4kt: Ensure MCC/MNC enrichment for sampling only happens on mdot API. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/137515 [00:47:19] liangent0: hmm? [00:47:21] NavigateToTitle is still there [00:47:30] liangent0: I'm an idiot [00:47:35] So I guess when I press back from the browser [00:47:50] It still shows me "page doesn't exist"? [00:48:19] YuviPanda: adam’s putting the latest on his tablet [00:48:20] (03PS2) 10Yuvipanda: Hide all Wikipedia apps from external link windows [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/137514 [00:48:22] (03PS2) 10Yuvipanda: Bounce out special pages to Browser when directly entered [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/137512 (https://bugzilla.wikimedia.org/66157) [00:48:24] liangent0: fixed [00:48:53] mhurd: cool [00:49:03] mhurd: remember tablet styling is going to be different because of width issues [00:49:09] YuviPanda: oh crap [00:49:16] YuviPanda: good point [00:49:35] YuviPanda: i may have to do this tomorrow [00:49:40] mhurd: :) ok! [00:49:54] YuviPanda: did the beach boys article have the grey table smooshed to the right side? [00:50:12] YuviPanda: “Pet sounds” section [00:51:11] mhurd: looks ok, the audio tag is overlapping some content, but other than that is fine [00:51:39] YuviPanda: weird! [00:57:12] search bar is no longer hiding? [00:57:38] liangent0: yeah, I know. Need to convince Deskana that it needs to hide [00:58:05] Convince? [00:58:20] liangent0: the code is there, is just disabled atm. [00:59:17] ragesoss: ^ :) [00:59:38] In honesty I'm not certain why it was removed from Android. [00:59:40] YuviPanda: maybe you can move that global margin-top CSS to the app? [00:59:54] Deskana: ok, putting it back now. [00:59:57] It's a part of app interface. Not about page styling [01:00:02] YuviPanda: Whoa, hold on. [01:00:06] Deskana: :P [01:00:09] YuviPanda: I'd like to know why it was removed first. :) [01:00:22] YuviPanda: Did a designer ask you to remove it? I don't want to overrule a designer on a design issue without talking to them first. [01:00:26] Yes, please! Hidey search bar is great. [01:00:55] Deskana: I'm not fully sure either, but Maryana said it was because they were concerned users won't find the ToC icon otherwise. [01:01:09] Deskana: and would be too lazy and just keep scrolling instead of using ToC [01:01:15] Deskana: this discussion happened on IRC yesterday [01:01:25] So in that case I should chat to Maryana, which coincidentally I am doing tomorrow. :) [01:01:46] Deskana: cool. this is also what I was trying to bring up when this exact functionality is being added to iOS as a separate card. [01:01:49] Hmmm... Hidey bar comes back easily enough for TOC discovery. [01:02:59] (03PS1) 10Yuvipanda: Bring back QuickReturn behavior for search bar [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/137517 [01:03:08] Permanent search bar is a high price to pay for slightly easing the learning curve. [01:03:23] Deskana: ^ I've prepared a patch that brings it back (was super tiny). I'll leave it unmerged for now, but I do feel rather strongly about this. [01:03:39] (03CR) 10Yuvipanda: [C: 04-1] "Await Dan's conversation with Maryana" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/137517 (owner: 10Yuvipanda) [01:03:57] +1 to ragesoss as well [01:03:59] I agree, but I'd say "I feel rather weakly about this" :P [01:04:04] Actually I never use the TOC button or the menu item [01:04:12] i.e. "I agree with Yuvi but I am open to conversation about it" [01:04:19] Swiping the screen is much better [01:04:36] Especially phone are getting bigger and bigger these days [01:04:45] But not easy to discover, liangent0 [01:05:31] How did I discovered it initially? :P [01:05:37] Without reading code [01:05:51] liangent0: it's not easy for everyone to discover, but I think quickreturn is fine. [01:05:56] Not impossible by any means. [01:06:46] Yeah. The icon is a good improvement. [01:07:14] (03CR) 10Dbrant: "One other line of code related to this change that should be removed:" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/137517 (owner: 10Yuvipanda) [01:08:11] (03PS2) 10Yuvipanda: Bring back QuickReturn behavior for search bar [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/137517 [01:08:24] dbrant: what's your opinion on the QuickReturn bar? [01:08:42] bearND: ^ [01:08:50] Was there any talk about changing the sidebar to black? [01:09:35] liangent0: it was pretty much a design decision, I think [01:10:01] YuviPanda: honestly I was on the fence about it. It doesn't bother me at all that it persists... and I like the quick access to Search and the ToC button without the extra swipe motion. [01:11:05] YuviPanda: i like the search bar hiding [01:11:17] dbrant: hmm, ok. the extra motion doesn't bother me, and I like the extra uninterrupted reading space [01:12:58] dbrant: bearND anyway, I opened up an etherpad to make some notes about a potential Saved Pages architecture, learning from my mistakes the last two times :) https://etherpad.wikimedia.org/p/wikipedia-app-saved-pages-architecture am filling it in now [01:13:14] A settings option, maybe? [01:13:36] ragesoss: settings bad. [01:14:15] YuviPanda: this is why we only had the fixed search bar for bigger devices; just think we should've increased the threshold. with 480dp even my nexus 4 is considered big [01:14:18] YuviPanda: why? [01:14:35] Deskana: ugh, I also realized we left out an entire card for Saved Pages, which is what to do when we import them! I remember it was there the previous meeting and was marked as needing refinement, but missing this time? [01:14:43] bearND: hmm, that might be an option too, yeah. [01:16:32] bearND: just enabling it on tablets or something like that makes sense too, I think [01:16:37] liangent0: why for what? 'settings bad'? [01:16:57] YuviPanda: yeah settings bad [01:17:56] YuviPanda: Good point. We ruled out a lot of options but we didn't finalise a solution. [01:18:05] liangent0: 1. defaults are important, so we can't fully kick the can down the road, 2. settings imply a decision point the user should make the app can't make intelligently, which I don't believe is the case here [01:18:17] Deskana: true, and I think that's an important part of the story and also a big chunk of work :'( [01:18:44] (03PS2) 10JGonera: Move notifications drawer to stable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/137481 [01:20:59] Deskana: it doesn't block any other saved pages work, but is something we definitely need to get done for release, I think. [01:21:09] YuviPanda: hm [01:22:06] YuviPanda: Let's chat more tomorrow. I've made a lot of product decisions today and am burnt out for today. :) [01:22:08] Well sometimes I want to complain that options in mobile browsers are too few [01:22:17] Compare to desktop ones [01:22:43] Deskana: :D makes sense! I am also hoping to try the deep fried snickers bars tomorrow! [01:23:26] liangent0: my philosophy tends to be: "configurable = unfinished". [01:23:38] Deskana: today was very productive and useful, thanks for all the support. <3 working with you guys, so yay :) [01:23:57] :/ [01:24:13] What about a guided tour demonstrating TOC swipe? [01:24:26] ragesoss: those are planned in the future, a general onboarding experience [01:24:29] much product [01:24:32] so mobile [01:24:38] wow [01:24:51] To the moon! [01:24:52] Deskana: to the moon? :) [01:24:54] gah! :D [01:24:59] And it's really annoying that an option goes away after some update, and the new default is the other side from I'm used to [01:25:14] :D [01:25:17] Catch you later guys. [01:25:22] liangent0: indeed, and hence the solution is to not have them in the first place :D it is super hard to remove things once they have been put in place [01:25:53] (03CR) 10Yuvipanda: [C: 04-1] Bring back QuickReturn behavior for search bar [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/137517 (owner: 10Yuvipanda) [01:28:45] dbrant: bearND https://etherpad.wikimedia.org/p/wikipedia-app-saved-pages-architecture is fairly complete now. [01:29:31] Saved pages is being brought back? [01:30:03] liangent0: yup [01:32:11] YuviPanda: so someone should revisit bugs/feature requests which got closed for "saved pages has gone"? [01:32:21] liangent0: probably, yeah. [01:32:24] liangent0: I can do that next week [01:35:18] Can haz switch positions of TOC icon and overflow menu? [01:35:52] Seems like icon for right-hand drawer should be right-most icon. [01:37:24] No? "More" button is always right most in apps? [01:37:38] what liangent0 said [01:37:54] ragesoss: the actionbar pattern puts some most used menu items directly on the bar, and that's what we are doing, no? [01:38:02] ragesoss: it used to be in the menu, and is now out of it [01:40:16] Eh. I guess. I've never seen an app with an icon for right-hand drawer. [01:41:03] Would be better if the right side also had a half-hidden hamburger like the left. [02:22:06] (03PS1) 10Yuvipanda: Fix SSL errors killing the app [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/137523 [02:24:29] 3Wikipedia App / 3Generic: [Android] Can't scroll wide tables to the right - 10https://bugzilla.wikimedia.org/64075#c2 (10Yuvi Panda) 5NEW>3RESO/FIX Should be fixed now. [02:25:15] 3Wikipedia App / 3Android App: About page should include build info - 10https://bugzilla.wikimedia.org/36702#c2 (10Yuvi Panda) 5NEW>3RESO/FIX Has version numbers now. [02:25:44] 3Wikipedia App / 3Generic: wikipedia page content is shown and the page is scrolling horizontally - 10https://bugzilla.wikimedia.org/62070#c3 (10Yuvi Panda) 5UNCO>3RESO/FIX Should be fixed now, most of the horizontal scrolling bugs have been fixed. [02:26:43] 3Wikipedia App / 3Generic: App stops responding after being used for a while - 10https://bugzilla.wikimedia.org/64450#c4 (10Yuvi Panda) 5NEW>3RESO/FIX Should be fixed now? Re-open if not. [02:26:58] 3Wikipedia App / 3Generic: "last edited" timestamps in the Android seem too old - 10https://bugzilla.wikimedia.org/63267#c1 (10Yuvi Panda) 5NEW>3RESO/FIX Should be fixed now. [02:27:44] 3Wikipedia App / 3Generic: Left drawer text is running too close to the right edge! - 10https://bugzilla.wikimedia.org/64335#c1 (10Yuvi Panda) 5NEW>3RESO/FIX Should be fixed now. [02:28:44] 3Wikipedia App / 3Generic: Main Page ToC is empty - 10https://bugzilla.wikimedia.org/64693 (10Yuvi Panda) 5NEW>3RESO/FIX [02:29:14] 3Wikipedia App / 3Generic: Tapping an image on commons causes "This page does not exist" - 10https://bugzilla.wikimedia.org/65462#c1 (10Yuvi Panda) 5NEW>3RESO/FIX Fixed now. [02:29:44] 3Wikipedia App / 3Generic: Android: App CSS failed to load after installation - 10https://bugzilla.wikimedia.org/65699#c1 (10Yuvi Panda) 5NEW>3RESO/FIX Should be way more robust now. [02:30:29] 3Wikipedia App / 3Android App: Allow clearing app cache to clear cache for real - 10https://bugzilla.wikimedia.org/65960#c1 (10Yuvi Panda) 5NEW>3RESO/WON The CSS is an internal detail, and shouldn't be cleared by cache, I think. Also complicates the code unnecessarily, and the CSS files don't take up tha... [02:31:14] 3Wikipedia App / 3Generic: Opening many pages in succession breaks rendering - 10https://bugzilla.wikimedia.org/64762#c8 (10Yuvi Panda) 5PATC>3RESO/FIX Should be fixed now. [02:31:28] 3Wikipedia App / 3Generic: The search bar shouldn't be covered by drawers - 10https://bugzilla.wikimedia.org/63812#c4 (10Yuvi Panda) 5PATC>3RESO/FIX Should be fixed now. [02:31:43] 3Wikipedia App / 3Generic: last update date appears as January 1, 1970 - 10https://bugzilla.wikimedia.org/64136#c5 (10Yuvi Panda) 5PATC>3RESO/FIX Should be fixed now. [02:32:14] 3Wikipedia App / 3Generic: java.lang.IllegalStateException: Fragment PageViewFragment{42c490f8} not attached to Activity - 10https://bugzilla.wikimedia.org/64493 (10Yuvi Panda) 5PATC>3RESO/FIX [02:32:29] 3Wikipedia App / 3Generic: Android: When overflow menu is disabled due to network error, it stays disabled even on articles it should be usable on - 10https://bugzilla.wikimedia.org/64774 (10Yuvi Panda) 5PATC>3RESO/FIX [02:32:44] 3Wikipedia App / 3Android App: History search only matches beginning of article titles - 10https://bugzilla.wikimedia.org/65930 (10Yuvi Panda) 5PATC>3RESO/FIX [02:32:46] that should be it for now, I'd think [02:33:08] liangent0: I found the most likely cause of the SSL crashes you were reporting, there's a patch in progress [02:34:56] am off now [03:17:44] (03PS1) 10BearND: searching only for # or : caused crashes [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/137527 (https://bugzilla.wikimedia.org/66151) [03:44:14] 3MobileFrontend / 3stable: Mobile view link unexpectedly goes to HTTPS - 10https://bugzilla.wikimedia.org/61358 (10Florian) 5PATC>3RESO/FIX [05:23:58] (03CR) 10Florianschmidtwelzow: [C: 031] Don't show photo upload icon when no action is possible [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/137462 (owner: 10Jdlrobson) [05:25:42] (03CR) 10Florianschmidtwelzow: [C: 031] Only show upload icon to autoconfirmed users. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/137461 (owner: 10Jdlrobson) [05:54:49] (03CR) 10Mhurd: "What are the bottom menu changes?" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/137515 (owner: 10Dr0ptp4kt) [05:54:59] 3MobileFrontend / 3stable: Filter for New User uploads in Mobile Web - 10https://bugzilla.wikimedia.org/62598#c41 (10Lupo) (In reply to Jon from comment #40) > See https://gerrit.wikimedia.org/r/137462 That is about not displaying the upload button in some other cases. The change about disabling this for no... [06:03:45] (03CR) 10Lupo: "Does this have to be done in JavaScript?" (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/137462 (owner: 10Jdlrobson) [06:28:40] (03CR) 10Florianschmidtwelzow: Don't show photo upload icon when no action is possible (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/137462 (owner: 10Jdlrobson) [06:39:59] 3MobileFrontend / 3stable: Other languages button should not appear when nothing is in the list - 10https://bugzilla.wikimedia.org/66158#c2 (10Florian) 5NEW>3UNCO Hmm, why there the button is visible i don't know, but in actual git version, the language button appears only, if languages are available: ht... [07:21:47] 3MobileFrontend / 3stable: Do not show "Contribute an Image", if wgEnableUploads = false - 10https://bugzilla.wikimedia.org/66164 (10Florian) 3NEW p:3Unprio s:3normal a:3None On Special:Uploads the "Contribute an Image" button is shown every time, but has to be invisble if $wgEnableUploads is false,... [07:22:30] 3MobileFrontend / 3stable: Do not show "Contribute an Image", if wgEnableUploads = false - 10https://bugzilla.wikimedia.org/66164 (10Florian) 5NEW>3ASSI p:5Unprio>3Normal a:3Florian [07:26:59] 3MobileFrontend / 3stable: Do not show "Contribute an Image", if wgEnableUploads = false - 10https://bugzilla.wikimedia.org/66164#c1 (10Max Semenik) Note that this functionality should still work if local uploads are disabled but there's a shared repository configured. [07:29:28] 3MobileFrontend / 3stable: Do not show "Contribute an Image", if wgEnableUploads = false - 10https://bugzilla.wikimedia.org/66164#c2 (10Florian) You're right, thx :) [08:20:01] (03PS1) 10Florianschmidtwelzow: Respect Upload Settings when show upload buttons [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/137541 (https://bugzilla.wikimedia.org/66164) [08:32:31] 3MobileFrontend / 3Feature requests: Make images clickable on image description pages - 10https://bugzilla.wikimedia.org/48996#c5 (10Florian) 5PATC>3ASSI a:3Florian I agree with Jon (in his comment on gerrit: Ideally this change should be done in core and in the HTML. I'd rather we didn't introduce suc... [08:33:07] (03Abandoned) 10Florianschmidtwelzow: Remove clickable link around image instead of abort click event [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/135288 (https://bugzilla.wikimedia.org/48996) (owner: 10Florianschmidtwelzow) [08:42:46] 3MobileFrontend / 3stable: Mobile/Web media uploads: generated file name contains timestamp in local time; should be UTC - 10https://bugzilla.wikimedia.org/66169 (10Lupo) 3NEW p:3Unprio s:3normal a:3None The timestamp at the end of generated file names for mobile uploads should be in UTC, not in the... [08:45:29] 3MobileFrontend / 3stable: Mobile/Web media uploads: generated file name contains timestamp in local time; should be UTC - 10https://bugzilla.wikimedia.org/66169#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/fBy3OF59 [12:06:46] 3Wikipedia App / 3Android App: Tapping a link in preview discards edit silently - 10https://bugzilla.wikimedia.org/66186 (10Liangent) 3NEW p:3Unprio s:3normal a:3None and I can't go back to the editing interface by tapping back. [12:08:44] 3Wikipedia App / 3Android App: Tapping a link in preview discards edit silently - 10https://bugzilla.wikimedia.org/66186#c1 (10Liangent) I tried to use this feature to reproduce bug 64450 by the way. It was significantly easier to trigger that one by navigating from preview. [12:10:15] 3MobileFrontend / 3stable: Other languages button should not appear on https://m.mediawiki.org/wik i/Bugzilla/zh - 10https://bugzilla.wikimedia.org/66158#c3 (10Liangent) 5UNCO>3NEW I know the general case, but I'm trying to report the bug about that particular page. [12:22:01] 3Wikipedia App / 3Android App: Weird "Â" appears on pages in the app - 10https://bugzilla.wikimedia.org/66187 (10Liangent) 3NEW p:3Unprio s:3normal a:3None Created attachment 15569 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15569&action=edit Screenshot See attachment. This is [[zh:威斯敏斯特宫... [12:23:25] YuviPanda: can you verify this https://bugzilla.wikimedia.org/66187 ? [12:23:36] it might be related to how my phone is configured [12:23:50] liangent: yeah, moment [12:23:55] liangent: is this on the alpha or the beta? [12:24:23] YuviPanda: alpha [12:25:50] liangent: nope, for me too [12:26:37] liangent: not on mobile web either [12:27:18] YuviPanda: hm? you mean you don't see "Â" there? [12:27:31] liangent: no, I *do* see the A on the app and not on mobile web [12:27:42] YuviPanda: fine [12:32:44] 3Wikipedia App / 3Android App: Allow clearing app cache to clear cache for real - 10https://bugzilla.wikimedia.org/65960#c2 (10Liangent) (In reply to Yuvi Panda from comment #1) > The CSS is an internal detail, and shouldn't be cleared by cache, I think. > Also complicates the code unnecessarily, and the CSS... [12:34:18] ^ wikibugs lags for half an hour? [12:35:42] liangent: might be toollabs mail server acting up again [12:36:42] hmm, it seems fine [12:41:06] (03PS1) 10Yuvipanda: Always show current app's About page [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/137559 [12:41:46] YuviPanda: where's the code adding 'mobile app edit' tag? [12:42:34] liangent: Extension:MobileApp [12:42:44] liangent: mediawiki/extensions/MobileApp, MobileAppHooks.php [12:49:00] (03PS1) 10Yuvipanda: Allow moving app to external storage [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/137561 [13:01:44] (03CR) 10Yuvipanda: [C: 032] searching only for # or : caused crashes [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/137527 (https://bugzilla.wikimedia.org/66151) (owner: 10BearND) [13:02:03] (03Merged) 10jenkins-bot: searching only for # or : caused crashes [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/137527 (https://bugzilla.wikimedia.org/66151) (owner: 10BearND) [13:03:06] YuviPanda: https://gerrit.wikimedia.org/r/137563 [13:03:18] maybe the cause of that missing tag [13:03:30] is MobileApp or MobileFrontend loaded earlier? [13:04:18] hm MobileApp. so I think that patch can explain the bug [13:04:37] liangent: MobileApp I think. [13:10:44] 3Wikipedia App / 3Android App: Weird "Â" appears on pages in the app - 10https://bugzilla.wikimedia.org/66187#c1 (10Brion Vibber) Encoding issue loading the CSS, probably? There's ":after" content on the hlist items: on zh.m.wikipedia.org: #content .hlist dd:after, #content .hlist li:after { content: "... [13:20:39] (03CR) 10Dbrant: [C: 04-1] "I can't reproduce this, and I don't see why it would actually happen. Special pages will always get bounced to external browser when they" (031 comment) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/137512 (https://bugzilla.wikimedia.org/66157) (owner: 10Yuvipanda) [13:27:42] * YuviPanda waves at dbrant [13:27:52] YuviPanda: hey! [13:28:19] dbrant: hmm, if I typed Special:Tags in the search bar and pressed 'go' on the keyboard (rathe than hit the search result) I do get a page not found message [13:29:11] YuviPanda: that's not what I see [13:29:36] dbrant: that's weird, I was able to repro it with the beta release as well [13:29:37] let me try now [13:30:16] dbrant: hmm, I can't repro it with beta now. I am confused [13:30:21] liangent: ^ can you still repro this behavior? [13:30:30] dbrant: anyway, that's not as important as the other crash fixes [13:30:42] YuviPanda: but they'r edependent [13:30:50] dbrant: let me move that ut [13:31:10] YuviPanda: I can. in 2.0-alpha-2014-06-03 [13:31:16] (03PS2) 10Yuvipanda: Fix SSL errors killing the app [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/137523 [13:31:18] (03PS2) 10Yuvipanda: Always show current app's About page [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/137559 [13:31:20] (03PS3) 10Yuvipanda: Hide all Wikipedia apps from external link windows [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/137514 [13:31:21] dbrant: undependented [13:31:22] (03PS2) 10Yuvipanda: Allow moving app to external storage [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/137561 [13:32:21] YuviPanda: could it have been a 'funky' build that didn't have the SpecialAliasData generated properly? (sort of like the language xml strings?) [13:32:42] dbrant: shouldn't be, since that is a Java generated class and not XML [13:33:01] liangent: try the beta? (which should be beta2) or the alph-2014-06-04? [13:34:59] (03CR) 10Dbrant: [C: 032] Hide all Wikipedia apps from external link windows [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/137514 (owner: 10Yuvipanda) [13:35:01] (03CR) 10Florianschmidtwelzow: [C: 031] "Do you think that we need to do anything with the watchstar after the user tapped on it, or schould we leave it as it is? :)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/137233 (https://bugzilla.wikimedia.org/65599) (owner: 10Jdlrobson) [13:35:17] (03Merged) 10jenkins-bot: Hide all Wikipedia apps from external link windows [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/137514 (owner: 10Yuvipanda) [13:36:34] dbrant: for the SSL stuff, I don't have a reproducible case, but that seemed the most likely culprit [13:36:57] YuviPanda: yep, I would think. [13:38:15] (03CR) 10Dbrant: [C: 032] Fix SSL errors killing the app [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/137523 (owner: 10Yuvipanda) [13:38:35] (03Merged) 10jenkins-bot: Fix SSL errors killing the app [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/137523 (owner: 10Yuvipanda) [13:39:22] is it just me or is the ToC icon really blurry on the beta? [13:39:30] brion: it is blurry, vibha is on it [13:39:35] ok :D [13:40:28] brion: also https://gerrit.wikimedia.org/r/#/c/137563/1 is a core change for our tags. liangent graciosuly submitted the patch [13:40:32] looking awesome in general :D [13:40:38] woo [13:41:00] brion: tomorrow (or whenever our rcstream setup goes live) I'll write a small tool that beeps every time someone makes an edit :) [13:42:05] hehe [13:43:28] (03CR) 10Dbrant: [C: 032] Always show current app's About page [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/137559 (owner: 10Yuvipanda) [13:44:54] (03CR) 10Dbrant: [C: 032] Allow moving app to external storage [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/137561 (owner: 10Yuvipanda) [13:45:14] (03Merged) 10jenkins-bot: Allow moving app to external storage [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/137561 (owner: 10Yuvipanda) [13:48:53] YuviPanda: beta is even newer than alpha? [13:49:11] liangent: beta2 is same as 2.0-alpha-2014-06-04, while you had -03 [13:51:24] YuviPanda: "Complete action using // About / Wikipedia // About / Wikipedia Beta" [13:51:28] what's this? [13:51:57] (03PS1) 10Yuvipanda: Don't crash if we can't find a language code [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/137577 [13:51:59] liangent: yeah, that got fixed [13:53:19] in beta 2, 66157 is fixed for the primary special namespace name, but is still there when special namespace aliases are used [13:54:02] dbrant: ^ [13:54:06] YuviPanda: and after it happens for aliases, it stops working for primary names too [13:54:29] YuviPanda: meh no [13:54:51] YuviPanda: "Special:BlankPage" is recognized, but even "special:BlankPage" is not [13:54:58] ah, hmm [13:55:16] isSpecial will fail on that too [13:55:35] yep... [13:55:59] 3Wikipedia App / 3Android App: WikiCode de + not found+ - 10https://bugzilla.wikimedia.org/66140#c2 (10Yuvi Panda) This has been happening for some non de users as well, with weird language codes that we don't have. Updated code to not crash. We need to instrument this to figure out which language codes thos... [13:56:03] (03PS2) 10Yuvipanda: Don't crash if we can't find a language code [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/137577 (https://bugzilla.wikimedia.org/66140) [13:56:12] actually ... it doesn't make a difference between alpha-03 and beta2 [13:56:38] just because I tried "special" in alpha but "Special" in beta for the first time [13:57:34] (03CR) 10Dbrant: [C: 032] Don't crash if we can't find a language code [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/137577 (https://bugzilla.wikimedia.org/66140) (owner: 10Yuvipanda) [14:00:18] * YuviPanda waves at bearND [14:00:38] dbrant: bearND I've been monitoring the play store reviews too. so far so good. [14:00:50] YuviPanda: me too! [14:00:52] YuviPanda: cool [14:01:10] dbrant: only major gripe (other than those asking for more customizations) seem to be the ones asking for the dark theme back [14:01:18] I had even forgotten that I added that feature to the old app [14:01:21] it was a rather ugly theme [14:01:47] lol yes, some OTRS requests for that, as well. [14:01:48] YuviPanda: was it a different css style? [14:01:51] yeah :D [14:01:53] bearND: yeah [14:02:21] it was fairly ugly because we still didn't do much with inline styles, so if there's a color: somewhere in a style= that fucked everything up [14:02:48] dbrant: I also went back and responded to all the people who had a non 5-star rating for the old beta going back to a full year :) [14:04:56] YuviPanda: lol very nice [14:05:01] 3Wikipedia App / 3Android App: The app shouldn't catch URLs of special pages - 10https://bugzilla.wikimedia.org/66188 (10Liangent) 3NEW p:3Unprio s:3normal a:3None If I open a special page in alpha, it asks me to choose a browser but beta is in it. [14:05:59] 3Wikipedia App / 3Android App: The app shouldn't catch URLs of special pages - 10https://bugzilla.wikimedia.org/66188#c1 (10Yuvi Panda) 5NEW>3RESO/FIX fixed in I047af3933eda0f10d869ebc7d89745c4c4d95b8b [14:07:51] YuviPanda: I would think the correct solution for the Special page issue(s) should be at the API level? [14:07:58] dbrant: how so? [14:08:25] YuviPanda: packageName.equals("org.wikipedia") || packageName.startsWith("org.wikipedia."), maybe? [14:08:28] dbrant: we shouldn't have to do a network request to determine that, I think [14:08:40] liangent: why so? the curreent one catches both [14:08:46] YuviPanda: well it's the API that sends a response saying "this page doesn't exist" [14:08:48] if some innocent org.wikipedia_something ever exists [14:08:49] liangent: and we can always re-visit. [14:09:13] YuviPanda: couldn't the API say, "this page is in the Special namespace"? [14:09:55] dbrant: the API should say that too, yeah. But we should really not need a network request for this [14:10:04] dbrant: we need to build in proper namespace parsing into the app. [14:10:24] dbrant: since that will also solve problems with pages like "Mortal Kombat 4: Redemption" (just made that up) [14:11:21] liangent: honestly, I'd rather just find the browsers alone and bounce out to them. Most apps can't handle special pages either [14:11:44] YuviPanda: well I have four browsers installed [14:11:52] firefox / firefox beta / chrome / chrome beta [14:11:58] hmm and plus opera mini [14:12:04] liangent: indeed, so there's no way to 'find just the browsers' [14:13:39] bearND: dbrant are either of you working on the & issue? [14:14:32] I can take it if no one else will [14:14:46] YuviPanda: btw firefox beta and firefox are listed together in "Data usage" .. [14:14:56] how is this achieved and what's its benefit? [14:15:01] dbrant: YuviPanda i can take a it [14:15:05] and should we use that for our beta? [14:15:41] bearND: cool [14:21:08] (03CR) 10BearND: "On second thought. We should default to "de". :)" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/137577 (https://bugzilla.wikimedia.org/66140) (owner: 10Yuvipanda) [14:21:20] bearND: :D [14:21:52] couldn't resist [14:22:13] ha! [14:22:15] :D [14:22:37] I'm rebasing the beta patch now [14:23:04] dbrant: can you look at the preview bug liangent reported? [14:23:11] liangent: was that with or without keep activities turned on? [14:23:20] YuviPanda: yes indeed. [14:24:04] YuviPanda: I myself saw some actions where the edit is discarded unwittingly. [14:24:13] YuviPanda: with *Don't* keep activities turned off [14:24:45] liangent: ok [14:24:51] dbrant: yeah, we should get those all fixed [14:26:44] 3Wikipedia App / 3Android App: ToC menu item is still usable - 10https://bugzilla.wikimedia.org/65962#c4 (10Yuvi Panda) 5NEW>3RESO/FIX Hides now when there's no ToC [14:28:44] 3Wikipedia App / 3Android App: Some content in preview gets covered by "By saving, you agree to..." - 10https://bugzilla.wikimedia.org/66160#c1 (10Yuvi Panda) This should go away with a preview screen simplification / redesign happening next week. [14:31:34] (03PS1) 10Dbrant: Hide keyboard when leaving History selection. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/137644 [14:34:02] (03PS10) 10Yuvipanda: Move everything to beta package [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/137311 [14:40:40] Hi, is there any timeline for the new Wikimedia Android App? Do you already have a release date in mind? [14:41:31] pajz: heya! the beta went out yesterday [14:41:44] pajz: the full release is expected on 25th June [14:42:54] YuviPanda, ah cool, have a link? Couldn't find anything on https://www.mediawiki.org/wiki/Wikimedia_Apps. [14:42:59] pajz: https://play.google.com/store/apps/details?id=org.wikipedia.beta [14:44:15] Thanks. Do you know the status of the iPhone app? [14:44:46] 3Wikipedia App / 3Android App: Open in app does not work if App is already open - 10https://bugzilla.wikimedia.org/66194 (10Yuvi Panda) 3NEW p:3Unprio s:3normal a:3None Steps to repro: 1. Open app, be reading something 2. Go to google, search for something 3. Click on wikipedia link Expected: Link... [14:44:53] pajz: still in active development, but I don't have a timeline. not for t he next month or so at least [14:45:07] k [14:45:29] bearND: dbrant just a reminder that we can get support / help for OTRS at #wikimedia-otrs. pajz and RD are the ones who help out a lot :D [14:46:08] pajz: much appreciated [14:46:34] dbrant: https://bugzilla.wikimedia.org/show_bug.cgi?id=66194 is also a major issue, I think. [14:46:59] Sure, just let us know if you need new response templates / new accounts created / whatever. [14:47:19] YuviPanda: I think my fix for Preview behavior will fix this, as well. [14:47:31] YuviPanda: the activity no longer needs to be singleTask. [14:47:33] dbrant: ah cool. [14:48:30] 3MobileFrontend / 3Feature requests: no path to Special:SpecialPages - 10https://bugzilla.wikimedia.org/63419#c7 (10carchaias) From the users view please consider that all pages within the Mediawiki:Sidebar are not accessible easy to the user who is familiar with the PC-Browser interface. Most of them don't... [14:52:01] (03PS1) 10Dbrant: Fix discarding of edit contents when clicking links in Preview. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/137654 (https://bugzilla.wikimedia.org/66186) [14:52:31] YuviPanda: ^ 2 lines of code! [14:52:59] 3MobileFrontend / 3stable: Nearby broken on commons - 10https://bugzilla.wikimedia.org/65888 (10Florian) [14:52:59] 3MobileFrontend / 3Feature requests: Allow configuration of the mobilefrontend menu - 10https://bugzilla.wikimedia.org/63459 (10Florian) [14:53:06] dbrant: looking [14:56:52] pajz: Thanks. Could we have a reply template that says something like "This issue is now tracked at . Thank you for reporting this." Not sure what the next state of the ticket should be. [14:59:32] bearND, the default next state is always "closed successful." if you want to select a different state you need to adjust that manually before hitting "send." [15:00:06] But since tickets get reopened as soon as a follow-up is received, the default is usually a good choice. [15:00:38] pajz: i see [15:00:52] bearND, what should the name of the template be? [15:02:05] pajz: How about en-mobile-Moved to Bug Tracker [15:04:47] bearND, ok, added. [15:06:18] pajz: Thank you! [15:07:25] (03CR) 10Yuvipanda: [C: 032] Fix discarding of edit contents when clicking links in Preview. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/137654 (https://bugzilla.wikimedia.org/66186) (owner: 10Dbrant) [15:07:45] (03Merged) 10jenkins-bot: Fix discarding of edit contents when clicking links in Preview. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/137654 (https://bugzilla.wikimedia.org/66186) (owner: 10Dbrant) [15:27:13] (03PS2) 10Yuvipanda: Hide keyboard when leaving History selection. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/137644 (owner: 10Dbrant) [15:29:05] dbrant: I'm going to do alpha and beta releases after merging ^ [15:29:22] YuviPanda: great! [15:29:34] dbrant: and then I'm going to step out for some foody things. [15:29:52] dbrant: bearND any objections to http://etherpad.wikimedia.org/wikipedia-app-saved-pages-architecture [15:31:32] YuviPanda: bearND: seems reasonable to me. [15:33:48] (03CR) 10Yuvipanda: [C: 032] Hide keyboard when leaving History selection. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/137644 (owner: 10Dbrant) [15:34:04] YuviPanda: one more trivial patch...? [15:34:09] dbrant: sure [15:34:10] (03Merged) 10jenkins-bot: Hide keyboard when leaving History selection. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/137644 (owner: 10Dbrant) [15:36:10] (03PS1) 10Dbrant: Fix clickability of About actionbar text. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/137675 [15:36:36] dbrant: what does this fix? [15:37:00] YuviPanda: in the About activity, the "About" title text was not clickable (to go back). [15:37:20] dbrant: oh, because it was a textview and we were setting linkmethod on it? [15:37:21] wow ;D [15:37:25] dbrant: can you add a line of documentation?} [15:37:34] YuviPanda: sure [15:38:01] * ragesoss still hopes the article title in the TOC will soon act as a link back to the top of the article. [15:38:23] YuviPanda: what's the reasoning for using internal storage? just curious. +1 for storing the revision id. [15:38:26] ragesoss: yeah, that's a bug that needs fixing too. [15:38:39] bearND: I put a question mark there because I was unsure [15:38:52] bearND: I don't really see positives/negatives, but it will be more secure against random snooping [15:38:57] how many people has the beta reached now? [15:40:19] ragesoss: very little, actually. also we don't have live data, only data that's 2 days old. so I'll have to wait another day or so before I can get accurate stats [15:40:27] ragesoss: but the current beta is with 40,000 people \o/ [15:40:32] ragesoss: so theoretically all of them should get it [15:40:35] nice. [15:40:44] that's a pretty solid beta group! [15:40:51] ragesoss: yeah! :D [15:41:16] (03PS2) 10Yuvipanda: Fix clickability of About actionbar text. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/137675 (owner: 10Dbrant) [15:41:22] (03PS1) 10Zfilipin: QA: Updated Ruby gems [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/137679 [15:42:02] (03CR) 10Cmcmahon: [C: 032] QA: Updated Ruby gems [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/137679 (owner: 10Zfilipin) [15:42:11] (03CR) 10Yuvipanda: [C: 032] Fix clickability of About actionbar text. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/137675 (owner: 10Dbrant) [15:42:20] dbrant: cool! making a release now. [15:42:31] (03Merged) 10jenkins-bot: Fix clickability of About actionbar text. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/137675 (owner: 10Dbrant) [15:42:37] (03Merged) 10jenkins-bot: QA: Updated Ruby gems [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/137679 (owner: 10Zfilipin) [15:45:42] (03PS1) 10Yuvipanda: Bump version number for 2.0-alpha-2014-06-05 [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/137683 [15:45:54] dbrant: ^ merge? [15:46:10] (03CR) 10Dbrant: [C: 032] Bump version number for 2.0-alpha-2014-06-05 [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/137683 (owner: 10Yuvipanda) [15:46:40] (03Merged) 10jenkins-bot: Bump version number for 2.0-alpha-2014-06-05 [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/137683 (owner: 10Yuvipanda) [15:48:52] dbrant: updated alpha. now updating beta [15:49:12] (03PS1) 10Dbrant: [WIP - test only] Implement syntax highlighting in Edit window. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/137684 [15:49:28] YuviPanda: bearND: in case you want to play around with it ^ [15:49:37] coool! :) [15:50:06] dbrant: nice! i like this idea very much :) [15:50:28] (03PS11) 10Yuvipanda: Move everything to beta package [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/137311 [15:50:48] dbrant: bearND we should make another release later in the day with the '&' fix [15:51:43] YuviPanda: agreed. also have you looked at https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom&TicketID=7589076? it would be great to get a fix for this as well. [15:53:11] bearND: I think that would be fixed too in one of the patches (I added an onCatch to second API request Section Fetcher thing) [15:55:25] bearND: dbrant beta published [15:55:34] \o/ [15:56:14] YuviPanda: :) [15:56:24] bearND: dbrant I'm going to head off now, will be back in a few hours. Do take a look at OTRS as well! Most of the issues reported were fixed, IIRC [15:58:33] * YuviPanda waves off for a bit [16:21:57] (03PS1) 10Florianschmidtwelzow: Remove clickable link around image on file page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/137692 (https://bugzilla.wikimedia.org/48996) [16:22:54] (03PS2) 10Florianschmidtwelzow: WIP/POC: Remove clickable link around image on file page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/137692 (https://bugzilla.wikimedia.org/48996) [16:24:59] 3MobileFrontend / 3Feature requests: Make images clickable on image description pages - 10https://bugzilla.wikimedia.org/48996#c9 (10Florian) Created attachment 15570 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15570&action=edit Result of gerrit patches Magnifying glass is clickable and points to... [16:49:05] (03CR) 10Dr0ptp4kt: "LOL, I have no idea where that came from! I'll remove that." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/137515 (owner: 10Dr0ptp4kt) [16:50:17] (03PS2) 10Dr0ptp4kt: Ensure MCC/MNC enrichment for sampling only happens on mdot API. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/137515 [17:01:19] Deskana|Away: looking over the reviews you have some good people to follow up with. the dark theme is being mentioned by a significant amount of them so lets get it on the backlog [17:18:14] dr0ptp4kt: autocorrect thinks when i type svg i mean “sag”. i do not. [17:22:53] jdlrobson, jgonera, Flow sent me, do you guys use hash changes for anything on the frontend? [17:28:16] jgonera, do you need anything for your demo? changing computers during the meeting is always a bit of a hassle. let me know if that's needed. [17:30:44] Eloquence I should be fine if the laptop has Chrome and is connected to the same network as my laptop [17:31:28] marktraceur what hash changes? [17:31:34] Maryana: moizsyed kaity|away we're in r37 [17:32:01] jgonera: Hash fragments. Mediaviewer does stuff like #mediaviewer/File:Foobar.jpg to support back button and direct linking to the viewer [17:32:41] marktraceur yes, we use it extensively for all overlays [17:32:50] OK [17:32:55] jgonera: Do you use a library for it? [17:33:18] We built a small wrapper around it [17:33:56] We could come up with an API that would be more useful for other projects [17:34:09] Or you're suggesting a library to use? [17:35:33] (03PS3) 10Dr0ptp4kt: Ensure MCC/MNC enrichment for sampling only happens on mdot API. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/137515 [17:41:45] (03PS1) 10Dr0ptp4kt: Enrich API object with MCC/MNC only on .m.wikipedia.org. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/137711 [17:42:35] jgonera: We're thinking of using something called Hasher (not Hashar) - https://github.com/millermedeiros/Hasher [17:42:43] Pretty smallish, not based on jquery [17:43:07] jgonera, I'll be on the wired network. [17:45:04] bearND, mind reviewing and, if appropriate, +2 publish-submitting https://gerrit.wikimedia.org/r/137711 ? the extra guard seemingly doesn't matter now, but i want it there just in case. i had noticed on ios, where this stuff is buried even deeper in the request introspection, that the initial connection was being made to bits, where the header would never be picked up! on android, by definition afaik for the moment, the app only hits mob [17:45:04] wikipedia servers for api calls, but a little defense can go a long way, i suppose. [17:47:09] dr0ptp4kt: looking at it [17:48:00] dr0ptp4kt: i thought we always go through m sites [17:48:13] dr0ptp4kt: when are we not? [17:49:29] bearND: yeah, we do. i'm adding the code to guard against a future state where we would potentially hit some non-wikipedia mdot subdomain api (e.g., imagine commons.m.wikimedia.org or something like that) [17:49:59] bearND, we don't have the api hook installed on commons.m.wikiMedia.org [17:50:13] dr0ptp4kt: makes sense. good point [17:52:09] (03CR) 10BearND: [C: 032] Enrich API object with MCC/MNC only on .m.wikipedia.org. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/137711 (owner: 10Dr0ptp4kt) [17:52:23] bearND: thx [17:52:44] dr0ptp4kt: yw [17:53:02] (03Merged) 10jenkins-bot: Enrich API object with MCC/MNC only on .m.wikipedia.org. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/137711 (owner: 10Dr0ptp4kt) [17:54:00] 3MobileFrontend / 3alpha: Last modified breaks on back button when lazy loading pages - 10https://bugzilla.wikimedia.org/65633#c3 (10Jon) I think this is caused by the same bug as bug 65631 [17:58:43] Eloquence can wired network see ips from WiFi? [18:04:26] 2014-06-05 - 10:42:35 jgonera: We're thinking of using something called Hasher (not Hashar) - https://github.com/millermedeiros/Hasher [18:04:29] 2014-06-05 - 10:42:43 Pretty smallish, not based on jquery [18:04:32] jdlrobson: ^^ [18:05:29] 3MobileFrontend / 3alpha: Last modified breaks on back button when lazy loading pages - 10https://bugzilla.wikimedia.org/65633#c4 (10Florian) Hmm, chrome gives no error, but possible. [18:17:24] (03PS1) 10Dbrant: Make clicking ToC header go to top of page. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/137725 (https://bugzilla.wikimedia.org/64890) [18:21:56] (03PS1) 10Kaldari: Allow text-alignment for thumbnail captions to be inherited [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/137726 (https://bugzilla.wikimedia.org/66103) [18:23:44] (03CR) 10Brion VIBBER: [C: 032 V: 032] "looks good" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/137515 (owner: 10Dr0ptp4kt) [18:33:45] (03PS1) 10Dbrant: Fix possible crash relating to ToC (based on OTRS tickets) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/137728 [18:35:13] (03Abandoned) 10Jdlrobson: Show a spinner when switching between editors [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/137251 (https://bugzilla.wikimedia.org/65506) (owner: 10Jdlrobson) [18:35:21] (03Abandoned) 10Jdlrobson: WIP: have a standard way of invoking loader [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/136249 (owner: 10Jdlrobson) [18:35:30] 3MobileFrontend / 3stable: Nearby broken on commons - 10https://bugzilla.wikimedia.org/65888#c4 (10Max Semenik) 5REOP>3RESO/FIX Works now. [18:40:34] (03PS1) 10Jdlrobson: Show loader when switching between editors [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/137731 (https://bugzilla.wikimedia.org/65506) [18:45:38] (03PS1) 10Dbrant: Only add successfully-loaded pages to History. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/137732 (https://bugzilla.wikimedia.org/65618) [18:46:40] YuviPanda|zzzz: bearND: a few fixes in the queue (when you have a chance)! [18:47:09] dbrant: https://gerrit.wikimedia.org/r/#/c/137732/1 ? [18:47:35] dbrant: stack refers to android activity stack in the bug [18:48:48] liangent: ah I see! I'll amend the commit message, since it still fixes an(other) issue. [18:51:09] (03PS2) 10Dbrant: Only add successfully-loaded pages to History. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/137732 [18:51:50] (03PS1) 10Jdlrobson: Emit ready event after delay to support chaining [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/137734 (https://bugzilla.wikimedia.org/65633) [18:52:23] (03CR) 10Florianschmidtwelzow: [C: 031] Show loader when switching between editors [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/137731 (https://bugzilla.wikimedia.org/65506) (owner: 10Jdlrobson) [18:52:59] 3Wikipedia App / 3Generic: Do not push an empty page into the stack when a link to some special page is tapped in preview - 10https://bugzilla.wikimedia.org/65618#c2 (10Liangent) 5PATC>3NEW Unrelated fix above. Stack refers to Android activity stack in summary. [18:53:20] liangent: thx [18:54:14] 3MobileFrontend / 3alpha: Ajax page loading - Uncaught TypeError: Cannot read property 'indexOf' of undefined - 10https://bugzilla.wikimedia.org/65631#c3 (10Jon) To replicate: In alpha: Go to California page Search for San Francisco and select it. Observe error. [19:03:02] (03PS1) 10Jdlrobson: Ensure edit protection is declared when only move permissions exist on page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/137735 (https://bugzilla.wikimedia.org/65631) [19:12:29] 3MobileFrontend / 3alpha: Middle click in alpha loads page in the same tab - 10https://bugzilla.wikimedia.org/62517#c2 (10Jon) In theory you should be able to do this with if ( ev.button === 0 ) { ev.preventDefault(); // hijack link } This doesn't seem to work with a Mac trackpad though :-/ [19:13:19] dbrant: is there any known way to crash the app now? [19:13:25] I want to have a look at the crash dialog [19:13:43] liangent: I hope not! [19:14:12] liangent: but if anyone can find a way, it's surely you! [19:14:39] liangent: you could still do the random, switch to a different app and come back quickly [19:16:09] bearND: yeah ok I got it [19:16:15] wheee! lunch then back to poking that cr [19:18:50] brion: thanks for the review [19:20:31] 3Wikipedia App / 3Android App: Indicate that the user is expected to send an Email in crash dialog somehow - 10https://bugzilla.wikimedia.org/66208 (10Liangent) 3NEW p:3Unprio s:3normal a:3None User is presented with a bunch of selection and if I accidentally choose something like "Keep", I won't kno... [19:22:06] (03PS1) 10Florianschmidtwelzow: Update doc for files in includes/ [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/137739 (https://bugzilla.wikimedia.org/66086) [19:22:44] 3MobileFrontend / 3Hygiene: make phpdoc shows errors in our PHP documentation - 10https://bugzilla.wikimedia.org/66086 (10Florian) 5PATC>3ASSI [19:22:47] 3Wikipedia App / 3Extension:MobileApp: Do not break words in middle - 10https://bugzilla.wikimedia.org/66209 (10Liangent) 3NEW p:3Unprio s:3normal a:3None Or at least hyphenate them correctly, though this may cause confusion about the real title. [19:23:14] 3Wikipedia App / 3Extension:MobileApp: Do not break words in middle - 10https://bugzilla.wikimedia.org/66209#c1 (10Liangent) Created attachment 15575 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15575&action=edit Broken word in TOC [19:24:44] 3Wikipedia App / 3Android App: Do not break words in middle - 10https://bugzilla.wikimedia.org/66209 (10Liangent) [19:27:07] * YuviPanda waves at dbrant and bearND [19:27:26] YuviPanda: 'sup [19:27:31] Hi YuviPanda [19:27:33] dbrant: looking at patches now [19:33:01] (03Abandoned) 10Yuvipanda: Hide keyboard when you scroll search results [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/108078 (owner: 10Yuvipanda) [19:39:53] (03PS2) 10Yuvipanda: Make clicking ToC header go to top of page. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/137725 (https://bugzilla.wikimedia.org/64890) (owner: 10Dbrant) [19:41:20] YuviPanda: http://lifehacker.com/wikipedia-beta-brings-slide-out-navigation-bookmarks-1586705654 :) nice [19:42:06] jdlrobson: \o/ [19:42:27] woo [19:42:36] jdlrobson: dbrant I love how they have just discovered reading history and saved pages [19:42:45] YuviPanda: sign of a better UI :) [19:42:49] jdlrobson: agreed [19:42:55] jdlrobson: dbrant bearND also nobody asking for saved pages [19:43:15] indeed [19:46:30] (03PS1) 10Jdlrobson: Alpha: Avoid multiple title parameters when rewriting url [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/137740 (https://bugzilla.wikimedia.org/65327) [19:46:33] bearND: we should get the & patch out today as well, I think. any blockers? [19:46:41] jdlrobson: have you used it yet? [19:47:23] Maryana: how goes the goal setting ? [19:48:00] YuviPanda: how hard is it to add the dark theme back ? [19:48:58] Congrats to app developers to the new app (and the good feedback) :) [19:50:06] FlorianSW: woot! thanks :) [19:51:04] FlorianSW: thx! [19:51:29] 3MobileFrontend / 3stable: If you switch to mobile view while editing and save your edit, it takes you back to the desktop editing interface - 10https://bugzilla.wikimedia.org/65041#c2 (10Jon) This weird edge case also effects stable. 1. Ensure in stable mode on mobile. 2. Go to http://en.wikipedia.beta.wmfl... [19:51:41] tfinc: the last one took me 3 days, but that wasn't very complete (inline styles would still show up glaring colors). I do think we can make a *nice* theme in about a week, though. [19:53:14] 3MobileFrontend / 3beta: Flash of Rory when clicking on redlink - 10https://bugzilla.wikimedia.org/64641#c5 (10Jon) you'll need to copy over this page to see Rory :-): https://en.m.wikipedia.org/wiki/MediaWiki:Mobile-frontend-editor-newpage-prompt [19:53:42] (03CR) 10Yuvipanda: [C: 032] Make clicking ToC header go to top of page. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/137725 (https://bugzilla.wikimedia.org/64890) (owner: 10Dbrant) [19:53:46] 3MobileFrontend / 3beta: Table of contents looks weird when only one lead section - 10https://bugzilla.wikimedia.org/60478#c5 (10Jon) So...? Maryana any guidance so we can get this bug fixed or closed as wont fix ? [19:53:48] (03PS2) 10Yuvipanda: Fix possible crash relating to ToC (based on OTRS tickets) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/137728 (owner: 10Dbrant) [19:54:02] (03Merged) 10jenkins-bot: Make clicking ToC header go to top of page. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/137725 (https://bugzilla.wikimedia.org/64890) (owner: 10Dbrant) [19:54:44] 3MobileFrontend / 3beta: Table of contents looks weird when only one lead section - 10https://bugzilla.wikimedia.org/60478#c6 (10Yuvi Panda) In the Android app we disable the ToC if there's only one section, fwiw. [19:55:59] 3MobileFrontend / 3beta: Flash of Rory when clicking on redlink - 10https://bugzilla.wikimedia.org/64641#c6 (10Florian) Yeah, i know, i have tested this on en wiki :D If a page isn't found, i become the tiger, but no flash if i click on a red link, only the editor directly :) [19:57:10] tfinc: I'm responding to comments on press everywhere as I find them as well. Also responding to the play store reviews :) [19:57:23] YuviPanda: thanks [19:57:25] (03CR) 10Jdlrobson: [C: 04-2] "Marking as -2 as we don't want to disable all content images on a site which disables uploads :)" (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/137541 (https://bugzilla.wikimedia.org/66164) (owner: 10Florianschmidtwelzow) [19:57:48] tfinc: I'll also note that we've had about 10-12 people asking for the dark theme back and only one person asking for saved pages, and even that person already gave the app 5 stars :D [19:58:04] how hard will it be to add it? [19:58:12] i mentioned it to Deskana|Away in the morning [19:58:31] tfinc: the last one took me 3 days, but that wasn't very complete (inline styles would still show up glaring colors). I do think we can make a *nice* theme in about a week, though. [19:58:43] lets prioritize it with Deskana|Away [19:58:53] tfinc: ok, when he's back [19:58:59] this is exactly why i was pushing to get this release out [19:59:05] we find out what our users truly need [19:59:07] tfinc: also, I just realized we have 40,000 Beta users on Android, not 15,000 :D [19:59:17] lets delight them YuviPanda [19:59:24] tfinc: +1 tfinc, +1 :D [20:00:29] (03CR) 10Yuvipanda: [C: 032] Fix possible crash relating to ToC (based on OTRS tickets) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/137728 (owner: 10Dbrant) [20:00:40] dbrant: want to handle a release once I've pushed the last patch to CR? [20:00:44] dbrant: alpha and beta [20:00:49] YuviPanda: of course [20:00:51] (03Merged) 10jenkins-bot: Fix possible crash relating to ToC (based on OTRS tickets) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/137728 (owner: 10Dbrant) [20:00:55] dbrant: cool! [20:01:03] YuviPanda: but I have one more nice patch in store... [20:01:12] dbrant: ah, let me wait for it. [20:01:26] * YuviPanda also pokes bearND again about '&' patch [20:02:01] YuviPanda: no luck with replacing & in query paramater values. The http-request library seem to mess with it. turning it into %2526 [20:02:09] bearND: hmm, bah [20:02:17] that looks like a double encoding somewhere [20:02:28] YuviPanda: i'll submit a patch so you can see the current state + a new test [20:02:32] dbrant: ok! [20:02:34] err, bearND ok! [20:02:39] it's very much WIP [20:02:46] (03PS3) 10Yuvipanda: Only add successfully-loaded pages to History. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/137732 (owner: 10Dbrant) [20:04:39] (03PS1) 10Dbrant: Show confirmation when about to discard edit changes. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/137746 (https://bugzilla.wikimedia.org/66195) [20:06:52] (03PS1) 10BearND: Open page with ampersand in title caused network issues [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/137747 (https://bugzilla.wikimedia.org/66152) [20:07:19] YuviPanda: dbrant: meant to add [WIP] ^ [20:09:04] (03CR) 10Jdlrobson: [C: 04-1] "Thanks for kicking this off. A few bits of feedback." (0317 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/137739 (https://bugzilla.wikimedia.org/66086) (owner: 10Florianschmidtwelzow) [20:10:07] (03CR) 10BearND: [C: 04-2] "not ready yet" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/137747 (https://bugzilla.wikimedia.org/66152) (owner: 10BearND) [20:10:24] bearND: have you checked with java-mwapi to see if *that* is doing the encoding? [20:11:07] YuviPanda: speaking of release, where's the branch for the beta app? [20:11:45] dbrant: right. there's no branch. you take https://gerrit.wikimedia.org/r/#/c/137311/, rebase it on top of gerrit/master, and then ammend it to include the new version number and code [20:12:02] dbrant: keepint it as one patch helps rebasing a bit, plus I haven't figured out gerrit perms to let us push to a non-master branch [20:12:10] YuviPanda: haven't found encoding in mwapi [20:12:15] bearND: gah, hmm. [20:12:26] YuviPanda: seems to be a ton of that in http-request [20:12:42] bearND: if it's being *double* encoded, that means we're encoding it once somewhewre... [20:13:05] brion: ping re our meeting [20:13:29] YuviPanda: well, i was manually encoding the & to %26, but then i think http-request encodes the % to %25 [20:13:46] bearND: ah, hmm [20:14:05] (03CR) 10Yuvipanda: [C: 032] Only add successfully-loaded pages to History. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/137732 (owner: 10Dbrant) [20:14:09] (03PS1) 10Kaldari: Tweak formatting of citation drop down [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/137748 [20:14:17] (03PS2) 10Yuvipanda: Show confirmation when about to discard edit changes. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/137746 (https://bugzilla.wikimedia.org/66195) (owner: 10Dbrant) [20:14:25] (03Merged) 10jenkins-bot: Only add successfully-loaded pages to History. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/137732 (owner: 10Dbrant) [20:15:07] YuviPanda: bearND: I've got to step out for a while (~2-3hrs), but I can do the release when I get back. [20:15:51] dbrant: hmm, nothing major here, so let's wait. [20:16:33] bearND: think you can clear out OTRS in the meantime? I see another bug about the main page causing crashes [20:18:07] (03PS2) 10Yuvipanda: Open page with ampersand in title caused network issues [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/137747 (https://bugzilla.wikimedia.org/66152) (owner: 10BearND) [20:18:21] bearND: this week might be a little hectic, but usually it's calmer around :) [20:19:56] YuviPanda: i'll take a peek at OTRS later, after we get a handle on the & bug. not sure what you want to do with the enhancement requests on OTRS [20:20:15] bearND: let's leave them alone for now, crash reports and bug reports take higher priority. I'm looking at the & bug too [20:20:40] YuviPanda: ok [20:20:52] (03PS2) 10Florianschmidtwelzow: Respect Upload Settings on Special:Uploads [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/137541 (https://bugzilla.wikimedia.org/66164) [20:21:20] (03PS3) 10JGonera: Move notifications drawer to stable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/137481 [20:24:16] (03PS3) 10Florianschmidtwelzow: Respect Upload Settings on Special:Uploads [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/137541 (https://bugzilla.wikimedia.org/66164) [20:25:14] (03CR) 10Kaldari: [C: 04-1] Alpha: Avoid multiple title parameters when rewriting url (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/137740 (https://bugzilla.wikimedia.org/65327) (owner: 10Jdlrobson) [20:27:31] Deskana: I love our users. https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom&TicketID=7590660 this guy [20:27:37] (03CR) 10Florianschmidtwelzow: Respect Upload Settings on Special:Uploads (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/137541 (https://bugzilla.wikimedia.org/66164) (owner: 10Florianschmidtwelzow) [20:27:48] Deskana: also, not sure if I told you, but we're reaching *40,000* users, not *15,000* as previously thought [20:29:52] aharoni: https://play.google.com/store/apps/details?id=org.wikipedia.beta wikipedia beta is out! Nobody's reported any RTL issues yet [20:30:06] YuviPanda: Wow. Cool. [20:30:12] tfinc: also, liangent was *asking* us to see if there's a way we know of to crash the app. If liangent can't find a way to crash the app, seems pretty solid :D [20:30:31] The cool thing so far is that there's not been a single instance of vandalism. [20:30:32] Deskana: roll out stats are delayed by a couple of days in google play, so we won't know right now, but we can in a few days [20:30:45] Deskana: oh yeah, I haven't been monitoring recentchanges at all [20:30:54] That's mostly what I've been doing. [20:30:59] Fucking tons of account creations. [20:31:12] Deskana: liangent submitted a patch to get the tags stuff fixed, I think. it's merged, but might need an LD. I won't be around, plus I don't feel comfortable enough LDing with core, so you might have to grab someone else [20:31:37] Not reviewed that thread yet, other than kicking it off with Dario. :P [20:31:42] Deskana: cool :) [20:31:46] 3Wikipedia App / 3Android App: app crash on startup - 10https://bugzilla.wikimedia.org/66213 (10Bernd Sitzmann) 3NEW p:3Unprio s:3major a:3None https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom;TicketID=7590604 APP_VERSION_NAME=2.0-beta3 STACK_TRACE=java.lang.RuntimeException: Unable... [20:32:21] YuviPanda: latey-late, I'll test tomorrow [20:32:24] congratz :) [20:33:10] Maryana: are you around? [20:33:14] YuviPanda: what's LD? [20:33:19] kaldari: yep [20:33:20] what's up? [20:33:39] Maryana: just wanted to ask you about the car plan when you have time [20:33:53] Deskana, Maryana: re: account creations, I posted a short report on analytics-l [20:33:53] bearND: Lightning deploy. Normally things get deployed in a two week cycle. [20:34:11] Deskana: would you like to respond to some of the enhancement requests on OTRS? [20:34:20] YuviPanda: ah [20:35:03] bearND: they are actually called SWAT now. The deploy we did yesterday was SWAT [20:38:30] yurik: yo [20:45:55] (03PS1) 10Jdlrobson: Make Special:Uploads render nicely on tablet devices [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/137774 [20:46:20] How much effort would it be to write a patch to remove tagging from account creations? [20:46:33] (03CR) 10Jdlrobson: [C: 032] Allow text-alignment for thumbnail captions to be inherited [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/137726 (https://bugzilla.wikimedia.org/66103) (owner: 10Kaldari) [20:46:35] I'm currently writing the rationale for the change for a mobile-l post. [20:46:46] YuviPanda, bearND, dbrant|bbl: ^^ [20:47:00] 3Wikipedia App / 3Android App: app crash on startup - 10https://bugzilla.wikimedia.org/66213#c1 (10Bernd Sitzmann) https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom;TicketID=7590648 is very similar; strangely the line numbers are slightly different (but both are beta3) [20:47:07] (03Merged) 10jenkins-bot: Allow text-alignment for thumbnail captions to be inherited [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/137726 (https://bugzilla.wikimedia.org/66103) (owner: 10Kaldari) [20:47:08] Deskana: 2mins [20:47:17] Deskana: but if we do that we must track it in some other way then [20:47:27] Deskana: since eventlogging doesn't record the name of the user, IIRC [20:47:53] YuviPanda: You know better than I do about this. Can you follow-up with Dario and make sure that the data we need is captured? [20:50:19] Deskana: I'm heading out in about 10m for a couple of hours (is 10pm here), I'll be back a little past midnight. I'll poke around and figure it out [20:50:28] (03CR) 10Florianschmidtwelzow: [C: 031] "Big thanks for the comments! Work on it, that the next commits will be better :)" (0317 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/137739 (https://bugzilla.wikimedia.org/66086) (owner: 10Florianschmidtwelzow) [20:50:59] 3MobileFrontend / 3stable: CSS Regression: Captions on Special:Uploads are left aligned - 10https://bugzilla.wikimedia.org/66103 (10Jon) 5PATC>3RESO/FIX [20:51:17] Deskana: I'll try to get it SWAT'd in tomorrow's early morning window (the one we used for Hovercards today) but if that doesn't happen it might have to wait for Monday. Is that acceptable? [20:51:46] Yeah, that's fine. It's not a "servers burning down" issue but the longer it goes on the more of a headache it creates. [20:51:49] (03PS2) 10Florianschmidtwelzow: Update doc for files in includes/ [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/137739 (https://bugzilla.wikimedia.org/66086) [20:52:03] 3Wikipedia App / 3Android App: NullPointerException in toggleToC() - 10https://bugzilla.wikimedia.org/66216 (10Bernd Sitzmann) 3NEW p:3Unprio s:3normal a:3None https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom;TicketID=7590473 ANDROID_VERSION=4.3 APP_VERSION_NAME=2.0-beta3 STACK_TRAC... [20:52:31] Deskana: cool. I'm off now, but constantly available on Google Hangout or Email if the need arises. [20:53:31] bearND: dbrant|bbl am off now, cya guys in a few hours (again) [20:54:21] YuviPanda: ok [20:54:29] MaxSem: thanks for fixing commons :) [20:54:42] * YuviPanda waves off [20:54:48] well, it still has 2 bugs:P [20:59:20] YuviPanda|zzz: Thanks Yuvi! [21:05:38] yurik: dbrant|bbl bearND : do you guys want to present at the next showcase? mobile web is punting. if not i'll cancel [21:05:42] err [21:05:44] YuviPanda|zzz: --^ [21:07:59] (03PS1) 10Jdlrobson: Correct sort algorithm on nearby [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/137805 [21:08:01] tfinc: when is the next one? i can't find it in my calendar [21:08:04] ^ MaxSem [21:08:07] Monday [21:10:55] (03PS2) 10Jdlrobson: Make Special:Uploads render nicely on tablet devices [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/137774 [21:12:01] awjr: you need coffee yet? [21:12:16] jdlrobson: just had some kitchen coffee - in mtgs rest of day :-| [21:13:42] i'm going to cancel and let you guys focus on the release [21:15:17] tfinc: sounds good [21:16:04] (03CR) 10MaxSem: [C: 032] Correct sort algorithm on nearby [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/137805 (owner: 10Jdlrobson) [21:16:38] (03Merged) 10jenkins-bot: Correct sort algorithm on nearby [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/137805 (owner: 10Jdlrobson) [21:17:03] good night and have a nice day @all :) [21:18:59] 3Wikipedia App / 3Android App: NullPointerException in toggleToC() - 10https://bugzilla.wikimedia.org/66216#c1 (10Bernd Sitzmann) 5NEW>3RESO/FIX fixed in https://gerrit.wikimedia.org/r/#/c/137728/ [21:23:12] (03CR) 10Kaldari: [C: 032] Make Special:Uploads render nicely on tablet devices [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/137774 (owner: 10Jdlrobson) [21:23:55] (03Merged) 10jenkins-bot: Make Special:Uploads render nicely on tablet devices [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/137774 (owner: 10Jdlrobson) [21:30:23] quiddity are we good to go for the post? [21:31:04] dgarry and I are testing, arent able to reproduce the flicker bug [21:36:08] (03CR) 10Jdlrobson: [C: 04-1] Update doc for files in includes/ (036 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/137739 (https://bugzilla.wikimedia.org/66086) (owner: 10Florianschmidtwelzow) [21:41:50] (03PS4) 10Jdlrobson: Move notifications drawer to stable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/137481 (owner: 10JGonera) [21:41:52] (03PS3) 10Jdlrobson: Notification bell tweaks [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/137361 [21:42:25] (03CR) 10Jdlrobson: [C: 031] "I rebased off notification drawer tweaks (since if we're changing that in core we might as well push it all together)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/137481 (owner: 10JGonera) [21:42:44] (03PS4) 10Jdlrobson: Notification bell tweaks [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/137361 [21:42:50] (03PS5) 10Jdlrobson: Move notifications drawer to stable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/137481 (owner: 10JGonera) [21:44:29] 3Wikipedia App / 3Android App: WikiCode de + not found+ - 10https://bugzilla.wikimedia.org/66140 (10Bernd Sitzmann) 5PATC>3RESO/FIX [21:45:04] (03PS2) 10Jdlrobson: Alpha: Avoid multiple title parameters when rewriting url [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/137740 (https://bugzilla.wikimedia.org/65327) [21:45:44] 3Wikipedia App / 3Android App: search for # crash - 10https://bugzilla.wikimedia.org/66151 (10Bernd Sitzmann) 5PATC>3RESO/FIX [21:47:26] (03CR) 10Jdlrobson: [C: 032] Tweak formatting of citation drop down [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/137748 (owner: 10Kaldari) [21:47:54] kaldari: MaxSem plleasseee can we resolve the site notice mess https://gerrit.wikimedia.org/r/#/c/136237/ [21:47:59] (03Merged) 10jenkins-bot: Tweak formatting of citation drop down [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/137748 (owner: 10Kaldari) [21:48:03] i don't care if we go for Max's solution or mine i just want them gone :) [21:48:58] (03CR) 10Florianschmidtwelzow: "The copyright warnings i will remove tomorrow. :) in my opinion we can live with the "no file summary" error when delete first docblock fr" (034 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/137739 (https://bugzilla.wikimedia.org/66086) (owner: 10Florianschmidtwelzow) [21:51:59] 3Wikipedia App / 3Android App: app crash on startup - 10https://bugzilla.wikimedia.org/66213#c2 (10Bernd Sitzmann) I can repro this by clearing app data, and switching to language "[Developer] Accented English (zz_ZZ)" [21:55:46] 3MobileFrontend / 3General/Unknown: Spotlight search wikipedia links go to desktop site on ios 8 phones - 10https://bugzilla.wikimedia.org/66220 (10Jared Zimmerman (WMF)) 3NEW p:3Unprio s:3normal a:3None rather than going to en.m.wikipedia site. [21:57:05] kaldari, https://gerrit.wikimedia.org/r/#/c/136244/ [22:00:30] 3MobileFrontend / 3General/Unknown: Spotlight search wikipedia links go to desktop site on ios 8 phones - 10https://bugzilla.wikimedia.org/66220#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/QGxqOvD6 [22:03:14] 3MobileFrontend / 3General/Unknown: Spotlight search wikipedia links go to desktop site on ios 8 phones - 10https://bugzilla.wikimedia.org/66220#c2 (10Jared Zimmerman (WMF)) Mozilla/5.0 (iPhone; CPU iPhone OS 8_0 like Mac OS X) AppleWebKit/538.34.9 (KHTML, like Gecko) Version/7.0 Mobile/12A4265u Safari/9537.53 [22:07:29] 3MobileFrontend / 3General/Unknown: Spotlight search wikipedia links go to desktop site on ios 8 phones - 10https://bugzilla.wikimedia.org/66220#c3 (10Jared Zimmerman (WMF)) 5NEW>3RESO/INV ok looks like it was a weird cookie issue, perhaps we should expire the desktop view/mobile view cookie sooner? [22:14:46] brion: heya! [22:17:20] brion: could i pester you for cr? the patch is… er… substantial [22:17:31] (03PS1) 10Mhurd: Sync with MobileApp extension css. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/137816 [22:21:11] (03PS1) 10Jdlrobson: Make search icon render okay on stable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/137817 [22:21:33] (03PS1) 10Kaldari: Make sure we detect Android tablets correctly [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/137818 [22:22:09] (03CR) 10jenkins-bot: [V: 04-1] Make sure we detect Android tablets correctly [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/137818 (owner: 10Kaldari) [22:22:16] (03PS2) 10Kaldari: Make sure we detect Android tablets correctly [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/137818 [22:22:51] (03CR) 10jenkins-bot: [V: 04-1] Make sure we detect Android tablets correctly [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/137818 (owner: 10Kaldari) [22:33:03] (03PS1) 10BearND: Fix crash when unknown language was used. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/137820 (https://bugzilla.wikimedia.org/66213) [22:43:05] (03PS1) 10Jdlrobson: QA: Random stab in dark to get chrome tests to pass [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/137826 [22:43:13] ^ kaldari [22:45:03] (03CR) 10Kaldari: [C: 032] QA: Random stab in dark to get chrome tests to pass [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/137826 (owner: 10Jdlrobson) [22:45:14] mhurd: ah great, i’ll poke it over in a bit [22:45:18] sorry was afk [22:45:36] (03Merged) 10jenkins-bot: QA: Random stab in dark to get chrome tests to pass [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/137826 (owner: 10Jdlrobson) [22:45:54] brion: no worry :) [22:45:56] lemme just pull it up real quick [22:46:17] oh my that is hefty :) [22:46:41] brion: it got crazy [22:46:46] hehe :) [22:46:52] you didn’t convert everything to swift did you ;)) [22:47:00] brion: hehe that’s tomorrow [22:47:03] lol [22:47:04] lol [22:47:27] ok i’ve gotta track down this lost package and then i’ll be back to cr [22:47:28] mhurd: http://l-lin.github.io/font-awesome-animation/ [22:47:40] somebody ain’t delivering things right from usps >:( [22:47:48] 3MobileFrontend / 3Hygiene: Make MobileFrontend dependent on Mantle extension - 10https://bugzilla.wikimedia.org/66224 (10Jon) 3NEW p:3Unprio s:3normal a:3Jon Depends on bug 66094 [22:47:54] violetto: whoa no way! [22:47:58] violetto: cool! [22:47:59] 3MobileFrontend / 3Hygiene: Make MobileFrontend dependent on Mantle extension - 10https://bugzilla.wikimedia.org/66224 (10Jon) [22:48:29] 3MobileFrontend / 3Hygiene: Nearby is not a PageList - 10https://bugzilla.wikimedia.org/64212#c1 (10Jon) 5NEW>3RESO/FIX It is now. [22:48:52] brion: i hear ya. i got a package slip a over the holidays - and they lost the package. i don’t even know who sent it :( [22:48:57] mhurd: can also put loader in there [22:49:31] violetto: i added that link to the etherpad [22:50:16] mhurd: im hoping shahyar can make that showcase the same on github pages [22:50:37] library of examples of things ppl can do [22:50:49] and when they find new things they can add to that mhurd [22:51:04] violetto: cool! [22:56:59] 3MobileFrontend / 3Hygiene: Hygiene: Remove disableBackToTop and enableExpandableSections from MobileFormatter.php - 10https://bugzilla.wikimedia.org/64004#c1 (10Jon) I think Florian noticed this during his cleanup of the PHP documentation [22:58:59] 3MobileFrontend / 3Hygiene: $wgMFNearby shouldn't exist - 10https://bugzilla.wikimedia.org/64029#c6 (10Jon) 5PATC>3RESO/DUP Moving the code to the Geodata extension would be a better idea. *** This bug has been marked as a duplicate of bug 64316 *** [22:59:14] 3MobileFrontend / 3Hygiene: Move Nearby code to Geodata extension - 10https://bugzilla.wikimedia.org/64316#c1 (10Jon) *** Bug 64029 has been marked as a duplicate of this bug. *** [23:26:07] jgonera: http://www.unwiredview.com/2013/11/21/android-4-4-kitkat-ships-without-browser-app-oems-have-to-license-chrome-or-build-their-own/ [23:30:06] (03PS3) 10Kaldari: Make sure we detect Android tablets correctly [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/137818 [23:32:23] (03PS1) 10Jdlrobson: Hygiene: Kill OverlayNew and LoadingOverlayNew [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/137831 [23:32:25] (03PS1) 10Jdlrobson: Make `make message` work again. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/137832 (https://bugzilla.wikimedia.org/63019) [23:32:35] (03PS2) 10Jdlrobson: Make `make message` work again. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/137832 (https://bugzilla.wikimedia.org/63019) [23:32:52] (03CR) 10Dbrant: [C: 032] Fix crash when unknown language was used. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/137820 (https://bugzilla.wikimedia.org/66213) (owner: 10BearND) [23:37:11] (03PS4) 10Kaldari: Make sure we detect Android tablets correctly [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/137818 [23:46:17] Maryana: you still around? [23:46:24] yep [23:46:29] at the lunch table [23:47:07] (03PS1) 10Jdlrobson: Collapse on the highest available heading level [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/137836 (https://bugzilla.wikimedia.org/60478) [23:53:14] (03CR) 10Brion VIBBER: [C: 032 V: 032] Refactor modal views. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/135956 (owner: 10Mhurd) [23:53:30] (03PS2) 10Jdlrobson: Collapse on the highest available heading level [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/137836 (https://bugzilla.wikimedia.org/60478) [23:56:00] (03PS12) 10Dbrant: Move everything to beta package [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/137311 (owner: 10Yuvipanda) [23:57:47] (03PS5) 10Kaldari: Make sure we detect Android tablets correctly [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/137818 [23:58:31] 3Wikipedia App / 3Android App: % and _ are not escaped in history search - 10https://bugzilla.wikimedia.org/66230 (10Liangent) 3NEW p:3Unprio s:3normal a:3None Or consider it as a hidden feature?