[00:05:03] MaxSem: https://gerrit.wikimedia.org/r/#/c/137818/3 [00:08:43] (03CR) 10Brion VIBBER: "(quick inline note from first read)" (031 comment) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/137816 (owner: 10Mhurd) [00:12:22] (03CR) 10MaxSem: [C: 032] "Awesome, thanks!" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/137818 (owner: 10Kaldari) [00:12:56] (03Merged) 10jenkins-bot: Make sure we detect Android tablets correctly [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/137818 (owner: 10Kaldari) [00:14:26] (03CR) 10Brion VIBBER: [C: 032 V: 032] "Doesn't seem to explode, let's go ahead and merge and see how it shakes out :D" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/137816 (owner: 10Mhurd) [00:14:48] ok gotta rebase eventlogging now [00:17:16] (03PS3) 10Brion VIBBER: Work in progress (do not merge): EventLogging refactor [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/135885 [01:32:44] android app gets a little media attn: http://thenextweb.com/apps/2014/06/06/wikipedia-adds-editing-functionality-beta-android-app/ [01:36:49] \o/ [02:06:44] nice that this one links to the official announcement. [02:48:02] bearND: heya! sorry was away for longer than expected [02:48:08] anything I missed? [02:48:10] * YuviPanda sees logs [02:50:21] hey YuviPanda, not much on irc. except http://thenextweb.com/apps/2014/06/06/wikipedia-adds-editing-functionality-beta-android-app/; got several otrs reports though [02:50:42] bearND: cool! I've been following the OTRS reports, a bunch of MainPage related crashes. I guess those are to do with the language issues? [02:51:14] 3Wikipedia App / 3Android App: IP block is not detected and saving using a blocked IP crashes the app - 10https://bugzilla.wikimedia.org/66235 (10Yuvi Panda) p:5Unprio>3High s:5normal>3major [02:52:14] 3Wikipedia App / 3Android App: IP block is not detected and saving using a blocked IP crashes the app - 10https://bugzilla.wikimedia.org/66235#c1 (10Yuvi Panda) Doubly important since we allow anon editing and also have no way of letting the user know they are blocked. The editable status with mobileview do... [03:02:18] bearND: did dbrant or you make a new release? [03:02:56] * YuviPanda checks [03:03:26] hmm, apparently not [03:03:29] 'tis ok, I can do that tomorrow [03:03:34] * YuviPanda wanders off for the night [03:03:36] night everyone [03:03:42] YuviPanda: did you make one? [03:06:51] YuviPanda|Zzz: i saw that 59 was pushed to beta. alpha is still at 58 ;( [03:08:14] YuviPanda|Zzz: i guess the that's because the beta stuff is on a separate branch [03:08:21] np then [03:08:24] nm [03:45:13] 3MobileFrontend / 3Hygiene: Hygiene: Remove disableBackToTop and enableExpandableSections from MobileFormatter.php - 10https://bugzilla.wikimedia.org/64004#c2 (10Florian) 5NEW>3PATC Yap, see change: https://gerrit.wikimedia.org/r/#/c/137739/ :) [05:23:22] hi brion [05:28:29] was wondering who to contact for translation issues. i've joined https://translatewiki.net/wiki/Translating:Wikimedia_Mobile_Apps but the info seems outdated. The issue I currently notice is that the fa (Farsi) translation of our Android strings has a garbled parameter: last_updated_text should have a %1$s but i only see $1%. [06:31:11] (03CR) 10Florianschmidtwelzow: Update doc for files in includes/ (036 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/137739 (https://bugzilla.wikimedia.org/66086) (owner: 10Florianschmidtwelzow) [06:35:21] (03PS3) 10Florianschmidtwelzow: Update doc for files in includes/ [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/137739 (https://bugzilla.wikimedia.org/66086) [06:51:31] 3Wikipedia App / 3Android App: some translations use illegal parameter syntax - 10https://bugzilla.wikimedia.org/66241 (10Bernd Sitzmann) 3NEW p:3Unprio s:3normal a:3None https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom;TicketID=7590812 https://ticket.wikimedia.org/otrs/index.pl?Acti... [06:52:47] (03PS1) 10BearND: Add TranslationTests [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/137885 (https://bugzilla.wikimedia.org/66241) [07:30:45] (03PS1) 10Ori.livneh: Fix MobileWebEditing code [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/137891 [08:13:35] Both quiddity and vbamba or on my timezone today :D [13:19:28] 3Wikipedia App / 3Android App: Add a 'Night Mode' to the Wikipedia Mobile app - 10https://bugzilla.wikimedia.org/35251#c10 (10Yuvi Panda) Is the most frequently asked for feature for the Android Beta. [13:32:59] 3Wikipedia App / 3Android App: Add a 'Night Mode' to the Wikipedia Mobile app - 10https://bugzilla.wikimedia.org/35251#c11 (10Antoine "hashar" Musso) I have a few apps that turns off OLED/AMOLED to render black. That saves a bit on battery and it is easier to the eyes when reading in plain dark. Random lin... [13:34:44] 3Wikipedia App / 3Android App: Add a 'Night Mode' to the Wikipedia Mobile app - 10https://bugzilla.wikimedia.org/35251#c12 (10Yuvi Panda) Indeed, and I do agree it is much less straining on the eyes in the dark (I use dark mode myself on Aldiko for reading books) [13:39:19] YuviPanda: http://etherpad.wikimedia.org/p/androidappfeedback [13:39:47] dbrant: cool! Is this from the play store reviews only? [13:39:50] dbrant: I can add in OTRS to this [13:39:58] YuviPanda: that's actually OTRS only [13:41:20] dbrant: ah, cool. do you want me to add the ones from play store review as well? [13:41:27] dbrant: let me add links to other places people have comments on [13:41:33] YuviPanda: sure! [13:42:30] dbrant: done [13:42:35] dbrant: incrementing count for reddit now [13:44:42] dbrant: we should also put a last update timestamp next to the sources ;D [13:45:10] dbrant: too early in the day, apparently I can't read [13:45:18] lol [13:48:02] dbrant: wow, dark theme is very popular [13:48:28] YuviPanda: it would appear so [13:51:32] dbrant: when was the OTRS ones last updated? [13:51:37] dbrant: can you put a timestamp next to it? [13:55:25] YuviPanda: I didn't do a release last night; got back later than I thought. Shall I do it now? [13:55:49] dbrant: yes please! [13:55:53] YuviPanda: have a chance to look at this? https://gerrit.wikimedia.org/r/#/c/137746/ [13:55:59] dbrant: looking now [13:56:04] (03PS3) 10Yuvipanda: Show confirmation when about to discard edit changes. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/137746 (https://bugzilla.wikimedia.org/66195) (owner: 10Dbrant) [13:56:16] dbrant: let me merge in a few mins, then you can do the release :) [14:09:14] (03CR) 10Yuvipanda: [C: 032] Show confirmation when about to discard edit changes. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/137746 (https://bugzilla.wikimedia.org/66195) (owner: 10Dbrant) [14:09:28] dbrant: I am wondering if we should fix the malformed translation bugs as well [14:09:36] dbrant: considering replacing all the placeholders with simpler %s ones [14:09:36] (03Merged) 10jenkins-bot: Show confirmation when about to discard edit changes. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/137746 (https://bugzilla.wikimedia.org/66195) (owner: 10Dbrant) [14:09:40] non numbered [14:10:39] YuviPanda: what's an example of this bug? [14:11:00] dbrant: https://gerrit.wikimedia.org/r/#/c/137885/1 is the fix, so you can check any of the locales there and try to use that message, it'll crash. [14:11:07] dbrant: a few showed up in OTRS [14:11:19] YuviPanda: ah, right [14:11:20] dbrant: I'd guess es is the largest in that list [14:16:03] dbrant: actual fix is to make them in translatewiki.net, though [14:16:15] dbrant: I guess the translators were more used to the $1 syntax and confused this with that [14:17:37] YuviPanda: why is the Farsi string commented out... [14:18:00] dbrant: not sure at all. perhaps editor issues with the RTL text made it harder for him to fix? [14:26:26] * YuviPanda waves at Deskana [14:28:30] I scared him off! [14:35:45] (03PS2) 10Dbrant: Add TranslationTests [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/137885 (https://bugzilla.wikimedia.org/66241) (owner: 10BearND) [14:37:25] (03PS3) 10Dbrant: Add TranslationTests [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/137885 (https://bugzilla.wikimedia.org/66241) (owner: 10BearND) [14:37:46] YuviPanda: ^ fixed the Farsi string [14:38:26] YuviPanda: is it acceptable for me to +2 after making my own change? [14:47:30] dbrant: minor things are ok, provided you mention that there. [14:47:51] dbrant: in this case I think it's ok (strings and comments are usually ok) [14:49:51] (03CR) 10Dbrant: [C: 032] "Updated the Farsi string (couldn't do it in the IntelliJ editor, but Windows Notepad FTW)." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/137885 (https://bugzilla.wikimedia.org/66241) (owner: 10BearND) [14:50:12] dbrant: also https://medium.com/@raureif/das-referenz-wikipedia-redesigned-for-ipad-65af999b576d seems pretty awesome [14:50:44] dbrant: release time! :) [14:52:13] YuviPanda: just looking at one tiny RTL bug... [14:52:18] dbrant: ah cool [15:03:51] (03PS1) 10Yuvipanda: Use simpler printf formatting for all messages [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/137937 [15:06:57] (03PS1) 10Dbrant: Fix hamburger icon behavior in RTL environment. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/137939 [15:08:10] (03PS2) 10Yuvipanda: Fix hamburger icon behavior in RTL environment. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/137939 (owner: 10Dbrant) [15:08:54] dbrant: looking at patch. mine was a minor one as well [15:09:04] YuviPanda: yep... [15:10:05] (03CR) 10Yuvipanda: [C: 032] Fix hamburger icon behavior in RTL environment. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/137939 (owner: 10Dbrant) [15:10:25] (03Merged) 10jenkins-bot: Fix hamburger icon behavior in RTL environment. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/137939 (owner: 10Dbrant) [15:11:28] YuviPanda: yours isn't compiling (apostrophes not preceded by \) [15:11:42] dbrant: bah. am idiot [15:12:09] (03PS2) 10Yuvipanda: Use simpler printf formatting for all messages [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/137937 [15:12:10] dbrant: updated [15:12:43] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/137937 (owner: 10Yuvipanda) [15:12:49] dbrant: I'm also changing the strings in translatewiki.net so the next import doesn't override. [15:13:01] YuviPanda: cool [15:14:42] (03CR) 10Dbrant: [C: 032] Use simpler printf formatting for all messages [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/137937 (owner: 10Yuvipanda) [15:14:51] * YuviPanda waves at bearND [15:16:08] hi YuviPanda, was just reading the log [15:16:55] YuviPanda: bearND: making release... [15:16:55] dbrant: thanks for fixing the Farsi string. Yeah, could quickly find a good editor for that on my Mac, and it was late. [15:18:08] dbrant: I like installing the app from the store and doing an adb install -r of the signed package to test before pushing it out, just in case. [15:18:25] YuviPanda: i signed up at ttps://translatewiki.net/wiki/Translating:Wikimedia_Mobile_Apps yesterday, but the info seems out-dated, and it wasn't clear to me how to fix the bugs there. the bugzilla link said that it didn't accept new bugs [15:18:42] bearND: looking, that might be the old app [15:18:53] YuviPanda: yeah [15:20:47] bearND: https://translatewiki.net/w/i.php?title=Special:Translate&group=out-wikimedia-mobile-wikipedia-android-strings&language=ta&filter=%21translated&action=translate [15:20:55] bearND: seems to be the correct one [15:21:20] bearND: you can join #mediawiki-i18n and poke siebrand or Nikerabbit about the outdated old page. Or email mediawiki-i18n mailing list. [15:26:41] YuviPanda: thanks. much better [15:36:36] (03PS1) 10Dbrant: Bump version number for 2.0-alpha-2014-06-06 [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/137941 [15:37:57] (03PS13) 10Dbrant: Move everything to beta package [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/137311 (owner: 10Yuvipanda) [15:40:27] YuviPanda: bearND: published! [15:40:32] dbrant: woot! :D [15:41:06] dbrant: bearND I'm making the updates in translatewiki.net [15:42:07] updated [15:44:22] (03PS1) 10Dbrant: Catch more errors when fetching non-lead sections. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/137942 [15:47:42] Hey everyone. [15:47:48] hello Deskana [15:48:06] heya DarTar! [15:48:18] howdy [15:48:33] DarTar: RC user creations from the app are still tagged as mobile app edit. I have a patch that fixes it, but needs someone to merge. [15:48:36] hmm, /me pokes MaxSem [15:48:40] around? [15:49:03] oh I thought MaxSem said the patch was live? [15:49:07] kinda [15:49:17] DarTar: different patch [15:49:22] ah [15:49:24] only the patch that makes taggging always work [15:49:28] got it [15:49:39] DarTar: https://gerrit.wikimedia.org/r/#/c/137930/ is the patch that stops the rc tags from everything that's not an edit [15:50:39] yurikR, YuviPanda: as mobile-ers, can you guys merge https://gerrit.wikimedia.org/r/#/c/137891/ ? [15:51:08] MaxSem: ^ [15:51:22] oh, didn't realize you're up already MaxSem [15:52:13] meh, js [15:54:10] (03PS1) 10Dbrant: Fix clickability of "About" titlebar text (properly). [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/137944 [15:54:13] YuviPanda, merged [15:54:37] MaxSem: ty [15:55:51] generally, can't be deployed this week [15:56:03] yeah, probably [15:56:07] monday morning SWAT, I'd think [15:56:13] DarTar: Deskana ^ [15:59:12] Thanks. :) [16:01:41] (03CR) 10Jdlrobson: [C: 032] Fix MobileWebEditing code [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/137891 (owner: 10Ori.livneh) [16:02:17] (03Merged) 10jenkins-bot: Fix MobileWebEditing code [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/137891 (owner: 10Ori.livneh) [16:03:55] Deskana: checking up some stats. ToC has so far been opened about 10,000 times :) only 278 completed edits across all projects, though. 11 captchas shown and only 2 captcha failures. [16:04:16] bearND: I also updated the twn patch [16:04:56] YuviPanda: twn? [16:05:05] bearND: translatewiki.net :) [16:05:28] YuviPanda: ah :) [16:06:21] (03CR) 10Jdlrobson: [C: 032] "There are a few cases where you describe @var above rather than as part of the @var declaration but these can be fixed in a follow up :)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/137739 (https://bugzilla.wikimedia.org/66086) (owner: 10Florianschmidtwelzow) [16:06:51] (03Merged) 10jenkins-bot: Update doc for files in includes/ [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/137739 (https://bugzilla.wikimedia.org/66086) (owner: 10Florianschmidtwelzow) [16:07:14] (03CR) 10Jdlrobson: Update doc for files in includes/ (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/137739 (https://bugzilla.wikimedia.org/66086) (owner: 10Florianschmidtwelzow) [16:10:10] (03CR) 10Jdlrobson: "my -2 no longer applies. will take a look at this on Monday if no one else has. have a good weekend Florian!! :)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/137541 (https://bugzilla.wikimedia.org/66164) (owner: 10Florianschmidtwelzow) [16:11:05] have a nice weekend too Jon! :) [16:11:31] YuviPanda, Deskana: wfm, it’s not particularly urgent, I checked that we’re getting app account registrations from EventLogging so it looks like we’re good [16:12:09] the only open question is whether, once the patch is live, we should clean up the existing records with no rev_id from the various change_tag tables [16:12:27] DarTar: i'd say go for it, no harm caused + consistency [16:12:34] (03CR) 10Florianschmidtwelzow: "You too :)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/137541 (https://bugzilla.wikimedia.org/66164) (owner: 10Florianschmidtwelzow) [16:13:50] YuviPanda: who do you think can help with that? In the past I’ve pull in Reedy to help with DB clean up requests [16:14:22] DarTar: springle and Reedy I'd guess [16:15:27] YuviPanda: kk, drop me a line when the patch is live and I’ll reach out to them. I’m OoO Mon/Tue, back in the office Wed morning [16:15:37] DarTar: ok. [16:15:42] thanks dude [16:15:51] DarTar: \o/ [16:16:46] YuviPanda: btw, I read the review of the app on AndroidPolice, good discussion/initial reaction [16:16:59] DarTar: indeed! mostly very positive! [16:17:07] DarTar: we've been trackign responses from users across places at https://etherpad.wikimedia.org/p/androidappfeedback [16:17:15] DarTar: reddit also has a decent discussion [16:17:57] YuviPanda: that's some impressive design in the Das Referenz app. [16:18:06] dbrant: very, yeah. [16:19:23] YuviPanda: it's in line with some thoughts I've been having on new color schemes... [16:20:03] dbrant: yeah, we'll need to do a fair amount of reformatting, I'd think. [16:20:13] dbrant: inline styles are going to be painful [16:20:57] DarTar: do we have an easy way to measure revert rates? [16:26:12] dbrant: but not an intractable problem, I think. we can even maybe do some color analysis of those and swap them appropriately. [16:26:52] dbrant: bigger problem is goign to be the small i mages (green / red arrows used for stock ups/downs in the financial articles, for example) [16:29:26] YuviPanda: sorry, standup, bbl [16:36:40] prtksxna: :) [16:36:52] vbamba: o/ [16:37:08] Yay! Saw the patch got merged [16:57:42] awjr, so do we have a standup? [16:58:01] 3Wikipedia App / 3Android App: crash with NoClassDefFoundError: support.v7.internal.view.menu.MenuBuilder - 10https://bugzilla.wikimedia.org/66263 (10Bernd Sitzmann) 3NEW p:3Unprio s:3normal a:3None https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom&TicketID=7591596 https://ticket.wiki... [16:58:17] jgonera: yeah! [16:58:24] jgonera: you in the office or at home? [16:58:35] home [16:58:46] I don't see anyone else online [16:59:07] jgonera: kaldari and maryana are here [16:59:12] oh, ok [17:00:10] jgonera: we're in the hangout [17:01:17] coming [17:01:25] (finding earphones) [17:02:13] awjr, I can't see anyone in the hangout [17:02:56] awjr_away, "You're the first one here" [17:04:24] brion: if you have an iPad https://medium.com/@raureif/das-referenz-wikipedia-redesigned-for-ipad-65af999b576d [17:04:45] YuviPanda: i’ll check it out [17:05:00] brion: they seem to be doing some good work with inline style rewriting, from reading. [17:07:19] heh it’s got ads [17:07:35] real purty though [17:07:38] might steal some ideas yes :D [17:08:01] brion: yeah [17:11:55] YuviPanda: If the kill switch is enabled, do the edit pencils disappear? [17:12:07] Deskana: on Android, yes. Unsure of iOS behavior [17:12:13] Deskana: they disappear on Android. [17:12:21] YuviPanda: Great, because if we're removing the CTA to sign in then that's important. [17:12:28] mhurd: Can you confirm iOS behaviour? [17:12:29] Deskana: indeed, I agree. [17:15:32] Deskana: standup! [17:15:46] YuviPanda: Joining already. :) [17:44:41] YuviPanda: would you reply to your email at http://lists.wikimedia.org/pipermail/mobile-l/2014-March/006642.html, with the corrected URL for alpha? So, we don't need to keep explaining that one has to remove the period at the end separately. it was written before I joined the list. [17:53:36] (03CR) 10BearND: [C: 032] Fix clickability of "About" titlebar text (properly). [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/137944 (owner: 10Dbrant) [17:53:56] (03Merged) 10jenkins-bot: Fix clickability of "About" titlebar text (properly). [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/137944 (owner: 10Dbrant) [17:56:11] (03PS4) 10Brion VIBBER: Work in progress (do not merge): EventLogging refactor [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/135885 [17:58:08] (03PS2) 10BearND: Catch more errors when fetching non-lead sections. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/137942 (owner: 10Dbrant) [17:58:30] (03CR) 10BearND: [C: 032] Catch more errors when fetching non-lead sections. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/137942 (owner: 10Dbrant) [17:58:49] (03Merged) 10jenkins-bot: Catch more errors when fetching non-lead sections. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/137942 (owner: 10Dbrant) [17:59:54] (03CR) 10Brion VIBBER: "Added a couple missing funnels, but not in use yet." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/135885 (owner: 10Brion VIBBER) [18:07:08] (03PS1) 10BearND: Refactor onCatch [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/137961 [18:11:39] I'm leaving IRC for a bit to really get my head down on the massive backlog of stuff I've built up to do today. [18:11:49] I'll be on later, and as always, reachable by email. :) [18:12:48] (03CR) 10Dbrant: [C: 032] Refactor onCatch [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/137961 (owner: 10BearND) [18:17:16] (03PS1) 10Cmcmahon: QA: confirm logout succeeds for protect page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/137964 [18:18:57] kaldari jgonera awjr would you mind merging https://gerrit.wikimedia.org/r/#/c/137964? It does no harm, and I'm 99% sure it will fix our single flaky test in the WMF Jenkins local headless build [18:20:48] chrismcmahon, why would we have to manually go to Special:UserLogout after logging out? that seems hacky, doesn't reflect user behavior [18:21:08] (03PS5) 10Brion VIBBER: Work in progress (do not merge): EventLogging refactor [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/135885 [18:23:33] jgonera: right now the test does not assert that logout succeeds. it's navigating to the protected page before the logout operation completes. [18:24:22] jgonera: I didn't write this test, but I have an interest in having it pass [18:24:36] jgonera: I mean, pass properly and not be flaky [18:25:38] bearND|bbl: hehe, I should make a wiki page [18:29:02] jgonera: I'd like to see that whole "page is protected" step unpacked and made more explicit, but I'd like to see the test pass in the WMF Jenkins build first. [18:30:34] (03CR) 10Brion VIBBER: "Still to do:" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/135885 (owner: 10Brion VIBBER) [18:35:17] tfinc: 2 reviews down, 2 to go… [18:35:25] mhurd: excellent [18:35:54] chrismcmahon, wouldn't it be possible to modify 'I click on "Log out" in the main navigation menu' in such way that it waits for a page reload? [18:37:15] jgonera: no, because the step is "I click on "(.+)" in the main navigation menu". arguably the MF repo should have an "I log out" step but it does not. [18:39:37] brion: moving us to Mon unless you think you'll have time at the VP9 summit [18:39:49] tfinc: monday’s fine [18:43:49] (03CR) 10MaxSem: [C: 04-1] "See inline comments. Also, lacks tests." (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/137836 (https://bugzilla.wikimedia.org/60478) (owner: 10Jdlrobson) [18:47:11] Maryana, https://office.wikimedia.org/wiki/WMF_FY_2013-14_Annual_Review_and_Retrospective#Friday.2C_June_6:_Co-Worker_Feedback_due says this is due today not Tuesday... [18:47:30] jgonera: erik moeller got them to extend it [18:47:33] via email [18:47:39] you're fine [18:47:59] oh, I see [18:50:21] Maryana: +1 for not setting concrete app goals without enough data :) [18:50:59] heh [18:53:09] (03PS1) 10Yurik: Updated to match JsonConfig validation change [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/137975 [18:53:24] dr0ptp4kt, around? [18:53:50] yurikR: yes [18:54:06] dr0ptp4kt, could you +2 the 3 patches pls [18:54:15] 2 in JsonConfig, 1 in ZeroBanner [18:54:48] yurikR, urls? or are there 'only' those three across those extensions? [18:55:01] dr0ptp4kt, leave the "new validated obj" to the last, its the most complex [18:55:08] dr0ptp4kt, https://gerrit.wikimedia.org/r/#/c/137973/ [18:55:17] followed by https://gerrit.wikimedia.org/r/#/c/137975/ [18:55:23] and last - https://gerrit.wikimedia.org/r/#/c/137972/ [18:56:15] yurikR: thank you! i'll review them [19:04:14] jgonera: did you figure out which table you want me to order ? [19:04:27] tfinc, no, haven't got to that yet [19:06:58] (03CR) 10Dr0ptp4kt: [C: 032] "Same concerns apply on getting the abstract class vs interface thing resolved." [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/137975 (owner: 10Yurik) [19:25:48] Deskana|Away: i put some stuff down here for apps: https://www.mediawiki.org/wiki/Wikimedia_Engineering/2014-15_Goals#Mobile -- feel free to add/modify as needed [20:13:00] (03PS1) 10Kaldari: Promoting mobile VisualEditor from alpha to beta [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/138019 [20:14:59] 3Wikipedia App / 3Android App: crash with NoClassDefFoundError: support.v7.internal.view.menu.MenuBuilder - 10https://bugzilla.wikimedia.org/66263#c1 (10Dmitry Brant) This seems to be a problem in a specific subset of devices (Samsung) with 4.2.2 installed. http://developer.samsung.com/forum/thread/androids... [20:16:43] (03CR) 10Awjrichards: [C: 032] QA: confirm logout succeeds for protect page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/137964 (owner: 10Cmcmahon) [20:17:47] (03Merged) 10jenkins-bot: QA: confirm logout succeeds for protect page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/137964 (owner: 10Cmcmahon) [20:21:48] thanks awjr [20:21:53] :) [20:24:22] (03PS1) 10Yuvipanda: Don't crash when blocked editors attempt to edit [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/138020 (https://bugzilla.wikimedia.org/66235) [20:24:43] dbrant: bearND ^ [20:24:58] dbrant: bearND I've admin on testwiki, so can block your IP from editing for 2h if you want :) [20:27:42] YuviPanda: ok, i'll pm you my ip [20:27:47] bearND: cool [20:28:32] bearND, your IP doesn't look very zomgsecret:P [20:28:56] dr0ptp4kt, any objections for me to quickly +2 https://gerrit.wikimedia.org/r/#/c/138021/ [20:29:06] debugging betalabs is always fun :) [20:30:38] (03CR) 10JGonera: [C: 032] Notification bell tweaks [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/137361 (owner: 10Jdlrobson) [20:31:12] (03Merged) 10jenkins-bot: Notification bell tweaks [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/137361 (owner: 10Jdlrobson) [20:32:14] yurikR: it is probably better than debugging in prod :] [20:32:46] tfinc, so who exactly is my core team (reviews)? Maryana, awjr, Jon, kaldari and MaxSem? [20:32:59] and arthur [20:33:07] jgonera: you get to choose 3-5 [20:33:17] their the peers that you work with day to day [20:33:19] hashar, hehe, i just wish it was more ... exactly just like prod ;) Btw, bblack said that puppets on beta is out of whack, and that's why some of his stuff not working theer [20:33:22] awjr=arthur [20:33:26] you could even include the designers that you work with as well [20:33:40] tfinc, oh, I didn't know that [20:33:59] awjr, so I can only review 3 people from my core team? [20:34:09] 3-5 jgonera [20:34:20] i was confused about this too; anna stillwell confirmed this for me this morning [20:34:25] ok, that means that I can skip 3? [20:34:27] 2 [20:34:34] hm [20:34:56] that's kinda weird, what is someone is skipped by everyone? [20:35:10] yurikR: beta uses a local puppetmaster on deployment-salt.eqiad.wmflabs so the changes merged in Gerrit needs to be applied on the puppetmaster instance :D [20:35:18] yurikR: I will tell him [20:35:27] thx :) [20:39:00] YuviPanda: which site have you blocked for me? en or test? [20:39:09] (03PS6) 10JGonera: Move notifications drawer to stable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/137481 [20:39:13] jgonera: sorry got disconnected - it depends on how you account ;) i think you're supposed to include your manager in there too [20:39:14] s/account/count [20:39:49] awjr, then it's 6 people, what if everyone chooses to review 3 people and nobody chooses to review you? [20:40:17] jgonera: i count 9 - 4 engineers, 3 designers, myself, tomasz [20:40:26] but yes, that seems like a potential problem [20:40:45] jgonera: make that 10 with maryana [20:41:04] ok, designers too, although it's too late for me because I asked that before to someone and have been told they're not my core team so I nominated moiz for feedback [20:41:21] (03CR) 10MaxSem: [C: 04-1] Make `make message` work again. (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/137832 (https://bugzilla.wikimedia.org/63019) (owner: 10Jdlrobson) [20:41:37] jgonera: aye; i think it wasn't totally clear [20:41:50] YuviPanda: https://gerrit.wikimedia.org/r/#/c/137941/ [20:42:14] (03CR) 10JGonera: [C: 032] "Rebased again and moved one CSS rule to a different file. +2 following Jon's review." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/137481 (owner: 10JGonera) [20:42:47] (03Merged) 10jenkins-bot: Move notifications drawer to stable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/137481 (owner: 10JGonera) [20:46:59] (03PS1) 10MaxSem: Hygiene: remove old b/c code that was there since October [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/138029 [20:47:55] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: remove old b/c code that was there since October [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/138029 (owner: 10MaxSem) [20:54:33] (03PS2) 10Yuvipanda: Bump version number for 2.0-alpha-2014-06-06 [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/137941 (owner: 10Dbrant) [20:54:40] dbrant: oh yeah. you already made the release, though. right? [20:54:46] (03CR) 10Yuvipanda: [C: 032] Bump version number for 2.0-alpha-2014-06-06 [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/137941 (owner: 10Dbrant) [20:54:51] YuviPanda: right, that was from this morning [20:55:07] (03Merged) 10jenkins-bot: Bump version number for 2.0-alpha-2014-06-06 [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/137941 (owner: 10Dbrant) [21:03:27] awjr: pretty neato: https://integration.wikimedia.org/ci/view/BrowserTests/job/browsertests-MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-firefox/77/ [21:03:42] (03PS2) 10MaxSem: Hygiene: remove old b/c code that was there since October [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/138029 [21:04:10] (03CR) 10JGonera: [C: 032] "There are still issue with thumbnails not being aligned left/right in VE even if they are when viewing a page, but we can fix it in a sepa" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/138019 (owner: 10Kaldari) [21:04:41] jgonera: I'm working on that problem right now [21:04:49] kaldari, awesome [21:04:59] jgonera: the problem lies in VE and core though, not in MobileFrontend [21:05:05] I see [21:06:11] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: remove old b/c code that was there since October [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/138029 (owner: 10MaxSem) [21:07:07] (03CR) 10JGonera: [C: 032] Show loader when switching between editors [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/137731 (https://bugzilla.wikimedia.org/65506) (owner: 10Jdlrobson) [21:09:47] dbrant: YuviPanda: in the future we should merge the bump commit right after the apk is published, so we can better see in the git log what fix is in the store. [21:09:55] (03PS3) 10MaxSem: Hygiene: remove old b/c code that was there since October [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/138029 [21:10:13] YuviPanda: have you blocked my ip? and if so, which site? [21:10:29] (03CR) 10JGonera: [C: 04-1] "Brings back a bug in watchlist where bottom part of characters such as "g" or "y" is cut off." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/136501 (owner: 10Jdlrobson) [21:10:58] yurik yurikR2 i started reviewing the patch, got lunch, and was just talking with dan on various things. getting back to code review now [21:11:41] (03CR) 10JGonera: [C: 032] Make search icon render okay on stable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/137817 (owner: 10Jdlrobson) [21:12:01] yay! green tests chrismcmahon [21:13:49] dr0ptp4kt, thx, just poke at the object one, see if you can make heads from tails... it is kinda hairy function :) [21:14:55] Deskana|Away: hey if you see any wierdness with the stying, doubled-up section titles etc, try deleting the app and reinstalling. moiz and vibha had this happen. [21:15:31] awjr: green tests in WMF Jenkins with headless Firefox on the local host no less [21:15:42] \o/ [21:49:50] jgonera: kaldari MaxSem tfinc i'm going to be leaving for the airport in ~10 mins; need anything from me before monday? [21:49:54] Maryana: ^ [21:49:59] awjr: i'm good. have a safe flight [21:50:08] i'm boat [21:50:12] i mean good :) [21:50:18] tehe [21:50:21] safe travels, awjr! good to see you [21:50:39] awjr: nope, have a good trip [21:51:17] awjr: take care [21:54:24] :D [21:57:00] yurikR2: so i did my first read through JCObjContent.php. i'm gonna re-read, actually perusing the other classes as well. i have a few superficial questions, which i just added to the patchset. [21:57:33] yurikR2: changing connections, gonna drop momentarily [21:58:17] dr0ptp4kt, ok [21:58:21] ok im out, hasta pronto! [21:58:23] * awjr waves [22:00:42] (03PS1) 10MaxSem: Log whether users getting token errors are logged in or not [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/138099 [22:07:01] (03CR) 10CSteipp: [C: 031] Log whether users getting token errors are logged in or not [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/138099 (owner: 10MaxSem) [22:14:52] Deskana|Away: you about ? [22:15:15] Deskana|Away: mhurd and i were looking for you to make sure that you've been able to test the iOS build [22:27:01] is there a list of media size breakpoints that we're targeting? [22:27:05] that i can obtain? [22:29:27] jorm: like for images, or general screen sizes? [22:29:35] general screen sizes. [22:29:44] i'm looking to add responsive shit to the winter prototype. [22:29:52] well your typical phones are going to be something on the order of [22:29:59] 320x480 (classic iphone and similar) [22:30:27] 320x532 (new iphone, some smaller androids) [22:30:46] 360x640ish (slightly larger phones) [22:30:55] that’s in CSS pixels / points / whatever you call em [22:31:27] tablets tend to be around 1024x768 (iPad-like) or 1280x800, sometimes circa 1024x600ish for smaller androids [22:31:40] i think that should cover most mobile stuff [22:32:29] groovy. [22:32:31] and of course all of those could be portrait or landscape [22:32:56] jorm: if you’re using firefox, the dev tools have a ‘responsive mode’ which lets you set the web page’s screen size within your window, it’s very handy [22:33:00] chrome may have a similar i’m not sure [22:35:02] jorm: whoops that’s 320x568 for new iphone [22:37:29] groovypants. [23:09:15] cya [23:11:00] brion: jorm from MobileFrontend.php wgMFDeviceWidthTablet = 768; $wgMFDeviceWidthMobileSmall = 280; if that's helpful. (also, Chrome seems to struggle to calculate around these boundaries) [23:12:53] also useful! [23:21:34] (03PS1) 10Kaldari: Make sure images are properly aligned in Mobile VisualEditor [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/138106 (https://bugzilla.wikimedia.org/66282) [23:28:36] (03PS1) 10Kaldari: Make sure images are properly formatted in mobile VisualEditor [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/138107 [23:29:14] (03PS2) 10Kaldari: Make sure images are properly aligned in Mobile VisualEditor [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/138106 (https://bugzilla.wikimedia.org/66282) [23:31:27] bearND, dbrant|bbl, YuviPanda|zzz: It looks like the main page is broken on the Android app. :/ [23:33:14] Deskana: works for me. what are you seeing? [23:34:09] bearND: Let me take a screenshot. [23:35:20] bearND: http://i.imgur.com/uZoK7mR.png [23:36:43] Deskana: looks like a styling issue [23:37:08] Hmm, it seems these are cropping up more and more. [23:37:33] Deskana: which version are you running? [23:37:45] 2.0-alpha-2014-06-06 [23:39:00] bearND: Changing my language to Dutch, pressing back (so it took me to the Dutch main page), then changing back to English has solved the problem. [23:49:06] Deskana: can you file a bug for this? i think the css caching code needs more fault tolerance. am a bit surprised that this happened because i thought that the styles wouldn't be downloaded until the 17th. But IIRC YuviPanda|zzz said that there might be different handling for the main page. [23:51:22] Deskana: I don't get the Welcome to Wikipedia part. That's only on Desktop, not on mobileview [23:52:31] Oh, strange. [23:52:50] OH! [23:52:52] I can replicate it. [23:53:00] Search for: main page [23:53:02] All lower case. [23:53:21] * Deskana files a bug. [23:54:24] Deskana: i see it now, too. yeah, that's not styling related. [23:55:01] Deskana: only does it when opening the lower case "main page" [23:55:37] bearND: [[Main page]] redirects to [[Main Page]] which I bet is what caused this [23:57:16] 3Wikipedia App / 3Android App: Android: Searching for "main page" and pressing go gives you a weird desktop-hybrid page - 10https://bugzilla.wikimedia.org/66294 (10Dan Garry) 3NEW p:3Unprio s:3normal a:3None Created attachment 15588 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15588&action=... [23:57:37] There we go [23:57:47] Off to the shops! Back later. [23:57:55] Deskana: later