[00:09:37] ragesoss: agreed. file a bug maybe? [00:16:34] K. Will do when I get a chance. [00:19:22] ragesoss: ty [01:09:57] (03PS1) 10Florianschmidtwelzow: Hygiene: Update/Create doc for php in diff and modules [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/138289 (https://bugzilla.wikimedia.org/66086) [01:10:29] 3MobileFrontend / 3Hygiene: make phpdoc shows errors in our PHP documentation - 10https://bugzilla.wikimedia.org/66086 (10Florian) 5PATC>3ASSI [07:25:15] 3MobileFrontend / 3Feature requests: Enable customization of footer - 10https://bugzilla.wikimedia.org/66350 (10Florian) [13:20:37] (03PS1) 10Dbrant: Correctly set email subject when sharing page. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/138334 [13:49:18] (03CR) 10Dbrant: [C: 032] Don't crash when blocked editors attempt to edit [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/138020 (https://bugzilla.wikimedia.org/66235) (owner: 10Yuvipanda) [13:52:48] (03PS2) 10Dbrant: [WIP - test only] Implement syntax highlighting in Edit window. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/137684 [14:22:03] * YuviPanda waves at dbrant and bearND [14:22:42] * bearND waves at YuviPanda and dbrant [14:23:06] dbrant: bearND I'm going to be flying out tomorrow, so will be fully out tomorrow and on and off today [14:25:02] YuviPanda: no problem; safe travels [14:25:07] dbrant: :) [14:25:34] YuviPanda: safe travels [14:25:55] (03PS1) 10Yuvipanda: Also handle global IP blocks [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/138341 [14:26:47] (03PS1) 10BearND: Honor system font size setting in WebView [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/138342 [14:28:15] 3Wikipedia App / 3Android App: Main page no longer appears editable - 10https://bugzilla.wikimedia.org/66298#c1 (10Yuvi Panda) 5NEW>3RESO/FIX WONTFIX, since Main Page goes through HTML transformations in MobileView, and the sections you see aren't the sections that actually exist. [15:12:45] dbrant: bearND feel free to do a release every day today and tomorrow. [15:13:23] dbrant: bearND we should also do a pass to make sure that all SaneAsyncTask subclasses have an onCatch that deals with things appropriately [15:13:32] 3MobileFrontend / 3beta: Make all buttons the same style - 10https://bugzilla.wikimedia.org/66373 (10Florian) 3NEW p:3Unprio s:3normal a:3None Created attachment 15601 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15601&action=edit Buttons in beta mode Like you see on the pictures (example... [15:13:58] YuviPanda: sure. [15:13:59] 3MobileFrontend / 3beta: Make all buttons the same style - 10https://bugzilla.wikimedia.org/66373#c1 (10Florian) Created attachment 15602 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15602&action=edit Buttons in stable mode [15:14:00] YuviPanda: yes, we should do a release today to roll in the crash fixes from Fri. [15:14:11] dbrant: yeah, agreed. [15:15:29] 3MobileFrontend / 3beta: Make all buttons the same style - 10https://bugzilla.wikimedia.org/66373#c2 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/nBpgfa0L [15:17:36] YuviPanda: any way to test your global blocking patch? [15:18:40] dbrant: need to find someone to globally block us. [15:18:43] * YuviPanda pokes James_F [15:18:54] James_F: can you globally block an IP for a while? we need to test an android app [15:19:01] dbrant: I don't have rights to globally block [15:19:50] YuviPanda: Eurgh. I /can/ but I shouldn't. [15:20:10] YuviPanda: Can't you point it at a test instance? That's what we do for other things. [15:20:44] James_F: we don't really have a test instance that is configured with all that, do we? we do have beta labs but it's kinda hard to swap it around. [15:21:05] YuviPanda: For VE we run local test instances for this purpose. [15:21:09] James_F: if policy restrictions are such that you can't block for testing, I can figure a way to get it on betalabs, but hopefully that won't have to happen... [15:21:18] James_F: yeah, but global blocking requires CA and a farm... [15:21:35] YuviPanda: It's not that hard to setup; I believe the Vagrant role covers it. [15:22:07] YuviPanda: I believe policy is that I shouldn't use my high-end production tools to testing unless it's critically-urgent, sorry. [15:22:13] James_F: ok, good to know. [15:22:26] James_F: I'll point it at betalabs and find someone with rights there. [15:22:33] YuviPanda: Kk. [15:22:36] James_F: can you tell me what rights are required to do a global block? [15:22:42] James_F: b'crat? or steward? [15:23:20] YuviPanda: Steward [15:23:24] James_F: cool [15:24:07] dbrant: we need to configure the app to hit en.wikipedia.beta.wmflabs.org and then find someone with steward rights on beta cluster. Need to wait for chrismcmahonbrb [15:24:43] oops [15:24:53] hi YuviPanda [15:24:59] hey chrismcmahon [15:25:09] chrismcmahon: can you give dbrant, bearND and me steward rights on betalabs? [15:25:24] YuviPanda: I think so, one moment... [15:25:31] YuviPanda: I suppose we can just merge the change, and defer "testing" to a later time, since the change is quite straightforward? [15:25:46] dbrant: that's a possibility too, yeah. but having steward accounts on betalabs seems good anyway [15:27:28] dbrant: bearND can you create accounts on betalabs and pm them to chrismcmahon? [15:27:44] dbrant: bearND betalabs is our 'staging' environment that runs all of production code in a very similar setup but is for testing [15:28:28] YuviPanda: user "Yuvipanda" on beta labs is now a steward [15:28:34] chrismcmahon: cool! [15:29:06] captcha when creating account: "dickslame" [15:29:12] dbrant: hahaha! :D [15:29:17] YuviPanda: anything else I can help you with? [15:29:36] chrismcmahon: would be nice to get dbrant and bearND steward accounts too [15:29:59] YuviPanda: as a steward I think you can do that now, yes? [15:30:05] chrismcmahon: ah, didn't realize. cool then :) [15:30:08] chrismcmahon: thank you! [15:30:15] YuviPanda: if that doesn't work let me know [15:30:32] chrismcmahon: ty! [16:02:59] dbrant: bearND 36k users had the android beta as of 7th june. This one is going to reach much farther than we thought! :D [16:03:11] YuviPanda: yes!! [16:03:28] YuviPanda: :) [16:04:25] dbrant: feel free to CR / merge the globalblocking patch. I got the message from an OTRS ticket [16:05:25] dbrant: bearND only 491 edits so far, though. [16:05:40] 415 not counting testwiki [16:05:56] dbrant: bearND we have funnel data, so we can see how many people don't make it [16:06:13] (03CR) 10Dbrant: [C: 032] Also handle global IP blocks [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/138341 (owner: 10Yuvipanda) [16:06:16] 3MobileFrontend / 3stable: Upload icon for anon no longer appears - 10https://bugzilla.wikimedia.org/66375 (10Chris McMahon) 3NEW p:3Unprio s:3normal a:3None As anonymous user at http://en.m.wikipedia.beta.wmflabs.org Click Random, get result e.g. http://en.m.wikipedia.beta.wmflabs.org/wiki/0.464670... [16:06:18] dbrant: bearND FUCK. 3268 edits started, but only 415 completed [16:06:25] that's a terrible rate. [16:06:55] YuviPanda: you think it has to do with the confusion regarding preview? [16:07:05] dbrant: yeah. a design is forthcoming for this sprint [16:08:26] YuviPanda: dbrant: looks like this is really needed. could also be a few who just wanted to see what the edit button does [16:08:58] bearND: dbrant true, but 804 made it to the preview step, so we lost about 50% of users at that point [16:09:59] 3MobileFrontend / 3stable: Upload icon for anon no longer appears - 10https://bugzilla.wikimedia.org/66375#c1 (10Chris McMahon) Also missing for logged-in new user: $ bundle exec cucumber features/uploads_lead_tutorial.feature:8 @chrome @en.m.wikipedia.beta.wmflabs.org @firefox @login @test2.m.wikipedia.or... [16:10:20] dbrant: bearND there's one patch from bearND, I believe. feel free to do a release right after [16:10:29] 3MobileFrontend / 3stable: Upload icon for anon no longer appears - 10https://bugzilla.wikimedia.org/66375#c2 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/yXevl4lK [16:11:05] YuviPanda: where can I access those statistics, again? [16:11:27] bearND: dbrant stat1003. https://wikitech.wikimedia.org/wiki/Stat1003 [16:11:47] bearND: dbrant hmm, that doesn't actually tell you how to get on it. [16:12:01] bearND: dbrant usually, ssh -A bast1001.wikimedia.org, then ssh stat1003 [16:12:19] bearND: dbrant more help in #wikimedia-analytics, and I can walk you guys through later as well [16:17:01] (03CR) 10Dbrant: [C: 032] "Good catch!" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/138342 (owner: 10BearND) [16:17:58] YuviPanda: bearND: I'll do a release now [16:18:04] dbrant: woot! :) [16:18:20] cool [16:18:22] YuviPanda: how to get into http://bast1001.wikimedia.org/? i.e. where to upload my public key? [16:20:24] bearND: dbrant ah, we have to set you up with one via RT. [16:20:27] bearND: and it takes 3 days [16:21:41] bearND: https://wikitech.wikimedia.org/wiki/Requesting_shell_access has instructions [16:21:45] bearND: cc tomasz too [16:22:08] YuviPanda: thank you [16:23:03] YuviPanda: do you think i should request it? [16:23:09] bearND: absolutely, yeah :) [16:23:17] YuviPanda: ok [16:25:41] dbrant: bearND am going to step away for a few hours. Will be sporadiocally available today and tomorrow. [16:25:53] YuviPanda: ok; later! [16:26:02] YuviPanda: one sec [16:26:05] bearND: sure [16:26:18] YuviPanda: i've been thinking about the ampersand issue [16:26:28] dbrant: bearND feel free to pick up the saved pages cards, but let's not merge them for a few days at least (so we can make interim builds easily) [16:26:44] YuviPanda: the java api currently encodes the whole query string as a whole [16:27:00] 3MobileFrontend / 3stable: Filter for New User uploads in Mobile Web - 10https://bugzilla.wikimedia.org/62598 (10Florian) [16:27:01] 3MobileFrontend / 3stable: Upload icon for anon no longer appears - 10https://bugzilla.wikimedia.org/66375#c3 (10Florian) Caused by change https://gerrit.wikimedia.org/r/#/c/137461/ Which restricts the visibility of upload button to autoconfirmed users. If i'm right in context to https://bugzilla.wikimedia.o... [16:27:07] (03PS1) 10Dbrant: Bump version number for 2.0-alpha-2014-06-09 [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/138353 [16:27:12] bearND: oh? [16:27:27] YuviPanda: i'd like to turn it off, since it leads to double encoding if i already have the page param encoded [16:27:38] bearND: hmm, but why are we already encoding the page param? [16:28:04] YuviPanda: if i don't encode the page param then it can't encode the & since that's used for delimiting single query params [16:28:11] (03PS14) 10Dbrant: Move everything to beta package [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/137311 (owner: 10Yuvipanda) [16:28:32] bearND: aaah, hmm. That might also be abug in either mwampi-java or the Http request library we are using, and if so should be fixed at that level [16:28:55] YuviPanda: the current code doesn't encode the page param; but i think that's the only way to get & working [16:29:14] YuviPanda: yes, was going to propose to change the java api. [16:29:35] bearND: no, & is a completely valid thing in any get param request, and we should fix it at the source than at the top layer. something is double encoding &s, and we need to find that and fix it [16:29:40] YuviPanda: we can just turn it off with the third and last paramater to get() [16:29:54] YuviPanda: but i don't know who else is using this api [16:30:12] YuviPanda: is it just us? it's a change that break backwards compatibility [16:30:13] bearND: ah, hmm. I'm still wary, since this looks like a bug in either HttpRequest or java-mwapi, and we should fix that at the source. nobody's using java-mwapi atm, but lots of people do use the Http library [16:30:29] bearND: need not be, since we can make it default to encode and have it as an overload. [16:31:23] YuviPanda: the change is in Api.setupRequest [16:31:23] bearND: but I really have to go now. I think we can let it rest in the to-do column for a bit more and come back to it in a while, since it seems to involve multiple layers [16:31:42] YuviPanda: ok, will chat with you about this another time. thanks [16:31:47] bearND: cool! [16:32:05] Hmm. My bouncer appears to be misbehaving. [16:32:37] bearND: at this point I'd think the preview changes and saved pages take priority, I think. Since they are pretty much new features and we should try to get them out on alpha / beta at least for a few days [16:32:39] * YuviPanda waves at Deskana [16:32:49] Hey. :) [16:32:50] Deskana: emailed you some numbers (we also discussed those on IRC). [16:33:01] YuviPanda: I replied to you. :) [16:33:18] Basically, before we panic about bleeding people, let's figure out what our control group is so that we know how well we're actually doing. [16:33:38] * Deskana spent a few hours last night doing corrections to his Master's thesis, so is feeling particularly scientific. [16:33:50] Deskana: :D wasn't panicking, that email started out as a 'can you poke the designers for the design' and then I got distracted by numbers [16:34:11] YuviPanda: That first bit got lost in noise. :P [16:34:20] * Deskana looks on Trello. [16:34:29] Deskana: yeah, that :) [16:34:55] Deskana: don't think we have the numbers for desktop, but StevenW might know (or someone from growth) [16:39:25] Deskana: re: setting you up with getting those numbers yourself, we can either 1. have you sit down with me (or Maryana!) one day and walk you through the SQL process or, 2. build a dashboard like mobile-reportcard.wmflabs.org [16:39:41] I'd fucking love a dashboard. [16:39:45] That makes the data even more accessible. [16:40:03] I actually did chat to Maryana about getting access to stat1 but I'd left my SSH key on my previous laptop. [16:40:17] Deskana: indeed, and I would too. Have talked a fair bit to analytics about building one (I built -reportcard too), so it would be something I'd love to take on after release. [16:41:32] Deskana: re: keys, ideal practice is to never transfer private keys from the machine they are generated. Just generate a new one for your new machine :) [16:51:28] YuviPanda: I'll do that then. [16:51:56] ...later. [17:01:32] jgonera: standup [17:01:46] awjr, I know I know, trying to untangle my earphones [17:19:11] jgonera: so instead of doing $.extend how about we just create an object which references the functions we care about [17:19:12] e.g. isAnon: mw.user.isAnon [17:19:59] 3MobileFrontend / 3stable: Upload icon for anon no longer appears - 10https://bugzilla.wikimedia.org/66375#c4 (10Jon) This is by design. See https://trello.com/c/jHKLcZ0j/7-5-only-allow-uploads-by-auto-confirmed-users I'll clean up the tests now. [17:20:17] 3MobileFrontend / 3stable: Upload icon for anon no longer appears - 10https://bugzilla.wikimedia.org/66375 (10Jon) 5NEW>3RESO/INV [17:21:41] YuviPanda: bug confirmation request: [17:21:56] can you have a look at https://bugzilla.wikimedia.org/show_bug.cgi?id=66321 ? I'm afraid any template change would flush it away [17:23:18] jdlrobson, I think that's fine [17:23:26] jgonera: cool 'll update the bug :) [17:23:31] thanks! [17:24:45] 3MobileFrontend / 3stable: Deprecation warnings in JS console - 10https://bugzilla.wikimedia.org/65643#c10 (10Jon) 5RESO/WON>3REOP Okay after talking to Juliusz we decided we should do some sort of shallow clone without using extend e.g M.define( 'user', { getName: mw.user.getName, isAnon: mw.user.is... [17:28:59] 3Wikipedia App / 3Android App: Android: ToC button should not just disappear when an article has no sections - 10https://bugzilla.wikimedia.org/66296#c2 (10Dan Garry) (In reply to Sage Ross from comment #1) > For some longish articles or atypically formatted ones, a link back to the > top may be useful even... [17:33:59] bearND: So, tell me if you agree with the following: [17:34:37] bearND: The two cards "renaming 'bookmarks' to saved pages" and "save page content to the file system" can really be combined into a single patch... [17:34:54] bearND: ...and then the "save images" card can be dependent on the former. [17:36:44] for some reason android trunk is showing me GIANT TEXT [17:37:02] "Skipping task style-fetcher" [17:37:06] “Using packaged styles” [17:38:16] brion: i added patch earlier today that adjusts the webViews text size based on the system settings under settings, Display, Font Size. Can you check the settings you have there? [17:38:35] bearND: “Normal" [17:38:43] Android 4.4.3 KitKat Nexus 5 (xxdpi) [17:40:29] brion: ok, normal should show up as the same size as before my change. [17:41:25] 06-09 10:41:15.523 11185-11185/org.wikipedia D/Wikipedia﹕ fontSize is: 24.0 [17:41:30] interesting [17:41:32] 3MobileFrontend / 3stable: last edited note incorrect on timedText namespace page - 10https://bugzilla.wikimedia.org/66384 (10Bawolff (Brian Wolff)) 3NEW p:3Unprio s:3normal a:3None Created attachment 15605 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15605&action=edit screenie of timedtext... [17:41:42] bearND: if i log the result of getResources().getDimension(R.dimen.textSize) i’m getting 24 [17:41:48] the default font size is supposed to be 16 supposedly [17:42:03] according to http://developer.android.com/reference/android/webkit/WebSettings.html#setDefaultFontSize%28int%29 [17:42:29] so 24 seems to be 8sp at xxhdpi (3x pixel ratio)? [17:42:40] and then that’s interpreted as 24 CSS pixels I think [17:42:48] which is muhc larger than expected [17:42:57] brion: on my nexus 4 i got font size of 16 [17:43:14] right, on nexus 4 with a 2x ratio you’d get 16 instead of 24 [17:43:24] 8 * 2 = 16 [17:43:26] 8 * 3 = 24 [17:43:40] dr0ptp4kt, thx, i will submit another big patch in half an hour. Some refatoring of jsonconfig [17:44:30] (03CR) 10Brion VIBBER: "This seems to be broken; on Nexus 5 (xxhdpi) I get 24-point HUGE TEXT. It seems to be reading the raw pixel size of 8sp as 24 raw pixels a" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/138342 (owner: 10BearND) [17:45:29] 3MobileFrontend / 3stable: last edited note incorrect on timedText namespace page - 10https://bugzilla.wikimedia.org/66384#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/1v45vQrr [17:45:35] brion: i'm ok to revert that change, bummer that we just did a release with that :( [17:46:05] expect some complaints from nexus 5 and galaxy s4/s5 owners :D [17:46:31] (03PS1) 10BearND: Revert "Honor system font size setting in WebView" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/138372 [17:47:03] (03PS1) 10Brion VIBBER: Revert "Honor system font size setting in WebView" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/138373 [17:47:07] heh whoops [17:47:16] (03Abandoned) 10Brion VIBBER: Revert "Honor system font size setting in WebView" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/138373 (owner: 10Brion VIBBER) [17:47:27] brion: sorry [17:47:32] no worries :D [17:47:52] bearND: brion: I'll crunch out a release [17:48:03] dbrant: thank you [17:48:08] mhurd: Shall we sign off on that story tomorrow when I'm in the office? [17:48:13] (03CR) 10Dbrant: [C: 032] Revert "Honor system font size setting in WebView" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/138372 (owner: 10BearND) [17:48:16] (03CR) 10Brion VIBBER: "Confirm this fixes font size on Nexus 5 (xxhdpi), which was accidentally huge from the previous patch." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/138372 (owner: 10BearND) [17:48:25] mhurd: I've still got tons of stuff on my own personal backlog which I'm trying to get done today. [17:48:54] Deskana: if that’s ok maybe it would be for the best as it gives brion and i a bit of time to track down those small inconsistancies which remain [17:49:06] mhurd: Let's do that then. :) [17:49:13] Deskana: sounds good [17:49:37] (03CR) 10Jdlrobson: "Uploading in mobile is dependent on JavaScript. It seems that this breaks some browser tests. I am working on a follow up patch that takes" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/137462 (owner: 10Jdlrobson) [17:50:14] brion: i think if we try this again we should have a specific dimens.xml file for the different densities [17:51:19] bearND: my main worry there is if they introduce another density we don’t know yet it’ll break. ;) we should be able to query for the right value from the system [17:51:32] of course if they introduce another density that’s only because someone is INSANE manufacturing hardware ;) [17:52:06] brion: agreed [17:53:09] (03PS2) 10Dbrant: Bump version number for 2.0-alpha-2014-06-09 [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/138353 [17:53:27] yurikR: ok, once review needed please add me to patchsets and hit me up here or on email with the urls [17:54:25] (03CR) 10MaxSem: [C: 04-1] "Thanks! I have some inline comments." (036 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/138289 (https://bugzilla.wikimedia.org/66086) (owner: 10Florianschmidtwelzow) [17:55:00] dbrant: YuviPanda brion: can we create branches in gerrit? i was thinking that we might want to have on for saved pages [17:55:54] bearND: yes though i forget offhand the way to do it :D [17:56:39] (03PS2) 10Jdlrobson: Don't show photo upload icon when no action is possible [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/137462 [17:56:41] (03PS1) 10Jdlrobson: QA: Fix failing builds [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/138375 [17:56:43] (03PS1) 10Jdlrobson: Hygiene: Remove dead code path [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/138376 [17:57:25] (03CR) 10jenkins-bot: [V: 04-1] Don't show photo upload icon when no action is possible [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/137462 (owner: 10Jdlrobson) [17:58:04] (03PS15) 10Dbrant: Move everything to beta package [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/137311 (owner: 10Yuvipanda) [18:01:55] (03CR) 10MaxSem: [C: 04-1] "What if local uploads are disabled but MF is configured to upload to a shared repository?" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/137541 (https://bugzilla.wikimedia.org/66164) (owner: 10Florianschmidtwelzow) [18:02:10] (03PS1) 10Kaldari: Updating mobile VisualEditor browser test - alpha->beta [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/138378 [18:04:15] (03CR) 10Florianschmidtwelzow: Hygiene: Update/Create doc for php in diff and modules (036 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/138289 (https://bugzilla.wikimedia.org/66086) (owner: 10Florianschmidtwelzow) [18:05:34] dbrant: If we can have a branch for saved pages then it really doesn't matter if we combine the two cards into a single patch. i'm concerned that pushing out half-baked saved pages feature it could cause some inconsistency while it's not completed. some users might have images included, others not. [18:06:47] (03PS6) 10Brion VIBBER: Work in progress (do not merge): EventLogging refactor [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/135885 [18:06:52] dbrant|lunch: YuviPanda: brion: in leu of a real branch we could also just add everything saved pages related to a single WIP patch, like we do for beta; and merge once it's all done [18:07:22] heh yeah [18:07:38] mhurd: let’s teeest [18:07:45] (03PS3) 10Jdlrobson: Don't show photo upload icon when no action is possible [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/137462 [18:07:49] (03PS2) 10Jdlrobson: QA: Fix failing builds [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/138375 [18:07:55] (03PS2) 10Jdlrobson: Hygiene: Remove dead code path [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/138376 [18:08:03] (03PS4) 10Jdlrobson: Don't show photo upload icon when no action is possible [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/137462 [18:10:20] jgonera: kaldari MaxSem can we sort out this site notice crap - it's been sitting around for over a week now - basically we have 2 approaches 1) use a global to turn them on or off and turn them off on wikimedia servers 2) Namespace them so people can have separate site notices for mobile and desktop (MaxSem can explain more) [18:10:34] 2nd requires a core change, 1 a MobileFrontend change [18:11:27] (03PS2) 10Florianschmidtwelzow: Hygiene: Update/Create doc for php in diff and modules [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/138289 (https://bugzilla.wikimedia.org/66086) [18:12:05] (03PS2) 10Jdlrobson: MobileOptions: Log authentication status for users getting token errors [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/138099 (owner: 10MaxSem) [18:12:09] (03CR) 10Jdlrobson: [C: 032] MobileOptions: Log authentication status for users getting token errors [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/138099 (owner: 10MaxSem) [18:12:52] jdlrobson: Personally, I like the first solution. If people want separate notices for mobile, they can use CentralNotice. [18:12:53] (03Merged) 10jenkins-bot: MobileOptions: Log authentication status for users getting token errors [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/138099 (owner: 10MaxSem) [18:13:45] kaldari: patch for that is https://gerrit.wikimedia.org/r/136237 [18:15:32] jdlrobson, is there any thread describing what the issue behind it is? what's the example of a site notice we don't want to show? [18:15:49] There is a bug report attached to that patch [18:15:57] to quote jared "Not only do they look bad, its really bad UX, the dismiss button hit area is far too small, and i accidently go to the banner target at least 50% of the time when i'm trying to dismiss." [18:16:49] (03PS4) 10Florianschmidtwelzow: Respect Upload Settings on Special:Uploads [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/137541 (https://bugzilla.wikimedia.org/66164) [18:17:12] jdlrobson, MaxSem, jgonera: I'm happy to merge that if MaxSem is OK with it [18:19:00] ok we will wait for Max's input in case he has any strong reasoning behind his approach [18:19:07] ^ MaxSem when you catch up :) [18:25:31] (03CR) 10Jdlrobson: [C: 04-1] "Thanks for leading this documentation push! But lots of things to fix! :) Most of them are the same problem - should be relatively easy to" (0343 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/137297 (https://bugzilla.wikimedia.org/66086) (owner: 10Florianschmidtwelzow) [18:39:56] (03CR) 10Kaldari: [C: 032] Hide enabling of site notices behind flag [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/136237 (https://bugzilla.wikimedia.org/65395) (owner: 10Jdlrobson) [18:40:33] (03Merged) 10jenkins-bot: Hide enabling of site notices behind flag [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/136237 (https://bugzilla.wikimedia.org/65395) (owner: 10Jdlrobson) [18:44:29] 3MobileFrontend / 3alpha: Cannot switch to VisualEditor after a reload - 10https://bugzilla.wikimedia.org/65506 (10Jon) 5PATC>3RESO/FIX [18:45:14] 3MobileFrontend / 3stable: Site notices look crappy on mobile - 10https://bugzilla.wikimedia.org/65395 (10Max Semenik) 5PATC>3RESO/FIX [18:53:04] (03CR) 10MaxSem: [C: 04-1] Respect Upload Settings on Special:Uploads (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/137541 (https://bugzilla.wikimedia.org/66164) (owner: 10Florianschmidtwelzow) [18:54:47] (03PS1) 10Jdlrobson: Hack around yet another template problem. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/138389 [18:55:01] brion: mhurd https://gerrit.wikimedia.org/r/138389 [18:55:27] (03CR) 10Brion VIBBER: [C: 032] "\o/" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/138389 (owner: 10Jdlrobson) [18:56:50] (03Merged) 10jenkins-bot: Hack around yet another template problem. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/138389 (owner: 10Jdlrobson) [19:00:07] (03CR) 10Jdlrobson: [C: 04-1] "This doesn't look too good, it also changes the point of entry for notifications to under the search bar, which takes away some consistenc" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/138229 (https://bugzilla.wikimedia.org/56834) (owner: 10Florianschmidtwelzow) [19:02:05] brion: dbrant|lunch in lieu of branches, let's just have multiple patches that depend on each other, provided we are all comfortable rebasing them [19:02:36] (03CR) 10Jdlrobson: [C: 04-2] "-2ing until core change has been made so we don't accidentally merge :-)." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/137692 (https://bugzilla.wikimedia.org/48996) (owner: 10Florianschmidtwelzow) [19:03:32] MaxSem: thanks for taking care of SWAT [19:03:40] :) [19:03:51] YuviPanda: hey! [19:03:57] mhurd: hey! [19:04:24] YuviPanda: do you know if this patch: https://gerrit.wikimedia.org/r/#/c/138389/ once it goes live, will automatically get pulled into the apps css? [19:04:54] mhurd: should if we're using betalabs, yeah [19:05:02] YuviPanda: woohoo! [19:05:07] (03PS5) 10Florianschmidtwelzow: Update docs for skin and Api Files [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/137297 (https://bugzilla.wikimedia.org/66086) [19:05:10] mhurd: in fact, I see it's already been merged, so it should be live already now [19:05:36] (03CR) 10Jdlrobson: [C: 04-1] Hygiene: Update/Create doc for php in diff and modules (034 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/138289 (https://bugzilla.wikimedia.org/66086) (owner: 10Florianschmidtwelzow) [19:05:59] (03CR) 10Florianschmidtwelzow: "i think i have all :)" (0343 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/137297 (https://bugzilla.wikimedia.org/66086) (owner: 10Florianschmidtwelzow) [19:08:00] YuviPanda: not seeing it so far… but it was just merged a few minutes ago [19:08:11] mhurd: takes 5-10m [19:08:16] YuviPanda: cool [19:08:31] YuviPanda: gonna grab some food then check again :) [19:08:37] ok! [19:09:44] (03PS6) 10Jdlrobson: Update docs for skin and Api Files [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/137297 (https://bugzilla.wikimedia.org/66086) (owner: 10Florianschmidtwelzow) [19:09:52] (03CR) 10jenkins-bot: [V: 04-1] Update docs for skin and Api Files [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/137297 (https://bugzilla.wikimedia.org/66086) (owner: 10Florianschmidtwelzow) [19:09:59] (03CR) 10Jdlrobson: Update docs for skin and Api Files (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/137297 (https://bugzilla.wikimedia.org/66086) (owner: 10Florianschmidtwelzow) [19:11:25] (03PS7) 10Jdlrobson: Update docs for skin and Api Files [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/137297 (https://bugzilla.wikimedia.org/66086) (owner: 10Florianschmidtwelzow) [19:11:27] (03CR) 10Jdlrobson: [C: 032] Update docs for skin and Api Files [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/137297 (https://bugzilla.wikimedia.org/66086) (owner: 10Florianschmidtwelzow) [19:11:32] (03Merged) 10jenkins-bot: Update docs for skin and Api Files [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/137297 (https://bugzilla.wikimedia.org/66086) (owner: 10Florianschmidtwelzow) [19:12:55] YuviPanda: busy working now? [19:13:08] liangent: heya! kinda (random paperwork), but 'sup [19:14:03] so anyway can you have a look at https://bugzilla.wikimedia.org/show_bug.cgi?id=66321 ? I'm afraid any template change would flush it away [19:14:29] (looks like a &action=mobileview bug) [19:14:38] (03CR) 10Florianschmidtwelzow: Respect Upload Settings on Special:Uploads (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/137541 (https://bugzilla.wikimedia.org/66164) (owner: 10Florianschmidtwelzow) [19:14:51] YuviPanda: ^ [19:14:53] liangent: looking [19:14:53] (03PS5) 10Florianschmidtwelzow: Respect Upload Settings on Special:Uploads [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/137541 (https://bugzilla.wikimedia.org/66164) [19:15:22] liangent: do you have any transcluded sections in there? [19:15:56] YuviPanda: I don't know [19:16:16] I just got trapped by this and made a copy of that page [19:16:42] (03CR) 10Florianschmidtwelzow: "That's an interesting idea, much better then this change :D I will look into it later." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/138229 (https://bugzilla.wikimedia.org/56834) (owner: 10Florianschmidtwelzow) [19:17:00] 3MobileFrontend / 3Feature requests: Standard pre-echo "you have new messages" bar is not displayed - 10https://bugzilla.wikimedia.org/56834 (10Florian) a:3Florian [19:18:15] YuviPanda: and yeah there is a transcluded heading [19:20:11] liangent: right, so that's a known bug with a known fix [19:20:51] liangent: we just haven't prioritized it much because of other stuff going on and it only occurs if there's a transcluded section heading, which doesn't happen much in articlespace [19:21:00] liangent: should be fixed in a week or so. The Saved pages stuff is more 'pending' [19:21:26] YuviPanda: good [19:24:32] liangent: https://bugzilla.wikimedia.org/show_bug.cgi?id=63874 is the bug for it [19:25:22] YuviPanda: thanks [19:25:45] 3Wikipedia App / 3Generic: Edit link loads the wrong section in some cases - 10https://bugzilla.wikimedia.org/63874#c3 (10Liangent) *** Bug 66321 has been marked as a duplicate of this bug. *** [19:25:45] 3Wikipedia App / 3Android App: Section number mismatch between the app and API - 10https://bugzilla.wikimedia.org/66321#c1 (10Liangent) 5NEW>3RESO/DUP *** This bug has been marked as a duplicate of bug 63874 *** [19:26:44] liangent: yw :) push went out today with fix for IP blocked (local and global) [19:26:44] (03CR) 10Florianschmidtwelzow: Hygiene: Update/Create doc for php in diff and modules (034 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/138289 (https://bugzilla.wikimedia.org/66086) (owner: 10Florianschmidtwelzow) [19:27:01] liangent: most of the remaining crashes are for things like samsung only issues and stuff, atm at least :) [19:27:11] are filtered edits handled as well? [19:27:16] abusefilter & spamblacklist [19:27:19] liangent: yeah. [19:27:38] (03PS3) 10Florianschmidtwelzow: Hygiene: Update/Create doc for php in diff and modules [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/138289 (https://bugzilla.wikimedia.org/66086) [19:27:39] liangent: abusefilter actually shows you the message (which looks ugly atm), spamblacklist shows a useful message too [19:27:43] what about protection? [19:27:46] liangent: captchas are handled too [19:27:57] liangent: yup. if you don't have rights to edit you can't get into the edit workflow [19:28:15] liangent: doesn't handle the case when you go into the edit workflow and then it changes status, but otherwise is fine [19:28:22] what if a page gets protected after I got into the workflow? [19:28:25] meh [19:28:39] liangent: :P there's only so few of us and so many bugs.. [19:28:57] liangent: it'll probably just crash at this moment. I'm going to wait until we get the first crash report from that line before we do things. [19:29:07] YuviPanda: sessionfailure? [19:29:18] $wgReadOnly=true? [19:29:29] liangent: handled by refetching tokens, but actually I just realized we don't handle password changes [19:29:43] liangent: wgReadOnly=true should be handled by mobileview's 'editable' status, which uses quickUserCan [19:30:27] which still suffers concurrent state change [19:31:11] (03PS1) 10Yurik: Switched config to an object instead of an array [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/138402 [19:31:42] dr0ptp4kt, around? [19:32:23] yurikR2: i am, and i'm planning to go to lunch pretty soon. what's up? [19:32:37] got 3 more patches for you :) [19:32:45] dr0ptp4kt, when do you think you could look over them? [19:33:29] dr0ptp4kt, i will to make a few config changes at the same time (labs only, no prod) [19:33:43] otherwise betalabs won't be happy ) [19:34:25] yurikR2: i could look at them after lunch. would you please add me to asll patches and provide the urls here? i have meetings from 3-5 pacific and will probably be coming home after that [19:34:47] liangent: true, so all the state change ones probably need to be handled [19:35:08] dr0ptp4kt, sure, will add you shortly. btw, i'm on pacific now [19:35:50] yurikR2: cool [19:36:32] YuviPanda: yay! that quotebox fix trickled down to app css :) [19:38:02] YuviPanda: edit conflict? [19:38:09] liangent: silently ignored [19:38:18] YuviPanda: Ping. [19:38:23] Deskana: pong [19:38:42] YuviPanda: Are you available any time today for a discussion about the abuse filter [19:38:55] Such as 3pm Pacific? [19:38:58] Deskana: in the next hour and 20m would be great [19:39:03] * Deskana looks. [19:39:04] * YuviPanda checks when 3pm pacific is [19:39:17] That's 2 hours and 20 minutes. [19:39:22] Deskana: hmm did we estimate for this card? https://trello.com/c/lc3dr2lK/23-edit-workflow-changes [19:39:24] But 1 hour and 20 minutes from now works for me. [19:39:40] mhurd: We didn't. Just sorting that out now, breaking the abuse filter stuff off. [19:40:02] Deskana: ah. no worry - i’ll just start on the non-abuse-filter stuff for now [19:40:11] Deskana: ok, cool. [19:40:23] Deskana: earlier the better. last night in Glasgow ;) [19:40:25] :( i mean [19:40:58] YuviPanda: Invite sent. [19:41:02] 1h20m [19:41:09] moizsyed: hey is mock on this card the latest? https://trello.com/c/zHmmH2xT/74-design [20:00:56] YuviPanda: just noticed captcha doesn’t appear with the ios app anymore during acct creation or when say saving an edit with a link… did something change server side? [20:01:07] mhurd: not in the last month and a half or so [20:01:14] mhurd: and nothing changed for edit [20:01:19] YuviPanda: hmm this was working last week... [20:01:27] YuviPanda: checking stuff and things... [20:01:31] ok [20:03:27] YuviPanda: weird… i may have not formatted the url to trigger the captcha [20:03:36] YuviPanda: ‘cause now i see it [20:08:56] YuviPanda|food: so is MobileWikiAppReadingAction gone now? looks like that’s no longer being sent in android and there’s some extra param to API mobileview or something? [20:14:40] kaldari, https://gerrit.wikimedia.org/r/133037 [20:17:15] (03PS7) 10Brion VIBBER: EventLogging refactor [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/135885 [20:18:03] (03CR) 10Brion VIBBER: [C: 032 V: 032] "Going ahead and merging this as-is, added another card to check out the remaining issue where things have changed on Android side." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/135885 (owner: 10Brion VIBBER) [20:24:14] brion: yeah, since that would kill EL if we sent an extra request [20:24:35] brion: so we're putting an extra get param, but it isn't being analyzed anywhere :) [20:28:43] YuviPanda|food: ok we probably need server-side and ios-side cards for that then [20:28:48] brion: yeah [20:29:28] YuviPanda|food: i threw https://trello.com/c/bEg2H5aH/524-check-eventlogging-status-of-readingaction in the backlog for now [20:29:40] brion: cool. if it isn't too much work you should add the query param, but if not 'tis k [20:29:52] yeah it’ll be easy enough [20:29:56] brion: cool. [20:30:09] brion: make sure to respect opt out! [20:30:22] do we have an ios eventlogging opt-out card? [20:30:30] brion: not that I know of [20:30:36] ok i see one in the backlog [20:30:39] brion: ok [20:31:43] (03PS1) 10Dbrant: [WIP] Rename "bookmarks" to "saved pages" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/138436 [20:34:30] * YuviPanda|food pokes jdlrobson [20:34:48] jdlrobson: any update on your anti-inline styles crusade? [20:36:01] YuviPanda|food: we were talking about that earilier; i may take some of it up and push it farther in the rfc process if i can put together a prototype of template styles :) [20:36:10] brion: cool! [20:36:16] at least make it easy for these things to have responsive styles [20:36:37] brion: I'm implementing mongodb support on toollabs, so one of the things I'm going to build to test that out is an inline styles usage tracker that goes through templates to find inline styles and classify them [20:36:43] brion: so we can go fix them in the meantime to be not stupid [20:36:51] the case seems to often be ‘if width > X then use this stupid style, otherwise don’t’ [20:36:55] nice [20:37:15] so if we could just wrap most of them in a @media query they’d be fine :D [20:37:43] brion: yeah. I was going to sugget doing something like style- and then applying that via JS [20:38:37] we’ll try a few things and see what works :D [20:38:50] YuviPanda|food: i spoke to mhurd and brion about this [20:39:03] and i see brion replied :) [20:39:16] but yeh I am not the person to edit the Parser code [20:39:21] and it seems that is the current state of the RFC [20:39:33] jdlrobson: indeed. Most requested feature for Android app is dark theme, so we'll be muddling into that the sprint after next [20:39:39] jdlrobson: err, sprint after *this* [20:40:14] native apps giveth features, and native apps taketh away [20:40:23] YuviPanda|food: theo was working on this for mobile web too [20:40:40] jdlrobson: what, dark theme? [20:41:01] YuviPanda|food: would be good to standardize on a UI: https://github.com/theopolisme/ReadingOptions [20:41:14] This was based on designs by Jared and violetto [20:41:23] jdlrobson: ah, cool. [20:41:27] I'm not sure if he's still actively working on it [20:41:33] jdlrobson: will keep in mind. there's a meeting scheduled on thursday [20:41:43] but the general idea was an icon in the bottom left which controlled font size and night mode [20:41:49] so you could easily toggle on or off [20:41:56] jdlrobson: I might whip up a script that goes through dumps to catalog what kinda inline styles are in use and where, so we can fix problematic ones [20:42:05] since for night mode I'd primarily be interested in inline style colors [20:42:10] and those are easily class-able [20:42:33] YuviPanda|food: personally i think the only way to remove the inline style issue is to deprecate inline styles [20:42:40] you are fighting a doomed campaign [20:42:48] jdlrobson: I do agree, but I'm thinking more of what to do 2 weeks from now. [20:43:01] jdlrobson: removing inline styles also will be a political battle if there's no alternative (scoped styles) [20:43:02] there's too much debt - and remember we are talking about more than just enwiki :) [20:43:09] YuviPanda|food: which is why scoped styles are needed [20:43:16] at least it will allow us to do a consistency drive [20:43:29] jdlrobson: agree, but I'm not the person to write parser code either :D [20:43:32] (there's this awesome tool called csscss which will help identify duplicate styles across stylesheets) [20:44:06] (03CR) 10Steinsplitter: [C: 031] Don't show photo upload icon when no action is possible [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/137462 (owner: 10Jdlrobson) [20:47:14] jdlrobson: also, +1 to your email re: goals [20:47:32] 3MobileFrontend / 3stable: Page images disappear from Nearby - 10https://bugzilla.wikimedia.org/66394 (10Max Semenik) 3NEW p:3Unprio s:3normal a:3None Go to Nearby on Commons in desktop mode, click on a result. Page images will disappear while the page is being loaded and are not be back once you ret... [20:50:29] 3MobileFrontend / 3stable: Page images disappear from Nearby - 10https://bugzilla.wikimedia.org/66394#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/mhSqXtg7 [20:51:49] (03CR) 10Jdlrobson: [C: 04-1] "Okay.. I see your approach now, I'm just not convinced it is the best one." (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/137541 (https://bugzilla.wikimedia.org/66164) (owner: 10Florianschmidtwelzow) [20:55:03] (03CR) 10Jdlrobson: [C: 04-1] Make sure images are properly aligned in Mobile VisualEditor (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/138106 (https://bugzilla.wikimedia.org/66282) (owner: 10Kaldari) [20:55:37] kaldari: question... [20:55:44] yes? [20:55:54] your patch https://gerrit.wikimedia.org/r/#/c/138107/1/includes/Resources.php [20:56:06] shouldn't 'ext.visualEditor.mwimage.core', be a dependency of ext.visualEditor.mobileViewTarget ? [20:56:12] this code doesn't look like it belongs here [20:56:35] just wanted to check with you before I -1 in case there was a good reason :) [20:57:00] Deskana: what else can we pass you to sign off on https://trello.com/b/ez8tIIcj/mobile-app-sprint-32-android-beta-release ? id like to close the sprint today [20:57:01] jdlrobson: yeah, I think you're right [20:57:06] ok cool [20:57:07] and get our total point tally [20:57:18] so i need the sign off and todo stories moved [20:57:39] (03CR) 10Jdlrobson: [C: 04-1] "Do this in VisualEditor - add 'ext.visualEditor.mwimage.core' dependency to 'ext.visualEditor.mobileViewTarget'" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/138107 (owner: 10Kaldari) [20:59:03] (03CR) 10Jdlrobson: [C: 032] Hygiene: remove old b/c code that was there since October [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/138029 (owner: 10MaxSem) [21:00:55] (03Merged) 10jenkins-bot: Hygiene: remove old b/c code that was there since October [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/138029 (owner: 10MaxSem) [21:05:26] brion: looks like you in the thick with mhurd. grab me when your done [21:05:57] moment :D [21:17:28] Deskana: I'm heading off now, can you summarize? [21:17:43] YuviPanda|zz: Yep, writing it as we speak. [21:17:53] Deskana: cool! i'm around for 5m more if you need anything from me [21:17:59] I think I'm good. [21:18:38] Deskana: cool! :) [21:18:44] Safe travels! [21:20:55] Deskana: ty :) Also are the crash numbers I sent you good enough? [21:21:08] YuviPanda|zz: I think so. Thanks for reminding me I need to send that to Eloquence! [21:21:29] Deskana: :D cool! There's also some rather well thought out comments on OTRS, so I suggest you take a stroll through when you have the time [21:35:58] Deskana: sooo, here again :) any idea, approximately, at what priority is analytics dashboards? [21:36:09] Hmm. [21:36:14] Definitely not this sprint. [21:36:21] Deskana: true. [21:36:24] You guys have enough on your plate and it's the sprint before release. [21:36:29] Mayyyybe next, but not sure. [21:36:30] Deskana: completely agree [21:36:37] Deskana: I guess next one if we have bandwidth or the one after? [21:36:45] I'll put a card in for the next sprint and we can discuss at the planning meeting on Friday. [21:37:04] Deskana: cool! [22:10:14] 3MobileFrontend / 3stable: last edited note incorrect on timedText namespace page - 10https://bugzilla.wikimedia.org/66384#c2 (10Jon) Created attachment 15611 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15611&action=edit Last just now by an anonymous user In addition to this I am seeing the word... [22:10:39] jdlrobson: https://gerrit.wikimedia.org/r/#/c/138475/ [22:11:14] (03Abandoned) 10Kaldari: Make sure images are properly formatted in mobile VisualEditor [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/138107 (owner: 10Kaldari) [22:16:02] (03PS1) 10Mhurd: Core data snippets. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/138477 [22:16:15] 3MobileFrontend / 3Feature requests: Obstacles to enabling MobileFrontend for anonymous users (tracking) - 10https://bugzilla.wikimedia.org/53069#c28 (10Jon) Nemo - See https://www.mediawiki.org/wiki/Mobile_wikitext_editing#Anonymous_editing Apps is launching with this first. The web is a small team and we... [22:23:59] 3MobileFrontend / 3Feature requests: Add intermediate screen to warn logged-out editors similar to 'anoneditwarning' message - 10https://bugzilla.wikimedia.org/59937#c12 (10Jon) I have little time to focus on writing patches around anonymous editing. I tried [1] but was too busy to see it through to completi... [22:24:12] (03PS3) 10Kaldari: Make sure images are properly aligned in Mobile VisualEditor [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/138106 (https://bugzilla.wikimedia.org/66282) [22:27:10] jgonera, jdlrobson: Here's the last piece for the mobile VE image handling: https://gerrit.wikimedia.org/r/#/c/138106/. I merged the two selector sets together, per Jon. [22:30:37] kaldari, if this is the last piece, then there's something wrong with image styling somewhere else: http://imgur.com/5qvnFAK (the background/border around caption) [22:31:09] (03CR) 10Jdlrobson: [C: 032] "I don't like this but okay." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/138106 (https://bugzilla.wikimedia.org/66282) (owner: 10Kaldari) [22:31:44] (03Merged) 10jenkins-bot: Make sure images are properly aligned in Mobile VisualEditor [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/138106 (https://bugzilla.wikimedia.org/66282) (owner: 10Kaldari) [22:31:45] kaldari, the size of the image also seems to be slightly different in VE/viewing [22:32:03] jgonera: you mean the extra 2 pixels? [22:32:17] kaldari, it's definitely more than 2 pixels [22:32:25] jgonera: That's an artifact of core assuming that all images have a border :( [22:32:43] different size or the weird background around caption? [22:32:52] (03CR) 10Jdlrobson: [C: 04-1] Updating mobile VisualEditor browser test - alpha->beta (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/138378 (owner: 10Kaldari) [22:33:03] jgonera: different size [22:33:14] I didn't notice the different background [22:33:23] ok, that's a smaller issue in my opinion, the border and background is kinda weird [22:33:40] the image in the article I'm testing on is uploaded using mobile's lead image feature [22:34:04] jgonera: The 2 pixel problem is actually fairly hard to fix, since the formatting of images needs to be abstracted in core [22:34:20] rather than hard-coded to always add 2 pixels [22:34:29] MaxSem: eek otice: Undefined variable: bottomScripts in /Users/jrobson/Sites/w/extensions/MobileFrontend/includes/skins/SkinMinerva.php on line 80 [22:34:34] are you seeing this in the logs? [22:34:40] Found it when visiting the watchlist [22:34:44] nope [22:34:48] I think the 2px difference is not a huge issue kaldari [22:35:17] jgonera: can you show me the background issues, I'm not seeing it in my instance [22:35:40] kaldari, http://imgur.com/5qvnFAK [22:36:05] (03CR) 10Jdlrobson: "Juliusz: I suspect this is the change in pagelist.less but I cannot replicate so would appreciate if you can point me at the bug and post " [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/136501 (owner: 10Jdlrobson) [22:36:05] jgonera: whoa, that looks really wrong :) [22:37:05] StevenW: re the german wiki app, is pretty cool :) We have the ability to experiment a lot with the fonts and stuff in the app (webfonts have no performance penalty), but the designers have chosen not to at this point. Maybe in the future :) [22:37:09] StevenW: we are getting a dark theme soon though [22:37:10] jgonera: can you update core and VisualEditor extension and see if it goes away? [22:37:23] kaldari, let me do that [22:37:38] YuviPanda: yeah, I just hope that it galls them in to posting a similar breakdown when it comes time to release the native apps [22:37:52] They could easily write something the same depth/detail. [22:38:07] StevenW: heh, the android app is already out in about 50-60k users' hands, and the page styling is exactly the same as mobile web's [22:38:16] StevenW: but yeah, would be nice. [22:38:18] kaldari, updated, still the same [22:38:35] jgonera: OK, I'll take a look [22:38:41] thanks kaldari [22:39:22] tfinc, can we move my 1:1 on Wednesday to 3pm? [22:39:48] jgonera: sure. move away [22:40:07] StevenW: since these are the new mobile web styles. [22:40:12] StevenW: maybe even more with the dark theme [22:40:38] thanks tfinc [22:41:26] (03PS4) 10Jdlrobson: Hygiene: Fix some FIXMEs [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/136501 [22:48:24] (03PS1) 10MaxSem: mobileview: return page_props [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/138483 (https://bugzilla.wikimedia.org/64638) [22:48:59] (03CR) 10jenkins-bot: [V: 04-1] mobileview: return page_props [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/138483 (https://bugzilla.wikimedia.org/64638) (owner: 10MaxSem) [22:50:36] (03PS2) 10MaxSem: mobileview: return page_props [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/138483 (https://bugzilla.wikimedia.org/64638) [23:00:06] kaity, do we have the VE meeting? [23:00:18] jgonera: yes [23:00:40] ok, we'll be there in a few minutes [23:04:04] mhurd vbamba i'm going to be a liittle late. i'm in r31 [23:04:48] nevermind [23:04:54] here i am [23:06:07] (03PS1) 10Jdlrobson: Avoid JavaScript deprecation warnings in user module [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/138487 (https://bugzilla.wikimedia.org/65643) [23:06:27] jgonera: Finally figured it out. Those styles are from new parsoid styling that was just added that I didn't have locally. I'll need to override those as well. Sigh. [23:06:49] (03PS5) 10Jdlrobson: Hygiene: Fix some FIXMEs [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/136501 [23:07:15] kaldari jgonera: can you review https://gerrit.wikimedia.org/r/137831 asap before we hit edit conflicts? [23:07:29] (03PS3) 10Jdlrobson: QA: Fix failing builds [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/138375 [23:07:40] chrismcmahon: also if you get a chance could you look at that one ^ [23:07:47] (03PS3) 10Jdlrobson: Hygiene: Remove dead code path [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/138376 [23:07:55] (03PS5) 10Jdlrobson: Don't show photo upload icon when no action is possible [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/137462 [23:10:32] jdlrobson, might have meetings until the edn of the day [23:10:39] (03CR) 10Jdlrobson: [C: 032] Hygiene: Update/Create doc for php in diff and modules [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/138289 (https://bugzilla.wikimedia.org/66086) (owner: 10Florianschmidtwelzow) [23:11:13] (03Merged) 10jenkins-bot: Hygiene: Update/Create doc for php in diff and modules [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/138289 (https://bugzilla.wikimedia.org/66086) (owner: 10Florianschmidtwelzow) [23:11:35] jgonera: jdlrobson kaldari MaxSem tfinc Maryana i'm taking off in ~20 mins - anything you need from me before i leave? [23:11:44] nope [23:11:47] nah [23:11:53] nope [23:12:05] awjr: safe travels [23:12:11] cool [23:12:13] thanks tfinc :) [23:12:29] vbamba: https://wikimediafoundation.org/wiki/Wikipedia_Zero_App_FAQ [23:13:19] awjr: think we're good [23:13:20] safe travels! [23:13:28] thanks Maryana :) [23:14:16] (03PS1) 10Jdlrobson: Documentation: Add summary blocks to files in api directory [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/138489 [23:17:38] awjr: high tomorrow is only 105F/41 [23:17:41] C [23:18:18] chrismcmahon: by then i will be in NH, hopefully with a high of only 72 ;) [23:18:48] (03PS1) 10Jdlrobson: Ignore tests directory when running `make phpdocs` [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/138491 [23:19:31] 3MobileFrontend / 3Hygiene: make phpdoc shows errors in our PHP documentation - 10https://bugzilla.wikimedia.org/66086#c9 (10Jon) Looks like we are making good progress on this bug. Thanks Florian you rock! :-) I notice phpdoc complains lots about 'No summary was found for this file'. I think for the purpose... [23:19:45] awjr: you get around! [23:20:45] chrismcmahon: i am just trying to avoid the heat [23:21:03] summer is a good time to travel when you live in tucson :p [23:28:32] MaxSem: can you also surface `page_top_level_section_count` in https://gerrit.wikimedia.org/r/138483 or a follow up patch? [23:28:57] it's a property of a different page, talk [23:29:02] hmmm [23:34:38] (03CR) 10Cmcmahon: [C: 04-1] "Works OK in Firefox but in Chrome I'm seeing a z-index issue where div class="transparent-shield cloaked-element" is floating "on top" of " [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/138375 (owner: 10Jdlrobson) [23:39:06] (03PS1) 10Jdlrobson: Slight tweak to quotebox template [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/138499 [23:40:34] (03CR) 10Mhurd: [C: 032] "Looks good." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/138499 (owner: 10Jdlrobson) [23:41:11] (03Merged) 10jenkins-bot: Slight tweak to quotebox template [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/138499 (owner: 10Jdlrobson) [23:43:53] (03PS1) 10Kaldari: Fixing styling of full-size (non-thumbnail) images in mobile [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/138501 [23:45:03] (03PS2) 10Kaldari: Fixing styling of full-size (non-thumbnail) images in mobile [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/138501