[00:11:55] (03CR) 10Jdlrobson: "I can't replicate this - and I'm not seeing this issue on any of the Jenkins builds. Issue with your local install?" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/138375 (owner: 10Jdlrobson) [00:15:33] Maryana, should we hide the star everywhere for non-js version if it isn't used much? [00:16:07] dr0ptp4kt is writing an email with some rough numbers around it [00:17:01] hm.. well, it depends on what "much" means [00:17:04] (03PS1) 10Yurik: Switching to JCObjContent [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/138509 [00:17:06] (03PS1) 10Yurik: Better initalization for this ext using JsonConfig [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/138510 [00:17:08] but potentially [00:17:35] it's way too prominent for what it actually provides for the end user, imo [00:18:16] (03PS3) 10Jdlrobson: Make `make message` work again. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/137832 (https://bugzilla.wikimedia.org/63019) [00:21:15] (03PS1) 10Yurik: init cleanup [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/138511 [00:22:34] (03CR) 10MaxSem: [C: 032] Make `make message` work again. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/137832 (https://bugzilla.wikimedia.org/63019) (owner: 10Jdlrobson) [00:22:41] dr0ptp4kt, got a whole bunch of new patches for you ) [00:22:51] hope you can stay afloat ;) [00:23:04] urls [00:23:11] (03Merged) 10jenkins-bot: Make `make message` work again. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/137832 (https://bugzilla.wikimedia.org/63019) (owner: 10Jdlrobson) [00:23:12] yurikR ^ [00:23:14] dr0ptp4kt, already added you to them [00:23:14] ^^ [00:23:27] (03PS3) 10Jdlrobson: Collapse on the highest available heading level [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/137836 (https://bugzilla.wikimedia.org/60478) [00:23:34] dr0ptp4kt, anything that came from me ;) [00:23:35] (03CR) 10Cmcmahon: "
is right above the footer in my view in this branch. It is an active element, and " [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/138375 (owner: 10Jdlrobson) [00:23:37] (03CR) 10jenkins-bot: [V: 04-1] Collapse on the highest available heading level [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/137836 (https://bugzilla.wikimedia.org/60478) (owner: 10Jdlrobson) [00:23:44] 3MobileFrontend / 3Hygiene: make message changes character encoding - 10https://bugzilla.wikimedia.org/63019 (10Jon) 5PATC>3RESO/FIX [00:24:08] yurikR: and where i'm on the patch, right? [00:24:25] dr0ptp4kt, you have been added to all of them... [00:24:26] i think [00:25:28] dr0ptp4kt, i added you to mediawiki-config too, but don't +2 that one - only for reference - i will deploy it on prod shortly [00:25:37] once you +2 everything else [00:26:31] (03PS4) 10Jdlrobson: Collapse on the highest available heading level [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/137836 (https://bugzilla.wikimedia.org/60478) [00:26:41] dr0ptp4kt, also, start with all jsonconfig patches, followed by ZB and ZP [00:27:30] 3MobileFrontend / 3stable: Filter for New User uploads in Mobile Web - 10https://bugzilla.wikimedia.org/62598#c42 (10Jon) 5PATC>3RESO/FIX Hopefully when this change goes live you will see a big difference :) [00:28:06] MaxSem, has there been any weirdness in mobile detection on vagrant? recently setting "android" UA stopped being detected [00:29:29] yurikR, should still work [00:30:30] 3MobileFrontend / 3Hygiene: Hygiene: Remove disableBackToTop and enableExpandableSections from MobileFormatter.php - 10https://bugzilla.wikimedia.org/64004#c3 (10Jon) 5PATC>3NEW Oh.. I notice protected $backToTopLink = true; is still present in MobileFormatter.php so sadly can't sign off on this bug jus... [00:31:50] yurikR, curl -I -H 'User-Agent: android' http://en.wikipedia.org/wiki/Main_Page [00:31:50] 3MobileFrontend / 3General/Unknown: When notifications count is [0] badge and count should be hidden - 10https://bugzilla.wikimedia.org/65914#c5 (10Jon) 5ASSI>3RESO/FIX Story has now been accepted. [00:32:27] (03PS2) 10Yurik: init cleanup, desc message fix [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/138511 [00:32:47] MaxSem, on vagrant, not prod [00:33:29] 3MobileFrontend / 3Hygiene: Avoid CSS rule duplication by using more descriptive classes - 10https://bugzilla.wikimedia.org/64217#c4 (10Jon) 5PATC>3RESO/INV I guess this is not really actionable now. We're in a much better state now so closing. The CSS rule duplication tool might be useful to package in... [00:35:03] (03PS1) 10Jdlrobson: Hygiene: Kill dead variable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/138515 (https://bugzilla.wikimedia.org/64004) [00:39:04] yurikR, you're using a tablet device [00:39:08] :P [00:39:30] MaxSem, wa??? what user agent should i use now? :) [00:39:53] 'android mobile' XD [00:40:25] bleh [00:41:11] we will start showing mobile view to tablets pretty soon though [00:44:56] (03PS1) 10MaxSem: Throw a couple more Android UAs at tests [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/138516 [00:45:01] kaldari, ^^^ [00:46:40] mhurd: got a question about the XPATH expression in the https://trello.com/c/6lX128DO/21-5-offline-save-page-images-to-the-filesystem-and-track-which-images-are-from-which-page [00:47:13] mhurd: basically i want to know why we exclude the Navbox images [00:47:21] bearND: lemme check... [00:47:42] (03PS1) 10MaxSem: Show mobile view to tablets by default [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/138517 [00:48:05] (03PS1) 10Kaldari: Migrate float and clear styles from parsoid styles to mobile [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/138518 [00:48:13] mhurd: are htere any good example pages you know of? [00:51:57] bearND: so i think i found a good example.. [00:52:21] bearND: if you look at this page on desktop: http://en.wikipedia.org/wiki/Fish [00:52:48] bearND: near the very bottom of the page is a box with a lot of links [00:53:22] bearND: on the left side it says things like “About fish” and Anatomy and physiology” [00:53:37] bearND: do you see that? [00:54:02] (03PS3) 10Kaldari: Fixing styling of full-size (non-thumbnail) images in mobile [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/138501 [00:54:21] bearND: be sure you’re looking at it on the desktop version of the site not in app or on mobile web version [00:55:27] (03CR) 10Kaldari: [C: 032] Throw a couple more Android UAs at tests [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/138516 (owner: 10MaxSem) [00:56:09] (03Merged) 10jenkins-bot: Throw a couple more Android UAs at tests [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/138516 (owner: 10MaxSem) [00:56:40] mhurd: Great example! I guess we don't want to save it because we don't display navboxes, right? [00:56:53] bearND: yes [00:57:15] bearND: in the fish nav box there’s even a little fish on the right side [00:57:22] *little fish image* [00:58:07] bearND: and they’re not displayed on mobile web either [00:58:48] yurik: i'll get to those code reviews first thing when i'm working tomorrow, probably after the standup [00:58:50] mhurd: yes, i see it. [01:15:13] (03PS2) 10Kaldari: Updating mobile VisualEditor browser test - alpha->beta [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/138378 [01:16:41] (03CR) 10Kaldari: Updating mobile VisualEditor browser test - alpha->beta (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/138378 (owner: 10Kaldari) [01:26:04] (03PS1) 10Dbrant: [WIP] Saving full text of page to filesystem. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/138525 [01:26:46] (03CR) 10Dbrant: [C: 032] Bump version number for 2.0-alpha-2014-06-09 [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/138353 (owner: 10Dbrant) [03:22:07] (03CR) 10BearND: "Wow, great progress." (038 comments) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/138525 (owner: 10Dbrant) [06:44:33] (03PS6) 10Florianschmidtwelzow: Respect Upload Settings on Special:Uploads [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/137541 (https://bugzilla.wikimedia.org/66164) [06:46:02] (03CR) 10Florianschmidtwelzow: "> What do you think?" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/137541 (https://bugzilla.wikimedia.org/66164) (owner: 10Florianschmidtwelzow) [06:56:02] (03CR) 10Florianschmidtwelzow: [C: 031] Documentation: Add summary blocks to files in api directory [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/138489 (owner: 10Jdlrobson) [06:56:12] (03CR) 10Florianschmidtwelzow: [C: 031] Ignore tests directory when running `make phpdocs` [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/138491 (owner: 10Jdlrobson) [06:56:14] 3MobileFrontend / 3Hygiene: make phpdoc shows errors in our PHP documentation - 10https://bugzilla.wikimedia.org/66086#c10 (10Florian) The summary blocks is a "problem", yes. I'm not really happy with, to only add the name of the file, but in context that i haven't found any other solution to handle this, it... [07:03:32] (03CR) 10Florianschmidtwelzow: [C: 031] Hygiene: Kill dead variable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/138515 (https://bugzilla.wikimedia.org/64004) (owner: 10Jdlrobson) [07:03:44] 3MobileFrontend / 3Hygiene: Hygiene: Remove disableBackToTop and enableExpandableSections from MobileFormatter.php - 10https://bugzilla.wikimedia.org/64004#c5 (10Florian) Oha, then we only said, that we want to remove this in one of the PS :P [07:18:52] (03PS1) 10Florianschmidtwelzow: Update file summary for phpdoc [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/138540 (https://bugzilla.wikimedia.org/66086) [07:21:14] 3MobileFrontend / 3Hygiene: make phpdoc shows errors in our PHP documentation - 10https://bugzilla.wikimedia.org/66086#c12 (10Florian) 5PATC>3ASSI Updated last merged phpdoc changed, looks much better now :) [07:28:49] (03CR) 10Florianschmidtwelzow: WIP: Anonymous editing in alpha (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/117324 (owner: 10Jdlrobson) [07:31:00] 3MobileFrontend / 3Feature requests: Add intermediate screen to warn logged-out editors similar to 'anoneditwarning' message - 10https://bugzilla.wikimedia.org/59937#c13 (10Florian) @Jon: Your PS, i think, is the right way and the basic function is in there, but it needs a lot of work and investigating in wh... [08:17:29] (03PS2) 10Florianschmidtwelzow: Enable View of new messages on talk page without Echo [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/138229 (https://bugzilla.wikimedia.org/56834) [08:30:33] (03CR) 10Florianschmidtwelzow: "It solves the problem, yes :)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/136926 (owner: 10Florianschmidtwelzow) [08:49:14] 3MobileFrontend / 3Feature requests: Include /* section title */ in edit summary for mobile section edits - 10https://bugzilla.wikimedia.org/60134#c13 (10Florian) Any opinions? :) [09:41:23] (03CR) 10Steinsplitter: [C: 031] Hygiene: Remove dead code path [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/138376 (owner: 10Jdlrobson) [11:49:16] (03CR) 10Dr0ptp4kt: [C: 032] Switching to JCObjContent [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/138509 (owner: 10Yurik) [11:50:21] (03CR) 10Dr0ptp4kt: [C: 032] Better initalization for this ext using JsonConfig [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/138510 (owner: 10Yurik) [11:52:17] (03CR) 10Dr0ptp4kt: [C: 032] Switched config to an object instead of an array [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/138402 (owner: 10Yurik) [11:53:30] (03CR) 10Dr0ptp4kt: [C: 032] init cleanup, desc message fix [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/138511 (owner: 10Yurik) [13:05:58] (03PS2) 10Dbrant: [WIP] Save full text of page to filesystem. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/138525 [13:14:26] (03PS2) 10Dbrant: [WIP] Rename "bookmarks" to "saved pages" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/138436 [13:21:52] (03PS3) 10Dbrant: [WIP] Save full text of page to filesystem. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/138525 [13:53:40] (03PS3) 10Dbrant: Rename "bookmarks" to "saved pages" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/138436 [13:54:12] (03PS4) 10Dbrant: [WIP] Save full text of page to filesystem. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/138525 [14:05:39] #wikimedia-staff [14:05:51] [mt] [14:56:11] (03PS5) 10Dbrant: [WIP] Save full text of page to filesystem. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/138525 [14:56:55] bearND: ^ all comments addressed :) [14:57:35] bearND: The only thing I'm still finishing with that is importing of pages from the old app... [15:11:53] (03CR) 10BearND: [C: 031] [WIP] Save full text of page to filesystem. (031 comment) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/138525 (owner: 10Dbrant) [15:12:03] dbrant: great! :) Looks like this is progressing very nicely. :) One minor thing. ^ [15:13:05] bearND: so you'll make your patch dependent on this one? [15:13:17] dbrant: yes [15:14:17] dbrant: i'm just +1 for now since we probably want to wait until the rest of the saved pages cards are done before merging to master [15:14:28] bearND: sure [15:52:45] (03CR) 10Cmcmahon: [C: 032] ""transparent-shield cloaked-element" seems to be a race condition, I'll fix that in a separate patch (I hope)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/138375 (owner: 10Jdlrobson) [15:53:47] (03CR) 10jenkins-bot: [V: 04-1] QA: Fix failing builds [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/138375 (owner: 10Jdlrobson) [16:10:41] chrismcmahon: you there? [16:11:05] (03CR) 10Jdlrobson: [C: 032] "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/138375 (owner: 10Jdlrobson) [16:12:14] (03CR) 10jenkins-bot: [V: 04-1] QA: Fix failing builds [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/138375 (owner: 10Jdlrobson) [16:12:40] (03PS6) 10Dbrant: Save full text of page to filesystem. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/138525 [16:12:50] hashar: any idea what's going wrong with jenkins here? https://integration.wikimedia.org/ci/job/mwext-MobileFrontend-qunit/6227/console [16:13:19] (03PS4) 10Jdlrobson: QA: Fix failing builds [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/138375 [16:14:15] (03CR) 10jenkins-bot: [V: 04-1] QA: Fix failing builds [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/138375 (owner: 10Jdlrobson) [16:17:34] jdlrobson: looking [16:17:56] Warning: An old copy of the Modern skin was found in your skins/ directory. You should remove it to avoid problems in the future.See [16:17:56] :( [16:18:15] the workspace is not properly cleaned up damn [16:18:58] (03CR) 10Jdlrobson: "Actually Florian - the advantage of the older version is that it is stable so it's probably better from that perspective then running the " [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/136926 (owner: 10Florianschmidtwelzow) [16:20:02] (03CR) 10Florianschmidtwelzow: "Ah, ok, then i can abandon this change :)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/136926 (owner: 10Florianschmidtwelzow) [16:20:23] (03Abandoned) 10Florianschmidtwelzow: Fix for installation of PHP Codesniffer with composer [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/136926 (owner: 10Florianschmidtwelzow) [16:25:39] jdlrobson: that is a side effect of mw/core throwing warnings when it finds obsolete skins ( https://gerrit.wikimedia.org/r/#/c/135429/ ) [16:25:55] yeh i think matmarex was working on that [16:26:10] so can we remove those files from the builds? [16:26:19] jdlrobson: mind filling a bug against Wikimedia > Continuous integration please? [16:26:31] I am pretty sure the issue is the warning regarding old skins [16:26:33] hashar: sure. it's pretty urgent as we can't merge code without it :) [16:26:43] https://integration.wikimedia.org/ci/job/mediawiki-core-regression-hhvm-master/496/console : ERROR! It seems this job introduced a regression although it might be caused by a previous commit. in 5m 41s (non-voting) ooh nice :) [16:26:55] the root cause is that we grab MediaWiki code using git archive in the jenkins workspace. That does not clean out old files though [16:27:29] I have a big project coming on to fix it for good. Meanwhile I guess we will want to remove the deprecation message until CI is fixed ( i.e. revert https://gerrit.wikimedia.org/r/#/c/135429/ ) [16:28:42] hashar: https://bugzilla.wikimedia.org/show_bug.cgi?id=66429 [16:28:58] thanks for that [16:29:02] i can revert it… :-/ [16:29:02] replying on the bug [16:29:38] ok reverting the patch now [16:29:46] jdlrobson: hold on [16:29:50] hashar: ok. [16:29:50] double checking [16:29:56] hashar: i will wait for your confirmation. [16:30:20] yeah confirmed the issue :-( [16:33:54] (03PS3) 10Jdlrobson: Enable View of new messages on talk page without Echo [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/138229 (https://bugzilla.wikimedia.org/56834) (owner: 10Florianschmidtwelzow) [16:34:49] (03CR) 10jenkins-bot: [V: 04-1] Enable View of new messages on talk page without Echo [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/138229 (https://bugzilla.wikimedia.org/56834) (owner: 10Florianschmidtwelzow) [16:36:35] (03CR) 10Jdlrobson: [C: 04-1] "This looks much better! yey! :)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/138229 (https://bugzilla.wikimedia.org/56834) (owner: 10Florianschmidtwelzow) [16:36:48] hashar: ok reverting [16:37:15] hashar: https://gerrit.wikimedia.org/r/138626 [16:37:42] (03PS3) 10Jdlrobson: Don't show spinner whilst watching a page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/137233 (https://bugzilla.wikimedia.org/65599) [16:38:25] awjr: can you bounce https://trello.com/c/lF4IBxYp/493-bug-65599-indeterminate-loader-graphic-should-not-be-displayed-when-watchlisting-or-watchlisting over to mobile web [16:38:30] it's in the wrong place [16:39:22] (03CR) 10jenkins-bot: [V: 04-1] Don't show spinner whilst watching a page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/137233 (https://bugzilla.wikimedia.org/65599) (owner: 10Jdlrobson) [16:39:35] looking jdlrobson [16:39:51] jdlrobson: moved [16:40:12] thanks :) [16:41:49] jdlrobson: replied on the bug. Not much I could do about it this week beside reverting the deprecation message :-( [16:45:24] (03PS2) 10Jdlrobson: Update file summary for phpdoc [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/138540 (https://bugzilla.wikimedia.org/66086) (owner: 10Florianschmidtwelzow) [16:45:44] hashar: i just hope i can merge code today [16:45:48] (03CR) 10Jdlrobson: [C: 032] Update file summary for phpdoc [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/138540 (https://bugzilla.wikimedia.org/66086) (owner: 10Florianschmidtwelzow) [16:46:08] (03CR) 10Jdlrobson: Update file summary for phpdoc (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/138540 (https://bugzilla.wikimedia.org/66086) (owner: 10Florianschmidtwelzow) [16:46:33] (03CR) 10jenkins-bot: [V: 04-1] Update file summary for phpdoc [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/138540 (https://bugzilla.wikimedia.org/66086) (owner: 10Florianschmidtwelzow) [16:46:49] i hope too ;) [16:46:57] jdlrobson: it is too late for me to figure out a workaround/solution beside reverting the mw/core change sorry :-( [16:47:16] (03PS4) 10Florianschmidtwelzow: Enable View of new messages on talk page without Echo [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/138229 (https://bugzilla.wikimedia.org/56834) [16:47:49] jdlrobson: potentially I can manually clear out the /skins/ directory from all -qunit jobs that would fix it. But I can't remember whether they run a REL1** branch [16:47:58] (03PS7) 10Jdlrobson: Respect Upload Settings on Special:Uploads [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/137541 (https://bugzilla.wikimedia.org/66164) (owner: 10Florianschmidtwelzow) [16:48:14] hashar: mm maybe add a note on the patch? [16:48:54] (03CR) 10jenkins-bot: [V: 04-1] Respect Upload Settings on Special:Uploads [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/137541 (https://bugzilla.wikimedia.org/66164) (owner: 10Florianschmidtwelzow) [16:50:05] (03CR) 10Jdlrobson: Respect Upload Settings on Special:Uploads (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/137541 (https://bugzilla.wikimedia.org/66164) (owner: 10Florianschmidtwelzow) [16:50:09] (03CR) 10Florianschmidtwelzow: Enable View of new messages on talk page without Echo (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/138229 (https://bugzilla.wikimedia.org/56834) (owner: 10Florianschmidtwelzow) [16:50:21] (03CR) 10Jdlrobson: [C: 04-1] "Once you've fixed up these remaining 2 things this looks ready to merge :)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/137541 (https://bugzilla.wikimedia.org/66164) (owner: 10Florianschmidtwelzow) [16:53:00] (03CR) 10Florianschmidtwelzow: Respect Upload Settings on Special:Uploads (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/137541 (https://bugzilla.wikimedia.org/66164) (owner: 10Florianschmidtwelzow) [16:53:44] (03PS8) 10Florianschmidtwelzow: Respect Upload Settings on Special:Uploads [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/137541 (https://bugzilla.wikimedia.org/66164) [16:53:46] (03CR) 10Jdlrobson: [C: 04-1] Enable View of new messages on talk page without Echo (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/138229 (https://bugzilla.wikimedia.org/56834) (owner: 10Florianschmidtwelzow) [16:55:23] (03CR) 10Jdlrobson: [C: 032] "oh.. I didn't realise we pushed VisualEditor to beta :) Must have missed that commit." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/138378 (owner: 10Kaldari) [16:55:30] (03PS3) 10Jdlrobson: QA: Updating mobile VisualEditor browser test - alpha->beta [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/138378 (owner: 10Kaldari) [16:56:23] (03CR) 10jenkins-bot: [V: 04-1] QA: Updating mobile VisualEditor browser test - alpha->beta [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/138378 (owner: 10Kaldari) [16:58:11] (03CR) 10Jdlrobson: [C: 04-1] "Please add some tests and then I'll merge." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/138483 (https://bugzilla.wikimedia.org/64638) (owner: 10MaxSem) [17:06:45] (03PS5) 10Florianschmidtwelzow: Enable View of "new messages on talk page" without Echo [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/138229 (https://bugzilla.wikimedia.org/56834) [17:11:33] (03CR) 10Kaldari: "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/138378 (owner: 10Kaldari) [17:18:38] chrismcmahon: Do you think this is safe to merge even though Jenkins is showing qunit errors: https://gerrit.wikimedia.org/r/#/c/138378/ [17:19:01] I don't think the errors are related to the patch [17:21:28] kaldari: agreed, qunit is unrelated. Is the move from alpha to beta merged already? [17:21:36] yes [17:21:51] kaldari: awesome, omw then [17:22:09] cool, just wanted a sanity check :) [17:22:19] (03CR) 10Cmcmahon: [C: 032] QA: Updating mobile VisualEditor browser test - alpha->beta [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/138378 (owner: 10Kaldari) [17:23:03] vbamba: hey! would it be ok to bump the board clean-up to 4:30 or 3:30? [17:23:22] (03CR) 10jenkins-bot: [V: 04-1] QA: Updating mobile VisualEditor browser test - alpha->beta [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/138378 (owner: 10Kaldari) [17:23:46] kaldari: please refer: https://bugzilla.wikimedia.org/show_bug.cgi?id=66429 :) [17:24:01] FlorianSW: Thanks [17:24:06] np :) [17:24:59] chrismcmahon: looks like we can't actually merge any code until the qunit issue is fixed, since we have it set up to only allow Jenkins to verify code with +2. [17:25:19] chrismcmahon: any idea who would be good to bug about that? [17:26:08] kaldari: I know zip about the qunit stuff [17:26:23] I'll follow up in the bug then [17:26:46] kaldari: Krinkle maybe? [17:26:58] Working on it [17:27:30] 3Wikipedia App / 3Android App: Some content in preview gets covered by "By saving, you agree to..." - 10https://bugzilla.wikimedia.org/66160#c2 (10Dan Garry) 5NEW>3RESO/WON The edit workflow is going to change significantly in the next sprint which will (indirectly) resolve this. [17:31:59] (03CR) 10Jdlrobson: [C: 032] Respect Upload Settings on Special:Uploads [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/137541 (https://bugzilla.wikimedia.org/66164) (owner: 10Florianschmidtwelzow) [17:33:22] (03CR) 10jenkins-bot: [V: 04-1] Respect Upload Settings on Special:Uploads [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/137541 (https://bugzilla.wikimedia.org/66164) (owner: 10Florianschmidtwelzow) [17:35:32] (03CR) 10Jdlrobson: [C: 04-1] "With Echo enabled:" (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/138229 (https://bugzilla.wikimedia.org/56834) (owner: 10Florianschmidtwelzow) [17:36:26] (03CR) 10Jdlrobson: [C: 031] Show mobile view to tablets by default [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/138517 (owner: 10MaxSem) [17:37:56] (03CR) 10Jdlrobson: [C: 04-1] Migrate float and clear styles from parsoid styles to mobile (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/138518 (owner: 10Kaldari) [17:38:03] (03CR) 10MaxSem: "Heh, actually it's possible to configure autopromotion to flag people with no edits." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/138376 (owner: 10Jdlrobson) [17:40:19] (03CR) 10Kaldari: Migrate float and clear styles from parsoid styles to mobile (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/138518 (owner: 10Kaldari) [17:41:38] (03CR) 10Jdlrobson: [C: 04-1] "1) Can you point to some examples e.g. open a bug report to document this better or add some sample wikitext above to explain how these ar" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/138501 (owner: 10Kaldari) [17:43:08] (03CR) 10Florianschmidtwelzow: Enable View of "new messages on talk page" without Echo (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/138229 (https://bugzilla.wikimedia.org/56834) (owner: 10Florianschmidtwelzow) [17:43:22] jdlrobson: greping for floatleft should give plenty of matches in core [17:43:40] kaldari: it doesn't this is what confuses me :) [17:43:46] kaldari: but how do you create that in wikitext? [17:43:50] it does for me :) [17:44:08] all I get is Parsoid and ./tests/parser/parserTests.txt [17:44:13] and some css files [17:44:18] but i don't see what introduces it [17:44:53] hmm, I see what you mean. must be some voodoo responsible for it. lemme see... [17:45:17] for example you can do {| class="wikitable floatright" [17:45:37] but it seems weird having stuff for float right in core when it should be in Common.css / Mobile.css [17:46:15] jdlrobson: it's not for inline styles, it for any full-size images that are aligned left or right [17:46:31] all i want is some sample wikitext so i can understand it better :) [17:46:37] i.e. not a thumbnail… [[File:Kitten.jpg|right]] [17:46:56] ahh okay. Can you put a comment above the css with that? [[File:Kitten.jpg|right]] / [[File:Kitten.jpg|left]] [17:47:02] sure [17:47:08] just makes shit clearer for the plebs like me :) [17:47:14] NP :) [17:49:04] jdlrobson: I'm surprised no one had noticed it before [17:52:02] kaldari: looks like they could use a right margin/left margin too? [17:52:38] on Vector margin: 0 .5em .5em 0; [17:52:40] maybe so [17:52:47] (for floatleft) [17:52:57] I'll add that too [17:53:51] (03CR) 10MaxSem: [C: 032] "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/138540 (https://bugzilla.wikimedia.org/66086) (owner: 10Florianschmidtwelzow) [17:54:26] (03Merged) 10jenkins-bot: Update file summary for phpdoc [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/138540 (https://bugzilla.wikimedia.org/66086) (owner: 10Florianschmidtwelzow) [17:54:47] (03CR) 10MaxSem: [C: 032] "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/137541 (https://bugzilla.wikimedia.org/66164) (owner: 10Florianschmidtwelzow) [17:55:08] (03CR) 10MaxSem: [C: 032] "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/138375 (owner: 10Jdlrobson) [17:55:24] (03Merged) 10jenkins-bot: Respect Upload Settings on Special:Uploads [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/137541 (https://bugzilla.wikimedia.org/66164) (owner: 10Florianschmidtwelzow) [17:55:26] (03CR) 10MaxSem: [C: 032] "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/138378 (owner: 10Kaldari) [17:55:47] (03Merged) 10jenkins-bot: QA: Fix failing builds [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/138375 (owner: 10Jdlrobson) [17:56:16] (03Merged) 10jenkins-bot: QA: Updating mobile VisualEditor browser test - alpha->beta [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/138378 (owner: 10Kaldari) [17:56:29] 3MobileFrontend / 3stable: Do not show "Contribute an Image", if wgEnableUploads = false - 10https://bugzilla.wikimedia.org/66164 (10Florian) 5PATC>3RESO/FIX [17:57:47] (03PS2) 10Kaldari: Migrate float and clear styles from parsoid styles to mobile [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/138518 [17:58:37] * tfinc heads into the office [18:09:48] (03PS4) 10Kaldari: Fixing styling of full-size (non-thumbnail) images in mobile [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/138501 [18:16:18] (03CR) 10Kaldari: [C: 032] Alpha: Avoid multiple title parameters when rewriting url [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/137740 (https://bugzilla.wikimedia.org/65327) (owner: 10Jdlrobson) [18:16:53] (03Merged) 10jenkins-bot: Alpha: Avoid multiple title parameters when rewriting url [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/137740 (https://bugzilla.wikimedia.org/65327) (owner: 10Jdlrobson) [18:17:31] dbrant|lunch: I replied to you on that card about the offline editing stuff. I think your proposed solution is great. :) [18:18:26] jdlrobson, jgonera, MaxSem: I'm going to try to finish up my co-worker reviews now, so may be unresponsive for a while [18:18:38] kaldari, ok [18:18:38] as I may lapse into a coma [18:18:44] ;) [18:18:46] :) [18:22:45] hiuregnaifS\ [18:22:51] EURRRGGH [18:22:54] REVIEEEEEEEWS [18:24:33] kaldari: yeh that's on my todo list too :) [18:25:48] (03CR) 10Jdlrobson: [C: 032] Fixing styling of full-size (non-thumbnail) images in mobile [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/138501 (owner: 10Kaldari) [18:26:25] (03CR) 10Jdlrobson: [C: 032] Migrate float and clear styles from parsoid styles to mobile [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/138518 (owner: 10Kaldari) [18:27:26] erffgggg fricking rebase conflicts [18:29:46] (03PS2) 10Jdlrobson: Hygiene: Kill OverlayNew and LoadingOverlayNew [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/137831 [18:30:51] (03PS4) 10Jdlrobson: Don't show spinner whilst watching a page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/137233 (https://bugzilla.wikimedia.org/65599) [18:32:00] (03CR) 10Jdlrobson: [C: 032] "If Florianschmidtwelzow wrote this patch I would merge it.. so since he agrees :)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/138489 (owner: 10Jdlrobson) [18:37:32] chrismcmahon: can you expose https://integration.wikimedia.org/ci/job/browsertests-MobileFrontend-en.m.wikipedia.org-linux-firefox/rssAll ? [18:38:33] jdlrobson: doesn't look like it. file a bug for hashar? [18:39:01] (03Merged) 10jenkins-bot: Fixing styling of full-size (non-thumbnail) images in mobile [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/138501 (owner: 10Kaldari) [18:39:20] (03Merged) 10jenkins-bot: Migrate float and clear styles from parsoid styles to mobile [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/138518 (owner: 10Kaldari) [18:40:40] awjr: where is bingle running on tool labs again? [18:40:43] jdlrobson: Now that that's merged, can you merge the tiny patch that was dependant on it as well: https://gerrit.wikimedia.org/r/#/c/138520/ [18:41:01] jdlrobson: bingle runs in a projected called 'bingle' and bugello runs in a project called 'bugello' [18:41:48] kaldari: if you merge some of my 14 open patches - i've code reviewed about the same today :) [18:42:04] i'm feeling a bit unloved :( [18:42:08] :( [18:42:08] (03CR) 10Florianschmidtwelzow: "Please merge :) I left out this files in I56a4c35b1a6b14ff58c8ce2e7fdeb6747289dfb0 because of this commit :)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/138489 (owner: 10Jdlrobson) [18:43:13] jdlrobson: I'll try to get to them as soon as I finish my reviews. I was just hoping to get all the VE mobile mess cleaned up since it's going to beta, but it can wait. [18:43:47] :jdlrobson :( [18:44:24] (03Merged) 10jenkins-bot: Documentation: Add summary blocks to files in api directory [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/138489 (owner: 10Jdlrobson) [18:44:31] jdlrobson: <3 [18:46:41] kaldari: so.. i'm not sure about the core change, since core should be agnostic of Minerva [18:46:47] (this is why I detest skinStyles) [18:47:30] jdlrobson: true, I discussed that with Gabrielle, but we decided it was OK since it's only temporary anyway. [18:47:43] awjr: thanks for the update. Added a card to fix selello [18:47:50] jdlrobson: what's going on [18:47:52] ? [18:47:52] jdlrobson: that entire style module is just a temporary hack [18:48:09] jdlrobson: but you can pass on it if you want [18:48:41] awjr: it looks like when we moved to integration.wikimedia.org the cloud bees service got shut down [18:48:51] https://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-firefox/ "This project is currently disabled" [18:48:57] jdlrobson: ah thus no more rss? [18:48:57] for Firefox at least [18:49:08] but there's another issue - the rss feed seems to be disabled on wikimedia servers [18:49:10] so i created a bug [18:49:16] roger that [18:59:14] 3MobileFrontend / 3alpha: Non-canonical URLs get rewritten into weird psuedo-canonical URLs in alpha - 10https://bugzilla.wikimedia.org/65327 (10Jon) 5PATC>3RESO/FIX [19:03:27] awjr kaldari: can you merge https://gerrit.wikimedia.org/r/138491 so that FlorianSW|away can work on the specials directory and get his bug closed? [19:03:45] (03PS6) 10Jdlrobson: Hygiene: Fix some FIXMEs [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/136501 [19:07:44] (03CR) 10Jdlrobson: [C: 04-1] "Hey Florian hope this feedback makes things a little clearer to you about what Juliusz was suggesting!" (034 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/135311 (https://bugzilla.wikimedia.org/60134) (owner: 10Florianschmidtwelzow) [19:08:36] (03CR) 10Jdlrobson: "Basically your patch introduces 2 ajax requests when both bits of data can be retrieved in one ajax request in the getPreview function :)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/135311 (https://bugzilla.wikimedia.org/60134) (owner: 10Florianschmidtwelzow) [19:17:51] jdlrobson, and don't buy inflatable mattresses at Target, mine's already leaking like hell [19:18:06] MaxSem: really? that sucks :-( [19:21:53] Deskana: i'm seeing a lot of users complain about crashes as their still using 1.3.4. lets message out to them to try the new app [19:23:00] this comment is interesting "Totally unusable in mainland China (for me only?), don't even work with uncensored words. It's ok if I access through VPN. Old beta (dark icon version) was ok, stable version is ok too." [19:23:10] YuviPanda|zzz: bearND dbrant|brb --^ [19:35:22] tfinc: Deskana: Would be great to get more info why he thinks it totally unusable in mainland China. It seems to work for Liangent. [19:42:46] (03CR) 10Florianschmidtwelzow: "Big thanks to you and Juliusz for the explanation, now i know how you mean this :)" (034 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/135311 (https://bugzilla.wikimedia.org/60134) (owner: 10Florianschmidtwelzow) [19:43:04] jdlrobson: thx for your explanation :) So clear after that :P [19:48:04] np FlorianSW [19:48:21] ok going dark… got 8 or 9 employee feedback forms to do [19:48:56] have fun ;) [20:02:59] bearND, tfinc: Interesting. I'll block off 4-5pm to respond to OTRS tickets. [20:03:20] Although I may have to shift it to later in the day, but that's fine. [20:10:47] Deskana: The feedback tfinc mentioned from China came in as an app review on the Play Store (for the latest published beta apk). BTW, there was also a German comment asking if we plan to do anything for the Wiktionary app. Not sure what our plans are there, so I'll defer to you and tfinc. I'd be happy to translate it to German though if you tell me what. [20:11:19] bearND: Do you think my responding in English would be acceptable? It's more acceptable in some cultures than others, so if it's fine then I'd prefer to respond directly. [20:11:49] I had a friend in Poland who tried to speak broken Polish to someone and they snapped at him for "assuming [he] was too stupid to speak English". [20:13:23] Deskana: sure, responding in English is perfectly acceptable, too [20:13:53] Great, thanks. :) [20:16:31] mhurd: Are you available at 4pm to do the signoff for the iOS cards in sprint 32? [20:16:53] Deskana: already double-booked for 4 :) [20:17:00] mhurd: Is 5pm okay? [20:17:04] Deskana: ya! [20:17:11] mhurd: Cool. I'll throw you an invite so I don't forget. [20:17:46] tfinc: I was waiting on getting admin rights on testwiki to sign off on the anon editing Android card. I'll do that after my meetings. And now I'm meeting Monte at 5pm to do the iOS ones. :) [20:18:10] tfinc: I should also have the rest of the cards in the to do on sprint 32 moved out by the end of the day so we can close the board. [20:18:16] (03PS7) 10Dbrant: Save full text of page to filesystem. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/138525 [20:18:30] mhurd: Sent. Thanks. :) [20:21:08] vbamba: mind if we bump design board clean-up to 4:30? [20:22:20] bearND, dbrant, YuviPanda|zzz: Vibha's uploaded the Android mocks for the edit workflow changes, so we're unblocked on that now. :) [20:22:35] Deskana: alright! [20:22:56] Deskana: cool. [20:23:09] Deskana: any word regarding icons exported from wikifont for use in Android? [20:23:57] dbrant: I'm a bit lost about that stuff, honestly. [20:24:05] dbrant: Perhaps send an email to Vibha and Moiz? [20:24:15] * Deskana is hoping the wikifont talk tomorrow will help clear up some of that haze. [20:24:26] Deskana: np, will do [20:34:29] 3MobileFrontend / 3Feature requests: Non-javascript based editing - 10https://bugzilla.wikimedia.org/64923#c5 (10Max Semenik) I have a suspicion that low-end devices also lack good text input methods, except a few phones with physical QWERTY keyboards. Also, they tend to have worse navigation (e.g. controlli... [20:35:42] tfinc, MaxSem: Do we need to give coworker feedback on arthur or just the other mobile web devs and tom? [20:45:29] 3MobileFrontend / 3Feature requests: mobile-friendly templates should be easy to create - 10https://bugzilla.wikimedia.org/65498#c9 (10Max Semenik) 5NEW>3RESO/WON Yes, and you're proposing to multiply this number by 2. [20:56:52] Deskana: thanks for the sign off. i want to close the sprint today [20:57:47] bearND: the wiktionary app is on ice. no plans to pick it up. [20:58:47] tfinc: thanks [21:03:27] (03CR) 10MaxSem: [C: 032] Hygiene: Kill dead variable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/138515 (https://bugzilla.wikimedia.org/64004) (owner: 10Jdlrobson) [21:04:09] (03Merged) 10jenkins-bot: Hygiene: Kill dead variable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/138515 (https://bugzilla.wikimedia.org/64004) (owner: 10Jdlrobson) [21:04:29] 3MobileFrontend / 3Hygiene: Hygiene: Remove disableBackToTop and enableExpandableSections from MobileFormatter.php - 10https://bugzilla.wikimedia.org/64004 (10Max Semenik) 5PATC>3RESO/FIX [21:06:22] (03PS1) 10Yurik: minor bug fix of ZeroConfig value [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/138723 [21:44:17] 3MobileFrontend / 3General/Unknown: Thumbnails for search results don't make sense for most projects - 10https://bugzilla.wikimedia.org/66455 (10Ryan Kaldari) 3NEW p:3Unprio s:3normal a:3None Right now, the search results overlay shows an image thumbnail for each result page. This makes sense for Wik... [21:45:30] 3MobileFrontend / 3General/Unknown: Thumbnails for search results don't make sense for most projects - 10https://bugzilla.wikimedia.org/66455#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/O7qRWbfQ [21:57:12] dr0ptp4kt, https://gerrit.wikimedia.org/r/#/c/138734/ [22:04:57] (03CR) 10Dr0ptp4kt: [C: 032] minor bug fix of ZeroConfig value [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/138723 (owner: 10Yurik) [23:10:17] (03PS3) 10MaxSem: mobileview: return page_props [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/138483 (https://bugzilla.wikimedia.org/64638) [23:39:10] kaldari, do we finally have to review 3-5 people from our core team or everyone? [23:40:15] jgonera: I think we have to review everyone from our core team + tomasz. [23:40:29] jgonera, 3-5 from team AND everyone who specifically requested [23:40:48] MaxSem, was this written in some email or somewhere? [23:40:57] I also asked in person [23:40:57] https://office.wikimedia.org/wiki/WMF_FY_2013-14_Annual_Review_and_Retrospective#Friday.2C_June_6:_Co-Worker_Feedback_due doesn't confirm this [23:41:04] jgonera: the email says it's up to tfinc [23:41:10] not sure I got it right though:) [23:41:18] and I already asked him the same question :) [23:41:23] :) [23:41:35] its the core team that you interact with on a regular basis [23:41:45] i'm trusting you guys to pick the right people and not micro managing it [23:42:07] tfinc, so not only 3-5 people? and you too, right? [23:42:15] and me yes [23:42:23] ok, I see [23:43:00] jgonera: well, there are only 3-4 people possible, right? Depending on if you count arthur. [23:43:51] tfinc: I didn't count Maryana. Should I include her too? [23:43:56] kaldari, Jon, MaxSem, Arthur, Maryana, tfinc [23:44:06] kaldari: you can [23:44:28] aha, SHOULD not MUST:P [23:48:12] OK, I'll review Maryana too [23:48:57] :-P