[00:10:35] (03PS1) 10Yurik: Fixed api status reporting [extensions/JsonConfig] - 10https://gerrit.wikimedia.org/r/138760 [00:10:43] dr0ptp4kt, ^ [00:14:04] (03CR) 10Dr0ptp4kt: [C: 032 V: 031] Fixed api status reporting [extensions/JsonConfig] - 10https://gerrit.wikimedia.org/r/138760 (owner: 10Yurik) [00:14:08] (03Merged) 10jenkins-bot: Fixed api status reporting [extensions/JsonConfig] - 10https://gerrit.wikimedia.org/r/138760 (owner: 10Yurik) [00:25:07] (03CR) 10Kaldari: [C: 04-1] Ensure edit protection is declared when only move permissions exist on page (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/137735 (https://bugzilla.wikimedia.org/65631) (owner: 10Jdlrobson) [00:25:52] moizsyed, vbamba https://www.youtube.com/watch?v=9jK-NcRmVcw [00:59:45] (03CR) 10MaxSem: [C: 032] Ignore tests directory when running `make phpdocs` [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/138491 (owner: 10Jdlrobson) [01:00:19] (03Merged) 10jenkins-bot: Ignore tests directory when running `make phpdocs` [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/138491 (owner: 10Jdlrobson) [01:56:08] (03PS1) 10Yurik: Minor cleanup [extensions/JsonConfig] - 10https://gerrit.wikimedia.org/r/138771 [02:24:56] 3Wikipedia App / 3Android App: Weird "Â" appears on pages in the app - 10https://bugzilla.wikimedia.org/66187#c2 (10Liangent) I want to prioritize this, because this affects Chinese Wikipedia main page. [02:39:44] (03CR) 10Yurik: [C: 032] "self-2+ing to test before depl tmrw" [extensions/JsonConfig] - 10https://gerrit.wikimedia.org/r/138771 (owner: 10Yurik) [02:39:48] (03Merged) 10jenkins-bot: Minor cleanup [extensions/JsonConfig] - 10https://gerrit.wikimedia.org/r/138771 (owner: 10Yurik) [05:18:56] 3MobileFrontend / 3General/Unknown: Thumbnails for search results don't make sense for most projects - 10https://bugzilla.wikimedia.org/66455#c2 (10Florian) +1 from me for this, this will be a good feature for third-party non-Wikimedia Wikis, too, i think. [05:26:17] (03PS6) 10Florianschmidtwelzow: Enable View of "new messages on talk page" without Echo [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/138229 (https://bugzilla.wikimedia.org/56834) [06:09:40] 3MobileFrontend / 3Feature requests: Add intermediate screen to warn logged-out editors similar to 'anoneditwarning' message - 10https://bugzilla.wikimedia.org/59937#c14 (10Jon) I think for the purposes of alpha we could either simply kill the anonymous CTA drawer, or update it to include a link in the drawe... [06:36:59] (03PS1) 10Yurik: Minor ZeroConfig refactorings [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/138783 [06:56:40] (03PS2) 10Yurik: Minor ZeroConfig refactorings [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/138783 [07:34:47] (03PS1) 10Raimond Spekking: Consistency tweaks [extensions/JsonConfig] - 10https://gerrit.wikimedia.org/r/138785 [07:41:44] (03CR) 10MaxSem: [C: 032] Consistency tweaks [extensions/JsonConfig] - 10https://gerrit.wikimedia.org/r/138785 (owner: 10Raimond Spekking) [07:41:48] (03Merged) 10jenkins-bot: Consistency tweaks [extensions/JsonConfig] - 10https://gerrit.wikimedia.org/r/138785 (owner: 10Raimond Spekking) [12:20:11] (03PS1) 10Florianschmidtwelzow: WIP: Enable anonymous editing in alpha mode [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/138802 (https://bugzilla.wikimedia.org/59937) [12:23:25] (03CR) 10Florianschmidtwelzow: [C: 04-1] "Edit button is disabled after the page is saved (and loaded the new version). The upload button appears, too (as disabled)." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/138802 (https://bugzilla.wikimedia.org/59937) (owner: 10Florianschmidtwelzow) [13:39:34] 3Wikipedia App / 3Android App: Media files continue playing when you leave the article or exit the app - 10https://bugzilla.wikimedia.org/66475 (10Sage Ross) 3NEW p:3Unprio s:3normal a:3None If you start playing a media file, for example the one in [[When Johnny Comes Marching Home]], and then naviga... [15:05:59] 3Wikipedia App / 3Android App: Cannot create or edit redirects - 10https://bugzilla.wikimedia.org/66480 (10Sage Ross) 3NEW p:3Unprio s:3normal a:3None In the mobile app, there is no way to view, or edit, or create, redirect pages. Improving redirects is a simple task that I often like to do while br... [15:10:35] hey dbrant, bearND [15:10:51] YuviPanda: hey! [15:11:13] YuviPanda: back safely? [15:11:33] YuviPanda: :) [15:12:10] dbrant: indeed. except my body thinks I'm somewhere in the mid atlantic (woke up a few hours ago) [15:12:25] i can imagine [15:13:44] heh [15:13:59] * YuviPanda looks at trello to figure out who picked up what [15:14:26] YuviPanda: plenty in CR, if you're up for it ;) [15:14:43] dbrant: oh, that's weird. reviewerbot didn't show me anything [15:19:03] dbrant: weird, I think reviewerbot is down [15:19:12] dbrant: I'm CRing your base saved pages patch now [15:20:20] somebody might want to ping Andre to have dbrant and bearND added to the bugzilla cc defaults. [15:20:27] (I got added, so I don' [15:20:34] t report too many dupes) [15:22:00] YuviPanda: been holding off on +2's until we have the whole saved pages features done, so we don't save "Saved Pages" when we still have bookmarks [15:22:22] YuviPanda: in case we want to push another release [15:22:32] bearND: yeah, let me see if I can find qchris (who helps with gerrit issues) [15:23:12] bearND: asking in -operations [15:31:00] (03PS1) 10Yuvipanda: Rename "bookmarks" to "saved pages" [apps/android/wikipedia] (savedpages) - 10https://gerrit.wikimedia.org/r/138829 [15:31:09] bearND: dbrant ^ branches! :D [15:31:32] bearND: dbrant I also created a 'beta' branch [15:32:13] dbrant: let me pull in the other patch as well to the new branch [15:34:52] YuviPanda: nice! [15:35:13] YuviPanda: how did you create the branch in gerrit? [15:35:40] bearND: so first you create a branch by doing 'git push gerrit HEAD:refs/heads/' [15:35:51] and then you can push to it with git push gerrit HEAD:refs/for/ [15:36:15] YuviPanda: so you don't use the git review tool for it [15:37:23] YuviPanda: was wondering for a while: is you gerrit remote the same as origin? [15:37:27] your [15:37:44] bearND: ah, right. stopped using git review ages ago, but that might have an option for this too [15:38:01] gerrit ssh://yuvipanda@gerrit.wikimedia.org:29418/apps/android/wikipedia (push) [15:38:01] origin https://yuvipanda@gerrit.wikimedia.org/r/apps/android/wikipedia (fetch) [15:38:03] bearND: ^ [15:38:49] bearND: (ignore fetch/push) [15:39:10] YuviPanda:ok, my origin is already the ssh one since that's how i cloned the repo [15:39:18] bearND: ah, right. [15:39:34] bearND: 'git review -s' gives me the hook and also sets up a gerrit origin with ssh, which is how I setup the repo [15:41:31] YuviPanda: IIRC i also used 'git review -s'. i've got the hook, and i think i didn't install it manually [15:43:37] bearND: hmm, weird. [15:43:46] bearND: maybe if your origin is already ssh, it doesn't setup 'gerrit' [15:44:34] YuviPanda: yes, that's my theory as well. I've now added the gerrit remote (duplicate of my origin) so the release script doesn't need to be changed so heavily [15:45:39] bearND: ah ok [15:52:58] (03PS1) 10Yuvipanda: Save full text of page to filesystem. [apps/android/wikipedia] (savedpages) - 10https://gerrit.wikimedia.org/r/138832 [15:53:23] dbrant: can you abandon the saved pages changes to master and use the ones I just pushed? [15:53:37] YuviPanda: right. [15:53:46] dbrant: I'll do it for beta now [15:55:08] (03Abandoned) 10Dbrant: Rename "bookmarks" to "saved pages" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/138436 (owner: 10Dbrant) [15:55:27] (03Abandoned) 10Dbrant: Save full text of page to filesystem. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/138525 (owner: 10Dbrant) [16:00:47] dbrant: bearND gah, power cut. No idea when it'll be back [16:00:49] * YuviPanda welcomes self to India [16:00:57] :( [16:06:30] dbrant: re: CR, two issues I spotted was: 1. folder name for page should include site info, since you can have two pages with the same name in different sites [16:06:50] dbrant: second thing was that the delete saved page async task should be a class of its own rather than an anon class [16:07:30] YuviPanda: for the saving of images card: do you think there is much reuse of images between pages? [16:07:44] bearND: sometiems, but not worth the trouble, I'd say [16:07:53] YuviPanda: the saved contents are a JSON dump of the Page object... doesn't that contain site info? [16:08:22] dbrant: yeah, but the folder name that you are deriving the MD5 from won't, so if two pages have the same name across sites, the hashes will clash, no? [16:08:23] YuviPanda: oh wait, nm [16:10:49] YuviPanda: i think i made it too complicated adding two tables in the DB to keep track of images and pages; i guess i'll switch over to just storing the images in a subdirectory of the page [16:13:49] YuviPanda: Also i noticed that on the main page the img tags are not well formed. So the XML parser is not happy. On other pages it seems fine. [16:15:16] bearND: yeah, I specifically wanted to make sure we don't use a db. that's just complicates lots of things, and introduces atomicity issues around delete [16:16:20] YuviPanda: agreed [16:16:37] bearND: also we shouldn't be excluding any images, I think. [16:17:02] bearND: not worth the hassle, and also causes problems in case we want to update them in core. so just //img should be enough, I think [16:18:20] but but but... think of the children! [16:19:32] * YuviPanda thinks of ragesoss [16:19:36] YuviPanda: what do you mean by "in case we want to update them in core."? [16:19:50] bearND: I mean, in case we decide to not hide navboxes, which we do via CSS now [16:20:02] bearND: since css updates are not tied to app updates... [16:20:04] YuviPanda: ok, makes sense [16:21:46] bearND: can you file a bug about MainPage XMLness? Under MobileFrontend [16:22:15] YuviPanda: will do [16:26:29] 3MobileFrontend / 3General/Unknown: img tags are not well formed on main page - 10https://bugzilla.wikimedia.org/66487 (10Bernd Sitzmann) 3NEW p:3Unprio s:3normal a:3None This breaks our XML parse when we try to detect images for the saved pages feature in the Android Wikipedia app. example from yes... [16:30:26] 3MobileFrontend / 3General/Unknown: img tags are not well formed on main page - 10https://bugzilla.wikimedia.org/66487#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/XeXwx61H [16:31:18] YuviPanda: hmm, so how do I push to the new branch now? [16:35:14] dbrant: git push gerrit HEAD:refs/for/ [16:37:09] dbrant: YuviPanda: question about SavedPagePersistanceHelper: shouldn't the getColumnsAdded() method switch statement have case 4 instead of 1? [16:37:11] 3MobileFrontend / 3General/Unknown: img tags are not well formed on main page - 10https://bugzilla.wikimedia.org/66487#c2 (10Max Semenik) We output HTML5 and thus it's not supposed to be a valid XML. Any alternative parsers around? [16:39:04] (03PS2) 10Dbrant: Save full text of page to filesystem. [apps/android/wikipedia] (savedpages) - 10https://gerrit.wikimedia.org/r/138832 (owner: 10Yuvipanda) [16:42:26] 3MobileFrontend / 3General/Unknown: img tags are not well formed on main page - 10https://bugzilla.wikimedia.org/66487#c3 (10Yuvi Panda) Does adding closing tags prevent it from being HTML5 compliant? [16:42:39] dbrant: bearND sorry, network issues [16:43:03] Hmm, bouncer strangeness again. [16:43:04] bearND: no, since the update iterates through all database version, up to the current [16:43:05] Hello! [16:43:33] Deskana: hello! am back in India, and it has welcomed me by cutting all power and putting me on 2G. yay. [16:43:41] YuviPanda: :( [16:44:30] bearND: unless you're adding tables to the db, then put them under case 4 [16:44:32] AITCH ONE BEE [16:44:35] AITCH ONE BEE [16:44:45] Deskana: hehe :D [16:44:49] Deskana: yes sir! [16:45:01] dbrant: but hte tables was added in version 4 [16:45:03] bearND: also, we should fully encapsulate the XML/HTML parsing so we can swap out the parser whenever we want [16:45:06] the table [16:45:22] YuviPanda: done that [16:45:28] bearND: might have been a mistake / issue when we renamed saved pages to bookmarks, unsure. [16:45:54] bearND: ah yes, you're right; because I renamed the table to 'savedpages' [16:45:55] Deskana: I've stopped counting requests at this point, since they majority fit into the three things you mentioned [16:47:24] Deskana: YuviPanda: same for me [16:52:26] Deskana: also, 45,000 beta testers :D and another 24k waiting, perhaps with auto updates turned off [16:55:22] YuviPanda: do you know where we are with extracting icons from Wikifont for use in the app? [16:55:47] dbrant: theoretically vibha is supposed to extract them for us and email them [16:58:02] dr0ptp4kt: heya! feel free to take a poke at the find in page thing. Also feel free to make it 4.0+ only [16:58:35] YuviPanda: k [16:59:53] YuviPanda: which layout file should get the object? an alertdialog-based find is obviously easiest, but if we wan to have a nice overlay in the top right of the viewport, i wanted to make sure i know where to put it [17:00:16] dr0ptp4kt: I'd say put it as search, and have it replace search bar with a find bar when in that mode. [17:00:52] YuviPanda: k [17:02:30] YuviPanda, dbrant: I answered a lot of OTRS tickets and it's mostly in those categories, yeah. [17:02:54] Deskana: thanks for answering! :D [17:03:22] YuviPanda, dbrant: Very few complaints, all in all. There was only one email from an angry person in the entire queue. And that was about the dark theme. :P [17:04:05] Deskana: yeah, saw that. "I AM OUTRAGED" [17:04:06] Deskana: this all caught me completely blindsided, since the previous dark theme was a 3 day hack I built over some weekend... [17:04:25] YuviPanda: I think all of us were as surprised as you... [17:04:26] Deskana: YuviPanda: yes, I'm very pleased that actual crashes have been few and far between. Knock on wood. [17:04:35] * Deskana knocks on wood. [17:04:39] famous last words. [17:04:42] heh [17:05:06] * YuviPanda puts a throw new RuntimeException("WOOD HATES ALL OF YOU GUYS WHO KNOCK ON IT, IT HURTS MAAAAN!"); in an onCreate [17:06:56] catch(RuntimeException lolnope) {} [17:06:59] Good job I was here! [17:08:24] Deskana: :P [17:08:39] Deskana: "ONE LITTLE TRICK THIS PM DISCOVERED! WOOD HATE HIM!!!!" [17:10:33] Haha [17:12:41] 3MobileFrontend / 3General/Unknown: img tags are not well formed on main page - 10https://bugzilla.wikimedia.org/66487#c4 (10Bernd Sitzmann) Other pages have closed tags, only the main page is different. [17:13:34] bearND: shall I commit a change to fix the db version number? [17:14:32] YuviPanda: lol [17:15:27] mhurd: hmm? [17:15:39] jdlrobson: what was the mobile-l post you were just talking about? [17:16:05] standup time! [17:16:36] brion: dbrant bearND won't make it, still on 2G, will juts be too painful [17:16:41] ok :D [17:20:23] jdlrobson: if juliusz doesn't come in, can you go to scrum of scrums? [17:20:23] Deskana|Away: saw the android design mockup, am fairly confused, left comments on the card [17:20:41] (03CR) 10Dr0ptp4kt: [C: 032 V: 031] Minor ZeroConfig refactorings [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/138783 (owner: 10Yurik) [17:20:56] jdlrobson: i want to make sure that we're continually reminding ops and everyone else about the tablet redirect going live on tuesday [17:21:53] (03Merged) 10jenkins-bot: Minor ZeroConfig refactorings [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/138783 (owner: 10Yurik) [17:24:54] MaxSem: kaldari you guys see jon around? [17:25:03] yeah... [17:25:11] hey [17:25:14] jdlrobson: hi :) [17:25:15] thanks :) [17:25:22] what time is scrum of scrums? [17:25:27] jdlrobson: 1030, r31 [17:25:45] erggh is there still a SoS board? [17:25:45] jdlrobson: i can't get in touch with juliusz so i am assuming he won't be in [17:25:52] jdlrobson: yeah [17:25:57] jdlrobson: details are on the calendar invite [17:26:02] and when is the tablet redirect exactly? [17:26:10] jdlrobson: june 17 [17:26:14] tuesday [17:26:24] anything else need reporting? [17:26:40] there is a load of VE stuff in there i know nothing about [17:26:44] * awjr loks [17:27:09] Interesting.. Firefox OS exploration is still there? That's not really happening any more [17:28:09] jdlrobson: lean on the VE folks to fill in any details about the ve cards, otherwise don't sweat it. as for firefox os exploration, adam has been discussing it a bit each week so you may want to folow up with hiim [17:28:16] k [17:28:24] thank you :) [17:28:49] 3Wikipedia App / 3Android App: Clear floating in footer - 10https://bugzilla.wikimedia.org/66322#c1 (10Dan Garry) Liangent, we're not sure what you mean. Can you offer some clarification? [17:32:49] YuviPanda: oh sry was laughing at your “one little trick” comment [17:32:55] mhurd: ah :D [17:33:11] 3MobileFrontend / 3General/Unknown: img tags are not well formed on main page - 10https://bugzilla.wikimedia.org/66487#c5 (10Jon) Isn't this an issue with the parser? I think assuming it is XML is not very future proof. Hopefully one day all of Wikipedia will be HTML5 which doesn't need closed tags. [17:35:09] YuviPanda: You should send an email to Vibha and Moiz about those issues, I think. [17:35:11] 3Wikipedia App / 3Android App: Clear floating in footer - 10https://bugzilla.wikimedia.org/66322#c2 (10Liangent) style="clear:both" in footer. Developers understand this :) [17:35:50] YuviPanda: The second and third are edit screens I think, it's just that the design doesn't indicate that clearly. [17:36:03] YuviPanda: Regarding the buttons though, that's something you should definitely reach out to them about. [17:39:26] awjr_away: ok done. i just waved my hands in the air and said tablet redirect is coming [17:41:06] jdlrobson: perfect :) [17:41:07] jdlrobson: thanks again - i got ahold of juliusz and he overslept :p [17:42:22] tfinc, I have just got up after 10h of sleep and oversleeping the alarm. can we move the 1:1 to Friday? I feel like it's a safer bet [17:43:07] jdlrobson: done. but were sticking to that one then [17:43:12] we've moved this one around enough [17:43:34] tfinc, it's not like I planned this... I still feel a bit sick, I normally don't sleep 10h [17:43:57] jgonera: lets us know if we can do anything for you [17:47:11] MaxSem: The HTML5 spec says that self-closing slashes are fine for void elements such as . They have no effect, but they are valid. [17:47:16] http://dev.w3.org/html5/spec-author-view/syntax.html#syntax-start-tag [17:47:33] yeah, plus that makes the number of parsers that can parse them much higher [17:47:53] it also makes my OCD feel better, and there's not much in the form of bandwidth cost anyway (hello, gzip) [17:51:41] 3MobileFrontend / 3General/Unknown: img tags are not well formed on main page - 10https://bugzilla.wikimedia.org/66487#c6 (10Ryan Kaldari) Just to clarify, self-closing img tags are not necessary in HTML5, but they are allowed and considered valid: http://dev.w3.org/html5/spec-author-view/syntax.html#syntax-... [18:00:28] 3Wikipedia App / 3Android App: Clear floating in footer - 10https://bugzilla.wikimedia.org/66322#c3 (10Yuvi Panda) Not really. I do know what clearing means, but what adverse issues are you seeing because it is uncleared? [18:04:18] mhurd brion: do you have the same issue as https://bugzilla.wikimedia.org/show_bug.cgi?id=66487 on iOS? it only seems to affect saving the main page [18:05:00] bearND: hmm, sounds like it could strike but there should be a way around it [18:05:13] i think libxml2 has a html parse mode or something [18:05:14] bearND: wonder if we should let people save the main page at all, actually [18:05:17] since it changes every day [18:05:27] ^ [18:06:05] true [18:06:10] and if we encapsulate the parser well enough, we can just swap it out later [18:06:12] 3MobileFrontend / 3General/Unknown: img tags are not well formed on main page - 10https://bugzilla.wikimedia.org/66487#c7 (10Brion Vibber) Are you using libxml2 here? There should be an HTML parsing mode which groks the implied-closed img elements I think [18:07:24] (03CR) 10Yuvipanda: [C: 032] Rename "bookmarks" to "saved pages" [apps/android/wikipedia] (savedpages) - 10https://gerrit.wikimedia.org/r/138829 (owner: 10Yuvipanda) [18:08:23] (03PS1) 10Jdlrobson: Optimise mobile site for 240x180 resolution [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/138867 [18:08:28] 3MobileFrontend / 3alpha: Upload icon appears after anonymous edit save - 10https://bugzilla.wikimedia.org/66490 (10Florian) 3NEW p:3Unprio s:3normal a:3None After Change https://gerrit.wikimedia.org/r/#/c/137462/ the upload icon does not appear, if no action is available. If you edit a page in alph... [18:08:42] 3MobileFrontend / 3alpha: Upload icon appears after anonymous edit save - 10https://bugzilla.wikimedia.org/66490 (10Florian) [18:08:58] 3MobileFrontend / 3stable: Filter for New User uploads in Mobile Web - 10https://bugzilla.wikimedia.org/62598 (10Florian) [18:08:58] 3MobileFrontend / 3stable: Filter for New User uploads in Mobile Web - 10https://bugzilla.wikimedia.org/62598 (10Florian) [18:08:59] 3MobileFrontend / 3alpha: Upload icon appears after anonymous edit save - 10https://bugzilla.wikimedia.org/66490 (10Florian) [18:09:24] (03Merged) 10jenkins-bot: Rename "bookmarks" to "saved pages" [apps/android/wikipedia] (savedpages) - 10https://gerrit.wikimedia.org/r/138829 (owner: 10Yuvipanda) [18:09:39] dbrant: CR / merging the other one now [18:09:53] YuviPanda: rockin' [18:10:26] 3MobileFrontend / 3alpha: Upload icon appears after anonymous edit save - 10https://bugzilla.wikimedia.org/66490#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/Pe5yHhES [18:15:56] jdlrobson: https://wikitech.wikimedia.org/wiki/Incident_documentation/20140509-EventLogging [18:16:02] that's the EventLogging incident report I mentioned [18:16:09] milimetric: looking [18:16:12] 3MobileFrontend / 3alpha: Upload icon appears after anonymous edit save - 10https://bugzilla.wikimedia.org/66490#c2 (10Jon) 5NEW>3UNCO The patch you mention hasn't been merged yet. I'm not 100% sure what the problem here is. When I check out the page, enable anonymous editing, I edit the page which needs... [18:16:19] ohh that explains a lot [18:16:22] it affects about a month, from 5/5 to 6/5 [18:16:34] but the biggest drops correspond to the biggest spikes [18:16:39] annoyingly it happened around the time we released a feature so i thought that was the reason for the spike [18:17:03] well, your graphs show a drop around that time, so I think it's safe to say it's because of us [18:18:04] http://mobile-reportcard.wmflabs.org/graphs/ui-daily < so that explains the drop on the start of May? [18:18:56] also that graph seems to stop on june 2nd? i'm confused.. [18:19:29] that might be a separate issue, i'll look at that [18:19:45] mm i'm confused at what data i can trust now :) [18:19:50] but yes, most likely any dips in your graphs starting around 5/5 and recovering on 6/5 are due to this [18:20:06] yeah, i know, this is a major sucky thing [18:20:08] actually none of our graphs have been running since 2nd [18:20:15] what happened was we were going at 40 events per second until multimedia launched [18:20:16] i'm not sure if something else is broken in the script [18:20:29] and they brought it to 500 events per second in a very short amount of time, and the system couldn't cope [18:20:42] in hewiki, clicking on images that appear in the search cause history.back(), any idea why? [18:20:43] now it can do 750 per second after a new fix ori put in [18:20:46] (theoretically) [18:21:03] YuviPanda: fresh bug report for you [18:21:12] matanya: oh? OTRS? [18:21:17] * YuviPanda checks [18:21:27] no, he.wiki help desk [18:21:27] matanya: or are you reporting it just now on IRC? :) [18:21:33] matanya: oh? can you translate / tell me? [18:21:36] ^^ [18:21:42] hi eranroz [18:22:02] hi matanya :) [18:22:37] YuviPanda: yes, sure. one android 4.3, using chrome when you search you get results [18:22:46] n hewiki, clicking on images that appear in the search cause history.back(), any idea why? (Android 4.4.3 for both firefox and chrome) [18:22:53] milimetric: so 1) how can i check if the cronjob is working correctly on our Limn graphs 2) we should probably force run all the graphs that use daily caching for that date period to ensure they are accurate [18:22:54] but when you click on one you re redirected to main page [18:23:13] matanya: yeah, that was an intermittent bug that was fixed in beta5, I think. released on Monday (or Friday, unsure) [18:23:20] matanya: so if they had an older version of the beta, that would appear [18:23:52] jdlrobson: 1) i'm just trying to run the scripts on stat1003 to see if they break [18:23:56] so latest beta is fixed YuviPanda ? [18:23:59] matanya: yes [18:24:11] 3MobileFrontend / 3General/Unknown: img tags are not well formed on main page - 10https://bugzilla.wikimedia.org/66487#c8 (10Max Semenik) Main page is different because we rewrite it for mobile, but there's no guarantee that other pages will not be processed too e.g. for image removal or Zero. [18:24:25] jdlrobson: 2) that's up to you, but the data in event logging hasn't been fixed / changed so if the reports ran they're most likely reflecting the latest [18:25:28] thanks YuviPanda [18:25:46] matanya: thanks for reporting, matanya. can you tell that to the person who reported? [18:26:00] already did :) [18:26:06] MaxSem: Strangely desktop en.wiki seems to make all img tags self-closing by default, but my local instance doesn't. Any idea what controls that? [18:26:06] Deskana: I had questions / confusions on https://trello.com/c/zHmmH2xT/74-design, can you look as well to make sure I'm not missing something obvious? [18:26:13] sorry for stealing your thunder eranroz [18:26:26] kaldari: tidy, I presume. [18:26:32] kaldari: we turned it off for mobile a while ago [18:26:38] ah [18:26:43] kaldari, see my latest comment: it's main page special-casing [18:26:58] MaxSem: wouldn't tidy close them anyway? [18:27:53] YuviPanda: Hey! Basically I think it's relatively clear that they intended for the second and third screens to be edit screens. [18:28:14] no. it's perfectly legal HTML [18:28:22] YuviPanda: The button styling stuff I would take up with them directly, though. We want to make sure that the app is consistent with Android design principles, and you probably know that best. [18:28:40] MaxSem: hmm, alright. and the text at the bottom is just leftover from something else, I presume [18:28:54] gah, I meant Deskana [18:28:59] MaxSem: hmm, right. [18:29:23] YuviPanda: The text at the bottom? [18:29:34] YuviPanda: Not sure what you mean by that. [18:29:52] Deskana: https://trello.com/c/zHmmH2xT/74-design has 'Per android design guidelines long press to select an item' [18:30:12] Oh, I didn't see that text, it was clipped off the bottom of the design for me. [18:30:13] * Deskana looks. [18:30:20] Yeah, I have no idea what that means. [18:30:49] Deskana: ok [18:31:00] Deskana: I pinged vibha on that card as well, and since she's not here hopefully she'll respond on trello [18:31:05] YuviPanda: Send a quick email to Vibha/Moiz? CC me too. :) [18:31:14] jdlrobson: I can run the scripts fine on stat1003 [18:31:24] gr, we have to log errors from that cron job of yours somewhere, this is silly [18:31:30] Deskana: also, re: saved pages, a lot of work is done atm, actually ( dbrant is awesome!) but they won't be on the alpha builds until we get them all in. so we can just delay signoff till the last story is completed, I guess [18:31:45] Sure, makes sense. [18:31:55] Deskana: cool. [18:31:58] Are you guys okay for work or do you need more cards? [18:32:11] The backlog's a bit of a disaster right now, I've not had the time to sort it out. [18:32:22] Some day soon you'll just be able to go in there and pull stuff out really easily... [18:32:36] YuviPanda: I wasn't sure if you were going to pick up the Edit Workflow card... [18:32:40] Deskana: heh :) the backlog I think is mostly dead and needs to be rebuilt. [18:32:48] dbrant: no, feel free to go ahead and pick it up :) [18:33:02] dbrant: bearND in general, I'm going to leave as much UI work as possible to you guys :) [18:33:10] sounds good [18:33:13] YuviPanda: Tomasz and I chatted about this yesterday. We agree. But keeping the team moving forwards on the release stuff is a higher priority to me now. [18:33:25] The only person the clusterfuck backlog is affecting right at this moment is me, and I'm okay with that. [18:33:35] Deskana: oh completely agreed, just talkign about it in general terms [18:33:44] Deskana: I *think* we will run out of cards by end of week. [18:34:00] Deskana: I see only two cards in todo, and edit workflow is going to be picked up soon. that leaves us with icons, which is more vibha work than us work anyway. [18:34:59] Okay, I won't worry about it right now, then. [18:35:07] Deskana: yeah, cool. [18:35:16] Onboarding would probably be a great thing to pick up. Imagine if we could have that in first release! [18:35:39] Deskana: yeah, I agree too. And it wasn't too hard... [18:35:57] Deskana: and this is also something I mentioned previously. 3 of the saved pages cards were interdependent enough to be one large patch, so it's not very parallelizable. [18:37:03] YuviPanda: Would you have handled this situation differently? [18:38:41] 3MobileFrontend / 3alpha: Upload icon appears after anonymous edit save - 10https://bugzilla.wikimedia.org/66490#c3 (10Florian) 5UNCO>3NEW Ah, sorry, my fault. I mean this change: https://gerrit.wikimedia.org/r/#/c/137461/ In attachment is a little video :) Main problem is that the edit button is deacti... [18:38:56] 3MobileFrontend / 3alpha: Upload icon appears after anonymous edit save - 10https://bugzilla.wikimedia.org/66490#c4 (10Florian) Created attachment 15629 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15629&action=edit Screencapture [18:39:02] mhurd: Do you have the etherpad for that meeting we were just in? I've lost it already. :P [18:39:17] Deskana: no i dont :( [18:39:32] brion: Do you? :) [18:40:55] Deskana: i can work with YuviPanda on android onboarding in the next few days [18:41:02] YuviPanda: what do you think? [18:41:22] lemme pull it back up [18:41:38] Deskana: https://etherpad.wikimedia.org/p/iosrelease [18:41:45] brion: Thank you! [18:41:58] “reopen closed tab” is best feature evar in browser :D [18:44:11] chrismcmahon: what's the current state of our browser tests? https://integration.wikimedia.org/ci/view/Mobile/job/browsertests-MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-firefox/ is a complete mess and I notice https://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-firefox/ has been disabled [18:44:18] thus none of our tests are reliably working :( [18:44:19] brion: Until they implement "reopen the tab you closed on your other computer that you just turned off", I'll be left wanting sometimes. :P [18:44:28] (I use my desktop for video calls as it's got a better setup) [18:44:40] Deskana: that’s what cross-device browser sync is for ;) [18:44:48] now if i could get safari to talk to firefox… [18:45:19] Deskana: sorry, network issues [18:45:32] Deskana: no, but we could've pushed up new cards from the start, but then at that point itself we were like 'if need more cards we can pick them up', so it's pretty much the ideal thing. [18:45:35] jdlrobson: underpowered host for WMF builds: https://bugzilla.wikimedia.org/show_bug.cgi?id=66449 [18:45:37] that we did [18:45:40] Deskana: so it's all right [18:46:20] YuviPanda: Good. Was just wondering if I could've done this better somehow. [18:46:26] YuviPanda: Thanks. :) [18:46:44] Deskana: no sir. in fact the fact you pinged now to check if we need more cards means you pretty much handled it the best way :) [18:46:47] chrismcmahon: :-( can we re-enable the old one in the meantime? [18:46:51] (on cloudbees) [18:46:51] jdlrobson: sure [18:46:56] YuviPanda: \o/ [18:47:01] Deskana: \o/ indeed :D [18:47:10] chrismcmahon i think we should only disable them both when we are ready to make the switch [18:47:33] jdlrobson: Did you mean to remove the search interface for small devices on purpose? [18:47:43] Deskana: re: baselines for workflow, have you checked with StevenW to see if they have data for edit completion rates on desktop? if we can make that a card at some point and do that work ourselves, it's not too much work [18:48:02] We do have it. [18:48:25] jdlrobson: improvements to WMF coming tomorrow and friday [18:48:25] YuviPanda: No, I haven't checked with him, but you just did. ;) [18:48:27] StevenW: woo! :D on apps it's about 12% (click edit button -> save edit) [18:48:47] StevenW: and 24% from 'click edit' -> 'preview'. [18:49:23] Preview is (presently) mandatory in the app though, so the only data that's comparable between desktop and apps is the first number, the success rate from edit to save. [18:49:31] yeah [18:49:35] Deskana: do we have mobile web rates, though? [18:49:38] jgonera: i need to get you to jump in on the mobile web goals thread [18:49:49] * Deskana pings Maryana for those numbers. [18:49:49] jgonera: do take a look at what jdlrobson sent out [18:50:08] tfinc, I have read through most of the replies, I'll post mine today [18:50:09] which #s? [18:50:32] Maryana: 'edit pencil -> save' numbers on mobile web [18:50:48] ah, yeah, i can get you those. what period of time? last week? [18:51:02] Maryana: yeah, that should suffice I think [18:52:29] Deskana: when we plan out the dashboard, we should include these numbers in it too, I think [18:55:37] YuviPanda: Deskana - 54077 attempts, 41738 saves [18:55:39] (03CR) 10Kaldari: [C: 04-1] "I would prefer that we remove the sidebar menu rather than search." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/138867 (owner: 10Jdlrobson) [18:55:57] 77% completion rate [18:56:07] err, wait.. actually [18:56:11] 54077 presses of edit, and 41738 saves? [18:56:16] That sounds... impossible. [18:56:18] 26467 successful saves [18:56:32] Overall success rate of around 50%. Hmm. [18:57:08] so yeah, that's ~49% [18:58:34] Interesting. [18:58:46] that does seem pretty high, yeah [18:59:09] i should look at the numbers from before they made the overlay changes [18:59:12] i bet they were higher [19:03:31] jdlrobson: https://gerrit.wikimedia.org/r/#/c/138884/ adds logging to your job, but I am shitty at puppet [19:03:48] if anyone can help with adding log-rotate there, we could merge it and find out wth is going on with our data :) [19:14:41] 3MobileFrontend / 3alpha: Upload icon appears after anonymous edit save - 10https://bugzilla.wikimedia.org/66490#c5 (10Jon) Okay. It looks like https://gerrit.wikimedia.org/r/#/c/137462/ fixes this though. [19:14:46] bearND: ping. how are we going to rewrite the image urls to point to the local image files instead of remote ones? [19:14:50] bearND: on read or on write? [19:15:32] 3MobileFrontend / 3alpha: Upload icon appears after anonymous edit save - 10https://bugzilla.wikimedia.org/66490#c6 (10Jon) 5NEW>3ASSI See Id10804beae1948942b1a4f62898904b7baf839a2 which hides this whenever it is not available. [19:16:06] YuviPanda: i'm looking at this right now. Currently I'm considerign switching to jsoup: http://jsoup.org/cookbook/modifying-data/set-attributes [19:16:29] YuviPanda: this would also avoid the XML parser issues [19:16:45] YuviPanda: any resevations about using jsoup? [19:16:49] bearND: true. I wonder if it'll cause memory issues, but no way to figure out but try I guess :) [19:17:01] bearND: no, as long as all the parser stuff is encapsulated well enough :) [19:18:37] (03PS2) 10Florianschmidtwelzow: WIP: Enable anonymous editing in alpha mode [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/138802 (https://bugzilla.wikimedia.org/59937) [19:18:49] (03CR) 10Jdlrobson: [C: 04-1] "I'm still getting" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/138229 (https://bugzilla.wikimedia.org/56834) (owner: 10Florianschmidtwelzow) [19:19:38] (03CR) 10Jdlrobson: Enable View of "new messages on talk page" without Echo (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/138229 (https://bugzilla.wikimedia.org/56834) (owner: 10Florianschmidtwelzow) [19:20:44] (03CR) 10Jdlrobson: [C: 032] mobileview: return page_props [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/138483 (https://bugzilla.wikimedia.org/64638) (owner: 10MaxSem) [19:21:11] (03Merged) 10jenkins-bot: mobileview: return page_props [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/138483 (https://bugzilla.wikimedia.org/64638) (owner: 10MaxSem) [19:21:16] (03PS3) 10Yuvipanda: Save full text of page to filesystem. [apps/android/wikipedia] (savedpages) - 10https://gerrit.wikimedia.org/r/138832 [19:21:25] (03CR) 10Yuvipanda: [C: 032] Save full text of page to filesystem. [apps/android/wikipedia] (savedpages) - 10https://gerrit.wikimedia.org/r/138832 (owner: 10Yuvipanda) [19:21:27] dbrant: ^ :D [19:21:34] dbrant: I just updated commit message to mention deletion [19:21:42] chrismcmalunch: when you get back from lunch can you force a run of https://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-firefox/ ? [19:21:55] YuviPanda: yay! [19:22:05] dbrant: :D [19:22:23] bearND: make sure to base your commit on top of the savedpages branch rather than master [19:22:44] (03Merged) 10jenkins-bot: Save full text of page to filesystem. [apps/android/wikipedia] (savedpages) - 10https://gerrit.wikimedia.org/r/138832 (owner: 10Yuvipanda) [19:22:51] YuviPanda: sure [19:22:52] (03PS2) 10Yuvipanda: Correctly set email subject when sharing page. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/138334 (owner: 10Dbrant) [19:22:58] (03CR) 10Yuvipanda: [C: 032] Correctly set email subject when sharing page. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/138334 (owner: 10Dbrant) [19:23:15] dbrant: bearND think we can ship an alpha with saved pages before end of week? [19:23:19] (03Merged) 10jenkins-bot: Correctly set email subject when sharing page. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/138334 (owner: 10Dbrant) [19:24:55] YuviPanda: i think that should be possible. i probably would stagger the releases a bit, so alpha first and after a while when it looks good push to beta. [19:25:09] bearND: yeah, makes sense. [19:26:56] jdlrobson: with the patch not merged to hide upload button the upload button is visible and activated after save page as anon in alpha :) [19:27:28] FlorianSW: I cannot replicate - are you sure you haven't made any changes to the codebase? [19:27:51] also code for refreshing page in alpha is exactly the same as stable [19:27:56] so shouldn't be any difference [19:28:42] anyway this is why $wgMFAnonymousEditing is documented as being without warranty ;-) [19:28:51] i have deleted complete git repository, load new from master and then load your patchset :) But if you've tested it, i will look into it :) (I have seen, that the reload method is the same, so i thougt i oversaw anything) :) [19:28:55] Yeah :D [19:29:43] the main reason why i enter the bug is, that the edit button is deactivated after edit (look https://gerrit.wikimedia.org/r/#/c/138802/) [19:30:47] okay actually I think I can replicate this now [19:30:51] but it should be fixed as part of my patch [19:30:58] YuviPanda: Do you know a good way to replace the content in a Section object? [19:31:14] bearND: so, I was thinking we should rewrite the tags when we read them [19:31:17] bearND: before we save them [19:31:22] bearND: thoughts? [19:31:33] bearND: so we wouldn't have to do any replacement on loading the saved page [19:31:38] (03CR) 10Jdlrobson: [C: 04-1] "Florian points out if $wgMFAnonymousEditing = true and I got to a page that has no image on it and I click edit and save, then the upload " [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/137462 (owner: 10Jdlrobson) [19:31:41] ^ FlorianSW [19:31:53] bearND: section and page are supposed to be immutable, so no. ideally I wouldn't like to change that [19:32:24] YuviPanda: yes, i agree that we should replace before save. it makes it easier and is also better for consistency. [19:32:41] jdlrobson: puh :) No fault in my test installation :D that would be terrible :P [19:33:11] bearND: yeah, cool. we should save the original URL in 'data-img-src' or something on the same element though, just in case [19:33:49] jdlrobson: maybe it's help to know, that the edit button is deactivated with the "enable anonymous edit" patch, too. I think this is the same problem, maybe? [19:34:44] Deskana: yay for setting iOS release date :) [19:34:58] YuviPanda: i share your reservation about modifying section content. Just need to find a way to store the modified pages until all img urls are replaced. [19:35:14] bearND: ah, hmm. that's true. [19:38:33] YuviPanda: Excited! [19:38:34] SOON [19:38:50] Deskana: yeah :D I'm a bit worried about pre-testing though. [19:39:05] Deskana: have you looked at the reviews on the iTunes store? Gave me a big fat depression when I used to. [19:39:38] YuviPanda: For the old app? [19:39:43] Deskana: yeah [19:39:59] I have not. [19:40:11] (03CR) 10Florianschmidtwelzow: Enable View of "new messages on talk page" without Echo (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/138229 (https://bugzilla.wikimedia.org/56834) (owner: 10Florianschmidtwelzow) [19:40:50] (03PS6) 10Jdlrobson: Don't show photo upload icon when no action is possible [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/137462 [19:40:57] I have to dash! We'll pick this up again later. [19:41:30] Deskana: ok! :) [19:45:26] (03CR) 10Florianschmidtwelzow: [C: 031] Don't show photo upload icon when no action is possible [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/137462 (owner: 10Jdlrobson) [19:46:15] yurikR: MaxSem what's left on https://www.mediawiki.org/wiki/Requests_for_comment/Reducing_image_quality_for_mobile - can we close it? [19:46:42] 3MobileFrontend / 3Feature requests: mobileview should return __NOEDITSECTION__ status - 10https://bugzilla.wikimedia.org/64638 (10Jon) 5PATC>3RESO/FIX [19:47:13] FlorianSW: are you taking a look at the php documentation for special pages? [19:47:32] sumanah, the core feature is in production, but it is on our todo to start using it in zero and or mobile [19:47:44] jdlrobson: Jap, it's on my plan, i think this weekend, maybe earlier :) [19:47:46] FlorianSW: i can take care of that if not [19:47:50] ok cool [19:47:52] yurikR: can we close the RfC as implemented? [19:48:04] basically are you awaiting anything [19:48:15] or can I take it off the docket of "things that need other people's opinions" :-) [19:48:42] sumanah, it needs people's opinion on how to start usinhg it :) [19:48:52] there was an email about it a few days ago [19:49:09] to mobile-l i think [19:49:22] awjr, Maryana, I'll be a bit late for the 1pm meeting... [19:49:24] ok yurikR it'll go into today's lightning round :) [19:50:43] i have a big depl today :( [19:51:15] jgonera_: ok - we might have to sync up with design sometime later today, because both moiz & kaity are in a growth quarterly review now, so we won't have them for the meeting, either [19:51:20] I heard that image quality, templates, and services are the topics of the RfCs that mobile cares most about - so I presume that's Storage service, Services & narrow interfaces, HTML templating, URL shortener, PHP Virtual REST service, SOA Auth, Allow styling in templates [19:51:32] bearND: hmm, potential perf issues with jsoup http://stackoverflow.com/questions/10291767/is-there-anything-faster-than-jsoup-for-html-scraping [19:51:41] bearND: but they were dealing with much larger HTML blobs I guess [19:51:53] * sumanah hears "html scraping" and perks her ear up [19:52:00] bearND: and re: temp storage, I guess we'll just have to do a 'processPage' process which goes through each section and creates a duplicate page object with the new sections [19:52:09] Maryana: orly? is the design related work on the must have cards clear enough or would it be prudent to reschedule the mtg for tomorrow? [19:52:18] Maryana: I'll come for a bit of the meeting [19:52:25] bearND: ah, hmm. maybe that person's perf issues were because of debug mode, so might be alright. [19:52:51] awjr: if kaity can be there for some of it, might be ok.. [19:53:50] but rescheduling for tomorrow would be a safer bet, probably [19:54:25] would also give kaity more time to prep assets & such :) [19:54:27] Maryana: let's reschedule for tomorrow; i think it would be better to have design there the whole time [19:54:33] yeah, makes sense [19:54:36] k [19:54:39] thanks :) [19:54:47] Maryana: yay! [19:55:00] Maryana: jdlrobson jgonera_ kaldari kaity moizsyed MaxSem: we're rescheduling the estimation mtg for tomorrow so the designers can be there since they're in a quarterly review mtg [19:55:07] Maryana: can you spread the word in the office? [19:55:09] perfect [19:55:11] i'll reschedule it now [19:55:13] will do [19:55:15] thanks, d00d [19:55:31] kaity: moizsyed - next time let me know sooner beforehand so we can accommodate ;) [19:55:39] violetto: ^^ [19:55:48] sorry, my bad [19:56:44] blame moiz. for everything. [19:56:51] that's my strategy. [19:57:04] speaking of which [19:57:11] moizsyed: i may not be able to accommodate your schedule tomorrow [19:57:22] moizsyed: are you ok with that so long as kaity and violetto are there? [19:57:33] unless you have some flexibility in your calendar events [19:58:52] tfinc: Today I checked with your folks and am happy to help them get feedback on the reduced image quality implementation https://www.mediawiki.org/wiki/Architecture_meetings/RFC_review_2014-06-11 - that's in about an hour [19:59:53] sumanah: heya! http://www.mediawiki.org/wiki/Requests_for_comment/URL_shortener#Tim.27s_implementation_suggestion seems to have clearish next steps (implmenet whatever Tim mentioned, which looks rather sane to me). I'll probably fork Extension:ShortURL and get to it. I'll keep you updated! [20:00:23] yurikR or MaxSem - invited you to the meeting [20:01:19] YuviPanda: cool, mind if I put that in the RfC status? [20:01:24] sumanah: sure [20:02:08] sumanah: https://github.com/yuvipanda/ShortURLv5 is the repo, I'll migrate it to gerrit in a few days [20:02:28] hey mhurd [20:02:35] YuviPanda: heya! [20:03:01] thank you awjr [20:04:02] bearND: hey did you msg me? i was in a meeting and lost the msg :( [20:04:07] mhurd: heya [20:05:07] YuviPanda: have you safely arrived? [20:05:33] mhurd: indeed! [20:05:47] sumanah: ty [20:07:43] mhurd: no, i'm good. But since you are here: I was wondering if you can extract all img tags from the main page on iOS, due to the issue with the XML parser (https://bugzilla.wikimedia.org/show_bug.cgi?id=66487) [20:08:02] bearND: lemme check... [20:08:11] mhurd: was attending the same meeting via hangout on air [20:08:22] bearND: cool :) [20:11:54] bearND: it looks like it works fine - on todays main page it finds 2 image tags [20:12:39] bearND: what XPATH library are you using? [20:13:07] mhurd: cool. looks like you're in good shape on iOS then. [20:15:59] mhurd: I'm getting org.apache.xpath.jaxp.XPathFactoryImpl from XPathFactory.newInstance() [20:16:05] yurikR, https://gerrit.wikimedia.org/r/138905 [20:16:55] bearND: can you tell that library that it’s not parsing xhtml so it doesn’t assume the trailing slash is required? [20:18:29] bearND: the process/libraries i use on iOS are defined here in case it helps: http://www.raywenderlich.com/14172/how-to-parse-html-on-ios [20:18:56] mhurd: maybe. Are you using the XML parser also for rewriting the URLs? [20:19:16] bearND: i don’t rewrite them [20:19:49] mhurd: how do you get the saved page to use the stored images? [20:20:36] mhurd: are you just relying on the cache? [20:25:47] (03CR) 10Kaldari: [C: 04-1] Hygiene: Make icons in overlays and drawers global and reusable (033 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/133190 (owner: 10Jdlrobson) [20:27:37] YuviPanda: one more bug for you [20:27:41] mhurd: sure [20:27:42] err [20:27:43] matanya: sure [20:28:18] when the apps crashes or the devices reboots and you open the app back afterwards - you are shown as still logged in [20:28:31] if you edit - you are in fact edit as anon [20:28:38] matanya: oh, that... ugh, is bad. [20:28:59] matanya: can you ask the person to 1. log out ('more' menu) and log back in, and 2. see if this is still a problem? [20:29:16] it is on my device [20:29:20] and i did that [20:29:25] and that fixes it [20:29:31] but it is misleading [20:29:47] bearND: no i listen in to the requests the web view makes for images. if i see it’s requesting an image which i don’t have in the core data store i allow it to proceed retrieving and presenting the image data, but i route the data to the core data store too. if i see it’s requesting an image which i *do* have in the core data store i directly return that image data so i doesn’t even have to proceed with the network request [20:29:48] i saw my edits on the computer, and saw there were anon [20:29:48] matanya: it is a bug, yes, but it's been something I've not had much luck replicating :( [20:30:03] i can do that every time [20:30:08] matanya: I agree it's a serious bug, am just trying to figure out ways to reproduce. [20:30:10] just reboot the device [20:30:12] matanya: oh, 1. app crash / reboot? [20:30:16] yes [20:30:17] hmm, that's not been the case for me [20:30:23] but let me try in a bit [20:30:30] bearND: it was tricky :) [20:30:43] i'll see if i can take this further [20:30:44] bearND: but it’s nice and seamless [20:31:04] bearND: and transparent to the webview [20:31:07] bearND: iOS has a fairly different architecture that is pretty much 'offline first', which saves everything to disk on every page view and then loads them from the disk [20:31:35] bearND: that’s not quite how it works [20:31:47] bearND: but it is very different [20:31:55] mhurd: thanks for the explanation! [20:32:02] bearND: np! :) [20:32:08] YuviPanda: mhurd: i guess we can't do that on Android [20:32:45] bearND: yeah. the intercept-requests feature is 4.0+ only, so we can't really do much there [20:33:21] bearND: if you can intercept or listen in on the network requests at some level you’ll find it simplifies everything as the html won’t have to be re-written at all. oh i see yuvi’s 4.0+ comment… bummer :( [20:39:29] rfarrand: thanks for all the help with the meeting! [20:39:40] mhurd: np :) [20:39:47] MaxSem: did we ever settle on a PHP templating thing at all? [20:39:51] does Mantle have something for it? [20:40:05] we didn't [20:40:16] MaxSem: and Mantle only has JS templating? [20:40:17] mantle is between us and flow [20:40:29] yes? [20:40:42] ok, just wanted to check [20:46:49] (03CR) 10Jdlrobson: Hygiene: Make icons in overlays and drawers global and reusable (033 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/133190 (owner: 10Jdlrobson) [20:53:24] YuviPanda: how is being back in India? [20:53:52] (03PS6) 10Jdlrobson: Hygiene: Make icons in overlays and drawers global and reusable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/133190 [20:53:54] (03PS6) 10Jdlrobson: Hygiene: Icon cleanup [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/133189 [20:53:54] YuviPanda: can you respond on the thread with Tim about image scaling ? [20:54:00] tfinc: 2h powercut today, *way* too many people everywhere, and about 40C weather. need to go to college tomorrow in the heat to get my papers done. [20:54:20] so you no longer need a blanket [20:54:44] tfinc: indeed. I'd die in a blanket here [20:54:51] MaxSem: yurikR tfinc 6 minutes till RfC review in #wikimedia-office on HTML templating, image quality for mobile, and debugging for production servers [20:55:03] thanks sumanah [20:55:32] sumanah, i can't - big depl :( [20:58:17] yurikR: can dr0ptp4kt be there in your place ? [20:58:43] (03CR) 10Jdlrobson: [C: 04-1] "This isn't a hygiene patch.. it pushes mediawiki ui buttons to stable :)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/135137 (owner: 10Kaldari) [20:59:53] tfinc yurikR sumanah i will try to follow that channel while this is going on, and will be testing things at the same time as yurikR deploys things [21:00:52] Hee [21:08:37] YuviPanda: 40C? [21:08:46] YuviPanda: I am reasonably sure I have never even experienced a temperature as high as that. [21:08:48] Deskana: yeah, cooled down a bit from the last few days [21:08:56] Cooled down? [21:08:59] * Deskana would die in India. [21:09:21] Deskana: it's actually far cooler now, only 32-33, but that's also because it is 3:40 AM [21:09:22] err [21:09:24] 2:40 AM [21:09:59] "only" [21:10:45] Deskana: the usual route for such people visiting India is Ladakh / Leh / Kashmir / Himachal during the summer (14-17C), and then Goa / south during the winter (where it's about 20-25) [21:11:24] I'm from the UK where the weather is pretty much the same in all of the country. [21:11:29] winter is a stalkword for me. [21:11:34] Then I move to the US and can't get my head around the weather here. [21:11:43] It's so different across the country. [21:11:47] Now India blows my mind. [21:12:19] Deskana: heh. I'm sure the US also has similar ones. Tuscon is 39C atm [21:12:35] Tucson, I think [21:12:41] wherever awjr is at :) [21:12:57] i am actually in NH atm :) [21:13:07] awjr: Not Here? :) [21:13:16] ha [21:13:18] New Hampshire [21:13:25] (03CR) 10Kaldari: [C: 032] Don't show photo upload icon when no action is possible (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/137462 (owner: 10Jdlrobson) [21:13:26] :D [21:13:53] currently 19C, very pleasant [21:14:00] Tucson is ~39C atm [21:15:20] awjr: :D at least no power cuts [21:15:37] Deskana: India visit is highly reccomended, though. Just do a bit of research before you leave and you'll be allrighhhtt [21:17:24] YuviPanda: Oh, by the way... [21:17:36] YuviPanda: This card: https://trello.com/c/wOWeKmL2/31-ip-block-is-not-detected-and-saving-using-a-blocked-ip-crashes-the-app [21:17:39] YuviPanda: truth :) [21:18:06] Deskana: right. so there's no way to figure out anon edits beforehand because of cache issues. [21:18:17] * Deskana sighs. [21:18:21] Deskana: if it is uneditable because of protection, that's fine. [21:18:35] Deskana: however, IP blocks aren't really cacheable, so... that won't really work. [21:18:42] (03PS2) 10Jdlrobson: Ensure edit protection is declared when only move permissions exist on page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/137735 (https://bugzilla.wikimedia.org/65631) [21:18:43] Can you query the API for this somehow? [21:18:50] ok, we're now talking about the Reducing Image Quality for Mobile implementation in #wikimedia-office [21:18:57] 3MobileFrontend / 3Feature requests: Enable red links on stable version of MobileFrontend - 10https://bugzilla.wikimedia.org/55500 (10Maryana Pinchuk) 5ASSI>3RESO/FIX [21:18:58] If not then I think we have a feature request for the API. :P [21:19:09] Deskana: we can, but I don't want to query the API again on every single pageview, since then that becomes the same cache problem we had with putting it into mobileview [21:19:29] Deskana: one thing we can do is perhaps query it after the user gets into the edit workflow and warn them at that point, but I dunno at what point to warn them. [21:21:11] Well if it's a "no easy solution" then I'll sign off on it since it accomplished the achieved goal (i.e. it doesn't crash anymore). :P [21:21:27] But we should revisit later to see if there's a better solution. [21:22:00] Deskana: indeed. maybe put it in the backlog. [21:23:10] Deskana: if you want to tweak the wording though, do let me know [21:26:56] 3MobileFrontend / 3beta: Nearby scrolls the page even if it is not required - 10https://bugzilla.wikimedia.org/58482#c8 (10Maryana Pinchuk) 5UNCO>3RESO/FIX Closing as fixed because the UI has changed a lot since the bug was originally reported. Feel free to reopen if still an issue. [21:28:13] 3MobileFrontend / 3General/Unknown: Upload page action doesn't belong on file pages - 10https://bugzilla.wikimedia.org/66500 (10Ryan Kaldari) 3NEW p:3Unprio s:3normal a:3None Right now, if you're logged in and you go to a page in the File namespace, there is an Upload page action button. It's not cle... [21:30:12] 3MobileFrontend / 3stable: Image tag for enwiki project logo should specify dimensions and use a stable URL - 10https://bugzilla.wikimedia.org/58886#c4 (10Juliusz Gonera) Ori, is this really a performance issue? I can't imagine one image slowing down rendering significantly. [21:30:27] 3MobileFrontend / 3General/Unknown: Upload page action doesn't belong on file pages - 10https://bugzilla.wikimedia.org/66500#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/tsl4Kj5p [21:30:38] jdlrobson: Could you take a look at this bug that is slightly related to https://gerrit.wikimedia.org/r/#/c/137462/? I went ahead and merged the change, but want to fix this in a follow-up. [21:30:56] https://bugzilla.wikimedia.org/show_bug.cgi?id=66500 [21:32:34] kaldari: this was by design if you look at git blame.. [21:32:44] https://bugzilla.wikimedia.org/show_bug.cgi?id=58311 [21:35:26] 3MobileFrontend / 3General/Unknown: Upload page action doesn't belong on file pages - 10https://bugzilla.wikimedia.org/66500#c2 (10Jon) I think the purpose of this was to show an upload button on an empty file page - see bug 58311 The 3rd point seems like an issue. I think the second part is an oversight bu... [21:36:20] (03PS1) 10Yurik: Shorter caching of error states, optimized validators [extensions/JsonConfig] - 10https://gerrit.wikimedia.org/r/138998 [21:36:29] jdlrobson: Ah, I see. In that case, we just need to disable it for file pages that already exist. [21:36:37] yeh or revert that patch [21:36:41] 3MobileFrontend / 3General/Unknown: Upload page action doesn't belong on file pages - 10https://bugzilla.wikimedia.org/66500#c3 (10Jon) (We might want to revert the fix to bug 58311 in the meantime) [21:36:42] whatever is esiest [21:36:46] i'd prefer fixing it if we can :) [21:36:56] 3MobileFrontend / 3Feature requests: Disable video and audio tags when not supported - 10https://bugzilla.wikimedia.org/58948#c3 (10Juliusz Gonera) Can you provide specific examples of pages and devices where this is a problem? Maryana and I checked on iPad and the browser simply shows a message saying that... [21:37:11] 3MobileFrontend / 3Feature requests: Disable video and audio tags when not supported - 10https://bugzilla.wikimedia.org/58948 (10Juliusz Gonera) 5NEW>3UNCO [21:38:11] 3MobileFrontend / 3stable: Image tag for enwiki project logo should specify dimensions and use a stable URL - 10https://bugzilla.wikimedia.org/58886#c5 (10Ori Livneh) (In reply to Juliusz Gonera from comment #4) > Ori, is this really a performance issue? I can't imagine one image slowing > down rendering sig... [21:38:26] 3MobileFrontend / 3General/Unknown: Upload page action should be disabled for file pages that already exist - 10https://bugzilla.wikimedia.org/66500 (10Ryan Kaldari) [21:38:30] (03CR) 10Dr0ptp4kt: [C: 032] Shorter caching of error states, optimized validators [extensions/JsonConfig] - 10https://gerrit.wikimedia.org/r/138998 (owner: 10Yurik) [21:38:34] (03Merged) 10jenkins-bot: Shorter caching of error states, optimized validators [extensions/JsonConfig] - 10https://gerrit.wikimedia.org/r/138998 (owner: 10Yurik) [21:42:10] tfinc: just sent email about proposed wikimania travel dates. if it looks good to you i can fire off a confirmation to doreen [21:42:18] mhurd: k [21:45:12] 3MobileFrontend / 3Feature requests: Disable video and audio tags when not supported - 10https://bugzilla.wikimedia.org/58948#c4 (10Jon) According to Brion, the original reporter, on the prior bug report "any browser where ogg and webm not supported". It's possibly fixed, haven't got time to explore this ye... [21:46:26] 3MobileFrontend / 3Feature requests: Back/Forward button doesn't show up when operating in standalone app mode - 10https://bugzilla.wikimedia.org/60917#c2 (10Juliusz Gonera) This bug is about adding mobile web to the home screen on iOS. When you open it from home screen it opens without any browser UI. Also,... [21:49:11] 3MobileFrontend / 3Feature requests: Disable video and audio tags when not supported - 10https://bugzilla.wikimedia.org/58948#c5 (10Brion Vibber) iPhone/iPad are the primary examples; ideally if playback isn't supported we should offer a file download link instead. (This allows for playback via a supporting... [21:51:11] 3MobileFrontend / 3Feature requests: Back/Forward button doesn't show up when operating in standalone app mode - 10https://bugzilla.wikimedia.org/60917#c3 (10Brion Vibber) IIRC if we simply *don't* enable the special Apple "web app" mode, a homescreen bookmark will get created in a mode that gets launched in... [21:57:23] (03CR) 10Kaldari: "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/137462 (owner: 10Jdlrobson) [21:58:26] (03PS4) 10Kaldari: Hygiene: Remove dead code path [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/138376 (owner: 10Jdlrobson) [22:02:34] (03CR) 10Kaldari: "Max is correct. Indeed the default value of $wgAutoConfirmCount is 0. The change is still a good idea though." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/138376 (owner: 10Jdlrobson) [22:04:23] (03CR) 10Kaldari: [C: 032] Hygiene: Remove dead code path [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/138376 (owner: 10Jdlrobson) [22:04:35] (03PS7) 10Kaldari: Don't show photo upload icon when no action is possible [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/137462 (owner: 10Jdlrobson) [22:04:59] (03Merged) 10jenkins-bot: Hygiene: Remove dead code path [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/138376 (owner: 10Jdlrobson) [22:09:26] 3MobileFrontend / 3Feature requests: iOS: Shake to undo in WTE on mobile does not undo or redo typing - 10https://bugzilla.wikimedia.org/65600#c5 (10Juliusz Gonera) What is WTE? [22:09:56] 3MobileFrontend / 3Feature requests: iOS: Shake to undo in WTE on mobile does not undo or redo typing - 10https://bugzilla.wikimedia.org/65600#c6 (10Jared Zimmerman (WMF)) WikiTextEditor (e.g. not VE) [22:11:06] Maryana, got to the end of it, I commented on two cards [22:15:21] (03CR) 10Kaldari: Don't show photo upload icon when no action is possible [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/137462 (owner: 10Jdlrobson) [22:15:27] (03CR) 10Kaldari: [C: 032] Don't show photo upload icon when no action is possible [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/137462 (owner: 10Jdlrobson) [22:16:09] jgonera: <3 [22:17:27] (03CR) 10Kaldari: "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/137462 (owner: 10Jdlrobson) [22:17:58] (03Merged) 10jenkins-bot: Don't show photo upload icon when no action is possible [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/137462 (owner: 10Jdlrobson) [22:21:35] (03PS1) 10Kaldari: Only show upload page action in File namespace if page doesn't already exist [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/139009 (https://bugzilla.wikimedia.org/66500) [22:48:17] (03CR) 10Kaldari: [C: 032] Hygiene: Kill OverlayNew and LoadingOverlayNew [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/137831 (owner: 10Jdlrobson) [22:48:51] (03Merged) 10jenkins-bot: Hygiene: Kill OverlayNew and LoadingOverlayNew [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/137831 (owner: 10Jdlrobson) [22:51:34] (03PS1) 10Yurik: Fixing Zero special page config deref [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/139021 [22:52:54] (03PS1) 10Mhurd: Status bar visiblity now easily settable from any view controller. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/139022 [22:58:13] (03PS1) 10Mhurd: Fix for edit pencil not working if user not logged in. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/139024 [22:58:41] (03CR) 10Kaldari: [C: 032] Avoid JavaScript deprecation warnings in user module [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/138487 (https://bugzilla.wikimedia.org/65643) (owner: 10Jdlrobson) [22:59:15] (03Merged) 10jenkins-bot: Avoid JavaScript deprecation warnings in user module [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/138487 (https://bugzilla.wikimedia.org/65643) (owner: 10Jdlrobson) [23:00:11] (03CR) 10Kaldari: [C: 031] Hygiene: Make icons in overlays and drawers global and reusable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/133190 (owner: 10Jdlrobson) [23:01:18] (03CR) 10JGonera: [C: 04-1] "-1 just because I'm not sure how that works. Can you elaborate a bit more why we need to use setTimeout here?" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/137734 (https://bugzilla.wikimedia.org/65633) (owner: 10Jdlrobson) [23:01:22] Deskana: tomasz just sent an email concerning my travel plans. does it look ok to you? [23:01:34] Deskana: *wikimania* travel plans [23:01:43] jgonera: want me to explain in IRC quickly? [23:02:08] jdlrobson, I'd rather have this explanation as a comment in code or commit message [23:02:18] sure but it would help articulating it in IRC first [23:02:24] so that i know my comment is going to be useful :) [23:02:35] jdlrobson, sure, or in person later if you want [23:02:41] mhurd: My gut says yes, but let me check sprint dates. [23:02:42] so new Page( { title: "Foo" } ) will work in 1 of 2 ways - firstly if you give it sections it will just render, if no sections are given then it will hit the API [23:02:57] The PageApi module will either hit the server or use cache [23:03:13] in the case where it uses cache, the creation of a page is synchronous. [23:03:22] when it hits the API async [23:03:55] so when doing new Page( { title: "Foo" } ).on( 'ready', fn ) when it hits the cache the ready event will get triggered during initialisation [23:04:11] so the ready event is binded afterwards and never gets run [23:04:38] so the setTimeout delays the execution till after the chaining has happened [23:04:50] is that clear? If so any ideas how I could explain that in a sentence? :) [23:05:49] (03CR) 10Mhurd: "Sample code - DO not merge :)" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/138477 (owner: 10Mhurd) [23:06:33] jdlrobson: still another upload icon gone: https://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-firefox/617/testReport/junit/(root)/Page%20actions%20menu%20when%20logged%20in/I_cannot_upload_a_lead_photo_to_the_Main_Page/ [23:10:04] jdlrobson, why not use a Deferred? [23:10:28] Deskana: how’s it look ? [23:10:44] mhurd: Looks good to me! You're travelling on the same days I am. :) [23:11:03] Deskana: I need to figure out my travel dates as well. Probably a while longer in the UK [23:11:12] (03CR) 10Dr0ptp4kt: [C: 032 V: 031] Fixing Zero special page config deref [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/139021 (owner: 10Yurik) [23:11:21] (03Merged) 10jenkins-bot: Fixing Zero special page config deref [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/139021 (owner: 10Yurik) [23:11:39] Deskana: woohoo! thanks! [23:11:45] jdlrobson, do we have click tracking for languages? [23:12:05] Deskana: sent confirmation to doreen so i should have flights booked soon :) [23:12:08] jgonera: i don't think so. Grep the code to be sure [23:12:23] mhurd: Although you're probably flying to the other end of the country to me. I'm going to/from Manchester. [23:12:26] jgonera: i do use a deferred.. but if a deferred has already been completed... [23:12:33] chrismcmahon: i'll take a look [23:13:39] brb - food time [23:18:11] Deskana: [23:18:15] you there? [23:18:28] moizsyed: Sure am. [23:18:41] Deskana: need to chat about onboarding stuff, you have a few minutes? [23:19:02] would only need 10 mins, not more [23:19:07] moizsyed: Yep. IRC or hangout? [23:19:12] hangout is better [23:19:23] Okay, let me set something up. [23:19:59] moizsyed: Booked you into Mushroom Kingdom. :) [23:20:07] thanks Deskana [23:20:15] (03PS1) 10Jdlrobson: QA: Update main page upload tests [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/139028 [23:20:16] ^ chrismcmahon [23:20:25] moizsyed: And invite sent. See you in a minute. [23:20:34] mhurd: odd, i’m having trouble getting edit buttons to work [23:21:12] 3MobileFrontend / 3stable: Deprecation warnings in JS console - 10https://bugzilla.wikimedia.org/65643 (10Jon) 5PATC>3RESO/FIX [23:21:15] *** WebKit discarded an uncaught exception in the webView:decidePolicyForNavigationAction:request:frame:decisionListener: delegate: *** setObjectForKey: object cannot be nil (key: userName) [23:21:44] ooooh i see [23:21:47] i broke it i think ;) [23:22:04] (03CR) 10Cmcmahon: [C: 031] "I'd rather have someone else +2 a change to the skin itself" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/139028 (owner: 10Jdlrobson) [23:24:02] brion: there’s a patch from me fixing that edit button thing already :) [23:24:10] oh hey :D [23:24:11] nice [23:25:15] (03CR) 10Brion VIBBER: "Is this supposed to hide the status bar in iOS 6 too or is it supposed to not hide it except on 7?" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/139022 (owner: 10Mhurd) [23:25:41] (03CR) 10Brion VIBBER: [C: 032 V: 032] "thanks ;D" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/139024 (owner: 10Mhurd) [23:25:47] (03CR) 10Mhurd: "No, not supposed to hide iOS 6 status bar." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/139022 (owner: 10Mhurd) [23:26:15] brion: ^ could add that ios 6 status bar hiding later if needed, but simpler to not do so for now [23:26:18] ok just double-checking :D [23:26:21] yeah no biggie [23:26:26] brion: yay! [23:26:27] and probably easier not to hide it on 6 :D [23:26:35] 6 is not long for this world [23:27:03] brion: heheheh it’s going’ down! [23:27:46] (03CR) 10Brion VIBBER: [C: 032 V: 032] "Great just double-checking that was intentional. :D Seems fine and simplifies some code yay! Let's merge..." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/139022 (owner: 10Mhurd) [23:28:08] awjr_away: in case you didn't see https://github.com/wikimedia/bingle/pull/40 [23:28:10] brion: woohoo! [23:28:44] reminds me, i’m trying to use my ipad more to get more ‘in the ios zone’ for when we tune this app up for tablet… i’m fiddling with text editors and ssh and vnc and stuff [23:29:09] manual ssh key management is ….. painful [23:29:19] this stuff will get a lot easier with some of the extension points in ios 8 [23:29:23] like document providers [23:30:54] brion: true! [23:34:21] jgonera: what's the bug for red links? i can't find one.. [23:36:41] 3MobileFrontend / 3Feature requests: Enable red links on stable version of MobileFrontend - 10https://bugzilla.wikimedia.org/55500#c35 (10Jon) The original issue with sup elements is fixed. The conversation and title are a little confusing, hence why this was closed. Tracking bug would be more useful (I thi... [23:36:52] (03CR) 10JGonera: [C: 04-1] Collapse on the highest available heading level (034 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/137836 (https://bugzilla.wikimedia.org/60478) (owner: 10Jdlrobson) [23:39:39] (03CR) 10Jdlrobson: Collapse on the highest available heading level (034 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/137836 (https://bugzilla.wikimedia.org/60478) (owner: 10Jdlrobson) [23:39:42] (03PS5) 10Jdlrobson: Collapse on the highest available heading level [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/137836 (https://bugzilla.wikimedia.org/60478) [23:40:16] jdlrobson, I might be mistaken, maybe there's only a story card for this: https://trello.com/c/hl7CEbVA/78-2-promote-red-links-to-stable [23:42:58] mmm ok we'll see what happens ;-) [23:45:12] mhurd: What are your plans for your time in the UK? [23:45:15] mhurd: Spending it all in London? [23:45:33] Deskana: no plans yet :) open to suggestions for sure! [23:45:42] * Deskana does not know London. [23:46:04] i don’t know the uk at all hehe [23:46:09] However, if you're looking to visit somewhere else in the UK... [23:46:20] Deskana: ya! [23:46:46] I'm spending all of the time not at Wikimania (i.e. 1-5th, 11th - 15th) in Manchester. [23:46:50] bearND: dbrant|brb: the PM'm and I are thinking about doing our next quarterly planning 7/1 7/2 ... would you guys be open to coming back to SF then ? [23:46:59] were currently testing out the dates and putting some holds in place [23:47:42] tfinc: as in, 3 weeks from now? [23:47:46] yup [23:48:05] mhurd: It's 200 miles north of London. It takes two hours on the train, and right now train tickets are going for around £25 for a return journey. [23:48:30] possibly! but I'd have to confirm. can I answer tomorrow? [23:48:35] Deskana: that sounds do-able [23:48:43] (03PS6) 10Jdlrobson: Collapse on the highest available heading level [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/137836 (https://bugzilla.wikimedia.org/60478) [23:48:50] dbrant: do it! :) [23:49:01] tfinc: possibly! but I'd have to confirm. can I answer tomorrow? [23:49:05] mhurd: I will make a more formal recommendation to you tomorrow, in person then! :) [23:49:12] Deskana: yay! [23:49:21] dbrant: sure, i just wanted to give you a heads up and feel it out [23:49:39] tfinc: awesome [23:49:40] we can chat about it tomorrow [23:49:42] (03CR) 10Jdlrobson: [C: 032] Only show upload page action in File namespace if page doesn't already exist [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/139009 (https://bugzilla.wikimedia.org/66500) (owner: 10Kaldari) [23:50:17] (03Merged) 10jenkins-bot: Only show upload page action in File namespace if page doesn't already exist [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/139009 (https://bugzilla.wikimedia.org/66500) (owner: 10Kaldari) [23:51:11] 3MobileFrontend / 3General/Unknown: Upload page action should be disabled for file pages that already exist - 10https://bugzilla.wikimedia.org/66500 (10Jon) 5PATC>3RESO/FIX [23:51:15] mhurd: If you want advice on London, or the south, ask one of the other Brits. I know nothing of the south. :P [23:51:24] I deal in northern things like Manchester! :D [23:51:37] Deskana: hehe sounds good [23:51:45] tfinc: generally, i'm open for it, but it's the 4th of July week, so need to check with my better half first. Is it just 2 days? [23:52:11] (03CR) 10JGonera: "How about instead of doing:" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/137734 (https://bugzilla.wikimedia.org/65633) (owner: 10Jdlrobson) [23:52:11] 3MobileFrontend / 3stable: Language menu (of pages) should show variants based on page language instead of site language - 10https://bugzilla.wikimedia.org/66159#c2 (10Jon) What does this bug mean? Could you add steps including URLS to replicate with expected behaviour? [23:52:39] Deskana: I quite enjoyed Glencoe and the hippies [23:53:05] YuviPanda: That's a bit further afield than Manchester. :P [23:53:05] Deskana: and the party at the National Science Museum :D [23:53:05] (in London) [23:53:18] But yes, I do highly recommend Scotland. [23:53:23] Edinburgh is beautiful. [23:53:28] jdlrobson, did you change anything in https://gerrit.wikimedia.org/r/#/c/136501/ or just rebased? [23:53:40] Deskana: yeah, haven't spent any time there this time. [23:53:52] jgonera: i fixed the issues you asked about [23:53:57] Deskana: next time I should actually take some time off. I didn't at all this time, with the release and all [23:54:02] see https://gerrit.wikimedia.org/r/#/c/136501/6/less/common/pagelist.less [23:54:03] jdlrobson, so no need for a screenshot? [23:54:05] just changed comment [23:54:14] cool [23:54:15] YuviPanda: hippies? isn’t there a spray for that? [23:54:21] i couldn't replicate but i assume that was the bug you were talking about [23:54:29] (03CR) 10Jdlrobson: "I'm not sure I completely follow - do you want to make an alternative patch?" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/137734 (https://bugzilla.wikimedia.org/65633) (owner: 10Jdlrobson) [23:54:34] mhurd: :) I did have a fun time with a bunch. [23:54:35] gawddd vagrant up is taking forever [23:54:37] YuviPanda: Maybe we'll end up with the apps outing to the north! :D [23:54:50] YuviPanda: jk :) [23:55:02] Deskana: oh yeah, that does sound awesome. It was super cheap as well - 16pounds a day for a nice car [23:55:07] mhurd: hehe, me too :P [23:55:19] The train from London -> Manchester is around £12.50 atm. [23:55:27] Julie and I got returns for £25 per person. [23:55:41] true, but this was more a 'trip to the mountains!' [23:56:18] Deskana: there's also a cricket series going on around that time, so I'm debating going to one of the matches [23:56:34] * Deskana has never been to a cricket match. [23:56:38] Deskana: me neither [23:57:56] Deskana: I was at the peacecamp in faslane, next to the nuclear submarines. it was... interesting [23:59:56] 3MobileFrontend / 3stable: Go directly to an article if we have an exact search match. - 10https://bugzilla.wikimedia.org/30884#c2 (10Ryan Kaldari) 5RESO/FIX>3REOP Reopening per complaint at en.wiktionary. A few months ago we changed the default search behavior so that it takes users to the search resul...