[00:01:56] kaldari: Can you open a new bug about search - it will be cleaner and it will make it into trello. Also please add a link to the "complaint". [00:02:23] (and close that one) [00:02:29] jdlrobson, awjr: Does bugello not pull reopened bugs? [00:02:45] (03CR) 10JGonera: [C: 032] Hygiene: Fix some FIXMEs [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/136501 (owner: 10Jdlrobson) [00:02:55] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Fix some FIXMEs [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/136501 (owner: 10Jdlrobson) [00:03:09] awjr_away: ^ [00:03:35] (03CR) 10Jdlrobson: [C: 032] Show mobile view to tablets by default [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/138517 (owner: 10MaxSem) [00:04:23] (03Merged) 10jenkins-bot: Show mobile view to tablets by default [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/138517 (owner: 10MaxSem) [00:06:02] (03PS7) 10Jdlrobson: Hygiene: Fix some FIXMEs [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/136501 [00:06:43] (03CR) 10Jdlrobson: [C: 032] "Rebased" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/136501 (owner: 10Jdlrobson) [00:06:43] 3MobileFrontend / 3General/Unknown: Go directly to an article if we have an exact search match - 10https://bugzilla.wikimedia.org/66506 (10Ryan Kaldari) 3NEW p:3Unprio s:3normal a:3None A few months ago we changed the default search behavior so that it takes users to the search results page instead o... [00:07:16] (03Merged) 10jenkins-bot: Hygiene: Fix some FIXMEs [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/136501 (owner: 10Jdlrobson) [00:07:20] (03CR) 10JGonera: [C: 04-1] "This is not exactly what we agreed upon during the meeting with the Opera Software person. Let's hold off on that until Maryana, Moiz and " [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/138867 (owner: 10Jdlrobson) [00:07:57] 3MobileFrontend / 3General/Unknown: Go directly to an article if we have an exact search match - 10https://bugzilla.wikimedia.org/66506#c1 (10Ryan Kaldari) *** Bug 30884 has been marked as a duplicate of this bug. *** [00:07:57] 3MobileFrontend / 3stable: Go directly to an article if we have an exact search match. - 10https://bugzilla.wikimedia.org/30884#c3 (10Ryan Kaldari) 5REOP>3RESO/DUP *** This bug has been marked as a duplicate of bug 66506 *** [00:08:21] kaldari, have you worked on https://gerrit.wikimedia.org/r/#/c/135137/1 recently? [00:10:26] 3MobileFrontend / 3General/Unknown: Go directly to an article if we have an exact search match - 10https://bugzilla.wikimedia.org/66506#c2 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/oZi8Usoh [00:16:16] jgonera: does make phpunit work for you with Vagrant? [00:16:34] jdlrobson, what do you mean? I run it in the host [00:17:30] (03CR) 10JGonera: [C: 04-1] Hygiene: Icon cleanup (033 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/133189 (owner: 10Jdlrobson) [00:18:16] jgonera: when i run `make phpunit` from MobileFrontend directory it fails [00:19:02] Warning: require_once(/vagrant/LocalSettings.php): failed to open stream: No such file or directory in /Users/jrobson/git/vagrant/mediawiki/LocalSettings.php on line 128 [00:19:02] Fatal error: require_once(): Failed opening required '/vagrant/LocalSettings.php' (include_path='.:') in /Users/jrobson/git/vagrant/mediawiki/LocalSettings.php on line 128 [00:19:17] jdlrobson, I guess I don't know then, I thought it was in pre-commit but now I see it's not [00:28:02] (03CR) 10Jdlrobson: Hygiene: Icon cleanup (033 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/133189 (owner: 10Jdlrobson) [00:28:11] 3MobileFrontend / 3stable: Need to click twice in search overlay - 10https://bugzilla.wikimedia.org/65676#c6 (10Juliusz Gonera) 5RESO/FIX>3REOP This is still happening for me now and then. I also saw other people hitting it when testing on tablets. [00:28:45] jdlrobson, kaldari do you know if a bug will show up in trello if I reopen it? [00:29:25] jgonera: According to Jon, it won't [00:32:07] can we get https://gerrit.wikimedia.org/r/139028 merged kaldari / jgonera so the test builds pass again [00:33:02] jdlrobson, aren't we removing all the page actions from main page? [00:33:16] we are in stable but not beta [00:33:31] (03CR) 10JGonera: [C: 032] QA: Update main page upload tests [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/139028 (owner: 10Jdlrobson) [00:33:33] looks good to me [00:33:36] (03CR) 10Kaldari: [C: 032] QA: Update main page upload tests [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/139028 (owner: 10Jdlrobson) [00:35:09] (03Merged) 10jenkins-bot: QA: Update main page upload tests [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/139028 (owner: 10Jdlrobson) [00:35:21] (03CR) 10Jdlrobson: "Note this is a general issue for Views where events are emitted in the initialize/render function." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/137734 (https://bugzilla.wikimedia.org/65633) (owner: 10Jdlrobson) [00:39:41] 3MobileFrontend / 3stable: Need to click twice in search overlay - 10https://bugzilla.wikimedia.org/65676#c7 (10Paul Henry) This also regularly happens for me. The bug is present in both the desktop and Android versions of Chrome. [00:44:29] (03PS1) 10Jdlrobson: Documentation: Add note to `make qunit` [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/139050 [00:49:05] (03PS1) 10JGonera: Regression: fix margin between thumbnail and its caption [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/139052 [01:00:32] (03CR) 10MaxSem: [C: 032] Don't show spinner whilst watching a page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/137233 (https://bugzilla.wikimedia.org/65599) (owner: 10Jdlrobson) [01:01:01] (03Merged) 10jenkins-bot: Don't show spinner whilst watching a page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/137233 (https://bugzilla.wikimedia.org/65599) (owner: 10Jdlrobson) [01:08:39] (03CR) 10Kaldari: [C: 032] Regression: fix margin between thumbnail and its caption [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/139052 (owner: 10JGonera) [01:09:13] (03Merged) 10jenkins-bot: Regression: fix margin between thumbnail and its caption [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/139052 (owner: 10JGonera) [01:09:56] (03CR) 10Kaldari: [C: 032] Documentation: Add note to `make qunit` [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/139050 (owner: 10Jdlrobson) [01:10:30] (03Merged) 10jenkins-bot: Documentation: Add note to `make qunit` [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/139050 (owner: 10Jdlrobson) [01:31:27] 3MobileFrontend / 3Feature requests: indeterminate loader graphic should not be displayed when watchlisting or watchlisting - 10https://bugzilla.wikimedia.org/65599 (10Jon) 5PATC>3RESO/FIX [04:56:35] * MaxSem bites YuviPanda [04:56:42] OMG WHAT DID I DO NOW [04:56:48] you're uploading new patchsets too quickly! [04:57:09] MaxSem: :P [05:28:12] 3Wikipedia App / 3Android App: Clear floating in footer - 10https://bugzilla.wikimedia.org/66322#c4 (10Liangent) (In reply to Yuvi Panda from comment #3) > Not really. I do know what clearing means, but what adverse issues are you > seeing because it is uncleared? https://zh.wikipedia.org/wiki/User:Liangent... [05:33:12] 3MobileFrontend / 3stable: Language menu (of pages) should show variants based on page language instead of site language - 10https://bugzilla.wikimedia.org/66159#c3 (10Liangent) Issue one: URL: https://m.mediawiki.org/wiki/Bugzilla/zh#/languages A variant list of Chinese is expected but it's not there. Is... [05:47:59] (03PS1) 10BearND: [WIP] Save images of saved page [apps/android/wikipedia] (savedpages) - 10https://gerrit.wikimedia.org/r/139067 [05:49:19] (03PS2) 10BearND: Save images of saved page [apps/android/wikipedia] (savedpages) - 10https://gerrit.wikimedia.org/r/139067 [05:56:39] * YuviPanda waves at bearND [05:56:41] * YuviPanda hasn't slept yet [05:56:46] * YuviPanda considers it [05:57:45] * bearND waves a YuviPanda [05:57:56] YuviPanda: hope you got some zzz on the plane [05:58:18] bearND: kinda, but it's about 27h since then [05:58:30] YuviPanda: ouch [05:58:32] yeah [06:01:30] YuviPanda: time to go to bed now. [06:02:15] * bearND|zzz trying to be a good role model [06:02:33] bearND|zzz: haha :D [06:02:39] bearND|zzz: good night! :) [06:05:57] YuviPanda: good night :) [06:30:08] YuviPanda: have you been able to reproduce ? [06:30:26] matanya: still childless, fortunately. I take precautions :) [06:30:45] LOL [06:31:24] matanya: :D but no, but that's because I've gotten caught up with paperwork and some other things. [06:31:29] matanya: I'll try tomorrow [06:31:33] matanya: also, can you file a bug anyway? [06:31:58] sure [06:36:15] 3Wikipedia App / 3Android App: When app crashes or device reboots user is still shown as logged-in although in fact not - 10https://bugzilla.wikimedia.org/66515 (10matanya) 3NEW p:3Unprio s:3normal a:3None When app crashes or device reboots user is still shown as logged-in although in fact not. When... [06:36:46] YuviPanda: ^ :) [06:36:53] matanya: ty [06:43:26] 3MobileFrontend / 3Feature requests: Enable red links on stable version of MobileFrontend - 10https://bugzilla.wikimedia.org/55500#c36 (10Andyrom75) 5RESO/FIX>3REOP I've reopened because the problem still persist. The most evident proof is the comparison of the links in the firt post. But I've noticed th... [08:26:45] (03PS3) 10Florianschmidtwelzow: Enable anonymous editing in alpha mode [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/138802 (https://bugzilla.wikimedia.org/59937) [08:28:26] 3Commons App / 3Android: Commons app doesn't handle changed login passwords properly - 10https://bugzilla.wikimedia.org/41704#c1 (10Jan Ainali) Possible workaround for user: Remove account in system settings. (Not very user friendly but solves the immediate problem). [09:04:11] (03PS4) 10Florianschmidtwelzow: Enable anonymous editing in alpha mode [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/138802 (https://bugzilla.wikimedia.org/59937) [09:41:55] (03CR) 10Siebrand: [C: 04-1] "L10n reviewed." (031 comment) [apps/android/wikipedia] (savedpages) - 10https://gerrit.wikimedia.org/r/139067 (owner: 10BearND) [09:58:38] (03CR) 10Siebrand: [C: 031] "L10n reviewed." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/138867 (owner: 10Jdlrobson) [12:47:57] 3MobileFrontend / 3Hygiene: make phpdoc shows errors in our PHP documentation - 10https://bugzilla.wikimedia.org/66086#c14 (10Florian) So, last two files i do later, here is the latest capture: Parsing files Parsing /var/www/devwiki/extensions/MobileFrontend/MobileFrontend.alias.php Parsing /var/www/devwiki... [12:54:56] (03PS1) 10Florianschmidtwelzow: WIP: Update doc for special pages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/139100 (https://bugzilla.wikimedia.org/66086) [12:55:26] 3MobileFrontend / 3Hygiene: make phpdoc shows errors in our PHP documentation - 10https://bugzilla.wikimedia.org/66086 (10Florian) 5PATC>3ASSI [12:57:13] (03CR) 10Florianschmidtwelzow: WIP: Update doc for special pages (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/139100 (https://bugzilla.wikimedia.org/66086) (owner: 10Florianschmidtwelzow) [13:18:17] (03CR) 10Dbrant: "Looking good! (i.e. works!!) Just a couple comments/thoughts. Generally, my gut feeling is that we can make this a lot more efficient by " (032 comments) [apps/android/wikipedia] (savedpages) - 10https://gerrit.wikimedia.org/r/139067 (owner: 10BearND) [13:29:34] (03CR) 10Yuvipanda: "Hmm, the bridge stuff should be removed, actually. The reason being we'd want to implement some sort of 'initial import' functionality fro" [apps/android/wikipedia] (savedpages) - 10https://gerrit.wikimedia.org/r/139067 (owner: 10BearND) [13:30:02] * YuviPanda waves at Deskana [13:30:22] Deskana: we forgot to add a story for 'import saved pages from old app in some way!' [13:42:57] 3MobileFrontend / 3Feature requests: Enable red links on stable version of MobileFrontend - 10https://bugzilla.wikimedia.org/55500#c37 (10Florian) > the problem still persist Yeah, because the main function to remove redlinks from mobile sites still exists :) Maybe we can rethink this? [13:57:19] (03CR) 10Yuvipanda: "Doing the img rewrites on load would be easier with the Webview, though. Wonder if it is faster, however - since if you do the rewerite on" [apps/android/wikipedia] (savedpages) - 10https://gerrit.wikimedia.org/r/139067 (owner: 10BearND) [14:32:28] 3Wikipedia App / 3Settings: Android app does not realize when it has been logged out - 10https://bugzilla.wikimedia.org/63875#c3 (10Sage Ross) *** Bug 66515 has been marked as a duplicate of this bug. *** [14:32:28] 3Wikipedia App / 3Android App: When app crashes or device reboots user is still shown as logged-in although in fact not - 10https://bugzilla.wikimedia.org/66515#c1 (10Sage Ross) 5NEW>3RESO/DUP *** This bug has been marked as a duplicate of bug 63875 *** [14:52:26] 3MobileFrontend / 3Feature requests: Enable red links on stable version of MobileFrontend - 10https://bugzilla.wikimedia.org/55500#c38 (10Andyrom75) I hope that it would be rethink. In my opinion all the red links should be shown by default. In case, through a specific gadget, who doesn't won't to deal with... [15:01:41] dbrant: power just went out again. gurrghhh. [15:01:45] must leave stupid city soon [15:02:05] YuviPanda: that's awful [15:02:39] dbrant: was happening for about 1.5 years, and then was fine for about 4-5 months, and now back to this again [15:02:45] every. fucking. day. [15:22:44] (03PS1) 10Dbrant: Fix possible crash with 3.x devices. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/139118 [15:23:18] YuviPanda: bearND: ^ from otrs ticket [15:24:08] (03CR) 10Yuvipanda: [C: 04-1] Fix possible crash with 3.x devices. (031 comment) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/139118 (owner: 10Dbrant) [15:25:49] dbrant: cool, can you add the stack trace or link to OTRS to the commit message? [15:26:15] YuviPanda: it actually works on my 3.0 device. But I suppose checking for ICS is safer. [15:27:06] dbrant: yeah. plus I think we should just split functionality as 'ICS+' and 'pre-ICS' [15:27:15] dbrant: and forget 3.x ever existed [15:29:43] (03CR) 10Yuvipanda: [C: 04-1] "Not a full review yet." (034 comments) [apps/android/wikipedia] (savedpages) - 10https://gerrit.wikimedia.org/r/139067 (owner: 10BearND) [15:29:51] (03PS2) 10Dbrant: Fix possible crash with <4.0 devices when opening More. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/139118 [15:30:30] (03CR) 10Yuvipanda: [C: 032] "Sane enough." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/139118 (owner: 10Dbrant) [15:30:52] (03Merged) 10jenkins-bot: Fix possible crash with <4.0 devices when opening More. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/139118 (owner: 10Dbrant) [15:39:10] YuviPanda: Are you saying in https://gerrit.wikimedia.org/r/#/c/139067/ that we should remove requestImagesList from the JS bridge? it would be cool to extract the image URLs. Sounds safer than using XPATH. [15:39:38] bearND: yeah, but also see my review. of the rewriter. [15:40:17] bearND: the reason being we will need to have a 'first run' story, where we actually save all the previously saved pages (from previous versions of the app) without having them open up each of them [15:40:25] bearND: and tying that to a webview just seems bad to me. [15:40:27] dbrant: ^ [15:41:53] bearND: dbrant however, if you guys think we can nicely do the 'first run' experience without having to mess with hidden pageviewfragments, we could possibly do that. [15:43:50] bearND: I think the rewriter code can also be much simpler easily if we combine the 'extract' and 'rewrite' steps together. [15:43:54] and make it a little async. [15:44:04] so xpath will be //img, and then we can manipulate the nodes right there. [15:44:24] bearND: I can take a shot at redoing that if you want [15:45:25] YuviPanda: I see now. Bummer. I was excited to try the JS solution when dbrant mentioned it. [15:45:40] bearND: yeah, that's remnants of code from the previous implementation [15:49:24] YuviPanda: Go that a stab at it. I was also thinking that it would be nice if the extract and replace steps were combined. There is the problem of updating the sections in the JSON before writing the content.json file. [15:49:55] bearND: right, so the transformation needs to happen before that. we'll have to make it a bit event driven. [15:49:59] bearND: I'll take a stab at it now. [15:53:58] dbrant YuviPanda: one more thing we need to do is to disable the Save Page menu item when the action is invoked, and also when a saved page is viewed. [15:54:06] bearND: we should probably change it to 'refresh page'? [15:54:34] YuviPanda: yes, but we probably want a refresh in general [15:54:49] bearND: hmm? there is already some refreshpage code, I think [15:55:22] YuviPanda: how is it triggered? [15:56:28] * dbrant needs to run a few errands. will bbl [15:56:36] bearND: not explicitly, I think. so yeah, we can make 'save page' to be 'refresh page' and have that be the explicit triggef [15:56:38] *trigger [15:57:29] YuviPanda: how does a user trigger a refresh on a live page? [15:58:26] bearND: right now? they can't [15:58:32] I'm saying we should make that possible. [16:00:09] YuviPanda: yes, that's why I said just disable the Save Page (and not replace it with refresh). The refresh user interaction would be a separate thing, but for a saved page it would trigger the rewrite of the saved page [16:00:25] bearND: oh wait, 'refresh' for a 'normal' page? not a saved page? [16:00:36] YuviPanda: yes [16:00:36] bearND: I don't think we should have that at all. I can't think of anywhere it'll be useful other than for saved pages [16:00:56] YuviPanda: what if the contents of the article changes? [16:01:16] bearND: you see it the next time? :) [16:01:17] see also http://en.wikipedia.org/wiki/Wikipedia:Wikipedia_is_not_a_newspaper [16:01:58] bearND: we can open a bug and wait for the first time someone asks for it. I don't think it's a necessary feature. [16:05:45] (03PS1) 10Cmcmahon: QA: update Ruby gems to pick up new mediawiki-selenium [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/139127 [16:07:05] YuviPanda: probably not MVP, agreed. Then it's fine to have a refresh on saved page views (probably also not MVP). We still should disable the save page action. [16:45:59] 3MobileFrontend / 3stable: Disabling of red links should be configurable - 10https://bugzilla.wikimedia.org/66534 (10Jon) 3NEW p:3Unprio s:3normal a:3None Currently red links are disabled on Wikimedia servers using JavaScript. This should not be the case for 3rd party installs. Ideally this should b... [16:47:12] 3MobileFrontend / 3Feature requests: Enable red links on stable version of MobileFrontend - 10https://bugzilla.wikimedia.org/55500#c39 (10Jon) 5REOP>3RESO/FIX I'm going to close this, since the conversation is a bit hard to follow and the original problem raised by Liagent is fixed and I can't find a tra... [16:49:11] 3MobileFrontend / 3stable: Language menu (of pages) should show variants based on page language instead of site language - 10https://bugzilla.wikimedia.org/66159#c4 (10Jon) Thanks Liagent, this is much clearer now :) I think you are right and this is the same underlying problem as the other bug. Do you mind... [16:49:26] 3MobileFrontend / 3stable: Disabling of red links should be configurable - 10https://bugzilla.wikimedia.org/66534#c1 (10Florian) This is a feature request, isn't it? :) Maybe we can use this as a basic: https://gerrit.wikimedia.org/r/#/c/135120/ [16:50:26] 3MobileFrontend / 3stable: Disabling of red links should be configurable - 10https://bugzilla.wikimedia.org/66534#c2 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/yW29IdAv [16:53:50] (03PS2) 10Florianschmidtwelzow: Update doc for special pages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/139100 (https://bugzilla.wikimedia.org/66086) [16:56:58] dbrant|bbl: added you to a meeting, I know it's very late notice, feel free to decline (have marked you as optional) [17:00:10] YuviPanda: Am still a bit concerned about using XPATH for the img detection due to some img tags not being closed. Just stumbled upon Html.fromHtml (http://developer.android.com/reference/java/lang/String.html source, http://developer.android.com/reference/android/text/Html.ImageGetter.html imageGetter,http://developer.android.com/reference/android/text/Html.TagHandler.html tagHandler), which seems to work pretty well for detec [17:00:46] (03CR) 10Jdlrobson: "Max I think this would be useful. I'm not sure when red links are being enabled on Wikimedia servers." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/135120 (https://bugzilla.wikimedia.org/65640) (owner: 10Florianschmidtwelzow) [17:03:02] (03CR) 10Jdlrobson: Introducing new "wgMFRemoveRedlinks" config (033 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/135120 (https://bugzilla.wikimedia.org/65640) (owner: 10Florianschmidtwelzow) [17:04:19] (03PS2) 10Cmcmahon: QA: update Ruby gems to pick up new mediawiki-selenium [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/139127 [17:04:48] bearND: yeah, but won't really work for replacement. [17:04:53] bearND: also why didn't we use Jsoup? [17:05:28] bearND: although image replacement on load doesn't have too many drawbacks anyway [17:07:21] YuviPanda: jsoup seems to be pretty big but we probably could strip most of it out when we hook up ProGuard eventually. [17:07:56] bearND: in terms of size you mean? [17:08:03] YuviPanda: yes [17:12:39] YuviPanda: if we move image replacement to on load then we wither need to keep the file name mapping algorithm stable between releases or store a mapping file, but both are doable. it would remove the need to change SavePage.writeToFileSystem. [17:13:43] bearND: hmm, right. I guess a mapping file would be rather easy, since we'll just put that in as JSON? [17:14:10] (03PS7) 10Jdlrobson: Collapse on the highest available heading level [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/137836 (https://bugzilla.wikimedia.org/60478) [17:15:09] YuviPanda: yes. I'll push what i have so far (the img detecting changes) so you can try it out. it's much simpler and works on the main page. [17:15:14] (03CR) 10Jdlrobson: [C: 032] QA: update Ruby gems to pick up new mediawiki-selenium [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/139127 (owner: 10Cmcmahon) [17:15:41] bearND: cool. but we definitely shouldn't be parsing HTML with regexes or strings, though :) [17:15:55] bearND: we can fix the mobileview api to return closed img tags on main page too if that's what we want [17:16:12] (03Merged) 10jenkins-bot: QA: update Ruby gems to pick up new mediawiki-selenium [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/139127 (owner: 10Cmcmahon) [17:16:23] YuviPanda: yeah, if we move img replacement to JS on load then we don't have to [17:17:13] YuviPanda: we could just use main.js replaceImageSrc [17:17:44] bearND: yup, using replaceImageSrc is fine. let's just not use webview for extracting them [17:18:54] YuviPanda: agreed. [17:19:02] bearND: sweet. can you update the PS? [17:19:21] YuviPanda: i keep forgetting to do an amend. [17:19:38] bearND: :D you can squash later if you forget... [17:19:41] git rebase -i is wonderful [17:20:06] YuviPanda: yeah, tried that: Cannot 'squash' without a previous commit [17:20:29] YuviPanda: ok, picking the other commit [17:20:33] bearND: hmm, my usual workflow is to do git commit -p --amend [17:21:44] (03PS1) 10BearND: [WIP] Save images of saved page [apps/android/wikipedia] (savedpages) - 10https://gerrit.wikimedia.org/r/139149 [17:21:55] YuviPanda: ^ [17:24:38] (03PS1) 10Florianschmidtwelzow: Use phpdoc.xml for configuration of phpdoc [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/139151 [17:25:08] YuviPanda: haven't tried git commit -p yet but seems cool. I usually commit from IntelliJ since it has a nice GUI where I can see the diffs of what has changed. [17:25:36] bearND: aaah, right. I stay away from it mostly. [17:25:40] YuviPanda: (Command-K) [17:25:42] bearND: git commit -p is awesome! :D [17:26:24] YuviPanda: i'll try it for next time [17:26:29] bearND: cool :) [17:35:51] jdlrobson: you mean no configuration var for redlink remove? https://gerrit.wikimedia.org/r/#/c/135120/4/javascripts/modules/redlinks/redlinks.js [17:36:54] YuviPanda: dbrant|bbl am going to upload the previous change again. got the wrong Change-id [17:37:29] YuviPanda: dbrant|bbl: and will also clean up some more, and address some of dbrant|bbl concerns [17:37:42] bearND: cool [17:38:18] jdlrobson: was there a regression yesterday? https://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.org-linux-firefox/lastCompletedBuild/testReport/ [17:41:01] Deskana: moved to r32 [17:42:11] (03Abandoned) 10BearND: [WIP] Save images of saved page [apps/android/wikipedia] (savedpages) - 10https://gerrit.wikimedia.org/r/139149 (owner: 10BearND) [17:42:34] (03CR) 10Jdlrobson: [C: 04-1] Update doc for special pages (035 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/139100 (https://bugzilla.wikimedia.org/66086) (owner: 10Florianschmidtwelzow) [17:42:37] (03PS3) 10BearND: [WIP] Save images of saved page [apps/android/wikipedia] (savedpages) - 10https://gerrit.wikimedia.org/r/139067 [17:44:10] (03CR) 10Jdlrobson: [C: 04-1] "Awesome! Slight unix/osx/windows carriage return character cleanup needed! :)" (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/139151 (owner: 10Florianschmidtwelzow) [17:50:15] (03PS2) 10Florianschmidtwelzow: Use phpdoc.xml for configuration of phpdoc [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/139151 [17:50:47] (03CR) 10Florianschmidtwelzow: Use phpdoc.xml for configuration of phpdoc (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/139151 (owner: 10Florianschmidtwelzow) [17:54:57] (03CR) 10Florianschmidtwelzow: Introducing new "wgMFRemoveRedlinks" config (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/135120 (https://bugzilla.wikimedia.org/65640) (owner: 10Florianschmidtwelzow) [17:58:41] brion: In a meeting right now. I'll be out to you as soon as I'm done. :) [17:58:50] Deskana: spiff [17:58:55] i’m setting up my testing devices :D [18:02:21] MaxSem: jdlrobson jgonera http://hatjitsu.wmflabs.org/68473 [18:02:32] (03CR) 10Florianschmidtwelzow: Update doc for special pages (035 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/139100 (https://bugzilla.wikimedia.org/66086) (owner: 10Florianschmidtwelzow) [18:02:44] can someone share that with kaldari MaxSem jgonera jdlrobson ^^ [18:04:01] kaldari: http://hatjitsu.wmflabs.org/68473 [18:04:03] http://hatjitsu.wmflabs.org/68473 [18:04:04] (03PS3) 10Florianschmidtwelzow: Update doc for special pages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/139100 (https://bugzilla.wikimedia.org/66086) [18:10:14] awjr: hey, is there a place where one could point people to regarding the redirect tablets to mobile plan for next week? [18:10:34] greg-g: check with Maryana [18:10:42] Maryana: ^^ :) [18:11:30] greg-g: by people do you mean staff, editors..? [18:12:15] Maryana: wikimedians generally [18:12:27] mostly just informational, really [18:12:54] I mean, there's not much more than "things which identify as tablets will now get the mobile view instead of desktop" right? [18:13:04] * greg-g is playing middle man right now [18:13:43] greg-g: ask for a cut ;) [18:13:44] yeah, that's pretty much it. and for all intents and purposes "tablets" means ipads, cos that's 95%+ of our current reader & editor traffic [18:13:54] i've got a blog post draft here: https://meta.wikimedia.org/wiki/Wikimedia_Blog/Drafts/Tablet_announcement [18:14:05] Maryana: ah, awesome re blog post [18:14:08] which has some more details on the UX desing changes [18:14:52] we'll be running a centralnotice banner on the day of the redirect & sending folks to the blog post :) [18:15:07] oh neat [18:15:21] thanks! [18:15:27] that's all I need [18:18:02] np [18:19:43] 3MobileFrontend / 3Feature requests: images are too small on tablets and large phones - 10https://bugzilla.wikimedia.org/63134#c7 (10Jon) In the https://en.m.wikipedia.org/wiki/Rittergut_K%C3%BCrbitz article the image at the top is declared in wikitext using: [[File:Rittergut Kürbitz um 1860.jpg|thumb|The f... [18:21:17] Deskana|Away: ping? [18:22:45] Deskana: ping? [18:23:08] Deskana: we don't have any work done on importing page contents of old app into new one. Current behavior would require them to go in and open each of them individually before they are all saved. [18:23:17] YuviPanda: Chatting to Brion. 10 minutes? :) [18:23:30] Deskana: oh, sure. do ping back though, since I think this should block release [18:23:39] YuviPanda: Okay. :) [18:26:19] (03PS3) 10Jdlrobson: Use phpdoc.xml for configuration of phpdoc [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/139151 (owner: 10Florianschmidtwelzow) [18:26:48] (03CR) 10Jdlrobson: [C: 032] "I added a new line to bottom of xml file" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/139151 (owner: 10Florianschmidtwelzow) [18:27:23] (03Merged) 10jenkins-bot: Use phpdoc.xml for configuration of phpdoc [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/139151 (owner: 10Florianschmidtwelzow) [18:29:30] (03CR) 10Jdlrobson: [C: 032] Update doc for special pages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/139100 (https://bugzilla.wikimedia.org/66086) (owner: 10Florianschmidtwelzow) [18:30:05] (03Merged) 10jenkins-bot: Update doc for special pages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/139100 (https://bugzilla.wikimedia.org/66086) (owner: 10Florianschmidtwelzow) [18:35:27] 3MobileFrontend / 3Hygiene: make phpdoc shows errors in our PHP documentation - 10https://bugzilla.wikimedia.org/66086#c17 (10Florian) 5ASSI>3RESO/FIX Last capture: Parsing /var/www/devwiki/extensions/MobileFrontend/MobileFrontend.alias.php Parsing /var/www/devwiki/extensions/MobileFrontend/MobileFronten... [18:42:49] FlorianSW|away: \o/ :) [18:44:43] I got a new iPhone today as my work phone, taking the beta for a spin. [18:45:07] Interesting how different the UX is. [18:45:21] Versus Android. [18:45:25] * YuviPanda hasn't really tried the iOS alpha [18:45:49] The TOC is an interesting concept. [18:46:01] ragesoss: what do you think of the images? [18:46:05] I think I might like it. [18:46:22] gah, missed the Dark Theme meeting! [18:46:22] ragesoss: hmm, the images are going away, It hink [18:46:39] dbrant: 'tis ok, nothing much there. we just decided to do it only on Android. [18:46:57] Images? Seems to be just pulling up the file page. [18:47:13] ragesoss: oh, the ToC had images the last time I saw it [18:47:22] Oh that! [18:47:40] Yeah, that's what I find most interesting. [18:48:22] jdlrobson: ? :D [18:48:45] That design seems more suited to the wider screens of a phablet than the slim iPhones. [18:49:36] The animation when you use the TOC to navigate is also nice. [18:50:08] Lack of flick-scroll momentum is not so nice. [18:50:56] And I immediately appreciate the Android drawer swipes even more now. [18:51:18] jdlrobson: Now i know what you mean :D It's late and was a stresful day :P [18:52:28] Oh, iOS also has TOC swipe. Motion is just a little different. [18:54:01] The way the article itself is handled when TOC is open is sweet! [19:22:44] yurikR, food? [19:31:49] YuviPanda: Okay, so, back. [19:31:53] Let's chat. [19:31:58] Deskana: ASL? [19:31:59] :P [19:32:29] Deskana: so, right now, old saved pages are carried over in name only - you need to open each of them individually to actually have them be saved locally [19:32:42] Deskana: that's terrible, since you'd open saved pages mostly when you have no network [19:32:57] Deskana: so on first load, we need to actually locally save all the saved pages, with some sort of progressbar, etc [19:33:02] That sucks pretty bad, yeah. [19:33:15] Deskana: this could potentially be a part of the onboarding workflow, with an option to skip it (and discard your saved pages as well) [19:38:32] YuviPanda: Well, we can't guarantee that the onboarding will be in the first release. [19:38:51] How about this? [19:39:46] If you load the app and it imports pages from the old app, show the user a dialogue saying "Want to pre-load your imported offline pages? This may take some time.". [19:39:55] Yes and no options. [19:39:57] No, do nothing. [19:40:03] Yes, do the (potentially long) preload. [19:41:48] YuviPanda: It's a bit of a hack solution, but it's simple, only a one-time thing, and even then only for part of the user base. [19:42:15] Deskana: two things. 1. Modal dialogs are terrible UX, doubly so when they just pop up when you open the app, 2. The UI work for this is way more than the UI work for onboarding anyway, if we do it as a dialog box, 3. If we do it as dialog box, error handling is complicated - what if the network fails in the middle? what if they run out of space? how to retry? 4. Technically, it'll be simpler to roll Onboarding on to this [19:42:15] and have this be a part of that than to do this [19:42:45] Deskana: Dialogs running potentially long, cancellable / errorable things that talk to the network isn't really simple [19:42:54] Right. [19:44:44] woo, new tablet styles live on enwiki! [19:44:54] YuviPanda: Let me have a quick chat to Maryana about this. I'm unsure how to proceed. [19:45:23] Deskana: ok. the technically most sensible thing to do would be to roll this into the simple onboarding flow that was shown at the last priori meeting. [19:51:43] MaxSem: what were the extensions you wanted added to bugello again? i've got pageimages and geodata - did you also want featuredfeeds and apisandbox? [19:51:57] TextExtracts? [19:55:08] YuviPanda: Do we have any way of getting numbers on who's used the saved pages feature on the old app? [19:55:12] YuviPanda: I suspect not, but just checking. [19:55:16] Deskana: nope [19:55:42] YuviPanda: I suspect we're dealing with an edge case here. So far nobody using the beta on the Play store has mentioned the offline pages stuff being gone. [19:56:03] Deskana: not true, at least 7 people have. [19:56:38] Oh wow! Is that on the store feedback? [19:56:50] Deskana: also, I'd suspect that the dialog based solution is technically *harder* to do than the one where we tag it to onboarding. [19:56:54] Deskana: yeah, both that and OTRS. [19:57:11] Deskana: *at least* 7, I have stopped counting a while ago. [19:57:17] Ah yeah, I see some of it now. [19:57:27] maybe 1 more since the original 7 [19:57:27] Well, what specifically are you thinking as part of the onboarding workflow? [19:58:26] Deskana: first it asks you to log in / create account (as we saw in design). after they skip/move forward with that, we tell them they have X saved pages, and ask 'do you want to prefetch them now?'. if yes, we do it there, if not we just keep 'prefetch all' as an option in the saved pages menu. [19:59:02] I'm really wary of bloating out the first-time UX. Bear in mind it's the second week of the sprint and we don't even have a design for it yet. That's a lot of pressure to put on yourselves; you'll need the design, implementation and testing done in a single week. [19:59:14] I think an "Update all" button on the saved pages bit is a really good idea. [19:59:40] It also doesn't have as many dependencies as the onboarding solution. [20:00:21] Deskana: hmm, that's true. my only concern is discoverability. Plus 'update all' implies that there already exists a local version [20:01:04] If someone tries to load a page and it doesn't load because it's not saved in the file system, they'll see that "Update all" button as a way to fix it. :) [20:01:16] After they press back from their page not loading, they'll be back at that screen right away. [20:01:38] Deskana: ah, so that's actually already taken care of - if we can't load the page from disk for some reason we fetch it from the server and save it anyway :) [20:02:31] With an option to update all in the saved pages menu, I think that's the use case satisfied. [20:02:50] dbrant: bearND ^ thoughts? [20:04:37] YuviPanda: Deskana: I don't really think that importing of saved pages should be mentioned in onboarding... [20:04:58] I kind of like the 'update all' button [20:05:05] YuviPanda: Deskana: I like the idea of an refresh button on the saved pages screen [20:05:14] hmm, ok then :) [20:05:35] * Deskana makes a card. [20:07:28] could later make it using a contextual Action Bar behavior so one could even select with pages to update. I also think once a saved page is loaded there should be a refresh button as well (to replace the "Save Page" action. This would be a small and somewhat hidden indication that one is looking at a saved page, better than nothing. [20:08:09] bearND: there's already a contextual action bar for delete :) [20:08:52] YuviPanda: even better :) [20:09:00] bearND: :D [20:09:19] Cards: https://trello.com/c/VFlTuZVe/42-offline-add-an-update-all-button-to-the-saved-pages-page [20:09:22] (03PS3) 10Yuvipanda: Bring back QuickReturn behavior for search bar [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/137517 [20:09:24] https://trello.com/c/NMinGQRi/41-offline-add-an-update-all-button-to-the-saved-pages-page [20:09:30] Deskana: cool! :) [20:09:43] Deskana: also, the patch to bring back autohiding top bar is waiting to be merged https://gerrit.wikimedia.org/r/#/c/137517/ [20:10:17] I have that as a card in the next sprint. [20:10:24] I can just move it to this one and put it in code review. [20:10:34] Deskana: yeah. let me remove my -1 so dbrant or bearND can review. [20:10:56] (03CR) 10Yuvipanda: [C: 031] "-1 removed so someone can review and merge :)" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/137517 (owner: 10Yuvipanda) [20:11:11] YuviPanda: i'll do it [20:11:18] dbrant: woot !:) [20:12:29] yeah! auto-hide :) [20:14:23] (03CR) 10Dbrant: [C: 032] Bring back QuickReturn behavior for search bar [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/137517 (owner: 10Yuvipanda) [20:14:40] dbrant: woot [20:15:46] YuviPanda: Good catch on this. Thanks for bringing it to my attention. :) [20:15:50] It'd slipped past me. [20:16:42] Deskana: :D [20:16:57] YuviPanda: shall I do a release? (considering the crash fix, plus this one) [20:17:09] Deskana: yeah, I say go for it. alpha and beta. [20:17:12] err, dbrant [20:17:20] dbrant: I'd say for beta, let's switch numbering schemes to match alpha. [20:17:29] 2.0-beta- [20:17:32] YuviPanda: ok [20:17:37] dbrant: cool [20:17:50] bearND: did you update the patch to use the js img replacement? [20:18:39] YuviPanda: I haven't pushed it yet, testing right now [20:18:44] bearND: cool. [20:20:18] ISO 8601! [20:20:41] Deskana: 2014-06-13! [20:21:03] it also made it easy for people to figure out how out of date their current build is [20:21:22] MaxSem: yt? [20:21:24] Deskana: I'm also quite happy with the number of people who made it all the way to 'More' -> 'About' -> 'scroll down' -> hit 'send feedback' -> 'type feedback' -> send [20:25:24] Deskana: just wanted to say I really appreciate the prompt 'we had a meeting, this is what happened' emails :) [20:25:32] awjr, yep [20:25:46] saw bugello in action:) [20:25:51] MaxSem: i've got pageimages and geodata bugs working in bugello - what was the other extension(s) you wanted? [20:25:53] :D [20:26:03] YuviPanda: It's particularly important because we can't have everyone in the meetings because it increases the overhead so massively, but at the same time everyone should have their say. [20:26:10] TextExtracts, Mantle [20:26:20] Deskana: indeed. agreed on all counts. [20:26:32] (do we even have a component for Mantle?) [20:26:35] YuviPanda: Also it seems like mobile outsiders like Steven are finding them helpful too, so I'm definitely going to carry on. [20:26:40] awjr, also FeaturedFeeds [20:26:42] Deskana: yup! [20:26:52] MaxSem: cool - one sec [20:27:27] Deskana: also, someone was complaining about the dual 'mobile' and 'mobile app edit' tags being cluttering. [20:27:38] Deskana: I also think we should remove the 'mobile' tag from app edits. It's a 4line patch as well. [20:28:31] dbrant: when you make the release, can you also email me the beta apk? I am going to put it on releases.wikimedia.org so people without play can get it [20:28:43] YuviPanda: Well, we're not the only consumers of this information. We should make sure that the others (analytics and mobile web, to think of two) are also happy with that decision. [20:28:45] YuviPanda: sure [20:28:56] YuviPanda: I seem to recall Dario and Jon both wanting to keep the mobile edit tag for backwards compatibility. [20:29:15] Deskana: no, they wanted to *not* rename it to 'mobile web edit' for backwards compatibility. [20:29:30] Deskana: currently it is backwards 'incompatible' since not all edits tagged mobile are from mobile web [20:29:38] ok MaxSem, featuredfeeds added [20:29:43] everything look ok in trello? [20:30:06] (03PS1) 10Dbrant: Bump version number for 2.0-alpha-2014-06-12 [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/139194 [20:30:18] YuviPanda: "We propose the creation of a new “app” tag in MediaWiki on top of the current “mobile edit” tag, which we will keep for backward-compatibility." (Dario) [20:30:22] awjr, yes - thank you [20:30:33] Deskana: indeed, keep the tag, not change it [20:30:49] Deskana: doesn't mean tag all app edits as mobile too. [20:30:52] DarTar: around? [20:31:05] YuviPanda: "This will give us an easy way of counting all mobile edits combined or app-only edits" [20:31:13] MaxSem: np - please feel free to triage bugs from those extensions so we can keep the board uncluttered [20:31:27] Deskana: but no simple way of counting only mobile web edits. [20:31:45] YuviPanda: That is true, yes. But Dario seemed to prefer this solution. [20:32:13] YuviPanda: Like I say, as PM for Apps I'm totally fine with any of these solutions as they don't affect me, but I just want to make sure that the relevant people are happy too. :) [20:32:38] Deskana: alright, so I'll make a patch, then catch up with DarTar to make sure he's happy and then get that merged by someone from Mobile Web :) [20:34:29] (03PS1) 10Yuvipanda: Don't tag edits made from Mobile apps with mobile [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/139195 [20:34:35] MaxSem: sorry it took so long to get around to that :p [20:35:55] YuviPanda: heyo, was the tag convo you were having with Deskana related to my request to change the copy of the tags? if so, ignore me -- i'm just a language snob and start hyperventilating when i see redundancy ;) [20:36:49] YuviPanda: Maryana just wanted the tags renamed rather than de-tagged. [20:36:50] Maryana: no, it's not :) it was from someone from nlwiki (sj?) and also I realized it's a harder query to get just the mobile web tags (no easy way to say 'get me edits with tags x but without tag y') [20:37:11] Deskana: right now, with recentchanges, I don't think it's possible to just get a list of mobile web edits, for example [20:37:24] YuviPanda: Sounds like there's a lot of ambiguity about this. I think getting a thread going on mobile-l about this would be good. [20:37:45] Deskana: ok, let me send it out. [20:37:48] can't you just use "and != app edit"? [20:38:33] (03CR) 10Florianschmidtwelzow: [C: 031] Don't tag edits made from Mobile apps with mobile (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/139195 (owner: 10Yuvipanda) [20:39:24] Maryana: nope, https://en.wikipedia.org/w/index.php?namespace=&tagfilter=mobile+edit+and+%21%3D+mobile+app+edit&title=Special%3ARecentChanges [20:39:41] oh, i meant in the database [20:40:10] select * from tag_summary where ts_tags = "mobile edit" and ts_tags != "app edit" [20:40:13] that sorta thing [20:40:42] that doesn't solve the problem for the community, of course, but it solves it for me :) [20:40:43] (03PS1) 10Yurik: Handle Title::getTitleValue() returning NULL [extensions/JsonConfig] - 10https://gerrit.wikimedia.org/r/139198 [20:40:48] and i'm all that matters, clearly ;) [20:41:46] Maryana: you'd have to do something like 'where ts_tags like 'mobile edit' and ts_tags not like 'mobile app edit''; [20:41:49] (03CR) 10Dr0ptp4kt: [C: 032] Handle Title::getTitleValue() returning NULL [extensions/JsonConfig] - 10https://gerrit.wikimedia.org/r/139198 (owner: 10Yurik) [20:41:53] (03Merged) 10jenkins-bot: Handle Title::getTitleValue() returning NULL [extensions/JsonConfig] - 10https://gerrit.wikimedia.org/r/139198 (owner: 10Yurik) [20:41:55] Maryana: which will also not use an index and throw perf down to the dogs [20:42:16] hehe, nonperformant queries is my middle name [20:42:28] (… i got teased a lot in school) [20:42:58] Maryana NPFQ! [20:43:28] :D [20:43:40] Maryana: sounds vaguely rapperish [20:43:46] haha [20:43:55] MC NPFQ [20:44:02] world's nerdiest rapper [20:44:06] :D [20:44:13] something something partial indexes [20:45:52] (03PS1) 10Yurik: Fixing patch 139198 [extensions/JsonConfig] - 10https://gerrit.wikimedia.org/r/139199 [20:46:30] (03CR) 10Dr0ptp4kt: [C: 032] Fixing patch 139198 [extensions/JsonConfig] - 10https://gerrit.wikimedia.org/r/139199 (owner: 10Yurik) [20:46:33] (03Merged) 10jenkins-bot: Fixing patch 139198 [extensions/JsonConfig] - 10https://gerrit.wikimedia.org/r/139199 (owner: 10Yurik) [20:47:48] Maryana: You should move to the UK and become a member of parliament. [20:47:49] (03PS1) 10Dbrant: Move everything to beta package [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/139200 [20:48:01] Maryana: Then the convention would be to refer to you as Maryana Pinchuk MP. [20:48:03] Deskana: MP NPFQ [20:48:08] hehe [20:48:17] or become a member of the military police [20:48:21] Maryana Pinchuk MP, Mobile PM [20:48:30] MP MP, PM [20:48:35] omg [20:48:41] i was born for this job! [20:48:43] :) [20:48:46] MP MP, MPM [20:49:02] OR JUST RENAME YOURSELF TO MARYANA RAMBO [20:49:14] (03Abandoned) 10Dbrant: Move everything to beta package [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/139200 (owner: 10Dbrant) [20:49:15] haha [20:51:52] (03PS4) 10BearND: [WIP] Save images of saved page [apps/android/wikipedia] (savedpages) - 10https://gerrit.wikimedia.org/r/139067 [20:53:49] (03CR) 10MaxSem: Don't tag edits made from Mobile apps with mobile (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/139195 (owner: 10Yuvipanda) [20:54:37] (03CR) 10MaxSem: [C: 032] Collapse on the highest available heading level [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/137836 (https://bugzilla.wikimedia.org/60478) (owner: 10Jdlrobson) [20:54:39] (03CR) 10Yuvipanda: Don't tag edits made from Mobile apps with mobile (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/139195 (owner: 10Yuvipanda) [20:54:48] YuviPanda: dbrant: ^^ (https://gerrit.wikimedia.org/r/139067 ) should be functional. still thinking about encapsulating the UrlMap [20:55:11] (03Merged) 10jenkins-bot: Collapse on the highest available heading level [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/137836 (https://bugzilla.wikimedia.org/60478) (owner: 10Jdlrobson) [20:55:35] (03CR) 10OliverKeyes: [C: 031] "Chipping in from an R&D perspective; this looks like a good change to put in :)." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/139195 (owner: 10Yuvipanda) [20:55:45] MaxSem: Y you hate double quotes? [20:55:48] jgonera: MaxSem can one of you respond to the mobile-tech email '[web] Tablet redirect launch is coming quick! Blockers, bugs?' about the process for enabling the tablet redirect? [20:56:11] YuviPanda, cuz they're C. cuz they're Java. cuz they're slower [20:56:24] MaxSem: hmpf. fine. [20:58:53] YuviPanda: I think I need to be walked through merging/pushing to the beta branch... [20:58:57] YuviPanda, Deskana: did you guys ping me? I was afk [20:59:23] awjr, I can have a look later, but I'd appreciate if MaxSem described the process if necessary, since he probably knows it better [20:59:23] DarTar: see #wikimedia-research [20:59:26] 3MobileFrontend / 3beta: Table of contents looks weird when only one lead section - 10https://bugzilla.wikimedia.org/60478 (10Jon) 5PATC>3RESO/FIX [20:59:42] 3MobileFrontend / 3stable: Can't edit subsequent sections when a section is commented out - 10https://bugzilla.wikimedia.org/60479 (10Jon) 5PATC>3RESO/FIX [20:59:56] YuviPanda: ok reading [21:00:41] cool jgonera thanks - MaxSem please respond when you've got a moment :) [21:04:58] awjr, resurrected the ops@ thread about it [21:05:26] nothing is needed besides a deployment of a one-line patch [21:06:30] MaxSem: great thanks - can you mention as much on the mobile-tech mail to close the loop there? not everyone on that list is on ops or is necessarily aware it's as simple as merge/deployment [21:06:32] (03PS16) 10Dbrant: Move everything to beta package [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/137311 (owner: 10Yuvipanda) [21:07:04] dbrant: oh, sorry, missed that in the conversation. did you manage to make that work? [21:08:17] YuviPanda: No, I just pushed to the original patch... [21:08:27] dbrant: ah, right. that's ok for now, I think [21:08:38] dbrant: you can push to the beta branch with 'git push gerrit HEAD:refs/for/beta' [21:09:00] awjr, mobile-tech is CC'd [21:09:14] dbrant: ah, also if you are using git-review you can just do git review beta [21:10:18] YuviPanda: alright! thx [21:14:49] ok MaxSem thanks [21:19:31] (03PS2) 10Kaldari: Promote mediawiki-ui buttons to stable in mobile [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/135137 [21:22:02] jgonera: do we have a bug filed about the image flipping in VE edit mode? [21:22:23] Maryana, flipping? not being left/right-aligned? [21:23:05] no, showing up on the left instead of the right in edit mode [21:23:11] and then going back to the right when you save [21:23:58] Deskana: Maryana had a conversation with DarTar, halfak and Ironholds on IRC and reached a consensus that'll preserve status quo while also making things easier. DarTar is writing an email to summarize while I'm preparing patches [21:24:43] dbrant: got email with build, ty [21:25:48] YuviPanda: Great. :) [21:28:07] (03PS2) 10Yuvipanda: Tag mobile web edits more explicitly [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/139195 [21:29:15] running a couple quick errands - back online in 45min [21:29:34] YuviPanda: Where's the edit workflow mockup for Android? [21:29:46] HERP [21:29:47] Got it. [21:29:52] Sorry, was getting my dates mixed up. [21:29:53] Deskana: :D ok [21:38:13] YuviPanda, Deskana: summary posted [21:48:32] jdlrobson: kaldari MaxSem Maryana jgonera im about to head out - need anything before i go? [21:48:43] nah [21:48:50] nope [21:48:54] are we all set for the redirect on the deployment cal & such? [21:49:19] nope [21:49:25] just poked ops about it [21:49:29] YuviPanda, dbrant, bearND: From the Android side, what things do you guys want to see in the next sprint? [21:49:57] Maryana: afaik unless there are any last minute patches/lightning deploys that need to happen [21:50:11] Deskana: besides dark theme? [21:50:20] YuviPanda, dbrant, bearND: Here's what I've got so far https://trello.com/b/BQHyq56D/mobile-app-sprint-34 [21:50:26] awjr: k cool [21:50:33] go have fun, then :) [21:50:36] YuviPanda, dbrant, bearND: Dark theme, home button, spike for styling improvements. [21:50:48] :D [21:51:02] Deskana: ah, hmm. onboarding, I'd think. [21:51:03] Maryana: couldn't hurt to dbl check with the team on fri and mon during standup [21:51:25] YuviPanda: I was thinking we'd be starting that this sprint and probably carrying it over if it's unfinished so I didn't explicitly include it. [21:51:33] Deskana: hmm, ok. [21:51:45] YuviPanda: Do you have concerns about that? [21:51:48] awjr: roger. is somebody covering standup leading? [21:51:52] Deskana: oh, I know! reference display! [21:51:55] Maryana: aye, jgonera [21:52:01] Deskana: https://trello.com/c/PAOojlEQ/316-reference-display [21:52:09] Deskana: no, that sounds right (re: onboarding) [21:52:10] i sent an email i think yesterday with coverage deets [21:52:24] ah, good deal [21:52:24] Whoa, that's a bug. [21:52:33] juliusz is doing standups, you'll be doing kickoff and dan g is doing the retro on monday :) [21:52:37] If you press on a reference in the preview it bounces you to your browser. [21:52:39] Deskana: a less-black nav menu? [21:52:42] * Deskana files. [21:53:07] Deskana: +1 on 'less black nav menu' [21:53:14] im out, see you all on weds [21:53:25] awjr: Have fun! [21:53:30] awjr: have fun! [21:53:37] * YuviPanda also first read that as 'see you all on meds' [21:54:30] Deskana: I think reference display will be a biggish one, and splitting that out into cards + dark theme will fill out that sprint [21:54:41] Deskana: +1 on less-black nav as well [21:54:50] Deskana: It would be good to clean up the login screen a bit, even if we can't fit all of the on-boarding in. The button "Create Account" should be a link and not look like an "Log In" button. [21:55:04] +1 ^^ [21:55:15] 3Wikipedia App / 3Android App: Android: Pressing on a reference during preview shouldn't bounce you to your browser - 10https://bugzilla.wikimedia.org/66558 (10Dan Garry) 3NEW p:3Unprio s:3normal a:3None 1) Edit a page with references in. 2) Make some random changes. 3) In preview, press on one of th... [21:56:29] Deskana: reference display is also technically a regression, since the old app had a nice one (similar to what's in MobileFrontend now) [21:58:13] 3MobileFrontend / 3alpha: Tapping a link in VE link inspector takes you to link in desktop mode - 10https://bugzilla.wikimedia.org/66559 (10Maryana Pinchuk) 3NEW p:3Unprio s:3normal a:3None In prod: * Go to an article in alpha * Get into VE edit mode * Tap any link Expected: you're taken to the lin... [21:59:15] References are pretty broken in iOS. [21:59:28] Tapping on them hides the nav bars in most cases... [21:59:51] Deskana: yeah, on Android they just jump you around, and you have to scroll all the way back up [22:00:42] 3MobileFrontend / 3alpha: Tapping a link in VE link inspector takes you to link in desktop mode - 10https://bugzilla.wikimedia.org/66559#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/sHQiIohr [22:00:51] (03PS7) 10Jdlrobson: Hygiene: Icon cleanup [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/133190 [22:01:07] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Icon cleanup [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/133190 (owner: 10Jdlrobson) [22:02:51] Deskana: +1 reference display, maybe for first release without the copy/share/add another source buttons to keep it simple, and to leave some breathing room [22:03:20] (03PS8) 10Jdlrobson: Hygiene: Icon cleanup [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/133190 [22:05:26] (03CR) 10Jdlrobson: [C: 032] Tag mobile web edits more explicitly [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/139195 (owner: 10Yuvipanda) [22:06:00] (03CR) 10Jdlrobson: "Fixed in https://gerrit.wikimedia.org/r/133190" (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/133189 (owner: 10Jdlrobson) [22:06:02] (03Merged) 10jenkins-bot: Tag mobile web edits more explicitly [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/139195 (owner: 10Yuvipanda) [22:06:07] (03Abandoned) 10Jdlrobson: Hygiene: Icon cleanup [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/133189 (owner: 10Jdlrobson) [22:06:15] jdlrobson: ty [22:07:02] YuviPanda, bearND, dbrant: How do you guys feel about styling on the Android app? [22:07:29] YuviPanda, bearND, dbrant: Vibha feels it's better on Android than iOS right now. I don't know if any of you have tested the iOS app, but I'd appreciate thoughts on that. [22:07:45] Deskana: page styling? it pretty much exactly mimics Mobile Web (we use the exact same files). it could use improvement, but that'd apply to mobile web as well. [22:08:04] Deskana: I think it's in a place where it's shippable, and orders of magnitude better than the old app. [22:08:11] Deskana: and yeah, I haven't really used the iOS app so can't say [22:08:19] Deskana: I would second "shippable" [22:08:40] (03PS9) 10Jdlrobson: Hygiene: Icon cleanup [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/133190 [22:09:05] Deskana: theoretically, iOS is also using the exact same styles as we are, so I am unsure why it isn't the same. that sounds like a bug in the implementation rather than a styling fix. [22:09:41] I'm just reiterating Vibha's concerns. If she thinks it's worse somehow then there clearly some work we need to do somewhere, whether it's bug or feature. [22:09:44] (03PS3) 10Jdlrobson: Promote mediawiki-ui buttons to stable in mobile [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/135137 (owner: 10Kaldari) [22:10:03] Deskana: sure, I agree. my gut feeling is a bug. [22:10:35] Deskana: I don't have an easy way to test the iOS app though, so unsure what exactly is happening there. [22:11:13] 3Wikipedia App / 3Android App: Weird "Â" appears on pages in the app - 10https://bugzilla.wikimedia.org/66187#c3 (10Bernd Sitzmann) It also happens on the English site: [[Barack Obama]] [22:11:57] Deskana: ^ that's already on the board but i wanted to +1 that since you mention styling [22:12:33] YuviPanda: and that issue does not appear on MF [22:12:59] bearND: I think that's curl or something fucking up the encoding. I'll take a look at it, should be an easy fix [22:14:44] (03PS1) 10Yuvipanda: Tag mobile web edits more explicitly [extensions/MobileFrontend] (wmf/1.24wmf8) - 10https://gerrit.wikimedia.org/r/139271 [22:15:04] (03CR) 10Jdlrobson: [C: 032] Promote mediawiki-ui buttons to stable in mobile [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/135137 (owner: 10Kaldari) [22:15:13] (03PS1) 10Yuvipanda: Tag mobile web edits more explicitly [extensions/MobileFrontend] (wmf/1.24wmf9) - 10https://gerrit.wikimedia.org/r/139272 [22:15:40] (03Merged) 10jenkins-bot: Promote mediawiki-ui buttons to stable in mobile [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/135137 (owner: 10Kaldari) [22:15:42] (03PS1) 10Jdlrobson: Make settings submit button mw-ui-constructive [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/139274 [22:22:21] chrismcmahon: hey! re: betalabs, do you know how I can trigger it to run in 'm' mode? [22:22:24] as in, mobile? [22:23:02] YuviPanda: yes, en.m.wikipedia.beta.wmflabs.org (there are a few other ways, but that's easiest) [22:23:21] (03CR) 10Kaldari: [C: 032] Hygiene: Icon cleanup [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/133190 (owner: 10Jdlrobson) [22:23:44] 3MobileFrontend / 3alpha: VE citation form bugginess on iOS - 10https://bugzilla.wikimedia.org/66562 (10Maryana Pinchuk) 3NEW p:3Unprio s:3normal a:3None In prod on an iPad: * Go to an article in alpha * Get into the VE editing interface * Tap on citation icon in the toolbar to add a citation (try "... [22:23:54] (03Merged) 10jenkins-bot: Hygiene: Icon cleanup [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/133190 (owner: 10Jdlrobson) [22:24:01] YuviPanda: congratulations on the Android app [22:24:14] chrismcmahon: woot! Ty :) [22:24:24] jgonera: VE still not loading in vagrant :( [22:24:27] even with uls enabled [22:24:57] YuviPanda: dbrant|bbl Deskana: more thoughts re: references. I'd be also ok to just add navigation via page internal links (e.g. to a reference) to the back stack. That way the user could just press the back button. [22:25:01] chrismcmahon: hmm, can you tell me the SHA of what MobileFrontend is running. [22:25:16] bearND: yeah, but that complicates our backstack a bit, and is not the 'right thing' to do anyway. [22:25:26] 3MobileFrontend / 3alpha: VE citation form bugginess on iOS - 10https://bugzilla.wikimedia.org/66562#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/DPv04bXr [22:25:28] bearND: I'm ok with just letting the references be for now and fixing it in next releaese [22:26:05] YuviPanda: I don't understand the question: SHA of what, exactly? beta labs should have current master branch of MF [22:27:24] chrismcmahon: hmm, a commit merged about an hour ago seems to have not made it yet. [22:27:53] YuviPanda: good points [22:28:45] Maryana jgonera I think VE is broken in beta labs right now also from some very recent commit: https://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-firefox/619/testReport/junit/ [22:33:13] YuviPanda: you mean this one? https://gerrit.wikimedia.org/r/#/c/139195/ [22:33:28] chrismcmahon: yes [22:33:34] chrismcmahon: wfm locally, but not on betalabs [22:34:10] YuviPanda: I'm guessing we're lagging on i18n update not specifically for MF [22:34:20] chrismcmahon: aaah, right. that'd make sense. [22:34:26] chrismcmahon: any way to force it? [22:34:39] chrismcmahon: since this is going on SWAT in about 25m [22:35:03] YuviPanda: good damn question. First time I've had to do try it. greg-g ^^ [22:35:21] chrismcmahon: hashar isn't around, I guess. [22:35:29] chrismcmahon: so we can't force i18n-update to run [22:35:33] it does work fine locally though [22:37:04] YuviPanda: unfortunately I don't know how the i18n-update is triggered in beta labs. Reading the change it seems low-risk to me. [22:37:14] chrismcmahon: yeah, does to me too. [22:38:41] beta scap is running right now, which should update i18n [22:38:42] https://integration.wikimedia.org/ci/job/beta-scap-eqiad/ [22:39:04] done [22:39:06] https://integration.wikimedia.org/ci/job/beta-scap-eqiad/8973/console [22:39:36] * YuviPanda checks [22:39:44] greg-g: indeed, all good now [22:41:26] good [22:42:25] thanks greg-g YuviPanda. beta labs ftmfw [22:43:59] (03PS1) 10Jdlrobson: Simplify toggling / dynamic page loading code [extensions/MobileFrontend] (wmf/1.24wmf7) - 10https://gerrit.wikimedia.org/r/139278 [22:44:49] YuviPanda: what's the deal with those patches in different MobileFrontend branches [22:44:56] are we planning to deploy outside deployment window? [22:45:03] jdlrobson: SWAT [22:45:20] ah i just read above [22:45:29] who's SWATing it [22:45:48] jdlrobson: :) usual SWAT deployers, I'd guess. I'll be around as well to test and verify [22:59:08] (03CR) 10Catrope: [C: 032] Tag mobile web edits more explicitly [extensions/MobileFrontend] (wmf/1.24wmf8) - 10https://gerrit.wikimedia.org/r/139271 (owner: 10Yuvipanda) [22:59:12] (03CR) 10Catrope: [C: 032] Tag mobile web edits more explicitly [extensions/MobileFrontend] (wmf/1.24wmf9) - 10https://gerrit.wikimedia.org/r/139272 (owner: 10Yuvipanda) [22:59:44] (03Merged) 10jenkins-bot: Tag mobile web edits more explicitly [extensions/MobileFrontend] (wmf/1.24wmf8) - 10https://gerrit.wikimedia.org/r/139271 (owner: 10Yuvipanda) [22:59:54] (03Merged) 10jenkins-bot: Tag mobile web edits more explicitly [extensions/MobileFrontend] (wmf/1.24wmf9) - 10https://gerrit.wikimedia.org/r/139272 (owner: 10Yuvipanda) [23:01:59] (03PS1) 10BearND: Save images of saved page [apps/android/wikipedia] (savedpages) - 10https://gerrit.wikimedia.org/r/139280 [23:06:28] (03CR) 10JGonera: "I don't see how chaining is related to the issue we have here. Chaining simply means page.on( 'sth', sth ).on( 'sth2', sth2 );" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/137734 (https://bugzilla.wikimedia.org/65633) (owner: 10Jdlrobson) [23:21:18] (03PS1) 10Yurik: fixed banner closing box layout [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/139287 [23:21:47] (03CR) 10Dr0ptp4kt: [C: 032] fixed banner closing box layout [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/139287 (owner: 10Yurik) [23:21:56] (03Merged) 10jenkins-bot: fixed banner closing box layout [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/139287 (owner: 10Yurik) [23:24:14] (03CR) 10Jdlrobson: "Maybe this will explain it better...?" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/137734 (https://bugzilla.wikimedia.org/65633) (owner: 10Jdlrobson) [23:35:42] 3MobileFrontend / 3General/Unknown: Thumbnails for search results don't make sense for most projects - 10https://bugzilla.wikimedia.org/66455 (10Jon) 5PATC>3RESO/FIX [23:41:27] YuviPanda: dbrant|bbl: the previous patch should make it more OO and maintainable. Looking to see if we can push the whole JSONArray with all the URL mappings over to the JS side in one fell swoop. For that I'll probably make a separate change in Gerrit since I'm not sure if you like the change in JS (basically trying to reuse the replaceImageSrc function). How do you debug the JS side inside the webview? [23:42:03] bearND: ah, with https://developer.chrome.com/devtools/docs/remote-debugging [23:42:47] YuviPanda: cool. Thanks! [23:42:50] bearND: we have it enabled in our code, so you can usually just connect your device, go to chrome://inspect, the devices tab and good to go [23:43:09] (03PS3) 10Jdlrobson: Ensure edit protection is declared when only move permissions exist on page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/137735 (https://bugzilla.wikimedia.org/65631) [23:44:13] YuviPanda: I made some deliberate changes to break the JS code rewriting the URLs, ran grunt, rebuild the app, but it's still showing the images. Weird. [23:44:45] bearND: ah, so the rewrite stuff, I think it only rewrites the src if the image didn't load [23:45:02] bearND: I *think*. it'll load from the server if possible, and if not hit the file url [23:45:19] YuviPanda: but i had airplane mode on and cleared the apps cache [23:45:26] bearND: aaah, hmm. [23:45:28] bearND: that's... weird [23:45:32] bearND: break it harder! :D