[00:21:15] <grrrit-wm>	 (03PS1) 10JGonera: Revert "Collapse on the highest available heading level" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/139299 
[00:21:24] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Revert "Collapse on the highest available heading level" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/139299 (owner: 10JGonera)
[00:21:48] <jgonera>	 kaldari, can you check if the latest master exhibits the bug described in the commit message here: https://gerrit.wikimedia.org/r/#/c/139299/
[00:21:53] <jgonera>	 and if yes, revert that patch?
[00:22:00] <jgonera>	 Guest62896, Jon are you here?
[00:22:18] <Guest62896>	 yo
[00:22:26] <jgonera>	 is this a yes?
[00:22:33] <Guest62896>	 for some reason limechat won't let me rename myself as jdlrobson :)
[00:22:39] <jgonera>	 your patch that Max merged has meesed up page layout
[00:22:44] <jgonera>	 see https://gerrit.wikimedia.org/r/#/c/139299/ jdlrobson2 
[00:22:56] <jdlrobson2>	 jgonera: in what way?
[00:23:06] <jgonera>	 jdlrobson2, just read the commit message
[00:23:18] <jdlrobson2>	 i just did.
[00:23:22] <jdlrobson2>	 give me 20 mins to look into it
[00:23:25] <grrrit-wm>	 (03PS2) 10JGonera: Revert "Collapse on the highest available heading level" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/139299 
[00:23:34] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Revert "Collapse on the highest available heading level" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/139299 (owner: 10JGonera)
[00:23:36] <jdlrobson2>	 (Rather than revert it straight away)
[00:23:41] <jdlrobson2>	 we have a week till next deployment train ;-)
[00:23:57] <jdlrobson2>	 i suspect something else changed and had a knock on effect when it got rebased
[00:24:01] <jdlrobson2>	 (it was fine before)
[00:24:07] <jgonera>	 jdlrobson2, ok, sure, it just makes working on tablet styling fixes a bit difficult...
[00:24:20] <jdlrobson2>	 give me 20 mins i'm sure it's simple
[00:24:24] <jgonera>	 ok
[00:25:49] <jdlrobson2>	 jgonera: can you post a screen?
[00:25:55] <jdlrobson2>	 what kind of page are yu seeing this issue on?
[00:26:00] <jdlrobson2>	 also tablet or mobile?
[00:27:08] <jgonera>	 jdlrobson2, http://imgur.com/ENC9Tu8
[00:27:13] <jdlrobson2>	 also stable/beta/alpha?
[00:27:17] <jgonera>	 whatever, if the section is open, I see this
[00:27:22] <jgonera>	 beta, can check other modes
[00:27:28] <jdlrobson2>	 wow. mm that's odd
[00:27:39] <jgonera>	 stable too
[00:28:15] <bearND>	 YuviPanda: it won't hit any of my breakpoints in JS land. I see 15 different index.html main entries. I guess that means I got 15 WebViews going. Some of them show up as detached, others as empty.
[00:28:38] <YuviPanda>	 bearND: hmm, are you able to see the source and verify you're on the correct webviews?
[00:29:09] <jdlrobson2>	 kaldari: can you replicate this?
[00:29:11] <bearND>	 YuviPanda: I can see the source (bundle.js), and added breakpoints
[00:29:28] <bearND>	 YuviPanda: not sure how to see which webview is the right one
[00:29:28] <YuviPanda>	 bearND: hmm. can you edit the HTML under elements and see if tthey change as ewll?
[00:29:36] <kaldari>	 jdlrobson2: testing now
[00:29:36] <jdlrobson2>	 jgonera: i'm not seeing this on my local master..
[00:29:49] <jdlrobson2>	 jgonera: can you check what css rule is styling that long line?
[00:30:03] <jgonera>	 jdlrobson2, I can in a few mins
[00:30:11] <jdlrobson2>	 jgonera: thanks.
[00:30:13] <jdlrobson2>	 i'm checking beta labs now
[00:30:56] <kaldari>	 jdlrobson2 jgonera: yes, I see the bug locally on master
[00:31:07] <YuviPanda>	 bearND: usually the topmost one is the one currently visible
[00:31:11] <bearND>	 YuviPanda: ah, that's how i figure out which is the correct webview
[00:31:23] <jdlrobson2>	 ok i can see it on betalabs
[00:31:40] <jdlrobson2>	 i have no idea why my master is fine
[00:32:03] <bearND>	 YuviPanda: great. changing elements works
[00:32:06] <jdlrobson2>	 mm where did Max go, i'm curious if he checked before merging :)
[00:32:13] <YuviPanda>	 bearND: cool. try breakpoints now?
[00:32:52] <jdlrobson2>	 ooh super weird. i see what's happening but i dont know why!
[00:33:17] <YuviPanda>	 ^ most of life
[00:34:02] <jdlrobson2>	 k i can replicate it now
[00:34:23] <jdlrobson2>	 aahh obviously
[00:34:57] <grrrit-wm>	 (03PS1) 10Kaldari: Revert "Collapse on the highest available heading level" [extensions/MobileFrontend] (wmf/1.24wmf7) - 10https://gerrit.wikimedia.org/r/139300 
[00:35:13] <jdlrobson2>	 kaldari: waitttt
[00:35:24] <jdlrobson2>	 ive got a fix and it hasn't made it to production yet
[00:35:29] <jdlrobson2>	 it was merged today
[00:35:31] <YuviPanda>	 wmf7? that isn't deployed anywhere...
[00:35:42] <bearND>	 YuviPanda: any good ones you recommend? I've added breakpoints to almost every function in bundle.js. Still nothing when I load a saved page again
[00:36:05] <YuviPanda>	 bearND: ah, I wonder if that's because when you load a new page, it loads a new webview...
[00:36:14] <YuviPanda>	 bearND: I usually just use console.log for debugging, rather than breakpoints
[00:36:39] <YuviPanda>	 bearND: actions.js has some code that's triggered on link clicks
[00:36:42] <kaldari>	 jdlrobson2: ?
[00:37:20] <bearND>	 YuviPanda: yeah, i thought too that it was because of new webviews but then it seems to remember when i switch from one webview to the other
[00:37:46] <bearND>	 YuviPanda: i've added console.log to my functions but get no output
[00:37:56] <YuviPanda>	 bearND: are you running grunt after every modification?
[00:37:58] <grrrit-wm>	 (03PS1) 10Jdlrobson: Hide the edit links unless they belong to a collapsible section [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/139302 
[00:38:04] <jdlrobson2>	 ^ jgonera kaldari that fixes the issue
[00:38:17] <bearND>	 YuviPanda: will try actions.js. yes, i run grunt after every js mod
[00:38:25] <grrrit-wm>	 (03Abandoned) 10Kaldari: Revert "Collapse on the highest available heading level" [extensions/MobileFrontend] (wmf/1.24wmf7) - 10https://gerrit.wikimedia.org/r/139300 (owner: 10Kaldari)
[00:38:35] <bearND>	 YuviPanda: and i see the updated js code in the chrome debugger
[00:38:39] <YuviPanda>	 bearND: you can also run grunt watch, which watches for js changes and recompiles as necssary
[00:38:52] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 04-1] "https://gerrit.wikimedia.org/r/139302 addresses the problem without the full revert." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/139299 (owner: 10JGonera)
[00:38:56] <bearND>	 YuviPanda: got that
[00:39:03] <YuviPanda>	 bearND: ok.
[00:39:05] <kaldari>	 jdlrobson2: testing....
[00:39:29] <grrrit-wm>	 (03PS2) 10Jdlrobson: Hide the edit links unless they belong to a collapsible section [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/139302 
[00:40:35] <grrrit-wm>	 (03CR) 10Kaldari: [C: 032] Hide the edit links unless they belong to a collapsible section [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/139302 (owner: 10Jdlrobson)
[00:41:18] <kaldari>	 jdlrobson2, jgonera: OK, everything should be kosher now
[00:41:27] <jdlrobson2>	 sweet crisis adverted
[00:41:37] <jdlrobson2>	 good spot jgonera :) and sorry for the bumpy ride!
[00:41:47] <Maryana>	 what happened?
[00:41:54] <Maryana>	 crisis? what crisis?
[00:42:03] <Maryana>	 jon, what did you dooooo
[00:42:07] <grrrit-wm>	 (03Abandoned) 10Kaldari: Revert "Collapse on the highest available heading level" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/139299 (owner: 10JGonera)
[00:42:10] <grrrit-wm>	 (03Merged) 10jenkins-bot: Hide the edit links unless they belong to a collapsible section [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/139302 (owner: 10Jdlrobson)
[00:48:26] <jgonera>	 thanks kaldari
[00:48:35] <bearND>	 YuviPanda: Thank you so much! Got JS debugging in Android WebView going
[00:48:43] <bearND>	 :)
[00:48:46] <YuviPanda>	 bearND: coool! :D what was the issue?
[00:49:17] <bearND>	 YuviPanda: when grunt regenerated the bundle it changed some lines numbers
[00:49:31] <YuviPanda>	 bearND: aaah
[00:51:59] <bearND>	 YuviPanda: and the other part was switching webviews seems to deactivate the breakpoints. so only console logging for that
[00:52:10] <YuviPanda>	 bearND: right
[01:27:54] <grrrit-wm>	 (03PS1) 10Dr0ptp4kt: Add basic Find in page functionality. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/139310 
[01:28:13] <YuviPanda>	 dr0ptp4kt: woot!
[01:28:54] <dr0ptp4kt>	 YuviPanda: it sort of works. mainly wanted to get the basic things in place. i decided not to try repurposing the main searchbar at the top. it seems like that may invite some pain
[01:29:02] <bearND>	 YuviPanda: whoa! Just noticed JS console log in Android logcat. Wicked! Don't even need to load the chrome debugger
[01:29:08] <dr0ptp4kt>	 YuviPanda: that is, it doesn't seem to be broken, but it does cover basic functionality
[01:29:19] <YuviPanda>	 bearND: oh yeah :D
[01:30:41] <bearND>	 dr0ptp4kt: +1 woot for find in page :)
[01:36:36] <dr0ptp4kt>	 heading out...
[01:39:09] <grrrit-wm>	 (03Abandoned) 10BearND: Save images of saved page [apps/android/wikipedia] (savedpages) - 10https://gerrit.wikimedia.org/r/139280 (owner: 10BearND)
[01:39:17] <grrrit-wm>	 (03PS5) 10BearND: Save images of saved page [apps/android/wikipedia] (savedpages) - 10https://gerrit.wikimedia.org/r/139067 
[01:41:19] <bearND>	 YuviPanda: can we easily undo a patch set? just wondering if I should make the change (to send all img url replacements over the JS bridge at once) as part of the same patch because I'm not sure if you like that
[01:41:29] <bearND>	 in gerrit
[01:41:33] <YuviPanda>	 bearND: yeah, undoing patchsets is fairly easy
[01:41:40] <YuviPanda>	 bearND: you just pick up a prior PS and push that again
[01:42:15] <bearND>	 YuviPanda: you mean with the git fetch command fromt he gerrit page?
[01:42:23] <YuviPanda>	 bearND: yeah
[01:42:31] <YuviPanda>	 bearND: git review also has some commands for it, but I don't remember.
[01:42:36] <bearND>	 YuviPanda: cool. pushing the next one
[01:42:44] <YuviPanda>	 bearND: :D
[01:44:52] <grrrit-wm>	 (03PS6) 10BearND: Save images of saved page [apps/android/wikipedia] (savedpages) - 10https://gerrit.wikimedia.org/r/139067 
[01:45:24] <bearND>	 YuviPanda: ^ this change sends all img url replacements over the JS bridge at once
[01:45:38] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Save images of saved page [apps/android/wikipedia] (savedpages) - 10https://gerrit.wikimedia.org/r/139067 (owner: 10BearND)
[01:46:01] <bearND>	 YuviPanda: weird thing is that i have two untracked files in the www folder: abusefilter.js and preview.js
[01:46:34] <YuviPanda>	 bearND: yeah, they should be added to gitignore
[01:46:54] <bearND>	 YuviPanda: ok. any suggestions on https://integration.wikimedia.org/ci/job/apps-android-wikipedia-jslint/48/console?
[01:47:25] <bearND>	 brb
[01:48:34] <grrrit-wm>	 (03CR) 10Yuvipanda: Save images of saved page (031 comment) [apps/android/wikipedia] (savedpages) - 10https://gerrit.wikimedia.org/r/139067 (owner: 10BearND)
[01:48:42] <YuviPanda>	 bearND: commented
[02:01:57] <bearND>	 YuviPanda: thanks
[02:02:04] <grrrit-wm>	 (03PS7) 10BearND: Save images of saved page [apps/android/wikipedia] (savedpages) - 10https://gerrit.wikimedia.org/r/139067 
[02:02:25] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Save images of saved page [apps/android/wikipedia] (savedpages) - 10https://gerrit.wikimedia.org/r/139067 (owner: 10BearND)
[02:04:23] <grrrit-wm>	 (03PS8) 10BearND: Save images of saved page [apps/android/wikipedia] (savedpages) - 10https://gerrit.wikimedia.org/r/139067 
[04:24:51] <grrrit-wm>	 (03CR) 10Florianschmidtwelzow: [C: 031] Make settings submit button mw-ui-constructive [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/139274 (owner: 10Jdlrobson)
[05:22:37] <grrrit-wm>	 (03CR) 10BearND: Save images of saved page (036 comments) [apps/android/wikipedia] (savedpages) - 10https://gerrit.wikimedia.org/r/139067 (owner: 10BearND)
[05:22:52] <grrrit-wm>	 (03CR) 10BearND: Save images of saved page (031 comment) [apps/android/wikipedia] (savedpages) - 10https://gerrit.wikimedia.org/r/139067 (owner: 10BearND)
[06:43:33] <grrrit-wm>	 (03PS5) 10Florianschmidtwelzow: Enable anonymous editing in alpha mode [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/138802 (https://bugzilla.wikimedia.org/59937) 
[06:44:36] <grrrit-wm>	 (03CR) 10Florianschmidtwelzow: Enable anonymous editing in alpha mode (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/138802 (https://bugzilla.wikimedia.org/59937) (owner: 10Florianschmidtwelzow)