[05:24:06] (03PS2) 10BearND: Quick fix for crash saving a page with images and no network [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/139561 [05:58:48] (03PS3) 10BearND: Quick fix for crash saving a page with images and no network [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/139561 (https://bugzilla.wikimedia.org/66601) [07:52:23] (03PS1) 10Florianschmidtwelzow: Add Article Title to PageTitle [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/139790 (https://bugzilla.wikimedia.org/66591) [09:19:43] (03CR) 10Liangent: "Better to add new message "$1 - Languages"?" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/139790 (https://bugzilla.wikimedia.org/66591) (owner: 10Florianschmidtwelzow) [09:21:40] 3MobileFrontend / 3Feature requests: Include "FooBar" in for [[Special:Contributions/FooBar]] - 10https://bugzilla.wikimedia.org/66656 (10Liangent) 3NEW p:3Unprio s:3normal a:3None Like what's done on desktop. [09:21:55] <wikibugs> 3MobileFrontend / 3Feature requests: Include "FooBar" in <title> for [[Special:Contributions/FooBar]] - 10https://bugzilla.wikimedia.org/66656 (10Liangent) [09:21:55] <wikibugs> 3MobileFrontend / 3Feature requests: Include "FooBar" in <title> for [[Special:MobileLanguages/FooBar]] - 10https://bugzilla.wikimedia.org/66591 (10Liangent) [09:25:23] <wikibugs> 3MobileFrontend / 3Feature requests: Include "FooBar" in <title> for [[Special:Contributions/FooBar]] - 10https://bugzilla.wikimedia.org/66656#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/8IA5TCCc [10:12:43] <grrrit-wm> (03CR) 10Florianschmidtwelzow: "Hmm, possible, but i'm unsure, which the best solution is :/ A new message key with almost the same content like languages-heading?" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/139790 (https://bugzilla.wikimedia.org/66591) (owner: 10Florianschmidtwelzow) [11:43:53] <wikibugs> 3MobileFrontend / 3beta: Distance between "read in another language" and Nearby - 10https://bugzilla.wikimedia.org/65907#c5 (10Florian) Is there a new status of this? :) [11:55:37] <twkozlowski> brion: Your client is flooding a little bit with all the quits and joins. [11:57:54] <twkozlowski> brion: Your client is flooding a little bit with all the quits and joins. [13:14:44] <YuviPanda> holyfuckballs, my bouncer had gone berserk [13:19:38] <ragesoss> good day to you as well, YuviPanda! [13:19:47] <YuviPanda> hehe :D [13:19:59] <YuviPanda> ragesoss: just came back from 8h spent in 40C heat trying to get some paperwork sorted [13:20:04] <YuviPanda> and failed, will have to go again tomorrow [13:20:45] <ragesoss> that sounds worse than the illness that laid me low for the last week. [13:21:30] <YuviPanda> ragesoss: I had to do 4h of that on friday, and another potential 8h tomorrow [13:21:48] <YuviPanda> about 60% of which is being bounced around two very b'cratic places 15km apart [13:22:21] <ragesoss> give me a fever, aches, and a big patch of cellulitis over that any day. [13:22:32] <YuviPanda> heh [13:24:24] <YuviPanda> I probably need to go watch something to calm down [13:24:35] <YuviPanda> ragesoss: the running around has also made my CTS flare up, and my right hand hurts up to my elbow now [13:24:36] <YuviPanda> grr [13:24:56] <ragesoss> :( [13:25:30] <ragesoss> YuviPanda: do you happen to know the current ETA for the iOS app general release? [13:25:38] <YuviPanda> ragesoss: oh yeah, was sent to mobile-l a while ago [13:25:46] <YuviPanda> ragesoss: 3 weeks from now, I believe [13:25:50] <ragesoss> cool. [13:26:03] <YuviPanda> ragesoss: Deskana|Away would know more :) [13:27:49] <ragesoss> not sure how I never got around to subscribing to mobile-l until just now. [13:28:40] <YuviPanda> ragesoss: boo! :P [13:28:59] <YuviPanda> ragesoss: there's more conversations there, btw that might interest you (talk pages, for example) [13:29:03] <YuviPanda> ragesoss: do see the arhcives [13:30:04] <YuviPanda> ok, I'm going to take a nap [13:30:05] <YuviPanda> brb [13:30:08] <ragesoss> :) [14:58:22] <grrrit-wm> (03PS2) 10Dbrant: Changes to edit workflow: [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/139692 [15:14:55] <grrrit-wm> (03PS1) 10Florianschmidtwelzow: Add page title to Special:Contributions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/139844 (https://bugzilla.wikimedia.org/66656) [15:26:45] <grrrit-wm> (03PS2) 10Florianschmidtwelzow: Add Article Title to PageTitle [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/139790 (https://bugzilla.wikimedia.org/66591) [15:28:08] <grrrit-wm> (03CR) 10Florianschmidtwelzow: "After thinking about, i think, it's much better to use a seperate language key. Maybe in other languages it's better to write the page tit" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/139790 (https://bugzilla.wikimedia.org/66591) (owner: 10Florianschmidtwelzow) [16:22:33] <grrrit-wm> (03PS1) 10Dbrant: Fix possible crash when logging out, with "don't keep activities" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/139859 [16:31:18] <grrrit-wm> (03CR) 10JGonera: [C: 032] Make settings submit button mw-ui-constructive [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/139274 (owner: 10Jdlrobson) [16:32:00] <grrrit-wm> (03Merged) 10jenkins-bot: Make settings submit button mw-ui-constructive [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/139274 (owner: 10Jdlrobson) [16:36:17] <grrrit-wm> (03CR) 10BearND: "YuviPanda: I cannot repro the Uncaught TypeError. What are the steps?" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/139561 (https://bugzilla.wikimedia.org/66601) (owner: 10BearND) [16:36:50] <bearND> YuviPanda|brb: ^ [16:37:52] <grrrit-wm> (03CR) 10JGonera: [C: 032] Simplify toggling / dynamic page loading code [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/136489 (owner: 10Jdlrobson) [16:38:27] <grrrit-wm> (03Merged) 10jenkins-bot: Simplify toggling / dynamic page loading code [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/136489 (owner: 10Jdlrobson) [16:41:39] <grrrit-wm> (03CR) 10JGonera: [C: 04-1] Ensure edit protection is declared when only move permissions exist on page (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/137735 (https://bugzilla.wikimedia.org/65631) (owner: 10Jdlrobson) [16:52:05] <grrrit-wm> (03CR) 10JGonera: [C: 04-1] "One small comment, but in general it looks fine. Thanks!" (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/139568 (https://bugzilla.wikimedia.org/64707) (owner: 10Florianschmidtwelzow) [16:53:04] * YuviPanda waves groggily at bearND, dbrant and Deskana|Away [16:53:35] <bearND> Hello YuviPanda [16:53:41] <YuviPanda> heya! [16:53:47] <grrrit-wm> (03CR) 10Florianschmidtwelzow: Hygiene: Manage z-index with less variables (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/139568 (https://bugzilla.wikimedia.org/64707) (owner: 10Florianschmidtwelzow) [16:53:56] <YuviPanda> bearND: steps to repro were to go offline and try to save a page [16:54:09] <bearND> YuviPanda: ah [16:56:11] <bearND> YuviPanda: Looking at parallelizing the img download. Problem is that ideally I'd like to only include the img file to the URL mapping file if it successfully downloaded. That makes the whole parallel downloading business trickier, though. [16:56:58] <YuviPanda> bearND: indeed, but I think you can use a countdownlatch with some creative effect there [16:57:12] <YuviPanda> bearND: did you check the way it was being done before? that should handle this usecase too [16:57:27] <bearND> YuviPanda: good idea. I remember seeing something like this in your old code [16:57:36] <YuviPanda> bearND: yeah [16:57:56] <dbrant> YuviPanda: dumb question: why don't we actually use WikiFont for our icons, just like the iOS app does? [17:01:22] <YuviPanda> dbrant: mostly because 1. It is unmanipulatable without external tools, 2. Gives no additional benefit over SVGs in apps (unlike web browsers, where it reduces number of requests), 3. Putting it in places like the actionbar, etc sounds like a bit of extra work, 4. I don't trust Android's font rendering enough, across android veresions, to give us any accuracy/consistency [17:01:35] <YuviPanda> s/external tools/not-common external tools/ [17:01:54] <dbrant> I see [17:04:05] <brion> i wonder if we could rig something up to rasterize the wikifont images directly to PNGs … [17:04:11] <brion> and not have to maintain separate svg files :D [17:04:26] <dbrant> ^ [17:05:23] <YuviPanda> dbrant: brion how easy / hard to do that is will probably be influenced by (1) above :) [17:05:30] <brion> heh yeah :D [17:06:07] <dbrant> YuviPanda: bearND: do we know what the deal is with all these Mainland China users? [17:06:24] <YuviPanda> dbrant: yeah, I think so. SSL versions of wiki are blocked there [17:06:27] <YuviPanda> dbrant: and we force ssl [17:06:32] <YuviPanda> dbrant: I believe the desktop / mobile website don't [17:06:35] <dbrant> ah! [17:06:49] <YuviPanda> dbrant: we have GeoIP for that there [17:06:55] <bearND> YuviPanda: so the old app did force SSL? [17:07:00] <bearND> didn't [17:07:02] <YuviPanda> bearND: it did [17:07:08] <YuviPanda> I don't see how it worked for them [17:07:17] <YuviPanda> unless they had a *really* old app and never updated [17:07:55] <bearND> YuviPanda: could it be another encoding issue like we have with the &? I wonder how this works for liangent [17:08:09] <YuviPanda> bearND: ah, of course. liangent would know best [17:08:49] <dbrant> YuviPanda: one other thing: how do I go about testing the captcha in the edit workflow? (i.e. force a captcha to be shown) [17:09:06] <YuviPanda> dbrant: 1. switch to testwiki, 2. insert an external link and try to save [17:09:16] <dbrant> YuviPanda: cool, thx [17:16:42] <bearND> YuviPanda: Turned on airplane mode. Saved a new page but still cannot repro the JS error you mentioned. Can you try again with the latest PS of https://gerrit.wikimedia.org/r/#/c/139561/? [17:16:57] <YuviPanda> bearND: hmm, sure [17:19:46] <kaldari> moizsyed: Hey Moiz, just want to ping you about the assets for the tablet redirect banner, since we want to put that us ASAP. [17:19:54] <kaldari> us=up [17:20:02] <YuviPanda> bearND: going to try out the new PS now [17:20:10] <kaldari> it's ready to go otherwise [17:21:18] <YuviPanda> dbrant: you what on the weekend? [17:21:40] <dbrant> YuviPanda: got engaged! [17:21:51] <YuviPanda> dbrant: woo! congrats :) [17:22:00] <liangent> bearND: where? [17:22:12] <dbrant> YuviPanda: thanks!! [17:23:00] <YuviPanda> liangent: OTRS, a bunch of people complaining about how they can't use the app from mainland china [17:24:54] <YuviPanda> liangent: do you know what the ssl situation is? [17:25:29] <liangent> they blocks websites randomly [17:25:38] <YuviPanda> liangent: for wiki? [17:26:27] <liangent> YuviPanda: for wiki? [17:26:41] <YuviPanda> liangent: as in, are ssl versions of wikipedia blocked? [17:28:57] <liangent> YuviPanda: no? [17:29:01] <YuviPanda> liangent: hmm, ok [17:29:18] <liangent> YuviPanda: some ips are blocked [17:30:09] <YuviPanda> liangent: hmm [17:30:22] <YuviPanda> liangent: do you have an OTRS account? [17:30:34] <liangent> YuviPanda: no [17:30:59] <liangent> YuviPanda: you want this? [17:31:00] <liangent> https://en.greatfire.org/test?url=https%3A//zh.wikipedia.org/ [17:31:03] <liangent> https://en.greatfire.org/test?url=https%3A//zh.m.wikipedia.org/ [17:31:19] <YuviPanda> liangent: ah, that's useful [17:32:26] <YuviPanda> dbrant: bearND testing with ^ seems to imply no blocking... [17:32:55] <liangent> YuviPanda: and this? https://en.greatfire.org/test?url=https%3A//zh.wikisource.org/ https://en.greatfire.org/test?url=http%3A//zh.wikisource.org/ if you're interested [17:32:58] <bearND> YuviPanda: liangent: dbrant: some for the mobile site though [17:33:09] <bearND> 70% [17:33:26] <YuviPanda> ah, hmm [17:33:37] <YuviPanda> https://en.greatfire.org/search/all/https%3A//en.m.wikipedia.org 64% [17:33:43] <YuviPanda> that would explain things, yeah [17:33:46] <YuviPanda> that's very weird [17:33:57] <YuviPanda> they aren't blocking the desktop site, but are blocking the mobile site? [17:34:04] <tfinc> Maryana: sadly the Comcast guy came here right at the end of his appointment window so i missed the web standup. Did you guys get to discuss the tablet redirect ? [17:34:27] <Maryana> tfinc: yep, we talked about it at the start of standup. the team was unanimously in favor of releasing at 100% [17:34:36] <Maryana> writing up the notes now to send out to everybody [17:34:41] <liangent> YuviPanda: so I was saying they're blocking stuff "randomly" :/ [17:34:41] <tfinc> thank you [17:34:51] <YuviPanda> dbrant: bearND liangent https://en.greatfire.org/https/en.m.wikipedia.org/w/api.php [17:35:01] <YuviPanda> dbrant: bearND liangent 100% of requests to api.php blocked :| [17:35:06] <dbrant> haaa... [17:35:08] <bearND> YuviPanda: wow 100% api [17:35:30] <YuviPanda> let me test desktop... [17:35:38] <liangent> YuviPanda: it doesn't make a difference between index.php and api.php to ids when you're on https [17:36:22] <YuviPanda> liangent: hmm, right. but in general it only said '64% blocked' for that, while for api.php it said 100%... [17:36:30] <YuviPanda> dbrant: bearND liangent https://en.greatfire.org/en.wikipedia.org/w/api.php [17:37:06] <YuviPanda> dbrant: bearND we could add an 'isChina()' function and have it go http. that's kinda what we do for desktop and mobile [17:38:38] <grrrit-wm> (03CR) 10Dr0ptp4kt: [C: 032] Minor code cleanup - removed cached validator vars [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/139659 (owner: 10Yurik) [17:38:48] <grrrit-wm> (03Merged) 10jenkins-bot: Minor code cleanup - removed cached validator vars [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/139659 (owner: 10Yurik) [17:39:02] <jgonera> jdlrobson, did you update config on labs for sellello? [17:39:04] <YuviPanda> dr0ptp4kt: see discussion above. I am going to guess we have no WP Zero in China? :) [17:39:13] <reeeve> hey everyone, are jquery ui elements eliminated as potential dependencies in ResourceLoader for mobile? (Error: Unknown dependency: jquery.ui.accordion) [17:39:13] <jdlrobson> jgonera: yes [17:39:19] <jgonera> thanks [17:39:21] <jdlrobson> reeeve: yep [17:39:39] <jdlrobson> we are trying to deprecate jquery ui everywhere last i heard [17:39:44] <reeeve> ahhhhh [17:39:45] <jdlrobson> in favour of a mediawiki ui library [17:39:53] <jdlrobson> so that we can have a standardised interface [17:39:57] <jdlrobson> but that will take time [17:40:42] <liangent> YuviPanda: because for index.php it says "Tests: 11 times (in the last 90 days)" and api.php "Tests: 1 times (in the last 90 days)" [17:40:52] <YuviPanda> liangent: aah, right [17:40:52] <dr0ptp4kt> YuviPanda, bearND there's no w0 in china at the moment. [17:40:57] <liangent> (obviously?) 64% means 64% of these tests failed [17:41:07] <YuviPanda> dr0ptp4kt: hmm, ok [17:41:13] <reeeve> ok, got it. will try to separate out all of the jquery ui calls to a different js module! thank you. [17:42:20] <liangent> YuviPanda: I don't like isChina() and don't want my data go over http [17:42:34] <dr0ptp4kt> YuviPanda: i think it would be prudent to move the discussion of how to modify traffic patterns to an email with the veep [17:42:48] <jgonera> MaxSem, so how https://trello.com/c/JKM73Wdn/17-bug-64638-mobileview-should-return-noeditsection-status returns _NOEDITSECTION_ now? or did you decide on a different solution? [17:42:50] <YuviPanda> dr0ptp4kt: liangent hmm, right. [17:43:06] <YuviPanda> dr0ptp4kt: this is mostly because https://en.greatfire.org/en.wikipedia.org/w/api.php and https://en.greatfire.org/en.m.wikipedia.org/w/api.php [17:43:31] <MaxSem> jgonera, as part of page properties [17:43:34] <YuviPanda> dr0ptp4kt: liangent oh wait. I think, what I was trying to say was, do isChina and route requests to the API of the *non* mobile site, since that doesn't seem to be blocked [17:43:56] <grrrit-wm> (03PS2) 10Brion VIBBER: Core data snippets. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/138477 (owner: 10Mhurd) [17:44:01] <liangent> YuviPanda: that's some mouse&cat game... [17:44:01] <brion> rebase whee [17:44:18] <liangent> what if they turn to block desktop but not mobile one day? [17:44:24] <YuviPanda> heh, true [17:44:33] <YuviPanda> I wonder what our options are [17:45:16] <liangent> YuviPanda: see also https://bugzilla.wikimedia.org/show_bug.cgi?id=53739 https://bugzilla.wikimedia.org/show_bug.cgi?id=64207 [17:45:44] <YuviPanda> liangent: I'm worried since the old app would've worked, since it didn't hit m. domains [17:45:56] <liangent> YuviPanda: I don't know [17:46:12] <YuviPanda> liangent: that's also what people are saying in OTRS [17:46:18] * YuviPanda invokes Deskana|Away [17:47:01] <ragesoss> is there already a bug about long math equations breaking the width of articles on Android? [17:47:14] <YuviPanda> ragesoss: nope. check on mobilefrontend too and then file? [17:47:25] <ragesoss> (and also, about long math equations getting truncated on iOS) [17:48:09] <ragesoss> okay. so if there's already an MFE bug, that means I should not file it against Android since the fix will need to come from MFE? [17:48:21] <YuviPanda> ragesoss: yeah, but cc me if you file it against MFE? [17:48:47] <ragesoss> okay. [17:49:35] <moizsyed> @kaldari [17:49:40] <moizsyed> you in office? [17:50:28] <kaldari> moizsyed: No, I'm sick [17:50:31] <liangent> YuviPanda: btw there's a saying on https://en.wikivoyage.org/wiki/China#Connect and I can't confirm it: "More common than outright blocking is throttling, such that users become frustrated with the speed of the web service and turn to a competitor that is more cooperative with the government. Google services in particular are frequently throttled." [17:50:33] <moizsyed> oh crap [17:50:43] <kaldari> moizsyed: got the boat flu I guess [17:50:56] <YuviPanda> liangent: right [17:51:01] <moizsyed> kaldari: damn [17:51:10] <moizsyed> kaldari: will send you the asset soon [17:51:16] <kaldari> thnaks! [17:51:18] <moizsyed> kaldari: im working on it next [17:54:26] <wikibugs> 3MobileFrontend / 3beta: Breaking VisualEditor breaks wikitext editor - 10https://bugzilla.wikimedia.org/66678 (10Jon) 3NEW p:3Unprio s:3normal a:3None If VisualEditor ever throws an exception, which seems to be happening a lot, this means that the editor is inaccessible unless you resize the window... [17:55:21] <moizsyed> kaldari: can we change the 'x' image on that banner [17:55:36] <moizsyed> kaldari: i can give you a much cleaner 'x' image and maybe you can update it for all banners [17:55:37] <wikibugs> 3MobileFrontend / 3beta: Breaking VisualEditor breaks wikitext editor - 10https://bugzilla.wikimedia.org/66678#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/iIcumWus [17:56:18] <grrrit-wm> (03PS2) 10Jdlrobson: Emit events after delay to support chaining [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/137734 (https://bugzilla.wikimedia.org/65633) [17:57:04] <grrrit-wm> (03Abandoned) 10Jdlrobson: Add frontend caching layer to nearby API calls [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/130383 (owner: 10Jdlrobson) [17:57:06] <grrrit-wm> (03CR) 10jenkins-bot: [V: 04-1] Emit events after delay to support chaining [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/137734 (https://bugzilla.wikimedia.org/65633) (owner: 10Jdlrobson) [17:57:26] <grrrit-wm> (03PS3) 10Dbrant: Changes to edit workflow: [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/139692 [17:57:49] <grrrit-wm> (03Abandoned) 10Jdlrobson: WIP: Use Mantle version of Class and eventemitter [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129336 (owner: 10Jdlrobson) [17:57:56] <grrrit-wm> (03Abandoned) 10Jdlrobson: WIP: Use the View in Mantle extension [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129337 (owner: 10Jdlrobson) [17:58:40] <jdlrobson> jgonera: could you please write up about what was agreed in your opera mobile meeting in relation to - "This is not exactly what we agreed upon during the meeting with the Opera Software person. Let's hold off on that until Maryana, Moiz and I create some stories since we were present there." [17:58:41] <grrrit-wm> (03CR) 10Dr0ptp4kt: [C: 032] Code cleanup [extensions/JsonConfig] - 10https://gerrit.wikimedia.org/r/139660 (owner: 10Yurik) [17:58:47] <grrrit-wm> (03Merged) 10jenkins-bot: Code cleanup [extensions/JsonConfig] - 10https://gerrit.wikimedia.org/r/139660 (owner: 10Yurik) [17:59:10] <jdlrobson> it's good to keep a record of these things, especially for the benefit of people like me who are interested and are missing half the conversation :) [18:00:00] <grrrit-wm> (03Abandoned) 10Jdlrobson: Optimise mobile site for 240x180 resolution [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/138867 (owner: 10Jdlrobson) [18:04:08] <grrrit-wm> (03CR) 10Dr0ptp4kt: [C: 032] Removed unneded class variable, minor cleanup [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/139661 (owner: 10Yurik) [18:04:25] <wikibugs> 3MobileFrontend / 3stable: Long math formulas break article layout - 10https://bugzilla.wikimedia.org/66679 (10Sage Ross) 3NEW p:3Unprio s:3normal a:3None Long formulas break the layout of articles and result in horizontal scrolling. For example, in [[Labelled enumeration theorem]], one of the equati... [18:04:45] <grrrit-wm> (03Merged) 10jenkins-bot: Removed unneded class variable, minor cleanup [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/139661 (owner: 10Yurik) [18:05:22] <wikibugs> 3MobileFrontend / 3stable: Long math formulas break article layout - 10https://bugzilla.wikimedia.org/66679#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/ytpXSO74 [18:06:34] <grrrit-wm> (03Abandoned) 10Jdlrobson: Hygiene: Cleanup main menu css border/background [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/132346 (owner: 10Jdlrobson) [18:09:01] <YuviPanda> bearND: am going to eat something, should be back in30m and look at the saved pages patch [18:09:18] <jgonera> jdlrobson, yes, I saw your comment, I'll write an email [18:09:19] <bearND> YuviPanda: ok, ty [18:10:21] <jdlrobson> thanks jgonera poked you on mail as well with maryana and moiz as i wasn't sure if you were watching irc :) [18:14:34] <grrrit-wm> (03PS4) 10Jdlrobson: Ensure edit protection is declared when only move permissions exist on page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/137735 (https://bugzilla.wikimedia.org/65631) [18:14:40] <wikibugs> 3Wikipedia App / 3iOS App: Long math formulas are cut off - 10https://bugzilla.wikimedia.org/66680 (10Sage Ross) 3NEW p:3Unprio s:3normal a:3None Long math formulas, such as in [[Labelled enumeration theorem]], get cut off if they extend beyond the width of the screen. See also bug 66679, which aff... [18:14:50] <reeeve> any good examples of an extension that integrates with MobileFrontend and uses all of the correct coding conventions? Should I be looking at using OOjs UI? Just trying to figure out what the "best" way to replace jQuery UI elements (dialogs, etc) would be [18:15:14] <kaity> hey jgonera [18:15:38] <jgonera> hi kaity [18:16:42] <grrrit-wm> (03PS3) 10Jdlrobson: Hygiene: Start using models for history and contributions page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/133680 [18:17:16] <kaity> jgonera: I'm updating this card [18:17:17] <kaity> https://trello.com/c/UBMwExIi/94-8-ve-context-for-links-and-references [18:17:30] <kaity> you said you're already working on it? [18:18:36] <grrrit-wm> (03CR) 10Jdlrobson: [C: 032] Use UTC time when generate Filename [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/139446 (https://bugzilla.wikimedia.org/66169) (owner: 10Florianschmidtwelzow) [18:19:04] <jgonera> kaity, yes, on the references part [18:19:11] <grrrit-wm> (03Merged) 10jenkins-bot: Use UTC time when generate Filename [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/139446 (https://bugzilla.wikimedia.org/66169) (owner: 10Florianschmidtwelzow) [18:19:41] <jgonera> kaity, if there is no reference text yet in the second toolbar, should the whole toolbar be tappable or should I make "Cite Web" (or other) a button? [18:21:16] <grrrit-wm> (03CR) 10Jdlrobson: Hygiene: Manage z-index with less variables (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/139568 (https://bugzilla.wikimedia.org/64707) (owner: 10Florianschmidtwelzow) [18:21:24] <kaity> jgonera: Trevor should have it done soon, but sure in the meantime the whole toolbar can be tappable [18:21:32] <jgonera> ok [18:21:45] <kaity> It can behave the same way when we show the whole reference too [18:22:11] <kaity> did you see that I added acceptance criteria [18:22:45] <kaity> jgonera: when you tap a reference/link, can we highlight the word or [1] ? [18:23:52] <jgonera> kaity, that's what happens for [1] currently [18:24:11] <jgonera> as for links, I'm not sure about this behavior, what if someone just wants to correct a typo in a link? [18:24:21] <kaity> cool [18:26:02] <kaity> I was thinking about that, I think the most common activity is editing the link [18:26:55] <grrrit-wm> (03CR) 10Jdlrobson: [C: 032] Add "wgMFShowRedLinks" and "wgMFShowRedLinksAnon" config [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/135120 (https://bugzilla.wikimedia.org/65640) (owner: 10Florianschmidtwelzow) [18:27:03] <kaity> if they tap again the selection goes away, then they can edit the typo [18:27:32] <grrrit-wm> (03Merged) 10jenkins-bot: Add "wgMFShowRedLinks" and "wgMFShowRedLinksAnon" config [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/135120 (https://bugzilla.wikimedia.org/65640) (owner: 10Florianschmidtwelzow) [18:28:09] <James_F> reeeve: If you want to use OOUI to do that, we'd be happy to help; note that "Agora" (MobileFrontend-like) styling is not complete for OOUI widgets yet, so you may have to do a little fiddling depending on what you use. [18:28:14] <kaity> I think the bigger issue is that when a person taps a link and the toolbar comes down, there's no visual indication of where the link word is [18:29:25] <FlorianSW|away> thx for merge jdlrobson :) [18:29:59] <jdlrobson> MaxSem: can you take a look at https://gerrit.wikimedia.org/r/139844 and https://gerrit.wikimedia.org/r/139790 ? [18:30:45] <kaity> jgonera: Is it possible to do? - Highlighting the link in the article text [18:31:24] <jgonera> kaity, I bet it's possible, but it's something we'll have to discuss with the VE team [18:31:43] <kaity> jgonera: Ok cool [18:32:08] <grrrit-wm> (03CR) 10MaxSem: [C: 04-1] Add page title to Special:Contributions (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/139844 (https://bugzilla.wikimedia.org/66656) (owner: 10Florianschmidtwelzow) [18:32:17] <reeeve> James_F: thanks! is OOUI the way to go? Should I be looking at something else for dialog forms? Just trying to figure out what the most supported way will be going forward [18:32:25] <kaity> jgonera: I think it makes sense for mobile, but not for desktop. (On desktop the tooltip is right there so the location isnt an issue) [18:33:12] <jgonera> kaity, I see, we'll have to think how to make this behavior different then [18:33:24] <grrrit-wm> (03CR) 10Jdlrobson: [C: 04-1] "Hey Florian - still more error warnings I'm afraid. Have you got $wgDevelopmentWarnings = true; enabled?" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/138229 (https://bugzilla.wikimedia.org/56834) (owner: 10Florianschmidtwelzow) [18:34:21] <grrrit-wm> (03Abandoned) 10Jdlrobson: WIP Experiment: Ajax login form on HTTPS [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129480 (owner: 10Jdlrobson) [18:34:40] <grrrit-wm> (03CR) 10MaxSem: [C: 04-1] Add Article Title to PageTitle (033 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/139790 (https://bugzilla.wikimedia.org/66591) (owner: 10Florianschmidtwelzow) [18:35:28] <MaxSem> jgonera, https://gerrit.wikimedia.org/r/#/c/139562/ needs manual backpoting to prod branches [18:35:59] <jgonera> MaxSem, I'll do that in a moment. what are the current prod branches? [18:36:14] <MaxSem> 8 and 9 [18:36:16] <Maryana> jgonera: are you in the office? [18:36:24] <jgonera> Maryana, not yet, why? [18:36:39] <Maryana> ok - just wanted you to check in with oliver about pv data at some point before he leaves [18:36:44] <Maryana> so today/tomorrow :) [18:36:50] <jgonera> ok [18:39:22] <grrrit-wm> (03PS3) 10Brion VIBBER: Initial 'garbage collection' of unused cached images when cleaning history [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/138477 (owner: 10Mhurd) [18:41:19] <grrrit-wm> (03PS9) 10Florianschmidtwelzow: Enable View of "new messages on talk page" without Echo [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/138229 (https://bugzilla.wikimedia.org/56834) [18:44:12] <grrrit-wm> (03PS2) 10Florianschmidtwelzow: Add page title to Special:Contributions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/139844 (https://bugzilla.wikimedia.org/66656) [18:46:32] <jgonera> MaxSem, how soon do you need this backported? [18:46:41] <MaxSem> before the SWAT [18:46:58] <MaxSem> preferrably at least an hour before [18:47:07] <jgonera> MaxSem, what time is that? 3pm? [18:47:12] <MaxSem> 4 [18:47:15] <jgonera> ok [18:47:16] <grrrit-wm> (03PS13) 10Jdlrobson: Create helper script for checking css rule duplication [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129032 (https://bugzilla.wikimedia.org/64217) [18:47:54] <grrrit-wm> (03CR) 10jenkins-bot: [V: 04-1] Create helper script for checking css rule duplication [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129032 (https://bugzilla.wikimedia.org/64217) (owner: 10Jdlrobson) [18:49:05] <grrrit-wm> (03PS3) 10Florianschmidtwelzow: Add Article Title to PageTitle [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/139790 (https://bugzilla.wikimedia.org/66591) [18:50:23] <grrrit-wm> (03PS1) 10Brion VIBBER: Workaround for breakage on 'Great Eastern Highway' featured article with video thumb [apps/win8/wikipedia] - 10https://gerrit.wikimedia.org/r/139884 [18:50:56] <grrrit-wm> (03CR) 10Brion VIBBER: [C: 032 V: 032] "another quick hack, need to either rework this thing or kill it :(" [apps/win8/wikipedia] - 10https://gerrit.wikimedia.org/r/139884 (owner: 10Brion VIBBER) [18:52:59] <grrrit-wm> (03CR) 10Jdlrobson: [C: 04-1] Enable View of "new messages on talk page" without Echo (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/138229 (https://bugzilla.wikimedia.org/56834) (owner: 10Florianschmidtwelzow) [18:53:17] <YuviPanda> brion: kill it [18:53:28] <brion> i suspect we will soon yes [18:53:49] <grrrit-wm> (03CR) 10Liangent: Add Article Title to PageTitle (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/139790 (https://bugzilla.wikimedia.org/66591) (owner: 10Florianschmidtwelzow) [18:54:03] <vbamba> @YuviPanda qq for you [18:54:20] <YuviPanda> vbamba: sure [18:54:25] <vbamba> is there a background color in the article on android [18:54:40] <vbamba> looks like a very dull grey [18:54:51] <YuviPanda> vbamba: am using the exact same styles as MobileFrontend, so should be the same as it is on MobileFrontend [18:54:54] <brion> YuviPanda: oh — there’s a cute win8 app some bing folks put together that’s a wikipedia reader app, and also a demo of some of their knowledge graph search [18:54:58] <James_F> reeeve: I'd say so, but I'm slightly biased because my team is the one making OOUI. :-) In general we're re-working dialogs right now (https://gerrit.wikimedia.org/r/#/c/139550/ for the Work In Progress change) but it should be a good route to go down. [18:55:00] <brion> so i won’t feel bad about pulling ours :) [18:55:10] <YuviPanda> brion: :) if only it were open source... [18:55:52] <James_F> reeeve: However, different teams more or less have autonomy about the architectural direction of their areas, so… [18:56:00] <YuviPanda> vbamba: want me to verify? [18:56:31] <grrrit-wm> (03CR) 10Florianschmidtwelzow: Enable View of "new messages on talk page" without Echo (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/138229 (https://bugzilla.wikimedia.org/56834) (owner: 10Florianschmidtwelzow) [18:56:38] <vbamba> YuviPanda: no its good, i turned the brightness up [18:56:45] <YuviPanda> vbamba: :) ok! [18:56:48] <vbamba> when the brightness is done, it looks kinda grey. [18:56:59] <vbamba> no simple fix there [18:57:05] <vbamba> down* [18:57:14] <YuviPanda> vbamba: :) yeah [18:57:47] <grrrit-wm> (03PS1) 10MaxSem: Move redlink logic to PHP [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/139885 [18:57:53] <reeeve> James_F: haha ok, well then! Any good examples I could work from? I have a lot of dialog/ajax forms using jquery ui dialog. Will be refactoring them to use OO UI to integrate with mobile. [19:04:22] <jdlrobson> kaldari: are you still working on https://gerrit.wikimedia.org/r/#/c/125747/ [19:04:46] <kaldari> jdlrobson: one of these days, yes :) [19:04:55] <kaldari> sorry it's been sitting there for a while [19:05:17] <kaldari> it needs to be refactored per Maryana's suggestions [19:05:56] <grrrit-wm> (03PS1) 10Dbrant: Stop playback of media files when leaving page. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/139887 (https://bugzilla.wikimedia.org/66475) [19:08:41] <grrrit-wm> (03CR) 10Florianschmidtwelzow: [C: 031] Move redlink logic to PHP [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/139885 (owner: 10MaxSem) [19:10:36] <James_F> reeeve: VisualEditor is the canonical user of OOUI; see the VisualEditor/VisualEditor.git repo and the mediawiki/extensions/VisualEditor.git repo, though the demo (see demos/ directory in oojs/ui.git) is probably the best place to start. [19:11:28] <YuviPanda> dbrant: bearND Deskana https://ticket.wikimedia.org/otrs/index.pl?Action=AgentZoom&TicketID=7609290 FEELS SOO GOOD! :) [19:11:57] <dbrant> YuviPanda: yeah!! just read that myself [19:12:51] <YuviPanda> dbrant: I guess the unlabeled icons they mention are the ToC and more on top [19:14:06] <dbrant> YuviPanda: I wonder how we can add a 'title' to those buttons, so that it works with Talkback? [19:14:30] <YuviPanda> dbrant: I think we should wrap them in a 'button' [19:16:40] <reeeve> James_F: Will do, thanks! [19:17:02] <liangent> dbrant: nice to hear Talkback here :) [19:19:01] <reeeve> James_F: last Q-- is OOjs and OOjs UI in core 1.23.0? [19:19:45] <James_F> reeeve: Yes and yes, though (many) breaking changes should be expected for the version of OOUI bundled with MW 1.24. [19:19:55] <grrrit-wm> (03PS1) 10Brion VIBBER: Bump internal app version to 1.1.0.36 [apps/win8/wikipedia] - 10https://gerrit.wikimedia.org/r/139892 [19:20:24] <grrrit-wm> (03CR) 10Brion VIBBER: [C: 032 V: 032] "uploading this package to store to work around bug in featured article extraction" [apps/win8/wikipedia] - 10https://gerrit.wikimedia.org/r/139892 (owner: 10Brion VIBBER) [19:22:16] <reeeve> James_F: so if i stick to oojs/ui.git demos I should be pretty safe? [19:23:56] <grrrit-wm> (03PS2) 10Jdlrobson: Move redlink logic to PHP [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/139885 (https://bugzilla.wikimedia.org/66534) (owner: 10MaxSem) [19:24:08] <grrrit-wm> (03CR) 10Jdlrobson: [C: 032] Move redlink logic to PHP [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/139885 (https://bugzilla.wikimedia.org/66534) (owner: 10MaxSem) [19:24:37] <wikibugs> 3MobileFrontend / 3stable: Disabling of red links should be configurable - 10https://bugzilla.wikimedia.org/66534 (10Jon) 5PATC>3RESO/FIX [19:24:48] <grrrit-wm> (03Merged) 10jenkins-bot: Move redlink logic to PHP [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/139885 (https://bugzilla.wikimedia.org/66534) (owner: 10MaxSem) [19:25:28] <grrrit-wm> (03Abandoned) 10Jdlrobson: Remember user choice (mobile/desktop) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/117699 (https://bugzilla.wikimedia.org/54885) (owner: 10Kelson) [19:40:06] <James_F> reeeve: Yes. [19:40:22] <wikibugs> 3MobileFrontend / 3General/Unknown: Long math formulas break article layout on mobile devices / small screens - 10https://bugzilla.wikimedia.org/66679#c6 (10Ryan Kaldari) The bug isn't really in the Math extension either. The bug is that any HTML block element in an article can contain an arbitrarily wide el... [19:41:12] <Maryana> kaldari: blahhh, sorry, writing long-ass emails has interfered with my ability to do real work today [19:41:32] <dbrant> dr0ptp4kt: hey, is it cool if I build upon your 'find in page' patch? Or are you still working on it? [19:41:46] <Maryana> kaldari: moiz is gonna run some designs by me and then i'll hand them off to you [19:41:58] <kaldari> Maryana: rapid [19:42:00] <dr0ptp4kt> dbrant: please do! [19:42:10] <Maryana> kaldari: one question: can we synchronize centralnotice and the blog post? [19:42:26] <Maryana> to make sure we're actually sending folks somewhere :) [19:42:27] <kaldari> Maryana: That's WMF fundraiser slang for "awesome" [19:42:33] <Maryana> oh, haha [19:42:39] <Maryana> i thought maybe it was spanish for awesome [19:43:33] <kaldari> Maryana: Not sure what you mean by synchonizing them. I can put the banner up at any arbitrary time. It doesn't require any sort of deployemnt. [19:43:52] <Maryana> that's more or less what i was getting at :) [19:44:44] <Maryana> one potential issue is that the new tou changes are getting announced via banner [19:45:22] <Maryana> but i don't think that's a huge deal - we can set them to swap out, right? [19:45:32] <Maryana> don't want 2 banners piling up on a small mobile screen.. [19:45:35] <Maryana> kaldari: ^^ [19:48:34] <kaldari> Maryana: It will only show one banner at a time. I can either set the tablet banner to override the TOU banner, or I can make them randomly alternate. [19:48:54] <Maryana> randomly alternating is fine [19:49:06] <Maryana> legal will shank us if we override the tou banner, probably :) [19:49:20] <Maryana> thanks, d00d - sorry this is all so last-minute [19:50:03] <Maryana> i've got guillaume reviewing the blog post, so it should be good to go by tomorrow morning [19:50:42] <YuviPanda> Maryana: has a decision been made on how the tablet release is going to roll out? (ok if you're writing a long email about it, I can wait :) ) [19:50:59] <dr0ptp4kt> dbrant: to answer the latter question, i was considering some additional changes: use a normal fragment without an alertdialog. inline the buttons, and get easier onTouchupOutside type functionality to clear the highlighted stuff in the webview in addition to the x, but without kludginess (currently, the x is required because onTouchupOutside would be sort of kludgy with an alertidialog). i do think it's important to have the find box [19:51:00] <dr0ptp4kt> /below/ the search box instead of repurposing the search box, as that's the convention on android, but anyhow, that's another topic....take all of that with a grain of salt, of course! [19:51:26] <Maryana> YuviPanda: i just sent off the long-ass version to howie for review before sending out to everyone in the world and their mom, but the tl;dr is we're gonna push to 100% tomorrow [19:51:34] <YuviPanda> dr0ptp4kt: on chrome it replaces the search bar [19:51:47] <YuviPanda> Maryana: :D cool! [19:52:25] <dr0ptp4kt> YuviPanda: what os and form factor you using? [19:52:37] <dr0ptp4kt> dbrant: ^ [19:53:04] <YuviPanda> dr0ptp4kt: n4 [19:53:17] <YuviPanda> dr0ptp4kt: 4.4, but it's always done that for me [19:53:23] <kaldari> jgonera, Maryana: going to lunch [19:53:25] <dr0ptp4kt> YuviPanda: do you mean the stock browser or chrome? [19:53:29] <YuviPanda> dr0ptp4kt: chrome [19:53:37] <dbrant> dr0ptp4kt: 4.3, Galaxy S3 [19:53:41] <dr0ptp4kt> YuviPanda: lol ok, that's what i get for using a tablet [19:53:52] <YuviPanda> dr0ptp4kt: :D [19:56:44] <jgonera> Kaldari, meeting in 5min? [19:57:51] <dr0ptp4kt> <grabs stock browser on 4.3 phone> YuviPanda dbrant, in that case i'm not opposed to the pattern in the stock android browser / apparently non-tablet chrome. ux-wise, that pattern where it completely overlays the top bar seems sensible enough (if it doesn't turn into lots and lots of programming time, anyway!) [19:58:14] <YuviPanda> :D \o/ [20:04:46] <Deskana> jgonera: Ping! Retrospective. :) [20:05:05] <Deskana> Un-ping. [20:07:20] <Deskana> http://etherpad.wikimedia.org/p/MobileWeb-Retrospective [20:09:05] <tfinc> Deskana: reviews are holding nicely on Android. no surprises that i can see [20:09:38] <YuviPanda> tfinc: yeah, we haven't had a single under-4 stars review for anything other than dark theme, and most of the 4 star ones were for saved pages. [20:09:55] <YuviPanda> tfinc: I also emailed mobile-l some feedback from a blind user who found the app a massive improvement :D [20:10:04] <violetto> Deskana: can't find link [20:10:10] <tfinc> YuviPanda: will saved pages make it back for the stable release ? [20:10:10] <Deskana> violetto: http://etherpad.wikimedia.org/p/MobileWeb-Retrospective [20:10:17] <violetto> Deskana: sanks [20:10:28] <YuviPanda> tfinc: yeah, they will. should be in alpha today most probably, tomorrow worst case. [20:10:32] <tfinc> :) [20:10:34] <tfinc> perfect [20:10:41] <YuviPanda> tfinc: :) [20:10:47] <Deskana> Yay! [20:11:21] <Deskana> You guys are running out of Android cards so I'm going to move some into the current sprint for you. [20:12:00] <YuviPanda> Deskana: hehe :D I should add a card for the chinese issue, though. That's going to be a bit [20:12:17] <tfinc> this is a good problem to have [20:12:21] <Deskana> :) [20:13:00] <tfinc> and to date no one has asked about maps/geo so no need to prioritize that [20:13:17] <brion> YuviPanda: ok sounds like consensus so far, we’ll kill the windows tablet app off this summer :) [20:13:26] <tfinc> :) [20:13:31] <tfinc> brion: its better that way [20:13:44] <brion> let the app terminate with dignity ;) [20:14:04] <tfinc> but i wanted to make sure you guys had the space to make that decision [20:14:07] <tfinc> yup [20:14:20] <YuviPanda> brion: tfinc we should consider doing that for FFOS as well. the current app there is... [20:14:28] <tfinc> with its head in the microsoft clouds [20:14:39] <tfinc> YuviPanda: thats a call for dr0ptp4kt and the Zero team [20:14:40] <brion> yeah, that also needs a major update-or-kill [20:14:45] <YuviPanda> tfinc: ah, forgot that. [20:14:47] <brion> but yeah that’s on zero’s side for time :D [20:14:48] <YuviPanda> they had taken over [20:14:49] <YuviPanda> that [20:15:04] <tfinc> i trust them to make the right call there for our users in areas where there is high usage [20:15:09] <YuviPanda> brion: can you, in one of your ffos devices, see if it works at least? [20:15:09] <grrrit-wm> (03PS1) 10Yurik: Allow validator chaining, added URL validator [extensions/JsonConfig] - 10https://gerrit.wikimedia.org/r/140013 [20:15:24] <dr0ptp4kt> YuviPanda: one idea i've bandied about on ffos is making the ffos stuff a good search widget only. we'll need to discuss more. [20:15:37] <brion> YuviPanda: it works, but the FFOS people routinely file bugs about little things with it :) [20:15:43] <YuviPanda> brion: ah, cool :) [20:15:49] <brion> dr0ptp4kt: i like that idea [20:16:01] <brion> integrate with the system, but kick you back to a browser window for the browsing [20:16:05] <YuviPanda> dr0ptp4kt: yeah, that sounds about right to me as well, esp. with the demise of Phonegap apps. [20:17:23] <brion> narrowing focus \o/ [20:17:43] * brion narrows focus to lunch [20:17:45] <brion> om nom nom nom [20:21:24] <bearND> YuviPanda: have you been able to look at https://gerrit.wikimedia.org/r/#/c/139561/ again? [20:21:46] <bearND> YuviPanda: i'm ready to push the parallel image download but i want to make it dependent on ^ [20:22:16] <YuviPanda> bearND: ah, looking at it again now. sorry got distracted by the chinese [20:22:46] <moizsyed> kaldari_lunch: [20:22:54] <YuviPanda> bearND: you can make it dependent, we can always re-ammend them with rebase -i :) [20:23:04] <moizsyed> kaldari: i got your assets for banner [20:23:13] <kaldari> rapid [20:23:13] <moizsyed> kaldari: maryana approved them too [20:23:23] <kaldari> bodacious [20:23:25] <bearND> YuviPanda: ok, pushing [20:23:33] <grrrit-wm> (03PS1) 10BearND: Parallel image download for saved pages [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/140014 [20:23:44] <moizsyed> kaldari: are you an adjective spitting bot right now? [20:23:55] <kaldari> apparently [20:24:20] <moizsyed> kaldari: is there a trello card for this task? [20:24:22] <moizsyed> i cant find it [20:24:32] <kaldari> yes... [20:24:41] <moizsyed> kaldari: found it [20:24:45] <Maryana> https://trello.com/c/2r5jHOd1/54-centralnotice-for-tablet-users [20:24:46] <moizsyed> gonna update it soon [20:24:48] <Maryana> moizsyed: ^^ [20:24:51] <moizsyed> thanks Maryana! [20:24:52] <Maryana> ah, you got it [20:25:44] <moizsyed> kaldari: growth uses an 'x' for its guided tours, can we use the same for this banner? [20:26:16] <kaldari> like a straight edge 'x'? [20:26:28] <kaldari> that would be edgey [20:27:50] <moizsyed> kaldari: i added the assets [20:27:55] <moizsyed> kaldari: let me know if you need anything [20:28:13] <kaldari> moizsyed: I'm afriad I'm not sure what you mean about the 'x' [20:28:20] <moizsyed> kaldari: the close 'x' [20:28:40] <moizsyed> kaldari: Guided Tours also have a close 'x' which is better [20:28:44] <moizsyed> kaldari: can we use that asset [20:28:50] <kaldari> moizsyed: I was just going to use the standard close icon. Is that not good? [20:29:38] <moizsyed> kaldari: the standard close is the one we have right now on banner? [20:29:46] <kaldari> yes [20:29:47] <moizsyed> kaldari: coz that one sucks [20:29:51] <YuviPanda> bearND: we should make an alpha release today once these patches are merged [20:29:54] <moizsyed> kaldari: ok yeah, can we replace that [20:30:07] <kaldari> moizsyed: sure, just send me what you'd like then [20:30:18] <bearND> YuviPanda: agreed [20:30:32] <YuviPanda> bearND: kk, testing patch now [20:32:05] <moizsyed> kaldari: you can use the same 'x' asset that this thing is using: https://en.wikipedia.org/wiki/Main_Page?tour=test [20:32:16] <moizsyed> kaldari: dont want to have two image assets for the same thing [20:33:54] <wikibugs> 3Wikipedia App / 3Android App: The same placeholder image is used for thumbnails that haven't loaded and for articles without illustrations - 10https://bugzilla.wikimedia.org/66685 (10Sage Ross) 3NEW p:3Unprio s:3normal a:3None The placeholder image used in search results, history, and bookmarks is t... [20:39:15] <grrrit-wm> (03CR) 10Yuvipanda: [C: 032] Quick fix for crash saving a page with images and no network [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/139561 (https://bugzilla.wikimedia.org/66601) (owner: 10BearND) [20:39:19] <YuviPanda> bearND: I don't see the error anymore [20:39:27] <bearND> YuviPanda: cool :) [20:39:37] <grrrit-wm> (03Merged) 10jenkins-bot: Quick fix for crash saving a page with images and no network [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/139561 (https://bugzilla.wikimedia.org/66601) (owner: 10BearND) [20:43:35] <moizsyed> kaldari: did you get my last msg? [20:48:28] <kaldari> moizsyed: the one about using the x from Guided Tour? I got that one. Was there anything after that? [20:54:20] <YuviPanda> MaxSem: GeoData is still WTFPL, right? [20:54:59] <MaxSem> yep [20:55:29] <YuviPanda> MaxSem: cool. me and legoktm just put UrlShortener under WTFPL too [20:55:43] <MaxSem> :P [20:55:52] <YuviPanda> MaxSem: :D [20:57:38] <YuviPanda> bearND: uh oh. why are we using JS to get image list here? that part of the code from the old patch is unnecessary here, since we are building list of images in another, more synchronous way [20:57:55] <YuviPanda> bearND: that'd also mean we don't need to have two latches, just one [20:57:57] <moizsyed> kaldari: nope, thats all good [20:59:39] <bearND> YuviPanda: we need to spawn more AsyncTasks, which should be done from the main thread. I figured this was what you were doing in your old code, but I guess there was another reason for that as well. [20:59:54] <YuviPanda> bearND: + bridge.sendMessage("requestImagesList", new JSONObject()); [21:00:18] <YuviPanda> bearND: yeah, spawning more asynctasks is from the main thread, but that's with the Handler, I think. I don't think we need the bridge here *at all* [21:00:41] <bearND> YuviPanda: i was hoping that this could be simplified [21:01:16] <bearND> YuviPanda: don't really need requestImagesList here [21:01:20] <YuviPanda> bearND: it definitely can be. When I meant include the code from the removed patch I only meant the multiple async task spawning code, not the bridge [21:01:30] <YuviPanda> bearND: yeah, I think no part of bridge is required here [21:03:57] <tfinc> Deskana: when can we start to see mobile app metrics for editing streaming through http://mobile-reportcard.wmflabs.org/ ? [21:04:08] <bearND> YuviPanda: did you have an approach in mind on how to spawn multiple AsyncTasks from another? Note that at the end we also need to write the mapping file to disk [21:04:29] <YuviPanda> bearND: mind if I submit another PS? You can CR dbrant's changes in the meantime :D [21:04:39] <bearND> YuviPanda: not at all [21:04:48] <YuviPanda> bearND: ty :) I'll do so now [21:04:48] <bearND> YuviPanda: go at it [21:06:03] <Deskana> tfinc: So I met with Toby/Dario/Howie about the next steps for Analytics and Mobile to collaborate. [21:06:31] <Deskana> tfinc: The next steps are a little unclear to me right now, but there's a lot of interest in collaboration. I need to try to turn that into ACTUAL collaboration rather than just interest. [21:06:32] * YuviPanda is raring to have a go at the dashboard too [21:07:52] <bearND> dbrant: is there a bug or OTRS report for https://gerrit.wikimedia.org/r/#/c/139859/? [21:08:30] <dbrant> bearND: no, I just noticed it myself today during normal use. [21:08:41] <dbrant> bearND: try enabling "don't keep activities", and log out [21:10:33] <tfinc> Deskana: Analytics captures the data, we right the code to make the report card work with it [21:10:45] <tfinc> Deskana: so its as simple as creating story cards once we have data streaming in [21:10:53] <tfinc> which ad this point we should ... right YuviPanda ? [21:11:00] <bearND> dbrant|bbl: ok, i just sent the OTRS report off, and will create a bug [21:11:33] <Deskana> tfinc: Right now it feels to me as a "this is really important but we have more pressing issues for the next two sprints" [21:11:47] <YuviPanda> tfinc: pretty much, just have to figure out which sprint to put that in. also because the structure of our data is far richer than anything else WMF have dealt with so far, we cna do more with it as well. [21:11:54] <YuviPanda> tfinc: it's up to Deskana to figure out when to prioritize that [21:12:04] <tfinc> Deskana: if were capturing the data then we can easily rig it up after [21:12:08] <YuviPanda> tfinc: but I don't think it's very dependent on analytics, though. I'll keep them informed, but that's about it [21:12:15] <tfinc> for display [21:12:16] <YuviPanda> tfinc: oh we are capturing all the data :) that was the EventLogging cards. [21:12:31] <tfinc> and i bet we have it all with the EventLogging stories [21:12:31] <tfinc> yes [21:12:33] <YuviPanda> tfinc: we just don't have a pretty display yet. you can ask me (or others with stat access) for numbers and we can run queries for you [21:12:56] <tfinc> Deskana: so just scheduling as YuviPanda puts it [21:13:05] <Deskana> tfinc, YuviPanda: Analytics are really interested in working closer with us. It's too early to say at this stage but Dario mentioned that may even include imbedding someone from analytics into our team as a part-time resource. :) [21:13:16] <Deskana> *embedding [21:15:11] <wikibugs> 3Wikipedia App / 3Android App: crash on log out - 10https://bugzilla.wikimedia.org/66688 (10Bernd Sitzmann) 3NEW p:3Unprio s:3normal a:3None turn on "Don't keep activities" in Dev options stack trace from https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom&TicketID=7609499 java.lang.R... [21:15:28] <dr0ptp4kt> YuviPanda: okay for me to take a look at that ssl stuff? [21:15:33] <dr0ptp4kt> YuviPanda: or you on it already? [21:17:00] <YuviPanda> dr0ptp4kt: no, feel free. [21:17:15] <dr0ptp4kt> YuviPanda: k, will look into it [21:17:47] <YuviPanda> dr0ptp4kt: ty. should be done at a reasonably global level though. [21:17:56] <dr0ptp4kt> YuviPanda: agreed [21:18:13] <YuviPanda> dr0ptp4kt: cool [21:19:04] <bearND> YuviPanda: just out of curiosity: why was saved pages changed to bookmarks a while ago? [21:19:39] <YuviPanda> bearND: ah, so the feature had issues (editing problems, and bugs, and no way to clean out images, etc). [21:20:10] <YuviPanda> bearND: bugs kept coming in, and so it was either rewrite or remove. me, brion and dbrant|bbl convinced the PMs to let us remove the feature, and hence it became bookmarks :) [21:20:44] <bearND> YuviPanda: i see. thanks for the context [21:21:12] <YuviPanda> bearND: :) and then product changed their mind :D [21:21:57] <bearND> YuviPanda: well, i think user demand is pretty high for this feature [21:22:10] <YuviPanda> bearND: true, true [21:23:03] <grrrit-wm> (03CR) 10BearND: [C: 04-1] "Works well. Just one minor nitpick is to add the bug number of the bug I just created for this: 66688" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/139859 (owner: 10Dbrant) [21:23:22] <Deskana> YuviPanda, bearND: One of the bad things about switching PMs... [21:23:42] <Deskana> bearND: I only joined the team as PM shortly before you were hired. :) [21:24:08] <YuviPanda> bearND: feel free to edit the commit message yourself and merge :) commit message edits are ok [21:24:23] <bearND> YuviPanda: ok [21:25:18] <YuviPanda> Deskana: have you seen my commit message for the removal? [21:25:27] <YuviPanda> KILL SAVED PAGES, MAKE THEM JUST BOOKMARKS [21:25:31] <YuviPanda> DIE DIE DIE SAVED PAGES! DIE [21:25:33] <grrrit-wm> (03PS2) 10BearND: Fix possible crash when logging out, with "don't keep activities" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/139859 (https://bugzilla.wikimedia.org/66688) (owner: 10Dbrant) [21:25:48] <Deskana> "Unkill saved pages, product said. It'll be fine, product said." [21:25:51] <grrrit-wm> (03PS3) 10BearND: Fix possible crash when logging out, with "don't keep activities" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/139859 (https://bugzilla.wikimedia.org/66688) (owner: 10Dbrant) [21:26:15] <YuviPanda> Deskana: the old app had saved pages, and it was a goddamn nightmare. a lot because of PhoneGap, but still. I guess I still have intense negative associations with the feature from those days :) [21:26:22] <jgonera> https://etherpad.wikimedia.org/p/MobileWeb-IterationName [21:26:24] <MaxSem> https://etherpad.wikimedia.org/p/MobileWeb-IterationName [21:27:13] <bearND> YuviPanda: Deskana: apologies for bringing back bad memories, RIP [21:27:29] <YuviPanda> bearND: hehe :D [21:27:38] <Deskana> bearND: ;) [21:33:34] <grrrit-wm> (03CR) 10Dr0ptp4kt: [C: 032] Allow validator chaining, added URL validator [extensions/JsonConfig] - 10https://gerrit.wikimedia.org/r/140013 (owner: 10Yurik) [21:33:38] <grrrit-wm> (03Merged) 10jenkins-bot: Allow validator chaining, added URL validator [extensions/JsonConfig] - 10https://gerrit.wikimedia.org/r/140013 (owner: 10Yurik) [21:33:43] <grrrit-wm> (03CR) 10BearND: [C: 032] "just changed the commit message myself to reference the bug#" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/139859 (https://bugzilla.wikimedia.org/66688) (owner: 10Dbrant) [21:34:02] <grrrit-wm> (03Merged) 10jenkins-bot: Fix possible crash when logging out, with "don't keep activities" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/139859 (https://bugzilla.wikimedia.org/66688) (owner: 10Dbrant) [21:38:07] <wikibugs> 3Wikipedia App / 3Android App: crash on log out - 10https://bugzilla.wikimedia.org/66688 (10Bernd Sitzmann) 5PATC>3RESO/FIX [21:39:00] <Deskana> YuviPanda, bearND, dbrant|bbl: So realistically Moiz can't get the mock for onboarding done before Thursday, so since you're running out of cards I moved two bugs over from sprint 34 for you. [21:39:09] <Deskana> YuviPanda, bearND, dbrant|bbl: Let me know if you end up needing more stuff. [21:39:09] <YuviPanda> Deskana: cool. [21:39:23] <YuviPanda> Deskana: moving the 'left nav is too black' might be nice :) [21:39:30] * YuviPanda goes to check which were actually moved [21:40:00] <YuviPanda> Deskana: did you repro https://trello.com/c/al0sXlO2/38-when-app-crashes-or-device-reboots-user-is-still-shown-as-logged-in-although-in-fact-not [21:40:00] <YuviPanda> ? [21:40:10] <Deskana> YuviPanda: I didn't try yet. I will grab my tablet and do it now. [21:40:17] <YuviPanda> Deskana: ok! ty! :) [21:40:53] <Deskana> What I did this morning was look at most of the links from the main page to make sure they don't contain any incorrect information [21:41:08] <Deskana> e.g. https://en.wikipedia.org/w/index.php?title=Wikipedia:Featured_articles&diff=prev&oldid=613174254 [21:41:47] <bearND> Deskana: Maybe we don't need to full monty for onboarding. How about a clean up the login screen first where we have a real log in button and the link to "create account" looks like a link and not a button? We've had a few reports on that already. [21:41:58] <bearND> Deskana: also do we get svgs for icons soon? [21:42:12] <grrrit-wm> (03PS1) 10JGonera: Tablet styling tweaks [extensions/MobileFrontend] (wmf/1.24wmf8) - 10https://gerrit.wikimedia.org/r/140025 (https://bugzilla.wikimedia.org/65201) [21:42:21] <Deskana> bearND: I've asked Vibha to follow up with you guys on that. [21:43:17] <YuviPanda> Deskana: +1 to what bearND said [21:43:46] <YuviPanda> bearND: just start a thread and poke vibha. Even do a patch and send a screenshot. easier that way :D [21:44:49] <YuviPanda> Deskana: bearND we shouldn't wait on design for smaller things *completely*. sure they can change, etc - but we shouldn't block on them for every single thing. design is scarcer compared to dev. doesn't mean we'll go and keep implementing whatever we want, just that we can start before a design is finalized. Looking at the iOS designs and translating to android how we feel best is ok too, and the designers can refine later [21:46:40] <bearND> YuviPanda: sounds good. I also wouldn't mind picking up https://trello.com/c/NzwhJWiM/55-ampersand-in-page-titles-makes-everything-after-the-ampersand-be-ignored again, once we feel comfortable with changes currently in the pipeline so we can push another alpha. [21:46:55] <YuviPanda> bearND: cool. I'm almost done with the saved pages parallel change [21:47:02] <Deskana> YuviPanda: The way you gave me of crashing the app doesn't work. It just gets stuck on "Saving...". [21:47:03] <bearND> YuviPanda: awesome [21:47:35] <grrrit-wm> (03PS1) 10JGonera: Tablet styling tweaks [extensions/MobileFrontend] (wmf/1.24wmf9) - 10https://gerrit.wikimedia.org/r/140026 (https://bugzilla.wikimedia.org/65201) [21:48:00] <YuviPanda> Deskana: hmm, ok. give me a bit, I'll make a build that crashes the app by tapping ToC and test it myself. don't worry about it :) [21:48:16] <YuviPanda> Deskana: but I guess if it is reproducible, it is something we should fix before release. 'surprise IP display!' is terrible [21:48:18] <jgonera> MaxSem, https://gerrit.wikimedia.org/r/#/c/140025/ and https://gerrit.wikimedia.org/r/#/c/140026/ [21:48:27] <MaxSem> thanks [21:48:43] <grrrit-wm> (03CR) 10MaxSem: [C: 032] Tablet styling tweaks [extensions/MobileFrontend] (wmf/1.24wmf8) - 10https://gerrit.wikimedia.org/r/140025 (https://bugzilla.wikimedia.org/65201) (owner: 10JGonera) [21:49:01] <grrrit-wm> (03CR) 10MaxSem: [C: 032] Tablet styling tweaks [extensions/MobileFrontend] (wmf/1.24wmf9) - 10https://gerrit.wikimedia.org/r/140026 (https://bugzilla.wikimedia.org/65201) (owner: 10JGonera) [21:49:19] <grrrit-wm> (03Merged) 10jenkins-bot: Tablet styling tweaks [extensions/MobileFrontend] (wmf/1.24wmf8) - 10https://gerrit.wikimedia.org/r/140025 (https://bugzilla.wikimedia.org/65201) (owner: 10JGonera) [21:49:36] <grrrit-wm> (03Merged) 10jenkins-bot: Tablet styling tweaks [extensions/MobileFrontend] (wmf/1.24wmf9) - 10https://gerrit.wikimedia.org/r/140026 (https://bugzilla.wikimedia.org/65201) (owner: 10JGonera) [21:49:47] <grrrit-wm> (03PS2) 10BearND: Stop playback of media files when leaving page. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/139887 (https://bugzilla.wikimedia.org/66475) (owner: 10Dbrant) [21:50:58] <grrrit-wm> (03CR) 10BearND: [C: 032] "Nice!" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/139887 (https://bugzilla.wikimedia.org/66475) (owner: 10Dbrant) [21:51:18] <grrrit-wm> (03Merged) 10jenkins-bot: Stop playback of media files when leaving page. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/139887 (https://bugzilla.wikimedia.org/66475) (owner: 10Dbrant) [21:51:22] <Deskana> YuviPanda: Do you happen to know where the card for that crash is? [21:51:24] <Deskana> YuviPanda: I should comment on the bug saying I can't reproduce it. [21:51:35] <YuviPanda> Deskana: https://trello.com/c/al0sXlO2/38-when-app-crashes-or-device-reboots-user-is-still-shown-as-logged-in-although-in-fact-not [21:52:02] <Deskana> YuviPanda: I meant the card for the crash. i.e. the start editing before protection card. [21:52:32] <YuviPanda> Deskana: ah, there's no card, I think. [21:53:46] <jdlrobson> thedj: are you around? [21:56:54] <wikibugs> 3Wikipedia App / 3Android App: Android: App should never get stuck trying to save - 10https://bugzilla.wikimedia.org/66690 (10Dan Garry) 3NEW p:3Unprio s:3normal a:3None Steps to reproduce 1) Go to testwiki and start editing a random article (e.g. [[Phone Chatter]]) 2) Before you're done editing, go... [21:57:22] <wikibugs> 3Wikipedia App / 3Android App: Android: App should never get stuck trying to save - 10https://bugzilla.wikimedia.org/66690#c1 (10Dan Garry) If the app can't save after n seconds, we could give a timeout or something. [21:58:28] <grrrit-wm> (03PS2) 10Yuvipanda: Parallel image download for saved pages [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/140014 (owner: 10BearND) [21:58:44] <YuviPanda> bearND: ^ much simpler :D note the constructor to DownloadImageTask that sets CONCURRENCY_HIGH or something. that limits the task to 4 threads [21:59:36] <bearND> YuviPanda: great! I'll check it out in 15 min. Have a meeting coming up. [21:59:53] <YuviPanda> bearND: ok! [22:00:34] <bearND> YuviPanda: waana look at https://gerrit.wikimedia.org/r/#/c/139692/? [22:02:09] <YuviPanda> bearND: a bit too big at this time of the night for me :D I'm going to finish up the EL for Saved pages patch [22:02:18] <YuviPanda> bearND: and then head to bed. I'll take alook tomorrow [22:11:54] <DarTar> YuviPanda/Deskana: you guys pinged me? [22:12:31] <Deskana> DarTar: I was just relaying some of the discussions we had last Friday about Analytics and Mobile. So nothing is needed from you. :) [22:12:41] <DarTar> k cool [22:25:44] <YuviPanda> Deskana: how did you crash the app? [22:26:31] * Deskana looks. [22:26:38] <Deskana> https://trello.com/c/ZVp3hA0B/48-app-crashes-if-we-attempt-to-save-a-page-without-network-connectivity [22:27:08] <thedj> jdlrobson: sort of. [22:27:15] <thedj> was about to go sleep [22:27:17] <YuviPanda> Deskana: ah. but how did you get a build with saved pages? :) [22:27:39] <Deskana> Wait. [22:27:42] <Deskana> I totally misunderstood that card and found another bug. [22:27:48] <Deskana> Sweet. [22:28:04] <Deskana> I thought "save" in this case referred to the final step of the edit workflow. [22:28:16] <Deskana> It kept saying "Unable to save" with a retry button. [22:28:18] <jdlrobson> thedj: any interest in helping me break up the preferences page? https://gerrit.wikimedia.org/r/#/c/139872/ [22:28:24] <YuviPanda> Deskana: lol! :D [22:28:26] <Deskana> I tried hammering the retry button and it wouldn't crash. [22:28:26] <jdlrobson> thedj: no rush :) [22:28:36] <Deskana> Then I looked away and looked back and it'd crashed. [22:28:44] <Deskana> Basically, trust nothing. Verify all bugs. :P [22:28:45] <YuviPanda> Deskana: hmm, should've sent a crash report [22:28:47] <YuviPanda> Deskana: :D [22:28:51] * Deskana sighs. [22:28:53] <Deskana> I should've done. [22:28:54] <Deskana> Let me try again. [22:29:14] <YuviPanda> :D [22:29:34] <YuviPanda> Deskana: it's especially important for 'looked away and looked back and it crashed' bugs, since it's hard to reproduce exactly what/who you were looking at [22:29:44] <Deskana> I mean I physically looked away from my tablet [22:29:58] <Deskana> I'm trying to reproduce it now. [22:30:08] <Deskana> Got it. [22:30:56] <thedj> jdlrobson: i'll keep it on my radar [22:31:29] <grrrit-wm> (03PS1) 10Yuvipanda: Add instrumentation for saved page actions [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/140035 [22:31:37] <Deskana> YuviPanda: https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom;TicketID=7609600 [22:31:56] <YuviPanda> Deskana: ah, cool [22:33:08] <grrrit-wm> (03PS3) 10BearND: Parallel image download for saved pages [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/140014 [22:33:14] <thedj> jdlrobson: i like the approach [22:33:29] <jdlrobson> thedj: so does Jared :) [22:33:34] <jdlrobson> i'm just working on Echo right now [22:33:52] <bearND> YuviPanda: your patch looks great! Thanks! I'm going to merge it if you don't mind [22:33:55] <YuviPanda> Deskana: <3 ty. [22:33:59] <thedj> needs some styling work.. [22:34:03] <YuviPanda> bearND: sure! do test it first, though [22:34:46] <bearND> YuviPanda: already did the good case, just need to do it without network. [22:34:57] <YuviPanda> bearND: cool [22:35:02] <Maryana> kaldari: do you happen to have a link to the draft banner handy? [22:35:10] <Maryana> ideally in a preview state that makes it look real :) [22:35:19] <kaldari> one sec... [22:36:12] <kaldari> Maryana: https://meta.wikimedia.org/w/index.php?title=Fundraising_2012&banner=Tablet_redirect_notice&uselang=en&force=1 [22:36:20] <kaldari> doesn't have the graphics yet [22:36:36] <Maryana> no worries - that works :) [22:36:56] <YuviPanda> bearND: I'm going to test out EL now again. [22:39:00] <bearND> YuviPanda: how are we dealing with EL when there is no network? [22:43:53] <YuviPanda> bearND: we just ignore it for now [22:44:01] <YuviPanda> bearND: should queue it and put it up later at some point [22:44:31] <grrrit-wm> (03PS4) 10Dbrant: Changes to edit workflow: [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/139692 [22:45:36] <bearND> YuviPanda: yes, in some projects i've seen EL bundled anyways and sent over to the mothership when there was an opportune time as to not slow things down [22:46:07] <YuviPanda> bearND: yeah, we should implement that at some point [22:52:11] <bearND> YuviPanda: https://gerrit.wikimedia.org/r/#/c/140014 still needs some work. The remove doesn't work correctly yet since the URL changes. [22:52:34] <YuviPanda> bearND: hmm? 'the URL changes'? [22:52:47] <bearND> from //wiki to https://wiki [22:52:59] <YuviPanda> bearND: ah, hmm. we should move that part to the imagegetter, I think. [22:53:13] <YuviPanda> bearND: let me move it [22:53:56] <bearND> YuviPanda: we just need to store the original URL in parallelDownload [22:54:11] <YuviPanda> bearND: no, but why should imagegetter store the relative URL at all? [22:54:24] <bearND> YuviPanda: if we move it then the map is wrong [22:54:34] <YuviPanda> bearND: hmm? [22:54:46] <YuviPanda> bearND: why so? [22:54:53] <YuviPanda> bearND: oh, because during replacement it'll check the other thing? [22:54:58] <bearND> YuviPanda: the the map has entries of https://wiki [22:55:06] <YuviPanda> bearND: I'm confused now [22:55:06] <bearND> YuviPanda: yeah [22:56:10] <bearND> YuviPanda: the JS code looks for img[src='original URL'] [22:56:22] <wikibugs> 3MobileFrontend / 3stable: Need to click twice in search overlay - 10https://bugzilla.wikimedia.org/65676#c8 (10Ryan Kaldari) I have not been able to reproduce this bug on desktop or mobile. Tried Chrome and Firefox on desktop and Mobile Safari on iOS. [22:56:31] <bearND> where original URL starts with // [22:56:35] <YuviPanda> bearND: right. [22:56:44] <YuviPanda> bearND: let me just move the url replacement code into DownloadImageTask [22:56:50] <YuviPanda> bearND: that should solve this, I think [22:56:54] <YuviPanda> bearND: and just do the replacement to the http client [22:57:07] <bearND> YuviPanda: that should work [22:57:43] <bearND> YuviPanda: i like that approach [22:57:49] <YuviPanda> bearND: ya, doing now [22:57:57] <yurikR> jdlrobson, hi, busy tomorrow at 11? [22:58:24] <kaldari> jdlrobson, jgonera, MaxSem: Has anyone reported a bug about being sent to the desktop site when clicking on the search bar? [22:58:36] <MaxSem> nope [22:58:46] <jgonera> kaldari, on the search bar? I don't think so [22:59:00] <kaldari> I didn't see anything in Bugzilla, but it seemed familiar [22:59:16] <kaldari> maybe because it's also related to the search bar like the other bug [22:59:25] <bearND> YuviPanda: BTW: Hehe, it took a while to get image download to fail because most of the time it uses the cache. Had to move to a different article first. [22:59:33] <YuviPanda> bearND: :D [23:01:06] <grrrit-wm> (03PS2) 10Yuvipanda: Add instrumentation for saved page actions [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/140035 [23:01:08] <grrrit-wm> (03PS4) 10Yuvipanda: Parallel image download for saved pages [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/140014 (owner: 10BearND) [23:01:09] <YuviPanda> bearND: there! haven't tested [23:06:09] <grrrit-wm> (03CR) 10BearND: [C: 032] "Works! :)" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/140014 (owner: 10BearND) [23:06:51] <YuviPanda> bearND: woot [23:06:59] <bearND> YuviPanda: :) [23:07:12] <YuviPanda> bearND: can you make a release? just to alpha [23:07:17] <YuviPanda> bearND: feel free to self merge the bump [23:07:25] <bearND> YuviPanda: yes [23:07:31] <YuviPanda> bearND: ty. [23:07:42] <YuviPanda> Deskana: when bearND makes the release, you should be able to test / sign off on saved pages cards [23:07:58] <grrrit-wm> (03Merged) 10jenkins-bot: Parallel image download for saved pages [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/140014 (owner: 10BearND) [23:11:10] <grrrit-wm> (03PS1) 10BearND: Bump version for release 2.0-alpha-2014-06-16 [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/140041 [23:11:31] <YuviPanda> bearND: don't use the script, I haven't looked at it yet [23:11:35] <grrrit-wm> (03CR) 10BearND: [C: 032] Bump version for release 2.0-alpha-2014-06-16 [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/140041 (owner: 10BearND) [23:11:57] <grrrit-wm> (03Merged) 10jenkins-bot: Bump version for release 2.0-alpha-2014-06-16 [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/140041 (owner: 10BearND) [23:11:58] <bearND> YuviPanda: i only used the first part to update the version number and then ctrl-c [23:12:07] <YuviPanda> bearND: cool :) [23:12:40] <bearND> YuviPanda: i'm building with intelliJ (rebuild) [23:12:47] <YuviPanda> bearND: cool! :) [23:13:34] <grrrit-wm> (03PS1) 10Kaldari: Revert CentralNotice banner box-sizing to content-box on mobile [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/140042 [23:13:44] <flyingclimber> Deskana: https://groups.google.com/a/wikimedia.org/forum/#!forum/climbers [23:19:02] <bearND> YuviPanda: dbrant: Deskana: published save pages to alpha [23:19:10] <YuviPanda> bearND: wooot! :) [23:19:26] <jgonera> Maryana, are you going to write a summary email about the Opera Mini discussion? [23:19:33] <dbrant> bearND, YuviPanda, yay! [23:19:44] <YuviPanda> I'm testing the EL patch now [23:19:58] <YuviPanda> bearND: did you email RT asking for stat access? [23:20:16] <YuviPanda> bearND: I'll also refine the 'update all' card tomorrow [23:23:10] <bearND> YuviPanda: yes, i should have it. Still need to test it out. [23:23:21] <YuviPanda> bearND: cool! [23:36:56] <grrrit-wm> (03PS3) 10Yuvipanda: Add instrumentation for saved page actions [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/140035 [23:37:09] <jgonera> jdlrobson, do you know why page actions don't show up on main page in beta? [23:37:41] <jdlrobson> jgonera: because that was the design when we started work on the "this page needs your help" call to action [23:38:00] <jgonera> jdlrobson, I mean, where do we hide them, technically ;) [23:38:25] <jdlrobson> I guess SkinMinervaBeta would be the first logical place I'd look but I'm not sure exactly [23:40:20] <YuviPanda> bearND: tested all EL things except import. going to do that now [23:40:28] * YuviPanda cracks knuckles, cds into old repo [23:42:12] <jgonera> MaxSem, Maryana and I discovered a small styling bug on main pages... we might need to deploy another small patch before the redirect [23:43:24] <YuviPanda> bearND: import works too! \o/. merge? [23:44:38] <bearND> YuviPanda: have you pushed import code? [23:44:48] <jgonera> jdlrobson, we need to hide page actions on main page in stable because they look weird on tablets... https://en.m.wikipedia.org/wiki/Main_Page [23:44:53] <YuviPanda> bearND: hmm? [23:44:56] <YuviPanda> bearND: which import code? [23:45:00] <jgonera> any objections to this or a preferred way of doing this? [23:45:09] <bearND> YuviPanda: you said import works [23:45:21] <bearND> YuviPanda: oh, that was a single import [23:45:27] <YuviPanda> bearND: tested all EL things except import. going to do that now [23:45:28] <bearND> not import all [23:45:33] <YuviPanda> bearND: import works too! \o/. merge? [23:45:46] <YuviPanda> bearND: this import event is fired during initial import. we'll have to instrument 'update all' when we build it [23:46:11] <YuviPanda> bearND: sorry, should've given more context :) [23:46:24] <bearND> YuviPanda: just to be clear: import of one saved page, right? [23:46:41] <jdlrobson> jgonera: that will be a controversial move.. :) [23:46:56] <YuviPanda> bearND: no. when you have the old app installed, and then upgrade to the new app, it will 'import' your old saved pages, but not update them. so they aren't actually available offline. [23:46:56] <jgonera> jdlrobson, we're already doing it in beta [23:47:00] <jdlrobson> jgonera: and how do they look weird? look fine to me [23:47:11] <YuviPanda> bearND: so this 'import' event just tracks that - when it was 'imported' from old app, but no updates to it yet [23:47:14] <jdlrobson> oh i see when logged out [23:47:18] <jgonera> jdlrobson, there's no title, so the title line just goes through them [23:47:19] <YuviPanda> bearND: this code was added by dbrant as part of the initial saved pages patch [23:47:26] <jgonera> yeah [23:47:51] <bearND> YuviPanda: why do we need to track that? [23:47:54] <jdlrobson> well you'll need a cache flush for that anyway [23:48:04] <jdlrobson> so you might as well fix up the css [23:48:11] <YuviPanda> bearND: to see how many saved pages people in the old app had? [23:48:15] <jgonera> jdlrobson, no, I can hide it in CSS too [23:48:20] <jdlrobson> there is mainpage.less [23:48:24] <jdlrobson> so why can't you? [23:48:46] <jgonera> jdlrobson, why can't I what? [23:48:53] <jdlrobson> oh i see misread that as "i can't hide it in CSS" [23:49:46] <bearND> YuviPanda: ok. [23:49:51] <YuviPanda> bearND: :) [23:49:58] <YuviPanda> bearND: Deskana dbrant I'm off to bed, need anything from me? [23:50:07] <YuviPanda> fuck, it's 5:20 AM :| [23:50:19] <Deskana> YuviPanda: I need you to sleep and be well rested. :) [23:50:35] <dbrant> YuviPanda: nope! but the Edit Workflow stuff awaits [23:50:40] <YuviPanda> Deskana: not a chance, need to be up at 10AM to go and try again (6th time?) to get my college certs (for H1B) :) [23:50:46] <YuviPanda> dbrant: indeed. I'll take a look tomorrow :) [23:50:50] <jgonera> jdlrobson, rules from mainpage.less don't seem to be in effect [23:50:56] <YuviPanda> dbrant: we'll probably have to modify our EventLogging schema a bit as well. [23:50:59] <YuviPanda> shouldn't be too hard [23:51:04] <jgonera> there is already a rule removing the bottom border, but the border is there [23:52:01] <bearND> dbrant: are you able to get to stat1003? [23:52:03] <jgonera> jdlrobson, mainpage.less is loaded only in beta :( [23:52:39] <Deskana> YuviPanda: :/ [23:52:45] <Deskana> YuviPanda: Well it'll be worth it! Think of it that way. [23:52:54] <YuviPanda> Deskana: yeah :) did that for about 8h today. 41C here. sigh. [23:53:06] <YuviPanda> bearND: dbrant https://wikitech.wikimedia.org/wiki/EventLogging#Check_if_the_data_I_am_logging_is_coming_through_properly.3F has some useful tips for debugging EL once you are on stat1003 [23:53:51] <dbrant> bearND: I believe I have access, but haven't tried anything with it yet. [23:54:11] * YuviPanda waves off for real [23:54:19] <bearND> YuviPanda: good night [23:54:19] <tfinc> night YuviPanda [23:54:47] <bearND> dbrant: i thought i had access, too, but I just tried earlier and access was denied [23:55:20] <jgonera> jdlrobson, so I assume you don't have strong objections or preferences how this should be done? [23:55:52] <wikibugs> 3MobileFrontend / 3stable: References drawer doesn't work after editing - 10https://bugzilla.wikimedia.org/65816 (10Maryana Pinchuk) 5PATC>3RESO/FIX [23:56:00] <jdlrobson> nope, i'm just predicting that removing them from the main page may result in a Village pump discussion so tread carefully :) [23:56:14] <Deskana> YuviPanda|zzz: Sleep well.