[00:00:09] jgonera: ok, just two things for you to check and then i can close xylophone cat :) [00:00:24] Maryana, ok, give me a few mintues [00:00:29] np [00:01:20] (03PS1) 10Yurik: Refactoring cleanup [extensions/JsonConfig] - 10https://gerrit.wikimedia.org/r/140047 [00:02:18] (03PS1) 10Yurik: Refactoring - matching name changes in JsonConfig [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/140048 [00:09:44] (03CR) 10Dr0ptp4kt: [C: 032] Refactoring cleanup [extensions/JsonConfig] - 10https://gerrit.wikimedia.org/r/140047 (owner: 10Yurik) [00:09:48] (03Merged) 10jenkins-bot: Refactoring cleanup [extensions/JsonConfig] - 10https://gerrit.wikimedia.org/r/140047 (owner: 10Yurik) [00:12:29] (03CR) 10Dr0ptp4kt: [C: 032] Refactoring - matching name changes in JsonConfig [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/140048 (owner: 10Yurik) [00:12:38] (03Merged) 10jenkins-bot: Refactoring - matching name changes in JsonConfig [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/140048 (owner: 10Yurik) [00:16:19] you guys, i think this might be the defining moment of my career as a PM: https://trello.com/b/JGcMpNEO/mobile-web-current-sprint-25-yolo-swag-bird [00:16:28] it just can't get any better than this [00:22:31] (03PS2) 10Dbrant: Add basic Find in page functionality. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/139310 (owner: 10Dr0ptp4kt) [00:49:42] (03PS3) 10Dbrant: Add basic Find in page functionality. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/139310 (owner: 10Dr0ptp4kt) [00:52:55] dr0ptp4kt: ^ something like this, perhaps... [00:53:37] dbrant: cool man, will take a look tomorrow, okay? [00:53:50] dr0ptp4kt: of course; anytime [00:53:56] dbrant: thx [01:02:45] (03PS3) 10Dbrant: [WIP - test only] Implement syntax highlighting in Edit window. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/137684 [02:16:44] moizsyed: Hey Moiz [02:16:50] hey [02:16:51] sup [02:17:21] you haven't sent me the banner assets yet have you? I haven't seen anything. [02:17:42] its in the trello card [02:17:49] i put an svg file in there [02:17:50] ah, sorry! [02:17:51] did you see it? [02:17:58] thanks! [02:18:41] shit, where'd that card go? [02:18:53] https://trello.com/c/2r5jHOd1/21-centralnotice-for-tablet-users [02:18:55] found it [02:19:06] banner.svg is the file [02:34:02] moizsyed: small problem... [02:34:09] kaldari: uh oh [02:35:06] The SVG rendering servers for Commons don't have Helvetica. Can you resave that SVG with the text rendered as shapes rather than text? If not, I can probably do it in Illustrator myself. [02:35:27] no problem [02:35:54] I think there's an option in the SVG export interface in Illustrator (although I'm not sure what program you're using) [02:36:25] alright [02:36:32] just uploaded it to the card [02:36:34] let me know if it works [02:36:41] sorry for the last minute change [02:36:53] no prob [03:03:57] kaldari: any updates on banner [03:04:19] https://meta.wikimedia.org/w/index.php?title=Wikimedia_Forum/Archives/2010-01&banner=Tablet_redirect_notice&uselang=en&force=1 [03:04:24] forgot to change the x though... [03:05:10] moizsyed: Does that look OK otherwise? [03:06:42] why is that svg looking all pix-y on retina screen? kaldari [03:06:58] kaldari: the blue banner ribbon image [03:07:05] ah, I can fix that... [03:07:24] kaldari: cool [03:08:42] kaldari: also, can you change the border on #Tablet_redirect_notice to just border-bottom [03:09:08] sure [03:10:23] moizsyed: https://meta.m.wikimedia.org/w/index.php?title=Wikimedia_Forum&banner=Tablet_redirect_notice&uselang=en&force=1 [03:10:52] pixelly issue should be fixed as well [03:12:05] now to track down that x [03:12:37] 3Wikipedia App / 3iOS App: Long math formulas are cut off - 10https://bugzilla.wikimedia.org/66680#c1 (10Bernd Sitzmann) Those are images. I know this is not great but as a workaround one could pinch to zoom out. In that regard the app is more flexible. I guess once this is fixed for MFE it would also be fix... [03:12:45] kaldari: its still pix-ey for me [03:12:55] also, the border hasn't updated [03:13:14] must be cached for you [03:13:33] i just ran it on another browser [03:13:33] do you have any way to clear your cache? [03:13:46] i can clear the cache [03:14:54] any luck? or still getting the old version? [03:15:16] stil getting the old version [03:16:52] hmm, can you try it on a desktop browser just for fun? [03:17:19] mobile browsers cache everything like crazy [03:17:25] alright [03:17:28] it works now [03:17:44] looks fucking good [03:17:48] god damn thats a hot banner [03:17:54] fix that 'x' tho please [03:17:57] sweet, I'll have the x replaced in a bit [03:19:53] who's Sam Smith? [03:20:01] it says he created the x [03:21:04] he's invisible! [03:23:38] haha [03:23:43] sam smith is an engineer on growth [03:23:47] lives in UK [03:23:56] do you need him? [03:23:58] kaldari: [03:24:19] No, I just needed to credit him for his excellent work [03:25:24] He's a genius [03:28:18] moizsyed: https://meta.m.wikimedia.org/w/index.php?title=Wikimedia_Forum&banner=Tablet_redirect_notice&uselang=en&force=1 [03:28:35] haha hes pretty good [03:29:11] alright [03:29:17] that banner looks good [03:29:20] i dont have a tablet with me [03:29:27] so i cant see it exactly on a device [03:29:37] but i will tell it tomorrow morning and give you my final a-ok [03:29:44] you could try a smart phone in landscape [03:29:50] yeah im doing that [03:29:54] its looking good on a fone [03:30:28] is the 'x' a good size? I can tweak it if you want [03:32:10] oh [03:32:18] the 'x' is looking a little big [03:32:24] true [03:32:33] it's 18x18 right no [03:32:34] now [03:32:39] wanna try 15? [03:32:41] sure [03:33:39] reload [03:34:45] I think I'm going to push it in from the edges a few pixels tooo [03:35:35] the size didnt change for me, coz of cache probably [03:35:41] but i will trust you on this one [03:37:36] it looks awesomer now. Made it 14x14 and pushed it 8px from the edge [03:37:56] ok perfect [04:33:27] (03PS1) 10BearND: Fix accessibility issue for search fragment buttons [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/140055 [05:28:07] 3MobileFrontend / 3stable: Need to click twice in search overlay - 10https://bugzilla.wikimedia.org/65676#c9 (10Florian) I've noticed it in Chrome on desktop sometimes, but not very often. Maybe it's only because of the input field isn't big as the header (see attachement for what i mean), so maybe sometimes... [05:28:22] 3MobileFrontend / 3stable: Need to click twice in search overlay - 10https://bugzilla.wikimedia.org/65676#c10 (10Florian) Created attachment 15671 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15671&action=edit Height of search input [06:15:23] 3Wikipedia App / 3Localization/Translation/Language: Add special support for languages with 3-letter codes on Android - 10https://bugzilla.wikimedia.org/36264#c5 (10Amir E. Aharoni) The upstream bug was fixed last February. Is this already usable in the current development tools? If not, when can we expect... [06:51:00] (03PS2) 10Florianschmidtwelzow: Proposal: Redirect to direct match in search [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/139556 (https://bugzilla.wikimedia.org/66506) [06:54:38] (03CR) 10Florianschmidtwelzow: [C: 04-1] "Only little code improvements:" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/139556 (https://bugzilla.wikimedia.org/66506) (owner: 10Florianschmidtwelzow) [09:15:35] (03CR) 10Yuvipanda: "Ok, this looks really good. Let's test for a bit and merge." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/139310 (owner: 10Dr0ptp4kt) [10:39:40] (03CR) 10Siebrand: [C: 032 V: 032] Fix syntax error [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/140081 (owner: 10L10n-bot) [11:06:22] 3Wikipedia App / 3iOS App: Long math formulas are cut off - 10https://bugzilla.wikimedia.org/66680#c2 (10Sage Ross) This is only in the iOS app. One Android and MFE, see the other bug. [11:56:26] [13WikipediaMobile] 15siebrand pushed 1 new commit to 06master: 02http://git.io/p7sqLQ [11:56:26] 13WikipediaMobile/06master 14921f2e5 15Siebrand Mazeland: Localisation updates from https://translatewiki.net. [12:25:32] (03PS4) 10Yuvipanda: Add basic Find in page functionality. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/139310 (owner: 10Dr0ptp4kt) [12:33:06] (03CR) 10Yuvipanda: "Minor nits, but otherwise looks good. Will merge after these are addressed." (034 comments) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/139310 (owner: 10Dr0ptp4kt) [12:33:26] (03PS5) 10Yuvipanda: Changes to edit workflow: [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/139692 (owner: 10Dbrant) [12:33:41] YuviPanda: ^ addressing... [12:40:39] (03CR) 10Yuvipanda: "Quite like it! Couple of changes:" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/139692 (owner: 10Dbrant) [12:52:44] (03CR) 10Dbrant: "Regarding (2), isn't that exactly what the design mockup calls for? At least that's how I interpreted it..." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/139692 (owner: 10Dbrant) [12:52:46] (03PS1) 10Jack Phoenix: Acronyms are evil, so avoid them whenever possible. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/140105 [12:58:54] 3Wikipedia App / 3Android App: App crashes when saving a page after restoring app with "don't keep activities" - 10https://bugzilla.wikimedia.org/66716 (10Dmitry Brant) 3NEW p:3Unprio s:3normal a:3None Enable "don't keep activities" -> Open a page -> exit app -> go back to app -> save the page. [13:00:10] (03PS1) 10Dbrant: Fix crash when saving page after restoring activity from parcel. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/140107 (https://bugzilla.wikimedia.org/66716) [13:10:09] (03PS1) 10Jack Phoenix: Grammar: vist -> visit [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/140108 [13:16:08] 3Wikipedia App / 3Android App: It shouldn't mention "article" when I'm editing non-article pages - 10https://bugzilla.wikimedia.org/66532#c1 (10Jack Phoenix) Ignoring things such as internally used function names, tests and internationalization messages' documentation, the only two meaningful instances of "a... [13:16:40] * YuviPanda waves at dbrant [13:17:15] YuviPanda: hey! [13:17:27] (03PS2) 10Yuvipanda: scripts: Document what the BMP is [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/140105 (owner: 10Jack Phoenix) [13:17:32] dbrant: sleeping didn't really work, so back here [13:17:44] (03CR) 10Yuvipanda: [C: 032] "Thanks for the patch!" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/140105 (owner: 10Jack Phoenix) [13:17:53] YuviPanda: lol I know how that is [13:18:12] (03Merged) 10jenkins-bot: scripts: Document what the BMP is [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/140105 (owner: 10Jack Phoenix) [13:18:15] (03CR) 10Yuvipanda: [C: 032] ":D" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/140108 (owner: 10Jack Phoenix) [13:18:39] (03Merged) 10jenkins-bot: Grammar: vist -> visit [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/140108 (owner: 10Jack Phoenix) [13:18:48] dbrant: yeah. plus it's still 37 or something, and ants everywhere [13:18:58] YuviPanda: my god! [13:19:15] dbrant: was 40C when I was out yesterday and today [13:19:42] YuviPanda: O_o [13:19:52] dbrant: fairly exhausted and drained as well. b'cracy sucks. [13:20:06] dbrant: last piece of paperwork required from me to get started on my move to the US. [13:21:09] 3Wikipedia App / 3Android App: It shouldn't mention "article" when I'm editing non-article pages - 10https://bugzilla.wikimedia.org/66532#c2 (10Yuvi Panda) Pages welcome! :) [13:21:44] 3Wikipedia App / 3Android App: It shouldn't mention "article" when I'm editing non-article pages - 10https://bugzilla.wikimedia.org/66532#c3 (10Yuvi Panda) Patches, I meant *PATCHES*. [13:21:45] dbrant: yay for getting find in page done. that's a good bonus :D [13:22:07] dbrant: slightly OffTopic, perhaps, but been a real pleasure working with you :) [13:23:24] YuviPanda: likewise! but we're just getting started, right? [13:23:33] dbrant: yeah :) [13:24:02] YuviPanda: so you like the way I put the 'find' bar at the bottom? I had a nagging feeling that we shouldn't obscure the main Search bar at the top... [13:24:20] dbrant: i'm ok with it, but I prefer it replacing the search bar [13:24:22] see: chrome [13:24:39] dbrant: plus, right now, what to do when you are in find in page, and user taps on search bar? [13:25:09] 3Wikipedia App / 3Android App: Android: Searching for "main page" and pressing go gives you a weird desktop-hybrid page - 10https://bugzilla.wikimedia.org/66294#c1 (10Yuvi Panda) Is a bug in the MobileView API. see https://en.wikipedia.org/wiki/Special:ApiSandbox#action=mobileview&format=json&page=main%20p... [13:25:30] YuviPanda: I suppose it'll go to another page, with the Find-in-page bar still showing [13:25:57] dbrant: right. I think that's a bit confusing. what happens to the text there? [13:26:23] 3MobileFrontend / 3General/Unknown: action=mobileview does not apply Main page transformation when requesting page that redirects to Main page - 10https://bugzilla.wikimedia.org/66294#c2 (10Yuvi Panda) I guess the code that checks if current page is main page is not resolving redirects first before checking. [13:26:38] 3MobileFrontend / 3General/Unknown: action=mobileview does not apply Main page transformation when requesting page that redirects to Main page - 10https://bugzilla.wikimedia.org/66294#c3 (10Yuvi Panda) Moved to MobileFrontend. [13:28:19] dbrant: plus I share dr0ptp4kt's concern of the keyboard being too near it... [13:29:30] YuviPanda: well, now that it's a separate Fragment, we can place it anywhere. I can play around with it being on top. [13:29:46] dbrant: yeah, that'll be nice too [13:30:29] 3MobileFrontend / 3General/Unknown: action=mobileview does not apply Main page transformation when requesting page that redirects to Main page - 10https://bugzilla.wikimedia.org/66294#c4 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/oohlIKmC [13:31:04] dbrant: re: the 'other' - I'm ok with it turning into a textbox in place, or expanding one below it. moving to another screen seems overkill. [13:31:17] dbrant: I think iOS has a textobox that when you tap hides the other things. [13:34:17] YuviPanda: very well! [13:34:20] dbrant: we'll also need instrumentation for that. [13:47:21] (03PS2) 10Yuvipanda: Fix accessibility issue for search fragment buttons [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/140055 (owner: 10BearND) [13:49:31] (03CR) 10Yuvipanda: [C: 032] Fix accessibility issue for search fragment buttons [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/140055 (owner: 10BearND) [13:49:55] (03Merged) 10jenkins-bot: Fix accessibility issue for search fragment buttons [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/140055 (owner: 10BearND) [13:50:12] (03PS1) 10Yuvipanda: Remove unused about prefs file [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/140117 [13:50:52] (03CR) 10Dbrant: [C: 032] "lol just noticed that, too." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/140117 (owner: 10Yuvipanda) [14:02:07] dbrant: :D idk how it survived so long [14:08:22] 3Wikipedia App / 3iOS App: Long math formulas are cut off - 10https://bugzilla.wikimedia.org/66680#c3 (10Bernd Sitzmann) Oops. Never mind then. I retract my earlier comment. [14:09:52] 3Wikipedia App / 3iOS App: [iOS app] Long math formulas are cut off - 10https://bugzilla.wikimedia.org/66680 (10Sage Ross) [14:22:34] dbrant: emailed a proposed release plan, tl;dr: being - code freeze on this friday for release. only crit bugs get fixed after that. [14:22:52] YuviPanda: great! sounds good [14:23:22] dbrant: cool :) [14:28:44] is the dark theme going to make the cutoff? [14:28:52] ragesoss: nope [14:29:07] ragesoss: find in page is most probably going to, though :) [14:29:14] cool [14:29:20] ragesoss: :) [14:29:56] I mostly focus on bugs, since I want a billion features that probably don't align well with the average user. [14:30:01] ragesoss: :D [14:31:08] ragesoss: do try out and file bugs in the iOS beta too. it has far less testing than the Android app [14:31:38] yeah. I did file one already, about the math images. [14:31:49] ragesoss: yup! :D moaaar [14:32:01] the only big one is, I assume, well-known: media files don't work at all. [14:32:11] ragesoss: I... don't think that's 'well known' [14:32:23] ragesoss: define 'media', btw? audio/video or images? [14:32:27] both. [14:32:33] video shows a thumbnail. [14:32:58] and audio? [14:32:59] audio gets a little grey bar saying it can't be played (which actually covers some of the surrounding text) [14:33:26] MFE behaves the same way on iOS [14:33:57] so I was assuming that brion has some sort of plan for all this involving his js decoding magic. [14:34:26] aaah [14:34:27] right [14:34:40] ragesoss: dbrant I guess this is us serving only free codecs and iOS having support for none of them [14:34:56] ragesoss: you should still file a bug anyway. [14:35:03] YuviPanda: correct [14:39:10] 3Wikipedia App / 3iOS App: [iOS app] Media files do not work - 10https://bugzilla.wikimedia.org/66722 (10Sage Ross) 3NEW p:3Unprio s:3normal a:3None Media files in articles do not play. For video files, a thumbnail is shown but tapping it does nothing. See [[Blowing a raspberry]]. For audio files,... [14:44:00] YuviPanda: yo yo yo yo. [14:44:04] aharoni: heya [14:44:27] See https://translatewiki.net/wiki/Support#About_[[Wikimedia:Wikipedia-android-strings-edit_save_action_license/en]]_42509 [14:44:48] aharoni: hehe, that string was *just* removed from the UI... [14:44:54] O I C [14:45:09] good then [14:45:20] YuviPanda: can you please reply there/ [14:45:22] ? [14:45:24] aharoni: oh, hmm. maybe twn.net is swalling html links or something? [14:45:32] aharoni: there are other things with html links in them, maybe [14:46:07] twn and the app source were out of sync for a while, and today they were finally synced [14:46:28] so I couldn't do full translation to Hebrew, and hence I couldn't do full RTL testing [14:46:42] aharoni: ah, hmm. [14:47:15] so today was a big step forward, as far as I'm concerned, even though the translation took me five minutes or so :) [14:47:42] aharoni: oh, but It is probably related to the fact that Wikimedia:Wikipedia-android-strings-about terms of use/en and Wikimedia:Wikipedia-android-strings-about privacy policy/en appear not to exist in English. [14:47:44] is wrong [14:47:48] those strings do exist in english [14:48:00] Terms of Use [14:48:01] Privacy Policy [14:48:06] aharoni: possibly lack of sync? [14:48:37] YuviPanda: I don't quite know [14:48:51] you should ask Siebrand [14:49:16] here I am only a translator and a tester of the app, I don't do any internal twn stuff with the app [14:49:33] (03PS1) 10Jack Phoenix: Bug #66532: s/article/page/ for the English localization [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/140129 [14:49:36] aharoni: blah. I'll just respond there. moment [14:49:48] YuviPanda: if all these strings are being removed then it may not be urgent, but go figure, something like that may return in future strings [14:49:58] aharoni: no, only the first one is removed. the rest are still there [14:50:06] aha, so it is a problem [14:50:27] aharoni: it is. [14:52:08] aharoni: I don't see him on IRC at all [14:52:17] neither do I [14:52:21] email or something :) [14:53:16] aharoni: heh. ok [14:53:36] aharoni: I hope this gets fixed before release. otherwise I'll have to ship stripping out all these strings from the translation [15:00:12] (03CR) 10Siebrand: [C: 031] "L10n reviewed." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/140129 (owner: 10Jack Phoenix) [15:00:28] aharoni: gah, it's actually https://bugzilla.wikimedia.org/show_bug.cgi?id=47310 [15:00:42] aharoni: a translate problem, not a translatewiki.net problem [15:00:43] (03PS6) 10Dbrant: Changes to edit workflow: [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/139692 [15:03:13] YuviPanda: as for the "Other" summary text, might I make an argument for keeping it the way it is (at leat for now): it's already nicely integrated with the "Next" button in the actionbar, and it provides space for the drop-down Persister for the summary text. [15:05:48] (03CR) 10Yuvipanda: [C: 032] "TY for the patch! :)" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/140129 (owner: 10Jack Phoenix) [15:06:16] (03Merged) 10jenkins-bot: Bug #66532: s/article/page/ for the English localization [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/140129 (owner: 10Jack Phoenix) [15:06:30] dbrant: hmm, let me test the new PS to see how it's like [15:07:08] (03CR) 10Siebrand: [C: 04-1] "L10n reviewed." (032 comments) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/139692 (owner: 10Dbrant) [15:10:13] YuviPanda: and perhaps we could come up with a couple more canned summary tags? [15:23:01] YuviPanda: another thing: https://bugzilla.wikimedia.org/show_bug.cgi?id=36264 [15:23:06] Remember this little boy? :) [15:23:14] aharoni: looking [15:23:28] YuviPanda: see my latest comment there. [15:25:22] aharoni: updating the android sdk tools, let me see how they fare [15:25:34] YuviPanda: thanks [15:27:11] dbrant: checking out the patch now. [15:29:39] YuviPanda: this message is probably also affected: https://translatewiki.net/wiki/Wikimedia:Wikipedia-android-strings-about_wmf/en [15:29:45] that's why it seemed "lego" to me. [15:29:55] aharoni: yup, that's one of the 6 I mentioned [15:31:01] YuviPanda: https://bugzilla.wikimedia.org/show_bug.cgi?id=66725 [15:31:10] 3Wikipedia App / 3Android App: Messages with links appear as empty in translatewiki.net - 10https://bugzilla.wikimedia.org/66725 (10Amir E. Aharoni) 3NEW p:3Unprio s:3normal a:3None There are messages with HTML that currently appear as empty or lacking characters when they are up for translations in... [15:32:10] 3Wikipedia App / 3Android App: ToC icon is fuzzy on large high-resolution devices - 10https://bugzilla.wikimedia.org/66726 (10Sage Ross) 3NEW p:3Unprio s:3normal a:3None On my 2013 Nexus 7, the ToC icon is noticeably fuzzy compared to the drawer icon on the left and the three-dots icon on the right. [15:55:24] 3MobileFrontend / 3General/Unknown: action=mobileview does not apply Main page transformation when requesting page that redirects to Main page - 10https://bugzilla.wikimedia.org/66294 (10Florian) a:3Florian [15:56:12] FlorianSW: woo, ty :) [15:56:30] YuviPanda: np :D [15:57:04] damn special main page behavior [15:57:06] :P [15:57:16] FlorianSW: :) hopefully it will die some day [15:58:04] YuviPanda: hope too :P *fingercross* [15:58:04] YuviPanda: the new up required Android 4, does it [15:58:06] ? [15:58:40] (03PS5) 10Dbrant: Add basic Find in page functionality. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/139310 (owner: 10Dr0ptp4kt) [15:58:55] aharoni: doesn't. 2.3+ [15:59:03] aha! [15:59:14] aharoni: old app was 2.2+ [15:59:16] what does my phone have?.. [15:59:23] 2.3.4 [15:59:24] aharoni: check check! :) [15:59:27] aharoni: should run [15:59:28] aharoni: do test [15:59:31] installing [15:59:48] aharoni: cool [15:59:54] I somehow thought that you said that it requires Android 4 at some point. [15:59:57] hi hpnadig ! [16:00:08] aharoni: it did when we last met, I think. 2.3 support was added later [16:00:10] aharoni: hi! :) [16:00:19] YuviPanda: cool [16:00:20] installing [16:00:25] aharoni: do report bugs! [16:00:36] YuviPanda: should be called "Wikipedia Beta" in Play Store, right? [16:00:39] aharoni: yup [16:00:52] Medieval cuisine :) [16:00:55] aharoni: :) [16:01:12] put an article about your favorite Tamil dish there!~ [16:01:25] aharoni: I'm too lazy to do screenshots... :D [16:01:29] he-hey, no special permissions needed [16:01:39] aharoni: :D yeah. just network. [16:01:39] downloading [16:02:21] "Last update" at the bottom of the page is not translated. [16:02:23] recent message? [16:02:48] same for "Search Wikipedia" at the top. [16:02:52] 3Wikipedia App / 3Android App: Cannot edit MediaWiki:Common.css - 10https://bugzilla.wikimedia.org/66320#c1 (10Jack Phoenix) I can't reproduce this on a beta build of the Android app, but then again I'm not able to edit enwiki's [[MediaWiki:Common.css]] via the app either (when logged in), even though I'm ab... [16:03:33] amusing: TOC is _aligned_ LTR, but the direction is correct [16:04:00] aharoni: 'last update' is the HTML message. unsure why it hasn't been updated [16:04:08] aharoni: search wikipedia has been around forever... [16:04:10] YuviPanda: no Kannada on it? [16:04:23] hpnadig: translations? Unsure of kannada status... [16:04:30] hpnadig: you can always add more translations on translatewiki.net :) [16:04:49] YuviPanda: I'm looking at "Read in other languages" option [16:05:03] hpnadig: ah. if the article has an interwiki link to kannada, it should be there [16:05:10] hpnadig: https://translatewiki.net/wiki/Special:Translate?filter=!translated&action=translate&group=out-wikimedia-mobile-wikipedia-android-strings&language=kn [16:05:17] hpnadig: try 'India' [16:05:22] 3Wikipedia App / 3Android App: Cannot edit MediaWiki:Common.css - 10https://bugzilla.wikimedia.org/66320#c2 (10Yuvi Panda) Does quickUserCan check for global rights? that is what the API backend that the app uses checks... [16:05:37] the interface is half-translated [16:05:50] aharoni: does it match to what you see on translatewiki.net status? [16:05:53] aharoni: I guess not [16:05:58] aharoni: since you translate all the things... [16:06:10] ah, so this is the inter-wiki. [16:06:14] hpnadig: yup [16:06:30] aharoni: the beta is about a week old though [16:06:34] (03PS1) 10Florianschmidtwelzow: Follow redirect for Main Page check if enabled [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/140141 (https://bugzilla.wikimedia.org/66294) [16:06:47] aharoni: nice to know! should probably push for some translations there. [16:07:14] YuviPanda: what about if I'd like to start with Kannada Wikipedia? [16:07:40] hpnadig: 1. open left nav menu (tap 'W' icon or swipe from left edge), 2. 'More' menu, 3. set language :) [16:07:44] hpnadig: afaik it starts with the wikipedia in the language of your phone by default [16:08:29] aharoni: ah, okay. The locale for Kn is probably non-existent. [16:08:57] YuviPanda: any idea? is yours on Tamil? [16:09:05] hpnadig: if you install the morelocales app and set that to 'Kannada' it should open by default with that [16:09:12] hpnadig: yeah, tamil is also non-existant [16:10:05] Let me try that. Meanwhile, found some bugs having switched to Kannada. [16:10:17] YuviPanda: If everything is English - phone locale, English Wikipedia, app ui - what is the supposed to be the order of the top bar from left to right? [16:10:38] In Hebrew I see, from left to right: logo, search box, toc icon, three vertical dots icon. [16:10:46] aharoni: yup [16:10:53] aharoni: that's how it is supposed to be on english [16:11:04] I'd imagine that this is the right order for an LTR language and should be the other way in RTL. [16:11:13] aharoni: unfortunately UI mirroring was not introduced until 4.1 or something, so older androids won't see UI mirroring. only content mirroring [16:11:29] oh, so it's an Android 2 issue? [16:11:30] ah well [16:11:35] aharoni: yeah. [16:11:36] I can live with it :0 [16:11:37] :) [16:11:39] YuviPanda: the hyperlinks aren't showing up for front page when on Kannada [16:12:06] But the search label is "Search Wikipedia" - that should be fixed. [16:12:07] hpnadig: do you see it different from https://kn.m.wikipedia.org/wiki/%E0%B2%AE%E0%B3%81%E0%B2%96%E0%B3%8D%E0%B2%AF_%E0%B2%AA%E0%B3%81%E0%B2%9F [16:12:23] aharoni: indeed. is it 'correct' on your tablet? [16:12:28] let's see [16:12:31] hpnadig: also can you send me a screenshot of what you see/ [16:12:32] ? [16:13:40] YuviPanda: hmm... no! It is actually the same. Guess they don't have hyperlinks on FA and news items these days! Weird. [16:13:41] (03PS6) 10Dbrant: Add basic Find in page functionality. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/139310 (owner: 10Dr0ptp4kt) [16:13:55] YuviPanda: sending the screenshot [16:14:10] YuviPanda: ^ Find bar on top (and works in 2.3!) [16:14:20] dbrant: woot! :D [16:14:54] YuviPanda: the action bar title doesn't change on Kannada while navigating [16:15:09] YuviPanda: was using History to navigate (and not typing in) [16:15:28] hpnadig: what does the title say? [16:15:43] hpnadig: the actionbar title should just say 'search wikipedia' all the time. it's just a search bar [16:16:14] dbrant: so, I'm ok with merging the edit summary patch as is (once siebrand's minor comments are addressed). We'll have Deskana|Away show it to the designers and see what they think? [16:16:35] YuviPanda: excellent; thanks [16:16:53] YuviPanda: it says "India" - probably because I searched for it when on English [16:16:56] that has stayed on [16:17:06] hpnadig: aaah, right. that should've cleared when you navigated to a new page. [16:17:14] YuviPanda: sent you a screenshot. [16:17:20] * hpnadig is off to dinner [16:17:21] hpnadig: can you file a bug? or I can do that for you in a bit [16:17:26] hpnadig: ah, I shall do the filing [16:17:28] hpnadig: thanks for reporting! [16:17:39] dbrant: I'm looking at the find patch now [16:17:42] YuviPanda: no issues. Can help test the app further - just let me know [16:17:57] hpnadig: :D testing for Indian language issues would be helpful. we haven't had anyone do that [16:18:01] hpnadig: get the morelocales app too :) [16:18:45] dbrant: also, modify the commit message to have a single line summary as the first line (like 'implement new edit workflow') and then move current one lines below? commit messages should be a standalone summary in first line, a blank line, adn then rest of message [16:22:51] YuviPanda: can you make those "generic exception handlers" output some stuff to logcat? [16:23:03] that "Could not reach the network" [16:23:14] liangent: ah, hmm. yeah, I will do that. [16:23:25] liangent: file a bug as well? so I don't forget [16:23:46] yeah I was trying to check the cause of https://bugzilla.wikimedia.org/show_bug.cgi?id=66320 [16:24:07] (03PS7) 10Dbrant: Implement new edit workflow. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/139692 [16:24:08] it's still saying "Could not..." for me [16:24:49] (03CR) 10Yuvipanda: [C: 031] "Quite nice!" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/139310 (owner: 10Dr0ptp4kt) [16:25:00] dbrant: another two minor fixes for find in page [16:25:40] 3Wikipedia App / 3Android App: Output error details to logcat in "generic exception" handlers - 10https://bugzilla.wikimedia.org/66728 (10Liangent) 3NEW p:3Unprio s:3normal a:3None For example network errors. [16:25:51] YuviPanda: ^ [16:25:54] liangent: kk ty! [16:26:58] YuviPanda: in Android 4.2.1 this label is translated. Should I open a bug? [16:27:04] aharoni: yes [16:27:19] aharoni: can you also go to 'about' and verify that they are the same version [16:28:49] (03CR) 10Yuvipanda: [C: 032] "Fix the trailing spaces in another commit? Also how did they get there in the first place? :|" (031 comment) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/139692 (owner: 10Dbrant) [16:28:53] dbrant: ^ [16:28:54] :) [16:28:59] dbrant: left some comments as well, however [16:29:01] YuviPanda: Huh?? On the phone it's 2.0-beta-2014-06-12, even though I installed it today. [16:29:03] bearND: heya! [16:29:10] (03Merged) 10jenkins-bot: Implement new edit workflow. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/139692 (owner: 10Dbrant) [16:29:13] aharoni: that was the last release :) [16:29:18] and on the tablet it's 2.0-beta-2014-06-16 [16:29:23] (updated today) [16:29:36] aharoni: oh wait. I forgot we put out a beta yesterday. Thought we had put out only an alpha [16:29:44] aha! [16:29:49] bearND: did we just push out an alpha, or both alpha and beta? [16:29:56] so I guess that I have an alpha on the tablet [16:30:15] YuviPanda: only alpha [16:30:21] ... yes I do. I wrote the version incorrectly. On the tablet it's 2.0-alpha-2014-06-12 [16:30:23] not beta [16:30:42] aharoni: aha! :D that explains :) [16:31:03] YuviPanda: we could do a beta today. i haven't seen any new issues [16:31:18]