[00:01:44] vbamba: your android phone is charged [00:05:19] (03PS2) 10BearND: Updated icons for ToC and overflow menu [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/140249 [00:06:00] dbrant|bbl: vbamba: increased the padding around the action bar icons, will send another apk [00:06:05] ^ [00:11:52] (03PS1) 10Mhurd: Editing workflow simplifications. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/140254 [00:15:23] (03PS1) 10Dbrant: Tweaks to edit workflow. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/140255 [00:18:11] mhurd: coming to retrieve. please do not release to other participants such as moizsyed [00:18:22] vbamba: hahah [00:24:52] (03CR) 10BearND: [C: 032] Tweaks to edit workflow. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/140255 (owner: 10Dbrant) [00:25:16] (03Merged) 10jenkins-bot: Tweaks to edit workflow. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/140255 (owner: 10Dbrant) [00:26:11] dbrant|bbl: ^ merged [00:26:56] mhurd: leaving around 5:45/6 [00:28:25] (03PS3) 10BearND: Updated icons for ToC and overflow menu [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/140249 [00:31:50] tfinc: sounds good [00:40:16] (03PS2) 10Mhurd: Editing workflow simplifications. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/140254 [00:53:25] 3Wikipedia App / 3Android App: Android app duplicates browsing history if same item is tapped - 10https://bugzilla.wikimedia.org/66760 (10Tomasz Finc) 3NEW p:3Unprio s:3normal a:3None #1 Load any article #2 Tap History and select the same article #3 Tap History and note that their are now two instanc... [01:01:12] 3Wikipedia App / 3Android App: Android app shows keyboard on edit tap but doesn't allow editing - 10https://bugzilla.wikimedia.org/66761 (10Tomasz Finc) 3NEW p:3Unprio s:3normal a:3None #1 Load any article #2 Tap edit #3 Start typing Notice how the focus is on the 'W' and no text gets inserted TILL... [01:05:26] kaldari, can you parse the comment at https://gerrit.wikimedia.org/r/#/c/140141/1/includes/api/ApiMobileView.php ? [01:06:58] https://translate.google.com/#pt/en/Que%20bosta%2C%20mudaram%20o%20layout%20da%20wikipedia%20todo%20pra%20tablets.%20Ch-ch-ch-changes. :P [01:08:09] MaxSem: Wow, that is impossible to read :) [01:08:55] MaxSem: I'll reply inline... [01:10:57] (03CR) 10Kaldari: [C: 04-1] Follow redirect for Main Page check if enabled (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/140141 (https://bugzilla.wikimedia.org/66294) (owner: 10Florianschmidtwelzow) [01:12:13] MaxSem: Has anyone said anything good about the redirect? [03:13:34] (03PS1) 10BearND: Fix translation issue: wrong parameter format in Danish [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/140277 [04:27:37] (03CR) 10Florianschmidtwelzow: Follow redirect for Main Page check if enabled (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/140141 (https://bugzilla.wikimedia.org/66294) (owner: 10Florianschmidtwelzow) [06:32:43] (03PS1) 10Yurik: Lower quality image src rewrite for configured carriers [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/140309 [06:32:48] (03PS1) 10BearND: [WIP] Update saved pages [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/140310 [06:39:24] 3MobileFrontend / 3stable: MobileFrontend does not display full page content like the desktop version. - 10https://bugzilla.wikimedia.org/66747#c3 (10deanator71) Maybe we should add an option in the mobile view to display full content without having to go to the desktop view. I can see that the MediaWiki ho... [09:14:41] 3MobileFrontend / 3stable: mobile table of contents icon needs to be flipped for RTL - 10https://bugzilla.wikimedia.org/66771 (10Amir E. Aharoni) 3NEW p:3Unprio s:3normal a:3None Mobile table of contents icon needs to be flipped for RTL. I tried to quickly fix it with the usual -ltr autoflip trick,... [09:15:04] (03PS1) 10Amire80: Flip the table of contents icon for RTL [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/140321 (https://bugzilla.wikimedia.org/66771) [09:15:22] 3MobileFrontend / 3stable: mobile table of contents icon needs to be flipped for RTL - 10https://bugzilla.wikimedia.org/66771#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/RUZEM1q8 [09:15:37] (03CR) 10Amire80: [C: 04-1] "-1 because it doesn't actually work, but I'm probably doing something incorrectly with LESS." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/140321 (https://bugzilla.wikimedia.org/66771) (owner: 10Amire80) [09:18:09] 3MobileFrontend / 3stable: mobile table of contents icon needs to be flipped for RTL - 10https://bugzilla.wikimedia.org/66771 (10Amir E. Aharoni) [09:19:22] (03CR) 10Amire80: "It's possible that this code is theoretically correct, but doesn't actually work because of bug 66091 (although I might be wrong about tha" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/140321 (https://bugzilla.wikimedia.org/66771) (owner: 10Amire80) [09:59:19] 3MobileFrontend / 3Feature requests: Links to talk pages in mobile view - 10https://bugzilla.wikimedia.org/52165#c8 (10Andre Klapper) The interwebs says "If you opt into the beta site (visit Settings in the left navigation menu and tap to opt into Beta), you'll also see a talk page feature". [10:17:48] (03PS2) 10Florianschmidtwelzow: Follow redirect for Main Page check if enabled [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/140141 (https://bugzilla.wikimedia.org/66294) [11:14:03] 3Wikipedia App / 3Android App: Android app shows keyboard on edit tap but doesn't allow editing - 10https://bugzilla.wikimedia.org/66761#c1 (10Sage Ross) Good catch. Maybe the solution is that the keyboard doesn't pop up until you tap within the edit field. Users are only occasionally going to want to start... [11:50:32] (03CR) 10Yuvipanda: [C: 032] Fix translation issue: wrong parameter format in Danish [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/140277 (owner: 10BearND) [11:51:32] (03Merged) 10jenkins-bot: Fix translation issue: wrong parameter format in Danish [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/140277 (owner: 10BearND) [12:16:32] (03PS2) 10Yuvipanda: Reorder buttons on Find in Page [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/140181 (owner: 10BearND) [12:36:44] (03CR) 10Yuvipanda: [C: 04-1] "Gap between x and edittext is too large." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/140181 (owner: 10BearND) [12:43:55] (03PS2) 10Yuvipanda: Fix ImageUrlMapTest [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/140220 (owner: 10BearND) [12:45:52] (03CR) 10Yuvipanda: [C: 032] Fix ImageUrlMapTest [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/140220 (owner: 10BearND) [12:46:12] (03Merged) 10jenkins-bot: Fix ImageUrlMapTest [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/140220 (owner: 10BearND) [12:46:40] (03PS1) 10Yuvipanda: Revert "Stop playback of media files when leaving page." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/140340 [13:20:12] hallo [13:20:27] there's something that I'm not sure that I understand: [13:20:40] can I use the VE on a tablet? [13:20:44] aharoni: not yet [13:20:53] hi YuviPanda [13:21:02] aharoni: the mobile web team is still workin on it. no concrete date set yet [13:21:06] being developed, but not yet deployed? [13:21:10] aharoni: yea [13:21:14] aharoni: it's in beta, I think [13:21:22] is it available anywhere ? [13:21:30] no matter how broken [13:21:32] aharoni: you can go to settings and turn on 'beta' I think [13:21:33] I'd love to test [13:21:38] I promise to be kind :) [13:21:43] (you know me) [13:21:48] and I don't see it in settings [13:21:50] at least not in Hebrew. [13:22:13] aharoni: no 'beta' or 'experimental' mode? [13:22:15] aharoni: in mobilefrontend settings [13:22:21] aharoni: just turning that on turns on a bunch of features [13:22:27] i have an experimental mode, but not VE [13:22:35] only expand all sections [13:22:41] aharoni: right. just turn on experimental mode, it should enable VE [13:22:48] it's like a 'turn on all the experimental features!' [13:22:49] hmm [13:22:51] let's see [13:23:24] on enwiki I see a banner about a tablet, but not on hewiki [13:23:37] aharoni: yeah, CN. of course, englishwiki is the only wiki... [13:23:38] :P [13:23:46] might have been an oversight or some issue. [13:24:00] heh, what do you know [13:24:09] looks like VE is indeed there [13:24:13] crazy crazy crazy [13:24:21] aharoni: ;) [13:24:24] aharoni: do file bugs [13:25:12] hmm [13:25:27] there's no way to add a heading [13:25:36] == Cats == [13:26:07] aharoni: file bugs! [13:26:18] you can add citations, which looks much more complex, but not headings. It's slightly odd. [13:26:42] I don't think that I need to file it, because it's pretty obvious, but I'm wondering why are citations implemented earlier :) [13:27:09] aharoni: you should file it anyway :) the VE stuff has had limited testing from people in the community [13:27:21] ah well, why not [13:27:30] [ under which component, come to think of it? ] [13:27:43] o i c [13:27:48] like https://bugzilla.wikimedia.org/show_bug.cgi?id=66759 [13:29:22] :) [13:30:16] YuviPanda: now I have a question where you may be able to help. On mobile devices there's the "stick" blinking cursor, and usually also another handle for moving the cursor around more conveniently. Does this thingie have a name? [13:30:48] aharoni: I know what you're talking about, but no, I haven't heard of a name [13:30:50] 'handle'? [13:30:52] maybe [13:30:56] selection handle? [13:31:42] ok :) [13:32:43] YuviPanda: https://bugzilla.wikimedia.org/show_bug.cgi?id=66783 [13:33:01] :) [13:33:02] cool [13:35:21] YuviPanda: three tags: https://en.wikipedia.org/w/index.php?title=Genre_fiction&diff=prev&oldid=613428145 \o/ [13:35:32] aharoni: haha :D [13:51:50] (03CR) 10Ineditable: [C: 031] "Looks like a clean revert to me." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/140340 (owner: 10Yuvipanda) [13:53:10] * YuviPanda waves at dbrant and brion [13:53:38] * dbrant waves back [13:53:56] * brion waves coffee [13:54:02] dbrant: so the audio clearing patch stops *all* audio, not just from our app :) [13:54:43] and because we renamed bookmarks table to savedpages, beta people lost bookmarks they made in the interim [13:54:48] well, 'lost' for some definition of lost [13:55:01] I'm writing a patch to fix the second one and already have a revert lined up for the first [13:55:42] YuviPanda: ah yes :( I'm happy to revert, but I'm just investigating another possible solution [13:56:04] dbrant: sure. we should push out another beta before end of day with at least these two though. [13:56:23] dbrant: I'm going to -2 the revert for now, can remove if the other possible solutions don't work out [13:56:28] YuviPanda: yep. [13:56:56] (03CR) 10Yuvipanda: [C: 04-2] "-2'd while dbrant looks at other potential solutions." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/140340 (owner: 10Yuvipanda) [15:01:16] YuviPanda: around? [15:05:18] matanya2: hey! yes [15:08:28] matanya3: hey? [15:11:13] hi, it seems i hit a bug. when writing an edit summary the edit isn't saved [15:11:35] matanya3: what do you mean? [15:11:35] is that known YuviPanda? [15:11:45] matanya3: if you write an edit summary and hit 'save' on top, it isn't saved? [15:11:50] matanya3: also what version of the app is this? [15:11:53] yes [15:12:03] bets 2 [15:12:15] matanya3: 'bets 2'? [15:12:18] matanya3: beta2? [15:12:37] matanya3: we're currently at beta-2014-06-17, which was released yesterday. do upgrade. the edit workflow has been completely rehauled. [15:14:10] i'll test and report [15:14:29] matanya3: ty [15:15:03] YuviPanda: ok, i'm ready to revert :( it's going to take a lot more investigating. [15:15:12] dbrant: :( ok. let me remove my -2 [15:15:32] YuviPanda: i don't see it on releases [15:15:34] dbrant: got distracted by the paperwork bits (they finally came through! after another tiring travel day today). [15:15:50] YuviPanda: well that's good! [15:15:51] matanya3: gah, haven't put it on releases. need to get the other engineers on the releases group as well. let me push [15:16:19] sorry, i don't use play [15:16:20] (03CR) 10Yuvipanda: Revert "Stop playback of media files when leaving page." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/140340 (owner: 10Yuvipanda) [15:16:24] dbrant: -2 removed [15:16:34] matanya3: no need to be sorry, we should support people who don't want to use play better [15:17:18] (03CR) 10Dbrant: [C: 032] Revert "Stop playback of media files when leaving page." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/140340 (owner: 10Yuvipanda) [15:17:22] dbrant: can you email matanya3 the latest beta apk? I'll get you and bearND access to releases.wikimedia.org soon [15:17:41] YuviPanda: sure thing [15:18:35] brb food [15:19:07] dbrant: feel free to CR bearND's patches when you have the time. I'm pretty drained from the days of running around, so dunno how long I'll be up [15:26:24] (03PS1) 10Dbrant: Hide keyboard when "find next" or "find prev" clicked. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/140384 [15:27:52] YuviPanda|zzz: yay. fixed. though u see other issues now :) [15:28:54] matanya3: do tell! [15:30:51] a bit hard on mobile, will log on a computer later on, will you be around? [15:31:01] if not i'll file bz [15:31:47] i'll be around. but if it's an actual bug, do file in BZ as well [15:33:32] (03PS1) 10Dbrant: Make sure EditText is focused when edit activity starts. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/140388 (https://bugzilla.wikimedia.org/66761) [15:42:40] bearND: is the 'updated icons' patch ready for merge? or are we waiting on designers for anything else (e.g. a different ToC icon (that doesn't look like "sort"))? [15:43:59] dbrant: i want to get at least less black versions of those icons [15:44:14] bearND: agreed... [15:45:58] bearND: I suggested to vibha that we set the opacity in code, since that way we won't need separate icons for disabled and normal states [15:49:29] (03PS4) 10Dbrant: [WIP - test only] Implement syntax highlighting in Edit window. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/137684 [15:54:11] dbrant: bearND I won't make it for today's onboarding discussion [16:18:09] (03CR) 10Dbrant: [C: 032 V: 032] Open page with ampersand in title caused network issues [apps/android/java-mwapi] - 10https://gerrit.wikimedia.org/r/140214 (https://bugzilla.wikimedia.org/66152) (owner: 10BearND) [16:19:34] (03CR) 10Dbrant: [C: 032] Add test for "Open page with ampersand in title caused network issues" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/140216 (https://bugzilla.wikimedia.org/66152) (owner: 10BearND) [16:21:43] YuviPanda: so do you think you could check out what I did wrong with https://gerrit.wikimedia.org/r/140223 [16:23:50] dbrant: sure, will do after I finish up the bookmarks migration patch [16:29:52] YuviPanda: ok, i'm going to set the alpha value for the two buttons in the layout file [16:32:18] bearND: ok! [16:32:35] bearND: we should also set the ToC to just look 'disabled' instead of hidden, I think [16:34:24] YuviPanda: check otrs. fresh crash for you [16:35:21] matanya3: got it! :) [16:35:53] matanya3: this was on RTL, right? [16:36:02] yes [16:36:05] matanya3: ok, cool [16:36:11] matanya3: let me file a bug [16:36:28] matanya3: can you tap the 'W' on the top left, see if that crashes as well? [16:36:39] yes [16:36:49] matanya3: does that crash too? [16:37:15] no. opens the menu [16:39:23] matanya3: hmm, thanks [16:39:46] YuviPanda: also. the read in other lang is wrong alighend [16:39:56] matanya3: the menu item? [16:40:07] matanya3: everything else is properly aligned? [16:40:31] matanya3: RTL support was 'properly' added to the UI in 4.2/4.3 [16:40:33] no. the list of langs is wrong [16:40:36] 3Wikipedia App / 3Android App: Attemptint to open ToC with RTL crashes the app - 10https://bugzilla.wikimedia.org/66794 (10Yuvi Panda) 3NEW p:3Unprio s:3normal a:3None See https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom&TicketID=7613916&OTRSAgentInterface=10a78a14824c0c1c65f77887351... [16:40:59] i'm on 4.4 [16:41:18] matanya3: ah, right. i assume you're on a mobile device? I'll file the bug [16:41:20] 4.4.3 if to be exact [16:41:38] yes. hence so many typos [16:42:05] matanya3: reported both [16:42:21] 3Wikipedia App / 3Android App: Read in other languages activity not properly flipped in RTL view - 10https://bugzilla.wikimedia.org/66795 (10Yuvi Panda) 3NEW p:3Unprio s:3normal a:3None Reported by Matanya. [16:43:52] YuviPanda: what are the icons next to articles in history? [16:44:17] matanya3: the source of the history page. people don't seem to understand them much, so they'll go away soon [16:44:56] the source? what do you meam? [16:46:14] matanya3: it has a 'link' if you opened a page from another link. a'dice' if you opened the page via random. etc [16:46:51] and one more tiny annoying bug. the page flickrs when you stsrt scroling [16:47:02] then it is ok [16:47:21] matanya3: hmm, that I haven't seen :| [16:47:34] sigh [16:47:37] (03PS1) 10Dr0ptp4kt: Lock orientation to portrait mode. [apps/firefox/wikipedia] - 10https://gerrit.wikimedia.org/r/140398 [16:47:48] i'll try to repoduce [16:48:02] matanya3: ok! [16:48:05] yurikR: please review and +2 https://gerrit.wikimedia.org/r/#/c/140398/ [16:48:28] just every page. [16:48:51] open scroll. flickr. start reading [16:49:15] matanya3: hmm, what device is this? [16:49:29] nexus 5 [16:49:55] oh. a new bug. image capition wrong aligen [16:50:12] matanya3: RTL again, I assume? can you send me a screenshot? [16:50:34] yes. to where? [16:50:45] matanya3: yuvipanda@gmail.com [16:51:07] (03PS2) 10Yurik: Lower quality image src rewrite for configured carriers [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/140309 [16:51:10] matanya3: for style issues in the page, can you also check the same page in chrome on the same device, and tell me if it exists there as well? [16:51:28] (03CR) 10Dr0ptp4kt: [C: 032] Lower quality image src rewrite for configured carriers [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/140309 (owner: 10Yurik) [16:51:37] (03Merged) 10jenkins-bot: Lower quality image src rewrite for configured carriers [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/140309 (owner: 10Yurik) [16:51:38] i don't have chrome [16:52:16] matanya3: ah, right. default browser? [16:52:33] matanya3: 'Android browser' I mean [16:54:32] don't have that too [16:54:34] (03PS1) 10Yurik: allow img qty reduction to run on labs [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/140400 [16:54:49] matanya3: err, any browser that uses webkit? [16:55:00] matanya3: the android default browser comes with every android install, no? [16:55:51] (03CR) 10Dr0ptp4kt: [C: 032] allow img qty reduction to run on labs [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/140400 (owner: 10Yurik) [16:55:53] not one you build yourself. send you the mail. [16:56:02] (03Merged) 10jenkins-bot: allow img qty reduction to run on labs [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/140400 (owner: 10Yurik) [16:57:02] matanya3: aaaaaah :D [16:57:11] matanya3: so can you test that on *any* browser you happen to have? [16:57:21] yes. firefox [16:57:32] matanya3: the app shares css exactly with the mobile web, so if you can test both I know if the issue is in the app, or if it is general to both [16:57:58] so the image thing. yes? [16:59:08] (03PS1) 10Yurik: Added type=analyticsconfig to action=zeroportal [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/140401 [16:59:52] (03CR) 10Yurik: [C: 032] "haven't tested but looks ok" [apps/firefox/wikipedia] - 10https://gerrit.wikimedia.org/r/140398 (owner: 10Dr0ptp4kt) [17:00:59] YuviPanda: ok on mobile view. problem in app [17:01:06] matanya3: hmm, ok [17:01:08] matanya3: thanks [17:01:17] (03PS1) 10Yurik: Fixed param type documentation [extensions/JsonConfig] - 10https://gerrit.wikimedia.org/r/140402 [17:03:33] (03PS4) 10BearND: Updated icons for ToC and overflow menu [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/140249 [17:05:03] (03CR) 10Dr0ptp4kt: [C: 032] "In follow up patch, add XML support, as that's broken in this version." [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/140401 (owner: 10Yurik) [17:05:13] (03Merged) 10jenkins-bot: Added type=analyticsconfig to action=zeroportal [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/140401 (owner: 10Yurik) [17:05:34] (03CR) 10Dr0ptp4kt: [C: 032] Fixed param type documentation [extensions/JsonConfig] - 10https://gerrit.wikimedia.org/r/140402 (owner: 10Yurik) [17:05:39] (03Merged) 10jenkins-bot: Fixed param type documentation [extensions/JsonConfig] - 10https://gerrit.wikimedia.org/r/140402 (owner: 10Yurik) [17:06:38] YuviPanda: i also sent you a broken template [17:06:45] matanya3: hmm, ok [17:07:40] that is it for now :) thanks for all the efforts [17:07:48] matanya3: :D thanks for reporting these! [17:11:44] brion: heya! [17:15:27] YuviPanda: I think I've solved the issue with the "Â" character, but it would involve updating the mobile Styles. In which repo would this be located? [17:16:11] dbrant|brb, content styles? MobileFrontend [17:16:29] dbrant|brb: Extension:MobileFrontend, and one in Extension:MobileApp [17:18:35] jgonera: on desktop, at what screen size/resolution do we switch the .m view from tablet view to phone view? [17:18:49] Maryana, on desktop? [17:18:55] yep [17:19:08] uh, we don't have tablet or mobile view on desktop? [17:19:21] if you go to en.m.wikipedia on your computer :) [17:19:22] or you mean using desktop browser? [17:19:25] ok [17:19:38] both dimensions lower than 768px [17:19:46] awesome, thanks [17:19:55] somebody was asking on the enwiki village pump [17:20:00] (browser window size, not screen resolution) [17:20:08] (03CR) 10Yurik: [V: 032] Lock orientation to portrait mode. [apps/firefox/wikipedia] - 10https://gerrit.wikimedia.org/r/140398 (owner: 10Dr0ptp4kt) [17:22:00] jgonera: by both dimensions you mean height/width, right? [17:22:02] just checking [17:22:18] yes [17:22:19] 3Wikipedia App / 3Localization/Translation/Language: RTL bugs in the Wikimedia Mobile Android app (tracking) - 10https://bugzilla.wikimedia.org/34166 (10Andre Klapper) [17:22:19] 3Wikipedia App / 3Android App: Read in other languages activity not properly flipped in RTL view - 10https://bugzilla.wikimedia.org/66795 (10Andre Klapper) [17:25:49] bearND: if you change the params in strings.xml for non-english, you should change them on translatewiki.net as well [17:27:11] (03PS1) 10Dr0ptp4kt: Updating manifest and version number. [apps/firefox/wikipedia] - 10https://gerrit.wikimedia.org/r/140408 [17:27:47] ^ yurikR [17:27:53] YuviPanda: not sure how to do that. I also need to apply for an account there again. ;( [17:28:09] bearND: I'll do it now, but you should get an account there anyway :) [17:29:50] (03CR) 10Yurik: [C: 032 V: 032] Updating manifest and version number. [apps/firefox/wikipedia] - 10https://gerrit.wikimedia.org/r/140408 (owner: 10Dr0ptp4kt) [17:31:53] bearND: updated [17:32:10] bearND: which icons are you not happy with? [17:32:39] YuviPanda: the three circles, and the ToC looking like sort [17:32:42] Maryana, is office overcrowded today? [17:32:50] no, it's not too bad [17:32:53] YuviPanda: but at least they are not blurry [17:32:59] i think a bunch of people are working from SPUR [17:33:06] bearND: yeah, I didn't realize that it was three squares. the second square is even concave on both sides. [17:33:23] bearND: I'm ok with leaving the three things as is, since the circles also feel weird considering t here aren't any roundy things in the app mostly otherwise [17:33:35] bearND: check with dbrant|brb too. [17:33:47] YuviPanda: the three squares is the Android default for overflow [17:33:54] bearND: yeah. [17:35:00] bearND: how about we keep the three squares, and just change the ToC? [17:37:58] YuviPanda: Would work for me. Would need to check with Vibha though [17:38:03] brion: hey i have an idea for the image cleanup code… have a sec to chat? [17:38:17] Sure [17:38:50] brion: on android, we have a folder structure, with the page being stored as json in the folder. so when we have to delete all images, we just delete the entire folder! :) [17:39:03] Handy! [17:39:33] We could change the db structure to store duplicates perhaps and let the delete cascade deal with it similarly [17:39:34] brion: yea [17:41:29] dr0ptp4kt: sos? [17:41:32] brion: so i was thinking we could de-couple the cleanup stuff from the history view controller, move it into a “housekeeping” obj which would be called periodically - say at most once every 24 hrs. all it would do is loop through all core data image objects, calling the code you wrote for checking if an image was references by any sectionImage records. it wouldn’t need to even touch an article record this way. [17:41:49] Mhurd nice [17:42:31] brion: want me to do quick patch to free up time for you to review that last big patch? ;) [17:42:42] Sure [17:43:05] brion: k will do [17:44:54] YuviPanda: i like the folder structure :) the re-downloading all images just to save a page… not so much ;) [17:45:53] awjr: sorry, this meeting overlaps with our deploiyment [17:46:27] awjr: image quality reduction /capability/ is deployed, and we have it turned on for our test configuration which has a small set of ips. that's all [17:48:39] mhurd: heh. saved pages is a stupid feature anyway :) [17:48:45] * YuviPanda hopes still one day it can be killed, but probably not [17:48:52] YuviPanda: hehe ya [17:52:28] I kinda like having offline bits... But it is something we can outsource to browser or offline dedicated apps [17:52:33] (03PS1) 10Dbrant: Set charset to UTF-8 when loading styles. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/140418 (https://bugzilla.wikimedia.org/66187) [17:53:52] Ooh amazon is releasing the "fire phone" [17:54:53] (03PS2) 10Dbrant: Set charset to UTF-8 when loading styles. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/140418 (https://bugzilla.wikimedia.org/66187) [17:55:24] Leading feature: brightest screen for outdoor reading :) [18:02:13] bearND: android based, I presume [18:02:53] YuviPanda: what is android based? [18:03:05] bearND: the new amazon phone [18:03:07] oh, i guess you mean brion [18:03:08] bearND: http://live.theverge.com/amazon-phone-liveblog/ [18:03:13] gah, I meant brion [18:03:18] heh [18:03:42] YuviPanda: yeah looks like it’s related to their kindle fire tablet android fork [18:03:48] brion: yeah. [18:04:06] so if we get in the amazon store we should appear on that phone too i think [18:04:34] but i’ll check the sdk docs when they’re out [18:04:57] brion: yeah. I also want us to think long and hard before going on the amazon store, since that'll also need to keep getting updated [18:05:04] heh [18:05:07] well i think the old app is on it [18:05:09] isn’t it? [18:05:42] brion: oh, not sure [18:06:16] http://www.amazon.com/Wikimedia-Foundation-Wikipedia/dp/B0088P2A7A :D [18:06:25] brion: right. we'll need to update that as well [18:06:32] or else kill it ;) [18:06:57] (03PS2) 10Dbrant: Don't show keyboard until user places cursor in Edit window. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/140388 (https://bugzilla.wikimedia.org/64077) [18:07:35] ooh they have some kind of google goggles-like app too, takes you to amazon store entries of things you photograph for ‘comparison shopping’ :D [18:08:01] yeah this device exists solely to get people to buy things from amazon :D [18:09:06] brion: it'll be an interesting future, with more android forks [18:09:42] i don’t mind the forks as much as i mind 50 different app stores [18:09:56] brion: heh [18:10:39] brion: such consumerism. [18:14:40] (03PS3) 10Brion VIBBER: Editing workflow simplifications. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/140254 (owner: 10Mhurd) [18:14:44] (rebase) [18:14:50] brion: cool [18:15:10] brion: clean rebase? [18:15:20] yeah [18:15:24] brion: yay [18:15:25] now let’s test :D [18:15:29] brion: :) [18:16:17] ooh, fire phone will have an SDK for the computer vision lookup thing [18:16:31] if we integrate that we could do a wikipedia search-by-photo :D [18:16:56] brion: IT’S THE FUTURE!!!! [18:17:14] now they just need a competitor with Google Glass [18:17:18] “one-glance ordering” [18:22:32] mhurd: so there’s no longer anything to direct people to log in if they’re editing when logged out, right? [18:22:41] (because we mean the intro screen to encourage a login instead) [18:23:01] brion: oh, i’ll be re-adding that when i update the license copy [18:23:07] ah ok [18:23:16] brion: patch later today for that if that’s ok [18:23:48] ok [18:24:37] mhurd: “Other ways you improved the ar…” gets cut off if you go into the ‘other’ summary mode [18:24:41] brion: it’s small, but on the mock here https://trello-attachments.s3.amazonaws.com/52e98a603e6d08a53861025b/531799dfc55d38b46d5cddba/5992x4208/200b92c873bd852b6c34da991aa3c6f7/Editing_MVP_June12.png you can see the tiny “Log in” link in the CC license copy in the 4th image from the left [18:24:55] brion: oh on ios6? [18:25:06] mhurd: no on ios 7, iphone 5s [18:25:21] brion: checking... [18:25:27] mhurd: perhaps it fit when it said “page” but was changed to “article”? [18:25:32] in either case, in other languages it would not fit [18:25:46] brion: should wrap in either case… investigating [18:25:51] ok [18:26:31] brion: oh was this in the modal that appears when you tap other? [18:26:59] mhurd: yeah [18:27:09] brion: ah! i see. easy fix [18:27:17] brion: I think we must integrate this functionality into the app soon http://thinkprogress.org/economy/2014/06/18/3450334/yo-app-tech-bubble/ [18:27:22] brion: want now or separately? [18:27:31] tapping the 'CC-BY-SA 3.0' link does nothing too, is that coming later? [18:27:48] brion: ya [18:28:33] ok [18:29:54] (03CR) 10Brion VIBBER: "Notes from testing & irc:" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/140254 (owner: 10Mhurd) [18:32:31] mhurd: ok other than those,nothing standing out as super scary :D [18:32:32] lemme merge [18:32:40] brion: cool! :) thanks! [18:32:49] (03CR) 10Brion VIBBER: [C: 032 V: 032] "note: fixes coming soon for the issues noted above" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/140254 (owner: 10Mhurd) [18:33:49] 3Wikipedia App / 3Generic: RTL support in page body in the app (language variant issues) - 10https://bugzilla.wikimedia.org/64420#c13 (10Dan Garry) 5PATC>3RESO/FIX The patch was merged so this should be fixed. [18:35:07] so the other main feature of the fire phone seems to be some sort of head tracker perspective thingy. this will drive people who hate the slight perspective tilt on ios backgrounds insane i suspect :) [18:36:40] (03PS1) 10Dbrant: Fix crash when opening ToC in RTL environment. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/140433 (https://bugzilla.wikimedia.org/66794) [18:37:03] (03PS1) 10Yuvipanda: Add FIXME about foreground thread operations [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/140434 [18:37:05] (03PS1) 10Yuvipanda: Migrate Bookmarks into Saved Pages [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/140435 [18:37:22] dbrant: ^ [18:37:26] fixing the FIXME now [18:40:16] wtf. the head tracking works by adding *four forward-facing wide-angle cameras* to the phone, figuring you’ll only obscure one or two cameras at a time with your hands [18:40:47] wow and i thought the kinect watching me was creepy [18:40:48] 3MobileFrontend / 3stable: MobileFrontend does not display full page content like the desktop version. - 10https://bugzilla.wikimedia.org/66747#c4 (10Ryan Kaldari) 5UNCO>3RESO/INV I don't think displaying the full content on mobile really makes sense. Take a page like https://en.wikipedia.org/wiki/Domest... [18:42:49] 3Wikipedia App / 3Generic: RTL support in page body in the app (language variant issues) - 10https://bugzilla.wikimedia.org/64420#c14 (10Liangent) 5RESO/FIX>3REOP It seems this bug has been hijacked with the ar issue which got resolved, but the original problem (content handler and language converter) is... [18:44:43] dbrant|brb: doing CR on your patches now [18:46:45] (03CR) 10Yuvipanda: [C: 032] Fix crash when opening ToC in RTL environment. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/140433 (https://bugzilla.wikimedia.org/66794) (owner: 10Dbrant) [18:47:13] (03Merged) 10jenkins-bot: Fix crash when opening ToC in RTL environment. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/140433 (https://bugzilla.wikimedia.org/66794) (owner: 10Dbrant) [18:47:20] (03CR) 10Yuvipanda: [C: 032] "Untested, but looks good :)" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/140418 (https://bugzilla.wikimedia.org/66187) (owner: 10Dbrant) [18:47:46] (03Merged) 10jenkins-bot: Set charset to UTF-8 when loading styles. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/140418 (https://bugzilla.wikimedia.org/66187) (owner: 10Dbrant) [18:48:24] (03PS3) 10Yuvipanda: Don't show keyboard until user places cursor in Edit window. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/140388 (https://bugzilla.wikimedia.org/64077) (owner: 10Dbrant) [18:49:30] heh amazon’s developer site is down i think [18:50:27] dbrant|brb: bearND why can't I drag from left/right edge to open the drawers? [18:51:06] (03CR) 10Yuvipanda: [C: 032] Don't show keyboard until user places cursor in Edit window. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/140388 (https://bugzilla.wikimedia.org/64077) (owner: 10Dbrant) [18:51:23] (03PS2) 10Yuvipanda: Hide keyboard when "find next" or "find prev" clicked. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/140384 (owner: 10Dbrant) [18:51:31] (03Merged) 10jenkins-bot: Don't show keyboard until user places cursor in Edit window. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/140388 (https://bugzilla.wikimedia.org/64077) (owner: 10Dbrant) [18:51:49] YuviPanda: i'm able to open the drawers... [18:52:03] dbrant: hmm, maybe issues with my phone [18:52:11] YuviPanda: yes, works for e as well. [18:52:16] me [18:52:18] YuviPanda: that logic certainly hasn't changed [18:52:31] dbrant: yeah, I checked that. I turned my screen off and on and works now [18:52:37] so ignore, just my phone being inconsistent. [18:52:43] it's been behaving oddly for a while now anyway [18:53:16] rumors correct; fire phone is an AT&T exclusive. boooooo [18:56:18] brion: heh. 'rest of the world? what do you mean, "world"?' [18:57:02] wouldn’t surprise me at all if the initial version is US-only [18:57:06] > This phone shines a secret light at your face at all times and lets you buy anything you can see and always knows where your head is at. [18:57:13] hehe [18:57:17] > "Yes I agree this is a little creepy," Bezos says. But I can't hear him, I'm in the fetal position on the floor. [18:57:23] dbrant: thanks for taking care of https://bugzilla.wikimedia.org/show_bug.cgi?id=64077 [18:57:38] tfinc: you bet! [18:59:12] (03PS1) 10Dbrant: Make the CC icon noflip (for RTL environment). [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/140441 [18:59:42] (03CR) 10Yuvipanda: [C: 032] Hide keyboard when "find next" or "find prev" clicked. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/140384 (owner: 10Dbrant) [18:59:52] (03PS2) 10Yuvipanda: Make the CC icon noflip (for RTL environment). [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/140441 (owner: 10Dbrant) [19:00:03] (03Merged) 10jenkins-bot: Hide keyboard when "find next" or "find prev" clicked. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/140384 (owner: 10Dbrant) [19:00:24] (03PS3) 10Yuvipanda: Make the CC icon noflip (for RTL environment). [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/140441 (owner: 10Dbrant) [19:00:39] (03CR) 10Yuvipanda: "why the changes to just the xhdpi and xxhdpi normal icons?" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/140441 (owner: 10Dbrant) [19:02:31] (03CR) 10Dbrant: "not sure... I re-ran the script on them on a different computer than before, and I guess the binary output was slightly different for thos" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/140441 (owner: 10Dbrant) [19:02:55] product page for fire phone now up: http://www.amazon.com/dp/B00EOE0WKQ [19:02:56] (03CR) 10Yuvipanda: [C: 032] "Fair enough." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/140441 (owner: 10Dbrant) [19:03:17] (03Merged) 10jenkins-bot: Make the CC icon noflip (for RTL environment). [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/140441 (owner: 10Dbrant) [19:04:02] interesting, they did not go 1080p, it’s a 720p display [19:04:42] (03CR) 10Yuvipanda: [C: 04-1] "BearND wants to keep the three squares as overflow to be consistent with rest of android. I think that makes sense." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/140249 (owner: 10BearND) [19:10:31] (03PS2) 10Yuvipanda: Migrate Bookmarks into Saved Pages [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/140435 [19:10:33] (03PS1) 10Yuvipanda: Perform data migrations in a background thread [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/140444 [19:10:37] (03CR) 10jenkins-bot: [V: 04-1] Perform data migrations in a background thread [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/140444 (owner: 10Yuvipanda) [19:10:41] (03Abandoned) 10Yuvipanda: Add FIXME about foreground thread operations [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/140434 (owner: 10Yuvipanda) [19:11:19] (03CR) 10Yuvipanda: "Jenkins is wrong" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/140444 (owner: 10Yuvipanda) [19:12:07] dbrant: bearND I've some patches up. I think I'll go to sleep now. [19:12:20] can either of you make an alpha / beta release once the savedpages/bookmarks patches are done? [19:14:39] lunch…. bbiab [19:15:03] dbrant: bearND I'm heading off now. too drained. [19:15:05] cya guys! [19:15:11] YuviPanda: later!! [19:15:47] dbrant: cya. even if we end up not doing a beta, we should at least do an alpha (and get a build to Deskana|Away) [19:15:55] YuviPanda: will do [19:20:57] bearND: hey [19:21:11] moizsyed: dbrant: https://developers.google.com/live/shows/6727337534029824 [19:24:23] tfinc: hey! I emailed you about post-wikimania UK dates. do check. [19:24:35] YuviPanda: i saw. will do [19:24:41] tfinc: ok. thanks! [19:26:51] dbrant: The alpha build you sent across yesterday does not have the updated icons. Is that right? [19:28:20] vbamba: the icons haven't been merged. bearND had some concerns, he responded in email. [19:28:51] vbamba: also we're considering letting the overflow icon be just the three squares, to be consistent with the rest of android. the circles do look a bit out of place, since there are no circles elsewhere in the app (or even major curves) [19:29:05] vbamba: also the ToC icon looks almost exactly the same as the standard android icon for sort [19:29:31] Jared and @violetto want things to be consistent with the wikifont [19:29:33] YuviPanda: vbamba: i need to update the patch again, also because it included changes to the cc icon (i don't want to overwrite dbrant's) [19:29:37] We may have to log these issues into wikifont [19:29:59] vbamba: sure, but we have to be consistent within android as well. Android user isn't going to switch daily between the android app and the iOS app, for example. [19:30:18] No I agree, But Android Users will also use Desktop. [19:30:37] (03CR) 10MaxSem: [C: 032] Follow redirect for Main Page check if enabled [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/140141 (https://bugzilla.wikimedia.org/66294) (owner: 10Florianschmidtwelzow) [19:30:41] We are pretty consistent with the interaction models that are native to Android [19:31:07] vbamba: indeed, so we should be here too, no? but I think the bigger problem is that the ToC icon is the same as the standard 'sort' icon [19:31:18] (03Merged) 10jenkins-bot: Follow redirect for Main Page check if enabled [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/140141 (https://bugzilla.wikimedia.org/66294) (owner: 10Florianschmidtwelzow) [19:31:27] vbamba: i had not seen the three circles in desktop. where does is show up? [19:31:51] vbamba: I also looked around, no other app seems to replace the overflow icon. [19:31:56] bearND: the more icon is eventually going to be the 3 circles everywhere [19:32:18] Look at the default play music app [19:32:30] @YuviPanda they use 3 circles for menu's [19:32:30] (03PS2) 10Yuvipanda: Perform data migrations in a background thread [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/140444 [19:32:36] and thats a native google app for android [19:33:10] vbamba: right, I had missed that :) but do look at *all* the other apps. [19:33:33] vbamba: but as I said, the *bigger* problem, is that the ToC icon is almost the same as what android by default uses for 'sort' [19:34:07] vbamba: what's the problem with using the three squares that comes by default with android? [19:34:15] The Google Play Store also uses 3 circles for overflow [19:34:36] @YuviPanda there isnt a problem, but when you guys switch to Wikifont, the visuals of the icons will change. [19:34:40] that will be confusing for users [19:35:01] The whole point of having a wikifont is that we have consistent visual language. [19:35:13] Unless you never plan to use Wikifont. Is that the case? [19:35:20] vbamba: are you saying that switching icons when you switch from android to iOS or from Android to Desktop is more important than confusing visuals when you switch from one app in your current device to another in your current device? [19:35:29] vbamba: currently we have no plans to use wikifont, no. [19:35:57] vbamba: the two google apps you mentioned have them in the cards only. i don't see an overflow in the action bar. [19:36:43] YuviPanda: I dont think it will confuse anyone [19:36:45] vbamba: let's not break consistency from inside android for consistency with a future desktop? [19:36:59] (03PS1) 10Kaldari: Restoring override param to SkinMinerva::getTermsLink() [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/140448 [19:37:00] vbamba: I also don't think it'll confuse anyone if they see three squares on Android and three circles on desktop [19:38:18] I can't add icons without them being in Wikifont. [19:38:27] You have to understand that the team is trying to build one set of icons [19:38:39] MaxSem: https://gerrit.wikimedia.org/r/#/c/140448/ [19:38:47] vbamba: I'm saying we don't need a custom icon there. [19:39:18] 3MobileFrontend / 3General/Unknown: action=mobileview does not apply Main page transformation when requesting page that redirects to Main page - 10https://bugzilla.wikimedia.org/66294 (10Florian) 5PATC>3RESO/FIX [19:39:19] (03CR) 10MaxSem: [C: 032] Restoring override param to SkinMinerva::getTermsLink() [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/140448 (owner: 10Kaldari) [19:39:21] vbamba: and also that consistency within android is more important than consistentcy across devices. [19:39:55] (03Merged) 10jenkins-bot: Restoring override param to SkinMinerva::getTermsLink() [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/140448 (owner: 10Kaldari) [19:40:34] Its fine by me, If violetto or jared have any questions, Ill send them your way :) [19:40:42] vbamba: ty :) [19:40:52] vbamba: also, I'm removing the small icons by the side of the history items as you asked :) [19:41:12] I dont remember asking for that [19:41:21] One Minute [19:41:21] vbamba: not the thumbnails [19:41:25] Lets sort action bar first [19:41:29] vbamba: the tiny ones that show how the user got to that page. [19:41:37] vbamba: you asked me over hangout the last time we hung out. [19:41:42] vbamba: ok. [19:41:46] First Action Bar !!! [19:41:52] I cant handle so many async conversations [19:42:04] hehe [19:42:05] ok [19:42:46] @YuviPanda the TOC icon is a problem also? [19:43:00] vbamba: so, that is the standard 'sort' icon on android [19:43:10] vbamba: but we use it to mean something else other than sort [19:43:17] vbamba: so that might be confusing. [19:43:32] YuviPanda: about to mail ops about +2. is it mostly so that you can review other peoples code ? i imagine they would frown on you self merging [19:44:12] tfinc: no, ops is completely the opposite. you're mostly ok self-merging. ori has rights only to self merge, for example - can't merge other people's code [19:44:32] tfinc: primarily, I want +2 on all labs related stuff, and that's it. I'll follow ops conventions for merging/review, which I'm already fairly well versed in [19:44:58] makes sense [19:45:04] tfinc: cool. thanks :) [19:45:24] @YuviPanda what area do you see a similar sort icon in? [19:46:30] vbamba: so that's the thing. it's present in https://developer.android.com/design/downloads/index.html as the standard sort icon, but I've seen it be used in only one place so far (ebook reader) [19:47:31] bearND: ^ [19:48:23] (03PS3) 10Jdlrobson: Emit events after delay to support chaining [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/137734 (https://bugzilla.wikimedia.org/65633) [19:48:23] Ive looked at 6 apps. I cant see it anywhere [19:48:33] Music, Movies, Email, Store ... [19:49:01] vbamba: yeah, me neither. I'm ok with ignoring its meaning as sort if bearND is ok with it. [19:49:12] (03CR) 10Yuvipanda: "So vibha is ok with us just using android standard overflow icon (yay!), so that needs to be removed. Discussion going on about toc/sort i" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/140249 (owner: 10BearND) [19:49:56] (03CR) 10jenkins-bot: [V: 04-1] Emit events after delay to support chaining [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/137734 (https://bugzilla.wikimedia.org/65633) (owner: 10Jdlrobson) [19:50:06] Unless you can show me frequent usage of the Android Default, I cant offer deviation from the wikifont in this case. [19:50:19] vbamba: yeah, I think I'll agree with you here. [19:50:27] The TOC as a concept is going to spread (virally) to mobile web and desktop. [19:50:39] :) [19:50:45] Hence, Visual Metaphor is important [19:50:45] vbamba: :) [19:51:15] vbamba: I think using things from wikifont in cases where there's no equivalent widely recognized android icon makes sense. [19:51:31] But, What I can do is ask May to look at this standard and see if we want to differentiate the wikifont icon itself ( just a tad ) [19:52:05] vbamba: cool :) that'll be nice too. [19:52:10] * tfinc_ applauds you both for agreeing [19:52:20] @YuviPanda @bearND @dbrant|brb - So no icons for anything that exists by default in Android. [19:52:35] Delete etc will be used from action bar defaults. [19:52:43] awjr|lunch: are we still on for 3pm? [19:52:59] vbamba: no icons when there's a direct match, I think. [19:54:23] YuviPanda: vbamba: yay for overflow! Thank you! I'll keep using the refresh icon from the Android default set as well then. [19:54:35] YuviPanda: there may be some follow up on this with jared Zimmerman (The Big Boss) [19:54:42] vbamba: sure. [19:55:05] bearND: can you merge the TOC please? [19:55:25] and send the ap in email. [19:55:52] tfinc_: just fixed my installation issues. Im twice as smart (Installation wise) [19:56:17] vbamba: i'll push another patch set to gerrit and send you the apk [19:56:59] vbamba: dbrant|brb can CR and merge to master. don't want to self-merge this one [19:57:01] actually dbrant|brb hasnt provided the whitespace fix [19:57:12] ya, lets wait on him. [19:57:19] tfinc yeah :) [19:57:31] bearND: looks like my sleepiness is gone for a bit :) I'll be around for 20-30m if you want me to merge as well [19:58:15] Is dbrant|brb trying to get away with reduced whitespace? That won't work. We may be nice occasionally about icons but whitespace is serious stuff. [19:58:23] tfinc you'll just have to pretend the mess isn't there :p [19:58:24] YuviPanda: dbrant|brb bearND, what's stopping you guys from signing the builds you send to designers? having to install/uninstall relative to market wastes time [19:58:43] tfinc_: it's an extra step, that's pretty much it. [19:58:58] vbamba: the increase whitespace change got merged yesterday, I think. [19:59:01] vbamba: just no build yet. [19:59:08] vbamba: yeah, it got merged yesterday. [19:59:13] yo [19:59:21] tfinc: I signed with the official cert I sent off yesterday [19:59:27] YuviPanda: why not just release it through the alpha builds ? too slow ? [19:59:35] thanks bearND [19:59:40] brion: yo [19:59:42] tfinc: that's what we usually do, but I think the apk bearND sent were of unmerged patches. [20:00:08] tfinc: it takes a couple of hours to be live, and we probably want vbamba some chance to review first [20:00:12] brion: talk to me about the Back-backlog on https://trello.com/b/h0B6QYBo/mobile-app-backlog. i'm eager to see if we can move it somewhere else but i'd like to know how your using it [20:00:26] tfinc: YuviPanda is right. those changes were not merged yet [20:00:30] tfinc: that’s “cool ideas that are TOTALLY BLOCKED right now” :D [20:00:43] if nobody’s interested i can move them to a private list and reintroduce them down the line [20:00:57] brion: are you ok moving that to separate board ? [20:01:03] sure [20:01:05] it'll makes Deskana|Away life easier [20:01:07] make* [20:01:09] yeah lemme do that now [20:01:10] thank you [20:02:04] brion: if their ready for consideration then do move them to In-analysis but if their crazy blocked then we should separate them [20:02:06] thanks [20:02:42] ok moved em [20:02:51] yeah that’s why i didn’t mix them in the main backlog column [20:03:34] 3Wikipedia App / 3Android App: Cannot edit MediaWiki:Common.css - 10https://bugzilla.wikimedia.org/66320#c3 (10Max Semenik) Yes it works - just checked that mobileview correctly returns that it can edit MediaWiki: NS pages from my staff account. [20:03:39] YuviPanda, ^^^ [20:04:15] MaxSem: hmm, so problem is in the app. [20:04:19] brion: what's left on https://trello.com/c/Afq8I3Ly/32-3-complete-implementation-of-event-logging-calls ? [20:04:30] MaxSem: I'll investigate... at some point in the future. editing Mediawiki:Common.css from the app doesn't sound like the best of ideas anyway [20:04:35] mhurd: how is styling and onboarding going ? [20:05:10] tfinc: just the couple bits remaining in the checklist i think; sync-up for things that changed during the implementation on the android side [20:05:20] (03PS5) 10BearND: Updated icons for ToC [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/140249 [20:06:26] brion: given that its wed and we have only two more days in this sprint is there anything else on your plate that is taking attention away from this? [20:06:50] bearND: testing it now, but the commit message seems half-missing? second line only has ic_toc [20:07:05] tfinc: no i should be able to finish it up today, just need to avoid distractions [20:07:49] jdlrobson, is there a bug for security/performance review for Mantle? [20:07:53] YuviPanda: i'll remove that line. [20:07:54] mhurd: ya can we get some candy and little build with it? [20:08:23] (03PS6) 10BearND: Updated icons for ToC [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/140249 [20:08:36] YuviPanda: ^ just changed commit message [20:09:22] brion: please send distraction my way so that i can squash them [20:09:33] i shall do :D [20:09:49] jgonera: spagewmf is doing that https://trello.com/c/lYSKDtdX/139-bug-63445-get-lightncandy-and-handlebars-through-security-audit and https://trello.com/c/0frWBknD/203-b-deploy-front-end-rewrite [20:10:09] brion: there are a number of other stories that we'd like to get to in the todo column of https://trello.com/b/KNqImlQo/mobile-app-sprint-33-the-final-android-countdown and i want to make sure nothing else gets in your way [20:10:42] (03CR) 10Yuvipanda: [C: 032] Updated icons for ToC [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/140249 (owner: 10BearND) [20:10:58] *nod* [20:11:02] bearND: done. [20:11:04] (03Merged) 10jenkins-bot: Updated icons for ToC [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/140249 (owner: 10BearND) [20:11:06] tfinc: coming along :) [20:11:11] vbamba: soon :) [20:13:31] YuviPanda: :) [20:14:01] tfinc: ok i’ll try and keep distractions clear the next couple of days and power through some more of those cards [20:14:04] ios 8 can wait :) [20:14:38] in fact let me hide those machines fo rnow so i’m not tempted [20:20:54] brion: heh :) [20:41:30] bearND: dbrant CR for my bookmarks patches? :) [20:43:08] YuviPanda: on it. any ideas how to do RefreshSavedPageTask properly in https://gerrit.wikimedia.org/r/#/c/140310/? [20:43:17] bearND: looking [20:43:43] bearND: // or get all from adapter and reuse RefreshSavedPageTask? [20:43:49] bearND: ^ is the right way to go, I think. [20:44:09] bearND: much easier than spawning multiple asynctasks from one [20:44:54] YuviPanda: that comment was for how to do all saved pages. I'm still having issues with even a single saved page [20:45:02] bearND: oh? [20:45:28] YuviPanda: need to exec SectionFetch("all"), and once that returns invoke the SavePageTask [20:46:07] bearND: right. might have to refactor LeadSectionFetchTask a bit to make its modifications easier, perhaps [20:46:08] YuviPanda: when i run it it crashes [20:46:55] YuviPanda: have to select a single one and hit refresh. the all saved pages is just a skeleton right now [20:47:21] bearND: hmm, right. [20:47:27] YuviPanda: This would be great with a jobqueue [20:47:35] (03PS1) 10Mhurd: Periodically remove old / unused article and associated data. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/140564 [20:47:52] brion: have a sec to look over ^ ? [20:48:01] bearND: we already have a jobqueue of sorts, no? [20:48:15] bearND: if you make a saneasynctask with SINGLE_THREAAD it is fully serialized, and pretty much a 'job queue' [20:49:00] brion: it should be all decoupled now. had to fiddle with a couple things to ensure everything went away when it should [20:49:32] bearND: I think I have to sleep now, but I'll take a poke at doing a new PS if you don't get to it by then :) [20:49:36] bearND: might need some refactoring [20:50:02] YuviPanda: ok. Thanks for your help. Good night. :) [20:50:09] bearND: :) [20:50:35] bearND: dbrant do an alpha/beta update today even if the bookmarks changes don't get merged, but hopefully they do - atleast 3 people complained when I looked many hours ago... [20:51:13] YuviPanda: did you ever get the beta branch ironed out? [20:51:26] bearND: dbrant gah, nope. didn't get to it [20:51:34] I'll poke tomorrow, I swear! [20:51:46] bearND: I also left minor comments on your re-arrange icons in find in page patch [20:52:03] YuviPanda: looking at bookmarks now... [20:52:09] YuviPanda: i can do an alpha easily. need to check with dbrant later what the issue was [20:53:34] (03CR) 10Jdlrobson: [C: 04-1] "It used to work, so something changed. I suspect something else is going wrong here. The first run is meant to take a long time as it need" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/140233 (owner: 10Cmcmahon) [20:55:49] brion: oh crap, there’s a merge conflict - amending [20:56:52] jgonera: http://etherpad.wikimedia.org/p/Alpha-beta_cleaning [20:58:15] Maryana, https://www.mediawiki.org/wiki/Mobile/Release_history [20:59:52] * YuviPanda goes to sleep [21:01:43] dbrant: cool. if you're looking at bookmarks then I don't have to test it. The code looks fine to me. I still think it would be good to get another patch in to guard this with a SharedPreference so we only do it once, and possibly move all this to a background thread [21:04:12] Maryana: jgonera im ready in the hangout when you are [21:04:53] MaxSem: http://etherpad.wikimedia.org/p/Alpha-beta_cleaning [21:07:17] (03CR) 10Cmcmahon: "If by "work" you mean "not time out", yes, the 90-second timeout is new, it's the default timeout provided by SauceLabs." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/140233 (owner: 10Cmcmahon) [21:09:22] jdlrobson: i know you care about this a lot - http://etherpad.wikimedia.org/p/Alpha-beta_cleaning [21:11:48] (03Abandoned) 10Mhurd: Periodically remove old / unused article and associated data. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/140564 (owner: 10Mhurd) [21:12:12] (03PS1) 10Mhurd: Periodically remove old / unused article and associated data. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/140572 [21:12:49] brion: updated to remove merge conflict ^ [21:18:42] (03CR) 10Dbrant: [C: 032] Migrate Bookmarks into Saved Pages [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/140435 (owner: 10Yuvipanda) [21:20:39] dr0ptp4kt, all is quiet? [21:20:55] yurikR: yeah [21:24:03] (03CR) 10Dbrant: [C: 032] Perform data migrations in a background thread [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/140444 (owner: 10Yuvipanda) [21:26:04] bearND: will you do alpha release? [21:26:44] dbrant: will do. what was the issue with beta? [21:27:23] jdlrobson, do we still show an edit guider if someone logs in from the left nav? [21:27:44] jgonera: you'll have to check the code i have no idea [21:28:06] bearND: lol I really don't know... I thought I renamed/merged everything correctly, and I was even able to push it to Gerrit, but then Jenkins rejected it. [21:28:19] bearND: and I started crying. [21:29:20] dbrant: ah, Yuvi already had a patch for moving this to the background. :) [21:29:29] bearND: right! [21:29:32] dbrant: what do you usually do for beta? [21:30:16] bearND: so, Yuvi had originally made a patch (on master) for the beta build: https://gerrit.wikimedia.org/r/137311 [21:31:11] bearND: we were supposed to push additional patch-sets onto that patch, and continually rebase it against master. [21:31:48] dbrant: he also created a branch for beta though (origin/beta) [21:32:54] bearND: that is true. And I believe I pushed my changes onto both of those... but they both got a -1 from jenkins, and that's where I got stuck. [21:36:35] dbrant: hmm, weird. i guess i'll do alpha first, then look at beta [21:38:28] (03PS1) 10BearND: Bump version for release 2.0-alpha-2014-06-18 [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/140575 [21:39:36] (03CR) 10BearND: [C: 032] "self-merge" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/140575 (owner: 10BearND) [21:39:59] (03Merged) 10jenkins-bot: Bump version for release 2.0-alpha-2014-06-18 [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/140575 (owner: 10BearND) [21:44:04] (03PS2) 10Dbrant: Move everything to beta package [apps/android/wikipedia] (beta) - 10https://gerrit.wikimedia.org/r/140217 [21:44:06] (03PS1) 10Dbrant: Bump version number for 2.0-beta-2014-06-18 [apps/android/wikipedia] (beta) - 10https://gerrit.wikimedia.org/r/140577 [21:44:39] (03CR) 10jenkins-bot: [V: 04-1] Move everything to beta package [apps/android/wikipedia] (beta) - 10https://gerrit.wikimedia.org/r/140217 (owner: 10Dbrant) [21:44:41] (03CR) 10jenkins-bot: [V: 04-1] Bump version number for 2.0-beta-2014-06-18 [apps/android/wikipedia] (beta) - 10https://gerrit.wikimedia.org/r/140577 (owner: 10Dbrant) [21:48:46] dbrant: hello [21:48:58] vbamba: hi! [21:49:28] i looked at the last build, the whitespace on the save screen looks like it hasn't changed much [21:51:12] vbamba: so you want the Preview to start much closer to the bottom? [21:52:30] dbrant: vbamba tfinc: alpha is published. should be visible in a few hours [21:54:25] vbamba: I was just approximating the spacing that's on the design mockups. [21:54:36] dbrant: yes, because when the tags are internationalized that whitespace wont be enough [21:55:20] vbamba: if the tags are too long, they will overflow, and the whitespace will be pushed down dynamically. [21:55:51] if the whitespace is dynamic, then it takes care of one thing. [21:55:59] vbamba: the whitespace will always be a constant amount. [21:55:59] the other concern is hierarchy. [21:56:04] Right now the page is split half and half [21:56:21] if we want to choreograph a users attention, we must weight one area more than the other. [21:56:56] giving the summary a little more whitespace will help frame the top half and establish hierarchy. [21:58:05] vbamba: ok then, how much more? (and what about larger screens, e.g. tablet) [22:18:12] brion: any chance to poke that “housekeeping” patch? [22:29:59] bearND: thanks [22:32:51] 3Wikipedia App / 3Android App: Android app shows 'Could not reach the network' when tapping pencil icon on image view - 10https://bugzilla.wikimedia.org/66814 (10Tomasz Finc) 3NEW p:3Unprio s:3normal a:3None #1 Load any page with an image #2 Tap on the image #3 Tap the pencil icon Notice how you get... [22:36:20] 3Wikipedia App / 3Android App: Android app shows add image icon for saved pages and history of FILE pages - 10https://bugzilla.wikimedia.org/66815 (10Tomasz Finc) 3NEW p:3Unprio s:3normal a:3None #1 Load any article with an image #2 Tap the image #3 Save the page #4 Open saved pages or history Notic... [22:42:33] 3Wikipedia App / 3Generic: Mobile Apps: Trying to create a username with a hash in should present the user with an error - 10https://bugzilla.wikimedia.org/64409#c9 (10Dan Garry) 5PATC>3RESO/FIX This bug is fixed now. [22:43:05] 3Wikipedia App / 3Android App: Android App doesn't show keyboard using Find in page on landscape mode - 10https://bugzilla.wikimedia.org/66816 (10Tomasz Finc) 3NEW p:3Unprio s:3normal a:3None #1 Load any page #2 Rotate phone to landscape mode #3 Tap find page A blinking cursor shows up but a keyboar... [22:45:37] 3Wikipedia App / 3Android App: Android app doesn't dismiss keyboard after following interwiki link - 10https://bugzilla.wikimedia.org/66817 (10Tomasz Finc) 3NEW p:3Unprio s:3normal a:3None #1 Load any article #2 Tap and *type* in any interwiki link #3 Select that interwiki link Notice how the keyboa... [22:46:08] (03PS1) 10Mhurd: Fix for "other" placeholder text clipping. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/140590 [22:46:33] 3Wikipedia App / 3iOS App: iOS App: Make sure that app updates don't wipe saved pages. - 10https://bugzilla.wikimedia.org/65106#c3 (10Dan Garry) 5NEW>3RESO/FIX I'll just say this is fixed. [22:47:13] brion: that last patch should fix the “other” placeholder text clipping :) [22:47:33] 3Wikipedia App / 3Generic: Following a link which can't be handled on the device crashes the app - 10https://bugzilla.wikimedia.org/64424 (10Dan Garry) 5PATC>3RESO/FIX [23:00:46] Maryana: i just created https://trello.com/b/TInnSh9E/mobile-web-q1-backlog-2014-2015 [23:01:02] that's probably a good place to start captuing the stuff that came out of the alpha/beta kill/iterate/graduate convo [23:04:52] awesome, thanks awjr [23:09:18] 3Wikipedia App / 3iOS App: iOS App: Make sure that app updates don't wipe saved pages. - 10https://bugzilla.wikimedia.org/65106#c4 (10Kunal Mehta (Legoktm)) Since I filed this bug, there hasn't been any breakage in this area :) [23:27:04] bit of coverage: http://www.webpronews.com/wikipedia-gets-a-revamp-on-tablets-2014-06 (mostly blog copy) [23:42:27] (03PS1) 10BearND: Merge branch 'master' into beta [apps/android/wikipedia] (beta) - 10https://gerrit.wikimedia.org/r/140612 [23:42:27] Saved pages don't work from History list. Has that been filed already? [23:44:08] ragesoss: elaborate? [23:45:01] Save a page. Now go off network. Try to access saved page via History instead of Saved pages. [23:45:37] ragesoss: i see! sounds like a new one. [23:45:38] You get network error message, even though that article is locally available. [23:46:30] K. I'll file later. [23:49:21] (03PS1) 10MaxSem: Flip TOC icon in RTL [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/140616 (https://bugzilla.wikimedia.org/66771) [23:50:33] 3Wikipedia App / 3Generic: Pressing 'done' on save workflow should perform the current affirmative action - 10https://bugzilla.wikimedia.org/64714#c1 (10Dan Garry) 5NEW>3RESO/INV Given the current structure of the editing workflow, this bug no longer makes sense. [23:53:18] 3MobileFrontend / 3Feature requests: images are too small on tablets and large phones - 10https://bugzilla.wikimedia.org/63134#c8 (10Max Semenik) Make images on large screens float like on desktop? [23:58:53] dbrant: would you take https://gerrit.wikimedia.org/r/140612  for a spin and let me know if i can publish it to beta?