[00:03:29] bearND: ah, you did it! [00:03:55] bearND: will you tell me how exactly it was done? [00:04:29] bearND: (and it still says it's dependent on an "outdated" patch...) [00:05:09] dbrant: was a beast to merge. I did it manually on the beta branch. Yeah, the problem is that in Gerrit it depends on YuviPanda|zzz old patch. So, I don't know if we ever going to merge that. [00:06:34] (03PS1) 10Kaldari: Add text to next & save buttons in mobile editors [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/140620 [00:07:04] bearND: you mean we'll just keep rebasing this patch, and never merge it? [00:07:09] dbrant: bearND question for you guys [00:07:27] vbamba: yes! [00:08:25] When you tap on the image in an article, it takes you to the file page. Is that a default or did you guys implement it? [00:08:58] vbamba: the app simply goes where the link points to. [00:09:46] dbrant: i basically first pulled master, checked out beta branch, also pulled beta to make sure I got the latest. Then I did a 'git merge master', resolved the conflicts manually. I also compared it with master to make sure the diffs are good. Had to deal with a lot of bookmark package to savedpages changes. [00:11:15] vbamba: are you thinking that clicking on an image should display the full-size image by itself? [00:12:43] bearND: and then, how did you push it back to gerrit? because up to this point, I thought I did it very similarly :( [00:13:48] dbrant: as usual for branches: git push gerrit HEAD:refs/for/ [00:16:06] bearND: well, it looks good for beta release! [00:16:24] dbrant: cool, i'll publish then [00:21:50] 3Wikipedia App / 3Android App: Saved pages are not loaded if selected via History list while offline - 10https://bugzilla.wikimedia.org/66818 (10Sage Ross) 3NEW p:3Unprio s:3normal a:3None If you save a page, then go offline, then selected that saved page from the History list, all you get is a netwo... [00:25:48] dbrant: tfinc vbamba moizsyed Deskana|Away YuviPanda|zzz: published beta, should arrive in a few hours; running out of space for what's new section ;) [00:25:55] thanks bearND [00:26:07] i'm eager to give it a spin [00:42:06] 3MobileFrontend / 3General/Unknown: Allow end users to view images compresses to decrease page load times - 10https://bugzilla.wikimedia.org/66819 (10Jared Zimmerman (WMF)) 3NEW p:3Unprio s:3normal a:3None enable qlow setting in mobile web (and app?) for all users not just wikipedia zero users setti... [00:45:34] 3MobileFrontend / 3General/Unknown: Allow end users to view images compresses to decrease page load times - 10https://bugzilla.wikimedia.org/66819#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/M7lzCG08 [00:49:09] (03PS1) 10Dr0ptp4kt: Per UX feedback, relabel, bold some buttons, always show OFF. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/140625 [00:50:16] bearND, would you be able to review and +2 above? ^^ minor style changes, plus always showing a dialog box when w0 goes from ON to OFF. [00:53:09] dr0ptp4kt: i can check it in ~ 45 minutes [00:54:05] dr0ptp4kt: is there an easy way for me to trigger w0 on/off transitions? [00:55:21] dr0ptp4kt: nm. i got an idea [00:55:27] bearND, can't remember, do i have your ip (e.g., home cable router as reported in a search for "what's my ip") in our test config? if so, the best way to trigger on off is to toggle your connection from exclusively using a "wikipedia zero network" (ip added in test config) to a non-w0 network (ip not in test config, e.g., cellular) [00:55:32] bearND: cool [00:56:25] dr0ptp4kt: yeah, my home ip is currently on the w0 "plan" ;) will check with my neighbor to get off it temporarily [00:56:45] bearND: cool. another option is to disable wifi and just use cellular [00:57:00] dr0ptp4kt: i don't have a data plan [00:57:08] bearND, word [01:00:52] bearND: one thing to note: it's not related to this patch, but it does seem that over the course of some code drift, going from On to OFF back to On in some cases now doesn't always cause the chrome to be updated in the last state change (going from OFF to On, and then tapping on article, say). i'm going to deal with that in a different patch, as it's a different matter altogether. [01:04:53] bearND: and that isn't the harmful sort of change where the user would think s/he is getting free access. worst case there the user thinks s/he is getting charged but is actually getting it for free [01:06:23] dr0ptp4kt: why did you change the string resource names to have the v2 added? [01:06:43] bearND, to request re-translations [01:06:56] bearND, do you happen to know of a way to trigger those faster? [01:08:50] dr0ptp4kt: not sure. Maybe submit a bug? [01:08:56] bearND, i can definitely roll back the names if necessary, just wasn't sure if there was a way to essentially ask for new translations on old "keys" [01:11:13] dr0ptp4kt: i thought that eventually that should all go through. but don't take my word for this since I'm the new guy. YuviPanda|zzz or brion would know for sure, probably mhurd, too [01:11:29] Maryana: you there? [01:12:40] mhurd, you know if there's a way to trigger a re-translation request when messages have already been populated on the old keys? [01:13:56] dr0ptp4kt: i’ve just changed them. i assume they do a diff? [01:14:27] (03CR) 10MaxSem: [C: 032] Ensure edit protection is declared when only move permissions exist on page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/137735 (https://bugzilla.wikimedia.org/65631) (owner: 10Jdlrobson) [01:14:29] mhurd, en or qqq or both? [01:14:54] MaxSem: do you know if there's a way to request re-translation when messages have already been populated for existing keys/ [01:14:55] ? [01:15:05] (03Merged) 10jenkins-bot: Ensure edit protection is declared when only move permissions exist on page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/137735 (https://bugzilla.wikimedia.org/65631) (owner: 10Jdlrobson) [01:15:05] dr0ptp4kt: both if they both changed i guess. not sure if they actually do a diff [01:15:17] dr0ptp4kt, cange the message [01:15:35] MaxSem: just english, or qqq, or what? [01:15:41] en [01:17:18] 3MobileFrontend / 3alpha: Ajax page loading - Uncaught TypeError: Cannot read property 'indexOf' of undefined - 10https://bugzilla.wikimedia.org/65631 (10Jon) 5PATC>3RESO/FIX [01:17:20] bearNd, mhurd, Maryana ^ MaxSem said just change the en message. bearND, i'll make the change [01:17:28] dr0ptp4kt: cool! [01:17:34] dr0ptp4kt: good to know for sure :) [01:17:56] dr0ptp4kt: thanks [01:19:07] thanks MaxSem [01:23:12] (03PS2) 10Dr0ptp4kt: Per UX feedback, relabel, bold some buttons, always show OFF. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/140625 [01:23:12] bearND ^ [01:23:22] updated messages back to old names [01:23:24] (03PS1) 10BearND: just a git test abandon me! [apps/android/wikipedia] (beta) - 10https://gerrit.wikimedia.org/r/140628 [01:23:37] dr0ptp4kt: cool :) [01:50:56] (03CR) 10Jdlrobson: "That sounds like a bug then. According to the code it should only run if the edit count < 50 so that is the problem. More digging required" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/140233 (owner: 10Cmcmahon) [01:58:29] violetto: hey may! [02:00:13] (03PS1) 10Jdlrobson: QA: Fix special history browser test [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/140633 [02:00:23] (03CR) 10Jdlrobson: "Problem is fixed in https://gerrit.wikimedia.org/r/140633" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/140233 (owner: 10Cmcmahon) [02:50:28] (03CR) 10BearND: [C: 04-1] "Not convinced about the bold buttons in dialogs." (037 comments) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/140625 (owner: 10Dr0ptp4kt) [03:07:18] hey mhurd! [03:07:26] violetto: heya! [03:07:49] mhurd: saw your comment on the 'w' [03:07:52] let me check [03:07:57] violetto: ah! perfect :) [03:08:40] mhurd: you're right. i'll fix it this friday. [03:09:02] btw, legal said we cannot specifically call out the logo anywhere [03:09:06] violetto: cool! i think a couple other new-ish icons aren’t in the css file yet too [03:09:13] violetto: gotcha [03:09:17] so i have to label the w in the future as some random characters [03:09:32] oh yikes, i might have merged the wrong file entirely [03:09:36] i'll check this friday [03:09:56] violetto: awesomethanks! [03:10:21] mhurd: np, thanks for catching that [03:10:31] violetto: yw! :) [03:18:51] (03PS1) 10Mhurd: Updated wikifont. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/140637 [03:35:39] (03PS2) 10Mhurd: Updated wikifont. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/140637 [03:44:18] 3Wikipedia App / 3Generic: Confusing pencil icons are shown for empty headings - 10https://bugzilla.wikimedia.org/64054#c1 (10Dan Garry) 5NEW>3RESO/WON There's not really a lot for us to do about this. If there's a section there, you can edit it. Removing the pencil icon doesn't make much sense. Besides,... [03:49:48] 3Wikipedia App / 3Generic: iOS: Long, single word article titles are not displayed correctly - 10https://bugzilla.wikimedia.org/64738#c1 (10Dan Garry) 5NEW>3RESO/FIX This is fixed now. [03:57:18] 3Wikipedia App / 3Search: app crash trying very long title search and hitting go - 10https://bugzilla.wikimedia.org/65610#c1 (10Dan Garry) 5NEW>3RESO/FIX Unable to reproduce this, so I'm marking it as fixed now. [03:57:50] bearND: so, I'm thinking the way to fix the beta thing is to actually just write a small python script that does the refactoring automatically, rather than rebasing [03:58:03] bearND: rebasing is always going to be hard because of the number of times org.wikipedia appears [04:00:59] YuviPanda: or we could base the branch on a stable footing, i.e. a merged commit, instead of an unmerged one [04:01:14] bearND: that's still going to cause rebasing problems everytime, and merge conflicts [04:01:25] bearND: if we write a script instead, it will not cause any rebase problems at all. [04:01:35] just run script, which makes a branch, and then we don't have to touch that branch afterwards [04:05:01] YuviPanda: hmm, sounds interesting. If it's not too time consuming to do the package change in python code. Moving directories around, changing package and import statements, modifying the manifest [04:05:21] bearND: in the long run will save us time and pain, I think. I've already started writing it [04:06:25] YuviPanda: how long do you think we'll have a separate beta app? It would be better to consolidate, then we could just use the alpha and beta feature of the store. And just promote from alpha to beta, to prod [04:07:11] bearND: not really. I think we'll have forever beta. It's just much easier to get people a separate app than 1. get them into a google group, 2. sign up for beta [04:13:36] YuviPanda: makes updating beta a real hassle though. I agree that it's easier for people to download a beta app without having to sign up for the group. Couldn't we just have a wiki page with some good instructions how to join alpha or beta group, and link to it from the store description? Wondering how other apps do alpha and beta. Google IO is coming up. Maybe there will be some changes in the process of ralphas/betas… (ok, [04:14:37] bearND: maybe, yeah [04:14:46] bearND: but I think if we have a simple 'make-beta' script it'll make updating beta easier [04:18:01] bearND: also your message got cutoff at (ok, [04:19:35] YuviPanda: there wasn't much more after that except "wishful thinking" [04:19:40] YuviPanda: IO starts on the 25th, btw. [04:19:56] YuviPanda: http://stackoverflow.com/questions/18491649/how-to-change-the-android-app-package-name-when-assembling-with-gradle [04:20:23] YuviPanda: doesn't help us now but maybe in the future when we switch to Gradle [04:20:50] bearND: still need to move the folder names, and rename all the imports, etc [04:22:24] YuviPanda: scratch that. doesn't probably apply to our problem here [04:23:34] bearND: yeah. [04:23:47] bearND: if google introduces something like a one click switch from inside the play app... [04:24:13] bearND: the current beta cycle is intended for companies intent on secrecy as well, rather than as wide a districution as possible. doesn't apply to us [04:29:02] YuviPanda: If we keep beta around forever we should have a wiki page showing the state of each type of release (alpha, beta, prod) and a changelog. https://ticket.wikimedia.org/otrs/index.pl?Action=AgentZoom&TicketID=7614553 asks what changed in the 6/17 update. Not sure if beta or alpha was meant. [04:30:34] bearND: yeah, beta I'd guess. we should make sure to update what's new as well, truncating older things if necessary [04:30:38] bearND: and yeah, a wiki page makes sense too [05:27:13] YuviPanda: Can you grant us permission to upload apks to https://releases.wikimedia.org/mobile/android/wikipedia/? [05:28:11] bearND: requires a puppet change, let me do a patchset [05:28:25] YuviPanda: ok [05:29:00] bearND: hmm, dbrant already has access [05:29:04] let me get access for you setup [05:31:16] (PS1) Yuvipanda: Grant bearND ability to upload mobile releases [operations/puppet] - https://gerrit.wikimedia.org/r/140646 [05:31:18] bearND: ^ [05:31:24] bearND: can you +1? I'll get someone to merge it later today [05:33:36] YuviPanda: +1'd [05:33:38] bearND: ty [05:36:22] YuviPanda: sending out the alpha/beta announcement email… [05:36:29] bearND: \o/ [05:38:30] bearND: ty. we should put up a release-checklist soon [05:39:48] YuviPanda: yes, that would be good. and also update https://www.mediawiki.org/wiki/Mobile/Release_history#Wikipedia [05:40:02] bearND: yeah. [05:40:04] bearND: that as well [05:45:28] YuviPanda: gonna add to the release email about searching with ampersands in the title. Did I miss anything else? [05:45:34] (03PS1) 10Yuvipanda: Move ObservableWebView into views [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/140649 [05:45:36] bearND: nothing I'm aware of, no [05:45:49] bearND: fixed crashing ToC when app is RTL [05:45:50] YuviPanda: ok, ty [05:46:12] YuviPanda: i had this in the previous mail: Fix crash in RightToLeft languages when Table of Contents icon was clicked [05:46:18] ah, ok [05:46:21] missed it, I think [05:46:29] trying to avoid abbreviations [05:46:47] bearND: ok [05:48:55] YuviPanda: morning, can i translate the edit summaries in the mobile app ? [05:49:03] matanya: hello! [05:49:06] matanya: what do you mean? [05:49:14] matanya: oh, the canned ones? [05:49:18] yes [05:49:46] matanya: yeah, you can. hasn't been imported into translatewiki.net yet [05:50:08] how/where [05:50:47] matanya: in translatewiki.net. https://translatewiki.net/w/i.php?title=Special:Translate&group=out-wikimedia-mobile-wikipedia-android-strings [05:51:03] matanya: they aren't there yet since the twn.net folks haven't sync'd changes yet. let me see if I can find someone to sync [05:52:24] aharoni: hello! Just checking - nikerabbit can also perform syncs of git repos -> translatewiki.net, right? [06:01:47] (03PS4) 10Florianschmidtwelzow: Add Article Title to PageTitle [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/139790 (https://bugzilla.wikimedia.org/66591) [06:03:05] (03PS3) 10Florianschmidtwelzow: Add page title to Special:Contributions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/139844 (https://bugzilla.wikimedia.org/66656) [06:03:41] (03PS1) 10Yuvipanda: [WIP] Add script that makes beta branch [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/140650 [06:03:43] (03PS2) 10Florianschmidtwelzow: Hygiene: Manage z-index with less variables [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/139568 (https://bugzilla.wikimedia.org/64707) [06:03:45] bearND: ^ WIP script, compiles and runs :) [06:04:16] (03PS3) 10Florianschmidtwelzow: Proposal: Redirect to direct match in search [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/139556 (https://bugzilla.wikimedia.org/66506) [06:08:44] (03CR) 10BearND: [C: 032] Move ObservableWebView into views [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/140649 (owner: 10Yuvipanda) [06:09:05] (03Merged) 10jenkins-bot: Move ObservableWebView into views [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/140649 (owner: 10Yuvipanda) [06:09:13] bearND: ty. shouldn't you be sleeping? :D [06:09:53] YuviPanda: yeah, got the same problems ;) [06:09:57] bearND: hehe :D [06:11:22] YuviPanda: looking at your new script: why do you have this: sh.git.reset('--hard') between two defs? [06:15:09] 3MobileFrontend / 3General/Unknown: "Add an image" icon/CTA is inconsistent - 10https://bugzilla.wikimedia.org/66826 (10Erik Moeller) 3NEW p:3Unprio s:3normal a:3None The "Add an image" icon next to the "Edit" icon is inconsistent with "Edit" and "Watchlist" in two ways: 1) It has a padlock indicato... [06:15:34] 3MobileFrontend / 3General/Unknown: "Add an image" icon/CTA is inconsistent - 10https://bugzilla.wikimedia.org/66826#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/UWbdeyog [06:16:15] (03CR) 10Amire80: [C: 031] Flip TOC icon in RTL [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/140616 (https://bugzilla.wikimedia.org/66771) (owner: 10MaxSem) [06:17:33] (03CR) 10Amire80: "It works and the code looks OK to me given bug 66091. Leaving the +2 approval for someone who may know LESS intricacies better." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/140616 (https://bugzilla.wikimedia.org/66771) (owner: 10MaxSem) [06:17:40] YuviPanda: just ran the script. it's pretty awesome. Could you also have it update the versionName in the manifest, so it says beta instead of alpha? Nice work! [06:17:48] bearND: yeah, that's what I'm doing now [06:17:55] YuviPanda: :) [06:18:01] bearND: this is much easier than rebasing :D [06:18:09] YuviPanda: yesss [06:18:54] (03Abandoned) 10BearND: just a git test abandon me! [apps/android/wikipedia] (beta) - 10https://gerrit.wikimedia.org/r/140628 (owner: 10BearND) [06:20:11] bearND: things left to do is, I think: 1. version info on androidManifest 2. icon on Android Manifest [06:20:42] YuviPanda: Could you take a stab at improving https://gerrit.wikimedia.org/r/#/c/140310/ later? I think you would be more efficient working on the background task for this. [06:21:02] bearND: sure! I quite enjoy threading problems [06:21:05] bearND: :) [06:21:12] YuviPanda: yes, almost forgot the icon [06:21:20] bearND: :) [06:21:26] YuviPanda: thank you! heading off to bed now [06:21:37] bearND: good night! [07:09:38] (03Abandoned) 10Amire80: Flip the table of contents icon for RTL [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/140321 (https://bugzilla.wikimedia.org/66771) (owner: 10Amire80) [07:22:44] (03CR) 10Siebrand: [C: 031] "L10n reviewed." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/140637 (owner: 10Mhurd) [07:56:53] (03CR) 10Liangent: Add Article Title to PageTitle (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/139790 (https://bugzilla.wikimedia.org/66591) (owner: 10Florianschmidtwelzow) [08:01:21] (03CR) 10Siebrand: [C: 04-1] "L10n reviewed. -1 per BearND's comments." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/140625 (owner: 10Dr0ptp4kt) [08:03:42] (03CR) 10Siebrand: "i18n/L10n reviewed. I don't think the key has to changed, so that existing translations can keep being used." (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/140620 (owner: 10Kaldari) [08:05:05] (03CR) 10Yuvipanda: [C: 04-1] "Needs more explanatory commit message as well." (032 comments) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/140625 (owner: 10Dr0ptp4kt) [08:18:32] (03PS5) 10Florianschmidtwelzow: Add Article Title to PageTitle [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/139790 (https://bugzilla.wikimedia.org/66591) [08:19:27] @YuviPanda but adding it to the action bar makes the 'Update Saved Pages' an optional action [08:19:52] vbamba: indeed. that was Deskana|Away's decision, to not make it a required action. I did protest. [08:20:48] https://trello.com/c/NMinGQRi/41-offline-add-an-update-all-button-to-the-saved-pages-page [08:20:59] Can you take a quick peek at V2 on this mock? [08:21:24] vbamba: looking now [08:22:40] vbamba: hmm, looks good to me provided it scrolls off when you scroll off, and doesn't take as much space (on smaller devices that itself could take 50% of the screen) [08:23:29] Trying to see if there is a similar pattern for android - one that allows us to explain whats going on [08:23:41] else I have no idea - why I even see a refresh icon [08:24:20] I think we can help Deskana|Away with context in this matter :) [08:24:22] vbamba: so the usual thing is you can 'long press' an icon in the actionbar and it shows a tooltip [08:24:30] vbamba: like 'refresh all' [08:24:38] ya but i need the information along with the action [08:24:59] Look at it this way - the information justifies the presence of the action [08:25:14] (03CR) 10Siebrand: Editing workflow simplifications. (031 comment) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/140254 (owner: 10Mhurd) [08:25:25] vbamba: by that logic, we should have text for table of contents icon, for delete all, etc as well, no? [08:26:55] vbamba: my only concern is what to do on the case of small screens :) [08:27:10] No. TOC and Delete are not the same. [08:27:12] vbamba: an option is to just show this the first time saved pages dialog is opened. [08:27:41] This case for 'refresh' occurs with lists or feeds that need updating [08:28:13] vbamba: indeed, I'm talking about the need for 'explanations'. It's useful the first few times, and then it's just something that takes up screen space. [08:29:11] Ya but this one of the cases where the refresh icon doesnt hold on its own - i dont see that in email. [08:29:20] vbamba: hmm? [08:29:45] 2 ways this is traditionally solved for - 'Pull to refresh' or use a tappable tooltip which says there is 'new content' [08:29:47] vbamba: I'd say show it the first time the user is on the saved pages activity. [08:30:06] ok, can you save that as a flag on the device? [08:30:12] vbamba: yup [08:30:18] ok lets do that then [08:30:47] vbamba: cool :) note that on the trello card? [08:42:04] Is the refresh icon there in the current build on the 'Saved' pages? [08:42:14] (I dont have an android device on me) [08:42:30] vbamba: nope, it isn't. patch hasn't been merged yet. [08:45:28] vbamba: there's an android icon, though, for refresh. bearND displayed it in his email [08:46:01] I'm going to take a bit of a nap now. too fucking hot. [10:37:10] (03CR) 10Siebrand: [C: 031] "L10n reviewed." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/140310 (owner: 10BearND) [11:31:18] 3MobileFrontend / 3Feature requests: Adds specific support for ProofreadPage Page: namespace - 10https://bugzilla.wikimedia.org/65165#c5 (10Florian) 5PATC>3NEW Hmm, it's difficult to find the best solution. I'm personally not happy with any change at the editor, it is dificult to copy the bevahior from d... [12:04:24] YuviPanda: new release to releases.wm.o ? [12:13:55] matanya: once https://gerrit.wikimedia.org/r/#/c/140646/ is merged [12:14:43] YuviPanda: add some ops to review so they can merge :) [12:15:25] matanya: added a few :) [12:31:21] (03CR) 10Siebrand: [C: 031] "L10n reviewed." [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/139658 (owner: 10Amire80) [13:14:29] (03PS2) 10Yuvipanda: Add script that makes beta branch [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/140650 [14:34:59] (03PS1) 10Dbrant: Handle the love triangle of ProgressDialog, AsyncTask, and Activity. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/140717 [14:35:33] hahaha [14:42:37] * YuviPanda waves at dbrant [14:43:16] YuviPanda: hello! [14:47:23] dbrant: saw the beta making script? easier than having to rebase [14:50:54] YuviPanda: yes! haven't tried it yet, though [14:52:27] dbrant: ok! do try at some point. I'll get to finish up the saved pages update story [14:53:07] dbrant: I think the way to fix RandomHandler's progress dialog is to not have one - just put a spinner next to the 'Random article' button itself [14:54:47] YuviPanda: agreed... I could update the patch with that [14:55:13] dbrant: yeah, that'll clear it up I think [14:55:39] dbrant: we could even just rotate the icon and change the text to 'fetching' or something [14:56:12] YuviPanda: spinner instead of the icon? [14:56:31] dbrant: yeah, that's probably less gimmiciker and more clerar [14:56:33] *clearer [14:56:36] *clear [14:57:00] dbrant: should also prevent the item from being tapped again, though [15:13:02] * bearND waves at YuviPanda and dbrant [15:13:16] hello! [15:13:21] /me waves at bearND as well [15:14:21] bearND: the script is complete! I shall finish up t he refresh page thing soon, but have a couple of meetings lined up shortly [15:14:42] YuviPanda: excellent! [15:21:27] I'm heading away for some food now, will brb [15:27:42] (03PS1) 10Dbrant: Remove ProgressDialog from random handler. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/140724 [15:33:52] (03PS2) 10Dbrant: Handle the love triangle of ProgressDialog, AsyncTask, and Activity. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/140717 [15:34:08] (03Abandoned) 10Cmcmahon: QA: history test times out every time [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/140233 (owner: 10Cmcmahon) [15:50:12] (03CR) 10BearND: [C: 04-1] "Minor change necessary, then I think we can use it. Awesome script! Thank you! :) If you'd like I could push that change." (031 comment) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/140650 (owner: 10Yuvipanda) [15:56:54] (03PS4) 10Jdlrobson: Hygiene: Start using models for history and contributions page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/133680 [15:58:17] bearND: aah, feel free to update that patch and then merge (after testing!) [15:58:35] * YuviPanda disappears again for a bit [16:03:55] (03PS3) 10BearND: Add script that makes beta branch [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/140650 (owner: 10Yuvipanda) [16:11:47] (03CR) 10BearND: [C: 032] Add script that makes beta branch [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/140650 (owner: 10Yuvipanda) [16:12:16] (03Merged) 10jenkins-bot: Add script that makes beta branch [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/140650 (owner: 10Yuvipanda) [16:37:47] (03PS1) 10Dbrant: Properly load saved pages from History. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/140735 (https://bugzilla.wikimedia.org/66818) [16:40:22] you guys are bug-fixing beasts! [16:43:30] (03CR) 10Yurik: [C: 032] Clarify some configuration messages [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/139658 (owner: 10Amire80) [16:43:41] (03Merged) 10jenkins-bot: Clarify some configuration messages [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/139658 (owner: 10Amire80) [16:49:06] ragesoss: :D [17:01:55] (03CR) 10Cmcmahon: [C: 032] QA: Fix special history browser test [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/140633 (owner: 10Jdlrobson) [17:02:30] (03Merged) 10jenkins-bot: QA: Fix special history browser test [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/140633 (owner: 10Jdlrobson) [17:02:34] dbrant|lunch: can you also take a gander at https://trello.com/c/VFlTuZVe/42-3-offline-add-an-update-all-button-to-the-saved-pages-page? I offered to take it off bearND's hands, but then I hit up on translatewiki.net bugs that we also mustfix [17:02:45] (anything with tags gets those swallowed when it goes to twn, ugh) [17:02:54] also need to go get a bunch more stuff translated so things aren't incomplete [17:03:09] aaand I've two one hour meetings coming up [17:03:34] bearND: can you also review dbrant|lunch's other changes when you get the time? :) [17:03:48] YuviPanda: doing so right now [17:03:51] bearND: cool [17:04:21] bearND: I spent the day talking to translatewiki.net folks. I've import/export rights now, so we should be able to get translations done faster [17:04:57] YuviPanda: great. I saw that the German translations there are updated, and would like to see them moved over to our code [17:05:22] bearND: yup. I'll do a push soon [17:05:44] bearND: the previous pushes happeneed once in two weeks or something, which I think is too late for our current speed [17:05:48] YuviPanda: bearND: dbrant|lunch heya! [17:05:57] hey mhurd [17:07:09] dr0ptp4kt? [17:07:27] or does anyone know what's "that tls thing"? [17:08:09] YuviPanda: dr0ptp4kt mentioned yesterday that he wanted his W0 string changes also pushed through soon but he should make some changes first. [17:08:18] liangent: where do you see tls? [17:11:07] bearND: dr0ptp4kt sent me a privmsg about "that tls thing" when I wasn't around [17:11:35] ~21hrs ago [17:11:39] liangent: TLS == SSL [17:11:59] roughly [17:12:08] but what's "that tls thing" [17:12:45] liangent: i think he wanted you to test his patch about HTTPS/SSL usage in China [17:14:16] bearND: ok maybe [17:14:31] when will dr0ptp4kt be around? [17:18:54] liangent: ^ [17:19:03] bearND: ya [17:24:19] 3Wikipedia App / 3Android App: ToC icon is fuzzy on large high-resolution devices - 10https://bugzilla.wikimedia.org/66726 (10Sage Ross) 5NEW>3RESO/FIX [17:24:44] (03CR) 10Kaldari: [C: 04-1] Add page title to Special:Contributions (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/139844 (https://bugzilla.wikimedia.org/66656) (owner: 10Florianschmidtwelzow) [17:29:23] (03CR) 10Kaldari: [C: 032] Flip TOC icon in RTL [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/140616 (https://bugzilla.wikimedia.org/66771) (owner: 10MaxSem) [17:29:47] brion: hey! [17:29:59] (03Merged) 10jenkins-bot: Flip TOC icon in RTL [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/140616 (https://bugzilla.wikimedia.org/66771) (owner: 10MaxSem) [17:30:07] yo [17:30:54] brion: think it’s ok if i sit out the evenlogging meeting? you have a much better handle on such things :) [17:31:39] sure :D [17:31:47] jgonera: shit, i thought language selection tracking was part of this schema (https://meta.wikimedia.org/wiki/Schema_talk:MobileWebClickTracking) but it's not [17:31:51] we need to add it [17:32:16] Maryana, you mean tracking if someone clicks the lang button? [17:32:21] mhurd: im popping into the hangout now :) [17:32:25] jgonera: yes [17:32:36] brion: awesome thx! [17:32:53] dbrant|lunch: bearND gah, my phone just seems to have died. trying to get that fixed. [17:32:54] jgonera: just filed a bug [17:33:02] https://bugzilla.wikimedia.org/show_bug.cgi?id=66853 [17:33:06] 3MobileFrontend / 3stable: Add EventLogging to language selection button - 10https://bugzilla.wikimedia.org/66853 (10Maryana Pinchuk) 3NEW p:3Unprio s:3normal a:3None We're currently logging many key mobile page actions, but we left off one very important feature: the "read in another language" butto... [17:33:09] hey brion! [17:33:19] good timezone YuviPanda :D [17:33:20] brion: I see you! [17:33:23] brion: hehe :) [17:33:33] brion: is that the office? [17:33:37] home office [17:33:41] i gotta decorate still [17:33:56] yeah the giant piece cardboard really ties the room together [17:34:11] brion: heh, hopefully nobody goes looking for another brion... [17:34:14] Deskana|Away: yt? [17:34:25] i could make more 2d brions [17:34:26] and accidentally comes to piss on your giant piece cardboard [17:34:28] brion: haha [17:34:37] brion: yes indeed. [17:34:38] we’re meeting in the quiet room (!) to talk about instrumentation and stuff [17:34:59] BE VERY QWIET! we’re hunting event wogging [17:35:19] brion: brb in a min, checking to make sure the gas is off :) [17:35:27] safety first [17:35:34] 3MobileFrontend / 3stable: Add EventLogging to language selection button - 10https://bugzilla.wikimedia.org/66853#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/MTfjRLrP [17:35:37] brion: I quite like this, where we are on hangout but actually just chat on IRC... [17:36:07] DarTar: Deskana|Away is on the hangout as well [17:37:12] Deskana: omg, how will I differentiate between you and Oliver?!?!! :P [17:50:39] mhurd: brion: can i get a quick status check of how the two of you are doing with your stories on https://trello.com/b/KNqImlQo/mobile-app-sprint-33-the-final-android-countdown ? [17:51:12] i'd like to update Deskana on our progress and adjust Sprint 34 as necessary as we still stories that haven't been picked up [17:51:27] tfinc: checking in on eventlogging right now to make sure i’m tweaking the right bits (in hangout) [17:52:35] tfinc: feeling pretty good about th onboarding and button-style re-do card i’m doing :) i do think we should perhaps move the unestimated cards in the to-do column to the backlog though… they keep sneaking in there [17:52:48] lemme check card status [17:53:00] Deskana: --^ [17:53:31] mhurd: are the buttons done or is that the part that didn’t make it in the first patch? [17:53:54] (https://trello.com/c/4Hzl37Ks/9-1-re-do-button-styling-for-progressive-actions) [17:54:14] brion: not done yet - working on the buttons for sign-in, acct creation and captcha now [17:54:25] ok, just making sure the board’s in sync [17:54:47] looks like i only have to add one more bit on eventlogging for our initial requirements [17:55:18] brion: awesome! :) if you happen to wrap up event logging mtg with any time to spare, i think i have 3 patches for ya for cr [17:55:26] ah great [18:00:08] jgonera: what's going on with the browser test failues? [18:00:23] awjr, I don't know yet, I'm in a meeting now [18:00:48] jgonera: k - let's get it figured out asap; i am concerned to see that builds have been failing for the last 6 days and there's a deployment today. [18:01:57] awjr, I'd say it's not "nice" to see that, but seeing how unreliable our tests have been lately, I don't envision a disaster coming [18:02:09] jgonera: would be good to know for sure ;) [18:02:46] Maryana: i forgot to add a room for a mtg - do you want me to add one? r31 is avail [18:03:14] (03PS4) 10Florianschmidtwelzow: Add page title to Special:Contributions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/139844 (https://bugzilla.wikimedia.org/66656) [18:03:23] (03PS5) 10Florianschmidtwelzow: Add page title to Special:Contributions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/139844 (https://bugzilla.wikimedia.org/66656) [18:04:25] Maryana, awjr should I prioritize browser tests over VE work? [18:08:13] (03CR) 10BearND: [C: 04-1] "Nice! This also covers" (033 comments) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/140724 (owner: 10Dbrant) [18:10:08] brion: I'll be making some changes to https://meta.wikimedia.org/wiki/Schema:MobileWikiAppEdit soon [18:10:12] ok [18:10:21] i’ll watch for your commits and update the ios side [18:10:32] brion: yeah, I'll poke you as well [18:10:43] brion: aalso did you get the appInstallToken thingy done? [18:10:46] we're generating an UUID [18:11:07] YuviPanda: i had it prepped for the EL method, need to swap it around to send with the API but the generation is easy [18:11:21] brion: yeah, ok [18:11:21] using NSUUID system class to generated UUIDs, and storing in a preference [18:11:34] brion: cool. also make sure to not send it in during opt out ;) [18:11:46] ah yes we have to add optout still :D [18:11:56] there’s a card somewhere for that [18:12:14] brion: :) [18:12:31] brion: do remember to do that before teh app release. as dario said, we are on shaky ground without it [18:13:02] yes :D [18:13:06] bearND: adding you to the group that can upload mobile releases is under process, should take a few days tho. in the mean time dbrant|lunch or me or brion can upload [18:13:24] awjr: gahh, hangout crashed [18:13:29] doh! [18:13:35] blame mercury in retrograde [18:14:25] i blame mercury in tuna [18:15:27] woops closed wrong window :P [18:15:32] brb [18:20:47] brion: Deskana might be a couple of mins late to the iteration. hopefully not. [18:20:50] * YuviPanda is a little sick atm. [18:20:51] brb [18:24:05] durrr it helps if i check out in the right project [18:24:41] mhurd: oh i got yosemite installed on that sd card; it boots a little slower but is WAY faster than the vmware virtual machine i tried :D [18:24:44] i’ll show ya tomorrow [18:25:10] any clue what happened yesterday with registrations spiking on mobile? is that the tablet redirect? [18:25:20] enwiki|156171: i’d suspect so yes [18:25:21] http://ee-dashboard.wmflabs.org/graphs/enwiki_daily_reg_mobile [18:25:28] makes sense [18:25:54] probably mostly ipads [18:26:10] (03CR) 10Brion VIBBER: [C: 032 V: 032] Fix for "other" placeholder text clipping. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/140590 (owner: 10Mhurd) [18:26:30] (03PS3) 10Brion VIBBER: Updated wikifont. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/140637 (owner: 10Mhurd) [18:27:17] Deskana: you see that graph? must be people using the site \o/ [18:27:27] * enwiki|156171 checking [18:27:46] brion: oh cool! that flush sd card? [18:27:51] mhurd: yeah [18:28:06] 128 gigs o’ os x 10.10 fun [18:28:13] brion: hehe [18:28:21] and i can still mount my regular disk and access files [18:28:34] brion: pretty slick [18:28:51] yeah, if i could get full ssd speeds out of one of those though…… THAT would rock [18:29:40] mhurd: so on the wikifont change, we’re back to may’s stock wikifont + a supplemental one for ios-specific icons? [18:29:51] brion: ya! [18:29:54] nice [18:30:04] that should be easier to manage as we maintain custom additions [18:30:12] brion: seemed more sane :) [18:31:28] brion, Deskana: 24% with a UA matching “iPad” [18:31:50] interesting [18:31:54] of all unique registrations across wikis with displayMobile = 1 on the 18th [18:32:16] i wonder if the others are android tablets or if we’re seeing a different behavior [18:32:17] (03CR) 10Dbrant: Remove ProgressDialog from random handler. (032 comments) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/140724 (owner: 10Dbrant) [18:32:48] (03PS2) 10Dbrant: Remove ProgressDialog from random handler. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/140724 [18:35:15] bearND: ^ comments addressed [18:37:13] jgonera: not sure if Maryana responded to your q yet, but i would say figuring out why browser tests are failing is highest priority atm [18:38:47] (03CR) 10Kaldari: [C: 032] Add page title to Special:Contributions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/139844 (https://bugzilla.wikimedia.org/66656) (owner: 10Florianschmidtwelzow) [18:39:32] (03Merged) 10jenkins-bot: Add page title to Special:Contributions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/139844 (https://bugzilla.wikimedia.org/66656) (owner: 10Florianschmidtwelzow) [18:39:40] kaldari, https://gerrit.wikimedia.org/r/140765 :) [18:39:41] (03CR) 10Brion VIBBER: [C: 04-1] "The CC icon on the edit preview/summary is cut vertically in half on iOS 6.1... otherwise looks good visually." (031 comment) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/140637 (owner: 10Mhurd) [18:39:52] brion: gah! [18:39:55] brion: will amend [18:40:00] 6.1 bah :D [18:41:01] brion: mhurd YuviPanda bearND dbrant http://hatjitsu.wmflabs.org/20262 [18:48:00] Deskana: evil commie browser!!1 [18:52:55] awjr jgonera I was just looking at those failures and the tests seem to be running properly https://integration.wikimedia.org/ci/view/BrowserTests/job/browsertests-MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-firefox-sauce/lastCompletedBuild/testReport/ [18:54:27] one expects to find edit and watch available on the main page but does not, the other expects to be able to edit a protected page jgonera awjr [18:59:05] (03PS1) 10Dbrant: Hide keyboard when interwiki link selected. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/140767 (https://bugzilla.wikimedia.org/66817) [19:02:33] 3MobileFrontend / 3Feature requests: Include "FooBar" in for [[Special:Contributions/FooBar]] - 10https://bugzilla.wikimedia.org/66656 (10Ryan Kaldari) 5PATC>3RESO/FIX [19:13:46] <awjr> thanks for looking chrismcmahon, jgonera sounds like there are either bugs or out of date tests [19:15:39] <chrismcmahon> awjr: these were OK 2 days ago btw https://integration.wikimedia.org/ci/view/BrowserTests/job/browsertests-MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-firefox-sauce/14/ probably a config update or code change [19:17:10] <YuviPanda> Deskana: it's ok, the entire cluster is down [19:22:43] <YuviPanda> Deskana: 'Send usage reports' [19:23:00] <YuviPanda> Deskana: 'Allow wikimedia to collect information about how you use the app to make the app better' [19:31:37] <ashley> back in December 2012 Quim asked on https://www.mediawiki.org/wiki/Talk:Wikipedia_S40_J2ME_app about the source code of the app, and UltrasonicNXT essentially repeated the question in October 2013, but so far the question hasn't been answered...who might be able to answer it? [19:31:59] <YuviPanda> tfinc: ^ status of J2ME app? I can't find the source anywhere either [19:32:19] <YuviPanda> dr0ptp4kt: ^ you might know as well? [19:32:30] <brion> heh [19:32:43] <brion> i think it’s hiding in github somewhere lemme find a link [19:33:00] <tfinc> ashley: https://github.com/wikimedia/WikipediaMobileJ2ME [19:33:17] <brion> https://github.com/wikimedia/WikipediaMobileJ2ME [19:33:36] <ashley> splendid, thanks :D I'll go update the docs [19:33:38] <tfinc> YuviPanda: --^ [19:33:41] <tfinc> ashley: thanks [19:33:43] <brion> i have no idea if/how well it works :D [19:33:54] <YuviPanda> tfinc: ty [19:34:17] <ashley> I'm guessing I should tag the whole page as {{Historical}} while I'm at it, too? :P [19:34:33] <YuviPanda> ashley: I'd say go for it. [19:34:48] <YuviPanda> ashley: tfinc: we don't have anyone actively working on it, and IIRC it wasn't actively deployed anywhere either. [19:34:56] <tfinc> so re-articulating what monte brought up at the end. i think that any story that continues to be blocked after the sprint kick off on Monday should be moved to the backlog [19:36:03] <grrrit-wm> (03PS3) 10BearND: Handle the love triangle of ProgressDialog, AsyncTask, and Activity. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/140717 (owner: 10Dbrant) [19:37:23] <brion> lunch, bbiab [19:37:35] <YuviPanda> tfinc: makes sense. [19:37:38] <YuviPanda> Deskana: ^^ [19:37:44] <grrrit-wm> (03PS4) 10Mhurd: Updated wikifont. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/140637 [19:37:45] <mhurd> brion: just amended that patch [19:37:53] <mhurd> brion: for the ios 6 CC issue [19:38:13] <tfinc> Deskana: what are your thoughts on that ? [19:38:31] <tfinc> effectively any story still blocked after the monday standup would go to the backlog [19:38:39] <tfinc> and would have to wait till the next sprint [19:38:58] <YuviPanda> tfinc: Deskana should probably invoke/involve the designers as well, since afaik that's pretty what most of these have been blocked on. [19:39:23] <tfinc> YuviPanda: it shouldn't matter if its a design, ops, product block [19:39:29] <tfinc> its all the same at the end of the day [19:39:46] <YuviPanda> tfinc: true, but just wanted to make sure that design knows of this decision/can participate in the discussion. [19:39:53] <tfinc> a card isn't actionable, it isn't estimable, so we need more time to discuss it [19:40:00] <tfinc> i'll put it on the list [19:40:06] <YuviPanda> tfinc: +1 [19:43:41] <grrrit-wm> (03Abandoned) 10Mhurd: Updated wikifont. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/140637 (owner: 10Mhurd) [19:43:48] <tfinc> mailed. now time for lunch [19:56:12] <grrrit-wm> (03CR) 10BearND: [C: 032] Remove ProgressDialog from random handler. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/140724 (owner: 10Dbrant) [19:56:36] <grrrit-wm> (03Merged) 10jenkins-bot: Remove ProgressDialog from random handler. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/140724 (owner: 10Dbrant) [19:56:59] <grrrit-wm> (03PS4) 10BearND: Handle the love triangle of ProgressDialog, AsyncTask, and Activity. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/140717 (owner: 10Dbrant) [19:58:06] <bearND> dbrant: ^ just a rebase for now [19:58:18] <YuviPanda> dr0ptp4kt: around? [19:58:20] <dbrant> bearND: sure [19:58:49] <YuviPanda> dbrant: bearND I'm trying to get https://trello.com/c/0dJGY0yi/64-messages-with-links-appear-as-empty-in-translatewiki-net fixed now [19:59:03] <YuviPanda> since we need to fix that soon and get it to twn so people can translate [19:59:11] <YuviPanda> the ToU / PP links are affected, so... [19:59:18] * YuviPanda continues [20:04:40] <bearND> YuviPanda: are you talking about the string resources with links being HTML encoded? Still seems to work when I switch to a language that has it. [20:05:56] <YuviPanda> bearND: right, that's because they are untranslated most of the time [20:06:09] <grrrit-wm> (03CR) 10BearND: [C: 032] "probably safer to invoke the overridden method last for destructive callbacks, but that's not really specific to this patch. It can be add" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/140717 (owner: 10Dbrant) [20:06:31] <YuviPanda> bearND: edit_save_action_license has not been translated to *any* language, for example [20:06:33] <YuviPanda> bearND: so it'll look odd in RTL, etc [20:06:33] <grrrit-wm> (03Merged) 10jenkins-bot: Handle the love triangle of ProgressDialog, AsyncTask, and Activity. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/140717 (owner: 10Dbrant) [20:08:05] <bearND> YuviPanda: content_license_html has been [20:08:20] <YuviPanda> bearND: yup, because that's in a CDATA [20:08:46] <YuviPanda> bearND: and if you look at the responses, you'll see that they don't have CDATA but are html encoded [20:09:01] <bearND> YuviPanda: so, should we wrap all html strings in CDATA then? [20:09:18] <YuviPanda> bearND: yeah, except then since they come back htmlencoded, we have to unencode them :) [20:09:25] <YuviPanda> bearND: am working on a patch right now, will put up in a minute [20:09:30] <YuviPanda> and then need to sync to translatewiki.net [20:09:50] <dr0ptp4kt> YuviPanda: sorry, i missed your message. i'm here [20:10:14] <dr0ptp4kt> bearND, you get a chance to look at the dialog box stuff for W0 patch? [20:10:21] <kaldari> MaxSem: https://trello.com/c/XFdSOdGw/128-move-special-mylanguage-to-core [20:10:41] <dr0ptp4kt> YuviPanda and bearND i gotta disconnect and reconnect. irc client messed up [20:10:47] <YuviPanda> dr0ptp4kt: two things - 1. the TLS patch, can't we just set a global flag and have PageTitle give back a non m. ApiDomain? 2. the patch :) I'm going to force a repo sync to translatewiki.net soon [20:10:48] <bearND> YuviPanda: cool. dr0ptp4kt: did you want amend your string changes so we can merge it before YuviPanda triggers a sync to twn? [20:10:49] <YuviPanda> dr0ptp4kt: ah, ok [20:12:29] <bearND> dr0ptp4kt: if you take out the code which makes the buttons bold and adjust the strings based on the comments i think we can merge it [20:12:38] <YuviPanda> dr0ptp4kt: two things - 1. the TLS patch, can't we just set a global flag and have PageTitle give back a non m. ApiDomain? 2. the patch :) I'm going to force a repo sync to translatewiki.net soon [20:12:44] <dr0ptp4kt> YuviPanda and bearND, ah i see you went in and re-reviewed ps2 of https://gerrit.wikimedia.org/r/#/c/140625. i'm a little behind on email and such [20:12:51] <YuviPanda> dr0ptp4kt: :) 'tis k [20:12:54] <dr0ptp4kt> bearND: the bolding of the button came from ux? [20:12:58] <dr0ptp4kt> i mean, it did. [20:13:22] <YuviPanda> dr0ptp4kt: it's still inconsistent with other dialogs inside the app and rest of Android, so should go. [20:13:54] <bearND> YuviPanda: never seen an Android app that does this [20:13:58] <dr0ptp4kt> YuviPanda and bearND i'm okay with that, we'll just need to explain this to vibha [20:14:11] <dr0ptp4kt> bearND and YuviPanda: yeah, it's more common on ios [20:14:19] <dr0ptp4kt> not quite so much on android in my experience, either [20:14:35] <bearND> http://developer.android.com/design/patterns/pure-android.html [20:14:57] <YuviPanda> dr0ptp4kt: yeah, usually we help out the designers with things that don't make sense on Android, since they don't really use Android much. So next time you get something from UX that seems to break something on Android, do push back :) [20:15:32] <YuviPanda> dr0ptp4kt: the designers, at least for now, rely on us for that pushback. [20:16:18] <dr0ptp4kt> YuviPanda: cool. bearND and YuviPanda i'm gonna go through the comments and make appropriate updates. regarding the tls thing, lemme address after the strings stuff [20:16:26] <YuviPanda> dr0ptp4kt: sure. [20:18:23] <dr0ptp4kt> YuviPanda and bearND, can you remind me if the current app session keeps an "unlimited" number of pages in cache without requiring a server hit? [20:18:50] <YuviPanda> dr0ptp4kt: nope, doesn't. keeps 3-4 I think, and that too only in the backstack. Tapping 'history' requires a server hit [20:18:53] <dr0ptp4kt> YuviPanda and bearND, if so, i'll change the verbiage. if it's unreliable, i'll just axe the part about pages from the current session (i'm axing "Recent" altogether) [20:19:01] <YuviPanda> dr0ptp4kt: yeah, just axe it [20:19:03] <dr0ptp4kt> YuviPanda: thx. [20:19:12] <YuviPanda> dr0ptp4kt: simpler messages are better :) [20:19:20] <bearND> dr0ptp4kt: in the Android app Recent is called History btw [20:19:28] <dr0ptp4kt> YuviPanda: right, it's only "Saved pages" that don't incur a hit, right? [20:19:44] <YuviPanda> dr0ptp4kt: yes. [20:19:50] <dr0ptp4kt> YuviPanda: cool [20:20:07] <bearND> dr0ptp4kt: as long as everything went fine and all the images were successfully saved [20:20:24] <dr0ptp4kt> bearND: <fingers crossed> [20:20:39] <bearND> if an image doesn't get saved we don't replace the link and therefore we could try to download from the net [20:20:47] <grrrit-wm> (03PS1) 10Mhurd: Updated wikifont and preview license/CC copy. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/140807 [20:21:11] <bearND> there would be an error message toast that some images are missing [20:21:19] <bearND> or could not be saved [20:22:04] <bearND> dr0ptp4kt: ^ [20:23:17] <YuviPanda> bearND: hmm, weird. the py script seems to have lost docs when you updated the PS, and also reset author on the patch. Maybe I didn't commit the docs in the first ps [20:24:26] <grrrit-wm> (03PS1) 10Yuvipanda: Add docs to make-beta script [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/140810 [20:24:30] <YuviPanda> bearND: ^ [20:25:45] <mhurd> brion: ok i think this should have the ios 6 CC icon displaying properly: https://gerrit.wikimedia.org/r/#/c/140807/ [20:25:55] <ashley> I guess that https://www.mediawiki.org/wiki/Mobile_Contact_US isn't very current either, since it's been without status updates for two years... [20:25:59] <bearND> YuviPanda: never saw the docs until now [20:26:11] <YuviPanda> bearND: yeah, must've been a git snafu on my end [20:26:41] <bearND> YuviPanda: but thanks for adding them :) merging shortly [20:27:02] <YuviPanda> bearND: :D yeah, I like to make sure I doc all my python code, or the ghost of ori will haunt me in my dreams [20:28:43] <dr0ptp4kt> YuviPanda and bearND: changes made, just going to test locally before i submit them to gerrit. as for adding more w0 detection points in different parts of the app i'd like to do that on a separate patch. [20:29:05] <YuviPanda> dr0ptp4kt: yeah, sure. and I wouldn't mind if we even made that after the release [20:29:45] <dr0ptp4kt> YuviPanda: i'm going to try to as much stuff as possible, although i think maybe even the tls stuff comes before that...maybe i can do it all. we're in bugfix mode after the beta tonight leading up to the release, right? [20:30:15] <YuviPanda> dr0ptp4kt: yeah, but only critical bug fixes and or minor fixes. We'll make a branch and cherry-pick only some of the things starting next week [20:31:20] <dr0ptp4kt> YuviPanda: right [20:32:37] <grrrit-wm> (03PS2) 10BearND: Add docs to make-beta script [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/140810 (owner: 10Yuvipanda) [20:32:50] <bearND> YuviPanda: ^ just fixed a typo [20:33:05] <YuviPanda> bearND: cool [20:33:15] <grrrit-wm> (03CR) 10BearND: [C: 032] Add docs to make-beta script [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/140810 (owner: 10Yuvipanda) [20:33:35] <grrrit-wm> (03Merged) 10jenkins-bot: Add docs to make-beta script [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/140810 (owner: 10Yuvipanda) [20:37:59] <jgonera> awjr, yes, the page actions on main page seems to be outdated, I'll fix it later today [20:40:06] <tfinc> Deskana: how is sign off going for https://trello.com/b/KNqImlQo/mobile-app-sprint-33-the-final-android-countdown ? [20:40:24] <Deskana> tfinc: Slowly. I'm blizting some comms stuff for Katherine right now. [20:40:31] <Deskana> *blitzing [20:40:41] <Deskana> I'm hoping to get to it later today. [20:41:41] <tfinc> Deskana: ok. it's important to get through it today if engineers need to do any additional touch up [20:41:51] <tfinc> tomorrow will be too late for most things [20:44:34] <bearND> YuviPanda: we don't save the thumbnails of saved pages which appear on the saved pages screen. Maybe we should, or at least dr0ptp4kt stops mentioning saved pages in the W0 text from being exempt. There would still be data charges for those. [20:45:03] <YuviPanda> bearND: only if they're out of zero mode intermittently [20:45:10] <YuviPanda> bearND: and yeah, we should save these thumbnails [20:46:12] <awjr> great jgonera thnx [20:46:14] <Deskana> tfinc: Sure. [20:51:33] <grrrit-wm> (03PS1) 10Yuvipanda: Make all messages containing links use CDATA [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/140816 [20:51:35] <grrrit-wm> (03CR) 10jenkins-bot: [V: 04-1] Make all messages containing links use CDATA [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/140816 (owner: 10Yuvipanda) [20:52:11] <grrrit-wm> (03PS2) 10Yuvipanda: Make all messages containing links use CDATA [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/140816 [20:52:19] <YuviPanda> bearND: my phone is dead again :( can you finish up this patch? I promise to finish up the update all pages patch tomorrow! [20:53:16] <YuviPanda> sorry I've not been as productive today as I'd have liked to be. [20:53:42] <tfinc> brion: Deskana: mhurd: any thoughts on the JD that i sent you yesterday ? [20:54:03] <Deskana> tfinc: I skimmed it and it looked fine to me. [20:54:23] <brion> i liked what i saw, lemme check the current version [20:54:53] <awjr> kaldari: can you take a look at https://gerrit.wikimedia.org/r/#/c/137734/ when you have a chance? this is the last open thing jon was working on and i'd like to get it closed out before we forget about it. i know jgonera had commented on, but i htink he's got his hands really full today [20:55:06] <kaldari> sure [20:55:19] <awjr> ty :D [20:56:52] <YuviPanda> dr0ptp4kt: dbrant bearND my phone isn't working, and I'm also a bit knackered. Mind if I go to sleep for now? I've not had a productive day, I'll try to catch up over the weekend, if that's ok. [20:57:25] <dbrant> YuviPanda: no worries from my end [20:57:30] <YuviPanda> ok [20:57:36] <flyingclimber> thanks YuviPanda [20:58:02] <brion> tfinc: i added a couple comments [20:58:52] <dr0ptp4kt> YuviPanda: yeah, that's cool. dbrant, you'll handle the amended patch for w0? [20:58:59] <YuviPanda> bearND: dbrant do see if either of you can complete https://gerrit.wikimedia.org/r/#/c/140816/ so I can get that merged and exported to translatewiki.net tomorrow. Should be reasonably simple to do... (make sure any message with <a> tags in it is surrounded by cdata, and parse the response as HTML in code... [20:59:12] <grrrit-wm> (03CR) 10Dr0ptp4kt: Per UX feedback, relabel, bold some buttons, always show OFF. (039 comments) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/140625 (owner: 10Dr0ptp4kt) [20:59:28] <grrrit-wm> (03PS3) 10Dr0ptp4kt: Per UX feedback, relabel W0 buttons, always show OFF. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/140625 [20:59:38] <YuviPanda> dr0ptp4kt: also update commit message :) [21:00:03] <grrrit-wm> (03CR) 10Kaldari: [C: 04-1] Emit events after delay to support chaining (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/137734 (https://bugzilla.wikimedia.org/65633) (owner: 10Jdlrobson) [21:00:07] <bearND> YuviPanda: sure, so for the CDATA patch you want me to do the html decode in the java part, and you will do the import to twn tomorrow? [21:00:22] <kaldari> awjr: reviewed (although -1) [21:00:40] <YuviPanda> bearND: yeah. if you just run it as is now, you'll get raw HTML output wherever the messags are used rather than actual links [21:00:48] <dr0ptp4kt> ^ bearND, amended patch submitted. per the mocks, i took out the "Settings" button on the external link interstitial dialog box [21:00:56] <dr0ptp4kt> YuviPanda: i updated the commit message [21:01:13] <mhurd> tfinc_: added comments to js as well [21:01:15] <YuviPanda> dr0ptp4kt: aaah, cool. didn't look too clearly, sorry. [21:01:22] <tfinc_> mhurd: thank you [21:01:43] <dr0ptp4kt> YuviPanda: it's all good. before you go to bed, could you elaborate just a little bit more on the tls thing? [21:02:03] <bearND> YuviPanda: ok, no problem [21:02:08] <dr0ptp4kt> YuviPanda: if you need to go to bed and want to discuss it tomorrow instead, that's cool, too. i'd really like to get the barebones thing in place at least [21:02:29] <YuviPanda> dr0ptp4kt: sure! so we decide which domain to hit based on Site#getApiDomain, right? so if we find out that we have SSL errors on the m. domain, we can set a flag somewhere global (WikipediaApp?) and check for that in Site.java to return non m. [21:02:57] <YuviPanda> dr0ptp4kt: and then have the 'retry and if fails switch' code wherever you have it right now, so it'll trigger everytime the app starts [21:03:54] <grrrit-wm> (03PS1) 10JGonera: Track "Read in another language" button clicks [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/140818 [21:03:59] <awjr> kaldari: given that jon is now focused on flow stuff, do you think you could take ownership of that patchset/bug? [21:04:09] <kaldari> sure [21:04:13] <jgonera> kaldari, Maryana says this is pretty important https://gerrit.wikimedia.org/r/140818 [21:04:19] <jgonera> we might even want to lightning deploy it [21:04:20] <Maryana> logging? [21:04:22] <YuviPanda> dr0ptp4kt: did that make sense? [21:04:23] <jgonera> yes [21:04:26] <Maryana> \o/ [21:04:28] <dr0ptp4kt> YuviPanda: that's what it does. are you saying to add a piece of code that will make a synthetic check at app startup for the purpose of making that determination? as it is, on app startup, the load of Main Page already has that same effect, i think [21:04:30] <awjr> thanks kaldari :) [21:04:36] <jgonera> btw, I discovered that ALL the logging in the left nav is broken [21:04:42] <jgonera> fixing that now [21:04:43] <grrrit-wm> (03PS2) 10Mhurd: Updated wikifont and preview license/CC copy. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/140807 [21:04:59] <YuviPanda> dr0ptp4kt: aaah, no. I read the 'should we make other parts of the app also aware' as if they aren't reading from the non-desktop site, but if that's what they're doing everything seems fine :) [21:05:04] <jgonera> that's a side effect of jdlrobson's icon clean up I think, we didn't catch that [21:05:45] <dr0ptp4kt> YuviPanda: the deal is that the other parts of the app have onCatches that implicitly obscure that specific type of exception. so i was wondering if i should do a full pass on all of those onCatch()s [21:05:51] <awjr> kaldari: i updated https://trello.com/c/9OmgKBjY/30-bug-65633-last-modified-breaks-on-back-button-when-lazy-loading-pages to reflect that, thanks again [21:05:53] <dr0ptp4kt> YuviPanda: now, does /that/ make sense? LOL [21:06:00] <YuviPanda> dr0ptp4kt: ah, yes, it does. [21:06:09] <kaldari> thanks [21:06:15] <dr0ptp4kt> dr0ptp4kt: so.... [21:06:16] <YuviPanda> dr0ptp4kt: nah, I don't think we should handle the case where suddenly censorship is switched on halfway through using the app [21:06:41] <brion> well, say you’re using the app offline on the plane [21:06:45] <dr0ptp4kt> YuviPanda: okay, is this on mvp pragmatist grounds? ;) that's fine with me, would you please place your ruling on that email thread? :) [21:06:47] <brion> then you arrive in beijing [21:06:50] <brion> and turn on wifi [21:07:02] <mhurd> brion: ok the 2 patches in cr should be good to go. just amended the wikifont one to use proper back glyphs for editing and preview screens [21:07:07] <brion> great :D [21:07:16] <dr0ptp4kt> brion: lol, just don't be trying to start editing from that spot, you'll need to restart the app or go back to an article and tap on something [21:07:22] <brion> hehe [21:07:45] <tfinc_> mhurd: responded to your issue on the doc [21:08:08] <brion> mhurd: ooh are those thicker arrows? they look different [21:08:30] <mhurd> brion: ya see the mock here: https://trello-attachments.s3.amazonaws.com/52e98a603e6d08a53861025b/531799dfc55d38b46d5cddba/5992x4208/200b92c873bd852b6c34da991aa3c6f7/Editing_MVP_June12.png [21:08:39] <brion> nice [21:08:45] <brion> they feel more consistent with our other top-bar icons now [21:08:49] <mhurd> brion: it’s the caret char from wikifont :) [21:08:54] <grrrit-wm> (03PS1) 10JGonera: Regression: Fix logging of left nav clicks [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/140821 [21:09:13] <mhurd> brion: agreed [21:09:33] <grrrit-wm> (03CR) 10Brion VIBBER: [C: 032 V: 032] "looks good!" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/140807 (owner: 10Mhurd) [21:09:40] <jgonera> kaldari, fix for logging left nav items clicks: https://gerrit.wikimedia.org/r/140821 [21:09:42] <mhurd> brion: yay! [21:10:20] <mhurd> brion: sry about the confusion on the housekeeping patch. it ended up getting a bit more complicated than i thought, but it seems super solid [21:10:27] <brion> no worries [21:10:54] <brion> lemme rebase it… [21:11:09] <brion> wooo CONFLICT (content): Merge conflict in Wikipedia.xcodeproj/project.pbxproj [21:11:32] <brion> easy fix [21:11:49] <grrrit-wm> (03PS2) 10Brion VIBBER: Periodically remove old / unused article and associated data. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/140572 (owner: 10Mhurd) [21:13:02] <YuviPanda> dr0ptp4kt: will do so :) also is the patch in gerrit yet? [21:13:24] <dr0ptp4kt> YuviPanda: was hoping we could slipstream into another patch, but I can submit it to gerrit. shall i? [21:13:26] <mhurd> brion: had to adjust a couple things to have the preview icons persist for articles which still had history entries, but for which we’d purged other data [21:13:39] <YuviPanda> dr0ptp4kt: yeah. [21:13:43] <brion> aha [21:13:47] <YuviPanda> dr0ptp4kt: it's ok, I think. [21:13:50] <mhurd> brion: but seems solid now [21:14:11] <grrrit-wm> (03PS1) 10Dr0ptp4kt: Handle connection errors better. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/140824 [21:14:15] <dr0ptp4kt> ^ YuviPanda [21:14:49] <YuviPanda> dr0ptp4kt: cool. I bet one of the others will get to it soon, if not I'll try to take a peek tomorrow [21:15:33] <YuviPanda> ok, can't seem to fix the phone right now. I'm going to let it charge overnight. Am off guys, cya. [21:15:37] <brion> lol @ ifNoThumbnailUseFirstSectionImageAsThumbnailUsingContext [21:17:08] <dr0ptp4kt> brion: lol, and yay [21:17:37] <brion> it’s gonna be weird getting used to mixing obj-c and swift [21:17:56] <brion> swift has a sort of half-way between method/parameter naming of obj-c and c/java/etc styles [21:18:46] <brion> like NSURL(string: mystring) instead of [NSURL URLWithString:mystring] [21:18:50] <dr0ptp4kt> brion: it's ruby and obj-c, on fruit juice [21:18:53] <brion> heh [21:19:18] <grrrit-wm> (03PS1) 10JGonera: Fix page actions browser tests [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/140826 [21:19:23] <jgonera> chrismcmahon, ^ [21:19:35] <brion> thank goodness ‘[stringA stringByAppendingString:stringB]’ is replaced with ‘stringA + stringB’ [21:20:07] <brion> mhurd: oh if you haven’t seen, they’ve dropped a second swift book into iBooks store, about Cocoa & obj-c interop [21:20:15] <brion> i recommend it, and also the wwdc session videos [21:20:31] <dr0ptp4kt> yeah :) i do like the notion of being able to (or at least not being dissuaded from) name all params [21:20:46] <dr0ptp4kt> (the first param, in particular) [21:20:58] <brion> oh yeah, after years of PHP dealing with *mysterious boolean parameters* i really appreciate param names [21:21:06] <brion> PHP/Java/C/whatever [21:21:16] <brion> people love my_annoying_function(param1, param3, FALSE) [21:21:21] <brion> FALSE WHAT? [21:21:57] <brion> also they have non-nullable reference types which i’m excited about [21:22:08] <brion> especially since obj-c’s behavior with nil is …. unreliable [21:22:13] <grrrit-wm> (03CR) 10Cmcmahon: [C: 032] "wfm" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/140826 (owner: 10JGonera) [21:22:20] <brion> calling a method on a nil object fails silently in objc :) it’s insane [21:22:28] <brion> but various other things will still crash ya [21:22:47] <grrrit-wm> (03Merged) 10jenkins-bot: Fix page actions browser tests [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/140826 (owner: 10JGonera) [21:23:36] <brion> mhurd: ok so we’re running the housekeeping on viewDidAppear in the reader screen? [21:23:36] <dr0ptp4kt> i sort of like that non-crashiness, but it's a source of silent and deadly errors! [21:23:52] <dr0ptp4kt> being able to express it's non-nullable is cool [21:23:56] <brion> i’m slightly worried that looks like it’s on the main thread, could delay some drawing if there’s a lot of cached stuff [21:24:28] <brion> hm, i wonder if the swift compiler is/will be open-source or if it’s all proprietary [21:24:41] <brion> this might be revenge for GNU forcing NeXT to open their gcc obj-c extensions ;) [21:25:48] <grrrit-wm> (03CR) 10Brion VIBBER: "Looks functional but I'm a little worried that the housekeeping tasks appear to run on the UI thread in the web view controller's viewWill" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/140572 (owner: 10Mhurd) [21:26:36] <grrrit-wm> (03PS4) 10Kaldari: Emit events after delay to support chaining [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/137734 (https://bugzilla.wikimedia.org/65633) (owner: 10Jdlrobson) [21:27:16] <grrrit-wm> (03CR) 10jenkins-bot: [V: 04-1] Emit events after delay to support chaining [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/137734 (https://bugzilla.wikimedia.org/65633) (owner: 10Jdlrobson) [21:27:50] <grrrit-wm> (03PS2) 10Dr0ptp4kt: Handle connection errors better. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/140824 [21:27:54] <grrrit-wm> (03CR) 10Kaldari: [C: 032] Track "Read in another language" button clicks [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/140818 (owner: 10JGonera) [21:28:28] <grrrit-wm> (03Merged) 10jenkins-bot: Track "Read in another language" button clicks [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/140818 (owner: 10JGonera) [21:28:28] <Maryana> jgonera: thanks for fixing the left nav logging - i thought it looked a bit fubar [21:29:07] <tfinc_> Deskana: i'd like to set some time aside to clean out the ToDO bugs in https://trello.com/b/KNqImlQo/mobile-app-sprint-33-the-final-android-countdown in prep for sprint 34 [21:29:24] <tfinc_> it needs house cleaning [21:29:42] <tfinc_> bearND: how goes reviewing the patchsets that dbrant has in https://trello.com/b/KNqImlQo/mobile-app-sprint-33-the-final-android-countdown ? [21:29:54] <tfinc_> overall we have way too many deep columns all over the place [21:30:04] <grrrit-wm> (03PS1) 10JGonera: Fix VE browser tests [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/140829 [21:30:08] <tfinc_> so i'm eager to move a lot of this work [21:30:12] <jgonera> chrismcmahon, another one ^ [21:31:49] <dbrant> tfinc_: those are mostly one-liners; should be easy to knock out by bearND or YuviPanda|zzz tomorrow [21:31:52] <bearND> tfinc_: am going to CR those soon [21:32:05] <Deskana> tfinc_: I'm pretty much melting down from all the things I'm trying to juggle right now. Can we do it tomorrow? [21:33:24] <chrismcmahon> jgonera: I'll go ahead and merge that for the tests to go green, but I'm a little concerned about the cruft left behind now unused [21:33:50] <jgonera> chrismcmahon, what cruft? I checked the steps, they're used in other features [21:34:18] <chrismcmahon> jgonera: thanks! I had not checked. [21:34:31] <grrrit-wm> (03CR) 10Cmcmahon: [C: 032] Fix VE browser tests [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/140829 (owner: 10JGonera) [21:35:06] <grrrit-wm> (03Merged) 10jenkins-bot: Fix VE browser tests [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/140829 (owner: 10JGonera) [21:38:24] <grrrit-wm> (03CR) 10Kaldari: [C: 04-1] "I'm a bit skeptical of the approach here. Isn't there a chance that this will cause some events to be lost if there is a page load in the " [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/137734 (https://bugzilla.wikimedia.org/65633) (owner: 10Jdlrobson) [21:39:19] <mhurd> brion: checking on the background thread stuff... [21:39:47] <kaldari> jdlrobson, jgonera, awjr: Actually, I think I'm going to need some more input on https://gerrit.wikimedia.org/r/#/c/137734/ as I'm not sure this is the best approach. [21:40:22] <jgonera> chrismcmahon, photo uploads are failing on beta labs, API returns error 500, but I have no idea why, they work for me locally (that's why Scenario: Upload image file is failing) [21:40:32] <jgonera> awjr_away, ^ who should I poke about this? [21:40:59] <jgonera> kaldari, I have mixed feelings about it too, any other ideas? [21:41:20] <chrismcmahon> jgonera: marktraceur about photo uploads failing on beta? [21:41:47] <marktraceur> chrismcmahon: How are they failing? [21:42:49] <chrismcmahon> marktraceur: dunno, I was just going to check. jgonera says "API returns error 500" but I know it was working just a little while ago because I was futzing with UW in IE10 [21:43:02] <marktraceur> Hm [21:43:31] <jgonera> marktraceur, I tried uploading manually in mobile view in Special:Uploads, and after the progress bar went to 100%, API returned error 500 [21:43:48] <marktraceur> Hm [21:43:55] <marktraceur> I'm going to check 'er on UW [21:44:24] <marktraceur> Yeah I get a weird error too [21:44:56] <marktraceur> Retrying makes it work [21:45:30] <grrrit-wm> (03CR) 10BearND: [C: 04-1] "Still getting "Could not reach the network :(" when I open a saved page from History." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/140735 (https://bugzilla.wikimedia.org/66818) (owner: 10Dbrant) [21:45:53] <kaldari> jgonera: Since we're getting rid of lazy loading, do we even need to fix bug 65633? [21:46:33] <dbrant> bearND: checking... [21:46:43] <kaldari> wonder if it affects the editing workflow... [21:46:57] <bearND> dbrant: turn on airplane mode and then go to history [21:48:21] <grrrit-wm> (03Abandoned) 10BearND: Merge branch 'master' into beta [apps/android/wikipedia] (beta) - 10https://gerrit.wikimedia.org/r/140612 (owner: 10BearND) [21:48:26] <marktraceur> I get mixed results on betacommons UW [21:50:03] <chrismcmahon> jgonera: this is odd, I can't get beyond the "Describe image" step at http://en.m.wikipedia.beta.wmflabs.org/wiki/Special:Uploads [21:50:10] <kaldari> jgonera: Hmm, looks like it does affect pages lazy-loaded via editing as well [21:50:37] <kaldari> jgonera: Why exactly do we lazy load edited pages? [21:50:45] <chrismcmahon> jgonera: scratch that, button was hidden [21:51:57] <dbrant> bearND: so the way I'm testing it is: 1) open a page from Saved Pages, 2) navigate to different pages while online, 3) go offline, click History, and select the saved page from there. That's working for me. [21:52:20] <dbrant> bearND: what were your steps? [21:54:19] <bearND> dbrant: almost the same except the beginning. i only saved the page before i went offline. i didn't open it again [21:54:53] <brion> bbiab errands [21:55:46] <chrismcmahon> jgonera marktraceur works for me now on http://en.m.wikipedia.beta.wmflabs.org/wiki/Special:Uploads it seems [21:56:21] <tfinc_> Deskana: sure, can i take something off your plate to help ? [21:56:43] * Deskana thinks. [21:56:45] <bearND> tfinc_ dbrant: question about https://bugzilla.wikimedia.org/show_bug.cgi?id=66817. What specifically does step #2 mean? Tap where and type what? [21:57:13] <bearND> is this using "Read in other language"? [21:57:17] <tfinc_> bearND: yes [21:57:20] <tfinc_> interwiki links [21:57:35] <tfinc_> keyboard doesn't dismiss after you've typed in a language and selected it [21:57:49] <Deskana> tfinc_: I think if you could check over the comms stuff that was just forwarded to you and see if it makes sense, that would be great. Also if you could check my blog post to make sure it's not ridiculous. [21:57:57] <Deskana> tfinc_: It's just my first pass, I want to refine it further tomorrow. [21:58:15] <dbrant> bearND: so your saved page technically didn't make it into History, because you didn't "navigate" to it. You navigated to the live page, and then saved it. [21:58:18] <Deskana> I could use some palette cleansing from all this email writing that I'm doing. The signoff could do that. [21:58:32] <bearND> tfinc_: hmm, weird. keyboard goes away when i select another language from "Read in other language" [21:58:38] <bearND> even before the patch [21:59:06] <tfinc_> Deskana: normally i'd edit and use comments in a google doc draft for these. how would you like me to do it as its on a wiki page ? [21:59:35] <Deskana> tfinc_: Edit mercilessly. I'll refine/revert as necessary. It is a wiki, after all! :-) [21:59:42] <tfinc_> ok [21:59:42] <Deskana> tfinc_: Or leave comments on the talk page if you prefer [22:00:19] <tfinc_> i don't. the disconnect between talk pages and article page content always gets me really annoyed and gets me to stop paying attention [22:00:32] <tfinc_> i'll edit [22:03:09] <dbrant> bearND: unless you're suggesting that, when someone clicks a History item, we check if there's a saved version of it. But I think that would be a much more complex issue. [22:03:32] <dr0ptp4kt> dbrant: sorry, i failed to point it out after submission. i resubmitted https://gerrit.wikimedia.org/r/140625 - lemme know if i need to change the "Saved pages" bit (if you have / will have the thumb in place in the list, no change, i think) [22:03:39] <dr0ptp4kt> i mean bearND ^ [22:04:54] <bearND> dbrant: if you want to do this as a separate patch that fine with me, but i don't think the bug is fully resolved [22:05:25] <grrrit-wm> (03PS3) 10Mhurd: Periodically remove old / unused article and associated data. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/140572 [22:05:45] <dr0ptp4kt> dbrant and bearND - irc issues again, gonna recycle connection [22:07:02] <bearND> dr0ptp4kt: i still would skip mentioning saved pages being excluded from data charges until we have the thumbnails covered, too [22:07:06] <grrrit-wm> (03Abandoned) 10Mhurd: Periodically remove old / unused article and associated data. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/140572 (owner: 10Mhurd) [22:07:16] <dr0ptp4kt> bearND, cool, one moment [22:07:59] <dbrant> bearND: agreed; I'll un-depend the other patch... [22:08:09] <jgonera> chrismcmahon, marktraceur now it does work for me... marktraceur have you changed anything? [22:08:27] <chrismcmahon> jgonera: yeah, it failed for me several times in a row, then worked [22:08:31] <grrrit-wm> (03PS4) 10Dr0ptp4kt: Per UX feedback, relabel W0 buttons, always show OFF. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/140625 [22:08:39] <dr0ptp4kt> bearND: ^ [22:08:46] <dr0ptp4kt> that removes the Saved pages bit [22:09:04] <marktraceur> jgonera: I haven't [22:09:04] <jgonera> kaldari, possibly we could skip that fix if it's controversial, I want to talk to Jon before we make the final decision about dynamic page loading [22:09:49] <jgonera> chrismcmahon, so I guess betalabs is just unreliable... I don't have time now to learn how to check the logs and investigate where those 500 errors come from. anyone we could ask for help? [22:09:53] <kaldari> jgonera: I agree. It seems to be a fairly edge case bug anyway. [22:10:25] <yurikR> dr0ptp4kt, are we meeting today? [22:10:57] <dr0ptp4kt> yurikR: not sure, left a vm, i'll hop back on the hangout [22:11:08] <grrrit-wm> (03PS2) 10Dbrant: Hide keyboard when interwiki link selected. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/140767 (https://bugzilla.wikimedia.org/66817) [22:11:55] <dbrant> bearND: I moved the others back to "doing" for now [22:12:25] <bearND> dbrant: ok [22:14:54] <grrrit-wm> (03PS1) 10Mhurd: Periodically remove old / unused article and associated data. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/140836 [22:15:19] <grrrit-wm> (03PS5) 10BearND: Per UX feedback, relabel W0 buttons, always show OFF. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/140625 (owner: 10Dr0ptp4kt) [22:15:59] <grrrit-wm> (03CR) 10BearND: [C: 032] Per UX feedback, relabel W0 buttons, always show OFF. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/140625 (owner: 10Dr0ptp4kt) [22:16:11] <dr0ptp4kt> bearND: thx [22:16:13] <grrrit-wm> (03CR) 10Mhurd: "Brion sorry I had to re-submit. For the record your comment is below:" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/140836 (owner: 10Mhurd) [22:16:23] <bearND> dr0ptp4kt: sure [22:16:42] <dr0ptp4kt> bearND: what's the exact cutoff for code for the the moment when it goes to beta and it's only "major" issues that are allowed to be treated? [22:17:08] <grrrit-wm> (03Merged) 10jenkins-bot: Per UX feedback, relabel W0 buttons, always show OFF. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/140625 (owner: 10Dr0ptp4kt) [22:17:33] <bearND> dr0ptp4kt: i think YuviPanda|zzz said something about Friday [22:17:48] <dr0ptp4kt> bearND: k, so i should upload like 8,100 lines of code, right? ;) [22:17:55] <dr0ptp4kt> KIDDING! [22:18:01] <bearND> lol [22:18:07] <jgonera> chrismcmahon, I'm leaving "Scenario: Edit button updates when lazy load a page from search via JavaScript" broken for now. I'm not sure why it's broken and why it requires a protected page, I'll ask Jon whenever I see him [22:18:18] <Technical_13> You mean 8,100,000 -- right? [22:18:36] <grrrit-wm> (03CR) 10Mhurd: "I switched it to use a background thread." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/140836 (owner: 10Mhurd) [22:19:01] <jgonera> awjr_away, Maryana so I analyzed all the failing tests, fixed most of them, one of them is failing because of betalabs flakiness and the last one tests something in alpha but I'm unsure why it does it the way it does [22:19:17] <Maryana> thanks jgonera [22:19:20] <Maryana> i suspected as much [22:19:53] <Maryana> are any of the tests running on search? i'm still seeing weirdness with that on phone and tablet [22:20:05] <Maryana> tapping doesn't consistently take me to search results [22:20:18] <Maryana> but this is in prod, so if there's a fix, maybe it hasn't made it to enwiki [22:20:20] <Maryana> jgonera: ^^ [22:20:53] <kaldari> MaxSem: If you ask me, I'm not even sure that's the correct behavior. Personally, I would only expect a link to a special page to render as a redlink if the special page wasn't registered. [22:21:00] <jgonera> Maryana, not sure if there are tests for this, also not sure if they would catch it anyway, it seems to be failing only in some cases [22:21:19] <kaldari> but maybe that's just me [22:21:33] <Maryana> kaldari: MaxSem ? [22:21:40] <Maryana> redlinks special pages what now? [22:21:42] <Maryana> :) [22:21:44] <jgonera> kaldari, when you have a moment check https://gerrit.wikimedia.org/r/#/c/140821/ (I checked it with EL devserver), Maryana probably would like that be part of LD too to have something to compare the languages button clicks to [22:21:57] <Maryana> yesss [22:22:00] <Maryana> +1000 [22:22:03] <MaxSem> Maryana, Special:MyLanguages [22:22:20] <kaldari> Maryana: don't worry, not mobile related :) [22:22:24] <Maryana> haha, ok [22:22:27] * Maryana tunes it out [22:22:33] <MaxSem> well, not yet related;) [22:22:55] <Maryana> not mobile, don't curr [22:23:53] <grrrit-wm> (03CR) 10Kaldari: [C: 032] Regression: Fix logging of left nav clicks [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/140821 (owner: 10JGonera) [22:25:18] <grrrit-wm> (03Merged) 10jenkins-bot: Regression: Fix logging of left nav clicks [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/140821 (owner: 10JGonera) [22:26:33] <grrrit-wm> (03PS3) 10BearND: Hide keyboard when interwiki link selected. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/140767 (https://bugzilla.wikimedia.org/66817) (owner: 10Dbrant) [22:26:56] <grrrit-wm> (03CR) 10BearND: [C: 032] Hide keyboard when interwiki link selected. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/140767 (https://bugzilla.wikimedia.org/66817) (owner: 10Dbrant) [22:27:21] <grrrit-wm> (03Merged) 10jenkins-bot: Hide keyboard when interwiki link selected. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/140767 (https://bugzilla.wikimedia.org/66817) (owner: 10Dbrant) [22:27:29] <bearND> dbrant|bbl: tfinc_: be back in a couple of hours [22:30:19] <ragesoss> Test2.wikipedia.org does not play nicely with the Android app. [22:31:21] <chrismcmahon> eh, missed jgonera [22:33:29] <ragesoss> chrismcmahon ^ [22:33:39] <chrismcmahon> thanks ragesoss [22:34:54] <chrismcmahon> jgonera: I was actually just now looking at the protected page stuff, it is kind of messy. At bare minimum explicitly logging out is going to cause problems for parallel tests (if it isn't already) [22:35:50] <chrismcmahon> jgonera: like you said, I'm not going to refactor it today, but I might take a crack tomorrow or next week [22:42:07] <grrrit-wm> (03CR) 10Brion VIBBER: "Yeah, it's fine to trigger then, as long as we don't block. :D" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/140836 (owner: 10Mhurd) [22:42:36] <grrrit-wm> (03CR) 10Mhurd: "Yay!" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/140836 (owner: 10Mhurd) [22:47:04] <grrrit-wm> (03CR) 10Brion VIBBER: Periodically remove old / unused article and associated data. (031 comment) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/140836 (owner: 10Mhurd) [22:52:04] <jgonera> chrismcmahon, we can disable this test temporarily, we might get rid of dynamic page loading soon [22:54:00] <grrrit-wm> (03CR) 10Mhurd: Periodically remove old / unused article and associated data. (031 comment) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/140836 (owner: 10Mhurd) [22:54:07] <mhurd> brion: ^ added comment [22:54:59] <brion> mhurd: fair enough, let’s merge this and profile it if necessary later [22:55:05] <mhurd> brion: coolness [22:55:27] <grrrit-wm> (03CR) 10Brion VIBBER: [C: 032 V: 032] Periodically remove old / unused article and associated data. (031 comment) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/140836 (owner: 10Mhurd) [22:55:31] <grrrit-wm> (03PS1) 10JGonera: Track "Read in another language" button clicks [extensions/MobileFrontend] (wmf/1.24wmf9) - 10https://gerrit.wikimedia.org/r/140856 [22:55:42] <grrrit-wm> (03CR) 10JGonera: [C: 032] Track "Read in another language" button clicks [extensions/MobileFrontend] (wmf/1.24wmf9) - 10https://gerrit.wikimedia.org/r/140856 (owner: 10JGonera) [22:56:05] <Maryana> kaldari: is the banner still running? [22:56:06] <grrrit-wm> (03PS1) 10JGonera: Track "Read in another language" button clicks [extensions/MobileFrontend] (wmf/1.24wmf10) - 10https://gerrit.wikimedia.org/r/140857 [22:56:15] <grrrit-wm> (03CR) 10JGonera: [C: 032] Track "Read in another language" button clicks [extensions/MobileFrontend] (wmf/1.24wmf10) - 10https://gerrit.wikimedia.org/r/140857 (owner: 10JGonera) [22:56:28] <grrrit-wm> (03PS1) 10JGonera: Regression: Fix logging of left nav clicks [extensions/MobileFrontend] (wmf/1.24wmf9) - 10https://gerrit.wikimedia.org/r/140858 [22:56:36] <grrrit-wm> (03CR) 10JGonera: [C: 032] Regression: Fix logging of left nav clicks [extensions/MobileFrontend] (wmf/1.24wmf9) - 10https://gerrit.wikimedia.org/r/140858 (owner: 10JGonera) [22:56:49] <grrrit-wm> (03PS1) 10JGonera: Regression: Fix logging of left nav clicks [extensions/MobileFrontend] (wmf/1.24wmf10) - 10https://gerrit.wikimedia.org/r/140859 [22:56:51] <kaldari> Maryana: Yeah, it runs for 1 more hour [22:56:58] <grrrit-wm> (03CR) 10JGonera: [C: 032] Regression: Fix logging of left nav clicks [extensions/MobileFrontend] (wmf/1.24wmf10) - 10https://gerrit.wikimedia.org/r/140859 (owner: 10JGonera) [22:57:05] <grrrit-wm> (03Merged) 10jenkins-bot: Track "Read in another language" button clicks [extensions/MobileFrontend] (wmf/1.24wmf9) - 10https://gerrit.wikimedia.org/r/140856 (owner: 10JGonera) [22:57:23] <kaldari> Maryana: Should I go ahead and kill it or extend it or leave it alone? [22:57:40] <Maryana> kaldari: just checking. i keep getting new blog comments -- will be somewhat relieved when they stop overwhelming my poor inbox [22:57:47] <grrrit-wm> (03Merged) 10jenkins-bot: Track "Read in another language" button clicks [extensions/MobileFrontend] (wmf/1.24wmf10) - 10https://gerrit.wikimedia.org/r/140857 (owner: 10JGonera) [22:57:48] <Maryana> but you can let it go for another hour, nbd [22:58:14] <grrrit-wm> (03Merged) 10jenkins-bot: Regression: Fix logging of left nav clicks [extensions/MobileFrontend] (wmf/1.24wmf9) - 10https://gerrit.wikimedia.org/r/140858 (owner: 10JGonera) [22:58:41] <kaldari> Maryana: Lemme know if you need to get a drink after it's finished :) [22:58:42] <grrrit-wm> (03Merged) 10jenkins-bot: Regression: Fix logging of left nav clicks [extensions/MobileFrontend] (wmf/1.24wmf10) - 10https://gerrit.wikimedia.org/r/140859 (owner: 10JGonera) [22:58:51] <Maryana> haha [22:59:08] <Maryana> we should all get a drink and do dramatic reenactments of some of the choicest bits of feedback [22:59:17] <Maryana> moiz was reading some aloud earlier. was pretty great. [23:00:10] <kaldari> Maryana: All in all, I thought it was relatively quiet (compared to past feature launches on desktop at least) [23:00:31] <Maryana> kaldari: whenever i start to feel a tinge of doubt or worry, i like to read through the comments here: http://publiceditor.blogs.nytimes.com/2014/01/08/times-designers-are-monitoring-reaction-to-the-redesign-with-adjustments-possible/ [23:00:47] <kaldari> lol [23:00:51] <Maryana> compared to that, this redesign launch was cake! [23:02:08] <kaldari> Maryana: I also heard that The NYT made a bunch of UI changes to their crossword app and people went totally nuts and were organizing torch mobs [23:02:38] <kaldari> Maryana: I guess you just can't mess with people's addictions [23:02:55] <Maryana> hahaha [23:03:07] <Maryana> that's. um. awesome? i don't even know. [23:03:08] <Maryana> something. [23:03:13] <Maryana> oh intarwebz [23:11:44] <mhurd> brion: time for one more small patch cr? [23:12:15] <brion> sure [23:13:04] <grrrit-wm> (03PS1) 10Mhurd: Slight increase to canned edit summary button height. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/140863 [23:13:12] <mhurd> brion: ^ here it be [23:15:59] <grrrit-wm> (03CR) 10Brion VIBBER: [C: 032 V: 032] Slight increase to canned edit summary button height. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/140863 (owner: 10Mhurd) [23:16:16] <mhurd> brion: thanks!! [23:16:40] <brion> sho thing :) [23:17:02] <mhurd> brion: merge machine! [23:17:57] <mhurd> :) [23:20:42] <mhurd> brion: food time! [23:32:43] <grrrit-wm> (03CR) 10Jdlrobson: "It would be useful for Wikisource/experimental plugins to enhance the editor in some way for example after it has rendered." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/137734 (https://bugzilla.wikimedia.org/65633) (owner: 10Jdlrobson) [23:41:51] <wikibugs> 3MobileFrontend / 3stable: Should __NOTOC__ mean no table of contents on tablet? - 10https://bugzilla.wikimedia.org/66861 (10dr0ptp4kt) 3NEW p:3Unprio s:3normal a:3None For example, https://m.wikimediafoundation.org/wiki/Wikipedia_Zero_App_FAQ shows a TOC at the bottom of the page despite having a __... [23:45:29] <wikibugs> 3MobileFrontend / 3stable: Should __NOTOC__ mean no table of contents on tablet? - 10https://bugzilla.wikimedia.org/66861#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/kZXLrqbs