[00:07:08] Deskana: i took a pass on the post and will do another later tonight. what else can i help with ? [00:07:33] tfinc_: How did that comms doc that Katherine sent out look? [00:08:31] Deskana: what feedback channel will you use for the app. email, store review, other ? [00:09:19] All of the above. [00:09:26] We should probably also create a page on mediawiki.org for it. [00:11:33] Deskana: i highly recommend not doing that to retain your sanity [00:11:50] and everyone elses [00:12:12] * Deskana thinks. [00:12:21] pick one and stick with it so that conversations stay focused and aren't duplicated [00:12:28] Let's go with store review. [00:12:31] Maryana chose to stick with the blog post and village pump [00:12:52] If people want to comment on the blog post and village pump, they can do that too. [00:12:55] were going to get store reviews wether we ask them or not so i'd focus it there [00:13:08] Village Pump doesn't do us much for the App i don't think [00:13:26] but if you think it'll raise it along power editors then more power to them [00:13:50] either way less is better here so that we're not triaging dozens of feedback streams [00:14:45] Non-Wikimedians will do app store reviews one way or another. [00:14:53] Similarly experienced Wikimedians will know how to find me. [00:15:22] So let's give people an email address they can send feedback to. [00:15:28] How about the mobile queue on OTRS? [00:18:08] (03PS1) 10Dr0ptp4kt: Updating On and Off dialog box to not have title. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/140874 [00:18:33] dbrant: wondering if you would be able to review and + 2 https://gerrit.wikimedia.org/r/140874 ? [00:19:04] dr0ptp4kt: ah yes, looking... [00:19:10] dbrant: thx [00:19:57] dbrant: the message changes are from ux too [00:20:13] Deskana: you already have mobile-android-wikipedia@wikimedia.org [00:21:46] We have an iOS queue too. [00:25:26] tfinc_: So let's do that. Android feedback to Android queue. iOS feedback to iOS queue. [00:25:50] I'll add that to the blog post [00:26:00] and its already on our store listing [00:26:57] tfinc_: Other than that, I think I'm good. [00:27:03] (03CR) 10Dbrant: [C: 032] Updating On and Off dialog box to not have title. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/140874 (owner: 10Dr0ptp4kt) [00:27:29] ruh roh [00:27:39] i just followed a wp link on my ipad & didn't get redirected [00:28:11] o_O [00:28:14] Maryana: link? [00:28:34] any link to en.wikipedia [00:28:48] i was on the mobile site yesterday :-/ [00:28:58] Deskana: excellent. i'll book you for a 30min afternoon to go through the bugs into the todo clumn [00:29:08] hopefully we'll get to them in the standup and not need it [00:29:14] Maryana: try clearing cookies and try again [00:29:26] kk [00:29:37] if you switched to the desktop site at some point, that would set a cookie that would prevent mobile redirect [00:29:47] Maryana: Did you opt out of your own product? :D [00:30:00] lulz thems fightin words [00:30:22] Maryana: redirect works for me in ios ipad simulator [00:30:35] oh wait that was an iphone simulator [00:30:53] eek [00:30:57] cleared cookies, tried again [00:31:00] dbrant: thx [00:31:00] still desktop :( [00:31:09] dr0ptp4kt: anytime [00:31:13] Maryana: :-/ [00:31:24] ipad simulator redirect works for me [00:31:47] hmm, if i clear cookies *and* history, it takes me to mobile [00:32:50] that is weird [00:32:57] i just tried on sarah's ipad and redirect worked [00:34:02] erica from the CL team also reported that she wasn't being redirected. not sure what device she's on, but i asked her to send in her info [00:34:20] @_@ [00:34:24] this could complicate our ability to see opt outs just by looking at where tablet UAs are landing... [01:11:03] (03PS2) 10Kaldari: Add text to next & save buttons in mobile editors [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/140620 [01:15:35] Deskana: add 2-3 images to the blog post and it'll be good [01:16:14] (03PS3) 10Kaldari: Add text to next & save buttons in mobile editors [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/140620 [01:20:37] Deskana: i added sharing to the feature list [03:11:36] (03PS3) 10BearND: Make all messages containing links use CDATA [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/140816 (owner: 10Yuvipanda) [04:35:54] (03CR) 10Yuvipanda: [C: 032] "(Docfix)" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/140816 (owner: 10Yuvipanda) [04:36:00] bearND: hey! merged, now going to import to twn [04:36:31] (03Merged) 10jenkins-bot: Make all messages containing links use CDATA [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/140816 (owner: 10Yuvipanda) [04:39:24] YuviPanda: great. I don't understand the docfix comment though. You didn't push another PS [04:39:40] bearND: yeah, but I'm theoretically merging my own patch :) [04:40:12] YuviPanda: yeah, but I reviewed your changes, and added some of mine [04:40:31] bearND: indeed, so this was just a 'my changes were just to the strings, so it's ok' [04:40:39] bearND: hmm, actually you are right. I should've called it stringfix [04:41:17] bearND: gah, forgot to remove the TODO from the commit message [04:41:18] oh well [04:41:33] YuviPanda: sorry [04:41:41] YuviPanda: how do you trigger the twn import? is that something easy to explain? [04:42:28] bearND: sadly no. you need shell access and 'staff' rights on twn.net, which I just got yesterday [04:42:50] YuviPanda: oh wow, nm then [04:43:17] bearND: yeah. I'll get you guys those rights in a while too [04:43:27] bearND: if we don't manually push/pull, there's a 2 week gap [04:43:52] bearND: ok, I sync'ed [04:44:04] YuviPanda: that was quick [04:44:10] bearND: yeah :) [04:44:12] :) [04:44:21] bearND: can you get an account on translatewiki? I can give you translation rights, etc. [04:44:41] YuviPanda: got one [04:44:50] bearND: cool. what's the username? [04:44:53] bsitzmann [04:45:26] bearND: oh, cool. you already have translation rights! :) [04:45:42] bearND: check https://translatewiki.net/wiki/Translating:Wikimedia_Mobile_Apps [04:45:43] brb [04:46:03] YuviPanda: not really, just for english [04:46:10] bearND: hmm? [04:46:25] (03PS1) 10Dr0ptp4kt: Immediately update W0 state in navdrawer on state transitions. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/140883 [04:46:26] bearND: no just wanted to make sure you have the rigts in case we needed to change some formatting, etc [04:46:41] YuviPanda or bearND, you guys able to quick peak and + 2 ^^ ? [04:46:58] YuviPanda: go back to bed. i mean wake up [04:47:11] dr0ptp4kt: pushed your string changes to translatewiki.net btw [04:47:18] dr0ptp4kt: gotta go, need to catch a bus in an hour [04:47:27] I'll see you guys when y'all wake up! [04:47:28] YuviPanda: thank you! [04:47:36] bearND: thanks for the quick work on the translation stuff! [04:47:37] YuviPanda: cool, have a good bu ride [04:47:39] I'll brb in a few hours [04:49:12] well, bearND, any chance you could look at https://gerrit.wikimedia.org/r/140883 ? [04:50:22] YuviPanda|zzz: sure. https://translatewiki.net/wiki/Translating:Wikimedia_Mobile_Apps is still not updated i think [04:50:52] dr0ptp4kt: what about the other one: https://gerrit.wikimedia.org/r/#/c/140824/? do you need that one in as well? [04:51:44] bearND: yeah, that would be good, too. 140824 has been verified by three different users [04:52:04] dr0ptp4kt: going to check out the patch you've mentioned. brb [04:52:11] bearND: thx [05:02:26] (03PS2) 10BearND: Immediately update W0 state in navdrawer on state transitions. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/140883 (owner: 10Dr0ptp4kt) [05:02:55] (03CR) 10BearND: [C: 032] "works" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/140883 (owner: 10Dr0ptp4kt) [05:03:13] bearND: thanks [05:03:15] (03Merged) 10jenkins-bot: Immediately update W0 state in navdrawer on state transitions. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/140883 (owner: 10Dr0ptp4kt) [05:26:56] bearND: i'm gonna head to bed. talk to you tomorrow. get some sleep :) [05:26:58] 3Wikipedia App / 3Android App: Media files continue playing when you leave the article or exit the app - 10https://bugzilla.wikimedia.org/66475#c4 (10Bernd Sitzmann) 5PATC>3NEW Had to revert this because it caused all audio to stop; not just from our app but from other apps as well. See https://ticket.w... [06:45:58] (03PS6) 10Florianschmidtwelzow: Enable anonymous editing in alpha mode [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/138802 (https://bugzilla.wikimedia.org/59937) [10:49:45] 3Wikipedia App / 3Android App: android.os.TransactionTooLargeException (when editing a large page?) - 10https://bugzilla.wikimedia.org/66872 (10Liangent) 3NEW p:3Unprio s:3normal a:3None The app crashes when editing [[zh:Module:CGroup/LuaIT]]. Note that this can't be caught by our own crash reporter.... [10:53:28] 3Wikipedia App / 3Android App: android.os.TransactionTooLargeException (when editing a large page?) - 10https://bugzilla.wikimedia.org/66872#c1 (10Liangent) E/JavaBinder( 813): !!! FAILED BINDER TRANSACTION !!! W/ActivityManager( 813): Exception when starting activity org.wikipedia/.editing.EditSectionActi... [15:41:00] (03PS2) 10Dbrant: Properly load saved pages from History. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/140735 (https://bugzilla.wikimedia.org/66818) [15:46:20] * YuviPanda waves at dbrant and bearND [15:46:46] Hi YuviPanda and dbrant [15:46:51] hello! [15:55:48] * YuviPanda waves at Deskana [15:56:03] Hey YuviPanda. :) [15:56:17] * YuviPanda destresses Deskana for the friday [15:56:44] 3Wikipedia App / 3Android App: android.os.TransactionTooLargeException (when editing a large page?) - 10https://bugzilla.wikimedia.org/66872#c2 (10Dmitry Brant) Possibly (probably) related to Bug 66732. This is because we're trying to store too much data in the savedInstanceState of our activities (we store... [15:57:51] * Deskana breathes deeply. [16:03:59] dr0ptp4kt is not here again... [16:07:40] @seen dr0ptp4kt [16:07:51] wm-bot? [16:08:22] liangent: can you clarify what you mean by 'links in headlines'? [16:09:10] dbrant: == [[a]] == [16:09:22] also links generated by [16:09:34] == foobar == [16:12:32] liangent: got it! (and confirmed) [16:25:29] 3Wikipedia App / 3Android App: Links in headlines are not clickable - 10https://bugzilla.wikimedia.org/66878#c1 (10Dmitry Brant) The API seems to be stripping HTML from section titles. The app is only receiving section titles in plain text... [16:40:14] 3Wikipedia App / 3iOS App: iOS autocorrect not enabled for edit summary - 10https://bugzilla.wikimedia.org/62574#c1 (10Dan Garry) 5NEW>3RESO/FIX This bug was fixed as part of the edit workflow changes. [16:45:29] 3Wikipedia App / 3Android App: Links in headlines are not clickable - 10https://bugzilla.wikimedia.org/66878#c2 (10Dan Garry) 5NEW>3RESO/DUP *** This bug has been marked as a duplicate of bug 64467 *** [16:45:29] 3MobileFrontend / 3General/Unknown: action=mobileview should not strip tags in headings for the 'line' property - 10https://bugzilla.wikimedia.org/64467#c5 (10Dan Garry) *** Bug 66878 has been marked as a duplicate of this bug. *** [16:46:58] (03PS1) 10BearND: Login and create account changes [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/140937 [16:55:40] (03PS1) 10Paladox: Update jquery from 1.7.2 to 1.11.1 [apps/win8/wikipedia] - 10https://gerrit.wikimedia.org/r/140939 [16:56:37] (03PS2) 10Paladox: Update jquery from 1.7.2 to 1.11.1 [apps/win8/wikipedia] - 10https://gerrit.wikimedia.org/r/140939 [17:02:35] (03Abandoned) 10Dbrant: Move everything to beta package [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/140223 (owner: 10Dbrant) [17:11:16] 3Wikipedia App / 3iOS App: "last modified" timestamp offsets by timezone instead of showing actual time since edit - 10https://bugzilla.wikimedia.org/66884 (10Julie) 3UNCO p:3Unprio s:3minor a:3None Created attachment 15688 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15688&action=edit Scre... [17:14:31] (03PS1) 10Mhurd: Made login use back arrow if presented in editing workflow. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/140941 [17:23:50] well that was less then fun [17:24:17] mhurd: we left off with me asking you what of the others iOS cards we were realistically going to get to [17:27:28] 3Wikipedia App / 3Android App: Read in other languages activity not properly flipped in RTL view - 10https://bugzilla.wikimedia.org/66795#c1 (10Dan Garry) What exactly does this mean? That it's not flipped after you switch languages? Where? Steps to reproduce would be nice. [17:28:29] 3Wikipedia App / 3iOS App: "last modified" timestamp offsets by timezone instead of showing actual time since edit - 10https://bugzilla.wikimedia.org/66884 (10Dan Garry) 5UNCO>3NEW [17:34:44] derp, my email to mobile-l is in mod limbo [17:34:50] Maryana: post approved [17:34:55] thanks :D [17:37:44] 3Wikipedia App / 3iOS App: "last modified" timestamp offsets by timezone instead of showing actual time since edit - 10https://bugzilla.wikimedia.org/66884 (10Dan Garry) [17:56:11] dbrant: bearND: are either of you interested attending the parsoid review today? [17:58:59] tfinc: interested yes, but still so much to do [17:59:06] (03PS3) 10Dr0ptp4kt: Handle connection errors better. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/140824 [18:00:30] bearND and dbrant ^ there. for the common case it just shows the Retry. for the exceptional exception case in SaneAsyncTask it still crashes, as that would indicate the calling activity or concrete SaneAsyncTask failed to implement proper exception handling and i think as always we'd still want to know about that. anyhow, the truly realistic case of fallback-doesn't-work is updated per our conversation. would you please approve? [18:00:48] their looking for any additional customers so if you see a place for it i can add you to the invite [18:10:12] dr0ptp4kt: Thanks for changing to not throwing RuntimeException in network error case anymore. Trying it out… [18:11:02] bearND and dbrant, my irc connection flaked out. anyhow, to repeat in case you didn't see it, and sorry to spam if you did see it: https://gerrit.wikimedia.org/r/#/c/140824/ is ready i think. i just emailed about the details [18:11:41] tfinc: sorry! got caught up reviewing code. quite a bit on my plate, as well! [18:12:34] dr0ptp4kt_: repeat: Thanks for changing to not throwing RuntimeException in network error case anymore. Trying it out… [18:29:05] sorry for missing the standup, slept poorly and my schedule’s completely effed today [18:30:05] (03PS4) 10BearND: Handle connection errors better. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/140824 (owner: 10Dr0ptp4kt) [18:33:09] (03CR) 10BearND: [C: 032] Handle connection errors better. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/140824 (owner: 10Dr0ptp4kt) [18:33:19] bearND: thx [18:33:31] (03Merged) 10jenkins-bot: Handle connection errors better. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/140824 (owner: 10Dr0ptp4kt) [18:33:54] bearND, thanks for adding perspective! [18:35:01] brion: yo [18:35:06] * YuviPanda waves [18:35:21] kaldari, can you repeat the trainwreck part of what you said during standup? [18:35:27] YuviPanda: thanks for your status email [18:35:30] brion: we still need yours [18:35:49] ok will send [18:36:04] tfinc: I responded to parsoid as well [18:36:10] dr0ptp4kt: sorry for making this hard, but i hope there will be a follow up patch, maybe YuviPanda could take a look at it as well since it so close to release [18:36:26] hey bearND [18:36:29] what's happening? [18:36:50] bearND, sure thing, planning to get on it today [18:36:52] YuviPanda: hello, just merged https://gerrit.wikimedia.org/r/#/c/140824/ [18:37:10] Deskana and YuviPanda, what's the code cutoff today? [18:38:00] dr0ptp4kt: I'd say all day today, whenever you get anyone of us to merge :) [18:38:04] bearND: dbrant|brb ^ [18:38:25] YuviPanda: thx cc Deskana [18:38:28] YuviPanda: did we want to push another beta today? [18:38:37] bearND: yeah, I'd think so. [18:38:46] bearND: I'll get the update all pages changes in an hour or so as well [18:39:29] YuviPanda: awesome. i'd like to do some more login changes [18:40:37] bearND: sure. feel free to [18:41:48] (03CR) 10Siebrand: Handle connection errors better. (031 comment) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/140824 (owner: 10Dr0ptp4kt) [18:43:45] YuviPanda: thanks [18:47:09] dr0ptp4kt: do you have any vague numbers on how many carriers will see the WP0 support on Android, sicne it'll be limited to ones that do IP based zero rating? [18:50:41] YuviPanda: right now there are five launched operators with HTTPS. there are several other that are new in the pipeline where it's working, but they're not announced as launched operators. pre-existing operators are being migrated. i feel it important that it's worded "Wikipedia Zero support (data charges waived) on select participating mobile operators." [18:51:26] dr0ptp4kt: ah, cool. I was aware of that, but just wanted to clarify [18:51:29] err, confirm [18:51:41] YuviPanda: cool man, clarify & confirm [18:51:45] dr0ptp4kt: :) [18:53:34] jgonera: are you following the discussion in #wikimedia-office about UI library standards ? [19:09:34] bearND: Hey [19:09:38] Got a sec? [19:13:15] bearND: dbrant|brb Friday Greetings, please holler when you see this [19:13:31] vbamba: holla! [19:13:41] vbamba: hollllla [19:14:57] (03PS3) 10Paladox: Update jquery from 1.7.2 to 1.11.1 [apps/win8/wikipedia] - 10https://gerrit.wikimedia.org/r/140939 [19:15:12] tfinc, no, I assumed it was only about skin refactoring [19:15:17] (03PS4) 10Paladox: Update jquery from 1.7.2 to 1.11.1 [apps/win8/wikipedia] - 10https://gerrit.wikimedia.org/r/140939 [19:15:33] brion: you might want to talk to ^ [19:15:58] oh good, you guys are back. Ok Quick Hangout in 15 minutes? [19:16:03] Sending an invite [19:17:54] vbamba: ok [19:20:22] (03CR) 10Brion VIBBER: "Note that we're planning to discontinue this app, but might keep it around for experiments so I'll go ahead and test and merge this when m" [apps/win8/wikipedia] - 10https://gerrit.wikimedia.org/r/140939 (owner: 10Paladox) [19:28:46] brb [19:53:28] 3MobileFrontend / 3General/Unknown: "Add an image" icon/CTA is inconsistent - 10https://bugzilla.wikimedia.org/66826#c2 (10Maryana Pinchuk) 5NEW>3RESO/FIX Not sure when/where you noticed this, but we've recently changed the behavior of this feature – you should only see the upload icon if you're able to... [19:57:29] 3MobileFrontend / 3General/Unknown: Hash gets swallowed (again) - 10https://bugzilla.wikimedia.org/64918#c5 (10Maryana Pinchuk) 5RESO/FIX>3REOP Sigh, it's back. Steps to repro: 1. Google "wiring color codes" in Safari mobile browser on iPhone. 2. Follow the "Jump to "Colour code" link in the results. 3... [20:03:37] tfinc: I've got one of the testing devices here. It wants me to update to 4.3. Are we intentionally keeping this on 4.2 for testing? [20:03:41] tfinc: Or can I update? [20:04:22] Deskana: feel free to update if there isn't a message on the phone to keep it on 4.2 [20:04:31] tfinc: You mean like a sticker? [20:04:45] jgonera_: kaldari: are there any phone you guys are keeping pegged at a specific version ? [20:04:48] Deskana: yes [20:05:24] No sticker. [20:05:25] Trying to get rid of all the notifications on it so I can take some screenshots and I can't get rid of the update notification without updating :P [20:06:11] tfinc: Not that I know of [20:06:21] Deskana: yeah, go for it [20:07:15] tfinc I don't think so [20:08:25] moizsyed: about the login page: do you want us to get rid of the display password checkbox? how do you feel about moving the log in action bar button down to the page and make it a regular big button? [20:08:59] 3MobileFrontend / 3General/Unknown: Hash gets swallowed (again) - 10https://bugzilla.wikimedia.org/64918#c6 (10Jon) I did write a browser test for this so you may want to check if that is failing... [20:09:03] tfinc: Although I do keep my personal iPhone at iOS 6 so that once skewmorphism comes back into style I'll be cooler than everyone else [20:10:20] I think I need to roll my iPhone back. [20:10:23] It's sooooo sloooooow [20:12:32] Can't update this due to insufficient battery. [20:13:14] (03PS1) 10Florianschmidtwelzow: Don't show toc if __NOTOC__ set [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/141047 (https://bugzilla.wikimedia.org/66861) [20:15:44] (03CR) 10MaxSem: [C: 04-2] "Sorry, but parsing is a very expensive operation, you can't do it on every request just to get a piece of metadata." (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/141047 (https://bugzilla.wikimedia.org/66861) (owner: 10Florianschmidtwelzow) [20:26:23] (03CR) 10Paladox: "Oh ok. so the app on the windows app store is being discontinued." [apps/win8/wikipedia] - 10https://gerrit.wikimedia.org/r/140939 (owner: 10Paladox) [20:30:27] moizsyed: you around? [20:30:37] nm [20:31:12] moizsyed: i had some questions about the login screen [20:31:28] moizsyed: do you want us to get rid of the display password checkbox? how do you feel about moving the log in action bar button down to the page and make it a regular big button? [20:31:48] (03CR) 10Florianschmidtwelzow: "You're right, i haven't considered that :/" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/141047 (https://bugzilla.wikimedia.org/66861) (owner: 10Florianschmidtwelzow) [20:34:47] mhurd: Designs have been moved to design board and links to the official marks are only in one place. [20:42:34] bearND: Personally I hate that checkbox. [20:42:42] bearND: I instinctively hit it thinking it's "Keep me signed in" [20:42:52] bearND: Because that's what checkboxes underneath password fields typically are [20:43:44] YuviPanda: Deskana: do you remember why it was added? [20:44:31] bearND: That was before my time on the team. I can speculate though. Typing passwords on phones is annoying if you get it wrong because it takes so long to type it in a second time; if you can see the mistake, then it lets you fix it easier [20:46:30] Deskana: was just wondering because it doesn't show up in the new mocks. i guess iOS doesn't have it [20:46:39] bearND: It doesn't. [20:46:44] bearND: I say take it out. :) [20:49:26] Deskana: ok. Are you going to create a card for the login/create account stuff? [20:50:27] bearND: Here we go: https://trello.com/c/zeB0LLeQ/91-refinements-to-create-account-and-log-in-forms [20:51:36] Deskana: maybe only remove the checkbox from the login screen but keep it in create account, so peole don't need to enter it twice [20:51:59] ? [20:52:01] ^ love it [20:52:08] Wise. [20:52:13] Card updated accordingly. [20:53:12] Deskana: ty [20:56:04] bearND: Feel free to add any extra stuff that you're doing in there. [20:56:12] bearND: Let me search the backlog for related cards. [20:56:44] https://trello.com/c/JVHufUet/408-font-of-password-field-is-changing-and-is-different-from-the-one-used-in-repeat-password [20:56:55] https://trello.com/c/voIm1ZtU/246-android-app-log-in-form-should-have-buttons-on-the-page-for-log-in [20:57:09] (03PS1) 10Paladox: Updating Certificate [apps/win8/wikipedia] - 10https://gerrit.wikimedia.org/r/141060 [20:57:22] (03PS2) 10Paladox: Updating Certificate [apps/win8/wikipedia] - 10https://gerrit.wikimedia.org/r/141060 [20:58:17] bearND: If you want to use those to guide some of your work, that's cool. You guys have earned a bit of flex time to work on whatever you want today, I think. :) [20:59:14] Deskana: thx :) [21:01:20] (03PS3) 10Paladox: Updating certificate [apps/win8/wikipedia] - 10https://gerrit.wikimedia.org/r/141060 [21:01:33] (03PS4) 10Paladox: Updating certificate [apps/win8/wikipedia] - 10https://gerrit.wikimedia.org/r/141060 [21:20:59] tfinc: What licence is the app under? [21:21:08] tfinc: Want to upload these screenshots to Commons and need to know what tag to use. [21:22:20] YuviPanda: am i reading it right hat you went with apache for the license https://github.com/wikimedia/apps-android-wikipedia/blob/master/COPYING ? [21:22:34] Deskana: did you make sure to clear your status bar for screenshots ? [21:23:05] tfinc: As much as I could. Here's an example: http://i.imgur.com/xkL1cTu.png [21:23:20] ha, system update [21:23:24] Yeah :( [21:23:31] and usb debugging [21:32:46] 3MobileFrontend / 3stable: Fix zooming in on tablets - 10https://bugzilla.wikimedia.org/66892 (10Moiz Syed) 3NEW p:3Unprio s:3critic a:3None It can't be zoomed beyond 1.6x right now. This is an accessibility issue for visually impaired people. Please fix it. [21:33:39] dbrant|bbl: would it be fair to say that you'd participate remotely if we get out dates of 8/1 - -8/2 ? [21:35:29] 3MobileFrontend / 3stable: Fix zooming in on tablets - 10https://bugzilla.wikimedia.org/66892#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/tNRwlSdR [21:43:21] (03PS2) 10Florianschmidtwelzow: Don't show toc if __NOTOC__ set [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/141047 (https://bugzilla.wikimedia.org/66861) [21:50:10] I'm just going to upload these screenshots. [21:50:16] We can change the licence later if necessary. [21:52:22] (03PS3) 10Florianschmidtwelzow: Don't show toc if __NOTOC__ set [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/141047 (https://bugzilla.wikimedia.org/66861) [21:53:53] I'm going to go with CC-BY-SA-3.0. [21:54:21] Because, after all, our contracts said we agreed to release all of our work under that licence anyway. [21:54:23] Well, mine did. :P [21:54:40] :) [22:04:21] (03CR) 10MaxSem: "Still not acceptable. Let me give it a try instead..." (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/141047 (https://bugzilla.wikimedia.org/66861) (owner: 10Florianschmidtwelzow) [22:08:33] (03PS1) 10JGonera: Allow more zooming [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/141064 (https://bugzilla.wikimedia.org/66892) [22:08:42] (03CR) 10jenkins-bot: [V: 04-1] Allow more zooming [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/141064 (https://bugzilla.wikimedia.org/66892) (owner: 10JGonera) [22:09:51] (03CR) 10JGonera: "Gerrit, you're a liar! This is based off the latest master!" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/141064 (https://bugzilla.wikimedia.org/66892) (owner: 10JGonera) [22:10:03] (03CR) 10JGonera: "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/141064 (https://bugzilla.wikimedia.org/66892) (owner: 10JGonera) [22:11:00] ooh jgonera - what does that patch do? [22:11:14] i left my work comp at work so i can't check with vagrant :( [22:11:32] Maryana, we received a call that the new tablet version can't be zoomed as much as the desktop version and someone visually impaired can't use it [22:11:39] k, that's what i thought [22:11:45] awesome [22:11:51] there were a couple of complaints about that in the blog, too [22:12:42] Maryana, it will take 2 weeks to hit production though? Is it something that should be SWAT-deployed? [22:13:10] eh, i think it's ok to let it go through the normal process [22:13:13] ok [22:13:24] thank you for working on it :) [22:13:27] sure [22:14:04] (03CR) 10MaxSem: [C: 032] Allow more zooming [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/141064 (https://bugzilla.wikimedia.org/66892) (owner: 10JGonera) [22:14:38] (03Merged) 10jenkins-bot: Allow more zooming [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/141064 (https://bugzilla.wikimedia.org/66892) (owner: 10JGonera) [22:16:26] (03CR) 10Florianschmidtwelzow: "feel free, looking forward to you :) Hope you can reuse some of my approach :/" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/141047 (https://bugzilla.wikimedia.org/66861) (owner: 10Florianschmidtwelzow) [22:19:21] (03PS4) 10Kaldari: Add text to next & save buttons in mobile editors [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/140620 [22:20:07] (03CR) 10JGonera: [C: 04-1] "I think a proper way of doing this would be to extend Maintenance class just like scripts in maintenance/ in core do it." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129032 (https://bugzilla.wikimedia.org/64217) (owner: 10Jdlrobson) [22:21:12] (03CR) 10JGonera: [C: 032] Revert CentralNotice banner box-sizing to content-box on mobile [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/140042 (owner: 10Kaldari) [22:22:14] (03Merged) 10jenkins-bot: Revert CentralNotice banner box-sizing to content-box on mobile [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/140042 (owner: 10Kaldari) [22:23:11] jgonera: you at the office today? Have a somewhat complicated question [22:27:44] 3MobileFrontend / 3stable: Fix zooming in on tablets - 10https://bugzilla.wikimedia.org/66892 (10Max Semenik) 5PATC>3RESO/FIX [22:30:58] 3MobileFrontend / 3stable: iPad tablet to mobile redirect not working (cookie or cache-related?) - 10https://bugzilla.wikimedia.org/66888 (10Max Semenik) [22:31:15] 3MobileFrontend / 3stable: iPad tablet to mobile redirect not working (cookie or cache-related?) - 10https://bugzilla.wikimedia.org/66888 (10Max Semenik) a:3Max Semenik [22:33:15] I look forward to casting a Wikipedia video from my phone to a Firefox TV dongle. http://liliputing.com/2014/06/mozillas-answer-chromecast-media-streaming-stick.html [22:35:28] 3MobileFrontend / 3stable: iPad tablet to mobile redirect not working (cookie or cache-related?) - 10https://bugzilla.wikimedia.org/66888#c2 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/BXMQWUIf [22:42:25] (03PS5) 10Kaldari: Add text to next & save buttons in mobile editors [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/140620 [22:44:01] (03PS6) 10Kaldari: Add text to next & save buttons in mobile editors [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/140620 [22:46:25] moizsyed: yo! [22:49:28] MaxSem: mw.config.get( 'wgMFMode' ) [22:53:01] (03PS7) 10Kaldari: Add text to next & save buttons in mobile editors [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/140620 [22:58:17] hey mhurd [22:58:32] sorry, just finishing the mock i owe you [23:02:58] (03PS8) 10Kaldari: Add text to next & save buttons in mobile editors [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/140620 [23:04:39] jgonera: Nevermind about the cache stuff. Apparently the 100% makes no difference (which is surprising), and I was forgetting about RL bumping the module version anyway. [23:04:54] ok ;) [23:20:14] Maryana, I'm hitting that bug when tapping a link in VE follows the link, unfortunately it doesn't happen all the times... [23:22:27] (03PS1) 10Dr0ptp4kt: Log (hopefully) recoverable connection errors. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/141079 [23:23:11] YuviPanda, bearND, dbrant|bbl ^ there's the EL follow up patch for connection management. your review and +2 would be appreciated [23:23:27] i gotta run in about 35 minutes and will be without connectivity after that [23:23:34] until probably monday [23:24:25] YuviPanda bearND dbrant|bbl here's one way to test it: [23:24:37] replace: [23:24:46] } else if (Utils.throwableContainsSpecificType(caught, SSLException.class)) { [23:24:47] with: [23:24:54] } else if (1 == 1) { [23:25:02] And then do the following: [23:25:07] 1. set device in airplane mode [23:25:21] 2. start app, with a breakpoint at tocDrawer.setSlidingEnabled(false); (at start of commonSectionFetchOnCatch(Throwable)). [23:25:37] 3. Continue from the breakpoint, this should yield a "Retry" button. [23:25:42] 4. tap retry [23:25:57] 5. from the encountered breakpoint, disable airplane mode and wait until you see connection working in statu bar. [23:26:03] 6. now, continue from the breakpoint [23:26:22] 7. this too should yield a retry button, but it will have made a connection on the correct scheme to bits [23:26:27] 8. inspect relevant el table [23:26:30] ... [23:26:31] ... [23:26:31] ... [23:27:00] of course you could also turn airplane mode OFF at step 3 to have an event fired over the tls scheme [23:27:06] tfinc: When did the previous PhoneGap app first launch? [23:27:12] Deskana: hmm [23:27:13] tfinc: Katherine wants to know for comms purposes. [23:27:25] Deskana: check in the google play store [23:27:34] Deskana: all published APK's have a date [23:27:37] awjr, why do we set/unset stopMobileRedirect cookie in JS? [23:27:52] there was a really good reason for that... [23:28:26] prolly, wasn't very good if we can't recall it:P [23:28:27] oh right; local caching sometimes was preventing the php cookie unsetting from running [23:28:38] MaxSem ^^ [23:28:44] 10 (1.1) [23:28:44] Mar 27, 2012 [23:28:44] Unpublished [23:28:55] tfinc: All of them say "Unpublished" except the latest version [23:29:00] tfinc: Is that the original date? [23:30:15] awjr, the problem is that this JS doesn't work in prod:P [23:30:57] Deskana: http://blog.wikimedia.org/2012/01/26/announcing-the-official-wikipedia-android-app/ [23:32:26] MaxSem ruhroh [23:32:51] tfinc: Do you know what the dates were for iOS? [23:33:27] MaxSem any idea when breakage was introduced? [23:33:30] Deskana: http://blog.wikimedia.org/2012/04/05/new-wikipedia-app-for-ios-and-an-update-for-our-android-app/ [23:33:39] apparently, long go:P [23:33:53] im surprised there havent been complaints [23:34:05] tfinc: Thank you! :D [23:35:49] jgonera: yeah, i thought it only happened on redlinks, but now it happens to me all the time [23:35:54] no idea what's going on [23:35:57] Deskana: your welcome. i'll be around for another 30min or so if you need anything else [23:36:14] Deskana: i see you still have cards for sign off. any feedback to the engineers about bits that need to get done ? [23:36:29] Maryana, I'll talk to the VE team when I'm done fighting with other issues [23:36:34] kk [23:36:48] (03PS9) 10Kaldari: Add text to next & save buttons in mobile editors [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/140620 [23:37:16] Deskana tfinc YuviPanda bearND dbrant|bbl any idea if the 'wikipedia beta' app will be installable on 2.3.* devices? on the 2.3.6 device i'm running here the google play store says "your device isn't compatible with this version." but i'm able to deploy the latest master via the adb just fine [23:37:42] dr0ptp4kt: its certainly 2.3 compatible [23:39:07] tfinc: yeah, i have it running on the 2.3 device! i tried uninstalling to see if that would make the play store think it was compatible, but no luck [23:41:12] dr0ptp4kt: yes, like tfinc said, we have min API level 10 (2.3.3 and higher), this is why you can install the app via adb. Some devices still can get excluded from the Play Store level because they declare that they don't have all required "features" the app wants. [23:41:26] bearND: blargh [23:43:05] dr0ptp4kt: we can look at a list of supported devices in the play store. which device do you have issues with? [23:43:43] 3MobileFrontend / 3stable: Need to click twice in search overlay - 10https://bugzilla.wikimedia.org/65676#c11 (10Ryan Kaldari) Still not able to reproduce. Could someone provide more details about how they are producing this bug? What page are you starting your search from on en.wiki? What are you searching... [23:43:52] ugh [23:44:03] i apparently slept off at the desk halfway through a patch [23:45:26] bearND: it's a Nexus One (ATT) from htc [23:45:34] dr0ptp4kt: are you looking at alpha app or beta in the store? It's really strange that there are more supported devices in alpha than i beta, even though it's roughly the same AndroidManifest.xml. At least no differences in terms of permissions. [23:45:37] Deskana: yes, apache2 :) and my contract didn't specify cc by-sa ;) [23:45:55] bearND: i was looking at the app called "Wikipedia Beta" [23:46:22] bearND: i don't have this device enrolled in the alpha program [23:51:21] kaldari: https://gerrit.wikimedia.org/r/#/c/139872/ [23:52:15] Maryana: Deskana: i have a new blocker 8/1 10-2pm with all the other managers [23:52:40] debating about options [23:54:05] dr0ptp4kt: based on what i see in the store the "HTC Nexus One - passion" is supported, for both alpha and beta. No idea why it claims otherwise. [23:54:56] bearND: cool. alright, i gotta start powering down... hoping you'll have a chance to look at that follow up patch and the instructions make enough sense [23:55:44] bearND: as i'll be without connectivity, feel free to make small tweaks if required in order to get it into the alpha/beta tonight [23:56:04] (i also realize you probably want to have a normal human weekend, too!) [23:56:50] bearND: dr0ptp4kt I don't think I'll get the saved pages update code in today (slept off on the keyboard for a while :|). we might have to push final 'nothing other than bugfixes' to Monday :( [23:57:18] dbrant|bbl: ^ [23:57:22] YuviPanda: bearND alright dbrant|bbl [23:57:25] dr0ptp4kt: i'll check it out later, unless somone else does [23:57:30] YuviPanda: ok [23:57:37] tfinc: 8/1 or 7/1? [23:57:55] 7/1 [23:57:56] bearND: dbrant|bbl dr0ptp4kt really sorry about that. looks like my body hasn't been holding up as well as I'd thought. should fix over the next few days. [23:58:19] bearND: in the meantime, want me to merge the login page patch and do a translation sync? [23:58:59] (03PS2) 10Yuvipanda: Login and create account changes [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/140937 (owner: 10BearND)