[00:00:05] YuviPanda: there will probably more changes in that regard, so no hurry with the login patch [00:00:27] bearND: hmm, ok. I just want to get the strings in asap :) [00:00:30] YuviPanda: if it's merged that's fine, if not i'll amend [00:00:46] tfinc: ok, thought so :) well, we don't have a lot of options to move the planning meeting days since i'm out of town right after the 2nd til midweek of the week after (which is starting to get a bit late for q1 planning) - i think dan & i can handle the show on the 1st [00:01:06] Maryana: the other option would be to shift it back 1 day [00:01:16] and do it Mon & Tues [00:01:27] YuviPanda: ok, then i'll push an amend quickly with just the string changes [00:01:34] oh yeah, i guess we could do that if you'd rather miss the 2nd day than the 1st [00:01:40] i thought the 1st was a monday for some reason [00:01:51] bearND: ah, hmm. the blue is very jarring, since we don't have it anywhere else, and definitely not with that background [00:02:05] i'd miss the app planing then [00:02:07] hmm will ponder [00:04:17] YuviPanda: no worries! if it's in on monday that's just as well. [00:04:32] YuviPanda dbrant|bbl bearND ttyl gotta go, have a good weekend [00:04:33] YuviPanda: i think the blue link text could use improvements as well. probably shouldn't have reused the background color [00:04:43] dr0ptp4kt: ok, have a great weekend! [00:04:52] bearND: yeah. I can +2 if you get rid of that and have it just be black. [00:05:48] YuviPanda: ok for now, but eventually we should have another blue to signify that it's a link (and not a button) [00:06:05] bearND: agreed, but not right now, I'd think. [00:06:10] Maryana: another option is to move it a week forward. when are you back ? [00:06:31] bearND: if we make them actual buttons, I'm ok with using the same blues from Agora on desktop/mobile [00:06:37] tfinc: the 9th [00:07:07] so we could do 9th & 10th [00:07:10] any preference ? [00:07:26] violetto: You around still? [00:08:23] kaldari: juuuust left [00:08:29] Didn't get it? [00:08:40] violetto: I got the icon, but it's the wrong color grey :( [00:09:05] all our other icons are #555555, but this one is #777777. I can probably fix it in photoshop though [00:09:55] kaldari: that's an easy fix if kaity|away is still around. It's vector don't shop it [00:10:47] (03PS3) 10BearND: Login and create account changes [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/140937 [00:10:53] violetto: The SVG is easy to fix. I could probably export the PNG from the SVG instead after I fix the SVG. I imagine there's some easy way to do that in illustrator [00:11:06] YuviPanda: ^^ [00:11:37] lemme try that... [00:12:04] Doyou have illustrator? [00:12:26] violetto: Yes [00:12:31] violetto: Looks like that worked! [00:12:48] violetto: Guess I should just Be Bold ;) [00:12:50] Open the svg in illustrator, ctrl-a [00:12:56] Oh good!! [00:13:03] Yhas sir! [00:13:25] violetto: You might want to change your copy as well, if you have a local version on your machine [00:32:42] bearND: looking [00:34:00] (03CR) 10Yuvipanda: [C: 04-1] "Needs qq" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/140937 (owner: 10BearND) [00:34:03] bearND: ^ [00:34:54] YuviPanda: good point [00:40:35] YuviPanda: Do we know for sure that create account always has a captcha? When I look at the code it seems like we're not sure [00:41:05] YuviPanda: just wondering if we ever can use the Next string [00:45:35] (03PS1) 10JGonera: [WIP] Tweak VE overlay to support mobile context [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/141087 [00:47:35] (03PS4) 10BearND: Login and create account changes [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/140937 [00:47:42] YuviPanda: ^^ [01:02:19] Deskana: is there an easy way to trigger captcha from an edit? [01:02:47] bearND: go to testwiki, uinsert a link [01:02:59] YuviPanda: ty [01:03:28] YuviPanda: did you see my new patch set? [01:03:50] bearND: yeah, hit run about to merge in a sec [01:04:49] bearND: hmm, it still looks too crowded having it right below. I think we should still stick it to the bottom of the view. maybe with more marginBottom, but still [01:05:49] YuviPanda: ok, i can undo that for now, and bring it back to the bottom [01:05:54] bearND: ok! [01:06:00] (03PS1) 10Kaldari: WIP: Change editor switcher to cog icon and move to right side [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/141092 [01:08:38] (03PS5) 10BearND: Login and create account changes [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/140937 [01:08:51] YuviPanda: ^ [01:09:15] YuviPanda: stuck the text back to the bottom [01:09:34] cool, looking now [01:12:29] bearND: hmm, I don't see link to login screen in create account [01:12:50] YuviPanda: the string is not used yet [01:13:09] bearND: ah, ok. can you amend the commit message to indicate what exactly was changed and why the string isn't used yet? [01:14:01] YuviPanda: i was planning on putting it in once we can switch between the two activities without creating a long string of create account > login > create account > … [01:14:21] bearND: yeah, that's ok. just amend the commit message and I'll merge [01:15:18] YuviPanda: Go to sleep! [01:15:30] Deskana: so... I apparently just went to sleep on my desk for 3.5h [01:15:34] woke up about 30m ago [01:15:35] Before that though, tell me what licence these screenshots should be under: https://commons.wikimedia.org/wiki/File:Wikipedia_Android_app_on_Main_Page.png [01:15:58] as a result of that, I couldn't get update all saved pages in, but should get that in 'today' [01:16:18] YuviPanda: ran into some git trouble when stashing [01:16:23] Deskana: the code is licensed under apache2, but I think CC BY is the closest analogy and should be fine [01:16:28] Okay, cool. [01:16:31] bearND: ah, you can edit it from the gerrit interface itself [01:16:37] YuviPanda: You should get to bed, sir. :) [01:17:06] Deskana: I shall, yeah. Just feeling a bit bad because I set a code freeze deadline and then didn't meet it. oh well. [01:20:08] YuviPanda: Don't feel bad. The timezone stress for you is pretty large. [01:20:35] And you do such a good job of minimising it for us US-based staff that I'm not going to lose any sleep (LULZ PUN) over it going a bit wrong once. [01:20:36] Deskana: yeah. my body now wants to wake up in the *morning* every day, which is fucking with my schedule [01:20:48] Deskana: :D <3. [01:20:58] Deskana: maybe I should start setting up midnight meetings with you guys [01:21:08] Hah! [01:21:11] * YuviPanda remembers a midnight meeting setup for ori to meet up with the language engineering folks [01:21:18] Well perhaps not midnight. :P [01:21:32] so me and Ori went to the office at midnight and grabbed food on the way, and hacked for a while after [01:21:58] But if you did ever want an evening meeting with me, throw one on my calendar. It will warn you that it's outside my working hours, but considering my working hours ended 1.5 hours ago and I'm still at the office... you can ignore that. [01:22:07] Deskana: :D hehe ;) [01:22:13] Deskana: well, I prefer meetings on IRC anyway. [01:22:23] Deskana: we used to have standups on IRC about 2.5 years ago. IT WAS AWESOME [01:22:29] and left a record in the logs [01:24:25] (03PS6) 10BearND: Login and create account string/icon changes [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/140937 [01:24:55] (03PS7) 10Yuvipanda: Login and create account string/icon changes [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/140937 (owner: 10BearND) [01:25:13] (03CR) 10Yuvipanda: [C: 032] Login and create account string/icon changes [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/140937 (owner: 10BearND) [01:25:14] YuviPanda: I have to say, I am personally a fan of the face-time. :) [01:25:26] Deskana: hehe, yeah, that's a popular opinion :) [01:25:35] (03Merged) 10jenkins-bot: Login and create account string/icon changes [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/140937 (owner: 10BearND) [01:26:31] bearND: we try to hard-limit line lengths in commit messages, if only because gerrit looks terrible in them [01:27:26] YuviPanda: right, i totally forgot about that when i edited in gerrit directly [01:27:30] sorry [01:27:36] bearND: pfft, 'tis k :) [01:27:40] YuviPanda: thanks for merging [01:27:48] bearND: \o/ I'll sync to translatewiki now [01:29:44] YuviPanda: how do you feel about having real buttons instead of using the action bar buttons for login/create account/captcha? [01:30:00] bearND: +1 [01:30:11] bearND: well, not for captcha in the edit workflow. [01:30:19] bearND: since that already has actionbar buttons so should stick there [01:30:31] YuviPanda: yeah, that's the problem right now i ran into [01:49:57] bearND: so we can just have buttons on login first, and then figure out create account later [01:52:45] (03PS1) 10MaxSem: Fix stopMobileRedirect cookie being set twice with different prefixes [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/141102 (https://bugzilla.wikimedia.org/66888) [01:54:43] bearND: btw, I imported into translatewiki [02:06:18] YuviPanda: cool. [02:06:32] YuviPanda: that would be very inconsistent to have a button for login but not for create account. well, my brain is fried. i think i'll try again tomorrw [02:06:52] bearND: yeah, am saying we could do that as two patches. [02:07:00] bearND: hah! yeah, mine's fried too atm. I'm going to just rest for a while... [02:07:04] YuviPanda: i hope you get some rest, too [02:07:23] bearND: :D Post release should be a little more chilled for a while, I'd hope [02:07:42] that would be good. :) [05:21:58] 3Wikipedia App / 3Android App: IP block is not detected and saving using a blocked IP crashes the app - 10https://bugzilla.wikimedia.org/66235#c4 (10Yuvi Panda) 5PATC>3RESO/FIX Fixed [05:22:13] 3Wikipedia App / 3Android App: Redirects to main page (WP:MAIN) appear empty - 10https://bugzilla.wikimedia.org/65880#c1 (10Yuvi Panda) Should be fixed at least in TestWiki now since a patch to MobileView was merged. can you confirm? [05:23:00] 3Wikipedia App / 3Android App: Messages with links appear as empty in translatewiki.net - 10https://bugzilla.wikimedia.org/66725#c1 (10Yuvi Panda) 5NEW>3RESO/FIX Fixed now. [05:24:44] 3Wikipedia App / 3Android App: Android app shows 'Could not reach the network' when tapping pencil icon on image view - 10https://bugzilla.wikimedia.org/66814#c1 (10Yuvi Panda) 5NEW>3RESO/DUP *** This bug has been marked as a duplicate of bug 66609 *** [05:24:44] 3Wikipedia App / 3Android App: Editing a commons file returns "Could not connect to the network" - 10https://bugzilla.wikimedia.org/66609#c2 (10Yuvi Panda) *** Bug 66814 has been marked as a duplicate of this bug. *** [05:25:15] 3Wikipedia App / 3Android App: Android app shows add image icon for saved pages and history of FILE pages - 10https://bugzilla.wikimedia.org/66815#c1 (10Yuvi Panda) 5NEW>3RESO/DUP *** This bug has been marked as a duplicate of bug 66685 *** [05:25:15] 3Wikipedia App / 3Android App: The same placeholder image is used for thumbnails that haven't loaded and for articles without illustrations - 10https://bugzilla.wikimedia.org/66685#c1 (10Yuvi Panda) *** Bug 66815 has been marked as a duplicate of this bug. *** [05:25:58] 3Wikipedia App / 3Android App: Tapping a link in preview discards edit silently - 10https://bugzilla.wikimedia.org/66186 (10Yuvi Panda) 5PATC>3RESO/FIX [05:26:15] 3Wikipedia App / 3Android App: Weird "Â" appears on pages in the app - 10https://bugzilla.wikimedia.org/66187 (10Yuvi Panda) 5PATC>3RESO/FIX [05:26:29] 3Wikipedia App / 3Android App: Open in app does not work if App is already open - 10https://bugzilla.wikimedia.org/66194 (10Yuvi Panda) 5PATC>3RESO/FIX [05:26:29] 3Wikipedia App / 3Android App: Show a confirmation when an edit is being discarded - 10https://bugzilla.wikimedia.org/66195 (10Yuvi Panda) 5PATC>3RESO/FIX [05:26:43] 3Wikipedia App / 3Android App: It shouldn't mention "article" when I'm editing non-article pages - 10https://bugzilla.wikimedia.org/66532 (10Yuvi Panda) 5PATC>3RESO/FIX [05:26:59] 3Wikipedia App / 3Android App: App crashes if we attempt to save a page without network connectivity - 10https://bugzilla.wikimedia.org/66601 (10Yuvi Panda) 5PATC>3RESO/FIX [05:26:59] 3Wikipedia App / 3Android App: App crashes when saving a page after restoring app with "don't keep activities" - 10https://bugzilla.wikimedia.org/66716 (10Yuvi Panda) 5PATC>3RESO/FIX [05:27:29] 3Wikipedia App / 3Android App: Android app shows keyboard on edit tap but doesn't allow editing - 10https://bugzilla.wikimedia.org/66761 (10Yuvi Panda) 5PATC>3RESO/FIX [05:27:30] 3Wikipedia App / 3Android App: Android app duplicates browsing history if same item is tapped - 10https://bugzilla.wikimedia.org/66760 (10Yuvi Panda) 5PATC>3RESO/FIX [05:27:43] 3Wikipedia App / 3Android App: Attemptint to open ToC with RTL crashes the app - 10https://bugzilla.wikimedia.org/66794 (10Yuvi Panda) 5PATC>3RESO/FIX [05:28:13] 3Wikipedia App / 3Android App: Android app doesn't dismiss keyboard after following interwiki link - 10https://bugzilla.wikimedia.org/66817 (10Yuvi Panda) 5PATC>3RESO/FIX [05:28:28] 3Wikipedia App / 3Android App: Ampersand in page titles - 10https://bugzilla.wikimedia.org/66152 (10Yuvi Panda) 5PATC>3RESO/FIX [05:30:43] 3Wikipedia App / 3Android App: app crash on startup - 10https://bugzilla.wikimedia.org/66213 (10Yuvi Panda) 5PATC>3RESO/FIX [05:51:31] YuviPanda: Well right now I'm trying to import the apps project into IntelliJ on my new laptop. :P [05:51:40] Deskana: aaah :D [05:51:43] Deskana: do let me know if I can help :) [05:51:50] Deskana: the README is a bit outdated, but has things... [05:51:51] Well I think I found a bug or something. :/ [05:51:54] oh? [05:52:08] Got to the stage where I have to choose my JDK and SDK. [05:52:08] there's one known issue with java-mwapi that's not documented there... [05:52:11] Chose my JDK just fine. [05:52:15] ok... [05:52:26] But my SDK... [05:52:33] I go to the Applications folder, and it shows as being empty. [05:52:43] Deskana: you've to download the SDK separately [05:52:53] I did. I put it in Applications. [05:52:56] oh. [05:53:04] in adt [05:53:14] Deskana: did you open the 'android' binary in the sdk you downloaded, and then use that to download the actual sdk? [05:53:26] Yep, I followed the instructions. [05:53:29] hmm [05:53:36] But IntelliJ shows my entire Applications folder as being empty. [05:53:39] I wonder if it's a permissions issue [05:53:42] Which is weird, because there are tons of things in there. [05:54:01] right. are you in the right applications folder? I think there is a 'root' one /Applications and a user one [05:54:02] Last time I did this I ignored the advice of putting in the Applications folder, which worked to my benefit it seems. :P [05:54:03] under your home [05:54:13] yeah, don't put it in the Application folder :D [05:54:23] Eugh. [05:54:26] I was in the wrong folder. [05:54:33] :D [05:55:16] (03PS1) 10Mhurd: Onboarding screen with create account and sign in buttons. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/141109 [05:55:18] YuviPanda: So what I was trying to do was add something to the edit preview step. [05:55:28] aah! [05:55:31] A little message underneath the licence thing. [05:55:33] Deskana: should have build cut in a minute [05:55:39] But the message is conditional... [05:55:44] It should only display if you're not logged in. [05:55:49] Deskana: aha! [05:56:15] I put the string and its description into the res folder [05:57:24] But anyway, the thing that then flummoxed me is I found a rather massive glaring error in WikipediaApp.java. [05:57:28] The function definition was in there twice... [05:57:35] Even though I'd just pulled from master. [05:57:47] So I thought, fuck it, install from scratch on my new laptop. [05:57:57] mhurd: Glad to hear it. Don't stay up too late. I don't want you burned out! :) [05:57:57] Deskana: ah [05:58:23] Deskana: climbing tomorrow and sunday so it’s all good :) [05:58:44] * Deskana realises the hypocrisy of staying up late to program and telling an engineer not to stay up late to program. :P [05:58:44] YuviPanda: Don't tell me the solution. ;) [05:58:55] YuviPanda: I want to root around myself and try to find a conditional message elsewhere in the code. [05:58:57] Deskana: :) [05:59:20] Deskana: yeah :) [06:04:32] Deskana: just cut build… *fingers crossed* [06:04:39] mhurd: \o/ [06:05:38] Deskana: i made it so if you quit the app, instead of just minimizing it, the onboarding will show again - so you can test it. will update after sign-off to make only show once [06:05:58] mhurd: Cool. Let me do the sign off now then. [06:06:55] Deskana: if you have time please test editing workflow too - especially the parts where you log in / create account [06:07:06] mhurd: Sure. Just downloading now. [06:07:29] Deskana: will need to do a quick pass later at styling the captcha interface closer to mocks [06:07:49] Deskana: will be a 0.5 or 1 pt story [06:08:22] Deskana: oh, i made the onboarding screen layout nicely on 3.5 inch, 4 inch and ipad screens too [06:08:46] Is 3.5 the 4 and 4 the 5? [06:08:54] Er, wow, that's confusing. [06:09:52] Deskana: the tricky part is some 3.5’s are retina and some are standard rez [06:10:20] So there was a slightly strange thing there. Between pressing "Log in" on the onboarding screen and it actually loading the Log in screen, I got a flash of what I was looking at before. [06:10:51] Oh, strange. The create account page is reeeeeally long. [06:11:34] When I press Create Account it takes me to the article I was reading. :/ [06:11:43] Oh, this time it didn't. [06:11:56] Deskana: lol whoa! it is long [06:12:47] Okay, so I think we need to do a few refinements to this next week. [06:12:56] Mostly just minor things. [06:13:14] For example, I pressed create account, then pressed "Already have an account? Log in." and when I'd logged in, it took me back to account creation [06:13:53] Deskana: oh god [06:15:02] Yeah, I think we need a little bit of a polish. [06:15:09] That's okay. :) [06:15:15] It looks really nice [06:15:19] I'm so pleased! :D [06:16:26] Deskana: woohoo! [06:16:48] I think we're like 90% of the way there on the interaction and 100% of the way there on the visual style. [06:17:15] I'll make some notes on what specifically needs fixing for the interaction and we can work on that at the start of next sprint. [06:17:18] For now, I must sleep. :) [06:17:38] Deskana: sounds good! :) see ya! [06:18:07] Thanks for your hard work, guys. :) [06:18:08] Later! [06:43:15] 3Wikipedia App / 3iOS App: iOS App: After account creation, login hangs - 10https://bugzilla.wikimedia.org/66899 (10Kunal Mehta (Legoktm)) 3NEW p:3Unprio s:3major a:3None I created a new account after being asked to (:(). After the captcha, submitted it, saw a brief "Success", and then it switched t... [06:47:48] 3Wikipedia App / 3iOS App: iOS App: Editing preview has no discover-ability - 10https://bugzilla.wikimedia.org/66900 (10Kunal Mehta (Legoktm)) 3NEW p:3Unprio s:3normal a:3None You have to scrolldown to see it, but there's no indicator that you should scroll down. [06:54:47] 3Wikipedia App / 3iOS App: iOS App: Login from the save menu automatically saves - 10https://bugzilla.wikimedia.org/66901 (10Kunal Mehta (Legoktm)) 3NEW p:3Unprio s:3normal a:3None If you're editing anonymously, the copyright warning gives you a "log in" link. Yay! But if you log in using it, it aut... [07:03:28] 3Wikipedia App / 3iOS App: iOS App: "W" menu needs reorganization - 10https://bugzilla.wikimedia.org/65824#c7 (10Kunal Mehta (Legoktm)) It's been 3 weeks now...have there been any updates? I'm told the app is going to be launched in ~2 weeks. [07:05:58] 3Wikipedia App / 3iOS App: iOS App: "W" menu needs reorganization - 10https://bugzilla.wikimedia.org/65824#c8 (10Yuvi Panda) Me (and rest of android team (and some people sending in feedback)) would like it to be less black as well. [07:07:01] 3Wikipedia App / 3iOS App: iOS App: infobox looks cut-off - 10https://bugzilla.wikimedia.org/66902 (10Kunal Mehta (Legoktm)) 3NEW p:3Unprio s:3normal a:3None Created attachment 15692 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15692&action=edit screenshot See screenshot from [[Battle of t... [07:07:14] 3Wikipedia App / 3iOS App: iOS App: "W" menu needs reorganization - 10https://bugzilla.wikimedia.org/65824#c9 (10Monte Hurd) I like the black. [07:08:14] 3Wikipedia App / 3iOS App: iOS App: "W" menu needs reorganization - 10https://bugzilla.wikimedia.org/65824#c10 (10Yuvi Panda) (my comment was for Android, since it doesn't fully overlay the screen) Will open a separate bug. [07:09:14] 3Wikipedia App / 3iOS App: iOS App: infobox looks cut-off - 10https://bugzilla.wikimedia.org/66902#c1 (10Monte Hurd) Yeah this one's driving me crazy too. Will get it fixed next week. [07:09:43] 3Wikipedia App / 3iOS App: iOS App: "W" menu needs reorganization - 10https://bugzilla.wikimedia.org/65824#c11 (10Monte Hurd) Agreed - if not overlaying whole screen it does look jarring. [07:12:16] 3Wikipedia App / 3iOS App: iOS App: Visiting a page you've already visited returns you to that scroll position - 10https://bugzilla.wikimedia.org/66903 (10Kunal Mehta (Legoktm)) 3NEW p:3Unprio s:3normal a:3None Easy reproduce case: Go to [[World War II]] Scroll down to any link to an article about... [07:14:09] (03PS2) 10Mhurd: Onboarding screen with create account and sign in buttons. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/141109 [07:15:17] 3Wikipedia App / 3iOS App: iOS App: Pages in "recent" are saved for offline use - 10https://bugzilla.wikimedia.org/66904 (10Kunal Mehta (Legoktm)) 3UNCO p:3Unprio s:3normal a:3None Pages in my recent history are also saved offline, even if I didn't explicitly save them. I'm not sure whether this is... [07:18:28] 3Wikipedia App / 3iOS App: iOS App: Pages in "recent" are saved for offline use - 10https://bugzilla.wikimedia.org/66904#c1 (10Monte Hurd) The data in for history items expires after 24 hrs. They'll stay in the list, and load if you have connectivity, but the images/html etc get wiped after a day unless you... [07:20:43] 3Wikipedia App / 3iOS App: iOS App: Pages in "recent" are saved for offline use - 10https://bugzilla.wikimedia.org/66904#c2 (10Monte Hurd) "The data for history items" hehe not sure how that "in" snuck in there. [07:22:30] 3Wikipedia App / 3iOS App: iOS App: Pages in "recent" are saved for offline use - 10https://bugzilla.wikimedia.org/66904 (10Kunal Mehta (Legoktm)) [07:22:30] 3Wikipedia App / 3iOS App: iOS App: Pages in "Recent" cache are not updated upon editing - 10https://bugzilla.wikimedia.org/66906 (10Kunal Mehta (Legoktm)) [07:22:32] 3Wikipedia App / 3iOS App: iOS App: Pages in "Recent" cache are not updated upon editing - 10https://bugzilla.wikimedia.org/66906 (10Kunal Mehta (Legoktm)) 3NEW p:3Unprio s:3normal a:3None Go to a random page. Then go to another random page. Edit the first random page from your computer. Go into hist... [07:26:58] 3Wikipedia App / 3iOS App: iOS App: Login from the save menu automatically saves - 10https://bugzilla.wikimedia.org/66901#c1 (10Monte Hurd) Good points! [07:28:58] 3Wikipedia App / 3iOS App: iOS App: Visiting a page you've already visited returns you to that scroll position - 10https://bugzilla.wikimedia.org/66903#c1 (10Monte Hurd) This behavior was added intentionally. Do you think maybe it should only behave this way when you visit saved pages? [07:29:45] 3Wikipedia App / 3iOS App: iOS App: "Last Modified..." should be clickable and take you to page history - 10https://bugzilla.wikimedia.org/66908 (10Kunal Mehta (Legoktm)) 3NEW p:3Unprio s:3normal a:3None Right now it's just text. This should help with the discoverability of page history, which is bur... [07:31:01] 3Wikipedia App / 3iOS App: iOS App: Last modified by doesn't display IP addresses - 10https://bugzilla.wikimedia.org/66909 (10Kunal Mehta (Legoktm)) 3NEW p:3Unprio s:3normal a:3None Don't say "anonymous user", just say the real IP address. [07:31:28] 3Wikipedia App / 3iOS App: iOS App: After account creation, login hangs - 10https://bugzilla.wikimedia.org/66899#c1 (10Monte Hurd) I just cut a new build. Does this still happen with the new build? With a clean install? [07:32:29] 3Wikipedia App / 3iOS App: iOS App: Editing preview has no discover-ability - 10https://bugzilla.wikimedia.org/66900#c1 (10Monte Hurd) The new build I just cut moves the preview up a bit for 3.5 inch screen devices. Does this help? [07:33:14] 3Wikipedia App / 3iOS App: iOS App: Last modified by doesn't display IP addresses - 10https://bugzilla.wikimedia.org/66909#c1 (10Monte Hurd) Even if ipv6? [07:33:19] mhurd: just saw the new beta come in. excited to try it. thank you. do take a break. tomorrow is another day [07:34:40] tfinc: hehe ok. i should go home :) [07:34:48] :) [07:35:31] mhurd: please do [07:35:43] 3Wikipedia App / 3iOS App: iOS App: After account creation, login hangs - 10https://bugzilla.wikimedia.org/66899#c2 (10Kunal Mehta (Legoktm)) I'm using #28. Let me try on a clean install. [07:36:03] mhurd: posted http://hire.jobvite.com/CompanyJobs/Careers.aspx?c=qSa9VfwQ&cs=9UL9Vfwt&page=Job%20Description&j=ovD8YfwY&s :) [07:36:09] tfinc: leaving now… fingers crossed setting that pesky alarm :) [07:36:18] mhurd: enjoy your night [07:37:13] 3Wikipedia App / 3iOS App: iOS App: Last modified by doesn't display IP addresses - 10https://bugzilla.wikimedia.org/66909#c2 (10Kunal Mehta (Legoktm)) (In reply to Monte Hurd from comment #1) > Even if ipv6? Yes. I think in this case mobile should display the same information as desktop, which treats IPv6... [07:38:03] mhurd: Hi, just got the email for #29, trying it out now. [07:38:33] legoktm: thanks so much for all the great testing and comments!!! :) [07:39:05] legoktm: gotta run. need sleep [07:39:18] np, and bye [07:43:00] 3Wikipedia App / 3iOS App: iOS App: Getting a captcha wrong doesn't say you got it wrong - 10https://bugzilla.wikimedia.org/66910 (10Kunal Mehta (Legoktm)) 3NEW p:3Unprio s:3normal a:3None When creating an account, I guess I got a captcha wrong. I was presented with a new captcha and a message that j... [07:43:43] 3Wikipedia App / 3iOS App: iOS App: After account creation, login hangs - 10https://bugzilla.wikimedia.org/66899#c3 (10Kunal Mehta (Legoktm)) Just tried with #29 on a clean install (deleted the app and re-installed it from testflight) and it still hung on login. [07:46:28] 3Wikipedia App / 3iOS App: iOS App: Editing preview has no discover-ability - 10https://bugzilla.wikimedia.org/66900#c2 (10Kunal Mehta (Legoktm)) Yeah, it looks better on #29. If I click on "preview", could we have it scroll that part to the top to show article text of the preview? [13:34:22] aharoni: holla! [13:34:40] aharoni: we fixed the html bug, think you can complete he translation so we can check everything works? :) [13:35:33] Haven't I already? ;) [13:35:59] aharoni: ah :D [13:36:12] aharoni: ok. just did a new full import from git to twn about 5h gao [13:36:18] YuviPanda: you are only asking about Android now, right? [13:36:20] aharoni: yeah. [13:36:26] aharoni: iOS release is a few weeks later [13:36:35] i dunno if it has been tested to see if there are similar i18n problems tho [13:36:38] it's 100%, but let me do another proofreading [13:37:26] a comment about an English message: "Wikipedia crashed" probably refers to the fact that the app crashed ;) [13:37:47] and you know, it's conceivable that the whole cluster would crash ;) [13:38:52] aharoni: :D [13:41:25] YuviPanda: I invited people to translate the app at the translators mailing list, and received one slightly depressing reply - [13:41:30] about three-letter codes ;( [13:41:53] still totally impossible? [13:42:01] possible only with dirty tricks? [13:42:25] aharoni: yeah. [13:42:34] drrrrrrrrat [13:42:42] aharoni: me and ashley were actually thinking of writing our own i18n system for android [13:42:59] aharoni: morelocales which lets you pick UI languages not shipped with your phone doesn't work anymore on Android, btw [13:43:14] aharoni: so it is literally impossible to see some of the UI languages without rooting your phone [13:43:28] (morelocales works with root) [13:43:38] o fudge [13:43:41] aharoni: ya [13:43:45] or with a device running an Android version old enough :p [13:43:54] yeah, *old* enough [13:43:57] "doesn't work anymore" - starting at a certain Android version? [13:44:03] aharoni: yeah, 4.2 or something [13:44:51] [ and they got the fucking nerve to call it Free Software ] [13:45:08] such stuff depresses me [13:45:15] aharoni: yeah. [13:45:21] product management gone awry [13:45:44] aharoni: to be fair, they removed that permission for good security reasons, since language wasn't the only settings those apps could change [13:46:01] aharoni: but yeah, not having language support is just... ugh [13:46:55] aharoni: either way, we have a chance to 'fix' it by building a nicer alternative [13:50:26] YuviPanda: re-checking my translations is useful. I'm finding mistakes :) [13:55:20] YuviPanda: "Links from blocked domains (%s) detected" [13:55:30] maybe it should be "Links *to* blocked domains (%s) detected"? [14:04:53] aharoni: gah, you are right [14:05:14] i'll submit a patch! i'll submit a patch! [14:06:11] aharoni: please do so [14:07:12] (03PS1) 10Amire80: Common American spelling for "license" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/141245 [14:08:33] (03PS1) 10Amire80: Clarifying the message about blocked domains [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/141246 [14:08:42] YuviPanda: two commits [14:08:43] (03CR) 10Yuvipanda: [C: 032] Common American spelling for "license" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/141245 (owner: 10Amire80) [14:09:26] (03CR) 10Yuvipanda: [C: 032] Clarifying the message about blocked domains [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/141246 (owner: 10Amire80) [14:09:30] (03Merged) 10jenkins-bot: Common American spelling for "license" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/141245 (owner: 10Amire80) [14:09:34] aharoni: want me to import to twn? :) [14:09:51] (03Merged) 10jenkins-bot: Clarifying the message about blocked domains [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/141246 (owner: 10Amire80) [14:09:51] YuviPanda: yeah [14:10:04] YuviPanda: IIRC there's an option not to fuzz a message, [14:10:16] so if it's there, don't fuzz the one with licence. [14:10:52] aharoni: ok [14:11:31] aharoni: doing [14:15:34] aharoni: done [14:16:32] YuviPanda: thanks [14:16:42] the Hebrew translation is now complete _and_ proofread. [14:16:50] I'd love to test the app with it. [14:16:59] aharoni: let me make an import [14:28:11] aharoni: bah, ssh forwarding issues. I'm heading out now, will do later? [14:33:46] YuviPanda: not urgent [14:37:55] (03CR) 10Florianschmidtwelzow: "I had a look into it, but found no way to know, if the magic word notoc is used or not, without use the parser. Then i thought about to se" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/141047 (https://bugzilla.wikimedia.org/66861) (owner: 10Florianschmidtwelzow) [14:58:56] (03PS1) 10Yuvipanda: Manual Localization update from TWN [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/141253 [14:58:58] (03CR) 10jenkins-bot: [V: 04-1] Manual Localization update from TWN [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/141253 (owner: 10Yuvipanda) [14:59:02] wat [15:00:58] (03PS1) 10Yuvipanda: Manual Translations update from TWN [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/141254 [15:01:27] (03CR) 10Yuvipanda: [C: 032] Manual Translations update from TWN [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/141254 (owner: 10Yuvipanda) [15:02:51] (03Merged) 10jenkins-bot: Manual Translations update from TWN [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/141254 (owner: 10Yuvipanda) [15:27:21] YuviPanda: On the About page, there's no space at all between the privacy policy link and the terms of use link. [15:28:53] YuviPanda: that app is pretty awesome otherwise [15:28:56] really [15:29:01] modern [15:29:03] simple [15:29:07] nice menus [15:29:13] useful functions [15:29:33] hmmm [15:29:40] "read in another language" [15:30:10] In Hebrew the language list is placed too close to the right-hand edge [15:30:51] and it's kinda weird that it shows the language names in English in a large font, the language's own name in a smaller font, and doesn't show the article name at all [15:39:32] 3Wikipedia App / 3Android App: no space between "privacy policy" and "terms of use" on the about page of the Android app - 10https://bugzilla.wikimedia.org/66916 (10Amir E. Aharoni) 3NEW p:3Unprio s:3normal a:3None There's no space between "privacy policy" and "terms of use" on the about page of the... [15:43:16] 3Wikipedia App / 3Android App: the languages list shows the languages in a suboptimal way - 10https://bugzilla.wikimedia.org/66917 (10Amir E. Aharoni) 3NEW p:3Unprio s:3normal a:3None In the "read in another language" list, there are several problems: 1. The language names in English appear in a lar... [15:43:47] 3Wikipedia App / 3Android App: language list in the android app is aligned to far to the right in Hebrew - 10https://bugzilla.wikimedia.org/66918 (10Amir E. Aharoni) 3NEW p:3Unprio s:3normal a:3None When I use the app in Hebrew, the list of languages in which the article is available is shown too far... [19:40:41] aharoni: saw the bugs :) [19:40:51] cool [19:42:24] aharoni: :) if those are the only bugs you could find, that's not too bad :D [19:42:26] aharoni: try editing tho [19:53:26] yuvipanda: works well [19:53:37] the only odd thing I noticed: [19:53:41] search in a page, [19:53:59] then delete all the letters from the search box, [19:54:20] the page keeps showing the last letter highlighted as if it was still in the search box [20:02:51] (03PS1) 10Amire80: Consistent capital CAPTCHA [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/141265 [20:09:38] yuvipanda: where is "Make changes to my edit" supposed to appear? [20:52:06] (03CR) 10Brion VIBBER: [C: 032 V: 032] Made login use back arrow if presented in editing workflow. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/140941 (owner: 10Mhurd) [21:01:07] (03CR) 10Brion VIBBER: [C: 04-1] "When creating an account, the account appears to be created but then it sticks at 'Logging in...'" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/141109 (owner: 10Mhurd) [23:48:16] * Deskana groans. [23:48:18] Strange errors.