[01:07:05] (03PS3) 10Brion VIBBER: Work in progress: fix for linking to pages with fragments [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/141365 [03:02:14] 3Wikipedia App / 3Android App: crash with NoClassDefFoundError: support.v7.internal.view.menu.MenuBuilder - 10https://bugzilla.wikimedia.org/66263#c4 (10Alex Monk) https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom;TicketID=7594890 https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZ... [03:43:28] 3Wikipedia App / 3Android App: crash with NoClassDefFoundError: support.v7.internal.view.menu.MenuBuilder - 10https://bugzilla.wikimedia.org/66263#c2 (10Alex Monk) Another one: https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom;TicketID=7593450 [03:46:59] 3Wikipedia App / 3Generic: App stops responding after being used for a while - 10https://bugzilla.wikimedia.org/64450#c6 (10Alex Monk) https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom;TicketID=7592860 [04:43:59] 3Wikipedia App / 3Android App: crash with NoClassDefFoundError: support.v7.internal.view.menu.MenuBuilder - 10https://bugzilla.wikimedia.org/66263#c3 (10Alex Monk) https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom;TicketID=7593858 [05:44:55] (03CR) 10Florianschmidtwelzow: [C: 031] Fix stopMobileRedirect cookie being set twice with different prefixes [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/141102 (https://bugzilla.wikimedia.org/66888) (owner: 10MaxSem) [06:01:16] 3Wikipedia App / 3General/Unknown: Many Difficulties in Mobile Display of Hebrew WIkisource - 10https://bugzilla.wikimedia.org/66958 (10Daniel) 3UNCO p:3Unprio s:3normal a:3None a number of needed changes to the design page of the hebrew wikisource when viewed from a cellphone (atlteast from my iphon... [06:38:26] (03PS1) 10BearND: Login and create account buttons [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/141380 [07:36:33] (03PS2) 10Yuvipanda: [WIP] Update saved pages [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/140310 (owner: 10BearND) [08:01:48] (03PS7) 10Florianschmidtwelzow: Enable anonymous editing in alpha mode [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/138802 (https://bugzilla.wikimedia.org/59937) [08:02:38] (03CR) 10Florianschmidtwelzow: [C: 04-1] Enable anonymous editing in alpha mode (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/138802 (https://bugzilla.wikimedia.org/59937) (owner: 10Florianschmidtwelzow) [08:06:11] (03PS8) 10Florianschmidtwelzow: Enable anonymous editing in alpha mode [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/138802 (https://bugzilla.wikimedia.org/59937) [08:06:42] (03PS9) 10Florianschmidtwelzow: Enable anonymous editing in alpha mode [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/138802 (https://bugzilla.wikimedia.org/59937) [08:08:47] (03PS10) 10Florianschmidtwelzow: Enable anonymous editing in alpha mode [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/138802 (https://bugzilla.wikimedia.org/59937) [08:09:41] (03PS11) 10Florianschmidtwelzow: Enable anonymous editing in alpha mode [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/138802 (https://bugzilla.wikimedia.org/59937) [10:06:11] (03PS3) 10Yuvipanda: [WIP] Update saved pages [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/140310 (owner: 10BearND) [10:55:46] 3Wikipedia App / 3Android App: Can't translate interface to Italian - 10https://bugzilla.wikimedia.org/66975 (10Elitre) 3NEW p:3Unprio s:3normal a:3None For some reason it's not in the list of whitelisted languages? https://git.wikimedia.org/blob/translatewiki.git/881f48bb2e40d9db66ffbdeed1a5c5920f89... [11:01:47] (03CR) 10Siebrand: [C: 031] "L10n reviewed." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/140310 (owner: 10BearND) [11:36:14] 3Wikipedia App / 3Android App: Can't translate interface to Italian - 10https://bugzilla.wikimedia.org/66975 (10Nemo) [12:44:56] [13WikipediaMobile] 15siebrand pushed 1 new commit to 06master: 02http://git.io/d6Si9g [12:44:56] 13WikipediaMobile/06master 145aa76b1 15Siebrand Mazeland: Localisation updates from https://translatewiki.net. [13:14:44] 3Wikipedia App / 3General/Unknown: Many Difficulties in Mobile Display of Hebrew WIkisource - 10https://bugzilla.wikimedia.org/66958#c1 (10Andre Klapper) Thanks for reporting this. Just to clarify, this is about the Wikimedia App and not about using your browser and going to the mobile version of he.wikisour... [16:02:59] (03PS1) 10Dbrant: More compatible arrangement of 'privacy policy' and 'terms of use' [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/141451 (https://bugzilla.wikimedia.org/66916) [16:10:22] (03PS1) 10Dbrant: Add paddingRight for correct RTL appearance. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/141454 (https://bugzilla.wikimedia.org/66918) [16:11:08] (03CR) 10Mhurd: "Poking at it..." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/141365 (owner: 10Brion VIBBER) [16:19:13] (03PS3) 10Dbrant: Properly load saved pages from History. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/140735 (https://bugzilla.wikimedia.org/66818) [16:32:00] (03CR) 10Dbrant: [C: 04-1] "New styles look awesome! However, it doesn't seem to be validating 'repeat password' when creating an account." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/141380 (owner: 10BearND) [16:33:21] dbrant: checking… [16:38:16] dbrant: good catch, should've called validator.validate(); [16:39:15] (03PS1) 10Cmcmahon: QA: More test pages being created in the live wikipedia [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/141463 [16:40:21] awjr: would you be averse to merging this? https://gerrit.wikimedia.org/r/#/c/141463/ [16:41:10] (03PS2) 10BearND: Login and create account buttons [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/141380 [16:41:40] dbrant|brb: ^ [16:42:56] chrismcmahon check with jgonera when he's in [16:52:05] hey [16:52:13] * YuviPanda waves at dbrant|brb and bearND [16:52:39] Hello YuviPanda [16:52:57] bearND: the saved pages update I updated, mostly complete. just need to put the strings to strings.xml [16:54:07] YuviPanda: and deal with network failures, and either implement update all saved pages or add a select all option [16:54:20] bearND: yeah, just update all should be easier [16:54:22] let me do that first [16:55:10] MaxSem, I'll be late for standup [16:55:55] jgonera: would you be OK merging this? https://gerrit.wikimedia.org/r/#/c/141463/ [16:56:41] YuviPanda: great job and thanks for doing the background stuff! :) [16:56:46] bearND: :D [16:56:48] bearND: be happy to :) [16:57:20] chrismcmahon, I'll have a look in a few minutes [16:57:54] jgonera: it just removes production as a target for tests. We once again created a test page in enwiki [16:58:53] chrismcmahon, OK, I'll merge it, I'm on a train now ;) [16:59:07] thanks jgonera [16:59:19] bearND: ^ has refreshall code [16:59:22] (03PS4) 10Yuvipanda: Update saved pages [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/140310 (owner: 10BearND) [16:59:51] bearND: let me finish up the network failure handling code. I'm just going to bail out on the first failure [17:01:33] YuviPanda: sounds reasonable. Let me know if I can be of assistance. [17:01:54] bearND: do CR the other patches :) [17:02:00] bearND: dbrant had a few up [17:02:03] YuviPanda: ok [17:02:11] YuviPanda: new release ? [17:02:20] matanya: in a few hours, probably [17:02:27] matanya: need to poke someone to merge bearND's access request. [17:02:37] thanks! [17:02:54] matanya: yw! we are very close to release [17:03:25] will it be published to releases.wm.o ? [17:03:42] brion: https://gist.github.com/montehurd/bfdded475defa19d788a [17:03:46] matanya: yes. [17:04:07] YuviPanda: link please ? [17:04:21] matanya: oh, no, I mean - we are close to release, but haven't released yet :) [17:04:30] matanya: I'll poke you with a link when we push out a beta. should be in a few hours [17:04:46] YuviPanda: i meany exactly this :) [17:04:51] *meant [17:04:52] matanya: ah, yeah :) [17:08:10] (03CR) 10BearND: [C: 032] Add paddingRight for correct RTL appearance. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/141454 (https://bugzilla.wikimedia.org/66918) (owner: 10Dbrant) [17:08:24] (03PS1) 10Mhurd: Fix for onboarding login lockup. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/141469 [17:08:49] (03Merged) 10jenkins-bot: Add paddingRight for correct RTL appearance. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/141454 (https://bugzilla.wikimedia.org/66918) (owner: 10Dbrant) [17:12:52] dbrant: от имени сотен миллионов людей от Марокко до Мальдивов, благодарю за исправления RTL-багов :) [17:14:32] aharoni: Пустяки! :) [17:20:17] (03CR) 10JGonera: [C: 032] QA: More test pages being created in the live wikipedia [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/141463 (owner: 10Cmcmahon) [17:20:53] (03Merged) 10jenkins-bot: QA: More test pages being created in the live wikipedia [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/141463 (owner: 10Cmcmahon) [17:30:53] Deskana: hey! didn't mean to come across as harsh, but did feel a slight pit in my stomach, so... [17:31:27] howdy [17:31:47] Deskana: what would you say are the pros/cons of delaying the Android release ? [17:31:57] (03CR) 10Dbrant: [C: 04-1] "A couple more notes." (032 comments) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/141380 (owner: 10BearND) [17:32:42] (03CR) 10JGonera: [C: 04-1] "If I remember correctly, we decided to change it in uploads too. Checklist in https://trello.com/c/AnqphAci/9-5-add-text-to-next-save-butt" (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/140620 (owner: 10Kaldari) [17:32:54] kaldari: just fiddled around with an ipad and iphone, and you're right - don't see the search overlay bug anymore [17:32:59] i guess it fixed itself? [17:33:38] Maryana: not sure [17:33:47] lemme test on beta labs [17:33:56] i was looking at prod, but maybe it's a labs issue [17:34:46] (03CR) 10BearND: "wondering if we could keep the layout horizontal to avoid having to scroll down to see the feedback link on a Nexus 4" (031 comment) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/141451 (https://bugzilla.wikimedia.org/66916) (owner: 10Dbrant) [17:36:04] Back. [17:36:06] So, pros. [17:36:30] The impact is larger. More downloads means more people hitting that edit button. [17:36:32] Cons. [17:37:10] Too many variables. Delaying isn't as simple as "waiting two weeks". It's waiting for two weeks until submission, which therefore includes the chance the submission will be denied, or that Apple will take ages to review. [17:37:18] jgonera & kaldari, please review https://gerrit.wikimedia.org/r/#/c/141102/ for today's SWAT. while Arthur is usually the expert is the expert in this area, he's ill today [17:37:19] There's also a risk (however small) that we'll find a showstopper in the iOS release and delay even further. [17:37:56] Part of the agreement on the 7/7 date for iOS was that we'd delay if we found showstoppers. [17:38:36] Also, as you say, we've been building up to this and our next few sprints are dependent on it; the impact we gain may not be worth the confusion and feedback that we lose. [17:39:14] Basically, my thinking is that although I want to maximise impact, there are far too many unknowns in us pinning the Android release to the iOS one. [17:39:29] The risk is too big relative to the reward. [17:40:48] YuviPanda: Don't worry. It's long been my philosophy that people should be brutally honest with me; that way, when you respond positively to something, I know for a fact that it's truthful, and not you trying to "not hurt my feelings" or some similar bullshit. [17:41:03] Deskana: :) [17:41:14] 3MobileFrontend / 3stable: Need to click twice in search overlay - 10https://bugzilla.wikimedia.org/65676#c12 (10Maryana Pinchuk) I've tried reproing this on a phone and tablet (iPhone 4 and iPad), in alpha, beta, and stable, in production as well as beta labs, and I don't see it. However, on desktop (Chrome... [17:41:36] (03CR) 10JGonera: [C: 04-1] "Thanks for the patch, small issues inline." (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/139790 (https://bugzilla.wikimedia.org/66591) (owner: 10Florianschmidtwelzow) [17:41:38] bearND: how about this, then: we could move the "app feedback" link up (say, right above "contributors") to make it more prominent, and also make it a button, using your new styles? [17:41:54] dbrant: I'd caution against making it too prominent. [17:42:13] dbrant: we don't want to overload our Volunteers, and this just provides a stupid form of sampling... [17:42:18] dbrant: under contributions, maybe? [17:42:37] We also need to make it clear that it's APP feedback and not article feedback. [17:42:49] So having it a menu with loads of other app-level settings is good. [17:43:14] Deskana: yeah, it's labelled that way. you also have to scroll to see it on most phones, we're just considering removing the requirement to scroll [17:44:38] dbrant, are you familiar with the whole "mobile feedback" fiasco? :) [17:44:43] Deskana: keep in mind that our success is aligned with getting in active editors. if were just trying to widen the funnel but are keeping a poor conversion rate then our attention is miss placed [17:44:46] it [17:44:49] MaxSem: that never happened with apps :P [17:44:53] it's your guys call on this but you know where i stand [17:45:04] MaxSem: YuviPanda: you'll have to fill me in [17:45:59] I rather have us optimize the workflow for the users that we do get after launch then just delay to get more of them with the same issues [17:46:05] tfinc: can you do a 'I approve' on https://rt.wikimedia.org/Ticket/Display.html?id=7719 so bearND can get rights to release.wikimedia.org? [17:46:30] YuviPanda: done [17:46:41] tfinc: ty. let me go find someone in ops to poke to merge that. [17:46:49] tfinc: just making sure everyone can do all the things :) [17:47:09] YuviPanda: tfinc: thank you :) [17:47:18] dbrant: so a long long time ago, mobile web had a 'leave feedback' link. so everyone emailed in about how pages were wrong, or this sucks, or how justin beiber was gay. [17:47:36] Deskana: Maryana: i'm not seeing a good way of getting out of my 7/1. are you guys fine shepherding this on your own or do you want me to delay this by a week when Maryana gets back ? [17:48:10] tfinc: Will Arthur be here for those days? [17:48:13] dbrant: first it put it on a wiki page, with the IP and UA of users, which was apparently a privacy policy violation. then it opened up an email link, and we got *plenty* of blank emails that caused problems for OTRS [17:48:14] 3MobileFrontend / 3stable: Need to click twice in search overlay - 10https://bugzilla.wikimedia.org/65676#c13 (10Florian) Hmm, on desktop chrome i can reproduce this in beta and stable, not in alpha. And there aren't any infos/errors in console :/ [17:48:39] dbrant: and then it was disabled :) But apps we've always put the feedback link in about page and the play store, and it hasn't been that bad [17:48:47] YuviPanda: lol a fiasco indeed [17:49:18] Deskana: i'm looking to have him there [17:49:49] tfinc: Well, either way, as long as he's in the meeting to facilitate (remote or not), then I'm fine with the 1st. [17:49:55] dbrant, basically, average mobile site feedback was "fjk" [17:50:12] "asdf" was also popular though [17:50:14] lolol [17:50:43] Deskana: just so that you know what the expectations are. at each quarterly planning session the PM's review the high level goals, break them down into their quarterly targets, and present a couple of scenarios of how we can get there for the quarter. then everyone discusses and we either pick one of them, build a hybrid, or something all together different [17:51:02] Deskana: you would need come to the planning with a couple of ideas on how to move forward for the next 3 months [17:51:22] given that its the first first quarter planning we'd want to think broadly about the year too [17:51:30] my bias is to go forward with next week to get this doen [17:51:46] plus i'd like to have Maryana go on vacation having this done rather than it being in the back of her head [17:52:35] meee toooooo :) [17:53:41] Okay, I'll write that down. [17:55:59] 3Wikipedia App / 3Android App: Can't translate interface to Italian - 10https://bugzilla.wikimedia.org/66975 (10Nemo) 5PATC>3RESO/FIX [17:56:48] lol, people were complaining that this page didn't work on mobile: https://en.wikipedia.org/w/index.php?title=Minor_places_in_Middle-earth&diff=614091952&oldid=614059586 :P:P:PXD [17:57:28] haha [18:00:22] kaldari: so i figured out what was up with the search bug (see my comments in BZ) but since it seems to be isolated to desktop, i don't think it's super high priority at this point [18:00:27] so if you finish the VE story, pick up the hash bug or the limn bug :) [18:00:36] oh, cool [18:01:40] MaxSem, why -3600 in https://gerrit.wikimedia.org/r/#/c/141102/1/includes/MobileContext.php ? [18:02:01] YuviPanda, bearND, dbrant, tfinc: Decision. We're sticking with the original plan. Android release 25th. [18:02:03] because that's how this thingie unsets cooies in the first place [18:02:08] Deskana: <3 [18:02:19] alright! [18:02:47] Basically, my rationale is that if it was as simple as "just delaying Android for two weeks", then I'd say we should do that. But that's the best case scenario. [18:03:08] The data we'll collect from the release will be invaluable. That's worth it. [18:03:21] Deskana: thanks for the update [18:03:28] I'll tell Katherine. [18:03:29] :) [18:05:34] Maryana: i've been thinking more and more about tech infrastructure work and given the small size of the team right now i'm going to think of Q1 as learning from our FLOW partnership and collaborating with Trevor on a partial resource share(day, sprint,etc). We can do more when the team size increases [18:06:44] Maryana: that way your resourcing for growth related work is clear [18:07:01] cool, makes sense [18:08:08] brb, comp whining for a software update [18:18:28] YuviPanda: So I tried to build and got this error. [18:18:48] Error:(41, 20) java: /Users/dgarry/Apps/android-wikipedia/wikipedia/src/main/java/org/wikipedia/networking/MccMncStateHandler.java:41: cannot find symbol [18:18:48] symbol : constructor Api(java.lang.String,java.lang.String,java.util.HashMap) [18:18:49] location: class org.mediawiki.api.json.Api [18:24:29] Deskana: hey! [18:24:54] Deskana: yeah, so that's a known bug. I'll fix it in a while. Until then, you need to 1. clone https://github.com/wikimedia/apps-android-java-mwapi 2. run 'mvn install' from inside it 3. 're-import sources' in IntelliJ [18:24:55] sorry [18:25:56] what's the url string that changes interface language? &uselanguage= ..? [18:26:09] Maryana: I thought it was &uselang= [18:26:09] Maryana: lang= [18:26:13] oh? [18:26:16] lang= or uselang= [18:26:45] &uselang=qqx [18:26:47] That works for me [18:26:49] (03PS4) 10Brion VIBBER: fix for linking to pages with fragments [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/141365 [18:26:58] weird, it's not working for me [18:27:00] YuviPanda: we probably should do a mvn release (or simulate it) for java-mwapi [18:27:10] bearND: yeah, we should. I've just been lazy :| [18:28:09] Deskana: also if you're getting that error (and only that) means you're almost there :) [18:28:57] (03CR) 10Brion VIBBER: [C: 032 V: 032] Fix for onboarding login lockup. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/141469 (owner: 10Mhurd) [18:29:09] YuviPanda: Where is reimport sources? [18:29:15] (03CR) 10Brion VIBBER: [C: 032 V: 032] fix for linking to pages with fragments [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/141365 (owner: 10Brion VIBBER) [18:29:18] oh, weird. so it works if i add that to a desktop url and then switch to mobile, but it doesn't work to add it to a .m url [18:29:32] Deskana: right click the project name in the left pane, under 'maven' is 'reimport' [18:30:39] YuviPanda: Seems to be working. :) [18:30:44] Deskana: wooot! :) [18:30:51] Although I've not actually made my change. :P [18:31:07] Deskana: :D [18:31:11] Still, good to have the SDK running again. [18:31:23] Deskana: yeah. [18:31:40] Deskana: let us know the pain points you find so we can document them [18:31:51] There was one... [18:31:52] Deskana: would you be up for taking the standup and retro this week? I'll be at Google I/O [18:32:00] Wed Standup and Thur Retro [18:32:27] YuviPanda: I followed the instructions here: https://github.com/wikimedia/apps-android-wikipedia [18:32:40] Deskana: were they sufficient? (except for the java-mwapi stuff) [18:32:49] YuviPanda: They worked for the most part, but it seems to have stripped the newlines out of the stuff to add to your bash profile [18:33:12] tfinc: Sure. [18:33:16] Deskana: ah, ok. if you want to check out the gerrit workflow, you can submit a patch to that when you want too :) [18:33:40] YuviPanda: That bit I've done before. I wrote a patch for OAuth. Fairly trivial, but still. [18:33:51] Deskana: ah cool :) [18:34:55] Deskana: thank you [18:35:14] mhurd: I've made some notes on refinements for the onboarding. They're on the card under "Refinements" checklist. [18:35:19] mhurd: Let me know if you need any clarification. [18:35:30] Deskana: cool thanks! [18:38:14] 3Wikipedia App / 3iOS App: iOS App: Pages in "recent" are saved for offline use - 10https://bugzilla.wikimedia.org/66904#c3 (10Dan Garry) 5UNCO>3RESO/INV It's a feature. :-) [18:39:16] YuviPanda: Question about the create account flow: is there always a CAPTCHA step? the code seems to be written like it's not necessarily the case. but if you say yes then a point could be made for renaming the first button from "Create Account" to "Next" to indicate that there's more coming. [18:39:42] bearND: yeah, but always a captcha step. 'next' sounds nice [18:39:44] 3MobileFrontend / 3General/Unknown: Many Difficulties in Mobile Display of Hebrew WIkisource - 10https://bugzilla.wikimedia.org/66958#c2 (10Dan Garry) I'm almost certain this isn't about the app, as you can't access anything other than Wikipedias using it. [18:39:58] Deskana: yeah, should move ^ to mobilefrontend [18:40:16] YuviPanda: I did. :) [18:40:26] YuviPanda: ok, i'll call the first button in create account next then (fyi dbrant) [18:40:28] Deskana: ah, didn't see that. [18:40:29] 3MobileFrontend / 3General/Unknown: Many Difficulties in Mobile Display of Hebrew WIkisource - 10https://bugzilla.wikimedia.org/66958#c3 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/bJd2ItqY [18:40:31] bearND: cool [18:40:44] 3Wikipedia App / 3iOS App: iOS App: Tapping on "Preview" should slide the preview up - 10https://bugzilla.wikimedia.org/66900 (10Dan Garry) [18:40:59] 3Wikipedia App / 3iOS App: iOS App: Tapping on "Preview" should slide the preview up - 10https://bugzilla.wikimedia.org/66900#c3 (10Dan Garry) (In reply to Kunal Mehta (Legoktm) from comment #2) > Yeah, it looks better on #29. If I click on "preview", could we have it > scroll that part to the top to show ar... [18:42:20] (03CR) 10BearND: Login and create account buttons (032 comments) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/141380 (owner: 10BearND) [18:43:18] (03PS3) 10BearND: Login and create account buttons [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/141380 [18:55:14] 3MobileFrontend / 3stable: Need to click twice in search overlay - 10https://bugzilla.wikimedia.org/65676#c14 (10Ryan Kaldari) Still can't reproduce it :( [18:57:12] YuviPanda, would you be able to review and, if appropriate, +2 https://gerrit.wikimedia.org/r/#/c/141079/ ? adds the eventlogging, silently failing if eventlogging itself causes an exception. [18:57:31] YuviPanda: it adds 42 lines, so you know it's good [18:57:33] dr0ptp4kt: hmm, I'm about to head to bed soon, and need to finish up the update all saved pages patch. dbrant|lunch bearND|lunch ^ [18:57:36] dr0ptp4kt: haha :D [18:57:47] dr0ptp4kt: it looks ok to me, so can +1. did you verify that data is coming through? [18:57:56] YuviPanda, word. dbrant|lunch: bearND|lunch your review on https://gerrit.wikimedia.org/r/#/c/141079/ would be most appreciated. thx [18:58:24] YuviPanda: yes, i did verify it, and was pleasantly greeted with log entries [18:59:00] dr0ptp4kt: :D nice [19:01:22] YuviPanda: bearND|lunch dbrant|lunch : Congrats. Wikipedia Beta on Android is now rated higher then the stable market release [19:01:49] tfinc: :D woot! [19:02:04] i had been keeping tabs on it waiting to happen [19:04:11] tfinc: awesome! [19:06:43] kaldari: MaxSem - lunch? [19:06:54] yes, one sec... [19:07:22] yeah! [19:08:10] dr0ptp4kt: looking... [19:11:27] dbrant: thx [19:16:56] dbrant: are there any code changes in https://gerrit.wikimedia.org/r/#/c/140735/3 besides rebasing? [19:17:18] bearND: nope, just rebase [19:17:57] dbrant: was just wondering since you had the card moved to code review [19:19:06] (03PS2) 10JGonera: [WIP] Tweak VE overlay to support mobile context [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/141087 [19:20:51] (03PS1) 10JGonera: Remove a workaround for position: fixed button bars [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/141494 [19:21:08] (03PS3) 10JGonera: [WIP] Tweak VE overlay to support mobile context [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/141087 [19:29:02] (03CR) 10Siebrand: "i18n/L10n reviewed." (032 comments) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/140937 (owner: 10BearND) [19:33:45] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/140620 (owner: 10Kaldari) [19:38:19] (03PS1) 10Dr0ptp4kt: When logging MCC-MNC, get both network and SIM. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/141497 [19:41:04] ^ bearND and dbrant your review and approval of 14197 would also be appreciated. it's just a header enrichment enhancement, which will actually be a server-side no-op until we update some server-side code. but i'd rather get this in the app with the server side no-op than wait. we can actually get the server side converted from no-opt to op as soon as wednesday; this is server-side el, not client side [19:42:10] (03PS5) 10Yuvipanda: Add method to update one or more saved pages [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/140310 (owner: 10BearND) [19:42:15] bearND: dbrant ^ is complete now. [19:42:26] needs instrumentation, but I'll do that as a part of 'check all EL!' sprint tomorrow [19:42:29] dr0ptp4kt: am looking [19:42:38] YuviPanda: thx [19:43:38] dr0ptp4kt: hmm, getSimOperator will be null if it is CDMA, and not throw an error? [19:44:05] dr0ptp4kt: I guess it's ok since we don't crash on errors anyway [19:45:20] dr0ptp4kt: I'm ok to merge after ^ [19:45:37] hmm, I'm ok to merge either way. let me test (on my GSM phone) [19:46:33] YuviPanda: it may or may not be null; 000-00 will be a hotword when we query the database [19:46:38] dr0ptp4kt: right. [19:46:43] dr0ptp4kt: and I guess nothing else will be 000-00 [19:47:22] YuviPanda: yep yep [19:47:53] (03CR) 10Yuvipanda: [C: 032] When logging MCC-MNC, get both network and SIM. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/141497 (owner: 10Dr0ptp4kt) [19:48:02] YuviPanda: thx [19:48:08] dr0ptp4kt: yw :) [19:48:21] (03Merged) 10jenkins-bot: When logging MCC-MNC, get both network and SIM. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/141497 (owner: 10Dr0ptp4kt) [19:48:40] (03Abandoned) 10Yuvipanda: Manual Localization update from TWN [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/141253 (owner: 10Yuvipanda) [19:48:46] (03Abandoned) 10Yuvipanda: Bump version number for 2.0-beta-2014-06-18 [apps/android/wikipedia] (beta) - 10https://gerrit.wikimedia.org/r/140577 (owner: 10Dbrant) [19:48:52] (03Abandoned) 10Yuvipanda: Move everything to beta package [apps/android/wikipedia] (beta) - 10https://gerrit.wikimedia.org/r/140217 (owner: 10Dbrant) [19:49:03] (03Abandoned) 10Yuvipanda: Move everything to beta package [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/137311 (owner: 10Yuvipanda) [19:49:06] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/140310 (owner: 10BearND) [19:49:37] dbrant: bearND I"ll be around for another 20-30m (FYI) [19:50:06] YuviPanda: thanks for the heads-up [19:50:11] :) [19:50:18] took painkillers for the hand, and they are starting to set in [19:50:19] dr0ptp4kt: and you say you've confirmed the data coming in? (from ConnectionIssueFunnel) [19:50:46] YuviPanda: too much typing? [19:50:55] bearND: yeah. over 13 years [19:51:02] I can hardly hold a plate of food with one hand now [19:51:08] dbrant: yep! select clientIp, event_failedEndpoint, event_applicationContext from MobileWikiAppStuffHappens_8955468\G [19:52:15] YuviPanda: ouch. sorry to hear. [19:52:34] bearND: yeah. hopefully I can recover fully (physio) [19:53:13] (03PS2) 10Dbrant: Log (hopefully) recoverable connection errors. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/141079 (owner: 10Dr0ptp4kt) [19:53:20] dbrant: thx [19:53:25] (03CR) 10Dbrant: [C: 032] Log (hopefully) recoverable connection errors. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/141079 (owner: 10Dr0ptp4kt) [19:53:47] (03Merged) 10jenkins-bot: Log (hopefully) recoverable connection errors. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/141079 (owner: 10Dr0ptp4kt) [19:56:10] (03PS1) 10Yuvipanda: Send Crash Reports to different OTRS queue [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/141531 [19:56:13] dbrant: bearND there's a new queue just for crash reports. makes the original queue less cluttery. [19:56:29] dbrant: bearND I also started https://etherpad.wikimedia.org/mobile-app-otrs to write up guidelines to help volunteers respond [19:56:34] YuviPanda: nice! [19:56:56] dbrant: we already have a couple of volunteers :) [19:57:11] dbrant: bearND do check the etherpad and edit as you see fit. I'll move it to the OTRS wiki tomorrow [19:57:46] tfinc: Hey Tom, do you know if there are any benefits that might help cover learning a foriegn language? Just curious. [19:58:42] YuviPanda: thanks. that's a great overview [19:59:47] bearND: I also left a minor comment on https://gerrit.wikimedia.org/r/#/c/140181/ [20:00:06] tfinc: I'll ask gayle if you're not sure [20:00:30] bearND: dbrant we should make a beta/alpha release once the current outstanding patches are done. Abusefilter should probably not be merged until after release. [20:00:48] bearND: dbrant also are you guys ok with using the make-beta script when I'm not around? we haven't used that before, I think [20:01:20] YuviPanda: I haven't tried it yet, but will surely try. [20:01:26] ok [20:01:33] let me also do a translation update. italian just got completed [20:01:38] YuviPanda: yes, beta script is great [20:01:46] :D [20:02:44] YuviPanda: do you want to get https://gerrit.wikimedia.org/r/#/c/140181/ (Reorder buttons on Find in Page) in for the release? [20:02:58] bearND: yeah, that'd be nice. it shouldn't be too hard a fix... [20:03:02] bearND: but it's not high priority. [20:03:07] YuviPanda: ok [20:03:26] I'd say update all saved pages and the privacy policy stuff is higher priority [20:05:27] YuviPanda: dbrant: looking at https://gerrit.wikimedia.org/r/#/c/140735/3 right now. I'd like to get this one in as well [20:05:39] (03PS1) 10Yuvipanda: Manual translation import from TWN [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/141555 [20:05:53] bearND: I don't actually know if that's nice behavior. [20:06:37] YuviPanda: you mean the loading from history page? [20:06:42] bearND: yeah [20:06:52] if you're in history, you'd expect it to not change behavior based on where it was from [20:06:58] and we don't have a clear indicator it was loaded from saved pages [20:07:15] accidentally loading a potentially out of date version of the page sounds dangerous to me [20:07:25] esp. if you go back on history to see if there's any updates to the thing [20:07:45] also considering that right now that's the easiest way to see the updated version of a page that you have saved. [20:08:02] kaldari: i remember awhile back you said you were working on a disambiguation thingy for mobile -- what ever happened to that? [20:08:50] YuviPanda: interesting thought. Deskana|Away submitted it. we should probably check with him. Then i'm fine with putting that one on the back burner [20:09:06] bearND: yeah. it doesn't need to make it to this beta, I'd think [20:09:06] kaldari: yes there are. wellness can be used for that but there is also a shared engineering budget for that [20:09:09] good question… Jared was supposed to get back to me about that, but I totally forgot about it [20:09:42] YuviPanda: bearND dbrant : you guys still have 3 stories in https://trello.com/b/KNqImlQo/mobile-app-sprint-33-the-final-android-countdown for CR review . what else do you guys need to review these? [20:09:45] YuviPanda: dbrant: we should move the card to somewhere though [20:09:55] i'd like to ship Dan a build with these changes so that we can close the board [20:09:56] kaldari: i'd like to see it when you have a sec, if there's something to look at/play with :) [20:10:13] tfinc: Thanks! That's exciting. I might actually have a use for my wellness money! [20:10:17] mobile dab solving is near and dear to my heart [20:10:35] tfinc: yeah, going to get merged in the next hour at worst, I'd say [20:10:44] YuviPanda: thanks [20:10:48] Maryana: btw, desktop dabsolver might die soon. The original author is unwilling to move it to toollabs [20:10:55] oh no! [20:10:59] Maryana: by 'soon' I mean 1 July [20:11:06] all the more reason to create a mobile version asap! [20:11:14] Maryana: https://en.wikipedia.org/wiki/User:Dispenser/Toolserver_migration [20:11:31] Maryana: me and a bunch of others have poked him about it, but doesn't seem to be having much of an effect [20:11:38] Deskana|Away: how goes moving through the todo column in https://trello.com/b/KNqImlQo/mobile-app-sprint-33-the-final-android-countdown ? [20:11:52] tfinc: Just starting up on that again now. [20:11:59] 3Wikipedia App / 3iOS App: iOS App: {{PLURAL:}} not parsed properly - 10https://bugzilla.wikimedia.org/66944#c2 (10Dan Garry) 5NEW>3RESO/INV (In reply to Kunal Mehta (Legoktm) from comment #1) > Hmm, this is actually the API returning the un-parsed PLURAL. > > ApiCreateAccount calls dieStatus, which use... [20:14:59] 3Wikipedia App / 3iOS App: iOS App: Last modified by doesn't display IP addresses - 10https://bugzilla.wikimedia.org/66909#c3 (10Dan Garry) 5NEW>3RESO/WON For simplicity's sake we're going to keep this as it is for now. We can reassess this decision further down the line if necessary. [20:15:10] Deskana|Away: can we move https://trello.com/c/3iLYdggQ/86-saved-pages-are-not-loaded-if-selected-via-history-list-while-offline to the backlog or kill it? Based on earlier convo with YuviPanda it shouldn't go into the next beta release [20:15:21] dbrant: ^ [20:15:41] (03PS1) 10Dr0ptp4kt: Log both the network and SIM MCC-MNC values. [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/141558 [20:16:01] YuviPanda: :-/ [20:16:18] bearND: Deskana|Away: I would agree with that; but I would need to separate this from it: https://trello.com/c/dlAbiFFG [20:16:24] bearND: You guys are low on cards for this sprint. Why do you want to backlog it? [20:16:31] Deskana|Away: I put rationale on the card [20:16:43] yurikR: when you get a moment, would you please review and +2 https://gerrit.wikimedia.org/r/141558 ? if possible, would be nice to have deployed on Wednesday, too. [20:16:50] * Deskana|Away reads. [20:16:53] Deskana|Away: I think it'd be a confusing and unexpected feature. History and Saved Pages work differently on iOS and Android. [20:17:03] dr0ptp4kt, looking [20:17:08] yurikR: thx [20:17:23] Oh, I know. This isn't about iOS at all. I just think it's a bit weird how it's telling you there's no content available even though there is. [20:18:05] Deskana|Away: sure, so the proper way to do it is to make it an underlying thing - if you access a page that's saved but you don't have network by *any* means (click a link, search, etc) you should get that plus a notice. Just doing it in Saved pages without a notice seems unexpected. we could backlog it and build *that* out. [20:18:41] That sounds like a better solution. But yeah, not a priority. [20:18:43] Okie doke. [20:18:59] * Deskana|Away notes this on the card. [20:23:21] (03PS1) 10BearND: Update a few strings based on L10N review [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/141560 [20:23:52] (03CR) 10Yuvipanda: [C: 032] Update a few strings based on L10N review [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/141560 (owner: 10BearND) [20:24:14] (03Merged) 10jenkins-bot: Update a few strings based on L10N review [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/141560 (owner: 10BearND) [20:24:25] mhurd, brion: Heads up that I've moved this to the current sprint: https://trello.com/c/Onxl3nfj/26-ios-app-after-account-creation-login-hangs [20:24:44] mhurd, brion: It seems like the create account form on the onboarding is a bit broken. :/ [20:24:46] Deskana|Away: i believe we fixed that recently [20:25:01] i moved it to signoff col :D [20:25:05] How recently is recently? It's still an issue in build #29. [20:25:11] Maryana: Here are the mock-ups: http://staging.noblestudios.com/wikipedia/dab-solver/ [20:25:19] Deskana|Away: merged this morning so it should be in next build [20:25:25] brion: Sweet! Thanks. [20:25:44] kaldari: oh yeah, i remember working with noble on the designs for this :) [20:25:48] but you actually built it? [20:26:25] Maryana: No, should I? [20:26:39] haha, well, probably not in your spare time [20:26:48] but it's one of the mobile contribution ideas for next year [20:27:05] Maryana: I did do preliminary infrastructure work for it though... [20:27:10] nice [20:27:27] dr0ptp4kt, why not log everything and optionally - if it matches your regex, parse it into a different field? with your patch, you only log in case you recognize mcc structre [20:27:54] Maryana: https://www.mediawiki.org/wiki/Extension:Disambiguator [20:28:00] kaldari: rad! [20:28:34] Maryana: That is currently installed on all project (and in use by VisualEditor even) [20:28:52] yurikR: garbage in, garbage out [20:28:58] kaldari: are most disambig pages marked with the magic word? [20:29:15] YuviPanda: On en.wiki, nearly 100% [20:29:23] kaldari: ah, cool [20:29:47] kaldari: does it have an API to list both disambig pages and pages that link to them? [20:29:57] kaldari: nevermind I see it [20:30:01] YuviPanda: As it's embedded in all the disambig templates. Same on several other projects, but I haven't done a broad survey. [20:30:04] dr0ptp4kt, couldn't a carrier have a different structure for that field? Every carrier could come up with something else? [20:30:14] logging it would allow us to catch them? [20:30:15] 3Wikipedia App / 3iOS App: iOS App: Visiting a page you've already visited returns you to that scroll position - 10https://bugzilla.wikimedia.org/66903#c2 (10Dan Garry) (In reply to Monte Hurd from comment #1) > This behavior was added intentionally. Do you think maybe it should only > behave this way when y... [20:30:49] YuviPanda: Unfortuantely, MiserMode makes it less useful than it could be [20:31:31] yurikR: in practice the mcc-mnc is standardized [20:31:38] kaldari: true, but it's good enough for building an app / game [20:31:50] yes [20:32:02] dr0ptp4kt, oki, up to you [20:32:32] kaldari: one thing the API should add is probably when you query a list of pages that link to disambig pages, list the actual disambig pages that are linked to [20:33:29] YuviPanda: It does [20:33:38] otherwise, it would be fairly useless :) [20:33:38] kaldari: oh, cool [20:33:40] kaldari: yeah :) [20:34:12] kaldari: I've been meaning to play with ReactJS and stuff, and was thinking of porting Dabsolver to tools but make it work nicely on mobile too (haven't written any JS in a while). might do that when the app release madness is done [20:34:33] kaldari: I was expecting to actually do all the things the API does on tools with sql, but awesome to have the API :) [20:35:17] dr0ptp4kt, actually, what i meant initially was that you used to match /^\d+-\d+$/, and now you go for /^(\d+-\d+),(\d+-\d+)$/ - but you had managed to log things initially, which means some carriers do use that format? [20:35:42] yurikR: no, we changed the app to log two things now, instead of one. [20:36:05] YuviPanda: It might run out of things to fix due to MiserMode though. Right now Ops is only running expensive query pages in MiserMode wikis once every 6 months, which really sucks :( [20:36:17] kaldari: hmm, true. [20:36:37] kaldari: wait, but if a page is 'fixed' so it no longer has any disambig outgoing links, won't that clear up space? [20:36:39] YuviPanda, gotcha, thx [20:37:41] yurikR: i'll create a separate card to explore the concept of logging bad values (e.g., l33t h4x0rs) to a separate el namespace altogether. that way we don't end up potentially polluting the well-formed el ns-schema. i'd like to get this one in on wednesday, though, coincident with the launch [20:38:10] YuviPanda: query pages use a database cache, and in this case the cache is updated once every 6 months. So you would have to keep track of which ones are fixed somewhere else, unfortunately. [20:38:17] kaldari: aaah, damn. [20:38:24] kaldari: might have to do that query on tools then, I guess [20:38:28] and cache more aggressively [20:38:31] YuviPanda: yeah [20:38:46] kaldari: is it expensive because of pageprops dependency? [20:38:51] kaldari: hmm, that makes the API kinda useless :( [20:38:52] it's just too expensive for production I guess [20:39:02] yurikR: i just created a card on the board called "Log malformed MCC/MNC to separate EL namespace-schema" [20:39:18] YuviPanda: It works great on wikis that aren't in MiserMode though :P [20:39:25] kaldari: :P [20:39:51] dr0ptp4kt, its ok, i for some dumb reason thought that value was created by carrier, not by our app. Ignore my comment. One thing - shouldn't the var $matches be created before passing by ref? [20:41:26] YuviPanda: the combination of joining page, page_links, and page_props makes it quite expensive :( [20:41:45] kaldari: yeah [20:41:51] (03CR) 10Siebrand: "i18n/L10n reviewed." (031 comment) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/140874 (owner: 10Dr0ptp4kt) [20:43:36] yurikR: dunno, would you recommend it as a matter of style? i'm happy to change that if you recommend it [20:44:19] dr0ptp4kt, i couldn't find any definitive answer if a var must be declared/assigned before being passed in by ref in php. [20:44:54] anyone remembers php spec by heart? :) [20:45:06] (03PS1) 10Brion VIBBER: Hack to fix table scrolling on iOS [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/141567 [20:45:13] (03PS3) 10BearND: Reorder buttons on Find in Page [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/140181 [20:46:24] YuviPanda: ^ I think it probably would be nice to also move the Find in Page menu item up by one (between Save page and Share). Thoughts? [20:46:32] MaxSem, ^^^ [20:46:47] bearND: nah, let's leave it there for now. chrome has it pretty far down [20:46:55] bearND: let me merge [20:46:57] YuviPanda: ok [20:47:01] bearND: dbrant can either of you review the update pages patch? [20:47:06] (03PS4) 10Yuvipanda: Reorder buttons on Find in Page [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/140181 (owner: 10BearND) [20:47:11] YuviPanda: check the background color change, too [20:47:19] bearND: hmm? [20:47:34] YuviPanda: in the same patch [20:47:56] bearND: checking [20:47:57] yurikR: MaxSem said mainly if it doesn't emit a notice, it's not really necessary. that said, let's just do it. one minute. [20:48:35] (03PS4) 10JGonera: [WIP] Tweak VE overlay to support mobile context [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/141087 [20:48:37] (03PS1) 10JGonera: Don't nest .overlay-header and .overlay-head-container [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/141570 [20:49:27] (03CR) 10Yuvipanda: [C: 032] Reorder buttons on Find in Page [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/140181 (owner: 10BearND) [20:49:49] (03Merged) 10jenkins-bot: Reorder buttons on Find in Page [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/140181 (owner: 10BearND) [20:50:17] kaldari, whenever you have a moment, could you check https://gerrit.wikimedia.org/r/#/c/141494/ and https://gerrit.wikimedia.org/r/#/c/141570/ ? I don't want to nest too many dependencies when working on VE, those two patches seem to be safe to merge [20:50:26] sure [20:51:01] (03PS2) 10Dr0ptp4kt: Log both the network and SIM MCC-MNC values. [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/141558 [20:51:05] (03PS2) 10Dbrant: More compatible arrangement of 'privacy policy' and 'terms of use' [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/141451 (https://bugzilla.wikimedia.org/66916) [20:51:18] yurikR: ^^ okay, initialized variable before using. [20:51:23] dbrant: checking that patch now [20:51:29] (03PS3) 10Yuvipanda: More compatible arrangement of 'privacy policy' and 'terms of use' [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/141451 (https://bugzilla.wikimedia.org/66916) (owner: 10Dbrant) [20:52:39] dbrant: won't the framelayout cause problems when the strings are long enough to overlap? [20:52:47] I don't think that happens with any of the languages, but still [20:54:05] (03PS2) 10BearND: Send Crash Reports to different OTRS queue [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/141531 (owner: 10Yuvipanda) [20:54:18] (03CR) 10BearND: [C: 032] Send Crash Reports to different OTRS queue [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/141531 (owner: 10Yuvipanda) [20:55:03] (03Merged) 10jenkins-bot: Send Crash Reports to different OTRS queue [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/141531 (owner: 10Yuvipanda) [20:55:22] Deskana: unsure if I showed you, but I've been working with OTRS admins and volunteers to get us more support after the launch. So far we've had https://etherpad.wikimedia.org/p/mobile-app-otrs :) Also has guidelines for volunteers to deal with responses, and we also separated the crash reports into a different queue [20:55:29] Deskana: should make wading through qualitative feedback easier [20:55:53] Deskana: only thing we need to do now is to create a 'roadmap' page and keep that reasonably up to date so volunteers know how to respond to what [20:56:05] I'll start on that page tomorrow, but it'll be great if you can eventually take ownership of that [20:56:30] (03CR) 10Brion VIBBER: [C: 032 V: 032] "seems to work, merge this for now..." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/141567 (owner: 10Brion VIBBER) [20:56:42] YuviPanda: Sweet! [20:56:49] brion: wat, self merging!!!1 :) [20:56:50] YuviPanda: Well, they're crashes, so not sweet. You know what I mean. :P [20:56:54] Deskana: yeah :) [20:56:55] :D [20:57:15] Deskana: working with OTRS has been awesome. Should email Phillippe (too many chars?) after the release [20:57:36] dr0ptp4kt, another minor thought - could you reverse mt_rand() check and preg_match? and I don't know if $matches=array() is as fast as $matches=null; [20:57:45] One l, iirc. [20:59:08] Deskana: ah, ok :) [20:59:22] dr0ptp4kt, but i think mt_rand should give you an answer before doing the whole string regex parsing [20:59:29] Deskana: RD and pajz have been super helpful, so if you need anything do feel free to ask them. There's also a #wikimedia-otrs channel. [20:59:53] dr0ptp4kt, or am i just nitpicking? :) [21:00:15] (03PS4) 10Dbrant: More compatible arrangement of 'privacy policy' and 'terms of use' [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/141451 (https://bugzilla.wikimedia.org/66916) [21:02:03] aww ... stackoverflow outage [21:02:18] dbrant: I remember a way to get them to be on the same line but behave properly when they overlap. mind if I amend the patch? [21:02:19] i wonder how much software development slows down when this happens [21:02:27] (03CR) 10BearND: [C: 04-1] Manual translation import from TWN (031 comment) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/141555 (owner: 10Yuvipanda) [21:02:30] YuviPanda: oh sure [21:02:39] ok good. their back in r/o mode [21:03:07] bearND: hmm, unsure how to fix that. [21:03:10] bearND: don't know italian [21:03:38] YuviPanda: not sure what the process is to submit L10N bugs [21:03:42] bearND: also great catch. we should write a script for this [21:04:12] bearND: usually you just gofixit on translatewiki.net, but since none of know Italian (I presume?) I've asked someone who does (Nemo_bis) on #mediawiki-i18n to see if they can help [21:04:30] bearND: another option is to amend the patch to remove just that [21:04:32] dr0ptp4kt, need to step away for a sec, email what you think, will review in 15 min [21:05:04] YuviPanda: That was caught by the TranslationTests I created a while ago. It's fine to fix that later, but I think we should be able to just add it to the end of the first sentence. [21:05:26] bearND: nah, I'd rather not muck with translations like that. we should just remove that one [21:05:31] bearND: since it'll crash the app otherwise [21:05:40] bearND: can you amend the patch removing that one? [21:06:07] YuviPanda: sure but how do we let translators know that there's a problem? [21:06:21] bearND: good question. I'll ask for the process [21:07:36] bearND: can you hop over to #mediawiki-i18n? [21:08:03] YuviPanda: there [21:08:39] dbrant: repeating, : [21:08:46] > Nike rabbit: do you know what the process is to report issues with a translation, for future cases like these? bearND was asking [21:08:58] > YuviPanda: we don't have good process for that [21:09:04] (I said the first thing, he did the second) [21:09:24] (03PS3) 10Dr0ptp4kt: Log both the network and SIM MCC-MNC values. [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/141558 [21:09:58] yurikR: it's all good, just reposted at ^ [21:10:36] yurikR wait one sec, gotta fix that [21:10:50] (03CR) 10Dbrant: [C: 032] Login and create account buttons [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/141380 (owner: 10BearND) [21:10:58] (03PS4) 10Dr0ptp4kt: Log both the network and SIM MCC-MNC values. [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/141558 [21:15:35] (03PS1) 10MaxSem: Simplify redirect cookie system [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/141576 [21:18:24] (03CR) 10jenkins-bot: [V: 04-1] Simplify redirect cookie system [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/141576 (owner: 10MaxSem) [21:19:27] (03PS1) 10Brion VIBBER: Restore hiding of broken audio tags [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/141579 [21:19:39] (03CR) 10Brion VIBBER: [C: 032 V: 032] Restore hiding of broken audio tags [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/141579 (owner: 10Brion VIBBER) [21:19:58] (03PS5) 10Yuvipanda: More compatible arrangement of 'privacy policy' and 'terms of use' [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/141451 (https://bugzilla.wikimedia.org/66916) (owner: 10Dbrant) [21:20:02] brion: more self merging! [21:20:04] * YuviPanda shakes head :P [21:20:10] tsk tsk [21:20:11] dbrant: bearND ^ for the about page [21:20:17] brion: why the self merges tho? [21:20:26] YuviPanda: lazy! [21:20:26] ;) [21:20:33] and i just want to get some quick fixes in quick ;) [21:20:38] brion: oh come on. I'm sure mhurd would be happy to merge them quickly too [21:20:41] you're even in the office! [21:20:45] :D [21:21:31] brion: it does care me when someone self merges a non-doc/typo fix patch every time. don't scare poor yuvi [21:21:37] ;_; [21:21:41] ok i’ll be good [21:21:45] brion: :) [21:22:08] peer pressure is what keeps our best practices strong ;)) [21:22:20] brion: haha :D [21:23:10] YuviPanda: your patch still doesn't look right with RTL. [21:23:28] dbrant: hmm? let me send you a screenshot... [21:23:29] 3Wikipedia App / 3iOS App: iOS App: {{PLURAL:}} not parsed properly - 10https://bugzilla.wikimedia.org/66944#c3 (10Kunal Mehta (Legoktm)) 5RESO/INV>3REOP Well, it's still a bug in the app, since users shouldn't ever see a raw {{PLURAL:}}. It might need to be fixed in the API, not really sure if the app c... [21:24:48] (03CR) 10JGonera: [C: 032] Fix stopMobileRedirect cookie being set twice with different prefixes [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/141102 (https://bugzilla.wikimedia.org/66888) (owner: 10MaxSem) [21:24:52] (03PS2) 10BearND: Manual translation import from TWN [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/141555 (owner: 10Yuvipanda) [21:25:15] YuviPanda: just commented out the offending string ^ [21:25:22] (03Merged) 10jenkins-bot: Fix stopMobileRedirect cookie being set twice with different prefixes [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/141102 (https://bugzilla.wikimedia.org/66888) (owner: 10MaxSem) [21:25:30] bearND: cool. feel free to merge :) [21:25:43] YuviPanda: ah, I see. I was testing with non-translated strings. [21:25:44] YuviPanda: let me run the tests again [21:25:48] dbrant: ah, right. [21:26:02] YuviPanda: familiar with quasseldroid ? [21:26:12] matanya2: not really, no. ragesoss uses it tho [21:26:34] yep, I do. [21:26:47] (03PS1) 10MaxSem: Fix stopMobileRedirect cookie being set twice with different prefixes [extensions/MobileFrontend] (wmf/1.24wmf10) - 10https://gerrit.wikimedia.org/r/141580 (https://bugzilla.wikimedia.org/66888) [21:26:59] (03CR) 10MaxSem: [C: 032] Fix stopMobileRedirect cookie being set twice with different prefixes [extensions/MobileFrontend] (wmf/1.24wmf10) - 10https://gerrit.wikimedia.org/r/141580 (https://bugzilla.wikimedia.org/66888) (owner: 10MaxSem) [21:27:09] ragesoss: do you have a binary to share with me ? saw your post about it [21:27:14] 3Wikipedia App / 3iOS App: [iOS app] Media files do not work - 10https://bugzilla.wikimedia.org/66722#c2 (10Brion Vibber) Ok, as a quick fix I've restored the code that hides the "Cannot play audio file" on audio bits, will see about making both audio and video able to open in VLC later. [21:27:19] (03PS1) 10MaxSem: Fix stopMobileRedirect cookie being set twice with different prefixes [extensions/MobileFrontend] (wmf/1.24wmf9) - 10https://gerrit.wikimedia.org/r/141581 (https://bugzilla.wikimedia.org/66888) [21:27:26] Deskana: hey have a sed? [21:27:30] Deskana: sec [21:27:36] * YuviPanda gives mhurd sed and grep [21:27:40] you want a binary because you don't have Google Play store, matanya2? [21:27:40] hehe [21:27:43] (03Merged) 10jenkins-bot: Fix stopMobileRedirect cookie being set twice with different prefixes [extensions/MobileFrontend] (wmf/1.24wmf10) - 10https://gerrit.wikimedia.org/r/141580 (https://bugzilla.wikimedia.org/66888) (owner: 10MaxSem) [21:27:44] 3Wikipedia App / 3iOS App: iOS App: Bottom of article says "1 other languages" - 10https://bugzilla.wikimedia.org/65825#c2 (10Brion Vibber) New design will change this text... [21:27:49] (03CR) 10MaxSem: [C: 032] Fix stopMobileRedirect cookie being set twice with different prefixes [extensions/MobileFrontend] (wmf/1.24wmf9) - 10https://gerrit.wikimedia.org/r/141581 (https://bugzilla.wikimedia.org/66888) (owner: 10MaxSem) [21:28:12] jgonera, did we wanted to swat something else? [21:28:24] (03Merged) 10jenkins-bot: Fix stopMobileRedirect cookie being set twice with different prefixes [extensions/MobileFrontend] (wmf/1.24wmf9) - 10https://gerrit.wikimedia.org/r/141581 (https://bugzilla.wikimedia.org/66888) (owner: 10MaxSem) [21:28:30] ragesoss: yes. and lazy to build [21:28:31] bearND: dbrant I'm going to sleep in about 5min (my initial 30m estimate seems to have been forgotten :|). Need anything before that? [21:28:37] no, I don't think so, Maryana did we have any other urgent changes to deploy? [21:30:26] matanya2: https://www.dropbox.com/sh/uxpckeobyz612qj/j2k7QsU7xC [21:31:10] YuviPanda: any updates on "update all saved pages"? [21:31:20] bearND: it's done, awaiting code review :) [21:31:41] jgonera: for an LD window? potentially the zoom stuff you worked on [21:31:49] bearND: https://gerrit.wikimedia.org/r/#/c/140310/ [21:31:52] not super super urgent, but if you're pushing stuff out today anyway... [21:31:53] :) [21:31:56] matanya2: I think this is the one you want: https://www.dropbox.com/sh/uxpckeobyz612qj/AABWSZAf0g0Cx0k-Nl__y9wCa/quasseldroid_v0.9.8.apk [21:31:57] YuviPanda: cool :) [21:32:12] thank you ragesoss [21:32:13] bearND: :) feel free to review/merge, since I reset author (and added you as co-author) [21:32:15] if it's passed code review, that is. [21:32:27] MaxSem, if it's not much more work, then https://gerrit.wikimedia.org/r/#/c/141064/ would be nice too, for people with impaired vision [21:32:33] yep, it's merged marktraceur [21:32:34] Maryana, [21:32:43] heh [21:32:45] np [21:32:54] poor mark, always getting my pings [21:33:01] Maryana: btw, are you monitoring mobile-feedback-l? Erik pointed out that it was used as a place to request feedback on some blog post, but it was actually just discarding all messages. That was fixed, and now there are a few messages from people there about the redirect [21:33:15] jgonera, is it that urgent? [21:33:20] YuviPanda: have you added the fuzzy marking to the Italian translation? [21:33:30] bearND: nope. too sleep :) [21:33:32] too sellpy [21:33:33] err [21:33:35] sleepy [21:33:44] 3Wikipedia App / 3iOS App: [iOS app] Long math formulas are cut off - 10https://bugzilla.wikimedia.org/66680#c4 (10Brion Vibber) Something like this should work in the styles to force them to fit screen: img.tex { max-width: 100% } however without pinch-to-zoom in the app it may be tricky to read long fo... [21:34:11] brion: remember all style changes to to the mobilefrontend repo. content/*.less [21:34:31] brion: android and iOS specific css should be in Extension:MobileApp. [21:34:36] right [21:34:42] YuviPanda: ok. i just a few more translation issues. Will add a comment in Gerrit and remove those string by commenting them out [21:34:42] i’m just testing inline in the debugger for now :D [21:34:44] 3MobileFrontend / 3General/Unknown: Long math formulas break article layout on mobile devices / small screens - 10https://bugzilla.wikimedia.org/66679#c7 (10Brion Vibber) On bug 66680 I recommend the max-width: 100% solution; it's easy, but perhaps should be paired with restoring pinch-to-zoom... [21:35:01] office wifi kicks me out now and then... reposting [21:35:05] MaxSem, if it's not much more work, then https://gerrit.wikimedia.org/r/#/c/141064/ would be nice too, for people with impaired vision [21:35:06] YuviPanda: insert "found" ^ [21:35:08] yep, it's merged Maryana [21:35:09] bearND: ok :) [21:35:36] bearND: dbrant Deskana alright, I'm off :) Do make a release when the update saved pages gets merged, and if it isn't by EOD make a release anyway. [21:35:44] thanks for being awesome, y'all! [21:35:51] * YuviPanda waves away [21:36:23] YuviPanda: Thank YOUvi [21:37:29] 3MobileFrontend / 3stable: "Read in another language" gives desktop site's links - 10https://bugzilla.wikimedia.org/65047#c4 (10fireattack) 5RESO/INV>3REOP I'm going to re-open this issue, because I found that you have no way to "leave" desktop version, if you ever clicked, except clearing your cookie.... [21:37:52] (03CR) 10Kaldari: Add text to next & save buttons in mobile editors (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/140620 (owner: 10Kaldari) [21:39:13] (03PS10) 10Kaldari: Add text to next & save buttons in mobile editors [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/140620 [21:39:44] 3MobileFrontend / 3stable: "Read in another language" gives desktop site's links - 10https://bugzilla.wikimedia.org/65047#c5 (10Brion Vibber) This is probably related to the extra '*stopMobileRedirect' cookies that I found on my iPad, which there are some fixes going in for soon. If I understand the problem... [21:42:07] (03PS3) 10BearND: Manual translation import from TWN [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/141555 (owner: 10Yuvipanda) [21:42:51] (03PS4) 10BearND: Manual translation import from TWN [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/141555 (owner: 10Yuvipanda) [21:43:06] (03CR) 10BearND: [C: 032] Manual translation import from TWN [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/141555 (owner: 10Yuvipanda) [21:43:31] (03Merged) 10jenkins-bot: Manual translation import from TWN [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/141555 (owner: 10Yuvipanda) [21:44:59] 3MobileFrontend / 3stable: "Read in another language" gives desktop site's links - 10https://bugzilla.wikimedia.org/65047#c6 (10Max Semenik) 5REOP>3RESO/INV Yep, that's bug 66888. [21:46:14] 3MobileFrontend / 3General/Unknown: Hash gets swallowed (again) - 10https://bugzilla.wikimedia.org/64918#c7 (10Jon) 5REOP>3RESO/WOR See features/toggling.feature According to the test it's not broken. Plus, when I follow those steps on my Android Chrome device it works for me. If it's not working on an... [21:50:44] 3MobileFrontend / 3stable: "Read in another language" gives desktop site's links - 10https://bugzilla.wikimedia.org/65047#c7 (10fireattack) 5RESO/INV>3REOP (In reply to Brion Vibber from comment #5) > This is probably related to the extra '*stopMobileRedirect' cookies that I > found on my iPad, which the... [21:53:28] 3MobileFrontend / 3stable: "Read in another language" gives desktop site's links - 10https://bugzilla.wikimedia.org/65047#c8 (10fireattack) Oh please don't mark this one as resolved since even though it's relevant to bug 66888, they two are not the same one (just bug 66888 makes this more annoying). [21:54:01] jdlrobson, are you working on https://bugzilla.wikimedia.org/show_bug.cgi?id=65326 ? [21:57:01] YuviPanda|zzz, dbrant|bbl, bearND: In your experience, once we push the app out, will it take time to propagate like the beta updates do? [21:57:10] YuviPanda|zzz, dbrant|bbl, bearND: Trying to figure out how to target communications. [21:57:59] Deskana: yes, it should take about the same time, roughly an hour or two [21:58:22] Deskana: at least to reach the first customers. [21:58:52] bearND: So do we push it early in the (SF) morning, then wait for a few hours to do the comms (blog post, press releases, etc.)? [21:58:59] Deskana: there are many more though for production, at a scale i have not yet experienced myself but i guess it would take a bit longer to reach all [21:59:45] jgonera: god no. [21:59:55] jdlrobson, ok, removing you ;) [21:59:58] bearND: We should set an actual time to push so we can give that to the comms team. [22:00:06] jgonera: i've never seen that bug in my life [22:00:20] Assignee: jforrester+veteambztickets@wikimedia.org → jrobson@wikimedia.org mmm [22:00:21] Deskana: that sounds fine to me. BTW, do we have updated text for the app in the store? [22:00:37] bearND: Not yet. Writing updated text is on my to do list for today. :) [22:00:56] jdlrobson, yeah, changed by Rummana, not sure why [22:01:01] I removed you [22:01:03] Deskana: we also would need that translated I think, and some clean screenshots added [22:01:20] jgonera: if you don't have it turned on https://bugzilla.wikimedia.org/userprefs.cgi put "When viewing a bug, show all bug activity" to On [22:01:25] it is very enlightening [22:01:47] jdlrobson, I guess I do, but how would it tell me if you have worked on it or not? [22:02:10] well you can see that i was assigned the bug and you know me i would have commented before taking it :) [22:02:18] or moved a card somewhere [22:02:45] I don't think there's a card. Anyway, the situation was not clear to me, so I asked [22:03:51] (03PS6) 10BearND: Add method to update one or more saved pages [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/140310 [22:04:12] (03PS7) 10BearND: Add method to update one or more saved pages [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/140310 [22:05:01] (03CR) 10BearND: [C: 032] Add method to update one or more saved pages [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/140310 (owner: 10BearND) [22:05:23] (03Merged) 10jenkins-bot: Add method to update one or more saved pages [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/140310 (owner: 10BearND) [22:08:28] bearND: Notice: /Stage[main]/Admin/Admin::Groupmembers[releasers-mobile]/Exec[releasers-mobile_ensure_members]/returns: executed successfully [22:08:43] Admin::User[bsitzmann]/File[/home/bsitzmann/.ssh]/ensure: created [22:08:55] which means: you can now upload releases [22:09:58] mutante: awesome! Thanks! :) Someone (YuviPanda|zzz or dbrant|bbl) still needs to tell me how to do this. [22:10:44] bearND: it will involve connecting to a host called "caesium" [22:10:53] this is the server where you actually put the files for download [22:11:06] yea, YuviPanda|zzz can walk you through [22:11:22] Deskana: hey have a sec? [22:11:30] mhurd: Sure do. [22:11:58] (03PS1) 10Dr0ptp4kt: Make MCC-MNC logging pattern consistent with Android. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/141589 [22:12:44] brion or mhurd: would you please review and, if appropriate, +2 https://gerrit.wikimedia.org/r/141589 ? [22:13:11] mhurd: Do you want to chat on IRC, or Hangout? [22:13:35] bearND: if you want to try now if the actual login works, ssh bsitzmann@bast1001.wikimedia.org [22:13:36] Deskana: ah cool. no just wanted to say the checklist here: https://trello.com/c/Io6a0jEi/24-3-onboarding has a couple issues. specifically, the first and third items differ from the mocks, so we’ll have to split those out into separate stories. avoid scope creep and all :) [22:14:23] dr0ptp4kt: why’s it doubled? [22:14:43] mhurd: Sure. [22:14:54] Deskana: cool thanks! [22:15:04] mutante: Permission denied (publickey). [22:15:23] mutante: from bast1001 [22:15:47] dr0ptp4kt: ah i see, android lists separate SIM and network ones [22:15:48] mumblerit: i mean i was on bast , and then ssh into caesium [22:15:49] brion: it's the format expected by the latest EventLogging schema. with ios not allowing to differentiate between the network and the sim card, needed to double it up [22:15:51] and we only have ….. something [22:15:53] ok :D [22:15:58] brion: yeah :) [22:16:22] (03CR) 10Brion VIBBER: [C: 032 V: 032] "Looks good; would be nice if we could distinguish the sim from the network but ah well. :D" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/141589 (owner: 10Dr0ptp4kt) [22:16:27] bearND: hold on, pasting an example config [22:16:45] mhurd: I've split them off. I'll get design input on them when I'm done writing this email to Katherine. [22:16:57] brion: thx. i'll have some other stuff coming along the next few days. and lemme know should you guys need any extra resources code reviewing ios stuff [22:17:17] Deskana: sounds good. i’ll add notes as well as i believe both behaviors were deliberate and i think correct [22:17:20] dr0ptp4kt: thanks! [22:18:26] bearND: Can we set a time to push the APK then, so I can tell that to comms? 9am SF time? [22:19:46] bearND: http://paste.debian.net/106450/ [22:19:55] bearND: I'd normally avoid setting 9am things but all the Android devs are at a later time due to time zones. :) [22:22:14] (03PS2) 10MaxSem: Simplify redirect cookie system [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/141576 [22:22:43] Deskana: can't set a time. when we publish the apk the time it takes is just for propagating the apk to the caches i think. the publish process is almost instant [22:22:49] (03CR) 10jenkins-bot: [V: 04-1] Simplify redirect cookie system [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/141576 (owner: 10MaxSem) [22:22:58] bearND: Yeah, I mean set a time for publishing the APK. [22:23:00] Deskana: i mean a delayed time [22:23:14] bearND: So that I can at least tell the comms team *something*. [22:23:15] Deskana: we can do that manually [22:23:36] Yeah, yeah, I know, but let's set a time when we're going to do it so the comms team knows. :) [22:23:49] They're dealing with a lot of variables and I'd like to take one out the equation for them. [22:25:18] (03PS3) 10MaxSem: Simplify redirect cookie system [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/141576 [22:25:19] Deskana: sure, 9 am works fine; all Android devs are in earlier time zones than SF time anyway [22:25:49] you can ask the people who make "jouncebot" to announce it ;) [22:25:53] (03CR) 10jenkins-bot: [V: 04-1] Simplify redirect cookie system [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/141576 (owner: 10MaxSem) [22:26:02] fuck you jerkins [22:26:08] hrhr [22:27:44] mutante: just updated my ssh config. when I run "ssh caesium.wikimedia.org" it tells me "channel 0: open failed: administratively prohibited: open failed" [22:28:25] bearND: Great. Thank you. :) [22:28:43] bearND: Sorry for the quick back-and-forth on this! Trying to coordinate comms and engineering is tricky! [22:29:25] bearND: it's not caesium.wikimedia.org, just "caesium" [22:29:47] 3MobileFrontend / 3General/Unknown: Image caption text color is too light - 10https://bugzilla.wikimedia.org/67005 (10Quiddity) 3NEW p:3Unprio s:3normal a:3None The thumbnail caption-text in Mobile is currently colored #777. This is quite hard to read, and will be inconsistent with planned Desktop ch... [22:30:26] mutante: much better :) it works [22:30:29] 3MobileFrontend / 3General/Unknown: Image caption text color is too light - 10https://bugzilla.wikimedia.org/67005#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/4h2hdeNr [22:30:36] mutante: thank you [22:30:51] bearND: cool :) you're welcome, the full name would have been caesium.eqiad.wmnet, it's a local IP [22:31:06] bearND: ok, then i say from here let Yuvi tell you the rest, k? [22:31:43] bearND: cd /srv/org/wikimedia/releases/mobile [22:34:28] mutante: ty [22:42:56] (03PS5) 10JGonera: Tweak VE overlay to support mobile context [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/141087 [22:42:58] (03PS2) 10JGonera: Don't nest .overlay-header and .overlay-head-container [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/141570 [22:43:00] (03PS2) 10JGonera: Remove a workaround for position: fixed button bars [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/141494 [22:54:56] dbrant|bbl: bearND YuviPanda|zzz : brion mhurd : excellent job clearing out https://trello.com/b/KNqImlQo/mobile-app-sprint-33-the-final-android-countdown . when can we get Deskana builds to sign off on ? [22:55:14] 3MobileFrontend / 3General/Unknown: Image caption text color is too light - 10https://bugzilla.wikimedia.org/67005#c2 (10Jared Zimmerman (WMF)) consistency! wooooo! [22:55:16] tfinc: ya [22:56:03] (03CR) 10Yurik: [C: 032] Log both the network and SIM MCC-MNC values. [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/141558 (owner: 10Dr0ptp4kt) [22:57:59] (03Merged) 10jenkins-bot: Log both the network and SIM MCC-MNC values. [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/141558 (owner: 10Dr0ptp4kt) [22:59:38] dbrant: is https://gerrit.wikimedia.org/r/#/c/141451/ ready to be merged or should we wait until after alpha/beta release? [23:00:05] bearND: yes, that's ready [23:00:14] dbrant: ok, checking... [23:00:17] \o/ whee [23:01:11] Deskana: ok to move the scrolling chrome card to sprint 34? [23:01:42] mhurd: Done... I'm a little afraid of how many story points you guys have in that sprint. [23:02:09] Deskana: remember when i said 2 sprints would be a bit crazy ;) [23:02:20] Deskana: it’s crazy time [23:02:30] we do have a couple already done :D [23:02:36] mhurd: Take things slow and steady. None of these are showstoppers imo. :) [23:02:50] Deskana: oh and i added a bajillion little cards for style issues [23:02:56] feel free to kick them to the backlog [23:03:01] or prioritize them as desired :D [23:03:57] kaldari: did you need anything from VE team for the stuff you're working on? [23:04:12] we're meeting in r31 - lemme know if there's anything that's blocking you [23:04:26] brion: I think that's mainly up to design. I'll set a meeting up with them tomorrow and we can figure out what to do. [23:04:35] spiff. [23:04:44] 3MobileFrontend / 3General/Unknown: Image caption text color is too light - 10https://bugzilla.wikimedia.org/67005#c3 (10Jon) Greys/grays have always been a mess in mobile. We created 5 LESS variables to keep the shades of grey constrained to 5. Would be great to upstream these to core, get core using them a... [23:05:00] 3MobileFrontend / 3General/Unknown: Image caption text color is too light - 10https://bugzilla.wikimedia.org/67005#c4 (10Jon) Even better if we can use the thumbnail styling from core... [23:06:44] 3MobileFrontend / 3General/Unknown: Image caption text color is too light - 10https://bugzilla.wikimedia.org/67005#c5 (10Jared Zimmerman (WMF)) If body copy is Grey 3 perhaps we should use Grey 5 for captions. [23:07:41] (03CR) 10BearND: [C: 04-1] "clips version string" (031 comment) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/141451 (https://bugzilla.wikimedia.org/66916) (owner: 10Dbrant) [23:09:01] bearND: ah, i didn't notice Yuvi changed that. [23:09:10] bearND: let's just release without it [23:10:07] dbrant: if you submit an updated patch set to just revert this line then i'll +2 it [23:11:41] (03PS6) 10Dbrant: More compatible arrangement of 'privacy policy' and 'terms of use' [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/141451 (https://bugzilla.wikimedia.org/66916) [23:12:01] wandering home; mhurd ping me when the scrolling bar is ready to CR and i’ll poke that tonight or in the morning [23:12:18] (03PS7) 10BearND: More compatible arrangement of 'privacy policy' and 'terms of use' [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/141451 (https://bugzilla.wikimedia.org/66916) (owner: 10Dbrant) [23:12:27] dbrant: ty [23:13:57] (03CR) 10BearND: [C: 032] "looks great" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/141451 (https://bugzilla.wikimedia.org/66916) (owner: 10Dbrant) [23:14:21] (03Merged) 10jenkins-bot: More compatible arrangement of 'privacy policy' and 'terms of use' [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/141451 (https://bugzilla.wikimedia.org/66916) (owner: 10Dbrant) [23:14:37] dbrant: want me to do the release? [23:15:00] bearND: sure, if you're up for it [23:15:12] sure [23:16:27] dbrant: if you want to compile a list of "what's new" that would speed things up [23:17:19] bearND: sure [23:19:10] (03PS1) 10BearND: Bump version for release 2.0-alpha-2014-06-23 [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/141597 [23:19:50] First stab at app store description: https://www.mediawiki.org/wiki/User:DGarry_(WMF)/Apps/Android/Store_Description [23:20:01] (03CR) 10BearND: [C: 032] Bump version for release 2.0-alpha-2014-06-23 [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/141597 (owner: 10BearND) [23:20:21] tfinc, Maryana: ^^ Thoughts/edits welcome. [23:20:29] 3MobileFrontend / 3General/Unknown: Image caption text color is too light - 10https://bugzilla.wikimedia.org/67005#c6 (10Ryan Kaldari) See https://gerrit.wikimedia.org/r/#/c/117105 which is related. [23:20:37] tfinc, Maryana: It's formatted all wrong until you press edit, btw. :) [23:21:59] 3MobileFrontend / 3General/Unknown: Image caption text color is too light - 10https://bugzilla.wikimedia.org/67005#c7 (10Jared Zimmerman (WMF)) @ryan does this include all the colors from https://trello.com/c/IRqbu8p4/15-color-swatches or only the grey values? [23:22:19] (03Merged) 10jenkins-bot: Bump version for release 2.0-alpha-2014-06-23 [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/141597 (owner: 10BearND) [23:26:22] (03PS1) 10Dr0ptp4kt: Proactively handle network connection error. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/141600 [23:27:13] (03PS2) 10Kaldari: Change editor switcher to cog icon and move to right side [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/141092 [23:29:09] bearND: i'll email you the list of what's new [23:31:46] dbrant:ok [23:33:49] (03PS3) 10Kaldari: Change editor switcher to cog icon and move to right side [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/141092 [23:34:31] jgonera: https://gerrit.wikimedia.org/r/#/c/133301/ (jorm if you're near Jared can you also poke him) [23:35:06] i can't; i'm at home now. [23:35:08] jgonera: What were those VE changes you wanted me to review? [23:35:15] jdlrobson, we decided we're holding off with that patch for 3 weeks [23:35:16] dbrant: Deskana: tfinc: YuviPanda|zzz: alpha is published; on to beta now [23:35:28] jdlrobson, that's what Fabrice asked for, I'll -2 it for now [23:35:30] bearND: thanks [23:35:43] jgonera: okay. I got confused because Jared was poking gwicke earlier about it with a sense of urgency [23:35:59] i just want to see the back of that patch to be honest :-) [23:36:14] kaldari, they're not strictly VE: https://gerrit.wikimedia.org/r/#/c/141494/ & https://gerrit.wikimedia.org/r/#/c/141570/ [23:36:31] jdlrobson, I know, me too, but I don't want it to be reverted again [23:43:27] (03CR) 10Kaldari: [C: 032] "I'm trusting Julius on his claim that we don't have button bars at the bottom of the screen anymore." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/141494 (owner: 10JGonera) [23:44:11] (03Merged) 10jenkins-bot: Remove a workaround for position: fixed button bars [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/141494 (owner: 10JGonera) [23:45:52] tfinc: Deskana: dbrant: YuviPanda|zzz: beta is also published [23:46:45] bearND: woohoo [23:47:12] w00t1 [23:47:17] (03PS2) 10Dr0ptp4kt: Proactively handle network connection error. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/141600 [23:48:18] dbrant: had to get rid of the old "What's new text" because it was getting too long. I guess that's not a bad problem to have. [23:48:33] bearND: not at all! [23:49:02] (03CR) 10Kaldari: [C: 04-1] "This will cause a messy merge conflict with https://gerrit.wikimedia.org/r/#/c/140620/. It would probably be a lot easier to re-un-nest af" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/141570 (owner: 10JGonera) [23:49:29] 3MobileFrontend / 3General/Unknown: Image caption text color is too light - 10https://bugzilla.wikimedia.org/67005#c8 (10Jared Zimmerman (WMF)) We're targeting a rerelease of the image styling consistency patch (linked above by ryan) for July 10th, it would be great to get these both using LESS Grey 5 at the... [23:53:46] 3Wikipedia App / 3Android App: "Refresh saved pages" button enabled when there aren't any saved pages. - 10https://bugzilla.wikimedia.org/67011 (10Dmitry Brant) 3NEW p:3Unprio s:3normal a:3None The "refresh" button should be disabled if there are no saved pages. And currently, if I hit the Refresh b... [23:54:02] (03PS5) 10Dbrant: [WIP - test only] Implement syntax highlighting in Edit window. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/137684 [23:54:29] 3MobileFrontend / 3General/Unknown: Image caption text color is too light - 10https://bugzilla.wikimedia.org/67005#c9 (10Ryan Kaldari) @jared: I'm pretty sure it includes all the new color values, except for a few of the grey mappings like "shadow", "neutral", etc. Should I add those as well? [23:56:14] 3MobileFrontend / 3General/Unknown: Image caption text color is too light - 10https://bugzilla.wikimedia.org/67005#c10 (10Jared Zimmerman (WMF)) @Ryan, I think we should include all of the values in the trello card. If we have access to all of them we're much less (ha!) likely to need to be calling custom c...