[00:01:03] Deskana: moizsyed: i've uploaded today's alpha apk to https://releases.wikimedia.org/mobile/android/wikipedia/alphas/ if you can't wait for the store to push it to your devices. Don't have permissions for the betas directory. Will ask YuviPanda|zzz for that [00:02:35] bearND: Thanks! [00:19:35] okay, ere's the full list: http://noc.wikimedia.org/~maxsem/words.txt :P [00:43:57] (03PS3) 10Dr0ptp4kt: Proactively handle network connection error. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/141600 [00:44:06] (03CR) 10Kaldari: "Double underscore magic words automatically set page properties in the page_props table. Just use that instead." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/141047 (https://bugzilla.wikimedia.org/66861) (owner: 10Florianschmidtwelzow) [00:44:24] ^^ mhurd [00:44:52] dr0ptp4kt: nice :) [00:44:58] mhurd: thank you for the advice [00:45:21] dr0ptp4kt: yw! [00:52:05] (03PS4) 10Kaldari: Don't show toc if __NOTOC__ set [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/141047 (https://bugzilla.wikimedia.org/66861) (owner: 10Florianschmidtwelzow) [00:53:23] (03PS5) 10Kaldari: Don't show toc if __NOTOC__ set [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/141047 (https://bugzilla.wikimedia.org/66861) (owner: 10Florianschmidtwelzow) [02:59:58] 3MobileFrontend / 3General/Unknown: Image caption text color is too light - 10https://bugzilla.wikimedia.org/67005#c11 (10Quiddity) (In reply to Ryan Kaldari from comment #6) > See https://gerrit.wikimedia.org/r/#/c/117105 which is related. Please do Not use #555 for the caption text. On Mobile or Desktop.... [03:14:43] (03PS1) 10Ori.livneh: Only define NS_ZERO & NS_ZERO_TALK if undefined [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/141625 [03:17:20] (03PS1) 10Ori.livneh: Only define NS_ZERO & NS_ZERO_TALK if undefined [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/141626 [03:43:01] hey bearND. thanks for making the release [03:43:08] I'll do the chmoding now [03:56:30] (03CR) 10Yuvipanda: "This seems a bit wrong / weird since it works without this on Android, and works fine on iOS safari (MobileFrontend). Perhaps some *other*" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/141567 (owner: 10Brion VIBBER) [03:56:56] * YuviPanda|woozy waves at Deskana [03:57:05] Hey YuviPanda|woozy. :) [03:58:43] * YuviPanda|woozy just woke up [03:59:00] Deskana: thanks for setting the time/date, although it's a bit weird timing for me (usual dinner time) [03:59:03] but that's k :) [03:59:37] YuviPanda|woozy: Yeah, sorry. At that moment, picking a time was way more important than picking the *best* time. [03:59:46] Deskana: yeah, I'm ok with that. [04:06:46] YuviPanda|woozy: Messing around trying to figure out how everything slots together in the app. [04:06:55] Deskana: :) [04:07:12] Deskana: some things are a bit inconsistent, but for the last month or so we've been adding docs to everthing we touch [04:09:47] Hmm, I think I'm getting close to figuring this out. [04:10:00] Managed to duplicate the CC license text in the edit workflow. [04:10:52] Deskana: nice! [04:11:06] Albeit in a form where it's spitting out HTML. [04:11:33] yeah, we've a hack in code for that that makes the HTML show up as proper links [04:11:40] a translatewiki missing-feature workaround [04:15:06] Ahh, and that's how you make it invisible. [04:47:22] hi YuviPanda|woozy: my pleasure. On Wednesday I'll give you dibs to do the release. You certainly deserve it. [04:47:32] bearND: woo :D [04:57:09] (03PS1) 10BearND: Adjust Random item in NavDrawer for GB [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/141640 [04:58:51] bearND: what happens if you don't set the contentDescription to null? [04:59:31] YuviPanda|woozy: you get a Lint warning saying that contentDescription is missing. You can also see those in IntelliJ [05:00:08] YuviPanda|woozy: see also the 2nd answer on http://stackoverflow.com/questions/8500544/android-lint-contentdescription-warning [05:00:16] bearND: aaah [05:00:17] ok [05:16:45] Eurgh [05:16:47] My limbs feel weak and I feel cold despite being warm [05:16:49] Looks like my attempt to hide at home may have spared others, but not spared myself [05:16:58] Deskana: get well [06:20:29] 3MobileFrontend / 3stable: "Read in another language" gives desktop site's links - 10https://bugzilla.wikimedia.org/65047#c9 (10Florian) 5REOP>3UNCO > 2. Tech restriction: Some language versions of wikipedia don't have mobile view and .m. links would lead to HTTP 404 or similar (I don't think it's the ca... [06:20:44] 3MobileFrontend / 3stable: iPad tablet to mobile redirect not working (cookie or cache-related?) - 10https://bugzilla.wikimedia.org/66888 (10Florian) [06:21:35] (03PS1) 10BearND: Make background lighter in site selection list item [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/141645 [06:32:59] 3MobileFrontend / 3General/Unknown: Many Difficulties in Mobile Display of Hebrew WIkisource - 10https://bugzilla.wikimedia.org/66958#c4 (10Florian) > # no need for a button for adding a picture (never used). more useful i > think to have a link to the Talk page of the respective page. The page actions for... [06:33:59] 3Wikipedia App / 3Android App: some translations use illegal parameter syntax - 10https://bugzilla.wikimedia.org/66241 (10Bernd Sitzmann) 5PATC>3RESO/FIX [06:35:46] 3Wikipedia App / 3Android App: NullPointerException at org.wikipedia.beta.createaccount.CreateAccountActivity - 10https://bugzilla.wikimedia.org/67019 (10Bernd Sitzmann) 3NEW p:3Unprio s:3major a:3None App crash while creating an account https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZo... [06:39:42] (03PS1) 10BearND: Guard against NPE before showing progressDialog in CreateAccountActivity [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/141648 (https://bugzilla.wikimedia.org/67019) [06:43:58] 3MobileFrontend / 3stable: "Read in another language" gives desktop site's links - 10https://bugzilla.wikimedia.org/65047#c10 (10fireattack) (In reply to Florian from comment #9) > > 2. Tech restriction: Some language versions of wikipedia don't have mobile view and .m. links would lead to HTTP 404 or simila... [07:31:15] (03CR) 10Florianschmidtwelzow: Add Article Title to PageTitle (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/139790 (https://bugzilla.wikimedia.org/66591) (owner: 10Florianschmidtwelzow) [07:34:29] (03PS6) 10Florianschmidtwelzow: Add Article Title to PageTitle [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/139790 (https://bugzilla.wikimedia.org/66591) [12:08:48] (03CR) 10Brion VIBBER: "Ok, so this has us fall back from *.m.wikipedia.org to *.wikipedia.org for the API hits in case we got an SSL-related failure on *.m.wikip" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/141600 (owner: 10Dr0ptp4kt) [14:10:29] 3MobileFrontend / 3General/Unknown: Many Difficulties in Mobile Display of Hebrew WIkisource - 10https://bugzilla.wikimedia.org/66958#c5 (10Daniel) I'm sorry. I reallly don't have the computer know-how to really understand your comments :-(. I just know that viewing wikisource on my iphone is an uncomfortabl... [14:44:44] 3MobileFrontend / 3General/Unknown: Many Difficulties in Mobile Display of Hebrew WIkisource - 10https://bugzilla.wikimedia.org/66958#c6 (10Florian) If you mean my comment: The first thing (disable upload button) is a setting in the wikis configuration, so it's possible already -> no bug for Mobile Frontned,... [14:47:24] (03PS1) 10Yuvipanda: Don't set progressdialog to null in onStop [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/141695 (https://bugzilla.wikimedia.org/67019) [14:48:31] (03PS2) 10Yuvipanda: Don't set progressdialog to null in onStop [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/141695 (https://bugzilla.wikimedia.org/67019) [14:51:00] (03PS1) 10Dbrant: Disable "refresh saved pages" button if there are no saved pages. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/141696 (https://bugzilla.wikimedia.org/67011) [14:52:36] YuviPanda|zzz: why not? [14:52:46] dbrant: why? [14:52:53] dbrant: it was also being done in onStop [14:53:01] dbrant: onCreate doesn't run after every onStop, no? [14:53:16] 3Wikipedia App / 3Android App: Saved pages are not ordered in a useful way - 10https://bugzilla.wikimedia.org/67028 (10Sage Ross) 3NEW p:3Unprio s:3minor a:3None Saved pages get ordered by date, just like the History list, with date dividers for pages saved on different days. That's not the worst thi... [14:53:18] dbrant: also this means after onStop a new account can't be created at all [14:54:06] YuviPanda|zzz: so it should be onDestroy, then? [14:54:16] dbrant: yeah, but why have it at all? was that leaking? [14:54:37] why would that leak? [14:55:01] YuviPanda|zzz: it's to prevent crashes when an AsyncTask finished after the activity is gone, and the progressDialog is no longer attached to a window. [14:55:24] dbrant: ah, right. but in that case can't we check if the activity exists? [14:56:40] I'm going through the crashes listed in https://etherpad.wikimedia.org/p/mobile-app-otrs [14:56:43] mostly things missing onCaught [14:58:45] YuviPanda|zzz: not easily. The prevailing suggestion is to dismiss the dialog when the activity exits, and then check from within the AsyncTask whether it's still showing. [14:59:16] YuviPanda|zzz: I do agree that it should be changed to onDestroy... [15:01:11] YuviPanda|zzz: I can make that change, since I initially made it this way. [15:06:12] dbrant: yeah, cool. I found that bearND also has a change for the same thing, so feel free to amend either or start a new one :) [15:06:18] dbrant: also remember to guard the onBeforeExecute [15:07:54] YuviPanda|zzz: hmm, I'd thought that onBeforeExecute happens on the same thread, when execute() is called... [15:08:16] dbrant: so does onFinish :D [15:08:26] dbrant: but there was a crash reported about progressDialog being null [15:08:36] activity finishing doesn't mean the original thread dies, I guess? [15:08:59] or someone figured out some way of killing the activity between when they tap create and onbeforeexecute is done... [15:09:13] YuviPanda|zzz: alright; I'll roll these into a new patch. [15:09:19] dbrant: cool [15:09:40] dbrant: do you want to go over the exceptions reported and summarized in https://etherpad.wikimedia.org/p/mobile-app-otrs or shall I? [15:09:49] I also have to do some EL stuff [15:10:53] YuviPanda|zzz: sure, I'm happy to investigate some more of those [15:13:00] dbrant: actually, I'm unsure if setting to null on onDestroy would actually help. is the progressdialog still attached after thea ctivity goes to background? [15:14:29] YuviPanda|zzz: indeed... I think the proper thing would be to dismiss it in onStop (which is when the window disappears), but not set it to null, and then from the AsyncTask check whether it's showing(). [15:14:38] dbrant: yup [15:29:30] * YuviPanda waves at dbrant and bearND [15:30:02] dbrant: bearND think we should focus today on fixing the crashes from https://etherpad.wikimedia.org/p/mobile-app-otrs rather than anything in Sprint 34 [15:30:03] bearND: regarding your patch for the ProgressBar in CreateActivity... [15:30:39] dbrant: bearND and thanks for doing the release! :) [15:31:29] bearND: it's a symptom of a larger issue with the way I implemented dismissing the dialogs in all the other activities. So I'm making a fuller patch to fix that. [15:31:47] YuviPanda: yes, fixing the crashes it is [15:31:52] \o/ [15:32:25] dbrant: thanks [15:33:52] bearND: I did an import into twn again, so our update saved pages stuff can be translated [15:34:07] bearND: also we shouldn't edit non -en things (we can remove them). That messes with translatewiki import [15:34:28] YuviPanda: commenting out ok? [15:34:33] dbrant: bearND if you're working on any of the crash reports on the etherpad, can you put your name on them? [15:34:43] bearND: that should be ok, but removing seems cleaner [15:34:52] YuviPanda: ok [15:35:40] YuviPanda: yep [15:35:59] 3MobileFrontend / 3Feature requests: Mobile login not compatible with OpenID - 10https://bugzilla.wikimedia.org/52059#c3 (10Florian) The header elements are given in data array as 'header', so the easiest way is, to create a new div, ahead of username and password and add the content of header. I think, for... [15:36:01] YuviPanda: have you added the fuzzy designation on the translated strings that caused issues? [15:36:29] 3MobileFrontend / 3Feature requests: Mobile login not compatible with OpenID - 10https://bugzilla.wikimedia.org/52059#c4 (10Florian) Created attachment 15712 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15712&action=edit Example with google and facebookloginbutton [15:36:41] bearND: no, let me do that. [15:37:15] YuviPanda: whenever we import from twn we should run the TranslationTests [15:37:26] bearND: before merging. agreed [15:37:42] bearND: although I'm wondering if we should make that a python script that also checks for other things (like missing qqq) [15:39:07] dbrant: bearND also, can we cc Krenair to the bugs / patches we fix from that etherpad page? He'll help us respond to the tickets [15:39:32] sure [15:40:49] Also https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom;TicketID=7590761 probably requires some action from a developer, if anything [15:41:09] * YuviPanda checks [15:41:34] Krenair: those are usually spam, I'd think. [15:42:02] Krenair: and is ok to mark them as such [15:42:07] okay [16:20:59] YuviPanda, bearND, dbrant: Do we have the APK for the release? [16:21:12] Deskana: hmm? no? I thought it was tomorrow. [16:21:27] Deskana: no new features since yesterday's beta [16:21:31] Deskana: we're doing crash fixes from OTRS [16:21:34] YuviPanda: It is, but Katherine wants to show journalists what the app will look like. [16:21:42] Deskana: i've uploaded the alpha apk to the web site [16:21:43] Deskana: use the beta. it's exactly the same. [16:21:45] YuviPanda: Okay, so I can safely direct her to the beta and say "This is what it looks like". [16:21:48] Deskana: yes. [16:21:50] Just checking! [16:21:51] Thanks. :) [16:22:03] Deskana: the icon will be different (no blue star) but nothing other than that [16:22:09] That's fine. :P [16:22:15] Deskana: :) [16:22:30] I figured the beta would be the same... but we're dealing with journalists, so I didn't think it hurt to double-check. [16:22:35] Deskana: yeah, true! [16:25:07] Sorry for all the back and forth recently. [16:25:20] Deskana: pfft. also known as 'communicating with the team' :) [16:25:34] Just think, back and forth from me is saving you from having to do the comms work yourselves. :P [16:25:42] Deskana: indeed. [16:25:49] Deskana: do sign off when you can so we get the points for the last sprint tho :P [16:26:22] Yeah, that's the first thing on my list once I'm done putting out fires. [16:26:39] * YuviPanda gives Deskana a fire extinguisher [16:27:05] brion: I'm making changes to the edit schema to account for the new workflow and also to account for analytics wanting us to use userid rather than username [16:31:24] (03PS1) 10Dbrant: Properly (for real this time) handle ProgressDialogs. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/141717 (https://bugzilla.wikimedia.org/67019) [16:31:58] YuviPanda: great, can you add an iOS card for updating that to the todo column? thx [16:36:43] brion: yeah, sure. [16:38:31] 3Wikipedia App / 3Android App: NullPointerException in PageActivity.handleIntent - 10https://bugzilla.wikimedia.org/67034 (10Bernd Sitzmann) 3NEW p:3Unprio s:3major a:3None https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom&TicketID=7622139 java.lang.NullPointerException at org.wikipe... [16:38:45] YuviPanda: me again, you don't push daily beta to releases.wm.o due to dbrant rights issue ? [16:39:03] matanya: yeah. alpha went out, let me chmod appropriately [16:39:06] in about 5min [16:58:30] brion: heya! [17:00:07] http://noc.wikimedia.org/~maxsem/words.txt [17:00:18] http://noc.wikimedia.org/~maxsem/words.txt [17:00:23] http://noc.wikimedia.org/~maxsem/words.txt [17:00:56] MaxSem: so much words [17:01:07] ASL's? [17:02:43] hey mhurd [17:02:50] should be in the office 11ish [17:03:24] 14/f/cali [17:03:27] spent the morning fiddling with software updates on various devices :D [17:03:29] lol [17:03:50] Deskana: hehe :P [17:04:16] Off to the office! [17:08:33] bearND: permission issue on releases fixed [17:09:52] brion: wanted to get your thought on this card: https://trello.com/c/LM8CghAt/88-design I was thinking about doing it native instead of w/html… [17:10:52] YuviPanda: great. ty. Just uploaded the beta apk (fyi, matanya) [17:11:01] bearND: sweet :) [17:16:50] mhurd: go for it! [17:19:18] brion: do you get an occasionaly “NSBundle NSBundle…en.lproj> (not yet loaded) was released too many times” warning when running app in the simulator sometimes? i can’t seem to suss out what’s causing it… [17:19:59] brion: i just got it 3 times at once… weird! [17:20:48] mhurd: yeah, might be a buglet in the localization fallback check [17:20:57] i’ll take a peek for it [17:20:59] brion: buglet :) [17:21:01] it seems harmless for now ;D [17:21:02] (03PS1) 10Yuvipanda: [WIP] Update logging to reflect new Edit Workflow [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/141727 [17:21:04] i like that [17:22:00] brb food [17:23:53] I get really excited everytime I see an email thread about a "Bugday", but then I realize they're talking about computer bugs. [17:24:00] kaldari: this patch is merged (?) but i don't see it on beta labs: https://gerrit.wikimedia.org/r/#/c/140620/ [17:24:05] gerrit, how does it work [17:24:14] “Bugs, Mr. Rico! Millions of them!” [17:24:38] Maryana: Not merged [17:24:46] i thought +2 meant merged? [17:24:49] meh [17:26:20] Maryana: It actually has to get two +2s. One for code-review (which comes from humans), and one for code-verification (which comes from robots) [17:26:37] oh right [17:27:06] i just wanna make sure we get that onto the train this week so we can do some user testing with the new changes :) [17:27:30] jgonera, awjr: ^ [17:27:51] is there any way to *not* put that patch on testwiki, actually? [17:28:01] would be cool to test with and without text.. [17:28:22] Maryana: No, there's no config switch for it, it's all or nothing [17:28:29] hmm, k [17:28:36] kaldari is that urgent to merge? [17:29:02] not super urgent, but would be great to get merged today/tomorrow [17:29:13] before code cutoff [17:29:15] Maryana in time for the train? [17:29:16] aye [17:29:53] we were gonna do some user testing on thursday, and this is an important thing to validate w/users [17:30:37] (03CR) 10Florianschmidtwelzow: [C: 031] Add text to next & save buttons in mobile editors [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/140620 (owner: 10Kaldari) [17:34:01] (03PS11) 10Kaldari: Add text to next & save buttons in mobile editors [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/140620 [17:40:23] (03CR) 10Florianschmidtwelzow: [C: 04-1] "If the message translated is big (maybe in german next -> Fortfahren) and the title is big, too, actually the title is shorted by "...". A" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/140620 (owner: 10Kaldari) [17:40:31] 3Wikipedia App / 3Android App: EditPreviewFragment doesn't handle errors - 10https://bugzilla.wikimedia.org/67038 (10Dmitry Brant) 3NEW p:3Unprio s:3normal a:3None We instantiate an EditPreviewTask without having an onCatch function. https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom;... [17:44:04] Kaldari, I'll have a second look today and merge if everything's fine [17:45:14] (03CR) 10Dr0ptp4kt: "Yep." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/141600 (owner: 10Dr0ptp4kt) [17:48:29] YuviPanda: bearND should i start reporting bugs ? [17:48:54] matanya: always :) [17:49:13] seems like some templates are not shown in the new version [17:49:16] 3Wikipedia App / 3Android App: PageImageSaveTask needs error handling. - 10https://bugzilla.wikimedia.org/67039 (10Dmitry Brant) 3NEW p:3Unprio s:3normal a:3None There is at least one instance of PageImageSaveTask that doesn't have an onCatch function. https://ticket.wikimedia.org/otrs/index.pl?Acti... [17:49:18] still not sure which [17:49:57] (03Abandoned) 10BearND: Guard against NPE before showing progressDialog in CreateAccountActivity [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/141648 (https://bugzilla.wikimedia.org/67019) (owner: 10BearND) [17:51:29] YuviPanda: seems like templates under the external links part are not shown [17:52:39] whee https://gerrit.wikimedia.org/r/141731 [17:53:10] nice [17:54:24] hey awjr, how are you? [17:54:32] hi MaxSem [17:54:39] still feeling sick, but better than yesterday [17:55:29] awjr, I would appreciate if you reviewed https://gerrit.wikimedia.org/r/141576 because that's your area of expertise [17:55:47] hahaha [17:55:53] i can take a look in a bit MaxSem [17:55:58] thanks:) [17:56:12] although im afraid to even breathe on the redierct cookie stuff [17:56:20] (03Abandoned) 10Dbrant: Don't set progressdialog to null in onStop [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/141695 (https://bugzilla.wikimedia.org/67019) (owner: 10Yuvipanda) [17:59:27] YuviPanda: I think i can show you how to reproduce. poke me when ever [18:00:05] YuviPanda, bearND, dbrant: I've written an updated description for the app: https://www.mediawiki.org/wiki/User:DGarry_(WMF)/Apps/Android/Store_Description [18:00:26] YuviPanda, bearND, dbrant: Note that the formatting is kind of broken in mediawiki but it should make sense if pasted from the edit window into Google Play. [18:00:42] YuviPanda, bearND, dbrant: Whichever one of you pushes the APK tomorrow, please also update the description at the same time. :) [18:01:33] YuviPanda: I take it back, it also doesn't show on mobile web [18:01:45] should report a bug to them, i guess [18:01:48] Deskana: sweet! [18:01:56] who is the relevant party ? [18:04:31] matanya: hey [18:04:36] matanya: mobilefrontend product [18:04:39] matanya: I think it is intentional tho [18:04:49] means ? [18:05:16] matanya: navboxes are intentionally hidden since they are styled badly on mobile [18:05:21] Deskana: sweet, will do [18:05:31] ok, thanks! [18:05:40] matanya: do file a bug tho [18:06:13] for an intentional thing? that would be a won't fix [18:06:18] (03CR) 10Kaldari: "This also seems to break the truncated text magic :(" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/140620 (owner: 10Kaldari) [18:06:34] matanya: yeah [18:07:42] (03PS1) 10Dbrant: Add (no-op) error handler for fetching page images. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/141738 (https://bugzilla.wikimedia.org/67039) [18:11:11] MaxSem i see https://trello.com/c/XTM2RRap/122-bug-33978-featuredfeeds-extension-set-feed-limit-for-monthly-featured-articles-on-la-wikipedia in the Q4 backlog - did you meant to put that in the bug backlog? [18:11:11] (03PS1) 10Dr0ptp4kt: Log bespoke User-Agent from Android and iOS apps along with MCC-MNC. [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/141740 [18:11:42] awjr, meh - I don't know what to do with it [18:11:57] feeds that update once in month kinda make no sense [18:12:06] wontfix? :D [18:12:12] yurik ^^^ just added you to that patch for your approval and merge tonight and for the deployment of changes tomorrow [18:12:20] (03CR) 10Kaldari: "According to MaxSem, there's an even more efficient way to do this by looking at the parser output (rather than re-parsing or doing a DB q" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/141047 (https://bugzilla.wikimedia.org/66861) (owner: 10Florianschmidtwelzow) [18:16:48] (03CR) 10Yurik: [C: 032] Log bespoke User-Agent from Android and iOS apps along with MCC-MNC. [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/141740 (owner: 10Dr0ptp4kt) [18:16:59] MaxSem i think either 'wontfix', or we should stick it in the bug backlog (rather than the q4 backlog) [18:17:00] (03Merged) 10jenkins-bot: Log bespoke User-Agent from Android and iOS apps along with MCC-MNC. [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/141740 (owner: 10Dr0ptp4kt) [18:17:23] aha [18:17:37] (03CR) 10Yurik: [C: 04-2] "this was by design - ZRMA & ZeroBanner should not be used at the same time." [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/141626 (owner: 10Ori.livneh) [18:17:48] done [18:18:02] ty MaxSem [18:18:44] (03CR) 10Yurik: [C: 04-2] "this was by design - ZRMA & ZeroBanner should not be used at the same time." [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/141625 (owner: 10Ori.livneh) [18:20:27] yurikR, both extensions still need to be included for l18n cache rebuilds [18:21:50] MaxSem, ZRMA has bee off on all wikies, we can safely kill it entirely [18:22:14] JFDI, then ;) [18:22:58] MaxSem, the patches are already in ;) [18:23:20] Deskana: we should also update some links on the Play Store: https://www.google.com/url?q=https://meta.wikimedia.org/wiki/Mobile_Projects&sa=D&usg=AFQjCNEVJgbWhYXEdHpsSViiXYW0Fm7UUg, mailto:mobile-feedback-l@lists.wikimedia.org. [18:23:45] Deskana: i mean Developer's Website + email [18:27:46] (03CR) 10Florianschmidtwelzow: "That was one of my first ideas:" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/141047 (https://bugzilla.wikimedia.org/66861) (owner: 10Florianschmidtwelzow) [18:37:05] bearND|bbl: Let me take a look. [18:47:41] MaxSem: btw.. on hiding content [18:47:47] HOLY FUCK [18:47:48] yep? [18:48:03] mobile currently hides all .metadata, but .metadata should only hidden in content namespaces. [18:48:24] Deskana: hmm? [18:48:46] what is it ued for outside of them? [18:48:49] I updated some of the details in the store and it said "Your application has been published" [18:49:02] Deskana: ah. you can't do that... [18:49:13] NO DON'T PUBLISH EARLY [18:49:15] But I don't think it has [18:49:22] YuviPanda: Can you check I've not accidentally published it early or something? [18:49:28] Deskana: yea, looking [18:49:46] Deskana: no apk change [18:49:52] Deskana: what did you change? [18:49:59] The developer website and email address. [18:50:01] OMGOMGOMGQUICKLYANNOUNCEITOMGALLISLOSTPREMATURELY [18:50:01] Deskana: ah. [18:50:03] Deskana: that's fine [18:50:09] Deskana: that was just changed, yeah [18:50:26] Deskana: so 'tis ok. all good. stupid message [18:50:28] I mean, it *shouldn't* release the APK. But then it shouldn't say "YOUR APPLICATION HAS BEEN PUBLISHED NOW PANIC MERE MORTALS" [18:50:31] MaxSem: Used to mark elements in content that are considered not to be part of the proper content of the article. These are annotations, maintenance templates, navigation links, media controls etc. These elements are often filtered out of 'alternative' views of the content, like CD-ROM editions, bookprint, webpage print, mobile views etc. [18:50:47] Deskana: heh [18:50:56] makes sense [18:51:07] MaxSem: originally it was to hide maintenance templates from the cd rom version :) [18:51:08] Deskana: theoretically you can release the app by just a few clicks in the store - specifically, 'promote alpha to production' :) [18:51:23] YuviPanda: Yeah but I'm not stupid enough to do that... we hope. [18:51:24] ;) [18:51:35] Deskana: :D we'll just have to buy you enough buckfast [18:51:42] it used to be a lot more confusing [18:51:45] well, I added it to hide title coordinates:P [18:52:00] MaxSem: use #coordinates for that. [18:52:19] not very cross-wiki, actually [18:52:30] i know, but that's a seperate issue [18:52:30] .metadata seemed more widespread [18:52:50] yeah everyone copies en.wp and then starts changing stuff :) [18:53:24] anyway, I see no problem here [18:53:45] do you have an example? [18:54:39] it came up on VP/T today, because AFD discussion closing templates seem to use it (subst'ed even) for some weird reason, and that now creates empty AfD discussion pages when using mobile :) [18:55:12] bleh [18:55:37] just removing .metadata would be even funnier:( [18:56:18] yeah, that's what it was before. but then again, before we only really had content of course :) [19:00:59] hmmm. [19:02:39] https://en.m.wikipedia.org/wiki/Stadskanaal for some reason, the toc is positioned under the infobox here when viewed on widescreen.... For desktop it's just left of the infobox.. [19:04:31] blegh, i hate floating.. it has such weird behavior [19:08:22] Deskana: do yo have edit rights on the meeting invite with Lila ? [19:08:34] tfinc: Don't think so. [19:08:44] tfinc: No, but Lisa is sat right behind you. :) [19:08:58] tfinc: It seems I can add guests though. [19:09:07] tfinc: I take it you want me to add Yuvi, Bernd, Vibha? [19:09:09] (03PS1) 10TheDJ: ToC: float left should also clear other left floats [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/141754 [19:09:28] yup [19:09:46] Doing. [19:10:01] Done. [19:10:11] tfinc: do you guys need me and mhurd too, or should we keep plugging away at stories? [19:10:23] (03PS2) 10Yuvipanda: Update logging to reflect new Edit Workflow [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/141727 [19:10:40] we have a full cast already so i think were fine. up to Deskana really [19:11:01] i know lila wants to talk about editing and specifically section level inline editing [19:11:12] ah right, toc's need display:table [19:11:39] spiff [19:12:29] dbrant: bearND ^ is updated, let me do the username -> userid patch for analytics now [19:14:53] brion, mhurd: I don't imagine we'll be making any decisions in the meeting, so I'd prefer to have you plugging away at stories. But I'm not your boss, if you want to come then it's not my place to stop you. :) [19:15:18] (03CR) 10Awjrichards: [C: 04-1] "Jenkins says unit tests are failing." (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/141576 (owner: 10MaxSem) [19:15:30] Deskana: nah sounds like working on stuff is best use of time today, let us know what fun stuff you’re thinking of from the meeting though :D [19:15:43] brion: Sure, I'll send around a summary if anything useful is said. [19:15:44] tfinc: lila’s coming to the app styling spike? [19:15:54] mhurd: yea [19:15:58] wat [19:16:02] :P [19:16:08] confused [19:16:12] mhurd: No, this is a separate meeting after that. [19:16:17] Deskana: ah [19:16:20] mhurd: tfinc sent out an email yesterday [19:16:25] mhurd: Lila is meeting with Dan and me and anyone else who wants to join @ 1:30. read the email i sent [19:16:32] YuviPanda: That was about a separate thing I just invited you to. [19:16:35] Deskana: yup [19:16:42] tfinc: k [19:16:44] She can come to the styling spike if she wants. :P [19:16:53] She's the boss! [19:16:59] Deskana: I was kidding :) [19:17:08] :) [19:17:09] YuviPanda: I know. [19:17:11] ...now. [19:17:14] Deskana: :P [19:17:22] :D [19:17:30] Deskana: the fact that you know now doesn't mean you didn't know already. You might have [19:17:46] I return to [19:17:46] wat [19:17:51] Deskana: heh :) [19:17:56] how do we know what we know? is knowledge an illusion? [19:18:04] YuviPanda: know no know no [19:18:13] Deskana: you used to be a product manager. you still are, but you used to be too. [19:18:49] If you immediately know the candlelight is fire, then the meal was cooked a long time ago. [19:18:53] brb food [19:19:02] Deskana: deep [19:19:15] YuviPanda: Stargate SG-1. ;) [19:19:20] Deskana: aaah. [19:21:58] Deskana: how is sign of going for https://trello.com/b/KNqImlQo/mobile-app-sprint-33-the-final-android-countdown ? do you have both builds? i'd like to close this board today [19:22:39] tfinc: So many fires, so little time! I'll try to do that 2:30-3:00pm, the only time I've got that's not meetings. [19:22:45] k [19:29:39] (03CR) 10Dbrant: [C: 032] Adjust Random item in NavDrawer for GB [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/141640 (owner: 10BearND) [19:31:19] Styling spike moved to Elder. [19:40:23] (03PS1) 10Brion VIBBER: Work in progress: adding edit protection fields [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/141763 [19:44:42] YuviPanda: https://en.wikipedia.org/wiki/List_of_terrorist_incidents,_2014 [19:48:20] hey at least it doesn’t say “You can improve this article by expanding it” [19:48:45] lol [19:50:26] Deskana: https://en.m.wikipedia.org/wiki/Special:History/Enid_Blyton [19:53:59] (03PS1) 10BearND: Guard against NPE in PageActivity.handleIntent [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/141775 (https://bugzilla.wikimedia.org/67034) [19:57:17] anyplace I can look for more detailed error output for MobileFrontend on image uploading? Just getting "Error, try again." in the mobile browser after it finishes with the ajax progress bar. Nothing in Apache log... [19:57:59] YuviPanda: this style change look ok? https://gerrit.wikimedia.org/r/#/c/141762/ <- moving some of the edit button styles from the android-specific to the main file so we can use them on ios [20:00:04] reeeve: anything in the client-side JS console? [20:00:23] you should be able to see the exact ajax responses etc [20:00:36] YuviPanda: https://trello.com/c/YYRdKkQn/18-search-wikipedia-is-not-translated-on-2-0-beta-2014-06-12-in-android-2-3-1 [20:01:47] brion: let me check via desktop, was doing it from phone [20:02:18] (note that recent versions of ios and android support remote debugging with safari and chrome respectively) [20:02:27] (but that may not help depending on what equipment you’ve got :D) [20:02:27] (03CR) 10BearND: "While I agree with the change it doesn't seem to be fitting the stack trace linked in the OTRS report:" (031 comment) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/141738 (https://bugzilla.wikimedia.org/67039) (owner: 10Dbrant) [20:04:43] (03PS2) 10BearND: Disable "refresh saved pages" button if there are no saved pages. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/141696 (https://bugzilla.wikimedia.org/67011) (owner: 10Dbrant) [20:05:10] (03CR) 10BearND: [C: 032] Disable "refresh saved pages" button if there are no saved pages. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/141696 (https://bugzilla.wikimedia.org/67011) (owner: 10Dbrant) [20:05:35] (03Merged) 10jenkins-bot: Disable "refresh saved pages" button if there are no saved pages. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/141696 (https://bugzilla.wikimedia.org/67011) (owner: 10Dbrant) [20:06:35] bearND: PageImageSaveTask extends PageImagesTask, which extends PageQueryTask. [20:08:18] dbrant: good point [20:08:32] bearND: that looks like the only path of failure [20:08:39] brion: will check that out! upload came back success on browser, but then viewing the page got shut down by img_auth, will take a look into it [20:10:28] bearND: and our pattern has been to put the onCatch function in the "final" instantiation of the tasks... that's why i put it there, and not in the actual PageImageSaveTask class. [20:11:36] dbrant: ok, that sounds fine then [20:11:49] (03PS2) 10BearND: Add (no-op) error handler for fetching page images. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/141738 (https://bugzilla.wikimedia.org/67039) (owner: 10Dbrant) [20:12:29] (03CR) 10BearND: [C: 032] Add (no-op) error handler for fetching page images. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/141738 (https://bugzilla.wikimedia.org/67039) (owner: 10Dbrant) [20:12:50] (03Merged) 10jenkins-bot: Add (no-op) error handler for fetching page images. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/141738 (https://bugzilla.wikimedia.org/67039) (owner: 10Dbrant) [20:14:57] some weird IE file extension cache check-- "Invalid file extension found in the path info or query string." [20:15:15] (03PS1) 10Dbrant: Fix possible crash(es) when pressing ToC button. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/141814 [20:15:58] (03CR) 10MaxSem: Simplify redirect cookie system (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/141576 (owner: 10MaxSem) [20:16:24] funky [20:17:34] brion: change looks good. I'll merge once I'm out of meetings? [20:17:45] YuviPanda: super thx :D [20:19:27] tfinc: https://translatewiki.net/w/i.php?title=Special:MessageGroupStats&group=out-wikimedia-mobile-wikipedia-android-strings#sortable:3=desc [20:19:35] tfinc: 33% translatd [20:20:57] (03CR) 10MaxSem: "Cookies should be set properly now because they're set from mobileaction=toggle_view_* at which both desktop and mobile view links are awa" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/141576 (owner: 10MaxSem) [20:21:30] (03PS1) 10Dbrant: Implement (simple) error handling when fetching preview. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/141816 (https://bugzilla.wikimedia.org/67038) [20:24:23] (03CR) 10Dbrant: [C: 031] "Fine with merging, but out of curiosity, how is this reproduced?" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/141775 (https://bugzilla.wikimedia.org/67034) (owner: 10BearND) [20:26:35] dbrant: not sure. I tried launching from search results in Google Now or Chrome, that didn't do it. [20:26:59] (03PS1) 10Yuvipanda: Use userID for logging editing events [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/141817 [20:27:01] (03PS1) 10Yuvipanda: Tweak color for ToC button [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/141818 [20:27:03] (03CR) 10jenkins-bot: [V: 04-1] Tweak color for ToC button [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/141818 (owner: 10Yuvipanda) [20:28:22] (03PS2) 10Yuvipanda: Use userID for logging editing events [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/141817 [20:28:24] (03PS3) 10Yuvipanda: Update logging to reflect new Edit Workflow [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/141727 [20:28:26] (03PS2) 10Yuvipanda: Tweak color for ToC button [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/141818 [20:28:55] (03CR) 10Dbrant: [C: 032] Guard against NPE in PageActivity.handleIntent [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/141775 (https://bugzilla.wikimedia.org/67034) (owner: 10BearND) [20:30:23] (03PS1) 10Yuvipanda: Don't grey out the subsections in ToC [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/141822 [20:32:33] commented out the IE6 file extension check that was messing up display of images, image upload works fine from mobile view on desktop browser (&mobileaction=toggle_view_mobile) but same errors in mobile (android, chrome) browser. Will try to look up the js debugging in mobile chrome [20:35:24] dbrant: pm [20:41:26] Deskana: re: multiwiki search is something we'd need wikidata for [20:42:00] Deskana: you should tell lila the previous one she saw was the iOS version? [20:42:05] Deskana: the android one has been this since forever [20:42:46] 3MobileFrontend / 3General/Unknown: API mobileview "protection" sometimes returns object, sometimes returns empty array in JSON output - 10https://bugzilla.wikimedia.org/67054 (10Brion Vibber) 3NEW p:3Unprio s:3normal a:3None A protected page returns an object/map/dictionary/associative array for the... [20:44:38] brion: yeah, ^ is a result of mediawiki being xml centric :) it is the same everywhere. [20:44:40] brion: can we blame you? [20:44:54] YuviPanda: nah that’s yurik I think ;)) [20:44:59] brion: haha [20:45:29] mainly we can blame PHP for having a freakish array/map hybrid type ;) [20:45:29] 3MobileFrontend / 3General/Unknown: API mobileview "protection" sometimes returns object, sometimes returns empty array in JSON output - 10https://bugzilla.wikimedia.org/67054#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/B5Hl0VhY [20:45:31] Deskana: she's seeing a different app! :) [20:45:36] YuviPanda: bearND: dbrant: is it useful to see the camera feed ? [20:45:39] tfinc: very [20:45:45] excellent [20:45:50] tfinc: most definitely [20:46:05] this is exactly why i got the camera for us [20:46:19] how is the refresh rate ? [20:46:27] let us know if we should make any adjustments [20:46:33] tfinc: very smooth for me [20:46:34] placement, angle, etc [20:47:28] 3MobileFrontend / 3General/Unknown: API mobileview "protection" sometimes returns object, sometimes returns empty array in JSON output - 10https://bugzilla.wikimedia.org/67054#c2 (10Brion Vibber) Note I can work around this on the client, it's just a pain. :) [20:48:28] 3MobileFrontend / 3General/Unknown: API mobileview "protection" sometimes returns object, sometimes returns empty array in JSON output - 10https://bugzilla.wikimedia.org/67054#c3 (10Max Semenik) Any suggestions how to do it short of rewriting the API in a saner language? :P [20:48:47] brion, ^^ :P [20:48:59] MaxSem: hmm i remember some similar bugs sitting around bugzilla [20:49:07] yep [20:49:11] maybe it requires fixing api to handle special empty arrays sighhhh [20:49:35] the problem here lies even deepr, in json_encode [20:49:58] which has no idea how to treat empty arrays [20:50:07] MaxSem: https://bugzilla.wikimedia.org/show_bug.cgi?id=10887#c12 suggests casting empty arrays to objects [20:50:12] that might work for json_encode [20:50:18] but i don’t know if it’ll explode the xml formatter :D [20:50:44] YuviPanda, brion, totally my fault :( [20:50:59] should have known about json taking over the world back then :( [20:51:13] hehe [20:51:19] php serialize() ! ;) [20:51:22] brion: it might even be a php issue. there's no differentiation between arrays and hashes [20:51:29] 3MobileFrontend / 3General/Unknown: API mobileview "protection" sometimes returns object, sometimes returns empty array in JSON output - 10https://bugzilla.wikimedia.org/67054#c4 (10Brion Vibber) Adding the general bug 10887 as a dep. [20:51:29] 3MobileFrontend / 3General/Unknown: Image caption text color is too light - 10https://bugzilla.wikimedia.org/67005#c12 (10Jared Zimmerman (WMF)) Created attachment 15719 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15719&action=edit Quickcolor text [20:51:37] YuviPanda: yeah we’d probably have to use a wrapper object or something [20:51:47] or add a hidden type marker in the array [20:51:56] brion: right. [20:51:57] anyway let’s worry about it later [20:51:58] 3MobileFrontend / 3General/Unknown: Image caption text color is too light - 10https://bugzilla.wikimedia.org/67005#c13 (10Jared Zimmerman (WMF)) @Quiddity, I uploaded a quick color test, easier to visualize this way. [20:53:14] YuviPanda, in reality, json de/serialize uses stdclass for the maps now [20:53:42] except that we use a special switch to always use arrays [20:53:54] jgonera: if you could review this patch today, i'd really appreciate it :) https://gerrit.wikimedia.org/r/#/c/140620/ [20:57:52] (03PS2) 10Brion VIBBER: Work in progress: adding edit protection fields [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/141763 [21:09:16] jgonera: anything I can do to help with the VE failiures? https://integration.wikimedia.org/ci/view/BrowserTests/job/browsertests-MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-firefox-sauce/lastCompletedBuild/testReport/ [21:13:25] (03PS2) 10Yuvipanda: Make background lighter in site selection list item [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/141645 (owner: 10BearND) [21:18:00] bearND: dbrant doing CR now [21:18:36] (03CR) 10Yuvipanda: [C: 04-2] Don't grey out the subsections in ToC [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/141822 (owner: 10Yuvipanda) [21:19:56] (03PS1) 10Jdlrobson: Hygiene: Move message tool out of repository [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/141838 [21:20:00] Deskana: so, I actually just realized we won't be able to get most of the things in the page styles meeting done before release. I just did a couple of 'em, and think we should just spend the rest of our time doing CR and fixing other stuff. can wait for next week, I think. [21:20:09] (03CR) 10Awjrichards: "if you can't test this in a multi-domain set up before merging this and getting it on betalabs, i will merge this when the tests pass on t" (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/141576 (owner: 10MaxSem) [21:20:21] YuviPanda: That's fine. [21:20:27] Deskana: cool :) [21:20:36] Deskana: also see my previous messages to you during the meeting :) [21:26:03] (03CR) 10BearND: [C: 031] "Looks good to me but since this is a big change at this time I'd prefer if YuviPanda could take a look at well." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/141717 (https://bugzilla.wikimedia.org/67019) (owner: 10Dbrant) [21:26:29] 3MobileFrontend / 3General/Unknown: Image caption text color is too light - 10https://bugzilla.wikimedia.org/67005#c14 (10Ryan Kaldari) @Quiddity: I changed the text color to #222222 since that is closer to the original Typography Refresh value (#252525). Let me know if that is acceptable. [21:27:09] Erm. [21:27:15] I just made the app crash by rotating my tablet. [21:27:35] But I was in a hurry so I couldn't send the crash report. :( [21:27:44] I think I know how to reproduce, hold on. [21:28:28] 3MobileFrontend / 3General/Unknown: Many Difficulties in Mobile Display of Hebrew WIkisource - 10https://bugzilla.wikimedia.org/66958#c7 (10Daniel) k great. let's just focus on the second issue then. 1. go the page of the template using a regular computer. https://he.wikisource.org/wiki/%D7%AA%D7%91%D7%A0%D... [21:29:09] Deskana: was it in the process of doing something? (with a "progress" dialog showing?) [21:29:31] I'd just changed my tablet's language to German, opened the app, and after it loaded the main page I stood up and it rotated. [21:29:37] Although it is possible that it rotated during the loading. [21:31:25] (03PS2) 10Yuvipanda: Fix possible crash(es) when pressing ToC button. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/141814 (owner: 10Dbrant) [21:31:55] (03CR) 10Yuvipanda: [C: 032] Fix possible crash(es) when pressing ToC button. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/141814 (owner: 10Dbrant) [21:32:15] (03Merged) 10jenkins-bot: Fix possible crash(es) when pressing ToC button. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/141814 (owner: 10Dbrant) [21:32:47] (03PS1) 10MaxSem: Make mobileview always return protection as an object [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/141842 (https://bugzilla.wikimedia.org/67054) [21:33:02] MaxSem: backwards compat. this will break android [21:33:13] o rly? [21:33:24] isit written that backwards? :P [21:33:35] MaxSem: well, the API was backwards, so yes, it is [21:33:42] plus Java differentiates betweens arrays and objects, so... [21:33:52] (03CR) 10Yuvipanda: [C: 04-2] "Breaks backwards compatibility." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/141842 (https://bugzilla.wikimedia.org/67054) (owner: 10MaxSem) [21:34:03] that is, it will explode on empty dictionaries, but not non-empty ones? [21:34:18] YuviPanda, feel fre to wontfix the bug then;) [21:34:25] MaxSem: no, we have specific code written that checks for arrays as 'empty' [21:34:36] bleh [21:34:37] MaxSem: and if it isn't an array, assumes then it is a dictionary with something in it [21:34:52] what's wrong if it's not empty? [21:34:57] MaxSem: because otherwise, we'll try to access the JSONArray as a JSONObject and crash everything. [21:35:14] MaxSem: ah, actually, no [21:35:20] MaxSem: it's fine. we check if it has an 'edit' as ewll [21:35:48] (03PS12) 10Kaldari: Add text to next & save buttons in mobile editors [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/140620 [21:36:00] (03CR) 10Yuvipanda: "Ah, nevermind. I wrote the Android app code better than expected. It will handle empty dicts fine." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/141842 (https://bugzilla.wikimedia.org/67054) (owner: 10MaxSem) [21:36:04] MaxSem: removed -2 [21:36:13] Maryana, kaldari is fixing this patch [21:36:24] YuviPanda, do you realise that some pages can be move-protected?:P [21:36:27] chrismcmahon, I'm going to have a look at those tests again now [21:36:28] jgonera, Maryana: it's fixed now [21:36:34] MaxSem: yea, that's why I have that code in there :) [21:36:34] (03PS3) 10Brion VIBBER: Work in progress: adding edit protection fields [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/141763 [21:36:35] jgonera: yeah, overheard you two talking - thank you! :) [21:36:41] ok, will check it soon [21:37:03] if (!(json.opt("protection") instanceof JSONArray) [21:37:03] && json.optJSONObject("protection").has("edit") [21:37:05] MaxSem: ^ [21:37:20] MaxSem: empty array will fail on first, empty object on second [21:37:22] so 'tis alright [21:45:03] (03PS4) 10Brion VIBBER: Work in progress: adding edit protection fields [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/141763 [21:50:44] 3MobileFrontend / 3General/Unknown: Image caption text color is too light - 10https://bugzilla.wikimedia.org/67005#c15 (10Jared Zimmerman (WMF)) #222222 isn't a LESS value… but it could be one #222 body "Grey 2" and #555 caption "Grey 5" seems to have high contrast and be reasonably differentiated [21:51:43] 3MobileFrontend / 3General/Unknown: Image caption text color is too light - 10https://bugzilla.wikimedia.org/67005#c16 (10Ryan Kaldari) Sorry, I meant to say I changed it to @colorGray2 (which is #222222). [21:52:10] (03Abandoned) 10Ori.livneh: Only define NS_ZERO & NS_ZERO_TALK if undefined [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/141626 (owner: 10Ori.livneh) [21:52:20] (03Abandoned) 10Ori.livneh: Only define NS_ZERO & NS_ZERO_TALK if undefined [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/141625 (owner: 10Ori.livneh) [21:52:36] (03PS5) 10Brion VIBBER: Work in progress: adding edit protection fields [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/141763 [21:53:01] 3Wikipedia App / 3iOS App: iOS App: Don't overwrite app CSS files if the new file is zero bytes - 10https://bugzilla.wikimedia.org/67055 (10Dan Garry) 3NEW p:3Unprio s:3normal a:3None When syncing the app's CSS with the servers every 24 hours, don't overwrite the CSS on the app with a new CSS file if... [21:53:19] mhurd: Filed and CC'd. ^^ [21:53:27] Deskana: yay! [21:53:43] 3Wikipedia App / 3iOS App: iOS App: Don't overwrite app CSS files if the new file is zero bytes - 10https://bugzilla.wikimedia.org/67055#c1 (10Yuvi Panda) It was, and we made a fix 3 weeks ago :) [21:54:42] bearND: hey! I saw you just picked up a card. think we should finish CR first :D [21:55:08] bearND: I've told Deskana we can do the style fixes later. I didn't realize we still had a bit of CR to do [21:55:56] YuviPanda: Could you take a quick look at that bug that I just filed? [21:56:05] bearND: on iOS? I responded already [21:56:17] So you did. [21:56:21] <3 [21:56:28] Deskana: :) [21:56:48] Deskana: I'm on default cc for all bugs in both the apps, and take a look at everything that comes in. [21:56:52] So there are three cards in ready for sign off. [21:56:57] The top two I'm unsure how to sign off on. [21:57:03] YuviPanda, brion: They're your cards. :) [21:57:07] The bottom I don't have a build for yet. [21:57:10] brb... [21:57:13] YuviPanda: ok, i didn't want to clash with your CR ing. [21:57:25] YuviPanda: what about iOS? [21:57:36] mhurd: you getting near ready for an iOS build? [21:57:39] ^ [21:57:50] bearND: hmm? what about iOS? the cards? [21:58:07] Deskana: I replied on trello [21:58:10] Deskana: by end of day. sorry took so long :( [21:58:37] YuviPanda: this one? https://trello.com/c/RgQcaohb/52-last-updated-link-takes-you-to-desktop-instead-of-mobile-view [21:59:06] bearND: that's just android, I guess. should be a trivial fix. still, CR first! :) [21:59:20] bearND: there're three of my patches ;) I'm just looking at dbrant|bbl's patches now [21:59:48] YuviPanda: ok, checking out yours [21:59:51] bearND: ty [22:00:14] 3MobileFrontend / 3General/Unknown: Hash gets swallowed (again) - 10https://bugzilla.wikimedia.org/64918#c8 (10Ryan Kaldari) I wasn't able to reproduce, but I'm also not 100% clear on the reproduction steps. When I search for "wiring color codes" on en.wiki I don't get any results to click on. I tried using... [22:00:18] bearND: there's two instrumentation changes, and one minor styule change [22:02:34] chrismcmahon, all those VE tests work for me locally... is it possible that saucelabs persists cookies and wikitext editor stays as the default? [22:02:52] chrismcmahon, I assumed that we always start with a clean browser [22:02:55] jgonera: I'll check [22:03:37] YuviPanda: did vbamba1 want the toc button lighter or darker? [22:03:57] bearND: 'same shade', and I realized we were setting the opacity to 0.5 rather than 0.6 which is what the overflow button would've had? [22:04:56] bearND: since 60% opacity is what is reccomended [22:07:09] YuviPanda: it appears darker now, though [22:09:21] chrismcmahon, I think the issue might be something different [22:09:57] chrismcmahon, I think beta labs, for some reason, is configured like eswiki rather than enwiki, i.e. VisualEditor is disabled by default (is an opt-in beta feature) [22:10:09] Why is a confirm dialog for refreshing saved pages? Shouldn't it just do it? [22:10:10] let me verify that [22:11:06] ragesoss: only for 'refresh all' [22:11:13] ragesoss: if you select individual ones and refresh it just does it [22:11:14] mhurd, yo [22:11:18] ragesoss: mostly because it's not obviously cancellable [22:11:20] dr0ptp4kt: hey [22:11:25] bearND: hmm, ok. let's leave that patch out for now as well [22:11:46] YuviPanda: others depend on it [22:11:46] (03CR) 10Yuvipanda: [C: 04-2] Tweak color for ToC button [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/141818 (owner: 10Yuvipanda) [22:11:51] bearND: yeah, I'll remove those out [22:11:59] ok [22:12:00] bearND: do look at their code in the meantime though :) [22:12:46] bearND: actually no. the only other thing that depends on it is also -2'd as needing design and not something that we should do last minute [22:13:01] chrismcmahon, or maybe it is like enwiki, but not like default vagrant config... let me figure this out [22:13:35] YuviPanda: good [22:16:22] internal v public mailing list confusion? :) [22:16:47] greg-g: ? [22:16:55] see mobile-l [22:17:27] Yuvipanda: seems like users might want to cancel *after starting an update-all, if on a slow connection, but I don't see the utility of the confirm dialog before update-all. [22:17:39] ragesoss: file a bug? [22:17:48] ragesoss: I'm ok with removing it, yeah, but not today. [22:18:12] greg-g: aah, I see. that might be ok publicly, even. [22:18:40] (03PS1) 10Dr0ptp4kt: Update W0 flourishes based on UX feedback for MVP. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/141852 [22:18:44] jgonera: sorry was in a meeting reading backscroll [22:19:23] chrismcmahon, it's probably not about persistent cookies, but about default VE config being different on different instances/vagrant [22:19:27] Yeah. Not urgent or important, just something that occurred to me. [22:19:42] ragesoss: :) [22:19:50] chrismcmahon, I'm investigating it now [22:19:53] greg-g: embargoes are a press thing, because mailing lists and IRC don't exist :) [22:28:32] (03CR) 10Yuvipanda: [C: 032] "Probably needs copy fix later on, but ok for now." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/141816 (https://bugzilla.wikimedia.org/67038) (owner: 10Dbrant) [22:33:01] 3Wikipedia App / 3Android App: Confirm dialog before mass-refresh of saved pages is not necessary - 10https://bugzilla.wikimedia.org/67057 (10Sage Ross) 3NEW p:3Unprio s:3minor a:3None The yes/no dialog before refreshing all saved pages is not very useful. Users with slow connections and many saved... [22:33:33] jgonera: yeah, looks like VE overlay should come up but does not. I'm not sure why yet. [22:34:43] jgonera: chrismcmahon - VE not coming up for me at all in vagrant. is that what y'all are discussing, or something else? [22:35:37] Maryana: sort of. automated tests that should invoke the VE overlay in mobile on beta labs are not doing that. seems OK when I do it manually though. [22:36:34] hmm, except justaminnit now... [22:37:17] YuviPanda: the patch you CR'd needs https://gerrit.wikimedia.org/r/#/c/141717/1 [22:37:52] bearND: yeah, looking at it now [22:41:13] So... I can start an update, press back, start another, and so on... And they will all eventually run to completion. [22:42:34] ragesoss: file bug? :) [22:43:14] jgonera: I think it's a bug in MF + VE for Firefox but not for Chrome [22:43:31] chrismcmahon, I think it's just a different config for vagrant [22:43:40] try a new window with private browsing [22:44:14] 3MobileFrontend / 3General/Unknown: Image caption text color is too light - 10https://bugzilla.wikimedia.org/67005#c17 (10Quiddity) (In reply to Ryan Kaldari from comment #14) > @Quiddity: I changed the text color to #222222 since that is closer to the > original Typography Refresh value (#252525). Let me kn... [22:44:18] and compare what mw.config.get( 'wgVisualEditorConfig' ) returns, especially, defaultUserOptions.enable [22:44:46] (03PS4) 10Kaldari: WIP: Change editor switcher to cog icon and move to right side [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/141092 [22:44:48] (03PS1) 10Kaldari: Change the X to a back icon in editing workflow [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/141857 [22:45:12] (03PS2) 10Yuvipanda: Properly (for real this time) handle ProgressDialogs. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/141717 (https://bugzilla.wikimedia.org/67019) (owner: 10Dbrant) [22:48:14] 3MobileFrontend / 3General/Unknown: Image caption text color is too light - 10https://bugzilla.wikimedia.org/67005#c18 (10Jared Zimmerman (WMF)) In my opinion the 000/333 combo is almost indistinguishable and doesn't provide enough differentiation between body and caption but 222/555 seems to. [22:49:21] chrismcmahon, that's the problem: https://gerrit.wikimedia.org/r/141860 I'll change this manually for now in my vagrant and fix the tests... [22:49:23] (03PS5) 10Kaldari: Change editor switcher to cog icon and move to right side [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/141092 [22:49:34] jgonera: weird, I am logged in as Selenium_user with beta enabled in Chrome, Chromium and in FF and in FF and Chrome I don't see VE and in Chromium I do see VE. [22:49:39] or actually, first I'll verify if the behavior we have on mobile by default is correct [22:50:04] chrismcmahon, that is weird... [22:53:33] (03CR) 10Yuvipanda: [C: 032] Properly (for real this time) handle ProgressDialogs. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/141717 (https://bugzilla.wikimedia.org/67019) (owner: 10Dbrant) [22:53:39] (03PS2) 10Yuvipanda: Implement (simple) error handling when fetching preview. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/141816 (https://bugzilla.wikimedia.org/67038) (owner: 10Dbrant) [22:53:45] Maryana, it seems that VE is opt-in on enwiki now, it used to be opt-out. This means that by default we load the wikitext editor on mobile, with a button allowing one to switch to VE. Is this what we want (I'm fixing tests and need to know what they should test)? [22:54:54] (03Merged) 10jenkins-bot: Properly (for real this time) handle ProgressDialogs. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/141717 (https://bugzilla.wikimedia.org/67019) (owner: 10Dbrant) [22:55:01] jgonera: VE has always been opt-in on enwiki [22:55:21] or at least, for the past 6+ months [22:55:25] nothing's changed in that regard [22:55:28] Maryana, yeah, I know that now [22:55:47] ok, so our behavior is correct, I'll submit a patch for vagrant to make it more enwiki-like [22:55:59] yep, cool [22:57:32] YuviPanda: Looks like merge build for https://gerrit.wikimedia.org/r/#/c/141816/ is not triggered. Want me to submit PS2? [22:57:45] bearND: nah, I'm making a small change (strings.xml) [22:57:52] YuviPanda: ok [22:57:56] currently it just says 'Edit failed!' which is false, since you are fetching preview [22:58:03] bearND: can you review my edit workflow instrumentation changes? [22:58:20] YuviPanda: already looked through the code [22:58:27] bearND: ah, cool :) [22:58:34] jgonera: also, want to take one more spin through kaldari's patch? :D [22:58:39] i know i sound like a broken record today [22:58:44] Maryana, one thing at a time [22:59:17] Maryana: Any thoughts on https://bugzilla.wikimedia.org/show_bug.cgi?id=64918? [22:59:44] jgonera: so you are changing the tests then also? [22:59:46] jgonera: sure, but one thing is time sensitive and the others aren't as much… :) [22:59:48] apparently I suck at reproducing bugs :P [22:59:56] (03CR) 10Mhurd: "I'll need to hold of on merging this for a bit until the storyboard changes I'm making have settled... A day or 2." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/141852 (owner: 10Dr0ptp4kt) [23:00:11] Maryana, I will get to it today, I can't context switch that often [23:00:16] dr0ptp4kt: ^ [23:00:30] chrismcmahon, yes, basically, I'll create a patch that kind of reverts my previous patch [23:00:32] bearND: do you have access to stat1003? [23:00:36] kaldari: search for "wiring color codes" in google on safari, not on enwiki [23:00:44] chrismcmahon, I can reproduce failures on my local instance with a changed VE setting [23:01:08] YuviPanda: yes [23:01:08] jgonera: sounds good, thanks [23:01:16] bearND: cool [23:01:18] (03PS3) 10Yuvipanda: Implement (simple) error handling when fetching preview. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/141816 (https://bugzilla.wikimedia.org/67038) (owner: 10Dbrant) [23:01:28] bearND: dbrant|bbl Deskana I'm going to head off and get some sleep, it's about 4:30 AM. need anything from me? [23:01:43] Maryana: Google directs me to "Electrical wiring" with no hash [23:01:49] bearND: can you do an alpha/beta release after you're done merging? :) the EL patches must go in, I think. [23:01:53] YuviPanda: I think we're good. Have fun releasing. :) [23:01:58] Deskana: will do :) [23:02:14] kaldari: in your google results, there's the primary target, and then there's the "jump to 'color code'" link right below that [23:02:16] Deskana: I'm going to wait until you turn up online to release, fwiw [23:02:16] YuviPanda: i haven't done anything with stat1003 yet, only got the login. how do i verify? [23:02:25] bearND: ah, hmm. [23:02:26] kaldari: but following that link doesn't actually jump me to the section [23:02:32] i just tried it again on my phone (iphone 4) [23:02:34] Maryana: ah! [23:02:41] :) [23:02:54] bearND: can you login now? I'll walk you through it [23:03:48] bearND: so, from stat1003, do 'mysql -h s1-analytics-slave.eqiad.wmnet -u research -p' [23:04:42] bearND: actually, simpler way! [23:04:45] YuviPanda: trying to remember how to login again [23:04:55] do i need to change the ssh config? [23:04:59] bearND: just do 'zsub vanadium.eqiad.wmnet:8600 | grep MobileWikiApp' from stat1003, and it'll list all Mobile App events as they come in [23:05:08] bearND: try doing 'ssh -A @bast1001.wikimedia.org' [23:05:35] Deskana: for the record, 9am releases are a terrible idea (the next time). 1pm is a much better time :) [23:05:40] YuviPanda: ok [23:06:40] YuviPanda: what does zsub do? [23:06:54] bearND: subscribes to a zeroMQ feed on a particular host/port [23:07:12] YuviPanda: cool [23:07:13] bearND: more details at https://wikitech.wikimedia.org/wiki/EventLogging#Check_if_the_data_I_am_logging_is_coming_through_properly.3F [23:07:17] bearND: were you able to login? [23:07:30] YuviPanda: yes, i'm in and zsubbing [23:07:36] bearND: cool [23:07:49] YuviPanda: (me, too) [23:07:56] dbrant|bbl: ah, cool :) [23:08:00] YuviPanda: mysql asks for a password [23:08:22] dbrant|bbl: PM'd you instructions [23:08:37] dbrant|bbl: you can also use zsub as mentioned in the wikitech link I just pasted [23:08:41] YuviPanda: did you want to submit a new PS for https://gerrit.wikimedia.org/r/#/c/141816/ (before i rebase your patch)? [23:09:11] (03CR) 10Yuvipanda: [C: 032] Implement (simple) error handling when fetching preview. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/141816 (https://bugzilla.wikimedia.org/67038) (owner: 10Dbrant) [23:09:21] bearND: nah, just merged it. [23:09:43] YuviPanda: awesome [23:09:58] :) [23:10:27] (03PS1) 10JGonera: Fix VE browser tests to switch to VE from source editor [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/141864 [23:10:46] (03Merged) 10jenkins-bot: Implement (simple) error handling when fetching preview. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/141816 (https://bugzilla.wikimedia.org/67038) (owner: 10Dbrant) [23:10:46] chrismcmahon, let's see if this fixes it: https://gerrit.wikimedia.org/r/141864 [23:11:07] bearND: dbrant|bbl mind if I get to sleep now? or if you want I can stay on till the patches are merged :) [23:11:44] YuviPanda: https://gerrit.wikimedia.org/r/#/c/141727/3 needs a manual merge [23:12:05] bearND: ah, let me rebase [23:12:08] YuviPanda: but i can do that as well i think [23:12:13] oh ok [23:12:21] i'll let you do it then [23:12:23] ok [23:12:52] (03CR) 10Cmcmahon: [C: 032] Fix VE browser tests to switch to VE from source editor [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/141864 (owner: 10JGonera) [23:12:54] (03CR) 10jenkins-bot: [V: 04-1] Fix VE browser tests to switch to VE from source editor [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/141864 (owner: 10JGonera) [23:13:08] jgonera: looks good to me, +2'd'd'd'd [23:13:17] bearND: done [23:13:20] (03PS3) 10Yuvipanda: Use userID for logging editing events [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/141817 [23:13:22] (03PS4) 10Yuvipanda: Update logging to reflect new Edit Workflow [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/141727 [23:13:48] chrismcmahon, we'll see if that fixes it, those tests, for some reason, failed previously. It does work on my local instance [23:14:20] jgonera: actually, I like it, it exercises that choice box [23:14:54] but the things is it did before as well, yet the tests were failing on beta labs [23:15:00] let's merge it and see [23:15:12] (before as in a couple of weeks ago) [23:15:47] jgonera: rebase? [23:16:05] (03PS2) 10Cmcmahon: Fix VE browser tests to switch to VE from source editor [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/141864 (owner: 10JGonera) [23:16:29] should be a clean rebase [23:16:51] (03PS1) 10Yuvipanda: Switch to production bits URL [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/141865 [23:16:55] it was [23:17:08] bearND: dbrant|bbl ^ as well. minor thing that isn't included in the beta script, so just put it here [23:18:28] YuviPanda: cool [23:19:20] (03CR) 10JGonera: [C: 04-1] "Two very minor things, one in inline comment, another is a leftover:" (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/140620 (owner: 10Kaldari) [23:19:30] kaldari, just two very minor things ^ [23:19:32] bearND: dbrant|bbl I'm off then. :) Do do a release as well! [23:19:34] thanks [23:19:57] YuviPanda: just alpha and beta, right? [23:19:58] bearND: dbrant|bbl exciting to have the release out tomorrow! \o/ [23:20:00] bearND: yes :) [23:20:03] in general, when you remove something completely, it's good to grep for it just in case, there's almost always some leftovers [23:20:10] YuviPanda: alright! later [23:20:31] YuviPanda: ok, good night. Seeing the EL events coming through :) [23:20:36] kaldari, let me know when you push a new patchset and I'll +2 it [23:24:44] 3MobileFrontend / 3beta: Tapping a link in VE link inspector takes you to link in desktop mode - 10https://bugzilla.wikimedia.org/66559#c3 (10Juliusz Gonera) 5NEW>3RESO/DUP This is a dupe of bug 65326. It's probably more of a VE bug. *** This bug has been marked as a duplicate of bug 65326 *** [23:25:17] (03CR) 10BearND: [C: 032] Update logging to reflect new Edit Workflow [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/141727 (owner: 10Yuvipanda) [23:25:36] (03Merged) 10jenkins-bot: Update logging to reflect new Edit Workflow [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/141727 (owner: 10Yuvipanda) [23:27:13] awjr: Got a sec? I need some advice. [23:27:43] awjr: Actually I'll send you an email about it. [23:28:28] 3MobileFrontend / 3General/Unknown: Image caption text color is too light - 10https://bugzilla.wikimedia.org/67005#c19 (10Juliusz Gonera) Maybe #444? ;) [23:29:38] Deskana sure what's up [23:34:44] 3MobileFrontend / 3General/Unknown: Image caption text color is too light - 10https://bugzilla.wikimedia.org/67005#c20 (10Quiddity) (In reply to Juliusz Gonera from comment #19) > Maybe #444? ;) #000/#444 would be a good thing to test. :) [23:38:18] (03CR) 10BearND: [C: 032] "verified on stat1003" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/141817 (owner: 10Yuvipanda) [23:38:39] (03Merged) 10jenkins-bot: Use userID for logging editing events [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/141817 (owner: 10Yuvipanda) [23:40:30] dbrant|bbl: looks like we've got all merged. do you have anything else before the alpha/beta release? [23:40:42] (03PS13) 10Kaldari: Add text to next & save buttons in mobile editors [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/140620 [23:40:49] jgonera: fixed [23:41:59] 3MobileFrontend / 3General/Unknown: Image caption text color is too light - 10https://bugzilla.wikimedia.org/67005#c21 (10Jared Zimmerman (WMF)) 000/444 https://www.dropbox.com/s/r3vrod451puj67w/Screenshot%202014-06-24%2016.41.18.png it looks ok in swatches, but in an actual text sample, it hardly looks di... [23:42:59] 3MobileFrontend / 3General/Unknown: Image caption text color is too light - 10https://bugzilla.wikimedia.org/67005#c22 (10Jared Zimmerman (WMF)) Created attachment 15720 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15720&action=edit 000/444 pasted url became garbled, uploading instead [23:43:27] (03PS1) 10BearND: Bump version for release 2.0-alpha-2014-06-24 [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/141870 [23:44:16] (03CR) 10BearND: [C: 032] Bump version for release 2.0-alpha-2014-06-24 [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/141870 (owner: 10BearND) [23:44:34] (03Merged) 10jenkins-bot: Bump version for release 2.0-alpha-2014-06-24 [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/141870 (owner: 10BearND) [23:49:59] dbrant|bbl: YuviPanda|zzz: tfinc: alpha is published [23:50:00] (03CR) 10Kaldari: [C: 032] ToC: float left should also clear other left floats [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/141754 (owner: 10TheDJ) [23:50:10] Deskana|Away: ^ [23:50:10] bearND: thanks [23:50:34] (03Merged) 10jenkins-bot: ToC: float left should also clear other left floats [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/141754 (owner: 10TheDJ) [23:58:30] (03CR) 10Kaldari: [C: 032] Fix VE browser tests to switch to VE from source editor [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/141864 (owner: 10JGonera) [23:59:06] (03Merged) 10jenkins-bot: Fix VE browser tests to switch to VE from source editor [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/141864 (owner: 10JGonera)