[00:00:28] dbrant: bearND SVG's are on the abuse filter card [00:00:39] I know its not high priority, whenever someone checks the size, please ping me [00:02:48] vbamba: great. i think dbrant is going to work on that once we get a handle on the crashes [00:02:51] Deskana: dbrant: we should ask around to see if anyone has an Samsung Galaxy S3/4 mini, Galaxy Light or Galaxy Ace 3 with 4.2.2 on it [00:03:40] bearND: Try sending an email out to wmfsf@. Be sure to include the details on how to check your version. Then if someone has one, I can go and try to reproduce. [00:03:52] Deskana: bearND: ~$80-$100 on ebay [00:04:03] dbrant: That bit is a question for Tomasz. :) [00:16:52] (03PS1) 10JGonera: Add article title and an editing indication in VE [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/142165 [00:18:15] (03PS1) 10Kaldari: Hygiene: Some clean-up of the Minerva skin code [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/142166 [00:27:22] i'm heading out - anybody need anything? [00:28:17] i'll take that as a no :) [00:38:20] maryana - i need Ice cream [00:42:13] vbamba: *did someone say ice cream* [00:43:48] yes correct - Since Maryana asked an open question about what we need at 5:43 pm on a wednesday evening [00:44:53] I hope she sees this, it took a lot to put myself out there and ask for ice cream [00:51:01] bearND: hello [00:51:04] bearND: qq [00:51:13] bearND: do you have a moment? [00:59:10] too late, she already left [01:04:30] (03PS2) 10Kaldari: Hygiene: Some clean-up of the Minerva skin code [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/142166 [01:09:47] (03PS3) 10Kaldari: Hygiene: Some clean-up of the Minerva skin code [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/142166 [01:18:44] bearND: I may have a fix soon... [01:19:16] dbrant: cool. what is it? [01:19:23] dbrant: i have a way to repro [01:19:43] bearND: orly?? [01:20:03] dbrant: ? [01:20:19] bearND: "oh really"?? [01:21:08] do tell! [01:21:20] dbrant: there's an online service which provides access to real android devices. i connected to their Samsung Galaxy Express 2 4.2.2 SM-G3815 and got the crash [01:21:54] bearND: wow! how does that work? what's the service? [01:22:17] dbrant: perfectomobile [01:23:20] dbrant: I was looking through their list of devices. They had an Ace 3, too, but it was disconnected, so I tried a few others with 4.2.2 on [01:23:39] and the Samsung Galaxy Express 2 did it [01:23:43] bearND: lol that's pretty cool [01:24:20] also tried a Samsung I9190 Galaxy S4 Mini GT-I9190 4.2.2 but that didn't crash even though we got some other models of S4 Mini's in OTRS [01:25:05] dbrant: well, once you have a patch I'd be ready to try it out. I can upload apk that are not in the store, too [01:25:22] bearND: just a few mins. [01:28:38] Gah. [01:29:29] Why do I bother trying to reply from my tablet. First Eloquence, then Brion beat me to the answer. [01:29:36] :D [01:32:46] (03PS1) 10Dbrant: Use support.v7.PopupMenu only on 2.3 devices. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/142182 (https://bugzilla.wikimedia.org/66263) [01:33:55] bearND: ^ brute force, FTW. [01:34:09] bearND: would you mind trying it on 2.3? [01:34:09] dbrant: trying it [01:34:36] dbrant: first on the 4.2.2. did you have a 2.3 device? [01:35:00] bearND: I did, but it hasn't been functioning well :( [01:37:49] 3Wikipedia App / 3Android App: Content pasted into search box is not converted to plain text - 10https://bugzilla.wikimedia.org/67109 (10Sage Ross) 3NEW p:3Unprio s:3normal a:3None I can copy formatted text, such as a link or the large-font title of an article, and then paste it into the search box.... [01:39:39] dbrant: got a crash on 2.3, sent to OTRS [01:39:59] accidentally [01:40:02] 3Wikipedia App / 3Generic: Formatting should be stripped when pasted into the app - 10https://bugzilla.wikimedia.org/65606#c1 (10Dan Garry) *** Bug 67109 has been marked as a duplicate of this bug. *** [01:40:02] 3Wikipedia App / 3Android App: Content pasted into search box is not converted to plain text - 10https://bugzilla.wikimedia.org/67109#c1 (10Dan Garry) 5NEW>3RESO/DUP This is actually a more general problem, as documented in bug 65606; formatting should be stripped when you paste *anywhere* into the app.... [01:41:17] quick closed it: https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom&TicketID=7629363 [01:42:07] bearND: ah, 1 more minute... [01:45:03] (03PS2) 10Dbrant: Use support.v7.PopupMenu only on 2.3 devices. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/142182 (https://bugzilla.wikimedia.org/66263) [01:45:13] bearND: ^ ok, one more time! [01:45:32] dbrant: it did help on the Galaxy Express 2 though :) [01:45:41] dbrant: no crash there anymore [01:45:46] bearND: good... [01:46:26] dbrant: i think eventually we should use a real action bar, but for now i prefer a quick fix [01:46:34] bearND: yep [01:48:47] 3Wikipedia App / 3Android App: "Refresh saved pages" button enabled when there aren't any saved pages. - 10https://bugzilla.wikimedia.org/67011 (10Dan Garry) 5PATC>3RESO/FIX [01:49:17] 3Wikipedia App / 3Android App: no space between "privacy policy" and "terms of use" on the about page of the Android app - 10https://bugzilla.wikimedia.org/66916 (10Dan Garry) 5PATC>3RESO/FIX [01:52:16] dbrant: PS2 works on 2.3 [01:53:00] bearND: great! working on my other devices, as well. [01:53:31] dbrant: probably would be good to use a Proxy pattern here [01:53:59] dbrant: The Galaxy Express 2 is happy, too [01:54:02] :) [01:56:20] dbrant: BTW, i was trying to update to the latest v7-appcompat but that didn't help [01:56:48] bearND: you mean like our own implementation of "PopupMenu" that encapsulates the two possible instances? [01:57:14] dbrant: yes [01:57:25] dbrant: but i'm ok with doing that later [01:57:34] up to you [01:58:26] bearND: if you're ok with this as-is, let's just use it now, and I'll 'solidify' it later. [01:59:11] dbrant: sure. let's also try to get in your other patch for the date parsing issue [02:01:47] (03CR) 10BearND: Force locale when parsing MW dates to avoid parsing errors. (032 comments) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/141964 (owner: 10Dbrant) [02:01:59] dbrant: i like the idea of that one but would prefer if we would use the ROOT locale for that [02:02:47] bearND: standby... [02:04:36] (03PS3) 10Dbrant: Force locale when parsing MW dates to avoid parsing errors. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/141964 [02:12:56] dbrant: mind if i switch the order of check to do newer Android versions first? [02:13:02] for the other patch [02:13:18] also reducing the amount of casting [02:14:51] bearND: but checking for the newer Android version is what made it crash on 2.3 [02:15:39] dbrant: ok, then we'll leave it at that for now. [02:16:25] bearND: i suppose we can get rid of one set of casts by using an import; but I purposely removed the imports to be explicit. [02:17:47] dbrant: imports wouldn't help reduce casts [02:18:33] bearND: ...right; getting confused here [02:26:51] bearND: are you close to merging? if not, I'm close to finishing an encapsulated class. [02:27:47] dbrant: i can merge the local issue first if that helps [02:27:51] locale [02:27:54] bearND: yep [02:28:10] (03PS4) 10BearND: Force locale when parsing MW dates to avoid parsing errors. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/141964 (owner: 10Dbrant) [02:31:50] (03CR) 10BearND: [C: 032] Force locale when parsing MW dates to avoid parsing errors. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/141964 (owner: 10Dbrant) [02:32:11] (03Merged) 10jenkins-bot: Force locale when parsing MW dates to avoid parsing errors. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/141964 (owner: 10Dbrant) [02:33:00] (03PS3) 10BearND: Use support.v7.PopupMenu only on 2.3 devices. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/142182 (https://bugzilla.wikimedia.org/66263) (owner: 10Dbrant) [02:37:04] 3Wikipedia App / 3iOS App: iOS App: Show custom edit summary instead of "Other" (like Android does) - 10https://bugzilla.wikimedia.org/67110 (10Kunal Mehta (Legoktm)) 3NEW p:3Unprio s:3normal a:3None In Android, if you pick a custom edit summary, it displays that text in the screen where you can pick... [02:41:46] (03PS4) 10Dbrant: Use support.v7.PopupMenu only on 2.3 devices. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/142182 (https://bugzilla.wikimedia.org/66263) [02:42:22] bearND: ^ something like this? [02:45:23] dbrant: still has a lot of casts; should've called for a factory; well at least it's more encapsulated [02:46:37] bearND: not quite sure what you mean... but it's late in the evening [02:47:24] dbrant: yeah, we can improve that later. Have you tested it on your devices? [02:47:36] bearND: I have. did you try on 2.3? [02:48:00] dbrant: doing now [02:50:27] dbrant: works on 2.3 [02:51:08] (03CR) 10BearND: [C: 032] "will improve this later to use a factory to reduce the amount of casting" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/142182 (https://bugzilla.wikimedia.org/66263) (owner: 10Dbrant) [02:51:28] (03Merged) 10jenkins-bot: Use support.v7.PopupMenu only on 2.3 devices. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/142182 (https://bugzilla.wikimedia.org/66263) (owner: 10Dbrant) [02:52:07] bearND: shall I slip out a release? [02:52:22] dbrant: if you're up for it [02:52:28] bearND: yep [02:52:54] dbrant: just checking: you have the latest mwapi, right? [02:53:28] and a clean repo (no modified files)? [02:53:53] bearND: yep, looks good [02:54:00] goood [02:54:23] dbrant: awesome, good job! :) [02:54:59] bearND: thanks... I wouldn't be able to sleep, with this bug on my mind! [02:56:10] bearND: published [02:57:05] (03PS1) 10Dbrant: Bump version number for 2014-06-25 [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/142189 [02:57:13] dbrant: same version string? [02:57:17] ^ [02:58:00] bearND: what convention are we following now? [02:58:35] dbrant: not sure, but something different would be better to distinguish between version when reports come in [02:59:09] dbrant: either 2.0.1 or 2.0-2014-06-25 would be my guess [03:00:09] Deskana: ^ thoughts? [03:00:38] about version strings [03:00:49] I really like the date-specific strings. [03:01:13] I wish YuviPanda|zzz were here to offer insight. [03:01:45] hmm, how about we pick that up with the next build? [03:02:08] Deskana: oh well, we can change the scheme with any build [03:02:17] if needed [03:02:43] If by choosing here we're not locked into any particular scheme, let's go with the date-specific one. [03:03:13] Deskana: works for me [03:05:40] alright, I'm off! anything else? [03:06:30] dbrant: no. Thanks for the fixes today. That was awesome! :) [03:11:57] bearND: So we've pushed out a release to market to fix the crashing issue with PopupMenu? [03:12:44] Deskana: recap: dbrant fixed the two most prevalent issues in 2.0: the NoClassDef found of PopupMenu on some 4.2.2 Samsung devices; and crashes for certain locales (I assume RTL languages) when parsing an internal date string [03:12:55] Deskana: yes [03:13:06] Yay! [03:13:37] Deskana: there's no space in the what's new section [03:13:58] to add that kind of info. so soon we need to clear that old stuff out [03:14:19] old as in earlier today ;) [03:14:31] \o/ [03:14:39] Haha [03:15:09] Let's leave it. [03:15:27] Seems a bit odd to change it so quickly. [03:17:56] Deskana: yeah, that's good for now. Just something to think about [03:32:58] (03CR) 10BearND: [C: 032] Bump version number for 2014-06-25 [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/142189 (owner: 10Dbrant) [03:33:28] (03Merged) 10jenkins-bot: Bump version number for 2014-06-25 [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/142189 (owner: 10Dbrant) [04:14:59] (03PS1) 10BearND: Last updated link goes to mobile view [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/142190 [05:06:48] (03PS1) 10BearND: Force locale for machine strings [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/142194 [05:21:04] 3Wikipedia App / 3Android App: NullPointerException: println needs a message - 10https://bugzilla.wikimedia.org/67112 (10Bernd Sitzmann) 3NEW p:3Unprio s:3normal a:3None https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom&TicketID=7629508 USER_COMMENT=opening app after update to androi... [05:22:46] (03PS1) 10BearND: NPE: println needs a message [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/142196 (https://bugzilla.wikimedia.org/67112) [05:25:55] * YuviPanda waves at bearND [05:26:17] hey brion [05:26:18] hello yuvipanda|zzz [05:26:20] yo [05:26:26] how’s the post-release fun coming ? [05:26:31] brion: pretty great :D [05:26:35] \o/ [05:27:51] The NoClassDef PopupMenu should trickle down since Dbrant pushed a quick fix release (and also fixed the Unparseable date crash) [05:29:34] (03CR) 10Yuvipanda: [C: 04-1] "Add a method to Utils instead?" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/142194 (owner: 10BearND) [05:29:56] bearND: ^ is this causing a lot of crashes? [05:31:46] (03CR) 10Yuvipanda: [C: 032] NPE: println needs a message [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/142196 (https://bugzilla.wikimedia.org/67112) (owner: 10BearND) [05:32:06] (03Merged) 10jenkins-bot: NPE: println needs a message [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/142196 (https://bugzilla.wikimedia.org/67112) (owner: 10BearND) [05:32:46] yuvipanda|zzz: haven't run into crashes for https://gerrit.wikimedia.org/r/142194 yet. More precautionary [05:33:06] bearND: yeah, true. I'd prefer if we made that into an Util so we can reuse that everywhere [05:33:07] :D [05:33:16] brion: I saw your post to wikimedia-l and then filed https://bugzilla.wikimedia.org/67110 after watching the screencast [05:33:18] I kinda wish I had an android device just so I could play with the app [05:33:33] you can enjoy the slow SDK emulator on your computer ;) [05:37:23] yuvipanda|zzz: Let's continue the discussion tomorrow. I need to leave soon. [05:37:37] bearND: yeah, get some sleep. awesome work and thanks for keeping a tab on things :) [05:37:58] sure. Thanks :) [05:38:32] Deskana: \o/ [05:38:49] Hey YuviPanda. :) [05:39:14] Deskana: everything seems to be going well. [05:39:22] so wheee on that [05:42:22] Agreed! [05:42:36] Deskana: now for iOS next week :) [05:42:44] Deskana: also can we tie in a font setting thing along with the dark mode? [05:42:51] Deskana: lots of requests for that too, I see [05:43:07] Deskana: Krenair's triaging of OTRS has also been super awesome! \o/ [05:44:40] Deskana: whats the font setting thing? [05:45:05] Font size, right? [05:48:59] i read quitea few pages of reviews, not sure hat you mean the 'tie in a font setting thing' [05:53:41] YuviPanda: Is there a way to get numbers on downloads and how many users are accessing the 'Save Page' in the overflow menu sometime next week? [05:53:53] Deskana: yeah [05:54:19] vbamba: we have numbers on downloads, and I think we'd have numbers on save page as well, yeah. [05:54:58] awesome! [05:55:03] vbamba: :) [05:55:30] one quick question - Did you have a specific opinion about us using 'Search Wikipedia' text on Android vs the search icon? [05:55:59] vbamba: I think we should use both, but say 'Search (English) wikipedia' instead? [05:56:15] vbamba: since even Tomasz had trouble figuring out which wiki he was on and moiz said the same thing [05:56:39] On IOS we don't spell Search out, we just use an icon [05:56:43] i would also love a design that lets the user switch languages easily during a search, but doing it without cluttering is important… we’ll think about that later [05:57:00] brion: agree [05:57:17] brion: I think the way to do that is wikidata and add options to return results in multiple languages :) [05:57:33] vbamba: right, but with this we can solve the 'which wiki am I on?' issue as well. Mobile web does this. [05:57:38] YuviPanda: I think the search box is not the best place to indicate which wiki you're in [05:57:47] moizsyed: but you're searching that wiki, aren't you? [05:58:05] moizsyed: either way, I think that's an issue that needs solving, and outside of that I don't have a strong opinion on the search icon vs search text :) [05:58:29] YuviPanda: yeah I agree, but still the "which wiki i am in" question is not solved by just the indication in the search box [05:58:41] moizsyed: vbamba should ask deskana / bearND / dbrant as well though. [05:58:46] moizsyed: why not? [05:59:03] moizsyed: the primary thing that switching wiki language affects is where you get search results from [05:59:21] YuviPanda: what percentage of our user base switches wikis? [05:59:32] moizsyed: from our reviews and OTRS? quite a few. [05:59:45] we can instrument that if you guys want. [05:59:54] not a bad idea (instrumenting) [05:59:56] YuviPanda: I would like to know that number [06:00:12] moizsyed: put a card in backlog and poke deskana? :) [06:00:16] haha [06:00:36] moizsyed: :P I'll set up a schema, should go out in an update in a few days. we can have enough data in a few weeks. [06:00:45] YuviPanda: awesome [06:01:13] moizsyed: but put a card in anyway and put your rationale for it? ToDo in this sprint... [06:01:17] YuviPanda: were you geeking out on google i/o shit all day today? [06:01:20] For now, we will make it consistent with IOS and use a magnifying glass icon instead of spelling search out. [06:01:44] +1 for consistency [06:01:52] Im adding this stuff to a pre existing card [06:02:16] moizsyed: no, I usually just read the notes after it is done. [06:02:33] moizsyed: loved the two protestors who stormed in, one of them saying how Google is building killer robots... [06:03:01] YuviPanda: is there a video of the protestors? [06:03:28] moizsyed: There are GIFs :P [06:03:38] prtksxna: share please [06:03:45] moizsyed: https://www.youtube.com/watch?v=BrgkdU0-bhY [06:03:53] prtksxna: also, sorry for not replying to your email [06:03:56] gifs might be better [06:04:09] but do the killer robots send you notifications to your watch when they kill? [06:04:56] brion: Only if you wink thrice while (dying and) wearing your Google Glass [06:04:56] I looked through all the reviews and made a list of feature requests [06:05:19] lol [06:06:00] None of this is substantial cos all these requests show up once, but we shd log feature requests with some frequency count. [06:07:37] moizsyed: no email. no gif. :P [06:07:52] prtksxna: haha, i think thats fair [06:07:56] prtksxna: i'll reply right away [06:09:22] lol, someone just reviewed the app as 'looks disgusting and old' and rated it as 5 stars [06:09:38] moizsyed: Take your time, I don't remember where I saw the gif :/ [06:09:46] prtksxna: alright replied just now [06:09:50] prtksxna: gif please [06:09:52] prtksxna: haha [06:34:37] (03CR) 10Yuvipanda: [C: 032] Last updated link goes to mobile view [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/142190 (owner: 10BearND) [06:34:59] (03Merged) 10jenkins-bot: Last updated link goes to mobile view [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/142190 (owner: 10BearND) [06:44:16] YuviPanda: have you seen this: https://app.testobject.com/#/share/21464867-df6b-409a-9d87-4593a3e85b3a/quality-report [06:48:03] moizsyed: lookin [06:48:29] moizsyed: it's running it on the old app [06:48:40] thats weird [06:49:26] moizsyed: yeah. must be a caching issue on their side [06:49:32] ah [06:50:44] moizsyed: we have a direct line to people where the app crashes through OTRS, and make sure we fix them and put new releases out asap :D [06:50:57] so far only one type of crash reported and we fixed and pushed out a point release [06:51:13] nice [07:01:39] one more user ranting on twitter - device deets are HTC One M8, software Android 4.4.2 with Sense 6. It's been like this for months and you didn't KNOW?! [07:01:48] Ignore the Rant [08:19:02] YuviPanda: hi [08:20:24] I don't have an iOS device myself, but I have friends who do. [08:20:31] Can anybody test the iOS app somehow? [08:21:22] aharoni: sadly not, apparently (unless they have an iOS dev account which costs 99$ a year) [08:21:27] atrocious, I'd say. [08:21:42] aharoni: testing is limited according to apple's ToS to eployees of WMF, IIRC [08:29:32] (03PS1) 10Amire80: Add Niklas Laxström to the credits [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/142204 [08:33:59] aharoni: hmm, I was picking up credits from git log [08:34:16] aharoni: but he did add android support to twn :D and fixed our bugs [08:34:30] aharoni: I should put a link there to translatewiki.net and the app source code [08:34:49] (03CR) 10Yuvipanda: [C: 032] "Apologies for missing this in the first build." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/142204 (owner: 10Amire80) [08:35:10] (03Merged) 10jenkins-bot: Add Niklas Laxström to the credits [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/142204 (owner: 10Amire80) [08:36:49] YuviPanda: that's precisely what I was talking about with the rabbit a few minutes ago :) [08:37:21] aharoni: at least two people pointed out that polish translations were very incomplete [08:37:50] the translatewiki.net translators are credited at the desktop Special:Version, and they should have it in the mobile About screen, too [08:37:57] I'll try to get Polish translators [08:39:42] aharoni: sorry, powercut (and network disconnected, switched to 3G) [08:39:44] did I miss anything? [08:40:17] I don't think so :) [08:40:36] aharoni: :) ok. how do you think the translators should be credited? [08:40:45] yes! [08:40:50] oh, how [08:40:54] something like: [08:41:43] add a section to the about page, make a title for it using a translatable message that says "Translation" [08:41:55] and in the content have a message that says something like [08:42:57] "This app was translated by the volunteer translators at translatewiki.net." [08:43:35] So two more messages and a bit of fiddling with activity_about.xml [08:43:51] (I already thought about doing it myself, but I don't have a way to test it.) [08:46:36] aharoni: I can test for you [08:47:34] YuviPanda: Do you have any idea about how many users do we expect in Polish? [08:47:52] aharoni: no, we don't. [08:48:01] hey vbamba! I responded to the guy on twitter and he seems happy now [08:52:36] heh [08:52:48] aharoni: we're considering instrumenting the number of people who change language in settings [10:12:29] aharoni: do you know what ' Все бы хорошо, но есть одно но. Прога вылетает как птенцы из гнезда' means? [10:12:49] :) [10:13:23] YuviPanda: "Everything would be good, but there's one thing. The app flies away like chicks out of a nest." [10:13:41] aharoni: ah, so that's what google translate told me as well... [10:13:47] was wondering if the second sentence was a mistranslation [10:13:49] I know Russian, but I'm actually not very familiar with Russian computer jargon, [10:13:57] aharoni: aah :) [10:14:00] although I guess that it means that the app crashes. [12:54:59] (03CR) 10Yuvipanda: [C: 032] release to 1.0 [apps/android/java-mwapi] - 10https://gerrit.wikimedia.org/r/141975 (owner: 10BearND) [12:55:11] (03CR) 10Yuvipanda: [V: 032] release to 1.0 [apps/android/java-mwapi] - 10https://gerrit.wikimedia.org/r/141975 (owner: 10BearND) [12:55:27] (03PS2) 10Yuvipanda: Set next dev version to 1.1-SNAPSHOT [apps/android/java-mwapi] - 10https://gerrit.wikimedia.org/r/142062 (owner: 10BearND) [12:55:40] (03CR) 10Yuvipanda: [C: 032 V: 032] Set next dev version to 1.1-SNAPSHOT [apps/android/java-mwapi] - 10https://gerrit.wikimedia.org/r/142062 (owner: 10BearND) [13:00:04] (03PS3) 10Yuvipanda: Add deploy config to pom.xml [apps/android/java-mwapi] - 10https://gerrit.wikimedia.org/r/141974 (owner: 10BearND) [13:06:53] (03PS1) 10Amire80: Add credit to translatewiki.net translators [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/142236 [13:09:28] YuviPanda: https://gerrit.wikimedia.org/r/#/c/142236/ [13:09:36] very naive and untested [13:10:00] I don't know how to make sure that it's correctly aligned for RTL. [13:10:09] aharoni: I shall test in about 2-3min [13:10:16] thanks [13:20:21] aharoni: testing now [13:28:26] aharoni: has some issues, fixing [13:28:36] thank you [15:03:02] 3MobileFrontend / 3Feature requests: Table borders are always shown - 10https://bugzilla.wikimedia.org/37222#c4 (10Ed Sanders) 5RESO/FIX>3REOP This appears to have regressed. The current selector for applying borders is just: .content table td [main.less,200]. There are many places where tables are used... [15:24:19] 3Wikipedia App / 3Android App: Android app: "how did you improve" hidden on 2.3 Gingerbread - 10https://bugzilla.wikimedia.org/67135 (10Brion Vibber) 3NEW p:3Unprio s:3normal a:3None From a report on wikimedia-l: http://lists.wikimedia.org/pipermail/wikimedia-l/2014-June/072986.html > > > The prev... [15:26:04] 3MobileFrontend / 3beta: VE hangs forever in beta labs - 10https://bugzilla.wikimedia.org/67137 (10Chris McMahon) 3NEW p:3Unprio s:3normal a:3None As a logged in user with beta set on http://en.m.wikipedia.beta.wmflabs.org, edit any page. Choose the VE editor from the pencil-bracket icon. VE neve... [15:26:38] (03CR) 10Cmcmahon: [C: 032] Updated Ruby gems [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/129144 (owner: 10Zfilipin) [15:27:04] (03Merged) 10jenkins-bot: Updated Ruby gems [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/129144 (owner: 10Zfilipin) [15:30:32] 3MobileFrontend / 3beta: VE hangs forever in beta labs - 10https://bugzilla.wikimedia.org/67137#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/xCdf1IgE [15:33:18] YuviPanda: He didnt even update his app! Jeez [15:33:49] vbamba: :) he apparently uninstalled it last week [15:36:47] 3MobileFrontend / 3beta: VE hangs forever in beta labs - 10https://bugzilla.wikimedia.org/67137#c2 (10Jon) Uncaught Error: Unknown dependency: es5-shim Does mobile really need an es5-shim? On a side note this completely wipes out editing functionality in beta on tablets/desktop - see related bug 66678. [15:39:32] Shd i set up a monday meeting to look at numbers for 'Save Page' ? [15:39:41] or you want to do that async on email? [15:40:16] vbamba: async sounds good :) we can setup a meeting sometime end of next week to talk about numbers in general, provided everyone's not busy with iOS release [15:43:59] Deskana: ^ (re: meeting) [15:44:36] Sounds good. [15:44:45] cool. can one of you set that up? :D [15:44:49] vbamba: ^ [15:48:00] i can set up for end of next week, in the mean time, just send us links to any dashboard etc [15:48:34] That's fine. [15:48:51] yeah, no dashboards yet but I'll do a stat dump [15:49:10] Deskana: dbrant bearND my hand's hurting really badly, I'm going to make a trip to the pharmacist. I'll be back in an hour or so. should make it for retro [15:49:11] :( [15:49:45] brb [15:49:49] YuviPanda: :( [15:57:50] vbamba: any chance we could do the meeting before the retrospective? [15:57:57] vbamba: (or tomorrow?) [16:03:50] dbrant: which one? [16:03:57] the numbers or search typeahead? [16:04:11] vbamba: search typeahead [16:05:18] ok! lemme see [16:06:16] moved [16:06:22] 10:30 am PSt now [16:06:46] vbamba: awesome, thanks [16:07:27] dbrant: any chance to try the SVG's for abuse filter? [16:08:09] vbamba: yep! they look good [16:08:55] send me a screenshot when you have a chance? [16:08:59] no hurries at all [16:16:59] hi, mobile team! search in hebrew on mobile is broken [16:17:13] Deskana: are you the address ? [16:17:40] matanya: Can you describe the problem? [16:18:07] yes, open he.m.wikipedia.org and search in hebrew letters [16:18:42] the pages freezes and then transformed to he.wikipedia.org [16:19:31] Huh, I'm not having that problem. [16:19:56] However, I do Apps not Web, so I might not know. :) [16:20:15] it is not consistent [16:20:30] who does web ? [16:21:50] matanya: Maryana is the PM for that. [16:21:58] ok, thanks [16:22:15] (03PS1) 10BearND: [WIP] Adjust font size based on system settings [needs testing] [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/142267 [16:23:02] MaxSem: are you aware of this ? [16:23:30] eh... [16:23:33] matanya: I can kinda reproduce it - Android 2.3.4 stock browser, I press the search box and the browser goes back [16:23:49] s/press/tap/ [16:25:22] yes, that aharoni [16:25:40] matanya: can you report to bugzilla? [16:25:46] yes [16:25:51] thanks [16:29:34] 3MobileFrontend / 3General/Unknown: search in Hebrew wiki in Hebrew letters in mobile frontend takes you to previous page instead of search - 10https://bugzilla.wikimedia.org/67140 (10matanya) 3NEW p:3Unprio s:3normal a:3None How to reproduce: go to he.m.wikipedia.org and try to search with Hebrew l... [16:30:32] 3MobileFrontend / 3General/Unknown: search in Hebrew wiki in Hebrew letters in mobile frontend takes you to previous page instead of search - 10https://bugzilla.wikimedia.org/67140#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/gfTmzanP [17:06:02] 3Wikipedia App / 3Android App: crash with NoClassDefFoundError: support.v7.internal.view.menu.MenuBuilder - 10https://bugzilla.wikimedia.org/66263#c7 (10Alex Monk) Is this fixed now? [17:06:32] 3MobileFrontend / 3General/Unknown: search in Hebrew wiki in Hebrew letters in mobile frontend takes you to previous page instead of search - 10https://bugzilla.wikimedia.org/67140#c2 (10Ryan Kaldari) Works fine for me. Can you provide additional details such as what browser you are using and what page you a... [17:10:32] 3Wikipedia App / 3Android App: crash with NoClassDefFoundError: support.v7.internal.view.menu.MenuBuilder - 10https://bugzilla.wikimedia.org/66263#c8 (10Dmitry Brant) There may be a few more residual reports from users who haven't gotten the very latest update, but I believe this is indeed fixed. Will conti... [17:11:07] (03Restored) 10Jdlrobson: WIP: Use the View in Mantle extension [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129337 (owner: 10Jdlrobson) [17:11:32] 3MobileFrontend / 3General/Unknown: search in Hebrew wiki in Hebrew letters in mobile frontend takes you to previous page instead of search - 10https://bugzilla.wikimedia.org/67140#c3 (10matanya) firefox 30 on android 4.4.4, searched on main page, but happened on others too. [17:13:04] (03Restored) 10Jdlrobson: WIP: Use Mantle version of Class and eventemitter [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129336 (owner: 10Jdlrobson) [17:14:23] (03PS2) 10Jdlrobson: Use Mantle version of Class, eventemitter and View [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129336 [17:14:26] (03PS4) 10Jdlrobson: Add template dependency to Mantle extension [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129335 [17:14:37] (03Abandoned) 10Jdlrobson: WIP: Use the View in Mantle extension [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129337 (owner: 10Jdlrobson) [17:14:56] (03CR) 10jenkins-bot: [V: 04-1] Use Mantle version of Class, eventemitter and View [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129336 (owner: 10Jdlrobson) [17:15:05] (03CR) 10jenkins-bot: [V: 04-1] Add template dependency to Mantle extension [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129335 (owner: 10Jdlrobson) [17:17:57] yurik: need anything from me? we'll be taking off relatively soon, but thought i'd check anyhow [17:20:29] yurik: shutting down [17:28:32] 3MobileFrontend / 3General/Unknown: search in Hebrew wiki in Hebrew letters in mobile frontend takes you to previous page instead of search - 10https://bugzilla.wikimedia.org/67140#c4 (10Ryan Kaldari) Hmm, tried to reproduce in desktop Firefox 30, but no luck. I'll see if I can reproduce on Android when I'm... [17:30:03] YuviPanda: can you add 2.0 to https://www.mediawiki.org/wiki/Mobile/Release_history ? [17:30:28] bearND: dbrant ^ can one of you do that? :) [17:46:45] Android L preview SDK is now available [17:49:51] jgonera_: kaldari - VE appears to be borked on beta labs [17:50:00] i can open the edit interface but can't save [17:50:06] the UI just stops responding [17:50:29] What article? [17:50:39] san francisco & european robin [17:51:10] Try on something really small [17:51:35] oh wait, it did work on european robin finally, but the overlay toolbars were all messed up [17:52:20] (03CR) 10MaxSem: [C: 032] Hygiene: Some clean-up of the Minerva skin code [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/142166 (owner: 10Kaldari) [17:52:24] OK, hold on for 2 minutes ;) [17:52:48] jgonera_: well, abbey and i were about to go do some user testing [17:52:58] (03Merged) 10jenkins-bot: Hygiene: Some clean-up of the Minerva skin code [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/142166 (owner: 10Kaldari) [17:53:04] so if it's actually more than a 2 minute fix, we probably want to delay til tomorrow [17:53:07] I know [17:53:12] At 11 [17:53:26] yup [17:54:57] @dbrant @bearND presenting the 'Search can be better' Etherpad [17:54:58] https://etherpad.wikimedia.org/p/search_enhancements [17:55:21] brion, wanna review https://gerrit.wikimedia.org/r/#/c/141842/ ? :P [17:55:28] looking [17:55:31] \o/ [17:55:52] assuming that doesn’t explode XML… :D [17:56:09] oh shi... [17:56:34] * MaxSem doesn't remeber if he checked it, so checks again [17:59:12] * brion updates his mediawiki install for a local test [17:59:21] (03CR) 10MaxSem: [C: 04-2] "Eh, breaks XML:P" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/141842 (https://bugzilla.wikimedia.org/67054) (owner: 10MaxSem) [18:00:06] dbrant: would you mind upload the apk to release so we can link to the latest one? [18:00:08] moizsyed: https://etherpad.wikimedia.org/p/search_enhancements [18:00:19] for your review [18:00:28] bearND: you should have releases access too now, I think? [18:00:29] bearND: yep [18:00:49] vbamba: cool [18:02:28] YuviPanda: id have it, but i don't have the latest apk [18:02:33] bearND: ah, ok [18:03:30] Deskana|Away: retro? [18:03:41] MaxSem, answered https://www.mediawiki.org/wiki/Talk:Requests_for_comment/Ditch_crappy_API_formats [18:05:25] yurik, replied [18:05:41] vbamba: I added a comment on the search etherpada too. [18:06:41] we’re having some a/v trouble with the hangout [18:07:41] brion, meh - looks like I'll have to special-case it for JSON only [18:07:51] is it worth the effort? [18:08:30] MaxSem: dont bother i guess, we already worked around it [18:08:40] :) [18:08:49] if we find a general solution we can use that klater [18:09:23] https://etherpad.wikimedia.org/p/MobileAppRetrospective [18:12:08] @YuviPanda thanks! [18:12:24] vbamba: I might be wrong, actually. Just talking to the search team to see if they can implement something for us. [18:21:16] YuviPanda: I don't have permissions to write to the "stable" directory on releases... [18:29:04] YuviPanda: ^’ stable’ dir needs chmod g+w, it’s owned by you :) [18:29:11] brion: dbrant yeah, doing [18:33:45] @dr0ptp4kt can you rephrase your search comment in the words of a user? [18:34:04] vbamba: i'll try :) [18:38:11] Its super useful stuff. [18:38:22] just need you to rephrase it [18:42:19] (03PS1) 10Dbrant: Improve appearance of Edit workflow on 2.3 [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/142307 (https://bugzilla.wikimedia.org/67135) [18:43:56] brion: ^ try, when you get a chance? [18:43:57] (03Abandoned) 10MaxSem: Make mobileview always return protection as an object [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/141842 (https://bugzilla.wikimedia.org/67054) (owner: 10MaxSem) [18:44:02] 3Wikipedia App / 3Android App: Font size changer - 10https://bugzilla.wikimedia.org/67102 (10Alex Monk) [18:44:16] dbrant: \o/ will test after the mtg [18:50:06] bearND: dbrant are either of you interested in getting translatewiki.net shell access, so you can do import/export of translations? [18:50:22] YuviPanda: but of course [18:50:28] YuviPanda: yes, please [18:51:11] dbrant: bearND let's talk about it after the meeting? [18:51:26] ok [18:51:26] dbrant: YuviPanda bearND Deskana: how is day 2 looking ? [18:52:07] tfinc: yesterday's annoying crash is fixed! and nothing else major so far [18:52:37] YuviPanda: mhurd lolz http://ampersandsoftworks.com/wikipedia-mobile-ios-critique/ [18:52:51] "Wikipedia Mobile is in need of a native rewrite" [18:53:27] poor guy writing this a month before the reboot [18:54:01] jdlrobson: :) [18:54:36] oh my god so many emails [18:54:59] dbrant: excellent. do we have an update scheduled or have you already pushed it out? [18:54:59] this conf wiki is killing me [18:54:59] wifi [18:55:24] tfinc: pushed out! (that's how we know it's fixed ;)) [18:56:39] jdlrobson: can't load the article due to crappy wifi but we should get him as a tester if he's constructive mhurd [18:58:02] 3MobileFrontend / 3General/Unknown: Hash gets swallowed (again) - 10https://bugzilla.wikimedia.org/64918#c9 (10Ryan Kaldari) 5RESO/WOR>3REOP I was able to reproduce by following the steps more closely. It looks like the hash is getting lost at the Varnish redirect level. Do you want to take a look at thi... [18:58:38] MaxSem: I might want to transfer this bug to you Max since you know more about the mobile Varnish redirect: https://bugzilla.wikimedia.org/show_bug.cgi?id=64918 [18:58:47] 3MobileFrontend / 3General/Unknown: API mobileview "protection" sometimes returns object, sometimes returns empty array in JSON output - 10https://bugzilla.wikimedia.org/67054#c7 (10Jon) Not there is a FIXME in PageApi.js for exactly this reason, would be good to remove that in the fix. [18:59:24] Deskana: getting 503's on http://blog.wikimedia.org/ .. is it just me? [18:59:34] i see it on my phone too [18:59:34] kaldari, what's varnishy in there? [18:59:40] using a data connection [18:59:53] tfinc: getting 503 as well [19:00:04] bearND: can you escalate this to OPS ? [19:00:18] tfinc: ok [19:00:27] give our press coverage right now we can't afford to have the post down let alone the whole blog [19:00:52] tfinc: they're on it [19:01:06] bearND: ^ [19:01:17] MaxSem: Just added clarification to the bug [19:01:18] 3MobileFrontend / 3General/Unknown: Hash gets swallowed (again) - 10https://bugzilla.wikimedia.org/64918#c10 (10Ryan Kaldari) In other words, if I try to go to https://en.m.wikipedia.org/wiki/Earth#Shape directly, it works fine. But if I try to go to https://en.wikipedia.org/wiki/Earth#Shape on a mobile devi... [19:01:42] tfinc: ops is aware and working on that [19:01:55] YuviPanda: beat me to it [19:02:15] kaldari, the problem here is that varnish has no way of knowing the hash [19:02:30] oh, so has that always been broken? [19:02:59] pretty much [19:03:21] bearND: dbrant what do you want your translatewiki shell names to be? [19:03:25] same as IRC nicks? [19:03:26] OK, I'll mention that in the bug and archive the Trello card then. [19:03:32] YuviPanda: "dbrant" [19:04:32] 3MobileFrontend / 3General/Unknown: Hash gets swallowed (again) - 10https://bugzilla.wikimedia.org/64918#c11 (10Ryan Kaldari) According to Max, the problem here is that Varnish has no way of knowing the hash and this has always been a problem. [19:05:02] 3MobileFrontend / 3General/Unknown: Hash gets swallowed by Varnish redirect to mobile site - 10https://bugzilla.wikimedia.org/64918 (10Ryan Kaldari) [19:06:20] bearND: dbrant brion can you +1 https://gerrit.wikimedia.org/r/#/c/142313/ [19:09:17] YuviPanda: can you change permissions on the "stable" directory under "releases"? [19:09:49] YuviPanda: no mhurd in the list? [19:10:23] bearND: ah, let me ask him as well [19:10:30] brion: can you poke mhurd and ask if he wants twn access too? [19:10:46] dbrant: ah, doing now [19:10:49] YuviPanda: he says yes [19:11:57] brion: ok. amended patch. can you ask him to +1 and +1 yourself as well? [19:12:08] vbamba: okay, i've tried to put in some points and i linked to the preexisting design page. i don't think there's any rule that says we have to be strictly bound to particular options. i prefer to see incremental improvements in the search, personally. [19:12:17] 3Wikipedia App / 3Android App: Font size changer - 10https://bugzilla.wikimedia.org/67102#c2 (10Alex Monk) https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom&TicketID=7628730 https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom&TicketID=7629162 https://ticket.wikimedia.org/otrs/in... [19:12:53] dr0ptp4kt: https://bugzilla.wikimedia.org/show_bug.cgi?id=67161 should fix a good part of 'em [19:13:27] ah mhurd got netsplitted [19:13:37] brion: they're dropping like flies [19:13:37] dr0ptp4kt: thank you thank you thank you [19:13:41] you'll have to finish the app without him [19:13:44] brion: uploaded new patchset to be brion VIBBER instead of brion vibber :) [19:13:51] eh [19:13:51] heh [19:13:51] it's chaos on irc right now. [19:14:04] i lost ten men in corefeatures [19:14:14] jdlrobson: that's why you are here, isn't it? :) [19:14:14] netsplit the movieeeeeeeee [19:15:05] dbrant: permissions changed for stable [19:15:19] (03CR) 10Brion VIBBER: [C: 031] "Looks much better on my Nexus One (2.3.7):" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/142307 (https://bugzilla.wikimedia.org/67135) (owner: 10Dbrant) [19:15:40] mhurd: can you do a +1 CR on https://gerrit.wikimedia.org/r/#/c/142313/ to confirm? [19:15:59] YuviPanda, sweet. ideally with did-you-mean intitle silently baked in as well :) as a starting point we gotta at least have intitle, right?! [19:16:32] dr0ptp4kt: yeah, intitle itself would be nice, but I'm worried about performance [19:16:51] Jdlrobson take a look at my tweet. We need to build a wall like that [19:17:38] flyingclimber: i've told you already we should have a device lab :P [19:17:47] YuviPanda: yeah, that's where i'm sort of thinking we need an "Experimental" search mode or something like that, that way the user understands it may be flaky, yet gets the benefits [19:17:55] you told me we probably couldn't find the space for one [19:18:04] YuviPanda, plus it would help to avoid beating up on the engine too much, i would hope [19:18:10] (perf wise) [19:18:35] flyingclimber: and http://media0.giphy.com/media/vO8F4fYQd39h6/giphy.gif [19:19:02] Jdlrobson strap them to the wall then. We can make shelves [19:19:19] Less talk and more do [19:19:29] flyingclimber: but we also have to keep 'em charged and in sync with wifi... [19:20:05] and it's more fun if we can be an open device lab that anyone in the area can use but i guess after the security issues we've had no way that will happen :( [19:20:18] Jdlrobson Google open sourced their whole wall setup [19:20:31] dr0ptp4kt: hey Adam. I found out a bad interaction between ZeroPortal and JsonConfig extension. The PHPUnit test throw some warning, filled at https://bugzilla.wikimedia.org/show_bug.cgi?id=67142 :) [19:20:52] dr0ptp4kt: might be an easy fix or not, would be great to have it looked at [19:21:26] (03PS1) 10MaxSem: Use TOC only when page is supposed to have it [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/142317 [19:21:36] kaldari_lunch, ^^^ :) [19:21:40] 10 lines, as promised [19:21:44] hashar: thanks, we'll take a look. might be a few days [19:21:50] yurik: ^ [19:22:03] YuviPanda: bearND: so here's something curious... I uploaded my APK to "stable", and I noticed that my APK is about 250KB smaller than the first one. [19:22:25] (03CR) 10jenkins-bot: [V: 04-1] Use TOC only when page is supposed to have it [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/142317 (owner: 10MaxSem) [19:22:30] dr0ptp4kt: yurik: can be reproduced with a stock mediawik install + a few extension as listed on bug :) I am sure it is an easy fix but take your time! [19:22:49] dbrant: gaaah, blame me. I had the hires icons generated in there via the script and forgot to clean [19:23:27] YuviPanda: ah, got it. just glad it's not something I forgot to include! [19:23:32] (03CR) 10Jdlrobson: [C: 04-1] "`make jshint`" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/142317 (owner: 10MaxSem) [19:23:33] dbrant: :) [19:23:56] bearND: dbrant can you respond on the patch with your translatewiki usernames? [19:24:16] brion: mhurd ^ [19:24:26] YuviPanda: already +1'd [19:24:44] bearND: Nemo_bis is asking for translatewiki.net usernames [19:24:50] assuming you have an account [19:25:09] YuviPanda: add them as comments? [19:25:14] bearND: yeah [19:25:22] YuviPanda: ok, will do [19:26:23] YuviPanda: bearND: i've got to head off for a while (driving to chicago), but will check in later. Anything you need at the moment? [19:26:43] dbrant: nope :) ty for all the work! we'll setup something tomorrow to get you guys up to speed on twn. [19:26:47] (translatewiki.net [19:26:55] YuviPanda: great [19:26:57] dbrant: have a safe drive! [19:27:06] YuviPanda: i created mhurd acct [19:27:15] mhurd: can you comment on the patch? [19:27:18] mhurd: https://gerrit.wikimedia.org/r/#/c/142313/4 [19:27:22] dbrant: yes, thank you for the fixes yesterday! [19:27:35] bearND: you bet! later... [19:31:48] jdlrobson, do you always have to repeat jenkinsbot? :P [19:32:32] (03PS2) 10MaxSem: Use TOC only when page is supposed to have it [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/142317 [19:33:05] bearND: what card are you going to pick up now? Can you pick up onboarding? [19:34:29] MaxSem: i'm just teaching you to fish [19:34:32] don't rely on jenkinsbot [19:34:36] install the commit hook [19:34:41] it will make your life a lot happier [19:34:44] install makehooks [19:34:45] nah [19:34:55] MaxSem: well then i will continue to repeat jenkinsbot [19:35:08] * YuviPanda gives jdlrobson cookies [19:35:57] YuviPanda: was working n some font sizing thingies, but not sure if we got the right card for that besides the bug one. It's not really a bug as a missing feature [19:36:07] YuviPanda: but i can pick up onboarding, too [19:36:14] bearND: yeah, I think we should handle that as part of the night mode stuff I'm working on [19:37:41] YuviPanda: beginning of font sizing: https://gerrit.wikimedia.org/r/#/c/142267/ [19:37:52] bearND: ah, cool! I'll poke around [19:39:10] YuviPanda: similar to the first try but adjusting for pixel density, so that should work better. needs some testing on an xxhdpi device for more confidence, but i have tested it with two different density devices (hdpi + xhdpi) [19:39:28] i think brion had an xxhdpi [19:39:51] yeah nexus 5 is xxhdpi [19:41:13] (03CR) 10Florianschmidtwelzow: "This won't work in alpha (lazyload) and will be use for all pages the value of first requested articlae? So if first page has toc disabled" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/142317 (owner: 10MaxSem) [19:41:25] brion: would you mind checking out the above patch and see if the font sizes look reasonable while switching system settings (display/font size) at your convenience? [19:41:52] (03CR) 10MaxSem: "That's not a problem because lazy loading will die." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/142317 (owner: 10MaxSem) [19:42:00] yeah moment [19:42:05] code looks reasonable :D lemme test [19:42:41] (03CR) 10Florianschmidtwelzow: [C: 031] "Oh, ok :)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/142317 (owner: 10MaxSem) [19:42:53] YuviPanda: vbamba: i still think we need a way for the user to override the settings. At least on 2.3 where there is no system setting to increase font size preference [19:43:17] bearND: oh completely agree. Think it should be part of an 'appearance' in settings, along with the night mode [19:44:13] YuviPanda: yes. I think a percentage like the old app would be easy and we would just apply the percentage value to the formula in the aforementioned patch [19:44:35] bearND: yeah. instead of static percentages we should just have a slider [19:44:59] bearND: for the old app, we first had like 3 options, and then people wanted one more because newer devices kept coming up :) [19:45:20] Deskana|Away: bearND font size changing is the number one request from the released app [19:45:25] YuviPanda: yeah, i heard also some people wanted smaller fonts [19:45:53] bearND: yeah, a -25% +300% slider would be nice, I think [19:46:20] YuviPanda: yeah, i think that a good start, and we can adjust later if needed [19:46:25] bearND: yeah [19:46:30] bearND: plus we should instrument it :) [19:47:11] YuviPanda: would be good to have some immediate feedback when using a slider though. So doing this in the more/settings activity doesn't seem ideal [19:47:22] bearND: ah, hmm, that's true. [19:47:34] bearND: perhaps we can remember zoomlevel, and make the app reflow when the user zooms [19:47:36] YuviPanda: +1 for instrumenting, and see how many max it out and keep it that way [19:47:49] bearND: that's what desktop browsers do [19:48:35] bearND: looks good; normal is normal-sized, and small/large/huge are … small/large/huge ;) [19:48:57] (03CR) 10Brion VIBBER: [C: 031] "Looks good on Nexus 5 (xxhdpi)!" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/142267 (owner: 10BearND) [19:49:14] maybe we need to get that one phone that’s xxxhdpi ;) [19:49:22] YuviPanda: i started a todo list on the patch, but it's more meant to be a list for discussion points. should we merge this with vbamba's? [19:49:30] brion: :)) [19:49:55] bearND: vbamba can we keep it in bugzilla instead? OTRS uses that as well, plus community can discover that much more easily than an etherpad. [19:49:59] http://arstechnica.com/gadgets/2014/06/lg-g3-review-a-great-phone-with-way-too-many-pixels/ <- frickin 2560x1440 [19:50:08] vbamba: can you also send out notes about your meeting yesterday with dbrant and bearnd to mobile-l? [19:50:33] 3MobileFrontend / 3General/Unknown: Hash gets swallowed by Varnish redirect to mobile site - 10https://bugzilla.wikimedia.org/64918#c12 (10Jon) Are you sure? The docs mention hashes.. https://www.varnish-cache.org/docs/3.0/installation/upgrade.html#req-hash-is-replaced-with-hash-data [19:50:41] MaxSem: http://akashbhunchal.blogspot.com/2013/09/https-redirection-with-elb-and-varnish.html [19:50:58] brion: nice headline: way too many pixels [19:51:01] this seems to suggest you can access the hash..? [19:51:51] jdlrobson: ping? small viewport related question you might know about... [19:51:58] YuviPanda: sure [19:52:17] jdlrobson: is there a way I can set it to 1. make pinch zoom available but, 2. when the user zooms, the text reflows rather than just zooms? [19:52:26] jdlrobson: this is the behavior of desktop browsers... [19:53:26] YuviPanda: i suspect you could change the size of a container div or something, but i dunno if that would scroll horizontally right [19:53:42] YuviPanda mmm [19:54:06] brion: right. one way to do it is to set content's width on scale change, but that seems a bit hackish when we can just change the definition of '1em' from the java side. I'm trying to see if there's a built in webview solution [19:54:47] hmm [19:54:56] YuviPanda: with my patch we can change the font size, just not the images [19:55:04] brion: right. [19:55:05] you could also maybe have it actually zoom back out, and change the font sizd depending on what your zoom was [19:55:39] brion: yeah, if we have a font size slider of some sort, we should be able to just dynamically change the definition of '1em' and have that work as 'zoom'. [19:55:46] http://dev.w3.org/csswg/css-device-adapt/#the-atviewport-rule < can we use this yet? :( [19:56:17] YuviPanda: i suspect the above will help you if it is possible though [19:56:20] jdlrobson: I suspect not. [19:56:36] jdlrobson: hmm, if there's nothing easy I guess we'll just do a java based solution. we've to work on 2.3 so I guess the answer to using the @ rules is no [19:58:01] (03PS3) 10Brion VIBBER: Work in progress: EventLogging opt-out switch [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/141926 [19:58:03] @YuviPanda put what in bugzilla? [19:58:11] search stuff - Im not sure what bugs to file yet :) [19:59:11] vbamba: he's talking about zoom [19:59:35] vbamba: https://bugzilla.wikimedia.org/show_bug.cgi?id=67102 [20:00:33] 3Wikipedia App / 3Android App: Font size changer - 10https://bugzilla.wikimedia.org/67102#c3 (10Yuvi Panda) And multiple people asking for it on the Play store as well. And more OTRS feedback has come in with the same request too. [20:02:29] vbamba: YuviPanda: see also double touch drag in http://developer.android.com/design/patterns/gestures.html [20:02:41] (03PS6) 10Brion VIBBER: adding edit protection fields [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/141763 [20:03:40] (03CR) 10Brion VIBBER: "Monte suggests using an NSAttributedString for the formatting of the add'l text, which may simplify things. Going to test that next..." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/141926 (owner: 10Brion VIBBER) [20:07:17] 3MobileFrontend / 3General/Unknown: Hash gets swallowed by Varnish redirect to mobile site - 10https://bugzilla.wikimedia.org/64918#c13 (10Jon) you should really create a new bug in these circumstances. the original bug was about a JavaScript error. I seem to remember the varnish bug was recorded separately. [20:10:37] Deskana: I split https://trello.com/c/65o3CWYW/4-as-a-user-who-reads-at-night-i-d-like-a-night-mode-so-that-reading-is-easier-in-dark-environments into subtasks [20:11:01] Cool. [20:11:08] For now I have to focus on getting the next sprint set up! [20:11:48] Deskana: alright. I haven't split the cards out yet, I shall do so now. I'll just estimate and poke the other engineers? [20:12:41] Sure. You guys know the estimation process, so I think you can carry it out just fine. [20:13:12] Deskana: is this all done https://trello.com/c/Afq8I3Ly/32-3-complete-implementation-of-event-logging-calls . we need to close the sprint before tomorrow [20:14:37] Deskana: sweet. ty. I expect it to total up pretty big, though. [20:15:06] tfinc_: I just spoke to Brion and we're pretty confident it works. We're done! [20:15:29] \o/ [20:15:48] yeah we’re not sure we have a way to grab the data that’s sent through API param instead of EventLogging gif [20:15:53] other than that it’s all known to work [20:15:54] :D [20:16:10] YuviPanda: What's the state of our Hebrew translations for the app? [20:16:19] Deskana: 100%, I think. on Android, at least. [20:16:31] Fucking awesome. [20:16:35] Deskana: :D [20:16:51] Was it Amir? [20:17:00] Deskana: I started the process of getting mhurd, brion, bearND and dbrant access to translatewiki.net shell, so they can do import/exports at will as well [20:17:04] Deskana: indeed, it was :) [20:17:35] @bearND @YuviPanda I don't know how you plan to do the font adjustment (Use the native font size setting) on Android [20:18:31] vbamba: right. we also need a place to put the night mode switching, so was thinking of combining both into some sort of control. [20:18:37] Deskana: was https://trello.com/c/Io6a0jEi/24-3-onboarding the only story to roll over to sprint 34 ? [20:18:37] Did you discuss the user behavior with anyone? [20:18:48] tfinc_: AFAIK yes, let me check. [20:18:50] vbamba: we haven't come up with a user behavior idea yet. [20:19:01] tfinc_: No, we also have https://trello.com/c/MYI1ws6p/43-3-ios-app-scrolling-does-not-automatically-show-hide-search-bar-navigation-buttons [20:19:03] When a user feels like the font is too small or too big, will they try to change the size within the app or go to the native setting? [20:19:06] Deskana: did any estimated stories get moved to the backlog? [20:19:11] Fatal error: Call to a member function isMainPage() on a non-object in /usr/local/apache/common-local/php-1.24wmf10/extensions/MobileFrontend/includes/api/ApiMobileView.php on line 270 [20:19:14] Do we want redundancy and do it in both places [20:19:25] so 6 points carried over [20:19:47] tfinc_: Checking. [20:19:56] vbamba: so, 1. on older devices there is no native setting, 2. native settings change things for all apps, which is undesirable for most users, 3. from qualitative feedback in the OTRS queue, people want to change the thing from inside the app. [20:20:30] vbamba: YuviPanda: I'm for including the system setting somehow (either for the default or always) but letting the user adjust based on that in-app [20:20:49] tfinc_: Nothing that was estimated was backlogged. [20:20:54] k [20:21:02] vbamba: do you have thoughts on where the dark page switcher would be? We should group 'change appearance' group of controls somewhere. [20:21:04] 3MobileFrontend / 3General/Unknown: Fatal error: Call to a member function isMainPage() on a non-object in ApiMobileView.php on line 270 - 10https://bugzilla.wikimedia.org/67164 (10Sam Reed (reedy)) 3NEW p:3Unprio s:3normal a:3None protected function isMainPage( $title ) { if ( $title->isRe... [20:21:10] vbamba: agreed with what bearND said [20:22:43] Deskana: i'm recording 29 story points for sprint 34 [20:22:45] i need to look within the app and need some time to think about this [20:22:49] YuviPanda: vbamba: based on http://developer.android.com/design/patterns/settings.html we should have the settings in the overflow menu [20:23:01] sprint 33 is now closed [20:23:03] thanks all [20:23:26] bearND: we can be a bit more user centric about this. [20:23:46] is this just on main page or every article page? [20:24:04] Deskana: you know have https://trello.com/b/5DhKhjmW/mobile-app-sprint-35 to seed [20:24:24] tfinc_: Yep, about to start that once I'm done with these last few emails. [20:24:29] vbamba: every article [20:24:35] page [20:25:21] bearND: haha :) [20:25:32] 3MobileFrontend / 3General/Unknown: Fatal error: Call to a member function isMainPage() on a non-object in ApiMobileView.php on line 270 - 10https://bugzilla.wikimedia.org/67164#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/KlFNspve [20:25:41] need time to think about the resize font behavior - are you implementing this right now? [20:26:02] vbamba: no. dark theme first. At best we'd get to font size behavior at end of next week. [20:26:33] bearND YuviPanda bearND vbamba convention in the most popular reader app is to support pinch zoom plus a +/- resize control. i often find myself messing up accidentally hitting pinch zoom. i like having +/-3 zoom levels [20:26:41] YuviPanda: Font size should be in next sprint, not this sprint. :) [20:26:44] two cents [20:26:52] Deskana: right. 'at best'. [20:27:18] Deskana: vbamba to rephrase, having the design by end of next week would be nice :) [20:27:25] YuviPanda: vbamba: I like how the Kindle app has the font and color settings as a popup, so you can see the effects right away. Very useful, esp. with sliders [20:28:12] is there a trello card for font change? [20:28:17] Deskana: YuviPanda ? [20:28:28] vbamba: https://trello.com/c/1IadWUPO/75-font-size-changer [20:28:35] merci [20:29:30] gotta disconnect....ttyl [20:30:47] Wait, how did this happen? [20:31:14] Deskana: bugello [20:31:28] Cards shouldn't really be able to creep into the current sprint and then start having designs provided and implementation begun like that. [20:31:49] Deskana: right. perhaps we should ask awjr_away to move them into a specific 'bugello' list that's at the end? [20:32:18] I'm probably just not on top of the cards coming in due to other stuff. [20:32:41] Deskana: what's your though about the traditional vs simplified chinese experience ? [20:32:56] But I'm uncomfortable with features creeping into the current sprint and getting estimated and stuff without me even knowing. Rule of three, remember. :) [20:33:07] Deskana: also, to be fair, we don't have an implementation (and weren't really considering doing it right now). We were just talking about it since Jon was around and he might have some ideas on how to do it in pure CSS. [20:33:29] Okay, I was talking about the "we'll start this next week" comment which implied it was going into the current sprint. [20:34:18] Deskana: yeah, that was me being unclear. sorry about that. It was probably more unclear because I was talking about how this interface should be unified with the night mode switcher, which we *would* do next week. [20:34:25] Right, okay. :) [20:34:32] tfinc_: This is the language variant issue that we backlogged a while back after we uncoupled the Arabic not being RTL issue from it. [20:34:51] (03PS4) 10Brion VIBBER: EventLogging opt-out switch [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/141926 [20:35:11] Deskana: and I wanted design to know that as well so whatever we do come up with for night mode switching is expandable to more later on :) [20:35:22] Okay, so I misunderstood. That's fine. :) [20:36:01] Deskana: :) bugello putting things there does sound like an issue though. [20:36:17] I think it's fine when I'm not so swamped with non-apps stuff AND release stuff. [20:36:27] Both of which should become less of a problem soon. [20:37:09] Deskana: :) true, but after the Android release swamp is the iOS release swamp :) [20:37:10] Deskana: k. thanks [20:39:02] bearND: re: the pom.xml change, that was the one you used to make the release, right? [20:39:05] Okay, so the next release-related fire that I have to put out [20:39:08] bearND: just wanted to confirm before I merge. [20:39:16] Comms have asked us to reset the non-English descriptions for the app while we get translations for the new one [20:39:20] Can someone do that please? :) [20:39:24] YuviPanda: which one? [20:39:56] bearND: java-mwapi [20:39:58] Deskana: yeah, on it. [20:40:38] Deskana: hahaha, great. so there's no way to reset them, only provide new ones [20:40:41] YuviPanda: the pom change in our app is to make sure our builds a reproducable in terms of java-mwapi (using a non-SNAPSHOT version) [20:41:05] bearND: right. I meant the pom change adding release target on java-mwapi so you can copy them over to toollabs [20:41:18] YuviPanda: Fail. Well, I'll get on getting the translations then. [20:41:23] Deskana: I'll just copy the english language description over. [20:41:44] Thanks YuviPanda. [20:41:48] Deskana: yw! :) [20:42:49] YuviPanda: https://gerrit.wikimedia.org/r/#/c/141974/ is to help better deploy the maven artifacts [20:43:38] Deskana: done [20:43:51] (03CR) 10Yuvipanda: [C: 032 V: 032] Add deploy config to pom.xml [apps/android/java-mwapi] - 10https://gerrit.wikimedia.org/r/141974 (owner: 10BearND) [20:44:01] Deskana: should propogate through in a while. [20:44:05] YuviPanda: thanks [20:44:15] Deskana: we should add the description to translatewiki.net so our translators can localize it. do you want me to do that now? [20:44:35] (03PS2) 10Yuvipanda: Use release version for MW api: 1.0 [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/142065 (owner: 10BearND) [20:44:42] (03CR) 10Yuvipanda: [C: 032] Use release version for MW api: 1.0 [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/142065 (owner: 10BearND) [20:45:31] YuviPanda: Yes! [20:45:36] brion: re: checking if the URL params show up, the way to do it is to grab someone who can tail all varnish logs (someone from analytics) and ask them to tail it for you when you hit the servers [20:45:40] Deskana: on it [20:45:48] fun! [20:45:52] YuviPanda: Tilman was just going to mark the page on mediawiki as being translatable. [20:45:54] we need a dashboard ;) [20:46:41] Deskana: ah. so if we put it in translatewiki via the app, then if we want to change the description we should do it via a gerrit change. and if we put it on mediawiki you can just follow usual mediawiki workflow. since you will be the person making that change primarily, what do you prefer? [20:47:22] (03Merged) 10jenkins-bot: Use release version for MW api: 1.0 [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/142065 (owner: 10BearND) [20:47:34] I want whatever gets us the faster translations. [20:47:39] What do you think accomplishes that? [20:48:19] Deskana: ah, hmm, I don't know enough about our translation community to answer that, unfortunately, and those who do aren't around right now. Ask Tilman? [20:48:34] Let's just go with the translatewiki solution. [20:48:54] In the absence of any other information, keeping all our translation work in one place makes sense to me. [20:49:04] Deskana: ah, cool. let me do that then. [20:51:54] Deskana: can I remove 'Send us your feedback about the app! In the menu, press \"More\", then \"About the Wikipedia app\", then \"Send app feedback".'? [20:52:05] Deskana: that line is problematic since we have no easy way of telling people which strings to look for there [20:52:37] Deskana: play store already displays the same email. [20:54:02] tfinc_: YuviPanda: about the new entry in https://www.mediawiki.org/w/index.php?title=Mobile/Release_history#Wikipedia. The older ones pointed to the dump server, but the new apks are on releases.wm.o. Ok, to point release.wm.o? [20:54:14] bearND: yeah, dumps redirects to releases [20:54:36] YuviPanda: Yep. [20:54:47] YuviPanda: then I should see the new apks there, too, but there don't show up [20:54:50] they [20:55:08] bearND: ah, hmm. either way, ignore dumps :) [20:55:22] YuviPanda: ok, using releases then [20:57:49] Anyone know where the retrospective notes go on mw.o? [20:58:24] I deleted that from the ehterpad at the start and now I've lost it. [20:58:38] tfinc_: ^ [20:58:42] Deskana: https://www.mediawiki.org/wiki/Wikimedia_Apps/Team [20:58:53] bearND: Thank you! [20:59:03] (03PS1) 10Yuvipanda: Make app store description be translatable [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/142409 [21:00:32] (03CR) 10Yuvipanda: [C: 032] "Trivial copy paste from store description." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/142409 (owner: 10Yuvipanda) [21:02:12] (03Merged) 10jenkins-bot: Make app store description be translatable [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/142409 (owner: 10Yuvipanda) [21:04:36] Deskana: feel free to add more release notes to https://www.mediawiki.org/wiki/Mobile/Release_history#Wikipedia [21:05:41] tfinc_: added 2.0 entry in ^ [21:07:14] Deskana: alright, submitted to translatewiki.net and available for people to translate [21:07:24] Thanks so much YuviPanda! [21:07:26] Deskana: :) [21:07:33] Deskana: bearND I'm going to go off and sleep :) [21:07:57] bearND: I think onboaring should be priority now. with dbrant on abusefilter and me doing nightmode, we should be able to finish up the three big things for this sprint :) [21:08:06] bearND: Deskana anything you guys need from me before I hit the bed? [21:08:14] YuviPanda: sounds good. get some rest! :) [21:08:22] bearND: will do! [21:08:22] nope [21:08:33] YuviPanda: All good for now. Sleep well. [21:09:00] Deskana: alright :) [21:14:51] bearND: thanks [21:18:54] (03PS5) 10Jdlrobson: Add template dependency to Mantle extension [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129335 [21:19:00] (03PS3) 10Jdlrobson: Use Mantle version of Class, eventemitter and View [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129336 [21:19:22] jgonera: kaldari_lunch MaxSem fyi mantle is now live on beta labs and ready to share code. [21:19:40] woo-hoo! [21:21:22] Krinkle and catrope can now begin cannabilising and bringing mobile/flow/ve in sync if they want too [21:22:08] (03CR) 10jenkins-bot: [V: 04-1] Add template dependency to Mantle extension [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129335 (owner: 10Jdlrobson) [21:22:08] (03CR) 10jenkins-bot: [V: 04-1] Use Mantle version of Class, eventemitter and View [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129336 (owner: 10Jdlrobson) [21:22:17] jdlrobson, thanks! [21:23:01] (03CR) 10BearND: "Can it still be translated if this goes into a separate file? Maybe that way we could remove it via a release script, or something like th" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/142409 (owner: 10Yuvipanda) [21:24:03] mhurd: http://stackoverflow.com/questions/13118529/wrong-presentingviewcontroller [21:25:44] mhurd: https://developer.apple.com/library/ios/documentation/uikit/reference/UIViewController_Class/Reference/Reference.html#//apple_ref/occ/instp/UIViewController/definesPresentationContext [21:25:50] (03PS2) 10BearND: Improve appearance of Edit workflow on 2.3 [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/142307 (https://bugzilla.wikimedia.org/67135) (owner: 10Dbrant) [21:25:50] i think it makes some kind of sense…. i think D: [21:25:51] :D [21:28:44] (03CR) 10BearND: [C: 032] Improve appearance of Edit workflow on 2.3 [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/142307 (https://bugzilla.wikimedia.org/67135) (owner: 10Dbrant) [21:37:03] (03Merged) 10jenkins-bot: Improve appearance of Edit workflow on 2.3 [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/142307 (https://bugzilla.wikimedia.org/67135) (owner: 10Dbrant) [22:02:01] (03CR) 10Jdlrobson: [C: 04-1] Change editor switcher to cog icon and move to right side (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/141092 (owner: 10Kaldari) [22:04:02] 3Wikipedia App / 3iOS App: iOS App: Login from the save menu automatically saves - 10https://bugzilla.wikimedia.org/66901#c2 (10Dan Garry) This issue will be resolved by Monte's work on onboarding. [22:06:19] 3Wikipedia App / 3Generic: Android app: Log in form should have buttons on the page for "Log in" - 10https://bugzilla.wikimedia.org/62653#c2 (10Dan Garry) 5NEW>3RESO/FIX Resolved by Bernd's work on these forms last week. [22:07:51] (03PS1) 10MaxSem: Fix fatal in mobileview [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/142436 [22:07:59] Reedy, ^^ [22:09:42] (03PS2) 10MaxSem: Fix fatal in mobileview [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/142436 (https://bugzilla.wikimedia.org/67164) [22:10:39] MaxSem: It can return null now [22:10:55] wat? [22:11:36] if !$target [22:11:44] so it'll return nothing [22:11:51] which is returning void/null/whatever the hell it is php does [22:12:01] rawr [22:12:58] (03PS3) 10MaxSem: Fix fatal in mobileview [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/142436 (https://bugzilla.wikimedia.org/67164) [22:13:28] Maryana: On the line between the back arrow and the rest of the toolbar.... [22:13:58] mm hm? [22:14:23] (03PS4) 10Reedy: Fix fatal in mobileview [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/142436 (https://bugzilla.wikimedia.org/67164) (owner: 10MaxSem) [22:14:29] (03CR) 10Reedy: [C: 032] Fix fatal in mobileview [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/142436 (https://bugzilla.wikimedia.org/67164) (owner: 10MaxSem) [22:15:13] kaldari: whatcha need on that? [22:15:15] I changed it back and forth a couple times as people seem to disagree on it. The last I heard was from jgonera who said that moizsyed wanted to remove the line. [22:15:18] (03Merged) 10jenkins-bot: Fix fatal in mobileview [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/142436 (https://bugzilla.wikimedia.org/67164) (owner: 10MaxSem) [22:15:36] kaldari: yeah, sorry about that. i checked with moiz one more time and he agreed we needed the line [22:15:43] arg [22:15:44] kaldari, so it appears the line should be there, but _only_ in VE overlay where the toolbar is present [22:15:45] just in the VE editing toolbar [22:15:51] kaldari: yeah, but only on this one place [22:16:06] OK. Seems weird to me, but whatever :) [22:16:16] kaldari: yeah, not the best solution :( [22:16:17] kaldari, will you change it? [22:16:19] 3MobileFrontend / 3General/Unknown: Hash gets swallowed by Varnish redirect to mobile site - 10https://bugzilla.wikimedia.org/64918#c14 (10Max Semenik) These are not the hashes you're looking for:P In varnish's terminology, a hash is a cache key. What JS calls a hash is never passed to server. [22:16:33] jgonera: yeah, I'll change it now [22:16:35] it looks weird without it - looks like the arrow is a formatting option (like, "bold, italic, add arrow" or something) [22:16:37] thanks [22:16:45] thanks kaldari [22:21:47] MaxSem: fragments from the Location header are honored. [22:21:54] (03PS1) 10Kaldari: Separate the back arrow from the toolbar in mobile VisualEditor [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/142441 [22:22:05] (03CR) 10jenkins-bot: [V: 04-1] Separate the back arrow from the toolbar in mobile VisualEditor [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/142441 (owner: 10Kaldari) [22:24:08] (03PS2) 10Kaldari: Separate the back arrow from the toolbar in mobile VisualEditor [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/142441 [22:25:15] jgonera: fixed [22:28:32] 3MobileFrontend / 3General/Unknown: Hash gets swallowed by Varnish redirect to mobile site - 10https://bugzilla.wikimedia.org/64918#c15 (10Jon) 5REOP>3RESO/WOR I'm closing this bug. See bug 50517 if you want to discuss this different issue. Original reported issue works fine. [22:43:12] (03CR) 10Kaldari: [C: 04-1] Add article title and an editing indication in VE (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/142165 (owner: 10JGonera) [22:46:21] (03CR) 10Kaldari: Change editor switcher to cog icon and move to right side (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/141092 (owner: 10Kaldari) [23:17:34] (03PS7) 10Kaldari: Change editor switcher to cog icon and move to right side [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/141092 [23:18:15] (03PS8) 10Kaldari: Change editor switcher to cog icon and move to right side [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/141092 [23:19:51] (03PS9) 10Kaldari: Change editor switcher to cog icon and move to right side [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/141092 [23:24:16] (03PS1) 10JGonera: Fix fixed header and keyboard behavior in VE on iOS Safari [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/142456 [23:24:46] kaldari, Maryana and Abbye will want to have this merged for tomorrow: https://gerrit.wikimedia.org/r/#/c/142456/ [23:24:51] (I think) [23:26:47] would be great, yes :) [23:26:53] kaldari, in https://gerrit.wikimedia.org/r/#/c/142165/1/i18n/qqq.json maybe I could write instead "a heading indicating that the user is currently editing". I don't want to marry this too much with page title because then it should be a single message [23:28:21] 3MobileFrontend / 3beta: Error saving settings: ... have cookies enabled - 10https://bugzilla.wikimedia.org/67171 (10Chris McMahon) 3NEW p:3Unprio s:3normal a:3None Created attachment 15755 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15755&action=edit Clicking Save looks OK After logging... [23:28:32] 3MobileFrontend / 3beta: Error saving settings: ... have cookies enabled - 10https://bugzilla.wikimedia.org/67171#c1 (10Chris McMahon) Created attachment 15756 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15756&action=edit Error after clicking Save [23:28:49] (03CR) 10MaxSem: "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/141576 (owner: 10MaxSem) [23:29:32] 3MobileFrontend / 3beta: Error saving settings: ... have cookies enabled - 10https://bugzilla.wikimedia.org/67171 (10Chris McMahon) [23:30:28] jdlrobson, you're not in the office, right? [23:30:32] 3MobileFrontend / 3beta: Error saving settings: ... have cookies enabled - 10https://bugzilla.wikimedia.org/67171#c2 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/jtxt8rEw [23:35:47] jgonera: nope [23:35:53] my house is getting heating [23:36:11] jdlrobson, are you coming tomorrow or on Monday? [23:36:47] jgonera: yup back in tomorrow [23:36:54] YuviPanda|zzz: and co .. https://twitter.com/luke_partin/status/482302081244884992 clap clap [23:42:20] 3Wikipedia App / 3Android App: Localized "Wikipedia" in about screen gets cut off - 10https://bugzilla.wikimedia.org/67173 (10Max Semenik) 3NEW p:3Unprio s:3normal a:3None Created attachment 15757 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15757&action=edit Screenshot on Galaxy SII See t... [23:47:03] (03CR) 10JGonera: Add article title and an editing indication in VE (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/142165 (owner: 10JGonera) [23:50:02] (03CR) 10JGonera: [C: 04-1] Separate the back arrow from the toolbar in mobile VisualEditor (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/142441 (owner: 10Kaldari) [23:50:58] (03CR) 10JGonera: "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129335 (owner: 10Jdlrobson) [23:51:29] jgonera: it might be worth leaving Mantle a week in production and merging that then [23:51:39] just in case there is any weirdness [23:51:42] yep [23:52:01] mhurd: When is the tap to remove chrome thing getting taken out? [23:52:02] tests fail anyway [23:52:07] mhurd: It's still causing me a lot of frustration. [23:52:27] Deskana: hehe this week i hope! [23:52:37] mhurd: Is it this card? https://trello.com/c/MYI1ws6p/43-3-ios-app-scrolling-does-not-automatically-show-hide-search-bar-navigation-buttons [23:52:54] Deskana: that sounds right [23:52:58] The card doesn't really make reference to it [23:52:59] (03CR) 10JGonera: [C: 032] Hygiene: Move message tool out of repository [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/141838 (owner: 10Jdlrobson) [23:53:03] I'll add to the acceptance criteria. [23:53:04] Thanks! [23:53:33] (03Merged) 10jenkins-bot: Hygiene: Move message tool out of repository [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/141838 (owner: 10Jdlrobson) [23:56:38] (03CR) 10JGonera: Separate the back arrow from the toolbar in mobile VisualEditor (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/142441 (owner: 10Kaldari)