[00:00:27] (03CR) 10JGonera: [C: 04-1] Change editor switcher to cog icon and move to right side (033 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/141092 (owner: 10Kaldari) [00:16:20] jgonera: I really have mixed feelings about minifying SVG files. After they are minified, it's a lot harder to edit them by hand (which I commonly do to change colors or the bounding box). It seems like the minifying should be handled by ResourceLoader, not locally, same as any other code. [00:17:51] but I guess until then, maybe we should keep minifying them? [00:19:47] jgonera: Looks like someone already filed a bug for it: https://bugzilla.wikimedia.org/show_bug.cgi?id=63491 [00:22:04] Hmm, looks like SVGO is a bit buggy regardless [00:24:54] kaldari, yeah, it is, that's why for now we have to do it manually I guess [00:25:39] jgonera: I'll see what I can do in the meantime to minify them without breaking anything... [00:27:14] ok [00:27:34] there's a yaml config file .svgo.yaml that disables one breaking transformation [00:27:39] in MF [00:31:47] kaldari, I think that Maryana might want you to merge VE bugfixes before you go back to working on the cog [00:32:14] :) [00:32:33] sure [00:32:46] are those in MF or VE (or both) [00:32:47] ? [00:35:23] (03PS10) 10Kaldari: Change editor switcher to cog icon and move to right side [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/141092 [00:38:23] (03CR) 10Kaldari: Add article title and an editing indication in VE (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/142165 (owner: 10JGonera) [00:45:30] (03CR) 10Kaldari: [C: 032] "Since we're not moving ahead with lazy-loading, this simple solution seems adequate." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/142317 (owner: 10MaxSem) [00:46:05] (03Merged) 10jenkins-bot: Use TOC only when page is supposed to have it [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/142317 (owner: 10MaxSem) [00:49:24] kaldari: i moved this guy (https://trello.com/c/MIEGwVFS/16-2-change-the-x-to-a-back-icon-in-editing-workflow) back to awaiting final cr - feel free to move back to ready for signoff once it gets merged. [00:49:31] anybody need anything else from me before i jet for the day? [00:49:48] ok [00:50:57] going once, going twice… going to target to buy tubes :) [00:50:59] cya [00:53:24] (03PS3) 10Kaldari: Don't nest .overlay-header and .overlay-head-container [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/141570 (owner: 10JGonera) [00:54:21] (03CR) 10Kaldari: [C: 032] Don't nest .overlay-header and .overlay-head-container [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/141570 (owner: 10JGonera) [00:54:30] (03PS6) 10Kaldari: Tweak VE overlay to support mobile context [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/141087 (owner: 10JGonera) [00:55:36] (03Merged) 10jenkins-bot: Don't nest .overlay-header and .overlay-head-container [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/141570 (owner: 10JGonera) [00:57:35] (03CR) 10Kaldari: [C: 032] Tweak VE overlay to support mobile context [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/141087 (owner: 10JGonera) [00:58:10] (03Merged) 10jenkins-bot: Tweak VE overlay to support mobile context [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/141087 (owner: 10JGonera) [01:06:21] (03CR) 10Kaldari: [C: 04-1] Fix fixed header and keyboard behavior in VE on iOS Safari (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/142456 (owner: 10JGonera) [01:35:22] mhurd: we punted put two more cards from Sprint 34 TO DO list [01:35:46] so its going to look much lighter when you filter [01:35:48] vbamba: yay! [01:35:52] :) [01:35:58] vbamba: thx! [05:38:02] 3MobileFrontend / 3General/Unknown: Fatal error: Call to a member function isMainPage() on a non-object in ApiMobileView.php on line 270 - 10https://bugzilla.wikimedia.org/67164#c2 (10Florian) 5NEW>3RESO/FIX New PS by MaxSem and Merged: https://gerrit.wikimedia.org/r/#/c/142436 [08:28:15] YuviPanda: do you know anything about Serbian localization for the Android app? [08:28:22] aharoni: nope. why? [08:28:28] aharoni: is that se? [08:28:32] sr [08:28:42] does Android handle Serbian Latin and Cyrillic somehow? [08:28:52] aharoni: not at all, IIRC [08:28:58] aharoni: *however* [08:29:02] aharoni: if the user is logged in on the app [08:29:06] and set their user preferences on desktop [08:29:10] aharoni: they get it in that variant [08:29:22] accidental feature :) [08:29:27] ok, that works for the content, I guess [08:29:32] what about the UI localization? [08:29:55] aharoni: same situation as before. if their phone ships with it they can switch to it, otherwise they can't [08:30:49] YuviPanda: on my tabled it's only Cyrillic [08:30:56] aharoni: right, so that's what we'd get, I guess [08:30:57] unless there's some hidden preference somewhere [08:31:01] don't think so [08:32:13] which is preposterous given that there four variants of French [08:32:21] AND NINE VARIANTS OF BLOODY ENGLISH [08:32:49] but anyway, I personally like Cyrillic more, so I am not complaining ;) [08:32:51] aharoni: didn't you know, the US is the only country that exists, and everyone there came from Europe [08:33:19] aharoni: I'm going to say that the only way to properly fix this to bring it up to MW standards is to write our own [08:33:23] Except the awesome Cherokees, who bothered to add their language to iPads :) [08:33:33] anyway, [08:33:47] aharoni: so it's a matter of will and resources and time. [08:33:57] yesterday a Serbian user said that he cannot translate to Serbian, which is odd, because I seem to be able to do it. [08:34:26] actually, let me move it to -i18n [09:09:32] 3Wikipedia App / 3Android App: Redirects to main page (WP:MAIN) appear empty - 10https://bugzilla.wikimedia.org/65880#c2 (10Liangent) 5NEW>3RESO/FIX Yeah this is fixed. [09:13:39] YuviPanda: "Last updated %s" [09:13:51] aharoni: right. [09:14:01] aharoni: so that date is formatted by android, and I was naively expecting it to use the UI locale [09:14:09] is %s like "2014-06-19" or like "seven days ago"? [09:14:19] and in what language? [09:14:35] aharoni: should be in local language, and latter for some and former for some, depending on how long ago it was [09:14:39] aharoni: can you check on your tablet? [09:14:47] 3MobileFrontend / 3Feature requests: Include /* section title */ in edit summary for mobile section edits - 10https://bugzilla.wikimedia.org/60134#c14 (10Florian) Any progress? I prefer the App solution. [09:14:59] it's odd, I'm pretty sure I checked, but people report problems [09:16:28] WTF. [09:16:32] aharoni: oh? [09:16:54] oh, I'm an idiot, I changed the language :) [09:16:59] let me change back to Hebrew [09:17:06] oh no no no [09:17:09] I am in Hebrew [09:17:14] what on Earth is going on [09:17:44] YuviPanda: I have Wikipedia app version 2.0 [09:17:51] my device language is Hebrew [09:17:58] and all the app UI is English [09:18:21] aharoni: hmm, that's weird. you didn't have this problem with the APKs I sent you. [09:18:27] aharoni: also do you have version 2.0 or 2.0.1? [09:18:30] 2.0 [09:18:42] aharoni: hmmm. check the beta app? [09:19:02] hmhmhmmhhmmhhmhm I don't know how [09:19:12] I signed up for some beta program in the past [09:19:21] I think that the app updated itself to 2.0 [09:19:30] I don't quite know how to get the beta app [09:19:48] maybe it's an iw/he problem again? [09:20:15] aharoni: worked for me when I tried yesterday [09:20:32] can you check it now by switching the device language to he? [09:20:35] aharoni: you get the beta app by installing https://play.google.com/store/apps/details?id=org.wikipedia.beta [09:23:35] YuviPanda: while I'm checking that, another thing: [09:23:37] https://translatewiki.net/w/i.php?title=Special:Translations&message=Wikimedia%3AWikipedia-android-strings-last+updated+text%2Fhe [09:23:47] it's probably wrong that some languages have %1$s [09:24:44] aharoni: right. they should have %s [09:24:52] aharoni: it was initially %1$s but we switched on english to %s [09:24:57] java works with either but %s is easier to translate [09:26:08] existing messages with %1$s should probably be fuzzed, but ask Niklas, Siebrand or Raimond about the best strategy [09:27:44] aharoni: yeah. I wish there's a way to fuzz things mass easily [09:28:01] YuviPanda: there may be such a way. ask them. [09:28:06] also, does this make sense? - https://translatewiki.net/w/i.php?title=Wikimedia:Wikipedia-android-strings-last_updated_text/qqq&diff=prev&oldid=5609942 [09:29:13] ah, now I have both 2.0 and 2.0-beta-2014-06-25 [09:29:16] nicey, should be useful [09:29:24] beta is properly localized. 2.0 is not. [09:29:56] aharoni: that's... weird [09:33:49] 3Wikipedia App / 3Android App: Wikipedia Android App 2.0 doesn't show Hebrew localization - 10https://bugzilla.wikimedia.org/67190 (10Amir E. Aharoni) 3NEW p:3Unprio s:3major a:3None On my Android 4.2.1 tablet I have both Wikipedia 2.0 and Wikipedia 2.0-beta-2014-06-25. My tablet language is Hebrew.... [10:13:23] YuviPanda, rechecking - does this make sense? - also, does this make sense? - https://translatewiki.net/w/i.php?title=Wikimedia:Wikipedia-android-strings-last_updated_text/qqq&diff=prev&oldid=5609942 [10:13:43] yes, aharoni [10:13:50] cool, thank you [10:14:00] :) [11:35:59] is action=mobileview cached? [11:39:48] (from app's view) [11:55:27] liangent: yeah, for anons [12:30:39] (03PS1) 10Yuvipanda: [WIP] Implement night mode for content [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/142512 [12:33:47] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Implement night mode for content [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/142512 (owner: 10Yuvipanda) [12:43:29] YuviPanda: does that stop OLEDs ? :-D [12:43:35] hashar: yeah, should. [12:43:44] YuviPanda: just because of #000 color? [12:43:50] hashar: theoretically [12:44:04] and 2019 is the future https://gerrit.wikimedia.org/r/#/c/142512/1/wikipedia/res/values/last_updated.xml [12:44:04] :D [12:44:47] hashar: :D yeah, to prevent it from downloading styles from bits and using those instead in the meantime :) [12:45:00] :D [14:09:23] (03CR) 10Dbrant: [C: 032] Make background lighter in site selection list item [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/141645 (owner: 10BearND) [14:18:08] (03PS1) 10Dbrant: Don't duplicate history entry if the same item is clicked twice. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/142525 (https://bugzilla.wikimedia.org/66760) [14:19:47] hey dbrant! [14:19:49] how's chicago? [14:20:52] YuviPanda: very good! haven’t had a chance to get out yet, though. I’ll go later today [14:21:40] YuviPanda: it’s full of really insane drivers. [14:21:55] dbrant: haha! [14:22:07] dbrant: I heard that as well from marktraceur and Ironholds, who were in Chicago a few days ago [14:22:29] oh man i hate driving there [14:22:43] Oh gods it's terrible. [14:22:44] i always get lost on those double-decker streets [14:22:47] We were actually there yesterday [14:22:58] But only until about 07:00, when we crossed into Indiana [14:23:07] nice [14:23:18] dbrant: Sorry we didn't know you were around! [14:23:41] Or did and then failed to plan, or something [14:23:54] I can't be relied upon to plan things on the Internet [14:24:01] no worries; I’m only here until this evening anyway :( [14:24:29] Ah, yeah [14:24:48] hey vbamba! I've a base nightmode working! :) Can I send you a build, and you can tell me what other colors to use? We need about 3 more colors (Infobox background, link colors and table header colors) [14:28:02] (03PS1) 10Dbrant: Hide keyboard when exiting interlanguage activity. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/142528 [14:29:25] (03Abandoned) 10Dbrant: Properly load saved pages from History. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/140735 (https://bugzilla.wikimedia.org/66818) (owner: 10Dbrant) [15:20:08] (03PS2) 10Yuvipanda: [WIP] Implement night mode for content [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/142512 [16:25:06] MaxSem: YuviPanda: question: if an attempted edit comes back with “abusefilter-warning”, what should I put in the subsequent request to “accept” the warning and confirm the edit? [16:25:35] dbrant: you don't really need to do anything, IIRC. Just sending it again should work [16:26:29] YuviPanda: ah… I didn’t check the ‘trivial’ case. [16:27:02] dbrant: :) [16:31:07] (03PS1) 10Dr0ptp4kt: If untagged traffic hits zerodot, send it to http://. [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/142566 [16:33:34] ^ yurik, would you please review and, if appropriate, +2? this is to cover the card 'If zero-dot https fails, bounce to http'. i don't think we should try to be any fancier than this. [16:40:49] Greetings @dbrant @bearND [16:41:03] vbamba: hello! [16:41:17] hello vbamba [16:41:20] YuviPanda: vbamba: what font should i use for the text in the middle of https://trello.com/c/Oz5u8zVU/15-2-first-time-ux-onboarding? [16:42:04] bearND: I'll let vbamba figure that out :) [16:42:32] YuviPanda: I assume we don't have that in Android so probably using a WebView [16:42:39] bearND: what, no. [16:42:42] bearND: just use Roboto? [16:42:47] bearND: that should definitely not be a webview, no. [16:43:07] for Wikipedia - The Free Encyclopedia [16:43:32] bearND: let's just use Roboto for now, and if completely necessary we can bundle that font into Android (but unnecessary I'd think) [16:43:43] YuviPanda: ok [16:43:47] for 'The Free Encyclopedia' ? [16:43:55] vbamba: yes [16:44:04] Noooo! Brand Destruction!! [16:44:14] Thats Linux Libertine or Hoeffler Text [16:44:17] One sec [16:44:20] vbamba: I don't want to use an image. it's an I18N nightmare [16:44:30] do not use roboto [16:45:01] YuviPanda: ^ oh oh [16:45:07] vbamba: bearND right, let's bundle that font then, but we can do that at the end. Let's not use a webview though. [16:45:17] YuviPanda: all right [16:45:22] bearND: cool [16:45:49] bearND: dbrant in general, I think we shouldn't use webviews *anywhere* unless we are showing arbitrary HTML that came from elsewhere. [16:46:21] vbamba: around? wanna hangout to chat about nightmode sometime soon? [16:48:08] YuviPanda: ok, was just a thought since i wasn't thrilled about bundling a font just for a first use screen [16:48:30] bearND: me neither, but how does adding a webview fix it? [16:48:50] YuviPanda: so it looks like when I re-send the edit after “abusefilter-warning”, it just comes back with “”abusefilter-disallow”… [16:48:59] …unless i’m not triggering it properly [16:49:13] 'The Free Encyclopedia' is set in Linux Libertine. I ran a type test with the latest official marks. [16:49:20] Can i sent you the otf/ ttf files? [16:49:30] bearND: let's do the interface first in one commit, and then the font bundling in another, and see the impact on apk size and decide based on that data? [16:49:51] Gentlemen, I have emailed the font files to you, just in case. [16:49:53] dbrant: hmm, that's weird. maybe brion knows? [16:49:59] vbamba: ok [16:50:01] YuviPanda: ok [16:50:14] vbamba: around? wanna hangout to chat about nightmode sometime soon? [16:50:26] ? [16:52:03] brion: I’m testing abuse-filter functionality, and my question was: when I receive an API response that contains “abusefilter-warning”, what should be the proper subsequent request to the API to accept the warning and confirm the edit? [16:52:19] no clue :) [16:52:37] MaxSem: ^ [16:54:52] looking at AbuseFilter’s hook….. i’m not sure i see an override :D [16:54:53] maybe it’s hiding [16:57:30] (03PS1) 10Mhurd: Retooled modal presentation. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/142577 [17:01:56] (03PS2) 10Dr0ptp4kt: If untagged traffic hits zerodot, send it to http://. [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/142566 [17:03:43] ^ yurik, i added the bit about only autoredirecting to mdot if config is actually enabled. this additionally addresses the card 'feature - for zero-only partners, banners appear on mdot. Enabling is per-partner.' [17:33:41] YuviPanda: yes around [17:33:47] can we do this after story prioritization please? [17:37:04] 3Wikipedia App / 3iOS App: Last Modified date is off by timezone offset - 10https://bugzilla.wikimedia.org/67204 (10Brion Vibber) 3NEW p:3Unprio s:3normal a:3None A page I just edited says "Last Modified 7 hours ago" in PDT timezone (UTC-7). Something's calculating timestamps in local time instead of... [17:37:36] vbamba: sure [17:38:17] 3Wikipedia App / 3iOS App: "last modified" timestamp offsets by timezone instead of showing actual time since edit - 10https://bugzilla.wikimedia.org/66884#c1 (10Dan Garry) *** Bug 67204 has been marked as a duplicate of this bug. *** [17:38:17] 3Wikipedia App / 3iOS App: Last Modified date is off by timezone offset - 10https://bugzilla.wikimedia.org/67204#c1 (10Dan Garry) 5NEW>3RESO/DUP Duplicate. :-) *** This bug has been marked as a duplicate of bug 66884 *** [17:38:52] i just emailed this guy to see if he want to be on the testflight list : http://ampersandsoftworks.com/wikipedia-mobile-ios-critique/ [17:39:50] (03CR) 10Brion VIBBER: "Adding a URL that's on the spam blacklist (eg "http://bit.ly") doesn't get caught on save, causing the save to silently fail and lose data" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/142577 (owner: 10Mhurd) [17:43:32] (03CR) 10Brion VIBBER: "Ok confirmed that URL bug is not new in this rev. :D" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/142577 (owner: 10Mhurd) [17:44:04] @YuviPanda @dbrant Did we just leave out 'tap to top' on Android? [17:44:10] Shd I file a bug for it? [17:45:00] vbamba: no, it's an iOS behavior, doesn't really exist on Android anywhere [17:45:06] vbamba: don’t recall discussions about that… where should the tap be? [17:45:24] vbamba: and I think you get that for free on Android, and not really on Android. we should let that be, I think. [17:45:39] err, 'you get that for free on iOS' [17:45:42] said android twice [17:45:45] dbrant: ^ [17:49:38] Do we have to have Fly Wheel or something enabled? Scrolling to the top in a long article on Android is quite slow [17:49:46] http://cyrilmottier.com/2013/01/09/back-to-top-android-vs-ios/ [17:50:53] vbamba: so if you do a fast fling it scrolls all the way to the top. or you can tap on the article title in the ToC. [17:58:51] (03CR) 10Brion VIBBER: "(inline note about selector checks, maybe switch to protocols in future to help the compiler if we can resolve)" (031 comment) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/142577 (owner: 10Mhurd) [17:59:00] (03CR) 10Brion VIBBER: [C: 032 V: 032] Retooled modal presentation. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/142577 (owner: 10Mhurd) [18:02:20] YuviPanda: dbrant missing you on the hangout [18:02:36] tfinc: hmm? says in one hour... [18:03:10] tfinc: joining [18:03:55] YuviPanda: nope. your clock is off. we missed you at the standup up too. please mail in your status [18:04:07] tfinc: augh, gah. will do. sorry. [18:23:44] (03PS1) 10Cmcmahon: QA: increase polling time to prevent flaky timeout [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/142605 [18:33:31] (03PS1) 10Dr0ptp4kt: Hide Watchlist thumbnails on zerodot. [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/142609 [18:36:23] dbrant: usually in these kinda meetings if you keep talking someone else stops quite quickly :) [18:37:01] YuviPanda: lol it’s ok, my connection is really poor [18:37:08] dbrant: ah :) [18:37:23] dbrant: unsure if I've done a meeting from a bus/train/road since you guys have joined :) [18:41:00] Deskana: would you add me to the new board? [18:42:26] bearND: Done. [18:42:42] Deskana: ty :) [18:50:50] Deskana: hey! [18:50:56] Deskana: 59839 users had saved pages in the old app [18:51:05] Deskana: 5.4 saved pages on average per user :) [18:52:00] YuviPanda: Do you happen to know the highest number of saved pages one person had? [18:52:06] YuviPanda: The range of values? [18:52:10] Deskana: sure. [18:52:11] Deskana: moment [18:52:18] YuviPanda: <3 [18:52:53] Deskana: 205 [18:53:46] Deskana: 8000 users more than 10 [18:54:07] YuviPanda: How many have more than 50? [18:54:42] Deskana: 643 [18:55:05] YuviPanda: What's the size of the dataset? How many people in it? [18:55:34] Deskana: 59839 users who had at least one. [18:57:30] Deskana: total of 321419 saved pages across all those. [18:57:46] Deskana: out of 10 million total installs [18:58:07] Deskana: only 3 people had more than 200 [19:00:22] Deskana: you should get stat access soon :) [19:00:45] Deskana: now that I'm here might as well check on edit numbers [19:03:34] Deskana: 38,000 people have tapped an edit pencil, but only 4,200 went on to preview, and 2,250 saved. not sure if good or bad ;( [19:03:51] Deskana: awight is working on instrumenting this on desktop as well, btw. [19:05:01] Deskana: ok, not 'people', impressions. [19:06:53] vbamba: hey! wannna do meeting at 1pm? [19:21:16] (03PS3) 10Yurik: If untagged traffic hits zerodot, send it to http://. [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/142566 (owner: 10Dr0ptp4kt) [19:21:18] (03PS2) 10Yurik: Contextize PageRenderingHooks [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/142029 (owner: 10MaxSem) [19:23:55] dr0ptp4kt, updated your patch a bit, could you take a look? i will test it for a bit too [19:24:23] MaxSem, i rebased your patch off of that one, will commit them once we check that dr0ptp4kt's works [19:26:29] dr0ptp4kt, also, why not use js for https://gerrit.wikimedia.org/r/#/c/142609/1/includes/PageRenderingHooks.php [19:28:35] yurikR: the watchlist is an html feature usable by both javascript and non-javascript clients. i'll look at 142566 [19:43:54] MaxSem, btw, are all the hook changes you did for zero in production? [19:45:17] kaldari: did you steal the CSS is awesome mug again? >:( [19:45:33] not this time [19:47:09] (03CR) 10Brion VIBBER: "fix coming..." (032 comments) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/141926 (owner: 10Brion VIBBER) [19:47:19] (03CR) 10Mhurd: "Added Small comments." (032 comments) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/141763 (owner: 10Brion VIBBER) [19:50:06] (03PS3) 10Yurik: Contextize PageRenderingHooks [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/142029 (owner: 10MaxSem) [19:50:13] (03PS5) 10Brion VIBBER: EventLogging opt-out switch [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/141926 [19:50:45] MaxSem, ^^ is due to getConfig() needing a new func name [19:52:22] (03CR) 10Mhurd: [C: 032 V: 032] "Yay!" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/141926 (owner: 10Brion VIBBER) [19:55:16] (03CR) 10Dr0ptp4kt: [C: 032 V: 032] If untagged traffic hits zerodot, send it to http://. [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/142566 (owner: 10Dr0ptp4kt) [19:55:29] (03Merged) 10jenkins-bot: If untagged traffic hits zerodot, send it to http://. [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/142566 (owner: 10Dr0ptp4kt) [19:57:12] yurikR: +2'd your rev on 142566 [19:58:40] dr0ptp4kt, did you test it? :) [20:00:37] yurikR: i did on localhost [20:00:45] oki [20:13:44] (03PS3) 10Yuvipanda: [WIP] Implement night mode for content [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/142512 [20:14:27] (03PS7) 10Brion VIBBER: adding edit protection fields [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/141763 [20:16:22] (03PS1) 10MaxSem: Improve tests isolation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/142639 [20:17:43] (03CR) 10Mhurd: [C: 032 V: 032] "Merge!" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/141763 (owner: 10Brion VIBBER) [20:17:58] (03PS2) 10Brion VIBBER: Update W0 flourishes based on UX feedback for MVP. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/141852 (owner: 10Dr0ptp4kt) [20:18:08] ^ rebase [20:18:35] brion: thx [20:18:45] monte’s looking it over now [20:18:58] brion + mhurd thx [20:19:03] :D [20:24:50] dr0ptp4kt: hey have a sec? [20:24:59] mhurd: yeah, whatup [20:25:52] so the patch looks good, but when i went to the “W” menu and unchecked “warn me when leaving 0” it still warned me. is that setting no longer hooked up, or is it even needed? [20:28:19] dr0ptp4kt: ^ [20:29:52] (03CR) 10Mhurd: "So the patch looks good, but when i went to the “W” menu and unchecked “warn me when leaving 0” it still warned me." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/141852 (owner: 10Dr0ptp4kt) [20:31:04] yuvipanda: I can meet now [20:31:51] mhurd: hm, i'll check. it was working, but this may be some oddity [20:32:27] dr0ptp4kt: i was using the fake flag in the web view controller’s memory warning method [20:33:01] dr0ptp4kt: is maybe the fake flag somehow disrespecting the setting but the normal handling respecting it? [20:34:55] (03PS4) 10Yurik: Contextize PageRenderingHooks [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/142029 (owner: 10MaxSem) [20:35:18] yurikR, any problems wth that patch? [20:35:38] MaxSem, i had to rename getConfig() - otherwise it overrode the base [20:35:47] :P [20:35:51] it might have worked, but could have caused issues [20:36:05] MaxSem, how old are the changes to all the hooks? [20:36:18] have they been done a while ago (i'm too lazy to track each one :)) [20:36:31] old enough [20:37:10] MaxSem, in other words - if i depl on wed, would any of the hooks fail because there is an extra param required by the callee [20:37:17] nah [20:37:18] that is not being supllied [20:37:19] ok [20:37:31] I didn't change anything to get that commit done [20:37:42] mhurd: toggling it off for me made it so that on top of the external link i didn't get a warning. this was on article "Richard Middleton (musicologist)", tapping on "Prof. Richard Middleton" in the External Links section. want to retry? maybe reset simulator, if that isn't too painful [20:38:33] (03CR) 10Yurik: [C: 032] Contextize PageRenderingHooks [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/142029 (owner: 10MaxSem) [20:38:45] (03Merged) 10jenkins-bot: Contextize PageRenderingHooks [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/142029 (owner: 10MaxSem) [20:38:57] thanks yurikR :) [20:39:20] i'll wait for it to blow up betalabs [20:39:36] dr0ptp4kt, so run https://gerrit.wikimedia.org/r/#/c/142609/1/includes/PageRenderingHooks.php by me again pls [20:39:47] why do we want that? [20:40:34] yurikR: the watchlist images are showing on zerodot, because they're loaded via the background-image style, not an tag [20:40:59] dr0ptp4kt, sorry, what is a watchlist image? an icon? [20:41:32] yurikR: a thumbnail [20:44:12] mhurd: s/top/tap/ [20:44:57] dr0ptp4kt: oh sry will try again… just a sec... [20:47:15] dr0ptp4kt: huh. that time it respected the setting... [20:47:22] dr0ptp4kt: close enough? [20:47:37] mhurd: probably :) [20:47:48] brion: i think adam’s patch is good. merge? [20:47:56] go for it! [20:48:35] mhurd: dr0ptp4kt: did we switch the verbiage from article to page? [20:49:40] brion & mhurd - not sure if that was resolved on a broader level. [20:50:10] hmmm [20:50:12] brion: dr0ptp4kt i don’t know what product want to do. i like article personally [20:50:28] let’s merge it with a note that we’re still under discussion on that bit i guess [20:50:47] mhurd: dr0ptp4kt siebrand will -1 anything using page, IIRC. He even removed GettingStarted from getting translated at one point when it kept using article. Just to keep in mind [20:50:57] Yep [20:51:15] yuvipanda: k. i think we’re using article everywhere in ios app presently [20:51:42] If you look at GettingStarted you can see how we got around it by setting special messages for Wikipedias only [20:51:46] and using page as default [20:52:12] whee [20:52:27] (03CR) 10Mhurd: "Huh, now the "don't warn" setting seems to be respected. I may have had a crufty build..." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/141852 (owner: 10Dr0ptp4kt) [20:52:51] yuvipanda: oh wait… he’ll -1 anything using page or article? [20:52:57] mhurd: using 'page' [20:53:03] mhurd: gah [20:53:05] mhurd: I meant using 'article' [20:53:11] * yuvipanda is growing old, mistyping things [20:53:31] yuvipanda: oh… gah! [20:53:42] (03CR) 10Brion VIBBER: [C: 032 V: 032] "Ok let's go ahead and merge this. Siebrand, note that we use "article" in many places in the iOS Wikipedia app currently (and we don't hav" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/141852 (owner: 10Dr0ptp4kt) [20:53:43] Deskana: ^ [20:53:53] Deskana: page vs article fun [20:54:50] (03PS2) 10JGonera: Fix fixed header and keyboard behavior in VE on iOS Safari [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/142456 [20:54:55] whee [20:55:04] kaldari, elaborated in the comment ^ [20:55:35] mhurd + brion thx [20:55:36] (03CR) 10jenkins-bot: [V: 04-1] Fix fixed header and keyboard behavior in VE on iOS Safari [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/142456 (owner: 10JGonera) [20:55:45] dr0ptp4kt: thank you too! [20:55:48] :) [20:56:25] (03CR) 10Kaldari: [C: 032] Fix fixed header and keyboard behavior in VE on iOS Safari [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/142456 (owner: 10JGonera) [20:56:33] (03CR) 10jenkins-bot: [V: 04-1] Fix fixed header and keyboard behavior in VE on iOS Safari [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/142456 (owner: 10JGonera) [20:57:28] (03PS2) 10JGonera: Add article title and an editing indication in VE [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/142165 [20:58:24] yuvipanda: https://meta.wikimedia.org/wiki/Schema:MobileWikiAppEdit doesn’t define an enum schema for ‘editSummaryTapped’ but the Android code seems to reduce them to symbolic names, with an exception if something new is called [20:58:27] should that go in the schema? [20:58:47] brion: yeah, it should. reason being it was too close to the launch and touching that would've caused issues for the revID :( [20:58:53] heh [20:58:58] brion: can you use the same ones? I'm assuming the summaries are the same [20:59:16] hey vbamba [20:59:18] (03PS3) 10JGonera: Fix fixed header and keyboard behavior in VE on iOS Safari [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/142456 [20:59:30] yuvipanda: yeah i think i can [20:59:33] kaldari, rebased ^ [20:59:39] brion: cool. document it in the code as well [20:59:50] (03CR) 10Kaldari: [C: 032] Fix fixed header and keyboard behavior in VE on iOS Safari [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/142456 (owner: 10JGonera) [21:00:30] (03Merged) 10jenkins-bot: Fix fixed header and keyboard behavior in VE on iOS Safari [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/142456 (owner: 10JGonera) [21:00:55] (03PS1) 10Mhurd: Protect css from being overwritten by zero byte response. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/142721 [21:00:58] brion: ^ [21:01:28] yuvipanda: added a note at https://meta.wikimedia.org/wiki/Schema_talk:MobileWikiAppEdit#Schema_missing_enum_for_editSummaryTapped also :D [21:02:00] (03CR) 10Brion VIBBER: [C: 032 V: 032] Protect css from being overwritten by zero byte response. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/142721 (owner: 10Mhurd) [21:03:04] yuvipanda: another question — do we send that only when tapping or also when untapping? [21:03:34] eg is this a ‘pushed the button’ or a ‘actually used it to save with'? [21:03:44] brion: both [21:04:33] ok [21:10:09] (03PS1) 10Brion VIBBER: Update EventLogging edit funnel [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/142724 [21:13:15] (03PS2) 10Brion VIBBER: Update EventLogging edit funnel [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/142724 [21:13:29] jdlrobson, kaldari do we have watchlist click tracking? https://meta.wikimedia.org/wiki/Schema_talk:MobileWebClickTracking#Watchlist_click_tracking says we do but I can't find it in code [21:13:49] (03CR) 10Mhurd: [C: 032 V: 032] "Looks good." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/142724 (owner: 10Brion VIBBER) [21:14:59] jgonera: Looks like there's some code around lines 20-25 in javascripts/speciesl/watchlist.js [21:15:39] kaldari, ah, ok, I grepped for the full name but it's concatenated, thanks [21:15:40] jgonera: kaldari: yup should go to MobileWebClickTracking [21:17:44] hey vbamba [21:17:52] hey yuvipanda [21:17:58] oh youre here [21:18:03] vbamba: I am :) [21:18:21] I havent had any time to investigate dark mode setting [21:18:27] lets talk on Monday [21:18:27] ? [21:18:35] vbamba: ah, that's ok. I just wanted to talk about colors so we can do that on Monday as well. [21:19:28] vbamba: can you setup a calendar invite and things so we don't end up missing eachother again? [21:20:00] Maryana, it seems we do have EL data on watch/unwatch actions [21:20:26]