[05:47:03] 3Wikipedia App / 3Android App: language list in the android app is aligned to far to the right in Hebrew - 10https://bugzilla.wikimedia.org/66918#c3 (10Dan Garry) 5PATC>3RESO/FIX Seems fixed on my build. [06:03:11] (03PS1) 10Mhurd: Fixes for page history and language selector crashes. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/142988 [06:05:20] (03PS2) 10Mhurd: Fixes for page history and language selector crashes. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/142988 [13:34:09] (03PS1) 10Dbrant: [WIP] Abusefilter changes in Edit workflow. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/143024 [14:29:45] (03CR) 10Cmcmahon: "Also see Bug 63620" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/142605 (owner: 10Cmcmahon) [14:59:32] Hi YuviPanda dbrant|brb: I'm thinking of turning CreateAccountActivity and LoginActivity into fragments to help transitions between Login and CreateAccount via the links to not cause a long list of activities, like Login > CreateAccount > Login > CreateAccount > … Any thoughts? Concerns? [15:02:02] 3MobileFrontend / 3stable: Filter for New User uploads in Mobile Web - 10https://bugzilla.wikimedia.org/62598#c45 (10Florian) If i'm right, it's still online :) [15:15:56] bearND: why is that a problem? [15:17:35] YuviPanda: it would be bad for the backstack. The user would have to press back a lot [15:17:47] bearND: ah, hmm.. [15:18:13] YuviPanda: it's because the design adds links between login and create account [15:18:17] back and forth [15:18:31] bearND: so, one way to fix this is to do a finish() as soon as you call startActivity() [15:18:37] so there won't be a long stack [15:18:45] bearND: what do you think of that? [15:19:01] fragments bring their own complexities, and I'd avoid them if back is the only rationale [15:19:38] YuviPanda: i think that could work [15:19:47] YuviPanda: Thanks [15:19:50] bearND: :D [15:35:32] 3MobileFrontend / 3Feature requests: Add default styling for tables (CSS for file description page for "File history" and "Metadata" tables) - 10https://bugzilla.wikimedia.org/49959 (10Florian) [15:35:33] 3MobileFrontend / 3Feature requests: Table borders are always shown - 10https://bugzilla.wikimedia.org/37222#c5 (10Florian) Caused by: Ib3376651b8bbca3fb5b5ff8e3020efc435be0408 (before moving content css from common to content) See: https://bugzilla.wikimedia.org/show_bug.cgi?id=49959 [15:52:42] YuviPanda: bearND: so, i'm no longer able to compile the app :( [15:53:12] dbrant: oh? [15:53:14] what happened [15:54:30] it started with something having to do with no longer being able to find java-mwapi (but it was clearly there)... so I ended up clearing everything out and starting fresh, and now Maven seems to have trouble downloading all the dependencies. [15:55:18] dbrant: oh... bearND updated java-mwapi online a while ago, maybe that went awry... [15:55:28] dbrant: can do do a maven install on java-mwapi in your machine? [15:57:00] YuviPanda: yes, that works fine, but then building the app still fails. How do I force Maven to re-download dependencies? [15:57:24] dbrant: rm -rf ~/.m2 is the way I do it [15:58:59] dbrant: from command line add -U to the mvn install command [15:59:09] ah, less destructive :) [15:59:34] I'm getting this error: [15:59:38] [ERROR] Failed to execute goal on project wikipedia: Could not resolve dependencies for project org.wikimedia:wikipedia:apk:1.0-SNAPSHOT: Failed to collect dependencies at android:android:jar:4.4_r1: Failed to read artifact descriptor for android:android:jar:4.4_r1: Could not transfer artifact android:android:pom:4.4_r1 from/to tools-repository (https://tools.wmflabs.org/android-maven-repo/): Failed to transfer file: https://to [15:59:38] ols.wmflabs.org/android-maven-repo/android/android/4.4_r1/android-4.4_r1.pom. Return code is: 503 , ReasonPhrase:Service Temporarily Unavailable. -> [Help 1] [16:00:05] dbrant: it shouldn't point to the SNAPSHOT anymore [16:00:07] aaaha [16:00:12] let me go check *that* [16:00:21] oh wait that was for the apk [16:00:24] looks like related to the tools outage yesterday [16:00:54] started that service on tools. try again? [16:00:55] dbrant: ^ [16:01:39] YuviPanda: nope... [16:01:53] dbrant: hmm, let me try. [16:22:33] dbrant: hmm, works for me?} [16:23:11] YuviPanda: what are your exact steps? [16:23:23] dbrant: go to wikipedia repo, do 'mvn -U package' [16:23:30] dbrant: actually, I don't remember if I'm on latest master. let me rebase [16:24:17] YuviPanda: in the browser i also get this https://tools.wmflabs.org/android-maven-repo/android/android/4.4_r1/android-4.4_r1.pom [16:24:38] … is not currently serviced [16:25:30] and curl: HTTP/1.1 503 Service Temporarily Unavailable [16:26:16] bearND: hmm, that mi ght be the issue. let me go see what's up with that [16:30:47] dbrant: bearND so labs is having some issues which is causing that URL to die. [16:31:48] dbrant: should be up in another 20-30m, I'm afarid [16:31:57] YuviPanda: how do you usually debug these kinds of issues? Just curious since I'm also added as one of the maintainers of the maven repo [16:32:19] bearND: usually just hanging out in #wikimedia-labs and asking people :D [16:32:19] :( [16:32:25] bearND: so there's general labs issues going on [16:32:34] bearND: it's slightly different in my case since I'm also an admin of toollabs, so have root. [16:33:02] YuviPanda: ah, thanks [16:35:28] YuviPanda: I ran into a problem with finishing the old login activity when starting the create account activity: onActivityResult is not called anymore [16:36:14] bearND: where? in LoginActivity? [16:36:22] YuviPanda: yes [16:37:10] bearND: ah, hmm. so that's going to be a problem anyway. [16:37:28] bearND: also, if the user went to create account from login, wouldn't they expect to see 'login' when they hit back? [16:37:44] dbrant: ^ thoughts? [16:38:53] yes, I would think so. [16:39:10] bearND: so... I'd say current behavior is 'expected' behavior. [16:40:05] Hey mobile nerds [16:40:15] YuviPanda: what do you mean with current behavior? what's on master or what I've got (where i finish the old activity) [16:40:38] Is there a bug for requesting cross-device login sessions, i.e. not getting logged out of desktop if I login from mobile? [16:41:02] StevenW: is that related to the ‘remember me’ checkbox? [16:41:24] No, this impacts login sessions in general AFAIK [16:41:36] then there should not be such a bug…. scary! [16:42:15] bearND: as in, you are in login, you tap 'create account' and when if you hit back you see 'login', and if you succeed you see login but you are being logged in [16:42:38] StevenW: works for me (Safari on my desktop is still logged in after logging in on mobile on my iPhone) [16:42:46] is there a specific workflow that you can reproduce the bug with? [16:43:17] YuviPanda: yes, but that mean I can't just finish the LoginActivity when i start the CreateAccountActivity [16:43:29] bearND: yeah, so don't do that? [16:44:39] brion: a user asked on an unrelated bug. They were asked to file a new one, but I thought there might be an existing one. [16:44:45] If not, they should file. :) [16:45:29] ah, a third-party bug-by-proxy :D [16:47:29] StevenW: so as far as I know, there should be no way for logins on separate devices to interfere with each other, unless they’re stomping on each others’ “remember me” cookie because there’s only one browser that can be remembered at a time [16:48:01] that must be it then [16:49:25] (03CR) 10Brion VIBBER: [C: 032 V: 032] Credits: "HPPLE" --> "Hpple" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/142809 (owner: 10Legoktm) [16:49:52] (03CR) 10Brion VIBBER: [C: 032 V: 032] Use "Content" instead of "Wiki text" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/142811 (owner: 10Legoktm) [16:50:23] YuviPanda: success! [16:50:45] dbrant: woot [16:53:43] (03CR) 10Brion VIBBER: [C: 032 V: 032] Fixes for page history and language selector crashes. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/142988 (owner: 10Mhurd) [16:54:13] awjr: you about in the office ? [16:55:13] 3Wikipedia App / 3iOS App: iOS App: Viewing page history kills app - 10https://bugzilla.wikimedia.org/67255#c1 (10Brion Vibber) 5NEW>3RESO/FIX This should be fixed by https://gerrit.wikimedia.org/r/#/c/142988/ [16:56:50] YuviPanda: how can I make a screenshot to demonstrate an issue in GB? [16:57:30] that system is cyanogenmod 7 [16:59:55] (03PS1) 10Dbrant: Make inter-language highlight consistent with other highlights. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/143051 [17:00:24] liangent: supposedly 'home + power' works? [17:00:41] “take a picture with another phone” :) [17:02:15] YuviPanda: hm right [17:02:28] there's already a "screenshot" menu entry in the power menu [17:02:54] (03PS1) 10Brion VIBBER: Don't append literal "Other" to edit summary when "Other" text is filled out [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/143052 (https://bugzilla.wikimedia.org/67222) [17:03:25] YuviPanda: do we actively support the app on GB? [17:04:32] liangent: yeah [17:04:36] liangent: theoretically, at least :) [17:04:57] 3Wikipedia App / 3Android App: Android app: "how did you improve" hidden on 2.3 Gingerbread - 10https://bugzilla.wikimedia.org/67135#c3 (10Brion Vibber) 5PATC>3RESO/FIX This was merged [17:08:14] 3Wikipedia App / 3Android App: [CM7] Stripes appear when the left drawer is pulled out - 10https://bugzilla.wikimedia.org/67311 (10Liangent) 3NEW p:3Unprio s:3normal a:3None Created attachment 15784 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15784&action=edit Screenshot Every dark stripe... [17:09:27] 3Wikipedia App / 3iOS App: iOS App: Links to sections don't work, and anchor shows up in title - 10https://bugzilla.wikimedia.org/65108#c1 (10Brion Vibber) 5NEW>3RESO/FIX This got fixed in 95e4a3278 [17:09:29] 3Wikipedia App / 3Android App: [CM7] The language selection dialog is unusable due to bad color theme - 10https://bugzilla.wikimedia.org/67312 (10Liangent) 3NEW p:3Unprio s:3normal a:3None Created attachment 15785 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15785&action=edit Screenshot [17:11:57] 3Wikipedia App / 3Generic: [iOS] Redirects cause wiki text to not load in editor - 10https://bugzilla.wikimedia.org/62085#c1 (10Brion Vibber) 5NEW>3RESO/FIX This was fixed a while ago. [17:12:16] jgonera: if you have a moment, could you review https://integration.wikimedia.org/ci/view/BrowserTests/job/browsertests-MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-firefox-sauce/lastCompletedBuild/testReport/? I think at least 'loading pages' and 'table of contents' have bugs [17:12:42] 3Wikipedia App / 3Generic: [iOS] Search input box loses focus after all text has been removed - 10https://bugzilla.wikimedia.org/60929#c1 (10Brion Vibber) 5NEW>3RESO/FIX Looks like this got fixed a while ago, probably when we redid the search input style. [17:13:57] 3Wikipedia App / 3Generic: [iOS] External links in reference section don't open external browser - 10https://bugzilla.wikimedia.org/60931#c1 (10Brion Vibber) 5NEW>3RESO/FIX Seems to work now, presumably fixed a while ago. [17:15:50] chrismcmahon, yes, we just had a standup and reserved some time for figuring this out [17:17:03] jgonera: OK, let me know if I can help, I am concentrating on the tests in /mediawiki/core and retiring the Cloudbees Jenkins completely, hopefully this week. [17:17:19] chrismcmahon, alright, thanks [17:25:26] jgonera kaldari if you have anything you'd like to demo at the showcase today, be sure to add it to the etherpad: http://etherpad.wikimedia.org/MobileShowcase [17:26:10] awjr, I can show the mobile context thing in VE, although it's small and not merged yet [17:26:23] jgonera i think that's ok - that sounds good! [17:35:21] 3Wikipedia App / 3Android App: [CM7] The captcha reloading animation looks weird - 10https://bugzilla.wikimedia.org/67316 (10Liangent) 3NEW p:3Unprio s:3normal a:3None Created attachment 15787 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15787&action=edit Screenshot after the new captcha is... [17:35:43] YuviPanda: ^ I need a screen recording now... [17:39:02] liangent: try holding the back button and pressing home? [17:42:06] YuviPanda: basically the loading circle appears weird everywhere [17:42:27] liangent: right. did the screencast thing work? [17:43:41] YuviPanda: no [17:43:59] liangent: sigh :( [17:44:07] liangent: unsure, I just picked that up from a google search [17:45:12] YuviPanda: http://imgur.com/0b0tToV [17:45:25] I achieved this somehow, but can't find a way to reproduce [17:46:11] maybe that's related to the order of some async tasks adding contents to the document? [17:46:23] liangent: hmm, yeah, it is [17:46:30] vbamba: hey! our meetings are colliding. can you move it a bit? [17:47:37] liangent: looks like a race condition, unsure what would cause that :| can you do a 'adb lolcat | grep Wikipedia' if you are able to use adb? [17:47:40] liangent: no problem if not [17:49:24] YuviPanda: lol for lolcat ^ [17:49:38] ;) [17:49:51] YuviPanda: http://pastebin.com/B51XaFmB [17:51:38] it doesn't seem useful [17:51:50] 3Wikipedia App / 3Android App: [CM7] Page footer is sometimes at the top - 10https://bugzilla.wikimedia.org/67317 (10Liangent) 3NEW p:3Unprio s:3normal a:3None Created attachment 15788 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15788&action=edit Screenshot liangent: I achieved this someh... [17:54:13] bearND: :D it works! [17:54:41] liangent: right. was checking for errors [17:54:43] js errors [17:55:28] maybe this one is better http://pastebin.com/LyLmjgjg ? [17:55:34] 3Wikipedia App / 3Android App: [CM7] Page footer is sometimes at the top - 10https://bugzilla.wikimedia.org/67317#c1 (10Liangent) Possible repro: 1. Clear app data 2. Open the app; it displays enwp main page 3. Save this page 4. Open it from "Saved pages" [17:55:37] YuviPanda: wow [17:56:34] liangent: no, I don't see anything there either. I've definiely seen that before, though [17:56:36] the foter on top [17:56:37] bearND: :D [17:57:29] YuviPanda: i didn't know you could say adb lolcat and get the same output as adb logcat. Funny Android tools devs [17:57:33] bearND: :D [17:58:03] bearND: there's also adb hell [17:58:32] YuviPanda: awesome :) [17:58:39] YuviPanda: so this bug is not CM-specific? [17:58:53] maybe it's just because this one of my phones is slower [17:59:05] liangent: yeah, I'd think it's slower phone specific [18:00:05] 3Wikipedia App / 3Android App: Page footer is sometimes at the top - 10https://bugzilla.wikimedia.org/67317 (10Liangent) [18:01:16] Deskana|Away: Maryana hey! meeting? [18:02:13] YuviPanda: dan is still chatting with vibha and monte [18:02:19] Maryana: ah, ok! [18:02:37] Maryana: vbamba scheduled a conflicting meeting with me, hopefully she got my emails. [18:06:06] 3Wikipedia App / 3Android App: "Send app feedback" crashes when there's no mail handler - 10https://bugzilla.wikimedia.org/67322 (10Liangent) 3NEW p:3Unprio s:3normal a:3None android.content.ActivityNotFoundException: No Activity found to handle Intent { act=android.intent.action.VIEW dat=mailto:mobi... [18:06:33] liangent: hahaha :D How did you even get a system with no mail handler? [18:06:54] liangent: also, I think that's an upstream bug (to ACRA) [18:07:21] YuviPanda: at least it crashes on my newly installed cyanogenmod [18:07:28] and no ACRA doesn't crash [18:07:35] liangent: oh, right. forgot [18:07:40] liangent: that send app feedback isn't ACRA [18:07:53] it shows two options for me: one is "Bluetooth" and another is "Messaging" [18:08:01] liangent: right. [18:10:39] YuviPanda: dan says 2 more minutes [18:10:50] Maryana: alright :) [18:15:33] 3MobileFrontend / 3General/Unknown: MobileFrontend: The "last edited" notice incorrectly shows up as "Just now" on pages that don't exist - 10https://bugzilla.wikimedia.org/67096#c3 (10Ryan Kaldari) Tried editing as an anonymous user to see if that made any difference. Went to a page that didn't exist, click... [18:15:56] (03PS1) 10Florianschmidtwelzow: Minerva Desktop: Remove toggling and fix TOC [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/143062 (https://bugzilla.wikimedia.org/67101) [18:17:06] (03CR) 10Florianschmidtwelzow: Minerva Desktop: Remove toggling and fix TOC (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/143062 (https://bugzilla.wikimedia.org/67101) (owner: 10Florianschmidtwelzow) [18:17:34] YuviPanda: heya! [18:17:53] YuviPanda: do you think ios should switch to pull css from “live” url now? [18:19:18] 3MobileFrontend / 3General/Unknown: MobileFrontend: The "last edited" notice incorrectly shows up as "Just now" on pages that don't exist - 10https://bugzilla.wikimedia.org/67096#c4 (10Jon) 5NEW>3RESO/DUP I believe this is a dupe of this bug. *** This bug has been marked as a duplicate of bug 66384 *** [18:21:19] 3Wikipedia App / 3Android App: [CM7] Unreadable text caused by bad color theme - 10https://bugzilla.wikimedia.org/67312 (10Liangent) [18:21:33] 3Wikipedia App / 3Android App: [CM7] Unreadable text caused by bad color theme - 10https://bugzilla.wikimedia.org/67312#c1 (10Liangent) Created attachment 15792 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15792&action=edit One more screenshot [18:23:49] (03CR) 10JGonera: [C: 04-1] "Inline, also tests?" (033 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/133680 (owner: 10Jdlrobson) [18:24:24] (03PS1) 10Mhurd: Fix for logo being too close to screen top on 3.5 inch screens. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/143066 [18:24:27] brion: ^ [18:26:38] mhurd: hey! [18:26:47] mhurd: sure, if you guys are happy with page styling as is [18:27:17] YuviPanda: bits is giving me an html error page instead of css right now :( [18:27:31] mhurd: heh, yeah, bit is flakey [18:28:16] mhurd: I'm going to send you a patch :) [18:28:24] YuviPanda: cool! [18:28:51] vbamba: hey! did you update the calendar invite? [18:29:21] (03CR) 10Brion VIBBER: [C: 032 V: 032] Fix for logo being too close to screen top on 3.5 inch screens. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/143066 (owner: 10Mhurd) [18:29:48] brion: thx! [18:32:05] (03PS1) 10Yuvipanda: Fetch CSS resources from prod instead of labs [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/143067 [18:32:07] mhurd: ^ untested. [18:32:26] (03PS1) 10Florianschmidtwelzow: Fix jsduck [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/143069 (https://bugzilla.wikimedia.org/66579) [18:32:53] YuviPanda: woohoo! testing... [18:33:26] jdlrobson2: Hey Jon, who added the template support to ResourceLoader? You? Roan? Someone else? [18:33:32] YuviPanda: is 1 pm too late? [18:33:39] Deskana i know you're super busy today - but is there a good time for you and i to sync up, maybe ~15mins? [18:33:42] vbamba: no, should be fine :) [18:33:46] YuviPanda: Ive set the meeting to happen in 1.5 hours [18:33:48] kaldari: me [18:33:50] ok, sorry about this [18:33:52] vbamba: cool! :) [18:34:55] awjr: Maybe, I'll get back to you. [18:35:00] YuviPanda: For clarity, for the edit workflow. [18:35:05] YuviPanda: start = hit edit pencil [18:35:15] YuviPanda: preview = hit "Next" having made some changes and saw preview [18:35:26] YuviPanda: saved = hit "Save" and successfully saved [18:35:44] YuviPanda: Is that right? [18:35:46] Deskana: yup [18:36:42] awjr: 1:30pm? [18:36:54] * YuviPanda piles more meetings on Deskana [18:36:57] YuviPanda: one thing in the workflow: some user failed to realize "other" allows you to input your own comment [18:37:12] based on user comments on the app [18:37:20] liangent: yeah, I've seen that happen. unsure how to fix [18:37:26] liangent: or if it is big enough to be fixed. [18:37:27] Deskana web has a sprint kickoff at 130 [18:37:45] Deskana how about right after the showcase? [18:37:58] awjr: If you don't mind following me while I go and get something to eat, sure. [18:38:10] Deskana i'll need to do the same ;) [18:38:19] awjr: Done! Throw something on my calendar? [18:38:23] yep [18:38:28] nick bearND|lunch [18:39:12] brion: so yuvi’s patch updating the css url looks good, but that server doesn’t yet have the protected edit pencil… should we wait until it does before merging? [18:39:21] YuviPanda: put a textbox there and make preset buttons simply append some text in the box? [18:39:23] YuviPanda|food: Query inc. [18:39:30] YuviPanda|food: select count(event_action) from MobileWikiAppEdit_8198182 where timestamp >= 20140625000000 and event_action = "start" [18:39:43] just ran this to get number of edit pencil taps and it came out with ~600 [18:39:43] agh [18:39:45] which seems… low [18:39:49] yeah let’s not downgrade... [18:39:56] brion: soon :) [18:40:38] (03CR) 10Mhurd: "Looks good. Will merge as soon as production css has the protected edit pencil in css." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/143067 (owner: 10Yuvipanda) [18:40:44] brion: ^ [18:41:25] Maryana: not sure if that's the right revid [18:41:33] for the schema? [18:41:38] should be.. the other two look older [18:41:42] contain data from like april [18:41:51] Maryana: 9003125 [18:41:55] https://meta.wikimedia.org/wiki/Schema:MobileWikiAppEdit [18:42:42] YuviPanda|food: that schema rev id doesn't exist in the log db.. [18:43:10] Maryana: hmm, it was there 2d ago... [18:43:25] YuviPanda|food: We found it. [18:43:51] muuuch better :) [18:44:04] :D [18:48:21] YuviPanda|food: On the MobileWikiAppLogin schema, are the ones that start "createAccount" just for creating accounts, and the others (error, start, success) for login attempts? [18:48:52] Deskana: there is a separate CreateAccount schema [18:49:09] Deskana: on login that just means user tapped the create account button [18:56:03] jdlrobson: would be great to have you join us for https://etherpad.wikimedia.org/p/MobileShowcase and give an update on your work with FLOW [18:56:06] and vice versa [18:59:36] MaxSem, when you have a moment - vagrant's zero role - https://gerrit.wikimedia.org/r/#/c/142832/ [19:05:36] jgonera joining us for the showcase? [19:05:50] nm you just walked in the door [19:31:53] awjr: please open the window behind you [19:32:30] kaldari: --^ [19:32:47] thanks. its getting hot in here [19:34:46] jdlrobson2 goal 3# surface flow on mobile where available in mobile stable mode [19:35:15] tfinc oops sorry, missed the msg [19:38:51] tfinc: Hi, just did a fresh install of the Commons mobile app and ran into something that looked like an unicode problem [19:39:35] multichill: bummer. sorry about that [19:39:35] It shows U00A0 instead of a space (that's the unicode code for a nbsp). Does that ring a bell or do I need to file a new bug? [19:39:59] Now I found it :-) [19:40:00] https://bugzilla.wikimedia.org/show_bug.cgi?id=51815 [19:40:07] multichill: wont ring a bell as that app has been on ice for 6+ months and we're not picking it up [19:40:16] but thats only because of our focus on the wikipedia app [19:40:29] looks like you can confirm it [19:40:30] thanks [19:41:36] 3Commons App / 3Android: Non-breaking space in translation is ignored for license string - 10https://bugzilla.wikimedia.org/51815#c2 (10Maarten Dammers) 5UNCO>3NEW Got it here too. [19:41:38] Any idea on how many people downloaded that Commons app? [19:42:36] 3Commons App / 3Android: Non-breaking space in translation is ignored for license string - 10https://bugzilla.wikimedia.org/51815 (10Maarten Dammers) p:5Low>3Normal [19:43:06] 3MobileFrontend / 3stable: Filter for New User uploads in Mobile Web - 10https://bugzilla.wikimedia.org/62598#c46 (10Lupo) (In reply to Florian from comment #45) > If i'm right, it's still online :) What does _that_ mean? What is "it", and what does "being online" mean here? The two Gerrit commits mentione... [19:54:54] jgonera are we waiting on review from VE on anything other than https://gerrit.wikimedia.org/r/#/c/141085/ ? [19:56:21] 3MobileFrontend / 3stable: Filter for New User uploads in Mobile Web - 10https://bugzilla.wikimedia.org/62598#c47 (10Maryana Pinchuk) 1. Is the "autoconfirmed users only" implemented as part of this bug now active or not? Yes. 2. Should we be seeing any improvements at the Commons already or not? Yes. I w... [19:56:35] awjr, I think that's the only one [19:56:41] kaldari, you have any VE patches? [19:56:54] jgonera: no [19:57:04] ok cool - i poked james that we're still waiting for that to get reviewed [19:58:05] Deskana ready? [19:58:20] im lurking in the mobile area - i think tfinc will join as well [20:03:12] * YuviPanda pokes vbamba [20:08:42] vbamba: https://etherpad.wikimedia.org/p/night-mode-colors [20:27:12] (03CR) 10Kaldari: [C: 04-1] Minerva Desktop: Remove toggling and fix TOC (033 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/143062 (https://bugzilla.wikimedia.org/67101) (owner: 10Florianschmidtwelzow) [20:39:09] dr0ptp4kt, we have just decided during sprint kick off that we'll just hide all page actions on really small screen devices [20:41:56] tfinc: ty [20:42:02] YuviPanda: sure [20:42:38] jgonera: cool. one more thing: how about the 'last edited' bar? i was thinking to have a max-width check on that at the top to suppress it for small screens, but have it echoed at the bottom as well. [20:43:26] Maryana, ^ [20:43:59] oh yeah, good call dr0ptp4kt [20:44:29] Maryana: cool thx [20:44:40] YuviPanda: Some more data I'd like... [20:44:47] Deskana: sure [20:44:55] YuviPanda: Number of page views [20:45:14] Deskana: hit up oliver for that one. [20:45:28] YuviPanda: Well, I think that was it, so great! [20:45:29] :P [20:45:31] Deskana: :D [20:45:47] Deskana: remind him of 'China' as well, so you can get the caveat filled lecture I got :) [20:48:41] kaldari: you're here? :) [20:50:18] FlorianSW|away: yes [20:50:26] http://etherpad.wikimedia.org/p/MobileWeb_Iteration_name [20:50:48] kaldari: maybe add a fixme here: https://gerrit.wikimedia.org/r/#/c/143062/1/javascripts/modules/toc/toc.js [20:50:57] ? :) [20:55:40] Deskana: btw, he should be able to give you number of *users* as well, and number of sessions / average length of sessions too. [20:57:13] (03PS2) 10Florianschmidtwelzow: Minerva Desktop: Remove toggling and fix TOC [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/143062 (https://bugzilla.wikimedia.org/67101) [20:57:20] http://www.alop.org/wp-content/uploads/2010/09/Chris-and-baby-Zedonk.jpg [21:02:10] dbrant: props for using https://en.wikipedia.org/wiki/Nintendo for testing today [21:03:46] tfinc: lol it was on the main page... but yes, I thought it was appropriate. [21:05:28] FlorianSW|away: No, I don't think it needs a fixme. Agile development means ugly workarounds are sometimes a good thing, i.e. time should be spent on improving functionality, rather than making the code beautiful. [21:08:55] food time [21:14:27] (03PS1) 10Dr0ptp4kt: During edit save, describe whether IP or username will be shown. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/143156 [21:16:51] YuviPanda dbrant bearND ^ small patch to add conditional verbiage so user has better idea of logging. old messages in strings.xml were related, but not specific to the new way of doing edits. [21:19:08] vbamba: think it'll be possible to get all the colors by tomorrow? [21:23:51] 3MobileFrontend / 3beta: VE hangs forever in beta labs - 10https://bugzilla.wikimedia.org/67137#c3 (10Juliusz Gonera) Seems to be working now for me. Is it working for you? [21:24:14] YuviPanda: I'll give you colors today [21:25:08] vbamba: :) ok! [21:26:20] (03PS1) 10Dr0ptp4kt: Instead of "send feedback", "send app feedback". [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/143159 [21:29:31] moizsyed: vbamba almost forgot - do we have a design for the “credits” page? [21:30:02] moizsyed: vbamba: *i* almost forgot... [21:36:51] jdlrobson2, there's a toc.feature browser test. I wonder how it ever worked, the test page it uses is too small to trigger section toggling [21:38:29] jdlrobson2, no, I'm wrong, there is section toggling, odd... [21:42:17] jgonera: ? "I am viewing the site in tablet mode" should make sure the screen is big enough [21:42:39] jdlrobson2, it's not screen, the wgTOC patch changed something [21:42:48] there's no TOC now if there are fewer than 3 sections [21:42:57] wgTOC ? [21:43:00] yes [21:43:07] * jdlrobson2 reads up on commits [21:43:13] not sure when this got merged, must be recent [21:43:34] anyway, this just shows that browser tests will be a bit useless until jenkins is able to run them... [21:44:11] jgonera: Is that a core change? [21:44:18] no jdlrobson2 [21:44:26] I don't see any variable called wgTOC [21:44:37] ohh i see [21:44:39] that should be wgMF [21:44:40] that's bad [21:44:45] jdlrobson2, 65ca386d [21:44:56] jgonera: yeh i'm already on it i git blamed SkinMinerva [21:45:47] seems to expect more than 0 sections [21:45:52] where did you get the number 3 from? [21:47:58] (03PS1) 10JGonera: Fix TOC browser test [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/143168 [21:48:40] jgonera: this wgTOC code is pretty hacky :/ $outputPage->setProperty( 'MinervaTOC', $po->getTOCHTML() !== '' ); wtffff ! [21:48:48] no documentation whatsoever [21:48:52] kaldari, MaxSem ^ [21:49:22] I mean, I understand it, but probably only because I got used to MW-style code (oh god) [21:49:23] (03PS2) 10Jdlrobson: QA: Fix TOC browser test [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/143168 (owner: 10JGonera) [21:51:16] jgonera: yeh i'm taking a look at core to see where the magic 3 number comes from [21:53:15] (03PS1) 10Dr0ptp4kt: Make MCC-MNC logging honor Event Logging preference. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/143169 [21:53:33] mhurd ^ another short one [21:53:55] dr0ptp4kt: ooh good catch [21:54:39] dr0ptp4kt: is the “!” deliberate? [21:54:49] mhurd: my irc connection got dropped earlier. i had also submitted a 'send app feedback' verbiage change. [21:56:22] mhurd: yeah, that opening if() is the exit hatch to not bother logging if the user opted out of logging. ! binds tightly, right? [21:56:43] dr0ptp4kt: ya [21:57:39] (03CR) 10Mhurd: [C: 032 V: 032] "Looks good to me." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/143169 (owner: 10Dr0ptp4kt) [21:57:46] mhurd: thx [21:58:09] dr0ptp4kt: np! thx for patch :) [21:58:30] (03PS3) 10Jdlrobson: QA: Fix TOC browser test [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/143168 (owner: 10JGonera) [21:59:07] (03CR) 10Jdlrobson: [C: 032] QA: Fix TOC browser test [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/143168 (owner: 10JGonera) [21:59:36] (03CR) 10Mhurd: "The design for the "More" menu is undergoing revision presently. Ok to hold off a bit on this one for now?" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/143159 (owner: 10Dr0ptp4kt) [22:00:24] (03CR) 10Dr0ptp4kt: "Yep." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/143159 (owner: 10Dr0ptp4kt) [22:00:43] (03Merged) 10jenkins-bot: QA: Fix TOC browser test [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/143168 (owner: 10JGonera) [22:10:52] (03CR) 10Kaldari: [C: 04-1] "Looks like the solution is going to have to be a bit more complicated since the toc.js code actually requires the toggling code (so that y" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/143062 (https://bugzilla.wikimedia.org/67101) (owner: 10Florianschmidtwelzow) [22:12:56] (03CR) 10Kaldari: [C: 032] Fix jsduck [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/143069 (https://bugzilla.wikimedia.org/66579) (owner: 10Florianschmidtwelzow) [22:13:33] (03Merged) 10jenkins-bot: Fix jsduck [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/143069 (https://bugzilla.wikimedia.org/66579) (owner: 10Florianschmidtwelzow) [22:14:36] 3MobileFrontend / 3Hygiene: jsduck is not installed by bundle - 10https://bugzilla.wikimedia.org/66579 (10Florian) 5PATC>3RESO/FIX [22:19:06] 3MobileFrontend / 3beta: VE hangs forever in beta labs - 10https://bugzilla.wikimedia.org/67137 (10Chris McMahon) 5NEW>3RESO/FIX [22:23:27] (03CR) 10Dr0ptp4kt: "See comments. About to resubmit." (031 comment) [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/142609 (owner: 10Dr0ptp4kt) [22:24:11] (03PS2) 10Dr0ptp4kt: Hide Watchlist thumbnails on zerodot. [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/142609 [22:24:51] yurikR: ^ resubmitted. i think if we're gonna do any sort of cookie stuff we really ought to do that with a separate patch and make sure it doesn't break any cookies [22:32:43] mhurd: What do you think the chances are that Apple will take longer than a week to review the app? [22:33:09] mhurd: Howie suggested telling the PR folks that we'd release the app a week after submission, but my impression is that there's a not insignificant chance that Apple wouldn't be done by then. [22:33:24] Deskana: no guarantees it will even pass review the first go-round. so don’t count on any hard date [22:34:01] mhurd: Sure, but assuming it does, does a week seem like a sensible stretch of time or is it risky? [22:34:25] Deskana: the unfortunate reality is that we only control submission date. i’ve had it take a month, but that was years ago. [22:34:36] Alright, I'll pass that one. [22:34:38] Stupid Apple. [22:34:43] WHY DO WE BUY THEIR PRODUCTS [22:34:52] awjr|away: https://github.com/wikimedia/bingle/pulls [22:34:57] ...he says, typing on his Apple keyboard connected to his MacBook Pro. [22:35:03] I can't help but think I'm partially to blame. :P [22:35:11] Deskana: i think if we google around we can get a better sense for how long it’s taking for apps to move through the queue these days [22:35:35] mhurd: http://appreviewtimes.com/ [22:35:39] mhurd: That was easy. :P [22:35:46] Deskana: ah! perfect! [22:36:02] Deskana: that’s *awesome*! [22:36:36] Deskana: interwebs ftw [22:36:40] :D [22:36:44] jdlrobson2 >_< [22:37:26] mhurd: What exactly happens if they do decline it? [22:37:27] jdlrobson2 should we ensure that boardBaseName is also utf8? [22:37:38] mhurd: Is it just a "no thx" or "This is what you need to fix to get it done:"? [22:38:04] Deskana: should be some indication of what ran afoul of their checklist [22:38:07] awjr: i guess so. Encoding in python is always a pain :/ [22:38:15] truth!! [22:39:30] Deskana: not anticipating that happening… but it happens now and again [22:40:00] mhurd: Indeed, but I appreciate your reminder, because it's worth mentioning to comms so they don't take it as an immutable fact. [22:40:28] Deskana: ah, true [22:40:42] os x 10.9.4 update, whee [22:40:49] brb [22:40:52] brion: wat [22:41:57] Deskana: this is interesting: http://appreviewtimes.com/ios/annual-trend-graph [22:42:00] (03CR) 10Kaldari: [C: 032] Move border-bottom out of .overlay-header-container [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/142759 (owner: 10JGonera) [22:42:36] (03Merged) 10jenkins-bot: Move border-bottom out of .overlay-header-container [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/142759 (owner: 10JGonera) [22:43:35] mhurd: So yeah, a week is not realistic. Thanks. :) [22:44:13] Deskana: interesting to see the dip to ~2 days last year [22:44:22] Deskana: i vote for that [22:44:42] I totally read that as -2 days. [22:44:51] App submissions approved two days before you even make them! [22:44:58] NEW RELEASE DATE 12TH JULY [22:45:01] you heard it here first [22:45:09] Deskana: hehe [22:45:10] I'LL RUN AND TELL COMMS [22:45:22] :) [22:45:54] Deskana: tell them they have -2 days to prepare [22:46:00] Haha [22:46:06] I'm sensing a dangerous chain [22:48:06] (03PS3) 10Florianschmidtwelzow: Minerva Desktop: fix TOC [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/143062 (https://bugzilla.wikimedia.org/67101) [22:48:45] (03CR) 10Florianschmidtwelzow: "> In the meantime, feel free to split the bug 67105 stuff into a separate commit, and I can go ahead and merge this one so that bug 67101 " [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/143062 (https://bugzilla.wikimedia.org/67101) (owner: 10Florianschmidtwelzow) [22:51:07] Deskana, Brion, mhurd: original image links still have a todo external link popup. Is that going to be in the shipped version? [22:51:07] 3MobileFrontend / 3stable: In desktop mode of Minerva, section toggling is broken. It should probably be removed. - 10https://bugzilla.wikimedia.org/67105#c4 (10Florian) 5PATC>3NEW Set to new again, after split PS in two commits (see comment from kaldari) :) [22:51:31] ragesoss: I'm not sure what you mean by "original image links"? [22:51:41] Click an image [22:52:03] Then on image page, click link for original file. [22:52:12] ragesoss: Deskana: good point about image taps. Also need to handle external link taps. [22:52:24] ragesoss: oh yeah we gotta fix that i think :D [22:52:39] Some external links work. [22:52:43] brion, mhurd: FWIW I'm fine with taps on the image on the file description page doing nothing. [22:52:50] yeah i forget exactly why some work and some don't [22:52:52] we’ll have to check that [22:52:56] The file description page is just really weird on the app. [22:53:00] ragesoss: Thanks for the reminder. :) [22:53:08] np [22:53:18] yeah we should do a better image zoom later [22:53:31] i leave it as an exercise for the PM whether that’s an mvp issue or later :D [22:54:06] I'm way past "MVP" right now and well and truly into the "blockers for release" stage :P [22:54:10] hehe [22:54:19] Deskana: for mvp should be ok? we were going to hide the edit pencil on file pages as well. can you double-check if we have stories for these? [22:54:30] ‘legal will kill us’ issues ;) [22:54:35] lol [22:56:34] mhurd: That's m'job! [22:56:59] There's this suitably vague card: https://trello.com/c/4coMpw3T/3-as-a-new-user-i-want-the-experience-i-get-when-i-tap-an-image-to-be-a-less-confusing [22:57:10] Deskana: hehe that sums it up :) [22:57:24] Let's add acceptance criteria to make it a little more estimable. [22:58:10] Deskana: those look good [22:58:31] was there still a some-links-dont-work issue or was that elsewhere? [22:59:05] hmm, yeah if you click the ‘other size’ download links it does the popup too [22:59:19] and the commons links etc [22:59:29] we could easily make those open in the browser :D [22:59:31] brion: Deskana: oh, maybe it was in edit preview - tapping them there pops up what they link to as a js msg - which is nice for proofing, but do we want it to do nothing instead? [22:59:35] * Deskana looks. [22:59:53] brion: Deskana: ok the edit preview link issue is separate [23:00:15] I've somehow ended up on [[United Kingdom]]. Hah. [23:00:51] mhurd, brion: Is it particularly hard to fix up these links on the file page? [23:01:02] Deskana: super easy to make them open in safari [23:01:02] mhurd, brion: I want this story to not bloat into a massive one. [23:01:20] if we want to make sure wikipedia links open within the app, slightly harder but not hugely i think [23:01:49] Deskana: for the edit preview links issue i’d recommend just using the exiting top alert with auto fade out. that way user could quickly proof links they added by just tapping them. [23:02:06] sounds good yeah [23:02:11] Deskana: heh, at least you're there in app if not in person :P [23:08:37] Maryana: I'm really looking forward to when tapping a diff from a watchlist email on mobile will redirect me to the mobile diff view. [23:08:50] (03PS1) 10Florianschmidtwelzow: Minerva Desktop: Remove toggling sections [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/143191 (https://bugzilla.wikimedia.org/67105) [23:10:28] ( or open a diff straight to app!) [23:10:45] (03CR) 10Florianschmidtwelzow: Minerva Desktop: Remove toggling sections (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/143191 (https://bugzilla.wikimedia.org/67105) (owner: 10Florianschmidtwelzow) [23:10:49] (03PS2) 10Florianschmidtwelzow: Minerva Desktop: Remove toggling sections [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/143191 (https://bugzilla.wikimedia.org/67105) [23:12:07] ragesoss: :D [23:12:39] Mobile diff view is great. [23:12:57] ios 7.1.2 update also, whee [23:13:05] I love the easy no-confirm thanksgiving. [23:13:49] But I have to scroll to the bottom of huge noticeboards to switch out of desktop diff view. [23:17:20] * ragesoss looks forward to iOS 8, so all the jailbreaks ppl are saving will get released. [23:17:46] :) [23:18:14] Aside from the nice camera, testing the Wikipedia app is all my new work phone is good for. [23:19:58] Do we have a photo lying around of what the CTA to sign in and save looked like? [23:20:07] Making a presentation for Metrics [23:25:22] (03CR) 10Kaldari: [C: 04-1] Minerva Desktop: fix TOC (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/143062 (https://bugzilla.wikimedia.org/67101) (owner: 10Florianschmidtwelzow) [23:28:37] YuviPanda: if I want to add a new LoginFunnel source for onboarding do we need to do something on the server first or is it all just in Android code? [23:29:06] bearND: need to do something in server as well, yeah. we can add that as a separate commit tho [23:29:25] (03CR) 10Florianschmidtwelzow: Minerva Desktop: fix TOC (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/143062 (https://bugzilla.wikimedia.org/67101) (owner: 10Florianschmidtwelzow) [23:29:31] (03PS4) 10Florianschmidtwelzow: Minerva Desktop: fix TOC [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/143062 (https://bugzilla.wikimedia.org/67101) [23:29:38] YuviPanda: would it break things if the server piece was not deployed? [23:29:47] bearND: no, it just won't record the new thing. [23:44:33] (03PS1) 10Kaldari: Changing labels in editor switcher [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/143198 [23:47:24] jgonera: https://gerrit.wikimedia.org/r/#/c/143198/ [23:48:03] (03CR) 10JGonera: [C: 032] Changing labels in editor switcher [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/143198 (owner: 10Kaldari) [23:48:37] (03Merged) 10jenkins-bot: Changing labels in editor switcher [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/143198 (owner: 10Kaldari) [23:50:19] Maryana: Can you re-review https://trello.com/c/3PGGXjb8/14-3-switch-ve-wikitext-icon ? [23:50:26] it should be fixed now [23:52:48] jgonera, jdlrobson: where are we on the lazy-loading discussion? [23:55:08] kaldari: hmm, i'm still seeing the old copy on beta labs [23:55:15] should i test in vagrant?