[00:01:17] (03PS1) 10BearND: Add link from create account to login [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/143204 [00:01:19] (03PS1) 10BearND: [WIP] Add onboarding screen [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/143205 [00:03:27] hmm [00:24:49] kaldari: ah, there it goes :) [00:25:05] three stickers later, lgtm [00:31:00] (03PS1) 10Kaldari: Fix editing message in source editor... [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/143219 [01:02:59] YuviPanda, btw did you ask anyone about that issue someone was experiencing with permissions? [01:03:25] Krenair: I asked a couple of android devs in the local community and they also said the same thing I did [01:03:37] ok [01:03:43] Thanks YuviPanda [01:03:54] Krenair: :) yw! [01:04:00] might ask for a screenshot of the permissions request or something [01:04:05] Krenair: yeah, that would help. [05:54:44] (03PS1) 10Deskana: Change edit workflow licensing text to include a link to the Terms of Use, per a legal requirement. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/143247 [06:03:41] (03CR) 10Deskana: "Turns out the description for edit_save_action_license doesn't need updating as it already says that the string contains the Terms of Use," [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/143247 (owner: 10Deskana) [06:43:52] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/143247 (owner: 10Deskana) [06:51:18] (03PS5) 10Florianschmidtwelzow: Minerva Desktop: fix TOC [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/143062 (https://bugzilla.wikimedia.org/67101) [07:07:54] (03PS2) 10BearND: [WIP] Add onboarding screen [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/143205 [07:13:54] (03PS1) 10Reza: 18n: native digits on 'pager-older-n' [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/143250 [07:20:47] (03CR) 10Florianschmidtwelzow: [C: 031] 18n: native digits on 'pager-older-n' [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/143250 (owner: 10Reza) [07:38:34] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/143250 (owner: 10Reza) [07:48:53] 3Wikipedia App / 3Android App: Enhancement - 10https://bugzilla.wikimedia.org/67351 (10dj.d) 3UNCO p:3Unprio s:3enhanc a:3None Really nice job you made with new beta app. Points for enhancement : + how to find a people with just his name..? example : Jules Haime. By typing "Haime", nothing is sugges... [07:56:10] 3MobileFrontend / 3General/Unknown: MobileFrontend: User right "mf-uploadbutton" is missing message (unit test failure) - 10https://bugzilla.wikimedia.org/67352 (10Krinkle) 3NEW p:3Unprio s:3major a:3None 1) UserTest::testAllRightsWithMessage Each user rights (core/extensions) has a corresponding rig... [08:09:33] (03CR) 10Florianschmidtwelzow: Changing labels in editor switcher (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/143198 (owner: 10Kaldari) [09:04:55] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/143159 (owner: 10Dr0ptp4kt) [09:07:29] (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed." (031 comment) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/143156 (owner: 10Dr0ptp4kt) [09:39:36] 3Wikipedia App / 3Android App: Several enhancement requests - 10https://bugzilla.wikimedia.org/67351#c1 (10Andre Klapper) Hi Tom, thanks a lot for your feedback! There are several issues listed in this report so this report unfortunately cannot be easily handled (see https://www.mediawiki.org/wiki/How_to_re... [10:38:46] (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed. One capitalisation issue, and one "food for thought"." (032 comments) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/143024 (owner: 10Dbrant) [12:08:08] (03PS4) 10Florianschmidtwelzow: Proposal: Redirect to direct match in search [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/139556 (https://bugzilla.wikimedia.org/66506) [13:39:33] (03CR) 10Dr0ptp4kt: "Will update patch." (031 comment) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/143156 (owner: 10Dr0ptp4kt) [13:41:27] (03PS1) 10Dbrant: Investigate possible crash when saving history item. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/143303 [13:46:22] 3MobileFrontend / 3General/Unknown: MobileFrontend: User right "mf-uploadbutton" is missing message (unit test failure) - 10https://bugzilla.wikimedia.org/67352#c1 (10Florian) 5NEW>3ASSI a:3Florian Caused by: Ibf12c27962ab3210ae24a0346553e48999de91ae Need to add right- and action- language key :) Will... [13:56:47] (03PS1) 10Dbrant: Fix possible crash(es) related to find-in-page. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/143310 [14:11:06] (03Abandoned) 10Dbrant: Investigate possible crash when saving history item. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/143303 (owner: 10Dbrant) [14:46:36] 3Wikipedia App / 3iOS App: iOS App: Don't overwrite app CSS files if the new file is zero bytes - 10https://bugzilla.wikimedia.org/67055#c2 (10Brion Vibber) 5NEW>3RESO/FIX this was done in I666d24ed [15:09:21] 3Wikipedia App / 3Localization/Translation/Language: timestamp in Hebrew and possibly other languages must support more than singular and plural - 10https://bugzilla.wikimedia.org/63265#c1 (10Brion Vibber) Is this still an issue for Android? In theory multiple plural numbers should be supported... Meanwhil... [15:39:30] YuviPanda: hmm, does that plural support in AndroidXmlFFS actually work? it doesn’t look like it quite matches mediawiki {{PLURAL:}} syntax either, and I don’t see any usage of it in the app [15:40:06] brion: yeah, we don't actually use it because I don't know if it works ;) [15:40:11] lol [15:40:13] brion: but we do use it in the commons app [15:40:30] YuviPanda: none of the localizations appear to include plural forms [15:40:34] (for commons) [15:40:42] except english original file [15:40:44] brion: hmm, weird. maybe we *don't* support plurals? [15:40:55] I remember niklas working on it [15:40:56] well there’s code in there [15:53:19] (03PS1) 10Florianschmidtwelzow: Add right- and action- lang key for permission [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/143334 (https://bugzilla.wikimedia.org/67352) [15:55:41] (03PS2) 10Florianschmidtwelzow: Add right- and action- lang key for permission [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/143334 (https://bugzilla.wikimedia.org/67352) [16:08:39] (03PS2) 10Dr0ptp4kt: During edit save, describe whether IP or username will be shown. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/143156 [16:09:43] YuviPanda ^ mind reviewing and +2'ing? i updated it to reflect siebrand's feedback [16:43:55] 3Wikipedia App / 3Android App: Unparseable date crashes - 10https://bugzilla.wikimedia.org/67372 (10Alex Monk) 3NEW p:3Unprio s:3normal a:3None STACK_TRACE=java.lang.RuntimeException: java.text.ParseException: Unparseable date: "2014-06-17T00:00:00Z" (at offset 5) at org.wikipedia.beta.bridge.StyleLo... [16:49:39] 3Wikipedia App / 3Android App: Unparseable date crashes - 10https://bugzilla.wikimedia.org/67372#c1 (10Alex Monk) 5NEW>3RESO/FIX a:3Dmitry Brant Woops, looks like this was fixed in Gerrit change 141964, hopefully [17:05:05] Maryana, I'm still on bart [17:06:37] 3MobileFrontend / 3stable: mobile table of contents icon needs to be flipped for RTL - 10https://bugzilla.wikimedia.org/66771#c4 (10Florian) 5PATC>3RESO/FIX Change merged and deployed (tested), set to fixed. [17:19:58] (03CR) 10Deskana: [C: 04-1] "We need to keep the text in the edit workflow as minimal as possible, so I'm really against adding prose into the edit workflow if you're " [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/143156 (owner: 10Dr0ptp4kt) [17:21:01] (03CR) 10Dr0ptp4kt: "Cool, will update patchset." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/143156 (owner: 10Dr0ptp4kt) [17:23:14] (03CR) 10Deskana: "The prose should be as follows:" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/143156 (owner: 10Dr0ptp4kt) [17:26:45] (03PS1) 10Dr0ptp4kt: Try to warn if connection is broken during search. [apps/firefox/wikipedia] - 10https://gerrit.wikimedia.org/r/143354 [17:27:43] ^ yurikR [17:27:47] that's the ffos one [17:30:02] (03CR) 10Yuvipanda: [C: 032] Change edit workflow licensing text to include a link to the Terms of Use, per a legal requirement. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/143247 (owner: 10Deskana) [17:30:09] Deskana: congrats! :) [17:30:20] YAY! :) [17:30:25] Deskana: :) [17:30:38] (03Merged) 10jenkins-bot: Change edit workflow licensing text to include a link to the Terms of Use, per a legal requirement. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/143247 (owner: 10Deskana) [17:30:43] Deskana: :) ty [17:35:42] Deskana: OTRS is a great channel too [17:36:54] hehe, so much iOS [17:39:15] Deskana: what do you think about changing it from 'the IP address of your device' to 'your current internet IP address'? i'm aware that's like saying 'atm machine', but it would be more accurate. i'm sort of hesitant about the 'more privacy' verbiage as it's subjective, although i subjectively agree with it, so no further comment there. if you're okay with the change on the 'your device' verbiage, i can submit an update for iOS; if no [17:39:15] change, then will go with the boilerplate provided. one thing to remember in the future: we should not be telling users that their ip address changes frequently; it simply is not true in a nontrivial number of cases. [17:39:18] i gotta start reviewing those incoming messages soon huh :) [17:40:05] dr0ptp4kt: The wording I gave you is the wording we use on iOS. So it's vbamba you need to convince, not I. :) [17:40:36] vbamba: see above. what do you think? [17:43:42] Deskana: just emailed vbamba in case or netsplits. btw, you been having any irc issues the last couple days? [17:43:49] s/or/of/ [17:44:00] dr0ptp4kt: Not really, other than those caused by office wifi. :P [17:44:13] Deskana: ha [17:55:07] dr0ptp4kt: Deskana can i check after our planningmeeting? [17:55:08] at 12? [17:55:22] vbamba: cool [17:55:35] vbamba: Yes. The patch will not be merged in the meantime. :) [17:56:10] * YuviPanda wonders if he'll actually say anything at all in this meeting, since it's all pretty much web focused [18:02:13] (03PS6) 10Kaldari: Minerva Desktop: fix TOC [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/143062 (https://bugzilla.wikimedia.org/67101) (owner: 10Florianschmidtwelzow) [18:03:05] (03CR) 10Kaldari: [C: 032] Minerva Desktop: fix TOC [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/143062 (https://bugzilla.wikimedia.org/67101) (owner: 10Florianschmidtwelzow) [18:04:17] (03Merged) 10jenkins-bot: Minerva Desktop: fix TOC [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/143062 (https://bugzilla.wikimedia.org/67101) (owner: 10Florianschmidtwelzow) [18:05:07] 3MobileFrontend / 3stable: In desktop mode, Minerva appends the table of contents to the end of the article - 10https://bugzilla.wikimedia.org/67101 (10Florian) 5PATC>3RESO/FIX [18:06:21] somone for mobile-web things online? [18:06:26] * Steinsplitter waves [18:06:40] Steinsplitter: mostly in meeting but ask away :D [18:08:46] there was a change for tables, now tablets are seeing only the mobile web interface if i am right? [18:08:57] is there a statistic abou it? [18:09:11] brion: do let me know if the meeting's back up [18:09:20] Deskana: awjr poke when meeting's back up? [18:09:20] vbamba: http://blog.wikimedia.org/2014/06/17/wikimedia-sites-get-a-new-look-on-tablets/ [18:09:20] take a look at the comments ^ [18:09:28] YuviPanda it's back-ish [18:10:18] awjr: poke when back back? being in a room when chitchat happens feels sad :( [18:10:30] YuviPanda it's happening :) the conversation is continuing [18:10:34] awjr: :) ok [18:10:44] are you still having a hard time following? [18:10:49] awjr: no, joining in again [18:10:59] kk [18:11:49] okay, mabye because of this there is moor mobile web spam (=uploads) :/ [18:13:14] Deskana: do point out OTRS for qualitative data, if you feel like :) [18:13:23] * YuviPanda joined in halfway [18:14:27] folks on the hangout - we have a camera pointed at the whiteboard that maryana is talking about :) [18:14:39] StevenW: can you thank me on this page - https://www.mediawiki.org/wiki/Talk:Beta_Features/Hovercards [18:14:42] just tseting [18:15:15] YuviPanda brion dbrant dr0ptp4kt bearND ^^^ [18:15:24] awjr: yeah, is useful [18:15:43] \o/ [18:16:11] awjr: thank you [18:16:16] awjr: it's cropped though, can't see the top :) [18:16:30] awjr: thx [18:16:39] YuviPanda violetto is trying to fix it [18:16:40] better? [18:16:46] awjr: can't see bottom :P [18:16:56] now YuviPanda ? [18:16:56] awjr: better now [18:17:15] awjr: MaxSem is in the way [18:17:20] hehe [18:27:23] @Steinsplitter: Yeah, there is a statistic, first numbers sent via mobile-l last week: http://lists.wikimedia.org/pipermail/mobile-l/2014-June/007467.html [18:27:42] @Steinsplitter: https://trello.com/c/LKVK7RfL/351-tablet-switchover-editor-activation (there is the image with the grahpic, too) [18:28:22] http://etherpad.wikimedia.org/p/MobileQ1_2014_2015 [18:28:27] I'm trying to transcribe everything. [18:30:07] thanks, there are quit too much nonsense uploads. is the new filter really working? [18:31:02] Steinsplitter: Tablets are now redirecting to mobile so the audience has greatly increased which may be effecting results. [18:31:18] I believe Maryana is collecting some data to assess what's going on so please be patient :) [18:32:06] Steinsplitter jdlrobson3: My actual stand was, that only autoconfirmed users can see uploadbutton and if the image is detected as useless, the user must click ok, right? [18:32:45] that is correct yes FlorianSW|away. However it is hard to tell what effect these changes had. [18:32:45] i think yes [18:32:54] We might want to explore only showing upload button to editors with < X edits [18:33:09] maybe autoconfirmed is too much of an easy barrier to reach :) [18:33:28] (hard to tell the effect as we've now grown our audience by bringing in all tablet users) [18:33:49] jdlrobson: yeah, i think too, but isn't abusefilter checking all uploads? Maybe it's better to create a new filter with the edit_count < X [18:34:21] it is not possible to scan filedescriptioncontent with AWB [18:34:26] *ABF i mean [18:34:44] Deskana: <3 [18:40:44] Steinsplitter: the upload goes via the API and, so i have seen in my short look, abusefilter errors are evaluated as error response, for now i don't know, what is checked from ABF [18:50:01] (03PS1) 10Mhurd: Scrolling web view shows/hides chrome. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/143371 [18:50:55] brion: ^ [18:50:57] :) [18:51:04] \o/ [18:51:37] (03CR) 10Mhurd: [C: 032 V: 032] "Looks good. Good catch!" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/143052 (https://bugzilla.wikimedia.org/67222) (owner: 10Brion VIBBER) [19:04:49] dbrant: bearND I won't be doing much CR this week, will have to limit whatever keyboard time I have to the nightmode patch :( can you guys CR each other's patches? [19:05:14] YuviPanda: alright; no worries [19:46:31] (03PS1) 10Ori.livneh: Fix crash in tests when array elem missing [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/143386 [19:55:12] Deskana: I'm going to rest my arm and go to sleep. Anything you need before that? [20:03:16] alright, I shall take that as a no [20:03:19] * YuviPanda waves to night [20:10:50] brion: have a minute for cr? https://gerrit.wikimedia.org/r/#/c/143371/ [20:12:59] moment [20:25:58] (03PS2) 10Mhurd: Scrolling web view shows/hides chrome. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/143371 [20:26:01] brion: did a quick amend ^ [20:26:11] whee [20:26:19] * brion roots around for his pile o’ iphones [20:30:52] brion: one more quick amend? it’s just one line :) [20:30:57] ok :D [20:32:01] (03PS3) 10Mhurd: Scrolling web view shows/hides chrome. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/143371 [20:32:09] brion: ^ sry that’s the last one i promise! :) [20:35:54] YuviPanda|zzz: basic colors are in the etherpad [20:40:35] brion: think it’s ok if i cut build with that scroll patch before we merge it? [20:43:32] (03CR) 10Brion VIBBER: [C: 04-1] "If I scroll down (hiding the bar), then switch from portrait to landscape, the view jumps to the top of the page but the bar is still hidd" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/143371 (owner: 10Mhurd) [20:43:47] brion: lemme check... [20:46:08] brion: ah! so prob and issue, but unrelated to this patch i believe. what’s happening is before rotate it sees which section was onscreen, then after rotate it scrolls to the top of that section. [20:46:17] *prob an issue* [20:46:50] brion: it’s non-trivial to fix because to do so “correctly” you’d have to know how the text and images will re-flow in other orientation [20:47:17] brion: so for now scrolls to top of section, which is easier to know. had same issue on android i believe [20:48:08] (03CR) 10Mhurd: "unrelated to this patch i believe. what’s happening is before rotate it sees which section was onscreen, then after rotate it scrolls to t" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/143371 (owner: 10Mhurd) [20:48:20] brion: added comments to patch [20:48:21] interaction between the overscroll-to-refresh and the scroll-to-reveal-toolbar seems a bit wonky at the top of the article n iOS 6 also [20:48:33] brion: checking... [20:48:40] … and on 7 [20:49:24] brion: ah! i’m seeing that too… just a minute... [20:49:37] scrolling down, then following a link to a new article jumps to the top of the new article but doesn’t reshow the toolbar [20:50:09] brion: that was intentional. do you think it should always reshow the menus if a link is followed? [20:50:23] (03CR) 10Brion VIBBER: "Interaction between the overscroll-to-refresh and the scroll-to-reveal-toolbar seems a bit wonky at the top of the article in both iOS 6 a" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/143371 (owner: 10Mhurd) [20:50:27] mhurd: oh yeah [20:50:33] at least i would expect so [20:50:42] at the top == the bar is shown [20:51:09] safari reshows the url bar and toolbar when following a link [20:51:40] so does chrome [20:51:56] brion: i would think if a user was in full screen mode they should stay in full screen mode. but i see that’s not a common pattern... [20:52:08] brion: ya just confirmed on chrome too [20:52:13] as soon as they scroll down they’ll be back to fullscreen [20:52:23] but not having a visible ‘back’ button after following a link seems like a mistake to me :) [20:52:50] brion: cool. so 2 things to fix: show when nav to new page, and wonky pull to refresh interaction? [20:53:11] and if we do jump to top on rotation, the bar shouldn’t be hidden [20:54:32] brion: i think i’d only disagree about that last one. (chrome leaves it hidden on rotate if it was already hidden) [20:54:56] mhurd: chrome retains your position correctly as well [20:55:03] it doesn’t jump to the top [20:56:11] brion: on my phone it doesn’t retain the position correctly - just confirmed. it will vary in accuracy if more images are present above the section you are reading. same issue unfortunately [20:56:26] brion: *chrome doesn’t* [20:56:49] mhurd: on what page do you see that problem in chrome? [20:57:11] google/news scroll about half way down then rotate [20:57:52] brion: problem becomes worse the farther down a long page you have scrolled [20:58:05] mhurd: that may be specific to the way google news lays out its page [20:58:13] try wikipedia [20:59:02] may change, but still doesn’t jump to top [21:00:28] brion: it’s only jumping to the top if you were reading the first section, the top of which is also top of page [21:00:50] right… if you do jump to the top of the page, the toolbar should show because the toolbar shows when you go the top of the page [21:03:10] or at least, scrolling up from the top of the page needs to show the toolbar again :D [21:03:39] which currently it doesn’t, as you fall partway into the refresh tool and then it jumps back a couple pixels so you can never pull it down enough [21:04:29] brion: ah. we were talking about 2 different things. i see what you [21:04:44] brion: i see that behavior now [21:04:55] \o/ [21:05:31] brion: fixing... [21:08:47] brion: Sir, please let me know if you have any questions about the footer [21:09:28] vbamba: i’m ready to roll thanks :) [21:09:30] oh actually [21:09:43] vbamba: should they have a visual highlight effect during tap? [21:37:11] brion: No visual effect. Each of these will invoke panels that scroll up which is good feedback. [21:37:28] thank you for checking :) [21:37:31] vbamba: great :D [21:44:44] Hey mobile folks [21:44:52] If I have MobileFrontend installed locally, how do I enable VE? [21:45:09] hm, i think i got it working once but i forget how :D [21:45:11] I tried the beta preference but it doesn't stick, and last I knew there was some query string / URL manipulation that could do it [21:45:12] lemme check [21:45:18] the web guys are in meeting and might not be watching irc [21:45:27] * RoanKattouw also updates MF from an ancient version, oops :) [21:46:20] RoanKattouw: you’ll at least need to go into the settings from the mobile menu and enable ‘beta’ mode [21:46:34] not sure if anything else is needed or not if you’ve already got VE set up [21:46:35] brion: i’m so glad you -1’ed that patch - it had some mushy toggle nonsense going on… got it mostly wrangled [21:46:36] brion: The problem is those settings don't stick at all [21:46:48] hmm, that’s not good [21:46:52] If I set it to beta, then come back into the settings menu to then enable alpha, beta is off again [21:47:09] Max looked at this and decided that rather than fix it he'd give me the query string trick [21:47:13] hmmm that’s not good [21:47:17] And ?mobileaction=alpha does seem to do /something/ [21:47:19] But I see no VE links [21:47:50] mhurd: :D [21:51:03] Ugh, whatever, I'll just merge this change [21:51:15] If it does display weird, it's their problem :D [21:51:55] heh [21:53:44] (03PS1) 10Yurik: Fixed defaults to allow non-configured extension to work per bug 67142 [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/143491 [21:54:52] dr0ptp4kt, could you +2 ^ [21:56:34] yurikR: we're confident this will work because on zero.wikimedia.org it's actually supposed to store locally, right? [21:56:47] dr0ptp4kt, yep [21:56:56] (03CR) 10Dr0ptp4kt: [C: 032] "Please test on beta." [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/143491 (owner: 10Yurik) [21:57:01] ^ yurikR there you go [21:57:08] (03Merged) 10jenkins-bot: Fixed defaults to allow non-configured extension to work per bug 67142 [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/143491 (owner: 10Yurik) [21:57:12] dr0ptp4kt, zeroportal doesn't make sense without local storage [21:57:43] yurikR: agreed [21:58:22] (03CR) 10MaxSem: [C: 032] Fix crash in tests when array elem missing [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/143386 (owner: 10Ori.livneh) [21:58:58] (03CR) 10MaxSem: [C: 032] 18n: native digits on 'pager-older-n' [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/143250 (owner: 10Reza) [21:59:17] (03Merged) 10jenkins-bot: Fix crash in tests when array elem missing [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/143386 (owner: 10Ori.livneh) [21:59:38] (03Merged) 10jenkins-bot: 18n: native digits on 'pager-older-n' [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/143250 (owner: 10Reza) [22:01:50] (03CR) 10MaxSem: "Instead of forcing extensions to alter both desktop and mobile forms, I'd prefer to have a shared login page." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/142874 (https://bugzilla.wikimedia.org/52059) (owner: 10Florianschmidtwelzow) [22:03:21] thx MaxSem [22:25:22] jdlrobson3: I have an iPhone that is apparently yours here. [22:25:24] jdlrobson3: I need it! [22:25:26] jdlrobson3: Are you around so I can unlock it? [22:25:35] i don't have an iPhone [22:25:44] It's called "Jon Robson's iPhone" [22:25:53] yeh jgonera pointed it out but i know nothing about this [22:26:12] Well, I am going to wipe it then! [22:26:18] However I do that. [22:26:40] Thanks. [22:39:36] 3MobileFrontend / 3General/Unknown: tapping on the search input in mobile frontend takes you to previous page - 10https://bugzilla.wikimedia.org/67140#c8 (10Juliusz Gonera) Yeah, saw it on enwiki the other day too... [22:41:39] brion: so i think i got it working… tap on title bar now always does what you’d expect. nav appears when following links. logic is more clean etc… [22:41:49] awesome, gimme a sec and i’ll test [22:41:58] brion: submitting now [22:42:00] (03PS4) 10Mhurd: Scrolling web view shows/hides chrome. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/143371 [22:42:16] brion: ^ oh and the pull to refresh jitter is gone :) [22:42:59] \o/ [22:46:01] ahhh much smoother :D [22:47:15] brion: yay! [22:47:42] brion: good catch… a bit thing for me to miss! [22:47:54] (03CR) 10Brion VIBBER: [C: 032 V: 032] "Much smoother. :) Still hides the toolbar on rotate when in the first section, but scrolling up from there works as expected so I'm fine w" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/143371 (owner: 10Mhurd) [22:47:59] brion: i was rushing a bit [22:48:04] brion: ah cool! [22:48:06] mhurd: that’s why we have code review. :D sometiems easy to miss things [22:48:14] hehe [22:48:16] yup [22:51:39] brion: think i’ll cut build… [22:52:36] mhurd: go for it [22:53:01] brion: yay! we’re looking good for this spring :) [22:53:09] brion: *sprint* [23:01:01] jgonera: Any chance you could merge https://gerrit.wikimedia.org/r/#/c/143219/ so we can lightning deploy it? [23:05:45] brion, just deployed your fix - please verify:) [23:07:05] mhurd: downloading the goodies [23:08:04] vbamba1: :) [23:11:55] mhurd: chrome is looking good [23:12:02] 8-) [23:12:19] <:o) [23:16:11] \o/ [23:16:26] jgonera, http://jeffreyhobson.github.io/snake [23:16:40] yurikR, thanks, looking at it [23:22:24] (03PS1) 10Mhurd: Quick fix for space above onboarding globe on iOS 6. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/143509 [23:22:55] (03CR) 10Mhurd: "This is mostly apparent on 3.5 inch devices." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/143509 (owner: 10Mhurd) [23:23:20] brion: a tiny patch ^ [23:30:01] whee [23:30:45] running errand… back in 45 min [23:32:51] (03CR) 10Brion VIBBER: [C: 032 V: 032] Quick fix for space above onboarding globe on iOS 6. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/143509 (owner: 10Mhurd) [23:55:15] Is there a bug about the create account CTA showing up after every iOS update even if you are already logged in? [23:55:51] brion: Do we have a windows phone in the office? [23:56:32] vbamba: there should be some windows phone 7.5 devices at least [23:56:43] i have a windows phone 8.1 device here, i can bring it in if you want to test it and can’t find another [23:56:51] (8.1 is prerelease still i think tho) [23:56:55] (03PS3) 10Dr0ptp4kt: During edit save, describe IP edit and offer login if appropriate. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/143156 [23:56:58] (03CR) 10jenkins-bot: [V: 04-1] During edit save, describe IP edit and offer login if appropriate. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/143156 (owner: 10Dr0ptp4kt) [23:57:19] ragesoss: in the app? yeah that’s a temporary behavior for testing [23:57:25] we should prolly fix it :D [23:59:54] (03PS4) 10Dr0ptp4kt: During edit save, describe IP edit and offer login if appropriate. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/143156