[00:00:04] Ack! I can't edit a semi protected page on mobile, via mfe or either app. [00:00:22] brion: that would be great [00:00:51] Deskana: ^^ i think that may do it^ [00:01:01] (143156) [00:01:26] Err... Rather, just not in the apps. [00:01:39] Works on mfe. [00:03:38] Deskana: wrapping up. 'night [00:04:54] Okay... On android it was just the issue where the app didn't realize I was signed out [00:05:46] But on iOS I still can't edit a semi-protected page even after logging out and back in. [00:06:08] Known issue, Brion? ^ [00:13:09] 3Wikipedia App / 3iOS App: Auto log-in across updates - 10https://bugzilla.wikimedia.org/67400 (10Julie) 3UNCO p:3Unprio s:3enhanc a:3None Each time I install a new update from TestFlight, I have to log-in again. Other iOS apps keep me logged in even after updates. It would be great if the Wikipedi... [00:13:38] 3Wikipedia App / 3iOS App: Auto log-in across updates - 10https://bugzilla.wikimedia.org/67400 (10Julie) [00:14:16] jgonera, kaldari: [17:14] grrrit-wm (PS1) Catrope: Use globalOverlay as the contextOverlay in MobileContext [VisualEditor/VisualEditor] - https://gerrit.wikimedia.org/r/143524 [00:14:30] Liiitle bug where the link inspector suggestions weren't showing at all :) [00:26:17] kaldari: Oh also: [16:51] grrrit-wm (PS1) Catrope: Split mwtransclusion and mwreference into core and non-core modules [extensions/VisualEditor] - https://gerrit.wikimedia.org/r/143518 [00:27:04] That makes references and templates recognized but uninspectable in mobile [00:27:07] as well as reference lists [00:27:23] It also avoids loading a whole bunch of code for reference/templating editing UI [00:28:30] RoanKattouw: thanks! [00:49:59] (03CR) 10Jdlrobson: [C: 032] Fix editing message in source editor... [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/143219 (owner: 10Kaldari) [00:50:28] (03Merged) 10jenkins-bot: Fix editing message in source editor... [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/143219 (owner: 10Kaldari) [04:03:23] 3Wikipedia App / 3iOS App: iOS App: "Allow Wikimedia to collect information about how you use the app..." is extremely vague - 10https://bugzilla.wikimedia.org/67405 (10Kunal Mehta (Legoktm)) 3NEW p:3Unprio s:3major a:3None Like, what is it collecting? My browsing history? Saved pages? Does it record... [04:09:06] 3Wikipedia App / 3iOS App: iOS App: Auto log-in across updates - 10https://bugzilla.wikimedia.org/67400#c1 (10Kunal Mehta (Legoktm)) s:5enhanc>3normal I think this is intentional for now (Brion or Monte can confirm). The release email for #29 said: "Onboarding screen with create account and sign in butto... [04:28:21] 3Wikipedia App / 3iOS App: iOS App: "Last Modified..." should be clickable and take you to page history - 10https://bugzilla.wikimedia.org/66908#c1 (10Kunal Mehta (Legoktm)) "Brion is working on this right now" [04:30:07] 3Wikipedia App / 3iOS App: iOS App: "Last Modified..." should be clickable and take you to page history - 10https://bugzilla.wikimedia.org/66908 (10Kunal Mehta (Legoktm)) [04:30:07] 3Wikipedia App / 3iOS App: iOS App: "W" menu needs reorganization - 10https://bugzilla.wikimedia.org/65824#c12 (10Kunal Mehta (Legoktm)) Once bug 66908 is fixed, we can remove page history from the hidden submenu, leaving us with no page specific items in it. [07:09:37] (03CR) 10Florianschmidtwelzow: "Yeah, that would be much better. I have tested it on my local wiki, and the current login form looks pretty good, with little styling issu" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/142874 (https://bugzilla.wikimedia.org/52059) (owner: 10Florianschmidtwelzow) [07:18:26] (03PS1) 10Yurik: Refactoring to support complex nested validations [extensions/JsonConfig] - 10https://gerrit.wikimedia.org/r/143573 [07:22:30] (03PS1) 10Yurik: Updated validators to match JsonConfig change I4ab5dfee792cb [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/143574 [07:26:48] (03PS1) 10Yurik: Updated Viewer to match JsonConfig change I4ab5dfee792cb [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/143575 [08:19:08] (03PS2) 10Yurik: Refactoring to support complex nested validations [extensions/JsonConfig] - 10https://gerrit.wikimedia.org/r/143573 [08:21:47] (03PS2) 10Yurik: Updated validators to match JsonConfig change I4ab5dfee792cb [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/143574 [10:17:55] (03PS3) 10Yurik: Refactoring to support complex nested validations [extensions/JsonConfig] - 10https://gerrit.wikimedia.org/r/143573 [10:24:44] Hi! How can I enable jquery.ui.autocomplete module in MobileFrontend? [10:25:14] It is a dependency for js module in the extension I am working on. [10:27:43] Djain: I think we are going to move out of jquery.ui entirely [10:37:12] (03PS4) 10Yurik: Refactoring to support complex nested validations [extensions/JsonConfig] - 10https://gerrit.wikimedia.org/r/143573 [14:13:45] why is stopMobileRedirect set as an https cookie ? [14:14:08] or rather as a 'secure' cookie ? [14:20:51] 3MobileFrontend / 3stable: MobileFrontend doesn't remember user choice (mobile/desktop) in some use cases - 10https://bugzilla.wikimedia.org/54885#c17 (10Derk-Jan Hartman) also, when on https, the stopMobileRedirect cookie is set with the 'secure' flag on. That means it won't be visible if the user enters fr... [15:14:01] (03PS2) 10Dbrant: [WIP] Abusefilter changes in Edit workflow. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/143024 [15:53:38] (03PS2) 10Dbrant: Add credit to translatewiki.net translators [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/142236 (owner: 10Amire80) [15:54:51] (03CR) 10Dbrant: [C: 032] Add credit to translatewiki.net translators [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/142236 (owner: 10Amire80) [15:59:57] WMF has never made any paid apps, right? [16:07:30] (03CR) 10Dbrant: Add link from create account to login (031 comment) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/143204 (owner: 10BearND) [16:10:03] (03CR) 10Dbrant: [C: 032] Wikify README [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/142785 (owner: 10Whym) [16:10:45] (03CR) 10BearND: Add link from create account to login (031 comment) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/143204 (owner: 10BearND) [16:11:03] (03PS2) 10Dbrant: Don't duplicate history entry if the same item is clicked twice. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/142525 (https://bugzilla.wikimedia.org/66760) [16:11:34] (03PS2) 10Dbrant: Hide keyboard when exiting interlanguage activity. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/142528 [16:11:45] (03PS2) 10Dbrant: Make inter-language highlight consistent with other highlights. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/143051 [16:12:00] (03PS2) 10Dbrant: Fix possible crash(es) related to find-in-page. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/143310 [16:12:32] bearND: ^ some CR, when you get a chance? I've got several patches backed up [16:13:07] dbrant: sure. just wrapping up a patch for onboarding [16:13:47] dbrant: i also responded to your comment in https://gerrit.wikimedia.org/r/143204 [16:14:57] (03CR) 10Dbrant: Add link from create account to login (031 comment) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/143204 (owner: 10BearND) [16:27:51] (03PS3) 10BearND: [WIP] Add onboarding screen [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/143205 [16:39:28] Someone here speaks German, right? Is it you, bearND? [16:40:27] Krenair: jawohl [16:41:31] bearND, https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom;TicketID=7612242 [16:42:13] I have no idea what this is about [16:42:32] Krenair: hmm, not sure what he's referring to. His space keys are gone. [16:44:53] Krenair: Would you like me to respond with some clarifying questions? [16:45:15] sounds good [16:46:41] Krenair: ok [16:52:19] chrismcmahon: are you here? :) [16:52:28] hi FlorianSW [16:53:55] hi :) If i look right, you're a software tester? :) Is it possible, that you take a look at my little unit test for my extension? I'm unsure, if this is the right :) [16:54:06] @chrismcmahon [16:54:16] * YuviPanda waves [16:54:58] Hi YuviPanda :) [16:55:00] heya [16:55:41] FlorianSW: what is the extension? I am more of a UI-level tester, I write and maintain most of our Selenium tests. But go ahead and let me know the link... [16:56:38] @chrismcmahon Ah, ok :) It's phpunit, an extension to provide a login with Google account: https://gerrit.wikimedia.org/r/#/c/143623/ [16:58:06] FlorianSW: jgonera is probably a better reviewer than me for https://gerrit.wikimedia.org/r/#/c/143623/ [16:58:30] ok, thanks :) [16:59:16] hey YuviPanda [16:59:57] @jgonera: Have you one minute? :) [17:01:14] dbrant: bearND hey! [17:01:24] probably won't be doing much typing today either, I'm afraid :( [17:01:41] Maryana, awjr I missed my regular Bart, I'll be a few minutes late [17:02:02] YuviPanda: can I be added as a member to our GitHub repo? (for completeness' sake) [17:02:21] dbrant: usre [17:02:23] *sure [17:02:26] dbrant: username? [17:02:34] YuviPanda: dbrant [17:03:37] dbrant: done [17:03:46] YuviPanda: thx! [17:05:11] Deskana: gah, forgot to give you numbers. 5 million users on the new app, with 5 million still to upgrade. [17:17:40] Deskana: isn't the annual goal just 'we will see what happens and decide'? That's what the email said, IIRC [17:18:31] Deskana: from email 'Mobile goals for next fiscal year: help decide your fate! ' [17:18:44] YuviPanda: Yes and no. [17:18:49] YuviPanda: Mobile overall has goals. [17:19:37] Deskana: ah, right. makes sense, ty for clarification [17:21:23] 3MobileFrontend / 3General/Unknown: MobileFrontend: Blue "issues" icon should have HiDPI version (or SVG) - 10https://bugzilla.wikimedia.org/67423 (10Krinkle) 3NEW p:3Unprio s:3normal a:3None Created attachment 15813 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15813&action=edit Screenshot... [17:23:30] (03PS2) 10BearND: Add link from create account to login [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/143204 [17:25:24] ETHERPAD [17:25:24] http://etherpad.wikimedia.org/p/AppsQ120142015 [17:25:33] FlorianSW, reviewed [17:25:39] Deskana: ty [17:25:52] jgonera: big thanks :) [17:26:17] lawl http://colinm.org/language_checklist.html [17:35:53] dr0ptp4kt, around? [17:36:08] yurikR2: yeah. i'm on the mobile apps planning hangout [17:36:21] yurikR2: what's up? you wanna deploy that ffos patch? :) [17:37:09] i was looking at the watchlist patch, something doesn't make sense: the watchlist already has this structure: [17:37:12]
[17:37:18] YuviPanda: I'm seeing red links on android [17:37:37] 'See Geoffrey Plantagenet Count' of Anjou article [17:38:28] dr0ptp4kt, and you are setting it again to 'listThumb icon icon-max-x' [17:39:46] (03PS1) 10Dbrant: Hide "send feedback" if no email app installed. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/143644 (https://bugzilla.wikimedia.org/67322) [17:40:38] yurikR2: it's to have it have a specific style that will create the correct amount of padding. the style varies by whether there's a thumbnail or not. [17:41:24] dr0ptp4kt, are you saying there are some watchlist items that i'm not seeing that have different class? [17:41:24] vbamba: yea, it's in the next sprint. sounds like an API thing, will do [17:41:49] yurikR2: yeah. unless my memory is failing from last time i looked. [17:42:43] dbrant: do feel free to butt in at any lull. it is a tiny bit painful when there is a large local contignent :) [17:42:57] dr0ptp4kt, when the icon is missing, the HTML is this:
[17:43:09] YuviPanda: of course [17:43:10] yurikR2: yay for my memory! [17:43:50] dr0ptp4kt, but if you remove the "needsPhoto", it will become a gray square [17:44:45] dr0ptp4kt, is that the behaviour you want? [17:47:21] yurikR2: booting up vagrant. [17:47:41] dr0ptp4kt, would it make sense to simply delete that
? Also, I think we should talk to mobile team to have a hook instead - this way they can avoid generating them and make the UI cleaner [17:47:48] yurikR2: i thought the color was see through, or that is, the same as the actual article title background. lemme look [17:48:10] dr0ptp4kt, deleting
leaves a blank space [17:48:26] i wonder if we can somehow remove it [17:49:22] same as removing 'needsPhoto' class [17:52:07] yurikR2: yeah, if you want to remove the
, that's cool. [17:52:32] dr0ptp4kt, i'm saying that i don't think we should have this kind of logic - rather lets add a hook to mobile? [17:53:23] MaxSem, what do you think? (context: mobile watchlist has icons that zero needs to hide - https://en.m.wikipedia.org/w/index.php?title=Special:Watchlist ) [17:53:27] yurikR2: a hook is fine, but should we deploy a fix now and then get the hook later? [17:53:41] dr0ptp4kt, you might have a point :) [17:54:12] quick fix and then create a hook [17:54:44] dr0ptp4kt, one note - you are also hiding it on lowquality, non-zerodot. Is that by design? [17:55:27] yurikR2: checking in vagrant, one moment [17:57:44] yurikR2: yeah, i was doing that intentionally. [17:58:05] yurikR2: BUT, i think for the follow on patch we could add the low quality thumb rewriting of the background-image for mdot low quality [17:58:22] thx [17:58:27] by that time we may have an operator that is willing to enroll in the thumbnail downsizing. cool? [17:58:57] (03CR) 10Yurik: [C: 032] "This really needs to be done via a mobile hook. Temporary patch, to be removed later." [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/142609 (owner: 10Dr0ptp4kt) [17:59:10] (03Merged) 10jenkins-bot: Hide Watchlist thumbnails on zerodot. [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/142609 (owner: 10Dr0ptp4kt) [18:03:23] (03CR) 10Liangent: Hide "send feedback" if no email app installed. (031 comment) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/143644 (https://bugzilla.wikimedia.org/67322) (owner: 10Dbrant) [18:04:11] bearND: hey! why separately? [18:04:13] (03CR) 10Dbrant: Hide "send feedback" if no email app installed. (031 comment) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/143644 (https://bugzilla.wikimedia.org/67322) (owner: 10Dbrant) [18:04:29] (03CR) 10BearND: [C: 032] Fix possible crash(es) related to find-in-page. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/143310 (owner: 10Dbrant) [18:05:01] (03Merged) 10jenkins-bot: Fix possible crash(es) related to find-in-page. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/143310 (owner: 10Dbrant) [18:05:10] (03PS2) 10Dbrant: Hide "send feedback" if no email app installed. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/143644 (https://bugzilla.wikimedia.org/67322) [18:09:17] yurikR2: also, about that firefox os patch (https://gerrit.wikimedia.org/r/#/c/143354/)....able to get that rolled in? [18:10:59] dr0ptp4kt, i haven't been able to test it yet - just charged my phone, will need to test it first... up to you, should i depl it? [18:12:40] yurikR2: let's deploy, and then i'll run it from my physical phone after it's pushed. if necessary, i'll rev again and then we can re-deploy in the same window. but it should work. it runs fine in the simulator, so the javascript is legit. it's just that i'm having problems tricking the simulator into thinking it's offline...and i haven't taken time to flash my phone to allow a good adb-based (under the hood!) push [18:12:54] yurikR2: yeah, deploy, in other words. let's just be ready to re-deploy /just in case/ [18:13:06] yurikR2: worst case, it is ineffective, yet harmless [18:13:22] dr0ptp4kt, oki [18:13:35] yurikR2: thx, will go get phone powered up [18:14:39] 3MobileFrontend / 3General/Unknown: Mobile is somehow sending API requests that ask for text/html content - 10https://bugzilla.wikimedia.org/67426 (10Oliver Keyes) 3NEW p:3Unprio s:3normal a:3None I've got multiple requests in the logs of the form http://commons.m.wikimedia.org/w/api.php?useformat=m... [18:15:47] http://etherpad.wikimedia.org/p/AppsQ120142015 [18:16:14] (03CR) 10Yurik: [C: 032] "not tested, but according to Adam, should be a noop :)" [apps/firefox/wikipedia] - 10https://gerrit.wikimedia.org/r/143354 (owner: 10Dr0ptp4kt) [18:18:06] (03PS1) 10Kaldari: Hygiene: compressing SVGs while retaining readability/editability [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/143656 [18:19:06] (03CR) 10Yurik: [V: 032] Try to warn if connection is broken during search. [apps/firefox/wikipedia] - 10https://gerrit.wikimedia.org/r/143354 (owner: 10Dr0ptp4kt) [18:26:45] dr0ptp4kt, FF app synced [18:27:09] yurikR2: ok, will try out soon [18:28:52] (03PS1) 10Kaldari: Hygiene: compressing SVGs while retaining readability/editability [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/143661 [18:29:10] yurikR2: installing... [18:29:35] (03Abandoned) 10Kaldari: Hygiene: compressing SVGs while retaining readability/editability [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/143656 (owner: 10Kaldari) [18:30:24] jgonera, kaldari, jdlrobson: Can someone of you take a look to: https://gerrit.wikimedia.org/r/#/c/143334/ It's fix failings of unit tests from core with installed MF :) Has major on Bugzilla [18:30:44] *to -> at [18:31:38] FlorianSW: sure [18:31:51] kaldari: thanks :) [18:33:21] yurikR2: meh, the ffos patch didn't address the underlying issue on ffos 1.1, but it's harmless on it. i guess i will need to flash phone and try another approach [18:37:47] yurikR2: MaxSem: thanks for the $wgJsonConfigs['ZeroPortal'] something fix yesterday. Worked like a charm. Kudos! [18:37:56] hashar, np [18:38:04] dr0ptp4kt, there is a prod bug, rolling back the depl [18:38:42] yurikR2: k [18:39:55] yurikR2: you're talking about ZeroBanner, ZeroPortal, or JsonConfig? [18:40:03] yurikR2: or did the ffos thing cause a problem? [18:40:13] dr0ptp4kt, see logs [18:40:17] yurikR2: if the ffos thing caused a problem, lemme know and i'll rev it so that we can roll forward [18:40:26] dr0ptp4kt, no, ZB [18:40:34] yurikR2: alright, thx [18:40:49] (03CR) 10Dbrant: [C: 032] Add link from create account to login [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/143204 (owner: 10BearND) [18:41:55] yurikR2: search text? [18:42:04] https://logstash.wikimedia.org/#/dashboard/elasticsearch/fatalmonitor [18:42:06] in logstash, what to enter besides "zero"? [18:42:20] dr0ptp4kt, don't enter anything, just look at fatalmon [18:42:37] Deskana: are you drinking wine? [18:42:45] YuviPanda: Water. In a wine glass. [18:42:58] yurikR2: ah, ok, thanks [18:42:58] Deskana: ah, right. My whiskey bottle filled with water has run out of water :( [18:43:58] YuviPanda: time to drink your water bottle filled with whiskey so [18:44:11] hashar: heh :) I'll fill in water in a while again [18:45:57] yurikR2: should i try patching it? i think it just needs to be getTitle() [18:46:19] dr0ptp4kt, almost done with it [18:47:26] (03PS1) 10Yurik: Merge conflict - fixes title access [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/143665 [18:47:29] dr0ptp4kt, please +2 ^ [18:48:03] (03CR) 10Dr0ptp4kt: [V: 032] Merge conflict - fixes title access [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/143665 (owner: 10Yurik) [18:48:21] yurikR2: +2'd. "and that's why you always use methods!" [18:48:41] hehe [18:48:50] dr0ptp4kt, that's why you always use betalabs :) [18:49:05] yurikR2: lol [18:51:05] (03CR) 10Yurik: [C: 032] Merge conflict - fixes title access [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/143665 (owner: 10Yurik) [18:51:47] dr0ptp4kt, you clicked +2 verified :) [18:51:57] (03Merged) 10jenkins-bot: Merge conflict - fixes title access [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/143665 (owner: 10Yurik) [18:53:09] yurikR2: oopsie. looks like you went in to add additional +2. cool [18:59:38] 3Wikipedia App / 3Android App: Wikipedia app should not use Android's built-in localization system for the footer "Last edited" text - 10https://bugzilla.wikimedia.org/67431 (10Jack Phoenix) 3NEW p:3Unprio s:3normal a:3None Created attachment 15816 --> https://bugzilla.wikimedia.org/attachment.cgi?... [19:02:43] kaldari: you said you'd been tagging mobile VE bugs somehow -- how do i find that in bugzilla? [19:05:46] Maryana: https://bugzilla.wikimedia.org/buglist.cgi?keywords=mobile&keywords_type=allwords&list_id=326315&product=VisualEditor&query_format=advanced&resolution=---&resolution=LATER&resolution=DUPLICATE [19:06:27] kaldari: danke schoen [19:13:38] dr0ptp4kt, all depl, pls test [19:13:47] yurikR2: i lost my internet connection [19:13:48] yurikR2: k, will check [19:13:57] thx :) [19:15:05] yurikR2: watchlist working as expected. will run banner check [19:15:13] thx [19:20:46] yurikR2: still running banner check [19:21:05] you know one can do with the new mobile app? [19:21:29] (03PS2) 10Kaldari: Changing TOC icon to be SVG instead of PNG [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/143661 [19:21:35] Blank the Main Page :) [19:21:53] (03CR) 10jenkins-bot: [V: 04-1] Changing TOC icon to be SVG instead of PNG [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/143661 (owner: 10Kaldari) [19:21:53] ANONYMOUSLY [19:22:01] not in English, don't worrry. [19:22:06] In Punjabi: [19:22:13] https://pa.wikipedia.org/w/index.php?title=%E0%A8%AE%E0%A9%81%E0%A9%B1%E0%A8%96_%E0%A8%AA%E0%A9%B0%E0%A8%A8%E0%A8%BE&action=history [19:23:50] (03PS3) 10Kaldari: Changing TOC icon to be SVG instead of PNG [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/143661 [19:24:39] yurikR2: banners came back okay [19:25:45] (03PS4) 10Kaldari: Changing TOC icon to be SVG instead of PNG [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/143661 [19:28:38] thx dr0ptp4kt ! [19:36:23] dr0ptp4kt, let me know when you can +2 everything :) [19:36:42] really want to get the refactoring in so that it at least goes on betalabs [19:38:22] (03PS1) 10Kaldari: Making SVG compression smarter in pre-commit hook [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/143684 [20:04:31] jgonera we're meeting outside of r35 rather than in r35 :) [20:06:50] (03PS3) 10BearND: Hide "send feedback" if no email app installed. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/143644 (https://bugzilla.wikimedia.org/67322) (owner: 10Dbrant) [20:06:57] 3MobileFrontend / 3stable: Filter for New User uploads in Mobile Web - 10https://bugzilla.wikimedia.org/62598#c48 (10Steinsplitter) Okay, There are still 80% nonsense/copyright violation uploads. [20:08:06] 3MobileFrontend / 3stable: Filter for New User uploads in Mobile Web - 10https://bugzilla.wikimedia.org/62598#c49 (10Steinsplitter) Mabye you like to IF globa_editcount = +900 allow mobile upload.? [20:09:24] (03PS1) 10Cmcmahon: QA: Run protected test without explicit logout [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/143745 [20:11:21] (03CR) 10BearND: [C: 032] Hide "send feedback" if no email app installed. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/143644 (https://bugzilla.wikimedia.org/67322) (owner: 10Dbrant) [20:12:00] (03Merged) 10jenkins-bot: Hide "send feedback" if no email app installed. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/143644 (https://bugzilla.wikimedia.org/67322) (owner: 10Dbrant) [20:17:31] Deskana: http://etherpad.wikimedia.org/p/AppsQ120142015 [20:36:41] (03PS1) 10Florianschmidtwelzow: WIP: Add Uploadrestriction using edit count [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/143751 (https://bugzilla.wikimedia.org/62598) [20:37:10] (03PS2) 10Florianschmidtwelzow: WIP: Add Uploadrestriction using edit count [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/143751 (https://bugzilla.wikimedia.org/62598) [20:40:40] (03CR) 10Florianschmidtwelzow: [C: 04-1] "See inline comments. Maybe there is a much better way to do this." (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/143751 (https://bugzilla.wikimedia.org/62598) (owner: 10Florianschmidtwelzow) [20:45:28] (03CR) 10Florianschmidtwelzow: "Ähm, abd: i have no working centralauth installation atm, so this isn't tested (the centralauth code comes from a maintenancescript in CA)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/143751 (https://bugzilla.wikimedia.org/62598) (owner: 10Florianschmidtwelzow) [20:48:11] Deskana: I''ll brb need more water [20:51:39] Deskana: am back. [20:55:12] http://etherpad.wikimedia.org/p/AppsQ120142015 [21:11:12] (03CR) 10Kaldari: [C: 04-1] "This seems a but redundant with the existing functionality. Currently, the upload page-action button is only displayed if the user is auto" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/143751 (https://bugzilla.wikimedia.org/62598) (owner: 10Florianschmidtwelzow) [21:20:51] 3MobileFrontend / 3stable: Filter for New User uploads in Mobile Web - 10https://bugzilla.wikimedia.org/62598#c51 (10Ryan Kaldari) According to http://mobile-reportcard.wmflabs.org/#uploads_daily-graphs-tab, restricting the upload page-action button to autoconfirmed users had no effect on mobile uploads what... [21:20:52] awjr_away: don't leave withotu saying bye :) [21:21:05] YuviPanda, any plans to support Special:Nearby in the android app? [21:21:21] Krenair: not in the next year, I think. Point them to Mobile web? [21:21:50] they're asking about it going away [21:22:03] There's no more menu entry. I tried to go to Special:Nearby and it just opened up in my normal browser [21:22:43] although apparently the mobile one had a map or something. [21:24:58] Krenair: yeah, that map isn't coming back anytime soon [21:25:17] Krenair: so they'll have to live without it, sadly [21:25:22] okay [21:39:51] 3MobileFrontend / 3stable: Filter for New User uploads in Mobile Web - 10https://bugzilla.wikimedia.org/62598#c52 (10Jon) I took a look at data and can confirm the filter is working on /English/ Wikipedia. There have been no uploads from users with an edit count of 0. On the other hand there were uploads fr... [21:44:09] bearND, dbrant|brb - able to review https://gerrit.wikimedia.org/r/#/c/143156/ ? lemme know if you need a quick demo of the corresponding iOS functionality (btw, you guys have iOS toolchain?) cc Deskana|Away [21:48:50] dbrant|brb: tfinc bearND Deskana I'm just going to rest my hand today and not write any code. I'll be off soon, hope that's ok. [21:49:35] YuviPanda: just a quick question for you. For onboarding should we also instrument the skip button? [21:49:43] bearND: yeah, definitely. [21:50:10] bearND: hmm, was Instrumentation part of the card? if not we should maybe make a separate one [21:50:36] 3MobileFrontend / 3stable: Filter for New User uploads in Mobile Web - 10https://bugzilla.wikimedia.org/62598#c53 (10Jon) Kaldari pointed out the above data is not accurate as it uses the edit count on English Wikipedia not the native wiki. I took a look at tablet vs mobile through the lead photo upload ico... [21:50:51] 3Wikipedia App / 3Android App: add the option to have favorite languages in the app - 10https://bugzilla.wikimedia.org/34100 (10Yuvi Panda) [21:51:06] 3Wikipedia App / 3Android App: add the option to have favorite languages in the app - 10https://bugzilla.wikimedia.org/34100#c4 (10Yuvi Panda) Note that this is a very popular request from users of the new app as well. [21:51:18] YuviPanda: How is the server side of the instrumentation usually done? [21:51:36] bearND: right, so you need to create a Schema in metawiki, define the schema, and then check for it. [21:51:44] bearND: I can do a hangout with you tomorrow to show you how it's done? [21:51:54] dbrant|brb: ^ as well [21:51:55] YuviPanda: sounds great [21:51:55] YuviPanda: ^ include me pls [21:52:01] dbrant|brb: yeah, totally [21:52:08] bearND: dbrant|brb you both have stat1003 access now, right? [21:52:14] yep! [21:52:36] cool [21:52:37] YuviPanda: yes, got stat access [21:52:40] dbrant|brb: bearND right after standup? [21:52:48] ok [21:53:02] YuviPanda: works for me [21:53:32] YuviPanda: maybe also pick up the L10N (TWN) stuff if we have time? [21:53:48] bearND: sure. [21:53:58] need to actually get your accounts done, I think. let me poke niklas again [21:54:00] YuviPanda: great :) [21:54:23] bearND: dbrant|brb hmm, I'll also do one on Extension:MobileApp next week, I think [21:54:56] dbrant|brb: YuviPanda: gonna do some more gerrit reviews. Should we do an alpha/beta release today? [21:55:16] bearND: hmm, let's do an alpha? [21:55:23] remember to change the icon back [21:55:24] :) [21:56:05] YuviPanda: ok [21:56:23] (03PS3) 10BearND: Make inter-language highlight consistent with other highlights. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/143051 (owner: 10Dbrant) [21:56:35] (03CR) 10BearND: [C: 032] Make inter-language highlight consistent with other highlights. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/143051 (owner: 10Dbrant) [22:00:07] (03Merged) 10jenkins-bot: Make inter-language highlight consistent with other highlights. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/143051 (owner: 10Dbrant) [22:00:23] bearND: dbrant|brb I sent invites [22:00:48] (03PS1) 10Kaldari: Fix editing message in source editor... [extensions/MobileFrontend] (wmf/1.24wmf11) - 10https://gerrit.wikimedia.org/r/143771 [22:01:27] mhurd: hey! see mobile-tech, I am doing a small hangout tomorrow on how to setup instrumentation end to end, do let me know if you're interested :) [22:01:27] (03PS3) 10BearND: Hide keyboard when exiting interlanguage activity. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/142528 (owner: 10Dbrant) [22:01:45] mhurd: will do one about Extension:MobileApp as well, but that should depend primarily on your availability wrt the iOS app release, etc [22:02:27] YuviPanda: oh cool! i’ll def try to listen in, but ya today got eaten by meetings [22:02:48] mhurd: yeah :) [22:03:09] mhurd: do you want me to invite you? [22:03:22] YuviPanda: ya for sure! [22:03:24] mhurd: I have :) [22:03:28] thx! [22:03:42] mhurd: yw :) I can do this again later for you as well if you want (after things have settled down in iOS land) [22:04:28] (03CR) 10BearND: [C: 032] Hide keyboard when exiting interlanguage activity. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/142528 (owner: 10Dbrant) [22:04:54] (03Merged) 10jenkins-bot: Hide keyboard when exiting interlanguage activity. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/142528 (owner: 10Dbrant) [22:05:49] alright folks [22:05:51] I'm off [22:05:51] cya [22:05:57] later [22:06:39] YuviPanda: cya [22:07:05] (03Abandoned) 10Kaldari: Fix editing message in source editor... [extensions/MobileFrontend] (wmf/1.24wmf11) - 10https://gerrit.wikimedia.org/r/143771 (owner: 10Kaldari) [22:08:54] MaxSem: good news. The regression actually landed the day after the last branch was cut so no need to SWAT deploy [22:09:06] wee [22:10:04] (03CR) 10Kaldari: "If that doesn't work though, we may need to revive this idea :)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/143751 (https://bugzilla.wikimedia.org/62598) (owner: 10Florianschmidtwelzow) [22:21:38] (03PS3) 10BearND: Don't duplicate history entry if the same item is clicked twice. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/142525 (https://bugzilla.wikimedia.org/66760) (owner: 10Dbrant) [22:30:30] dr0ptp4kt: are you there? [22:30:41] Sorry I didn't get to the copy issue [22:30:43] vbamba: yes, hola [22:31:04] vbamba: no problem. i've resubmitted the android patch with the latest copy. [22:31:07] (03PS1) 10JGonera: QA: Remove keep going browser tests [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/143777 [22:31:56] (03PS1) 10Kaldari: Hide Uploads button unless user has adequate permissions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/143778 (https://bugzilla.wikimedia.org/62598) [22:33:04] (03PS2) 10Kaldari: Hide Uploads button unless user has adequate permissions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/143778 (https://bugzilla.wikimedia.org/62598) [22:34:52] MaxSem: Would be great if you could merge this uploads fix before wmf12 is cut tomorrow: https://gerrit.wikimedia.org/r/#/c/143778/ [22:35:31] (03CR) 10MaxSem: [C: 032] Hide Uploads button unless user has adequate permissions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/143778 (https://bugzilla.wikimedia.org/62598) (owner: 10Kaldari) [22:35:39] thanks! [22:35:55] (03CR) 10BearND: [C: 032] Don't duplicate history entry if the same item is clicked twice. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/142525 (https://bugzilla.wikimedia.org/66760) (owner: 10Dbrant) [22:36:06] (03Merged) 10jenkins-bot: Hide Uploads button unless user has adequate permissions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/143778 (https://bugzilla.wikimedia.org/62598) (owner: 10Kaldari) [22:36:19] (03Merged) 10jenkins-bot: Don't duplicate history entry if the same item is clicked twice. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/142525 (https://bugzilla.wikimedia.org/66760) (owner: 10Dbrant) [22:38:48] vbamba: any time for toc questions? [22:39:36] 3MobileFrontend / 3stable: Filter for New User uploads in Mobile Web - 10https://bugzilla.wikimedia.org/62598#c56 (10Ryan Kaldari) In the meantime, we've added a new change which also hides the Upload button in the left menubar unless the user is autoconfirmed. If that doesn't improve things, we may need to... [22:48:10] mhurd: yeah sure [22:48:13] whats up [22:52:51] 3MobileFrontend / 3stable: Filter for New User uploads in Mobile Web - 10https://bugzilla.wikimedia.org/62598#c57 (10Maryana Pinchuk) I just took a look at the deletion stats -- while the autoconfirmed change did decrease the total number of uploads coming from the in-article upload button, as opposed to the... [22:56:06] (03PS1) 10JGonera: QA: Remove protected page step from stable page loading [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/143786 [22:57:15] (03CR) 10Cmcmahon: [C: 04-1] "Also remove keep_going_element from whatever page it is on?" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/143777 (owner: 10JGonera) [23:01:58] chrismcmahon, I have no idea why Search.Search for partial text doesn't create a test page on beta labs [23:03:53] Maryana, it seems full text search is broken, but not only on mobile but also on desktop, that's why some of our search tests are failing [23:07:03] uh oh [23:07:15] well, then that's out of our hands, i guess [23:08:17] Not broken. Shaky, though. [23:08:23] jgonera: getting weird results in Template search in VE also [23:09:06] chrismcmahon, full text search seems to be broken in core but that should not affect partial title search [23:09:34] Full text search is working for me on [[Special:Search]]. [23:12:22] (03PS1) 10JGonera: QA: Fix Special:Uploads test [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/143789 [23:12:28] (03CR) 10Cmcmahon: [C: 032] QA: Remove protected page step from stable page loading [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/143786 (owner: 10JGonera) [23:13:19] (03Merged) 10jenkins-bot: QA: Remove protected page step from stable page loading [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/143786 (owner: 10JGonera) [23:15:51] (03PS2) 10JGonera: QA: Remove keep going browser tests [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/143777 [23:16:43] (03CR) 10Cmcmahon: [C: 032] QA: Remove keep going browser tests [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/143777 (owner: 10JGonera) [23:17:22] (03Merged) 10jenkins-bot: QA: Remove keep going browser tests [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/143777 (owner: 10JGonera) [23:23:30] 3MobileFrontend / 3stable: Filter for New User uploads in Mobile Web - 10https://bugzilla.wikimedia.org/62598#c58 (10Didym) (In reply to Maryana Pinchuk from comment #57) > (So, Steinsplitter, I don't think the 80% junk rate you quote above is entirely > accurate.) Just have a look at https://commons.wiki... [23:24:08] jgonera: would you be OK with my change here? https://gerrit.wikimedia.org/r/#/c/143745/ [23:31:39] (03CR) 10Cmcmahon: [C: 032] QA: Fix Special:Uploads test [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/143789 (owner: 10JGonera) [23:32:15] (03Merged) 10jenkins-bot: QA: Fix Special:Uploads test [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/143789 (owner: 10JGonera) [23:32:17] 3MobileFrontend / 3beta: MobileFrontend displaying both page and discussion when a talk is opened and closed - 10https://bugzilla.wikimedia.org/67442 (10deanator71) 3UNCO p:3Unprio s:3minor a:3None Created attachment 15820 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15820&action=edit The p... [23:34:15] 3Wikipedia App / 3Android App: crash with NoClassDefFoundError: support.v7.internal.view.menu.MenuBuilder - 10https://bugzilla.wikimedia.org/66263#c9 (10Alex Monk) 5PATC>3NEW There's a *lot* more of these. For example: https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom;TicketID=7637822 ht... [23:43:08] (03CR) 10BearND: [C: 04-1] During edit save, describe IP edit and offer login if appropriate. (032 comments) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/143156 (owner: 10Dr0ptp4kt) [23:48:47] dbrant|brb: going to do the alpha release [23:48:58] bearND: cool [23:49:20] last call for any inclusions [23:49:25] dbrant|brb: ^ [23:49:41] I think we're good [23:50:07] (03CR) 10JGonera: [C: 04-1] "Does this make one test depend on another? Or in other words, makes the order in which tests are run significant?" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/143745 (owner: 10Cmcmahon) [23:51:45] 3Wikipedia App / 3Android App: crash with NoClassDefFoundError: support.v7.internal.view.menu.MenuBuilder - 10https://bugzilla.wikimedia.org/66263#c10 (10Dmitry Brant) Based on the stack traces, these are clearly from the previous version (i.e. the initial release, instead of the newest patched version). It... [23:52:14] (03PS1) 10BearND: Bump version for release 2.0-alpha-2014-07-02 [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/143792 [23:53:06] dbrant|brb: not committing the icon change to alpha (just kept it local) [23:53:29] bearND: sure [23:53:55] (03CR) 10BearND: [C: 032] Bump version for release 2.0-alpha-2014-07-02 [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/143792 (owner: 10BearND) [23:54:17] (03Merged) 10jenkins-bot: Bump version for release 2.0-alpha-2014-07-02 [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/143792 (owner: 10BearND)