[00:04:00] 3MobileFrontend / 3stable: Filter for New User uploads in Mobile Web - 10https://bugzilla.wikimedia.org/62598#c59 (10Steinsplitter) (In reply to Maryana Pinchuk from comment #57) > (So, Steinsplitter, > I don't think the 80% junk rate you quote above is entirely accurate.) Not all uploads will be deleted i... [00:04:45] 3MobileFrontend / 3stable: Filter for New User uploads in Mobile Web - 10https://bugzilla.wikimedia.org/62598#c60 (10Ryan Kaldari) FYI, the latest change (hiding the upload button in the left sidebar menu unless the user is autoconfirmed) should take affect on Thursday, July 10. This basically makes it impos... [00:28:17] (03PS1) 10Kaldari: If error occurs while loading VE, load source editor instead [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/143797 (https://bugzilla.wikimedia.org/66678) [00:30:21] is juliusz out for the day? [00:31:59] Maryana: he's back [00:32:28] jgonera: this looks like it's still failing, no? https://integration.wikimedia.org/ci/view/BrowserTests/job/browsertests-MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-chrome-sauce/ [00:33:00] 3MobileFrontend / 3General/Unknown: Image caption text color is too light - 10https://bugzilla.wikimedia.org/67005#c24 (10Quiddity) Created attachment 15822 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15822&action=edit screenshot1 - 000/333 [00:33:03] or am i not using the right heuristic to determine whether a test is failing? :) [00:33:30] 3MobileFrontend / 3General/Unknown: Image caption text color is too light - 10https://bugzilla.wikimedia.org/67005#c25 (10Quiddity) Created attachment 15823 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15823&action=edit screenshot2 - 000/444 [00:34:00] 3MobileFrontend / 3General/Unknown: Image caption text color is too light - 10https://bugzilla.wikimedia.org/67005#c26 (10Quiddity) Created attachment 15824 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15824&action=edit screenshot3 - 222/555 [00:34:26] (03PS1) 10MaxSem: Revert "Give anons tokens too" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/143799 (https://bugzilla.wikimedia.org/67171) [00:38:01] Maryana, it runs every several hours, plus yes, some of them will still fail, as described in comments on trello card [00:39:45] 3MobileFrontend / 3General/Unknown: Image caption text color is too light - 10https://bugzilla.wikimedia.org/67005#c27 (10Quiddity) I've attached 3 screenshots, of what I see. I would prefer 000/444, and I think it looks good/reasonable. Especially so, for people who have thin fonts by default (eg me on Lin... [00:40:46] (Sorry for the discussion happening in the mobile bug. 'twas not intended.) [00:41:27] (It should be finished, now. Or we can nudge it onwiki, if it continues.) [00:43:56] (03CR) 10Kaldari: [C: 04-1] "This doesn't work since mw.loader.using is asynchronous..." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/143797 (https://bugzilla.wikimedia.org/66678) (owner: 10Kaldari) [01:13:39] (03PS2) 10Kaldari: If error occurs while loading VE, load source editor instead [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/143797 (https://bugzilla.wikimedia.org/66678) [01:40:45] 3MobileFrontend / 3General/Unknown: Image caption text color is too light - 10https://bugzilla.wikimedia.org/67005#c28 (10Jared Zimmerman (WMF)) Grey 2 body / Grey 5 caption seems to be acceptable, Quiddity, I'm looking forward to the user controllable text styling as well. but in the mean time, i think "hi... [04:27:15] 3MobileFrontend / 3stable: Filter for New User uploads in Mobile Web - 10https://bugzilla.wikimedia.org/62598#c61 (10Florian) > makes it impossible to upload from mobile unless you are autoconfirmed What if some users have a bookmark to Special:Uploads or still navigate directly to upload page :) they still... [05:24:20] (03PS1) 10Florianschmidtwelzow: Show Uploadbutton only when user has the permission [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/143822 (https://bugzilla.wikimedia.org/62598) [05:32:00] (03CR) 10Florianschmidtwelzow: "Yeah, right :) Like you said on bug, we wait for the score after your ps to hide the upload link in sidemenu too and then we see, what we " [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/143751 (https://bugzilla.wikimedia.org/62598) (owner: 10Florianschmidtwelzow) [06:38:30] 3MobileFrontend / 3beta: MobileFrontend displaying both page and discussion when a talk is opened and closed - 10https://bugzilla.wikimedia.org/67442#c1 (10Florian) 5UNCO>3NEW Confirmed on Firefox Desktop (enwiki and actual master). [07:06:15] 3Wikipedia App / 3Android App: crash with NoClassDefFoundError: support.v7.internal.view.menu.MenuBuilder - 10https://bugzilla.wikimedia.org/66263#c11 (10Alex Monk) So the beta version does not have this fix, but the stable version does? https://ticket.wikimedia.org/otrs/index.pl?Action=AgentZoom&TicketID=76... [08:54:45] 3MobileFrontend / 3Feature requests: Option labels on the mobile preferences page can be too long - 10https://bugzilla.wikimedia.org/61114#c9 (10Florian) Is there any news to this bug? :) [08:59:15] 3MobileFrontend / 3Feature requests: Rethink the upload summaries for photo uploads from mobile - 10https://bugzilla.wikimedia.org/58983#c6 (10Florian) So, actual following status? - Change upload summary to optional - prefill upload summary with page name, if workflow started for lead image ? [10:31:02] 3MobileFrontend / 3General/Unknown: Search: Disambiguations pages show 'missing image' symbol - 10https://bugzilla.wikimedia.org/67471 (10Derk-Jan Hartman) 3NEW p:3Unprio s:3normal a:3None Disambiguation pages however don't generally have images, so we probably shouldn't encourage people to add one.... [10:32:45] 3MobileFrontend / 3General/Unknown: Search: Disambiguations pages show 'missing image' symbol - 10https://bugzilla.wikimedia.org/67471 (10Derk-Jan Hartman) s:5normal>3enhanc [10:59:15] 3MobileFrontend / 3General/Unknown: Search: Disambiguations pages show 'missing image' symbol - 10https://bugzilla.wikimedia.org/67471#c1 (10Florian) Actually there are some other pages, too, which don't need an image (and have no available option if you navigate to the page), e.g. category pages. Maybe we... [14:10:51] (03CR) 10Cmcmahon: "The ideal would be to protect the page via the API. Doing it in the UI is clumsy and expensive." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/143745 (owner: 10Cmcmahon) [15:08:45] 3Wikipedia App / 3Android App: crash with NoClassDefFoundError: support.v7.internal.view.menu.MenuBuilder - 10https://bugzilla.wikimedia.org/66263#c12 (10Bernd Sitzmann) That's correct. We haven't pushed out a new beta release in over a week. I hope we get some of the newer features merged today so we can do... [15:53:21] (03PS6) 10Jdlrobson: Add template dependency to Mantle extension [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129335 [15:53:31] (03CR) 10jenkins-bot: [V: 04-1] Add template dependency to Mantle extension [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129335 (owner: 10Jdlrobson) [16:10:32] 3Wikipedia App / 3iOS App: Edit icon is hard to tap - 10https://bugzilla.wikimedia.org/67479 (10Sage Ross) 3NEW p:3Unprio s:3normal a:3None It seems like the tappable area for the edit icon is not large enough. It often takes me multiple tries to successfully activate the edit button. [16:13:48] 3Wikipedia App / 3iOS App: After login or logout, edit icons are not updated until page is refreshed manually - 10https://bugzilla.wikimedia.org/67480 (10Sage Ross) 3NEW p:3Unprio s:3normal a:3None If an article is protected or semi-protected and I decide I want to edit it, I log in. However, I still... [16:21:46] 3MobileFrontend / 3Feature requests: Option labels on the mobile preferences page can be too long - 10https://bugzilla.wikimedia.org/61114#c10 (10Jared Zimmerman (WMF)) we could do a bandaid fix or make a major improvement to the page… https://bugzilla.wikimedia.org/show_bug.cgi?id=65079 [16:21:46] 3MobileFrontend / 3General/Unknown: Show what features are included in Beta and Experimental on mobile. - 10https://bugzilla.wikimedia.org/65079 (10Jared Zimmerman (WMF)) [16:21:46] 3MobileFrontend / 3Feature requests: Option labels on the mobile preferences page can be too long - 10https://bugzilla.wikimedia.org/61114 (10Jared Zimmerman (WMF)) [16:30:16] 3MobileFrontend / 3Feature requests: Rethink the upload summaries for photo uploads from mobile - 10https://bugzilla.wikimedia.org/58983#c7 (10Bawolff (Brian Wolff)) (In reply to Jared Zimmerman (WMF) from comment #5) > I'd be ok with it as long as it was optional, and not doing it didn't cancel > the upload... [16:55:16] 3Wikipedia App / 3Android App: Wikipedia app should not use Android's built-in localization system for the footer "Last edited" text - 10https://bugzilla.wikimedia.org/67431#c1 (10Brion Vibber) WTF, Nokia shipping a phone without Finnish locale????? :) On my Nexus 5 with locale set to Finnish I see "Viimeks... [16:58:30] 3Wikipedia App / 3iOS App: After login or logout, edit icons are not updated until page is refreshed manually - 10https://bugzilla.wikimedia.org/67480#c1 (10Brion Vibber) Yeah, currently the 'editable' status (which is user- and page-specific) gets stashed directly in the Article entry in the local database,... [16:59:45] 3Wikipedia App / 3iOS App: Edit icon is hard to tap - 10https://bugzilla.wikimedia.org/67479#c1 (10Brion Vibber) Yeah, I can confirm it feels a bit tricky sometimes to hit the button. I'm not sure if the touch target is too small or if something's eating some of the events. [17:12:45] 3Wikipedia App / 3Android App: Handle the "Search" key (on 2.x devices) - 10https://bugzilla.wikimedia.org/67324#c1 (10Brion Vibber) I presume we'd handle this within the app by setting focus in the search box? (If you're in some dialog, presumably it should do nothing...?) [17:14:53] that’s interesting… my google watch’s time is 3 minutes ahead of my phone’s time [17:14:58] HOW THIS HAPPEN [17:15:16] it's from teh future [17:15:21] +1 [17:15:33] * YuviPanda waves weakly [17:16:24] save your strength! [17:20:35] (03PS5) 10Dr0ptp4kt: During edit save, describe IP edit and offer login if appropriate. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/143156 [17:23:44] (03PS6) 10Dr0ptp4kt: During edit save, describe IP edit and offer login if appropriate. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/143156 [17:27:19] YuviPanda, around? [17:27:25] yurikR: hey! yes [17:27:36] (03CR) 10Dr0ptp4kt: During edit save, describe IP edit and offer login if appropriate. (031 comment) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/143156 (owner: 10Dr0ptp4kt) [17:28:57] YuviPanda, hi, so i got jsonconfig in production, and now wanted to move the horrible hack of storing proxies inside ZERO into its own place. Considering that you have some other configs, we might want to store everything on META in CONFIG: namespace. What do you think? [17:29:18] bearND: ^ would you please re-review? [17:29:22] yurikR: I don't think having one namespace for all unrelated things is useful, no. Especially since they display very differently. [17:29:23] er ^^^^ [17:29:37] YuviPanda, I would store proxies in Config:Proxy:xxxx, and your upload will store in Config:Yuvi:xxxx [17:29:46] YuviPanda, don't worry - jsonconfig is designed for that :) [17:29:48] yurikR: http://commons.wikimedia.org/wiki/Campaign:wlm-nl displays very differently, for example. Having different things in same namespaces feels icky. [17:29:56] yurikR: subnamespaces? :) [17:29:58] it has sub-namespace feature :) [17:30:29] this way we keep all json configs in one spot, don't polute namespaces (meta ppl don't like that), and yet each has totally different configuration/look/etc [17:30:38] yurikR: nice :) either way, the multimedia team maintains that now, so it is out of my hands... [17:30:43] YuviPanda, https://www.mediawiki.org/wiki/Extension:JsonConfig [17:30:57] who is maintaining it? [17:31:04] i would love to unify those things soonish [17:31:18] YuviPanda: you hopping on EventLogging video? [17:31:47] dr0ptp4kt, and yes, eventlogging should also migrate ;) [17:32:30] YuviPanda, where do you store your stuff ATM? [17:33:57] https://meta.wikimedia.org/wiki/Schema:MobileWikiAppEdit [17:34:52] YuviPanda, that's eventlogging, what about the upload wizard? [17:37:35] (03PS7) 10Dr0ptp4kt: During edit save, describe IP edit and offer login if appropriate. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/143156 [17:39:55] https://meta.wikimedia.org/w/index.php?title=Special%3APrefixIndex&prefix=MobileWikiApp&namespace=470 [17:42:41] https://meta.wikimedia.org/wiki/Schema:MobileWikiAppLogin [17:44:34] (03CR) 10MaxSem: "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129335 (owner: 10Jdlrobson) [17:45:00] 3Wikipedia App / 3Android App: Handle the "Search" key (on 2.x devices) - 10https://bugzilla.wikimedia.org/67324#c2 (10Liangent) Yeah and pop up the keyboard at the same time of course. [17:46:33] (03CR) 10Kaldari: "Yes, I think that's a good idea. Rather than having both checks, we should probably consolidate it into something based on edit count if i" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/143751 (https://bugzilla.wikimedia.org/62598) (owner: 10Florianschmidtwelzow) [17:54:00] (03CR) 10Florianschmidtwelzow: "Yeah, hope too :P" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/143751 (https://bugzilla.wikimedia.org/62598) (owner: 10Florianschmidtwelzow) [18:13:47] * brion stabs parallels 9 [18:13:55] it’s still broken for mac os x 10.9.3 and 10.10 guests [18:17:01] gonna move some of my VMs to vmware :P [18:20:37] brion: vwware just works for me [18:20:42] upgraded to 6.0 last night [18:20:48] yeah [18:30:40] https://wikitech.wikimedia.org/wiki/EventLogging [18:36:10] I guess we could set up some volunteering positions about responding to google play reviews? [18:36:49] not sure how to technically implement this [18:37:21] liangent: that's kinda... hard. [18:37:35] liangent: we already have volunteering positions responding to OTRS (WOULD BE AWESOME IF YOU CAN JOIN, BTW) [18:37:46] liangent: but hard to give people access to the play store dashboard without also giving them access to upload new apks [18:40:30] YuviPanda: I just noticed some "irrelevant responses" to reviews written in Chinese [18:40:42] liangent: yeah, that was dr0ptp4kt doing auto translate :) [18:40:44] and yeah dr0ptp4kt has already realized this (in the mailing list) [18:41:01] liangent: apologies about that! [18:42:10] liangent: i stopped replying about those things now that it became clear it's not users being confused, but rather something where we probably need to make some changes to the UI [18:43:02] liangent YuviPanda - i gotta step out to eat something. ttyl [18:45:49] YuviPanda: I feel I don't bother to ask for OTRS access .. ? [18:46:00] liangent: I can set you up, if you want. [18:46:07] should be fairly easy. [18:46:09] and maybe allowing uploading apk is not critical, as long as your certificate is not leaked [18:46:39] and google will reject new apks with mismatched certificates [18:46:42] liangent: sure, but it also means that you can change the settings, etc. Also it is limited to only wikimedia.org domain, I think. Either way, I think that's a nonstarter. [18:47:33] ok I wonder if there's an api to do that? [18:47:49] so we can build our own interface for volunteers [18:47:54] liangent: to respond? Sadly no. [18:47:59] in some hackathon maybe [18:48:00] ok [18:50:05] liangent: so I'll set you up with OTRS access? [18:54:48] YuviPanda: not requiring https://meta.wikimedia.org/w/index.php?title=Identification_noticeboard& stuff? [18:55:11] liangent: nope [18:55:22] liangent: just 'a' name, a username, and email address. [18:56:02] liangent: I think, at least. Haven't had to do that for anyone so far. [18:56:05] RD: ^ [19:03:44] YuviPanda: and start a translatable page on meta for google play description? not sure if that field is multilingual [19:04:38] liangent: it's on translatewiki.net [19:06:51] YuviPanda: is the Play store description in the app localization files or separate on twn? [19:07:00] brion: app localization files [19:07:01] we gotta do the ios version soon too [19:07:07] ok that’s easy enough to handle :D [19:07:22] brion: :) [19:12:46] YuviPanda: is it group=out-wikimedia-mobile-wikipedia-android-strings ? [19:12:52] liangent: yea [19:13:05] translation to either language=zh-cn or language=zh-hans is disabled there [19:13:17] aharoni: ^ [19:14:52] YuviPanda: actually what language codes do you expect? [19:15:02] zh-hans/zh-hant or zh-cn/zh-tw/zh-hk ? [19:15:13] liangent: zh-cn zh-hans should be translated by translatewiki.net into appropriate ones, I think [19:16:43] so anyway I can't find a place to do translation for Chinese (Simplified) or Chinese (PRC) [19:18:16] liangent: ugh, I'm not sure how to fix atm. Moving to a meta page, probably. [19:20:41] if you can’t figure it out write up a note and send it to me and i’ll poke at it over the weekend [19:20:59] want to fix those plurals if i can so i’ll be messing in there anyway :D [19:21:02] brion: it's a bug in Extension:Translate. It doesn't support anything with variants [19:21:11] liangent: I don't know how to set up a translatable page :( can you help? [19:22:48] YuviPanda: I don't know either but I think you need to be https://meta.wikimedia.org/w/index.php?title=Special:ListUsers&group=translationadmin first? [19:22:54] bah [19:23:05] liangent: let me poke in -i18n [19:24:03] YuviPanda: anyway I guess stuff still needs to be fixed on twn for app translation? [19:24:22] liangent: yup. it's an Extension:Translate bug, and I don't know how far up it is on the i18n tem's priorities [19:27:46] YuviPanda: are google play descriptions imported in batch? [19:27:57] YuviPanda: or are you copy-pasting them one by one? [19:28:05] liangent: copy pasted. no API [19:29:28] YuviPanda: so I think it makes more sense to make their own translatable pages, instead of having them mixed in app strings? [19:30:03] liangent: it does, I think. It was put in the app strings primarily because, uh, it was easier, and keep all strings in one place [19:30:09] liangent: let me go and find a translateadmin [19:31:55] YuviPanda: just waiting on you [19:32:07] tfinc: yeah, hangout crashed chrome. moment [19:33:04] tfinc: no video from you guys [19:33:20] Deskana: fwiw, there's a lot more ff work on Windows than Linux :) Market share and all [19:34:27] (03PS1) 10Yurik: Testing cleanup, bugs, rendering [extensions/JsonConfig] - 10https://gerrit.wikimedia.org/r/144035 [19:36:01] http://hatjitsu.wmflabs.org/69225 [19:36:16] dbrant|brb: bearND so do drive the design conversations, I'll mostly lay back on those (on going part of moving all UI work off me :) ) [19:38:07] (03PS1) 10Yurik: Initial support for multiple configuration sets [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/144038 [19:41:02] (03PS1) 10Yurik: Update to match config changes in Ia52c6110a [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/144041 [19:41:27] dr0ptp4kt, 3 more patches ^ :) [19:45:42] yurikR: k [19:50:58] Deskana: also needs eventlogging for update/refresh. [19:56:08] dr0ptp4kt, do you know if dan is around? [19:56:27] yurikR: not sure [20:29:05] mhurd: http://hatjitsu.wmflabs.org/69225 [20:31:50] @YuviPanda @bearND @dbrant|brb YOu guys can do whatever saved page feedback you feel is appropriate for android [20:32:14] vbamba: alright! [20:32:17] @YuviPanda I'll just delete the design [20:32:31] Deskana|Away: ^ [20:36:21] mhurd: when you said the icons are a bit heavy did you mean they are too dark? [20:36:44] bearND: too thick / bold [20:36:48] 3Wikipedia App / 3iOS App: Article title not in italics for genus and species pages - 10https://bugzilla.wikimedia.org/67492 (10Julie) 3UNCO p:3Unprio s:3minor a:3None Article titles that are italicised on desktop, web, and the Android app are not italicised in the iOS app. [20:37:15] 3Wikipedia App / 3iOS App: Article title not in italics for genus and species pages - 10https://bugzilla.wikimedia.org/67492 (10Julie) [20:37:36] mhurd: ok. i think for android they are too black (vbamba) [20:38:18] bearND: yeah, that's because we aren't applying the 60% opacity [20:38:33] bearND: that's on our side, though. we need to figure out how to get the enabled and disabled states consistently different opacities. [20:38:51] bearND: note that it looks correct on the page view's fake actionbar, since we set the opacity manually [20:40:01] YuviPanda: I don't usually see other Android apps applying an alpha value in the real action bar [20:40:25] bearND: yeah, so we should modify convert-icons to generate 60% (active) and 30% (inactive) variants [20:41:21] bearND: we should make the amount of drudge work the designers have to do as minimal as possible and automate the rest :) [20:42:54] YuviPanda: agreed. I was originally hoping that if the WikiFont was updated to be less heavy that it meant it was a bit lighter in color. [20:42:58] @YuviPanda @bearND @dbrant|brb I dont think you need any input from design here [20:43:07] You guys know what to do :) [20:43:15] vbamba: yeah, it's a thing we need to fix [20:43:17] oh well [20:43:24] bearND: ah, no - they were talking about the font 'weights' [20:43:39] YuviPanda: yeah, got that now [20:43:43] :) [20:53:12] dr0ptp4kt, any questions for me so far? [20:53:30] dan wants to play with it :) [20:54:07] yurikR: no. i've looked through the code. i'm rebuilding vagrant [20:54:32] dr0ptp4kt, always fun :) [20:54:58] dr0ptp4kt, maybe we should set up vagrant on dan's machine :) [20:55:15] yurikR: yes, that would be good [21:01:51] Is there a way to edit an entire page and not just one section on the mobile website? [21:02:29] tfinc: do we have a room? [21:02:46] jdlrobson: i'm camping out in r37 per the invite [21:03:19] ok cool [21:03:57] When I hit the first edit button it justs open the lead section with "#editor/0" [21:04:34] Jan_Ainali_WMSE: hey! AFAIK (am not in the mobile web team) there's only section editing, no full page editing [21:06:49] Oh. There goes that tablet editing experience :/ [21:07:40] MaxSem: is kaldari in the office? [21:07:53] he is [21:08:09] MaxSem: can you poke him to get him on IRC? [21:08:19] already poking [21:08:28] hey kaldari [21:09:03] kaldari: me and legoktm were wondering if we can poke opsen to run the expensive disambig query once a day or half a day or something like that instead of once a few months. Do you think that'd be possible? [21:09:36] YuviPanda, what query? [21:09:47] YuviPanda: Good question, I have no idea how long it takes to actually run on en.wiki... [21:10:12] MaxSem: https://www.mediawiki.org/wiki/Extension:Disambiguator [21:10:18] regardless I'm sure it could at least be run once a month instead of every 6 months :P [21:10:30] MaxSem: api.php?action=query&list=querypage&qppage=DisambiguationPageLinks [21:10:57] kaldari: yeah, poking springle would be good. me and zz_prtksxna and legoktm were thinking of doing something with it in our spare time. [21:11:05] MaxSem: also https://en.wikipedia.org/wiki/Special:DisambiguationPageLinks [21:11:14] which is the same query [21:11:17] right [21:11:31] "The following information is cached, and was last updated 01:55, 2 July 2014." [21:12:10] it just hit it's 6 month anniversary :) [21:12:10] kaldari: do you know where that information is specified? mediawiki-config? [21:13:48] YuviPanda: it's in puppet [21:13:56] legoktm: oh? do you know where? [21:14:09] legoktm: or what to grep for [21:14:34] YuviPanda: I'm not sure where that's set. Maybe MaxSem knows [21:14:45] misc::maintenance::updatequerypages I think [21:15:03] YuviPanda: https://github.com/wikimedia/operations-puppet/blob/29ddad6f8a0701c7c415c8f2b9043c1dd1549895/manifests/misc/maintenance.pp#L320 [21:16:10] kaldari: ah, right. I see the code, it's not really treating disambiguator as anything special [21:16:22] kaldari: if we can find out how long it takes, should be not too hard to increase the frequency. [21:17:52] YuviPanda: I would assume that QueryPage has some profiling [21:18:07] MaxSem: ^ do you know if we can get that from graphite? [21:18:34] mhm [21:23:38] MaxSem: hmm, graphite has the keys but alll seem to be 0 [21:24:01] (03CR) 10Florianschmidtwelzow: If error occurs while loading VE, load source editor instead (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/143797 (https://bugzilla.wikimedia.org/66678) (owner: 10Kaldari) [21:26:38] YuviPanda: You might also want to comment on this bug: https://bugzilla.wikimedia.org/show_bug.cgi?id=50979 [21:26:54] it's been sitting there for a year with no comments [21:27:06] kaldari: what does increasing that do? [21:27:38] Right now, when the query gets run every 6 months, it's run with 'LIMIT = 1000' :( [21:27:44] oh lol [21:27:46] right [21:28:32] en.wiki has the most strict limit [21:31:07] kaldari: right. [21:31:27] kaldari: I could set this up more efficiently in some specialiezed way on tools, but then whatever we end up building can't go into prod at any point [21:32:19] yeah, it seems like there should be some way of getting useful results from prod without killing the cluster [21:35:07] heh i’m deleting old snapshots from my windows virtual machine, it’s taking foreeeeeeeever to recompact the hdd [21:35:07] yurikR: running ZeroBanner, ZeroPortal, and JsonConfig at those three latest commits in Gerrit that you submitted...and with the contents of 250-99 having been copied from production into Zero:250-99 while running the /current/ master for those three extensions, are you able to see banners with the following headers on 127.0.0.1:8080? X-CS: 250-99, X-Subdomain: M, User-Agent: android mobile [21:36:11] brion: hey! Any screenshots from footer styling yet ? :) [21:39:12] yurikR: to restate, here's what i did: 1. rebuilt vagrant. 2. added vagrant role zero, provisioned. 3. created 127.0.0.1:8080/wiki/Zero:250-99. 4. issued git review -d for each of ZeroBanner, ZeroPortal, and JsonConfig for the latest Gerrit submission for each. 5. tried to visit http://127.0.0.1:8080/wiki/Main_Page. No banner shown, whereas at master they show. should i just resave the 250-99 thing to get it updated?...and does this mean [21:39:12] re-save will be needed for all of the configs in production? [21:41:18] 3Wikipedia App / 3iOS App: iOS: "back" button does not always return to the previous article - 10https://bugzilla.wikimedia.org/67497 (10Julie) 3UNCO p:3Unprio s:3normal a:3None The back button does not return to the previously viewed article, IF the article to be returned to has been viewed at least... [21:46:03] dr0ptp4kt, just to confirm, are you pulling the latest 3 that i submitted today? [21:46:25] yurikR: yep. i just re-saved 250-99 while running at those latest 3 [21:46:27] oh, dr0ptp4kt, yes, it wouldn't, because there is a mistake in that config ;) [21:46:35] add "DIRECT" as a proxy [21:46:59] i need to go through production and add it everywhere [21:47:01] (03PS1) 10Yuvipanda: Add function to test if a page is a file page [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/144069 [21:47:02] bearND: dbrant|brb ^ hacked this up real quick :) [21:47:07] dr0ptp4kt, ^ [21:48:14] yurikR: updated, trying to reload Main_Page [21:48:45] yurikR: banner, w00t [21:49:31] (03CR) 10MaxSem: Making SVG compression smarter in pre-commit hook (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/143684 (owner: 10Kaldari) [21:50:16] gonna try this other IRC client now.... [21:55:15] (03PS1) 10Yuvipanda: Hide edit pencils for file pages [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/144072 [21:55:40] yurikR: you ready to monitor this in beta labs if i +2 in reverse chronological order? [21:56:24] dr0ptp4kt, just +2 all of it if you are ok with it [21:56:35] yurikR: okay, man the decks... [21:56:36] no worries about the order [21:56:44] its beta, who cares :D [21:56:51] * yurikR hides [21:57:02] (03CR) 10Dr0ptp4kt: [C: 032 V: 031] Cleanup [extensions/JsonConfig] - 10https://gerrit.wikimedia.org/r/142762 (owner: 10Yurik) [21:57:09] (03Merged) 10jenkins-bot: Cleanup [extensions/JsonConfig] - 10https://gerrit.wikimedia.org/r/142762 (owner: 10Yurik) [21:57:58] (03CR) 10Dr0ptp4kt: [C: 032 V: 031] Refactoring to support complex nested validations [extensions/JsonConfig] - 10https://gerrit.wikimedia.org/r/143573 (owner: 10Yurik) [21:58:04] (03Merged) 10jenkins-bot: Refactoring to support complex nested validations [extensions/JsonConfig] - 10https://gerrit.wikimedia.org/r/143573 (owner: 10Yurik) [21:58:35] (03CR) 10Dr0ptp4kt: [C: 032 V: 031] Testing cleanup, bugs, rendering [extensions/JsonConfig] - 10https://gerrit.wikimedia.org/r/144035 (owner: 10Yurik) [21:58:40] (03Merged) 10jenkins-bot: Testing cleanup, bugs, rendering [extensions/JsonConfig] - 10https://gerrit.wikimedia.org/r/144035 (owner: 10Yurik) [22:00:04] (03CR) 10Dr0ptp4kt: [C: 032 V: 031] Updated Viewer to match JsonConfig change I4ab5dfee792cb [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/143575 (owner: 10Yurik) [22:00:22] (03Merged) 10jenkins-bot: Updated Viewer to match JsonConfig change I4ab5dfee792cb [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/143575 (owner: 10Yurik) [22:00:23] (03CR) 10BearND: "Wow. Pretty cool. Just some a minor code style thing." (032 comments) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/144069 (owner: 10Yuvipanda) [22:00:45] (03CR) 10Dr0ptp4kt: [C: 032 V: 031] Update to match config changes in Ia52c6110a [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/144041 (owner: 10Yurik) [22:00:55] (03Merged) 10jenkins-bot: Update to match config changes in Ia52c6110a [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/144041 (owner: 10Yurik) [22:01:38] (03CR) 10Kaldari: Making SVG compression smarter in pre-commit hook (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/143684 (owner: 10Kaldari) [22:01:40] (03CR) 10Dr0ptp4kt: [C: 032 V: 031] Updated validators to match JsonConfig change I4ab5dfee792cb [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/143574 (owner: 10Yurik) [22:01:53] (03Merged) 10jenkins-bot: Updated validators to match JsonConfig change I4ab5dfee792cb [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/143574 (owner: 10Yurik) [22:02:23] (03CR) 10Dr0ptp4kt: [C: 032 V: 031] Initial support for multiple configuration sets [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/144038 (owner: 10Yurik) [22:02:35] (03Merged) 10jenkins-bot: Initial support for multiple configuration sets [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/144038 (owner: 10Yurik) [22:03:08] bearND: yeah, code generation is pretty powerful [22:04:11] yurikR: done. lost irc connection, naturally, just before +2'ing last piece. [22:04:38] YuviPanda: :) [22:04:55] bearND: :) I took my painkiller about an hour ago, so that means about 2h of painfree typing before I drop off to deep sleep :) [22:05:14] bearND: hmm, so those should be in the private context, and I'm not sure how to best format those with reference to the JavaDoc [22:05:19] since the Doc itself is just for the methods [22:06:09] bearND: I'll just add javaDoc for those as well [22:07:01] YuviPanda: i was just commenting on the fact that the variable declarations are switched. The one for isSpecial is next to isFile() and vv. [22:07:07] dr0ptp4kt, np, btw, why do you mark them +1 verified? [22:07:14] bearND: gaah, grurr. missed that :) [22:07:21] i thought that was jenkins job [22:07:33] YuviPanda: as i said, minor thing [22:07:41] yurikR: maybe it would be better to leave that for jenkins. i just like to indicate that i actually did try it out. [22:07:58] YuviPanda: and thanks for adding the test [22:08:00] bearND: nah, let me fix 'em :) [22:08:02] :D [22:08:21] dr0ptp4kt, thx for the review :) any questions? [22:08:33] or concerns [22:08:41] (03PS2) 10Yuvipanda: Hide edit pencils for file pages [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/144072 [22:08:43] (03PS2) 10Yuvipanda: Add function to test if a page is a file page [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/144069 [22:09:04] yurikR: let us beat on this thing in beta labs next week. mainly now i'm hoping you can just watch on beta labs to make sure nothing is borked [22:09:28] bearND: yeah, fixed [22:09:36] dr0ptp4kt, oki [22:09:50] is jon still at the office? [22:17:04] (03PS2) 10Kaldari: Making SVG compression smarter in pre-commit hook [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/143684 [22:18:05] YuviPanda: i'm prepared to +2 this, unless you think it's not ready. [22:18:14] bearND: no I think it's good [22:18:31] (03CR) 10BearND: [C: 032] Add function to test if a page is a file page [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/144069 (owner: 10Yuvipanda) [22:18:43] YuviPanda: i agree. [22:18:45] (03CR) 10Kaldari: Making SVG compression smarter in pre-commit hook (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/143684 (owner: 10Kaldari) [22:18:56] bearND: :D there's another patch as well, which I think completes that card [22:20:11] (03Merged) 10jenkins-bot: Add function to test if a page is a file page [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/144069 (owner: 10Yuvipanda) [22:22:29] YuviPanda: ok, i'm looking at that, too. Would you mind checking out https://gerrit.wikimedia.org/r/#/c/143156? I'm not sure if that's the right wqay to deal with RTL. [22:22:40] looking [22:25:04] (03CR) 10BearND: [C: 032] "Works great!" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/144072 (owner: 10Yuvipanda) [22:25:27] (03Merged) 10jenkins-bot: Hide edit pencils for file pages [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/144072 (owner: 10Yuvipanda) [22:25:44] (03CR) 10Yuvipanda: [C: 04-1] "We shouldn't be hand constructing a message ever like this. Put a CDATA around it in strings.xml, and leave instructions in the qq?" (031 comment) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/143156 (owner: 10Dr0ptp4kt) [22:25:54] bearND: yeah, not the way, I think. [22:27:57] YuviPanda: to split cards between Android and iOS do you usually copy them? [22:28:06] bearND: yeah, am doing that now. [22:28:15] YuviPanda: ok, great! [22:29:04] bearND: you ok with marking that a (2)? [22:29:49] dbrant|brb: ^ [22:33:12] (03CR) 10Kaldari: If error occurs while loading VE, load source editor instead (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/143797 (https://bugzilla.wikimedia.org/66678) (owner: 10Kaldari) [22:33:13] everybody have a good holiday weekend! [22:33:46] YuviPanda: 2 is fine [22:33:51] bearND: cool [22:34:29] YuviPanda: are you good with ImageMagick cropping commands? [22:34:49] bearND: not really, no. and for the SVGs I don't think that'll cut it. [22:35:03] bearND: the proper way is to look into the SVG and rip out the globe group [22:35:21] bearND: I think this patch should be merged as is, and make a new card for the fonts. I'll take care of that next sprint [22:35:52] YuviPanda: ok, i'll change the commit message [22:35:57] bearND: ok [22:36:18] (03PS4) 10BearND: [WIP] Add onboarding screen [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/143205 [22:36:20] MaxSem: hey! mobileview doesn't strip redlinks? [22:36:30] YuviPanda: rebase ^ [22:36:47] bearND: don't think I can review it now, though :( get dbrant|brb on? :) [22:37:12] (03PS5) 10BearND: Add onboarding screen [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/143205 [22:37:49] YuviPanda: ok. dbrant|brb: Would you review https://gerrit.wikimedia.org/r/143205 ? [22:37:49] bearND: btw, it shouldn't be shown if getIntent() is not null. if the user clicks on a link from chrome and we show them this, it's jarring. [22:38:07] bearND: so it should be shown the first time user opens it by itself without coming in from another app [22:39:27] YuviPanda: agreed. I'll make the change [22:39:42] bearND: cool :) [22:39:50] [i'll be back in a little while] [22:39:53] (03CR) 10Kaldari: If error occurs while loading VE, load source editor instead (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/143797 (https://bugzilla.wikimedia.org/66678) (owner: 10Kaldari) [22:40:34] (03PS3) 10Kaldari: If error occurs while loading VE, load source editor instead [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/143797 (https://bugzilla.wikimedia.org/66678) [22:49:01] MaxSem: You're listed as a member on the "Move MediaViewer" to stable card, but it's still in ready for dev. Are you working on that, or should I pick it up (it's currently the highest priority card on the stack) [22:49:54] If you want to work on it, I can work on the small screen card [22:55:28] MaxSem: poke? doesn't action=mobileview strip redlinks? [22:56:26] YuviPanda, it doesn't [22:56:45] MaxSem: oh. is it hard to make it so? should we do it clientside? [22:57:19] YuviPanda, we had this talk 2 months ago, when we killed red links:D [22:57:38] MaxSem: ^ poke [22:57:52] kaldari, no [22:57:53] MaxSem: aaah. [22:57:57] I don't work on it [22:58:01] MaxSem: right, so I guess I'll have to do it clientside [22:58:04] ok, thanks [22:58:09] I wonder if we can do it in pure CSS [22:58:49] MaxSem: does this mean that non-js MF clients get redlinks? [23:00:00] yes [23:00:47] YuviPanda: you can remove the styling in pure CSS but they’ll still be clickable potentially [23:01:03] dunno if you get a long-press menu or anything [23:01:23] brion: yeah, I'm just gonna JS. [23:01:51] yeah it’s pretty straightforward in JS to turn them from s into s or something [23:02:18] brion: hmm, yeah. I guess I should just replace the element [23:02:34] (03PS6) 10BearND: Add onboarding screen [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/143205 [23:03:11] dbrant|brb: ^