[09:07:53] (03PS2) 10Florianschmidtwelzow: Rewrite prepareSiteLinks and add check for "-" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/144280 [11:43:19] (03PS4) 10Yuvipanda: [WIP] Implement night mode for content [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/142512 [14:03:21] (03CR) 10Dbrant: [C: 032] Add onboarding screen [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/143205 (owner: 10BearND) [14:31:43] (03PS3) 10Dbrant: Abusefilter changes in Edit workflow. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/143024 [14:47:48] 3MobileFrontend / 3General/Unknown: PHP Fatal error: Cannot use object of type stdClass as array in /usr/local/apache/common-local/php-1.24wmf11/extension s/MobileFrontend/includes/MobileFrontend.hooks.php on line 304 - 10https://bugzilla.wikimedia.org/67596 (10Sam Reed (reedy)) 3NEW p:3Unprio s:3norma... [14:49:01] 3MobileFrontend / 3General/Unknown: PHP Fatal error: Cannot use object of type stdClass as array in MobileFrontend.hooks.php on line 304 - 10https://bugzilla.wikimedia.org/67596 (10Sam Reed (reedy)) [15:03:49] (03PS5) 10Yuvipanda: Implement night mode for content [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/142512 (https://bugzilla.wikimedia.org/35251) [15:03:52] (03CR) 10jenkins-bot: [V: 04-1] Implement night mode for content [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/142512 (https://bugzilla.wikimedia.org/35251) (owner: 10Yuvipanda) [15:10:59] (03PS6) 10Yuvipanda: Implement night mode for content [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/142512 (https://bugzilla.wikimedia.org/35251) [15:27:46] 3MobileFrontend / 3General/Unknown: When database is locked (read-only), mobile editor doesn't know what to do - 10https://bugzilla.wikimedia.org/67514#c1 (10Florian) Hmm, i have tested it, but i can go through the edit workflow (get the section loaded into editor and get the preview too). If i try to save,... [15:34:55] YuviPanda: dbrant: Hello. Are you ok with 2 points for https://trello.com/c/RVrZDzjl/17-2-add-instrumentation-for-onboarding? [15:36:19] bearND: sure [15:37:05] * YuviPanda waves at be dbrant [15:37:21] hey! [15:38:44] * YuviPanda also waves at bearND [15:38:52] my hands seems to be better this week :) lots of icing. [15:39:11] YuviPanda: so is it correct that your Night Mode patch is for the WebView content only? (i.e. an intermediate step towards Night Mode throughout the app) [15:39:14] hi YuviPanda! That's great! :) [15:39:40] dbrant: yes, it is. I don't know if we can/should do throughout the app, though. With other activities it is... problematic. [15:39:45] well, at least a lot of work [15:40:02] YuviPanda: dbrant: we should create some themes [15:40:49] bearND: can't re apply themes without restarting app [15:41:50] YuviPanda: bearND: We should at least update the color of the ToC, as well as the background behind the WebView (when you go to a new page, you get a flash of white before the page loads). [15:42:33] dbrant: indeed, was going to do that in the new patch. [15:42:46] bearND: idea being everything you are reading is color switched, others not so much. and then we see if people complain :) [15:43:31] YuviPanda: bearND: I ask because I was about to pick up https://trello.com/c/1IadWUPO which would tie together night mode, plus font size. [15:44:15] dbrant: right. I'd be ok with you picking up the UI fixes for the night mode along with it as well, since those will be very releated. [15:44:41] YuviPanda: alright! [15:44:54] dbrant: I'll move the cards over and point you to them in a minute. [15:45:21] dbrant: a few colors still have to be fixed (primarily, borders and stuff). sent an email to mobile-tech about those a bit ago [15:48:27] YuviPanda: yeah, we probably would have to restart the PageActivity, which is not very nice. We could deal with that later. [16:09:30] dbrant: added cards [16:10:02] YuviPanda: great [16:12:17] Sigh. [16:12:23] The queue crept back up to 300 while I wasn't looking. [16:12:43] bearND: dbrant we should do another round of OTRS clearing today. [16:13:38] YuviPanda: yep [16:14:32] So one of the common crashes I'm seeing is Unable to start activity ComponentInfo{org.wikipedia/org.wikipedia.page.PageActivity}: java.lang.RuntimeException: Could not dispatch event: class org.wikipedia.events.NewWikiPageNavigationEvent to handler [EventHandler public void org.wikipedia.page.PageActivity.onNewWikiPageNavigationEvent(org.wikipedia.events.NewWikiPageNavigationEvent)] [16:14:51] Might've filed a bug about this... not sure [16:21:36] There are 41 "could not dispatch event" errors at the moment [16:21:48] (individual reports of them, that is) [16:22:38] Krenair: so those are kidna catchall events, the actuall error happens somewhere else (and is the inner exception) [16:23:10] I see [16:24:52] (03CR) 10Dbrant: [C: 031] "Tested (successfully) on mdpi (Acer Iconia Tab A500) and xhdpi (Galaxy S3)." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/142267 (owner: 10BearND) [16:32:29] (03PS7) 10Yuvipanda: Implement night mode for content [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/142512 (https://bugzilla.wikimedia.org/35251) [16:33:09] dbrant: I can pick up https://trello.com/c/dZ5UBkV5/19-as-a-user-who-reads-at-night-i-d-like-a-night-mode-so-that-reading-is-easier-in-dark-environments-page-native-ui and you can pick up https://trello.com/c/D4P02d0C/20-as-a-user-who-reads-at-night-i-d-like-an-easy-way-to-switch-between-night-mode-and-dark (since that is closely tied to font settings) [16:33:11] dbrant: is that ok? [16:33:25] YuviPanda: yep! [16:33:44] dbrant: also a (2) for both? [16:33:52] YuviPanda: sure [16:35:43] (03CR) 10jenkins-bot: [V: 04-1] Implement night mode for content [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/142512 (https://bugzilla.wikimedia.org/35251) (owner: 10Yuvipanda) [16:35:48] hmm [16:37:08] (03PS8) 10Yuvipanda: Implement night mode for content [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/142512 (https://bugzilla.wikimedia.org/35251) [16:47:41] (03CR) 10Dr0ptp4kt: "@Deskana, would you please see inline comment and latest question from @Yuvipanda (1 - autosave on login, 2 - make full thing tappable)" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/143156 (owner: 10Dr0ptp4kt) [16:51:46] 3MobileFrontend / 3alpha: Middle click in alpha loads page in the same tab - 10https://bugzilla.wikimedia.org/62517#c3 (10Florian) I think this is a problem related with lazyload (stable and beta works fine). I don't know the roadmap, but Kaldari posted in this comment: https://gerrit.wikimedia.org/r/#/c/142... [16:52:37] (03CR) 10Florianschmidtwelzow: "Jon, can you look at my last inline comment? :)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/138229 (https://bugzilla.wikimedia.org/56834) (owner: 10Florianschmidtwelzow) [17:04:46] 3Wikipedia App / 3iOS App: iOS App: typing in unique edit summary results in word "Other" being included - 10https://bugzilla.wikimedia.org/67222 (10Dan Garry) 5PATC>3RESO/FIX [17:05:10] (03PS9) 10Yuvipanda: Implement night mode for content [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/142512 (https://bugzilla.wikimedia.org/35251) [17:05:46] (03PS1) 10Yuvipanda: Remove dead code from previous saved pages implementation [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/144481 [17:06:07] (03CR) 10jenkins-bot: [V: 04-1] Remove dead code from previous saved pages implementation [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/144481 (owner: 10Yuvipanda) [17:06:13] now what, jenkins [17:06:31] 3Wikipedia App / 3iOS App: iOS App: Auto log-in across updates - 10https://bugzilla.wikimedia.org/67400#c2 (10Dan Garry) 5UNCO>3NEW (In reply to Kunal Mehta (Legoktm) from comment #1) > I think this is intentional for now (Brion or Monte can confirm). I'm not sure that it is; I'm pretty sure I've had to... [17:06:45] (03PS1) 10Florianschmidtwelzow: Enable customization of footer links [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/144482 (https://bugzilla.wikimedia.org/66350) [17:09:01] 3Wikipedia App / 3iOS App: Edit icon is hard to tap - 10https://bugzilla.wikimedia.org/67479#c2 (10Dan Garry) 5NEW>3RESO/FIX This was an issue for me when we had the "tap to hide interface" feature in there. Since we took that out, I've personally found it much easier to tap the edit button successfully.... [17:10:31] 3MobileFrontend / 3Feature requests: Allow configuration of the mobilefrontend menu - 10https://bugzilla.wikimedia.org/63459#c8 (10Florian) > Max what would you suggest? ? :) [17:18:34] dr0ptp4kt, have you had a chance to look at the unified patch? [17:18:39] would be nice to push it all out on wed [17:19:06] that patch (unlike the other ones) won't change config structure, and can be enabled one at a time [17:20:13] yurikR: hola. please add me to any patchsets (if not already added) and lemme know specific URL(s) to review and in which order [17:20:27] dr0ptp4kt, all of them :) [17:20:32] 3MobileFrontend / 3General/Unknown: Mobile is somehow sending API requests that ask for text/html content - 10https://bugzilla.wikimedia.org/67426#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/oGal5O2C [17:20:33] 3MobileFrontend / 3General/Unknown: MobileFrontend: Blue "issues" icon should have HiDPI version (or SVG) - 10https://bugzilla.wikimedia.org/67423#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/JemJaaId [17:20:48] 3MobileFrontend / 3General/Unknown: When database is locked (read-only), mobile editor doesn't know what to do - 10https://bugzilla.wikimedia.org/67514#c2 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/ija1pbwE [17:20:48] 3MobileFrontend / 3General/Unknown: Search: Disambiguations pages show 'missing image' symbol - 10https://bugzilla.wikimedia.org/67471#c2 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/boFbz4ev [17:20:48] 3MobileFrontend / 3beta: MobileFrontend displaying both page and discussion when a talk is opened and closed - 10https://bugzilla.wikimedia.org/67442#c2 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/1cx88dsI [17:20:48] 3MobileFrontend / 3Feature requests: MobileFrontend contradicts established expectations for watchlist UI - 10https://bugzilla.wikimedia.org/67526#c6 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/gpDIK9VA [17:20:49] yurikR: reverse chronological order (accounting for dependencies) ? [17:20:55] yep :) [17:21:02] 3MobileFrontend / 3General/Unknown: PHP Fatal error: Cannot use object of type stdClass as array in MobileFrontend.hooks.php on line 304 - 10https://bugzilla.wikimedia.org/67596#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/wCCP87du [17:26:01] MaxSem bugello's working again - have you seen this? https://bugzilla.wikimedia.org/show_bug.cgi?id=67596 [17:26:54] nm just saw what you did on trello [17:26:55] yup, just kicked it to core [17:26:59] cool thnx [17:28:42] dr0ptp4kt, btw, sorry, forgot to say - just like the patch comment say - the info screen patch should not go in [17:28:54] yurikR: thx [17:29:04] the note clearly stated that :D [17:29:09] sorry :) [17:29:37] dr0ptp4kt, and brandon just +2 varnish patch, so all is clear for unified testing :) [17:29:57] (03CR) 10MaxSem: Enable customization of footer links (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/144482 (https://bugzilla.wikimedia.org/66350) (owner: 10Florianschmidtwelzow) [17:30:01] yurikR: word [17:30:23] dfoy, ^, make sure you don't add any more 555-111a -type of pages, the new ones won't work [17:30:32] (see above) [17:30:39] (03CR) 10MaxSem: [C: 032] Consistent use of ellipsis [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/144347 (owner: 10Amire80) [17:30:42] (03CR) 10BBlack: [C: 031] "I'm not really qualified to analyze the code diff. This +1 means "I like the results this is aiming for, please lets get this implemented" [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/144258 (owner: 10Yurik) [17:30:56] (03PS2) 10Yuvipanda: Remove dead code from previous saved pages implementation [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/144481 [17:30:59] (03PS1) 10Yuvipanda: Don't show Red Links [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/144486 [17:31:18] (03Merged) 10jenkins-bot: Consistent use of ellipsis [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/144347 (owner: 10Amire80) [17:31:20] yurikR: No problem, I understand the new configs are designed for this [17:31:21] dr0ptp4kt, LOL ^^... brandon is not even in this chat :) [17:31:33] i'm right here. [17:31:34] ok, food time [17:31:42] just not teh brandon you're looking for. [17:31:48] hehe [17:32:07] (03CR) 10MaxSem: [C: 04-1] Rewrite prepareSiteLinks and add check for "-" (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/144280 (owner: 10Florianschmidtwelzow) [17:32:12] (03PS1) 10Florianschmidtwelzow: Show No bytes changed on mobile diff [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/144487 (https://bugzilla.wikimedia.org/64616) [17:33:40] (03PS2) 10Florianschmidtwelzow: Show No bytes changed on mobile diff [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/144487 (https://bugzilla.wikimedia.org/64616) [17:34:46] (03PS3) 10Florianschmidtwelzow: Rewrite prepareSiteLinks and add check for "-" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/144280 [17:37:28] (03PS4) 10Florianschmidtwelzow: Rewrite prepareSiteLinks and add check for "-" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/144280 [17:40:06] MaxSem? [17:40:16] yep [17:40:19] https://gerrit.wikimedia.org/r/#/c/144482/1/includes/skins/SkinMinerva.php [17:40:27] you mean SkinMinerva... is better? :) [17:40:42] I thought to use the "original, immited" hook and add simply a "Mobile" [17:40:46] yes - it's not SkinTemplate after all [17:40:48] 3Wikipedia App / 3iOS App: iOS App: Auto log-in across updates - 10https://bugzilla.wikimedia.org/67400#c3 (10Brion Vibber) There should be nothing requiring you to log in again; there's just the onboardibg prompt on every cold start which you can skip until we add logic to not show it. [17:40:48] 3MobileFrontend / 3General/Unknown: Search: Disambiguations pages show 'missing image' symbol - 10https://bugzilla.wikimedia.org/67471#c3 (10Ryan Kaldari) Yeah, the placeholder icon in Search shouldn't have the '+' symbol on it. That should be changed to a different icon (for all pages). [17:40:57] and Mobile postfix is not needed either [17:41:01] hmm, yeah, right :) [17:41:03] ok [17:41:24] (03PS2) 10Florianschmidtwelzow: Enable customization of footer links [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/144482 (https://bugzilla.wikimedia.org/66350) [17:43:22] (03PS3) 10Florianschmidtwelzow: Enable customization of footer links [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/144482 (https://bugzilla.wikimedia.org/66350) [17:44:24] (03CR) 10Florianschmidtwelzow: Enable customization of footer links (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/144482 (https://bugzilla.wikimedia.org/66350) (owner: 10Florianschmidtwelzow) [17:46:48] 3Wikipedia App / 3iOS App: iOS App: Auto log-in across updates - 10https://bugzilla.wikimedia.org/67400#c4 (10Dan Garry) 5NEW>3RESO/WOR (In reply to Brion Vibber from comment #3) > There should be nothing requiring you to log in again; there's just the > onboardibg prompt on every cold start which you ca... [17:47:15] agh i think my old spare monitor is finally dying [17:47:56] …or the cable’s loose. [17:48:44] (03CR) 10Kaldari: [C: 04-1] Rewrite prepareSiteLinks and add check for "-" (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/144280 (owner: 10Florianschmidtwelzow) [17:48:59] ok lemme test this footer on RTL [17:52:02] (03PS5) 10Florianschmidtwelzow: Rewrite prepareSiteLinks and add check for "-" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/144280 [17:52:19] Is there someone who created the images for MF? :) https://github.com/wikimedia/mediawiki-extensions-MobileFrontend/blob/master/less/specials/images/camera.png e.g. ? [17:54:18] (03CR) 10Kaldari: [C: 032] Rewrite prepareSiteLinks and add check for "-" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/144280 (owner: 10Florianschmidtwelzow) [17:54:30] (03PS4) 10MaxSem: Simplify redirect cookie system [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/141576 [17:54:56] (03Merged) 10jenkins-bot: Rewrite prepareSiteLinks and add check for "-" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/144280 (owner: 10Florianschmidtwelzow) [17:55:22] (03CR) 10jenkins-bot: [V: 04-1] Simplify redirect cookie system [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/141576 (owner: 10MaxSem) [17:56:15] ok icons look right but the little cut-out on the divider is not flipped. fixing… [18:12:34] 3Wikipedia App / 3iOS App: [iOS] Table of Contents sidebar shows as empty space with locale set to Arabic - 10https://bugzilla.wikimedia.org/67610 (10Brion Vibber) 3NEW p:3Unprio s:3normal a:3None It seems that some combination of the layout flipping in RTL locales and our magic ToC sidebar logic isn... [18:13:12] (03PS1) 10BearND: Add EL to onboarding [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/144492 [18:13:34] 3Wikipedia App / 3iOS App: [iOS] Edit pencil icons float on wrong side in RTL content (ex Arabic) - 10https://bugzilla.wikimedia.org/67611 (10Brion Vibber) 3NEW p:3Unprio s:3normal a:3None Edit pencil icons are supposed to float to the left side in RTL languages, but they're floating to the right whi... [18:14:00] YuviPanda: ^ also updated schema https://meta.wikimedia.org/wiki/Schema:MobileWikiAppOnboarding [18:14:12] cool! I'll take a look in a bit [18:14:19] bearND: can you CR dbrant's abusefulter patch? [18:14:30] YuviPanda: yes [18:14:33] bearND: ty [18:14:34] 3Wikipedia App / 3iOS App: [iOS] Fix that onboarding page hide-once-seen logic - 10https://bugzilla.wikimedia.org/67612 (10Brion Vibber) 3NEW p:3Unprio s:3normal a:3None It's confusing testers who think they have to log in again, and it's annoying. Let's flip the switch. [18:16:46] 3MobileFrontend / 3Feature requests: MobileFrontend contradicts established expectations for watchlist UI - 10https://bugzilla.wikimedia.org/67526#c7 (10Scott) That was super-cogent, Brian, thank you. I'll bear it in mind as a standard to aim for when filing future reports. Kunal, that strikes me as having... [18:18:39] (03PS2) 10Brion VIBBER: Work in progress: Footer updates [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/144342 [18:21:04] (03PS5) 10MaxSem: Simplify redirect cookie system [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/141576 [18:21:40] (03CR) 10jenkins-bot: [V: 04-1] Simplify redirect cookie system [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/141576 (owner: 10MaxSem) [18:22:59] (03PS6) 10MaxSem: Simplify redirect cookie system [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/141576 [18:23:34] (03CR) 10jenkins-bot: [V: 04-1] Simplify redirect cookie system [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/141576 (owner: 10MaxSem) [18:30:27] dbrant: How do you trigger the abusefilter? Are you using test or enwiki? [18:32:34] bearND: I was using Test wiki. Try editing an article (such as "Test"); making an edit with a bunch of repeating characters should trigger the Warning, and making an edit containing "poop" should trigger Disallow. [18:33:15] brion: What's the best way for me to sign off on this? https://trello.com/c/oerMPG7i/86-ios-app-don-t-overwrite-app-css-files-if-the-new-file-is-zero-bytes [18:33:25] bearND: What's the best way for me to sign off on this? https://trello.com/c/ApfWwbXH/47-nullpointerexception-in-pageactivity-handleintent [18:34:32] Deskana: ……. no idea [18:34:42] trust us? :) [18:34:44] brion: We'll have to assume it works then. :) [18:35:17] Works for me! [18:35:26] Oh, that's ambiguous. :P [18:35:30] This course of action works for me! [18:35:52] hehe [18:37:24] Deskana: that one is difficult to reproduce. We just added some extra check for null in there so it doesn't produce a NPE, and go to the main page instead of the requested page. The issue happened when a different app was requesting a to open a particular page but we cannot see which one. Not sure which app and device this is coming from. [18:37:40] Well, then we'll also just assume this one works. [18:37:46] That's okay. [18:37:50] 3Wikipedia App / 3iOS App: [iOS] Find a way to eliminate manual clearing of derivatives to update the web view assets when building - 10https://bugzilla.wikimedia.org/67614 (10Brion Vibber) 3NEW p:3Unprio s:3normal a:3None Arr, it's driving me nuts. [18:38:02] Deskana: Yes. The main thing is that we fall back to the main page if something like that happens [18:39:33] (03PS3) 10Brion VIBBER: Footer updates [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/144342 [18:40:10] (03CR) 10Brion VIBBER: [C: 032 V: 032] Instead of "send feedback", "send app feedback". [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/143159 (owner: 10Dr0ptp4kt) [18:40:23] mhurd: how’s this look for you? https://gerrit.wikimedia.org/r/#/c/144342/ [18:40:27] footer changes [18:40:34] brion: cool! checking… [18:43:22] dbrant: i still don't get any warnings or disallows to show up on the preview page [18:43:53] dbrant: i tried on both test and enwiki [18:44:15] bearND: are you actually clicking the final Save button? (that's when it shows up) [18:45:09] dbrant: ok, i get it on the final save. Shouldn't it come a bit earlier? [18:46:25] dbrant: added repeating characters on the test page [18:46:32] 3Wikipedia App / 3iOS App: iOS App: "Allow Wikimedia to collect information about how you use the app..." is extremely vague - 10https://bugzilla.wikimedia.org/67405#c5 (10Dan Garry) 5NEW>3RESO/WON It's not really feasible to fill the app with information on what our EventLogging does and what informatio... [18:46:43] dbrant: did not show a warning [18:47:07] bearND: it has to be a *lot* of repeating characters. [18:47:17] 3Wikipedia App / 3iOS App: Article title not in italics for genus and species pages - 10https://bugzilla.wikimedia.org/67492 (10Dan Garry) 5UNCO>3NEW [18:48:42] bearND: the API only passes it through the abuse filters in the actual edit request. So, we can't really show it earlier. [18:49:21] brion: whoa looks great! couple quick tweaks to consider: if you rotate landscape the “other langs” text is aligning to top of the icon - maybe center vertically? and maybe add a bit of space beneath the license text - maybe 30 or 40 px or equiv? [18:50:01] 3Wikipedia App / 3iOS App: iOS: "back" button does not always return to the previous article - 10https://bugzilla.wikimedia.org/67497#c1 (10Dan Garry) 5UNCO>3NEW This also happens when using file pages; often, when you press back, you don't end up where you expect. I guess some forward navigation option... [18:50:03] hmm, should be doable in theory :D [18:53:52] dbrant: how many repeating chars are necessary? see test page again. this did not trigger any warning [18:54:01] 3Wikipedia App / 3iOS App: iOS: "back" button does not always return to the previous article - 10https://bugzilla.wikimedia.org/67497#c2 (10Monte Hurd) What's happening is we're not adding more than one history entry for a given page. The problem is, when you revisit a page it should move that history entry... [18:54:41] mhurd: oh MAN using the Safari hookup to the webview debugger is SOOOO nice for these in-web bits [18:54:48] brion: :) [18:54:50] i can literally edit the CSS styles live and copy-paste them back :D [18:55:07] brion: haha awesome! [18:55:51] brion: btw, chrome+android also works the same, 4.4+ [18:56:01] YuviPanda: <3 [18:56:11] this would have helped a lot in phonegap days :D [18:56:17] but even with the debugger, i prefer native… [18:57:33] (03PS4) 10Brion VIBBER: Footer updates [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/144342 [18:57:36] mhurd: how’s this look? [18:57:48] fixed the centering in landscape and added a little more margins [18:57:52] bearND: lol that's a lot of characters you added! I just triggered it by trying to add "aaaaaaaaaaaaaaaaaaaa" to the section called "new section" in that article. [18:57:56] brion: looking…. [19:00:34] brion: oh, that’s strange… on ios 6 the icons are both gray… [19:03:31] mhurd: hmm, looking at the same page? [19:03:38] the last-modified time only shows green if it’s within last 24 hrs [19:03:42] brion: oops good point! [19:04:12] dbrant: ok, got the warning to show up [19:04:13] brion: i think it looks great! want me to merge now? [19:04:19] mhurd: go for it! [19:04:21] \o/ [19:04:37] (03CR) 10Mhurd: [C: 032 V: 032] "This looks sweet!" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/144342 (owner: 10Brion VIBBER) [19:04:46] :D [19:04:49] brion: yay! [19:16:16] 3Wikipedia App / 3iOS App: iOS App: "Allow Wikimedia to collect information about how you use the app..." is extremely vague - 10https://bugzilla.wikimedia.org/67405#c6 (10Kunal Mehta (Legoktm)) (In reply to Dan Garry from comment #5) > It's not really feasible to fill the app with information on what our >... [19:24:31] gonna grab some lunch, then poke at next things \o/ [19:28:57] dbrant: hey? PM? [19:29:09] YuviPanda: yep [19:30:28] yurikR: hey! Is there any point in having REL1_23 branches for ZeroBanner and ZeroPortal ? [19:30:56] hashar, not really, not even sure how they got created [19:31:14] * yurikR conceedes he ain't no git guru :) [19:32:33] hashar, basically i tend to push master to prod on wednesdays, git adding them directly to wmf-xxx branches [19:37:33] 3MobileFrontend / 3Feature requests: Difficult or impossible to copy and paste file link from commons "use this image" - 10https://bugzilla.wikimedia.org/67618 (10Jared Zimmerman (WMF)) 3NEW p:3Unprio s:3normal a:3None Use this file on commons is a popup that is not mobile formatted, mobile version o... [19:40:31] 3MobileFrontend / 3Feature requests: Difficult or impossible to copy and paste file link from commons "use this image" - 10https://bugzilla.wikimedia.org/67618#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/OQReZlGW [19:45:18] YuviPanda: bearND|food still seeing this in review https://trello.com/c/ClliqXWm/17-3-edit-workflow-changes-abuse-filter , who's picking it up ? [19:45:39] mhurd: how is https://trello.com/c/yaiq6DSA/9-5-table-of-contents-refinements-for-articles coming long ? [19:45:42] i'm eager to close out the sprint [19:45:47] yurikR: will look at getting it removed. thanks! [19:45:56] tfinc: bearND|food was testing it before he went for lunch. [19:46:02] excellent [19:46:04] tfinc: getting close! [19:46:04] thanks YuviPanda [19:46:25] tfinc: yes, test is complete. just looking through the code changes [19:46:28] mhurd: exciting. looking forward to the build with it [19:47:49] dbrant: question about abusefilterCode. When is it supposed to become visible? [19:52:33] bearND: ah, I put it there expecting it to show up in the Designs, but in the end the designers chose to leave it out. I can delete it from the layout... [19:54:23] bearND: dbrant https://www.mediawiki.org/wiki/User:Yuvipanda/Android_app_releases draft release plan. Leave comments on the talk page? [19:54:27] I'm going to email it out to mobile-l now [20:16:40] tfinc: email sent. [20:16:46] YuviPanda: thanks [20:21:12] Is anyone from the mobile team here today? [20:26:29] KeybladeSpyMaste: mobile web team? jgonera and MaxSem and kaldari, I think. [20:26:37] KeybladeSpyMaste: go ahead and ask your question and whoever’s around will see if they can help [20:27:55] I'm hoping someone can help me. I'm trying to develop a mobile app for the Kingdom Hearts Wiki. When I was last here, I was told to send an email to the mailing list, but I got an automatic response that it had been rejected. So, I'm here again. [20:28:38] I'll be honest, I'm no expert in coding languages. I know very little, but I hope this project can help me learn more. [20:30:13] I really don't know where to start, but I think a good place would be to understand how the app would be able to get information from the wiki the way the Wikipedia app does from the site. [20:33:03] couple quick notes: [20:33:30] the mailing lists are generally configured to allow posts only from mail addresses that are subscribed, so double-check that you are subscribed with the same address you’re posting from [20:33:53] ^Well, that's the problem. I'm not subscribed at all. [20:33:59] well that’s fixable :D [20:34:13] as for how the app gets info: we use the API [20:34:37] for page views specifically we use action=mobileview which is provided by the MobileFrontend extension [20:35:19] and we have some CSS overrides for the web content area, some of which are shared with MobileFrontend and some which come in the MobileApp extension [20:35:45] KeybladeSpyMaste: our new apps (just released android, soon to release ios) are native apps; we also have an older codebase that was PhoneGap-based which ran on both but was a lot flakier [20:35:54] KeybladeSpyMaste: do you know which platform you want to concentrate on? [20:36:39] you could possibly use our apps as a base to work from, but we have a lot of Wikipedia-specific assumptions in them right now that would require modification for use on another wiki [20:36:52] Right now, I'm trying to develop it for Windows 8, because I'm really comfortable with that environment. And I can't get Eclipse to start up. [20:36:54] (03PS4) 10Dbrant: Abusefilter changes in Edit workflow. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/143024 [20:37:00] bearND: ^ [20:37:17] KeybladeSpyMaste: JavaScript or C#? [20:37:23] C# [20:37:29] dbrant: ok [20:37:57] ok, i’m fuzzier on C# but it’s a solid framework to use, shouldn’t be too hard for you to whip up an API data fetch wrapper [20:38:16] and if you’re comfier in visual studio, great :D [20:38:44] I don't know JS at all, and I learned a little C# last year in school, so that's why. And yeah, Visual Studio is what I'm using. [20:39:00] basically you need some way to fetch the data, then inject it into a web view [20:39:18] (our experimental windows 8 app was done in JS, so it’s probably not a good jumping off point) [20:39:56] Yeah. I downloaded the source code for that app, and tried to stare it down to understand it, but five days later, and I'm nowhere. [20:40:01] :D [20:40:35] KeybladeSpyMaste: you might want to peek at the Java API module we use for the ANdroid app — it’s not quite the same but it’s closer to C# than JS is :) https://github.com/Wikimedia/apps-android-java-mwapi <- github mirror [20:41:19] https://github.com/Wikimedia/apps-android-wikipedia <- and there’s the full android app in case you want examples of usage [20:41:46] KeybladeSpyMaste: and definitely check out the API docs. note that on any mediawiki site you can usually go to ‘api.php’ manually in place of ‘index.php’ and it’ll show self-documentation as well [20:42:06] this’ll be helpful if you can’t modify what’s on the site itself to see what’s available for an api client to use [20:42:32] I think I got the full Android app source code. The download link for the Windows 8 app, there wasn't one. The only way to download the source code was download the whole thing, with the source code to the iOS and Android apps, as well. [20:42:33] (for instance i don’t know if it’s got MobileFrontend’s action=mobileview or not) [20:42:59] yeah the combined app was hard to maintain :D [20:43:34] Someone told me that we had to install that first mobilefrontend extension before an app could be developed to access the wiki's content. [20:44:17] KeybladeSpyMaste: you could use other api methods instead but mobileview is optimized for what dynamic loading from web and apps need [20:44:46] KeybladeSpyMaste: this the wikia one? [20:45:07] Nope the Independent wiki. --> http://www.khwiki.com [20:45:10] aha [20:45:26] I figure it'd be easier than a wikia wiki, wouldn't it? [20:45:45] as long as you are or know the person who can install things on the wiki, yes :D [20:46:41] The wiki's developer said that he would install the MobileFrontend extension when we update to MediaWiki 1.23. I don't know when that will be, but he tends to be pretty timely about these kinds of things. [20:47:19] great. if you want to get started early, you can probably use standard API’s action=parse to fetch HTML [20:47:26] it’s a little wonky but it’s documented on mediawiki.org ;) [20:47:50] Where would that information be? [20:47:54] exactly? [20:48:32] KeybladeSpyMaste: http://www.mediawiki.org/wiki/API:Parsing_wikitext [20:49:20] our api’s a little weird because it started as XML and has gradually converted to often using JSON, so do read the introductory pages too :D [20:50:35] dbrant: bearND anything you guys need from me before I go? I think the redlinks patch is up for review once the abusefilter stuff is done, if you guys want [20:52:12] YuviPanda: I think it would be godd to spell out more of the git branching/tagging on https://www.mediawiki.org/wiki/User:Yuvipanda/Android_app_releases, but that could come tomrrow, too [20:52:39] bearND: I think that would come when we actually start doing this :) Can you add it to the 'TODO' section? [20:52:59] YuviPanda: ok, i'll review your redlink patch after the updated abusefilter patch is done [20:53:03] bearND: ty! [20:53:05] * YuviPanda waves [20:55:34] 3MobileFrontend / 3Feature requests: Add Donation link to main navigation - 10https://bugzilla.wikimedia.org/67626 (10Sherah Smith) 3NEW p:3Unprio s:3normal a:3None Could we add a donation link to the main navigation, which routes to donate.wikimedia.org? [20:57:18] 3MobileFrontend / 3Feature requests: Add Donation link to main navigation - 10https://bugzilla.wikimedia.org/67626 (10Sherah Smith) a:3Juliusz Gonera [20:58:03] 3MobileFrontend / 3Feature requests: Add Donation link to main navigation - 10https://bugzilla.wikimedia.org/67626 (10Sherah Smith) a:5Juliusz Gonera>3None [20:59:32] bearND, you want me to delete https://www.mediawiki.org/wiki/User:Yuvipanda/Talk:Android_app_releases ? [21:00:34] 3MobileFrontend / 3Feature requests: Add Donation link to main navigation - 10https://bugzilla.wikimedia.org/67626#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/XFwVzTAL [21:00:47] Krenair: yes. ty [21:01:19] bearND, okay. in future, remember we don't have templates like enwiki's db-g7 [21:01:28] we have 'speedy' and 'delete'. [21:01:48] done [21:11:13] Krenair: thank you. [21:16:57] YuviPanda: question: can i get a "nightly" or "ci" builds of mobile app ? [21:17:14] matanya: you can once we have them. They don't exist anywhere other than that page right now :) [21:17:22] but yes, once that goes through, we'll have public CI builds [21:17:34] sign me in :) [21:17:42] matanya: :D do +1 on talk page :) [21:18:48] {{done}} [21:19:55] matanya: ty [21:28:19] YuviPanda: I opted in to alpha and my app's icon is changing randomly between updates [21:28:29] when a version comes from alpha there's a star [21:28:37] liangent: yup, that's a problem. [21:28:38] when it's from stable the star is not there [21:28:41] funky [21:28:45] liangent: solution is to get rid of alpha :) [21:28:46] see mobile-l [21:30:51] om nom nom release cadence [21:35:28] YuviPanda: so one more package org.wikipedia.ci ? [21:35:36] liangent: probably, yeah [21:39:15] mhurd: how’s it going with the ToC stuff? anything i can help with or should i move on to the saved page update internals? [21:40:00] (03CR) 10BearND: [C: 04-1] Abusefilter changes in Edit workflow. (032 comments) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/143024 (owner: 10Dbrant) [21:42:36] brion: almost ready to for review. hopefully another 20 min or so. [21:43:55] awesome, ping me when ready :D [21:44:16] mhurd: excellent. lets get Dan that build once its reviewed [21:47:07] brion: will do. have a minute to chat about the backend saved pages stuff? [21:47:23] sure [21:49:33] 3Wikipedia App / 3Android App: i18n translations strings for 'yes' and 'no' are used in multiple questions - 10https://bugzilla.wikimedia.org/67628 (10Lloffiwr) 3NEW p:3Unprio s:3normal a:3None The current strings Wikipedia-android-strings-yes and Wikipedia-android-strings-no are used to answer 4 dif... [21:51:30] brion: there’s a slight (hopefully haha) refactor to the way the retrieved article gets routed to the core data store which would make doing the saved pages updates super simple. i’d have to poke around for a bit to refresh my memory. want me to fiddle with that first? [21:52:09] brion: or hangout after i get this patch wrapped? [21:52:13] mhurd: sure, just let me know how big a refactor it looks once you’re in there ;) [21:52:19] sure [21:53:04] brion: coolness! ok back to wrapping this up… :) [21:53:07] :D [22:04:12] brion I've been playing around and skimming the API documentation. I have a question on using it. To use it in the app, would the MobileFrontend extension add to the API that makes accessing the wiki's content easier, then? I'm sorry if you've alreay answered this, I'm just trying to make sure. [22:04:41] KeybladeSpyMaste: yeah, MobileFrontend extension adds the ‘action=mobileview’ API method which is very handy [22:04:47] (and probably not documented well….) [22:05:29] * brion coffee! [22:12:23] oh lemme set it to skip the onboarding page for now [22:12:26] that’s been driving me nuts :D [22:12:56] James_F|Away, kaity, are we doing the VE&mobile sync up today? I'd rather have a bit of rest instead today if you don't mind, an 1h interview is not something my throat was prepared for apparently [22:13:29] (03CR) 10BearND: [C: 031] "This patch depends on the nightmode patch, so I'll let dbrant +2 it once that is ready." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/144481 (owner: 10Yuvipanda) [22:13:43] jgonera: Its fine with me to hold off. James? [22:14:38] (03PS1) 10Brion VIBBER: Comment out the onboarding always-on mode [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/144594 [22:22:32] James_F, ^ [22:23:03] jgonera: Happy to push to tomorrow. Is Maryana OK with that? [22:23:12] jgonera: s/tomorrow/whenever/ [22:23:20] Maryana is on vacation, until Wednesday I think [22:23:31] let me check [22:24:15] yeah, she's back on Wednesday [22:24:51] James_F, ^ [22:25:57] (03PS1) 10Mhurd: Table of contents refinements. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/144597 [22:26:11] jgonera: Well in that case, would Wednesday be better? [22:26:17] brion: sry took so long [22:26:22] no worries [22:26:30] James_F, if we want Maryana to be there, yes ;) I can do tomorrow as well [22:26:34] Kk. [22:26:52] brion: snuck the rtl fix in there [22:26:56] nice :D [22:27:48] thanks James_F [22:27:55] :-) [22:31:39] mhurd: nice! [22:31:43] lemme test on 6 real quick :D [22:32:38] (03CR) 10BearND: [C: 031] "This patch depends on another patch which in turn depends on the nightmode patch, so I'll let dbrant +2 it once that is ready" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/144486 (owner: 10Yuvipanda) [22:33:43] it woorrrrrrks :D [22:34:01] lol [22:34:16] 3Wikipedia App / 3Android App: i18n translations strings for 'yes' and 'no' are used in multiple questions - 10https://bugzilla.wikimedia.org/67628#c1 (10Andre Klapper) https://translatewiki.net/wiki/Summary:Thread/About_Wikimedia:Wikipedia-android-strings-yes/en_(2) is empty for me so I wonder why this is n... [22:36:42] (03CR) 10Brion VIBBER: [C: 032 V: 032] "Awesome; looks great, and now comes in from the proper side on both LTR and RTL locales." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/144597 (owner: 10Mhurd) [22:36:55] woohoo! [22:37:05] mhurd: also i’ve got a quick fix here: https://gerrit.wikimedia.org/r/#/c/144594/ [22:37:12] comments out the lines that force the onboarding to always show :D [22:37:19] brion: poking… [22:37:22] (03PS5) 10BearND: Abusefilter changes in Edit workflow. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/143024 (owner: 10Dbrant) [22:37:31] ok lemme hope i can find the “english” button again [22:37:37] dbrant|brb: ^ made the changes I commented about earlier [22:37:46] (03CR) 10Mhurd: [C: 032 V: 032] "Looks good." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/144594 (owner: 10Brion VIBBER) [22:37:57] brion: merged [22:38:02] whew, back to english UI :D [22:38:04] thanks [22:38:34] brion: quick hangout at 4 about saved pages sync? [22:38:42] mhurd: sounds good [22:38:52] (03CR) 10Dr0ptp4kt: [C: 04-1] "See inline comment." (031 comment) [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/144132 (owner: 10Yurik) [22:39:26] brion: oops i have 1:1 w tomasz at 4. 4:30 work? [22:39:42] 4:30 it is :D [22:39:49] brion: perfect [22:39:53] i’ll poke on other bits until then, i’ve got some small b ugs to pick up [22:39:58] (03CR) 10BearND: [C: 032] Abusefilter changes in Edit workflow. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/143024 (owner: 10Dbrant) [22:40:18] (03Merged) 10jenkins-bot: Abusefilter changes in Edit workflow. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/143024 (owner: 10Dbrant) [22:41:16] (03CR) 10Dr0ptp4kt: [C: 04-1] "Just waiting on dependency issue to be resolved. After that's resolved, let's look at this one." [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/144333 (owner: 10Yurik) [22:41:57] dr0ptp4kt, could you try it with the follow-up patch? [22:42:10] i'm having some issues with vagrant now :) [22:43:33] 3Wikipedia App / 3iOS App: [iOS] ToC entries should be right-aligned in RTL content languages - 10https://bugzilla.wikimedia.org/67630 (10Brion Vibber) 3NEW p:3Unprio s:3normal a:3None Currently the ToC entries seem to be always left-aligned within their boxes. For RTL content languages we should swi... [22:43:43] (03CR) 10MaxSem: Insert section name in edit summary (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/135311 (https://bugzilla.wikimedia.org/60134) (owner: 10Florianschmidtwelzow) [22:44:26] yurikR: same result there. kinda thought so because they hit different parts of the code [22:46:49] 3Wikipedia App / 3iOS App: [iOS] back/forward button icons should be horizontally flipped in RTL locale - 10https://bugzilla.wikimedia.org/67632 (10Brion Vibber) 3NEW p:3Unprio s:3normal a:3None Layouts get flipped in RTL locale and so the 'back' button appears to the right of the 'forward' button in... [22:48:39] bearND: is https://trello.com/c/ClliqXWm/17-3-edit-workflow-changes-abuse-filter ready to go into a build ? [22:48:45] Brion thanks so much for you help! I think I've got somewhere I can go from here. [22:48:55] KSM|GadgetCoding: awesome! [22:49:03] 3Wikipedia App / 3iOS App: [iOS] Tapping ToC entries near end of page scrolls to wrong position - 10https://bugzilla.wikimedia.org/67633 (10Brion Vibber) 3NEW p:3Unprio s:3normal a:3None Tapping for instance 'external links' section at the bottom often ends up scrolling to somewhere above it, as I be... [22:49:36] KSM|GadgetCoding: drop me a line if I can help with anything; my C# experience is a little limited but I know the API side :) [22:49:40] I'll probably still drop in once in a while for help, so I apologize ahead of time. I realize you guys have a lot more work to do than help a random user with an app for a random wiki, but I appreciate the help. [22:49:44] yurikR: that is, 144333 for ZeroPortal, and either of master or 144133 for ZeroBanner: problems. master (warning), 144133 (fatal). gotta run. will be online later tonight in case of any luck... [22:50:17] tfinc: yes, apk is built. i'll send email to Deskana|Away. Do i need to include anyone else? [22:50:55] bearND: Deskana|Away is fine. please move the card over [22:51:30] tfinc: done [22:52:08] thanks [22:53:16] 3Wikipedia App / 3iOS App: [iOS] Tapping ToC entries near end of page scrolls to wrong position - 10https://bugzilla.wikimedia.org/67633 (10Brion Vibber) [22:53:19] 3Wikipedia App / 3iOS App: Add ToC entry for page footer links - 10https://bugzilla.wikimedia.org/67635 (10Brion Vibber) 3NEW p:3Unprio s:3normal a:3None We've put important things like 'read in other languages' down in the page footer, which is difficult to scroll to on a long page. Might want to ad... [23:00:32] 3Wikipedia App / 3iOS App: iOS App: Bottom of article says "1 other languages" - 10https://bugzilla.wikimedia.org/65825#c3 (10Brion Vibber) Ok, new design updated the text, but we still have the "plural problem". Filed a bug for Translate extension to add support for the iOS 7 / OS X 10.9 plurals addition to... [23:03:06] Deskana|Away: You have links for mobile web view destinations from the more screens? [23:04:17] 3Wikipedia App / 3iOS App: iOS App: "Last Modified..." should be clickable and take you to page history - 10https://bugzilla.wikimedia.org/66908#c2 (10Brion Vibber) 5NEW>3RESO/FIX is done. [23:04:46] 3Wikipedia App / 3iOS App: iOS App: bad unlocalized API message with {{PLURAL:}} shown to user - 10https://bugzilla.wikimedia.org/66944#c5 (10Brion Vibber) (updated summary) [23:05:32] 3Wikipedia App / 3iOS App: [iOS] Fix that onboarding page hide-once-seen logic - 10https://bugzilla.wikimedia.org/67612#c1 (10Brion Vibber) 5NEW>3RESO/FIX done [23:06:17] 3Wikipedia App / 3iOS App: iOS App: Table of contents drawer should animate from right instead of left - 10https://bugzilla.wikimedia.org/64336#c7 (10Brion Vibber) 5REOP>3RESO/FIX Done in latest commits. [23:07:02] 3Wikipedia App / 3iOS App: Article title not in italics for genus and species pages - 10https://bugzilla.wikimedia.org/67492#c2 (10Brion Vibber) see also bug 63971 -- maybe merge [23:14:32] 3Wikipedia App / 3iOS App: iOS app: "Log out [username]" does not normalize username - 10https://bugzilla.wikimedia.org/63969#c1 (10Brion Vibber) Probably the thing to do is normalize on login, so we save the normalized version and just keep that for display later. Not sure if we get it back from the API con... [23:15:31] 3Wikipedia App / 3iOS App: iOS App: History view stops after a certain point - 10https://bugzilla.wikimedia.org/65820#c1 (10Brion Vibber) Yeah, we either need to handle infinite scroll, or link out to the mobile web view as a temporary hack. [23:16:17] 3Wikipedia App / 3iOS App: iOS app: "Log out [username]" does not normalize username - 10https://bugzilla.wikimedia.org/63969#c2 (10Yuvi Panda) It does return them properly when you login. This is what the Android app uses. [23:22:35] bearND: thanks for that patch! [23:23:19] dbrant: sure thing. i sent off an apk to Deskana|Away so he can review the latest bits [23:25:19] bearND: is https://gerrit.wikimedia.org/r/142267 ready to graduate from WIP? it seems to work on all devices we've tried. [23:26:00] dbrant: yes, it is. just need to change the commit message. Most of the TODOs are obsolete [23:26:16] dbrant: feel free to change that [23:27:16] dbrant: was thinking we could use the system settings info as the default value, and then just use the current preference value [23:32:26] bearND: what do you think is better -- three discrete options to select "small/medium/large" text, or a slider that provides a finer-grained selection? [23:37:11] (03PS1) 10Brion VIBBER: Add footer-divider.png (whoops!) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/144614 [23:38:56] dbrant: i like what the current design and the kindle app have: two buttons: - and + font size [23:40:01] bearND: the current design has only two selections... is that enough? [23:40:38] dbrant: i'm thinking of the two buttons as "make it smaller" and "make it bigger" [23:41:04] dbrant: not really two absolute sizes [23:41:18] bearND: oooh, that's not how I interpreted it! [23:41:21] lol [23:41:38] dbrant: more like a fontSize— and fontSize++ [23:41:55] kaldari: Is there a general bug for sub-page support in MF? Can't find one in Bugzilla but I might not be looking right. [23:42:29] James_F: No, there are just lots of bugs related to subpages and lazy-loading. [23:43:01] James_F: although I have no idea how many are reported and/or still open [23:43:14] * James_F nods. [23:43:21] (03PS2) 10Dbrant: Adjust font size based on system settings [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/142267 (owner: 10BearND) [23:43:34] (03CR) 10Dbrant: [C: 032] Adjust font size based on system settings [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/142267 (owner: 10BearND) [23:43:47] kaldari: OK if I make one with lots of "?"s in it? :-) [23:43:57] yes [23:44:20] you don't have to troubleshoot it, just describe the brokenness :) [23:45:04] (03Merged) 10jenkins-bot: Adjust font size based on system settings [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/142267 (owner: 10BearND) [23:45:43] * James_F cheats. [23:45:48] 3MobileFrontend / 3alpha: VisualEditor Mobile: When saving a sub page, Mobile Frontend redirects it to the parent page which contains a link to it - 10https://bugzilla.wikimedia.org/67639 (10James Forrester) a:3None [23:50:31] 3MobileFrontend / 3alpha: VisualEditor Mobile: When saving a sub page, Mobile Frontend redirects it to the parent page which contains a link to it - 10https://bugzilla.wikimedia.org/67639#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/wdlVRRim [23:57:05] eh, no yurik?