[00:07:46] (03CR) 10Yurik: New config page text update (031 comment) [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/144132 (owner: 10Yurik) [00:08:17] 3MobileFrontend / 3alpha: VisualEditor Mobile: When saving a sub page, Mobile Frontend redirects it to the parent page which contains a link to it - 10https://bugzilla.wikimedia.org/67639#c2 (10Ryan Kaldari) Sounds like another lazy-loading bug. [01:16:31] 3Wikipedia App / 3iOS App: iOS App: Table of contents drawer should animate from right instead of left - 10https://bugzilla.wikimedia.org/64336 (10Kunal Mehta (Legoktm)) 5RESO/?>3VERI [01:19:01] 3Wikipedia App / 3iOS App: iOS App: "Last Modified..." should be clickable and take you to page history - 10https://bugzilla.wikimedia.org/66908 (10Kunal Mehta (Legoktm)) 5RESO/?>3VERI [01:21:19] 3Wikipedia App / 3iOS App: iOS App: Last modified pencil icon is the same as edit pencil - 10https://bugzilla.wikimedia.org/67647 (10Kunal Mehta (Legoktm)) 3NEW p:3Unprio s:3normal a:3None There is a pencil icon right next to the Last modified link, but it's the exact same pencil as the one you'd cli... [01:22:19] 3Wikipedia App / 3iOS App: iOS App: "Search English language wiki" should say Wikipedia - 10https://bugzilla.wikimedia.org/67648 (10Kunal Mehta (Legoktm)) 3NEW p:3Unprio s:3normal a:3None On the ... menu behind the W menu. wiki != Wikipedia [01:24:35] 3Wikipedia App / 3iOS App: iOS App: CC link in footer should link to mobile version of site - 10https://bugzilla.wikimedia.org/67650 (10Kunal Mehta (Legoktm)) 3NEW p:3Unprio s:3minor a:3None In the footer, there is a link to the CC-BY-SA 3.0 license on Wikipedia, but it links to the desktop site, not... [01:27:57] (03PS1) 10Legoktm: Link directly to mobile site in CC-BY-SA 3.0 link [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/144628 (https://bugzilla.wikimedia.org/67650) [01:59:01] 3Wikipedia App / 3Android App: i18n translations strings for 'yes' and 'no' are used in multiple questions - 10https://bugzilla.wikimedia.org/67628#c2 (10Yuki Shira) See https://translatewiki.net/wiki/Thread:Support/About_Wikimedia:Wikipedia-android-strings-yes/en_%282%29 [01:59:31] 3MobileFrontend / 3General/Unknown: Mobile is somehow sending API requests that ask for text/html content - 10https://bugzilla.wikimedia.org/67426#c2 (10Max Semenik) Oliver, anything interesting about their user-agents? [03:27:21] yurik: you there? [03:30:56] (03CR) 10Dr0ptp4kt: [C: 032] Safer caching, reorged config fields [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/144133 (owner: 10Yurik) [03:31:09] (03Merged) 10jenkins-bot: Safer caching, reorged config fields [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/144133 (owner: 10Yurik) [03:31:44] (03CR) 10Dr0ptp4kt: [C: 032] New config page text update [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/144132 (owner: 10Yurik) [03:32:54] (03Merged) 10jenkins-bot: New config page text update [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/144132 (owner: 10Yurik) [03:33:20] (03CR) 10Dr0ptp4kt: [C: 032] Show zero image banners in the config page [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/144333 (owner: 10Yurik) [03:33:31] (03Merged) 10jenkins-bot: Show zero image banners in the config page [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/144333 (owner: 10Yurik) [03:50:10] (03CR) 10Dr0ptp4kt: [C: 04-1] "See inline comment." (031 comment) [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/144258 (owner: 10Yurik) [03:51:00] yurik: i gotta get some sleep. looks like there's some stuff to do on the gif. talk to you tomorrow... [04:32:32] (03CR) 10Yurik: Unified HTML with image banners for non-js users (031 comment) [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/144258 (owner: 10Yurik) [05:02:02] whee updates to ios & osx betas [05:08:12] (03PS9) 10Florianschmidtwelzow: Insert section name in edit summary [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/135311 (https://bugzilla.wikimedia.org/60134) [05:12:22] (03PS10) 10Florianschmidtwelzow: Insert section name in edit summary [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/135311 (https://bugzilla.wikimedia.org/60134) [05:29:36] (03PS1) 10Yurik: Skip processing invalid pages in API, better err msg [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/144636 [05:31:19] MaxSem, if around, tiny patch https://gerrit.wikimedia.org/r/#/c/144636/ - i don't want to self +2 it [05:34:28] yurikR, did you know you can "ZeroAPI: Unable to parse json of page {$page['title']}" ? [05:34:45] MaxSem, yes :) [05:34:48] (03CR) 10MaxSem: [C: 032] Skip processing invalid pages in API, better err msg [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/144636 (owner: 10Yurik) [05:34:58] (03Merged) 10jenkins-bot: Skip processing invalid pages in API, better err msg [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/144636 (owner: 10Yurik) [05:35:10] thanks! btw, MaxSem, q for you - perf wise - are they the same? :D [05:35:34] you shouuldn't do microoptimization [05:35:59] true, but would be good to know [05:36:12] i wonder if this is a compiler function or runtime [05:36:17] I vaguely recall that double quotes are slightly faster duee to lack of concatenation, but doesn't really matter [05:36:41] oh? strange, i would have thought that formatting is actually slower process [05:36:59] anyway, thx :) [05:37:15] concatenation = new string = memory allocation [05:37:29] and formatting uses internal buffer? [05:37:55] still it has to create a new str - allocation [06:56:39] (03PS7) 10Yurik: Unified HTML with image banners for non-js users [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/144258 [09:08:16] (03PS1) 10Yurik: Comma-separated list view, extra validators [extensions/JsonConfig] - 10https://gerrit.wikimedia.org/r/144650 [09:11:21] (03PS1) 10Yurik: Validate each admin value individually [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/144651 [09:13:27] (03PS1) 10Yurik: Simplified config view [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/144652 [09:19:26] (03CR) 10Yurik: [C: 04-2] Comma-separated list view, extra validators [extensions/JsonConfig] - 10https://gerrit.wikimedia.org/r/144650 (owner: 10Yurik) [09:19:44] (03CR) 10Yurik: [C: 04-2] Validate each admin value individually [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/144651 (owner: 10Yurik) [09:19:46] (03CR) 10Yurik: [C: 04-2] Simplified config view [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/144652 (owner: 10Yurik) [09:55:17] 3Wikipedia App / 3Android App: i18n translations strings for 'yes' and 'no' are used in multiple questions - 10https://bugzilla.wikimedia.org/67628#c3 (10Andre Klapper) Ok, but I expected that link to provide an explanation for the "htmlform-yes and htmlform-no precedent" or where to find that. :) [11:35:54] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/144651 (owner: 10Yurik) [15:09:56] * YuviPanda waves [15:10:33] 3MobileFrontend / 3alpha: Tasks suggestion campaign for adding links not specific enough - 10https://bugzilla.wikimedia.org/67674 (10Derk-Jan Hartman) 3NEW p:3Unprio s:3normal a:3None https://en.m.wikipedia.org/w/index.php?title=Human_trafficking_in_Turkmenistan&campaign=mobile-mainpage-keepgoing-lin... [15:12:37] Hi YuviPanda and dbrant [15:12:46] hello! [15:12:57] heya [15:13:20] 3MobileFrontend / 3alpha: Continue button in campaign is missing - 10https://bugzilla.wikimedia.org/67675 (10Derk-Jan Hartman) 3NEW p:3Unprio s:3normal a:3None Tablet mode: https://en.m.wikipedia.org/w/index.php?title=Maru_Pradesh&campaign=mobile-mainpage-keepgoing-links There is a continue button... [15:14:56] YuviPanda: mind talking me through the make-css-assets script? Main question is how do I get a list of available modules? And where does the android module live? [15:15:18] bearND: ah, so it lives in the Extension:MobileApp code repsository [15:15:33] 3MobileFrontend / 3alpha: Continue button in campaign is missing - 10https://bugzilla.wikimedia.org/67675#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/ETERhkpC [15:15:33] 3MobileFrontend / 3alpha: Tasks suggestion campaign for adding links not specific enough - 10https://bugzilla.wikimedia.org/67674#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/lwJaVjd9 [15:15:34] bearND: https://gerrit.wikimedia.org/r/#/c/144454/ is the patch that adds the night mode colors [15:16:29] YuviPanda: great. I'll check it out [15:16:35] bearND: :) [15:16:47] bearND: dbrant you should use https://www.mediawiki.org/wiki/MediaWiki-Vagrant [15:17:01] I can do a session on MW-Vagrant / Extension:MobileApp in a few days if you want [15:17:20] that would probably be helpful [15:17:48] YuviPanda: yes, please [15:20:54] bearND: dbrant friday post standup? [15:21:56] YuviPanda: how long does it take? we have another meeting 30 min later [15:22:31] bearND: ow, I have that too :) How about before standup, if that works for you guys? [15:22:53] YuviPanda: sure, before works for me [15:23:45] dbrant: ^? [15:23:45] yep, that's fine [15:30:36] YuviPanda: about https://trello.com/c/4uM5TyRG/4-5-as-a-reader-i-would-like-references-to-not-move-my-screen-position-around-as-much-and-be-generally-more-usable: Have you thought about implementation of the reference drawer in web code vs native Android UI? The reference drawer in MF seems pretty nice already. Was wondering if it would make sense to leverage that. [15:30:50] bearND: nah, definitely native code. [15:30:55] bearND: keep JS as minimal as possible. [15:31:20] YuviPanda: alright [15:31:32] bearND: it's going to be slightly more complex, but well worth it [15:32:46] YuviPanda: I've already got code to bring the ref info over the bridge. Why do you say it's well worth it? [15:33:28] bearND: mostly negative experiences from the phonegap days :) Plus, especially since this will be a viewpager with swiping to access prev/next references, I'd think native code ought to be far smoother than web code [15:34:44] YuviPanda: sounds good [15:53:07] vbamba: YuviPanda: dbrant: Deskana|Away: what's your opinion re: reference display: should the PageViewer be able to go through all references on a page or only the nearby ones? [15:53:28] bearND: just the nearby ones, I'd say [15:53:40] bearND: only the ones that are contiguous within the text [15:53:51] yeah [15:53:57] contiguous is the important bit there, I'd think [15:56:08] thanks guys [15:57:40] (03PS5) 10Florianschmidtwelzow: Proposal: Redirect to direct match in search [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/139556 (https://bugzilla.wikimedia.org/66506) [16:07:47] 3MobileFrontend / 3Feature requests: Difficult or impossible to copy and paste file link from commons "use this image" - 10https://bugzilla.wikimedia.org/67618#c2 (10Florian) Maybe add a static section to file pages with title "Use this file" (like categories) and display the possibilities to insert this fil... [16:51:00] dr0ptp4kt, hi, did you try your sample again? [16:51:39] (03PS1) 10Florianschmidtwelzow: Add continue message to KeepGoing [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/144719 (https://bugzilla.wikimedia.org/67675) [16:54:29] yurikR: huh? [16:55:33] (03CR) 10Jdlrobson: [C: 031] "Since this is alpha only, I think we should merge this. It will be really useful to gather some anonymous editing data." (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/138802 (https://bugzilla.wikimedia.org/59937) (owner: 10Florianschmidtwelzow) [16:55:47] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/144487 (https://bugzilla.wikimedia.org/64616) (owner: 10Florianschmidtwelzow) [16:56:13] dr0ptp4kt, i tried your sample yesterday, couldn't see the problem [16:56:48] dr0ptp4kt, when you are trying, make sure to get both zb & zp [16:58:17] 3MobileFrontend / 3alpha: VisualEditor Mobile: When saving a sub page, Mobile Frontend redirects it to the parent page which contains a link to it - 10https://bugzilla.wikimedia.org/67639#c3 (10Jon) OT: I notice you are testing VisualEditor in alpha since the bug is assigned to alpha. Please don't.... Please... [16:59:25] (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed. Qqq needs a small refinement." (031 comment) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/143156 (owner: 10Dr0ptp4kt) [17:03:22] yurikR: see email with attachments for js vs non-js [17:09:44] YuviPanda: what was the rationale of creating the "Agora" theme? When I run the app with "AppCompat.Light", I see hardly any difference... [17:10:18] dbrant: minor color differences, IIRC (white action bars?). idea being we'd put button colors, etc there as well [17:10:38] dbrant: it was created by our previous designer (May) through one of the generators [17:13:48] YuviPanda: well, if I'll be working on a "dark" theme, I'd like to simplify this a bit. [17:16:12] (03PS2) 10Jdlrobson: Revert "Give anons tokens too" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/143799 (https://bugzilla.wikimedia.org/67171) (owner: 10MaxSem) [17:16:26] (03CR) 10Jdlrobson: [C: 032] Revert "Give anons tokens too" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/143799 (https://bugzilla.wikimedia.org/67171) (owner: 10MaxSem) [17:17:58] (03Merged) 10jenkins-bot: Revert "Give anons tokens too" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/143799 (https://bugzilla.wikimedia.org/67171) (owner: 10MaxSem) [17:18:08] dbrant: yeah, feel free to [17:18:18] dbrant: also I'm unsure if we can use the theme framework. Can we dynamically set the theme at all? [17:18:50] YuviPanda: yes, but it would require restarting the activity. [17:19:27] dbrant: hmm, right. so we could do that for all other activities, and not for the pageactivity itself [17:19:29] makes sense. [17:19:47] dbrant: feel free to simplify [17:20:02] dbrant: also I think the current night mode patch can be merged if you/bearND are ok with it. we can always change the colors later [17:20:30] am ok with it if you guys want to wait for the colors as well [17:20:45] I can rebase the ther patches so they aren't blocked by the night mode patch as well [17:21:10] (03PS1) 10Mhurd: Hide images in toc for now. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/144723 [17:21:12] YuviPanda: i've already +1 most of the night mode patches. I'll let dbrant +2 when he's ready [17:21:12] Deskana: i'd like to close https://trello.com/b/BQHyq56D/mobile-app-sprint-34-the-final-ios-countdown, have you been able to review the stories in the 'Ready for sign off column' ? [17:21:15] brion: ^ [17:21:36] ah cool [17:21:50] tfinc: I can take a quick look now. [17:22:28] Deskana and YuviPanda, was wondering if you had a chance to think about my Comment (questions) in https://gerrit.wikimedia.org/r/#/c/143156/ ? [17:22:40] * YuviPanda clicks agaikn [17:22:55] YuviPanda: the only comment I had about that was the "last_updated" time (it's 2019). Did you mean to leave it that way? [17:23:02] dbrant: ah, hmm. good question. [17:23:25] dbrant: I'm unsure. the MobileApp patch hasn't been merged yet, but easy to take care of that with brion or someone. and then we'd need to point the stylefetcher to betalabs [17:23:32] dbrant: personally, I'm ok with leaving it at 2019 for now [17:24:04] bearND: What build is the onboarding in? [17:24:14] bearND: I downloaded the 07-02 APK but I can't get the onboarding to trigger, if it's in that. [17:24:29] Deskana: I sent you an email with a link to the apk yesterday [17:24:52] (03CR) 10Brion VIBBER: [C: 032 V: 032] Hide images in toc for now. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/144723 (owner: 10Mhurd) [17:24:55] So you did. [17:25:39] Deskana: BTW you'll get the onboarding screen only once. if you want to get it again you need to clear data in the app settings. [17:26:43] (03CR) 10Brion VIBBER: [C: 032 V: 032] Link directly to mobile site in CC-BY-SA 3.0 link [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/144628 (https://bugzilla.wikimedia.org/67650) (owner: 10Legoktm) [17:26:44] which reminds me: YuviPanda: or dbrant: woul dyou CR https://gerrit.wikimedia.org/r/#/c/144492/? [17:27:17] 3MobileFrontend / 3beta: VisualEditor Mobile: When saving a sub page, Mobile Frontend redirects it to the parent page which contains a link to it - 10https://bugzilla.wikimedia.org/67639#c4 (10Jon) Just checked with Rumana and it's actually an issue in beta mode too. So not necessarily related to ajax page l... [17:27:36] bearND: dbrant yeah, let me CR that patch now [17:27:51] (03CR) 10Mhurd: [C: 032 V: 032] "Looks good. Will make it stretch later." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/144614 (owner: 10Brion VIBBER) [17:28:15] bearND: There are some minor tweaks for the onboarding, but they can be a separate card. [17:28:38] bearND: I'm impressed with how it looks, especially considering I'm testing on my tablet. [17:28:57] Deskana: try landscape too [17:31:11] Deskana: what tweaks do we need? [17:31:35] bearND: I got stuck in an infinite loop tapping "Don't have an account?" and "Already have an account?" on the forms [17:31:59] I just quickly tested the abuse filter. Going back to the onboarding now to write this down. [17:32:09] Deskana: yeah but if you press back you should get back quickly [17:32:45] If you press back repeatedly, it then just shows the login form tons of times [17:32:47] Which is really odd [17:33:45] Aha, the landscape is nice. [17:36:12] Deskana: the back behavior is a bug then [17:36:34] Let me test that again. [17:38:00] I had to tap back 19 times to leave the onboarding that time! [17:38:12] So basically the only issue is that you can get stuck in that infinite loop. [17:38:23] If it's a quick fix then I'd say let's do it. If it's going to be more involved, then we should leave it. [17:38:25] Thoughts? [17:40:55] Deskana: it's a bit more involved [17:41:33] that's the reason why i originally wanted to make the logina and create account screens into fragments [17:41:34] The back bug is a bit more worrying, as I suspect it's not limited to the onboarding flow, but more to do with cycling between two pages. [17:42:12] yes, the same would happen when you click login from the nav drawer [17:44:16] (03CR) 10Yurik: [C: 04-2] Show ZERO info screen on banner click [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/144175 (owner: 10Yurik) [18:05:01] brion: http://stackoverflow.com/questions/12497940/uirefreshcontrol-without-uitableviewcontroller [18:23:25] (03PS1) 10Mhurd: Fix for line wrapping in TOC in iOS 6. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/144729 [18:23:28] brion: ^ [18:26:25] (03CR) 10Dr0ptp4kt: [C: 032] "The font size issue needs to be resolved in a follow up patch prior to rollout to operators. Probably via CommonsSettings.php, but maybe i" [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/144258 (owner: 10Yurik) [18:26:41] (03Merged) 10jenkins-bot: Unified HTML with image banners for non-js users [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/144258 (owner: 10Yurik) [18:28:48] 3Wikipedia App / 3iOS App: iOS App: CC link in footer should link to mobile version of site - 10https://bugzilla.wikimedia.org/67650 (10Kunal Mehta (Legoktm)) 5PATC>3RESO/FIX a:3Kunal Mehta (Legoktm) [18:29:10] (03PS2) 10Yurik: Validate each admin value individually [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/144651 [18:38:22] (03CR) 10Brion VIBBER: [C: 032 V: 032] Fix for line wrapping in TOC in iOS 6. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/144729 (owner: 10Mhurd) [18:40:33] 3MobileFrontend / 3Feature requests: Add Donation link to main navigation - 10https://bugzilla.wikimedia.org/67626#c2 (10Jon) Sherah I find we need make the donation page mobile friendly and pretty first before we can even think of doing this... https://donate.wikimedia.org/w/index.php?title=Special:Fundrai... [18:41:48] (03CR) 10Dr0ptp4kt: "@Siebrand, see inline comment." (031 comment) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/143156 (owner: 10Dr0ptp4kt) [18:44:36] YuviPanda: yo [18:44:41] aharoni: heya! [18:45:04] it's fun to see the credit to the translatewiki translators in the about page :) [18:45:14] but it is not translated itself [18:45:17] ;) [18:45:37] aharoni: oh, that got merged? I... kinda forgot [18:45:55] yeah [18:46:01] dr0ptp4kt, hehe, found first bug - take a look at http://zero.wikimedia.beta.wmflabs.org/wiki/Zero:ZM2-SO [18:46:23] it thinks that zero. is a zero domain, hence renders the error warning [18:46:28] YuviPanda: but it looks like the translations weren't synced in a few days [18:46:52] yurikR: ha [18:46:59] aharoni: yeah, don't think so. we're just letting the normal twn import/export process take place. Don't want manual imports/exports to become the norm :) [18:47:08] dr0ptp4kt, but at least you can see what the text looks like (and how big it is) [18:47:53] yurikR: i haven't been doing editing in betalabs. to edit configs there, just create an id and go to the Zero: config to modify? [18:47:58] MAN i am so happy with modern debuggers in javascript, java, and obj-c [18:48:05] dr0ptp4kt, correctc [18:48:10] how’s the debugger in phpstorm for server-side code? anyboy use it? [18:48:26] brion, use it all the time, best thing on earth [18:48:31] excellent [18:48:38] i may grab it before i next dive into PHP stuff :D [18:48:48] i just can’t go back to adding wfDebug() calls [18:48:52] brion, just get vagrant - it is already pre-setup for debugging [18:48:57] ah nice [18:49:13] yeah i should stop doing my local install and just give in to the future :D [18:49:20] btw, it is also pre-setup for phpstorm [18:49:25] .idea dir is part of vagrant [18:49:32] nice [18:49:41] so you get our coding style, etc [18:49:50] (might need some cleanup there too) [18:51:46] YuviPanda: o i [18:51:48] YuviPanda: o i c [18:51:53] aharoni: ya [18:53:17] 3MobileFrontend / 3Feature requests: Add Donation link to main navigation - 10https://bugzilla.wikimedia.org/67626#c3 (10Sherah Smith) (In reply to Jon from comment #2) > Sherah I find we need make the donation page mobile friendly and pretty > first before we can even think of doing this... > > https://don... [18:56:47] (03PS1) 10Brion VIBBER: Work in progress: pull to refresh refactor [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/144735 [19:09:08] dr0ptp4kt, i tried setting -font to FreeSans and FreeSansWMF.ttf on betalabs but it instantly stopped working. still investigating [19:17:23] mhurd: Just looking at the ToC stuff. It's lagging a lot on my iPhone 4. [19:17:48] mhurd: If I swipe down on the ToC really quickly it lags a lot at first, but then the animation stops lagging as it reaches the correct spot. [19:18:04] mhurd: There's also no images on the ToC at all, which surprised me. [19:21:55] Hmm. [19:22:00] Deskana: (mhurd’s on a falafel run) [19:22:15] So we have the More menu mockup done, but there's no card for it in the current sprint? [19:22:17] I done goofed. [19:22:18] Deskana: yeah we saw the slow behavior on older devices, monte’s gonna try fixing it [19:22:38] hmm, what’s the plan on images? remove or keep or restyle? [19:22:53] brion: Let me check the mockup. [19:23:27] brion: https://trello.com/c/FUzGGf2G/7-design [19:23:34] brion: There should be some images in there according to this. [19:24:18] It's not a blocker for release as far as I'm concerned, we can just add them in later. [19:24:25] But I'm just wondering if there was some discussion I missed. [19:25:03] Yes, there's no card in sprint 35. [19:25:04] Fuck. [19:25:15] Well, we all agreed it's a blocker for release, so I'm putting it in. [19:25:24] moar stoary points! [19:26:04] yeah not sure i’ll poke mhurd when he’s back [19:28:37] I sent an email to mobile-l. [19:28:45] I'll take more points out of the to do column to compensate for this. [19:30:03] I mean, it's the second day of the sprint and there's barely any points left in to do, but that's fine. :) [19:30:07] Better than fine. [19:30:35] :D [19:31:14] It's a 37 point sprint and we're running out of things to do. On the second day. [19:31:15] wat. [19:31:16] A good kind of wat. [19:31:34] We do have 18 points in doing, I guess. :P [19:31:41] So that's probably about right. [19:31:49] Deskana: yeah, plus a few biggish cards [19:36:23] (03PS1) 10BearND: Break infinite loop of login and create account activities [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/144742 [19:36:37] Deskana: ^ I think this should fix the issue [19:37:21] bearND: I've a few comments on the EL patch as well, got lost in a few hundred tabs. will hit submit shortly [19:37:47] 3MobileFrontend / 3Feature requests: Add Donation link to main navigation - 10https://bugzilla.wikimedia.org/67626#c4 (10Jon) That's Maryanas call but I would definitely argue against surfacing a badly optimised page prominently in the UI as it reflects badly on my developer skills ;). Happy to assist in mak... [19:47:02] YuviPanda: curious about your comments re:EL [19:47:33] YuviPanda: how necessary is it to change the chrome colors when switching to WP Zero? (this would be affected by my theme updates) [19:47:44] dbrant: right, I'm thinking we should kill it. [19:48:02] YuviPanda: that's what I was lookin' for ;) [19:48:16] dbrant: yeah, ask dr0ptp4kt first tho [19:48:27] dbrant: dr0ptp4kt I'm personally ok with the Crouton that comes up when you move in and out of Zero [19:51:02] dr0ptp4kt: I'm implementing overall light/dark themes for the app, so changing the search bar to Black when entering Zero wouldn't make sense anymore... I'd rather not modify any colors for Zero, and just have the Crouton pop up. [19:52:43] dbrant: that's cool. if, alternatively, when it's white theme it can be black background (light text) and when it's night mode it's dark grey (still light text) and doesn't look funky, that would be swell. if not, cool. cc YuviPanda [19:55:47] (03CR) 10Yuvipanda: "Couple of things:" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/144492 (owner: 10BearND) [19:55:57] bearND: minor points, sorry, got lost in other things [20:05:11] Deskana: i’m back :) [20:06:47] YuviPanda: Thanks. re: your first comment about CreateAccount needing a source. That is a general comment and independent of my change, right? [20:07:13] bearND: no, it should be added here. The reason CreateAccount didn't have source before was that the only way you can get to it was from login [20:07:18] now that it is no longer the case, we should add one [20:08:39] YuviPanda: it still goes through the LoginActivity. I added a flag to LoginActivity to start the CreateAccountActivity [20:09:10] bearND: oh. hmm, that would indeed be necessary, since the login-after-create-account logic lives in loginactivity [20:09:19] bearND: but the source would still have to be changed, I think. [20:09:53] bearND: should be rolled up into this patch itself, I think. [20:10:12] bearND: so if createaccount is started from login through onboarding, it should pass as source 'onboarding', else 'login' [20:10:50] YuviPanda: ok, i'll make the change. Regarinding your second comment. I had checked that the events come through to stat1003, but with this new change I'll have to test that again, of course [20:10:56] bearND: yeah [20:13:25] (03CR) 10Yuvipanda: [C: 032] Break infinite loop of login and create account activities [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/144742 (owner: 10BearND) [20:13:48] YuviPanda: you there? [20:13:50] (03Merged) 10jenkins-bot: Break infinite loop of login and create account activities [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/144742 (owner: 10BearND) [20:13:56] vbamba1: hey! yup [20:14:38] Can we talk about night mode colors on hangout? [20:15:04] Who is focussing on front end stuff - you or dbrant and bearND ? [20:15:28] vbamba1: <<< [20:15:48] vbamba1: both me and dbrant for the nightmode stuff, but generally otherwise dbrant/bearND [20:16:37] vbamba1: sure, can do hangout. me or dbrant? (or both?) [20:17:27] YuviPanda: question about sources for CreateAccount? Shouldn't I just pass in the source from LoginActivity {edit, nav, onboarding}? [20:17:37] bearND: ah, yeah, that makes sense. [20:17:48] YuviPanda: ok, good [20:17:58] Everyone who wants to weigh in, should come to the meeting. I do't want things blowing up during estimation. [20:18:17] (in future) [20:18:37] 'blowing up'? [20:18:40] *shrug* [20:18:51] vbamba1: I guess just dbrant then. He's doing most of the UI color stuff now anyway. [20:20:40] vbamba1: dbrant do mail out the outcome of the meeting to mobile-l. [20:25:02] mhurd: Hey! Any comments on my above messages? [20:25:14] Deskana: checking... [20:26:12] Deskana: btw, the 'infinite loop between login and createaccount' has been fixed/merged [20:26:25] YuviPanda: Oh, sweet! [20:26:33] Deskana: also do comment on https://www.mediawiki.org/wiki/User:Yuvipanda/Android_app_release_cadence when you have the time :) [20:26:59] YuviPanda: You know that page is empty, right? :) [20:27:13] waitwat [20:27:43] Deskana: ya! so images gone is deliberate and at direction of moiz/vibha/jared - too many layout issues to be addressed related to images in toc for now. concerning performance, i’ve borrowed an old/slow device from brion for getting to the bottom of it - i’m pretty confident i can make it snappy, especially now that images are no longer in toc. will poke at it as i have time over the next few days [20:28:01] Deskana: https://www.mediawiki.org/wiki/User:Yuvipanda/Android_app_releases [20:28:53] mhurd: Okay, cool. I personally wasn't a massive fan of the images in the ToC, but I was fine supporting whatever decision they made. I was just checking that it was intentional! [20:29:02] Deskana: coolness :) [20:29:18] mhurd: And if you're aware of the slight slowdown on older devices and working on it then I think we're good for now. :) [20:30:59] YuviPanda: just noticed that the Schema is also missing another source value: blocked. We have that in our Java code but not in the schema [20:31:17] bearND: ah, right. can you add that as another patch? [20:31:35] YuviPanda: how about in the same patch? [20:31:42] bearND: sure, that's fine by me too. [20:31:46] ok [20:33:07] YuviPanda: do enum entries in schemas need to saty in the same order? [20:33:10] stay [20:33:12] bearND: nope [20:33:16] ok [20:34:25] Deskana: sounds good! [20:34:35] Deskana: btw, did your stat1003 account get setup? [20:45:46] dbrant: bearND I'm going to head off in another 15m. anything you guys want before that? [20:45:47] Deskana: ^ [20:45:55] nope! [20:47:02] YuviPanda: i should have an update patch for EL soon, fyi but that shouldn't keep you up [20:47:19] bearND: yeah, if I don't get to it before I sleep I'll get to it tomorrow before you guys wake up :) [20:49:30] yurikR2: you around? [20:49:41] kaldari, yep [20:51:00] yurikR2: I need to do some work related to Zero, but I forgot what headers to set to trigger zero mode [20:51:12] is there a page somewhere I can refer to? [20:51:16] kaldari, local or server? [20:51:20] for emulating it? [20:51:23] local [20:51:27] vagrant zero role? [20:51:43] YuviPanda: It did but I've not had the chance to use it yet. [20:51:53] I'm not using vagrant. I guess maybe that would be a good idea :) [20:52:01] YuviPanda: Remember that patch I submitted? I spent 45 minutes debugging why I was getting errors when I ran git review only to figure out my ssh config was fucked. [20:52:05] kaldari, basically - do you want to set up your own configs, or use them from betalabs? [20:52:29] from betalabs would probably be fine [20:52:47] YuviPanda: I was getting "permission denied, publickey" error, but considering I'd just changed my public key I figured the error was with that rather than the ssh config... [20:52:49] kaldari - local is easier because you don't have to deal with the login :) [20:52:57] yurikR2: basically, I just need to trigger the interstiatial when clicking on images. [20:52:57] Deskana: hah! yeah, ssh can be... fickle sometimes. and very prone to red herrings [20:53:15] kaldari, ok, set X-CS to the ID of a carrier [20:53:25] Deskana: I've spent about an hour once wondering why I can't ssh into a labs instance (it kept telling me public key denied), and it turned out the NFS server was down and hence the instance couldn't find my keys [20:53:32] kaldari, but you need to make sure that your zero role is enabled locally [20:53:37] if using zero role, its easier [20:53:40] (03PS2) 10BearND: Add EL to onboarding [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/144492 [20:53:50] bearND: want me to review? [20:54:09] YuviPanda: not yet [20:54:12] that was just a rebase [20:54:26] kaldari, create a local page called Zero:555-55 or something like that, and just use semi-default settings. [20:54:43] all this assuming you are using vagrant [20:54:48] ah ok [20:58:05] (03PS3) 10BearND: Add EL to onboarding [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/144492 [20:58:15] YuviPanda: I guess there's a cost for proper security, eh? :P [20:59:00] YuviPanda: that one should do it ^^ [21:00:27] Deskana: heh, yeah :) [21:00:44] Deskana: although I remember long ago someone was proposing we do away with ssh key auth and only do password auth (on labs) for ease of use... [21:00:50] (was shot down promptly, of course) [21:00:54] Good! [21:00:56] bearND: looking. tested? [21:01:41] YuviPanda: i checked that the source was included in create account event [21:02:10] YuviPanda: but you may want to test, too, just in case i missed something [21:02:52] (03PS1) 10Brion VIBBER: Footer style updates from Vibha [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/144811 [21:03:55] bearND: hmm, in that case I'll do that tomorrow, if that's ok? [21:04:05] YuviPanda: Anyway, I'm fine! Go sleep. :) [21:04:41] Deskana: no sleeping yet. Have some physio-y things that are supposed to be done before you sleep, but I guess the physio guy didn't expect that they'd be done at 3AM... [21:04:42] still [21:04:46] YuviPanda: sure. that's fine. [21:04:53] bearND: alright, ty [21:05:57] night [21:08:51] yurikR2: BTW, the default config has a bunch of JSON syntax errors in it [21:08:59] mostly missing commas [21:09:07] kaldari, did you get the latest? [21:09:13] the comments are meant to be deleted [21:09:27] kaldari, make sure you get the latest jsonconfig, zeroconfig, and zeroportal [21:09:46] yeah, I deleted the comments, but still a few syntax errors [21:11:33] not a big deal, but wanted to let you know in case you want to clean it up [21:15:27] yurikR2: also, neither the comments nor that documentation explain what whitelistedLangs is for, but it's apparently required. What is whitelistedLangs? Is it languages for cross-wiki language links that won't trigger warnings? Just a guess :) [21:15:46] kaldari, yep ;) [21:15:49] cool [21:15:56] kaldari, you can set it to [] [21:15:59] for all [21:16:19] but than you won't get any interstituals for other langs [21:16:26] only external links [21:16:36] that's fine. I'm only interested in images for now [21:18:47] looks like I need the ZeroBanner extension too [21:26:51] yurikR2: Hmm, not having much luck. If I don't have JsonConfig installed it complains that "Class 'JsonConfig\JCSingleton' not found", but if I do have it installed, it complains that "JsonConfig: Invalid $wgJsonConfigs['JsonZeroConfig']: Model 'JsonZeroConfig' is already registered in $wgContentHandlers to Extensions\ZeroRatedMobileAccess\ZeroConfigContentHandler" [21:27:11] kaldari, get vagrant ;) [21:27:15] you have old extension [21:27:17] get rid of it [21:27:22] ZRMA is obsolete [21:27:30] oh :) [21:27:30] get 3 exts [21:27:53] that's why i created zero role in vagrant - one command and its up :) [21:27:57] that would explain it :) [21:28:02] hehe :) [21:28:21] i wonder if i should delete everything in zrma ext so that ppl would get a crash if tehy try to include that file [21:45:11] kaldari, works? [21:47:10] (03PS1) 10Kaldari: WPI: Promoting MediaViewer to stable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/144833 [21:55:18] yurikR2: No luck so far. I set up the Zero Config page and configured my local instance, but I'm running to a problem with the JSONConfig settings... [21:56:16] In the readme it says that if I set 'islocal' to true, I don't have to set a remote 'url', but for some reason it's complaining about that anyway [21:56:52] should I just set 'url' to the local API url? [21:58:17] hmm, it seems to specifically want a ['remote']['url'] for some reason [21:59:14] it seems to still think that the config is not stored locally [22:09:28] yurikR2: Any idea about that? [22:09:37] too bad adam isn't here [22:09:46] where's he been the last few days? [22:09:52] kaldari, you shouldn't be required any settings at all [22:10:12] kaldari, just include all 3 in this order: jc, zb, zp [22:10:18] that's all [22:10:45] vagrant vagrant vagrant :) [22:11:59] although vagrant is broken for me atm :( [22:12:12] need to rebuild (takes about 10 min, but still!) [22:15:14] well, it's not giving me any errors now. [22:18:48] 3MobileFrontend / 3General/Unknown: After you save a page in Zero namespace, it shows the title as 'false' - 10https://bugzilla.wikimedia.org/67697 (10Ryan Kaldari) 3NEW p:3Unprio s:3normal a:3None After you save a page in Zero namespace, it shows the title as 'false'. Reloading the page fixes it. Se... [22:20:32] 3MobileFrontend / 3Feature requests: Add Donation link to main navigation - 10https://bugzilla.wikimedia.org/67626#c5 (10Florian) Maybe a good chance to use mediawiki-ui, too? :) [22:20:32] 3MobileFrontend / 3General/Unknown: After you save a page in Zero namespace, it shows the title as 'false' - 10https://bugzilla.wikimedia.org/67697#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/JSRPY0MC [22:24:32] 3MobileFrontend / 3Feature requests: Add Donation link to main navigation - 10https://bugzilla.wikimedia.org/67626#c6 (10Sherah Smith) (In reply to Florian from comment #5) > Maybe a good chance to use mediawiki-ui, too? :) part of the redesign :) [22:52:37] (03PS1) 10Kaldari: Hygiene: Removing a bunch of old icon CSS that is no longer needed [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/144844 [23:03:53] (03PS1) 10Brion VIBBER: Work in progress: pull to refresh UI on Saved Pages [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/144846 [23:14:28] (03PS5) 10Paladox: Update jquery from 1.7.2 to 1.11.1 [apps/win8/wikipedia] - 10https://gerrit.wikimedia.org/r/140939 [23:19:50] kaldari, success? [23:20:21] kaldari, next time i'm in town, i will show you how easy it is to work with vagrant ;) [23:20:31] until you like it :-P [23:20:35] (03PS1) 10Kaldari: Hygiene: Cleaning up pageaction icon CSS [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/144852 [23:21:08] (03PS6) 10Paladox: Updating certificate [apps/win8/wikipedia] - 10https://gerrit.wikimedia.org/r/141060 [23:21:23] yurikR2: No, I think I have everything set up right now including the browser headers, but I'm still not getting the banners for some reason :( [23:21:43] kaldari, can you paste your config somewhere? [23:21:49] sure... [23:21:57] and which headers you set [23:22:04] jgonera yt? [23:22:56] aaa, what's going on?!?? who "fixed" code editor extension to skip comments? [23:23:31] http://pastebin.com/d3UXPhd5 If you want the raw JSON, let me know [23:23:52] kaldari, raw pls [23:24:26] http://pastebin.com/PD1Dp5FM [23:24:27] kaldari, aha, proxies are not all set [23:24:33] add "DIRECT" [23:24:46] where did you get that config? [23:24:57] we might need to cleanup docs... [23:24:59] from the default suggestions [23:25:17] kaldari, are you sure you have everything up to date? [23:25:26] run vagrant git-update (updates all repos including extensions) [23:25:45] yes [23:28:02] kaldari, clearly a disconnect somewhere - this is what i see when i try to create a new page in zero: [23:28:02] http://pastebin.com/NzjLNEVQ [23:28:08] still no luck. Might be easier to have Adam look at it in person. Any idea when he's going to be back in the office? [23:28:40] it shouldn't be that hard, lets figure it out. something tells me you have the wrong version of one of the 3 extensions [23:28:51] if you want, share the screen with me. [23:28:52] hangout? [23:29:34] kaldari, calling... [23:30:57] yurikR2: Ah, I think ZeroRatedMF must ahve been interfering with it until I turned it off. Now when I go to create a new Zero page the default suggestions are different [23:31:09] of course :) [23:31:17] you were running on a month-old version ;) [23:31:45] i'm about to delete it [23:31:50] just to make sure it doesn't happen again [23:31:58] yurikR2: Here's what I get now: http://pastebin.com/gBYcJmAc [23:32:10] kaldari, much better [23:32:21] just enable it [23:32:26] and remove comments [23:32:58] awjr, yes [23:33:09] jgonera feeling any better? [23:33:20] awjr, yes, a bit [23:33:32] jgonera good :) i wanted to check in on this bug https://bugzilla.wikimedia.org/show_bug.cgi?id=67390 james mentioned you're working on it? [23:33:54] awjr, correct [23:34:15] yurikR2: I want BannerWarning to e true, right? [23:34:24] I was hoping to have a patch ready today and test it tomorrow on iPad in office, but my vagrant stopped working after VirtualBox update... [23:34:43] kaldari, nah, banner warning is for URLs in the banner [23:34:45] don't worry about it [23:34:57] jgonera no problem - i just wanted to dbl check it was on your radar :) [23:34:58] just set enabled:true (or delete it) [23:35:01] kaldari, ^ [23:39:03] (03PS1) 10Yurik: Deleting ALL code [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/144856 [23:39:05] yurikR2: If I set the ipset to "127.0.0.1/32" it complains, so I set it to "198.73.209.1/32" (the office IPs), does that sound right? [23:39:19] don't worry about it - its only for varnihs [23:39:24] ah [23:39:31] kaldari, told you - defaultts are good :) [23:39:57] yurikR2: It actually won't let me save it with that ipset [23:40:03] so I had to change it to something [23:40:10] hmm, ok, any random i guess :) [23:40:16] strange, need to review [23:40:55] tfinc: As discussed last week can we get a sprint 37 board as well? [23:41:02] tfinc: Planning further ahead, etc [23:41:06] Deskana: sure [23:41:14] kaldari, can you do me the honor pls? [23:41:15] https://gerrit.wikimedia.org/r/#/c/144856/ [23:41:40] Deskana: done [23:41:44] (03CR) 10jenkins-bot: [V: 04-1] Deleting ALL code [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/144856 (owner: 10Yurik) [23:42:06] oh my god, jenkins is against it! :D [23:42:21] MaxSem, ^ :) [23:43:01] but the honor should be kaldari 's :) [23:43:12] of +2ing [23:43:26] yurikR2: Looks like jenkins doesn't want to see it go :) [23:43:42] good thing it doesn't have a decisive vote :) [23:50:36] kaldari, zero success? [23:51:29] Nothing yet, but I'm mostly working on something else at the moment, so haven't had time to really troubleshoot it. [23:52:33] :( it should work out of the box [23:54:02] (03CR) 10MaxSem: [C: 032] Deleting ALL code [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/144856 (owner: 10Yurik) [23:54:23] thx MaxSem, RIP ZRMA [23:54:46] nah, I can't verify and submit [23:55:15] (03PS3) 10Yurik: Validate each admin value individually [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/144651 [23:55:18] you can just create an empty ZRMA.php and tests will pass [23:56:39] MaxSem, i want it removed from all tests too [23:56:50] no point to keep it around anywhere [23:57:08] otherwise it will be silently present in some god knows where place :) [23:57:44] yurikR2, you might want to leave a file called DELETED or something to let people browsing know why nothing's here [23:57:54] there is a readme [23:57:59] ah [23:58:15] should be enough, right :) [23:58:26] if not, "DELETED" won't help :) [23:58:31] (03CR) 10jenkins-bot: [V: 04-1] Deleting ALL code [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/144856 (owner: 10Yurik) [23:58:41] LOL [23:58:44] back from the grave [23:59:14] MaxSem, want to override it? or should i? [23:59:20] it just won't die! [23:59:56] I can't