[00:00:47] oh, bummer, they disabled it :(( [00:00:53] who is maintaining jenkins? [00:01:24] hashar and Krinkle [00:05:39] Submit a patch to zuul-config to disable a job from a pipeline. [00:06:18] Note though that this failure ins't from the absence of tests, but the absence of ZeroRatedMobileAccess.php. The convention to disabling an extension is leasving .php with a php comment. [00:06:26] <Krinkle> see also extensions/Vector/Vector.php [00:06:43] <Krinkle> To avoid breaking too badly with git modules etc. [00:07:02] <Krinkle> yurikR2: [00:07:25] <Krinkle> Keep ZeroRatedMobileAccess.php (empty with just <?php // Extension obsolete [00:07:31] <Krinkle> and presumably an OBSOLETE file with some info [00:07:34] <yurikR2> Krinkle, oki [00:07:47] <Krinkle> Ah, you have README, that's good too [00:08:02] <yurikR2> bleh, i wanted to cause as much trouble as possible as to force ppl to delete that repo from their machines [00:08:20] <Krinkle> yurikR2: You could throw an exception :) [00:08:44] <yurikR2> won't zuul barf? [00:08:53] <Krinkle> jenkins would [00:08:54] <Krinkle> yeah [00:09:07] <Krinkle> but then it'd be appropiate to disable the tests for it [00:09:27] <Krinkle> which is a one line patch I'd welcome in integration/zuul-config.git which I'd happily deploy in a few minutes [00:09:35] <Krinkle> Whichever you rpefer [00:10:43] <Krinkle> (either remove 'extension-unittests' and add 'extension-checks' for ZeroRatedMobileAccess, or add "mwext-Workflow-ZeroRatedMobileAccess-master: voting: false") [00:13:47] <grrrit-wm1> (03PS2) 10Yurik: Deleting ALL code [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/144856 [00:15:49] <grrrit-wm1> (03CR) 10MaxSem: [C: 032] Deleting ALL code [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/144856 (owner: 10Yurik) [00:16:02] <grrrit-wm1> (03Merged) 10jenkins-bot: Deleting ALL code [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/144856 (owner: 10Yurik) [00:20:12] <Carmela> Deskana: I like you better as Deskana than Dan Garry. [00:20:16] <Carmela> FWIW. [00:20:24] <Carmela> Or Deskbanana. [00:20:27] <Carmela> Or Cassie! [00:23:47] <jgonera> kaldari, is the TOC icon visible for you on master? I just recreated my vagrant virtualbox and it isn't... [00:34:08] <Deskana> Carmela: Then I'll stick to this! [00:34:43] <Carmela> I meant I like Deskabana and Cassie better than D. Garry. I think I was ambiguous. [00:34:49] <Carmela> But in any case, all right! [00:55:35] <wikibugs> 3Wikipedia App / 3Android App: Common crash - 10https://bugzilla.wikimedia.org/67718 (10Alex Monk) 3NEW p:3Unprio s:3normal a:3None java.lang.RuntimeException: Unable to start activity ComponentInfo{org.wikipedia/org.wikipedia.page.PageActivity}: java.lang.RuntimeException: Could not dispatch event:... [00:56:17] <wikibugs> 3Wikipedia App / 3Android App: Common crash - 10https://bugzilla.wikimedia.org/67718 (10Alex Monk) p:5Unprio>3High [01:10:46] <wikibugs> 3MobileFrontend / 3General/Unknown: Mobile is somehow sending API requests that ask for text/html content - 10https://bugzilla.wikimedia.org/67426#c3 (10Oliver Keyes) Adding Ezachte; Erik, MaxSem asked about which header we're taking the MIME type found in the sampled logs from. Any chance you know? [02:29:29] <grrrit-wm1> (03CR) 10JGonera: [C: 032] Changing TOC icon to be SVG instead of PNG [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/143661 (owner: 10Kaldari) [02:30:12] <grrrit-wm1> (03Merged) 10jenkins-bot: Changing TOC icon to be SVG instead of PNG [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/143661 (owner: 10Kaldari) [02:41:51] <grrrit-wm1> (03PS1) 10Yurik: Fixed path to the same-dir blank.gif file [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/144869 [02:42:23] <grrrit-wm1> (03CR) 10Yurik: [C: 032] "very minor fix, needed before depl tmrw" [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/144869 (owner: 10Yurik) [02:42:32] <grrrit-wm1> (03Merged) 10jenkins-bot: Fixed path to the same-dir blank.gif file [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/144869 (owner: 10Yurik) [02:47:16] <grrrit-wm1> (03CR) 10JGonera: [C: 04-1] "Doesn't seem to work. Tested by modifying ve.ui.MobileContext.js in the following ways:" (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/143797 (https://bugzilla.wikimedia.org/66678) (owner: 10Kaldari) [02:53:21] <grrrit-wm1> (03CR) 10JGonera: [C: 04-1] "For some reason this makes the log out icon (in main nav, next to profile link) smaller." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/144844 (owner: 10Kaldari) [02:54:58] <grrrit-wm1> (03CR) 10JGonera: [C: 04-1] "Minor inline thing." (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/143684 (owner: 10Kaldari) [03:54:50] <grrrit-wm1> (03PS1) 10Yurik: Convert to array-notation shell call [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/144872 [03:55:05] <grrrit-wm1> (03CR) 10Yurik: [C: 04-2] Convert to array-notation shell call [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/144872 (owner: 10Yurik) [04:43:41] <grrrit-wm1> (03PS1) 10Yurik: Better error handling calling imagemagick [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/144875 [05:13:05] <grrrit-wm1> (03CR) 10Yurik: [C: 032] "seilf-+2ing and emailing adam for post review. Testing more on beta." [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/144875 (owner: 10Yurik) [05:13:15] <grrrit-wm1> (03Merged) 10jenkins-bot: Better error handling calling imagemagick [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/144875 (owner: 10Yurik) [05:21:09] <grrrit-wm1> (03PS4) 10Yurik: Validate each admin value individually [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/144651 [07:50:20] <wikibugs> 3MobileFrontend / 3stable: Text does not appear in the place of icons when images are disabled - 10https://bugzilla.wikimedia.org/67726 (10Pine) 3NEW p:3Unprio s:3major a:3None Steps to reproduce the problem Start the Android browser Disable images Clear cache Navigate to https://en.wikipedia.org Ty... [07:50:31] <wikibugs> 3MobileFrontend / 3stable: Text does not appear in the place of icons when images are disabled - 10https://bugzilla.wikimedia.org/67726#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/iWReoFnb [08:14:02] <wikibugs> 3MobileFrontend / 3stable: Text does not appear in the place of icons when images are disabled - 10https://bugzilla.wikimedia.org/67726#c2 (10Florian) s:5major>3enhanc Confirmed on Chrome desktop. It's an enhancement in my view, there is no code for now to support non-image-loading setting if i'm right.... [09:33:32] <wikibugs> 3Wikipedia App / 3Android App: i18n translations strings for 'yes' and 'no' are used in multiple questions - 10https://bugzilla.wikimedia.org/67628 (10Nemo) [09:36:01] <wikibugs> 3Wikipedia App / 3Android App: i18n translations strings for 'yes' and 'no' are used in multiple questions - 10https://bugzilla.wikimedia.org/67628#c4 (10Nemo) (In reply to Andre Klapper from comment #3) > Ok, but I expected that link to provide an explanation for the "htmlform-yes > and htmlform-no preceden... [11:55:15] <grrrit-wm1> (03PS10) 10Dbrant: Implement night mode for content [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/142512 (https://bugzilla.wikimedia.org/35251) (owner: 10Yuvipanda) [11:56:16] <grrrit-wm1> (03CR) 10Dbrant: [C: 032] "Merging, with the understanding that this is an intermediate step towards a full night-mode throughout the app (in a later commit)." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/142512 (https://bugzilla.wikimedia.org/35251) (owner: 10Yuvipanda) [11:58:17] <grrrit-wm1> (03Merged) 10jenkins-bot: Implement night mode for content [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/142512 (https://bugzilla.wikimedia.org/35251) (owner: 10Yuvipanda) [12:01:08] * YuviPanda waves at dbrant [12:01:11] <YuviPanda> thanks for the merge! [12:01:26] <YuviPanda> dbrant: I also put you up for a couple of design meetings today, hope they aren't clashing with anything else [12:02:10] <dbrant> sure! no conflicts for meetings [12:02:45] <YuviPanda> dbrant: alright, ty. Do email out to mobile-l about outcomes [12:03:26] <dbrant> YuviPanda: totally! [12:03:31] <YuviPanda> dbrant: thanks :) [12:07:30] <grrrit-wm1> (03PS3) 10Dbrant: Remove dead code from previous saved pages implementation [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/144481 (owner: 10Yuvipanda) [12:07:39] <grrrit-wm1> (03CR) 10Dbrant: [C: 032] Remove dead code from previous saved pages implementation [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/144481 (owner: 10Yuvipanda) [12:08:50] <YuviPanda> dbrant: you can test the redlinks code on [[Barburrito]] article on enwiki [12:08:52] <grrrit-wm1> (03Merged) 10jenkins-bot: Remove dead code from previous saved pages implementation [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/144481 (owner: 10Yuvipanda) [12:09:10] <YuviPanda> before and after, the names of the founders should change from redlinks to normal text [12:09:22] <dbrant> YuviPanda: processing.. [12:10:05] <grrrit-wm1> (03PS2) 10Dbrant: Don't show Red Links [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/144486 (owner: 10Yuvipanda) [12:11:31] <grrrit-wm1> (03CR) 10Dbrant: [C: 032] Don't show Red Links [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/144486 (owner: 10Yuvipanda) [12:15:18] <wikibugs> 3MobileFrontend / 3General/Unknown: Mobile is somehow sending API requests that ask for text/html content - 10https://bugzilla.wikimedia.org/67426#c4 (10Erik Zachte) Sorry, no idea, I take the mime types in the log at face value. They might be from a footer instead of a header. Christian might know better? [12:53:10] <YuviPanda> dbrant: btw, nice (and short) talk about WMF's Architecture https://www.youtube.com/watch?v=646mJu5f2cQ [12:53:16] <YuviPanda> rather backendy, however [12:54:18] <dbrant> i watched it! (i read the email chain) [12:54:36] <YuviPanda> dbrant: coool! :) I found a bunch of brochures, but have lost the links. I'll ask ragesoss_ again [13:12:36] <ragesoss_> YuviPanda, dbrant: https://outreach.wikimedia.org/wiki/Education/Brochures [13:12:42] <YuviPanda> dbrant: ^ [13:12:48] <YuviPanda> ragesoss_: ty [13:12:58] <dbrant> ragesoss_: YuviPanda: very nice! [13:13:13] <YuviPanda> dbrant: ragesoss_ is also a long time wikipedian I've learnt a lot from :) [14:53:56] <grrrit-wm1> (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/144846 (owner: 10Brion VIBBER) [15:03:36] <grrrit-wm1> (03PS1) 10Dbrant: [WIP] Implement Theme/Font chooser. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/144987 [15:03:50] <dbrant> yuvipanda: ^ boom. [15:04:00] <yuvipanda> dbrant: woot [15:09:45] <yuvipanda> dbrant: finishing up the EL patch for onboarding now (CR), I'll take a look right after [15:09:52] <grrrit-wm1> (03PS4) 10Yuvipanda: Add EL to onboarding [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/144492 (owner: 10BearND) [15:10:05] <dbrant> yuvipanda: sure; it's by no means complete yet. [15:13:21] <aharoni> WAT!!! [15:13:27] * aharoni is furious [15:13:53] <yuvipanda> aharoni: what happened now? [15:14:28] <aharoni> 10% https://en.wikipedia.org/wiki/Buyer%27s_remorse , 90% fury about consistently horrible product management behind all vendors of Android phones I ever encountered. [15:14:37] <aharoni> Got a new Galaxy S5 today. [15:14:47] <aharoni> it's great and all, but the languages that came with it are: [15:15:10] <yuvipanda> yup, you should stay away from all non-Google Play devices. [15:15:19] <yuvipanda> which, of course, are restricted to fewer countries [15:15:28] <aharoni> Hebrew, English UK, English US, Spanish, French, Russian, Arabic, and another one [15:15:33] <aharoni> care to guess which one? [15:15:42] <yuvipanda> German? [15:15:45] <aharoni> oh no [15:15:46] <yuvipanda> Hindi? [15:15:49] <aharoni> it's Samsung [15:15:52] <yuvipanda> lol [15:15:52] <aharoni> Korean, of course. [15:15:53] <yuvipanda> wat [15:15:55] <yuvipanda> aaah [15:15:56] <yuvipanda> right [15:16:04] <yuvipanda> I thought they had a language named Samsung [15:16:23] <aharoni> I don't have anything against this language or any other, but how on Earth is it relevant? !@#$%^&*( [15:16:40] <aharoni> And how do I add more? [15:17:05] <yuvipanda> you've to flash your device with CyanogenMod or somesuch [15:17:07] <yuvipanda> no other way [15:17:12] <aharoni> :) [15:17:15] <aharoni> I might just do that. [15:17:25] <yuvipanda> Nexus phones ftw? [15:18:01] <aharoni> weren't available, but what's the big difference? [15:18:35] <yuvipanda> aharoni: they ship all the available languages [15:18:39] <aharoni> ok [15:18:51] <aharoni> this one does have a lot of keyboards, however, which is great [15:19:11] <aharoni> of course, somebody FAILED to remove them, [15:19:45] <aharoni> because somebody was told to remove all the languages except the ones relevant for Israel + The One And Only Korean, [15:19:54] <aharoni> but didn't notice that keyboards are separate. [15:20:02] <aharoni> of course, I'm happy about such mistakes :) [15:20:09] <aharoni> There's even Malayalam! [15:21:25] <grrrit-wm1> (03CR) 10Yuvipanda: [C: 04-1] "Works as advertised, but one problem (that I failed to catch earlier) - there's no easy way to count login attempts from onboarding now, s" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/144492 (owner: 10BearND) [15:21:33] <yuvipanda> bearND: ^ sorry I didn't catch that earlier [15:21:34] <grrrit-wm1> (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/144987 (owner: 10Dbrant) [15:22:09] <Krenair> yuvipanda, I guess I can start telling people that there is a night mode feature coming in the next release? [15:22:22] <aharoni> yuvipanda: now, more importantly, https://bugzilla.wikimedia.org/show_bug.cgi?id=67190 is still relevant [15:22:23] <Krenair> (I just tested it out on my device) [15:22:27] <aharoni> is there a new version on the way? [15:22:30] <yuvipanda> Krenair: yes! Tell them it'll hit the next beta due out in a week. [15:23:12] <yuvipanda> aharoni: yes, https://www.mediawiki.org/wiki/User:Yuvipanda/Android_app_releases [15:23:14] <yuvipanda> Krenair: ^ release plans [15:23:29] <yuvipanda> Krenair: not finalized yet, but should be by next monday. [15:24:22] <Krenair> yuvipanda, cool. will note that link in the etherpad [15:24:31] <Krenair> yuvipanda, does that fix the bug? [15:24:31] <bearND> yuvipanda: Any suggestions what to do about counting login attempts? [15:24:48] <yuvipanda> bearND: I left two suggestions in the comment [15:24:55] <yuvipanda> Krenair: the night mode bug? no, there are two more patches to be merged. [15:24:55] <bearND> yuvipanda: oh, ok [15:25:01] <Krenair> ah ok [15:25:11] <yuvipanda> Krenair: but the biggest part is in place [15:25:34] <Krenair> Also, sigh, the queue is out of control :( [15:26:13] <Krenair> 333 now. [15:26:38] <yuvipanda> dbrant|brb: bearND we should foramlize some 'OTRS time' as part of the sprint, every sprint, I think [15:27:00] <Krenair> 212 of which are in crash reports [15:27:17] <Krenair> A lot of those are dupes of each other, obviously. [15:27:31] <yuvipanda> Krenair: right. I think we should treat Crash reports as 'readonly'. I should perhaps write something that uses the OTRS API and dedupes them into a report [15:27:40] <Krenair> possibly [15:27:47] <yuvipanda> Krenair: I think the non-crash queue is the one we should worry about? [15:28:21] <Krenair> Well we should keep an eye on crash reports still, but yeah [15:28:41] <grrrit-wm1> (03CR) 10Siebrand: During edit save, describe IP edit and offer login if appropriate. (031 comment) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/143156 (owner: 10Dr0ptp4kt) [15:29:19] <Krenair> I made https://bugzilla.wikimedia.org/show_bug.cgi?id=67718 for one of the recurring things [15:29:53] <yuvipanda> yeah, I'll take a look at those later today [15:31:31] <wikibugs> 3Wikipedia App / 3Android App: Wikipedia Android App 2.0 doesn't show Hebrew localization - 10https://bugzilla.wikimedia.org/67190#c1 (10Yuvi Panda) Can you try the 2.0 apk from http://releases.wikimedia.org/mobile/android/wikipedia/stable/ and see if this issue exists there? [15:31:43] <Krenair> Actually it looks like dbrant already tried fixing that one... https://gerrit.wikimedia.org/r/#/c/143310/ [15:32:21] <yuvipanda> yeah, the find in page one was fixed, I think. [15:32:59] <grrrit-wm1> (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed." (032 comments) [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/144175 (owner: 10Yurik) [15:33:02] <wikibugs> 3Wikipedia App / 3Android App: Common crash - 10https://bugzilla.wikimedia.org/67718#c1 (10Alex Monk) Looks like Dmitry tried to solve part of this in Gerrit change 143310 actually [15:33:58] <Krenair> probably not the ones originating in PageTitle.isSpecial though [15:34:25] <yuvipanda> right. that one's a little weird. I'm looking at it now [15:35:00] <yuvipanda> aha, I think I know what's happening [15:35:03] <yuvipanda> Krenair: fix coming up soon [15:35:08] <Krenair> Brilliant [15:36:04] <aharoni> yuvipanda: 2.0.apk or 2.0-2014-06-25 ? [15:36:06] <yuvipanda> hmm, actuall no, I don't [15:36:09] <yuvipanda> aharoni: 2.0.apk [15:37:57] <aharoni> yuvipanda: that one works [15:38:26] <yuvipanda> aharoni: ah, right. so it is a build issue, apparently symlinks from he -> iw wasn't working in whoever who did the build [15:38:35] <yuvipanda> aharoni: next release should fix it [15:38:49] <aharoni> second day of sprint? when is that? [15:39:09] <yuvipanda> aharoni: that's about... 2 weeks away [15:39:37] <yuvipanda> aharoni: Deskana can override and we can make an emergency release, of course. Not too hard. [15:54:02] <wikibugs> 3Wikipedia App / 3Android App: Common crash - 10https://bugzilla.wikimedia.org/67718#c2 (10Dmitry Brant) That's correct. The patch just hasn't made it to public release yet. [16:03:21] <aharoni> yuvipanda: can you please remember to test it before release? :) [16:04:47] <grrrit-wm1> (03PS5) 10Yurik: Validate each admin value individually [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/144651 [16:08:02] <wikibugs> 3Wikipedia App / 3Generic: App stops responding after being used for a while - 10https://bugzilla.wikimedia.org/64450#c7 (10Alex Monk) Is this bug 66732 ? This ticket has the same stack trace as the issue marked as for bug 66732 on the etherpad [16:08:18] <wikibugs> 3Wikipedia App / 3Android App: App occasionally closes when too much Activity state is stored. - 10https://bugzilla.wikimedia.org/66732 (10Alex Monk) [16:08:20] <wikibugs> 3Wikipedia App / 3Generic: App stops responding after being used for a while - 10https://bugzilla.wikimedia.org/64450 (10Alex Monk) [16:18:24] <liangent> what's the content of https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom;TicketID=7592860 ? [16:18:48] <liangent> Krenair: and where's "the etherpad"? [16:19:55] <Krenair> liangent, https://etherpad.wikimedia.org/mobile-app-otrs [16:20:07] <Krenair> liangent, sorry, that's the only etherpad I'm dealing with at the moment :) [16:24:49] <liangent> Krenair: I guess "java.lang.RuntimeException: Adding window failed " is mislabeled as 66732; it is 64450 [16:25:05] <liangent> and a sample stack trace for 66732 is in https://bugzilla.wikimedia.org/show_bug.cgi?id=66872#c1 [16:28:03] <liangent> and it appears.. samsung is causing too many troubles? [16:29:02] <grrrit-wm1> (03PS2) 10Yurik: Show ZERO info screen on banner click [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/144175 [16:30:04] <grrrit-wm1> (03PS5) 10BearND: Add EL to onboarding [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/144492 [16:30:06] <Krenair> liangent, you just saw my addition of those 24 mostly-samsung android.app.ActivityThread.handleStopActivity exceptions? [16:30:38] <bearND> yuvipanda: ^^ updated patch [16:31:06] <liangent> Krenair: yeah plus I remember 'samsung' has been mentioned too many times in this channel (incl. wikibugs, grrrit-wm etc) [16:35:28] <yuvipanda> bearND: looking [16:41:17] <grrrit-wm1> (03PS1) 10Yurik: Incorrect static var access fix, moved PageRendering to its own class [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/145011 [16:41:39] <yurikR> dr0ptp4kt, ^ [16:43:35] <yurikR> dr0ptp4kt, need that one before deploy - not sure how i missed it before [16:43:47] <dr0ptp4kt> yurikR: k [16:44:11] <yurikR> dr0ptp4kt, you might want to copy it into a diffing program (meld?) to see the diff [16:44:18] <yurikR> git doesn't want to show it [16:44:47] <wikibugs> 3Wikipedia App / 3Android App: Common crash - 10https://bugzilla.wikimedia.org/67718#c3 (10Alex Monk) Yuvi, https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom;TicketID=7635103 contains a comment which looks useful for solving the issue with PageTitle.isSpecial [16:45:02] <dr0ptp4kt> yurikR: right [16:45:09] <yurikR> dr0ptp4kt, http://stackoverflow.com/questions/8131135/git-how-to-diff-two-different-files-in-different-branches [16:46:04] <dr0ptp4kt> yurikR: right [16:46:28] <yurikR> dr0ptp4kt, git diff HEAD^:includes/PageRenderingHooks.php..HEAD:includes/PageRendering.php [16:46:30] <yurikR> :D [16:46:36] <dr0ptp4kt> yurikR: :) [16:53:51] <dr0ptp4kt> yuvipanda: to keep the patch moving, would you be able to reply to the question in https://gerrit.wikimedia.org/r/#/c/143156/ - "@YuviPanda, using the English strings, which part were you thinking for full underlining?" ? wasn't sure if dan g was able to reply yesterday on irc, as i may have lost my connection to irc after having requested his feedback on my questions in that patch [16:54:02] <wikibugs> 3Wikipedia App / 3Android App: Common crash - 10https://bugzilla.wikimedia.org/67718#c4 (10Alex Monk) Am wondering if any of the following fit in this bug as well: https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom;TicketID=7622139 https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZ... [16:54:10] <yuvipanda> dr0ptp4kt: I'll take a look after the standup [16:54:25] <dr0ptp4kt> yuvipanda: cool [16:54:43] <yuvipanda> Krenair: yeah, that OTRS link for isSpecial was useful! [16:54:50] <Krenair> yay :) [16:55:13] <Krenair> I added a few more that sounded related. probably a different fix, but due to my slightly wrong bug filing, they might still fit there [16:55:26] <yuvipanda> right, I'll check those up in a bit as well [16:57:35] <wikibugs> 3Wikipedia App / 3Android App: NullPointerException from android.app.ActivityThread.handleStopActivity? - 10https://bugzilla.wikimedia.org/67736 (10Alex Monk) 3NEW p:3Unprio s:3normal a:3None A lot of these coming from usually-Samsung devices (I think) A few from the bigger list in https://etherpad.w... [17:01:22] <awjr> Maryana MaxSem standup? [17:02:17] <grrrit-wm1> (03CR) 10Dr0ptp4kt: [C: 032] "Works for me." [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/145011 (owner: 10Yurik) [17:02:26] <dr0ptp4kt> ^ yurikR worked on localhost [17:02:37] <yurikR> dr0ptp4kt, thx ! [17:03:17] <yurikR> btw, dr0ptp4kt, i found out the issue with debugging - they switched default to hhvm, which broked debugging :( need to enable "zend" [17:03:23] <dr0ptp4kt> yurikR: there aren't any config re-save actions required once code is deployed where it would put all the configs into the new format immediately, right? [17:03:25] <yurikR> (enable-role zend) [17:03:27] <dr0ptp4kt> yurikR: yeahs, saw that [17:03:57] <dr0ptp4kt> yurikR: we will need to figure out a better way to debug that can ride on hhvm at some point. the code is standardized enough that i don't think it should matter, but still... [17:04:02] <yurikR> dr0ptp4kt, correct - dynamic patching ) [17:04:31] <yurikR> yeah, as i wrote in my email - we need to be able to easily switch back/forth [17:05:49] <yurikR> dr0ptp4kt, btw, i just realized that we were idiotic to futs around with api calls in js [17:06:14] <yurikR> we could have simply included window.mw.zeroConfig = {...}; next to the banner [17:06:52] <yurikR> muuuch easier :) [17:07:18] <dr0ptp4kt> yurikR: yeah, dunno if being in the same namespace is the place we really want the code to be (there's some magic sometimes), but that can be reviewed in the future [17:08:15] <dr0ptp4kt> (problem being if rl stuff is loaded in a deferred fashion too late) [17:08:16] <yurikR> dr0ptp4kt, even if it was a separate var - till, i shouldn't have bothered spending all that time making it dynamic only when needed code :( [17:08:25] <yurikR> rl? [17:08:36] <dr0ptp4kt> yurikR: Resourceloader. [17:08:55] <yurikR> this wouldn't be RL [17:10:30] <yurikR> oh, the window.mw is set very early in html [17:15:31] <grrrit-wm1> (03Merged) 10jenkins-bot: Incorrect static var access fix, moved PageRendering to its own class [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/145011 (owner: 10Yurik) [17:15:52] <grrrit-wm1> (03CR) 10Yuvipanda: [C: 032] Add EL to onboarding [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/144492 (owner: 10BearND) [17:19:07] <grrrit-wm1> (03Merged) 10jenkins-bot: Add EL to onboarding [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/144492 (owner: 10BearND) [17:21:47] <wikibugs> 3Wikipedia App / 3Android App: NullPointerException from android.app.ActivityThread.handleStopActivity? - 10https://bugzilla.wikimedia.org/67736#c1 (10Dmitry Brant) This has to do with Android 2.3.x, although it may also be correlated with Samsung devices. My guess is that it also has to do with our memory... [17:23:25] <dr0ptp4kt> yurikR: i think i understand what you're saying, although it's fine as is from what i see [17:25:12] <yurikR> dr0ptp4kt, we could also start using onMakeGlobalVariablesScript [17:25:36] <yurikR> but again, that would only work if X-CS is not ON [17:25:48] <yurikR> which we are obsoleting soon [17:26:02] <yurikR> so might not be worth changing [17:26:25] <dr0ptp4kt> yurikR: would need to look at that. that has some gotchas as i recall, but i remember also us discussing that there would be a time we'd be able to get around the gotchas. lol [17:30:45] <yuvipanda> bearND: congrats on your first end to end EL patch! :) [17:31:19] <wikibugs> 3Wikipedia App / 3iOS App: iOS App: Last modified pencil icon is the same as edit pencil - 10https://bugzilla.wikimedia.org/67647#c1 (10Dan Garry) 5NEW>3RESO/WON This is a conscious design decision. The context the icon is in should make it clear that it's not an edit button. [17:32:40] <awjr> jgonera sos? [17:33:18] <bearND> yuvipanda: thanks for you guidance :) [17:33:23] <bearND> your [17:33:25] <yuvipanda> bearND: :D PM for a min? [17:33:30] <bearND> sure [17:33:31] <jgonera> awjr, sorry, I was lost in the browser tests land [17:33:40] <awjr> no problem jgonera :) [17:41:01] <wikibugs> 3MobileFrontend / 3stable: Text does not appear in the place of icons when images are disabled - 10https://bugzilla.wikimedia.org/67726#c3 (10Ryan Kaldari) The better way to disable images on mobile is to go into your settings and turn "Images" off. This will hide all article images, but still show user inte... [17:48:33] <yuvipanda> bearND: btw, if the draft android release plan becomes final as is, we'd have to have CI builds. since I remember you were entusiastic about that, want to lead that when it happens? [17:48:39] <dr0ptp4kt> jgonera: is kaldari around? [17:48:55] <jgonera> dr0ptp4kt, he's in the office [17:49:10] <jgonera> Maryana, tell Kaldari to get on IRC if he's around [17:50:20] <wikibugs> 3MobileFrontend / 3stable: Text does not appear in the place of icons when images are disabled - 10https://bugzilla.wikimedia.org/67726#c4 (10Ryan Kaldari) We should, however, at least have title attributes on everything. [17:50:34] <Maryana> done :) [17:52:22] <dr0ptp4kt> jgonera, Maryana: thx [17:52:23] <jgonera> dr0ptp4kt, ^ [17:52:25] <yuvipanda> dbrant: can you link bearND to the outreachwiki link with the brochures? [17:52:35] <dr0ptp4kt> kaldari, was just looking at mediaViewer/init.js and i was thinking that if in there the code would check wgImagesDisabled and not attach the listener (that is, just follow the href), that should do the trick. if the user is on zerodot (textonly), wgImagesDisabled is activated to true (i.e., don't show images) via the following in the ZeroBanner extension: $out->addJsConfigVars( array( 'wgImagesDisabled' => true ) ); [17:52:55] <dr0ptp4kt> kaldari: that said, still happy to help you with setting up the configuration for testing [17:53:17] <wikibugs> 3MobileFrontend / 3stable: Text does not appear in the place of icons when images are disabled - 10https://bugzilla.wikimedia.org/67726#c5 (10Ryan Kaldari) It looks like two of the page actions, 'add image' and 'add to watchlist', don't have any text at all (and thus aren't accessible). [17:53:51] <kaldari> dr0ptp4kt: That sounds like a clever solution [17:54:42] <dr0ptp4kt> kaldari: knowing you, i wouldn't be surprised if you have that already. /me heads to gerrit [17:55:40] <kaldari> dr0ptp4kt: I would still like to get zero working locally to test it [17:56:08] <kaldari> dr0ptp4kt: Just let me know when you're available later [17:56:17] <dr0ptp4kt> kaldari: you using vagrant? [17:56:54] <kaldari> dr0ptp4kt: no, I was going to set it up, but several people have told me it's borked right now, so I'm not sure it would be a good time to try [17:57:28] * yuvipanda goes off to get some food now, brb [17:59:17] <YuviPanda|food> dbrant: btw, Deskana's leading an editathon later today, highly reccomended :) [17:59:37] * YuviPanda|food really goes afk [18:00:22] <wikibugs> 3MobileFrontend / 3stable: Full text search results missing - 10https://bugzilla.wikimedia.org/67740 (10Juliusz Gonera) 3NEW p:3Unprio s:3normal a:3None If you search in pages content (using button or by pressing Enter), the search results page won't show results due to changes in markup and ours CSS... [18:00:48] <wikibugs> 3MobileFrontend / 3stable: Full text search results missing - 10https://bugzilla.wikimedia.org/67740#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/HDmKHKry [18:01:38] <Maryana> jgonera: kaldari -- just made this card: https://trello.com/c/MuE5Ysov/68-spike-decide-whether-ajax-page-loading-needs-to-be-kept-for-editing-workflow -- fill in the details when you get a chance? [18:02:00] <kaldari> thanks [18:02:49] <dr0ptp4kt> kaldari: even if you aren't using vagrant, one way to reverse engineer the settings is to get the mediawiki-vagrant repo, then cd down into puppet/manifests/roles, then look at zero.pp. you'll note that it does include directives on several other vagrant roles, so examination of those other roles in the same roles dir to get the appropriate settings should get it to roughly the right place. once you've done that, the next thing you'll wa [18:02:50] <dr0ptp4kt> to do is unset your X-CS header, set the X-Subdomain header to ZERO, and for good meausre, set your User-Agent to android mobile. when you do that, if you try to go to Main Page on your local host it will redirect you to an error page (on en.zero.wikipedia.org) saying that it isn't supported. that would demonstrate that the extension is setup properly. [18:04:11] <dr0ptp4kt> kaldari: also, i'm running mediawiki-vagrant at 155c3c6a2050047f6e0e0b923874792f90190a29 and it's working for me. but i am running vagrant at 1.5.4 and virtualbox at 4.3.12 r93733 [18:04:47] <dr0ptp4kt> kaldari: i started *completely* fresh following the instructions at https://m.mediawiki.org/wiki/Vagrant last time to get it to work last week or so [18:06:09] <kaldari> dr0ptp4kt: I was setting the X-Subdomain header to 'M'. What does that header do? [18:06:11] <dr0ptp4kt> kaldari: that will probably take a while to download and run the provisioners, to be sure, and as recent changes to that repo shake out i'm guessing it may become necessary to blow away everything and start fresh again. but hey, it's infrastructure as code, so that's half the fun [18:06:18] <wikibugs> 3MobileFrontend / 3General/Unknown: Allow end users to view images compressed to decrease page load times - 10https://bugzilla.wikimedia.org/66819 (10Jared Zimmerman (WMF)) [18:07:11] <dr0ptp4kt> kaldari: X-Subdomain is added on by Varnish to indicate whether it is an m.wikipedia.org domain ("M") or zero.wikipedia.org ("ZERO"). we call them mdot and zerodot to try to keep them straight [18:07:52] <dbrant> bearND|food: https://outreach.wikimedia.org/wiki/Education/Brochures [18:08:00] <kaldari> ok, I'll change that to ZERO then [18:08:31] <dr0ptp4kt> kaldari: so when it's set to ZERO and ZeroBanner picks up that header, it says to itself, hey, i'm not supposed to be showing images. [18:08:33] <dr0ptp4kt> kaldari: cool [18:11:48] <wikibugs> 3MobileFrontend / 3General/Unknown: Allow end users to view images compressed to decrease page load times - 10https://bugzilla.wikimedia.org/66819 (10Jared Zimmerman (WMF)) [18:12:43] <dr0ptp4kt> vagrant enable-role more-C8H10N4O2 [18:14:47] <wikibugs> 3MobileFrontend / 3Feature requests: MobileFrontend contradicts established expectations for watchlist UI - 10https://bugzilla.wikimedia.org/67526#c8 (10Maryana Pinchuk) What you describe is expected behavior for power users of Wikipedia who have been editing for a number of years; that's not the bulk of the... [18:16:17] <wikibugs> 3MobileFrontend / 3stable: Full text search results missing - 10https://bugzilla.wikimedia.org/67740#c2 (10Florian) Confirmed on my private wiki :/ (http://www.droidwiki.de/index.php?search=Root&fulltext=search) I think it's a new version of cirrussearch (both, beta labs and en uses cirrussearch for elastic... [18:20:19] <wikibugs> 3MobileFrontend / 3Feature requests: MobileFrontend contradicts established expectations for watchlist UI - 10https://bugzilla.wikimedia.org/67526#c9 (10Maryana Pinchuk) 5NEW>3RESO/WON ^ that's specifically RE this: "Expected behaviour: *Design/UI paradigms are consistent between the mobile site and the... [18:21:37] <dr0ptp4kt> Deskana: what are your thoughts on https://gerrit.wikimedia.org/r/#/c/143156/ (see Comments section) ? cc YuviPanda|food for his return. [18:22:47] <wikibugs> 3MobileFrontend / 3Feature requests: Add Donation link to main navigation - 10https://bugzilla.wikimedia.org/67626#c7 (10Maryana Pinchuk) Yeah, definitely let us know when the donate landing page gets a mobile facelift! Sending mobile users to it now seems a little cruel and unusual.. [18:23:47] <wikibugs> 3MobileFrontend / 3stable: Full text search results missing - 10https://bugzilla.wikimedia.org/67740#c3 (10Florian) Caused by (reverted: worked, now publish on my private, so no longer an example :P): https://gerrit.wikimedia.org/r/#/c/143548/1 (moving to SpecialPage?) [18:24:32] <wikibugs> 3MobileFrontend / 3Feature requests: Difficult or impossible to copy and paste file link from commons "use this image" - 10https://bugzilla.wikimedia.org/67618#c3 (10Maryana Pinchuk) I'm pretty sure we don't expose that feature anywhere on the mobile site -- are you looking at the desktop site on a mobile de... [18:30:11] <awjr> kaldari see max around? [18:30:34] <kaldari> he's here [18:30:46] <awjr> oh i see he's on as OuKB [18:30:50] <awjr> thanks :) [18:31:12] <grrrit-wm1> (03CR) 10Kaldari: [C: 032] Add continue message to KeepGoing [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/144719 (https://bugzilla.wikimedia.org/67675) (owner: 10Florianschmidtwelzow) [18:31:14] <OuKB> pinging me as MaxSem always works [18:31:19] <wikibugs> 3MobileFrontend / 3Feature requests: Difficult or impossible to copy and paste file link from commons "use this image" - 10https://bugzilla.wikimedia.org/67618#c4 (10Jared Zimmerman (WMF)) currently using the desktop site is the only way to expose this. We could rewrite to be "It is not possible to copy and... [18:31:34] <FlorianSW|away> thx for merge kaldari :) [18:31:57] <kaldari> OuKB: but you're not MaxSem anymore :) [18:37:20] <yurik> dr0ptp4kt, deployed... seems to be ok [18:40:32] <wikibugs> 3MobileFrontend / 3alpha: Tasks suggestion campaign for adding links not specific enough - 10https://bugzilla.wikimedia.org/67674#c2 (10Maryana Pinchuk) This was just an experimental feature that didn't get a whole lot of product or design love :) We'll be removing it since it didn't generate much usable data. [18:43:16] <grrrit-wm1> (03Merged) 10jenkins-bot: Add continue message to KeepGoing [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/144719 (https://bugzilla.wikimedia.org/67675) (owner: 10Florianschmidtwelzow) [18:46:02] <wikibugs> 3MobileFrontend / 3alpha: Continue button in campaign is missing - 10https://bugzilla.wikimedia.org/67675 (10Florian) 5PATC>3RESO/FIX [19:04:33] <grrrit-wm1> (03CR) 10Jdlrobson: [C: 04-1] "returnto parameter gets set incorrectly." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/138802 (https://bugzilla.wikimedia.org/59937) (owner: 10Florianschmidtwelzow) [19:15:47] <wikibugs> 3MobileFrontend / 3Feature requests: Add Donation link to main navigation - 10https://bugzilla.wikimedia.org/67626#c8 (10Sherah Smith) (In reply to Maryana Pinchuk from comment #7) > Yeah, definitely let us know when the donate landing page gets a mobile > facelift! Sending mobile users to it now seems a lit... [19:16:26] <grrrit-wm1> (03PS2) 10Brion VIBBER: Pull to refresh refactor [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/144735 [19:16:28] <grrrit-wm1> (03PS2) 10Brion VIBBER: Pull to refresh UI on Saved Pages (frontend only) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/144846 [19:16:49] <brion> mhurd: when you have a chance, i think those are ready [19:17:02] <brion> i tracked down the intermittent crash and fixed it, and added the basic alert on the initial view [19:17:10] <grrrit-wm1> (03PS1) 10Yuvipanda: Fix potential crash in PageTitle isSpecialPage [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/145046 [19:17:17] <mhurd> brion: woohoo! will poke soon [19:17:23] <YuviPanda> Krenair: ^ should potentially fix the isSpecial errors [19:17:33] <brion> ima grab a sandwich, be back shortly [19:17:45] <Krenair> yay [19:19:35] <grrrit-wm1> (03PS1) 10Kaldari: Syncing our blues and greens with desktop palette [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/145048 [19:19:57] <grrrit-wm1> (03PS2) 10Kaldari: Syncing mobile blues and greens with desktop palette [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/145048 [19:20:45] <grrrit-wm1> (03PS3) 10Kaldari: Syncing mobile blues and greens with official design palette [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/145048 [19:22:10] <grrrit-wm1> (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/144846 (owner: 10Brion VIBBER) [19:24:32] <wikibugs> 3MobileFrontend / 3Feature requests: MobileFrontend contradicts established expectations for watchlist UI - 10https://bugzilla.wikimedia.org/67526#c10 (10Scott) (In reply to Maryana Pinchuk from comment #8) > What you describe is expected behavior for power users of Wikipedia who have > been editing for a nu... [19:35:33] <grrrit-wm1> (03PS1) 10Mhurd: Removed toc image cruft. Much faster on old devices. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/145050 [19:36:44] <mhurd> brion: ^ this seems to make toc much faster on your old ipod. grabbing food then i’ll review and continue backend refactor :) [19:43:27] <grrrit-wm1> (03PS17) 10Florianschmidtwelzow: Enable anonymous editing in alpha mode [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/138802 (https://bugzilla.wikimedia.org/59937) [19:50:48] <grrrit-wm1> (03CR) 10Florianschmidtwelzow: "> returnto parameter gets set incorrectly." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/138802 (https://bugzilla.wikimedia.org/59937) (owner: 10Florianschmidtwelzow) [19:51:34] <grrrit-wm1> (03PS18) 10Florianschmidtwelzow: Enable anonymous editing in alpha mode [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/138802 (https://bugzilla.wikimedia.org/59937) [19:52:38] <tfinc> brion: are you working from home today ? [19:52:47] <brion> tfinc: yep [19:52:48] <tfinc> you gotta love automated listings for goods http://www.amazon.com/gp/offer-listing/B00AGFISF8/ref=dp_olp_new?ie=UTF8&condition=new [19:53:27] <brion> those are some expensive cables :D [19:54:45] <brion> mhurd: ok testing it on my 3gs… [19:56:42] <brion> oh yeah that’s a big improvement in the ToC speed! [19:57:01] <mhurd> brion: :) [19:58:08] <mhurd> brion: it’s even noticably faster on new devices - instant on by 5s [19:58:46] <grrrit-wm1> (03CR) 10Brion VIBBER: [C: 032 V: 032] "HUGE improvement in ToC scrolling speed on slow old iPhone 3Gs. Awesome!" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/145050 (owner: 10Mhurd) [19:58:59] <brion> that should help on dan’s iphone 4 as well :D [19:59:06] <mhurd> brion: yay! ok getting food for real this time [19:59:12] <brion> ok :D [20:01:56] <awjr> MaxSem we're getting started with estimation mtg now [20:05:11] <awjr> http://etherpad.wikimedia.org/p/VE_bugs [20:07:47] <wikibugs> 3MobileFrontend / 3Feature requests: MobileFrontend contradicts established expectations for watchlist UI - 10https://bugzilla.wikimedia.org/67526#c11 (10Florian) Ähm, is there any reason why you redirect the conversation in such way with these formulations and hostility? I think no, so please back to the no... [20:12:00] <grrrit-wm1> (03PS2) 10Dbrant: [WIP] Implement Theme/Font chooser. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/144987 [20:17:32] <wikibugs> 3MobileFrontend / 3Feature requests: MobileFrontend contradicts established expectations for watchlist UI - 10https://bugzilla.wikimedia.org/67526#c12 (10Scott) (In reply to Florian from comment #11) > First i want to ask, who "we" is :) The group Maryana described as "power users" in the comment that I was... [20:21:23] <awjr> http://hatjitsu.wmflabs.org/70309 [20:21:46] <wikibugs> 3MobileFrontend / 3Feature requests: MobileFrontend contradicts established expectations for watchlist UI - 10https://bugzilla.wikimedia.org/67526#c13 (10Bawolff (Brian Wolff)) (In reply to Maryana Pinchuk from comment #9) > ^ that's specifically RE this: "Expected behaviour: > *Design/UI paradigms are consi... [20:27:01] <kaity> https://trello.com/c/UnRoyodm/136-add-edit-link-and-edit-citation-text-to-context-toolbars [20:27:32] <wikibugs> 3MobileFrontend / 3Feature requests: MobileFrontend contradicts established expectations for watchlist UI - 10https://bugzilla.wikimedia.org/67526#c14 (10Scott) I wrote: > that's exactly what the mobile UX already did for experienced editors. That should have read: > that's exactly what the mobile UX alread... [20:30:41] <vbamba> brion: Hey Brion, will the footer treatment be merged in the next build (the stuff we worked on yesterday) ? [20:31:42] <brion> vbamba: should be — i’ll make sure mhurd pokes it before the next build :) [20:47:32] <jdlrobson> MaxSem: I like it :) [20:48:17] <wikibugs> 3MobileFrontend / 3stable: Full text search results missing - 10https://bugzilla.wikimedia.org/67740#c6 (10Juliusz Gonera) This is now fixed, but might require an LD. [20:48:20] <jgonera> Maryana, https://bugzilla.wikimedia.org/show_bug.cgi?id=67740 is fixed but might require LD [20:49:47] <wikibugs> 3MobileFrontend / 3stable: Full text search results missing - 10https://bugzilla.wikimedia.org/67740#c7 (10Max Semenik) On it. [20:50:29] <Maryana> jgonera: k, cool -- thanks for catching that! [20:52:07] <FlorianSW|away> jgonera: Maybe a good idea to merge the cherry picked change, too? https://gerrit.wikimedia.org/r/#/c/145037/ [20:52:18] <FlorianSW|away> So it will not go into Wikipedia production tomorrow [20:52:24] <jgonera> Maryana, actually FlorianSW|away fixed it earlier than I did [20:52:42] <Maryana> oh, excellent -- thanks, FlorianSW|away ! [20:52:43] <FlorianSW|away> (or is there any restriction, bc it's already released? :/) [20:52:45] <jgonera> FlorianSW|away, will check with MaxSem about that [20:53:04] <MaxSem> already! [20:53:22] <jgonera> MaxSem, so we need to do a SWAT deploy for this? [20:53:28] <FlorianSW> Maryana: Np :P [20:53:32] <MaxSem> yes [20:53:38] <MaxSem> already nominated [20:53:43] <jgonera> MaxSem, thanks [20:54:00] <brion> mhurd: lemme know when you have time to do a quick review on the commits i’ve got in the queue [20:55:26] <FlorianSW> MaxSem, jgonera: what is LD? :/ [20:55:36] <jgonera> lightning deployment [20:55:38] <Deskana> How are things going everyone? [20:55:40] <Deskana> I'm caught up in this editathon. [20:55:42] <Deskana> bearND: I hope it was useful. :) [20:55:52] <MaxSem> FlorianSW, an obsolete name for SWAT;) [20:55:56] <Deskana> FlorianSW: https://wikitech.wikimedia.org/wiki/SWAT_deploys [20:56:31] <FlorianSW> ah, ok, is there any "long" version for ld? :D [20:56:45] <mhurd> brion: reviewing now [20:57:03] <brion> woohoo! [20:57:20] <MaxSem> lightning deployment [20:57:22] <bearND> Deskana: it was helpful. Thank you! [20:57:44] <mhurd> brion: i see 2 pull2refresh2 branches… is one cruft? [20:57:58] <brion> mhurd: it’s two patches in series [20:58:08] <brion> the refactor is first [20:58:11] <brion> then the saved pages change [20:58:17] <mhurd> brion: oh. derp [20:58:30] <brion> yeah it’s unclear from the list, you have to click in to see the dependencies :) [20:58:35] <brion> gerrit is ….. well gerrit is gerrit [20:58:41] <mhurd> hehe [20:58:42] <bearND> Deskana: maybe next time you could also show some more things, like how to use talk pages, templates, citations? [20:58:56] <FlorianSW> thx MaxSem :) [21:00:50] <Deskana> bearND: Sure. I think someone else might be best to show citations because I'm the odd case that writes the templates by hand. :) [21:03:41] <MaxSem> jgonera, please don't merge changes to core deployment branches unless you're going to deploy them immediately [21:04:50] <StevenW> kaldari|2: I don't understand why design team folks are dictating the LESS semantics for mediawiki.ui [21:04:59] <StevenW> they're not working with the code [21:05:18] <kaldari|2> well, it does potentially affect how they are used by developers [21:05:26] <grrrit-wm1> (03Abandoned) 10Jdlrobson: Use Mantle version of Class, eventemitter and View [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129336 (owner: 10Jdlrobson) [21:05:32] <mhurd> brion: i may be doing something silly, but when i try to use the gerrit git url for the footer style update i get no changed files... [21:05:33] <grrrit-wm1> (03PS7) 10Jdlrobson: Add template dependency to Mantle extension [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129335 [21:06:13] <StevenW> kaldari|2: right. we're adding a bunch of grey values that we're not supposed to use? [21:06:21] <grrrit-wm1> (03CR) 10jenkins-bot: [V: 04-1] Add template dependency to Mantle extension [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129335 (owner: 10Jdlrobson) [21:06:28] <StevenW> The whole patch confuses the shit out of me. [21:07:08] <brion> mhurd: ah you may have to do the whole ‘clear derived data’ thing [21:07:48] <kaldari|2> StevenW: The idea is to use semantic values when they exist, but we don't need semantic values for every use of grey (since most of them are just random UI elements without semantic meaning) [21:08:05] <StevenW> Yeah that sort of makes sense [21:08:09] <grrrit-wm1> (03Abandoned) 10Jdlrobson: WIP: Use MobileFrontendEditCollection model [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/133681 (owner: 10Jdlrobson) [21:08:15] <StevenW> but why are we adding so many grey values at all? [21:09:26] <kaldari|2> StevenW: according to design, they want to encourage reuse of a smaller set of colors, but I'm not really sure it's needed personally. [21:09:49] <StevenW> Yeah to be honest I think we need to push back on adding color values that we're not intended to use. [21:10:17] <StevenW> but are basically just "waiting around" on the hope someone will be use one of the LESS values instead of whatever in their CSS. [21:10:55] <brion> mhurd: also make sure grunt gets run and din’t overwrite something oddly [21:11:08] <brion> sometimes git refuses to do a checkout because of possible conflicts also [21:11:19] <grrrit-wm1> (03CR) 10Mhurd: [C: 032 V: 032] "Looks good!" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/144811 (owner: 10Brion VIBBER) [21:11:24] <brion> woot [21:11:52] <brion> vbamba: the footer updates are merged :D [21:14:43] <Guest4485> تحذير [21:14:43] <Guest4485> warning [21:14:43] <Guest4485> you may be watched [21:14:43] <Guest4485> do usa&israel use the internet(facebook,youtube,twitter, chat rooms ..ect)to spy?? [21:14:43] <Guest4485> do usa&israel use the internet 2 collect informations,,can we call that spying?? [21:14:43] <Guest4485> do they record&analyse everything we do on the internet,,can they harm you using these informations?? [21:14:43] <Guest4485> warning [21:15:06] <Maryana> wtf [21:15:06] <mhurd> lol [21:15:08] <YuviPanda> awww [21:15:09] <YuviPanda> poor guy [21:15:12] <YuviPanda> ther he is again [21:15:35] <YuviPanda> hmm, why do I assume everyone on the internet is male by default? /me slaps self [21:15:50] <Maryana> i read that as "/me slaps elf" [21:15:56] <Maryana> apparently i assume everyone on the internet is an elf [21:16:03] <mhurd> YuviPanda: warning! [21:16:08] <awjr> lol [21:16:20] <brion> oh noooooooooes [21:16:21] * YuviPanda gives Maryana his axe [21:16:26] <mhurd> beware the informations [21:17:31] <Guest4485> تحذير [21:17:32] <Guest4485> warning [21:17:32] <Guest4485> you may be watched [21:17:32] <Guest4485> do usa&israel use the internet(facebook,youtube,twitter, chat rooms ..ect)to spy?? [21:17:32] <Guest4485> do usa&israel use the internet 2 collect informations,,can we call that spying?? [21:17:32] <Guest4485> do they record&analyse everything we do on the internet,,can they harm you using these informations?? [21:17:55] <YuviPanda> we should tell Guest about EL [21:18:05] <brion> :D [21:18:06] <mhurd> lol [21:18:06] <YuviPanda> so he can add WMF to that list, and post it to wikimedia-l [21:18:30] <Maryana> maybe this is related to this story? http://arstechnica.com/security/2014/07/mobile-apps-cookies-leave-a-data-trail-behind-you/ [21:18:40] <Maryana> our app is actually singled out as being quite good and non-invasive :D [21:19:08] <Deskana> EXCESS FLOOD [21:19:20] <jdlrobson> MaxSem: can we talk in real life? [21:19:42] <brion> excess Flood is a frequent problem when playing certain Halo levels [21:19:45] <Reedy> Don't be silly [21:19:51] <Maryana> hehehe [21:21:16] <brion> Deskana: you’re still listed as on this ‘don’t show redlinks’ card — anything more to add or is it ready to go? https://trello.com/c/w6H2lnUk/22-don-t-show-redlinks [21:21:33] <brion> \o/ [21:21:50] <Deskana> brion: I think that was while we found out how to do it, i.e. pending the results of Yuvi's investigation (which he's finished). [21:21:55] <brion> spiff [21:21:58] <Deskana> If you know how to do it, then we're good to go. [21:22:06] <brion> yeah it’s pretty straightforward [21:22:38] <YuviPanda> Maryana: heh, and they are quite wrong as well :) We collect the same IP info from apps as we do from web (and again don't use it), and the app actually sends your carrier's code to us (for Zero purposes), which they have no way of knowing. [21:22:38] <YuviPanda> awwwwm Journalism [21:24:54] <Deskana> Incorrect journalism! [21:25:03] <Deskana> That happens about as often as someone being wrong on the internet. [21:25:15] <YuviPanda> Deskana: so you mean never? [21:25:20] <Deskana> Exactly. [21:25:27] <Deskana> (the irony of that statement being incorrect is not lost on me) [21:26:23] <grrrit-wm1> (03CR) 10Mhurd: "Added comments on tiny issues." (032 comments) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/144735 (owner: 10Brion VIBBER) [21:26:27] <mhurd> brion: ^ [21:26:35] <brion> looking [21:26:56] <mhurd> brion: could you rebase while you’re poking? [21:27:06] <brion> sure [21:28:27] <grrrit-wm1> (03CR) 10Brion VIBBER: Pull to refresh refactor (032 comments) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/144735 (owner: 10Brion VIBBER) [21:29:30] <mhurd> brion: good point on super / delegate [21:30:27] <mhurd> brion: if you can rebase i’ll merge that :) [21:30:32] <brion> yay :D [21:31:00] <tfinc> Deskana: is 37 the correct tally for spring 35 ? [21:31:24] <grrrit-wm1> (03PS1) 10JGonera: QA: Fix tests for search on special pages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/145135 [21:31:38] <brion> mhurd: yeah the compiler won’t let me add asuper call there as it’s only a protocol method, not an override from parent class [21:31:46] <brion> ok lemme rebase and remove that mark :D [21:31:47] <mhurd> brion: sounds good [21:32:19] <grrrit-wm1> (03PS3) 10Brion VIBBER: Pull to refresh refactor [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/144735 [21:32:27] <brion> lemme rebase the other one on top of that now [21:32:38] <grrrit-wm1> (03PS3) 10Brion VIBBER: Pull to refresh UI on Saved Pages (frontend only) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/144846 [21:32:46] <brion> oh good, it was a clean rebase *phew* [21:32:50] <mhurd> :) [21:34:26] <grrrit-wm1> (03PS2) 10Kaldari: Hygiene: Removing a bunch of old icon CSS that is no longer needed [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/144844 [21:34:47] <grrrit-wm1> (03PS2) 10Kaldari: Hygiene: Cleaning up pageaction icon CSS [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/144852 [21:35:27] <grrrit-wm1> (03CR) 10Mhurd: [C: 032 V: 032] "This is AWESOME." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/144735 (owner: 10Brion VIBBER) [21:35:36] <brion> :D [21:46:07] <mhurd> brion: ok if i hold off on merging the remaining patch until i’m a little close to hooking things up to it? [21:46:36] <brion> mhurd: sure [21:46:42] <mhurd> brion: little *closer* [21:46:47] <mhurd> brion: coolness [21:54:03] <grrrit-wm1> (03PS1) 10Brion VIBBER: Remove redlinks [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/145138 [22:20:19] <kaldari|2> dr0ptp4kt: You free? [22:20:36] <dr0ptp4kt> kaldari|2: yeah, in 2 mins. google hangout? [22:21:03] <kaldari|2> dr0ptp4kt: actually, gimme 5 minutes [22:21:37] <dr0ptp4kt> kaldari|2: k [22:28:43] <mhurd> brion: wanna see something cool? [22:28:53] <brion> i sure do :D [22:31:27] <mhurd> brion: paste this in the web view controller’s memory did receive warning method, then load an article, the toggle with command-shift-m https://gist.github.com/montehurd/b2178e281ef39a216318 [22:31:40] <mhurd> *then toggle* [22:32:22] <mhurd> brion: using this for quick visual confirmation that images have been properly routed to core data store [22:33:29] <grrrit-wm1> (03PS1) 10JGonera: QA: Don't test for Uploads in menu for anon users [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/145148 [22:33:45] <brion> nice [22:34:27] <mhurd> brion: looks even nicer if you set that UIImageView to do this: imageView.contentMode = UIViewContentModeScaleAspectFit; [22:36:04] <brion> sweeeet [22:36:09] <grrrit-wm1> (03PS1) 10JGonera: QA: Remove test for dynamic page loading [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/145149 [22:37:56] <mhurd> brion: used to get this confirmation for free with the toc images. now that they’re gone this is super handy :) [22:38:09] <brion> \o/ [22:43:52] <jgonera> Maryana, awjr I think I tackled all browser test failures that are not caused by saucelabs or beta labs flakiness [22:44:05] <awjr> nice jgonera! [22:44:11] <jgonera> unfortunately, most of them seem to be caused just by that [22:44:16] <awjr> argh [22:44:30] <awjr> have you been in touch with chris about it? [22:44:44] <awjr> i am surprised to not have heard anything from him about it [22:44:51] <jgonera> I was going to ask him but I haven't seen him on IRC today [22:45:12] <jgonera> do you remember when we're ditching saucelabs in favor of our own servers? [22:45:56] <awjr> i thought we had already [22:46:09] <jgonera> nope, everything still uses saucelabs [22:46:20] <awjr> oh, but the job execution is happening on our end now, right? [22:46:26] <jgonera> yes [22:46:30] <awjr> right ok [22:46:39] <awjr> i don't remember off the top of my head what the timeline was for that [22:46:40] <jgonera> but that's not helping if saucelabs can't rech beta labs for some reason [22:46:43] <awjr> right [22:47:15] <awjr> well, send an email to mobile and qa lists detailing what you've resolved and what flakiness you're seeing [22:47:29] <jgonera> awjr ok [22:47:30] <awjr> i would push qa for an updated timeline on getting the flakiness resolved [22:47:50] <awjr> it is really frustrating to have so many failures be a result of infra issues [22:58:52] <awjr> thanks for mailing that out jgonera [22:59:03] <jgonera> no problem [22:59:30] <grrrit-wm1> (03PS1) 10Brion VIBBER: Terms of Use update for edit screen [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/145152 [23:02:27] <grrrit-wm1> (03PS2) 10Kaldari: WPI: Promoting MediaViewer to stable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/144833 [23:09:08] <mhurd> brion: that looks great! [23:09:20] <brion> thanks :D [23:10:02] <brion> having that function to do string replacements made it easy to just add a second parameter [23:10:07] <brion> *attributed string replacements [23:10:08] <mhurd> yay! [23:10:21] <brion> and then it was just fighting UIActionSheet ;) [23:11:46] <grrrit-wm1> (03CR) 10Mhurd: [C: 032 V: 032] "Looks awesome!" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/145152 (owner: 10Brion VIBBER) [23:12:29] <brion> woot [23:12:57] <brion> mhurd: another small one: https://gerrit.wikimedia.org/r/#/c/145138/ JS tweak to hide redlinks [23:13:20] <mhurd> brion: peeking... [23:15:38] <mhurd_> brion: opps got disconnected. would you have time for a quick hangout? [23:15:45] <brion> sure [23:15:48] <brion> moment [23:19:22] <bearND> hey YuviPanda: still up? [23:19:34] <YuviPanda> bearND: surprisingly :) [23:19:35] <YuviPanda> 'sup [23:19:55] <bearND> YuviPanda: was wondering if I should show the back links of references [23:20:30] <YuviPanda> bearND: in the reference display? [23:20:33] <bearND> YuviPanda: i mean showing them isn't hard just letting the click do the right thing is, since we'd have to scroll to the right location in the webview [23:20:43] <bearND> YuviPanda: yes [23:21:01] <YuviPanda> bearND: but you can't actually get to the reference display without the reference being on your screen right now, no?: [23:21:11] <YuviPanda> bearND: one thing we can do eventually is to highlight the current reference being displayed [23:21:26] <bearND> YuviPanda: true, so it's not that useful. sometimes there are multiple back references [23:21:37] <YuviPanda> bearND: ah, hmm. I'd say leave it out for now [23:21:54] <bearND> YuviPanda: yeah, that sounds good [23:22:04] <bearND> YuviPanda: thanks [23:22:45] <YuviPanda> bearND: :D sweet [23:23:56] <bearND> YuviPanda: fyi, I'm using a TextView for the reference display instead of a webview since I think the latter is a bit heavy. [23:24:07] <YuviPanda> bearND: oh yeah, definitely agreed. no webviews ther. [23:24:24] <YuviPanda> bearND: textview's html support should be 'good enough' for us [23:25:01] <bearND> YuviPanda: esp. once we have multiple of those in a PageViewer [23:25:10] <YuviPanda> bearND: yup, yup. [23:25:50] <bearND> YuviPanda: yes, it is sufficient for displaying links. Just had to use a custom LinkMovementMethod to get the links to work [23:26:06] <YuviPanda> bearND: yeah, I think we've had the LinkMovementMethod thing elsewhere, maybe even in Util? [23:26:07] <YuviPanda> unsure [23:26:19] <bearND> YuviPanda: feeding that into the LinkHandler [23:26:28] <YuviPanda> bearND: aaah, that sounds best :D [23:26:32] <YuviPanda> yay for LinkHandler! [23:33:57] <grrrit-wm1> (03PS1) 10Mhurd: Shortened edit workflow login message. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/145163 [23:34:17] <mhurd> brion: ^ [23:34:46] <mhurd> brion: quick patch from vibha [23:35:29] <grrrit-wm1> (03PS1) 10MaxSem: Only collapse sections on wikitext pages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/145165 [23:35:41] <MaxSem> jdlrobson, ^^^ [23:36:01] <grrrit-wm1> (03CR) 10MaxSem: [C: 04-2] "Waiting for more clarity with Flow." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/145165 (owner: 10MaxSem) [23:36:04] <grrrit-wm1> (03CR) 10Mhurd: [C: 032 V: 032] "Looks good!" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/145138 (owner: 10Brion VIBBER) [23:47:26] <dr0ptp4kt> kaldari|2: http://shop.oreilly.com/product/0636920030508.do [23:47:48] <grrrit-wm1> (03CR) 10Brion VIBBER: [C: 032 V: 032] Shortened edit workflow login message. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/145163 (owner: 10Mhurd) [23:48:44] <tfinc> awjr: plan updated [23:49:00] <tfinc> awjr: it was all good. that estimation meeting that tripped me up was for Zero [23:49:55] <mhurd> brion: yay! [23:50:01] <mhurd> brion: thx! [23:50:12] <brion> np :) [23:50:25] <mhurd> brion: did you play with that updated gist? [23:50:43] <brion> not yet [23:50:54] <mhurd> brion: no rush - it’s just cool :) [23:50:58] <brion> :) [23:56:19] <jgonera> MaxSem, looks like everything's fine [23:56:34] <grrrit-wm1> (03PS1) 10Kaldari: Disable other click event handlers for images/thumbnails [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/145170 [23:56:55] <MaxSem> whee [23:57:58] <grrrit-wm1> (03PS2) 10Kaldari: Disable other click event handlers for images/thumbnails [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/145170 [23:58:16] <awjr> tfinc ok sweet, thanks!