[00:00:08] tfinc so she will pick up facilitating planning meetings for the cycle after 7/31? [00:01:56] (03CR) 10Dr0ptp4kt: [C: 032] "Works for me." [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/145170 (owner: 10Kaldari) [00:02:02] yes [00:02:13] awjr: i added one more bullet point to clarify that [00:02:22] ah yes, thanks tfinc :) [00:02:43] awjr: now it looks as clean as i wanted it to look :) [00:03:19] good move to spell out the specific mtg dates [00:04:39] (03Merged) 10jenkins-bot: Disable other click event handlers for images/thumbnails [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/145170 (owner: 10Kaldari) [00:05:07] (03PS3) 10Kaldari: Promoting MediaViewer to stable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/144833 [00:05:53] awjr: feel to reformat as you need. i just did it that way to organize and spell everything out [00:06:00] aye [00:07:30] jgonera: where are you hiding? [00:07:51] Maryana, couch near entrance [00:10:19] brion: looks like the protected edit pencil hasn’t gone to production yet (https://gerrit.wikimedia.org/r/#/c/143067/). just tested it. [00:15:18] (03PS4) 10Kaldari: Promoting MediaViewer to stable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/144833 [00:16:00] jgonera: https://trello.com/c/dMNavklt/8-spike-get-benchmarks-on-mobile-ve-performance-as-compared-to-desktop [00:16:56] Maryana, lgtm [00:17:08] how much time do you think that should take? [00:17:10] 2 hrs? 4? [00:17:28] 16-hour thank trolling spike? [00:17:30] :) [00:18:04] jgonera: ^ [00:18:29] hm, let's say 4 for now [00:26:17] I have no idea what https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom&TicketID=7659747 is talking about [00:27:17] 3MobileFrontend / 3stable: Full text search results missing - 10https://bugzilla.wikimedia.org/67740#c10 (10Ryan Kaldari) 5PATC>3RESO/FIX You guys are fast :) [00:30:05] (03PS3) 10Kaldari: Making SVG compression smarter in pre-commit hook [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/143684 [00:40:47] (03PS1) 10JGonera: WIP: Improve fixed header in overlays on iOS [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/145185 [05:54:02] (03PS1) 10BearND: [WIP] Show references without scrolling [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/145225 [06:10:24] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/145225 (owner: 10BearND) [07:27:31] (03CR) 10Siebrand: "i18n/L10n reviewed." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/144846 (owner: 10Brion VIBBER) [07:34:53] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/144987 (owner: 10Dbrant) [08:37:50] (03CR) 10Hashar: "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129335 (owner: 10Jdlrobson) [10:17:43] (03PS6) 10Florianschmidtwelzow: Proposal: Redirect to direct match in search [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/139556 (https://bugzilla.wikimedia.org/66506) [10:17:52] (03CR) 10Florianschmidtwelzow: Proposal: Redirect to direct match in search [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/139556 (https://bugzilla.wikimedia.org/66506) (owner: 10Florianschmidtwelzow) [10:19:29] (03CR) 10Florianschmidtwelzow: Hygiene: Manage z-index with less variables (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/139568 (https://bugzilla.wikimedia.org/64707) (owner: 10Florianschmidtwelzow) [11:27:26] (03PS3) 10Dbrant: [WIP] Implement Theme/Font chooser. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/144987 [11:36:12] (03CR) 10Dbrant: "@Siebrand, The term "theme" is very much used in the Android ecosystem, and therefore more familiar to users. (although we could ask the d" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/144987 (owner: 10Dbrant) [12:00:32] 3MobileFrontend / 3Feature requests: Tracking: Watchlist features available on desktop that aren't on mobile yet - 10https://bugzilla.wikimedia.org/56817#c7 (10Quim Gil) Marking specific problems as duplicates of a tracking bug doesn't help fixing the specific problems. Do you think it would make sense to de... [12:10:26] (03PS4) 10Dbrant: [WIP] Implement Theme/Font chooser. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/144987 [12:15:17] 3MobileFrontend / 3Feature requests: MobileFrontend contradicts established expectations for watchlist UI - 10https://bugzilla.wikimedia.org/67526#c15 (10Quim Gil) As a daily user of the mobile watchlist and a "established contributor" in desktop, I think the current mobile watchlist is useful and has a good... [12:29:16] 3MobileFrontend / 3Feature requests: Tracking: Watchlist features available on desktop that aren't on mobile yet - 10https://bugzilla.wikimedia.org/56817 (10Quim Gil) [12:29:17] (03PS5) 10Dbrant: Implement Theme/Font chooser. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/144987 [12:29:19] 3MobileFrontend / 3Feature requests: Mobile watchlist should follow the same Show/Hide preferences as the desktop watchlist - 10https://bugzilla.wikimedia.org/67799 (10Quim Gil) 3NEW p:3Unprio s:3normal a:3None In desktop, users can fine tune their watchlist by showing / hiding minor edits, bots, etc... [12:30:32] 3MobileFrontend / 3Feature requests: Mobile watchlist should follow the same Show/Hide preferences as the desktop watchlist - 10https://bugzilla.wikimedia.org/67799#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/jPqFGTT1 [13:31:11] * YuviPanda waves at dbrant [13:31:19] hello! [13:32:12] let me CR that patch now [13:32:28] (03PS6) 10Yuvipanda: Implement Theme/Font chooser. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/144987 (owner: 10Dbrant) [13:36:46] dbrant: me likey, although I wish there was an easier way to transition without having to reboot the activigty [13:36:59] dbrant: also, wasn't the switcher design something different taking up the whole bottom pane? [13:38:32] YuviPanda: I can easily make the dialog fill up the entire bottom area... but I thought this would be less obtrusive, and would show more of the article in the background. [13:38:37] dbrant: also the bottom border color on the search bar in dark mode feels way too bright. [13:38:51] dbrant: hmm, right. But I think the original intent was to keep it consistent for this + references in terms of design [13:40:18] YuviPanda: and yes, restarting the activity is pretty much the only way :( but I tried to preserve state as well as possible. [13:40:32] dbrant: yeah, hitting back seems to work fine [13:41:19] YuviPanda: bottom border of the search bar? Mine doesn't look bright... can you send a screenshot? [13:41:41] dbrant: it seems to be making a network request for the current page, though [13:41:43] dbrant: sure [13:42:16] dbrant: we should also call it 'Change appearance' or somesuch [13:42:38] shorter, and will also probably be shorter in other languages as well [13:45:45] YuviPanda: perhaps, but in terms of discoverability, for users who are looking to change the font size, it should mention "font" explicitly. The same for colors... [13:45:56] hmm, that's true as well [13:46:05] I'll leave it to you and dan to figure that out :) [13:46:29] dbrant: we should probably put the light/dark buttons into 'button groups' of some sort, which act like radio buttons but are styled somewhat like buttons [13:46:35] rather than what we have now. [13:49:52] dbrant: but otherwise seems good! I'm going to look through the code now [13:51:02] dbrant: btw, in the future, try to make more atomic commits. the preview night mode should've been its own commit, for example [13:51:17] dbrant: I find git commit -p great for doing such things. do all the work, but split them into smaller commits in the end [13:52:54] YuviPanda: alright! I'll agree that this one's a bit all-encompassing. [13:57:31] dbrant: yeah, but 'tis ok [14:15:38] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/144987 (owner: 10Dbrant) [14:27:16] (03PS1) 10Dbrant: Strip text formatting when pasting into text fields. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/145322 (https://bugzilla.wikimedia.org/65606) [14:39:36] (03CR) 10Dbrant: [C: 032] Fix potential crash in PageTitle isSpecialPage [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/145046 (owner: 10Yuvipanda) [14:54:19] 3Wikipedia App / 3Android App: NPEs from page.PageViewFragment.commonSectionFetchOnCatch - 10https://bugzilla.wikimedia.org/67807 (10Alex Monk) 3NEW p:3Unprio s:3normal a:3None STACK_TRACE=java.lang.RuntimeException: java.lang.NullPointerException at org.wikipedia.page.PageViewFragment.commonSectionF... [14:55:09] YuviPanda, I think to clean things up I'm going to close crash report tickets that are obviously related to things we already track in BZ [14:55:22] Krenair: woot! thank you [14:56:07] +1 [14:58:56] otherwise that queue is just out of control [14:59:14] Krenair: right, anything matching the find in page and special page can be archived? [14:59:32] I did the find in page stuff already, because that was getting ridiculous [14:59:41] right [15:00:39] I'm going to eat food, brb [15:30:34] 3Wikipedia App / 3Android App: NPEs from android.support.v4.widget.DrawerLayout.isContentView ? - 10https://bugzilla.wikimedia.org/67808 (10Alex Monk) 3NEW p:3Unprio s:3normal a:3None STACK_TRACE=java.lang.NullPointerException at android.support.v4.widget.DrawerLayout.isContentView(DrawerLayout.java:... [15:50:34] 3Wikipedia App / 3Android App: ConcurrentModificationException in org.wikipedia.concurrency.SaneAsyncTask.onCatch - 10https://bugzilla.wikimedia.org/67809 (10Alex Monk) 3NEW p:3Unprio s:3normal a:3None STACK_TRACE=java.lang.RuntimeException: java.util.ConcurrentModificationException at org.wikipedia.... [15:52:32] 3Wikipedia App / 3Android App: ConcurrentModificationException in org.wikipedia.concurrency.SaneAsyncTask.onCatch - 10https://bugzilla.wikimedia.org/67809#c1 (10Alex Monk) Oh and https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom;TicketID=7661125 as well [16:27:13] (03PS1) 10Dbrant: Add graphics and explanations for History and Saved Pages. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/145355 [16:29:18] YuviPanda: hey, i just emailed on mobile-l regarding the cdata for the log in clickablespan. would you mind replying on list to provide guidance (ideally, the cdata text and any hints on how to phrase the qqq for the translators) ? [16:31:17] dr0ptp4kt: yeah, still eating food, I'll do that right after [16:31:25] YuviPanda: thank you! [16:37:14] (03PS2) 10Brion VIBBER: Fetch CSS resources from prod instead of labs [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/143067 (owner: 10Yuvipanda) [16:37:32] rebased [16:38:30] brion: is that gonna merge? :) [16:39:14] (03PS4) 10Florianschmidtwelzow: Enable customization of footer links [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/144482 (https://bugzilla.wikimedia.org/66350) [16:39:36] YuviPanda: is the broken edit pencil live? if so we can switch :D [16:39:44] lemme check [16:40:26] ok i see it i think \o/ [16:40:35] .page-protected a.edit_section_button { background-image: … [16:41:30] oh wait i was loading the beta one [16:41:31] lol [16:42:08] brion: you can have MaxSem SWAT it [16:42:43] ok looks good at https://bits.wikimedia.org/en.wikipedia.org/load.php?debug=true&lang=en&modules=mobile.app.pagestyles.ios&only=styles&skin=vector [16:42:44] \o/ [16:43:14] (03PS1) 10Alex Monk: Fix browsing to test2wiki [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/145362 [16:43:32] (03PS1) 10Brion VIBBER: Fix a compiler warning about unknown symbol [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/145363 [16:43:54] judging by the amout of mobile swats, this should be really upgraded to Navy SEALing [16:45:01] Hi guys, https://www.mediawiki.org/wiki/Talk:Wikimedia_Apps/Commons#Why_.22Donate.22.3F <- the donate thing again :P [16:45:27] Dejavu! (but I can't find the previous topic about it) [16:45:34] MaxSem: Maybe the Green Tablets (pronounced tah-blays) should take a whack :) [16:45:51] (03CR) 10Brion VIBBER: [C: 032 V: 032] "Updates are live." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/143067 (owner: 10Yuvipanda) [16:46:15] bah my nexus5 spontaneously rebooted again [16:46:42] i’m pretty sure i’m pressing the poewr button with the armrest of my office chair :D [16:50:43] (03CR) 10Alex Monk: "I had been getting this issue when I clicked links to test2wiki, but haven't been able to reproduce the error since..." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/145362 (owner: 10Alex Monk) [16:54:01] (03CR) 10Yuvipanda: "Ah, hm." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/145362 (owner: 10Alex Monk) [16:56:00] (03CR) 10Dbrant: "I would argue for defaulting to "en" if the language isn't found. I can make the change, if you guys want." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/145362 (owner: 10Alex Monk) [16:56:57] dbrant, I have to go now, but sounds good to me [16:57:13] Krenair: alright! [16:57:41] dbrant: yeah, defaulting to en sounds good to me too [17:08:24] Deskana|Away: are you 'San' now? [17:12:33] brion: gah! i forgot to cut build before i left yesterday… cutting now [17:14:40] (03PS2) 10Dbrant: Fix possible crash when looking up page alias data. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/145362 (owner: 10Alex Monk) [17:35:07] (03CR) 10Yuvipanda: [C: 032] Fix possible crash when looking up page alias data. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/145362 (owner: 10Alex Monk) [17:37:50] (03Merged) 10jenkins-bot: Fix possible crash when looking up page alias data. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/145362 (owner: 10Alex Monk) [17:43:29] brion: are you working from home today? [17:43:34] yep [17:46:26] Deskana: just cut an ios build - curious to see if the toc performance is better on your device... [17:53:22] (03PS8) 10Yuvipanda: During edit save, describe IP edit and offer login if appropriate. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/143156 (owner: 10Dr0ptp4kt) [17:55:39] mhurd: Will check in a sec. [17:55:47] YuviPanda: Yes. :) [17:55:52] Deskana: no rush! [17:56:31] Deskana: 私が日本語であなたに話すべきでしょうか？ [17:56:58] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/144175 (owner: 10Yurik) [17:56:59] dr0ptp4kt: looking at your patch now, making some tweaks [17:57:26] YuviPanda: thanks! oh, one thing, "Your edits" should now be "Edits" in order to reflect iOS verbiage [17:57:43] ok [17:58:26] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/144651 (owner: 10Yurik) [18:02:36] YuviPanda: I think I might have misunderstood what you meant. [18:02:58] Deskana: you signed as 'San' in the last email in the play store reviews thread rather than Dan :) [18:03:07] YuviPanda: Oops. Phone autocorrect. [18:03:11] and San is somewhat equivalent of something vaguely related to Mr. in Japanese [18:03:15] #involvedjokes [18:03:17] YuviPanda: I thought you were asking if I was in *San* Francisco. [18:03:21] Deskana: hahahaahn [18:03:21] So I replied yes! [18:03:25] Then I got Japanese. [18:03:44] Deskana: hahaha. [18:03:55] mhurd: Much faster! In honesty still a little slower than I'd like, but that could just be my phone being a pain. [18:04:17] mhurd: "Faster" was "MVP". "Much faster" is "Next release". ;) [18:04:59] Deskana: what part is still slow? appearance, scrolling, selection, disappearance? [18:05:05] YuviPanda：　君の日本語は上手です。 [18:05:10] What is SkinMinervaApp.php? [18:07:10] tfinc: :D [18:07:33] jdlrobson: What is SkinMinervaApp.php? [18:07:45] kaldari: talk to dr0ptp4kt [18:07:57] that was made for the itention of the Wikipedia Firefox app [18:08:04] tfinc: it was from Google Translate, though [18:08:24] தமிழே வரலயாம். ஜப்பானா? [18:08:30] jdlrobson: Cool, I'll add a comment to that effect [18:08:58] kaldari: specifically it is used by Special:MobileWebApp [18:11:32] Ah thanks [18:13:11] (03CR) 10MaxSem: [C: 031] "Will upgrade to +2 soon unless there will be objections." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/144482 (https://bugzilla.wikimedia.org/66350) (owner: 10Florianschmidtwelzow) [18:14:39] dr0ptp4kt: right, so here's what I think we should do. bearND's patch for doing references makes more generic a LinkHandler class that lets us handle links as appropriate. So, 1. rebase on top of that, 2. use that class, 3. Surround the string with CData, and use a Login for the string itself, 4. Put in qqq to not have people change the value [18:15:03] dr0ptp4kt: https://gerrit.wikimedia.org/r/#/c/145225/1 is the patch in question [18:15:22] dr0ptp4kt: let me split that part of the patch out, so you can do this easier. moment [18:15:26] (03PS2) 10Yuvipanda: [WIP] Show references without scrolling [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/145225 (owner: 10BearND) [18:15:47] (03CR) 10MaxSem: [C: 031] Add template dependency to Mantle extension [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129335 (owner: 10Jdlrobson) [18:26:15] (03PS1) 10Yuvipanda: Make LinkMovementMethodExt more generic [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/145394 [18:26:17] bearND: dbrant ^ I just refactored one bit of code out of bearND's patch for references. [18:29:45] YuviPanda: cool. Was wondering if we could use the LinkHandler also in EditSection. I refrained from that for now since all links there seem to be external and I don't want to create a LinkHandler unnecessarily. But if there could be internal links in the future we could do that easily. [18:30:11] bearND: yup, dr0ptp4kt's patch is adding an internal link (to Login). I'm rebasing that patch on top of this now [18:30:14] bearND: can you rebase yours too? [18:30:18] bearND: sorry about the extra work [18:30:30] YuviPanda bearND - sorry, was on a call, need to scroll up and see what's up [18:31:06] dr0ptp4kt: TL;DR: I'm amending the patch after rebasing it on a split off of one of bearND's patches, should be working without hacks shortly [18:31:46] YuviPanda cool [18:33:10] YuviPanda: your patch right now, as it stands only covers external links. Log in is a special case not covered by LinkHandler yet since it launches a new activity. Are you planning on adding that to dr0ptp4kt's patch or to yours? [18:33:23] bearND: dr0ptp4kt's [18:33:30] YuviPanda: ok [18:35:15] (03PS1) 10Kaldari: Hygiene: Adding some documentation to the mobile web app code [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/145399 [18:35:26] YuviPanda: want me to CR your patch? It's kinda weird since I originally wrote the code ;) [18:35:55] bearND: :D go ahead [18:36:01] I... think it's ok. [18:36:20] YuviPanda: ok, I guess you've looked at it long enough, too :) [18:36:24] bearND: :D [18:38:59] (03CR) 10BearND: [C: 032] Make LinkMovementMethodExt more generic [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/145394 (owner: 10Yuvipanda) [18:39:29] (03Merged) 10jenkins-bot: Make LinkMovementMethodExt more generic [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/145394 (owner: 10Yuvipanda) [18:39:32] mhurd: We're moving the meeting to some time earlier next week. [18:40:11] (03PS3) 10BearND: [WIP] Show references without scrolling [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/145225 [18:40:17] bearND: ty! [18:40:45] (03CR) 10Kaldari: [C: 032] QA: Don't test for Uploads in menu for anon users [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/145148 (owner: 10JGonera) [18:42:17] dr0ptp4kt: btw, is the SSL fix in place for iOS? just curious [18:42:49] YuviPanda: yes [18:42:53] dr0ptp4kt: cool! [18:43:02] 3MobileFrontend / 3General/Unknown: Mobile is somehow sending API requests that ask for text/html content - 10https://bugzilla.wikimedia.org/67426#c5 (10christian) For sampled-1000 logs underneath /a/squid/archive on stat1002, it is [1] %{Content-Type}o So Content-Type header of response to client. [1]... [18:44:28] (03Merged) 10jenkins-bot: QA: Don't test for Uploads in menu for anon users [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/145148 (owner: 10JGonera) [18:47:29] Deskana: cool! thanks! [18:50:07] (03CR) 10Kaldari: [C: 032] Minerva Desktop: Remove toggling sections [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/143191 (https://bugzilla.wikimedia.org/67105) (owner: 10Florianschmidtwelzow) [18:50:45] (03CR) 10Florianschmidtwelzow: [C: 031] Add template dependency to Mantle extension [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129335 (owner: 10Jdlrobson) [18:50:48] (03Merged) 10jenkins-bot: Minerva Desktop: Remove toggling sections [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/143191 (https://bugzilla.wikimedia.org/67105) (owner: 10Florianschmidtwelzow) [18:51:45] (03CR) 10Kaldari: [C: 032] QA: Fix tests for search on special pages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/145135 (owner: 10JGonera) [18:51:47] 3MobileFrontend / 3General/Unknown: Many Difficulties in Mobile Display of Hebrew WIkisource - 10https://bugzilla.wikimedia.org/66958#c10 (10Maryana Pinchuk) Daniel: "go the page above using an iphone. see how if you move your mouse over the sample text no numeric value appears." Not sure what you mean by "m... [18:52:27] (03CR) 10Florianschmidtwelzow: [C: 031] Hygiene: Adding some documentation to the mobile web app code [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/145399 (owner: 10Kaldari) [18:52:48] (03Merged) 10jenkins-bot: QA: Fix tests for search on special pages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/145135 (owner: 10JGonera) [18:53:34] 3MobileFrontend / 3General/Unknown: If Javascript is disabled and an article doesn't have a talk page, we shouldn't show the talk page icon - 10https://bugzilla.wikimedia.org/67819 (10Ryan Kaldari) 3NEW p:3Unprio s:3normal a:3None If Javascript is disabled and an article doesn't have a talk page, we... [18:54:16] 3MobileFrontend / 3stable: In desktop mode of Minerva, section toggling is broken. It should probably be removed. - 10https://bugzilla.wikimedia.org/67105#c7 (10Florian) 5PATC>3RESO/FIX both merged, set as resolved :) [18:54:57] (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed." (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/143334 (https://bugzilla.wikimedia.org/67352) (owner: 10Florianschmidtwelzow) [18:55:41] (03PS1) 10Dr0ptp4kt: WIP: Add Home icon to sidebar. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/145402 [18:55:46] 3MobileFrontend / 3General/Unknown: If Javascript is disabled and an article doesn't have a talk page, we shouldn't show the talk page icon - 10https://bugzilla.wikimedia.org/67819#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/p2p2lEgY [18:57:25] mhurd: tfinc: I’m coming into the office for the rest of the afternoon, see ya in a bit [18:57:27] (03CR) 10Yuvipanda: [C: 04-1] "Don't think we should do this until we've something more useful on 'Home' other than just today's featured article" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/145402 (owner: 10Dr0ptp4kt) [18:58:12] dbrant: heads up that i may move our 1:1 today [18:58:29] tfinc: sure, np [18:59:19] (03CR) 10Florianschmidtwelzow: Add right- and action- lang key for permission (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/143334 (https://bugzilla.wikimedia.org/67352) (owner: 10Florianschmidtwelzow) [18:59:22] (03PS3) 10Florianschmidtwelzow: Add right- and action- lang key for permission [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/143334 (https://bugzilla.wikimedia.org/67352) [19:00:10] (03PS4) 10Florianschmidtwelzow: Add right- and action- lang key for permission [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/143334 (https://bugzilla.wikimedia.org/67352) [19:00:37] (03PS5) 10Florianschmidtwelzow: Add right- and action- lang key for permission [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/143334 (https://bugzilla.wikimedia.org/67352) [19:03:11] (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed." (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/143334 (https://bugzilla.wikimedia.org/67352) (owner: 10Florianschmidtwelzow) [19:05:22] (03CR) 10Florianschmidtwelzow: Add right- and action- lang key for permission (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/143334 (https://bugzilla.wikimedia.org/67352) (owner: 10Florianschmidtwelzow) [19:05:56] (03PS6) 10Florianschmidtwelzow: Add right- and action- lang key for permission [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/143334 (https://bugzilla.wikimedia.org/67352) [19:06:58] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/145402 (owner: 10Dr0ptp4kt) [19:08:10] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/143334 (https://bugzilla.wikimedia.org/67352) (owner: 10Florianschmidtwelzow) [19:12:56] (03PS1) 10Dbrant: Fix concurrency issue when saving page images. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/145407 (https://bugzilla.wikimedia.org/67809) [19:16:31] 3MobileFrontend / 3Feature requests: images are too small on tablets and large phones - 10https://bugzilla.wikimedia.org/63134 (10Jared Zimmerman (WMF)) [19:19:52] dbrant, YuviPanda, bearND: Last time I checked, Wikipedia Beta is behind production. Can we at least get the same APK on the Beta app for now? [19:21:31] Deskana: I think it's ok. The Night Mode code is in CR, and waiting I think some more design review, so we can cut one as soon as that is done. [19:21:38] and switch to the 'release cadence plan' from next sprint :) [19:24:36] dbrant, YuviPanda, bearND: Not a pressing issue, but I have had at least one staff member come to me with her out-of-date Beta app wondering what had happened. [19:24:58] Deskana: yeah, I think from next sprint it should be allright. we should do a release next week, though (to beta) [19:25:17] Deskana: btw, comments/thoughts on the app release plan page? Should I take silence as 'yeah, that sounds ok' [19:25:18] ? [19:26:03] YuviPanda: After signoff, that's next on my list to look at. Then your email about the dashboard. :) [19:26:20] Deskana: YuviPanda: I sure would like the design-related patches currently in CR to make it into the next beta. [19:27:10] dbrant: Is the styling of the selector for font and theme a work in progress? [19:28:02] YuviPanda: i would like to see a git branching/tagging plan for the releases, as I've added in the TODO section of your releases page [19:28:16] Deskana: I suppose it still is. Do you have any feedback on it? [19:29:04] (03PS1) 10Dbrant: Don't show current saved-page title being refreshed. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/145410 [19:29:12] dbrant: I'd like to see it closer to the design: https://trello.com/c/0Oe7NH6Y/92-design [19:29:39] dbrant: If that's just a "we've just not got to that yet" then there's no problem. [19:30:16] (03PS1) 10Florianschmidtwelzow: Show talk button only when JS enabled or talk page not empty [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/145411 (https://bugzilla.wikimedia.org/67819) [19:30:20] dbrant: On interaction, I'd prefer it if it didn't fade the entire page away and then have it reappear when I toggled between light and dark,. [19:30:42] dbrant: That gives it a "loading a different page" feel which it shouldn't have. [19:30:54] Deskana: I'm afraid that's the only way the theme can be changed in Android (reloading the whole activity) :( [19:31:06] dbrant: another option is for just the PageActivity to set them by hand [19:31:09] like we did for Zero [19:31:22] dbrant: That's okay if it's tricky. It's not an MVP feature. [19:31:40] Deskana: thought we were past MVP now :) [19:31:42] * YuviPanda kids [19:32:08] (03CR) 10Siebrand: [C: 031] "L10n reviewed." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/145410 (owner: 10Dbrant) [19:32:25] Well, I'd say I've done goofed if I was still at the "blockers for release" stage with Android considering it's released already. :p [19:32:56] Deskana: :D [19:33:43] (03PS9) 10Yuvipanda: During edit save, describe IP edit and offer login if appropriate. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/143156 (owner: 10Dr0ptp4kt) [19:33:49] dr0ptp4kt: ^ boom [19:34:12] Deskana: I can easily change its appearance to match the design. But my only issue with that was: on a tablet screen, the selector would take up an absurd amount of space, most of it being empty. Is that OK? [19:35:25] Deskana: Whereas, if it's just a self-contained selector off to the side, the user can see more of the article in the background, and observe the effect of the changes. [19:35:41] YuviPanda: i'll test [19:35:49] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/143156 (owner: 10Dr0ptp4kt) [19:36:05] cool [19:38:39] dbrant: Yeah, we can figure that out too. [19:38:48] dbrant: Maybe some styling to make it seem a bit less like dead space. [19:39:08] dbrant: By the way, there is a slight seizure-inducing moment; if you're on the dark mode and you change pages, it momentarily flashes white between the change. [19:39:09] :P [19:39:16] I went and sat in a dark conference room and tested it. [19:39:23] (03CR) 10Jdlrobson: [C: 032] Hygiene: Adding some documentation to the mobile web app code [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/145399 (owner: 10Kaldari) [19:40:15] Deskana: but... did you have a seizure? [19:40:16] dbrant: That is actually really important to get ironed out. [19:40:32] YuviPanda: So you're saying "User didn't have a seizure, so not a must-have"? :P [19:41:04] Deskana: I haven't seen that on my device... but there may be some latency in the WebView when it loads the night-mode CSS. I'll check it out. [19:41:15] Deskana: (and I'll update the appearance) [19:41:16] (03Merged) 10jenkins-bot: Hygiene: Adding some documentation to the mobile web app code [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/145399 (owner: 10Kaldari) [19:41:46] Well if you want we can refocus the Android team on computational simulations of epileptic seizures. Just so happens I have some expertise in that area. :-p [19:42:40] dbrant: Great. It's looking good. :) [19:43:39] Deskana: wanted to have a separate card for it. 'As a user with no medical insurance in the US, I do not want to have a seizure while reading the app.' [19:43:51] Hell, even as a user with medical insurance. [19:43:54] Backlog. [19:44:01] Even with insurance I'm still paying more for shit than I did in the UK. [19:44:25] Deskana: heard everyone hates the NHS so the Government must bend to the will of the people and slowly hack away at it until it dies naturally :) [19:44:36] A prescription cost $100. [19:44:49] oh wow [19:44:59] Cost in the UK? £8. [19:45:03] Deskana: the device email i was talking about yesterday was "RE: [WikimediaMobile] [Apps] Monthly retrospective notes" [19:45:28] Although to be fair I think the actual prescription was free. The doctor's appointment cost $100. [19:45:29] Deskana: unsure how the UK system is going to treat me during Wikimania+post. should be interesting. [19:45:38] dbrant: CRing your crash fix patches now [19:45:58] YuviPanda: Be very, very careful. As you're neither a British or EU citizen, nor resident in the UK, it's not free for you. [19:46:09] Deskana: yup. [19:46:18] YuviPanda: Although in practice they may not bother checking. It's not like Indians are rare in the UK. [19:46:34] I've never had to prove my citizenship to receive NHS treatment. [19:46:36] Deskana: true, but still. Better be carefuller [19:47:03] Anyway... what was I doing?> [19:47:06] Oh, yeah. [19:47:08] Emails. [19:50:11] (03CR) 10Dr0ptp4kt: [C: 04-1] "Verbiage update needed. Regarding interspersing referenced in comment, do we live with it or update the patch?" (032 comments) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/143156 (owner: 10Dr0ptp4kt) [19:50:43] ^ YuviPanda, lemme know if/how i can assist so we can get this thing in [19:52:06] YuviPanda: Right, so your proposal is for a fortnightly release pattern? [19:52:24] (03CR) 10Yuvipanda: During edit save, describe IP edit and offer login if appropriate. (031 comment) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/143156 (owner: 10Dr0ptp4kt) [19:52:29] Deskana: pretty much. [19:52:47] Deskana: at least, to start that way now. In the future, if they do end up being 'no big deal's, we can reduce the length of them. [19:52:56] dr0ptp4kt: commented. want to update the patch or should I? [19:54:01] YuviPanda: you, please, then i'll test and accordingly +2. cool? [19:54:12] dr0ptp4kt: ah, neither of us can +2, I'd think :) [19:54:15] dr0ptp4kt: but let me update the patch [19:54:36] YuviPanda: oh, ok [20:19:32] Deskana: ping [20:20:51] (03PS1) 10Brion VIBBER: File page cleanup hacks [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/145424 [20:21:35] YuviPanda: Hmm? [20:23:30] Deskana: phrasing for the IP edit message / login CTA in the edit workflow [20:24:01] YuviPanda: I thought I replied to that. [20:24:06] YuviPanda: Is there something specific? [20:24:15] Deskana: it currently says 'Your edits will be attributed to the IP address of your device', and I'd like to keep it that way, vs the iOS verbiage of 'Edits will be attributed to the IP address of your device' [20:24:30] seems far more clearer with the 'Your', at least to my ESL self. [20:24:36] Deskana: objections to keeping the 'Your'? [20:25:00] The reason we took it out of iOS was because it reduced the text to two lines instead of three. [20:25:23] And there is a "Your" in the sentence already so it's user-specific. [20:26:17] Deskana: right, on Android the entire thing is already about 5 lines anyway :) Plus with Android device sizes being so varied, we can't really count on those things. [20:26:35] Deskana: I'm ok with either, but the one without 'Your' feels confusing to me. It might be just me, so if you think taking it out makes it clearer, I can [20:27:10] YuviPanda: I don't think it makes it clearer per se, but it reduces the amount of legal text that's in there so that's helpful. [20:27:22] Anything we can do to reduce that is good in my books. [20:27:26] So I'd prefer it to not be in there. [20:27:29] Deskana: hmm, are we treating this as legal text vs login CTA? [20:27:31] either way, taking it out now [20:27:35] Sorry, no, not legal. [20:27:37] Ethical in this case. [20:27:58] right. [20:28:01] (03PS10) 10Yuvipanda: During edit save, describe IP edit and offer login if appropriate. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/143156 (owner: 10Dr0ptp4kt) [20:28:11] that should do it, I think [20:28:13] Deskana: ty [20:30:02] (03PS2) 10Yuvipanda: Fix concurrency issue when saving page images. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/145407 (https://bugzilla.wikimedia.org/67809) (owner: 10Dbrant) [20:30:32] (03CR) 10Yuvipanda: [C: 032] "Good catch!" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/145407 (https://bugzilla.wikimedia.org/67809) (owner: 10Dbrant) [20:31:03] (03Merged) 10jenkins-bot: Fix concurrency issue when saving page images. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/145407 (https://bugzilla.wikimedia.org/67809) (owner: 10Dbrant) [20:31:33] (03PS2) 10Yuvipanda: Don't show current saved-page title being refreshed. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/145410 (owner: 10Dbrant) [20:31:53] (03CR) 10Yuvipanda: [C: 04-1] "Should remove from qq as well?" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/145410 (owner: 10Dbrant) [20:32:04] YuviPanda: ah yes... [20:32:19] (03PS2) 10Yuvipanda: Strip text formatting when pasting into text fields. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/145322 (https://bugzilla.wikimedia.org/65606) (owner: 10Dbrant) [20:34:30] Maryana: jdlrobson : you guys are the last two hold outs for devices that are checked out Nexus4 355136052540492 & Galaxy Nexus 355136058992614 [20:34:46] (03CR) 10Yuvipanda: "Very nice solution! Minor nit." (031 comment) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/145322 (https://bugzilla.wikimedia.org/65606) (owner: 10Dbrant) [20:35:07] (03PS3) 10Dbrant: Don't show current saved-page title being refreshed. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/145410 [20:35:37] (03CR) 10Yuvipanda: [C: 032] Don't show current saved-page title being refreshed. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/145410 (owner: 10Dbrant) [20:35:45] YuviPanda: lol I knew you've make a comment about that name [20:35:49] *you'd [20:35:51] dbrant: :D [20:36:03] (03Merged) 10jenkins-bot: Don't show current saved-page title being refreshed. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/145410 (owner: 10Dbrant) [20:37:37] YuviPanda: how about "PlainPasteEditText". The EditText itself may not be plain-text (cf. syntax highlighting) [20:37:48] dbrant: ah, that makes sense, yeah [20:38:16] YuviPanda: and yes, I tested by copying from Browser [20:38:23] dbrant: cool [20:39:40] (03PS2) 10Yuvipanda: Add graphics and explanations for History and Saved Pages. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/145355 (owner: 10Dbrant) [20:41:42] (03CR) 10Yuvipanda: [C: 032] "Nice" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/145355 (owner: 10Dbrant) [20:42:08] (03Merged) 10jenkins-bot: Add graphics and explanations for History and Saved Pages. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/145355 (owner: 10Dbrant) [20:42:24] (03PS3) 10Dbrant: Strip text formatting when pasting into text fields. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/145322 (https://bugzilla.wikimedia.org/65606) [20:47:32] (03PS4) 10Yuvipanda: Strip text formatting when pasting into text fields. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/145322 (https://bugzilla.wikimedia.org/65606) (owner: 10Dbrant) [20:47:44] dbrant: testing + merging in a bit :) [20:48:06] YuviPanda: thx! [20:55:43] (03PS11) 10Yuvipanda: During edit save, describe IP edit and offer login if appropriate. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/143156 (owner: 10Dr0ptp4kt) [20:55:59] (03CR) 10Yuvipanda: [C: 032] Strip text formatting when pasting into text fields. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/145322 (https://bugzilla.wikimedia.org/65606) (owner: 10Dbrant) [20:56:26] (03Merged) 10jenkins-bot: Strip text formatting when pasting into text fields. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/145322 (https://bugzilla.wikimedia.org/65606) (owner: 10Dbrant) [20:56:57] dbrant: ^ all done, I think :) [20:57:12] YuviPanda: yay :D [20:57:21] back to night mode... [20:57:48] :) y6ay [20:57:49] yay [21:03:36] bearND: re: tags for the release process. 1. Tag everything with release/, 2. if fixes need to be backported, *then* create a branch, cherry-pick fixes, and then tag again with new release name [21:03:41] bearND: thoughts? [21:05:55] YuviPanda: that sounds good to me [21:07:05] bearND: cool. let me add it to the doc [21:08:28] (03PS12) 10Dr0ptp4kt: During edit save, describe IP edit and offer login if appropriate. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/143156 [21:08:53] YuviPanda: fied small bug ^ looks okay to me now [21:09:30] YuviPanda: i assume the branches + tags are not just local ones. So, please add some blurp as to how to get that through Gerrit [21:10:02] 3Wikipedia App / 3Android App: ConcurrentModificationException in org.wikipedia.concurrency.SaneAsyncTask.onCatch - 10https://bugzilla.wikimedia.org/67809#c4 (10Alex Monk) Should be fixed then? [21:13:48] bearND: ah, yeah, will be on gerrit, yes [21:14:03] dr0ptp4kt: ah, cool. Now to wait for dbrant or bearND to CR that :) [21:15:02] dbrant or bearND, would you be able to spare 2-5 minutes on https://gerrit.wikimedia.org/r/143156 ? [21:15:31] dbrant and bearND that's the one YuviPanda and i have been tinkering on [21:15:40] dr0ptp4kt: looking [21:15:54] bearND: thx cc dbrant YuviPanda [21:16:39] cool [21:17:39] dr0ptp4kt: YuviPanda: why https://#login? and not a custom protocol like, activity://login? [21:17:59] bearND: good question, no reason to not use activity://login [21:18:01] 3Wikipedia App / 3Android App: ConcurrentModificationException in org.wikipedia.concurrency.SaneAsyncTask.onCatch - 10https://bugzilla.wikimedia.org/67809#c5 (10Dan Garry) 5PATC>3RESO/FIX (In reply to Alex Monk from comment #4) > Should be fixed then? Indeed. [21:18:13] bearND: activity://LoginActivity even [21:18:21] YuviPanda: yeah, even better [21:18:30] bearND: yeah, let me amend. [21:19:39] YuviPanda: great. [21:40:19] (03PS13) 10Yuvipanda: During edit save, describe IP edit and offer login if appropriate. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/143156 (owner: 10Dr0ptp4kt) [21:41:47] (03PS1) 10Kaldari: Improvements for viewing mobile site on very small screens (<=280px) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/145443 [21:43:38] (03PS2) 10Kaldari: Improvements for viewing mobile site on very small screens (<=280px) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/145443 [21:44:45] (03CR) 10MaxSem: [C: 032] Add right- and action- lang key for permission [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/143334 (https://bugzilla.wikimedia.org/67352) (owner: 10Florianschmidtwelzow) [21:45:35] (03Merged) 10jenkins-bot: Add right- and action- lang key for permission [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/143334 (https://bugzilla.wikimedia.org/67352) (owner: 10Florianschmidtwelzow) [21:49:26] (03CR) 10MaxSem: [C: 032] Making SVG compression smarter in pre-commit hook [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/143684 (owner: 10Kaldari) [21:50:40] (03Merged) 10jenkins-bot: Making SVG compression smarter in pre-commit hook [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/143684 (owner: 10Kaldari) [21:55:07] tfinc: Only one story point left in to do for the current sprint! [21:55:09] tfinc: dat velocity [22:11:19] yurikR2, is it possible to use JsonConfig in NS_MEDIAWIKI? I don't want to create a new namespace just for 1-2 pags [22:11:55] MaxSem, i haven't tried expanding existing namespace, but i think it should be fairly easily doable [22:12:13] because i already have all the code for partial/subnamespaces [22:12:19] i will take a look later tonight? [22:12:29] thanks! [22:13:11] Deskana: make sure that backlog is ready to go [22:13:44] tfinc: I'd like stories to be pulled from the next sprint (which I am working on populating right now) [22:13:49] tfinc: I will communicate this. [22:13:58] Deskana: makes sense [22:14:29] Just hammering our analytics dashboard stuff with Yuvi [22:15:09] yay dashboards [22:36:16] dbrant|brb: Sent you an invite for link color and 1 other small change [22:39:50] 3MobileFrontend / 3General/Unknown: Mobile is somehow sending API requests that ask for text/html content - 10https://bugzilla.wikimedia.org/67426#c6 (10Oliver Keyes) 5NEW>3RESO/FIX It looks like the bug is in fact not MobileFrontend, but instead PHP. We all knew the language was a big collection of bugs... [22:44:27] jgonera: kaldari|2: RFC round 2 for Trevors redo skin framework. would be good to have you there [22:44:35] jdlrobson: --^ [22:44:49] tfinc, thanks, forgot about it again, I have to reconfigure my calendar somehow [22:53:16] 3Commons App / 3Android: [Android] Populate {{Information}} from EXIF tags for JPEGs always - 10https://bugzilla.wikimedia.org/45909#c2 (10phoebe) Example: I uploaded https://commons.wikimedia.org/wiki/File:Dahlia_garden_in_golden_gate_park_2.jpg and https://commons.wikimedia.org/wiki/File:Dahlia_garden_in_g... [23:04:30] mhurd brion MaxSem guys, this is Ulf, good to meet you today! Just got a Gerrit account, will try to find the checkout URL for the upcoming iOS app ;) [23:04:46] :) [23:04:53] * brion waves [23:04:54] :D [23:04:58] if0xx: awesome!!! [23:05:39] I take it you prefere pull reqs to Gerrit rather then GitHub? [23:09:08] Deskana: btw, one thing missing from the 36 board is search improvements, is the biggest set of complaints now (on OTRS) [23:09:18] specifically searching for 'beatles' does not catch 'the beatles' [23:09:37] I talked to the search folks, is doable with a new API from them, but we need to prioritize it and make it happen. + more backend cards! :) [23:09:43] if0xx: no strong preference - either is easy on our end [23:09:50] (03PS1) 10Brion VIBBER: Work in progress: saved pages & recent 'empty' icons/texts [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/145461 [23:12:15] thanks Monte, will try Github then & get back to you guys. Finger crossed for review! #iosreviewtime looks like 6 day-ish ... [23:13:12] dbrant: btw, did anything come out of the design meeting about page styling improvements? [23:13:18] if so, can you mail out? [23:13:21] Deskana: ^ [23:13:49] YuviPanda: We separated the cards and split them up into two pieces [23:14:25] vbamba: ah, https://trello.com/c/pxzofz2d/93-first-fold-styling? [23:14:36] Dan has created a card for disambiguation notice cleanup. We can discuss that + lead image separately. [23:14:42] YuviPanda: Yes correct [23:14:43] vbamba: cool, ty [23:15:31] Deskana: should I redo the card to be 'style disambig links properly' and put an estimate on it? Android TODO is otherwise empty :) [23:16:17] brion: https://etherpad.wikimedia.org/p/iOSAppi18nIssues [23:26:02] 3MobileFrontend / 3Feature requests: MobileFrontend watchlist should default to a chronological rather than alphabetical listing - 10https://bugzilla.wikimedia.org/67526#c16 (10MZMcBride) 5RESO/WON>3REOP I've re-opened this bug with a tighter bug summary. Is there a tracking bug about consistency betwee... [23:34:26] YuviPanda: I have to balance user requested features with our goals of increasing active editors. [23:34:32] YuviPanda: s/I/We all [23:34:49] Deskana: true, true. Just wanted to point it out to make sure it's on the radar somewehre [23:34:50] I'm unsure how search improvements fit into that. [23:34:53] dbrant: no seizures, but lack of a reset to default for text size frustrates me a little. [23:35:31] Deskana: I'd consider it a basic readability / reduce-frustration improvement, and I know that the designers were trying to get that done as well. [23:36:38] True. But fulltext search is potentially a massive, multi-sprint endeavour. [23:36:56] Given our sprint schedule, do we have time for that *and* our commitment to ship onboarding improvements in Q1? [23:37:12] Also, I don't like "Color schemes" as the text. It's not color, it's black and white! [23:37:34] Deskana: oh no, not talking about full text search [23:37:45] Deskana: just 'full article title' search. intitle: essentially [23:37:52] ragesoss: hmm, noted. I'll consult with designers. This isn't totally finalized yet. [23:37:53] since that's what most of the complaints are about. [23:38:09] ragesoss: lol I agree about "color theme". It could just say "Theme", I suppose [23:38:21] YuviPanda: Interesting. More tightly scoped, true. Potentially tricky from a product standpoint too, but less so. [23:38:38] Deskana: indeed, since there's no user visible change other than 'oh, it found The Beatles when i typed beatles, nice' [23:38:58] +1 to "Theme" [23:39:14] Deskana: so it's mostly just harassing the search devs until they add that API (I was told by them it wasn't too hard, the feature already exists just isn't exposed in a friendly way), and then swap out the search code [23:39:25] Which API? [23:39:30] Not OpenSearch, right? [23:39:43] list=search? [23:40:02] Deskana: no :) Yes, but more cacheable than now to improve performance for our use case [23:40:17] Right, that was what I was worried about. [23:40:17] which would be just introducing a new endpoint and setting appropriate varnish tags [23:40:36] Right, if Nik and Chad have considered the potential search cluster meltdown then that's cool. :P [23:40:53] Deskana: :D [23:41:01] dbrant: There's something... weird with that APK you sent me. [23:41:13] Currently says "change font and theme" in overflow, but the option box says "text size" and "color scheme". Pick one set of terms. [23:41:29] ragesoss: that's not the latest apk [23:41:37] Deskana: do tell! [23:41:38] Really? [23:41:41] dbrant: It says it's "2.0-alpha-2014-07-02" in the About menu. Is that correct? [23:41:52] dbrant: Because it seems to not include any of the changes you said it does. [23:42:06] dbrant: The design's the same, and I'm still getting the seizure effect. [23:42:44] dbrant: I just installed from your link in email. [23:42:44] Deskana: well I didn't bump the version number, so that's expected... but the design should have changed. [23:42:49] Deskana: are you sure it's not you? :) [23:42:55] (the seizures I mean) [23:43:06] Deskana: ragesoss: let me make a build with a bumped version number... [23:43:20] brb carbamazepine [23:43:23] :P [23:44:01] YuviPanda: It could be. If it was just the version number I'd say it was. But the design is exactly the same and the seizure thing is still happening, so I'm not sure the APK is right. [23:44:22] I was mostly just joking, since you were the only one reporting seizures :) [23:44:34] it's past 5AM, I've given up trying to productively write code. [23:44:43] Haha [23:48:22] dbrant: btw, we should create a 'scratch' or some such folder to put these apks in I guess [23:48:50] dbrant: maybe this is fixed in the real latest version, but mine opens to a blank view instead of main page, and all overflow options are grayed out until I load an article. [23:49:26] ragesoss: that's whack [23:49:33] ragesoss: I don't get that at all. [23:49:35] :) [23:50:16] I close the app... Not even hard close... And then reopen, and it's blank. [23:50:33] Deskana: btw, left a message for you on https://trello.com/c/lADtYeQl/7-as-a-user-i-d-like-the-start-of-an-article-to-be-formatted-better-so-the-articles-are-more-readable-disambiguation-styling-fix [23:50:45] http://releases.wikimedia.org/mobile/android/wikipedia/scratch/wikipedia_20140710_194600.apk [23:50:54] Deskana: ragesoss: ^^^ [23:51:00] Click [23:51:51] Problem gone. [23:51:57] * Deskana installs. [23:52:25] And design and copy for font / theme are better. [23:52:42] Full width for that is good. [23:52:51] Same here. [23:53:03] Let me try and have a seizure. [23:53:14] Copy is still font vs text size. [23:53:26] No more seizures! [23:53:27] \o/ [23:53:31] well look at that [23:53:47] Deskana: that'll be $100 please [23:53:57] Haha [23:54:03] YuviPanda: You'll fit in well here in America. [23:54:10] :) [23:54:10] Deskana: :D [23:54:18] ragesoss: Thanks for testing with us. :) [23:54:35] :) [23:55:22] As usual, I'm testing while watching my kids in the bath. [23:55:23] kaldari|2: yt? [23:55:31] kaldari|2: small question? [23:55:37] hmm, I can just check Disambiguator code... [23:56:16] ragesoss: just don’t test if our new updates make the phone waterproof [23:56:20] cause…. they won’t. [23:57:21] Will they fix my Nexus 7, which I sat on last night? [23:57:21] MaxSem, around? [23:57:28] yep [23:57:48] *sigh [23:58:05] MaxSem, what's the best way to check if a namespace is registered? E.g. there is a contenthandler associated with it (even if its default) [23:58:22] i see $wgExtraNamespaces and $wgCanonicalNamespaceNames