[00:00:49] yurikR, MWNamespace::getValidNamespaces() [00:01:45] MaxSem, yes, it calls getCanonicalNamespaces which includes the <0 ns [00:01:51] thx :) [00:02:04] but then filters them out [00:03:55] MaxSem, yes. The problem is that in order for JC to tell if it needs to add a namespace to the global namespace, it needs to know any other extensions have added that same namespace, and if not, add it as part of getCanonicalNamespaces() :) [00:04:37] mmm, and it will create cache that will need to be busted [00:05:04] check $wgExtraNamespaces? [00:05:25] it's usually easy to tell if ns is core:) [00:05:27] yep. it can be solved two ways - trust the user (if nsname = false, assume someone else added it), [00:05:46] so it will be up to the configurator to set nsname=false [00:06:16] or another way - analyze core namespaces (via $wgCanonicalNamespaceNames variable [00:06:32] and also check if anyone has added it to &$namespaces in onCanonicalNamespaces [00:07:12] oh, actually getCanonicalNamespaces() already adds everything it knows to that array [00:07:47] thx [00:10:42] dbrant: Deskana am off to sleep! Will CR the Night mode patches tomorrow :) [00:10:51] YuviPanda: ok! [00:11:01] Deskana: and also remember I hope to close out the release plan by Monday, so do put in your thoughts before then :) [00:19:14] oh good, i’ve memorized how to set my phone from arabic back to english [00:19:16] *whew* [00:19:30] they really need an icon on some of those settings :) [00:19:33] haha [00:36:25] YuviPanda|zzz: Sure. [00:49:18] Anyone Android app people around? got a quick question [00:52:13] Krenair: sup? [00:52:40] How easy is it to point it at my local wiki? To test things like blocking exceptions [00:54:33] 3Wikipedia App / 3Android App: Password changes? - 10https://bugzilla.wikimedia.org/67539#c1 (10Alex Monk) (In reply to Alex Monk from comment #0) > There appears to be no link to the password reset form (assuming the app has > one) from the login form. Depends on bug 30788 [00:57:01] Krenair: hmmm. Good question. Never tried that. The first thing I would try to change is WikipediaApp.getPrimarySite() [00:57:26] Krenair: but there may be more to it [00:57:49] MobileFrontend is presumably a dependency? [00:58:00] so for example I don't use language subdomains [00:59:43] Krenair: yeah, switching languages would obviously not work. Noone is forcing you to call getPrimaryLanguage() inside getPrimarySite(). [01:03:21] Okay, thanks bearND [01:03:47] I'll fiddle with that... probably tomorrow (aka later) [01:05:14] (03CR) 10Kaldari: "Hmmm, I thought this was working when I tested it, but now it doesn't seem to be working." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/143797 (https://bugzilla.wikimedia.org/66678) (owner: 10Kaldari) [01:08:52] Krenair: The more difficult part is to get the Api calls not to include the '.m" portion in the URI. That part is in the java-mwapi library. [01:10:32] Krenair: I changed getPrimarySite() implementation to just use primarySite = new Site("www.mediawiki.org"); then I got a network error since it tried to talk to https://www.m.mediawiki.org/w/api.php [01:11:47] bearND, you put the .m part in java-mwapi...? [01:13:10] (03PS7) 10Dbrant: Implement Theme/Font chooser. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/144987 [01:16:51] Krenair: sorry, i was wrong. it's not that bad, it's actually in the app, so should be easier to change [01:17:23] I was going to say putting stuff like that into a generic MW API library sounds wrong :) [01:17:23] Krenair: it's in the Site class [01:17:29] okay, thanks [01:23:38] Krenair: ok, got it working with two changes in WikipediaApp: (1) as mentioned before, change getPrimarySite() implementation to just use primarySite = new Site("http://www.mediawiki.org/"); /* replace with your sire of course */ and (2) set FALLBACK = true; instead of false. [01:24:16] bearND, requiring MobileFrontend, right? [01:25:16] Krenair: I think so but am too new to know for sure [01:25:59] Krenair: yeah, actually pretty sure since we use mobileview action, duh [01:26:33] Krenair: unless you want to change that, too. But I think that's more trouble to deal with than it's worth it [01:26:49] yeah... not planning to change that just to test some things [01:26:51] :) [01:26:54] but thanks bearND [03:25:17] 3MobileFrontend / 3General/Unknown: Many Difficulties in Mobile Display of Hebrew WIkisource - 10https://bugzilla.wikimedia.org/66958#c11 (10Daniel) Sorry. I meant if you push on it with your finger. But something has changed now I see anyway. It used to be that there would appear a dotted red line above t... [06:05:47] 3MobileFrontend / 3General/Unknown: MobileFrontend: User right "mf-uploadbutton" is missing message (unit test failure) - 10https://bugzilla.wikimedia.org/67352 (10Florian) 5PATC>3RESO/FIX [12:38:31] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/144987 (owner: 10Dbrant) [12:52:51] (03CR) 10Siebrand: [C: 031] "L10n reviewed." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/145461 (owner: 10Brion VIBBER) [13:06:04] (03CR) 10Siebrand: [C: 031] "L10n reviewed." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/143156 (owner: 10Dr0ptp4kt) [13:55:03] dbrant: I'm still having that issue where the app opens to a blank page. It happens when I exit by pressing Back enough times. [13:55:21] I'll file a bug. [13:55:54] ragesoss: to be clear, is this only with the latest build, or does it also happen with the production version? [13:56:14] only in the latest. [13:56:19] doesn't happen on the beta. [13:56:44] the first time it happened was yesterday when I installed the not-really-the-latest alpha. [13:57:05] I thought it was gone when I tried the latest alpha, but I think I was just not triggering it because I wasn't using Back. [13:58:32] ragesoss: hmm, I'll need the precise steps to reproduce. I'm not getting it on my device [14:00:37] dbrant: want me to try clearing app data? it happens consistently for me in this alpha: if I use the app, go through a series of pages, and then exit by pressing back enough times to back through all those pages and finally close the app, then when I reopen it, it doesn't load an article. [14:02:19] ragesoss: (i'm just thinking how that could logically happen in the code...) yes, try clearing app data [14:04:25] dbrant: when I logged in after clearing data, I ended up on the same blank view: no main page loaded. [14:04:59] and same behavior is present when I exit via Back. [14:06:05] 3Wikipedia App / 3Android App: If app is exited by pressing Back, it loads no article when re-opened - 10https://bugzilla.wikimedia.org/67854 (10Sage Ross) 3NEW p:3Unprio s:3normal a:3None In the latest alpha build as of last night, I often end up with no article being loaded. This happens consisten... [14:07:32] 3Wikipedia App / 3Android App: If app is exited by pressing Back, it loads no article when re-opened - 10https://bugzilla.wikimedia.org/67854#c1 (10Sage Ross) Same thing happens if I clear data and then skip the login (so it's probably not related to me having admin rights). [14:17:41] ragesoss: could you possibly provide a Logcat trace during this behavior? (do you know how to do that?) [14:18:03] I can't reproduce on any of my devices :( [14:18:09] dbrant: I can do that. [14:18:23] anything in particular to filter for, or do you just want the full stream? [14:18:29] full [14:29:40] stupid USB cables. you never can tell whether one will actually work for data transfer. [14:29:52] dbrant: logcat in your email. [14:30:28] ragesoss: terrific; thanks! [15:41:02] * YuviPanda waves at dbrant|brb [15:41:04] and bearND [15:41:16] an attempt to 'fix' my sleep cycle went slightly awry, and I just woke up. oh well [15:42:22] hey YuviPanda [15:55:45] dbrant: CRing night mode patch now, think it shall get merged soon :) [15:56:04] YuviPanda: smashing. [16:02:03] ragesoss: I think I'm zeroing in on it... will you have time to run through a test build in a bit? [16:02:14] dbrant: sure. [16:02:21] * dbrant reads the tea leaves... [16:05:12] (03CR) 10Yuvipanda: [C: 032] Implement Theme/Font chooser. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/144987 (owner: 10Dbrant) [16:05:19] dbrant: great work :) [16:05:30] YuviPanda: hot dawg! ty [16:06:37] :D [16:06:51] dbrant: no seizures in this one, and I suspect ragesoss's bug is unrelated? related to onboarding, perhaps [16:07:13] YuviPanda: actually, the bug may be related. I think I've almost got it. [16:07:20] dbrant: we also need to EL this. Want to take that up after? [16:07:29] YuviPanda: yep [16:13:57] (03Merged) 10jenkins-bot: Implement Theme/Font chooser. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/144987 (owner: 10Dbrant) [16:17:59] ragesoss: https://releases.wikimedia.org/mobile/android/wikipedia/scratch/wikipedia_20140711.apk [16:18:05] ragesoss: for your consideration [16:19:37] wikipedia/src/main/java/org/wikipedia/PageTitle.java: "%1$s://%2$s/wiki/%3$s%4$s", [16:19:37] wikipedia/src/main/java/org/wikipedia/page/LinkHandler.java: if (href.startsWith("/wiki/")) { [16:19:37] wikipedia/src/main/java/org/wikipedia/page/LinkHandler.java: if (authority != null && Site.isSupportedSite(authority) && uri.getPath().startsWith("/wiki/")) { [16:19:37] wikipedia/src/main/java/org/wikipedia/Site.java: * @param internalLink Internal link target text (eg. /wiki/Target). [16:19:40] wikipedia/src/main/java/org/wikipedia/Site.java: return new PageTitle(internalLink.replace("/wiki/", ""), this); [16:19:57] Hmm... You're special-casing 'wiki/'? :/ [16:20:34] Krenair: yeah, easiest way to special case out links in emails and such [16:20:36] to diffs, etc [16:20:40] which use the index.php format [16:20:58] There has got to be a proper way to do that. [16:21:30] Krenair: not in Android, sadly, which only supports globs for 'can this application open this URL?' [16:21:35] dbrant: that did it. and there's a reset button for text size too! [16:22:48] ragesoss: fantastic. your diligence is greatly appreciated! [16:22:57] likewise! [16:26:35] (03PS1) 10Dbrant: Fix theme-change bug on devices that like to preserve Intent extras. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/145579 (https://bugzilla.wikimedia.org/67854) [16:27:38] YuviPanda: ^ fixes ragesoss's bug [16:27:47] dbrant: cool! [16:28:03] YuviPanda: is https://gerrit.wikimedia.org/r/#/c/143156 good to go? [16:28:15] (03CR) 10Yuvipanda: [C: 032] Fix theme-change bug on devices that like to preserve Intent extras. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/145579 (https://bugzilla.wikimedia.org/67854) (owner: 10Dbrant) [16:28:15] dbrant: code looks sane to me, and considering ragesoss has tested... [16:28:36] dr0ptp4kt: yes, I implemented the change bearND suggestd [16:28:37] (03Merged) 10jenkins-bot: Fix theme-change bug on devices that like to preserve Intent extras. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/145579 (https://bugzilla.wikimedia.org/67854) (owner: 10Dbrant) [16:29:28] Hmm... Some strange errors in the log when I try those changes suggested yesterday [16:29:31] 07-11 17:27:35.789 16149-16182/org.wikipedia I/dalvikvm﹕ Could not find method com.squareup.okhttp.internal.http.HttpsURLConnectionImpl$HttpUrlConnectionDelegate.getContentLengthLong, referenced from method com.squareup.okhttp.internal.http.HttpsURLConnectionImpl.getContentLengthLong [16:29:31] 07-11 17:27:35.789 16149-16182/org.wikipedia W/dalvikvm﹕ VFY: unable to resolve virtual method 10544: Lcom/squareup/okhttp/internal/http/HttpsURLConnectionImpl$HttpUrlConnectionDelegate;.getContentLengthLong ()J [16:29:31] 07-11 17:27:35.789 16149-16182/org.wikipedia D/dalvikvm﹕ VFY: replacing opcode 0x6e at 0x0002 [16:29:31] 07-11 17:27:35.789 16149-16182/org.wikipedia I/dalvikvm﹕ Could not find method com.squareup.okhttp.internal.http.HttpsURLConnectionImpl$HttpUrlConnectionDelegate.getHeaderFieldLong, referenced from method com.squareup.okhttp.internal.http.HttpsURLConnectionImpl.getHeaderFieldLong [16:29:35] 07-11 17:27:35.789 16149-16182/org.wikipedia W/dalvikvm﹕ VFY: unable to resolve virtual method 10557: Lcom/squareup/okhttp/internal/http/HttpsURLConnectionImpl$HttpUrlConnectionDelegate;.getHeaderFieldLong (Ljava/lang/String;J)J [16:29:39] oh, that's quite a lot for an IRC paste. sorry [16:29:57] Krenair: what are you using to edit? IntelliJ? or just regular editors? [16:30:07] IntelliJ [16:30:17] running the app on my phone from there [16:30:53] Krenair: does this crash the app? [16:31:09] no, just can't reach the network [16:31:20] bearND: able to +2 https://gerrit.wikimedia.org/r/#/c/143156 cc YuviPanda [16:31:23] ? [16:31:49] the changes were basically replacing getPrimaryLanguage() + ".wikipedia.org" in getPrimarySite with "http://192.168.1.243/MediaWiki/Git/core/" and setting FALLBACK = true [16:31:58] Krenair: hmm, right, so that shouldn't affect things much. [16:32:19] Krenair: so, try right clicking on the project name, 'maven' -> 'reimport'? [16:32:22] and see if that fixes things? [16:35:02] doesn't seem to have fixed it [16:35:14] ah, hmm [16:35:29] Krenair: are you sure the network unreachability is because of that? can you hit that url from the browser on your phone? [16:36:24] YuviPanda, I can hit it from Chrome on the phone, get the web UI [16:36:29] dr0ptp4kt: when i'm done hitting my head against the wall [16:36:33] Krenair: hmm, right. weird. [16:36:46] Krenair: I've to run to get some food now, I'll help debug when back [16:36:52] ok, thanks [16:37:21] Krenair: OkHttp put out a new version that breaks API compat (and is versioned appropriately), wonder if that is the cause [16:37:33] bearND: LOL. practicing for soccer/football? [16:37:56] dr0ptp4kt: no, just a weird issue with ViewPagers [16:39:05] bearND: you working on tabbed browsing?! :) [16:40:02] dr0ptp4kt: no, I'm working on a references display that can swipe between multiple references. I can't see the ref text anymore [16:40:27] bearND: ah. oy [16:41:09] dr0ptp4kt: I'm going to create a separate patch for that so that maybe YuviPanda or dbrant can take a look [16:42:09] (03PS14) 10Dbrant: During edit save, describe IP edit and offer login if appropriate. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/143156 (owner: 10Dr0ptp4kt) [16:45:48] dr0ptp4kt: YuviPanda: it looks good to me... shall I +2? [16:50:27] (03PS1) 10BearND: [WIP] Swipe between nearby references [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/145585 [16:50:45] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Swipe between nearby references [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/145585 (owner: 10BearND) [16:51:39] dbrant: yes, please [16:51:53] bearND: you may need a manual rebase, since my (ginormous) theme patch went through [16:52:10] dbrant: yeah [16:52:40] MaxSem: hi, made a patch for you, take a look. [16:52:52] bearND: sure [16:53:28] (03CR) 10Dbrant: [C: 032] During edit save, describe IP edit and offer login if appropriate. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/143156 (owner: 10Dr0ptp4kt) [16:53:42] YuviPanda, also, with that /wiki/ stuff, I wouldn't be surprised if some of that broke on any MW page including that magic string in it's title [16:53:46] dbrant: thanks. i feel better for your users :) [16:53:54] s/yours/ours/ [16:53:59] Krenair: magic strings? [16:54:19] dr0ptp4kt: I, as well! [16:54:20] "/wiki/" [16:54:29] Krenair: it looks for the prefix [16:54:39] not 'contains' [16:55:10] YuviPanda, even in Site::titleForInternalLink ? [16:55:19] Site.titleForInternalLink* even [16:55:34] Krenair: bah, good catch [16:55:49] Anyway, MediaWiki exposes the article path for a reason :p [16:56:08] You can see it on Special:Version and probably get it from the API somewhere [16:56:17] Krenair: true, you can get it from siteinfo, I think [16:56:25] that sounds reasonable [16:56:34] Krenair: but how often do you update it is the question. on every session sounds wasteful to me [16:57:00] plus, one of the early decisions made was that while we'll make an effort to make this not be Wikipedia centric, we won't hold ourselves to it [16:57:03] yurik, sure - in a sec [16:57:22] dbrant: hmm, i rebased locally, and now it's missing @color/nav_text [16:58:15] Yeah, action=query&siprop=general&format=jsonfm gives it under query.general.articlepath. It also provides variantarticlepath which I imagine is used on the language variant wikis [16:58:21] bearND: hmm, I have it in my current Master... [16:58:58] Krenair: yeah, it does. We need to add variant support anyway... [16:59:01] YuviPanda, I'm not saying this is some -major- bug that breaks the entire thing that needs fixing ASAP. [16:59:03] at some point... in the future. [16:59:13] Krenair: oh I understand. I'm just trying to explain the original rationale :) [16:59:22] yeah, I understand that completely [16:59:34] back later [16:59:36] Krenair: the previos phonegap app I tried to be far more Wiki agnostic, and that created troubles at points and it ended up being weird-in-the-middle [17:00:36] (03PS1) 10Dbrant: Fix possible crash when returning to Preview after Login. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/145589 [17:00:55] dbrant: yeah, i see it. need to redo the rebase somehow [17:01:39] bearND: sorry, I know my patch was a bit too 'widespread' :( [17:08:01] (03PS4) 10BearND: [WIP] Show references without scrolling [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/145225 [17:08:03] (03PS2) 10BearND: [WIP] Swipe between nearby references [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/145585 [17:08:33] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Swipe between nearby references [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/145585 (owner: 10BearND) [17:09:21] dbrant: YuviPanda: rebased my patches. The 2nd one has some weird issues. can one you take a look. it's probably something stupid and simple. I can't see the references text anymore once it's inside the ViewPager [17:11:57] bearND: looking... [17:12:37] dbrant: going to amend a simple js thing to make jslint happy but it shouldn't change anything on the Java side [17:12:57] (03PS3) 10BearND: [WIP] Swipe between nearby references [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/145585 [17:18:11] (03CR) 10Dr0ptp4kt: "Given that stable only shows the Watchlist icon for devices at the intersection of no/RL-impaired JS && small screen size, this works. Oth" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/145443 (owner: 10Kaldari) [17:18:39] (03CR) 10Dr0ptp4kt: [C: 031] "Er, I meant +1 code review." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/145443 (owner: 10Kaldari) [17:21:00] (03CR) 10Kaldari: "The watchlist star actually works without JS. According to Jon, the issue here is primarily one of screen space/layout." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/145443 (owner: 10Kaldari) [17:21:02] (03CR) 10Jdlrobson: [C: 031] "Leaving at +1 as I'm not sure whether Juliusz would prefer we go down a completely mobile first approach to this." (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/145443 (owner: 10Kaldari) [17:33:40] (03PS1) 10Mhurd: Small refactorings. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/145594 [17:33:46] brion: ^ [17:33:58] \o/ [17:37:07] Deskana: you there? [17:47:17] baack! [17:56:48] (03CR) 10Mhurd: "fullImageLink.href = '';" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/145424 (owner: 10Brion VIBBER) [17:56:53] (03CR) 10Brion VIBBER: [C: 032 V: 032] "no explosions \o/ scrolls nice on 3gs" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/145594 (owner: 10Mhurd) [17:57:09] (03CR) 10MaxSem: Allow mixing of non-JC pages in the same namespace (031 comment) [extensions/JsonConfig] - 10https://gerrit.wikimedia.org/r/145484 (owner: 10Yurik) [18:00:23] (03CR) 10MaxSem: [C: 032] Enable customization of footer links [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/144482 (https://bugzilla.wikimedia.org/66350) (owner: 10Florianschmidtwelzow) [18:00:27] MaxSem, was on the phone before, couldn't explain: with the new patch, you can createa profile {name=mySettings, namespace=NS_MEDIAWIKI, nsName=false, isLocal=true} [18:00:53] mhurd: I've brownies for dinner :D [18:01:08] yuvipanda, magic? [18:01:08] yurikR2, yeah - I left a comment already [18:01:11] thanks! [18:01:20] yurikR2: sadly not [18:01:39] * yurikR2 doesn't like chocolate [18:01:50] (03Merged) 10jenkins-bot: Enable customization of footer links [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/144482 (https://bugzilla.wikimedia.org/66350) (owner: 10Florianschmidtwelzow) [18:02:03] dbrant: meeting? [18:02:22] whoops... [18:03:36] hmm, am i in the wrong hangout? [18:03:41] Deskana: YuviPanda ? [18:03:54] * Maryana hangs out sadly with self :( [18:03:56] Maryana: possibly, I don'\t see you [18:04:01] Maryana: https://plus.google.com/hangouts/_/calendar/dGZpbmNAd2lraW1lZGlhLm9yZw.rngl8lb2dl3voo04j1h6ig8hic?authuser=2 [18:04:33] "you're not allowed to join this video call" [18:04:36] :( :( :( [18:05:05] (03PS2) 10Brion VIBBER: File page cleanup hacks [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/145424 [18:05:21] Maryana: I invited you now [18:06:20] thanks YuviPanda :) [18:06:24] Maryana: yw :) [18:07:05] yuvipanda: how did you join the board earlier? [18:07:13] bearND: just went there and added myself :) [18:07:21] bearND: https://trello.com/wikimediafoundation lists everything [18:07:51] yuvipanda: i was already on the board but couldn't find a way to add myself [18:08:07] bearND: aaah, I'm a trello admin as well so that might have been the reason [18:08:39] yuvipanda: ok, that explains. ty [18:11:32] 3MobileFrontend / 3Feature requests: Enable customization of footer - 10https://bugzilla.wikimedia.org/66350#c5 (10Florian) 5PATC>3RESO/FIX @mobile team: should we document the new Hook somewhere? (ExtensionMobileFrontend as subpage or in Manual:Hooks?) [18:23:51] jgonera, what problems do you have with vagrant? [18:28:16] MaxSem, I have to debug it more to pinpoint if the problem lies in iOS safari or using an external ip [18:40:10] Deskana: told you this was the first full sprint where all of Android engineering is fully working on stories :) [18:41:16] Deskana: most of the cards in the backlog board look grayed out. what does that mean? [18:41:52] bearND: That's a card age addon. Old cards go grey. [18:42:19] Deskana: ok, so i can ignore that then [18:42:32] bearND: Deskana I just turned that off [18:42:34] bearND: I may have an answer for you shortly... [18:42:39] Deskana: just noticed. thanks [18:42:45] dbrant: awesome [18:48:23] dbrant: An answer to what? The meaning of life, the universe, and everything? [18:48:45] (03PS4) 10Kaldari: If error occurs while loading VE, load source editor instead [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/143797 (https://bugzilla.wikimedia.org/66678) [18:48:55] * fortytwo_ gives self to Deskana [18:49:00] Deskana: yes... it will take me 7 million years. [18:49:20] dbrant: That's a poorly scoped card then if it's 7 million points. [18:49:39] Deskana: 7 million times 365 [18:50:26] MaxSem: Maryana hey [18:50:37] yo [18:50:44] sup jdlrobson [18:50:53] so Flow and MobileFrontend are not getting along as nice as they could - http://en.m.wikipedia.beta.wmflabs.org/wiki/Talk:Flow_QA [18:51:21] https://bugzilla.wikimedia.org/show_bug.cgi?id=67085 [18:51:40] yeah, noticed that… it looks slightly better than last time i looked at least [18:51:48] 3MobileFrontend / 3stable: HTMLFormatter should never run on Flow pages - 10https://bugzilla.wikimedia.org/67085 (10Jon) a:5Jon>3None [18:52:11] (03PS5) 10Kaldari: If error occurs while loading VE, load source editor instead [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/143797 (https://bugzilla.wikimedia.org/66678) [18:52:22] Maryana: is it possible to prioritise that bug in the mobile sprint? [18:52:41] basically MobileFrontend mangles the HTML trying to apply section collapsing [18:52:46] sure thing :) MaxSem, what are you working on currently? [18:52:58] (03CR) 10Mhurd: [C: 032 V: 032] "Seems to work!" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/145424 (owner: 10Brion VIBBER) [18:53:12] jdlrobson, you mean https://gerrit.wikimedia.org/r/145165 ? ;) [18:53:41] MaxSem: you are a super star :) [18:53:50] jgonera: I switched to a different approach on https://gerrit.wikimedia.org/r/#/c/143797. Now it is using mw.loader's built-in (but undocumented) error handing. [18:53:53] (03PS2) 10Jdlrobson: Only collapse sections on wikitext pages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/145165 (https://bugzilla.wikimedia.org/67085) (owner: 10MaxSem) [18:54:16] MaxSem: i'll take a look and see if that fixes things for Flow [18:54:18] (03CR) 10Mhurd: [C: 032 V: 032] "Makes sense." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/145363 (owner: 10Brion VIBBER) [18:54:40] jdlrobson, have you already switched it to its own content type? [18:54:47] MaxSem: yup [18:54:49] and i can confirm that works :D [18:54:55] content type is flow-board is Flow land [18:55:06] MaxSem: can i merge? [18:55:10] yup [18:55:22] (03CR) 10Jdlrobson: [C: 032] "Works for Flow!" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/145165 (https://bugzilla.wikimedia.org/67085) (owner: 10MaxSem) [18:55:33] YuviPanda: we can't easily add the external link indicators for external references in the TextView. (and we dont want to use a webview for refs). So, probably skip that for now. [18:55:49] bearND: yeah, I agree. [18:57:47] 3MobileFrontend / 3stable: HTMLFormatter should never run on Flow pages - 10https://bugzilla.wikimedia.org/67085 (10Jon) 5PATC>3RESO/FIX [18:58:11] Kaldari, did you ask someone, maybe Roan, why it's undocumented? [18:58:16] (03Merged) 10jenkins-bot: Only collapse sections on wikitext pages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/145165 (https://bugzilla.wikimedia.org/67085) (owner: 10MaxSem) [18:59:59] (03PS2) 10Brion VIBBER: Work in progress: saved pages & recent 'empty' icons/texts [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/145461 [19:00:05] rebase [19:00:10] now to make fixes \o/ [19:00:23] bearND|food: nope, no answer... :( [19:03:24] bearND|food: dbrant|brb Deskana I'm going to go off earlier today, anything you want from me before I do that? [19:07:04] 3Wikipedia App / 3iOS App: iOS App: History is slow to load - 10https://bugzilla.wikimedia.org/67874 (10Kunal Mehta (Legoktm)) 3NEW p:3Unprio s:3normal a:3None Loading the history takes a long time (relatively), about 5 seconds for [[Avatar (2009 film)]]. I'm guessing this is because it tries to loa... [19:09:21] Maryana: http://en.m.wikipedia.beta.wmflabs.org/wiki/Talk:Flow :D [19:10:32] better! [19:10:58] though i still find the lack of buttons disturbing... [19:13:20] YuviPanda: Nope. :) [19:15:06] Maryana: any luck finding that Nexus4 ? [19:15:26] (03PS1) 10Mhurd: Wrapped the 2 section retrieval chunks in blocks. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/145618 [19:15:54] brion: tiny fix ^ [19:16:00] tfinc: will look [19:16:11] thank you [19:19:32] (03CR) 10Yurik: Allow mixing of non-JC pages in the same namespace (031 comment) [extensions/JsonConfig] - 10https://gerrit.wikimedia.org/r/145484 (owner: 10Yurik) [19:19:44] MaxSem, ^ [19:19:51] have you tried using it? [19:25:27] Deskana: alright then, I'm off. cya [19:29:43] vbamba: hey the mock for the more menu (https://trello.com/c/HftLmETl/86-design) still says “mumbo jumbo” … what should it really say? [19:39:17] MaxSem, i might rework it a bit further, not sure if or how, but that patch should be enough to get you started on testing it. [19:39:34] :) [19:42:10] Krinkle: Added a bit of documentation for mw.loader.using. If you want to check for accuracy: https://www.mediawiki.org/w/index.php?title=ResourceLoader%2FDefault_modules&diff=1064610&oldid=1058520 [19:43:08] kaldari: error callback signature is variable. [19:43:22] kaldari: Generally I try to phase that page out. Anything usefu should go to doc.wikimedia.org / document in the code. [19:43:35] can you submit a patch for mediawiki.js? [19:43:43] an example would be nice ther [19:43:44] e [19:44:11] https://doc.wikimedia.org/mediawiki-core/master/js/#!/api/mw.loader-method-using [19:44:16] And it returns a Promise [19:45:18] Krinkle: Having documentation at mediawiki.org is useful for people using the functions on-wiki (who probably wouldn't bother looking at the code) [19:45:39] Krinkle: Sure, I'll add some docs to the code as well [19:46:07] kaldari: I disagree, I'd say either is just as easy to discover. There's links to it from that every page even [19:46:13] the problem is that if you look for loader.using, you miss the link to doc.wikimedia.org which is one section higher.. [19:46:17] onwiki documentation at this level of detail is going away [19:47:14] bound to get outdated, not easily re-usable, not referenced by mw branch/release for third parties. And most important, except for ResourceLoader (hehe) not usually written by the developers and not reviewed nearly enough. [19:47:53] Krinkle: I'm fine with doing away with it. As long as it exists though, people are going to refer to it, so it should be somewhat maintained, IMO. [19:48:28] but maybe better to just remove it altogether [19:48:42] hm... suddenly the code editor doesn't work half the time... [19:48:44] I'd like to reduce that page to only module-level, not property or method level. With a link to API documentation and a short description. maybe a very brief code examplle but thats' imho already too much, can just as easily go into api docs [19:49:05] Krinkle: yeah, that sounds like a good idea [19:50:41] (03PS3) 10Brion VIBBER: Work in progress: saved pages & recent 'empty' icons/texts [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/145461 [19:52:56] (03PS4) 10Brion VIBBER: Saved pages & recent 'empty' icons/texts [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/145461 [19:53:19] (03CR) 10Brion VIBBER: "Updated copy text & padding/spacing per checkin with Moiz." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/145461 (owner: 10Brion VIBBER) [19:59:43] awjr_away: thanks for that last email. Until we can give you a better answer, assume you can annoy me with pings; I'll be following this through to completion. [20:01:48] (03CR) 10Brion VIBBER: [C: 032 V: 032] Wrapped the 2 section retrieval chunks in blocks. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/145618 (owner: 10Mhurd) [20:10:23] (03PS1) 10Brion VIBBER: Update CSS derivative files that didn't get updated before whoops [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/145674 [20:13:10] (03CR) 10Yurik: Simplified config view [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/144652 (owner: 10Yurik) [20:13:15] (03CR) 10Yurik: Validate each admin value individually [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/144651 (owner: 10Yurik) [20:13:20] (03CR) 10Yurik: Comma-separated list view, extra validators [extensions/JsonConfig] - 10https://gerrit.wikimedia.org/r/144650 (owner: 10Yurik) [20:20:30] kaldari, let me know when you hear from someone why this RL behavior is undocumented [20:22:04] jgonera: Apparently the RL module documentation on mediawiki.org is being deprecated in favor or in-code documentation, so it hasn't been kept up to date very well. [20:22:23] kaldari, oh, so JSDuck has documentation for it? [20:22:32] (03CR) 10JGonera: [C: 032] Hygiene: Removing a bunch of old icon CSS that is no longer needed [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/144844 (owner: 10Kaldari) [20:23:32] jgonera: yes, so it's fine really. I just thought it was weird that it wasn't mentioned at all in the mediawiki.org documentation (so I added it there). [20:23:47] kaldari, ok, cool [20:24:55] (03Merged) 10jenkins-bot: Hygiene: Removing a bunch of old icon CSS that is no longer needed [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/144844 (owner: 10Kaldari) [20:25:51] (03CR) 10JGonera: [C: 032] Hygiene: Cleaning up pageaction icon CSS [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/144852 (owner: 10Kaldari) [20:26:32] (03Merged) 10jenkins-bot: Hygiene: Cleaning up pageaction icon CSS [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/144852 (owner: 10Kaldari) [20:28:21] (03CR) 10Mhurd: [C: 032 V: 032] "Yay!" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/145674 (owner: 10Brion VIBBER) [20:29:02] (03CR) 10Mhurd: [C: 032 V: 032] "This looks really sweet!" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/145461 (owner: 10Brion VIBBER) [20:41:00] kaldari, we're positive that https://gerrit.wikimedia.org/r/#/c/144833/4 won't mess up things for zero then? [20:42:57] (03CR) 10JGonera: [C: 04-1] "Small inline comment. Also, are we 100% positive this won't mess up anything for Zero?" (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/144833 (owner: 10Kaldari) [20:43:12] jgonera: Yeah, I tested it with Adam and everything seems to work fine with Zero (dependant on https://gerrit.wikimedia.org/r/#/c/145170/). Honestly, it's a little hacky/fragile, but making the interaction foolproof would require some bigger changes. [20:44:19] ok [20:44:34] then just one inline thing, not sure why we have min-height for details now [20:45:24] sure, I'll reply inline... [20:46:38] (03CR) 10JGonera: "Also, close icon doesn't show up because it's in common/images and less is in modules/" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/144833 (owner: 10Kaldari) [20:46:48] One more thing kaldari ^ [20:48:57] jgonera: ? The CSS for the close icon is in less/common/icons.less [20:49:13] kaldari, oh, right, weird, does the icon show up for you? [20:49:23] I was. Let me check... [20:50:02] (03CR) 10JGonera: [C: 04-1] Syncing mobile blues and greens with official design palette (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/145048 (owner: 10Kaldari) [20:50:32] jgonera: Yeah, shows up for me. Did you make sure all your cache was cleared? [20:50:47] hm, I have cache disabled in Chrome, I'll try again [20:51:05] (03PS1) 10Mhurd: Saved pages and history no entries labels wrapping on. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/145682 [20:52:56] dang. no Yuvi here, either. [20:53:39] (03CR) 10JGonera: [C: 032] If error occurs while loading VE, load source editor instead [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/143797 (https://bugzilla.wikimedia.org/66678) (owner: 10Kaldari) [20:53:57] bearND: so, I'm still not sure what's happening, but I did notice one interesting thing: if you start the app, then change the theme, and then click on a reference, it shows up correctly! [20:55:24] kaldari, the file is called cancel-light.svg but LESS asks for close-light.svg so I'm not sure how it works for you ;) [20:55:41] vbamba: thanks!!! [20:56:06] oops, I forgot to add the new image :P [20:56:18] dbrant: hmm. that's interesting [20:56:44] (03Merged) 10jenkins-bot: If error occurs while loading VE, load source editor instead [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/143797 (https://bugzilla.wikimedia.org/66678) (owner: 10Kaldari) [20:57:17] (03CR) 10Brion VIBBER: [C: 032 V: 032] Saved pages and history no entries labels wrapping on. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/145682 (owner: 10Mhurd) [20:57:41] bearND: (changing the theme simply re-launches the activity, so it's still pretty puzzling) [20:58:19] dbrant: yeah. thanks for the pointer though [21:01:08] (03PS5) 10Kaldari: Promoting MediaViewer to stable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/144833 [21:08:16] (03CR) 10JGonera: [C: 04-1] "One inline. Also, why do we need both close-light and cancel-light?" (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/144833 (owner: 10Kaldari) [21:16:42] (03PS1) 10Brion VIBBER: Project file fix for storyboard localizations [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/145690 [21:17:15] kaldari, have you tested https://gerrit.wikimedia.org/r/#/c/145443/2 on a phone with opera mini? [21:19:39] jgonera: No, do we have one? [21:20:14] kaldari, not sure, but we should definitely have a phone where we could install one, let me check [21:20:29] yeah, max was playing with a crappy old nokia phone yesterday [21:22:30] I've given it to him now [21:24:54] brion: i should prob merge that commit before i mess w/ new i18n strings? [21:27:32] (03CR) 10Dr0ptp4kt: [C: 032] Comma-separated list view, extra validators (033 comments) [extensions/JsonConfig] - 10https://gerrit.wikimedia.org/r/144650 (owner: 10Yurik) [21:27:41] (03CR) 10Dr0ptp4kt: [C: 032] Validate each admin value individually [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/144651 (owner: 10Yurik) [21:27:43] (03Merged) 10jenkins-bot: Comma-separated list view, extra validators [extensions/JsonConfig] - 10https://gerrit.wikimedia.org/r/144650 (owner: 10Yurik) [21:27:46] (03CR) 10Dr0ptp4kt: [C: 032] Simplified config view [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/144652 (owner: 10Yurik) [21:27:50] yei dr0ptp4kt ! [21:27:57] (03Merged) 10jenkins-bot: Validate each admin value individually [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/144651 (owner: 10Yurik) [21:27:59] (03Merged) 10jenkins-bot: Simplified config view [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/144652 (owner: 10Yurik) [21:28:19] dr0ptp4kt, were there any concerns? [21:29:19] (03CR) 10Mhurd: [C: 032 V: 032] "Total success." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/145690 (owner: 10Brion VIBBER) [21:30:19] yurikR2: i think i might rename a variable and, depending on thoughts about the future state, enforce type consistency in simple lists, but those are not blockers and potentially actually don't matter at all. see comments in 144650. looked good, though. i was thinking about whether empty lists should be nulled and not part of the configuration, but i guess sometimes those may have a specific meaning for someone implement in a subclass [21:30:20] validator...so it's not possible to do that arbitrarily, i guess [21:30:57] dbrant: Do you have a build for me yet? :) [21:31:28] dr0ptp4kt, thx. I will look through the comments. [21:31:42] yurikR2: right on. good work [21:31:43] Deskana: almost! I was waiting to squeeze in Vibha's latest color tweaks. [21:31:58] thx for reviewing! [21:32:08] Deskana: very soon [21:33:01] brion: one for the backlog : wrangle all those “lproj” folders into a subfolder : [21:33:07] :) [21:33:20] yeah that’d be nice [21:33:28] they’re multiplying! [21:36:17] kaldari, Opera Mini 4.x was 1.5% in April [21:36:29] 1.6% [21:36:53] jgonera: 1.6% of mobile traffic? [21:36:59] yes [21:38:49] (03CR) 10Yurik: Comma-separated list view, extra validators (033 comments) [extensions/JsonConfig] - 10https://gerrit.wikimedia.org/r/144650 (owner: 10Yurik) [21:38:55] dr0ptp4kt, ^ [21:39:00] answered comments [21:39:55] (03CR) 10JGonera: [C: 04-1] "One small thing inline. Also, we need to check what it looks like on Opera Mini 4.x." (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/145443 (owner: 10Kaldari) [21:39:55] yurikR2: cool, and thx [21:44:16] hmm… was just doing some VE performance testing and noticed that on french wikipedia, i get taken to wikitext editor by default after clearing cookies & data [21:44:38] are we not actually respecting local wiki config for VE editing? i should get taken to VE by default there [21:45:39] jgonera ^^ [21:46:15] err.. and i don't even get the cog to switch to VE in the edit window on frwiki [21:47:12] same on portuguese wikipedia [21:47:41] and spanish :( [21:52:45] (03PS6) 10Kaldari: Promoting MediaViewer to stable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/144833 [21:54:44] jgonera: I think I have everything fixed in the MediaViewer now: https://gerrit.wikimedia.org/r/#/c/144833/ [21:55:22] the sizing of the details and image are now completely dynamic [21:57:34] 3MobileFrontend / 3beta: Option to use VisualEditor not showing up on non-enwiki projects - 10https://bugzilla.wikimedia.org/67892 (10Maryana Pinchuk) 3NEW p:3Unprio s:3normal a:3None In production in beta. Steps to repro: 1. Go to French, Polish, or Russian Wikipedia (where VE should be the default... [21:58:16] That's a feature, not a bug. [21:58:19] * RD hides [22:00:33] 3MobileFrontend / 3beta: Option to use VisualEditor not showing up on non-enwiki projects - 10https://bugzilla.wikimedia.org/67892#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/EShXsKmu [22:00:54] fuuuunny [22:01:10] ignore, derp on my part [22:01:31] 3MobileFrontend / 3beta: Option to use VisualEditor not showing up on non-enwiki projects - 10https://bugzilla.wikimedia.org/67892#c2 (10Maryana Pinchuk) 5NEW>3RESO/INV Derp, helps to enable beta again after you clear your cookies for testing purposes :) [22:01:35] (03CR) 10Kaldari: Syncing mobile blues and greens with official design palette (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/145048 (owner: 10Kaldari) [22:04:31] (03PS4) 10Kaldari: Syncing mobile blues and greens with official design palette [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/145048 [22:05:09] (03CR) 10Kaldari: Syncing mobile blues and greens with official design palette (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/145048 (owner: 10Kaldari) [22:08:22] (03PS1) 10Dbrant: A couple more color/layout tweaks from Designers. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/145705 [22:09:47] Maryana, we should be taking default VE options into account [22:10:02] yeah, we are. i just forgot to switch back into beta after clearing cookies [22:10:17] (03CR) 10Kaldari: Improvements for viewing mobile site on very small screens (<=280px) (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/145443 (owner: 10Kaldari) [22:11:43] (03PS1) 10Dr0ptp4kt: Log when OM slot missing or has unexpected value. [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/145707 [22:12:01] (03CR) 10JGonera: [C: 032] Promoting MediaViewer to stable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/144833 (owner: 10Kaldari) [22:12:30] yurikR2: mind taking a minute to review and +2 https://gerrit.wikimedia.org/r/145707 ? [22:13:35] dr0ptp4kt, it should be merged with the block above - that's where all the logging is happening. Lets keep logging separate from logic [22:15:30] (03PS1) 10Brion VIBBER: Update storyboard strings, qqq files when master files change [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/145708 [22:27:24] (03CR) 10Kaldari: Improvements for viewing mobile site on very small screens (<=280px) (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/145443 (owner: 10Kaldari) [22:30:39] (03CR) 10MaxSem: [C: 032] Allow mixing of non-JC pages in the same namespace [extensions/JsonConfig] - 10https://gerrit.wikimedia.org/r/145484 (owner: 10Yurik) [22:31:38] (03PS2) 10Dr0ptp4kt: Log when OM slot missing or has unexpected value. [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/145707 [22:31:47] yurikR2: ^ like that? [22:32:33] hmm yurikR2 and dr0ptp4kt, why does ZeroBanner does that: $wgExtensionFunctions[] = function() { [22:32:33] global $wgAPIModules; [22:32:33] $wgAPIModules['zeroconfig'] = 'ZeroBanner\ApiZeroBanner'; [22:32:33] }; [22:32:49] why not do this directly? [22:34:10] (03PS3) 10Kaldari: Improvements for viewing mobile site on very small screens (<=280px) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/145443 [22:34:39] dr0ptp4kt, :) I meant not to mix loging code - its ok to have duplicate if() statemnt [22:34:46] as long as its not an expensive check of course [22:35:00] this way they are independent, and logging can later be easily changed/deleted [22:35:13] MaxSem, not sure, historical reasons :) [22:35:24] heh [22:35:40] yurikR2: you're referring to an elseif. will update. yurikR2 you wann respond to MaxSem ? [22:36:00] (03CR) 10Kaldari: "jgonera: I haven't been able to test on Opera Mini 4.x yet. I haven't had any luck getting those older phones charged :(" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/145443 (owner: 10Kaldari) [22:37:56] yurikR2: well, actually, it's not an elseif. it's conceivable it could have obselete flags and be problematic. so a separate if [22:38:46] dr0ptp4kt, i mean in your patch - isStylable is set in the middle of logging block [22:38:50] its ok [22:38:58] i'll fix it and +2 it a bit later [22:39:00] (03PS2) 10Brion VIBBER: Update storyboard strings, qqq files when master files change [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/145708 [22:39:28] (03CR) 10Brion VIBBER: "added the qqq files to the project so they show up in the commit/diff view in Xcode" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/145708 (owner: 10Brion VIBBER) [22:46:00] (03PS3) 10Brion VIBBER: Update storyboard strings, qqq files when master files change [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/145708 [22:48:51] (03CR) 10BearND: [C: 032] "Looks good." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/145705 (owner: 10Dbrant) [22:48:56] (03CR) 10Mhurd: [C: 032 V: 032] "TOTAL VICTORY!" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/145708 (owner: 10Brion VIBBER) [22:53:31] kaldari, SAMSUNG-S8000/S800MXEJA1 SHP/VPP/R5 Jasmine/1.0 Nextreaming SMM-MMS/1.2.0 profile/MIDP-2.1 configuration/CLDC-1.1 SS-Widget/S8000-FM [23:07:09] Deskana: hey! [23:10:45] (03PS1) 10MaxSem: Initialize API directly, not relying on extension functions [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/145717 [23:11:40] yurikR2, ^ [23:12:44] (03CR) 10Yurik: [C: 032] Initialize API directly, not relying on extension functions [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/145717 (owner: 10MaxSem) [23:16:10] (03PS4) 10Kaldari: Improvements for viewing mobile site on very small screens (<=280px) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/145443 [23:22:13] (03PS1) 10Brion VIBBER: Use system language as default wiki search language [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/145719 [23:23:22] (03CR) 10Kaldari: [C: 032] QA: Remove test for dynamic page loading [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/145149 (owner: 10JGonera) [23:23:58] (03CR) 10Krinkle: [C: 032] Initialize API directly, not relying on extension functions [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/145717 (owner: 10MaxSem) [23:24:00] (03Merged) 10jenkins-bot: QA: Remove test for dynamic page loading [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/145149 (owner: 10JGonera) [23:24:05] mhurd do you know if jdlrobson's back? [23:24:11] (03Merged) 10jenkins-bot: Initialize API directly, not relying on extension functions [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/145717 (owner: 10MaxSem) [23:24:17] * jdlrobson waves [23:24:59] violetto: i dont see him [23:25:17] 3Wikipedia App / 3Android App: If app is exited by pressing Back, it loads no article when re-opened - 10https://bugzilla.wikimedia.org/67854#c4 (10Dan Garry) 5PATC>3RESO/FIX Fixed in my current test build. [23:25:21] jdlrobson where's your face [23:25:27] mhurd: thanks for looking! [23:25:36] jdlrobson: do you want to play? [23:26:29] (03CR) 10Krinkle: [C: 032] "(re-submit CR+2 as Jenkins was restarted)" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/145705 (owner: 10Dbrant) [23:26:49] (03CR) 10Krinkle: [C: 032] "(re-submit CR+2 as Jenkins was restarted)" [extensions/JsonConfig] - 10https://gerrit.wikimedia.org/r/145484 (owner: 10Yurik) [23:27:09] violetto: i'm at the sofa come on over [23:27:14] just finishing up some button crap [23:28:05] (03Merged) 10jenkins-bot: Allow mixing of non-JC pages in the same namespace [extensions/JsonConfig] - 10https://gerrit.wikimedia.org/r/145484 (owner: 10Yurik) [23:28:21] (03CR) 10Krinkle: [C: 032] "(re-submit CR+2 as Jenkins was restarted)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/144833 (owner: 10Kaldari) [23:29:34] (03Merged) 10jenkins-bot: Promoting MediaViewer to stable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/144833 (owner: 10Kaldari) [23:31:19] (03Merged) 10jenkins-bot: A couple more color/layout tweaks from Designers. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/145705 (owner: 10Dbrant) [23:46:16] (03PS2) 10Brion VIBBER: Use system language as default wiki search language [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/145719 [23:51:32] (03CR) 10Mhurd: [C: 032 V: 032] "Great!" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/145719 (owner: 10Brion VIBBER) [23:59:01] (03PS2) 10JGonera: WIP: Improve fixed header in overlays on iOS [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/145185