[00:39:56] (03PS1) 10Nemo bis: Fix capitalisation of "Zero" [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/146004 [02:40:46] (03PS7) 10BearND: Show references without scrolling [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/145225 [04:12:49] (03PS8) 10BearND: Show references without scrolling [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/145225 [07:38:37] (03PS1) 10Mhurd: Restyle more and credits menus. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/146034 [08:22:42] (03PS2) 10Mhurd: Restyle more and credits menus. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/146034 [08:48:59] (03PS3) 10Mhurd: Restyle more and credits menus. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/146034 [09:25:42] (03CR) 10Yurik: [C: 032] Fix capitalisation of "Zero" [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/146004 (owner: 10Nemo bis) [09:27:01] (03Merged) 10jenkins-bot: Fix capitalisation of "Zero" [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/146004 (owner: 10Nemo bis) [10:21:03] 3Commons App / 3Android: Undocumented messages in Wikimedia Commons android app - 10https://bugzilla.wikimedia.org/67977 (10Nemo) 3NEW p:3Unprio s:3normal a:3None Context requested for some messages: * https://translatewiki.net/wiki/Thread:Support/About_Wikimedia:Commons-android-strings-multiple_sha... [10:52:04] 3Commons App / 3Android: Message keys containing spaces in Wikimedia Commons android app - 10https://bugzilla.wikimedia.org/67978 (10Nemo) 3NEW p:3Unprio s:3normal a:3None There should be no spaces in keys, only hyphen or underscore. Some messages reported: https://translatewiki.net/wiki/Thread:Tran... [10:57:04] 3Commons App / 3Android: Messages' whitespace excess or escaping Wikimedia Commons android app - 10https://bugzilla.wikimedia.org/67979 (10Nemo) 3NEW p:3Unprio s:3normal a:3None 1) Extra empty line here, with several null diffs across syncs (?): https://translatewiki.net/w/i.php?title=Wikimedia:Commo... [11:01:36] 3Commons App / 3Android: "%d files uploading" should probably be "%1$d" in Wikimedia Commons android app - 10https://bugzilla.wikimedia.org/67980 (10Nemo) 3NEW p:3Unprio s:3normal a:3None Reported at https://translatewiki.net/wiki/Thread:Support/About_Wikimedia:Commons-android-strings-uploads_pending... [11:06:04] 3Wikipedia App / 3Android App: Context needed for some Wikipedia android app messages - 10https://bugzilla.wikimedia.org/67981 (10Nemo) 3NEW p:3Unprio s:3normal a:3None Translators requested message documentation, plus in one case a screenshot if possible and in another (clarifications on how to deal... [11:10:34] 3Commons App / 3iOS (iPhone or iPad): Unwarranted uppercase in four Wikimedia Commons iOS app messages - 10https://bugzilla.wikimedia.org/67982 (10Nemo) 3NEW p:3Unprio s:3normal a:3None https://translatewiki.net/wiki/Thread:Support/About_Wikimedia:Commons-ios-details-deletion-button/en https://transl... [11:12:19] 3Commons App / 3iOS (iPhone or iPad): Context needed for two Wikimedia Commons iOS app messages - 10https://bugzilla.wikimedia.org/67983 (10Nemo) 3NEW p:3Unprio s:3normal a:3None Please add documentation: https://translatewiki.net/wiki/Thread:Support/About_Wikimedia:Commons-ios-catdetail-remove-label... [12:14:16] (03CR) 10Yuvipanda: [C: 04-1] "Haven't tested yet." (032 comments) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/145225 (owner: 10BearND) [12:47:27] (03PS2) 10Yuvipanda: Fix possible crash when returning to Preview after Login. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/145589 (owner: 10Dbrant) [12:48:03] (03CR) 10Yuvipanda: [C: 032] Fix possible crash when returning to Preview after Login. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/145589 (owner: 10Dbrant) [12:50:27] (03Merged) 10jenkins-bot: Fix possible crash when returning to Preview after Login. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/145589 (owner: 10Dbrant) [13:10:18] (03PS1) 10Zfilipin: QA: Fixed TypeError when MEDIAWIKI_USER variable is not set [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/146057 [13:15:13] (03PS1) 10Zfilipin: QA: Deleted empty page file [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/146058 [13:35:38] (03PS1) 10Dbrant: Adapt Captcha handler to night mode. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/146059 [14:06:19] (03PS1) 10Dbrant: Make sure Overflow menu gets properly unregistered from Bus. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/146061 [14:07:20] 3MobileFrontend / 3stable: beta labs: Watchlist "Modified" view shows no results. - 10https://bugzilla.wikimedia.org/67987 (10Chris McMahon) 3NEW p:3Unprio s:3normal a:3None As logged-in user, navigate to Watchlist/Modified, http://en.m.wikipedia.beta.wmflabs.org/w/index.php?title=Special:Watchlist&w... [14:10:49] 3MobileFrontend / 3stable: beta labs: Watchlist "Modified" view shows no results. - 10https://bugzilla.wikimedia.org/67987#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/TPJyM1xl [14:19:43] (03PS1) 10Dbrant: Fix possible crash in LangLinks activity. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/146066 [14:23:49] 3Wikipedia App / 3Android App: Common crash - 10https://bugzilla.wikimedia.org/67718#c5 (10Dmitry Brant) 5NEW>3PATC This should fix the crash mentioned in Comment 4: https://gerrit.wikimedia.org/r/146066 (and the patch in Comment 1 should take care of the original tickets linked in the bug) [14:24:32] 3Wikipedia App / 3Android App: IllegalArgumentException: View not attached to window manager causing crashes - 10https://bugzilla.wikimedia.org/67947#c1 (10Dmitry Brant) 5NEW>3PATC This ought to do it: https://gerrit.wikimedia.org/r/146061 [14:30:30] (03PS2) 10Yuvipanda: Fix possible crash in LangLinks activity. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/146066 (owner: 10Dbrant) [14:30:35] (03CR) 10Yuvipanda: [C: 032] Fix possible crash in LangLinks activity. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/146066 (owner: 10Dbrant) [14:30:50] * YuviPanda waves [14:30:59] (03Merged) 10jenkins-bot: Fix possible crash in LangLinks activity. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/146066 (owner: 10Dbrant) [14:32:02] (03PS2) 10Yuvipanda: Make sure Overflow menu gets properly unregistered from Bus. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/146061 (owner: 10Dbrant) [14:32:09] (03CR) 10Yuvipanda: [C: 032] Make sure Overflow menu gets properly unregistered from Bus. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/146061 (owner: 10Dbrant) [14:33:01] (03Merged) 10jenkins-bot: Make sure Overflow menu gets properly unregistered from Bus. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/146061 (owner: 10Dbrant) [14:33:40] (03CR) 10Yuvipanda: [C: 032] Adapt Captcha handler to night mode. (031 comment) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/146059 (owner: 10Dbrant) [14:34:08] (03Merged) 10jenkins-bot: Adapt Captcha handler to night mode. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/146059 (owner: 10Dbrant) [14:34:17] \o/ [14:38:28] (03PS1) 10Yurik: Further Opera slot logging [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/146071 [14:38:31] dr0ptp4kt, ^ [14:39:00] dbrant: awesome work :) [14:39:25] dr0ptp4kt, re opera, what case do you think we are not covering/overcovering? [14:39:26] YuviPanda: thx! [14:43:24] dr0ptp4kt, sorry, network issues [14:47:33] (03PS7) 10Dbrant: [WIP] Implement syntax highlighting in Edit window. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/137684 [14:50:12] yurikJerusalem: i'll look at the patch after a bit. the existing code merged in master is probably sufficient, but your additional check for slotted traffic that's not tagged on our side adds some good coverage, too. will review later. [15:02:57] (03PS1) 10Dbrant: Slightly better event for unregistering from Bus. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/146073 [15:12:31] (03PS1) 10Yurik: Proper global JS value, domain, always include cfg block in js [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/146076 [15:12:33] (03CR) 10jenkins-bot: [V: 04-1] Proper global JS value, domain, always include cfg block in js [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/146076 (owner: 10Yurik) [15:34:03] dbrant: you might be interested in https://translatewiki.net/wiki/Thread:Support/About_Wikimedia:Wikipedia-android-strings-edit_section_abusefilter_back_text/en [15:35:19] ashley: thanks! I'll have a look [15:36:39] yw :) (took a while to track all that down, though -- thankfully there's always github and it's slightly more usable than gitblit ;) [15:42:07] as for the last request on https://bugzilla.wikimedia.org/show_bug.cgi?id=67981 , I'm thinking it should be possible to use proper pluralization (see also http://www.joulespersecond.com/2010/04/android-tip-proper-pluralization/)...except that wikipedia/AndroidManifest.xml specifies android:minSdkVersion="10" , and https://code.google.com/p/android-i18n-plurals/ notes that "Unfortunately, it... [15:42:09] ...seems that on early Android versions (API Level 10 and below) the plurals support does not cover all languages." [15:45:06] (03PS1) 10Dbrant: Update overflow menu text when Saved pages are saved/loaded. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/146081 [15:48:15] ashley: indeed, support for API10 is a pain in all of our backsides, but it's still necessary. (it's something like 12% of our users) [15:58:03] (03Abandoned) 10BearND: [WIP] Swipe between nearby references [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/145585 (owner: 10BearND) [15:58:20] (03PS1) 10BearND: [Do not merge] Swipe between nearby references [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/146086 [16:07:35] dr0ptp4kt, https://gerrit.wikimedia.org/r/#/c/146076/ pls too ) [16:17:07] (03PS2) 10BearND: Don't break when clicking an internal link to a page title containing '/wiki/' [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/145900 (https://bugzilla.wikimedia.org/67949) (owner: 10Alex Monk) [16:22:10] (03CR) 10Dr0ptp4kt: Further Opera slot logging (031 comment) [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/146071 (owner: 10Yurik) [16:32:14] (03PS3) 10BearND: Don't break when clicking an internal link to a page title containing '/wiki/' [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/145900 (https://bugzilla.wikimedia.org/67949) (owner: 10Alex Monk) [16:33:54] (03PS4) 10BearND: Don't break when clicking an internal link to a page title containing '/wiki/' [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/145900 (https://bugzilla.wikimedia.org/67949) (owner: 10Alex Monk) [16:35:17] (03CR) 10BearND: [C: 032] "Good catch Alex! I only added some unit tests." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/145900 (https://bugzilla.wikimedia.org/67949) (owner: 10Alex Monk) [16:35:39] (03Merged) 10jenkins-bot: Don't break when clicking an internal link to a page title containing '/wiki/' [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/145900 (https://bugzilla.wikimedia.org/67949) (owner: 10Alex Monk) [16:41:11] bearND: I left some CR on the references patch [16:46:32] (03PS1) 10Mhurd: Fix for back/forward buttons in rtl langs. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/146109 [16:46:59] YuviPanda: thanks. re the first comment: that was a refactoring, not new code. re 2nd comment: do you have a good name in mind for the new action? [16:48:40] who is it who knows about FirefoxOS? brion? awjr? this might be of interest: http://www.meetup.com/The-Mountain-View-Mozilla-Meetup-Group/events/194226832/ [16:48:55] bearND: 'referenceClicked' [16:49:03] bearND: yeah, realized that one later (the refactor) we can fix it later [16:49:32] YuviPanda: ok, i'll make the change. [16:49:47] chrismcmahon i think dr0ptp4kt and jon have been the most involved in the firefox os wikipedia app. i suspect that brion knows quite a bit about firefoxos too [16:49:58] chrismcmahon maybe send an email to mobile-l? [16:50:06] there may be others there who would be interested too :) [16:50:21] chrismcmahon awjr what's up? [16:51:07] dr0ptp4kt: the Mozilla QA team is meeting IRL at Mountain View, and having a bunch of stuff for for FFOS: http://www.meetup.com/The-Mountain-View-Mozilla-Meetup-Group/events/194226832/ [16:51:51] YuviPanda: dbrant|brb: re the other references patch: ViewPagers are very problematic for this case. i don't recommend going forward with the second patch. i just submitted it so you can take a look/ in case you have a good idea how to salvage this. [16:53:39] chrismcmahon: thanks. yeah, i think you should email mobile-l. i'll forward it to the partnerships team (ffos part of portfolio) for the individuals not following mobile-l. [17:16:33] (03PS2) 10Yurik: Proper global JS value, domain, always include cfg block in js [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/146076 [17:20:03] wmflabs appears to be falling over.. [17:20:22] all the limn dashboards are down: http://mobile-reportcard.wmflabs.org/ [17:20:58] Maryana: yeah, dns issue. [17:21:00] Maryana: being looked at [17:21:08] kk [17:21:37] (03PS4) 10Yurik: Show ZERO info screen on banner click [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/144175 [17:26:39] awjr: kaldari - yeah, that watchlist bug was invalid - archiving [17:26:48] yay [17:26:48] great thanks Maryana [17:27:27] (03PS2) 10Yurik: Further Opera slot logging [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/146071 [17:28:15] Maryana: should be back up [17:30:10] (03CR) 10Yurik: Further Opera slot logging (031 comment) [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/146071 (owner: 10Yurik) [17:30:18] yes - awesome, thanks, YuviPanda [17:30:25] dr0ptp4kt, fixed the ^, and pls review https://gerrit.wikimedia.org/r/#/c/146076/ [17:30:43] kaldari, you should have received an email with an emulator that can run Opera Mini so that you don't have to fight with those old feature phones ;) [17:31:19] Yeah, I've had the emulator running Opera Mini 4 [17:31:26] (03CR) 10Dr0ptp4kt: [C: 032] Further Opera slot logging [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/146071 (owner: 10Yurik) [17:31:31] dr0ptp4kt, when done, would love to discuss info screen design... btw, i think we need to ask one of the mobile guys to help with interstitual - it broke recently, probably because some CSS got changed in the mobile world [17:31:39] (03Merged) 10jenkins-bot: Further Opera slot logging [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/146071 (owner: 10Yurik) [17:31:40] kaldari, cool [17:31:46] it's way easier that try to get those phones working :) [17:31:59] trying [17:32:01] kaldari: if you're testing small screen improvements, can i look over your shoulder? [17:32:30] (03PS3) 10Dr0ptp4kt: Proper global JS value, domain, always include cfg block in js [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/146076 (owner: 10Yurik) [17:33:29] yurikR: k, will ping once done w/ 146076 [17:33:56] yurikR: actually gotta get something to eat, then will be back to resume that review [17:33:58] thx [17:34:02] ok [17:34:14] Maryana: sure, lemme get it set up... [17:35:22] dr0ptp4kt, whom should we bug with css... kaldari ? :) [17:35:45] yurikR: me or jgonera [17:36:19] kaldari, do you still have zero on? the intertsitual seemed to have broken visually somehow, looks ugly :( [17:36:30] the confirmation screen [17:36:36] when you click on the external link [17:36:44] it might be due to some CSS magic breaking somewhere [17:37:10] yurikR: I can take a look at it in a little while [17:38:01] thanks, no rush :) [17:43:33] YuviPanda: hey quick question - how many search results do you request at a time? oh and what search result thumb resolution do you request? [17:43:50] mhurd: looking, moment [17:44:31] mhurd: 12 items [17:44:57] YuviPanda: can a mulitple of that be requested w/o making caching servers sad? [17:45:17] mhurd: thumb size is '48dp', which can be different resolutions based on the screen's density [17:45:29] mhurd: should not cause server issues, from what I know of how opensearch works, however, it'll be slower [17:46:03] YuviPanda: cool thanks! [18:00:19] (03CR) 10Brion VIBBER: "Minor RTL issue: the main label text is still left-aligned with UI set to Arabic. Should switch to right-aligned. (looks like the secondar" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/146034 (owner: 10Mhurd) [18:02:54] (03CR) 10Brion VIBBER: [C: 032 V: 032] "Ok RTL issue will be fixed up in another commit, monte says it's easy fix. :D" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/146034 (owner: 10Mhurd) [18:07:51] (03CR) 10Brion VIBBER: [C: 032 V: 032] "nice :D" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/146109 (owner: 10Mhurd) [18:18:34] omg you guys, which one of you used an ipad to vandalize the zebroid article?? https://en.wikipedia.org/w/index.php?diff=prev&oldid=615773790 [18:18:51] kaity: i'm looking at you... [18:21:39] lolol [18:21:46] oh, kaity goes away… how very convenient! [18:21:48] :D [18:27:09] Maryana: ready [18:28:20] Maryana, I think it was StevenW, he confessed that he edited all of those articles (zebroid, zedonk, etc.) [18:29:40] * YuviPanda takes StevenW to arbcom [18:29:50] MISUSE OF STAFF PREVILAGES! WE SHOULD FORK THE WIKI NOW! [18:30:57] (03PS9) 10BearND: Show references without scrolling [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/145225 [18:30:59] (03PS2) 10BearND: [Do not merge] Swipe between nearby references [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/146086 [18:31:11] YuviPanda: ^ [18:31:19] looking [18:32:24] I have not edited the zebroid article [18:32:56] dbrant|brb: Can't find the remote for the TV in here... [18:33:12] Deskana: lol [18:33:37] Deskana: my biggest concern right now is instal vs. uninstall rate. i want to validate that data and understand it [18:34:28] flyingclimber: Yeah. Uninstalls have increased too. [18:36:18] (03CR) 10Dr0ptp4kt: [C: 032] Proper global JS value, domain, always include cfg block in js (031 comment) [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/146076 (owner: 10Yurik) [18:36:40] Deskana: yes. i find the numbers hard to believe but if their real i want to know why [18:36:52] how could we find it out ? [18:37:03] (03Merged) 10jenkins-bot: Proper global JS value, domain, always include cfg block in js [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/146076 (owner: 10Yurik) [18:37:11] Deskana: tfinc > Uninstalls on TCT Mobile Limited (Alcatel) ALCATEL ONE TOUCH 991 (ONE_TOUCH_991_gsm) devices increased by 68% compared to last week. [18:37:23] from the 'alerts' section [18:37:31] it's possible we've a bug that's crashing on that particular device [18:39:31] YuviPanda: the uninstall rate doesn't have a spike like that so while that's not helping i don't think thats the core issue [18:40:34] and of course to be fair. the numbers are trending down [18:40:37] just not fast enough for me [18:41:11] effectively i would set our goal to have *fewer* uninstall then the PhoneGap app [18:44:10] tfinc: right. Other than that one, I don't have any other data that could help, though. OTRS is almost overwhelmingly positive, and so are the reviews... [18:44:25] YuviPanda: and thats why i just don't get it [18:44:51] (03PS5) 10Kaldari: Improvements for viewing mobile site on very small screens (<=280px) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/145443 [18:44:53] indeed, and it's not crashing much either. most of the crash bugs we fix these days are edge cases [18:44:54] spike in uninstalls may also simply be “oh this app updated? i wasn’t using that, lemme delete it” [18:45:05] hehe [18:45:06] (03CR) 10jenkins-bot: [V: 04-1] Improvements for viewing mobile site on very small screens (<=280px) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/145443 (owner: 10Kaldari) [18:45:11] yeah, I've done what brion said a few times as well [18:50:08] hmmmm [18:50:22] YuviPanda: in android are you using the global user id or the per-wiki user id for edit eventlogging? [18:50:57] brion: whatever action=login returns [18:51:00] i just realized that getting the local per-wiki user id on login is useless when editing on another wiki [18:51:16] yeah that’s local id :( [18:51:22] brion: oh... gah. I, uh, don't know how Android handles that [18:51:24] this... could be a problem [18:52:01] wheeeee [18:52:01] brion: I guess you guys just send the cookie? [18:52:06] brion: I wonder if the cookie has the local userid [18:52:21] (03PS6) 10Kaldari: Improvements for viewing mobile site on very small screens (<=280px) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/145443 [18:52:34] (03CR) 10jenkins-bot: [V: 04-1] Improvements for viewing mobile site on very small screens (<=280px) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/145443 (owner: 10Kaldari) [18:53:07] brion: whelp, no info I can find on that. [18:53:22] i’m updating ios to send the userid [18:53:30] it looked easy until i realized the storage might be … interesting [18:53:34] brion: ok, do let me know how you're determining the current one [18:53:45] brion: yeah, I guess would need for us to send the current one per wiki [18:53:48] in progress grabbing it from login [18:53:54] brion: ok. [18:56:07] shit, yeah this code ends up sending the wrong id if i switch languages after login and then edit [18:58:22] brion: I'd say timebox it to say, 1.5h, and if that doesn't work out, just send the username [18:58:28] (03PS1) 10Brion VIBBER: Work in progress: adding userId for edit event logging [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/146164 [18:58:36] “it’s analytics problem” ;) [18:59:20] brion: heh, and by extension *my* problem [18:59:33] YuviPanda: ina ndroid are you sending id and username, or just id? [18:59:39] cause you may have a bunch of bogus ids :) [18:59:44] brion: just id, and yeah, you're right [18:59:47] bogguuusss iddss [18:59:50] dangit [18:59:57] brion: let me verify, actually [19:00:08] brion: I might not have gotten to getting CA to work and instead just have done another action=login [19:00:22] heh [19:01:17] heh, I just got spammed with about 300 emails from tools because of a DNS failure [19:01:19] #sysadminproblems [19:02:15] heh [19:04:06] hmm, if we only need user id for editing EL, i can probably just request the user metadata along with the section fetch or some shit [19:04:18] and then use that instead of keeping it in global state [19:04:20] does section fetch give it to us? [19:04:27] oh, yeah, action=query [19:04:36] api can stick a couple queries together yeah [19:04:48] * brion goes to api playground [19:04:55] (03PS5) 10Yurik: Show ZERO info screen on banner click [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/144175 [19:05:18] (03PS7) 10Kaldari: Improvements for viewing mobile site on very small screens (<=280px) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/145443 [19:05:22] meta=userinfo should do it [19:05:29] (03CR) 10jenkins-bot: [V: 04-1] Improvements for viewing mobile site on very small screens (<=280px) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/145443 (owner: 10Kaldari) [19:07:06] kaldari, yurikR2 may be able to help you find some users to assist with the hebrew thing. [19:08:00] yeah this should work. lemme poke around [19:10:02] 3Wikipedia App / 3Android App: IllegalArgumentException: View not attached to window manager causing crashes - 10https://bugzilla.wikimedia.org/67947#c2 (10Alex Monk) 5PATC>3RESO/FIX Marked as fixed since that got merged [19:16:16] brion: rtl’s looking good! :) [19:16:21] woohoo [19:18:03] 3Wikipedia App / 3Android App: All internal links containing '/wiki/' are broken - 10https://bugzilla.wikimedia.org/67949 (10Alex Monk) 5PATC>3RESO/FIX [19:19:48] 3MobileFrontend / 3stable: beta labs: Watchlist "Modified" view shows no results. - 10https://bugzilla.wikimedia.org/67987#c2 (10Florian) If i navigate to the link provided, i see that my talkpage has changed (registered just a moment ago, so it's the welcome message)? :) [19:20:04] 3Wikipedia App / 3iOS App: iOS app long press menu on links shows/copies wrong domain - 10https://bugzilla.wikimedia.org/67994 (10Brion Vibber) 3NEW p:3Unprio s:3normal a:3None Created attachment 15933 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15933&action=edit Screenshot of long press m... [19:20:07] (03PS1) 10Mhurd: RTL lang fixes! [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/146170 [19:20:19] brion: ^ [19:21:41] (03PS2) 10Brion VIBBER: Adding userId for edit event logging [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/146164 [19:21:47] 3MobileFrontend / 3stable: beta labs: Watchlist "Modified" view shows no results. - 10https://bugzilla.wikimedia.org/67987#c3 (10Jon) The page appears to be stuck on the 'Other' view by default for some reason. It should be defaulting to the main view. Does someone want to explore the default view, or is it... [19:22:01] 3MobileFrontend / 3stable: beta labs: Watchlist "Modified" view shows no results. - 10https://bugzilla.wikimedia.org/67987#c4 (10Jon) In meantime test can be fixed by manually logging in, going to watchlist view and clicking 'Main' tab. [19:23:48] mhurd: ok for that eventlogging bit i had to change DownloadWikiTextOp to also fetch the local wiki’s user information, returns it as a second parameter; and then that userid gets fed into the EL funnel [19:23:50] seems to work :D [19:24:06] it also reminded me i’m user id 1 on a lot of languages, cause i migrated them back in the day and was first to log in ;) [19:24:15] on english i’m 51 though :) [19:29:32] 3MobileFrontend / 3stable: beta labs: Watchlist "Modified" view shows no results. - 10https://bugzilla.wikimedia.org/67987#c5 (10Maryana Pinchuk) 5NEW>3RESO/WOR Tested with a few of my accounts on beta labs, and it seems to default correctly for me (to Pages), so I think this test account just got stuck... [19:30:17] 3MobileFrontend / 3stable: beta labs: Watchlist "Modified" view shows no results. - 10https://bugzilla.wikimedia.org/67987#c6 (10Chris McMahon) 5RESO/WOR>3REOP I'm going to re-open this, hopefully on the way to get to PATCH_TO_REVIEW. I manually clicked the "Pages" view which I will take on faith will... [19:32:38] (03CR) 10Brion VIBBER: [C: 032 V: 032] "looks great!" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/146170 (owner: 10Mhurd) [19:32:47] 3MobileFrontend / 3stable: beta labs: Watchlist "Modified" view shows no results. - 10https://bugzilla.wikimedia.org/67987#c7 (10Jon) To get these tests passing someone will need to login to beta labs under the test user account and switch the watchlist view on the feed... [19:33:10] brion: yay! i’ll have another quick patch in a minute for search results and lang selector rtl [19:33:15] awesome [19:38:03] 3MobileFrontend / 3Feature requests: Go directly to an article if we have an exact search match - 10https://bugzilla.wikimedia.org/66506#c7 (10Ryan Kaldari) CCing Maryana for product approval. [19:47:31] (03Abandoned) 10Cmcmahon: QA: Run protected test without explicit logout [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/143745 (owner: 10Cmcmahon) [19:51:15] (03CR) 10BearND: [C: 04-1] "When you hit Refresh page it doesn't get the latest version from the server. It just saves the same content again." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/146081 (owner: 10Dbrant) [19:52:46] (03PS3) 10Brion VIBBER: Adding userId for edit event logging [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/146164 [19:53:09] ^ removes asserts [19:53:20] bearND: ah yes, I'll patch that. Would you look at this, also? https://gerrit.wikimedia.org/r/#/c/146073/1 [19:53:35] dbrant: already looking at that one [19:53:40] (03PS1) 10Mhurd: Rtl fixes for search results and lang selector. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/146183 [19:54:01] brion: ^ [19:54:40] kaldari: two enthusiastic thumbs up for search patch [19:54:40] whee [19:54:53] yay [19:57:46] (03CR) 10Brion VIBBER: [C: 032 V: 032] Rtl fixes for search results and lang selector. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/146183 (owner: 10Mhurd) [20:01:25] (03CR) 10Yuvipanda: [C: 04-1] "1. The display should disappear once the user taps outside the ref display (should match Mobile Web)" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/145225 (owner: 10BearND) [20:01:28] bearND: ^ left comments [20:02:34] (03PS2) 10Dbrant: Update overflow menu text when Saved pages are saved/loaded. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/146081 [20:04:33] bearND: I also got a crash, forwarded you report [20:05:34] mhurd, brion: We still on track to cut a release candidate this afternoon? :) [20:05:42] yep! [20:05:51] Once we've done that, do you guys do the submission? [20:05:58] I mean, once we've all agreed we're good to go. [20:06:04] I'm unsure of the actual mechanics of submitting. [20:06:31] yeah we package it up from xcode and push some magic buttons and it goes up [20:06:36] and then waits around for a few days MYSTERIOUSLY [20:06:38] :D [20:07:06] (03CR) 10Dbrant: "(Making the reference window into a Dialog would take care of 1 and 3)" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/145225 (owner: 10BearND) [20:07:17] YuviPanda: re your first comment: If we make the refs disappear when someone clicks outside then the user cannot scroll around. But ok, I'm fine with that. Probably do the same that dbrant did for the font/theme choser [20:07:44] dbrant: yeah, what you just said ^^ [20:07:47] bearND: ^ lol [20:08:53] YuviPanda: not sure what the crash hayou sent me s to do with my patch. I think https://gerrit.wikimedia.org/r/#/c/146073/1 is might fix that [20:09:50] (03PS8) 10Kaldari: Improvements for viewing mobile site on very small screens (<=280px) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/145443 [20:09:51] weird, whenever i get an irc notification it messes with the text i'm writing in irc [20:10:09] what client are you using? [20:10:12] Deskana: aloha [20:10:16] dbrant: Adium [20:10:21] aharoni: Hey. :) [20:10:22] YuviPanda: aloha to you, too [20:10:59] (03PS2) 10BearND: Slightly better event for unregistering from Bus. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/146073 (owner: 10Dbrant) [20:11:08] Deskana: YuviPanda : does anybody remember to sync the translations for iOS and Android before releasing/ [20:11:10] ? [20:11:29] (03CR) 10BearND: [C: 032] Slightly better event for unregistering from Bus. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/146073 (owner: 10Dbrant) [20:11:59] (03Merged) 10jenkins-bot: Slightly better event for unregistering from Bus. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/146073 (owner: 10Dbrant) [20:12:22] (03PS10) 10BearND: Show references without scrolling [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/145225 [20:13:58] aharoni: ah, unsure. brion, did an iOS sync happen? [20:14:14] YuviPanda: i assume it happens on whatever schedule it regularly happens so far? [20:14:29] aharoni: ^ [20:14:34] I'm going to do one for android now anyway [20:15:10] YuviPanda: What do you recommend to do about "The code is included in preview fragment JS, but doesn't work there."? [20:15:37] bearND: extract it out into its own js file, and add it to the gruntfile.js only for bundle.js and not for preview.js [20:16:34] YuviPanda: So, like a references.js. Problem is though that i still need to use an onclick handler. [20:17:05] bearND: hmm, so actions.js would need a generic way to let other interested parties register for link clicks as well [20:17:09] I think there's one for general ones [20:19:15] YuviPanda, brion - I'm not sure what the schedule is. [20:19:20] it's certainly not automatic. [20:19:50] aharoni: last update i see is from june 23 (!) [20:19:56] AFAIK "schedule" is "whenever Siebrand does it", and I don't know how does he plan it [20:20:03] i guess we should probably poke it [20:20:06] YuviPanda: can you do it for iOS, too? [20:20:31] I can, but I don't think we should rely on me doing the updates all the time. brion, can you work with aharoni afterwards to get a regular schedule established? :) [20:20:33] I'll do it now [20:20:39] yep [20:20:44] For now, it'd be good to get it in for the release candidate. [20:20:49] (technically, I can do it, too, but my last time was at least a year ago, and I'd need a memory refreshment from nikerabbit) [20:20:51] That's my biggest concern. :) [20:21:01] i’ll need documentation on how to do that too :) [20:21:41] brion: siebrand -2'd the patch getting you all guys twn.net access, so having docs would be of no use :) [20:21:48] heh [20:21:54] (03PS1) 10Mhurd: Rtl fixes for edit workflow, sign-in, acct creation & captcha. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/146253 [20:22:21] aharoni: hmm, /resources/yuvipanda is also now gone, after the reinstall. let me poke around [20:22:37] ow [20:23:06] (03CR) 10Dr0ptp4kt: [C: 04-1] "See comments." (0310 comments) [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/144175 (owner: 10Yurik) [20:23:48] dr0ptp4kt, thx, looking [20:24:27] yurikJerusalem: Jerusalem? [20:25:09] (03CR) 10Brion VIBBER: [C: 032 V: 032] Rtl fixes for edit workflow, sign-in, acct creation & captcha. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/146253 (owner: 10Mhurd) [20:25:47] aharoni, yep :) [20:26:18] call 02.5819820 if you want a beer or something [20:26:29] right next to holy land apt - the apt complex that put the previous prime ministr of israel into jail for corruption... [20:26:35] aharoni, oh, you are here! [20:27:02] https://wikimediafoundation.org/wiki/User:Aaharoni [20:27:21] i know who you are :) [20:29:23] aharoni: brion imported latest android and ios changes into twn [20:29:29] aharoni: brion now exporting from there to here... [20:29:32] \o/ [20:29:34] tx [20:29:38] there should be lots of updates on ios :) [20:29:49] so yeah good to get that updated on twn [20:29:50] brion: yeah, quite a few [20:29:56] I had to click a lot of checkboxes! :D [20:29:59] haha [20:31:19] now i’m tempted to go in and translate the app to esperanto, alas i can’t select that as a locale in unhacked ios :) [20:31:29] eventually we’ll have to figure out a way to override [20:31:37] (03PS1) 10Yuvipanda: Manual import of translations from translatewiki.net [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/146255 [20:32:40] (03PS1) 10Yuvipanda: Manual update of translations from translatewiki.net [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/146256 [20:32:41] brion: ^ caution, I just did a git add . and commit, so do check before merging :) [20:32:46] aharoni: both done :) [20:34:21] YuviPanda: thanks a lot [20:34:29] (03PS1) 10Mhurd: Rtl leading padding fix for history date headings. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/146257 [20:34:32] brion: ^ [20:34:40] whee [20:36:09] (03PS3) 10Yuvipanda: Update overflow menu text when Saved pages are saved/loaded. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/146081 (owner: 10Dbrant) [20:36:12] brion: oh is your el patch ready for review? (https://gerrit.wikimedia.org/r/#/c/146164/) [20:36:28] YuviPanda: need to leave the qqq.lproj/Main_iPhone.strings [20:36:33] mhurd: yeah seems to work :D [20:36:37] brion: can you amend the patch? :D [20:36:42] yeah i can do that :D [20:36:45] brion: sweet [20:37:10] reminds me i gotta find some time to test plurals on both android and ios [20:38:10] (03CR) 10Mhurd: [C: 032 V: 032] "Seems solid." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/146164 (owner: 10Brion VIBBER) [20:39:25] (03PS2) 10Brion VIBBER: Manual update of translations from translatewiki.net [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/146256 (owner: 10Yuvipanda) [20:40:06] (03CR) 10Brion VIBBER: [C: 032 V: 032] Manual update of translations from translatewiki.net [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/146256 (owner: 10Yuvipanda) [20:42:35] woops deleted some qqq strings by accident lemme fix [20:44:06] YuviPanda: ios and android translated to hebrew :) [20:44:12] aharoni: nice :D [20:44:18] aharoni: woohoo! [20:44:20] aharoni: I'll do an update again for android before the actual release. [20:44:38] is Apple all fascist when it comes to updating translations? [20:45:10] or do they have an easier procedure for localization update? [20:45:23] (or am i ridiculously naive to even imagine such a silly thing?) [20:45:27] aharoni: same as any update, has to go through review but small updates are usually quicker than big ones [20:46:30] we’ll just toss them in with our semi-regular bugfixes i guess [20:46:40] which will initially be pretty frequently i expect :D [20:47:22] (03PS1) 10Brion VIBBER: Re-add qqq descriptions accidentally removed during merge [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/146260 [20:47:26] (03PS6) 10Yurik: Show ZERO info screen on banner click [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/144175 [20:47:39] dr0ptp4kt, fixed (i think) ^ [20:47:43] (03CR) 10Brion VIBBER: [C: 032 V: 032] "selfmerge fix of previous merge" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/146260 (owner: 10Brion VIBBER) [20:47:58] yurikR: thx, will look [20:48:29] (03CR) 10Brion VIBBER: [C: 032 V: 032] Rtl leading padding fix for history date headings. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/146257 (owner: 10Mhurd) [20:48:57] YuviPanda: can you do another import to twn to fix the qqq’s? thanks :D [20:49:19] brion: to twn from the repo you mean? [20:49:23] right [20:51:31] brion: hmm, says 'no changes found'? [20:51:47] hmm [20:51:52] mysterious… [20:52:01] well then hopefully that’s.. . ok :D [20:52:12] :) [20:52:48] Deskana: I'm going to assume you're ok with the release cadence plan :) [20:53:41] YuviPanda: Yep. I read it. Just forgot to comment. [20:53:54] Deskana: ah, ok! any comments? :D [20:53:55] yurikR: still seems like the operator hyperlink doesn't go anywhere on that? [20:54:37] (03PS1) 10Mhurd: Rtl fix for other edit summary. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/146261 [20:54:41] brion: ^ [20:54:55] YuviPanda: Hold on. I'll give it another skim once I'm done in this meeting. [20:55:00] Deskana: alright! [20:55:30] (03CR) 10Brion VIBBER: [C: 032 V: 032] Rtl fix for other edit summary. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/146261 (owner: 10Mhurd) [21:00:49] YuviPanda: dbrant|brb: since I move reference display to a dialog do you think we still need the x to close the reference display? [21:01:08] bearND: dialog? why? [21:01:23] can we absolutely position a dialog to be at the bottom? [21:01:36] YuviPanda: that's exactly how I implemented the theme chooser [21:01:47] ah [21:01:49] cool :) [21:01:54] bearND: I'm ok with taking out the 'x' [21:02:05] YuviPanda: ok, cool [21:02:11] * YuviPanda 's memory is failing him, must be growing old [21:02:18] bearND: that's a good point; we probably don't need it [21:04:10] (03PS7) 10Yurik: Show ZERO info screen on banner click [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/144175 [21:04:10] dr0ptp4kt, thx, found another reason why i wasn't working, fixed and tested now :) [21:04:16] YuviPanda: ok, will be gone with my next patch [21:04:27] * tfinc hands YuviPanda a rocking chair for his old age [21:04:53] * YuviPanda trudges off carrying tfinc's rocking chair with difficulty [21:05:22] YuviPanda: My question is, how do we access the CI builds? [21:05:23] * tfinc pokes YuviPanda with his own walking cane [21:05:27] :D [21:05:53] Deskana: how is the team feeling about the iOS app ? [21:06:25] Deskana: they'll be available for download from a http location, and in addition, there'll be a small helper app (won't be on play store) that you can download that'll notify you when there's a new CI build available, and also let you download/install it easily [21:07:50] Deskana: they'll be done by jenkins, most probably (although toollabs isn't out of the question either, due to our puppetization procedures) [21:09:49] YuviPanda: It'd be a lot easier if we didn't have to download APKs all the time. [21:10:09] tfinc: we’re madly committing little tiny fixes \o/ [21:10:15] :) [21:10:25] should be ready to give Deskana a QA build real soon [21:10:36] Deskana: that's the 'helper app'. You'll tap a button, it'll download the apk for you and start the install process, and you'll have to just tap again (yes, do install it) to install [21:10:47] brion: Can you also send it to Howie and Erik? They expressed interest. [21:10:58] brion: I told them they'll only have a few hours between receiving it and us submitting it, but still. :P [21:11:02] Deskana: you won't have to hunt around for a link, download, fumble around to see where it downloaded, click that, etc [21:11:05] YuviPanda: Okay, cool. [21:11:20] Deskana: if they’re in the existing alpha distribution group they’ll get it [21:11:28] brion: Okay, sweet. [21:11:39] (03PS1) 10Mhurd: Changed search result thumb resolution. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/146264 [21:11:40] brion: Wasn't sure whether you were just going to send it to me or not. [21:11:53] it’s easiest to just stick it on testflight as before :) [21:12:09] (03CR) 10Brion VIBBER: [C: 032 V: 032] Changed search result thumb resolution. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/146264 (owner: 10Mhurd) [21:12:56] (03CR) 10Yurik: Show ZERO info screen on banner click [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/144175 (owner: 10Yurik) [21:12:57] YuviPanda: No problems here then. [21:13:02] Deskana: sweet :) [21:13:19] tfinc: do you have any comments on the release plans? everyone else in the team seems to have weighed in [21:13:21] and are ok with it [21:13:32] YuviPanda: i like it [21:13:34] ship ip [21:13:38] :D cool [21:13:40] early and often :) [21:14:10] YuviPanda: if you can make it so that i don't have to ask Deskana wether he has a build to sign off on then i'll be happy [21:14:22] fix that and you get a gold star [21:14:32] tfinc: indeed, the CI builds are meant to address that exact problem. a commit gets merged, and boom there's a build [21:15:36] (03CR) 10Dr0ptp4kt: [C: 032] "Needs more polish, but this will allow for verification on a per-operator basis. Works for me." [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/144175 (owner: 10Yurik) [21:15:46] yurikR: ^ there [21:15:48] (03Merged) 10jenkins-bot: Show ZERO info screen on banner click [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/144175 (owner: 10Yurik) [21:16:08] dr0ptp4kt, thx! [21:16:13] off to bed [21:16:17] yurikR: 'night [21:22:27] YuviPanda: Maryana and I are meeting on Wednesday to discuss the product requirements for the analytics dashboard. [21:22:35] YuviPanda: So that card might be refined further. [21:23:41] Deskana: cool. btw, I've been talking to analytics, and having app stats come directly to mobile-reportcard.wmflabs.org isn't something they prefer (and isn't something I prefer either). They're working on replacing Limn with something that's not insane (trust me, Limn is), and the new stats should probably go there. I can help migrate the mobile web ones there as well. Will keep in mind that I should finish whatever it [21:23:41] is within that sprint as well. [21:31:39] Deskana: tfinc bearND dbrant|brb am going to head off now, need anything before I go? [21:31:54] YuviPanda: i'm good. thanks [21:33:23] YuviPanda: have you exported the strings to twn? [21:33:38] bearND: yep, there's also an import to our repo awaiting review [21:33:57] YuviPanda: cool [21:35:38] alright then, I'm off [21:35:41] cya tomorrow, guys [21:35:52] I'll send in notes and setup events / tasks for the release cadence stuff after [21:35:58] whee [21:36:16] brion: did you see the release cadence proposal for Android? :) [21:36:23] i did, it looks great :D [21:36:49] http://hatjitsu.wmflabs.org/06286 [21:36:54] MaxSem jgonera kaldari|2 ^ [21:38:36] http://etherpad.wikimedia.org/p/MobileWeb_Iteration_name [21:38:51] Maryana jgonera kaldari|2 MaxSem moizsyed_ ^ [21:39:06] https://en.wikipedia.org/wiki/List_of_films:_A [21:42:11] brion: sweet [21:42:14] * YuviPanda waves [21:45:20] jgonera: i still need your thoughts on jr candidates. please mail me [21:45:25] (03PS1) 10Mhurd: Set scroll velocity thresholds for menu reveal/hide. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/146290 [21:45:28] brion: ^ [21:45:46] tfinc, did anyone tech screen Steven Vachon? [21:46:05] jgonera: please don't mention candidate names in the channel [21:46:10] jgonera: pm me or find me in person [22:00:07] (03CR) 10Kaldari: [C: 04-1] Proposal: Redirect to direct match in search (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/139556 (https://bugzilla.wikimedia.org/66506) (owner: 10Florianschmidtwelzow) [22:02:24] (03CR) 10Brion VIBBER: [C: 032 V: 032] Set scroll velocity thresholds for menu reveal/hide. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/146290 (owner: 10Mhurd) [22:04:53] Deskana|Away: we found a last-minute crasher bug on ios 6.1, fixing up now and then i think we’re about ready to send out an RC build [22:08:51] kaldari|2: jgonera_: I may need some help getting https://gerrit.wikimedia.org/r/#/c/146296/ into shape [22:09:19] perhaps you will have time to chat about it later this afternoon or on Wenesday? [22:09:25] added myself as a reviewer [22:09:30] cool [22:09:58] basically, it works, except the suggestions popup and lookup input widget are haunted [22:10:04] I will show you guys later [22:10:22] TrevorParscal, not sure if I'll have time today, but I should be able to look at it on Wednesday, thanks [22:10:28] sure [22:11:02] basically, the latest thing to land in VE core and OOUI breaks things for you guys, and this seeks to mend that [22:13:08] looks like the input being haunted is a chrome mobile emulation problem - but anyway.. [22:13:11] Wednesday sounds good [22:16:58] (03CR) 10MaxSem: "My thoughts about this: https://bugzilla.wikimedia.org/show_bug.cgi?id=67471#c5" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/145895 (https://bugzilla.wikimedia.org/67471) (owner: 10Florianschmidtwelzow) [22:18:31] (03PS1) 10Mhurd: iOS 6 docs led us astray with NSTextAlignmentNatural. Fixed. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/146303 [22:18:34] brion: ^ [22:18:52] woohoo [22:23:24] (03CR) 10Kaldari: [C: 032] Show Uploadbutton only when user has the permission [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/143822 (https://bugzilla.wikimedia.org/62598) (owner: 10Florianschmidtwelzow) [22:24:02] (03Merged) 10jenkins-bot: Show Uploadbutton only when user has the permission [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/143822 (https://bugzilla.wikimedia.org/62598) (owner: 10Florianschmidtwelzow) [22:26:19] (03CR) 10Brion VIBBER: [C: 032 V: 032] iOS 6 docs led us astray with NSTextAlignmentNatural. Fixed. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/146303 (owner: 10Mhurd) [22:37:00] moizsyed: Make the placeholder at 1:1 aspect ratio [22:37:24] moizsyed: If you want to set a size for the SVG: 56x56px [22:37:46] or larger [22:44:20] (03PS1) 10Cmcmahon: QA: WIP use API to protect page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/146328 [22:49:51] (03CR) 10Kaldari: [C: 04-1] "Temporary -1 until we get new placeholder image from design. They want to use something more subtle. Otherwise, looks good." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/145895 (https://bugzilla.wikimedia.org/67471) (owner: 10Florianschmidtwelzow) [22:51:25] dr0ptp4kt: Do you know what yuri wanted me to take a look at? Re CSS? [22:52:17] kaldari|2: i think he was looking for assistance on making the w0 exit iterstitals for external links pretty [22:53:55] kaldari|2: alright [22:58:25] kaity: are you gonna hop on ghangouts for the VE mobile meeting? [22:58:44] Maryana: yes [22:58:58] ok, cool, lemme fire up the tv then :) [23:07:10] (03PS1) 10Brion VIBBER: Tweak 'last modified' text [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/146338 [23:07:17] mhurd: ^ [23:07:21] (03PS1) 10Dr0ptp4kt: Make CasperJS tests run with nested configs. [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/146339 [23:08:58] (03CR) 10Dr0ptp4kt: [C: 032] Make CasperJS tests run with nested configs. [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/146339 (owner: 10Dr0ptp4kt) [23:09:13] (03CR) 10Mhurd: [C: 032 V: 032] "Yay!" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/146338 (owner: 10Brion VIBBER) [23:09:15] (03Merged) 10jenkins-bot: Make CasperJS tests run with nested configs. [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/146339 (owner: 10Dr0ptp4kt) [23:14:03] (03PS1) 10Mhurd: Made web view taps hide the toc instead of following links etc. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/146343 [23:14:08] brion: ^ [23:16:48] (03CR) 10Brion VIBBER: [C: 032 V: 032] "does what it says on the tin" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/146343 (owner: 10Mhurd) [23:22:05] @mhurd ping me when you guys are close to finish [23:22:15] vbamba: k [23:24:22] jgonera: If you have time, would be good to get https://gerrit.wikimedia.org/r/#/c/145730/ and https://gerrit.wikimedia.org/r/#/c/145443/ reviewed. [23:25:08] kaldari|2, I know, I've been trying to come up with some ideas to fixing sticky toolbar in VE before VE sync up meeting which is happening now [23:25:15] I'll review after the meeting (5pm) [23:25:22] NP [23:30:35] (03PS1) 10Brion VIBBER: Fix long-press menu on links [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/146346 [23:51:38] kaldari|2: hey [23:51:40] kaldari|2: you there [23:51:47] yes [23:52:30] kaldari|2: so we cant use '+' in the 'no image' icon, right? [23:52:41] correct [23:52:47] kaldari|2: why doesnt the community like the '+'.. tell me that again [23:53:25] because most people aren't allowed to upload images from mobile now [23:53:39] so we don't want to get their hopes up :) [23:54:09] kaldari|2: got it [23:54:11] kaldari|2: thanks [23:57:10] Deskana: i also need a ‘support URL’ for the app store page; currently points to broken http://en.m.wikipedia.org/w/index.php?title=Special:MobileFeedback&returnto=Main+Page [23:57:25] Hmm, like what? :/ [23:57:33] hopefully not “bugzilla" [23:57:40] can we put a mailto: url? :P [23:57:55] Hah! [23:57:57] That'd be good. [23:59:20] I don't know what else we'd put. [23:59:35] Let me just quickly double-check the More menu functionality with this build that was just put on my phone. [23:59:53] k