[00:02:11] Hmm. [00:02:25] Can you quickly change the "License" button in the More menu to say "Terms of Use"? [00:02:58] i can :) [00:05:46] (03PS1) 10Brion VIBBER: License -> Terms of Use in menu [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/146354 [00:17:48] brion: Are you guys waiting on us for the screenshots? [00:18:02] brion: We can spend ages stylising it all, but if you're sat waiting then we can go quick and dirty. [00:18:04] Deskana: monte’s finishing up the splash screen now [00:18:13] we can take the screenshots whenever you’re ready [00:18:46] brion: We're just taking the last ones. Trying to figure out how much post-processing we do, basically! [00:18:51] If you're sat waiting then we'll keep it short. [00:19:23] i’m just waiting :) [00:22:40] brion: I'm trying to speed things up! [00:22:49] Eugh, I can't believe you have to do this at submission. [00:22:54] APPLE MUST CONTROL [00:23:32] srsly [00:26:17] (03PS1) 10Mhurd: Added splash screens. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/146359 [00:27:45] (03CR) 10Brion VIBBER: [C: 032 V: 032] Added splash screens. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/146359 (owner: 10Mhurd) [00:28:23] (03PS4) 10JGonera: WIP: Improve fixed header in overlays on iOS [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/145185 [00:29:01] (03CR) 10Mhurd: [C: 032 V: 032] "Yay!" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/146354 (owner: 10Brion VIBBER) [00:30:58] (03CR) 10Mhurd: [C: 032 V: 032] "Yup." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/146346 (owner: 10Brion VIBBER) [00:31:36] @mhurd How much time do we have? (We are almost ready) [00:32:04] awesome [00:32:08] vbamba: i think we’re ready [00:32:18] \o/ [00:35:23] (03CR) 10JGonera: [C: 04-1] "Minor issues inline." (033 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/145730 (owner: 10Kaldari) [00:35:33] kaldari|2, very small issues: https://gerrit.wikimedia.org/r/#/c/145730/ [00:39:51] Fucking screenshot standards. [00:39:53] Hold on. [00:39:58] We might have to retake these... [00:43:21] heh [00:44:51] brion, mhurd: Can we get the rc built? I need to put it on Abbey's test device for some testing I've organised with her tomorrow. [00:45:04] Deskana: vbamba cutting test flight build now [00:45:05] Deskana: monte’s uploading it now [00:45:16] mhurd, brion: <3 [00:45:27] \o/ [00:55:01] (03PS9) 10Kaldari: Improvements for viewing mobile site on very small screens (<=280px) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/145443 [00:56:00] (03PS10) 10Kaldari: Improvements for viewing mobile site on very small screens (<=280px) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/145443 [01:10:20] brion, mhurd: Trying to wrap up the screenshots. [01:10:24] \o/ [01:11:01] Sorry it's taking so long. We want to do it right. [01:11:22] no worries, i’ll coffee up :) [01:18:12] (03CR) 10Kaldari: Improving save workflow for mobile editing (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/145730 (owner: 10Kaldari) [01:18:35] (03PS2) 10Kaldari: Improving save workflow for mobile editing [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/145730 [01:26:12] brion, mhurd: did the iOS app get submitted? [01:26:30] legoktm: we’re waiting on the screenshots from design team ;) [01:26:44] oh? [01:26:52] well, I found a weird bug where the preview isn't rendering properly. [01:27:47] wait, [01:27:55] the top edit button only edits section 0? [01:33:51] legoktm: yeah [01:34:00] it didn't always do that did it? [01:37:05] ok, I'm probably just confused [01:37:44] legoktm: oh, yeah it’s section level editing & preview [01:38:03] ok [01:38:12] legoktm: too much scrolling on tiny screens otherwise [01:38:22] reasonable I guess [01:38:37] legoktm: can always tweak it later if needed :) [01:39:14] I don't understand why we're linking to GitHub instead of just a git.wm.o link in the Credits screen [02:08:09] (03CR) 10JGonera: [C: 032] Improving save workflow for mobile editing [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/145730 (owner: 10Kaldari) [02:08:46] (03Merged) 10jenkins-bot: Improving save workflow for mobile editing [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/145730 (owner: 10Kaldari) [02:09:19] (03CR) 10JGonera: [C: 032] Improvements for viewing mobile site on very small screens (<=280px) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/145443 (owner: 10Kaldari) [02:09:55] (03Merged) 10jenkins-bot: Improvements for viewing mobile site on very small screens (<=280px) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/145443 (owner: 10Kaldari) [03:07:45] (03PS11) 10BearND: Show references without scrolling [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/145225 [03:07:47] (03PS3) 10BearND: [Do not merge] Swipe between nearby references [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/146086 [03:56:03] (03CR) 10BearND: "Yuvi's comments 1, 3 are covered by making the reference window a Dialog." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/145225 (owner: 10BearND) [04:33:29] (03PS12) 10BearND: Show references without scrolling [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/145225 [04:33:31] (03PS4) 10BearND: [Do not merge] Swipe between nearby references [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/146086 [05:06:34] (03CR) 10BearND: [C: 04-1] "Minor nits." (032 comments) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/146081 (owner: 10Dbrant) [05:16:18] (03CR) 10BearND: [C: 04-1] "does not compile" (031 comment) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/146255 (owner: 10Yuvipanda) [05:17:08] (03PS7) 10Florianschmidtwelzow: Proposal: Redirect to direct match in search [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/139556 (https://bugzilla.wikimedia.org/66506) [05:24:50] (03PS1) 10BearND: Rename menu item Change font and theme -> Display settings [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/146384 [05:29:55] (03PS8) 10Florianschmidtwelzow: Redirect to direct match in search [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/139556 (https://bugzilla.wikimedia.org/66506) [05:31:50] (03CR) 10Florianschmidtwelzow: Redirect to direct match in search (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/139556 (https://bugzilla.wikimedia.org/66506) (owner: 10Florianschmidtwelzow) [05:31:56] (03CR) 10Florianschmidtwelzow: Redirect to direct match in search (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/139556 (https://bugzilla.wikimedia.org/66506) (owner: 10Florianschmidtwelzow) [07:06:05] (03PS9) 10Florianschmidtwelzow: Redirect directly to a match in search [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/139556 (https://bugzilla.wikimedia.org/66506) [07:42:16] 3MobileFrontend / 3stable: beta labs: Watchlist "Modified" view shows no results. - 10https://bugzilla.wikimedia.org/67987#c8 (10Chris McMahon) No, the test is already logged in. Just have the test click the "Pages" column explicitly after navigating to the Watchlist view. The element with text "Pages" is c... [07:45:19] 3MobileFrontend / 3stable: Blockquotes are misformatted in desktop mode - 10https://bugzilla.wikimedia.org/68001 (10Max Semenik) 3NEW p:3Unprio s:3normal a:3None Created attachment 15934 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15934&action=edit Screenshot in Chrome See the screenshot.... [07:49:01] 3MobileFrontend / 3stable: Blockquotes are misformatted in desktop mode - 10https://bugzilla.wikimedia.org/68001#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/CilLssWC [10:40:18] 3Commons App: Remove option to upload to testwiki - 10https://bugzilla.wikimedia.org/53386#c4 (10This, that and the other) 5NEW>3RESO/FIX We don't seem to have had any of these for a few months, so guessing it got fixed somewhere along the line. [11:33:32] 3Wikipedia App / 3iOS App: iOS App: "Allow Wikimedia to collect information about how you use the app..." is extremely vague - 10https://bugzilla.wikimedia.org/67405#c7 (10Kunal Mehta (Legoktm)) 5RESO/WON>3REOP (In reply to Kunal Mehta (Legoktm) from comment #6) > (In reply to Dan Garry from comment #5)... [11:43:16] 3MobileFrontend / 3General/Unknown: Search: Disambiguations pages show 'missing image' symbol - 10https://bugzilla.wikimedia.org/67471#c5 (10Max Semenik) I think there should be no placeholder image at all: it made sense for the design that assumed aggressive upload calls to actions, however now that the CTA... [11:52:31] 3MobileFrontend / 3General/Unknown: Search: Disambiguations pages show 'missing image' symbol - 10https://bugzilla.wikimedia.org/67471#c6 (10Ryan Kaldari) Time to get some feedback from design it sounds like. [11:54:05] 3MobileFrontend / 3General/Unknown: Special:Uploads throws Javascript error: Module not found: loggingSchemas/MobileWebClickTracking - 10https://bugzilla.wikimedia.org/68009 (10Ryan Kaldari) 3NEW p:3Unprio s:3normal a:3None Looks like the MobileWebClickTracking module isn't being loaded on that page.... [11:55:32] 3MobileFrontend / 3General/Unknown: Search: Disambiguations pages show 'missing image' symbol - 10https://bugzilla.wikimedia.org/67471#c7 (10Ryan Kaldari) Moiz says he's going to send us a new placeholder asset that will be much less prominent than the current one, probably some sort of grayed-out icon. Stay... [11:55:46] 3MobileFrontend / 3General/Unknown: Special:Uploads throws Javascript error: Module not found: loggingSchemas/MobileWebClickTracking - 10https://bugzilla.wikimedia.org/68009#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/Q775Kh5P [12:09:20] People really hate search [12:09:44] It's a simple title prefix search at the moment, right? [12:17:47] 3Wikipedia App / 3Android App: Common crash - 10https://bugzilla.wikimedia.org/67718#c6 (10Alex Monk) Okay, that seems to just leave these then, I think: > https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom;TicketID=7622139 > https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom;Ti... [12:23:01] 3Wikipedia App / 3Android App: Common NPE crashes involving not being able to start activities - 10https://bugzilla.wikimedia.org/67718 (10Alex Monk) [13:14:24] (03PS4) 10Dbrant: Update overflow menu text when Saved pages are saved/loaded. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/146081 [13:23:33] 3MobileFrontend / 3Feature requests: Go directly to an article if we have an exact search match - 10https://bugzilla.wikimedia.org/66506#c8 (10Maryana Pinchuk) Yes, please! This has been bothering me for awhile. [13:23:46] 3MobileFrontend / 3stable: Blockquotes are misformatted in desktop mode - 10https://bugzilla.wikimedia.org/68001#c2 (10Ryan Kaldari) Looks like this is caused by all the inline crap added by the Quotation template. The Quote template (which is much cleaner), doesn't cause any problems. [13:29:31] 3Wikipedia App / 3Android App: Font size changer - 10https://bugzilla.wikimedia.org/67102#c4 (10Alex Monk) p:5Unprio>3High I've been responding to multiple tickets about this every day [13:29:32] (03CR) 10Dbrant: "Hmm, was this requested by designers? I'm not sure I agree with it: from a discoverability standpoint, we need to be very explicit about " [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/146384 (owner: 10BearND) [13:54:47] * YuviPanda waves [14:10:51] (03PS1) 10Dbrant: Order saved pages alphabetically, instead of by date. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/146456 (https://bugzilla.wikimedia.org/67028) [14:17:38] dbrant: I'm not sure if we should do that, but it does make some senes... [14:17:45] dbrant: we should also add a search interface tho [14:19:21] YuviPanda: you mean in saved pages? [14:19:26] yeah [14:20:03] actually nevermind, alphabetical ordering does make sense [14:21:13] YuviPanda: right; there may be some i18n considerations... but I think most languages have a concept of sorting alphabetically? [14:21:21] dbrant: yup [14:33:11] (03CR) 10Zfilipin: [C: 04-1] QA: increase polling time to prevent flaky timeout (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/142605 (owner: 10Cmcmahon) [14:35:54] (03CR) 10Zfilipin: QA: increase polling time to prevent flaky timeout (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/142605 (owner: 10Cmcmahon) [14:47:01] (03CR) 10Yuvipanda: [C: 032] "Sweet. We should add search tho, similar to history." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/146456 (https://bugzilla.wikimedia.org/67028) (owner: 10Dbrant) [14:47:25] (03Merged) 10jenkins-bot: Order saved pages alphabetically, instead of by date. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/146456 (https://bugzilla.wikimedia.org/67028) (owner: 10Dbrant) [14:50:33] (03PS1) 10Dbrant: Add search to saved pages. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/146469 [14:52:32] dbrant: damn you are fast :) [14:53:59] YuviPanda: most of the code is copied from History; but I'll take the compliment ;) [14:54:58] :D [14:57:35] dbrant: thoughts on spending the next few days cleaning up the checkstyle errors in our code? [14:57:45] if we can bring it to 0, we can make it blocking for merges, and I think that's useful [14:59:33] (03Abandoned) 10Cmcmahon: QA: increase polling time to prevent flaky timeout [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/142605 (owner: 10Cmcmahon) [15:01:32] YuviPanda: yeah sure, we've got some time. How do we see all the checkstyle errors? [15:02:10] dbrant: in every patch, jenkins-bot comments with a link [15:02:24] dbrant: https://integration.wikimedia.org/ci/job/apps-android-wikipedia-maven-checkstyle/1414/checkstyleResult/ [15:05:12] dbrant: you can also run them locally [15:05:13] hey bearND [15:07:49] hey YuviPanda [15:08:08] bearND: me and dbrant were considering fixing all the checkstyle errors in the 'spare' days we have this sprint [15:10:56] YuviPanda: we can certainly reduce the number of failures there significantly [15:11:30] bearND: yeah, I want us to hit 0 before end of week. less than 200 errors, mostly with constants that [15:12:28] YuviPanda: bearND: how about splitting it into patches that take care of certain 'categories' of checkstyle fixes? [15:12:39] +1 [15:13:04] dbrant: sure [15:14:36] dbrant: I suppose we should replace the constants with just getString calls? [15:15:00] (03CR) 10BearND: "This was more a proposal, since I think the current name is too long. Image how long it would be in other languages, like German. The name" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/146384 (owner: 10BearND) [15:15:31] (03CR) 10Yuvipanda: "+1 to what bearND said" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/146384 (owner: 10BearND) [15:17:26] YuviPanda: yes, I suppose [15:17:53] (03CR) 10Yuvipanda: "In tamil, for example, the current one will translate to:" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/146384 (owner: 10BearND) [15:18:04] dbrant: i'm open to other short length suggestions of course [15:23:28] YuviPanda: have you had a chance to look at my latest patch set for https://gerrit.wikimedia.org/r/#/c/145225/? [15:27:35] bearND: no, looking now [15:28:05] bearND: YuviPanda: point taken; however, both the Kindle and Pocket apps have an icon for that action, which is much more descriptive than the caption. Without an icon, I'm afraid it's not descriptive enough. [15:28:31] we should probably let designers have the last word. [15:33:54] dbrant: sounds fine [15:42:46] YuviPanda: where is the checkstyle.xml coming from? [15:43:06] bearND: it's in the tree [15:43:08] source tree [15:43:30] YuviPanda: i know, but where did you get it from originally [15:44:33] bearND: ah, I think I picked up the android standard and modified it [15:44:44] either the android standard or the sun standard [15:46:16] YuviPanda: it would be great if we could change the IntelliJ code style settings to match most of that. (I know we can't do all.) Then it would be a matter of pressing cmd-option-L [15:46:47] bearND: yeah, I completely agree, but most of the stylistic stuff was fixed early on (I spent a few days). Now it's mostly our use of constants [15:47:53] YuviPanda: dbrant: for xml files you can say in IntelliJ to use the Android code style. It actually should have prompted you shortly after you imported your projects. [15:50:38] Does the Android app ever send unencrypted requests? [15:52:25] Krenair: nope [15:52:51] Krenair: ah, so if https on mobile is blocked, it falls back to https on desktop, and if *that* is blocked, it sends an *eventlogging* request via http recording this [15:53:17] Is that transparent to the user? [15:53:31] yup [15:53:33] hm :/ [15:53:40] Someone wants to force it to always use HTTPS [15:53:45] it's always https [15:53:52] unless there's a https error [15:53:59] and content is never over http [15:55:03] So "The Wikipedia app always sends encrypted requests. (Unless there is an HTTPS error, then it sends an unencrypted log entry.)" ? [15:55:51] Krenair: "No content is ever sent over HTTP" [15:55:51] yeah [15:56:13] "The Wikipedia app always sends encrypted requests. (Unless there is an HTTPS error, then it sends an unencrypted log entry. No content is sent over plain HTTP.)" it is then [15:56:58] Krenair: yeah [16:40:16] (03PS1) 10BearND: Checkstyle: remove unused imports [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/146486 [16:47:19] bearND: looks like you missed on in "TranslationTests.java:7" [16:47:22] *one [16:47:47] dbrant: ok, will update [16:49:32] 3Wikipedia App / 3iOS App: [iOS] back/forward button icons should be horizontally flipped in RTL locale - 10https://bugzilla.wikimedia.org/67632 (10Dan Garry) 5NEW>3RESO/FIX [16:49:45] (03PS2) 10BearND: Checkstyle: Category Imports [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/146486 [16:49:47] (03PS1) 10BearND: Checkstyle: Category Modifier [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/146490 [16:49:49] (03PS1) 10BearND: Checkstyle: Category Regexp [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/146491 [16:52:25] (03PS2) 10BearND: Checkstyle: Category Regexp [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/146491 [16:54:52] (03CR) 10Dbrant: [C: 032] Checkstyle: Category Imports [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/146486 (owner: 10BearND) [16:57:20] (03CR) 10Dbrant: [C: 032] Checkstyle: Category Modifier [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/146490 (owner: 10BearND) [16:59:47] (03CR) 10Dbrant: [C: 032] Checkstyle: Category Regexp [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/146491 (owner: 10BearND) [17:15:04] YuviPanda: dbrant: going to work on some more of the checkstyle warnings. While I do that I'm also changing the code style settings in IntelliJ. I'll share them with you when I'm done. [17:15:16] bearND: cool! [17:24:21] YuviPanda: lets start @ 10:40 [17:31:18] tfinc: ok [17:35:46] 3Wikipedia App / 3iOS App: iOS App: "Search English language wiki" should say Wikipedia - 10https://bugzilla.wikimedia.org/67648 (10Dan Garry) 5NEW>3RESO/FIX [17:37:16] (03PS2) 10Yuvipanda: Rename menu item Change font and theme -> Display settings [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/146384 (owner: 10BearND) [17:38:53] (03PS1) 10Cmcmahon: QA make sure watchlist shows correct tab [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/146500 [17:41:54] (03PS2) 10Cmcmahon: QA make sure watchlist shows correct tab [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/146500 [17:49:44] (03PS1) 10BearND: Checkstyle: Category Whitespace [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/146505 [17:52:17] (03PS1) 10BearND: Checkstyle: Category Blocks [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/146506 [18:10:15] YuviPanda: dbrant: how did you install the python module unicodecsv? I need it to run make-templates.py [18:10:27] bearND: 'sudo pip install unicodecsv' [18:10:38] YuviPanda: ty [18:16:12] kaldari: help a brother out https://gerrit.wikimedia.org/r/#/c/145032/ [18:27:01] 3Wikipedia App / 3iOS App: iOS app long press menu on links shows/copies wrong domain - 10https://bugzilla.wikimedia.org/67994#c1 (10Brion Vibber) 5NEW>3RESO/FIX Fixed this yesterday. [18:29:31] 3MobileFrontend / 3General/Unknown: tapping on the search input in mobile frontend takes you to previous page - 10https://bugzilla.wikimedia.org/67140#c9 (10Ryan Kaldari) I have confirmed with certainty that this bug is dependent on CentralNotice banners being active. [18:33:46] 3MobileFrontend / 3General/Unknown: tapping on the search input in mobile frontend takes you to previous page - 10https://bugzilla.wikimedia.org/67140#c10 (10Matt Walker) Any banner? Or just the WikiLovesEarth banner? [18:45:17] 3Wikipedia App / 3iOS App: iOS App: History is slow to load - 10https://bugzilla.wikimedia.org/67874 (10Brion Vibber) [18:45:19] 3Wikipedia App / 3iOS App: iOS app page edit history should load more revisions on demand (infinite scroll) - 10https://bugzilla.wikimedia.org/68055 (10Brion Vibber) 3NEW p:3Unprio s:3normal a:3None Currently we fetch only the last 50 revisions' worth of info. This has two problems: 1) On slow conne... [18:47:01] 3Wikipedia App / 3iOS App: iOS App: History is slow to load - 10https://bugzilla.wikimedia.org/67874#c1 (10Brion Vibber) I can confirm that 50 revisions takes a little longer to download than 5 revisions when I set the link conditioner to emulate a slow EDGE network. We can't eliminate the basic request late... [18:47:29] (03PS10) 10Kaldari: Redirect directly to a match in search [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/139556 (https://bugzilla.wikimedia.org/66506) (owner: 10Florianschmidtwelzow) [18:47:41] (03CR) 10Kaldari: [C: 032] Redirect directly to a match in search [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/139556 (https://bugzilla.wikimedia.org/66506) (owner: 10Florianschmidtwelzow) [18:48:16] 3Wikipedia App / 3iOS App: [iOS] ToC entries should be right-aligned in RTL content languages - 10https://bugzilla.wikimedia.org/67630#c1 (10Brion Vibber) 5NEW>3RESO/FIX This got fixed yesterday. [18:49:31] (03Merged) 10jenkins-bot: Redirect directly to a match in search [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/139556 (https://bugzilla.wikimedia.org/66506) (owner: 10Florianschmidtwelzow) [18:49:31] 3MobileFrontend / 3Feature requests: Go directly to an article if we have an exact search match - 10https://bugzilla.wikimedia.org/66506#c9 (10Ryan Kaldari) 5PATC>3RESO/FIX Fixed (for the most part). The functionality is currently dependent on the speed of the API response, however, so we may want to rev... [18:52:16] 3MobileFrontend / 3General/Unknown: tapping on the search input in mobile frontend takes you to previous page - 10https://bugzilla.wikimedia.org/67140#c11 (10Ryan Kaldari) Seems to be any banner. Need to investigate further though. [18:54:34] 3Wikipedia App / 3iOS App: iOS app 'qqq.lproj' dir causes validation warning - 10https://bugzilla.wikimedia.org/68056 (10Brion Vibber) 3NEW p:3Unprio s:3minor a:3None We have a qqq.lproj dir with the translation descriptions; iOS app submission validation warns that this is not a known language code,... [18:55:46] 3Wikipedia App / 3iOS App: [iOS] Table of Contents sidebar shows as empty space with locale set to Arabic - 10https://bugzilla.wikimedia.org/67610#c1 (10Brion Vibber) 5NEW>3RESO/FIX Monte got this the other day. [19:11:17] awjr: there is a small chance that i'll move our afternoon 1:1 [19:11:28] tfinc to when? [19:11:42] i'll let you know if i do [19:11:44] kk [19:11:51] no problem tfinc [19:14:31] 3Wikipedia App / 3iOS App: iOS App: "W" menu needs reorganization - 10https://bugzilla.wikimedia.org/65824#c13 (10Brion Vibber) Is this ready to close out with latest updates? [19:14:47] 3Wikipedia App / 3iOS App: iOS app page edit history should load more revisions on demand (infinite scroll) - 10https://bugzilla.wikimedia.org/68055 (10Brion Vibber) [19:14:47] 3Wikipedia App / 3iOS App: iOS App: History view stops after a certain point - 10https://bugzilla.wikimedia.org/65820 (10Brion Vibber) [19:30:37] YuviPanda: dbrant: after running the make-templates.py script do you manually move the files in the correct locations? [19:30:40] bearND: yup [19:30:49] YuviPanda: k [19:30:50] bearND: ideally the python script should be fixed to move it automatically tho [19:30:59] YuviPanda: agreed [19:32:05] bearND: shouldn't be too hard, convert-icons does it [19:38:02] (03CR) 10Yuvipanda: [C: 032] Checkstyle: Category Whitespace [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/146505 (owner: 10BearND) [19:39:11] (03Abandoned) 10Brion VIBBER: Use empty placeholder while loading, CTA placeholder only for known missing images [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/98579 (owner: 10Brion VIBBER) [19:39:51] (03Merged) 10jenkins-bot: Checkstyle: Category Whitespace [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/146505 (owner: 10BearND) [19:58:00] (03CR) 10Yuvipanda: [C: 032] Checkstyle: Category Blocks [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/146506 (owner: 10BearND) [19:58:49] bearND: dbrant almost down to a hundred checkstyle errors! [19:59:52] (03Merged) 10jenkins-bot: Checkstyle: Category Blocks [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/146506 (owner: 10BearND) [20:04:18] (03PS1) 10BearND: Checkstyle: Category Naming [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/146535 [20:13:54] bearND: reference display looks ok to me. I'm going to do a manual rebase + remove the unused webview onclick and merge [20:14:36] YuviPanda: which unused webview? [20:14:53] (03PS13) 10Yuvipanda: Show references without scrolling [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/145225 (owner: 10BearND) [20:14:54] oh the onclick [20:15:08] yeah [20:16:22] (03PS14) 10Yuvipanda: Show references in a pane at the bottom of the app [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/145225 (owner: 10BearND) [20:16:25] bearND: ^ just that + modified commit message. ok to merge? [20:17:21] YuviPanda: what was the onclick for? [20:17:43] bearND: I don't know, it was just an empty one that your patch added that I removed [20:17:44] :D [20:17:57] - webView.setOnClickListener(new View.OnClickListener() { [20:17:57] - @Override [20:17:57] - public void onClick(View view) { [20:17:59] - [20:18:01] - } [20:18:01] YuviPanda: i don't remember adding that [20:18:03] - }); [20:18:40] bearND: hmm, unsure. [20:18:54] bearND: accidental autocomplete madaness? [20:19:50] YuviPanda: probably. that's for catching that [20:19:55] bearND: :D [20:19:58] probably would have eaten clicks [20:20:16] (03CR) 10Yuvipanda: [C: 032] "w00t." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/145225 (owner: 10BearND) [20:20:37] (03Merged) 10jenkins-bot: Show references in a pane at the bottom of the app [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/145225 (owner: 10BearND) [20:20:40] bearND: hmm, didn't seem to eat anything in my testintg [20:20:46] YuviPanda: woot [20:21:27] bearND: :D do move the card appropriately, and talk to Dan about dropping the 'swipe to nearby references' feature? [20:21:49] YuviPanda: ok [20:23:29] Deskana: the reference display stuff just got merged. We won't have the swiping between nearby references though. It's too problematic with Android's ViewPager. [20:23:47] bearND: Cool! Looking forward to taking a look. [20:23:54] bearND: is jsonArrayToNativeArray used anywhere? [20:23:58] bearND: if not we should just get rid of it... [20:25:50] bearND: can you send Deskana a build as well? :D [20:26:41] Deskana: I'll send you a build soon (cc YuviPanda) [20:26:49] yay [20:27:20] bearND: JSONArrayToStringArray isn't used anywhere, can you remove it? [20:27:37] YuviPanda: ok [20:27:53] (03PS2) 10Yuvipanda: Add search to saved pages. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/146469 (owner: 10Dbrant) [20:32:12] brion: https://developer.apple.com/videos/wwdc/2014/?id=412 [20:34:25] (03CR) 10Yuvipanda: [C: 04-1] "All good, except that the star in 'no pages found' overlaps with the edit box with keyboard up when I type in a non existing page name (N4" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/146469 (owner: 10Dbrant) [20:34:25] brion: https://devforums.apple.com/message/1001836#1001836 [20:34:59] YuviPanda: hmm, I suppose I'll just hide the star when searching. [20:35:10] dbrant: yeah, seems a simple/safe solution [20:35:20] dbrant: I think it doesn't happen in history because it's smaller (the glasses) [20:38:32] 3MobileFrontend / 3General/Unknown: tapping on the search input in mobile frontend takes you to previous page - 10https://bugzilla.wikimedia.org/67140#c12 (10Ryan Kaldari) The bug does not happen for me after the banner is dismissed, however. [20:39:53] (03PS3) 10Dbrant: Add search to saved pages. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/146469 [20:40:03] dbrant: reviewing... [20:41:31] brion: https://developer.apple.com/support/appstore/ [20:42:15] (03CR) 10Yuvipanda: [C: 032] Add search to saved pages. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/146469 (owner: 10Dbrant) [20:42:18] dbrant: \o/ [20:42:27] yay [20:43:29] (03Merged) 10jenkins-bot: Add search to saved pages. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/146469 (owner: 10Dbrant) [20:43:31] 3MobileFrontend / 3General/Unknown: tapping on the search input in mobile frontend takes you to previous page - 10https://bugzilla.wikimedia.org/67140#c13 (10Ryan Kaldari) So far reproduced in Chrome for Android and Mobile Safari. Haven't been able to reproduce on any desktop browser. [20:43:58] (03PS5) 10Dbrant: Update overflow menu text when Saved pages are saved/loaded. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/146081 [20:46:27] Deskana: tfinc interesting pie chart: https://developer.apple.com/support/appstore/ [20:46:53] mhurd: the iOS7 chart ? [20:46:59] tfinc: ya [20:47:03] dbrant: bearND Deskana am going to try to sleep early today, anything you guys need from me before I go? [20:47:16] YuviPanda: nope [20:47:19] i love seeing that 2% grow smaller and smaller [20:47:30] tfinc: yes [20:47:32] mhurd: Yeah, interesting. I'm actually thinking of resetting my phone to iOS6. [20:47:37] mhurd: It actually totally froze today. [20:47:43] Was frozen for a good 10 minutes. [20:47:47] Deskana: is it ios 7 now? [20:47:48] YuviPanda: when do you plan to make a beta release? [20:47:51] mhurd: Yeah. [20:47:59] YuviPanda: I'm good. :) [20:48:08] Deskana: it wont let you downgrade for whatever reason iirc [20:48:21] mhurd: Even if I factory reset? [20:48:37] Deskana: that’s what i think i heard [20:48:53] Deskana: let me know if that’s not the case [20:48:58] bearND: I'm thinking tomorrow/ [20:48:59] ? [20:49:07] bearND: although, we'll be doing one on Monday as well... [20:49:09] YuviPanda: sounds good. was just wondering [20:49:11] but tomorrow sounds good too [20:49:14] as a one off [20:49:42] alright, I'm off then! [20:53:16] 3Wikipedia App / 3Generic: iOS: Long article titles cause button prose to be very long - 10https://bugzilla.wikimedia.org/64739#c1 (10Brion Vibber) 5NEW>3RESO/FIX This is now selected a different way, and the page title is not exposed in the button on the activity controller. [20:59:02] 3Wikipedia App / 3iOS App: iOS app: "Log out [username]" does not normalize username - 10https://bugzilla.wikimedia.org/63969#c3 (10Brion Vibber) 5NEW>3RESO/FIX This should be fixed in latest build as part of Ied5d52cf4 -- you'll have to log out and log in to see the now-normalized form though. [21:00:53] brion: Are you getting the Trello cards for those bugs, too? [21:01:00] Deskana: yeah [21:01:03] brion: <3 [21:01:05] :) [21:01:08] Thank you! [21:11:32] 3MobileFrontend / 3General/Unknown: tapping on the search input in mobile frontend takes you to previous page - 10https://bugzilla.wikimedia.org/67140#c14 (10Ryan Kaldari) Actually, it's any banner that is 40 pixels or taller. [21:12:35] (03Abandoned) 10Brion VIBBER: Split ApiResult into ApiRequest and ApiResult [apps/android/java-mwapi] - 10https://gerrit.wikimedia.org/r/93097 (owner: 10Brion VIBBER) [21:15:29] Deskana: just sent out email about tasks for the CI builds. [21:15:58] YuviPanda|zzzzzz: SLEEP [21:16:09] ;) [21:16:11] :D [21:16:13] yeah, that too [21:16:22] I'll go to sleep at 3AM, foshure [21:16:32] I said that yesterday as well and ended up at 8AM, BUT NOT THIS TIME. [21:17:45] Deskana: so yeah, I hope to get some of those tasks into next sprint, and some into the sprint after. Should also help iOS play catch up :D [21:20:53] vbamba: have you had a chance to think about the final design for the font size selector? [21:22:53] YuviPanda: going through some of the magic number warnings (https://integration.wikimedia.org/ci/job/apps-android-wikipedia-maven-checkstyle/1420/checkstyleResult/HIGH/category.2023747466/). I got a question about SavedPagesActivity.java:197: why is column index 4 used? As far as I can see the persistance helper's columns only goes till 3. [21:23:28] jgonera: https://www.mediawiki.org/wiki/Requests_for_comment/HTML_templating_library/Knockoff_-_Tassembly/Mobile_spike [21:23:46] YuviPanda|zzz: never mind [21:23:58] YuviPanda|zzz: got the wrong persistance helper [21:24:22] YuviPanda|zzz: Sure, sounds sensible to me. [21:55:08] dbrant|brb: Looking! will ping you in a few minutes. Having trouble with the APK on my device [21:56:55] @Deskana are you free now for 15 minutes? [21:57:05] Gotto discuss some cards and review the android build with you [21:57:21] vbamba: Unfortunately not. I should be back at 5pm though. [21:57:29] vbamba: Got some stuff with the Product team. [21:58:22] vbamba: Does that work? [21:58:28] vbamba: Or do you want to do first thing tomorrow? [22:01:11] hmm…Lets do first thing tomorrow I guess or 5pm on Hangout [22:01:36] @Deskana have you got the apk's on your phone? [22:02:05] latest from @bearND and @dbrant|brb [22:07:16] 3MobileFrontend / 3General/Unknown: tapping on the search input in mobile frontend takes you to previous page - 10https://bugzilla.wikimedia.org/67140#c15 (10Ryan Kaldari) OK, I think I know what's going on. When you click on the search input, the search overlay renders at the top of the page. When there isn... [22:08:30] @Deskana Also wanted to quickly chat about design review [22:09:07] jgonera: I don't have any of the code I used for testing, but the basic instructions are in the spike notes. [22:15:17] @Deskana I changed my mind - Lets talk at 5 [22:25:27] (03PS2) 10BearND: Checkstyle: Category Naming [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/146535 [22:25:29] (03PS1) 10BearND: Checkstyle: Category Coding (some) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/146629 [22:33:07] (03PS1) 10Yurik: Cleaned up X-Forward-Proto variance [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/146633 [22:53:46] 3MobileFrontend / 3General/Unknown: tapping on the search input in mobile frontend takes you to previous page - 10https://bugzilla.wikimedia.org/67140#c16 (10Ryan Kaldari) I asked Moiz about moving the banner under the header, but he says it makes more sense to leave it at the top. Other possible solutions:... [23:01:03] bearND: Ive installed the latest apk [23:01:16] but the date says 10th July instead of 15th [23:01:19] is this correct? [23:01:24] or am I looking at an old build [23:01:35] I installed it using the apk file from my email on the device [23:02:49] vbamba: that's fine. the version number was not bumped. [23:02:54] ooh ok [23:03:28] (03CR) 10Yuvipanda: [C: 032] Checkstyle: Category Naming [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/146535 (owner: 10BearND) [23:04:59] @dbrant|brb ok Im looking at all the things now [23:06:29] (03PS1) 10Brion VIBBER: Fix ToC scrolling to sections near end of page [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/146641 (https://bugzilla.wikimedia.org/67633) [23:07:57] (03Merged) 10jenkins-bot: Checkstyle: Category Naming [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/146535 (owner: 10BearND) [23:26:18] 3Wikipedia App / 3iOS App: [iOS] horizontal rule before page info section doesn't extend to device width in landscape or iPad - 10https://bugzilla.wikimedia.org/68080 (10Brion Vibber) 3NEW p:3Unprio s:3normal a:3None Image needs to be made wider and split into notch and remainder portions. [23:30:49] dbrant|brb: bearND Need to quickly chat with you guys [23:30:54] Can we hangout? [23:31:16] I scheduled a 4:30, but i can move it out by 15 minutes if you guys are in the middle of something [23:32:43] vbamba: just noticed it in my email. I usually respond faster in IRC [23:33:21] vbamba: i can join now and we can talk about reference pane [23:33:55] vbamba: night mode is something for dbrant|brb [23:34:12] vbamba: I can join [23:37:50] vbamba: we're ready now, if you like [23:43:46] mhurd: brion: got a second? [23:46:05] I'm mostly done w/ a first version of a map view but I can't get the Wikiglyph @"\ue032" to display [23:46:13] that's the map logo :) [23:46:41] if0xx: nice. on ios? [23:46:51] might need to make sure it’s an attributed string [23:46:53] any idea what to fix? I'm using WikiGlyphButtons [23:46:56] wioth the right font [23:46:58] yup [23:47:36] yeah I was wondering what to tweak in order to set the right font ... I've been stepping through WikiGlyphLabel to no avail [23:48:16] it just shows a rose /o\ [23:48:58] if0xx: can you poke it in github or gerrit patchset to look at? [23:49:29] ok, I'll just use the gear icon as a stand in & polish the patch [23:49:49] then maybe you guys could look at the issue and give me a hint [23:49:50] heh :) [23:50:01] yeah if we can figure it out we’ll try :D [23:50:12] cool :) [23:50:28] we’re playing with scroll views it’s …. fun :D [23:50:51] have tried to nest them? :D [23:51:13] scrolling & zooming at the same time [23:51:49] like in the UIWebView? [23:51:52] ya [23:52:05] sleak! [23:53:06] btw when I'm done I just push to the master branch on gerrit? [23:54:06] if0xx: i always use the git-review addition, i forget how to manually do it :D [23:54:40] ah ok, I'll look into that [23:55:01] i think ‘easy_install git-review’ usually works [23:55:05] or pip install git-review [23:55:11] i don’t understand these python package managers [23:55:21] :D [23:55:38] http://www.mediawiki.org/wiki/Gerrit/git-review [23:55:46] thanks!